{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61282","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61282/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61282/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61282/events","html_url":"https://github.com/kubernetes/kubernetes/pull/61282","id":305973395,"number":61282,"title":"Always Start pvc-protection-controller","user":{"login":"pospispa","id":7236993,"avatar_url":"https://avatars0.githubusercontent.com/u/7236993?v=4","gravatar_id":"","url":"https://api.github.com/users/pospispa","html_url":"https://github.com/pospispa","followers_url":"https://api.github.com/users/pospispa/followers","following_url":"https://api.github.com/users/pospispa/following{/other_user}","gists_url":"https://api.github.com/users/pospispa/gists{/gist_id}","starred_url":"https://api.github.com/users/pospispa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pospispa/subscriptions","organizations_url":"https://api.github.com/users/pospispa/orgs","repos_url":"https://api.github.com/users/pospispa/repos","events_url":"https://api.github.com/users/pospispa/events{/privacy}","received_events_url":"https://api.github.com/users/pospispa/received_events","type":"User","site_admin":false},"labels":[{"id":414883982,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":339502903,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cherrypick-approved","name":"cherrypick-approved","color":"fef2c0","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687565804,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":114528068,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/priority/critical-urgent","name":"priority/critical-urgent","color":"e11d21","default":false},{"id":349530249,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":253450978,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false},{"id":611767149,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/status/approved-for-milestone","name":"status/approved-for-milestone","color":"fef2c0","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":20,"created_at":"2018-03-16T15:31:58Z","updated_at":"2018-03-19T21:26:23Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/61282","html_url":"https://github.com/kubernetes/kubernetes/pull/61282","diff_url":"https://github.com/kubernetes/kubernetes/pull/61282.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/61282.patch"},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\nAfter K8s 1.9 is upgraded to K8s 1.10 finalizer [kubernetes.io/pvc-protection] is added to PVCs\r\nbecause `StorageObjectInUseProtection` feature is enabled by default in K8s 1.10.\r\nHowever, when K8s 1.10 is downgraded to K8s 1.9 the finalizers remain in the PVCs and as `pvc-protection-controller` is not started by default in K8s 1.9 finalizers are not removed automatically from deleted PVCs and that's why deleted PVC are not removed but remain in Terminating phase.\r\n\r\nThat's why `pvc-protection-controller` is always started because the `pvc-protection-controller` removes finalizers from PVCs automatically when a PVC is not in active use by a pod.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes #60764 \r\n\r\n**Special notes for your reviewer**:\r\nThis PR fixes problem with finalizers in PVCs only. It does not fix problem with finalizers in PVs.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nNONE\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/374384427","html_url":"https://github.com/kubernetes/kubernetes/pull/61282#issuecomment-374384427","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/61282","id":374384427,"user":{"login":"liggitt","id":980082,"avatar_url":"https://avatars0.githubusercontent.com/u/980082?v=4","gravatar_id":"","url":"https://api.github.com/users/liggitt","html_url":"https://github.com/liggitt","followers_url":"https://api.github.com/users/liggitt/followers","following_url":"https://api.github.com/users/liggitt/following{/other_user}","gists_url":"https://api.github.com/users/liggitt/gists{/gist_id}","starred_url":"https://api.github.com/users/liggitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liggitt/subscriptions","organizations_url":"https://api.github.com/users/liggitt/orgs","repos_url":"https://api.github.com/users/liggitt/repos","events_url":"https://api.github.com/users/liggitt/events{/privacy}","received_events_url":"https://api.github.com/users/liggitt/received_events","type":"User","site_admin":false},"created_at":"2018-03-19T21:26:23Z","updated_at":"2018-03-19T21:26:23Z","author_association":"MEMBER","body":"Also, the delete that sets the deletionTimestamp (but leaves the record in place until all finalizers are removed) would trigger an Update watch event"}}
{"actor":{"display_login":"liggitt"}}