{"action":"created","comment":{"url":"https://api.github.com/repos/aces/Loris-MRI/pulls/comments/236375933","pull_request_review_id":178438403,"id":236375933,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjM3NTkzMw==","diff_hunk":"@@ -91,34 +129,38 @@\n ####     Main program     ####\n ##############################\n \n-# Get tarchives list from the database and stores ArchiveLocation and md5sumArchive informations in a hash.\n-## ArchiveLocation will be the key of the hash\n-## md5sumArchive will be the value of the hash\n-my ($tarchivesList_db)  = &selectTarchives($dbh, $tarchiveLibraryDir);\n+# Get the list of DICOM archives the tarchive table of the database and stores","path":"tools/cleanupTarchives.pl","position":144,"original_position":144,"commit_id":"92f00c8ca66e97deddc902eeba97af089412fc58","original_commit_id":"92f00c8ca66e97deddc902eeba97af089412fc58","user":{"login":"nicolasbrossard","id":6844033,"node_id":"MDQ6VXNlcjY4NDQwMzM=","avatar_url":"https://avatars0.githubusercontent.com/u/6844033?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolasbrossard","html_url":"https://github.com/nicolasbrossard","followers_url":"https://api.github.com/users/nicolasbrossard/followers","following_url":"https://api.github.com/users/nicolasbrossard/following{/other_user}","gists_url":"https://api.github.com/users/nicolasbrossard/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolasbrossard/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolasbrossard/subscriptions","organizations_url":"https://api.github.com/users/nicolasbrossard/orgs","repos_url":"https://api.github.com/users/nicolasbrossard/repos","events_url":"https://api.github.com/users/nicolasbrossard/events{/privacy}","received_events_url":"https://api.github.com/users/nicolasbrossard/received_events","type":"User","site_admin":false},"body":"__Gets__ the list of DICOM archives __from__ the tarchive table of the database and...","created_at":"2018-11-26T18:34:50Z","updated_at":"2018-11-26T18:38:16Z","html_url":"https://github.com/aces/Loris-MRI/pull/344#discussion_r236375933","pull_request_url":"https://api.github.com/repos/aces/Loris-MRI/pulls/344","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/comments/236375933"},"html":{"href":"https://github.com/aces/Loris-MRI/pull/344#discussion_r236375933"},"pull_request":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/344"}}},"pull_request":{"url":"https://api.github.com/repos/aces/Loris-MRI/pulls/344","id":230993901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTkzOTAx","html_url":"https://github.com/aces/Loris-MRI/pull/344","diff_url":"https://github.com/aces/Loris-MRI/pull/344.diff","patch_url":"https://github.com/aces/Loris-MRI/pull/344.patch","issue_url":"https://api.github.com/repos/aces/Loris-MRI/issues/344","number":344,"state":"open","locked":false,"title":"Fixed errors in cleanupTarchives.pl tool","user":{"login":"cmadjar","id":1402456,"node_id":"MDQ6VXNlcjE0MDI0NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1402456?v=4","gravatar_id":"","url":"https://api.github.com/users/cmadjar","html_url":"https://github.com/cmadjar","followers_url":"https://api.github.com/users/cmadjar/followers","following_url":"https://api.github.com/users/cmadjar/following{/other_user}","gists_url":"https://api.github.com/users/cmadjar/gists{/gist_id}","starred_url":"https://api.github.com/users/cmadjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmadjar/subscriptions","organizations_url":"https://api.github.com/users/cmadjar/orgs","repos_url":"https://api.github.com/users/cmadjar/repos","events_url":"https://api.github.com/users/cmadjar/events{/privacy}","received_events_url":"https://api.github.com/users/cmadjar/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\nThis PR fixes and cleans up the tool `cleanupTarchives.pl` and document it with Perldoc at the same time.\r\n\r\nBefore the fixes, got the following errors:\r\n```\r\ndefined(@array) is deprecated at cleanupTarchives.pl line 54.\r\n    (Maybe you should just omit the defined()?)\r\nGlobal symbol \"$this\" requires explicit package name at cleanupTarchives.pl line 71.\r\nGlobal symbol \"$this\" requires explicit package name at cleanupTarchives.pl line 74.\r\nExecution of cleanupTarchives.pl aborted due to compilation errors.\r\n```\r\n\r\n### This fixes\r\n\r\n- [x] Redmine https://redmine.cbrain.mcgill.ca/issues/15041\r\n\r\n### How to test this\r\n\r\n- [ ] Read the documentation to make sure it all makes sense\r\n- [ ] Create with the `touch` command a few dummy files in `/data/project/data/tarchive` that matches the filename of one or several of the DICOM archives that you have in the year subfolders (to create false duplicate)\r\n- [ ] Run `cleanupTarchives.pl` and make sure the files you created with the `touch` command are no longer in `/data/project/data/tarchive`","created_at":"2018-11-14T21:50:47Z","updated_at":"2018-11-26T18:38:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"abd0a76cca0d3215b0ffa3a8f3e9a2bc8f8a283e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":196885450,"node_id":"MDU6TGFiZWwxOTY4ODU0NTA=","url":"https://api.github.com/repos/aces/Loris-MRI/labels/Add%20to%20release%20notes","name":"Add to release notes","color":"fef2c0","default":false},{"id":196885287,"node_id":"MDU6TGFiZWwxOTY4ODUyODc=","url":"https://api.github.com/repos/aces/Loris-MRI/labels/BugFix","name":"BugFix","color":"f7c6c7","default":false},{"id":782220207,"node_id":"MDU6TGFiZWw3ODIyMjAyMDc=","url":"https://api.github.com/repos/aces/Loris-MRI/labels/Perldoc","name":"Perldoc","color":"bfdadc","default":false},{"id":717895910,"node_id":"MDU6TGFiZWw3MTc4OTU5MTA=","url":"https://api.github.com/repos/aces/Loris-MRI/labels/[branch]%20minor","name":"[branch] minor","color":"996633","default":false}],"milestone":{"url":"https://api.github.com/repos/aces/Loris-MRI/milestones/12","html_url":"https://github.com/aces/Loris-MRI/milestone/12","labels_url":"https://api.github.com/repos/aces/Loris-MRI/milestones/12/labels","id":3835149,"node_id":"MDk6TWlsZXN0b25lMzgzNTE0OQ==","number":12,"title":"20.2","description":null,"creator":{"login":"cmadjar","id":1402456,"node_id":"MDQ6VXNlcjE0MDI0NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1402456?v=4","gravatar_id":"","url":"https://api.github.com/users/cmadjar","html_url":"https://github.com/cmadjar","followers_url":"https://api.github.com/users/cmadjar/followers","following_url":"https://api.github.com/users/cmadjar/following{/other_user}","gists_url":"https://api.github.com/users/cmadjar/gists{/gist_id}","starred_url":"https://api.github.com/users/cmadjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmadjar/subscriptions","organizations_url":"https://api.github.com/users/cmadjar/orgs","repos_url":"https://api.github.com/users/cmadjar/repos","events_url":"https://api.github.com/users/cmadjar/events{/privacy}","received_events_url":"https://api.github.com/users/cmadjar/received_events","type":"User","site_admin":false},"open_issues":4,"closed_issues":3,"state":"open","created_at":"2018-11-20T17:30:18Z","updated_at":"2018-11-21T15:55:34Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aces/Loris-MRI/pulls/344/commits","review_comments_url":"https://api.github.com/repos/aces/Loris-MRI/pulls/344/comments","review_comment_url":"https://api.github.com/repos/aces/Loris-MRI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aces/Loris-MRI/issues/344/comments","statuses_url":"https://api.github.com/repos/aces/Loris-MRI/statuses/92f00c8ca66e97deddc902eeba97af089412fc58","head":{"label":"cmadjar:fix_cleanupTarchives_tool_script","ref":"fix_cleanupTarchives_tool_script","sha":"92f00c8ca66e97deddc902eeba97af089412fc58","user":{"login":"cmadjar","id":1402456,"node_id":"MDQ6VXNlcjE0MDI0NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1402456?v=4","gravatar_id":"","url":"https://api.github.com/users/cmadjar","html_url":"https://github.com/cmadjar","followers_url":"https://api.github.com/users/cmadjar/followers","following_url":"https://api.github.com/users/cmadjar/following{/other_user}","gists_url":"https://api.github.com/users/cmadjar/gists{/gist_id}","starred_url":"https://api.github.com/users/cmadjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmadjar/subscriptions","organizations_url":"https://api.github.com/users/cmadjar/orgs","repos_url":"https://api.github.com/users/cmadjar/repos","events_url":"https://api.github.com/users/cmadjar/events{/privacy}","received_events_url":"https://api.github.com/users/cmadjar/received_events","type":"User","site_admin":false},"repo":{"id":26882688,"node_id":"MDEwOlJlcG9zaXRvcnkyNjg4MjY4OA==","name":"Loris-MRI","full_name":"cmadjar/Loris-MRI","private":false,"owner":{"login":"cmadjar","id":1402456,"node_id":"MDQ6VXNlcjE0MDI0NTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1402456?v=4","gravatar_id":"","url":"https://api.github.com/users/cmadjar","html_url":"https://github.com/cmadjar","followers_url":"https://api.github.com/users/cmadjar/followers","following_url":"https://api.github.com/users/cmadjar/following{/other_user}","gists_url":"https://api.github.com/users/cmadjar/gists{/gist_id}","starred_url":"https://api.github.com/users/cmadjar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmadjar/subscriptions","organizations_url":"https://api.github.com/users/cmadjar/orgs","repos_url":"https://api.github.com/users/cmadjar/repos","events_url":"https://api.github.com/users/cmadjar/events{/privacy}","received_events_url":"https://api.github.com/users/cmadjar/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cmadjar/Loris-MRI","description":"The set of scripts that preprocess and insert MRI data into the database.","fork":true,"url":"https://api.github.com/repos/cmadjar/Loris-MRI","forks_url":"https://api.github.com/repos/cmadjar/Loris-MRI/forks","keys_url":"https://api.github.com/repos/cmadjar/Loris-MRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmadjar/Loris-MRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmadjar/Loris-MRI/teams","hooks_url":"https://api.github.com/repos/cmadjar/Loris-MRI/hooks","issue_events_url":"https://api.github.com/repos/cmadjar/Loris-MRI/issues/events{/number}","events_url":"https://api.github.com/repos/cmadjar/Loris-MRI/events","assignees_url":"https://api.github.com/repos/cmadjar/Loris-MRI/assignees{/user}","branches_url":"https://api.github.com/repos/cmadjar/Loris-MRI/branches{/branch}","tags_url":"https://api.github.com/repos/cmadjar/Loris-MRI/tags","blobs_url":"https://api.github.com/repos/cmadjar/Loris-MRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmadjar/Loris-MRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmadjar/Loris-MRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmadjar/Loris-MRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmadjar/Loris-MRI/statuses/{sha}","languages_url":"https://api.github.com/repos/cmadjar/Loris-MRI/languages","stargazers_url":"https://api.github.com/repos/cmadjar/Loris-MRI/stargazers","contributors_url":"https://api.github.com/repos/cmadjar/Loris-MRI/contributors","subscribers_url":"https://api.github.com/repos/cmadjar/Loris-MRI/subscribers","subscription_url":"https://api.github.com/repos/cmadjar/Loris-MRI/subscription","commits_url":"https://api.github.com/repos/cmadjar/Loris-MRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmadjar/Loris-MRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmadjar/Loris-MRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmadjar/Loris-MRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmadjar/Loris-MRI/contents/{+path}","compare_url":"https://api.github.com/repos/cmadjar/Loris-MRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmadjar/Loris-MRI/merges","archive_url":"https://api.github.com/repos/cmadjar/Loris-MRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmadjar/Loris-MRI/downloads","issues_url":"https://api.github.com/repos/cmadjar/Loris-MRI/issues{/number}","pulls_url":"https://api.github.com/repos/cmadjar/Loris-MRI/pulls{/number}","milestones_url":"https://api.github.com/repos/cmadjar/Loris-MRI/milestones{/number}","notifications_url":"https://api.github.com/repos/cmadjar/Loris-MRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmadjar/Loris-MRI/labels{/name}","releases_url":"https://api.github.com/repos/cmadjar/Loris-MRI/releases{/id}","deployments_url":"https://api.github.com/repos/cmadjar/Loris-MRI/deployments","created_at":"2014-11-19T21:33:47Z","updated_at":"2018-08-23T15:15:12Z","pushed_at":"2018-11-23T20:55:16Z","git_url":"git://github.com/cmadjar/Loris-MRI.git","ssh_url":"git@github.com:cmadjar/Loris-MRI.git","clone_url":"https://github.com/cmadjar/Loris-MRI.git","svn_url":"https://github.com/cmadjar/Loris-MRI","homepage":"","size":4624,"stargazers_count":1,"watchers_count":1,"language":"Perl","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"aces:minor","ref":"minor","sha":"a380e5df9cdce8931555c3d454235ab300a1032e","user":{"login":"aces","id":472868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"repo":{"id":2728966,"node_id":"MDEwOlJlcG9zaXRvcnkyNzI4OTY2","name":"Loris-MRI","full_name":"aces/Loris-MRI","private":false,"owner":{"login":"aces","id":472868,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3Mjg2OA==","avatar_url":"https://avatars2.githubusercontent.com/u/472868?v=4","gravatar_id":"","url":"https://api.github.com/users/aces","html_url":"https://github.com/aces","followers_url":"https://api.github.com/users/aces/followers","following_url":"https://api.github.com/users/aces/following{/other_user}","gists_url":"https://api.github.com/users/aces/gists{/gist_id}","starred_url":"https://api.github.com/users/aces/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aces/subscriptions","organizations_url":"https://api.github.com/users/aces/orgs","repos_url":"https://api.github.com/users/aces/repos","events_url":"https://api.github.com/users/aces/events{/privacy}","received_events_url":"https://api.github.com/users/aces/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/aces/Loris-MRI","description":"The set of scripts that preprocess and insert MRI data into the database.","fork":false,"url":"https://api.github.com/repos/aces/Loris-MRI","forks_url":"https://api.github.com/repos/aces/Loris-MRI/forks","keys_url":"https://api.github.com/repos/aces/Loris-MRI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aces/Loris-MRI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aces/Loris-MRI/teams","hooks_url":"https://api.github.com/repos/aces/Loris-MRI/hooks","issue_events_url":"https://api.github.com/repos/aces/Loris-MRI/issues/events{/number}","events_url":"https://api.github.com/repos/aces/Loris-MRI/events","assignees_url":"https://api.github.com/repos/aces/Loris-MRI/assignees{/user}","branches_url":"https://api.github.com/repos/aces/Loris-MRI/branches{/branch}","tags_url":"https://api.github.com/repos/aces/Loris-MRI/tags","blobs_url":"https://api.github.com/repos/aces/Loris-MRI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aces/Loris-MRI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aces/Loris-MRI/git/refs{/sha}","trees_url":"https://api.github.com/repos/aces/Loris-MRI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aces/Loris-MRI/statuses/{sha}","languages_url":"https://api.github.com/repos/aces/Loris-MRI/languages","stargazers_url":"https://api.github.com/repos/aces/Loris-MRI/stargazers","contributors_url":"https://api.github.com/repos/aces/Loris-MRI/contributors","subscribers_url":"https://api.github.com/repos/aces/Loris-MRI/subscribers","subscription_url":"https://api.github.com/repos/aces/Loris-MRI/subscription","commits_url":"https://api.github.com/repos/aces/Loris-MRI/commits{/sha}","git_commits_url":"https://api.github.com/repos/aces/Loris-MRI/git/commits{/sha}","comments_url":"https://api.github.com/repos/aces/Loris-MRI/comments{/number}","issue_comment_url":"https://api.github.com/repos/aces/Loris-MRI/issues/comments{/number}","contents_url":"https://api.github.com/repos/aces/Loris-MRI/contents/{+path}","compare_url":"https://api.github.com/repos/aces/Loris-MRI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aces/Loris-MRI/merges","archive_url":"https://api.github.com/repos/aces/Loris-MRI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aces/Loris-MRI/downloads","issues_url":"https://api.github.com/repos/aces/Loris-MRI/issues{/number}","pulls_url":"https://api.github.com/repos/aces/Loris-MRI/pulls{/number}","milestones_url":"https://api.github.com/repos/aces/Loris-MRI/milestones{/number}","notifications_url":"https://api.github.com/repos/aces/Loris-MRI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aces/Loris-MRI/labels{/name}","releases_url":"https://api.github.com/repos/aces/Loris-MRI/releases{/id}","deployments_url":"https://api.github.com/repos/aces/Loris-MRI/deployments","created_at":"2011-11-07T20:19:37Z","updated_at":"2018-11-20T17:31:48Z","pushed_at":"2018-11-23T20:55:17Z","git_url":"git://github.com/aces/Loris-MRI.git","ssh_url":"git@github.com:aces/Loris-MRI.git","clone_url":"https://github.com/aces/Loris-MRI.git","svn_url":"https://github.com/aces/Loris-MRI","homepage":"","size":3808,"stargazers_count":7,"watchers_count":7,"language":"Perl","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":31,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":31,"open_issues":12,"watchers":7,"default_branch":"minor"}},"_links":{"self":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/344"},"html":{"href":"https://github.com/aces/Loris-MRI/pull/344"},"issue":{"href":"https://api.github.com/repos/aces/Loris-MRI/issues/344"},"comments":{"href":"https://api.github.com/repos/aces/Loris-MRI/issues/344/comments"},"review_comments":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/344/comments"},"review_comment":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aces/Loris-MRI/pulls/344/commits"},"statuses":{"href":"https://api.github.com/repos/aces/Loris-MRI/statuses/92f00c8ca66e97deddc902eeba97af089412fc58"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"nicolasbrossard"}}