{"action":"created","issue":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/31633","repository_url":"https://api.github.com/repos/elastic/elasticsearch","labels_url":"https://api.github.com/repos/elastic/elasticsearch/issues/31633/labels{/name}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/31633/comments","events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/31633/events","html_url":"https://github.com/elastic/elasticsearch/pull/31633","id":336387918,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3ODUzOTc0","number":31633,"title":"DOC: Add examples to the SQL docs","user":{"login":"costin","id":76245,"node_id":"MDQ6VXNlcjc2MjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/76245?v=4","gravatar_id":"","url":"https://api.github.com/users/costin","html_url":"https://github.com/costin","followers_url":"https://api.github.com/users/costin/followers","following_url":"https://api.github.com/users/costin/following{/other_user}","gists_url":"https://api.github.com/users/costin/gists{/gist_id}","starred_url":"https://api.github.com/users/costin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costin/subscriptions","organizations_url":"https://api.github.com/users/costin/orgs","repos_url":"https://api.github.com/users/costin/repos","events_url":"https://api.github.com/users/costin/events{/privacy}","received_events_url":"https://api.github.com/users/costin/received_events","type":"User","site_admin":false},"labels":[{"id":912794284,"node_id":"MDU6TGFiZWw5MTI3OTQyODQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Search/SQL","name":":Search/SQL","color":"0e8a16","default":false},{"id":23715,"node_id":"MDU6TGFiZWwyMzcxNQ==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Edocs","name":">docs","color":"db755e","default":false},{"id":912911731,"node_id":"MDU6TGFiZWw5MTI5MTE3MzE=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v6.4.0","name":"v6.4.0","color":"DDDDDD","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"state":"open","locked":false,"assignee":{"login":"costin","id":76245,"node_id":"MDQ6VXNlcjc2MjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/76245?v=4","gravatar_id":"","url":"https://api.github.com/users/costin","html_url":"https://github.com/costin","followers_url":"https://api.github.com/users/costin/followers","following_url":"https://api.github.com/users/costin/following{/other_user}","gists_url":"https://api.github.com/users/costin/gists{/gist_id}","starred_url":"https://api.github.com/users/costin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costin/subscriptions","organizations_url":"https://api.github.com/users/costin/orgs","repos_url":"https://api.github.com/users/costin/repos","events_url":"https://api.github.com/users/costin/events{/privacy}","received_events_url":"https://api.github.com/users/costin/received_events","type":"User","site_admin":false},"assignees":[{"login":"costin","id":76245,"node_id":"MDQ6VXNlcjc2MjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/76245?v=4","gravatar_id":"","url":"https://api.github.com/users/costin","html_url":"https://github.com/costin","followers_url":"https://api.github.com/users/costin/followers","following_url":"https://api.github.com/users/costin/following{/other_user}","gists_url":"https://api.github.com/users/costin/gists{/gist_id}","starred_url":"https://api.github.com/users/costin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costin/subscriptions","organizations_url":"https://api.github.com/users/costin/orgs","repos_url":"https://api.github.com/users/costin/repos","events_url":"https://api.github.com/users/costin/events{/privacy}","received_events_url":"https://api.github.com/users/costin/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-06-27T21:08:01Z","updated_at":"2018-06-27T22:10:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/31633","html_url":"https://github.com/elastic/elasticsearch/pull/31633","diff_url":"https://github.com/elastic/elasticsearch/pull/31633.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/31633.patch"},"body":"Wip on the documentation examples.\r\nPut the tests into a separate suite to help with clarity and isolation.\r\nThe existing tests have different CVS tests (that include data type among other things) which are not relevant for the docs.\r\nAlso moved the library dataset into the test suite.\r\nAdditionally, used the same output from CLI in the JDBC test suite (a different PR should eliminate the JdbcTestUtils output entirely and only use the `CliFormatter`).\r\n\r\nOnce the infrastructure is in place, adding the examples goes quite smooth. I also like the SQL with table approach since it's easier to read (and applicable for all consumers - REST, JDBC, CLI)."},"comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments/400845469","html_url":"https://github.com/elastic/elasticsearch/pull/31633#issuecomment-400845469","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/31633","id":400845469,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDg0NTQ2OQ==","user":{"login":"costin","id":76245,"node_id":"MDQ6VXNlcjc2MjQ1","avatar_url":"https://avatars3.githubusercontent.com/u/76245?v=4","gravatar_id":"","url":"https://api.github.com/users/costin","html_url":"https://github.com/costin","followers_url":"https://api.github.com/users/costin/followers","following_url":"https://api.github.com/users/costin/following{/other_user}","gists_url":"https://api.github.com/users/costin/gists{/gist_id}","starred_url":"https://api.github.com/users/costin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costin/subscriptions","organizations_url":"https://api.github.com/users/costin/orgs","repos_url":"https://api.github.com/users/costin/repos","events_url":"https://api.github.com/users/costin/events{/privacy}","received_events_url":"https://api.github.com/users/costin/received_events","type":"User","site_admin":false},"created_at":"2018-06-27T22:10:50Z","updated_at":"2018-06-27T22:10:50Z","author_association":"MEMBER","body":"I ended up with a different test since for tests we have a number of indices that show up in `SHOW TABLES` or any type of `FROM emp*` query.\r\nWe have `test_emp`, `test_emp_copy` plus an alias to them.\r\nIf `library` and `emp` are placed in the same suite, the tests for `SHOW TABLES` need to be changed both in the docs and in the tests.\r\nSo in the interest of time, having this namespace between the test suite (that might get geo in the future, maybe the flight data) and the docs seems reasonable and not too much effort.\r\nIt can be definitely be revisited in the future but as of right now, I could come up with a single test suite and isolation between the datasets so they don't leak into each others commands."}}
{"actor":{"display_login":"costin"}}