{"action":"created","issue":{"url":"https://api.github.com/repos/SymbolixAU/mapdeck/issues/78","repository_url":"https://api.github.com/repos/SymbolixAU/mapdeck","labels_url":"https://api.github.com/repos/SymbolixAU/mapdeck/issues/78/labels{/name}","comments_url":"https://api.github.com/repos/SymbolixAU/mapdeck/issues/78/comments","events_url":"https://api.github.com/repos/SymbolixAU/mapdeck/issues/78/events","html_url":"https://github.com/SymbolixAU/mapdeck/issues/78","id":381612529,"node_id":"MDU6SXNzdWUzODE2MTI1Mjk=","number":78,"title":"remove names from location argument","user":{"login":"mpadge","id":6697851,"node_id":"MDQ6VXNlcjY2OTc4NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/6697851?v=4","gravatar_id":"","url":"https://api.github.com/users/mpadge","html_url":"https://github.com/mpadge","followers_url":"https://api.github.com/users/mpadge/followers","following_url":"https://api.github.com/users/mpadge/following{/other_user}","gists_url":"https://api.github.com/users/mpadge/gists{/gist_id}","starred_url":"https://api.github.com/users/mpadge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mpadge/subscriptions","organizations_url":"https://api.github.com/users/mpadge/orgs","repos_url":"https://api.github.com/users/mpadge/repos","events_url":"https://api.github.com/users/mpadge/events{/privacy}","received_events_url":"https://api.github.com/users/mpadge/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-16T14:04:31Z","updated_at":"2018-11-16T19:43:14Z","closed_at":null,"author_association":"NONE","body":"Current status:\r\n```\r\n> loc <- c(144.86, -37.86)\r\n> names(loc) <- c(\"lon\", \"lat\")\r\n> mapview(token = ...,\r\n>                   location = loc)\r\n# Input to asJSON(keep_vec_names=TRUE) is a named vector. In a future version of jsonlite, this \r\n# option will not be supported, and named vectors will be translated into arrays instead of\r\n# objects. If you want JSON object output, please use a named list instead. See ?toJSON. \r\n```\r\nand the worst thing ... it still opens in the browser but just serves a blank page. Easy to fix by ensuring that the `location` parameter is converted to a non-named vector - no matter what form it is passed in - before passing through.\r\n\r\nEven better would be to allow any kind of object to be passed (`sf`, `sp`, `tibble`, whatevs), and you could extract mean coordinates to pass through. That would also provide some useful skeleton stuff for what you'll ultimately need to do to allow full `sf`-plotability. Want me to PR?"},"comment":{"url":"https://api.github.com/repos/SymbolixAU/mapdeck/issues/comments/439505296","html_url":"https://github.com/SymbolixAU/mapdeck/issues/78#issuecomment-439505296","issue_url":"https://api.github.com/repos/SymbolixAU/mapdeck/issues/78","id":439505296,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTUwNTI5Ng==","user":{"login":"SymbolixAU","id":18344164,"node_id":"MDQ6VXNlcjE4MzQ0MTY0","avatar_url":"https://avatars2.githubusercontent.com/u/18344164?v=4","gravatar_id":"","url":"https://api.github.com/users/SymbolixAU","html_url":"https://github.com/SymbolixAU","followers_url":"https://api.github.com/users/SymbolixAU/followers","following_url":"https://api.github.com/users/SymbolixAU/following{/other_user}","gists_url":"https://api.github.com/users/SymbolixAU/gists{/gist_id}","starred_url":"https://api.github.com/users/SymbolixAU/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SymbolixAU/subscriptions","organizations_url":"https://api.github.com/users/SymbolixAU/orgs","repos_url":"https://api.github.com/users/SymbolixAU/repos","events_url":"https://api.github.com/users/SymbolixAU/events{/privacy}","received_events_url":"https://api.github.com/users/SymbolixAU/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T19:43:14Z","updated_at":"2018-11-16T19:43:14Z","author_association":"OWNER","body":"Yes please, a PR would be helpful"}}
{"actor":{"display_login":"SymbolixAU"}}