{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments/185871061","pull_request_review_id":117348329,"id":185871061,"diff_hunk":"@@ -586,13 +611,15 @@ extension RouteController: CLLocationManagerDelegate {\n                 RouteControllerNotificationUserInfoKey.locationKey: self.location!, //guaranteed value\n                 RouteControllerNotificationUserInfoKey.rawLocationKey: location //raw\n                 ])\n+            // Check for a tunnel intersection whenever the current route step progresses.\n+            checkForTunnelIntersection(at: location, for: manager)\n         }\n \n         updateDistanceToIntersection(from: location)\n         updateRouteStepProgress(for: location)\n         updateRouteLegProgress(for: location)\n \n-        guard userIsOnRoute(location) || !(delegate?.routeController?(self, shouldRerouteFrom: location) ?? true) else {\n+        guard tunnelAnimationEnabled || userIsOnRoute(location) || !(delegate?.routeController?(self, shouldRerouteFrom: location) ?? true) else {","path":"MapboxCoreNavigation/RouteController.swift","position":86,"original_position":86,"commit_id":"f00ae83b54d47a7d4de7fbf3dd43ad1758a56d6b","original_commit_id":"f00ae83b54d47a7d4de7fbf3dd43ad1758a56d6b","user":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"body":"I'm slightly concerned with this. If the tunnel animation taking place, and the user is obviously outside of the tunnel, someplace else, we won't reroute them.","created_at":"2018-05-03T17:01:47Z","updated_at":"2018-05-03T17:06:38Z","html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1218#discussion_r185871061","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1218","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments/185871061"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-ios/pull/1218#discussion_r185871061"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1218"}}},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1218","id":174496311,"html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1218","diff_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1218.diff","patch_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1218.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1218","number":1218,"state":"open","locked":false,"title":"Enable simulated navigation for tunnel segments.","user":{"login":"vincethecoder","id":2340650,"avatar_url":"https://avatars0.githubusercontent.com/u/2340650?v=4","gravatar_id":"","url":"https://api.github.com/users/vincethecoder","html_url":"https://github.com/vincethecoder","followers_url":"https://api.github.com/users/vincethecoder/followers","following_url":"https://api.github.com/users/vincethecoder/following{/other_user}","gists_url":"https://api.github.com/users/vincethecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/vincethecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincethecoder/subscriptions","organizations_url":"https://api.github.com/users/vincethecoder/orgs","repos_url":"https://api.github.com/users/vincethecoder/repos","events_url":"https://api.github.com/users/vincethecoder/events{/privacy}","received_events_url":"https://api.github.com/users/vincethecoder/received_events","type":"User","site_admin":false},"body":"This will enable the simulated navigation whenever the commuter enters a tunnel until they exit the tunnel. \r\n\r\nAddresses #835\r\n\r\nTODO: \r\n- [x] Accompanied Issue Ticket\r\n- [x] Tests\r\n- [x] Documentation\r\n- [x] Class dedicated to Simulated Tunnel Navigation \r\n\r\n","created_at":"2018-03-12T21:13:04Z","updated_at":"2018-05-03T17:06:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1c75520dd8a7bf1a4539c220e1ef1cde41ffb973","assignee":{"login":"vincethecoder","id":2340650,"avatar_url":"https://avatars0.githubusercontent.com/u/2340650?v=4","gravatar_id":"","url":"https://api.github.com/users/vincethecoder","html_url":"https://github.com/vincethecoder","followers_url":"https://api.github.com/users/vincethecoder/followers","following_url":"https://api.github.com/users/vincethecoder/following{/other_user}","gists_url":"https://api.github.com/users/vincethecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/vincethecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincethecoder/subscriptions","organizations_url":"https://api.github.com/users/vincethecoder/orgs","repos_url":"https://api.github.com/users/vincethecoder/repos","events_url":"https://api.github.com/users/vincethecoder/events{/privacy}","received_events_url":"https://api.github.com/users/vincethecoder/received_events","type":"User","site_admin":false},"assignees":[{"login":"vincethecoder","id":2340650,"avatar_url":"https://avatars0.githubusercontent.com/u/2340650?v=4","gravatar_id":"","url":"https://api.github.com/users/vincethecoder","html_url":"https://github.com/vincethecoder","followers_url":"https://api.github.com/users/vincethecoder/followers","following_url":"https://api.github.com/users/vincethecoder/following{/other_user}","gists_url":"https://api.github.com/users/vincethecoder/gists{/gist_id}","starred_url":"https://api.github.com/users/vincethecoder/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vincethecoder/subscriptions","organizations_url":"https://api.github.com/users/vincethecoder/orgs","repos_url":"https://api.github.com/users/vincethecoder/repos","events_url":"https://api.github.com/users/vincethecoder/events{/privacy}","received_events_url":"https://api.github.com/users/vincethecoder/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":650004041,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels/-%20feature","name":"- feature","color":"0052cc","default":false},{"id":650004013,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels/%E2%9C%93%20ready%20for%20review","name":"✓ ready for review","color":"0e8a16","default":false}],"milestone":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones/17","html_url":"https://github.com/mapbox/mapbox-navigation-ios/milestone/17","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones/17/labels","id":3210394,"number":17,"title":"v0.17.0","description":"","creator":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":18,"state":"open","created_at":"2018-03-22T20:01:11Z","updated_at":"2018-05-03T15:54:30Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1218/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1218/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1218/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/f00ae83b54d47a7d4de7fbf3dd43ad1758a56d6b","head":{"label":"mapbox:tunnel/simulate_navigation","ref":"tunnel/simulate_navigation","sha":"f00ae83b54d47a7d4de7fbf3dd43ad1758a56d6b","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":73870932,"name":"mapbox-navigation-ios","full_name":"mapbox/mapbox-navigation-ios","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-ios","description":"Turn-by-turn navigation logic and UI in Swift or Objective-C on iOS","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/deployments","created_at":"2016-11-16T01:23:44Z","updated_at":"2018-05-03T16:08:51Z","pushed_at":"2018-05-03T16:45:10Z","git_url":"git://github.com/mapbox/mapbox-navigation-ios.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-ios.git","clone_url":"https://github.com/mapbox/mapbox-navigation-ios.git","svn_url":"https://github.com/mapbox/mapbox-navigation-ios","homepage":"https://www.mapbox.com/navigation-sdk/","size":51989,"stargazers_count":359,"watchers_count":359,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":72,"open_issues":97,"watchers":359,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"f45a9390138617d1526177dae2bf873e8d92b468","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":73870932,"name":"mapbox-navigation-ios","full_name":"mapbox/mapbox-navigation-ios","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-ios","description":"Turn-by-turn navigation logic and UI in Swift or Objective-C on iOS","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/deployments","created_at":"2016-11-16T01:23:44Z","updated_at":"2018-05-03T16:08:51Z","pushed_at":"2018-05-03T16:45:10Z","git_url":"git://github.com/mapbox/mapbox-navigation-ios.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-ios.git","clone_url":"https://github.com/mapbox/mapbox-navigation-ios.git","svn_url":"https://github.com/mapbox/mapbox-navigation-ios","homepage":"https://www.mapbox.com/navigation-sdk/","size":51989,"stargazers_count":359,"watchers_count":359,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":72,"mirror_url":null,"archived":false,"open_issues_count":97,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":72,"open_issues":97,"watchers":359,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1218"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-ios/pull/1218"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1218"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1218/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1218/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1218/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/f00ae83b54d47a7d4de7fbf3dd43ad1758a56d6b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bsudekum"}}