{"action":"created","comment":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/180602870","pull_request_review_id":111048481,"id":180602870,"diff_hunk":"@@ -1503,7 +1470,7 @@ namespace aspect\n     AssertThrow((!use_direct_stokes_solver) || (nullspace_removal == NullspaceRemoval::none),\n                 ExcMessage(\"Because of the difference in system partitioning, nullspace removal is \"\n                            \"currently not compatible with the direct solver. \"\n-                           \"Please turn off one or both of the options 'Model settings/Remove nullspace', \"\n+                           \"Please turn off one or both of the options 'Remove nullspace', \"","path":"source/simulator/parameters.cc","position":297,"original_position":297,"commit_id":"e982d02cec3403e4bf253e4a28db6a2627e79e09","original_commit_id":"c0c1ab220f41512cda6fda175f571ec3916a2bfd","user":{"login":"naliboff","id":3475679,"avatar_url":"https://avatars2.githubusercontent.com/u/3475679?v=4","gravatar_id":"","url":"https://api.github.com/users/naliboff","html_url":"https://github.com/naliboff","followers_url":"https://api.github.com/users/naliboff/followers","following_url":"https://api.github.com/users/naliboff/following{/other_user}","gists_url":"https://api.github.com/users/naliboff/gists{/gist_id}","starred_url":"https://api.github.com/users/naliboff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/naliboff/subscriptions","organizations_url":"https://api.github.com/users/naliboff/orgs","repos_url":"https://api.github.com/users/naliboff/repos","events_url":"https://api.github.com/users/naliboff/events{/privacy}","received_events_url":"https://api.github.com/users/naliboff/received_events","type":"User","site_admin":false},"body":"Don't forgot to change this if you add the section `Nullspace removal`.","created_at":"2018-04-11T00:08:55Z","updated_at":"2018-04-11T00:50:09Z","html_url":"https://github.com/geodynamics/aspect/pull/2157#discussion_r180602870","pull_request_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2157","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments/180602870"},"html":{"href":"https://github.com/geodynamics/aspect/pull/2157#discussion_r180602870"},"pull_request":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2157"}}},"pull_request":{"url":"https://api.github.com/repos/geodynamics/aspect/pulls/2157","id":180709978,"html_url":"https://github.com/geodynamics/aspect/pull/2157","diff_url":"https://github.com/geodynamics/aspect/pull/2157.diff","patch_url":"https://github.com/geodynamics/aspect/pull/2157.patch","issue_url":"https://api.github.com/repos/geodynamics/aspect/issues/2157","number":2157,"state":"open","locked":false,"title":"Remove model settings subsection","user":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars0.githubusercontent.com/u/7582930?v=4","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"body":"This is a rework of #2105, but without its dependencies on #2051 and #2099. It only depends on #2156, which should be easy to merge. It leaves all of the class structure intact, and only moves parameters in different subsections. The most complicated part is really the parameter update script.","created_at":"2018-04-10T19:52:59Z","updated_at":"2018-04-11T00:50:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7eb1648692a782288d86ace06348e37c55329351","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/geodynamics/aspect/milestones/4","html_url":"https://github.com/geodynamics/aspect/milestone/4","labels_url":"https://api.github.com/repos/geodynamics/aspect/milestones/4/labels","id":1860877,"number":4,"title":"2.0","description":"2.0 will be a major release that breaks backward compatibility for plugins and prm files.\r\nIt will address a number of issues that have been lying around for too long, and that can only be addressed by breaking compatibility. Pull requests with this tag will be kept open until a 'flag day' (date t.b.d.) when the most  serious changes will be merged.","creator":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars0.githubusercontent.com/u/7582930?v=4","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"open_issues":6,"closed_issues":11,"state":"open","created_at":"2016-07-01T22:10:54Z","updated_at":"2018-04-10T21:43:37Z","due_on":"2016-12-31T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2157/commits","review_comments_url":"https://api.github.com/repos/geodynamics/aspect/pulls/2157/comments","review_comment_url":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geodynamics/aspect/issues/2157/comments","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/e982d02cec3403e4bf253e4a28db6a2627e79e09","head":{"label":"gassmoeller:remove_model_settings_subsection","ref":"remove_model_settings_subsection","sha":"e982d02cec3403e4bf253e4a28db6a2627e79e09","user":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars0.githubusercontent.com/u/7582930?v=4","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"repo":{"id":19785507,"name":"aspect","full_name":"gassmoeller/aspect","owner":{"login":"gassmoeller","id":7582930,"avatar_url":"https://avatars0.githubusercontent.com/u/7582930?v=4","gravatar_id":"","url":"https://api.github.com/users/gassmoeller","html_url":"https://github.com/gassmoeller","followers_url":"https://api.github.com/users/gassmoeller/followers","following_url":"https://api.github.com/users/gassmoeller/following{/other_user}","gists_url":"https://api.github.com/users/gassmoeller/gists{/gist_id}","starred_url":"https://api.github.com/users/gassmoeller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gassmoeller/subscriptions","organizations_url":"https://api.github.com/users/gassmoeller/orgs","repos_url":"https://api.github.com/users/gassmoeller/repos","events_url":"https://api.github.com/users/gassmoeller/events{/privacy}","received_events_url":"https://api.github.com/users/gassmoeller/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gassmoeller/aspect","description":"Finite element parallel code to simulate problems in thermal convection in both 2D and 3D models.","fork":true,"url":"https://api.github.com/repos/gassmoeller/aspect","forks_url":"https://api.github.com/repos/gassmoeller/aspect/forks","keys_url":"https://api.github.com/repos/gassmoeller/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gassmoeller/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gassmoeller/aspect/teams","hooks_url":"https://api.github.com/repos/gassmoeller/aspect/hooks","issue_events_url":"https://api.github.com/repos/gassmoeller/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/gassmoeller/aspect/events","assignees_url":"https://api.github.com/repos/gassmoeller/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/gassmoeller/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/gassmoeller/aspect/tags","blobs_url":"https://api.github.com/repos/gassmoeller/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gassmoeller/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gassmoeller/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/gassmoeller/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gassmoeller/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/gassmoeller/aspect/languages","stargazers_url":"https://api.github.com/repos/gassmoeller/aspect/stargazers","contributors_url":"https://api.github.com/repos/gassmoeller/aspect/contributors","subscribers_url":"https://api.github.com/repos/gassmoeller/aspect/subscribers","subscription_url":"https://api.github.com/repos/gassmoeller/aspect/subscription","commits_url":"https://api.github.com/repos/gassmoeller/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/gassmoeller/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/gassmoeller/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/gassmoeller/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/gassmoeller/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/gassmoeller/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gassmoeller/aspect/merges","archive_url":"https://api.github.com/repos/gassmoeller/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gassmoeller/aspect/downloads","issues_url":"https://api.github.com/repos/gassmoeller/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/gassmoeller/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/gassmoeller/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/gassmoeller/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gassmoeller/aspect/labels{/name}","releases_url":"https://api.github.com/repos/gassmoeller/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/gassmoeller/aspect/deployments","created_at":"2014-05-14T15:40:43Z","updated_at":"2018-03-23T23:11:07Z","pushed_at":"2018-04-10T23:43:08Z","git_url":"git://github.com/gassmoeller/aspect.git","ssh_url":"git@github.com:gassmoeller/aspect.git","clone_url":"https://github.com/gassmoeller/aspect.git","svn_url":"https://github.com/gassmoeller/aspect","homepage":null,"size":171462,"stargazers_count":2,"watchers_count":2,"language":"Gnuplot","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":2,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"geodynamics:master","ref":"master","sha":"402da57989cc71fcb8ada37b536839d1c00e85ff","user":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"repo":{"id":19502452,"name":"aspect","full_name":"geodynamics/aspect","owner":{"login":"geodynamics","id":4052461,"avatar_url":"https://avatars1.githubusercontent.com/u/4052461?v=4","gravatar_id":"","url":"https://api.github.com/users/geodynamics","html_url":"https://github.com/geodynamics","followers_url":"https://api.github.com/users/geodynamics/followers","following_url":"https://api.github.com/users/geodynamics/following{/other_user}","gists_url":"https://api.github.com/users/geodynamics/gists{/gist_id}","starred_url":"https://api.github.com/users/geodynamics/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geodynamics/subscriptions","organizations_url":"https://api.github.com/users/geodynamics/orgs","repos_url":"https://api.github.com/users/geodynamics/repos","events_url":"https://api.github.com/users/geodynamics/events{/privacy}","received_events_url":"https://api.github.com/users/geodynamics/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geodynamics/aspect","description":"A parallel, extensible finite element code to simulate convection in both 2D and 3D models.","fork":false,"url":"https://api.github.com/repos/geodynamics/aspect","forks_url":"https://api.github.com/repos/geodynamics/aspect/forks","keys_url":"https://api.github.com/repos/geodynamics/aspect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geodynamics/aspect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geodynamics/aspect/teams","hooks_url":"https://api.github.com/repos/geodynamics/aspect/hooks","issue_events_url":"https://api.github.com/repos/geodynamics/aspect/issues/events{/number}","events_url":"https://api.github.com/repos/geodynamics/aspect/events","assignees_url":"https://api.github.com/repos/geodynamics/aspect/assignees{/user}","branches_url":"https://api.github.com/repos/geodynamics/aspect/branches{/branch}","tags_url":"https://api.github.com/repos/geodynamics/aspect/tags","blobs_url":"https://api.github.com/repos/geodynamics/aspect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geodynamics/aspect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geodynamics/aspect/git/refs{/sha}","trees_url":"https://api.github.com/repos/geodynamics/aspect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geodynamics/aspect/statuses/{sha}","languages_url":"https://api.github.com/repos/geodynamics/aspect/languages","stargazers_url":"https://api.github.com/repos/geodynamics/aspect/stargazers","contributors_url":"https://api.github.com/repos/geodynamics/aspect/contributors","subscribers_url":"https://api.github.com/repos/geodynamics/aspect/subscribers","subscription_url":"https://api.github.com/repos/geodynamics/aspect/subscription","commits_url":"https://api.github.com/repos/geodynamics/aspect/commits{/sha}","git_commits_url":"https://api.github.com/repos/geodynamics/aspect/git/commits{/sha}","comments_url":"https://api.github.com/repos/geodynamics/aspect/comments{/number}","issue_comment_url":"https://api.github.com/repos/geodynamics/aspect/issues/comments{/number}","contents_url":"https://api.github.com/repos/geodynamics/aspect/contents/{+path}","compare_url":"https://api.github.com/repos/geodynamics/aspect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geodynamics/aspect/merges","archive_url":"https://api.github.com/repos/geodynamics/aspect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geodynamics/aspect/downloads","issues_url":"https://api.github.com/repos/geodynamics/aspect/issues{/number}","pulls_url":"https://api.github.com/repos/geodynamics/aspect/pulls{/number}","milestones_url":"https://api.github.com/repos/geodynamics/aspect/milestones{/number}","notifications_url":"https://api.github.com/repos/geodynamics/aspect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geodynamics/aspect/labels{/name}","releases_url":"https://api.github.com/repos/geodynamics/aspect/releases{/id}","deployments_url":"https://api.github.com/repos/geodynamics/aspect/deployments","created_at":"2014-05-06T16:47:18Z","updated_at":"2018-04-09T18:05:43Z","pushed_at":"2018-04-10T23:43:09Z","git_url":"git://github.com/geodynamics/aspect.git","ssh_url":"git@github.com:geodynamics/aspect.git","clone_url":"https://github.com/geodynamics/aspect.git","svn_url":"https://github.com/geodynamics/aspect","homepage":"https://aspect.geodynamics.org/","size":172291,"stargazers_count":50,"watchers_count":50,"language":"Gnuplot","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":176,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":86,"open_issues":176,"watchers":50,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2157"},"html":{"href":"https://github.com/geodynamics/aspect/pull/2157"},"issue":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/2157"},"comments":{"href":"https://api.github.com/repos/geodynamics/aspect/issues/2157/comments"},"review_comments":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2157/comments"},"review_comment":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geodynamics/aspect/pulls/2157/commits"},"statuses":{"href":"https://api.github.com/repos/geodynamics/aspect/statuses/e982d02cec3403e4bf253e4a28db6a2627e79e09"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"naliboff"}}