{"action":"opened","number":1336,"pull_request":{"url":"https://api.github.com/repos/psi4/psi4/pulls/1336","id":228727602,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NzI3NjAy","html_url":"https://github.com/psi4/psi4/pull/1336","diff_url":"https://github.com/psi4/psi4/pull/1336.diff","patch_url":"https://github.com/psi4/psi4/pull/1336.patch","issue_url":"https://api.github.com/repos/psi4/psi4/issues/1336","number":1336,"state":"open","locked":false,"title":"Fix 1288: ODC Compatible with Other OO Code","user":{"login":"JonathonMisiewicz","id":29777889,"node_id":"MDQ6VXNlcjI5Nzc3ODg5","avatar_url":"https://avatars0.githubusercontent.com/u/29777889?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathonMisiewicz","html_url":"https://github.com/JonathonMisiewicz","followers_url":"https://api.github.com/users/JonathonMisiewicz/followers","following_url":"https://api.github.com/users/JonathonMisiewicz/following{/other_user}","gists_url":"https://api.github.com/users/JonathonMisiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathonMisiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathonMisiewicz/subscriptions","organizations_url":"https://api.github.com/users/JonathonMisiewicz/orgs","repos_url":"https://api.github.com/users/JonathonMisiewicz/repos","events_url":"https://api.github.com/users/JonathonMisiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/JonathonMisiewicz/received_events","type":"User","site_admin":false},"body":"## Description\r\nFixes 1288. The trouble was that Bozkaya's code used libtrans to transform integrals, and those were written to disk in their antisymmetrized, redundancy-free form, as libtrans does. The DCT code gets different integrals from libtrans but then sorts those to get the same blocks as Bozkaya wrote earlier in the redundant form. Because the DCT-sorted integral block had antisymmetry redundancies, it was larger than the libtrans block that did not have those redundancies.\r\n\r\nFixed by changing the code to use a block without those redundancies.\r\n\r\nI imagine this is of interest to @amjames and @ssh2.\r\n\r\n## Todos\r\nNotable points (developer or user-interest) that this PR has or will accomplish.\r\n- [x] Fixes 1288\r\n\r\n## Checklist\r\n- [x] DCFT tests run\r\n\r\n## Status\r\n- [x] Ready for review\r\n- [x] Ready for merge\r\n","created_at":"2018-11-06T15:18:36Z","updated_at":"2018-11-06T15:18:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/psi4/psi4/pulls/1336/commits","review_comments_url":"https://api.github.com/repos/psi4/psi4/pulls/1336/comments","review_comment_url":"https://api.github.com/repos/psi4/psi4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/psi4/psi4/issues/1336/comments","statuses_url":"https://api.github.com/repos/psi4/psi4/statuses/ea13180fd76c147eb34258b484bd62d7bab2ef2b","head":{"label":"JonathonMisiewicz:fixodc12","ref":"fixodc12","sha":"ea13180fd76c147eb34258b484bd62d7bab2ef2b","user":{"login":"JonathonMisiewicz","id":29777889,"node_id":"MDQ6VXNlcjI5Nzc3ODg5","avatar_url":"https://avatars0.githubusercontent.com/u/29777889?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathonMisiewicz","html_url":"https://github.com/JonathonMisiewicz","followers_url":"https://api.github.com/users/JonathonMisiewicz/followers","following_url":"https://api.github.com/users/JonathonMisiewicz/following{/other_user}","gists_url":"https://api.github.com/users/JonathonMisiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathonMisiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathonMisiewicz/subscriptions","organizations_url":"https://api.github.com/users/JonathonMisiewicz/orgs","repos_url":"https://api.github.com/users/JonathonMisiewicz/repos","events_url":"https://api.github.com/users/JonathonMisiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/JonathonMisiewicz/received_events","type":"User","site_admin":false},"repo":{"id":107976097,"node_id":"MDEwOlJlcG9zaXRvcnkxMDc5NzYwOTc=","name":"psi4","full_name":"JonathonMisiewicz/psi4","private":false,"owner":{"login":"JonathonMisiewicz","id":29777889,"node_id":"MDQ6VXNlcjI5Nzc3ODg5","avatar_url":"https://avatars0.githubusercontent.com/u/29777889?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathonMisiewicz","html_url":"https://github.com/JonathonMisiewicz","followers_url":"https://api.github.com/users/JonathonMisiewicz/followers","following_url":"https://api.github.com/users/JonathonMisiewicz/following{/other_user}","gists_url":"https://api.github.com/users/JonathonMisiewicz/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathonMisiewicz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathonMisiewicz/subscriptions","organizations_url":"https://api.github.com/users/JonathonMisiewicz/orgs","repos_url":"https://api.github.com/users/JonathonMisiewicz/repos","events_url":"https://api.github.com/users/JonathonMisiewicz/events{/privacy}","received_events_url":"https://api.github.com/users/JonathonMisiewicz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/JonathonMisiewicz/psi4","description":"Open-Source Quantum Chemistry – an electronic structure package in C++ driven by Python","fork":true,"url":"https://api.github.com/repos/JonathonMisiewicz/psi4","forks_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/forks","keys_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/teams","hooks_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/hooks","issue_events_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/issues/events{/number}","events_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/events","assignees_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/assignees{/user}","branches_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/branches{/branch}","tags_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/tags","blobs_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/git/refs{/sha}","trees_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/statuses/{sha}","languages_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/languages","stargazers_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/stargazers","contributors_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/contributors","subscribers_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/subscribers","subscription_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/subscription","commits_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/commits{/sha}","git_commits_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/git/commits{/sha}","comments_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/comments{/number}","issue_comment_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/issues/comments{/number}","contents_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/contents/{+path}","compare_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/merges","archive_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/downloads","issues_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/issues{/number}","pulls_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/pulls{/number}","milestones_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/milestones{/number}","notifications_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/labels{/name}","releases_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/releases{/id}","deployments_url":"https://api.github.com/repos/JonathonMisiewicz/psi4/deployments","created_at":"2017-10-23T12:00:29Z","updated_at":"2018-10-31T19:19:55Z","pushed_at":"2018-11-06T15:13:55Z","git_url":"git://github.com/JonathonMisiewicz/psi4.git","ssh_url":"git@github.com:JonathonMisiewicz/psi4.git","clone_url":"https://github.com/JonathonMisiewicz/psi4.git","svn_url":"https://github.com/JonathonMisiewicz/psi4","homepage":"http://psicode.org","size":87510,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"psi4:master","ref":"master","sha":"69cdc873bbba6fce3a9cd45a4f8459e315d6c770","user":{"login":"psi4","id":2636883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzY4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2636883?v=4","gravatar_id":"","url":"https://api.github.com/users/psi4","html_url":"https://github.com/psi4","followers_url":"https://api.github.com/users/psi4/followers","following_url":"https://api.github.com/users/psi4/following{/other_user}","gists_url":"https://api.github.com/users/psi4/gists{/gist_id}","starred_url":"https://api.github.com/users/psi4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psi4/subscriptions","organizations_url":"https://api.github.com/users/psi4/orgs","repos_url":"https://api.github.com/users/psi4/repos","events_url":"https://api.github.com/users/psi4/events{/privacy}","received_events_url":"https://api.github.com/users/psi4/received_events","type":"Organization","site_admin":false},"repo":{"id":9174469,"node_id":"MDEwOlJlcG9zaXRvcnk5MTc0NDY5","name":"psi4","full_name":"psi4/psi4","private":false,"owner":{"login":"psi4","id":2636883,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2MzY4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/2636883?v=4","gravatar_id":"","url":"https://api.github.com/users/psi4","html_url":"https://github.com/psi4","followers_url":"https://api.github.com/users/psi4/followers","following_url":"https://api.github.com/users/psi4/following{/other_user}","gists_url":"https://api.github.com/users/psi4/gists{/gist_id}","starred_url":"https://api.github.com/users/psi4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/psi4/subscriptions","organizations_url":"https://api.github.com/users/psi4/orgs","repos_url":"https://api.github.com/users/psi4/repos","events_url":"https://api.github.com/users/psi4/events{/privacy}","received_events_url":"https://api.github.com/users/psi4/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/psi4/psi4","description":"Open-Source Quantum Chemistry – an electronic structure package in C++ driven by Python","fork":false,"url":"https://api.github.com/repos/psi4/psi4","forks_url":"https://api.github.com/repos/psi4/psi4/forks","keys_url":"https://api.github.com/repos/psi4/psi4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/psi4/psi4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/psi4/psi4/teams","hooks_url":"https://api.github.com/repos/psi4/psi4/hooks","issue_events_url":"https://api.github.com/repos/psi4/psi4/issues/events{/number}","events_url":"https://api.github.com/repos/psi4/psi4/events","assignees_url":"https://api.github.com/repos/psi4/psi4/assignees{/user}","branches_url":"https://api.github.com/repos/psi4/psi4/branches{/branch}","tags_url":"https://api.github.com/repos/psi4/psi4/tags","blobs_url":"https://api.github.com/repos/psi4/psi4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/psi4/psi4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/psi4/psi4/git/refs{/sha}","trees_url":"https://api.github.com/repos/psi4/psi4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/psi4/psi4/statuses/{sha}","languages_url":"https://api.github.com/repos/psi4/psi4/languages","stargazers_url":"https://api.github.com/repos/psi4/psi4/stargazers","contributors_url":"https://api.github.com/repos/psi4/psi4/contributors","subscribers_url":"https://api.github.com/repos/psi4/psi4/subscribers","subscription_url":"https://api.github.com/repos/psi4/psi4/subscription","commits_url":"https://api.github.com/repos/psi4/psi4/commits{/sha}","git_commits_url":"https://api.github.com/repos/psi4/psi4/git/commits{/sha}","comments_url":"https://api.github.com/repos/psi4/psi4/comments{/number}","issue_comment_url":"https://api.github.com/repos/psi4/psi4/issues/comments{/number}","contents_url":"https://api.github.com/repos/psi4/psi4/contents/{+path}","compare_url":"https://api.github.com/repos/psi4/psi4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/psi4/psi4/merges","archive_url":"https://api.github.com/repos/psi4/psi4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/psi4/psi4/downloads","issues_url":"https://api.github.com/repos/psi4/psi4/issues{/number}","pulls_url":"https://api.github.com/repos/psi4/psi4/pulls{/number}","milestones_url":"https://api.github.com/repos/psi4/psi4/milestones{/number}","notifications_url":"https://api.github.com/repos/psi4/psi4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/psi4/psi4/labels{/name}","releases_url":"https://api.github.com/repos/psi4/psi4/releases{/id}","deployments_url":"https://api.github.com/repos/psi4/psi4/deployments","created_at":"2013-04-02T16:21:04Z","updated_at":"2018-11-05T20:12:43Z","pushed_at":"2018-11-06T10:42:59Z","git_url":"git://github.com/psi4/psi4.git","ssh_url":"git@github.com:psi4/psi4.git","clone_url":"https://github.com/psi4/psi4.git","svn_url":"https://github.com/psi4/psi4","homepage":"http://psicode.org","size":87623,"stargazers_count":251,"watchers_count":251,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":203,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":203,"open_issues":120,"watchers":251,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1336"},"html":{"href":"https://github.com/psi4/psi4/pull/1336"},"issue":{"href":"https://api.github.com/repos/psi4/psi4/issues/1336"},"comments":{"href":"https://api.github.com/repos/psi4/psi4/issues/1336/comments"},"review_comments":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1336/comments"},"review_comment":{"href":"https://api.github.com/repos/psi4/psi4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/psi4/psi4/pulls/1336/commits"},"statuses":{"href":"https://api.github.com/repos/psi4/psi4/statuses/ea13180fd76c147eb34258b484bd62d7bab2ef2b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":6,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"JonathonMisiewicz"}}