{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/763","repository_url":"https://api.github.com/repos/aws/aws-sdk-java-v2","labels_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/763/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/763/comments","events_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/763/events","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/763","id":370867382,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNDQ2NzU0","number":763,"title":"Use virtual style addressing for non Amazon S3 endpoints.","user":{"login":"ebabani","id":2236882,"node_id":"MDQ6VXNlcjIyMzY4ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/2236882?v=4","gravatar_id":"","url":"https://api.github.com/users/ebabani","html_url":"https://github.com/ebabani","followers_url":"https://api.github.com/users/ebabani/followers","following_url":"https://api.github.com/users/ebabani/following{/other_user}","gists_url":"https://api.github.com/users/ebabani/gists{/gist_id}","starred_url":"https://api.github.com/users/ebabani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebabani/subscriptions","organizations_url":"https://api.github.com/users/ebabani/orgs","repos_url":"https://api.github.com/users/ebabani/repos","events_url":"https://api.github.com/users/ebabani/events{/privacy}","received_events_url":"https://api.github.com/users/ebabani/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-17T02:02:12Z","updated_at":"2018-10-26T17:55:23Z","closed_at":"2018-10-26T17:42:23Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/pulls/763","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/763","diff_url":"https://github.com/aws/aws-sdk-java-v2/pull/763.diff","patch_url":"https://github.com/aws/aws-sdk-java-v2/pull/763.patch"},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\nAllow using the dns style (bucket.s3-endpoint) instead or forcing the path style (s3-endpoint/bucket) for non Amazon s3-compatible endpoint. This allows using the sdk with third party providers that only support the dns style for access (eg. Alicloud)\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here -->\r\n\r\nAllows using this sdk with any third party s3 providers that support virtual style addressing.\r\n\r\n## Testing\r\n<!--- Please describe in detail how you tested your changes -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\n\r\n## Screenshots (if appropriate)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n\r\n\r\n## Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have read the **CONTRIBUTING** document\r\n- [x] Local run of `mvn install` succeeds\r\n- [x] My code follows the code style of this project\r\n- [ ] My change requires a change to the Javadoc documentation\r\n- [x] I have updated the Javadoc documentation accordingly\r\n- [x] I have read the **README** document\r\n- [x] I have added tests to cover my changes\r\n- [x] All new and existing tests passed\r\n- [x] A short description of the change has been added to the **CHANGELOG** \r\n\r\n## License\r\n<!--- The SDK is released under the Apache 2.0 license (http://aws.amazon.com/apache2.0/), so any code you submit will be released under that license -->\r\n<!--- For substantial contributions, we may ask you to sign a Contributor License Agreement (http://en.wikipedia.org/wiki/Contributor_License_Agreement) -->\r\n<!--- Put an `x` in the below box if you confirm that this request can be released under the Apache 2 license -->\r\n- [x] I confirm that this pull request can be released under the Apache 2 license\r\n"},"comment":{"url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/comments/433492099","html_url":"https://github.com/aws/aws-sdk-java-v2/pull/763#issuecomment-433492099","issue_url":"https://api.github.com/repos/aws/aws-sdk-java-v2/issues/763","id":433492099,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzQ5MjA5OQ==","user":{"login":"ebabani","id":2236882,"node_id":"MDQ6VXNlcjIyMzY4ODI=","avatar_url":"https://avatars3.githubusercontent.com/u/2236882?v=4","gravatar_id":"","url":"https://api.github.com/users/ebabani","html_url":"https://github.com/ebabani","followers_url":"https://api.github.com/users/ebabani/followers","following_url":"https://api.github.com/users/ebabani/following{/other_user}","gists_url":"https://api.github.com/users/ebabani/gists{/gist_id}","starred_url":"https://api.github.com/users/ebabani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ebabani/subscriptions","organizations_url":"https://api.github.com/users/ebabani/orgs","repos_url":"https://api.github.com/users/ebabani/repos","events_url":"https://api.github.com/users/ebabani/events{/privacy}","received_events_url":"https://api.github.com/users/ebabani/received_events","type":"User","site_admin":false},"created_at":"2018-10-26T17:55:23Z","updated_at":"2018-10-26T17:55:23Z","author_association":"NONE","body":"@millems Totally agree with that behaviour, but at the moment this SDK is NOT using virtual hosted-style addressing for third party endpoints, and there is no way to change that.\r\n\r\nhttps://github.com/aws/aws-sdk-java-v2/blob/master/services/s3/src/main/java/software/amazon/awssdk/services/s3/handlers/EndpointAddressInterceptor.java#L141\r\n\r\nThis PR addresses that limitation, but does not affect the addressing behaviour above."}}
{"actor":{"display_login":"ebabani"}}