{"action":"created","issue":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/136","repository_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok","labels_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/136/labels{/name}","comments_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/136/comments","events_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/136/events","html_url":"https://github.com/logstash-plugins/logstash-filter-grok/pull/136","id":298787345,"number":136,"title":"fix memory leak on JRuby 1.x","user":{"login":"jakelandis","id":976291,"avatar_url":"https://avatars2.githubusercontent.com/u/976291?v=4","gravatar_id":"","url":"https://api.github.com/users/jakelandis","html_url":"https://github.com/jakelandis","followers_url":"https://api.github.com/users/jakelandis/followers","following_url":"https://api.github.com/users/jakelandis/following{/other_user}","gists_url":"https://api.github.com/users/jakelandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jakelandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakelandis/subscriptions","organizations_url":"https://api.github.com/users/jakelandis/orgs","repos_url":"https://api.github.com/users/jakelandis/repos","events_url":"https://api.github.com/users/jakelandis/events{/privacy}","received_events_url":"https://api.github.com/users/jakelandis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-20T23:25:11Z","updated_at":"2018-02-21T01:30:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/pulls/136","html_url":"https://github.com/logstash-plugins/logstash-filter-grok/pull/136","diff_url":"https://github.com/logstash-plugins/logstash-filter-grok/pull/136.diff","patch_url":"https://github.com/logstash-plugins/logstash-filter-grok/pull/136.patch"},"body":"It seems that on JRuby 1.x (tested jruby-1.7.27), the outer loop when coded as Java forEach causes JRuby to leak some internal state. Specifically the NonBlockingHashMapLong$CHM dominates the memory. See the referenced bug for a reproduction case. The commit changes the outer loop to a standard for loop to avoid this bug.\r\n\r\nFixes #135\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/comments/367182561","html_url":"https://github.com/logstash-plugins/logstash-filter-grok/pull/136#issuecomment-367182561","issue_url":"https://api.github.com/repos/logstash-plugins/logstash-filter-grok/issues/136","id":367182561,"user":{"login":"jakelandis","id":976291,"avatar_url":"https://avatars2.githubusercontent.com/u/976291?v=4","gravatar_id":"","url":"https://api.github.com/users/jakelandis","html_url":"https://github.com/jakelandis","followers_url":"https://api.github.com/users/jakelandis/followers","following_url":"https://api.github.com/users/jakelandis/following{/other_user}","gists_url":"https://api.github.com/users/jakelandis/gists{/gist_id}","starred_url":"https://api.github.com/users/jakelandis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jakelandis/subscriptions","organizations_url":"https://api.github.com/users/jakelandis/orgs","repos_url":"https://api.github.com/users/jakelandis/repos","events_url":"https://api.github.com/users/jakelandis/events{/privacy}","received_events_url":"https://api.github.com/users/jakelandis/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T01:30:03Z","updated_at":"2018-02-21T01:30:03Z","author_association":"CONTRIBUTOR","body":"@yaauie - thanks!  \r\n\r\nI updated to use the keySet, I agree it reads much better. \r\n\r\nI also updated the commit message (and this PR's first comment) to help clarify. I meant Java 8's lambda based forEach instead of the standard for loop. "}}
{"actor":{"display_login":"jakelandis"}}