{"action":"created","issue":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/4242","repository_url":"https://api.github.com/repos/envoyproxy/envoy","labels_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4242/labels{/name}","comments_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4242/comments","events_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4242/events","html_url":"https://github.com/envoyproxy/envoy/pull/4242","id":353742223,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwNzEwNzU5","number":4242,"title":"Creating JwksFetcher interface and impl v2","user":{"login":"nickrmc83","id":1595216,"node_id":"MDQ6VXNlcjE1OTUyMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1595216?v=4","gravatar_id":"","url":"https://api.github.com/users/nickrmc83","html_url":"https://github.com/nickrmc83","followers_url":"https://api.github.com/users/nickrmc83/followers","following_url":"https://api.github.com/users/nickrmc83/following{/other_user}","gists_url":"https://api.github.com/users/nickrmc83/gists{/gist_id}","starred_url":"https://api.github.com/users/nickrmc83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickrmc83/subscriptions","organizations_url":"https://api.github.com/users/nickrmc83/orgs","repos_url":"https://api.github.com/users/nickrmc83/repos","events_url":"https://api.github.com/users/nickrmc83/events{/privacy}","received_events_url":"https://api.github.com/users/nickrmc83/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false},"assignees":[{"login":"lizan","id":1016047,"node_id":"MDQ6VXNlcjEwMTYwNDc=","avatar_url":"https://avatars1.githubusercontent.com/u/1016047?v=4","gravatar_id":"","url":"https://api.github.com/users/lizan","html_url":"https://github.com/lizan","followers_url":"https://api.github.com/users/lizan/followers","following_url":"https://api.github.com/users/lizan/following{/other_user}","gists_url":"https://api.github.com/users/lizan/gists{/gist_id}","starred_url":"https://api.github.com/users/lizan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lizan/subscriptions","organizations_url":"https://api.github.com/users/lizan/orgs","repos_url":"https://api.github.com/users/lizan/repos","events_url":"https://api.github.com/users/lizan/events{/privacy}","received_events_url":"https://api.github.com/users/lizan/received_events","type":"User","site_admin":false}],"milestone":null,"comments":7,"created_at":"2018-08-24T11:12:08Z","updated_at":"2018-09-13T12:07:40Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/envoyproxy/envoy/pulls/4242","html_url":"https://github.com/envoyproxy/envoy/pull/4242","diff_url":"https://github.com/envoyproxy/envoy/pull/4242.diff","patch_url":"https://github.com/envoyproxy/envoy/pull/4242.patch"},"body":"JwksFetcher wraps up HTTP acquisition of JWKS strings converting them into a concrete type on the way.\r\nJwksFetcher is reusable so can be used in a wider context.\r\n\r\nTests updated and fixed where necessary.\r\n*Description*:\r\nWe are in the process of implementing a new Envoy filter based on the design presented here and wish to re-use existing logic in the jwt_authn filter. We've split out the logic we're interested in into a new class called JwksFetcher. Later PRs will re-use the split out logic an OpenID Connect filter.\r\n\r\nThis is the second crack at this PR (see https://github.com/envoyproxy/envoy/pull/4225 which went horribly wrong after following the DCO rebase guidelines).\r\n\r\n*Risk Level*:\r\nMedium\r\n*Testing*:\r\nAdd replacement and additional unit tests for the logic that's been moved.\r\n*Docs Changes*:\r\nNone\r\n*Release Notes*:\r\n[Optional Fixes #Issue]\r\n[Optional *Deprecated*:]\r\n"},"comment":{"url":"https://api.github.com/repos/envoyproxy/envoy/issues/comments/420983523","html_url":"https://github.com/envoyproxy/envoy/pull/4242#issuecomment-420983523","issue_url":"https://api.github.com/repos/envoyproxy/envoy/issues/4242","id":420983523,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDk4MzUyMw==","user":{"login":"nickrmc83","id":1595216,"node_id":"MDQ6VXNlcjE1OTUyMTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1595216?v=4","gravatar_id":"","url":"https://api.github.com/users/nickrmc83","html_url":"https://github.com/nickrmc83","followers_url":"https://api.github.com/users/nickrmc83/followers","following_url":"https://api.github.com/users/nickrmc83/following{/other_user}","gists_url":"https://api.github.com/users/nickrmc83/gists{/gist_id}","starred_url":"https://api.github.com/users/nickrmc83/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nickrmc83/subscriptions","organizations_url":"https://api.github.com/users/nickrmc83/orgs","repos_url":"https://api.github.com/users/nickrmc83/repos","events_url":"https://api.github.com/users/nickrmc83/events{/privacy}","received_events_url":"https://api.github.com/users/nickrmc83/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T12:07:40Z","updated_at":"2018-09-13T12:07:40Z","author_association":"NONE","body":"@htuch I think this is done with the following caveats \r\n- My local check_format run shows no errors and the CI failure is giving me no hints.\r\n- The failing ipv6 looks like an intermittent issue completely outside of the changes in this PR.\r\n\r\nCan you advise on the format error?"}}
{"actor":{"display_login":"nickrmc83"}}