{"action":"created","issue":{"url":"https://api.github.com/repos/zalando/nakadi/issues/838","repository_url":"https://api.github.com/repos/zalando/nakadi","labels_url":"https://api.github.com/repos/zalando/nakadi/issues/838/labels{/name}","comments_url":"https://api.github.com/repos/zalando/nakadi/issues/838/comments","events_url":"https://api.github.com/repos/zalando/nakadi/issues/838/events","html_url":"https://github.com/zalando/nakadi/pull/838","id":296363551,"number":838,"title":"Aruha 1173","user":{"login":"antban","id":2656223,"avatar_url":"https://avatars3.githubusercontent.com/u/2656223?v=4","gravatar_id":"","url":"https://api.github.com/users/antban","html_url":"https://github.com/antban","followers_url":"https://api.github.com/users/antban/followers","following_url":"https://api.github.com/users/antban/following{/other_user}","gists_url":"https://api.github.com/users/antban/gists{/gist_id}","starred_url":"https://api.github.com/users/antban/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/antban/subscriptions","organizations_url":"https://api.github.com/users/antban/orgs","repos_url":"https://api.github.com/users/antban/repos","events_url":"https://api.github.com/users/antban/events{/privacy}","received_events_url":"https://api.github.com/users/antban/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-12T12:47:36Z","updated_at":"2018-02-12T12:50:06Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/zalando/nakadi/pulls/838","html_url":"https://github.com/zalando/nakadi/pull/838","diff_url":"https://github.com/zalando/nakadi/pull/838.diff","patch_url":"https://github.com/zalando/nakadi/pull/838.patch"},"body":"# Do not reformat incoming messages while publishing\r\n\r\n> Zalando ticket : ARUHA-1173\r\n\r\n## Description\r\nRight now nakadi is parsing json while validating events and than stores events from parsed format to a kafka format. This may lead to problems user behavior (for example 0.0 and 0 should be treated in the same manner, but it is actually not)\r\nThis ticket prevents nakadi from this kind of modifications, removing only meaningless values from the events.\r\n"},"comment":{"url":"https://api.github.com/repos/zalando/nakadi/issues/comments/364913537","html_url":"https://github.com/zalando/nakadi/pull/838#issuecomment-364913537","issue_url":"https://api.github.com/repos/zalando/nakadi/issues/838","id":364913537,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T12:50:06Z","updated_at":"2018-02-12T12:50:06Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/zalando/nakadi/pull/838?src=pr&el=h1) Report\n> Merging [#838](https://codecov.io/gh/zalando/nakadi/pull/838?src=pr&el=desc) into [master](https://codecov.io/gh/zalando/nakadi/commit/485927c776d9ce1b0b1b707448f7bed077d149c8?src=pr&el=desc) will **increase** coverage by `0.38%`.\n> The diff coverage is `80.11%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/zalando/nakadi/pull/838/graphs/tree.svg?height=150&width=650&token=7HPn3YxsBG&src=pr)](https://codecov.io/gh/zalando/nakadi/pull/838?src=pr&el=tree)\n\n```diff\n@@             Coverage Diff              @@\n##             master     #838      +/-   ##\n============================================\n+ Coverage     53.78%   54.17%   +0.38%     \n- Complexity     1596     1638      +42     \n============================================\n  Files           304      304              \n  Lines          8909     9034     +125     \n  Branches        773      807      +34     \n============================================\n+ Hits           4792     4894     +102     \n- Misses         3837     3846       +9     \n- Partials        280      294      +14\n```\n\n\n| [Impacted Files](https://codecov.io/gh/zalando/nakadi/pull/838?src=pr&el=tree) | Coverage Δ | Complexity Δ | |\n|---|---|---|---|\n| [...ava/org/zalando/nakadi/service/EventPublisher.java](https://codecov.io/gh/zalando/nakadi/pull/838/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9vcmcvemFsYW5kby9uYWthZGkvc2VydmljZS9FdmVudFB1Ymxpc2hlci5qYXZh) | `91.48% <ø> (ø)` | `20 <0> (ø)` | :arrow_down: |\n| [.../nakadi/repository/kafka/KafkaTopicRepository.java](https://codecov.io/gh/zalando/nakadi/pull/838/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9vcmcvemFsYW5kby9uYWthZGkvcmVwb3NpdG9yeS9rYWZrYS9LYWZrYVRvcGljUmVwb3NpdG9yeS5qYXZh) | `54.77% <100%> (ø)` | `52 <0> (ø)` | :arrow_down: |\n| [...o/nakadi/controller/EventPublishingController.java](https://codecov.io/gh/zalando/nakadi/pull/838/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9vcmcvemFsYW5kby9uYWthZGkvY29udHJvbGxlci9FdmVudFB1Ymxpc2hpbmdDb250cm9sbGVyLmphdmE=) | `85.5% <100%> (ø)` | `16 <0> (ø)` | :arrow_down: |\n| [.../nakadi/enrichment/MetadataEnrichmentStrategy.java](https://codecov.io/gh/zalando/nakadi/pull/838/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9vcmcvemFsYW5kby9uYWthZGkvZW5yaWNobWVudC9NZXRhZGF0YUVucmljaG1lbnRTdHJhdGVneS5qYXZh) | `100% <100%> (ø)` | `8 <1> (ø)` | :arrow_down: |\n| [...n/java/org/zalando/nakadi/domain/BatchFactory.java](https://codecov.io/gh/zalando/nakadi/pull/838/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9vcmcvemFsYW5kby9uYWthZGkvZG9tYWluL0JhdGNoRmFjdG9yeS5qYXZh) | `74.46% <73.56%> (-0.54%)` | `50 <45> (+27)` | |\n| [...main/java/org/zalando/nakadi/domain/BatchItem.java](https://codecov.io/gh/zalando/nakadi/pull/838/diff?src=pr&el=tree#diff-c3JjL21haW4vamF2YS9vcmcvemFsYW5kby9uYWthZGkvZG9tYWluL0JhdGNoSXRlbS5qYXZh) | `88.11% <86.07%> (-7.54%)` | `26 <16> (+15)` | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/zalando/nakadi/pull/838?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/zalando/nakadi/pull/838?src=pr&el=footer). Last update [485927c...f492b1b](https://codecov.io/gh/zalando/nakadi/pull/838?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}