{"action":"created","issue":{"url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1888","repository_url":"https://api.github.com/repos/bitshares/bitshares-ui","labels_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1888/labels{/name}","comments_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1888/comments","events_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1888/events","html_url":"https://github.com/bitshares/bitshares-ui/issues/1888","id":362957091,"node_id":"MDU6SXNzdWUzNjI5NTcwOTE=","number":1888,"title":"[Exchange Refinement] Scrap Layout Selections","user":{"login":"startailcoon","id":12114550,"node_id":"MDQ6VXNlcjEyMTE0NTUw","avatar_url":"https://avatars1.githubusercontent.com/u/12114550?v=4","gravatar_id":"","url":"https://api.github.com/users/startailcoon","html_url":"https://github.com/startailcoon","followers_url":"https://api.github.com/users/startailcoon/followers","following_url":"https://api.github.com/users/startailcoon/following{/other_user}","gists_url":"https://api.github.com/users/startailcoon/gists{/gist_id}","starred_url":"https://api.github.com/users/startailcoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/startailcoon/subscriptions","organizations_url":"https://api.github.com/users/startailcoon/orgs","repos_url":"https://api.github.com/users/startailcoon/repos","events_url":"https://api.github.com/users/startailcoon/events{/privacy}","received_events_url":"https://api.github.com/users/startailcoon/received_events","type":"User","site_admin":false},"labels":[{"id":857418383,"node_id":"MDU6TGFiZWw4NTc0MTgzODM=","url":"https://api.github.com/repos/bitshares/bitshares-ui/labels/task","name":"task","color":"0052cc","default":false}],"state":"open","locked":false,"assignee":{"login":"startailcoon","id":12114550,"node_id":"MDQ6VXNlcjEyMTE0NTUw","avatar_url":"https://avatars1.githubusercontent.com/u/12114550?v=4","gravatar_id":"","url":"https://api.github.com/users/startailcoon","html_url":"https://github.com/startailcoon","followers_url":"https://api.github.com/users/startailcoon/followers","following_url":"https://api.github.com/users/startailcoon/following{/other_user}","gists_url":"https://api.github.com/users/startailcoon/gists{/gist_id}","starred_url":"https://api.github.com/users/startailcoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/startailcoon/subscriptions","organizations_url":"https://api.github.com/users/startailcoon/orgs","repos_url":"https://api.github.com/users/startailcoon/repos","events_url":"https://api.github.com/users/startailcoon/events{/privacy}","received_events_url":"https://api.github.com/users/startailcoon/received_events","type":"User","site_admin":false},"assignees":[{"login":"startailcoon","id":12114550,"node_id":"MDQ6VXNlcjEyMTE0NTUw","avatar_url":"https://avatars1.githubusercontent.com/u/12114550?v=4","gravatar_id":"","url":"https://api.github.com/users/startailcoon","html_url":"https://github.com/startailcoon","followers_url":"https://api.github.com/users/startailcoon/followers","following_url":"https://api.github.com/users/startailcoon/following{/other_user}","gists_url":"https://api.github.com/users/startailcoon/gists{/gist_id}","starred_url":"https://api.github.com/users/startailcoon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/startailcoon/subscriptions","organizations_url":"https://api.github.com/users/startailcoon/orgs","repos_url":"https://api.github.com/users/startailcoon/repos","events_url":"https://api.github.com/users/startailcoon/events{/privacy}","received_events_url":"https://api.github.com/users/startailcoon/received_events","type":"User","site_admin":false}],"milestone":null,"comments":3,"created_at":"2018-09-23T16:38:54Z","updated_at":"2018-10-01T19:07:52Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"I think that we should scrap the Layout Selections as part of the design in #1477.\r\n\r\nAs I've added back the option to pin the order book as part of issue #1873, we can do the following changes.\r\n\r\n### Layout 1 and 2\r\nLayout 1 and 2 has OrderBook, My Markets and Find Markets in the same column, which is very awkward I think. Switching tabs to look for a new market, to then switch back after the market is changed isn't good. We should keep them separated as before. \r\n\r\nLayout 1 is the same as Layout 5 with a pinned order book on left, markets on right.\r\nLayout 2 is the same as Layout 5 with a pinned order book, but mirrored. \r\n\r\nA global option in Personalize should make it possible to set \"Mirror Panels\":Yes/No.\r\nBoth panels can be hidden independently.\r\n\r\n### Layout 3 and 4\r\nThese have Buy/Sell in the same column as markets, still awkward.\r\n\r\nI propose we put the forms in a left/right column, like order book in layout 1+2, if at all.\r\n\r\nWith a \"Pin Buy/Sell Form\" it could take the place for the order book in the side column. You can't pin both the form and the order book at the same time if you do this.\r\n\r\nA global option in Personalize should make it possible to set \"Mirror Panels\":Yes/No.\r\nBoth panels can be hidden independently.\r\n\r\n### Layout 5\r\nThis is the only layout left, which makes the selection option obsolete.\r\n\r\n## Combined Details\r\nPart of Layout 3+4 we have an option to combine/separate the details of market trades, my trades, open orders, settle orders.\r\n\r\nWhat we could do, is to make an option to combine when we have limited space. \r\n\r\nAn option in Personalize for \"Combine details in limited space\":\"Yes/No\".\r\n\r\nThis would combine the following in the following order as space gets smaller:\r\n1. Combine \"My Markets\" and \"Market Trades\". Combine \"My Open Orders\" and \"Settlement Orders\".\r\n2. Combine all four to one box. Combine Buy/Sell to a tabbed element.\r\n\r\nThis is one example on how to make it more dynamic. If the user chose \"No\", it will never combine and make it stack in a scrollable page, still nicer than today.\n\n**Requested hours: ~3-4 hours** "},"comment":{"url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/comments/426026289","html_url":"https://github.com/bitshares/bitshares-ui/issues/1888#issuecomment-426026289","issue_url":"https://api.github.com/repos/bitshares/bitshares-ui/issues/1888","id":426026289,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjAyNjI4OQ==","user":{"login":"wmbutler","id":1254810,"node_id":"MDQ6VXNlcjEyNTQ4MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/1254810?v=4","gravatar_id":"","url":"https://api.github.com/users/wmbutler","html_url":"https://github.com/wmbutler","followers_url":"https://api.github.com/users/wmbutler/followers","following_url":"https://api.github.com/users/wmbutler/following{/other_user}","gists_url":"https://api.github.com/users/wmbutler/gists{/gist_id}","starred_url":"https://api.github.com/users/wmbutler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmbutler/subscriptions","organizations_url":"https://api.github.com/users/wmbutler/orgs","repos_url":"https://api.github.com/users/wmbutler/repos","events_url":"https://api.github.com/users/wmbutler/events{/privacy}","received_events_url":"https://api.github.com/users/wmbutler/received_events","type":"User","site_admin":false},"created_at":"2018-10-01T19:07:52Z","updated_at":"2018-10-01T19:07:52Z","author_association":"CONTRIBUTOR","body":"I really appreciate best practices and I hear repeatedly that users are happy with Binance's approach to the exchange layout. If we were to limit layouts, I'd go with theirs by default. Fundamentally I think that:\r\n\r\n- My Trade History and Market Trade History can be the same column with a filter and can reside underneath My Markets on the right side\r\n- I agree that All Markets and My Markets is an awkward tabbed interface and can go away. I also feel that a distinction between My Markets and starred markets is redundant. If it has a star, I think it should imply that it is in My Market, otherwise, it's not.\r\n- Orderbook can be on the left side\r\n- Open orders needs it's own container\r\n\r\nThe groups are interesting but I think I'll need to see it in practice because the definition and placement of a \"Group\" is not immediately intuitive to me."}}
{"actor":{"display_login":"wmbutler"}}