{"action":"created","comment":{"url":"https://api.github.com/repos/magento/devdocs/pulls/comments/204565768","pull_request_review_id":139668640,"id":204565768,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDU2NTc2OA==","diff_hunk":"@@ -753,14 +753,26 @@ class SampleEventObserverThatModifiesInputs\n \n 15.6.3. Logs should not be excessive, e.g. PDO exception contains MySQL credentials that should not be logged.\n \n-15.7. CSRF protection.\n+15.7. Cross-Site Request Forgery (CSRF) protection.\n \n 15.7.1. CSRF tokens mechanism should be utilized.\n \n 15.7.2. All data manipulation requests should be made with POST requests.\n \n 15.8. Frequently update the third-party libraries used in the project/component to eliminate known vulnerabilities.\n \n+15.9. Local File Inclusion (LFI) protection.\n+\n+15.9.1. SHOULD NOT trust user-submitted requests containing path and file name.\n+\n+15.9.2. SHOULD sanitize user-submitted path and file values to remove dot-dot-slash from the request.\n+\n+15.10. Remote Code Execution (RCE) protection.\n+\n+15.10.1. SHOULD NOT use eval(), passthru(), system(), shell_exec(), serialize(), unserialize(), md5(), srand(), mt_srand()\n+\n+15.10.2. SHOULD NOT directly pass user-submitted values to include*(), require*(), create_function(), fopen(), preg_replace()\n+\n <!-- LINKS: DEFINITIONS AND ADDRESSES -->","path":"guides/v2.2/coding-standards/technical-guidelines.md","position":34,"original_position":34,"commit_id":"2d43f1f526ba75630dfa3612e52f1e42afc8d723","original_commit_id":"2d43f1f526ba75630dfa3612e52f1e42afc8d723","user":{"login":"melnikovi","id":9437495,"node_id":"MDQ6VXNlcjk0Mzc0OTU=","avatar_url":"https://avatars3.githubusercontent.com/u/9437495?v=4","gravatar_id":"","url":"https://api.github.com/users/melnikovi","html_url":"https://github.com/melnikovi","followers_url":"https://api.github.com/users/melnikovi/followers","following_url":"https://api.github.com/users/melnikovi/following{/other_user}","gists_url":"https://api.github.com/users/melnikovi/gists{/gist_id}","starred_url":"https://api.github.com/users/melnikovi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/melnikovi/subscriptions","organizations_url":"https://api.github.com/users/melnikovi/orgs","repos_url":"https://api.github.com/users/melnikovi/repos","events_url":"https://api.github.com/users/melnikovi/events{/privacy}","received_events_url":"https://api.github.com/users/melnikovi/received_events","type":"User","site_admin":false},"body":"If extension needs to write/modify files, these files should be located in directories application not trying to include/execute files from (pub/media, var). It's very tricky as sometimes attacks because possible as combination of multiple vulnerabilities. ","created_at":"2018-07-23T21:52:53Z","updated_at":"2018-07-23T21:52:53Z","html_url":"https://github.com/magento/devdocs/pull/2580#discussion_r204565768","pull_request_url":"https://api.github.com/repos/magento/devdocs/pulls/2580","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/magento/devdocs/pulls/comments/204565768"},"html":{"href":"https://github.com/magento/devdocs/pull/2580#discussion_r204565768"},"pull_request":{"href":"https://api.github.com/repos/magento/devdocs/pulls/2580"}},"in_reply_to_id":204560198},"pull_request":{"url":"https://api.github.com/repos/magento/devdocs/pulls/2580","id":203073235,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDczMjM1","html_url":"https://github.com/magento/devdocs/pull/2580","diff_url":"https://github.com/magento/devdocs/pull/2580.diff","patch_url":"https://github.com/magento/devdocs/pull/2580.patch","issue_url":"https://api.github.com/repos/magento/devdocs/issues/2580","number":2580,"state":"open","locked":false,"title":"LFI and RCE protection guidelines","user":{"login":"kalpmehta","id":9616066,"node_id":"MDQ6VXNlcjk2MTYwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9616066?v=4","gravatar_id":"","url":"https://api.github.com/users/kalpmehta","html_url":"https://github.com/kalpmehta","followers_url":"https://api.github.com/users/kalpmehta/followers","following_url":"https://api.github.com/users/kalpmehta/following{/other_user}","gists_url":"https://api.github.com/users/kalpmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/kalpmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalpmehta/subscriptions","organizations_url":"https://api.github.com/users/kalpmehta/orgs","repos_url":"https://api.github.com/users/kalpmehta/repos","events_url":"https://api.github.com/users/kalpmehta/events{/privacy}","received_events_url":"https://api.github.com/users/kalpmehta/received_events","type":"User","site_admin":false},"body":"LFI and RCE protection guidelines. Also formatted Security Guidelines.\r\n\r\n## This PR is a:\r\n\r\n- [ ] New topic\r\n- [x] Content update\r\n- [x] Content fix or rewrite\r\n- [ ] Bug fix or improvement\r\n\r\n## Summary\r\n\r\nIncludes LFI and RCE protection guidelines.","created_at":"2018-07-22T19:48:45Z","updated_at":"2018-07-23T21:52:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d14e28d8c60e83338f65280f458da1ac0aea0c2","assignee":{"login":"jeff-matthews","id":13662379,"node_id":"MDQ6VXNlcjEzNjYyMzc5","avatar_url":"https://avatars2.githubusercontent.com/u/13662379?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff-matthews","html_url":"https://github.com/jeff-matthews","followers_url":"https://api.github.com/users/jeff-matthews/followers","following_url":"https://api.github.com/users/jeff-matthews/following{/other_user}","gists_url":"https://api.github.com/users/jeff-matthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-matthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-matthews/subscriptions","organizations_url":"https://api.github.com/users/jeff-matthews/orgs","repos_url":"https://api.github.com/users/jeff-matthews/repos","events_url":"https://api.github.com/users/jeff-matthews/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-matthews/received_events","type":"User","site_admin":false},"assignees":[{"login":"jeff-matthews","id":13662379,"node_id":"MDQ6VXNlcjEzNjYyMzc5","avatar_url":"https://avatars2.githubusercontent.com/u/13662379?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff-matthews","html_url":"https://github.com/jeff-matthews","followers_url":"https://api.github.com/users/jeff-matthews/followers","following_url":"https://api.github.com/users/jeff-matthews/following{/other_user}","gists_url":"https://api.github.com/users/jeff-matthews/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff-matthews/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff-matthews/subscriptions","organizations_url":"https://api.github.com/users/jeff-matthews/orgs","repos_url":"https://api.github.com/users/jeff-matthews/repos","events_url":"https://api.github.com/users/jeff-matthews/events{/privacy}","received_events_url":"https://api.github.com/users/jeff-matthews/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"akaplya","id":2064499,"node_id":"MDQ6VXNlcjIwNjQ0OTk=","avatar_url":"https://avatars0.githubusercontent.com/u/2064499?v=4","gravatar_id":"","url":"https://api.github.com/users/akaplya","html_url":"https://github.com/akaplya","followers_url":"https://api.github.com/users/akaplya/followers","following_url":"https://api.github.com/users/akaplya/following{/other_user}","gists_url":"https://api.github.com/users/akaplya/gists{/gist_id}","starred_url":"https://api.github.com/users/akaplya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/akaplya/subscriptions","organizations_url":"https://api.github.com/users/akaplya/orgs","repos_url":"https://api.github.com/users/akaplya/repos","events_url":"https://api.github.com/users/akaplya/events{/privacy}","received_events_url":"https://api.github.com/users/akaplya/received_events","type":"User","site_admin":false},{"login":"DrewML","id":5233399,"node_id":"MDQ6VXNlcjUyMzMzOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5233399?v=4","gravatar_id":"","url":"https://api.github.com/users/DrewML","html_url":"https://github.com/DrewML","followers_url":"https://api.github.com/users/DrewML/followers","following_url":"https://api.github.com/users/DrewML/following{/other_user}","gists_url":"https://api.github.com/users/DrewML/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewML/subscriptions","organizations_url":"https://api.github.com/users/DrewML/orgs","repos_url":"https://api.github.com/users/DrewML/repos","events_url":"https://api.github.com/users/DrewML/events{/privacy}","received_events_url":"https://api.github.com/users/DrewML/received_events","type":"User","site_admin":false},{"login":"paliarush","id":10828073,"node_id":"MDQ6VXNlcjEwODI4MDcz","avatar_url":"https://avatars0.githubusercontent.com/u/10828073?v=4","gravatar_id":"","url":"https://api.github.com/users/paliarush","html_url":"https://github.com/paliarush","followers_url":"https://api.github.com/users/paliarush/followers","following_url":"https://api.github.com/users/paliarush/following{/other_user}","gists_url":"https://api.github.com/users/paliarush/gists{/gist_id}","starred_url":"https://api.github.com/users/paliarush/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paliarush/subscriptions","organizations_url":"https://api.github.com/users/paliarush/orgs","repos_url":"https://api.github.com/users/paliarush/repos","events_url":"https://api.github.com/users/paliarush/events{/privacy}","received_events_url":"https://api.github.com/users/paliarush/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/devdocs/pulls/2580/commits","review_comments_url":"https://api.github.com/repos/magento/devdocs/pulls/2580/comments","review_comment_url":"https://api.github.com/repos/magento/devdocs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/devdocs/issues/2580/comments","statuses_url":"https://api.github.com/repos/magento/devdocs/statuses/2d43f1f526ba75630dfa3612e52f1e42afc8d723","head":{"label":"kalpmehta:patch-3","ref":"patch-3","sha":"2d43f1f526ba75630dfa3612e52f1e42afc8d723","user":{"login":"kalpmehta","id":9616066,"node_id":"MDQ6VXNlcjk2MTYwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9616066?v=4","gravatar_id":"","url":"https://api.github.com/users/kalpmehta","html_url":"https://github.com/kalpmehta","followers_url":"https://api.github.com/users/kalpmehta/followers","following_url":"https://api.github.com/users/kalpmehta/following{/other_user}","gists_url":"https://api.github.com/users/kalpmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/kalpmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalpmehta/subscriptions","organizations_url":"https://api.github.com/users/kalpmehta/orgs","repos_url":"https://api.github.com/users/kalpmehta/repos","events_url":"https://api.github.com/users/kalpmehta/events{/privacy}","received_events_url":"https://api.github.com/users/kalpmehta/received_events","type":"User","site_admin":false},"repo":{"id":92204036,"node_id":"MDEwOlJlcG9zaXRvcnk5MjIwNDAzNg==","name":"devdocs","full_name":"kalpmehta/devdocs","owner":{"login":"kalpmehta","id":9616066,"node_id":"MDQ6VXNlcjk2MTYwNjY=","avatar_url":"https://avatars0.githubusercontent.com/u/9616066?v=4","gravatar_id":"","url":"https://api.github.com/users/kalpmehta","html_url":"https://github.com/kalpmehta","followers_url":"https://api.github.com/users/kalpmehta/followers","following_url":"https://api.github.com/users/kalpmehta/following{/other_user}","gists_url":"https://api.github.com/users/kalpmehta/gists{/gist_id}","starred_url":"https://api.github.com/users/kalpmehta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kalpmehta/subscriptions","organizations_url":"https://api.github.com/users/kalpmehta/orgs","repos_url":"https://api.github.com/users/kalpmehta/repos","events_url":"https://api.github.com/users/kalpmehta/events{/privacy}","received_events_url":"https://api.github.com/users/kalpmehta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kalpmehta/devdocs","description":"Magento Developer Documentation","fork":true,"url":"https://api.github.com/repos/kalpmehta/devdocs","forks_url":"https://api.github.com/repos/kalpmehta/devdocs/forks","keys_url":"https://api.github.com/repos/kalpmehta/devdocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kalpmehta/devdocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kalpmehta/devdocs/teams","hooks_url":"https://api.github.com/repos/kalpmehta/devdocs/hooks","issue_events_url":"https://api.github.com/repos/kalpmehta/devdocs/issues/events{/number}","events_url":"https://api.github.com/repos/kalpmehta/devdocs/events","assignees_url":"https://api.github.com/repos/kalpmehta/devdocs/assignees{/user}","branches_url":"https://api.github.com/repos/kalpmehta/devdocs/branches{/branch}","tags_url":"https://api.github.com/repos/kalpmehta/devdocs/tags","blobs_url":"https://api.github.com/repos/kalpmehta/devdocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kalpmehta/devdocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kalpmehta/devdocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/kalpmehta/devdocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kalpmehta/devdocs/statuses/{sha}","languages_url":"https://api.github.com/repos/kalpmehta/devdocs/languages","stargazers_url":"https://api.github.com/repos/kalpmehta/devdocs/stargazers","contributors_url":"https://api.github.com/repos/kalpmehta/devdocs/contributors","subscribers_url":"https://api.github.com/repos/kalpmehta/devdocs/subscribers","subscription_url":"https://api.github.com/repos/kalpmehta/devdocs/subscription","commits_url":"https://api.github.com/repos/kalpmehta/devdocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/kalpmehta/devdocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/kalpmehta/devdocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/kalpmehta/devdocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/kalpmehta/devdocs/contents/{+path}","compare_url":"https://api.github.com/repos/kalpmehta/devdocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kalpmehta/devdocs/merges","archive_url":"https://api.github.com/repos/kalpmehta/devdocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kalpmehta/devdocs/downloads","issues_url":"https://api.github.com/repos/kalpmehta/devdocs/issues{/number}","pulls_url":"https://api.github.com/repos/kalpmehta/devdocs/pulls{/number}","milestones_url":"https://api.github.com/repos/kalpmehta/devdocs/milestones{/number}","notifications_url":"https://api.github.com/repos/kalpmehta/devdocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kalpmehta/devdocs/labels{/name}","releases_url":"https://api.github.com/repos/kalpmehta/devdocs/releases{/id}","deployments_url":"https://api.github.com/repos/kalpmehta/devdocs/deployments","created_at":"2017-05-23T18:04:58Z","updated_at":"2017-05-23T18:05:11Z","pushed_at":"2018-07-23T20:55:51Z","git_url":"git://github.com/kalpmehta/devdocs.git","ssh_url":"git@github.com:kalpmehta/devdocs.git","clone_url":"https://github.com/kalpmehta/devdocs.git","svn_url":"https://github.com/kalpmehta/devdocs","homepage":"http://devdocs.magento.com","size":392394,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"magento:master","ref":"master","sha":"a9aaa8d376b1803872b03939e55a6f89684b6650","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":17608126,"node_id":"MDEwOlJlcG9zaXRvcnkxNzYwODEyNg==","name":"devdocs","full_name":"magento/devdocs","owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/magento/devdocs","description":"Magento Developer Documentation","fork":false,"url":"https://api.github.com/repos/magento/devdocs","forks_url":"https://api.github.com/repos/magento/devdocs/forks","keys_url":"https://api.github.com/repos/magento/devdocs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/devdocs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/devdocs/teams","hooks_url":"https://api.github.com/repos/magento/devdocs/hooks","issue_events_url":"https://api.github.com/repos/magento/devdocs/issues/events{/number}","events_url":"https://api.github.com/repos/magento/devdocs/events","assignees_url":"https://api.github.com/repos/magento/devdocs/assignees{/user}","branches_url":"https://api.github.com/repos/magento/devdocs/branches{/branch}","tags_url":"https://api.github.com/repos/magento/devdocs/tags","blobs_url":"https://api.github.com/repos/magento/devdocs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/devdocs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/devdocs/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/devdocs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/devdocs/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/devdocs/languages","stargazers_url":"https://api.github.com/repos/magento/devdocs/stargazers","contributors_url":"https://api.github.com/repos/magento/devdocs/contributors","subscribers_url":"https://api.github.com/repos/magento/devdocs/subscribers","subscription_url":"https://api.github.com/repos/magento/devdocs/subscription","commits_url":"https://api.github.com/repos/magento/devdocs/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/devdocs/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/devdocs/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/devdocs/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/devdocs/contents/{+path}","compare_url":"https://api.github.com/repos/magento/devdocs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/devdocs/merges","archive_url":"https://api.github.com/repos/magento/devdocs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/devdocs/downloads","issues_url":"https://api.github.com/repos/magento/devdocs/issues{/number}","pulls_url":"https://api.github.com/repos/magento/devdocs/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/devdocs/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/devdocs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/devdocs/labels{/name}","releases_url":"https://api.github.com/repos/magento/devdocs/releases{/id}","deployments_url":"https://api.github.com/repos/magento/devdocs/deployments","created_at":"2014-03-10T20:54:08Z","updated_at":"2018-07-23T20:39:24Z","pushed_at":"2018-07-23T21:31:17Z","git_url":"git://github.com/magento/devdocs.git","ssh_url":"git@github.com:magento/devdocs.git","clone_url":"https://github.com/magento/devdocs.git","svn_url":"https://github.com/magento/devdocs","homepage":"http://devdocs.magento.com","size":608725,"stargazers_count":336,"watchers_count":336,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":895,"mirror_url":null,"archived":false,"open_issues_count":150,"license":null,"forks":895,"open_issues":150,"watchers":336,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/devdocs/pulls/2580"},"html":{"href":"https://github.com/magento/devdocs/pull/2580"},"issue":{"href":"https://api.github.com/repos/magento/devdocs/issues/2580"},"comments":{"href":"https://api.github.com/repos/magento/devdocs/issues/2580/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/devdocs/pulls/2580/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/devdocs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/devdocs/pulls/2580/commits"},"statuses":{"href":"https://api.github.com/repos/magento/devdocs/statuses/2d43f1f526ba75630dfa3612e52f1e42afc8d723"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"melnikovi"}}