{"action":"created","comment":{"url":"https://api.github.com/repos/scipy/scipy/pulls/comments/196807554","pull_request_review_id":130428296,"id":196807554,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjgwNzU1NA==","diff_hunk":"@@ -0,0 +1,43 @@\n+\"\"\"\n+========================================================\n+Spatial Transformations (:mod:`scipy.spatial.transform`)\n+========================================================\n+\n+.. currentmodule:: scipy.spatial.transform\n+\n+This package implements various spatial transformations. For now,\n+only rotations are supported.\n+\n+Rotations in 3 dimensions\n+-------------------------\n+This package supports `Rotation` transforms with the following representations\n+\n+* Quaternions\n+* Discrete Cosine Matrices\n+* Euler angles\n+* Axis angle representation\n+\n+It also implements some useful algorithms such as\n+\n+* Quaternion slerp\n+* Quaternion spline\n+* Rotation estimation (Wahba's problem)\n+\n+Class Reference\n+---------------\n+\n+.. autosummary::\n+    :toctree: generated/\n+\n+    Rotation\n+\n+\"\"\"\n+from __future__ import division, print_function, absolute_import\n+\n+from .rotation import *\n+\n+__all__ = [s for s in dir() if not s.startswith('_')]","path":"scipy/spatial/transform/__init__.py","position":39,"original_position":39,"commit_id":"cbef71e0621bbd9c31d651c3445010e6a199840c","original_commit_id":"cbef71e0621bbd9c31d651c3445010e6a199840c","user":{"login":"larsoner","id":2365790,"node_id":"MDQ6VXNlcjIzNjU3OTA=","avatar_url":"https://avatars1.githubusercontent.com/u/2365790?v=4","gravatar_id":"","url":"https://api.github.com/users/larsoner","html_url":"https://github.com/larsoner","followers_url":"https://api.github.com/users/larsoner/followers","following_url":"https://api.github.com/users/larsoner/following{/other_user}","gists_url":"https://api.github.com/users/larsoner/gists{/gist_id}","starred_url":"https://api.github.com/users/larsoner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/larsoner/subscriptions","organizations_url":"https://api.github.com/users/larsoner/orgs","repos_url":"https://api.github.com/users/larsoner/repos","events_url":"https://api.github.com/users/larsoner/events{/privacy}","received_events_url":"https://api.github.com/users/larsoner/received_events","type":"User","site_admin":false},"body":"Here you might as well just do `__all__ = ['Rotation']`. The `*` import above will import many things without leading `_` that we do not want in `__all__`, such as `np`, `re`, etc. And even if you change that import, then `division`, `print_function`, `absolute_import` will still be in `__all__` (and the code here will have the problem that if someone else does such a `*` import in the future they will have this problem).\r\n\r\nAlthough the explicit list has some redundancy, it does not suffer from these problems.","created_at":"2018-06-20T14:38:43Z","updated_at":"2018-06-20T14:51:12Z","html_url":"https://github.com/scipy/scipy/pull/8945#discussion_r196807554","pull_request_url":"https://api.github.com/repos/scipy/scipy/pulls/8945","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments/196807554"},"html":{"href":"https://github.com/scipy/scipy/pull/8945#discussion_r196807554"},"pull_request":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8945"}}},"pull_request":{"url":"https://api.github.com/repos/scipy/scipy/pulls/8945","id":195980574,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1OTgwNTc0","html_url":"https://github.com/scipy/scipy/pull/8945","diff_url":"https://github.com/scipy/scipy/pull/8945.diff","patch_url":"https://github.com/scipy/scipy/pull/8945.patch","issue_url":"https://api.github.com/repos/scipy/scipy/issues/8945","number":8945,"state":"open","locked":false,"title":"Initial Pull Request for Rotation class","user":{"login":"adbugger","id":15844796,"node_id":"MDQ6VXNlcjE1ODQ0Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/15844796?v=4","gravatar_id":"","url":"https://api.github.com/users/adbugger","html_url":"https://github.com/adbugger","followers_url":"https://api.github.com/users/adbugger/followers","following_url":"https://api.github.com/users/adbugger/following{/other_user}","gists_url":"https://api.github.com/users/adbugger/gists{/gist_id}","starred_url":"https://api.github.com/users/adbugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbugger/subscriptions","organizations_url":"https://api.github.com/users/adbugger/orgs","repos_url":"https://api.github.com/users/adbugger/repos","events_url":"https://api.github.com/users/adbugger/events{/privacy}","received_events_url":"https://api.github.com/users/adbugger/received_events","type":"User","site_admin":false},"body":"This pull request implements, documents, and tests the following features to the `Rotation` class under a new sub-package `scipy.spatial.transform`:\r\n- Initializers from and converters to quaternions, direction cosine matrices, euler angles and rotation vector representations of rotations\r\n- Application of a rotation to vectors\r\n- Inversion and composition of rotations\r\n- Indexing into a `Rotation` object to extract specific rotation(s)","created_at":"2018-06-19T22:57:40Z","updated_at":"2018-06-20T14:51:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"99f143e7e14e9f1d189a2c44ed2710e58f0939b9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nmayorov","id":7074023,"node_id":"MDQ6VXNlcjcwNzQwMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/7074023?v=4","gravatar_id":"","url":"https://api.github.com/users/nmayorov","html_url":"https://github.com/nmayorov","followers_url":"https://api.github.com/users/nmayorov/followers","following_url":"https://api.github.com/users/nmayorov/following{/other_user}","gists_url":"https://api.github.com/users/nmayorov/gists{/gist_id}","starred_url":"https://api.github.com/users/nmayorov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nmayorov/subscriptions","organizations_url":"https://api.github.com/users/nmayorov/orgs","repos_url":"https://api.github.com/users/nmayorov/repos","events_url":"https://api.github.com/users/nmayorov/events{/privacy}","received_events_url":"https://api.github.com/users/nmayorov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":37340735,"node_id":"MDU6TGFiZWwzNzM0MDczNQ==","url":"https://api.github.com/repos/scipy/scipy/labels/enhancement","name":"enhancement","color":"bfe5bf","default":true},{"id":37345293,"node_id":"MDU6TGFiZWwzNzM0NTI5Mw==","url":"https://api.github.com/repos/scipy/scipy/labels/scipy.spatial","name":"scipy.spatial","color":"207de5","default":false}],"milestone":{"url":"https://api.github.com/repos/scipy/scipy/milestones/36","html_url":"https://github.com/scipy/scipy/milestone/36","labels_url":"https://api.github.com/repos/scipy/scipy/milestones/36/labels","id":3257163,"node_id":"MDk6TWlsZXN0b25lMzI1NzE2Mw==","number":36,"title":"1.2.0","description":"","creator":{"login":"pv","id":35046,"node_id":"MDQ6VXNlcjM1MDQ2","avatar_url":"https://avatars1.githubusercontent.com/u/35046?v=4","gravatar_id":"","url":"https://api.github.com/users/pv","html_url":"https://github.com/pv","followers_url":"https://api.github.com/users/pv/followers","following_url":"https://api.github.com/users/pv/following{/other_user}","gists_url":"https://api.github.com/users/pv/gists{/gist_id}","starred_url":"https://api.github.com/users/pv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pv/subscriptions","organizations_url":"https://api.github.com/users/pv/orgs","repos_url":"https://api.github.com/users/pv/repos","events_url":"https://api.github.com/users/pv/events{/privacy}","received_events_url":"https://api.github.com/users/pv/received_events","type":"User","site_admin":false},"open_issues":30,"closed_issues":59,"state":"open","created_at":"2018-04-10T20:26:02Z","updated_at":"2018-06-20T13:28:02Z","due_on":"2018-11-09T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/scipy/scipy/pulls/8945/commits","review_comments_url":"https://api.github.com/repos/scipy/scipy/pulls/8945/comments","review_comment_url":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scipy/scipy/issues/8945/comments","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/cbef71e0621bbd9c31d651c3445010e6a199840c","head":{"label":"adbugger:rotation","ref":"rotation","sha":"cbef71e0621bbd9c31d651c3445010e6a199840c","user":{"login":"adbugger","id":15844796,"node_id":"MDQ6VXNlcjE1ODQ0Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/15844796?v=4","gravatar_id":"","url":"https://api.github.com/users/adbugger","html_url":"https://github.com/adbugger","followers_url":"https://api.github.com/users/adbugger/followers","following_url":"https://api.github.com/users/adbugger/following{/other_user}","gists_url":"https://api.github.com/users/adbugger/gists{/gist_id}","starred_url":"https://api.github.com/users/adbugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbugger/subscriptions","organizations_url":"https://api.github.com/users/adbugger/orgs","repos_url":"https://api.github.com/users/adbugger/repos","events_url":"https://api.github.com/users/adbugger/events{/privacy}","received_events_url":"https://api.github.com/users/adbugger/received_events","type":"User","site_admin":false},"repo":{"id":121636791,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE2MzY3OTE=","name":"scipy","full_name":"adbugger/scipy","owner":{"login":"adbugger","id":15844796,"node_id":"MDQ6VXNlcjE1ODQ0Nzk2","avatar_url":"https://avatars1.githubusercontent.com/u/15844796?v=4","gravatar_id":"","url":"https://api.github.com/users/adbugger","html_url":"https://github.com/adbugger","followers_url":"https://api.github.com/users/adbugger/followers","following_url":"https://api.github.com/users/adbugger/following{/other_user}","gists_url":"https://api.github.com/users/adbugger/gists{/gist_id}","starred_url":"https://api.github.com/users/adbugger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adbugger/subscriptions","organizations_url":"https://api.github.com/users/adbugger/orgs","repos_url":"https://api.github.com/users/adbugger/repos","events_url":"https://api.github.com/users/adbugger/events{/privacy}","received_events_url":"https://api.github.com/users/adbugger/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/adbugger/scipy","description":"Scipy library main repository","fork":true,"url":"https://api.github.com/repos/adbugger/scipy","forks_url":"https://api.github.com/repos/adbugger/scipy/forks","keys_url":"https://api.github.com/repos/adbugger/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/adbugger/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/adbugger/scipy/teams","hooks_url":"https://api.github.com/repos/adbugger/scipy/hooks","issue_events_url":"https://api.github.com/repos/adbugger/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/adbugger/scipy/events","assignees_url":"https://api.github.com/repos/adbugger/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/adbugger/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/adbugger/scipy/tags","blobs_url":"https://api.github.com/repos/adbugger/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/adbugger/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/adbugger/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/adbugger/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/adbugger/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/adbugger/scipy/languages","stargazers_url":"https://api.github.com/repos/adbugger/scipy/stargazers","contributors_url":"https://api.github.com/repos/adbugger/scipy/contributors","subscribers_url":"https://api.github.com/repos/adbugger/scipy/subscribers","subscription_url":"https://api.github.com/repos/adbugger/scipy/subscription","commits_url":"https://api.github.com/repos/adbugger/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/adbugger/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/adbugger/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/adbugger/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/adbugger/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/adbugger/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/adbugger/scipy/merges","archive_url":"https://api.github.com/repos/adbugger/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/adbugger/scipy/downloads","issues_url":"https://api.github.com/repos/adbugger/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/adbugger/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/adbugger/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/adbugger/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/adbugger/scipy/labels{/name}","releases_url":"https://api.github.com/repos/adbugger/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/adbugger/scipy/deployments","created_at":"2018-02-15T14:07:00Z","updated_at":"2018-06-08T02:21:06Z","pushed_at":"2018-06-19T22:49:07Z","git_url":"git://github.com/adbugger/scipy.git","ssh_url":"git@github.com:adbugger/scipy.git","clone_url":"https://github.com/adbugger/scipy.git","svn_url":"https://github.com/adbugger/scipy","homepage":"http://scipy.org/scipylib/","size":78305,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"scipy:master","ref":"master","sha":"2597c46fa47dd60b86c8ddfaf3da8b6d1c7b67f0","user":{"login":"scipy","id":288277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"repo":{"id":1460385,"node_id":"MDEwOlJlcG9zaXRvcnkxNDYwMzg1","name":"scipy","full_name":"scipy/scipy","owner":{"login":"scipy","id":288277,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4ODI3Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/288277?v=4","gravatar_id":"","url":"https://api.github.com/users/scipy","html_url":"https://github.com/scipy","followers_url":"https://api.github.com/users/scipy/followers","following_url":"https://api.github.com/users/scipy/following{/other_user}","gists_url":"https://api.github.com/users/scipy/gists{/gist_id}","starred_url":"https://api.github.com/users/scipy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scipy/subscriptions","organizations_url":"https://api.github.com/users/scipy/orgs","repos_url":"https://api.github.com/users/scipy/repos","events_url":"https://api.github.com/users/scipy/events{/privacy}","received_events_url":"https://api.github.com/users/scipy/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scipy/scipy","description":"Scipy library main repository","fork":false,"url":"https://api.github.com/repos/scipy/scipy","forks_url":"https://api.github.com/repos/scipy/scipy/forks","keys_url":"https://api.github.com/repos/scipy/scipy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scipy/scipy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scipy/scipy/teams","hooks_url":"https://api.github.com/repos/scipy/scipy/hooks","issue_events_url":"https://api.github.com/repos/scipy/scipy/issues/events{/number}","events_url":"https://api.github.com/repos/scipy/scipy/events","assignees_url":"https://api.github.com/repos/scipy/scipy/assignees{/user}","branches_url":"https://api.github.com/repos/scipy/scipy/branches{/branch}","tags_url":"https://api.github.com/repos/scipy/scipy/tags","blobs_url":"https://api.github.com/repos/scipy/scipy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scipy/scipy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scipy/scipy/git/refs{/sha}","trees_url":"https://api.github.com/repos/scipy/scipy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scipy/scipy/statuses/{sha}","languages_url":"https://api.github.com/repos/scipy/scipy/languages","stargazers_url":"https://api.github.com/repos/scipy/scipy/stargazers","contributors_url":"https://api.github.com/repos/scipy/scipy/contributors","subscribers_url":"https://api.github.com/repos/scipy/scipy/subscribers","subscription_url":"https://api.github.com/repos/scipy/scipy/subscription","commits_url":"https://api.github.com/repos/scipy/scipy/commits{/sha}","git_commits_url":"https://api.github.com/repos/scipy/scipy/git/commits{/sha}","comments_url":"https://api.github.com/repos/scipy/scipy/comments{/number}","issue_comment_url":"https://api.github.com/repos/scipy/scipy/issues/comments{/number}","contents_url":"https://api.github.com/repos/scipy/scipy/contents/{+path}","compare_url":"https://api.github.com/repos/scipy/scipy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scipy/scipy/merges","archive_url":"https://api.github.com/repos/scipy/scipy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scipy/scipy/downloads","issues_url":"https://api.github.com/repos/scipy/scipy/issues{/number}","pulls_url":"https://api.github.com/repos/scipy/scipy/pulls{/number}","milestones_url":"https://api.github.com/repos/scipy/scipy/milestones{/number}","notifications_url":"https://api.github.com/repos/scipy/scipy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scipy/scipy/labels{/name}","releases_url":"https://api.github.com/repos/scipy/scipy/releases{/id}","deployments_url":"https://api.github.com/repos/scipy/scipy/deployments","created_at":"2011-03-09T18:52:03Z","updated_at":"2018-06-20T12:15:55Z","pushed_at":"2018-06-20T08:37:08Z","git_url":"git://github.com/scipy/scipy.git","ssh_url":"git@github.com:scipy/scipy.git","clone_url":"https://github.com/scipy/scipy.git","svn_url":"https://github.com/scipy/scipy","homepage":"https://scipy.org/scipylib/","size":80668,"stargazers_count":4565,"watchers_count":4565,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2361,"mirror_url":null,"archived":false,"open_issues_count":1261,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2361,"open_issues":1261,"watchers":4565,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8945"},"html":{"href":"https://github.com/scipy/scipy/pull/8945"},"issue":{"href":"https://api.github.com/repos/scipy/scipy/issues/8945"},"comments":{"href":"https://api.github.com/repos/scipy/scipy/issues/8945/comments"},"review_comments":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8945/comments"},"review_comment":{"href":"https://api.github.com/repos/scipy/scipy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scipy/scipy/pulls/8945/commits"},"statuses":{"href":"https://api.github.com/repos/scipy/scipy/statuses/cbef71e0621bbd9c31d651c3445010e6a199840c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"larsoner"}}