{"action":"closed","number":953,"pull_request":{"url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls/953","id":167826986,"html_url":"https://github.com/ChatSecure/ChatSecure-iOS/pull/953","diff_url":"https://github.com/ChatSecure/ChatSecure-iOS/pull/953.diff","patch_url":"https://github.com/ChatSecure/ChatSecure-iOS/pull/953.patch","issue_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/issues/953","number":953,"state":"closed","locked":false,"title":"WIP: More occupant fixes","user":{"login":"N-Pex","id":5418622,"avatar_url":"https://avatars0.githubusercontent.com/u/5418622?v=4","gravatar_id":"","url":"https://api.github.com/users/N-Pex","html_url":"https://github.com/N-Pex","followers_url":"https://api.github.com/users/N-Pex/followers","following_url":"https://api.github.com/users/N-Pex/following{/other_user}","gists_url":"https://api.github.com/users/N-Pex/gists{/gist_id}","starred_url":"https://api.github.com/users/N-Pex/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/N-Pex/subscriptions","organizations_url":"https://api.github.com/users/N-Pex/orgs","repos_url":"https://api.github.com/users/N-Pex/repos","events_url":"https://api.github.com/users/N-Pex/events{/privacy}","received_events_url":"https://api.github.com/users/N-Pex/received_events","type":"User","site_admin":false},"body":"Sigh, now after these changes, hanging on to the jid:s, I wonder if we maybe should have sticked to having XMPPRoomOccupant as an occupant and not a container object...  Ah well. Consider this Work In Progress, still stuff to do here, but mostly wanted to see how you like the idea of storing online/offline in the buddy cache (which nowadays is a bit of a misnomer)?\r\n\r\nAlso in this PR - delay fetching the history until we are done getting room members, admins and owners. Currently really only works in theory since we 1. Use old-school history elements and 2. Fetch MAM history for everything when we connect to the server, so the results will come \"too early\".","created_at":"2018-02-07T22:28:12Z","updated_at":"2018-02-12T21:12:09Z","closed_at":"2018-02-12T21:12:09Z","merged_at":null,"merge_commit_sha":"e96c517543b68a8ddc41e7957436a1fb6aaa0392","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls/953/commits","review_comments_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls/953/comments","review_comment_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/issues/953/comments","statuses_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/statuses/254bfecb5592490f3971be5224ad29fd8258d1dc","head":{"label":"zom:more_occupant_fixes","ref":"more_occupant_fixes","sha":"254bfecb5592490f3971be5224ad29fd8258d1dc","user":{"login":"zom","id":14287777,"avatar_url":"https://avatars3.githubusercontent.com/u/14287777?v=4","gravatar_id":"","url":"https://api.github.com/users/zom","html_url":"https://github.com/zom","followers_url":"https://api.github.com/users/zom/followers","following_url":"https://api.github.com/users/zom/following{/other_user}","gists_url":"https://api.github.com/users/zom/gists{/gist_id}","starred_url":"https://api.github.com/users/zom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zom/subscriptions","organizations_url":"https://api.github.com/users/zom/orgs","repos_url":"https://api.github.com/users/zom/repos","events_url":"https://api.github.com/users/zom/events{/privacy}","received_events_url":"https://api.github.com/users/zom/received_events","type":"Organization","site_admin":false},"repo":{"id":66939417,"name":"ChatSecure-iOS","full_name":"zom/ChatSecure-iOS","owner":{"login":"zom","id":14287777,"avatar_url":"https://avatars3.githubusercontent.com/u/14287777?v=4","gravatar_id":"","url":"https://api.github.com/users/zom","html_url":"https://github.com/zom","followers_url":"https://api.github.com/users/zom/followers","following_url":"https://api.github.com/users/zom/following{/other_user}","gists_url":"https://api.github.com/users/zom/gists{/gist_id}","starred_url":"https://api.github.com/users/zom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zom/subscriptions","organizations_url":"https://api.github.com/users/zom/orgs","repos_url":"https://api.github.com/users/zom/repos","events_url":"https://api.github.com/users/zom/events{/privacy}","received_events_url":"https://api.github.com/users/zom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zom/ChatSecure-iOS","description":"ChatSecure is a free and open source encrypted chat client for iPhone and Android that supports OTR encryption over XMPP.","fork":true,"url":"https://api.github.com/repos/zom/ChatSecure-iOS","forks_url":"https://api.github.com/repos/zom/ChatSecure-iOS/forks","keys_url":"https://api.github.com/repos/zom/ChatSecure-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zom/ChatSecure-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zom/ChatSecure-iOS/teams","hooks_url":"https://api.github.com/repos/zom/ChatSecure-iOS/hooks","issue_events_url":"https://api.github.com/repos/zom/ChatSecure-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/zom/ChatSecure-iOS/events","assignees_url":"https://api.github.com/repos/zom/ChatSecure-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/zom/ChatSecure-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/zom/ChatSecure-iOS/tags","blobs_url":"https://api.github.com/repos/zom/ChatSecure-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zom/ChatSecure-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zom/ChatSecure-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/zom/ChatSecure-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zom/ChatSecure-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/zom/ChatSecure-iOS/languages","stargazers_url":"https://api.github.com/repos/zom/ChatSecure-iOS/stargazers","contributors_url":"https://api.github.com/repos/zom/ChatSecure-iOS/contributors","subscribers_url":"https://api.github.com/repos/zom/ChatSecure-iOS/subscribers","subscription_url":"https://api.github.com/repos/zom/ChatSecure-iOS/subscription","commits_url":"https://api.github.com/repos/zom/ChatSecure-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/zom/ChatSecure-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/zom/ChatSecure-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/zom/ChatSecure-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/zom/ChatSecure-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/zom/ChatSecure-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zom/ChatSecure-iOS/merges","archive_url":"https://api.github.com/repos/zom/ChatSecure-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zom/ChatSecure-iOS/downloads","issues_url":"https://api.github.com/repos/zom/ChatSecure-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/zom/ChatSecure-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/zom/ChatSecure-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/zom/ChatSecure-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zom/ChatSecure-iOS/labels{/name}","releases_url":"https://api.github.com/repos/zom/ChatSecure-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/zom/ChatSecure-iOS/deployments","created_at":"2016-08-30T12:41:34Z","updated_at":"2016-08-30T12:41:38Z","pushed_at":"2018-02-12T21:07:38Z","git_url":"git://github.com/zom/ChatSecure-iOS.git","ssh_url":"git@github.com:zom/ChatSecure-iOS.git","clone_url":"https://github.com/zom/ChatSecure-iOS.git","svn_url":"https://github.com/zom/ChatSecure-iOS","homepage":"https://chatsecure.org","size":47027,"stargazers_count":0,"watchers_count":0,"language":"Objective-C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":2,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"ChatSecure:xep_0313","ref":"xep_0313","sha":"4a1f502408abe55e7401ab4b1a5a6c3cc963a1ac","user":{"login":"ChatSecure","id":1697368,"avatar_url":"https://avatars3.githubusercontent.com/u/1697368?v=4","gravatar_id":"","url":"https://api.github.com/users/ChatSecure","html_url":"https://github.com/ChatSecure","followers_url":"https://api.github.com/users/ChatSecure/followers","following_url":"https://api.github.com/users/ChatSecure/following{/other_user}","gists_url":"https://api.github.com/users/ChatSecure/gists{/gist_id}","starred_url":"https://api.github.com/users/ChatSecure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChatSecure/subscriptions","organizations_url":"https://api.github.com/users/ChatSecure/orgs","repos_url":"https://api.github.com/users/ChatSecure/repos","events_url":"https://api.github.com/users/ChatSecure/events{/privacy}","received_events_url":"https://api.github.com/users/ChatSecure/received_events","type":"Organization","site_admin":false},"repo":{"id":2195601,"name":"ChatSecure-iOS","full_name":"ChatSecure/ChatSecure-iOS","owner":{"login":"ChatSecure","id":1697368,"avatar_url":"https://avatars3.githubusercontent.com/u/1697368?v=4","gravatar_id":"","url":"https://api.github.com/users/ChatSecure","html_url":"https://github.com/ChatSecure","followers_url":"https://api.github.com/users/ChatSecure/followers","following_url":"https://api.github.com/users/ChatSecure/following{/other_user}","gists_url":"https://api.github.com/users/ChatSecure/gists{/gist_id}","starred_url":"https://api.github.com/users/ChatSecure/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChatSecure/subscriptions","organizations_url":"https://api.github.com/users/ChatSecure/orgs","repos_url":"https://api.github.com/users/ChatSecure/repos","events_url":"https://api.github.com/users/ChatSecure/events{/privacy}","received_events_url":"https://api.github.com/users/ChatSecure/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ChatSecure/ChatSecure-iOS","description":"ChatSecure is a free and open source encrypted chat client for iOS that supports OTR and OMEMO encryption over XMPP.","fork":false,"url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS","forks_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/forks","keys_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/teams","hooks_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/hooks","issue_events_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/issues/events{/number}","events_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/events","assignees_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/assignees{/user}","branches_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/branches{/branch}","tags_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/tags","blobs_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/git/refs{/sha}","trees_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/statuses/{sha}","languages_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/languages","stargazers_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/stargazers","contributors_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/contributors","subscribers_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/subscribers","subscription_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/subscription","commits_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/commits{/sha}","git_commits_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/git/commits{/sha}","comments_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/comments{/number}","issue_comment_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/issues/comments{/number}","contents_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/contents/{+path}","compare_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/merges","archive_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/downloads","issues_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/issues{/number}","pulls_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls{/number}","milestones_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/milestones{/number}","notifications_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/labels{/name}","releases_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/releases{/id}","deployments_url":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/deployments","created_at":"2011-08-12T06:07:51Z","updated_at":"2018-02-11T10:32:04Z","pushed_at":"2018-02-12T21:10:41Z","git_url":"git://github.com/ChatSecure/ChatSecure-iOS.git","ssh_url":"git@github.com:ChatSecure/ChatSecure-iOS.git","clone_url":"https://github.com/ChatSecure/ChatSecure-iOS.git","svn_url":"https://github.com/ChatSecure/ChatSecure-iOS","homepage":"https://chatsecure.org","size":47103,"stargazers_count":2542,"watchers_count":2542,"language":"Objective-C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":922,"mirror_url":null,"archived":false,"open_issues_count":223,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":922,"open_issues":223,"watchers":2542,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls/953"},"html":{"href":"https://github.com/ChatSecure/ChatSecure-iOS/pull/953"},"issue":{"href":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/issues/953"},"comments":{"href":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/issues/953/comments"},"review_comments":{"href":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls/953/comments"},"review_comment":{"href":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/pulls/953/commits"},"statuses":{"href":"https://api.github.com/repos/ChatSecure/ChatSecure-iOS/statuses/254bfecb5592490f3971be5224ad29fd8258d1dc"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":136,"deletions":71,"changed_files":7}}
{"actor":{"display_login":"chrisballinger"}}