{"action":"created","issue":{"url":"https://api.github.com/repos/Sable/soot/issues/954","repository_url":"https://api.github.com/repos/Sable/soot","labels_url":"https://api.github.com/repos/Sable/soot/issues/954/labels{/name}","comments_url":"https://api.github.com/repos/Sable/soot/issues/954/comments","events_url":"https://api.github.com/repos/Sable/soot/issues/954/events","html_url":"https://github.com/Sable/soot/pull/954","id":330664579,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjE4ODUx","number":954,"title":"Test struct. equivalence in equivTo of JimpleLocal","user":{"login":"gandreadis","id":5272244,"node_id":"MDQ6VXNlcjUyNzIyNDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/5272244?v=4","gravatar_id":"","url":"https://api.github.com/users/gandreadis","html_url":"https://github.com/gandreadis","followers_url":"https://api.github.com/users/gandreadis/followers","following_url":"https://api.github.com/users/gandreadis/following{/other_user}","gists_url":"https://api.github.com/users/gandreadis/gists{/gist_id}","starred_url":"https://api.github.com/users/gandreadis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gandreadis/subscriptions","organizations_url":"https://api.github.com/users/gandreadis/orgs","repos_url":"https://api.github.com/users/gandreadis/repos","events_url":"https://api.github.com/users/gandreadis/events{/privacy}","received_events_url":"https://api.github.com/users/gandreadis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-06-08T13:45:38Z","updated_at":"2018-06-11T11:47:05Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Sable/soot/pulls/954","html_url":"https://github.com/Sable/soot/pull/954","diff_url":"https://github.com/Sable/soot/pull/954.diff","patch_url":"https://github.com/Sable/soot/pull/954.patch"},"body":"The JimpleLocal class has an `equivTo` and an `equivHashCode` method. Both claim to test for structural equality (as described in their Javadocs). However, as mentioned in #953, this is not actually the case. This change replaces the referential equality check with a type equality check.\r\n\r\nCloses #953."},"comment":{"url":"https://api.github.com/repos/Sable/soot/issues/comments/396215688","html_url":"https://github.com/Sable/soot/pull/954#issuecomment-396215688","issue_url":"https://api.github.com/repos/Sable/soot/issues/954","id":396215688,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjIxNTY4OA==","user":{"login":"mbenz89","id":7669513,"node_id":"MDQ6VXNlcjc2Njk1MTM=","avatar_url":"https://avatars0.githubusercontent.com/u/7669513?v=4","gravatar_id":"","url":"https://api.github.com/users/mbenz89","html_url":"https://github.com/mbenz89","followers_url":"https://api.github.com/users/mbenz89/followers","following_url":"https://api.github.com/users/mbenz89/following{/other_user}","gists_url":"https://api.github.com/users/mbenz89/gists{/gist_id}","starred_url":"https://api.github.com/users/mbenz89/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbenz89/subscriptions","organizations_url":"https://api.github.com/users/mbenz89/orgs","repos_url":"https://api.github.com/users/mbenz89/repos","events_url":"https://api.github.com/users/mbenz89/events{/privacy}","received_events_url":"https://api.github.com/users/mbenz89/received_events","type":"User","site_admin":false},"created_at":"2018-06-11T11:47:05Z","updated_at":"2018-06-11T11:47:05Z","author_association":"CONTRIBUTOR","body":"I would rather not mess with this. At least not without being sure about the consequences of such a change.\r\n\r\nCan't you use something like this:\r\n```\r\n  private boolean compareValueTypes(Stmt first, Stmt sec) {\r\n    final List<Type> firstTypes = first.getUseBoxes().stream().map(v -> v.getValue().getType()).collect(Collectors.toList());\r\n    final List<Type> secTypes = sec.getUseBoxes().stream().map(v -> v.getValue().getType()).collect(Collectors.toList());\r\n    return firstTypes.equals(secTypes);\r\n  }\r\n```"}}
{"actor":{"display_login":"mbenz89"}}