{"action":"created","issue":{"url":"https://api.github.com/repos/aspnet/Blazor/issues/444","repository_url":"https://api.github.com/repos/aspnet/Blazor","labels_url":"https://api.github.com/repos/aspnet/Blazor/issues/444/labels{/name}","comments_url":"https://api.github.com/repos/aspnet/Blazor/issues/444/comments","events_url":"https://api.github.com/repos/aspnet/Blazor/issues/444/events","html_url":"https://github.com/aspnet/Blazor/pull/444","id":309987750,"number":444,"title":"[wip] possible approach for conditional attributes","user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-03-30T06:32:25Z","updated_at":"2018-04-03T04:37:20Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/aspnet/Blazor/pulls/444","html_url":"https://github.com/aspnet/Blazor/pull/444","diff_url":"https://github.com/aspnet/Blazor/pull/444.diff","patch_url":"https://github.com/aspnet/Blazor/pull/444.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/aspnet/Blazor/issues/comments/378125866","html_url":"https://github.com/aspnet/Blazor/pull/444#issuecomment-378125866","issue_url":"https://api.github.com/repos/aspnet/Blazor/issues/444","id":378125866,"user":{"login":"rynowak","id":1430011,"avatar_url":"https://avatars1.githubusercontent.com/u/1430011?v=4","gravatar_id":"","url":"https://api.github.com/users/rynowak","html_url":"https://github.com/rynowak","followers_url":"https://api.github.com/users/rynowak/followers","following_url":"https://api.github.com/users/rynowak/following{/other_user}","gists_url":"https://api.github.com/users/rynowak/gists{/gist_id}","starred_url":"https://api.github.com/users/rynowak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rynowak/subscriptions","organizations_url":"https://api.github.com/users/rynowak/orgs","repos_url":"https://api.github.com/users/rynowak/repos","events_url":"https://api.github.com/users/rynowak/events{/privacy}","received_events_url":"https://api.github.com/users/rynowak/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T04:37:20Z","updated_at":"2018-04-03T04:37:20Z","author_association":"MEMBER","body":"Here's more data with outlining of the attribute case from `AppendDiffEntriesForFramesWithSameSequence` - I think it's a small improvement, but I think it's a good change in general since attributes mostly have their own code path\r\n\r\n``` ini\r\n\r\nBenchmarkDotNet=v0.10.13, OS=Windows 10 Redstone 3 [1709, Fall Creators Update] (10.0.16299.309)\r\nIntel Core i7 CPU 950 3.07GHz (Nehalem), 1 CPU, 8 logical cores and 4 physical cores\r\nFrequency=3030835 Hz, Resolution=329.9421 ns, Timer=TSC\r\n.NET Core SDK=2.1.300-preview2-008322\r\n  [Host]     : .NET Core 2.0.6 (CoreCLR 4.6.26212.01, CoreFX 4.6.26212.01), 64bit RyuJIT\r\n  Job-KJRAYN : .NET Core 2.1.0-preview2-26308-01 (CoreCLR 4.6.26307.01, CoreFX 4.6.26308.02), 64bit RyuJIT\r\n\r\nRuntime=Core  Server=True  Toolchain=.NET Core 2.1  \r\nRunStrategy=Throughput  \r\n\r\n```\r\n|                                                                Method |     Mean |     Error |    StdDev |      Op/s | Scaled | ScaledSD | Allocated |\r\n|---------------------------------------------------------------------- |---------:|----------:|----------:|----------:|-------:|---------:|----------:|\r\n| &#39;RenderTreeDiffBuilder: Input and validation on a single form field.&#39; | 2.980 us | 0.0090 us | 0.0071 us | 335,582.8 |   1.00 |     0.00 |      40 B |\r\n|                              &#39;RenderTreeDiffBuilder: With Fast Path.&#39; | 1.546 us | 0.0413 us | 0.0387 us | 647,028.7 |   0.52 |     0.01 |      40 B |\r\n|                &#39;RenderTreeDiffBuilder: With Fast Path and outlining.&#39; | 1.475 us | 0.0421 us | 0.0591 us | 678,114.6 |   0.49 |     0.02 |      40 B |"}}
{"actor":{"display_login":"rynowak"}}