{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/57625","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/57625/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/57625/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/57625/events","html_url":"https://github.com/Microsoft/vscode/pull/57625","id":355631823,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyMTE1Njgz","number":57625,"title":"expose waitOnExit in vscode.TerminalOptions for extensions","user":{"login":"tdyas","id":901363,"node_id":"MDQ6VXNlcjkwMTM2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/901363?v=4","gravatar_id":"","url":"https://api.github.com/users/tdyas","html_url":"https://github.com/tdyas","followers_url":"https://api.github.com/users/tdyas/followers","following_url":"https://api.github.com/users/tdyas/following{/other_user}","gists_url":"https://api.github.com/users/tdyas/gists{/gist_id}","starred_url":"https://api.github.com/users/tdyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdyas/subscriptions","organizations_url":"https://api.github.com/users/tdyas/orgs","repos_url":"https://api.github.com/users/tdyas/repos","events_url":"https://api.github.com/users/tdyas/events{/privacy}","received_events_url":"https://api.github.com/users/tdyas/received_events","type":"User","site_admin":false},"labels":[{"id":272689423,"node_id":"MDU6TGFiZWwyNzI2ODk0MjM=","url":"https://api.github.com/repos/Microsoft/vscode/labels/needs%20more%20info","name":"needs more info","color":"E2A1C2","default":false}],"state":"open","locked":false,"assignee":{"login":"Tyriar","id":2193314,"node_id":"MDQ6VXNlcjIxOTMzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false},"assignees":[{"login":"Tyriar","id":2193314,"node_id":"MDQ6VXNlcjIxOTMzMTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-08-30T15:14:07Z","updated_at":"2018-08-31T23:38:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Microsoft/vscode/pulls/57625","html_url":"https://github.com/Microsoft/vscode/pull/57625","diff_url":"https://github.com/Microsoft/vscode/pull/57625.diff","patch_url":"https://github.com/Microsoft/vscode/pull/57625.patch"},"body":"This PR exposes to extensions the the existing `waitOnExit` attribute on terminals."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/417814369","html_url":"https://github.com/Microsoft/vscode/pull/57625#issuecomment-417814369","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/57625","id":417814369,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNzgxNDM2OQ==","user":{"login":"tdyas","id":901363,"node_id":"MDQ6VXNlcjkwMTM2Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/901363?v=4","gravatar_id":"","url":"https://api.github.com/users/tdyas","html_url":"https://github.com/tdyas","followers_url":"https://api.github.com/users/tdyas/followers","following_url":"https://api.github.com/users/tdyas/following{/other_user}","gists_url":"https://api.github.com/users/tdyas/gists{/gist_id}","starred_url":"https://api.github.com/users/tdyas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tdyas/subscriptions","organizations_url":"https://api.github.com/users/tdyas/orgs","repos_url":"https://api.github.com/users/tdyas/repos","events_url":"https://api.github.com/users/tdyas/events{/privacy}","received_events_url":"https://api.github.com/users/tdyas/received_events","type":"User","site_admin":false},"created_at":"2018-08-31T23:38:43Z","updated_at":"2018-08-31T23:38:43Z","author_association":"NONE","body":"I didn't file an issue.\r\n\r\nBackground: My company has an extension to run a command-line test runner in a Terminal pane. We have to either sleep or wait for input in order to prevent the terminal pane from closing before the developer has a chance to see the output.\r\n\r\nGiven the existence of `waitOnExit` in the internal API, it would be nice to just leverage that existing functionality.\r\n\r\nIs there any reason why waitOnExit is not already exported to extensions?"}}
{"actor":{"display_login":"tdyas"}}