{"action":"created","issue":{"url":"https://api.github.com/repos/mlpack/benchmarks/issues/125","repository_url":"https://api.github.com/repos/mlpack/benchmarks","labels_url":"https://api.github.com/repos/mlpack/benchmarks/issues/125/labels{/name}","comments_url":"https://api.github.com/repos/mlpack/benchmarks/issues/125/comments","events_url":"https://api.github.com/repos/mlpack/benchmarks/issues/125/events","html_url":"https://github.com/mlpack/benchmarks/pull/125","id":359898000,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1Mjg0MjI3","number":125,"title":"Reduce output messages when running benchmarks","user":{"login":"geektoni","id":3296552,"node_id":"MDQ6VXNlcjMyOTY1NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/3296552?v=4","gravatar_id":"","url":"https://api.github.com/users/geektoni","html_url":"https://github.com/geektoni","followers_url":"https://api.github.com/users/geektoni/followers","following_url":"https://api.github.com/users/geektoni/following{/other_user}","gists_url":"https://api.github.com/users/geektoni/gists{/gist_id}","starred_url":"https://api.github.com/users/geektoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geektoni/subscriptions","organizations_url":"https://api.github.com/users/geektoni/orgs","repos_url":"https://api.github.com/users/geektoni/repos","events_url":"https://api.github.com/users/geektoni/events{/privacy}","received_events_url":"https://api.github.com/users/geektoni/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-13T13:33:16Z","updated_at":"2018-09-13T15:19:46Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mlpack/benchmarks/pulls/125","html_url":"https://github.com/mlpack/benchmarks/pull/125","diff_url":"https://github.com/mlpack/benchmarks/pull/125.diff","patch_url":"https://github.com/mlpack/benchmarks/pull/125.patch"},"body":"This PR reduces the number of the message which are printed to the terminal when running `make run`. I do not know if that `print` statement was just for debugging purposes and then it was forgotten, or if it was placed there for a more sensible reason, therefore I just guarded it.\r\n\r\nBefore patch output:\r\n```\r\n/home/uriel/Applications/miniconda3/bin/python3 benchmark/run_benchmark.py -c config.yaml -b shogun -l False -u False -m ALLKNN --f \"\" --n False -r \"\" -p \"\"\r\n[WARN ] No module named simplejson\r\n[INFO ] CPU Model:  Intel(R) Core(TM) i3-3217U CPU @ 1.80GHz\r\n[INFO ] Distribution: debian stretch/sid\r\n[INFO ] Platform: x86_64\r\n[INFO ] Memory: 7.6943359375 GB\r\n[INFO ] CPU Cores: 4\r\n{'general': dict_items([('timeout', 9000), ('databaseHost', 'localhost'), ('port', 3306), ('database', 'benchmarks'), ('driver', 'mysql'), ('keepReports', 20), ('bootstrap', 10), ('libraries', ['mlpack', 'shogun', 'weka', 'scikit', 'mlpy', 'flann', 'ann', 'annoy', 'mrpt', 'dlibml']), ('version', ['HEAD', '3.2.0', '3.6.11', '0.15.1', '3.5.0', '1.8.4', '1.1.2', '1.8.3', '0.1', '19.4'])]), 'DTC': {'{}': [('mlpack', [['datasets/iris_train.csv', 'datasets/iris_test.csv', 'datasets/iris_labels.csv'], ['datasets/oilspill_train.csv', 'datasets/oilspill_test.csv', 'datasets/oilspill_labels.csv'], ['datasets/scene_train.csv', 'datasets/scene_test.csv', 'datasets/scene_labels.csv'], ['datasets/webpage_train.csv', 'datasets/webpage_test.csv', 'datasets/webpage_labels.csv'], ['datasets/isolet_train.csv', 'datasets/isolet_test.csv', 'datasets/isolet_labels.csv'], ['datasets/mammography_train.csv', 'datasets/mammography_test.csv', 'datasets/mammography_labels.csv'], ['datasets/reuters_train.csv', 'datasets/reuters_test.csv', 'datasets/reuters_labels.csv'], ['datasets/abalone19_train.csv', 'datasets/abalone19_test.csv', 'datasets/abalone19_labels.csv'], ['datasets/sickEuthyroid_train.csv', 'datasets/sickEuthyroid_test.csv', 'datasets/sickEuthyroid_labels.csv'], ['datasets/abalone7_train.csv', 'datasets/abalone7_test.csv', 'datasets/abalone7_labels.csv'], ['datasets/satellite_train.csv', 'datasets/satellite_test.csv', 'datasets/satellite_labels.csv'], ['datasets/ecoli_train.csv', 'datasets/ecoli_test.csv', 'datasets/ecoli_labels.csv']], 3, 'methods/mlpack/decision_tree.py', ['csv', 'txt', 'arff'], ['metric'], 'None', ['None'])]}}\r\n{'general': dict_items([('timeout', 9000), ('databaseHost', 'localhost'), ('port', 3306), ('database', 'benchmarks'), ('driver', 'mysql'), ('keepReports', 20), ('bootstrap', 10), ('libraries', ['mlpack', 'shogun', 'weka', 'scikit', 'mlpy', 'flann', 'ann', 'annoy', 'mrpt', 'dlibml']), ('version', ['HEAD', '3.2.0', '3.6.11', '0.15.1', '3.5.0', '1.8.4', '1.1.2', '1.8.3', '0.1', '19.4'])]), 'DTC': {'{}': [('mlpack', [['datasets/iris_train.csv', 'datasets/iris_test.csv', 'datasets/iris_labels.csv'], ['datasets/oilspill_train.csv', 'datasets/oilspill_test.csv', 'datasets/oilspill_labels.csv'], ['datasets/scene_train.csv', 'datasets/scene_test.csv', 'datasets/scene_labels.csv'], ['datasets/webpage_train.csv', 'datasets/webpage_test.csv', 'datasets/webpage_labels.csv'], ['datasets/isolet_train.csv', 'datasets/isolet_test.csv', 'datasets/isolet_labels.csv'], ['datasets/mammography_train.csv', 'datasets/mammography_test.csv', 'datasets/mammography_labels.csv'], ['datasets/reuters_train.csv', 'datasets/reuters_test.csv', 'datasets/reuters_labels.csv'], ['datasets/abalone19_train.csv', 'datasets/abalone19_test.csv', 'datasets/abalone19_labels.csv'], ['datasets/sickEuthyroid_train.csv', 'datasets/sickEuthyroid_test.csv', 'datasets/sickEuthyroid_labels.csv'], ['datasets/abalone7_train.csv', 'datasets/abalone7_test.csv', 'datasets/abalone7_labels.csv'], ['datasets/satellite_train.csv', 'datasets/satellite_test.csv', 'datasets/satellite_labels.csv'], ['datasets/ecoli_train.csv', 'datasets/ecoli_test.csv', 'datasets/ecoli_labels.csv']], 3, 'methods/mlpack/decision_tree.py', ['csv', 'txt', 'arff'], ['metric'], 'None', ['None'])]}, 'PCA': {'{}': [('mlpack', ['datasets/iris.csv', 'datasets/wine.csv', 'datasets/cities.csv', 'datasets/diabetes_X.csv'], 3, 'methods/mlpack/pca.py', ['csv', 'txt'], ['metric'], 'None', ['None'])]}}\r\n{'general': dict_items([('timeout', 9000), ('databaseHost', 'localhost'), ('port', 3306), ('database', 'benchmarks'), ('driver', 'mysql'), ('keepReports', 20), ('bootstrap', 10), ('libraries', ['mlpack', 'shogun', 'weka', 'scikit', 'mlpy', 'flann', 'ann', 'annoy', 'mrpt', 'dlibml']), ('version', ['HEAD', '3.2.0', '3.6.11', '0.15.1', '3.5.0', '1.8.4', '1.1.2', '1.8.3', '0.1', '19.4'])]), 'DTC': {'{}': [('mlpack', [['datasets/iris_train.csv', 'datasets/iris_test.csv', 'datasets/iris_labels.csv'], ['datasets/oilspill_train.csv', 'datasets/oilspill_test.csv', 'datasets/oilspill_labels.csv'], ['datasets/scene_train.csv', 'datasets/scene_test.csv', 'datasets/scene_labels.csv'], ['datasets/webpage_train.csv', 'datasets/webpage_test.csv', 'datasets/webpage_labels.csv'], ['datasets/isolet_train.csv', 'datasets/isolet_test.csv', 'datasets/isolet_labels.csv'], ['datasets/mammography_train.csv', 'datasets/mammography_test.csv', 'datasets/mammography_labels.csv'], ['datasets/reuters_train.csv', 'datasets/reuters_test.csv', 'datasets/reuters_labels.csv'], ['datasets/abalone19_train.csv', 'datasets/abalone19_test.csv', 'datasets/abalone19_labels.csv'], ['datasets/sickEuthyroid_train.csv', 'datasets/sickEuthyroid_test.csv', 'datasets/sickEuthyroid_labels.csv'], ['datasets/abalone7_train.csv', 'datasets/abalone7_test.csv', 'datasets/abalone7_labels.csv'], ['datasets/satellite_train.csv', 'datasets/satellite_test.csv', 'datasets/satellite_labels.csv'], ['datasets/ecoli_train.csv', 'datasets/ecoli_test.csv', 'datasets/ecoli_labels.csv']], 3, 'methods/mlpack/decision_tree.py', ['csv', 'txt', 'arff'], ['metric'], 'None', ['None'])]}, 'PCA': {'{}': [('mlpack', ['datasets/iris.csv', 'datasets/wine.csv', 'datasets/cities.csv', 'datasets/diabetes_X.csv'], 3, 'methods/mlpack/pca.py', ['csv', 'txt'], ['metric'], 'None', ['None'])]}, 'PERCEPTRON': {'{\"max_iterations\": 10000}': [('mlpack', [['datasets/iris_train.csv', 'datasets/iris_test.csv', 'datasets/iris_labels.csv'], ['datasets/oilspill_train.csv', 'datasets/oilspill_test.csv', 'datasets/oilspill_labels.csv'], ['datasets/scene_train.csv', 'datasets/scene_test.csv', 'datasets/scene_labels.csv'], ['datasets/webpage_train.csv', 'datasets/webpage_test.csv', 'datasets/webpage_labels.csv'], ['datasets/isolet_train.csv', 'datasets/isolet_test.csv', 'datasets/isolet_labels.csv'], ['datasets/mammography_train.csv', 'datasets/mammography_test.csv', 'datasets/mammography_labels.csv'], ['datasets/reuters_train.csv', 'datasets/reuters_test.csv', 'datasets/reuters_labels.csv'], ['datasets/abalone19_train.csv', 'datasets/abalone19_test.csv', 'datasets/abalone19_labels.csv'], ['datasets/sickEuthyroid_train.csv', 'datasets/sickEuthyroid_test.csv', 'datasets/sickEuthyroid_labels.csv'], ['datasets/abalone7_train.csv', 'datasets/abalone7_test.csv', 'datasets/abalone7_labels.csv'], ['datasets/satellite_train.csv', 'datasets/satellite_test.csv', 'datasets/satellite_labels.csv'], ['datasets/ecoli_train.csv', 'datasets/ecoli_test.csv', 'datasets/ecoli_labels.csv']], 3, 'methods/mlpack/perceptron.py', ['csv', 'txt', 'arff'], ['metric'], 'None', ['None'])]}}\r\n.... and many more lines like this\r\n```  \r\n\r\nAfter patch output:\r\n```\r\n/home/uriel/Applications/miniconda3/bin/python3 benchmark/run_benchmark.py -c config.yaml -b shogun -l False -u False -m ALLKNN --f \"\" --n False -r \"\" -p \"\"\r\n[WARN ] No module named simplejson\r\n[INFO ] CPU Model:  Intel(R) Core(TM) i3-3217U CPU @ 1.80GHz\r\n[INFO ] Distribution: debian stretch/sid\r\n[INFO ] Platform: x86_64\r\n[INFO ] Memory: 7.6943359375 GB\r\n[INFO ] CPU Cores: 4\r\n[INFO ] Method: ALLKNN\r\n[INFO ] Options: {'k': 3}\r\n[INFO ] Library: shogun\r\n[INFO ] Dataset: wine\r\n[INFO ] Dataset: cloud\r\n[INFO ] Dataset: wine\r\n```"},"comment":{"url":"https://api.github.com/repos/mlpack/benchmarks/issues/comments/421045563","html_url":"https://github.com/mlpack/benchmarks/pull/125#issuecomment-421045563","issue_url":"https://api.github.com/repos/mlpack/benchmarks/issues/125","id":421045563,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMTA0NTU2Mw==","user":{"login":"rcurtin","id":1845039,"node_id":"MDQ6VXNlcjE4NDUwMzk=","avatar_url":"https://avatars0.githubusercontent.com/u/1845039?v=4","gravatar_id":"","url":"https://api.github.com/users/rcurtin","html_url":"https://github.com/rcurtin","followers_url":"https://api.github.com/users/rcurtin/followers","following_url":"https://api.github.com/users/rcurtin/following{/other_user}","gists_url":"https://api.github.com/users/rcurtin/gists{/gist_id}","starred_url":"https://api.github.com/users/rcurtin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcurtin/subscriptions","organizations_url":"https://api.github.com/users/rcurtin/orgs","repos_url":"https://api.github.com/users/rcurtin/repos","events_url":"https://api.github.com/users/rcurtin/events{/privacy}","received_events_url":"https://api.github.com/users/rcurtin/received_events","type":"User","site_admin":false},"created_at":"2018-09-13T15:19:46Z","updated_at":"2018-09-13T15:19:46Z","author_association":"MEMBER","body":"Thanks!  I think you are right that it is unnecessary debugging output.  Personally I'd be okay with removing the print entirely, even when verbose is set.  @zoq any thoughts on this one?"}}
{"actor":{"display_login":"rcurtin"}}