{"action":"created","comment":{"url":"https://api.github.com/repos/Workiva/w_common/pulls/comments/221978501","pull_request_review_id":160756006,"id":221978501,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTk3ODUwMQ==","diff_hunk":"@@ -204,31 +225,37 @@ void main() {\n         var childCache = new Cache(stubCachingStrategy);\n         await childCache.get(cachedId, () => cachedValue);\n         await childCache.remove(cachedId);\n-        verify(stubCachingStrategy.onDidRemove(cachedId, cachedValue));\n+\n+        expect(stubCachingStrategy.onDidRemoveCalled == 1, isTrue);","path":"test/unit/browser/cache/cache_test.dart","position":54,"original_position":54,"commit_id":"e73bd2b17ae4b87aae6193e9a0006b86c0df4a4d","original_commit_id":"e73bd2b17ae4b87aae6193e9a0006b86c0df4a4d","user":{"login":"georgelesica-wf","id":7902990,"node_id":"MDQ6VXNlcjc5MDI5OTA=","avatar_url":"https://avatars0.githubusercontent.com/u/7902990?v=4","gravatar_id":"","url":"https://api.github.com/users/georgelesica-wf","html_url":"https://github.com/georgelesica-wf","followers_url":"https://api.github.com/users/georgelesica-wf/followers","following_url":"https://api.github.com/users/georgelesica-wf/following{/other_user}","gists_url":"https://api.github.com/users/georgelesica-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/georgelesica-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgelesica-wf/subscriptions","organizations_url":"https://api.github.com/users/georgelesica-wf/orgs","repos_url":"https://api.github.com/users/georgelesica-wf/repos","events_url":"https://api.github.com/users/georgelesica-wf/events{/privacy}","received_events_url":"https://api.github.com/users/georgelesica-wf/received_events","type":"User","site_admin":false},"body":"Better error messages if you do `expect(stubCachingStrategy.onDidRemoveCalled, 1);`, same goes for the others.","created_at":"2018-10-02T14:39:26Z","updated_at":"2018-10-02T14:39:27Z","html_url":"https://github.com/Workiva/w_common/pull/98#discussion_r221978501","pull_request_url":"https://api.github.com/repos/Workiva/w_common/pulls/98","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Workiva/w_common/pulls/comments/221978501"},"html":{"href":"https://github.com/Workiva/w_common/pull/98#discussion_r221978501"},"pull_request":{"href":"https://api.github.com/repos/Workiva/w_common/pulls/98"}}},"pull_request":{"url":"https://api.github.com/repos/Workiva/w_common/pulls/98","id":205298938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1Mjk4OTM4","html_url":"https://github.com/Workiva/w_common/pull/98","diff_url":"https://github.com/Workiva/w_common/pull/98.diff","patch_url":"https://github.com/Workiva/w_common/pull/98.patch","issue_url":"https://api.github.com/repos/Workiva/w_common/issues/98","number":98,"state":"open","locked":false,"title":"AF-1910 fixes for dart 1 and dart 2 compatibility","user":{"login":"robbecker-wf","id":6053699,"node_id":"MDQ6VXNlcjYwNTM2OTk=","avatar_url":"https://avatars3.githubusercontent.com/u/6053699?v=4","gravatar_id":"","url":"https://api.github.com/users/robbecker-wf","html_url":"https://github.com/robbecker-wf","followers_url":"https://api.github.com/users/robbecker-wf/followers","following_url":"https://api.github.com/users/robbecker-wf/following{/other_user}","gists_url":"https://api.github.com/users/robbecker-wf/gists{/gist_id}","starred_url":"https://api.github.com/users/robbecker-wf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robbecker-wf/subscriptions","organizations_url":"https://api.github.com/users/robbecker-wf/orgs","repos_url":"https://api.github.com/users/robbecker-wf/repos","events_url":"https://api.github.com/users/robbecker-wf/events{/privacy}","received_events_url":"https://api.github.com/users/robbecker-wf/received_events","type":"User","site_admin":false},"body":"### Description\r\nFixes to allow dart 1 and dart 2 compatibility at the same time.\r\n\r\n\r\n### Changes\r\n- CI changes (travis and Dockerfile) to use dartanalyzer and dartfmt directly\r\n- test on chrome instead of dartium\r\n- 1 small Type fix\r\n- some changes for mockito under dart 2\r\n\r\n### Semantic Versioning\r\n\r\n- [x] **Patch**\r\n  - [x] This change does not affect the public API\r\n  - [ ] This change fixes existing incorrect behavior without any additions\r\n- [ ] **Minor**\r\n  - [ ] This change adds something to the public API\r\n  - [ ] This change deprecates a part of the public API\r\n* [ ] Major\r\n  - [ ] This change modifies part of the public API in a backwards-incompatible manner\r\n  - [ ] This change removes part of the public API\r\n\r\n### Testing/QA\r\n\r\n- [ ] CI passes\r\n\r\n","created_at":"2018-08-01T03:26:31Z","updated_at":"2018-10-02T14:39:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e5186901e5e20a2610da19c138bac26fe8d4f51b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":468760444,"node_id":"MDU6TGFiZWw0Njg3NjA0NDQ=","url":"https://api.github.com/repos/Workiva/w_common/labels/Merge%20Requirements%20Unmet","name":"Merge Requirements Unmet","color":"e11d21","default":false},{"id":514880629,"node_id":"MDU6TGFiZWw1MTQ4ODA2Mjk=","url":"https://api.github.com/repos/Workiva/w_common/labels/type:%20Tech-Debt","name":"type: Tech-Debt","color":"b2dfdb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Workiva/w_common/pulls/98/commits","review_comments_url":"https://api.github.com/repos/Workiva/w_common/pulls/98/comments","review_comment_url":"https://api.github.com/repos/Workiva/w_common/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Workiva/w_common/issues/98/comments","statuses_url":"https://api.github.com/repos/Workiva/w_common/statuses/e73bd2b17ae4b87aae6193e9a0006b86c0df4a4d","head":{"label":"Workiva:dart2","ref":"dart2","sha":"e73bd2b17ae4b87aae6193e9a0006b86c0df4a4d","user":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":71292440,"node_id":"MDEwOlJlcG9zaXRvcnk3MTI5MjQ0MA==","name":"w_common","full_name":"Workiva/w_common","private":false,"owner":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Workiva/w_common","description":"A collection of helpful utilities for use in Dart projects.","fork":false,"url":"https://api.github.com/repos/Workiva/w_common","forks_url":"https://api.github.com/repos/Workiva/w_common/forks","keys_url":"https://api.github.com/repos/Workiva/w_common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/w_common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/w_common/teams","hooks_url":"https://api.github.com/repos/Workiva/w_common/hooks","issue_events_url":"https://api.github.com/repos/Workiva/w_common/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/w_common/events","assignees_url":"https://api.github.com/repos/Workiva/w_common/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/w_common/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/w_common/tags","blobs_url":"https://api.github.com/repos/Workiva/w_common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/w_common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/w_common/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/w_common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/w_common/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/w_common/languages","stargazers_url":"https://api.github.com/repos/Workiva/w_common/stargazers","contributors_url":"https://api.github.com/repos/Workiva/w_common/contributors","subscribers_url":"https://api.github.com/repos/Workiva/w_common/subscribers","subscription_url":"https://api.github.com/repos/Workiva/w_common/subscription","commits_url":"https://api.github.com/repos/Workiva/w_common/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/w_common/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/w_common/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/w_common/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/w_common/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/w_common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/w_common/merges","archive_url":"https://api.github.com/repos/Workiva/w_common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/w_common/downloads","issues_url":"https://api.github.com/repos/Workiva/w_common/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/w_common/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/w_common/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/w_common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/w_common/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/w_common/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/w_common/deployments","created_at":"2016-10-18T21:21:38Z","updated_at":"2018-06-25T14:33:03Z","pushed_at":"2018-09-29T15:39:53Z","git_url":"git://github.com/Workiva/w_common.git","ssh_url":"git@github.com:Workiva/w_common.git","clone_url":"https://github.com/Workiva/w_common.git","svn_url":"https://github.com/Workiva/w_common","homepage":"","size":388,"stargazers_count":3,"watchers_count":3,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":3,"watchers":3,"default_branch":"master"}},"base":{"label":"Workiva:master","ref":"master","sha":"2e6356e9dbebdf37a5534c224c1c5fb1e74cd9c9","user":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"repo":{"id":71292440,"node_id":"MDEwOlJlcG9zaXRvcnk3MTI5MjQ0MA==","name":"w_common","full_name":"Workiva/w_common","private":false,"owner":{"login":"Workiva","id":1087529,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODc1Mjk=","avatar_url":"https://avatars3.githubusercontent.com/u/1087529?v=4","gravatar_id":"","url":"https://api.github.com/users/Workiva","html_url":"https://github.com/Workiva","followers_url":"https://api.github.com/users/Workiva/followers","following_url":"https://api.github.com/users/Workiva/following{/other_user}","gists_url":"https://api.github.com/users/Workiva/gists{/gist_id}","starred_url":"https://api.github.com/users/Workiva/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Workiva/subscriptions","organizations_url":"https://api.github.com/users/Workiva/orgs","repos_url":"https://api.github.com/users/Workiva/repos","events_url":"https://api.github.com/users/Workiva/events{/privacy}","received_events_url":"https://api.github.com/users/Workiva/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Workiva/w_common","description":"A collection of helpful utilities for use in Dart projects.","fork":false,"url":"https://api.github.com/repos/Workiva/w_common","forks_url":"https://api.github.com/repos/Workiva/w_common/forks","keys_url":"https://api.github.com/repos/Workiva/w_common/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Workiva/w_common/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Workiva/w_common/teams","hooks_url":"https://api.github.com/repos/Workiva/w_common/hooks","issue_events_url":"https://api.github.com/repos/Workiva/w_common/issues/events{/number}","events_url":"https://api.github.com/repos/Workiva/w_common/events","assignees_url":"https://api.github.com/repos/Workiva/w_common/assignees{/user}","branches_url":"https://api.github.com/repos/Workiva/w_common/branches{/branch}","tags_url":"https://api.github.com/repos/Workiva/w_common/tags","blobs_url":"https://api.github.com/repos/Workiva/w_common/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Workiva/w_common/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Workiva/w_common/git/refs{/sha}","trees_url":"https://api.github.com/repos/Workiva/w_common/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Workiva/w_common/statuses/{sha}","languages_url":"https://api.github.com/repos/Workiva/w_common/languages","stargazers_url":"https://api.github.com/repos/Workiva/w_common/stargazers","contributors_url":"https://api.github.com/repos/Workiva/w_common/contributors","subscribers_url":"https://api.github.com/repos/Workiva/w_common/subscribers","subscription_url":"https://api.github.com/repos/Workiva/w_common/subscription","commits_url":"https://api.github.com/repos/Workiva/w_common/commits{/sha}","git_commits_url":"https://api.github.com/repos/Workiva/w_common/git/commits{/sha}","comments_url":"https://api.github.com/repos/Workiva/w_common/comments{/number}","issue_comment_url":"https://api.github.com/repos/Workiva/w_common/issues/comments{/number}","contents_url":"https://api.github.com/repos/Workiva/w_common/contents/{+path}","compare_url":"https://api.github.com/repos/Workiva/w_common/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Workiva/w_common/merges","archive_url":"https://api.github.com/repos/Workiva/w_common/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Workiva/w_common/downloads","issues_url":"https://api.github.com/repos/Workiva/w_common/issues{/number}","pulls_url":"https://api.github.com/repos/Workiva/w_common/pulls{/number}","milestones_url":"https://api.github.com/repos/Workiva/w_common/milestones{/number}","notifications_url":"https://api.github.com/repos/Workiva/w_common/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Workiva/w_common/labels{/name}","releases_url":"https://api.github.com/repos/Workiva/w_common/releases{/id}","deployments_url":"https://api.github.com/repos/Workiva/w_common/deployments","created_at":"2016-10-18T21:21:38Z","updated_at":"2018-06-25T14:33:03Z","pushed_at":"2018-09-29T15:39:53Z","git_url":"git://github.com/Workiva/w_common.git","ssh_url":"git@github.com:Workiva/w_common.git","clone_url":"https://github.com/Workiva/w_common.git","svn_url":"https://github.com/Workiva/w_common","homepage":"","size":388,"stargazers_count":3,"watchers_count":3,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":3,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Workiva/w_common/pulls/98"},"html":{"href":"https://github.com/Workiva/w_common/pull/98"},"issue":{"href":"https://api.github.com/repos/Workiva/w_common/issues/98"},"comments":{"href":"https://api.github.com/repos/Workiva/w_common/issues/98/comments"},"review_comments":{"href":"https://api.github.com/repos/Workiva/w_common/pulls/98/comments"},"review_comment":{"href":"https://api.github.com/repos/Workiva/w_common/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Workiva/w_common/pulls/98/commits"},"statuses":{"href":"https://api.github.com/repos/Workiva/w_common/statuses/e73bd2b17ae4b87aae6193e9a0006b86c0df4a4d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"georgelesica-wf"}}