{"action":"created","issue":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/10197","repository_url":"https://api.github.com/repos/sequelize/sequelize","labels_url":"https://api.github.com/repos/sequelize/sequelize/issues/10197/labels{/name}","comments_url":"https://api.github.com/repos/sequelize/sequelize/issues/10197/comments","events_url":"https://api.github.com/repos/sequelize/sequelize/issues/10197/events","html_url":"https://github.com/sequelize/sequelize/pull/10197","id":383953932,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMjk3NjEy","number":10197,"title":"fix(association): build-association-without-saving(#10150)","user":{"login":"tsasaki609","id":916115,"node_id":"MDQ6VXNlcjkxNjExNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/916115?v=4","gravatar_id":"","url":"https://api.github.com/users/tsasaki609","html_url":"https://github.com/tsasaki609","followers_url":"https://api.github.com/users/tsasaki609/followers","following_url":"https://api.github.com/users/tsasaki609/following{/other_user}","gists_url":"https://api.github.com/users/tsasaki609/gists{/gist_id}","starred_url":"https://api.github.com/users/tsasaki609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsasaki609/subscriptions","organizations_url":"https://api.github.com/users/tsasaki609/orgs","repos_url":"https://api.github.com/users/tsasaki609/repos","events_url":"https://api.github.com/users/tsasaki609/events{/privacy}","received_events_url":"https://api.github.com/users/tsasaki609/received_events","type":"User","site_admin":false},"labels":[{"id":736009475,"node_id":"MDU6TGFiZWw3MzYwMDk0NzU=","url":"https://api.github.com/repos/sequelize/sequelize/labels/think-about","name":"think-about","color":"53e267","default":false}],"state":"open","locked":false,"assignee":{"login":"sushantdhiman","id":9989487,"node_id":"MDQ6VXNlcjk5ODk0ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/9989487?v=4","gravatar_id":"","url":"https://api.github.com/users/sushantdhiman","html_url":"https://github.com/sushantdhiman","followers_url":"https://api.github.com/users/sushantdhiman/followers","following_url":"https://api.github.com/users/sushantdhiman/following{/other_user}","gists_url":"https://api.github.com/users/sushantdhiman/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdhiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdhiman/subscriptions","organizations_url":"https://api.github.com/users/sushantdhiman/orgs","repos_url":"https://api.github.com/users/sushantdhiman/repos","events_url":"https://api.github.com/users/sushantdhiman/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdhiman/received_events","type":"User","site_admin":false},"assignees":[{"login":"sushantdhiman","id":9989487,"node_id":"MDQ6VXNlcjk5ODk0ODc=","avatar_url":"https://avatars1.githubusercontent.com/u/9989487?v=4","gravatar_id":"","url":"https://api.github.com/users/sushantdhiman","html_url":"https://github.com/sushantdhiman","followers_url":"https://api.github.com/users/sushantdhiman/followers","following_url":"https://api.github.com/users/sushantdhiman/following{/other_user}","gists_url":"https://api.github.com/users/sushantdhiman/gists{/gist_id}","starred_url":"https://api.github.com/users/sushantdhiman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sushantdhiman/subscriptions","organizations_url":"https://api.github.com/users/sushantdhiman/orgs","repos_url":"https://api.github.com/users/sushantdhiman/repos","events_url":"https://api.github.com/users/sushantdhiman/events{/privacy}","received_events_url":"https://api.github.com/users/sushantdhiman/received_events","type":"User","site_admin":false}],"milestone":null,"comments":2,"created_at":"2018-11-24T03:02:59Z","updated_at":"2018-11-27T13:50:45Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sequelize/sequelize/pulls/10197","html_url":"https://github.com/sequelize/sequelize/pull/10197","diff_url":"https://github.com/sequelize/sequelize/pull/10197.diff","patch_url":"https://github.com/sequelize/sequelize/pull/10197.patch"},"body":"### Pull Request check-list\r\n\r\n_Please make sure to review and check all of these items:_\r\n\r\n- [x] Does `npm run test` or `npm run test-DIALECT` pass with this change (including linting)?\r\n- [x] Does the description below contain a link to an existing issue (Closes #[issue]) or a description of the issue you are solving?\r\n- [x] Have you added new tests to prevent regressions?\r\n- [x] Is a documentation update included (if this change modifies existing APIs, or introduces new ones)?\r\n- [x] Did you follow the commit message conventions explained in [CONTRIBUTING.md](https://github.com/sequelize/sequelize/blob/master/CONTRIBUTING.md)?\r\n\r\n<!-- NOTE: these things are not required to open a PR and can be done afterwards / while the PR is open. -->\r\n\r\n### Description of change\r\n\r\n<!-- Please provide a description of the change here. -->\r\nfix #10150 \r\nI got it fixed with just a few modifications. 😃 "},"comment":{"url":"https://api.github.com/repos/sequelize/sequelize/issues/comments/442064700","html_url":"https://github.com/sequelize/sequelize/pull/10197#issuecomment-442064700","issue_url":"https://api.github.com/repos/sequelize/sequelize/issues/10197","id":442064700,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MjA2NDcwMA==","user":{"login":"tsasaki609","id":916115,"node_id":"MDQ6VXNlcjkxNjExNQ==","avatar_url":"https://avatars0.githubusercontent.com/u/916115?v=4","gravatar_id":"","url":"https://api.github.com/users/tsasaki609","html_url":"https://github.com/tsasaki609","followers_url":"https://api.github.com/users/tsasaki609/followers","following_url":"https://api.github.com/users/tsasaki609/following{/other_user}","gists_url":"https://api.github.com/users/tsasaki609/gists{/gist_id}","starred_url":"https://api.github.com/users/tsasaki609/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsasaki609/subscriptions","organizations_url":"https://api.github.com/users/tsasaki609/orgs","repos_url":"https://api.github.com/users/tsasaki609/repos","events_url":"https://api.github.com/users/tsasaki609/events{/privacy}","received_events_url":"https://api.github.com/users/tsasaki609/received_events","type":"User","site_admin":false},"created_at":"2018-11-27T13:50:45Z","updated_at":"2018-11-27T13:50:45Z","author_association":"CONTRIBUTOR","body":"Hi @sushantdhiman ,\r\n> 1. What if you are building with primary key, should it save?\r\n\r\nI'll think about the question for a while. The answer does not come immediately right now. 🤔 \r\n\r\n> 2. hasOne should be fixed\r\n\r\nOK, I'll try.\r\n"}}
{"actor":{"display_login":"tsasaki609"}}