{"action":"created","issue":{"url":"https://api.github.com/repos/DQM4hep/DQM4hep/issues/56","repository_url":"https://api.github.com/repos/DQM4hep/DQM4hep","labels_url":"https://api.github.com/repos/DQM4hep/DQM4hep/issues/56/labels{/name}","comments_url":"https://api.github.com/repos/DQM4hep/DQM4hep/issues/56/comments","events_url":"https://api.github.com/repos/DQM4hep/DQM4hep/issues/56/events","html_url":"https://github.com/DQM4hep/DQM4hep/issues/56","id":386665355,"node_id":"MDU6SXNzdWUzODY2NjUzNTU=","number":56,"title":"ROOT c+17 and DQM4HEP","user":{"login":"flagarde","id":8627746,"node_id":"MDQ6VXNlcjg2Mjc3NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/8627746?v=4","gravatar_id":"","url":"https://api.github.com/users/flagarde","html_url":"https://github.com/flagarde","followers_url":"https://api.github.com/users/flagarde/followers","following_url":"https://api.github.com/users/flagarde/following{/other_user}","gists_url":"https://api.github.com/users/flagarde/gists{/gist_id}","starred_url":"https://api.github.com/users/flagarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flagarde/subscriptions","organizations_url":"https://api.github.com/users/flagarde/orgs","repos_url":"https://api.github.com/users/flagarde/repos","events_url":"https://api.github.com/users/flagarde/events{/privacy}","received_events_url":"https://api.github.com/users/flagarde/received_events","type":"User","site_admin":false},"labels":[{"id":308704034,"node_id":"MDU6TGFiZWwzMDg3MDQwMzQ=","url":"https://api.github.com/repos/DQM4hep/DQM4hep/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":1023920652,"node_id":"MDU6TGFiZWwxMDIzOTIwNjUy","url":"https://api.github.com/repos/DQM4hep/DQM4hep/labels/main","name":"main","color":"b7d61b","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-03T05:32:44Z","updated_at":"2018-12-03T08:45:42Z","closed_at":null,"author_association":"NONE","body":"ROOT 6 can be compiled with c++17 support. In this case : \r\n```cmake\r\n# Set C++ standard\r\nset(CMAKE_CXX_STANDARD 11 CACHE STRING \"C++ standard used for compiling\")\r\nset(CMAKE_CXX_STANDARD_REQUIRED ON)\r\nset(CMAKE_CXX_EXTENSIONS OFF)\r\n```\r\nbreak the compilation. Maybe It could be possible to know  if ROOT was compiled with c++11 or c++17 etc and compile DQM4HEP accordingly.\r\n\r\nUgly solution : \r\n```cmake\r\nset(CMAKE_CXX_FLAGS \"${CMAKE_CXX_FLAGS} ${ROOT_CXX_FLAGS}\")\r\n\r\nmessage(\"ROOT :  ${ROOT_CXX_FLAGS}\")\r\nstring(FIND \"${ROOT_CXX_FLAGS}\" \"std=\" Founded)\r\nif(${Founded} STREQUAL \"-1\")\r\n\tmessage(\"oops... Trying to recover your %!£\")\r\n\tset(ROOT_DEFINITIONS -std=c++11)\r\nendif()\r\n\r\nadd_compile_options(${ROOT_DEFINITIONS})\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/DQM4hep/DQM4hep/issues/comments/443632038","html_url":"https://github.com/DQM4hep/DQM4hep/issues/56#issuecomment-443632038","issue_url":"https://api.github.com/repos/DQM4hep/DQM4hep/issues/56","id":443632038,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzYzMjAzOA==","user":{"login":"flagarde","id":8627746,"node_id":"MDQ6VXNlcjg2Mjc3NDY=","avatar_url":"https://avatars2.githubusercontent.com/u/8627746?v=4","gravatar_id":"","url":"https://api.github.com/users/flagarde","html_url":"https://github.com/flagarde","followers_url":"https://api.github.com/users/flagarde/followers","following_url":"https://api.github.com/users/flagarde/following{/other_user}","gists_url":"https://api.github.com/users/flagarde/gists{/gist_id}","starred_url":"https://api.github.com/users/flagarde/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flagarde/subscriptions","organizations_url":"https://api.github.com/users/flagarde/orgs","repos_url":"https://api.github.com/users/flagarde/repos","events_url":"https://api.github.com/users/flagarde/events{/privacy}","received_events_url":"https://api.github.com/users/flagarde/received_events","type":"User","site_admin":false},"created_at":"2018-12-03T08:45:42Z","updated_at":"2018-12-03T08:45:42Z","author_association":"NONE","body":"Hi, \n\nYes i can try to recompile ROOT of course but as mentioned DQM4HEP compile with c++17, I only had to modify the cmake file by hand as you fix the cpp version to 11. Unfortunatly, i'm just starting playing we DQM4HEP and try to use it with the hardware we have so can not test if everything is going well with c++17. \n\n\nDe: \"Antoine Pingault\" <notifications@github.com> \nÀ: \"DQM4hep/DQM4hep\" <DQM4hep@noreply.github.com> \nCc: \"f lagarde\" <f.lagarde@ipnl.in2p3.fr>, \"Mention\" <mention@noreply.github.com> \nEnvoyé: Lundi 3 Décembre 2018 16:18:35 \nObjet: Re: [DQM4hep/DQM4hep] ROOT c+17 and DQM4HEP (#56) \n\n\n\nYes, I agree that we should not automatically enforce the flavor depending on how root was installed. \nThough in the case of root with c++17 there is no choice, dqm4hep needs to be compiled with c++17 too. \n\nAnyway, option2 seems the way to go. \n\nI don't know how extensive are the changes we need to make to the framework for c++17 compatibility. Plus, having only a c++17 installation of root seems to be quite rare for now. I don't think this feature will be a priority on our todolist for now. \n\n[ https://github.com/flagarde | @flagarde ] Can you use a c++11/14 installation of root in the meantime? \n\n— \nYou are receiving this because you were mentioned. \nReply to this email directly, [ https://github.com/DQM4hep/DQM4hep/issues/56#issuecomment-443625069 | view it on GitHub ] , or [ https://github.com/notifications/unsubscribe-auth/AIOmIgUGhCufF0RpoezKf3yFqMs9Ps8-ks5u1N5agaJpZM4Y954R | mute the thread ] . \n\n"}}
{"actor":{"display_login":"flagarde"}}