{"action":"created","comment":{"url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/comments/171115399","pull_request_review_id":99911926,"id":171115399,"diff_hunk":"@@ -210,7 +210,7 @@ def TestInvokeContract(wallet, args, withdrawal_tx=None, parse_params=True, from\n     return None, None, None, None\n \n \n-def test_invoke(script, wallet, outputs, withdrawal_tx=None, from_addr=None):\n+def test_invoke(script, wallet, outputs, withdrawal_tx=None, from_addr=None, net_fee_override=None):","path":"neo/Prompt/Commands/Invoke.py","position":23,"original_position":23,"commit_id":"8904f751fc87b66601becb1dc605f5c0f6cd9b85","original_commit_id":"8904f751fc87b66601becb1dc605f5c0f6cd9b85","user":{"login":"brianlenz","id":2305088,"avatar_url":"https://avatars1.githubusercontent.com/u/2305088?v=4","gravatar_id":"","url":"https://api.github.com/users/brianlenz","html_url":"https://github.com/brianlenz","followers_url":"https://api.github.com/users/brianlenz/followers","following_url":"https://api.github.com/users/brianlenz/following{/other_user}","gists_url":"https://api.github.com/users/brianlenz/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlenz/subscriptions","organizations_url":"https://api.github.com/users/brianlenz/orgs","repos_url":"https://api.github.com/users/brianlenz/repos","events_url":"https://api.github.com/users/brianlenz/events{/privacy}","received_events_url":"https://api.github.com/users/brianlenz/received_events","type":"User","site_admin":false},"body":"Actually, I'll just make it use a constant. I think that'll make the most sense. Update incoming shortly...","created_at":"2018-02-28T00:50:24Z","updated_at":"2018-02-28T00:50:24Z","html_url":"https://github.com/CityOfZion/neo-python/pull/266#discussion_r171115399","pull_request_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/266","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/comments/171115399"},"html":{"href":"https://github.com/CityOfZion/neo-python/pull/266#discussion_r171115399"},"pull_request":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/266"}},"in_reply_to_id":170918852},"pull_request":{"url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/266","id":171549278,"html_url":"https://github.com/CityOfZion/neo-python/pull/266","diff_url":"https://github.com/CityOfZion/neo-python/pull/266.diff","patch_url":"https://github.com/CityOfZion/neo-python/pull/266.patch","issue_url":"https://api.github.com/repos/CityOfZion/neo-python/issues/266","number":266,"state":"open","locked":false,"title":"Allow custom network tx fee","user":{"login":"brianlenz","id":2305088,"avatar_url":"https://avatars1.githubusercontent.com/u/2305088?v=4","gravatar_id":"","url":"https://api.github.com/users/brianlenz","html_url":"https://github.com/brianlenz","followers_url":"https://api.github.com/users/brianlenz/followers","following_url":"https://api.github.com/users/brianlenz/following{/other_user}","gists_url":"https://api.github.com/users/brianlenz/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlenz/subscriptions","organizations_url":"https://api.github.com/users/brianlenz/orgs","repos_url":"https://api.github.com/users/brianlenz/repos","events_url":"https://api.github.com/users/brianlenz/events{/privacy}","received_events_url":"https://api.github.com/users/brianlenz/received_events","type":"User","site_admin":false},"body":"**What current issue(s) does this address, or what feature is it adding?**\r\n\r\nGives developers flexibility to specify a custom tx `net_fee` when automating bulk transactions to save on gas costs (the default of 0.001 is a bit higher than needed).\r\n\r\n**How did you solve this problem?**\r\n\r\nAdded a new `net_fee_override` parameter to the `test_invoke` and `test_deploy_and_invoke` methods (along with calling methods, as appropriate) to allow developers to set a custom fee to use.\r\n\r\n**How did you make sure your solution works?**\r\n\r\nTested it before and after and also updated an existing test case to test that it works properly.\r\n\r\n**Are there any special changes in the code that we should be aware of?**\r\n\r\nNo.\r\n\r\n**Please check the following, if applicable:**\r\n\r\n- [X] Did you add any tests?\r\n- [X] Did you run `make lint`?\r\n- [X] Did you run `make test`?\r\n- [X] Are you making a PR to a feature branch or development rather than master?\r\n- [ ] Did you add an entry to `CHANGELOG.rst`? (if not, please do)\r\n","created_at":"2018-02-27T02:43:18Z","updated_at":"2018-02-28T00:50:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"549a1cb05c3effed4440201d0e7ee860508f8506","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/266/commits","review_comments_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/266/comments","review_comment_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CityOfZion/neo-python/issues/266/comments","statuses_url":"https://api.github.com/repos/CityOfZion/neo-python/statuses/8904f751fc87b66601becb1dc605f5c0f6cd9b85","head":{"label":"brianlenz:allow-custom-net-tx-fee","ref":"allow-custom-net-tx-fee","sha":"8904f751fc87b66601becb1dc605f5c0f6cd9b85","user":{"login":"brianlenz","id":2305088,"avatar_url":"https://avatars1.githubusercontent.com/u/2305088?v=4","gravatar_id":"","url":"https://api.github.com/users/brianlenz","html_url":"https://github.com/brianlenz","followers_url":"https://api.github.com/users/brianlenz/followers","following_url":"https://api.github.com/users/brianlenz/following{/other_user}","gists_url":"https://api.github.com/users/brianlenz/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlenz/subscriptions","organizations_url":"https://api.github.com/users/brianlenz/orgs","repos_url":"https://api.github.com/users/brianlenz/repos","events_url":"https://api.github.com/users/brianlenz/events{/privacy}","received_events_url":"https://api.github.com/users/brianlenz/received_events","type":"User","site_admin":false},"repo":{"id":121700758,"name":"neo-python","full_name":"brianlenz/neo-python","owner":{"login":"brianlenz","id":2305088,"avatar_url":"https://avatars1.githubusercontent.com/u/2305088?v=4","gravatar_id":"","url":"https://api.github.com/users/brianlenz","html_url":"https://github.com/brianlenz","followers_url":"https://api.github.com/users/brianlenz/followers","following_url":"https://api.github.com/users/brianlenz/following{/other_user}","gists_url":"https://api.github.com/users/brianlenz/gists{/gist_id}","starred_url":"https://api.github.com/users/brianlenz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianlenz/subscriptions","organizations_url":"https://api.github.com/users/brianlenz/orgs","repos_url":"https://api.github.com/users/brianlenz/repos","events_url":"https://api.github.com/users/brianlenz/events{/privacy}","received_events_url":"https://api.github.com/users/brianlenz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brianlenz/neo-python","description":"Python Node and SDK for the NEO blockchain","fork":true,"url":"https://api.github.com/repos/brianlenz/neo-python","forks_url":"https://api.github.com/repos/brianlenz/neo-python/forks","keys_url":"https://api.github.com/repos/brianlenz/neo-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianlenz/neo-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianlenz/neo-python/teams","hooks_url":"https://api.github.com/repos/brianlenz/neo-python/hooks","issue_events_url":"https://api.github.com/repos/brianlenz/neo-python/issues/events{/number}","events_url":"https://api.github.com/repos/brianlenz/neo-python/events","assignees_url":"https://api.github.com/repos/brianlenz/neo-python/assignees{/user}","branches_url":"https://api.github.com/repos/brianlenz/neo-python/branches{/branch}","tags_url":"https://api.github.com/repos/brianlenz/neo-python/tags","blobs_url":"https://api.github.com/repos/brianlenz/neo-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianlenz/neo-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianlenz/neo-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianlenz/neo-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianlenz/neo-python/statuses/{sha}","languages_url":"https://api.github.com/repos/brianlenz/neo-python/languages","stargazers_url":"https://api.github.com/repos/brianlenz/neo-python/stargazers","contributors_url":"https://api.github.com/repos/brianlenz/neo-python/contributors","subscribers_url":"https://api.github.com/repos/brianlenz/neo-python/subscribers","subscription_url":"https://api.github.com/repos/brianlenz/neo-python/subscription","commits_url":"https://api.github.com/repos/brianlenz/neo-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianlenz/neo-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianlenz/neo-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianlenz/neo-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianlenz/neo-python/contents/{+path}","compare_url":"https://api.github.com/repos/brianlenz/neo-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianlenz/neo-python/merges","archive_url":"https://api.github.com/repos/brianlenz/neo-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianlenz/neo-python/downloads","issues_url":"https://api.github.com/repos/brianlenz/neo-python/issues{/number}","pulls_url":"https://api.github.com/repos/brianlenz/neo-python/pulls{/number}","milestones_url":"https://api.github.com/repos/brianlenz/neo-python/milestones{/number}","notifications_url":"https://api.github.com/repos/brianlenz/neo-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianlenz/neo-python/labels{/name}","releases_url":"https://api.github.com/repos/brianlenz/neo-python/releases{/id}","deployments_url":"https://api.github.com/repos/brianlenz/neo-python/deployments","created_at":"2018-02-16T00:37:46Z","updated_at":"2018-02-16T00:37:48Z","pushed_at":"2018-02-27T13:33:53Z","git_url":"git://github.com/brianlenz/neo-python.git","ssh_url":"git@github.com:brianlenz/neo-python.git","clone_url":"https://github.com/brianlenz/neo-python.git","svn_url":"https://github.com/brianlenz/neo-python","homepage":"https://neo-python.readthedocs.io/en/latest/","size":118013,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"CityOfZion:development","ref":"development","sha":"78583047564f15b30a3f22f5dbba7b04dbfdd486","user":{"login":"CityOfZion","id":29782569,"avatar_url":"https://avatars1.githubusercontent.com/u/29782569?v=4","gravatar_id":"","url":"https://api.github.com/users/CityOfZion","html_url":"https://github.com/CityOfZion","followers_url":"https://api.github.com/users/CityOfZion/followers","following_url":"https://api.github.com/users/CityOfZion/following{/other_user}","gists_url":"https://api.github.com/users/CityOfZion/gists{/gist_id}","starred_url":"https://api.github.com/users/CityOfZion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CityOfZion/subscriptions","organizations_url":"https://api.github.com/users/CityOfZion/orgs","repos_url":"https://api.github.com/users/CityOfZion/repos","events_url":"https://api.github.com/users/CityOfZion/events{/privacy}","received_events_url":"https://api.github.com/users/CityOfZion/received_events","type":"Organization","site_admin":false},"repo":{"id":97416422,"name":"neo-python","full_name":"CityOfZion/neo-python","owner":{"login":"CityOfZion","id":29782569,"avatar_url":"https://avatars1.githubusercontent.com/u/29782569?v=4","gravatar_id":"","url":"https://api.github.com/users/CityOfZion","html_url":"https://github.com/CityOfZion","followers_url":"https://api.github.com/users/CityOfZion/followers","following_url":"https://api.github.com/users/CityOfZion/following{/other_user}","gists_url":"https://api.github.com/users/CityOfZion/gists{/gist_id}","starred_url":"https://api.github.com/users/CityOfZion/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CityOfZion/subscriptions","organizations_url":"https://api.github.com/users/CityOfZion/orgs","repos_url":"https://api.github.com/users/CityOfZion/repos","events_url":"https://api.github.com/users/CityOfZion/events{/privacy}","received_events_url":"https://api.github.com/users/CityOfZion/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/CityOfZion/neo-python","description":"Python Node and SDK for the NEO blockchain","fork":false,"url":"https://api.github.com/repos/CityOfZion/neo-python","forks_url":"https://api.github.com/repos/CityOfZion/neo-python/forks","keys_url":"https://api.github.com/repos/CityOfZion/neo-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CityOfZion/neo-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CityOfZion/neo-python/teams","hooks_url":"https://api.github.com/repos/CityOfZion/neo-python/hooks","issue_events_url":"https://api.github.com/repos/CityOfZion/neo-python/issues/events{/number}","events_url":"https://api.github.com/repos/CityOfZion/neo-python/events","assignees_url":"https://api.github.com/repos/CityOfZion/neo-python/assignees{/user}","branches_url":"https://api.github.com/repos/CityOfZion/neo-python/branches{/branch}","tags_url":"https://api.github.com/repos/CityOfZion/neo-python/tags","blobs_url":"https://api.github.com/repos/CityOfZion/neo-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CityOfZion/neo-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CityOfZion/neo-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/CityOfZion/neo-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CityOfZion/neo-python/statuses/{sha}","languages_url":"https://api.github.com/repos/CityOfZion/neo-python/languages","stargazers_url":"https://api.github.com/repos/CityOfZion/neo-python/stargazers","contributors_url":"https://api.github.com/repos/CityOfZion/neo-python/contributors","subscribers_url":"https://api.github.com/repos/CityOfZion/neo-python/subscribers","subscription_url":"https://api.github.com/repos/CityOfZion/neo-python/subscription","commits_url":"https://api.github.com/repos/CityOfZion/neo-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/CityOfZion/neo-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/CityOfZion/neo-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/CityOfZion/neo-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/CityOfZion/neo-python/contents/{+path}","compare_url":"https://api.github.com/repos/CityOfZion/neo-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CityOfZion/neo-python/merges","archive_url":"https://api.github.com/repos/CityOfZion/neo-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CityOfZion/neo-python/downloads","issues_url":"https://api.github.com/repos/CityOfZion/neo-python/issues{/number}","pulls_url":"https://api.github.com/repos/CityOfZion/neo-python/pulls{/number}","milestones_url":"https://api.github.com/repos/CityOfZion/neo-python/milestones{/number}","notifications_url":"https://api.github.com/repos/CityOfZion/neo-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CityOfZion/neo-python/labels{/name}","releases_url":"https://api.github.com/repos/CityOfZion/neo-python/releases{/id}","deployments_url":"https://api.github.com/repos/CityOfZion/neo-python/deployments","created_at":"2017-07-16T23:05:32Z","updated_at":"2018-02-26T23:16:51Z","pushed_at":"2018-02-28T00:40:35Z","git_url":"git://github.com/CityOfZion/neo-python.git","ssh_url":"git@github.com:CityOfZion/neo-python.git","clone_url":"https://github.com/CityOfZion/neo-python.git","svn_url":"https://github.com/CityOfZion/neo-python","homepage":"https://neo-python.readthedocs.io/en/latest/","size":118122,"stargazers_count":123,"watchers_count":123,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":27,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":87,"open_issues":27,"watchers":123,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/266"},"html":{"href":"https://github.com/CityOfZion/neo-python/pull/266"},"issue":{"href":"https://api.github.com/repos/CityOfZion/neo-python/issues/266"},"comments":{"href":"https://api.github.com/repos/CityOfZion/neo-python/issues/266/comments"},"review_comments":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/266/comments"},"review_comment":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CityOfZion/neo-python/pulls/266/commits"},"statuses":{"href":"https://api.github.com/repos/CityOfZion/neo-python/statuses/8904f751fc87b66601becb1dc605f5c0f6cd9b85"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"brianlenz"}}