{"action":"closed","issue":{"url":"https://api.github.com/repos/mui-org/material-ui/issues/10696","repository_url":"https://api.github.com/repos/mui-org/material-ui","labels_url":"https://api.github.com/repos/mui-org/material-ui/issues/10696/labels{/name}","comments_url":"https://api.github.com/repos/mui-org/material-ui/issues/10696/comments","events_url":"https://api.github.com/repos/mui-org/material-ui/issues/10696/events","html_url":"https://github.com/mui-org/material-ui/issues/10696","id":306222279,"number":10696,"title":"defaultValue type errors on number input","user":{"login":"cworf","id":4837717,"avatar_url":"https://avatars2.githubusercontent.com/u/4837717?v=4","gravatar_id":"","url":"https://api.github.com/users/cworf","html_url":"https://github.com/cworf","followers_url":"https://api.github.com/users/cworf/followers","following_url":"https://api.github.com/users/cworf/following{/other_user}","gists_url":"https://api.github.com/users/cworf/gists{/gist_id}","starred_url":"https://api.github.com/users/cworf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cworf/subscriptions","organizations_url":"https://api.github.com/users/cworf/orgs","repos_url":"https://api.github.com/users/cworf/repos","events_url":"https://api.github.com/users/cworf/events{/privacy}","received_events_url":"https://api.github.com/users/cworf/received_events","type":"User","site_admin":false},"labels":[{"id":122764862,"url":"https://api.github.com/repos/mui-org/material-ui/labels/bug","name":"bug","color":"e11d21","default":true},{"id":460201816,"url":"https://api.github.com/repos/mui-org/material-ui/labels/component:%20TextField","name":"component: TextField","color":"ffffff","default":false},{"id":444915427,"url":"https://api.github.com/repos/mui-org/material-ui/labels/good%20first%20issue","name":"good first issue","color":"c2e0c6","default":true}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-18T08:27:12Z","updated_at":"2018-03-18T13:57:06Z","closed_at":"2018-03-18T13:57:06Z","author_association":"NONE","body":"Im receiving an error \r\n`Warning: Failed prop type: Invalid prop 'defaultValue' of type 'number' supplied to 'TextField', expected 'string'.`\r\n\r\non the following code:\r\n\r\n```jsx\r\nconst thisValue = 5;\r\nconst type = number;\r\n\r\nreturn <TextField\r\n            id={field}\r\n            label={!noLabel ? field : null}\r\n            type={type}\r\n            defaultValue={thisValue}\r\n            className={classes.textField}\r\n            margin=\"normal\"\r\n            multiline={type === 'text' ? true : false}\r\n            rowsMax=\"4\"\r\n            onChange={this.handleInputChange}\r\n            InputLabelProps={{\r\n            shrink: type === 'text' ? false : true,\r\n          }}\r\n/>\r\n```\r\n\r\nThis makes no sense as it is a text field of `type='number` ... am I missing some sort of best practices here?"}}
{"actor":{"display_login":"oliviertassinari"}}