{"action":"closed","issue":{"url":"https://api.github.com/repos/mtesseract/nakadi-client/issues/103","repository_url":"https://api.github.com/repos/mtesseract/nakadi-client","labels_url":"https://api.github.com/repos/mtesseract/nakadi-client/issues/103/labels{/name}","comments_url":"https://api.github.com/repos/mtesseract/nakadi-client/issues/103/comments","events_url":"https://api.github.com/repos/mtesseract/nakadi-client/issues/103/events","html_url":"https://github.com/mtesseract/nakadi-client/issues/103","id":333622275,"node_id":"MDU6SXNzdWUzMzM2MjIyNzU=","number":103,"title":"Use seperate data types for Subscriptions-to-be-created and Subscriptions-already-created","user":{"login":"mtesseract","id":11706080,"node_id":"MDQ6VXNlcjExNzA2MDgw","avatar_url":"https://avatars0.githubusercontent.com/u/11706080?v=4","gravatar_id":"","url":"https://api.github.com/users/mtesseract","html_url":"https://github.com/mtesseract","followers_url":"https://api.github.com/users/mtesseract/followers","following_url":"https://api.github.com/users/mtesseract/following{/other_user}","gists_url":"https://api.github.com/users/mtesseract/gists{/gist_id}","starred_url":"https://api.github.com/users/mtesseract/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mtesseract/subscriptions","organizations_url":"https://api.github.com/users/mtesseract/orgs","repos_url":"https://api.github.com/users/mtesseract/repos","events_url":"https://api.github.com/users/mtesseract/events{/privacy}","received_events_url":"https://api.github.com/users/mtesseract/received_events","type":"User","site_admin":false},"labels":[{"id":655713022,"node_id":"MDU6TGFiZWw2NTU3MTMwMjI=","url":"https://api.github.com/repos/mtesseract/nakadi-client/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":811161914,"node_id":"MDU6TGFiZWw4MTExNjE5MTQ=","url":"https://api.github.com/repos/mtesseract/nakadi-client/labels/good%20first%20issue","name":"good first issue","color":"781cb5","default":true},{"id":966114439,"node_id":"MDU6TGFiZWw5NjYxMTQ0Mzk=","url":"https://api.github.com/repos/mtesseract/nakadi-client/labels/idea","name":"idea","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-19T11:02:08Z","updated_at":"2018-06-28T08:09:51Z","closed_at":"2018-06-28T08:09:51Z","author_association":"OWNER","body":"Currently these two cases are handled by the same data type \"Subscription\". It's field \"id\" (a Subscription ID) is optional. Which is, of course, a poor attempt at covering these two different use-cases.\r\n\r\nWhen creating a subscription the field \"id\" should not be provided, not even `Nothing`. When an existing subscription is returned it should contained a mandatory subscription ID, not a `Maybe`.\r\n\r\nIt probably makes sense to come with two distinct data type names and use them accordingly.\r\n"}}
{"actor":{"display_login":"mtesseract"}}