{"action":"closed","number":40,"pull_request":{"url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls/40","id":178647005,"html_url":"https://github.com/FormidableLabs/eslint-config-formidable/pull/40","diff_url":"https://github.com/FormidableLabs/eslint-config-formidable/pull/40.diff","patch_url":"https://github.com/FormidableLabs/eslint-config-formidable/pull/40.patch","issue_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues/40","number":40,"state":"closed","locked":false,"title":"Improvements to promise and import and return rules","user":{"login":"chrisbolin","id":2822048,"avatar_url":"https://avatars2.githubusercontent.com/u/2822048?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisbolin","html_url":"https://github.com/chrisbolin","followers_url":"https://api.github.com/users/chrisbolin/followers","following_url":"https://api.github.com/users/chrisbolin/following{/other_user}","gists_url":"https://api.github.com/users/chrisbolin/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbolin/subscriptions","organizations_url":"https://api.github.com/users/chrisbolin/orgs","repos_url":"https://api.github.com/users/chrisbolin/repos","events_url":"https://api.github.com/users/chrisbolin/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbolin/received_events","type":"User","site_admin":false},"body":"based on current formidable configs, e.g. https://github.com/FormidableLabs/louder-cloud/blob/master/.eslintrc#L10-L21\r\n\r\n- add promise rules\r\n- add options to consistent-return and import/no-unresolved\r\n- fix bug in `configurations/off.js` - we forgot to turn off `import` and `filename` rules that `es5.js` turns on","created_at":"2018-03-30T22:33:54Z","updated_at":"2018-04-02T16:25:08Z","closed_at":"2018-04-02T16:25:08Z","merged_at":"2018-04-02T16:25:08Z","merge_commit_sha":"1ffefb79834ef382a6b0b3bfcd4121423d91392f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls/40/commits","review_comments_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls/40/comments","review_comment_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues/40/comments","statuses_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/statuses/fa626a5014ed6b59c50cfe4c8ae5118a9563eded","head":{"label":"FormidableLabs:improvements-to-promise-and-import-and-return-rules","ref":"improvements-to-promise-and-import-and-return-rules","sha":"fa626a5014ed6b59c50cfe4c8ae5118a9563eded","user":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars3.githubusercontent.com/u/5078602?v=4","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":64498594,"name":"eslint-config-formidable","full_name":"FormidableLabs/eslint-config-formidable","owner":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars3.githubusercontent.com/u/5078602?v=4","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FormidableLabs/eslint-config-formidable","description":"A set of default eslint configurations from Formidable","fork":false,"url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable","forks_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/forks","keys_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/events","assignees_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/merges","archive_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/deployments","created_at":"2016-07-29T17:29:08Z","updated_at":"2018-04-02T16:24:11Z","pushed_at":"2018-04-02T16:25:08Z","git_url":"git://github.com/FormidableLabs/eslint-config-formidable.git","ssh_url":"git@github.com:FormidableLabs/eslint-config-formidable.git","clone_url":"https://github.com/FormidableLabs/eslint-config-formidable.git","svn_url":"https://github.com/FormidableLabs/eslint-config-formidable","homepage":"","size":361,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":20,"default_branch":"master"}},"base":{"label":"FormidableLabs:master","ref":"master","sha":"11c789aad0cece748bfe583c82a62b6c4029789c","user":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars3.githubusercontent.com/u/5078602?v=4","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":64498594,"name":"eslint-config-formidable","full_name":"FormidableLabs/eslint-config-formidable","owner":{"login":"FormidableLabs","id":5078602,"avatar_url":"https://avatars3.githubusercontent.com/u/5078602?v=4","gravatar_id":"","url":"https://api.github.com/users/FormidableLabs","html_url":"https://github.com/FormidableLabs","followers_url":"https://api.github.com/users/FormidableLabs/followers","following_url":"https://api.github.com/users/FormidableLabs/following{/other_user}","gists_url":"https://api.github.com/users/FormidableLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/FormidableLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FormidableLabs/subscriptions","organizations_url":"https://api.github.com/users/FormidableLabs/orgs","repos_url":"https://api.github.com/users/FormidableLabs/repos","events_url":"https://api.github.com/users/FormidableLabs/events{/privacy}","received_events_url":"https://api.github.com/users/FormidableLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FormidableLabs/eslint-config-formidable","description":"A set of default eslint configurations from Formidable","fork":false,"url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable","forks_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/forks","keys_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/teams","hooks_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/hooks","issue_events_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues/events{/number}","events_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/events","assignees_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/assignees{/user}","branches_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/branches{/branch}","tags_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/tags","blobs_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/refs{/sha}","trees_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/statuses/{sha}","languages_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/languages","stargazers_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/stargazers","contributors_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/contributors","subscribers_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/subscribers","subscription_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/subscription","commits_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/commits{/sha}","git_commits_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/git/commits{/sha}","comments_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/comments{/number}","issue_comment_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues/comments{/number}","contents_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/contents/{+path}","compare_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/merges","archive_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/downloads","issues_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues{/number}","pulls_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls{/number}","milestones_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/milestones{/number}","notifications_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/labels{/name}","releases_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/releases{/id}","deployments_url":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/deployments","created_at":"2016-07-29T17:29:08Z","updated_at":"2018-04-02T16:24:11Z","pushed_at":"2018-04-02T16:25:08Z","git_url":"git://github.com/FormidableLabs/eslint-config-formidable.git","ssh_url":"git@github.com:FormidableLabs/eslint-config-formidable.git","clone_url":"https://github.com/FormidableLabs/eslint-config-formidable.git","svn_url":"https://github.com/FormidableLabs/eslint-config-formidable","homepage":"","size":361,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":6,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls/40"},"html":{"href":"https://github.com/FormidableLabs/eslint-config-formidable/pull/40"},"issue":{"href":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues/40"},"comments":{"href":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/issues/40/comments"},"review_comments":{"href":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls/40/comments"},"review_comment":{"href":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/pulls/40/commits"},"statuses":{"href":"https://api.github.com/repos/FormidableLabs/eslint-config-formidable/statuses/fa626a5014ed6b59c50cfe4c8ae5118a9563eded"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"chrisbolin","id":2822048,"avatar_url":"https://avatars2.githubusercontent.com/u/2822048?v=4","gravatar_id":"","url":"https://api.github.com/users/chrisbolin","html_url":"https://github.com/chrisbolin","followers_url":"https://api.github.com/users/chrisbolin/followers","following_url":"https://api.github.com/users/chrisbolin/following{/other_user}","gists_url":"https://api.github.com/users/chrisbolin/gists{/gist_id}","starred_url":"https://api.github.com/users/chrisbolin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chrisbolin/subscriptions","organizations_url":"https://api.github.com/users/chrisbolin/orgs","repos_url":"https://api.github.com/users/chrisbolin/repos","events_url":"https://api.github.com/users/chrisbolin/events{/privacy}","received_events_url":"https://api.github.com/users/chrisbolin/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":63,"deletions":4,"changed_files":7}}
{"actor":{"display_login":"chrisbolin"}}