{"action":"closed","number":7,"pull_request":{"url":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls/7","id":233903749,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTAzNzQ5","html_url":"https://github.com/quipper/react-native-i18n-ts/pull/7","diff_url":"https://github.com/quipper/react-native-i18n-ts/pull/7.diff","patch_url":"https://github.com/quipper/react-native-i18n-ts/pull/7.patch","issue_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues/7","number":7,"state":"closed","locked":false,"title":"Improve: change return type to string literal","user":{"login":"hotchemi","id":471318,"node_id":"MDQ6VXNlcjQ3MTMxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/471318?v=4","gravatar_id":"","url":"https://api.github.com/users/hotchemi","html_url":"https://github.com/hotchemi","followers_url":"https://api.github.com/users/hotchemi/followers","following_url":"https://api.github.com/users/hotchemi/following{/other_user}","gists_url":"https://api.github.com/users/hotchemi/gists{/gist_id}","starred_url":"https://api.github.com/users/hotchemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hotchemi/subscriptions","organizations_url":"https://api.github.com/users/hotchemi/orgs","repos_url":"https://api.github.com/users/hotchemi/repos","events_url":"https://api.github.com/users/hotchemi/events{/privacy}","received_events_url":"https://api.github.com/users/hotchemi/received_events","type":"User","site_admin":false},"body":"## Overview\r\n\r\nThis PR improves traceability between string resource and type definition file.\r\n\r\nFor now, you can figure out **which key exists in string resource** but can't discover a relation between key and value.\r\n\r\nIt means you may have to move around resource json file and view every time you want to use new string resource..to solve the problem this PR changes return type to string literal, now you can leverage IDE power!\r\n\r\n<img width=\"742\" alt=\"screen shot 2018-11-27 at 21 55 13\" src=\"https://user-images.githubusercontent.com/471318/49083260-74493500-f28f-11e8-8513-3f2e95e5f85f.png\">\r\n\r\nGenerated file would be like below.\r\n\r\n```diff\r\ndeclare module \"react-native-i18n\" {\r\n    var fallbacks: boolean;\r\n    var translations: {\r\n        [keys: string]: any;\r\n    };\r\n-    function t(key: \"title\"): string;\r\n+    function t(key: \"title\"): 'Example';\r\n}\r\n```","created_at":"2018-11-27T13:05:53Z","updated_at":"2018-11-28T14:38:03Z","closed_at":"2018-11-28T14:38:03Z","merged_at":"2018-11-28T14:38:03Z","merge_commit_sha":"8ad3b2c13d0e804bfca644f8a280abb62e87f174","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls/7/commits","review_comments_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls/7/comments","review_comment_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues/7/comments","statuses_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/statuses/28434f358f9e9ec853db162d96c66dffe926e565","head":{"label":"quipper:string_literal","ref":"string_literal","sha":"28434f358f9e9ec853db162d96c66dffe926e565","user":{"login":"quipper","id":535481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNTQ4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/535481?v=4","gravatar_id":"","url":"https://api.github.com/users/quipper","html_url":"https://github.com/quipper","followers_url":"https://api.github.com/users/quipper/followers","following_url":"https://api.github.com/users/quipper/following{/other_user}","gists_url":"https://api.github.com/users/quipper/gists{/gist_id}","starred_url":"https://api.github.com/users/quipper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quipper/subscriptions","organizations_url":"https://api.github.com/users/quipper/orgs","repos_url":"https://api.github.com/users/quipper/repos","events_url":"https://api.github.com/users/quipper/events{/privacy}","received_events_url":"https://api.github.com/users/quipper/received_events","type":"Organization","site_admin":false},"repo":{"id":131988886,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5ODg4ODY=","name":"react-native-i18n-ts","full_name":"quipper/react-native-i18n-ts","private":false,"owner":{"login":"quipper","id":535481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNTQ4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/535481?v=4","gravatar_id":"","url":"https://api.github.com/users/quipper","html_url":"https://github.com/quipper","followers_url":"https://api.github.com/users/quipper/followers","following_url":"https://api.github.com/users/quipper/following{/other_user}","gists_url":"https://api.github.com/users/quipper/gists{/gist_id}","starred_url":"https://api.github.com/users/quipper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quipper/subscriptions","organizations_url":"https://api.github.com/users/quipper/orgs","repos_url":"https://api.github.com/users/quipper/repos","events_url":"https://api.github.com/users/quipper/events{/privacy}","received_events_url":"https://api.github.com/users/quipper/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/quipper/react-native-i18n-ts","description":"A d.ts file generator for react-native-i18n.","fork":false,"url":"https://api.github.com/repos/quipper/react-native-i18n-ts","forks_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/forks","keys_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/teams","hooks_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/hooks","issue_events_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues/events{/number}","events_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/events","assignees_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/assignees{/user}","branches_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/branches{/branch}","tags_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/tags","blobs_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/statuses/{sha}","languages_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/languages","stargazers_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/stargazers","contributors_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/contributors","subscribers_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/subscribers","subscription_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/subscription","commits_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/contents/{+path}","compare_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/merges","archive_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/downloads","issues_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues{/number}","pulls_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls{/number}","milestones_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/milestones{/number}","notifications_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/labels{/name}","releases_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/releases{/id}","deployments_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/deployments","created_at":"2018-05-03T12:02:58Z","updated_at":"2018-11-22T04:49:16Z","pushed_at":"2018-11-28T14:38:03Z","git_url":"git://github.com/quipper/react-native-i18n-ts.git","ssh_url":"git@github.com:quipper/react-native-i18n-ts.git","clone_url":"https://github.com/quipper/react-native-i18n-ts.git","svn_url":"https://github.com/quipper/react-native-i18n-ts","homepage":"","size":980,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":25,"default_branch":"master"}},"base":{"label":"quipper:master","ref":"master","sha":"5b14ab27132ca8bf6ecc030d56870decd6817384","user":{"login":"quipper","id":535481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNTQ4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/535481?v=4","gravatar_id":"","url":"https://api.github.com/users/quipper","html_url":"https://github.com/quipper","followers_url":"https://api.github.com/users/quipper/followers","following_url":"https://api.github.com/users/quipper/following{/other_user}","gists_url":"https://api.github.com/users/quipper/gists{/gist_id}","starred_url":"https://api.github.com/users/quipper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quipper/subscriptions","organizations_url":"https://api.github.com/users/quipper/orgs","repos_url":"https://api.github.com/users/quipper/repos","events_url":"https://api.github.com/users/quipper/events{/privacy}","received_events_url":"https://api.github.com/users/quipper/received_events","type":"Organization","site_admin":false},"repo":{"id":131988886,"node_id":"MDEwOlJlcG9zaXRvcnkxMzE5ODg4ODY=","name":"react-native-i18n-ts","full_name":"quipper/react-native-i18n-ts","private":false,"owner":{"login":"quipper","id":535481,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUzNTQ4MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/535481?v=4","gravatar_id":"","url":"https://api.github.com/users/quipper","html_url":"https://github.com/quipper","followers_url":"https://api.github.com/users/quipper/followers","following_url":"https://api.github.com/users/quipper/following{/other_user}","gists_url":"https://api.github.com/users/quipper/gists{/gist_id}","starred_url":"https://api.github.com/users/quipper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quipper/subscriptions","organizations_url":"https://api.github.com/users/quipper/orgs","repos_url":"https://api.github.com/users/quipper/repos","events_url":"https://api.github.com/users/quipper/events{/privacy}","received_events_url":"https://api.github.com/users/quipper/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/quipper/react-native-i18n-ts","description":"A d.ts file generator for react-native-i18n.","fork":false,"url":"https://api.github.com/repos/quipper/react-native-i18n-ts","forks_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/forks","keys_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/teams","hooks_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/hooks","issue_events_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues/events{/number}","events_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/events","assignees_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/assignees{/user}","branches_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/branches{/branch}","tags_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/tags","blobs_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/refs{/sha}","trees_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/statuses/{sha}","languages_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/languages","stargazers_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/stargazers","contributors_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/contributors","subscribers_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/subscribers","subscription_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/subscription","commits_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/commits{/sha}","git_commits_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/git/commits{/sha}","comments_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/comments{/number}","issue_comment_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues/comments{/number}","contents_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/contents/{+path}","compare_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/merges","archive_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/downloads","issues_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues{/number}","pulls_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls{/number}","milestones_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/milestones{/number}","notifications_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/labels{/name}","releases_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/releases{/id}","deployments_url":"https://api.github.com/repos/quipper/react-native-i18n-ts/deployments","created_at":"2018-05-03T12:02:58Z","updated_at":"2018-11-22T04:49:16Z","pushed_at":"2018-11-28T14:38:03Z","git_url":"git://github.com/quipper/react-native-i18n-ts.git","ssh_url":"git@github.com:quipper/react-native-i18n-ts.git","clone_url":"https://github.com/quipper/react-native-i18n-ts.git","svn_url":"https://github.com/quipper/react-native-i18n-ts","homepage":"","size":980,"stargazers_count":25,"watchers_count":25,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":2,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls/7"},"html":{"href":"https://github.com/quipper/react-native-i18n-ts/pull/7"},"issue":{"href":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues/7"},"comments":{"href":"https://api.github.com/repos/quipper/react-native-i18n-ts/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/quipper/react-native-i18n-ts/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/quipper/react-native-i18n-ts/statuses/28434f358f9e9ec853db162d96c66dffe926e565"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"hotchemi","id":471318,"node_id":"MDQ6VXNlcjQ3MTMxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/471318?v=4","gravatar_id":"","url":"https://api.github.com/users/hotchemi","html_url":"https://github.com/hotchemi","followers_url":"https://api.github.com/users/hotchemi/followers","following_url":"https://api.github.com/users/hotchemi/following{/other_user}","gists_url":"https://api.github.com/users/hotchemi/gists{/gist_id}","starred_url":"https://api.github.com/users/hotchemi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hotchemi/subscriptions","organizations_url":"https://api.github.com/users/hotchemi/orgs","repos_url":"https://api.github.com/users/hotchemi/repos","events_url":"https://api.github.com/users/hotchemi/events{/privacy}","received_events_url":"https://api.github.com/users/hotchemi/received_events","type":"User","site_admin":false},"comments":0,"review_comments":2,"maintainer_can_modify":false,"commits":1,"additions":13,"deletions":7,"changed_files":7}}
{"actor":{"display_login":"hotchemi"}}