{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/216127072","pull_request_review_id":153550331,"id":216127072,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjEyNzA3Mg==","diff_hunk":"@@ -14,9 +14,18 @@\n use Symfony\\Component\\Form\\AbstractType;\n use Symfony\\Component\\Form\\FormInterface;\n use Symfony\\Component\\Form\\FormView;\n+use Symfony\\Component\\OptionsResolver\\OptionsResolver;\n \n class TextareaType extends AbstractType\n {\n+    /**\n+     * {@inheritdoc}\n+     */\n+    public function configureOptions(OptionsResolver $resolver)\n+    {\n+        $resolver->setDefault('invalid_message', 'The text area is invalid.');","path":"src/Symfony/Component/Form/Extension/Core/Type/TextareaType.php","position":13,"original_position":13,"commit_id":"48b4155e5daec202c5344cfc830d940fd6a4c1ca","original_commit_id":"48b4155e5daec202c5344cfc830d940fd6a4c1ca","user":{"login":"ro0NL","id":1047696,"node_id":"MDQ6VXNlcjEwNDc2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1047696?v=4","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"body":"i think we can keep the default value here no? same for `text` and other generic types","created_at":"2018-09-08T10:26:58Z","updated_at":"2018-09-08T10:26:58Z","html_url":"https://github.com/symfony/symfony/pull/27142#discussion_r216127072","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/27142","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/216127072"},"html":{"href":"https://github.com/symfony/symfony/pull/27142#discussion_r216127072"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27142"}}},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/27142","id":185824727,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1ODI0NzI3","html_url":"https://github.com/symfony/symfony/pull/27142","diff_url":"https://github.com/symfony/symfony/pull/27142.diff","patch_url":"https://github.com/symfony/symfony/pull/27142.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/27142","number":27142,"state":"open","locked":false,"title":"[Form] Improve invalid messages for form types","user":{"login":"hiddewie","id":1073881,"node_id":"MDQ6VXNlcjEwNzM4ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1073881?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddewie","html_url":"https://github.com/hiddewie","followers_url":"https://api.github.com/users/hiddewie/followers","following_url":"https://api.github.com/users/hiddewie/following{/other_user}","gists_url":"https://api.github.com/users/hiddewie/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddewie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddewie/subscriptions","organizations_url":"https://api.github.com/users/hiddewie/orgs","repos_url":"https://api.github.com/users/hiddewie/repos","events_url":"https://api.github.com/users/hiddewie/events{/privacy}","received_events_url":"https://api.github.com/users/hiddewie/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Bug fix?      |  no\r\n| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->\r\n| BC breaks?    | no     <!-- see https://symfony.com/bc -->\r\n| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->\r\n| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->\r\n| Fixed tickets | #5946   <!-- #-prefixed issue number(s), if any -->\r\n| License       | MIT\r\n\r\nImprovement of #14106. Added `invalid_message` fields to all form types. This gives better errors to users instead of the default *Invalid value* error.","created_at":"2018-05-03T20:10:59Z","updated_at":"2018-09-08T10:26:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"30b3525a63f91285bca2505d9fae0c7a79b6269d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":99594,"node_id":"MDU6TGFiZWw5OTU5NA==","url":"https://api.github.com/repos/symfony/symfony/labels/Form","name":"Form","color":"DDDDDD","default":false},{"id":238909857,"node_id":"MDU6TGFiZWwyMzg5MDk4NTc=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Work","name":"Status: Needs Work","color":"fad8c7","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":138,"closed_issues":209,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-09-08T07:29:39Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/27142/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/27142/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/27142/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/48b4155e5daec202c5344cfc830d940fd6a4c1ca","head":{"label":"hiddewie:better-invalid-messages","ref":"better-invalid-messages","sha":"48b4155e5daec202c5344cfc830d940fd6a4c1ca","user":{"login":"hiddewie","id":1073881,"node_id":"MDQ6VXNlcjEwNzM4ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1073881?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddewie","html_url":"https://github.com/hiddewie","followers_url":"https://api.github.com/users/hiddewie/followers","following_url":"https://api.github.com/users/hiddewie/following{/other_user}","gists_url":"https://api.github.com/users/hiddewie/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddewie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddewie/subscriptions","organizations_url":"https://api.github.com/users/hiddewie/orgs","repos_url":"https://api.github.com/users/hiddewie/repos","events_url":"https://api.github.com/users/hiddewie/events{/privacy}","received_events_url":"https://api.github.com/users/hiddewie/received_events","type":"User","site_admin":false},"repo":{"id":31769177,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc2OTE3Nw==","name":"symfony","full_name":"hiddewie/symfony","owner":{"login":"hiddewie","id":1073881,"node_id":"MDQ6VXNlcjEwNzM4ODE=","avatar_url":"https://avatars3.githubusercontent.com/u/1073881?v=4","gravatar_id":"","url":"https://api.github.com/users/hiddewie","html_url":"https://github.com/hiddewie","followers_url":"https://api.github.com/users/hiddewie/followers","following_url":"https://api.github.com/users/hiddewie/following{/other_user}","gists_url":"https://api.github.com/users/hiddewie/gists{/gist_id}","starred_url":"https://api.github.com/users/hiddewie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiddewie/subscriptions","organizations_url":"https://api.github.com/users/hiddewie/orgs","repos_url":"https://api.github.com/users/hiddewie/repos","events_url":"https://api.github.com/users/hiddewie/events{/privacy}","received_events_url":"https://api.github.com/users/hiddewie/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hiddewie/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/hiddewie/symfony","forks_url":"https://api.github.com/repos/hiddewie/symfony/forks","keys_url":"https://api.github.com/repos/hiddewie/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hiddewie/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hiddewie/symfony/teams","hooks_url":"https://api.github.com/repos/hiddewie/symfony/hooks","issue_events_url":"https://api.github.com/repos/hiddewie/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/hiddewie/symfony/events","assignees_url":"https://api.github.com/repos/hiddewie/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/hiddewie/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/hiddewie/symfony/tags","blobs_url":"https://api.github.com/repos/hiddewie/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hiddewie/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hiddewie/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/hiddewie/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hiddewie/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/hiddewie/symfony/languages","stargazers_url":"https://api.github.com/repos/hiddewie/symfony/stargazers","contributors_url":"https://api.github.com/repos/hiddewie/symfony/contributors","subscribers_url":"https://api.github.com/repos/hiddewie/symfony/subscribers","subscription_url":"https://api.github.com/repos/hiddewie/symfony/subscription","commits_url":"https://api.github.com/repos/hiddewie/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/hiddewie/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/hiddewie/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/hiddewie/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/hiddewie/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/hiddewie/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hiddewie/symfony/merges","archive_url":"https://api.github.com/repos/hiddewie/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hiddewie/symfony/downloads","issues_url":"https://api.github.com/repos/hiddewie/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/hiddewie/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/hiddewie/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/hiddewie/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hiddewie/symfony/labels{/name}","releases_url":"https://api.github.com/repos/hiddewie/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/hiddewie/symfony/deployments","created_at":"2015-03-06T12:54:27Z","updated_at":"2016-10-03T12:46:48Z","pushed_at":"2018-09-08T10:18:47Z","git_url":"git://github.com/hiddewie/symfony.git","ssh_url":"git@github.com:hiddewie/symfony.git","clone_url":"https://github.com/hiddewie/symfony.git","svn_url":"https://github.com/hiddewie/symfony","homepage":"symfony.com","size":112365,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"2.7"}},"base":{"label":"symfony:master","ref":"master","sha":"f6b4dc94d1ff450f85b7f3cea4a8df5ae55e4f1a","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-09-08T07:29:42Z","pushed_at":"2018-09-08T10:18:55Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":124136,"stargazers_count":18517,"watchers_count":18517,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6386,"mirror_url":null,"archived":false,"open_issues_count":914,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6386,"open_issues":914,"watchers":18517,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27142"},"html":{"href":"https://github.com/symfony/symfony/pull/27142"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/27142"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/27142/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27142/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/27142/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/48b4155e5daec202c5344cfc830d940fd6a4c1ca"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ro0NL"}}