{"action":"created","comment":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/169741267","pull_request_review_id":98315732,"id":169741267,"diff_hunk":"@@ -514,4 +514,22 @@ angular.module('openshiftConsole')\n     return function(feature) {\n       return _.get(Constants, ['ENABLE_TECH_PREVIEW_FEATURE', feature], false);\n     };\n-  });\n+  })\n+  .filter('mobileClientIconClass', function() {\n+    return function(mobileClientResource) {\n+      var clientIcon = _.get(mobileClientResource, 'metadata.labels.icon');\n+      var clientType = _.get(mobileClientResource, 'spec.clientType');\n+      switch (clientType) {\n+        case 'android':\n+        case 'iOS':\n+          clientIcon = 'fa ' + clientIcon;","path":"app/scripts/filters/util.js","position":13,"original_position":13,"commit_id":"65ed533284ddf45bba785c3a54f3c67660507fe1","original_commit_id":"65ed533284ddf45bba785c3a54f3c67660507fe1","user":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"body":"I don't think we should make assumptions about the kind of icon. It would be better if we can have the full icon class like `fa fa-foo` if possible in an annotation.","created_at":"2018-02-21T18:53:45Z","updated_at":"2018-02-21T18:57:50Z","html_url":"https://github.com/openshift/origin-web-console/pull/2838#discussion_r169741267","pull_request_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/2838","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments/169741267"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/2838#discussion_r169741267"},"pull_request":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/2838"}}},"pull_request":{"url":"https://api.github.com/repos/openshift/origin-web-console/pulls/2838","id":170553202,"html_url":"https://github.com/openshift/origin-web-console/pull/2838","diff_url":"https://github.com/openshift/origin-web-console/pull/2838.diff","patch_url":"https://github.com/openshift/origin-web-console/pull/2838.patch","issue_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2838","number":2838,"state":"open","locked":false,"title":"[WIP] allow viewing mobile clients in the overview screen","user":{"login":"maleck13","id":304628,"avatar_url":"https://avatars2.githubusercontent.com/u/304628?v=4","gravatar_id":"","url":"https://api.github.com/users/maleck13","html_url":"https://github.com/maleck13","followers_url":"https://api.github.com/users/maleck13/followers","following_url":"https://api.github.com/users/maleck13/following{/other_user}","gists_url":"https://api.github.com/users/maleck13/gists{/gist_id}","starred_url":"https://api.github.com/users/maleck13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maleck13/subscriptions","organizations_url":"https://api.github.com/users/maleck13/orgs","repos_url":"https://api.github.com/users/maleck13/repos","events_url":"https://api.github.com/users/maleck13/events{/privacy}","received_events_url":"https://api.github.com/users/maleck13/received_events","type":"User","site_admin":false},"body":"This is an initial PR focused around show mobile clients in the overview screen. Covered under the following issue:\r\nhttps://github.com/openshift/origin-web-console/issues/2835\r\n\r\n**Note to reviewer**\r\n\r\nLooking for guidance here on approach and changes made. Happy to change based on feedback","created_at":"2018-02-21T18:35:44Z","updated_at":"2018-02-21T18:57:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8d7708bf310d2def0f1008620d17d426cefd164f","assignee":{"login":"spadgett","id":1167259,"avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false},"assignees":[{"login":"spadgett","id":1167259,"avatar_url":"https://avatars1.githubusercontent.com/u/1167259?v=4","gravatar_id":"","url":"https://api.github.com/users/spadgett","html_url":"https://github.com/spadgett","followers_url":"https://api.github.com/users/spadgett/followers","following_url":"https://api.github.com/users/spadgett/following{/other_user}","gists_url":"https://api.github.com/users/spadgett/gists{/gist_id}","starred_url":"https://api.github.com/users/spadgett/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/spadgett/subscriptions","organizations_url":"https://api.github.com/users/spadgett/orgs","repos_url":"https://api.github.com/users/spadgett/repos","events_url":"https://api.github.com/users/spadgett/events{/privacy}","received_events_url":"https://api.github.com/users/spadgett/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":711569770,"url":"https://api.github.com/repos/openshift/origin-web-console/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":711766287,"url":"https://api.github.com/repos/openshift/origin-web-console/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/2838/commits","review_comments_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/2838/comments","review_comment_url":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/issues/2838/comments","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/65ed533284ddf45bba785c3a54f3c67660507fe1","head":{"label":"aerogear:issue-2835-view-mobileclient-overview","ref":"issue-2835-view-mobileclient-overview","sha":"65ed533284ddf45bba785c3a54f3c67660507fe1","user":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"repo":{"id":121731677,"name":"origin-web-console","full_name":"aerogear/origin-web-console","owner":{"login":"aerogear","id":954205,"avatar_url":"https://avatars1.githubusercontent.com/u/954205?v=4","gravatar_id":"","url":"https://api.github.com/users/aerogear","html_url":"https://github.com/aerogear","followers_url":"https://api.github.com/users/aerogear/followers","following_url":"https://api.github.com/users/aerogear/following{/other_user}","gists_url":"https://api.github.com/users/aerogear/gists{/gist_id}","starred_url":"https://api.github.com/users/aerogear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aerogear/subscriptions","organizations_url":"https://api.github.com/users/aerogear/orgs","repos_url":"https://api.github.com/users/aerogear/repos","events_url":"https://api.github.com/users/aerogear/events{/privacy}","received_events_url":"https://api.github.com/users/aerogear/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aerogear/origin-web-console","description":null,"fork":true,"url":"https://api.github.com/repos/aerogear/origin-web-console","forks_url":"https://api.github.com/repos/aerogear/origin-web-console/forks","keys_url":"https://api.github.com/repos/aerogear/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aerogear/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aerogear/origin-web-console/teams","hooks_url":"https://api.github.com/repos/aerogear/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/aerogear/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/aerogear/origin-web-console/events","assignees_url":"https://api.github.com/repos/aerogear/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/aerogear/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/aerogear/origin-web-console/tags","blobs_url":"https://api.github.com/repos/aerogear/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aerogear/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aerogear/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/aerogear/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aerogear/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/aerogear/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/aerogear/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/aerogear/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/aerogear/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/aerogear/origin-web-console/subscription","commits_url":"https://api.github.com/repos/aerogear/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/aerogear/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/aerogear/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/aerogear/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/aerogear/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/aerogear/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aerogear/origin-web-console/merges","archive_url":"https://api.github.com/repos/aerogear/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aerogear/origin-web-console/downloads","issues_url":"https://api.github.com/repos/aerogear/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/aerogear/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/aerogear/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/aerogear/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aerogear/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/aerogear/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/aerogear/origin-web-console/deployments","created_at":"2018-02-16T09:06:45Z","updated_at":"2018-02-16T09:06:49Z","pushed_at":"2018-02-21T18:33:23Z","git_url":"git://github.com/aerogear/origin-web-console.git","ssh_url":"git@github.com:aerogear/origin-web-console.git","clone_url":"https://github.com/aerogear/origin-web-console.git","svn_url":"https://github.com/aerogear/origin-web-console","homepage":null,"size":69418,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"openshift:master","ref":"master","sha":"49a7d0dbc548a82fa1cc0b8f50213ed2531eb3dc","user":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"repo":{"id":58488264,"name":"origin-web-console","full_name":"openshift/origin-web-console","owner":{"login":"openshift","id":792337,"avatar_url":"https://avatars3.githubusercontent.com/u/792337?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift","html_url":"https://github.com/openshift","followers_url":"https://api.github.com/users/openshift/followers","following_url":"https://api.github.com/users/openshift/following{/other_user}","gists_url":"https://api.github.com/users/openshift/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift/subscriptions","organizations_url":"https://api.github.com/users/openshift/orgs","repos_url":"https://api.github.com/users/openshift/repos","events_url":"https://api.github.com/users/openshift/events{/privacy}","received_events_url":"https://api.github.com/users/openshift/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openshift/origin-web-console","description":null,"fork":false,"url":"https://api.github.com/repos/openshift/origin-web-console","forks_url":"https://api.github.com/repos/openshift/origin-web-console/forks","keys_url":"https://api.github.com/repos/openshift/origin-web-console/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openshift/origin-web-console/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openshift/origin-web-console/teams","hooks_url":"https://api.github.com/repos/openshift/origin-web-console/hooks","issue_events_url":"https://api.github.com/repos/openshift/origin-web-console/issues/events{/number}","events_url":"https://api.github.com/repos/openshift/origin-web-console/events","assignees_url":"https://api.github.com/repos/openshift/origin-web-console/assignees{/user}","branches_url":"https://api.github.com/repos/openshift/origin-web-console/branches{/branch}","tags_url":"https://api.github.com/repos/openshift/origin-web-console/tags","blobs_url":"https://api.github.com/repos/openshift/origin-web-console/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openshift/origin-web-console/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openshift/origin-web-console/git/refs{/sha}","trees_url":"https://api.github.com/repos/openshift/origin-web-console/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openshift/origin-web-console/statuses/{sha}","languages_url":"https://api.github.com/repos/openshift/origin-web-console/languages","stargazers_url":"https://api.github.com/repos/openshift/origin-web-console/stargazers","contributors_url":"https://api.github.com/repos/openshift/origin-web-console/contributors","subscribers_url":"https://api.github.com/repos/openshift/origin-web-console/subscribers","subscription_url":"https://api.github.com/repos/openshift/origin-web-console/subscription","commits_url":"https://api.github.com/repos/openshift/origin-web-console/commits{/sha}","git_commits_url":"https://api.github.com/repos/openshift/origin-web-console/git/commits{/sha}","comments_url":"https://api.github.com/repos/openshift/origin-web-console/comments{/number}","issue_comment_url":"https://api.github.com/repos/openshift/origin-web-console/issues/comments{/number}","contents_url":"https://api.github.com/repos/openshift/origin-web-console/contents/{+path}","compare_url":"https://api.github.com/repos/openshift/origin-web-console/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openshift/origin-web-console/merges","archive_url":"https://api.github.com/repos/openshift/origin-web-console/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openshift/origin-web-console/downloads","issues_url":"https://api.github.com/repos/openshift/origin-web-console/issues{/number}","pulls_url":"https://api.github.com/repos/openshift/origin-web-console/pulls{/number}","milestones_url":"https://api.github.com/repos/openshift/origin-web-console/milestones{/number}","notifications_url":"https://api.github.com/repos/openshift/origin-web-console/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openshift/origin-web-console/labels{/name}","releases_url":"https://api.github.com/repos/openshift/origin-web-console/releases{/id}","deployments_url":"https://api.github.com/repos/openshift/origin-web-console/deployments","created_at":"2016-05-10T19:31:50Z","updated_at":"2018-02-14T17:37:59Z","pushed_at":"2018-02-21T18:53:31Z","git_url":"git://github.com/openshift/origin-web-console.git","ssh_url":"git@github.com:openshift/origin-web-console.git","clone_url":"https://github.com/openshift/origin-web-console.git","svn_url":"https://github.com/openshift/origin-web-console","homepage":null,"size":69309,"stargazers_count":72,"watchers_count":72,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":171,"mirror_url":null,"archived":false,"open_issues_count":174,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":171,"open_issues":174,"watchers":72,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/2838"},"html":{"href":"https://github.com/openshift/origin-web-console/pull/2838"},"issue":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/2838"},"comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/issues/2838/comments"},"review_comments":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/2838/comments"},"review_comment":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openshift/origin-web-console/pulls/2838/commits"},"statuses":{"href":"https://api.github.com/repos/openshift/origin-web-console/statuses/65ed533284ddf45bba785c3a54f3c67660507fe1"}},"author_association":"NONE"}}
{"actor":{"display_login":"spadgett"}}