{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/207671452","pull_request_review_id":143334856,"id":207671452,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzY3MTQ1Mg==","diff_hunk":"@@ -1996,6 +1996,126 @@ Will generate an object similar to:\n   tz: '2016b' }\n ```\n \n+## Access Control\n+\n+> Stability: 1 - Experimental\n+\n+### process.accessControl.apply(restrictions)\n+<!-- YAML\n+added: REPLACEME\n+-->\n+\n+* `restrictions` {Object} A set of access restrictions that will be applied\n+  to the current Node.js instance. The format should be the same as the one\n+  returned by [`process.accessControl.getCurrent()`][]. Omitted keys will\n+  default to `true`, i.e. to retaining the relevant permissions.\n+\n+*Warning*: This does not provide a full isolation mechanism. Child processes,\n+native addons, and other communication channels may be used to circumvent\n+these measures.\n+\n+This API is recent and may not be complete.\n+Please report bugs at https://github.com/nodejs/node/issues.\n+\n+Operations scheduled before this call are not undone or stopped.\n+Features that were previously disabled through this call can not be re-enabled.\n+Child processes do not inherit these restrictions, whereas [`Worker`][]s do.\n+\n+The following code removes some permissions of this Node.js instance:\n+\n+```js\n+process.accessControl.apply({\n+  childProcesses: false,\n+  createWorkers: false,\n+  fsRead: false,\n+  fsWrite: false,\n+  loadAddons: false,\n+  setV8Flags: false\n+});\n+```\n+\n+Keys not listed in the object, or with values not set to `false`,\n+are unaffected.\n+\n+See [`process.accessControl.getCurrent()`][] for a list of permissions.\n+\n+### process.accessControl.getCurrent()\n+<!-- YAML\n+added: REPLACEME\n+-->\n+\n+Returns an object representing a set of permissions for the current Node.js","path":"doc/api/process.md","position":52,"original_position":52,"commit_id":"698b17dcd05b0caf2a3948855abb0f3800a97ab3","original_commit_id":"698b17dcd05b0caf2a3948855abb0f3800a97ab3","user":{"login":"vsemozhetbyt","id":10393198,"node_id":"MDQ6VXNlcjEwMzkzMTk4","avatar_url":"https://avatars1.githubusercontent.com/u/10393198?v=4","gravatar_id":"","url":"https://api.github.com/users/vsemozhetbyt","html_url":"https://github.com/vsemozhetbyt","followers_url":"https://api.github.com/users/vsemozhetbyt/followers","following_url":"https://api.github.com/users/vsemozhetbyt/following{/other_user}","gists_url":"https://api.github.com/users/vsemozhetbyt/gists{/gist_id}","starred_url":"https://api.github.com/users/vsemozhetbyt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vsemozhetbyt/subscriptions","organizations_url":"https://api.github.com/users/vsemozhetbyt/orgs","repos_url":"https://api.github.com/users/vsemozhetbyt/repos","events_url":"https://api.github.com/users/vsemozhetbyt/events{/privacy}","received_events_url":"https://api.github.com/users/vsemozhetbyt/received_events","type":"User","site_admin":false},"body":"Replace with the formal `* Returns: {Object} Description...` signature?","created_at":"2018-08-03T21:23:58Z","updated_at":"2018-08-03T21:50:09Z","html_url":"https://github.com/nodejs/node/pull/22112#discussion_r207671452","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/22112","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/207671452"},"html":{"href":"https://github.com/nodejs/node/pull/22112#discussion_r207671452"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/22112"}}},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22112","id":206135894,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MTM1ODk0","html_url":"https://github.com/nodejs/node/pull/22112","diff_url":"https://github.com/nodejs/node/pull/22112.diff","patch_url":"https://github.com/nodejs/node/pull/22112.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/22112","number":22112,"state":"open","locked":false,"title":" process: initial impl of feature access control ","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"body":"Just playing around with something here … this doesn’t need to happen, or can happen in a completely different way or by somebody else. I’d love to get ideas and feedback on this, though.\r\n\r\n/cc @nodejs/security @nodejs/collaborators \r\n\r\n---\r\n\r\nImplement `process.accessControl`, a simple API for restricting usage of certain in-process APIs,\r\nand similarly an `accessControl` option when setting up workers.\r\n\r\nRefs: #22107\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-08-03T20:51:19Z","updated_at":"2018-08-03T21:50:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c62d6eeb23e61c77537ffde6faedf064e11e4a78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267502,"node_id":"MDU6TGFiZWwxNTUyNjc1MDI=","url":"https://api.github.com/repos/nodejs/node/labels/C++","name":"C++","color":"e11d21","default":false},{"id":171787081,"node_id":"MDU6TGFiZWwxNzE3ODcwODE=","url":"https://api.github.com/repos/nodejs/node/labels/discuss","name":"discuss","color":"02d7e1","default":false},{"id":647282848,"node_id":"MDU6TGFiZWw2NDcyODI4NDg=","url":"https://api.github.com/repos/nodejs/node/labels/experimental","name":"experimental","color":"c5def5","default":false},{"id":281232761,"node_id":"MDU6TGFiZWwyODEyMzI3NjE=","url":"https://api.github.com/repos/nodejs/node/labels/lib%20/%20src","name":"lib / src","color":"fad8c7","default":false},{"id":207521371,"node_id":"MDU6TGFiZWwyMDc1MjEzNzE=","url":"https://api.github.com/repos/nodejs/node/labels/process","name":"process","color":"00aaff","default":false},{"id":169485478,"node_id":"MDU6TGFiZWwxNjk0ODU0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/semver-minor","name":"semver-minor","color":"fef2c0","default":false},{"id":868621832,"node_id":"MDU6TGFiZWw4Njg2MjE4MzI=","url":"https://api.github.com/repos/nodejs/node/labels/worker","name":"worker","color":"94fffb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/22112/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/22112/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22112/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/698b17dcd05b0caf2a3948855abb0f3800a97ab3","head":{"label":"addaleax:access-control","ref":"access-control","sha":"698b17dcd05b0caf2a3948855abb0f3800a97ab3","user":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"repo":{"id":47707342,"node_id":"MDEwOlJlcG9zaXRvcnk0NzcwNzM0Mg==","name":"node","full_name":"addaleax/node","owner":{"login":"addaleax","id":899444,"node_id":"MDQ6VXNlcjg5OTQ0NA==","avatar_url":"https://avatars2.githubusercontent.com/u/899444?v=4","gravatar_id":"","url":"https://api.github.com/users/addaleax","html_url":"https://github.com/addaleax","followers_url":"https://api.github.com/users/addaleax/followers","following_url":"https://api.github.com/users/addaleax/following{/other_user}","gists_url":"https://api.github.com/users/addaleax/gists{/gist_id}","starred_url":"https://api.github.com/users/addaleax/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/addaleax/subscriptions","organizations_url":"https://api.github.com/users/addaleax/orgs","repos_url":"https://api.github.com/users/addaleax/repos","events_url":"https://api.github.com/users/addaleax/events{/privacy}","received_events_url":"https://api.github.com/users/addaleax/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/addaleax/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/addaleax/node","forks_url":"https://api.github.com/repos/addaleax/node/forks","keys_url":"https://api.github.com/repos/addaleax/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/addaleax/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/addaleax/node/teams","hooks_url":"https://api.github.com/repos/addaleax/node/hooks","issue_events_url":"https://api.github.com/repos/addaleax/node/issues/events{/number}","events_url":"https://api.github.com/repos/addaleax/node/events","assignees_url":"https://api.github.com/repos/addaleax/node/assignees{/user}","branches_url":"https://api.github.com/repos/addaleax/node/branches{/branch}","tags_url":"https://api.github.com/repos/addaleax/node/tags","blobs_url":"https://api.github.com/repos/addaleax/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/addaleax/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/addaleax/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/addaleax/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/addaleax/node/statuses/{sha}","languages_url":"https://api.github.com/repos/addaleax/node/languages","stargazers_url":"https://api.github.com/repos/addaleax/node/stargazers","contributors_url":"https://api.github.com/repos/addaleax/node/contributors","subscribers_url":"https://api.github.com/repos/addaleax/node/subscribers","subscription_url":"https://api.github.com/repos/addaleax/node/subscription","commits_url":"https://api.github.com/repos/addaleax/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/addaleax/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/addaleax/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/addaleax/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/addaleax/node/contents/{+path}","compare_url":"https://api.github.com/repos/addaleax/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/addaleax/node/merges","archive_url":"https://api.github.com/repos/addaleax/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/addaleax/node/downloads","issues_url":"https://api.github.com/repos/addaleax/node/issues{/number}","pulls_url":"https://api.github.com/repos/addaleax/node/pulls{/number}","milestones_url":"https://api.github.com/repos/addaleax/node/milestones{/number}","notifications_url":"https://api.github.com/repos/addaleax/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/addaleax/node/labels{/name}","releases_url":"https://api.github.com/repos/addaleax/node/releases{/id}","deployments_url":"https://api.github.com/repos/addaleax/node/deployments","created_at":"2015-12-09T17:26:30Z","updated_at":"2018-07-31T15:41:27Z","pushed_at":"2018-08-03T21:50:01Z","git_url":"git://github.com/addaleax/node.git","ssh_url":"git@github.com:addaleax/node.git","clone_url":"https://github.com/addaleax/node.git","svn_url":"https://github.com/addaleax/node","homepage":"https://nodejs.org","size":387052,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"f19fa7ca4deea517f66cb0ef8b5fd9574bb33a66","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-08-03T20:23:22Z","pushed_at":"2018-08-03T21:49:57Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":399013,"stargazers_count":51950,"watchers_count":51950,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10963,"mirror_url":null,"archived":false,"open_issues_count":825,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10963,"open_issues":825,"watchers":51950,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/22112"},"html":{"href":"https://github.com/nodejs/node/pull/22112"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/22112"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/22112/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/22112/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/22112/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/698b17dcd05b0caf2a3948855abb0f3800a97ab3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vsemozhetbyt"}}