{"action":"opened","number":107,"pull_request":{"url":"https://api.github.com/repos/killnine/s7netplus/pulls/107","id":179985186,"html_url":"https://github.com/killnine/s7netplus/pull/107","diff_url":"https://github.com/killnine/s7netplus/pull/107.diff","patch_url":"https://github.com/killnine/s7netplus/pull/107.patch","issue_url":"https://api.github.com/repos/killnine/s7netplus/issues/107","number":107,"state":"open","locked":false,"title":"Fix communication with WinAC/SoftPLC CPUs and Fix write double","user":{"login":"thoj","id":153440,"avatar_url":"https://avatars0.githubusercontent.com/u/153440?v=4","gravatar_id":"","url":"https://api.github.com/users/thoj","html_url":"https://github.com/thoj","followers_url":"https://api.github.com/users/thoj/followers","following_url":"https://api.github.com/users/thoj/following{/other_user}","gists_url":"https://api.github.com/users/thoj/gists{/gist_id}","starred_url":"https://api.github.com/users/thoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoj/subscriptions","organizations_url":"https://api.github.com/users/thoj/orgs","repos_url":"https://api.github.com/users/thoj/repos","events_url":"https://api.github.com/users/thoj/events{/privacy}","received_events_url":"https://api.github.com/users/thoj/received_events","type":"User","site_admin":false},"body":"Hi\r\n\r\nThanks for this library! I stumbled on some issues when trying to write some values to a SIPROTECT unit (WinAC/LC). \r\n\r\nIssue1: All softPLC based units apparently send out an early \"ACK\" before most replies that messes with the code. This patch fixes it. The packet in question is \"03-00-00-07-02-F0-00\". I just wrote a function that trows away this packet if it sees it. \r\n\r\nIssue2: It seems the code for writing single values is broken for some types. When writing double it casts it to a UInt32 and throws away numbers after the decimal point and writes it as a Uint32 on the PLC. This patch fixes this for for double.\r\n","created_at":"2018-04-06T15:43:13Z","updated_at":"2018-04-06T15:43:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/killnine/s7netplus/pulls/107/commits","review_comments_url":"https://api.github.com/repos/killnine/s7netplus/pulls/107/comments","review_comment_url":"https://api.github.com/repos/killnine/s7netplus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/killnine/s7netplus/issues/107/comments","statuses_url":"https://api.github.com/repos/killnine/s7netplus/statuses/9ff38525744453560b1f670790b5cf6baed0c6d4","head":{"label":"thoj:master","ref":"master","sha":"9ff38525744453560b1f670790b5cf6baed0c6d4","user":{"login":"thoj","id":153440,"avatar_url":"https://avatars0.githubusercontent.com/u/153440?v=4","gravatar_id":"","url":"https://api.github.com/users/thoj","html_url":"https://github.com/thoj","followers_url":"https://api.github.com/users/thoj/followers","following_url":"https://api.github.com/users/thoj/following{/other_user}","gists_url":"https://api.github.com/users/thoj/gists{/gist_id}","starred_url":"https://api.github.com/users/thoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoj/subscriptions","organizations_url":"https://api.github.com/users/thoj/orgs","repos_url":"https://api.github.com/users/thoj/repos","events_url":"https://api.github.com/users/thoj/events{/privacy}","received_events_url":"https://api.github.com/users/thoj/received_events","type":"User","site_admin":false},"repo":{"id":128392342,"name":"s7netplus","full_name":"thoj/s7netplus","owner":{"login":"thoj","id":153440,"avatar_url":"https://avatars0.githubusercontent.com/u/153440?v=4","gravatar_id":"","url":"https://api.github.com/users/thoj","html_url":"https://github.com/thoj","followers_url":"https://api.github.com/users/thoj/followers","following_url":"https://api.github.com/users/thoj/following{/other_user}","gists_url":"https://api.github.com/users/thoj/gists{/gist_id}","starred_url":"https://api.github.com/users/thoj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thoj/subscriptions","organizations_url":"https://api.github.com/users/thoj/orgs","repos_url":"https://api.github.com/users/thoj/repos","events_url":"https://api.github.com/users/thoj/events{/privacy}","received_events_url":"https://api.github.com/users/thoj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/thoj/s7netplus","description":"S7.NET+ -- A .NET library to connect to Siemens Step7 devices","fork":true,"url":"https://api.github.com/repos/thoj/s7netplus","forks_url":"https://api.github.com/repos/thoj/s7netplus/forks","keys_url":"https://api.github.com/repos/thoj/s7netplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thoj/s7netplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thoj/s7netplus/teams","hooks_url":"https://api.github.com/repos/thoj/s7netplus/hooks","issue_events_url":"https://api.github.com/repos/thoj/s7netplus/issues/events{/number}","events_url":"https://api.github.com/repos/thoj/s7netplus/events","assignees_url":"https://api.github.com/repos/thoj/s7netplus/assignees{/user}","branches_url":"https://api.github.com/repos/thoj/s7netplus/branches{/branch}","tags_url":"https://api.github.com/repos/thoj/s7netplus/tags","blobs_url":"https://api.github.com/repos/thoj/s7netplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thoj/s7netplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thoj/s7netplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/thoj/s7netplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thoj/s7netplus/statuses/{sha}","languages_url":"https://api.github.com/repos/thoj/s7netplus/languages","stargazers_url":"https://api.github.com/repos/thoj/s7netplus/stargazers","contributors_url":"https://api.github.com/repos/thoj/s7netplus/contributors","subscribers_url":"https://api.github.com/repos/thoj/s7netplus/subscribers","subscription_url":"https://api.github.com/repos/thoj/s7netplus/subscription","commits_url":"https://api.github.com/repos/thoj/s7netplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/thoj/s7netplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/thoj/s7netplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/thoj/s7netplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/thoj/s7netplus/contents/{+path}","compare_url":"https://api.github.com/repos/thoj/s7netplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thoj/s7netplus/merges","archive_url":"https://api.github.com/repos/thoj/s7netplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thoj/s7netplus/downloads","issues_url":"https://api.github.com/repos/thoj/s7netplus/issues{/number}","pulls_url":"https://api.github.com/repos/thoj/s7netplus/pulls{/number}","milestones_url":"https://api.github.com/repos/thoj/s7netplus/milestones{/number}","notifications_url":"https://api.github.com/repos/thoj/s7netplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thoj/s7netplus/labels{/name}","releases_url":"https://api.github.com/repos/thoj/s7netplus/releases{/id}","deployments_url":"https://api.github.com/repos/thoj/s7netplus/deployments","created_at":"2018-04-06T12:32:21Z","updated_at":"2018-04-06T15:28:23Z","pushed_at":"2018-04-06T15:28:22Z","git_url":"git://github.com/thoj/s7netplus.git","ssh_url":"git@github.com:thoj/s7netplus.git","clone_url":"https://github.com/thoj/s7netplus.git","svn_url":"https://github.com/thoj/s7netplus","homepage":null,"size":2005,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"killnine:master","ref":"master","sha":"f6a2e11045aaf4a92c83c04f9c9be38a96a9fafa","user":{"login":"killnine","id":660420,"avatar_url":"https://avatars2.githubusercontent.com/u/660420?v=4","gravatar_id":"","url":"https://api.github.com/users/killnine","html_url":"https://github.com/killnine","followers_url":"https://api.github.com/users/killnine/followers","following_url":"https://api.github.com/users/killnine/following{/other_user}","gists_url":"https://api.github.com/users/killnine/gists{/gist_id}","starred_url":"https://api.github.com/users/killnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killnine/subscriptions","organizations_url":"https://api.github.com/users/killnine/orgs","repos_url":"https://api.github.com/users/killnine/repos","events_url":"https://api.github.com/users/killnine/events{/privacy}","received_events_url":"https://api.github.com/users/killnine/received_events","type":"User","site_admin":false},"repo":{"id":8101288,"name":"s7netplus","full_name":"killnine/s7netplus","owner":{"login":"killnine","id":660420,"avatar_url":"https://avatars2.githubusercontent.com/u/660420?v=4","gravatar_id":"","url":"https://api.github.com/users/killnine","html_url":"https://github.com/killnine","followers_url":"https://api.github.com/users/killnine/followers","following_url":"https://api.github.com/users/killnine/following{/other_user}","gists_url":"https://api.github.com/users/killnine/gists{/gist_id}","starred_url":"https://api.github.com/users/killnine/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/killnine/subscriptions","organizations_url":"https://api.github.com/users/killnine/orgs","repos_url":"https://api.github.com/users/killnine/repos","events_url":"https://api.github.com/users/killnine/events{/privacy}","received_events_url":"https://api.github.com/users/killnine/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/killnine/s7netplus","description":"S7.NET+ -- A .NET library to connect to Siemens Step7 devices","fork":false,"url":"https://api.github.com/repos/killnine/s7netplus","forks_url":"https://api.github.com/repos/killnine/s7netplus/forks","keys_url":"https://api.github.com/repos/killnine/s7netplus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/killnine/s7netplus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/killnine/s7netplus/teams","hooks_url":"https://api.github.com/repos/killnine/s7netplus/hooks","issue_events_url":"https://api.github.com/repos/killnine/s7netplus/issues/events{/number}","events_url":"https://api.github.com/repos/killnine/s7netplus/events","assignees_url":"https://api.github.com/repos/killnine/s7netplus/assignees{/user}","branches_url":"https://api.github.com/repos/killnine/s7netplus/branches{/branch}","tags_url":"https://api.github.com/repos/killnine/s7netplus/tags","blobs_url":"https://api.github.com/repos/killnine/s7netplus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/killnine/s7netplus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/killnine/s7netplus/git/refs{/sha}","trees_url":"https://api.github.com/repos/killnine/s7netplus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/killnine/s7netplus/statuses/{sha}","languages_url":"https://api.github.com/repos/killnine/s7netplus/languages","stargazers_url":"https://api.github.com/repos/killnine/s7netplus/stargazers","contributors_url":"https://api.github.com/repos/killnine/s7netplus/contributors","subscribers_url":"https://api.github.com/repos/killnine/s7netplus/subscribers","subscription_url":"https://api.github.com/repos/killnine/s7netplus/subscription","commits_url":"https://api.github.com/repos/killnine/s7netplus/commits{/sha}","git_commits_url":"https://api.github.com/repos/killnine/s7netplus/git/commits{/sha}","comments_url":"https://api.github.com/repos/killnine/s7netplus/comments{/number}","issue_comment_url":"https://api.github.com/repos/killnine/s7netplus/issues/comments{/number}","contents_url":"https://api.github.com/repos/killnine/s7netplus/contents/{+path}","compare_url":"https://api.github.com/repos/killnine/s7netplus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/killnine/s7netplus/merges","archive_url":"https://api.github.com/repos/killnine/s7netplus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/killnine/s7netplus/downloads","issues_url":"https://api.github.com/repos/killnine/s7netplus/issues{/number}","pulls_url":"https://api.github.com/repos/killnine/s7netplus/pulls{/number}","milestones_url":"https://api.github.com/repos/killnine/s7netplus/milestones{/number}","notifications_url":"https://api.github.com/repos/killnine/s7netplus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/killnine/s7netplus/labels{/name}","releases_url":"https://api.github.com/repos/killnine/s7netplus/releases{/id}","deployments_url":"https://api.github.com/repos/killnine/s7netplus/deployments","created_at":"2013-02-08T21:00:55Z","updated_at":"2018-04-04T15:38:57Z","pushed_at":"2018-03-21T21:45:01Z","git_url":"git://github.com/killnine/s7netplus.git","ssh_url":"git@github.com:killnine/s7netplus.git","clone_url":"https://github.com/killnine/s7netplus.git","svn_url":"https://github.com/killnine/s7netplus","homepage":null,"size":2005,"stargazers_count":133,"watchers_count":133,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":86,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":86,"open_issues":28,"watchers":133,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/107"},"html":{"href":"https://github.com/killnine/s7netplus/pull/107"},"issue":{"href":"https://api.github.com/repos/killnine/s7netplus/issues/107"},"comments":{"href":"https://api.github.com/repos/killnine/s7netplus/issues/107/comments"},"review_comments":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/107/comments"},"review_comment":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/killnine/s7netplus/pulls/107/commits"},"statuses":{"href":"https://api.github.com/repos/killnine/s7netplus/statuses/9ff38525744453560b1f670790b5cf6baed0c6d4"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":57,"deletions":36,"changed_files":1}}
{"actor":{"display_login":"thoj"}}