{"action":"closed","issue":{"url":"https://api.github.com/repos/GIScience/openrouteservice/issues/177","repository_url":"https://api.github.com/repos/GIScience/openrouteservice","labels_url":"https://api.github.com/repos/GIScience/openrouteservice/issues/177/labels{/name}","comments_url":"https://api.github.com/repos/GIScience/openrouteservice/issues/177/comments","events_url":"https://api.github.com/repos/GIScience/openrouteservice/issues/177/events","html_url":"https://github.com/GIScience/openrouteservice/issues/177","id":325290375,"node_id":"MDU6SXNzdWUzMjUyOTAzNzU=","number":177,"title":"RouteResultBuilder Issue","user":{"login":"marq24","id":8012359,"node_id":"MDQ6VXNlcjgwMTIzNTk=","avatar_url":"https://avatars3.githubusercontent.com/u/8012359?v=4","gravatar_id":"","url":"https://api.github.com/users/marq24","html_url":"https://github.com/marq24","followers_url":"https://api.github.com/users/marq24/followers","following_url":"https://api.github.com/users/marq24/following{/other_user}","gists_url":"https://api.github.com/users/marq24/gists{/gist_id}","starred_url":"https://api.github.com/users/marq24/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marq24/subscriptions","organizations_url":"https://api.github.com/users/marq24/orgs","repos_url":"https://api.github.com/users/marq24/repos","events_url":"https://api.github.com/users/marq24/events{/privacy}","received_events_url":"https://api.github.com/users/marq24/received_events","type":"User","site_admin":false},"labels":[{"id":1012390711,"node_id":"MDU6TGFiZWwxMDEyMzkwNzEx","url":"https://api.github.com/repos/GIScience/openrouteservice/labels/Awaiting%20release","name":"Awaiting release","color":"02ff06","default":false}],"state":"closed","locked":false,"assignee":{"login":"rabidllama","id":7126643,"node_id":"MDQ6VXNlcjcxMjY2NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7126643?v=4","gravatar_id":"","url":"https://api.github.com/users/rabidllama","html_url":"https://github.com/rabidllama","followers_url":"https://api.github.com/users/rabidllama/followers","following_url":"https://api.github.com/users/rabidllama/following{/other_user}","gists_url":"https://api.github.com/users/rabidllama/gists{/gist_id}","starred_url":"https://api.github.com/users/rabidllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabidllama/subscriptions","organizations_url":"https://api.github.com/users/rabidllama/orgs","repos_url":"https://api.github.com/users/rabidllama/repos","events_url":"https://api.github.com/users/rabidllama/events{/privacy}","received_events_url":"https://api.github.com/users/rabidllama/received_events","type":"User","site_admin":false},"assignees":[{"login":"rabidllama","id":7126643,"node_id":"MDQ6VXNlcjcxMjY2NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7126643?v=4","gravatar_id":"","url":"https://api.github.com/users/rabidllama","html_url":"https://github.com/rabidllama","followers_url":"https://api.github.com/users/rabidllama/followers","following_url":"https://api.github.com/users/rabidllama/following{/other_user}","gists_url":"https://api.github.com/users/rabidllama/gists{/gist_id}","starred_url":"https://api.github.com/users/rabidllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabidllama/subscriptions","organizations_url":"https://api.github.com/users/rabidllama/orgs","repos_url":"https://api.github.com/users/rabidllama/repos","events_url":"https://api.github.com/users/rabidllama/events{/privacy}","received_events_url":"https://api.github.com/users/rabidllama/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/GIScience/openrouteservice/milestones/6","html_url":"https://github.com/GIScience/openrouteservice/milestone/6","labels_url":"https://api.github.com/repos/GIScience/openrouteservice/milestones/6/labels","id":3147779,"node_id":"MDk6TWlsZXN0b25lMzE0Nzc3OQ==","number":6,"title":"4.6","description":null,"creator":{"login":"rabidllama","id":7126643,"node_id":"MDQ6VXNlcjcxMjY2NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/7126643?v=4","gravatar_id":"","url":"https://api.github.com/users/rabidllama","html_url":"https://github.com/rabidllama","followers_url":"https://api.github.com/users/rabidllama/followers","following_url":"https://api.github.com/users/rabidllama/following{/other_user}","gists_url":"https://api.github.com/users/rabidllama/gists{/gist_id}","starred_url":"https://api.github.com/users/rabidllama/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rabidllama/subscriptions","organizations_url":"https://api.github.com/users/rabidllama/orgs","repos_url":"https://api.github.com/users/rabidllama/repos","events_url":"https://api.github.com/users/rabidllama/events{/privacy}","received_events_url":"https://api.github.com/users/rabidllama/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":18,"state":"open","created_at":"2018-02-27T15:29:06Z","updated_at":"2018-10-10T07:50:26Z","due_on":null,"closed_at":null},"comments":4,"created_at":"2018-05-22T13:19:31Z","updated_at":"2018-10-10T07:50:26Z","closed_at":"2018-10-10T07:50:26Z","author_association":"CONTRIBUTOR","body":"Hi,\r\n\r\nas I started in the google groups \r\nhttps://groups.google.com/d/msg/openrouteservice/o5-ZTUZVP-I/vU8C2rvuBwAJ\r\n\r\nI believe there is an issue with the route instruction builder... I have collected few more examples:\r\n\r\nHere BOTH of the roundabout turning instructions will be removed\r\n\r\nhttps://maps.openrouteservice.org/directions?n1=51.830152&n2=8.446485&n3=17&a=51.831362,8.448905,51.828949,8.444045&b=0&c=0&k1=en-US&k2=km\r\n\r\nwhile here\r\n\r\nhttps://maps.openrouteservice.org/directions?n1=51.830152&n2=8.446485&n3=17&a=51.831362,8.448905,51.828995,8.445407&b=0&c=0&k1=en-US&k2=km\r\n\r\nthey will be keept...\r\n\r\nI am not 100% sure, but I believe that the root cause of this issue can be found in the heigit.ors.routing.RouteResultBuilder - starting from line 220\r\n\r\n`// merge route steps with similar names \r\n`\r\nhere TurnInstructions of the same type will be merged, if the \"name1\" contains \"name2\" or vice versa - in the code there is an example URL which should demonstrate why this code can be useful -  unfortunately I am not able to check/understand this route [it's quite long] - so might be the code is removing some turn instructions with a good reason - but the check\r\n\r\n`\r\nif (prevStep != null && instrType == prevInstrType && canMergeInstructions(instr.getName(), prevInstr.getName()))\r\n`\r\nis IMHO not correct (or way to less) - in my initial case two right turns will be merged into one - or in my second example the roundabout turn instructions will be merged...\r\n\r\nSo IF this merging is required (in the given example URL) then you should add additional checks for specific turn types ONLY - and second check which might be helpful is the distance between the the \"possible merge targets\" ?\r\n\r\nThanks for spending time with this issue report - if you want/need more examples - please let me know ;-)\r\n\r\nCheers\r\nMatthias\r\n\r\n\r\n"}}
{"actor":{"display_login":"rabidllama"}}