{"action":"created","comment":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/comments/242324995","pull_request_review_id":185809640,"id":242324995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MjMyNDk5NQ==","diff_hunk":"@@ -39,12 +39,36 @@\n     QuietRestoreBinaryLog           \"true\" to produce binary log for Restore.\n   -->\n \n+  <PropertyGroup>\n+    <NuGetRestoreTargets Condition=\"'$(NuGetRestoreTargets)'=='' and '$([MSBuild]::IsRunningFromVisualStudio())'=='true'\">$(MSBuildToolsPath32)\\..\\..\\..\\Common7\\IDE\\CommonExtensions\\Microsoft\\NuGet\\NuGet.targets</NuGetRestoreTargets>\n+    <NuGetRestoreTargets Condition=\"'$(NuGetRestoreTargets)'==''\">$(MSBuildToolsPath)\\NuGet.targets</NuGetRestoreTargets>\n+  </PropertyGroup>\n+\n+  <PropertyGroup>\n+    <_RepoRootOriginal>$(RepoRoot)</_RepoRootOriginal>\n+    <RepoRoot>$([System.IO.Path]::GetFullPath('$(RepoRoot)/'))</RepoRoot>\n+\n+    <_RemoveProps>Projects;Restore;QuietRestore;QuietRestoreBinaryLog;Build;Rebuild;Deploy;Test;IntegrationTest;PerformanceTest;Pack;Sign;Publish;Execute</_RemoveProps>\n+  </PropertyGroup>\n+\n+  <Import Project=\"RepoLayout.props\"/>\n+\n+  <!-- Setting the Projects property is only supported from the command line, not using Build.props. Build.props should only add items to <ProjectToBuild> -->\n+  <ItemGroup Condition=\" '$(Projects)' != '' \">\n+    <ProjectToBuild Include=\"$(Projects)\" />\n+  </ItemGroup>\n+\n+  <!-- Allow for repo specific Build properties such as the list of Projects to build -->\n+  <Import Project=\"$(RepositoryEngineeringDir)Build.props\" Condition=\"Exists('$(RepositoryEngineeringDir)Build.props')\" />\n+\n   <!--\n     Default values.\n   -->\n-  <ItemGroup>\n-    <ProjectToBuild Include=\"$(Projects)\"/>\n+  <!-- If Projects is unspecified and ProjectToBuild was not set via Build.props, fallback to building .sln files in the repo root. -->\n+  <ItemGroup Condition=\"'$(BuildSolutions)' != 'false' and '@(ProjectToBuild)' == '' \">","path":"src/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj","position":32,"original_position":32,"commit_id":"6c65a2a56b7b603e13fb7e901e67f16556c21294","original_commit_id":"6c65a2a56b7b603e13fb7e901e67f16556c21294","user":{"login":"natemcmaster","id":2696087,"node_id":"MDQ6VXNlcjI2OTYwODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"body":"yes, still needed.","created_at":"2018-12-17T21:36:55Z","updated_at":"2018-12-17T21:36:56Z","html_url":"https://github.com/dotnet/arcade/pull/1567#discussion_r242324995","pull_request_url":"https://api.github.com/repos/dotnet/arcade/pulls/1567","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments/242324995"},"html":{"href":"https://github.com/dotnet/arcade/pull/1567#discussion_r242324995"},"pull_request":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/1567"}},"in_reply_to_id":241993567},"pull_request":{"url":"https://api.github.com/repos/dotnet/arcade/pulls/1567","id":238206691,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MjA2Njkx","html_url":"https://github.com/dotnet/arcade/pull/1567","diff_url":"https://github.com/dotnet/arcade/pull/1567.diff","patch_url":"https://github.com/dotnet/arcade/pull/1567.patch","issue_url":"https://api.github.com/repos/dotnet/arcade/issues/1567","number":1567,"state":"open","locked":false,"title":"Allow specifying csproj files and/or disabling the default .sln glob for projects to build","user":{"login":"natemcmaster","id":2696087,"node_id":"MDQ6VXNlcjI2OTYwODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"body":"Addresses #1454 - cc @rynowak \r\nAddresses https://github.com/dotnet/arcade/issues/1525 - cc @bricelam \r\n\r\nChanges:\r\n\r\n* Add tests for Arcade SDK\r\n* Move the default \"*.sln\" glob into MSBuild so it can be overridden via eng/build.props\r\n* Add support for specifying a list of *.csproj files to build.","created_at":"2018-12-12T22:39:11Z","updated_at":"2018-12-17T21:36:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ffb33e4c4a5efe11f4c7424db8c34157b8118d1","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dotnet/arcade/pulls/1567/commits","review_comments_url":"https://api.github.com/repos/dotnet/arcade/pulls/1567/comments","review_comment_url":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dotnet/arcade/issues/1567/comments","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/6c65a2a56b7b603e13fb7e901e67f16556c21294","head":{"label":"natemcmaster:conditional-projects","ref":"conditional-projects","sha":"6c65a2a56b7b603e13fb7e901e67f16556c21294","user":{"login":"natemcmaster","id":2696087,"node_id":"MDQ6VXNlcjI2OTYwODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"repo":{"id":133995134,"node_id":"MDEwOlJlcG9zaXRvcnkxMzM5OTUxMzQ=","name":"arcade","full_name":"natemcmaster/arcade","private":false,"owner":{"login":"natemcmaster","id":2696087,"node_id":"MDQ6VXNlcjI2OTYwODc=","avatar_url":"https://avatars0.githubusercontent.com/u/2696087?v=4","gravatar_id":"","url":"https://api.github.com/users/natemcmaster","html_url":"https://github.com/natemcmaster","followers_url":"https://api.github.com/users/natemcmaster/followers","following_url":"https://api.github.com/users/natemcmaster/following{/other_user}","gists_url":"https://api.github.com/users/natemcmaster/gists{/gist_id}","starred_url":"https://api.github.com/users/natemcmaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/natemcmaster/subscriptions","organizations_url":"https://api.github.com/users/natemcmaster/orgs","repos_url":"https://api.github.com/users/natemcmaster/repos","events_url":"https://api.github.com/users/natemcmaster/events{/privacy}","received_events_url":"https://api.github.com/users/natemcmaster/received_events","type":"User","site_admin":false},"html_url":"https://github.com/natemcmaster/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":true,"url":"https://api.github.com/repos/natemcmaster/arcade","forks_url":"https://api.github.com/repos/natemcmaster/arcade/forks","keys_url":"https://api.github.com/repos/natemcmaster/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/natemcmaster/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/natemcmaster/arcade/teams","hooks_url":"https://api.github.com/repos/natemcmaster/arcade/hooks","issue_events_url":"https://api.github.com/repos/natemcmaster/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/natemcmaster/arcade/events","assignees_url":"https://api.github.com/repos/natemcmaster/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/natemcmaster/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/natemcmaster/arcade/tags","blobs_url":"https://api.github.com/repos/natemcmaster/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/natemcmaster/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/natemcmaster/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/natemcmaster/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/natemcmaster/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/natemcmaster/arcade/languages","stargazers_url":"https://api.github.com/repos/natemcmaster/arcade/stargazers","contributors_url":"https://api.github.com/repos/natemcmaster/arcade/contributors","subscribers_url":"https://api.github.com/repos/natemcmaster/arcade/subscribers","subscription_url":"https://api.github.com/repos/natemcmaster/arcade/subscription","commits_url":"https://api.github.com/repos/natemcmaster/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/natemcmaster/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/natemcmaster/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/natemcmaster/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/natemcmaster/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/natemcmaster/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/natemcmaster/arcade/merges","archive_url":"https://api.github.com/repos/natemcmaster/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/natemcmaster/arcade/downloads","issues_url":"https://api.github.com/repos/natemcmaster/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/natemcmaster/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/natemcmaster/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/natemcmaster/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/natemcmaster/arcade/labels{/name}","releases_url":"https://api.github.com/repos/natemcmaster/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/natemcmaster/arcade/deployments","created_at":"2018-05-18T19:18:58Z","updated_at":"2018-08-17T22:56:32Z","pushed_at":"2018-12-13T16:56:02Z","git_url":"git://github.com/natemcmaster/arcade.git","ssh_url":"git@github.com:natemcmaster/arcade.git","clone_url":"https://github.com/natemcmaster/arcade.git","svn_url":"https://github.com/natemcmaster/arcade","homepage":"","size":6065,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dotnet:master","ref":"master","sha":"ffc7a871add67b229c7fd41ad1cdff41da926312","user":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"repo":{"id":121444325,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0NDQzMjU=","name":"arcade","full_name":"dotnet/arcade","private":false,"owner":{"login":"dotnet","id":9141961,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkxNDE5NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/9141961?v=4","gravatar_id":"","url":"https://api.github.com/users/dotnet","html_url":"https://github.com/dotnet","followers_url":"https://api.github.com/users/dotnet/followers","following_url":"https://api.github.com/users/dotnet/following{/other_user}","gists_url":"https://api.github.com/users/dotnet/gists{/gist_id}","starred_url":"https://api.github.com/users/dotnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dotnet/subscriptions","organizations_url":"https://api.github.com/users/dotnet/orgs","repos_url":"https://api.github.com/users/dotnet/repos","events_url":"https://api.github.com/users/dotnet/events{/privacy}","received_events_url":"https://api.github.com/users/dotnet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/dotnet/arcade","description":"Tools that provide common build infrastructure for multiple .NET Foundation projects.","fork":false,"url":"https://api.github.com/repos/dotnet/arcade","forks_url":"https://api.github.com/repos/dotnet/arcade/forks","keys_url":"https://api.github.com/repos/dotnet/arcade/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dotnet/arcade/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dotnet/arcade/teams","hooks_url":"https://api.github.com/repos/dotnet/arcade/hooks","issue_events_url":"https://api.github.com/repos/dotnet/arcade/issues/events{/number}","events_url":"https://api.github.com/repos/dotnet/arcade/events","assignees_url":"https://api.github.com/repos/dotnet/arcade/assignees{/user}","branches_url":"https://api.github.com/repos/dotnet/arcade/branches{/branch}","tags_url":"https://api.github.com/repos/dotnet/arcade/tags","blobs_url":"https://api.github.com/repos/dotnet/arcade/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dotnet/arcade/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dotnet/arcade/git/refs{/sha}","trees_url":"https://api.github.com/repos/dotnet/arcade/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dotnet/arcade/statuses/{sha}","languages_url":"https://api.github.com/repos/dotnet/arcade/languages","stargazers_url":"https://api.github.com/repos/dotnet/arcade/stargazers","contributors_url":"https://api.github.com/repos/dotnet/arcade/contributors","subscribers_url":"https://api.github.com/repos/dotnet/arcade/subscribers","subscription_url":"https://api.github.com/repos/dotnet/arcade/subscription","commits_url":"https://api.github.com/repos/dotnet/arcade/commits{/sha}","git_commits_url":"https://api.github.com/repos/dotnet/arcade/git/commits{/sha}","comments_url":"https://api.github.com/repos/dotnet/arcade/comments{/number}","issue_comment_url":"https://api.github.com/repos/dotnet/arcade/issues/comments{/number}","contents_url":"https://api.github.com/repos/dotnet/arcade/contents/{+path}","compare_url":"https://api.github.com/repos/dotnet/arcade/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dotnet/arcade/merges","archive_url":"https://api.github.com/repos/dotnet/arcade/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dotnet/arcade/downloads","issues_url":"https://api.github.com/repos/dotnet/arcade/issues{/number}","pulls_url":"https://api.github.com/repos/dotnet/arcade/pulls{/number}","milestones_url":"https://api.github.com/repos/dotnet/arcade/milestones{/number}","notifications_url":"https://api.github.com/repos/dotnet/arcade/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dotnet/arcade/labels{/name}","releases_url":"https://api.github.com/repos/dotnet/arcade/releases{/id}","deployments_url":"https://api.github.com/repos/dotnet/arcade/deployments","created_at":"2018-02-13T22:29:54Z","updated_at":"2018-12-17T17:26:20Z","pushed_at":"2018-12-17T17:53:06Z","git_url":"git://github.com/dotnet/arcade.git","ssh_url":"git@github.com:dotnet/arcade.git","clone_url":"https://github.com/dotnet/arcade.git","svn_url":"https://github.com/dotnet/arcade","homepage":"","size":6138,"stargazers_count":42,"watchers_count":42,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":355,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":52,"open_issues":355,"watchers":42,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/1567"},"html":{"href":"https://github.com/dotnet/arcade/pull/1567"},"issue":{"href":"https://api.github.com/repos/dotnet/arcade/issues/1567"},"comments":{"href":"https://api.github.com/repos/dotnet/arcade/issues/1567/comments"},"review_comments":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/1567/comments"},"review_comment":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dotnet/arcade/pulls/1567/commits"},"statuses":{"href":"https://api.github.com/repos/dotnet/arcade/statuses/6c65a2a56b7b603e13fb7e901e67f16556c21294"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"natemcmaster"}}