{"action":"created","issue":{"url":"https://api.github.com/repos/connexta/saml-conformance/issues/124","repository_url":"https://api.github.com/repos/connexta/saml-conformance","labels_url":"https://api.github.com/repos/connexta/saml-conformance/issues/124/labels{/name}","comments_url":"https://api.github.com/repos/connexta/saml-conformance/issues/124/comments","events_url":"https://api.github.com/repos/connexta/saml-conformance/issues/124/events","html_url":"https://github.com/connexta/saml-conformance/pull/124","id":318996795,"number":124,"title":"MAINT - Major refactor to standardize and simplify inputs to the verifiers","user":{"login":"brjeter","id":8130140,"avatar_url":"https://avatars3.githubusercontent.com/u/8130140?v=4","gravatar_id":"","url":"https://api.github.com/users/brjeter","html_url":"https://github.com/brjeter","followers_url":"https://api.github.com/users/brjeter/followers","following_url":"https://api.github.com/users/brjeter/following{/other_user}","gists_url":"https://api.github.com/users/brjeter/gists{/gist_id}","starred_url":"https://api.github.com/users/brjeter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brjeter/subscriptions","organizations_url":"https://api.github.com/users/brjeter/orgs","repos_url":"https://api.github.com/users/brjeter/repos","events_url":"https://api.github.com/users/brjeter/events{/privacy}","received_events_url":"https://api.github.com/users/brjeter/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-30T18:56:32Z","updated_at":"2018-05-01T19:14:58Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/connexta/saml-conformance/pulls/124","html_url":"https://github.com/connexta/saml-conformance/pull/124","diff_url":"https://github.com/connexta/saml-conformance/pull/124.diff","patch_url":"https://github.com/connexta/saml-conformance/pull/124.patch"},"body":"#### What does this PR do (if it's not clear from the Title)? Please include any specification references that apply.\r\nFirst commit:\r\n- Removed our custom Response objects and corresponding Decorators\r\n- Use RestAssured Response object for output of plugin portion and input of BindingVerifiers\r\n- Added extension functions to RestAssured Response object to determine binding\r\n- BindingVerifiers now return the `samlResponseDom` to be used by the other Verifiers\r\n- Made naming consistent to say either `saml[Response/Request]` or `http[Response/Request]` to make more clear and explicit in the code\r\n- Commented out Core and Profiles verifications (see third commit)\r\n\r\nSecond commit:\r\n- Pulled Post form verifications and parsing out into `PostFormVerifier`\r\n\r\nThird commit:\r\n- Fixed the Core and Profiles verifiers to take the `samlRequestDom` and `samlResponseDom`\r\n#### Checklist:\r\n- [ ] SAML Spec Table of Contents documentation updated"},"comment":{"url":"https://api.github.com/repos/connexta/saml-conformance/issues/comments/385761795","html_url":"https://github.com/connexta/saml-conformance/pull/124#issuecomment-385761795","issue_url":"https://api.github.com/repos/connexta/saml-conformance/issues/124","id":385761795,"user":{"login":"blen-desta","id":29550062,"avatar_url":"https://avatars0.githubusercontent.com/u/29550062?v=4","gravatar_id":"","url":"https://api.github.com/users/blen-desta","html_url":"https://github.com/blen-desta","followers_url":"https://api.github.com/users/blen-desta/followers","following_url":"https://api.github.com/users/blen-desta/following{/other_user}","gists_url":"https://api.github.com/users/blen-desta/gists{/gist_id}","starred_url":"https://api.github.com/users/blen-desta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blen-desta/subscriptions","organizations_url":"https://api.github.com/users/blen-desta/orgs","repos_url":"https://api.github.com/users/blen-desta/repos","events_url":"https://api.github.com/users/blen-desta/events{/privacy}","received_events_url":"https://api.github.com/users/blen-desta/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T19:14:58Z","updated_at":"2018-05-01T19:14:58Z","author_association":"COLLABORATOR","body":"Hero'd successfully 👍 "}}
{"actor":{"display_login":"blen-desta"}}