{"action":"created","comment":{"url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/comments/179934673","pull_request_review_id":110274180,"id":179934673,"diff_hunk":"@@ -9,122 +10,103 @@\n  * @param options - object with following keys:\n  *\n  *  * tfClient - the TF client handle to use\n- *  * texture - (optional) Image url for a texture to use for the points. Defaults to a single white pixel.\n- *  * rootObject (optional) - the root object to add this marker to\n- *  * size (optional) - size to draw each point (default 0.05)\n- *  * max_pts (optional) - number of points to draw (default 100)","path":"src/sensors/Particles.js","position":14,"original_position":14,"commit_id":"d63760ba465d313ed0ad9e2cb5127f69ee815d2e","original_commit_id":"d63760ba465d313ed0ad9e2cb5127f69ee815d2e","user":{"login":"jihoonl","id":1556736,"avatar_url":"https://avatars3.githubusercontent.com/u/1556736?v=4","gravatar_id":"","url":"https://api.github.com/users/jihoonl","html_url":"https://github.com/jihoonl","followers_url":"https://api.github.com/users/jihoonl/followers","following_url":"https://api.github.com/users/jihoonl/following{/other_user}","gists_url":"https://api.github.com/users/jihoonl/gists{/gist_id}","starred_url":"https://api.github.com/users/jihoonl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jihoonl/subscriptions","organizations_url":"https://api.github.com/users/jihoonl/orgs","repos_url":"https://api.github.com/users/jihoonl/repos","events_url":"https://api.github.com/users/jihoonl/events{/privacy}","received_events_url":"https://api.github.com/users/jihoonl/received_events","type":"User","site_admin":false},"body":"`texture` and `size` are gone here also. Could you add a check with deprecation warning?","created_at":"2018-04-08T04:27:12Z","updated_at":"2018-04-08T04:47:01Z","html_url":"https://github.com/RobotWebTools/ros3djs/pull/218#discussion_r179934673","pull_request_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/218","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/comments/179934673"},"html":{"href":"https://github.com/RobotWebTools/ros3djs/pull/218#discussion_r179934673"},"pull_request":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/218"}}},"pull_request":{"url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/218","id":179409828,"html_url":"https://github.com/RobotWebTools/ros3djs/pull/218","diff_url":"https://github.com/RobotWebTools/ros3djs/pull/218.diff","patch_url":"https://github.com/RobotWebTools/ros3djs/pull/218.patch","issue_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/218","number":218,"state":"open","locked":false,"title":"PointCloud2 and LaserScan","user":{"login":"mbredif","id":7373521,"avatar_url":"https://avatars1.githubusercontent.com/u/7373521?v=4","gravatar_id":"","url":"https://api.github.com/users/mbredif","html_url":"https://github.com/mbredif","followers_url":"https://api.github.com/users/mbredif/followers","following_url":"https://api.github.com/users/mbredif/following{/other_user}","gists_url":"https://api.github.com/users/mbredif/gists{/gist_id}","starred_url":"https://api.github.com/users/mbredif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbredif/subscriptions","organizations_url":"https://api.github.com/users/mbredif/orgs","repos_url":"https://api.github.com/users/mbredif/repos","events_url":"https://api.github.com/users/mbredif/events{/privacy}","received_events_url":"https://api.github.com/users/mbredif/received_events","type":"User","site_admin":false},"body":"This PR builds on #216 and #217 to address #213 and give extra functionnalities to PointCloud2 and LaserScan topics : \r\n- *subsample* : input PointCloud2 and LaserScan messages may be subsampled by the given amount (1 point every N other points). This is mostly useful to visualize topics with too many points per second.\r\n- *material* : the previous custom material implementation has been changed to a material option, which defaults to a THREE.PointsMaterial constructed from *material* if it is not a THREE.Material already. For instance, *size*, *sizeAttenuation*, *color* should now be specified as *material.size*, *material.sizeAttenuation* and *material.color*. See the doc of [THREE.PointsMaterial](https://threejs.org/docs/#api/materials/PointsMaterial) and [THREE.Material](https://threejs.org/docs/#api/materials/Material) for available parameters.\r\n- *colorsrc* is expecting a PointCloud2 field name to be used for coloring (defaults to 'rgb')\r\n- *colormap* is expecting a function that converts the *colorsrc* field value to a THREE.Color (defaults to THREE.Color construction)\r\n- many aspects have been optimized (eg: skipped values are not decoded, dynamic buffers are used with tight update range counts...)\r\n\r\nMisc:\r\n- I added a simple launchfile `examples/ros3djs.launch` to simplify setup to simply `roslaunch examples/ros3djs.launch` instead of launching manually `roscore`, `rosbridge` and `tf2_web_republisher`.\r\n- I also added a `kitti.html` example that is intended to be used to visualize [rossified](https://github.com/tomas789/kitti2bag) [kitti datasets](http://www.cvlibs.net/datasets/kitti/raw_data.php).","created_at":"2018-04-04T14:30:11Z","updated_at":"2018-04-08T04:47:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e699ecca2764ba8f57360f53ef95ea3ef2903938","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/218/commits","review_comments_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/218/comments","review_comment_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/218/comments","statuses_url":"https://api.github.com/repos/RobotWebTools/ros3djs/statuses/d63760ba465d313ed0ad9e2cb5127f69ee815d2e","head":{"label":"mbredif:pointcloud2","ref":"pointcloud2","sha":"d63760ba465d313ed0ad9e2cb5127f69ee815d2e","user":{"login":"mbredif","id":7373521,"avatar_url":"https://avatars1.githubusercontent.com/u/7373521?v=4","gravatar_id":"","url":"https://api.github.com/users/mbredif","html_url":"https://github.com/mbredif","followers_url":"https://api.github.com/users/mbredif/followers","following_url":"https://api.github.com/users/mbredif/following{/other_user}","gists_url":"https://api.github.com/users/mbredif/gists{/gist_id}","starred_url":"https://api.github.com/users/mbredif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbredif/subscriptions","organizations_url":"https://api.github.com/users/mbredif/orgs","repos_url":"https://api.github.com/users/mbredif/repos","events_url":"https://api.github.com/users/mbredif/events{/privacy}","received_events_url":"https://api.github.com/users/mbredif/received_events","type":"User","site_admin":false},"repo":{"id":128071306,"name":"ros3djs","full_name":"mbredif/ros3djs","owner":{"login":"mbredif","id":7373521,"avatar_url":"https://avatars1.githubusercontent.com/u/7373521?v=4","gravatar_id":"","url":"https://api.github.com/users/mbredif","html_url":"https://github.com/mbredif","followers_url":"https://api.github.com/users/mbredif/followers","following_url":"https://api.github.com/users/mbredif/following{/other_user}","gists_url":"https://api.github.com/users/mbredif/gists{/gist_id}","starred_url":"https://api.github.com/users/mbredif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbredif/subscriptions","organizations_url":"https://api.github.com/users/mbredif/orgs","repos_url":"https://api.github.com/users/mbredif/repos","events_url":"https://api.github.com/users/mbredif/events{/privacy}","received_events_url":"https://api.github.com/users/mbredif/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mbredif/ros3djs","description":"3D Visualization Library for use with the ROS JavaScript Libraries","fork":true,"url":"https://api.github.com/repos/mbredif/ros3djs","forks_url":"https://api.github.com/repos/mbredif/ros3djs/forks","keys_url":"https://api.github.com/repos/mbredif/ros3djs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mbredif/ros3djs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mbredif/ros3djs/teams","hooks_url":"https://api.github.com/repos/mbredif/ros3djs/hooks","issue_events_url":"https://api.github.com/repos/mbredif/ros3djs/issues/events{/number}","events_url":"https://api.github.com/repos/mbredif/ros3djs/events","assignees_url":"https://api.github.com/repos/mbredif/ros3djs/assignees{/user}","branches_url":"https://api.github.com/repos/mbredif/ros3djs/branches{/branch}","tags_url":"https://api.github.com/repos/mbredif/ros3djs/tags","blobs_url":"https://api.github.com/repos/mbredif/ros3djs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mbredif/ros3djs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mbredif/ros3djs/git/refs{/sha}","trees_url":"https://api.github.com/repos/mbredif/ros3djs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mbredif/ros3djs/statuses/{sha}","languages_url":"https://api.github.com/repos/mbredif/ros3djs/languages","stargazers_url":"https://api.github.com/repos/mbredif/ros3djs/stargazers","contributors_url":"https://api.github.com/repos/mbredif/ros3djs/contributors","subscribers_url":"https://api.github.com/repos/mbredif/ros3djs/subscribers","subscription_url":"https://api.github.com/repos/mbredif/ros3djs/subscription","commits_url":"https://api.github.com/repos/mbredif/ros3djs/commits{/sha}","git_commits_url":"https://api.github.com/repos/mbredif/ros3djs/git/commits{/sha}","comments_url":"https://api.github.com/repos/mbredif/ros3djs/comments{/number}","issue_comment_url":"https://api.github.com/repos/mbredif/ros3djs/issues/comments{/number}","contents_url":"https://api.github.com/repos/mbredif/ros3djs/contents/{+path}","compare_url":"https://api.github.com/repos/mbredif/ros3djs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mbredif/ros3djs/merges","archive_url":"https://api.github.com/repos/mbredif/ros3djs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mbredif/ros3djs/downloads","issues_url":"https://api.github.com/repos/mbredif/ros3djs/issues{/number}","pulls_url":"https://api.github.com/repos/mbredif/ros3djs/pulls{/number}","milestones_url":"https://api.github.com/repos/mbredif/ros3djs/milestones{/number}","notifications_url":"https://api.github.com/repos/mbredif/ros3djs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mbredif/ros3djs/labels{/name}","releases_url":"https://api.github.com/repos/mbredif/ros3djs/releases{/id}","deployments_url":"https://api.github.com/repos/mbredif/ros3djs/deployments","created_at":"2018-04-04T14:07:42Z","updated_at":"2018-04-05T16:54:44Z","pushed_at":"2018-04-05T16:54:42Z","git_url":"git://github.com/mbredif/ros3djs.git","ssh_url":"git@github.com:mbredif/ros3djs.git","clone_url":"https://github.com/mbredif/ros3djs.git","svn_url":"https://github.com/mbredif/ros3djs","homepage":"http://robotwebtools.org/","size":3746,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"RobotWebTools:develop","ref":"develop","sha":"cd71c57c45c49c5335ed0752d75ff73612fe4400","user":{"login":"RobotWebTools","id":1491238,"avatar_url":"https://avatars2.githubusercontent.com/u/1491238?v=4","gravatar_id":"","url":"https://api.github.com/users/RobotWebTools","html_url":"https://github.com/RobotWebTools","followers_url":"https://api.github.com/users/RobotWebTools/followers","following_url":"https://api.github.com/users/RobotWebTools/following{/other_user}","gists_url":"https://api.github.com/users/RobotWebTools/gists{/gist_id}","starred_url":"https://api.github.com/users/RobotWebTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobotWebTools/subscriptions","organizations_url":"https://api.github.com/users/RobotWebTools/orgs","repos_url":"https://api.github.com/users/RobotWebTools/repos","events_url":"https://api.github.com/users/RobotWebTools/events{/privacy}","received_events_url":"https://api.github.com/users/RobotWebTools/received_events","type":"Organization","site_admin":false},"repo":{"id":8788891,"name":"ros3djs","full_name":"RobotWebTools/ros3djs","owner":{"login":"RobotWebTools","id":1491238,"avatar_url":"https://avatars2.githubusercontent.com/u/1491238?v=4","gravatar_id":"","url":"https://api.github.com/users/RobotWebTools","html_url":"https://github.com/RobotWebTools","followers_url":"https://api.github.com/users/RobotWebTools/followers","following_url":"https://api.github.com/users/RobotWebTools/following{/other_user}","gists_url":"https://api.github.com/users/RobotWebTools/gists{/gist_id}","starred_url":"https://api.github.com/users/RobotWebTools/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RobotWebTools/subscriptions","organizations_url":"https://api.github.com/users/RobotWebTools/orgs","repos_url":"https://api.github.com/users/RobotWebTools/repos","events_url":"https://api.github.com/users/RobotWebTools/events{/privacy}","received_events_url":"https://api.github.com/users/RobotWebTools/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RobotWebTools/ros3djs","description":"3D Visualization Library for use with the ROS JavaScript Libraries","fork":false,"url":"https://api.github.com/repos/RobotWebTools/ros3djs","forks_url":"https://api.github.com/repos/RobotWebTools/ros3djs/forks","keys_url":"https://api.github.com/repos/RobotWebTools/ros3djs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RobotWebTools/ros3djs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RobotWebTools/ros3djs/teams","hooks_url":"https://api.github.com/repos/RobotWebTools/ros3djs/hooks","issue_events_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/events{/number}","events_url":"https://api.github.com/repos/RobotWebTools/ros3djs/events","assignees_url":"https://api.github.com/repos/RobotWebTools/ros3djs/assignees{/user}","branches_url":"https://api.github.com/repos/RobotWebTools/ros3djs/branches{/branch}","tags_url":"https://api.github.com/repos/RobotWebTools/ros3djs/tags","blobs_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/refs{/sha}","trees_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RobotWebTools/ros3djs/statuses/{sha}","languages_url":"https://api.github.com/repos/RobotWebTools/ros3djs/languages","stargazers_url":"https://api.github.com/repos/RobotWebTools/ros3djs/stargazers","contributors_url":"https://api.github.com/repos/RobotWebTools/ros3djs/contributors","subscribers_url":"https://api.github.com/repos/RobotWebTools/ros3djs/subscribers","subscription_url":"https://api.github.com/repos/RobotWebTools/ros3djs/subscription","commits_url":"https://api.github.com/repos/RobotWebTools/ros3djs/commits{/sha}","git_commits_url":"https://api.github.com/repos/RobotWebTools/ros3djs/git/commits{/sha}","comments_url":"https://api.github.com/repos/RobotWebTools/ros3djs/comments{/number}","issue_comment_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/comments{/number}","contents_url":"https://api.github.com/repos/RobotWebTools/ros3djs/contents/{+path}","compare_url":"https://api.github.com/repos/RobotWebTools/ros3djs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RobotWebTools/ros3djs/merges","archive_url":"https://api.github.com/repos/RobotWebTools/ros3djs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RobotWebTools/ros3djs/downloads","issues_url":"https://api.github.com/repos/RobotWebTools/ros3djs/issues{/number}","pulls_url":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls{/number}","milestones_url":"https://api.github.com/repos/RobotWebTools/ros3djs/milestones{/number}","notifications_url":"https://api.github.com/repos/RobotWebTools/ros3djs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RobotWebTools/ros3djs/labels{/name}","releases_url":"https://api.github.com/repos/RobotWebTools/ros3djs/releases{/id}","deployments_url":"https://api.github.com/repos/RobotWebTools/ros3djs/deployments","created_at":"2013-03-15T00:52:55Z","updated_at":"2018-04-08T04:02:41Z","pushed_at":"2018-04-08T04:02:40Z","git_url":"git://github.com/RobotWebTools/ros3djs.git","ssh_url":"git@github.com:RobotWebTools/ros3djs.git","clone_url":"https://github.com/RobotWebTools/ros3djs.git","svn_url":"https://github.com/RobotWebTools/ros3djs","homepage":"http://robotwebtools.org/","size":3707,"stargazers_count":86,"watchers_count":86,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":90,"mirror_url":null,"archived":false,"open_issues_count":34,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":90,"open_issues":34,"watchers":86,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/218"},"html":{"href":"https://github.com/RobotWebTools/ros3djs/pull/218"},"issue":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/218"},"comments":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/issues/218/comments"},"review_comments":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/218/comments"},"review_comment":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/pulls/218/commits"},"statuses":{"href":"https://api.github.com/repos/RobotWebTools/ros3djs/statuses/d63760ba465d313ed0ad9e2cb5127f69ee815d2e"}},"author_association":"NONE"}}
{"actor":{"display_login":"jihoonl"}}