{"action":"created","comment":{"url":"https://api.github.com/repos/apache/beam/pulls/comments/237190647","pull_request_review_id":179429289,"id":237190647,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzE5MDY0Nw==","diff_hunk":"@@ -838,4 +884,50 @@ public final void prepareForProcessing() {}\n    */\n   @Override\n   public void populateDisplayData(DisplayData.Builder builder) {}\n+\n+  /**\n+   * A parameter that is accessible during {@link StartBundle @StartBundle}, {@link\n+   * ProcessElement @ProcessElement} and {@link FinishBundle @FinishBundle} that allows the caller\n+   * to register a callback that will be invoked after the bundle has been successfully completed\n+   * and the runner has commit the output.\n+   *\n+   * <p>A common usage would be to perform any acknowledgements required by an external system such\n+   * as acking messages from a message queue since this callback is only invoked after the output of\n+   * the bundle has been durably persisted by the runner.\n+   *\n+   * <p>Note that a runner may make the output of the bundle available immediately to downstream\n+   * consumers without waiting for finalization to succeed. For pipelines that are sensitive to\n+   * duplicate messages, they must perform output deduplication in the pipeline.\n+   */\n+  // TODO: Add support for a deduplication PTransform.\n+  @Experimental(Kind.SPLITTABLE_DO_FN)\n+  public interface BundleFinalizer {\n+    /**\n+     * The provided function will be called after the runner successfully commits the output of a\n+     * successful bundle. Throwing during finalization represents that bundle finalization may have\n+     * failed and the runner may choose to attempt finalization again. The provided duration\n+     * controls how long the finalization is valid for before it is garbage collected and no longer\n+     * able to be invoked.\n+     *\n+     * <p>Note that finalization is best effort and it is expected that the external system will\n+     * self recover state if finalization never happens or consistently fails. For example, a queue\n+     * based system that requires message acknowledgement would replay messages if that\n+     * acknowledgement was never received within the provided time bound.\n+     *\n+     * <p>See <a href=\"https://s.apache.org/beam-finalizing-bundles\">Apache Beam Portability API:\n+     * How to Finalize Bundles</a> for further details.\n+     */\n+    void afterBundleCommit(Duration finalizationDelayLimit, Callback callback);\n+\n+    /**\n+     * An instance of a function that will be invoked after bundle finalization.\n+     *\n+     * <p>Note that this function should maintain all state necessary outside of a DoFn's context to\n+     * be able to perform bundle finalization and should not rely on mutable state stored within a\n+     * DoFn instance.\n+     */\n+    interface Callback {","path":"sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/DoFn.java","position":null,"original_position":203,"commit_id":"8579dfaf6f00f7c522e12740aeee94a1a8cdbb12","original_commit_id":"eb3c764bb754d3235c91811fa66fe3159bcd7051","user":{"login":"swegner","id":674021,"node_id":"MDQ6VXNlcjY3NDAyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/674021?v=4","gravatar_id":"","url":"https://api.github.com/users/swegner","html_url":"https://github.com/swegner","followers_url":"https://api.github.com/users/swegner/followers","following_url":"https://api.github.com/users/swegner/following{/other_user}","gists_url":"https://api.github.com/users/swegner/gists{/gist_id}","starred_url":"https://api.github.com/users/swegner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/swegner/subscriptions","organizations_url":"https://api.github.com/users/swegner/orgs","repos_url":"https://api.github.com/users/swegner/repos","events_url":"https://api.github.com/users/swegner/events{/privacy}","received_events_url":"https://api.github.com/users/swegner/received_events","type":"User","site_admin":false},"body":"Cool, I wasn't familiar with the new Java 8 syntax. Thanks for the explanation.","created_at":"2018-11-28T17:42:16Z","updated_at":"2018-11-28T17:42:17Z","html_url":"https://github.com/apache/beam/pull/6969#discussion_r237190647","pull_request_url":"https://api.github.com/repos/apache/beam/pulls/6969","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/comments/237190647"},"html":{"href":"https://github.com/apache/beam/pull/6969#discussion_r237190647"},"pull_request":{"href":"https://api.github.com/repos/apache/beam/pulls/6969"}},"in_reply_to_id":235097184},"pull_request":{"url":"https://api.github.com/repos/apache/beam/pulls/6969","id":228882888,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4ODgyODg4","html_url":"https://github.com/apache/beam/pull/6969","diff_url":"https://github.com/apache/beam/pull/6969.diff","patch_url":"https://github.com/apache/beam/pull/6969.patch","issue_url":"https://api.github.com/repos/apache/beam/issues/6969","number":6969,"state":"open","locked":false,"title":"[BEAM-2939] SplittableDoFn Java SDK API Changes","user":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"body":"\r\n------------------------\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.\r\n - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).\r\n\r\nIt will help us expedite review of your Pull Request if you tag someone (e.g. `@username`) to look at it.\r\n\r\nPost-Commit Tests Status (on master branch)\r\n------------------------------------------------------------------------------------------------\r\n\r\nLang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark\r\n--- | --- | --- | --- | --- | --- | --- | ---\r\nGo | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Go_GradleBuild/lastCompletedBuild/) | --- | --- | --- | --- | --- | ---\r\nJava | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_GradleBuild/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Gradle/lastCompletedBuild/) [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza_Gradle/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark_Gradle/lastCompletedBuild/)\r\nPython | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_Verify/lastCompletedBuild/) | --- | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/) </br> [![Build Status](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [![Build Status](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/badge/icon)](https://builds.apache.org/job/beam_PostCommit_Python_VR_Flink/lastCompletedBuild/) | --- | --- | ---\r\n\r\n\r\n\r\n\r\n","created_at":"2018-11-07T00:44:24Z","updated_at":"2018-11-28T17:42:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0586fcb9eddd50334a515f193cf116a2dff30d55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/beam/pulls/6969/commits","review_comments_url":"https://api.github.com/repos/apache/beam/pulls/6969/comments","review_comment_url":"https://api.github.com/repos/apache/beam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/beam/issues/6969/comments","statuses_url":"https://api.github.com/repos/apache/beam/statuses/8579dfaf6f00f7c522e12740aeee94a1a8cdbb12","head":{"label":"lukecwik:splittabledofn4","ref":"splittabledofn4","sha":"8579dfaf6f00f7c522e12740aeee94a1a8cdbb12","user":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"repo":{"id":52895685,"node_id":"MDEwOlJlcG9zaXRvcnk1Mjg5NTY4NQ==","name":"incubator-beam","full_name":"lukecwik/incubator-beam","private":false,"owner":{"login":"lukecwik","id":10078956,"node_id":"MDQ6VXNlcjEwMDc4OTU2","avatar_url":"https://avatars3.githubusercontent.com/u/10078956?v=4","gravatar_id":"","url":"https://api.github.com/users/lukecwik","html_url":"https://github.com/lukecwik","followers_url":"https://api.github.com/users/lukecwik/followers","following_url":"https://api.github.com/users/lukecwik/following{/other_user}","gists_url":"https://api.github.com/users/lukecwik/gists{/gist_id}","starred_url":"https://api.github.com/users/lukecwik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lukecwik/subscriptions","organizations_url":"https://api.github.com/users/lukecwik/orgs","repos_url":"https://api.github.com/users/lukecwik/repos","events_url":"https://api.github.com/users/lukecwik/events{/privacy}","received_events_url":"https://api.github.com/users/lukecwik/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lukecwik/incubator-beam","description":"Mirror of Apache Beam (Incubating)","fork":true,"url":"https://api.github.com/repos/lukecwik/incubator-beam","forks_url":"https://api.github.com/repos/lukecwik/incubator-beam/forks","keys_url":"https://api.github.com/repos/lukecwik/incubator-beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lukecwik/incubator-beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lukecwik/incubator-beam/teams","hooks_url":"https://api.github.com/repos/lukecwik/incubator-beam/hooks","issue_events_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues/events{/number}","events_url":"https://api.github.com/repos/lukecwik/incubator-beam/events","assignees_url":"https://api.github.com/repos/lukecwik/incubator-beam/assignees{/user}","branches_url":"https://api.github.com/repos/lukecwik/incubator-beam/branches{/branch}","tags_url":"https://api.github.com/repos/lukecwik/incubator-beam/tags","blobs_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lukecwik/incubator-beam/statuses/{sha}","languages_url":"https://api.github.com/repos/lukecwik/incubator-beam/languages","stargazers_url":"https://api.github.com/repos/lukecwik/incubator-beam/stargazers","contributors_url":"https://api.github.com/repos/lukecwik/incubator-beam/contributors","subscribers_url":"https://api.github.com/repos/lukecwik/incubator-beam/subscribers","subscription_url":"https://api.github.com/repos/lukecwik/incubator-beam/subscription","commits_url":"https://api.github.com/repos/lukecwik/incubator-beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/lukecwik/incubator-beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/lukecwik/incubator-beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/lukecwik/incubator-beam/contents/{+path}","compare_url":"https://api.github.com/repos/lukecwik/incubator-beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lukecwik/incubator-beam/merges","archive_url":"https://api.github.com/repos/lukecwik/incubator-beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lukecwik/incubator-beam/downloads","issues_url":"https://api.github.com/repos/lukecwik/incubator-beam/issues{/number}","pulls_url":"https://api.github.com/repos/lukecwik/incubator-beam/pulls{/number}","milestones_url":"https://api.github.com/repos/lukecwik/incubator-beam/milestones{/number}","notifications_url":"https://api.github.com/repos/lukecwik/incubator-beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lukecwik/incubator-beam/labels{/name}","releases_url":"https://api.github.com/repos/lukecwik/incubator-beam/releases{/id}","deployments_url":"https://api.github.com/repos/lukecwik/incubator-beam/deployments","created_at":"2016-03-01T17:24:29Z","updated_at":"2018-11-27T15:54:39Z","pushed_at":"2018-11-28T01:11:53Z","git_url":"git://github.com/lukecwik/incubator-beam.git","ssh_url":"git@github.com:lukecwik/incubator-beam.git","clone_url":"https://github.com/lukecwik/incubator-beam.git","svn_url":"https://github.com/lukecwik/incubator-beam","homepage":null,"size":112075,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"c2aaf2d613f25df1754d67f61d29d7124ac06b50","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":50904245,"node_id":"MDEwOlJlcG9zaXRvcnk1MDkwNDI0NQ==","name":"beam","full_name":"apache/beam","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/beam","description":"Apache Beam","fork":false,"url":"https://api.github.com/repos/apache/beam","forks_url":"https://api.github.com/repos/apache/beam/forks","keys_url":"https://api.github.com/repos/apache/beam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/beam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/beam/teams","hooks_url":"https://api.github.com/repos/apache/beam/hooks","issue_events_url":"https://api.github.com/repos/apache/beam/issues/events{/number}","events_url":"https://api.github.com/repos/apache/beam/events","assignees_url":"https://api.github.com/repos/apache/beam/assignees{/user}","branches_url":"https://api.github.com/repos/apache/beam/branches{/branch}","tags_url":"https://api.github.com/repos/apache/beam/tags","blobs_url":"https://api.github.com/repos/apache/beam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/beam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/beam/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/beam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/beam/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/beam/languages","stargazers_url":"https://api.github.com/repos/apache/beam/stargazers","contributors_url":"https://api.github.com/repos/apache/beam/contributors","subscribers_url":"https://api.github.com/repos/apache/beam/subscribers","subscription_url":"https://api.github.com/repos/apache/beam/subscription","commits_url":"https://api.github.com/repos/apache/beam/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/beam/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/beam/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/beam/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/beam/contents/{+path}","compare_url":"https://api.github.com/repos/apache/beam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/beam/merges","archive_url":"https://api.github.com/repos/apache/beam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/beam/downloads","issues_url":"https://api.github.com/repos/apache/beam/issues{/number}","pulls_url":"https://api.github.com/repos/apache/beam/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/beam/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/beam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/beam/labels{/name}","releases_url":"https://api.github.com/repos/apache/beam/releases{/id}","deployments_url":"https://api.github.com/repos/apache/beam/deployments","created_at":"2016-02-02T08:00:06Z","updated_at":"2018-11-28T17:08:14Z","pushed_at":"2018-11-28T17:07:58Z","git_url":"git://github.com/apache/beam.git","ssh_url":"git@github.com:apache/beam.git","clone_url":"https://github.com/apache/beam.git","svn_url":"https://github.com/apache/beam","homepage":"https://beam.apache.org","size":112886,"stargazers_count":2345,"watchers_count":2345,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1478,"mirror_url":null,"archived":false,"open_issues_count":78,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1478,"open_issues":78,"watchers":2345,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/beam/pulls/6969"},"html":{"href":"https://github.com/apache/beam/pull/6969"},"issue":{"href":"https://api.github.com/repos/apache/beam/issues/6969"},"comments":{"href":"https://api.github.com/repos/apache/beam/issues/6969/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/beam/pulls/6969/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/beam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/beam/pulls/6969/commits"},"statuses":{"href":"https://api.github.com/repos/apache/beam/statuses/8579dfaf6f00f7c522e12740aeee94a1a8cdbb12"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"swegner"}}