{"action":"created","issue":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/10293","repository_url":"https://api.github.com/repos/WordPress/gutenberg","labels_url":"https://api.github.com/repos/WordPress/gutenberg/issues/10293/labels{/name}","comments_url":"https://api.github.com/repos/WordPress/gutenberg/issues/10293/comments","events_url":"https://api.github.com/repos/WordPress/gutenberg/issues/10293/events","html_url":"https://github.com/WordPress/gutenberg/pull/10293","id":366058764,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5ODI4NTQw","number":10293,"title":"Fix button alignment","user":{"login":"kshitijdeota","id":1005012,"node_id":"MDQ6VXNlcjEwMDUwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005012?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitijdeota","html_url":"https://github.com/kshitijdeota","followers_url":"https://api.github.com/users/kshitijdeota/followers","following_url":"https://api.github.com/users/kshitijdeota/following{/other_user}","gists_url":"https://api.github.com/users/kshitijdeota/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitijdeota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitijdeota/subscriptions","organizations_url":"https://api.github.com/users/kshitijdeota/orgs","repos_url":"https://api.github.com/users/kshitijdeota/repos","events_url":"https://api.github.com/users/kshitijdeota/events{/privacy}","received_events_url":"https://api.github.com/users/kshitijdeota/received_events","type":"User","site_admin":false},"labels":[{"id":570263070,"node_id":"MDU6TGFiZWw1NzAyNjMwNzA=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/Blocks","name":"Blocks","color":"fbca04","default":false},{"id":630674253,"node_id":"MDU6TGFiZWw2MzA2NzQyNTM=","url":"https://api.github.com/repos/WordPress/gutenberg/labels/[Status]%20Needs%20More%20Info","name":"[Status] Needs More Info","color":"0052cc","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-02T20:06:24Z","updated_at":"2018-10-10T08:58:20Z","closed_at":"2018-10-10T08:58:20Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/WordPress/gutenberg/pulls/10293","html_url":"https://github.com/WordPress/gutenberg/pull/10293","diff_url":"https://github.com/WordPress/gutenberg/pull/10293.diff","patch_url":"https://github.com/WordPress/gutenberg/pull/10293.patch"},"body":"## Description\r\n.wp-block-button needs to be a 'block' element for 'aligncenter' to work on actual inner 'button' elements using 'text-align: centre' to centre.\r\nUse case (From Gutenberg demo post) : \r\n\r\n```\r\n<div class=\"wp-block-button aligncenter\">\r\n   <a class=\"wp-block-button__link\" href=\"https://github.com/WordPress/gutenberg\">Help build Gutenberg</a>\r\n</div>\r\n\r\n```\r\n\r\n## How has this been tested?\r\nStandard WordPress installation with demo posts and pages, Gutenberg installed and enabled alongside Woocommerce and Jetpack plugin. \r\nBrowser : Safari 12, Firefox Quantum 62, Google Chrome 69.0.3497.100 \r\n\r\n## Types of changes\r\nChanging CSS display type for 'wp-block-button' from 'inline-block' to 'block' level element.\r\n\r\n## Checklist:\r\n- [x] My code is tested.\r\n- [x] My code follows the WordPress code style. <!-- Check code: `npm run lint`, Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/javascript/ -->\r\n- [x] My code follows the accessibility standards. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/coding-standards/accessibility-coding-standards/ -->\r\n- [x] My code has proper inline documentation. <!-- Guidelines: https://make.wordpress.org/core/handbook/best-practices/inline-documentation-standards/javascript/ -->"},"comment":{"url":"https://api.github.com/repos/WordPress/gutenberg/issues/comments/428493562","html_url":"https://github.com/WordPress/gutenberg/pull/10293#issuecomment-428493562","issue_url":"https://api.github.com/repos/WordPress/gutenberg/issues/10293","id":428493562,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODQ5MzU2Mg==","user":{"login":"kshitijdeota","id":1005012,"node_id":"MDQ6VXNlcjEwMDUwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1005012?v=4","gravatar_id":"","url":"https://api.github.com/users/kshitijdeota","html_url":"https://github.com/kshitijdeota","followers_url":"https://api.github.com/users/kshitijdeota/followers","following_url":"https://api.github.com/users/kshitijdeota/following{/other_user}","gists_url":"https://api.github.com/users/kshitijdeota/gists{/gist_id}","starred_url":"https://api.github.com/users/kshitijdeota/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kshitijdeota/subscriptions","organizations_url":"https://api.github.com/users/kshitijdeota/orgs","repos_url":"https://api.github.com/users/kshitijdeota/repos","events_url":"https://api.github.com/users/kshitijdeota/events{/privacy}","received_events_url":"https://api.github.com/users/kshitijdeota/received_events","type":"User","site_admin":false},"created_at":"2018-10-10T08:58:20Z","updated_at":"2018-10-10T08:58:20Z","author_association":"NONE","body":"This change is absolutely not required as the button is within a default block level element (div). So in any case if the alignment fails it has to be a theme specific issue every time.\r\n\r\nThank you @chrisvanpatten for being so kind and clearing things up, I really appreciate your time and efforts. I should be more thorough and alert. 😅\r\nCheers! 🍻"}}
{"actor":{"display_login":"kshitijdeota"}}