{"action":"closed","number":1796,"pull_request":{"url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1796","id":156838045,"node_id":"MDExOlB1bGxSZXF1ZXN0MTU2ODM4MDQ1","html_url":"https://github.com/pi-hole/pi-hole/pull/1796","diff_url":"https://github.com/pi-hole/pi-hole/pull/1796.diff","patch_url":"https://github.com/pi-hole/pi-hole/pull/1796.patch","issue_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1796","number":1796,"state":"closed","locked":false,"title":"added the tested logic for the password validation for the issue # 1781…","user":{"login":"sri786","id":21104237,"node_id":"MDQ6VXNlcjIxMTA0MjM3","avatar_url":"https://avatars0.githubusercontent.com/u/21104237?v=4","gravatar_id":"","url":"https://api.github.com/users/sri786","html_url":"https://github.com/sri786","followers_url":"https://api.github.com/users/sri786/followers","following_url":"https://api.github.com/users/sri786/following{/other_user}","gists_url":"https://api.github.com/users/sri786/gists{/gist_id}","starred_url":"https://api.github.com/users/sri786/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri786/subscriptions","organizations_url":"https://api.github.com/users/sri786/orgs","repos_url":"https://api.github.com/users/sri786/repos","events_url":"https://api.github.com/users/sri786/events{/privacy}","received_events_url":"https://api.github.com/users/sri786/received_events","type":"User","site_admin":false},"body":"**By submitting this pull request, I confirm the following (please check boxes, eg [X]) _Failure to fill the template will close your PR_:**\r\n\r\n***Please submit all pull requests against the `development` branch. Failure to do so will delay or deny your request***\r\n\r\n- [X] I have read and understood the [contributors guide](https://github.com/pi-hole/pi-hole/blob/master/CONTRIBUTING.md).\r\n- [X] I have checked that [another pull request](https://github.com/pi-hole/pi-hole/pulls) for this purpose does not exist.\r\n- [X] I have considered, and confirmed that this submission will be valuable to others.\r\n- [X] I accept that this submission may not be used, and the pull request closed at the will of the maintainer.\r\n- [X] I give this submission freely, and claim no ownership to its content.\r\n\r\n**How familiar are you with the codebase?:**\r\n\r\n8\r\n\r\nFollowing is the link for detailed documentation of the issue and the changes with the test results:\r\n[pihole-issue-1781-documentation.docx](https://github.com/pi-hole/pi-hole/files/1536793/pihole-issue-1781-documentation.docx)\r\n\r\nFollowing is the pull request content (line 100 to 121):\r\n![image](https://user-images.githubusercontent.com/21104237/33684183-03952d38-da93-11e7-83fb-97f0a5ba9ff2.png)\r\n\r\n\r\n_This template was created based on the work of [`udemy-dl`](https://github.com/nishad/udemy-dl/blob/master/LICENSE)._\r\n","created_at":"2017-12-06T20:59:32Z","updated_at":"2018-07-10T01:35:58Z","closed_at":"2018-07-10T01:35:58Z","merged_at":null,"merge_commit_sha":"642e6b6812b9dbf56da14fd1cf4a9726c9b9e62a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":458736810,"node_id":"MDU6TGFiZWw0NTg3MzY4MTA=","url":"https://api.github.com/repos/pi-hole/pi-hole/labels/WIP","name":"WIP","color":"00a7ed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1796/commits","review_comments_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1796/comments","review_comment_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/1796/comments","statuses_url":"https://api.github.com/repos/pi-hole/pi-hole/statuses/3f392a9e381f16ea8f6e21b3b664e263279c20c3","head":{"label":"sri786:sri786","ref":"sri786","sha":"3f392a9e381f16ea8f6e21b3b664e263279c20c3","user":{"login":"sri786","id":21104237,"node_id":"MDQ6VXNlcjIxMTA0MjM3","avatar_url":"https://avatars0.githubusercontent.com/u/21104237?v=4","gravatar_id":"","url":"https://api.github.com/users/sri786","html_url":"https://github.com/sri786","followers_url":"https://api.github.com/users/sri786/followers","following_url":"https://api.github.com/users/sri786/following{/other_user}","gists_url":"https://api.github.com/users/sri786/gists{/gist_id}","starred_url":"https://api.github.com/users/sri786/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri786/subscriptions","organizations_url":"https://api.github.com/users/sri786/orgs","repos_url":"https://api.github.com/users/sri786/repos","events_url":"https://api.github.com/users/sri786/events{/privacy}","received_events_url":"https://api.github.com/users/sri786/received_events","type":"User","site_admin":false},"repo":{"id":113138153,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMxMzgxNTM=","name":"pi-hole","full_name":"sri786/pi-hole","owner":{"login":"sri786","id":21104237,"node_id":"MDQ6VXNlcjIxMTA0MjM3","avatar_url":"https://avatars0.githubusercontent.com/u/21104237?v=4","gravatar_id":"","url":"https://api.github.com/users/sri786","html_url":"https://github.com/sri786","followers_url":"https://api.github.com/users/sri786/followers","following_url":"https://api.github.com/users/sri786/following{/other_user}","gists_url":"https://api.github.com/users/sri786/gists{/gist_id}","starred_url":"https://api.github.com/users/sri786/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sri786/subscriptions","organizations_url":"https://api.github.com/users/sri786/orgs","repos_url":"https://api.github.com/users/sri786/repos","events_url":"https://api.github.com/users/sri786/events{/privacy}","received_events_url":"https://api.github.com/users/sri786/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sri786/pi-hole","description":"A black hole for Internet advertisements","fork":true,"url":"https://api.github.com/repos/sri786/pi-hole","forks_url":"https://api.github.com/repos/sri786/pi-hole/forks","keys_url":"https://api.github.com/repos/sri786/pi-hole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sri786/pi-hole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sri786/pi-hole/teams","hooks_url":"https://api.github.com/repos/sri786/pi-hole/hooks","issue_events_url":"https://api.github.com/repos/sri786/pi-hole/issues/events{/number}","events_url":"https://api.github.com/repos/sri786/pi-hole/events","assignees_url":"https://api.github.com/repos/sri786/pi-hole/assignees{/user}","branches_url":"https://api.github.com/repos/sri786/pi-hole/branches{/branch}","tags_url":"https://api.github.com/repos/sri786/pi-hole/tags","blobs_url":"https://api.github.com/repos/sri786/pi-hole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sri786/pi-hole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sri786/pi-hole/git/refs{/sha}","trees_url":"https://api.github.com/repos/sri786/pi-hole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sri786/pi-hole/statuses/{sha}","languages_url":"https://api.github.com/repos/sri786/pi-hole/languages","stargazers_url":"https://api.github.com/repos/sri786/pi-hole/stargazers","contributors_url":"https://api.github.com/repos/sri786/pi-hole/contributors","subscribers_url":"https://api.github.com/repos/sri786/pi-hole/subscribers","subscription_url":"https://api.github.com/repos/sri786/pi-hole/subscription","commits_url":"https://api.github.com/repos/sri786/pi-hole/commits{/sha}","git_commits_url":"https://api.github.com/repos/sri786/pi-hole/git/commits{/sha}","comments_url":"https://api.github.com/repos/sri786/pi-hole/comments{/number}","issue_comment_url":"https://api.github.com/repos/sri786/pi-hole/issues/comments{/number}","contents_url":"https://api.github.com/repos/sri786/pi-hole/contents/{+path}","compare_url":"https://api.github.com/repos/sri786/pi-hole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sri786/pi-hole/merges","archive_url":"https://api.github.com/repos/sri786/pi-hole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sri786/pi-hole/downloads","issues_url":"https://api.github.com/repos/sri786/pi-hole/issues{/number}","pulls_url":"https://api.github.com/repos/sri786/pi-hole/pulls{/number}","milestones_url":"https://api.github.com/repos/sri786/pi-hole/milestones{/number}","notifications_url":"https://api.github.com/repos/sri786/pi-hole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sri786/pi-hole/labels{/name}","releases_url":"https://api.github.com/repos/sri786/pi-hole/releases{/id}","deployments_url":"https://api.github.com/repos/sri786/pi-hole/deployments","created_at":"2017-12-05T05:43:24Z","updated_at":"2017-12-05T05:43:26Z","pushed_at":"2017-12-06T20:30:39Z","git_url":"git://github.com/sri786/pi-hole.git","ssh_url":"git@github.com:sri786/pi-hole.git","clone_url":"https://github.com/sri786/pi-hole.git","svn_url":"https://github.com/sri786/pi-hole","homepage":"https://pi-hole.net","size":3349,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pi-hole:development","ref":"development","sha":"472f7725c7f493ac2194f41352c2ad15894ab95c","user":{"login":"pi-hole","id":16827203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODI3MjAz","avatar_url":"https://avatars2.githubusercontent.com/u/16827203?v=4","gravatar_id":"","url":"https://api.github.com/users/pi-hole","html_url":"https://github.com/pi-hole","followers_url":"https://api.github.com/users/pi-hole/followers","following_url":"https://api.github.com/users/pi-hole/following{/other_user}","gists_url":"https://api.github.com/users/pi-hole/gists{/gist_id}","starred_url":"https://api.github.com/users/pi-hole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi-hole/subscriptions","organizations_url":"https://api.github.com/users/pi-hole/orgs","repos_url":"https://api.github.com/users/pi-hole/repos","events_url":"https://api.github.com/users/pi-hole/events{/privacy}","received_events_url":"https://api.github.com/users/pi-hole/received_events","type":"Organization","site_admin":false},"repo":{"id":20619036,"node_id":"MDEwOlJlcG9zaXRvcnkyMDYxOTAzNg==","name":"pi-hole","full_name":"pi-hole/pi-hole","owner":{"login":"pi-hole","id":16827203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODI3MjAz","avatar_url":"https://avatars2.githubusercontent.com/u/16827203?v=4","gravatar_id":"","url":"https://api.github.com/users/pi-hole","html_url":"https://github.com/pi-hole","followers_url":"https://api.github.com/users/pi-hole/followers","following_url":"https://api.github.com/users/pi-hole/following{/other_user}","gists_url":"https://api.github.com/users/pi-hole/gists{/gist_id}","starred_url":"https://api.github.com/users/pi-hole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pi-hole/subscriptions","organizations_url":"https://api.github.com/users/pi-hole/orgs","repos_url":"https://api.github.com/users/pi-hole/repos","events_url":"https://api.github.com/users/pi-hole/events{/privacy}","received_events_url":"https://api.github.com/users/pi-hole/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pi-hole/pi-hole","description":"A black hole for Internet advertisements","fork":false,"url":"https://api.github.com/repos/pi-hole/pi-hole","forks_url":"https://api.github.com/repos/pi-hole/pi-hole/forks","keys_url":"https://api.github.com/repos/pi-hole/pi-hole/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pi-hole/pi-hole/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pi-hole/pi-hole/teams","hooks_url":"https://api.github.com/repos/pi-hole/pi-hole/hooks","issue_events_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/events{/number}","events_url":"https://api.github.com/repos/pi-hole/pi-hole/events","assignees_url":"https://api.github.com/repos/pi-hole/pi-hole/assignees{/user}","branches_url":"https://api.github.com/repos/pi-hole/pi-hole/branches{/branch}","tags_url":"https://api.github.com/repos/pi-hole/pi-hole/tags","blobs_url":"https://api.github.com/repos/pi-hole/pi-hole/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pi-hole/pi-hole/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pi-hole/pi-hole/git/refs{/sha}","trees_url":"https://api.github.com/repos/pi-hole/pi-hole/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pi-hole/pi-hole/statuses/{sha}","languages_url":"https://api.github.com/repos/pi-hole/pi-hole/languages","stargazers_url":"https://api.github.com/repos/pi-hole/pi-hole/stargazers","contributors_url":"https://api.github.com/repos/pi-hole/pi-hole/contributors","subscribers_url":"https://api.github.com/repos/pi-hole/pi-hole/subscribers","subscription_url":"https://api.github.com/repos/pi-hole/pi-hole/subscription","commits_url":"https://api.github.com/repos/pi-hole/pi-hole/commits{/sha}","git_commits_url":"https://api.github.com/repos/pi-hole/pi-hole/git/commits{/sha}","comments_url":"https://api.github.com/repos/pi-hole/pi-hole/comments{/number}","issue_comment_url":"https://api.github.com/repos/pi-hole/pi-hole/issues/comments{/number}","contents_url":"https://api.github.com/repos/pi-hole/pi-hole/contents/{+path}","compare_url":"https://api.github.com/repos/pi-hole/pi-hole/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pi-hole/pi-hole/merges","archive_url":"https://api.github.com/repos/pi-hole/pi-hole/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pi-hole/pi-hole/downloads","issues_url":"https://api.github.com/repos/pi-hole/pi-hole/issues{/number}","pulls_url":"https://api.github.com/repos/pi-hole/pi-hole/pulls{/number}","milestones_url":"https://api.github.com/repos/pi-hole/pi-hole/milestones{/number}","notifications_url":"https://api.github.com/repos/pi-hole/pi-hole/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pi-hole/pi-hole/labels{/name}","releases_url":"https://api.github.com/repos/pi-hole/pi-hole/releases{/id}","deployments_url":"https://api.github.com/repos/pi-hole/pi-hole/deployments","created_at":"2014-06-08T15:02:55Z","updated_at":"2018-07-10T00:07:58Z","pushed_at":"2018-07-10T01:32:13Z","git_url":"git://github.com/pi-hole/pi-hole.git","ssh_url":"git@github.com:pi-hole/pi-hole.git","clone_url":"https://github.com/pi-hole/pi-hole.git","svn_url":"https://github.com/pi-hole/pi-hole","homepage":"https://pi-hole.net","size":4015,"stargazers_count":9124,"watchers_count":9124,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":736,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":736,"open_issues":58,"watchers":9124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1796"},"html":{"href":"https://github.com/pi-hole/pi-hole/pull/1796"},"issue":{"href":"https://api.github.com/repos/pi-hole/pi-hole/issues/1796"},"comments":{"href":"https://api.github.com/repos/pi-hole/pi-hole/issues/1796/comments"},"review_comments":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1796/comments"},"review_comment":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pi-hole/pi-hole/pulls/1796/commits"},"statuses":{"href":"https://api.github.com/repos/pi-hole/pi-hole/statuses/3f392a9e381f16ea8f6e21b3b664e263279c20c3"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":11,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":32,"deletions":19,"changed_files":1}}
{"actor":{"display_login":"dschaper"}}