{"action":"created","issue":{"url":"https://api.github.com/repos/Benjamin-Dobell/Heimdall/issues/432","repository_url":"https://api.github.com/repos/Benjamin-Dobell/Heimdall","labels_url":"https://api.github.com/repos/Benjamin-Dobell/Heimdall/issues/432/labels{/name}","comments_url":"https://api.github.com/repos/Benjamin-Dobell/Heimdall/issues/432/comments","events_url":"https://api.github.com/repos/Benjamin-Dobell/Heimdall/issues/432/events","html_url":"https://github.com/Benjamin-Dobell/Heimdall/issues/432","id":267480701,"number":432,"title":"\"#define nullptr 0\" breaks build w/libc++","user":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2017-10-22T16:58:22Z","updated_at":"2018-02-23T19:52:23Z","closed_at":null,"author_association":"NONE","body":"This is done in `heimdall/source/Heimdall.h` and `libpit/source/libpit.h`.\r\n\r\nUnfortunately this breaks the build for me (w/libc++ and clang 4.0), but I'm surprised it doesn't break elsewhere--nullptr needs to be `std::nullptr_t` not `int`.\r\n\r\nI'm guessing this code is meant as part of transition to C++11, presumably it can be removed now?\r\n\r\n`git blame` points to [this commit](https://github.com/Benjamin-Dobell/Heimdall/commit/4d850a272aabe91eab08bcc735b4297d51e6e35f) for what it's worth.\r\n\r\nIf there's a platform that needs this for compatibility reasons perhaps instead of guarding with `#ifndef` the code instead checks for C++ version (`#if __cplusplus < 201103L`) or so?\r\n\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/Benjamin-Dobell/Heimdall/issues/comments/368120695","html_url":"https://github.com/Benjamin-Dobell/Heimdall/issues/432#issuecomment-368120695","issue_url":"https://api.github.com/repos/Benjamin-Dobell/Heimdall/issues/432","id":368120695,"user":{"login":"dtzWill","id":817330,"avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"created_at":"2018-02-23T19:52:23Z","updated_at":"2018-02-23T19:52:23Z","author_association":"NONE","body":"(no longer want to track this, hopefully no longer a problem :))"}}
{"actor":{"display_login":"dtzWill"}}