{"action":"created","issue":{"url":"https://api.github.com/repos/onivim/oni/issues/2391","repository_url":"https://api.github.com/repos/onivim/oni","labels_url":"https://api.github.com/repos/onivim/oni/issues/2391/labels{/name}","comments_url":"https://api.github.com/repos/onivim/oni/issues/2391/comments","events_url":"https://api.github.com/repos/onivim/oni/issues/2391/events","html_url":"https://github.com/onivim/oni/pull/2391","id":337715091,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4ODI4MDg3","number":2391,"title":"[WIP] Added coloring option for dirty-marker","user":{"login":"wheyerstrass","id":37278089,"node_id":"MDQ6VXNlcjM3Mjc4MDg5","avatar_url":"https://avatars2.githubusercontent.com/u/37278089?v=4","gravatar_id":"","url":"https://api.github.com/users/wheyerstrass","html_url":"https://github.com/wheyerstrass","followers_url":"https://api.github.com/users/wheyerstrass/followers","following_url":"https://api.github.com/users/wheyerstrass/following{/other_user}","gists_url":"https://api.github.com/users/wheyerstrass/gists{/gist_id}","starred_url":"https://api.github.com/users/wheyerstrass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wheyerstrass/subscriptions","organizations_url":"https://api.github.com/users/wheyerstrass/orgs","repos_url":"https://api.github.com/users/wheyerstrass/repos","events_url":"https://api.github.com/users/wheyerstrass/events{/privacy}","received_events_url":"https://api.github.com/users/wheyerstrass/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-03T01:35:09Z","updated_at":"2018-07-04T20:19:22Z","closed_at":"2018-07-04T20:02:27Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/onivim/oni/pulls/2391","html_url":"https://github.com/onivim/oni/pull/2391","diff_url":"https://github.com/onivim/oni/pull/2391.diff","patch_url":"https://github.com/onivim/oni/pull/2391.patch"},"body":"As dicussed with @Akin909 and @hoschi in #1580 I created a styled component that replaces the current dirty-marker. Its `background-color` can be customized using the configuration key `editor.dirtyMarker.userColor`, which accepts css color values and defaults to the current themes `foreground` color."},"comment":{"url":"https://api.github.com/repos/onivim/oni/issues/comments/402553572","html_url":"https://github.com/onivim/oni/pull/2391#issuecomment-402553572","issue_url":"https://api.github.com/repos/onivim/oni/issues/2391","id":402553572,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjU1MzU3Mg==","user":{"login":"wheyerstrass","id":37278089,"node_id":"MDQ6VXNlcjM3Mjc4MDg5","avatar_url":"https://avatars2.githubusercontent.com/u/37278089?v=4","gravatar_id":"","url":"https://api.github.com/users/wheyerstrass","html_url":"https://github.com/wheyerstrass","followers_url":"https://api.github.com/users/wheyerstrass/followers","following_url":"https://api.github.com/users/wheyerstrass/following{/other_user}","gists_url":"https://api.github.com/users/wheyerstrass/gists{/gist_id}","starred_url":"https://api.github.com/users/wheyerstrass/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wheyerstrass/subscriptions","organizations_url":"https://api.github.com/users/wheyerstrass/orgs","repos_url":"https://api.github.com/users/wheyerstrass/repos","events_url":"https://api.github.com/users/wheyerstrass/events{/privacy}","received_events_url":"https://api.github.com/users/wheyerstrass/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T20:19:22Z","updated_at":"2018-07-04T20:19:22Z","author_association":"CONTRIBUTOR","body":"@Akin909 I wanted to make the config to dirty-marker component passing more robust, because right now this line:  \r\n```js\r\nbackground-color: ${props => props.userColor || props.theme.foreground}\r\n```\r\nwould fail if `userColor === \"\"`\r\nI'd add that and then remove the WIP.\r\n"}}
{"actor":{"display_login":"wheyerstrass"}}