{"action":"created","issue":{"url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/733","repository_url":"https://api.github.com/repos/sul-dlss/preservation_catalog","labels_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/733/labels{/name}","comments_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/733/comments","events_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/733/events","html_url":"https://github.com/sul-dlss/preservation_catalog/pull/733","id":320126409,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg1ODczMjgw","number":733,"title":"Account for rubocop exceptions in the right places","user":{"login":"atz","id":109954,"node_id":"MDQ6VXNlcjEwOTk1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/109954?v=4","gravatar_id":"","url":"https://api.github.com/users/atz","html_url":"https://github.com/atz","followers_url":"https://api.github.com/users/atz/followers","following_url":"https://api.github.com/users/atz/following{/other_user}","gists_url":"https://api.github.com/users/atz/gists{/gist_id}","starred_url":"https://api.github.com/users/atz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atz/subscriptions","organizations_url":"https://api.github.com/users/atz/orgs","repos_url":"https://api.github.com/users/atz/repos","events_url":"https://api.github.com/users/atz/events{/privacy}","received_events_url":"https://api.github.com/users/atz/received_events","type":"User","site_admin":false},"labels":[{"id":719133329,"node_id":"MDU6TGFiZWw3MTkxMzMzMjk=","url":"https://api.github.com/repos/sul-dlss/preservation_catalog/labels/needs%20review","name":"needs review","color":"e6e6e6","default":false},{"id":709763140,"node_id":"MDU6TGFiZWw3MDk3NjMxNDA=","url":"https://api.github.com/repos/sul-dlss/preservation_catalog/labels/refactor","name":"refactor","color":"c2e0c6","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-05-04T00:57:02Z","updated_at":"2018-08-13T17:47:42Z","closed_at":"2018-08-13T17:47:42Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/sul-dlss/preservation_catalog/pulls/733","html_url":"https://github.com/sul-dlss/preservation_catalog/pull/733","diff_url":"https://github.com/sul-dlss/preservation_catalog/pull/733.diff","patch_url":"https://github.com/sul-dlss/preservation_catalog/pull/733.patch"},"body":"By definition \"shameless green\" style exceptions are not the same as others we may intend permanently.  The right place for those to live is the TODO file. That way when they get fixed (intentionally or coincidentally), the exclusion can just be mechanically deleted/overwritten by `--auto-gen-config`.\r\n\r\nThe `puts` statements exceptions are a good example of why storing many of these cases in `.rubocop.yml` is misguided.  Those cases where already cleaned up.  If they lived in `.rubocop_todo.yml`, they would never have needed to be revisited manually, since auto-generating the TODO file would do the trick."},"comment":{"url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/comments/412604646","html_url":"https://github.com/sul-dlss/preservation_catalog/pull/733#issuecomment-412604646","issue_url":"https://api.github.com/repos/sul-dlss/preservation_catalog/issues/733","id":412604646,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjYwNDY0Ng==","user":{"login":"SaravShah","id":7877303,"node_id":"MDQ6VXNlcjc4NzczMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/7877303?v=4","gravatar_id":"","url":"https://api.github.com/users/SaravShah","html_url":"https://github.com/SaravShah","followers_url":"https://api.github.com/users/SaravShah/followers","following_url":"https://api.github.com/users/SaravShah/following{/other_user}","gists_url":"https://api.github.com/users/SaravShah/gists{/gist_id}","starred_url":"https://api.github.com/users/SaravShah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SaravShah/subscriptions","organizations_url":"https://api.github.com/users/SaravShah/orgs","repos_url":"https://api.github.com/users/SaravShah/repos","events_url":"https://api.github.com/users/SaravShah/events{/privacy}","received_events_url":"https://api.github.com/users/SaravShah/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T17:47:42Z","updated_at":"2018-08-13T17:47:42Z","author_association":"CONTRIBUTOR","body":"close in favor of #1069 1069"}}
{"actor":{"display_login":"SaravShah"}}