{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/comments/217726871","pull_request_review_id":155513717,"id":217726871,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzcyNjg3MQ==","diff_hunk":"@@ -228,43 +231,54 @@ typeOf (TyInst x t ty) = do\n             k' <- kindOf ty\n             typeCheckStep\n             if k == k'\n-                then pure (tyReduce (tySubstitute (extractUnique n) (void ty) ty''))\n+                then tyReduce =<< tySubstitute (extractUnique n) (void ty) ty''\n                 else throwError (KindMismatch x (void ty) k k')\n         _ -> throwError (TypeMismatch x (void t) (TyForall () dummyTyName dummyKind dummyType) (void ty'))\n typeOf (Unwrap x t) = do\n     ty <- typeOf t\n     case ty of\n         TyFix _ n ty' -> do\n-            let subst = tySubstitute (extractUnique n) ty ty'\n-            pure (tyReduce subst)\n+            subst <- tySubstitute (extractUnique n) ty ty'\n+            typeCheckStep","path":"language-plutus-core/src/Language/PlutusCore/TypeSynthesis.hs","position":89,"original_position":89,"commit_id":"047f1962eb45aa14b3c76f9b68b3385193956b14","original_commit_id":"148b0804ad1e7c1741a51e588a572dbf9ed6e47c","user":{"login":"vmchale","id":13259982,"node_id":"MDQ6VXNlcjEzMjU5OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/13259982?v=4","gravatar_id":"","url":"https://api.github.com/users/vmchale","html_url":"https://github.com/vmchale","followers_url":"https://api.github.com/users/vmchale/followers","following_url":"https://api.github.com/users/vmchale/following{/other_user}","gists_url":"https://api.github.com/users/vmchale/gists{/gist_id}","starred_url":"https://api.github.com/users/vmchale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmchale/subscriptions","organizations_url":"https://api.github.com/users/vmchale/orgs","repos_url":"https://api.github.com/users/vmchale/repos","events_url":"https://api.github.com/users/vmchale/events{/privacy}","received_events_url":"https://api.github.com/users/vmchale/received_events","type":"User","site_admin":false},"body":"Oh, no I was confused. I believe they accompany a `tySubstitute`. Perhaps I should put them before? ","created_at":"2018-09-14T14:13:22Z","updated_at":"2018-09-14T14:13:22Z","html_url":"https://github.com/input-output-hk/plutus-prototype/pull/110#discussion_r217726871","pull_request_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/110","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/comments/217726871"},"html":{"href":"https://github.com/input-output-hk/plutus-prototype/pull/110#discussion_r217726871"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/110"}},"in_reply_to_id":217659745},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/110","id":215464471,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NDY0NDcx","html_url":"https://github.com/input-output-hk/plutus-prototype/pull/110","diff_url":"https://github.com/input-output-hk/plutus-prototype/pull/110.diff","patch_url":"https://github.com/input-output-hk/plutus-prototype/pull/110.patch","issue_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues/110","number":110,"state":"open","locked":false,"title":"[WIP] Plutus core/fix typechecker","user":{"login":"vmchale","id":13259982,"node_id":"MDQ6VXNlcjEzMjU5OTgy","avatar_url":"https://avatars1.githubusercontent.com/u/13259982?v=4","gravatar_id":"","url":"https://api.github.com/users/vmchale","html_url":"https://github.com/vmchale","followers_url":"https://api.github.com/users/vmchale/followers","following_url":"https://api.github.com/users/vmchale/following{/other_user}","gists_url":"https://api.github.com/users/vmchale/gists{/gist_id}","starred_url":"https://api.github.com/users/vmchale/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vmchale/subscriptions","organizations_url":"https://api.github.com/users/vmchale/orgs","repos_url":"https://api.github.com/users/vmchale/repos","events_url":"https://api.github.com/users/vmchale/events{/privacy}","received_events_url":"https://api.github.com/users/vmchale/received_events","type":"User","site_admin":false},"body":"Fixes the typechecker. I think it also introduces a performance regression, which I will put in a separate ticket. ","created_at":"2018-09-14T02:25:14Z","updated_at":"2018-09-14T14:13:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a2b2b73fe1d2d3867c2429e11019977e2469b613","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/110/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/110/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues/110/comments","statuses_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/statuses/047f1962eb45aa14b3c76f9b68b3385193956b14","head":{"label":"input-output-hk:plutus-core/fix-typechecker","ref":"plutus-core/fix-typechecker","sha":"047f1962eb45aa14b3c76f9b68b3385193956b14","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":73861563,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg2MTU2Mw==","name":"plutus-prototype","full_name":"input-output-hk/plutus-prototype","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/plutus-prototype","description":"The Plutus language reference implementation and tools","fork":false,"url":"https://api.github.com/repos/input-output-hk/plutus-prototype","forks_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/forks","keys_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/teams","hooks_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/events","assignees_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/tags","blobs_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/subscription","commits_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/merges","archive_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/downloads","issues_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/deployments","created_at":"2016-11-15T22:38:43Z","updated_at":"2018-09-14T13:46:27Z","pushed_at":"2018-09-14T14:12:24Z","git_url":"git://github.com/input-output-hk/plutus-prototype.git","ssh_url":"git@github.com:input-output-hk/plutus-prototype.git","clone_url":"https://github.com/input-output-hk/plutus-prototype.git","svn_url":"https://github.com/input-output-hk/plutus-prototype","homepage":"","size":7708,"stargazers_count":127,"watchers_count":127,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":10,"watchers":127,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"fec7df5fcb3236c9293c0d33f11b97799e36083f","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":73861563,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg2MTU2Mw==","name":"plutus-prototype","full_name":"input-output-hk/plutus-prototype","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/plutus-prototype","description":"The Plutus language reference implementation and tools","fork":false,"url":"https://api.github.com/repos/input-output-hk/plutus-prototype","forks_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/forks","keys_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/teams","hooks_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/events","assignees_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/tags","blobs_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/subscription","commits_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/merges","archive_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/downloads","issues_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/plutus-prototype/deployments","created_at":"2016-11-15T22:38:43Z","updated_at":"2018-09-14T13:46:27Z","pushed_at":"2018-09-14T14:12:24Z","git_url":"git://github.com/input-output-hk/plutus-prototype.git","ssh_url":"git@github.com:input-output-hk/plutus-prototype.git","clone_url":"https://github.com/input-output-hk/plutus-prototype.git","svn_url":"https://github.com/input-output-hk/plutus-prototype","homepage":"","size":7708,"stargazers_count":127,"watchers_count":127,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":20,"open_issues":10,"watchers":127,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/110"},"html":{"href":"https://github.com/input-output-hk/plutus-prototype/pull/110"},"issue":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues/110"},"comments":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/issues/110/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/110/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/pulls/110/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/plutus-prototype/statuses/047f1962eb45aa14b3c76f9b68b3385193956b14"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vmchale"}}