{"action":"created","comment":{"url":"https://api.github.com/repos/googleapis/toolkit/pulls/comments/170310245","pull_request_review_id":98983905,"id":170310245,"diff_hunk":"@@ -669,7 +669,9 @@ private void setInitValueAndComments(\n \n       String formatMethodName = \"\";\n       String transformParamFunctionName = \"\";\n-      if (context.getFeatureConfig().useResourceNameConverters(fieldConfig)) {\n+      if (context.getFeatureConfig().useResourceNameConvertersInSampleOnly(fieldConfig)","path":"src/main/java/com/google/api/codegen/transformer/InitCodeTransformer.java","position":null,"original_position":32,"commit_id":"48dd893633f89045e6a3f5636a442a44eaa21ba5","original_commit_id":"3513d41554996c3cc77a52028eafe4048fb228f6","user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"body":"I feel that it is harder to reason about the boolean logic when expressed that way.\r\n\r\nIn the end, I'd prefer to do a simplification pass later by adding logic which analyzes source & target types, and automatically adds conversions when necessary. Our current approach of tracking every conversion site is too complex to reason about.\r\n\r\nI have broken apart my current boolean expression and added comments so that it is easier to understand. ","created_at":"2018-02-23T17:11:13Z","updated_at":"2018-02-23T17:11:13Z","html_url":"https://github.com/googleapis/toolkit/pull/1851#discussion_r170310245","pull_request_url":"https://api.github.com/repos/googleapis/toolkit/pulls/1851","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/comments/170310245"},"html":{"href":"https://github.com/googleapis/toolkit/pull/1851#discussion_r170310245"},"pull_request":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/1851"}},"in_reply_to_id":170140283},"pull_request":{"url":"https://api.github.com/repos/googleapis/toolkit/pulls/1851","id":170853519,"html_url":"https://github.com/googleapis/toolkit/pull/1851","diff_url":"https://github.com/googleapis/toolkit/pull/1851.diff","patch_url":"https://github.com/googleapis/toolkit/pull/1851.patch","issue_url":"https://api.github.com/repos/googleapis/toolkit/issues/1851","number":1851,"state":"open","locked":false,"title":"Java: Adding string-based overloads for resource name methods","user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-22T20:11:19Z","updated_at":"2018-02-23T17:11:13Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f6b63b8b592165aaca7ffb36abedd70471a39bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/googleapis/toolkit/pulls/1851/commits","review_comments_url":"https://api.github.com/repos/googleapis/toolkit/pulls/1851/comments","review_comment_url":"https://api.github.com/repos/googleapis/toolkit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/googleapis/toolkit/issues/1851/comments","statuses_url":"https://api.github.com/repos/googleapis/toolkit/statuses/48dd893633f89045e6a3f5636a442a44eaa21ba5","head":{"label":"garrettjonesgoogle:master","ref":"master","sha":"48dd893633f89045e6a3f5636a442a44eaa21ba5","user":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"repo":{"id":58162108,"name":"toolkit","full_name":"garrettjonesgoogle/toolkit","owner":{"login":"garrettjonesgoogle","id":13341017,"avatar_url":"https://avatars2.githubusercontent.com/u/13341017?v=4","gravatar_id":"","url":"https://api.github.com/users/garrettjonesgoogle","html_url":"https://github.com/garrettjonesgoogle","followers_url":"https://api.github.com/users/garrettjonesgoogle/followers","following_url":"https://api.github.com/users/garrettjonesgoogle/following{/other_user}","gists_url":"https://api.github.com/users/garrettjonesgoogle/gists{/gist_id}","starred_url":"https://api.github.com/users/garrettjonesgoogle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/garrettjonesgoogle/subscriptions","organizations_url":"https://api.github.com/users/garrettjonesgoogle/orgs","repos_url":"https://api.github.com/users/garrettjonesgoogle/repos","events_url":"https://api.github.com/users/garrettjonesgoogle/events{/privacy}","received_events_url":"https://api.github.com/users/garrettjonesgoogle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/garrettjonesgoogle/toolkit","description":null,"fork":true,"url":"https://api.github.com/repos/garrettjonesgoogle/toolkit","forks_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/forks","keys_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/teams","hooks_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/hooks","issue_events_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/events","assignees_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/tags","blobs_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/languages","stargazers_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/stargazers","contributors_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/contributors","subscribers_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/subscribers","subscription_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/subscription","commits_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/merges","archive_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/downloads","issues_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/garrettjonesgoogle/toolkit/deployments","created_at":"2016-05-05T21:35:23Z","updated_at":"2016-05-05T21:35:25Z","pushed_at":"2018-02-23T17:09:43Z","git_url":"git://github.com/garrettjonesgoogle/toolkit.git","ssh_url":"git@github.com:garrettjonesgoogle/toolkit.git","clone_url":"https://github.com/garrettjonesgoogle/toolkit.git","svn_url":"https://github.com/garrettjonesgoogle/toolkit","homepage":null,"size":20093,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"googleapis:master","ref":"master","sha":"5bafb66b6b430e04bda238d7194e4b81965267db","user":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"repo":{"id":56533838,"name":"toolkit","full_name":"googleapis/toolkit","owner":{"login":"googleapis","id":16785467,"avatar_url":"https://avatars3.githubusercontent.com/u/16785467?v=4","gravatar_id":"","url":"https://api.github.com/users/googleapis","html_url":"https://github.com/googleapis","followers_url":"https://api.github.com/users/googleapis/followers","following_url":"https://api.github.com/users/googleapis/following{/other_user}","gists_url":"https://api.github.com/users/googleapis/gists{/gist_id}","starred_url":"https://api.github.com/users/googleapis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/googleapis/subscriptions","organizations_url":"https://api.github.com/users/googleapis/orgs","repos_url":"https://api.github.com/users/googleapis/repos","events_url":"https://api.github.com/users/googleapis/events{/privacy}","received_events_url":"https://api.github.com/users/googleapis/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/googleapis/toolkit","description":null,"fork":false,"url":"https://api.github.com/repos/googleapis/toolkit","forks_url":"https://api.github.com/repos/googleapis/toolkit/forks","keys_url":"https://api.github.com/repos/googleapis/toolkit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/googleapis/toolkit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/googleapis/toolkit/teams","hooks_url":"https://api.github.com/repos/googleapis/toolkit/hooks","issue_events_url":"https://api.github.com/repos/googleapis/toolkit/issues/events{/number}","events_url":"https://api.github.com/repos/googleapis/toolkit/events","assignees_url":"https://api.github.com/repos/googleapis/toolkit/assignees{/user}","branches_url":"https://api.github.com/repos/googleapis/toolkit/branches{/branch}","tags_url":"https://api.github.com/repos/googleapis/toolkit/tags","blobs_url":"https://api.github.com/repos/googleapis/toolkit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/googleapis/toolkit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/googleapis/toolkit/git/refs{/sha}","trees_url":"https://api.github.com/repos/googleapis/toolkit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/googleapis/toolkit/statuses/{sha}","languages_url":"https://api.github.com/repos/googleapis/toolkit/languages","stargazers_url":"https://api.github.com/repos/googleapis/toolkit/stargazers","contributors_url":"https://api.github.com/repos/googleapis/toolkit/contributors","subscribers_url":"https://api.github.com/repos/googleapis/toolkit/subscribers","subscription_url":"https://api.github.com/repos/googleapis/toolkit/subscription","commits_url":"https://api.github.com/repos/googleapis/toolkit/commits{/sha}","git_commits_url":"https://api.github.com/repos/googleapis/toolkit/git/commits{/sha}","comments_url":"https://api.github.com/repos/googleapis/toolkit/comments{/number}","issue_comment_url":"https://api.github.com/repos/googleapis/toolkit/issues/comments{/number}","contents_url":"https://api.github.com/repos/googleapis/toolkit/contents/{+path}","compare_url":"https://api.github.com/repos/googleapis/toolkit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/googleapis/toolkit/merges","archive_url":"https://api.github.com/repos/googleapis/toolkit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/googleapis/toolkit/downloads","issues_url":"https://api.github.com/repos/googleapis/toolkit/issues{/number}","pulls_url":"https://api.github.com/repos/googleapis/toolkit/pulls{/number}","milestones_url":"https://api.github.com/repos/googleapis/toolkit/milestones{/number}","notifications_url":"https://api.github.com/repos/googleapis/toolkit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/googleapis/toolkit/labels{/name}","releases_url":"https://api.github.com/repos/googleapis/toolkit/releases{/id}","deployments_url":"https://api.github.com/repos/googleapis/toolkit/deployments","created_at":"2016-04-18T18:58:04Z","updated_at":"2018-02-22T15:20:07Z","pushed_at":"2018-02-23T17:09:44Z","git_url":"git://github.com/googleapis/toolkit.git","ssh_url":"git@github.com:googleapis/toolkit.git","clone_url":"https://github.com/googleapis/toolkit.git","svn_url":"https://github.com/googleapis/toolkit","homepage":null,"size":19679,"stargazers_count":38,"watchers_count":38,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":140,"license":null,"forks":47,"open_issues":140,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/1851"},"html":{"href":"https://github.com/googleapis/toolkit/pull/1851"},"issue":{"href":"https://api.github.com/repos/googleapis/toolkit/issues/1851"},"comments":{"href":"https://api.github.com/repos/googleapis/toolkit/issues/1851/comments"},"review_comments":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/1851/comments"},"review_comment":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/googleapis/toolkit/pulls/1851/commits"},"statuses":{"href":"https://api.github.com/repos/googleapis/toolkit/statuses/48dd893633f89045e6a3f5636a442a44eaa21ba5"}},"author_association":"OWNER"}}
{"actor":{"display_login":"garrettjonesgoogle"}}