{"action":"created","comment":{"url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/comments/185748463","pull_request_review_id":117198487,"id":185748463,"diff_hunk":"@@ -0,0 +1,85 @@\n+---\n+name: Buttons have an accessible name\n+description: |\n+  Each button element has an accessible name\n+\n+success_criterion:\n+- 4.1.2 # Name, Role, Value\n+\n+test_aspects: # Remove what is not applicable\n+- DOM Tree\n+- CSS Styling\n+\n+authors:\n+- Wilco Fiers\n+- Stein Erik Skotkjerra\n+---\n+\n+## Test procedure\n+\n+### Applicability\n+\n+The rule applies to any element with the role of `button`, except for `input` elements of `type=\"image\"` that are [visible on the page][] or [exposed to assistive technologies][].\n+\n+### Expectation\n+\n+Each target element has an [accessible name][] that is [non-empty][].\n+\n+## Assumptions\n+\n+- The rule assumes that all buttons are user interface components as defined by WCAG 2. When the button role is used incorrectly, the assumption may not be true.","path":"_drafts/SC4-1-2-button-has-name.md","position":30,"original_position":30,"commit_id":"f61f06b64920508ffad078178f1322be1c595fe4","original_commit_id":"f61f06b64920508ffad078178f1322be1c595fe4","user":{"login":"jkodu","id":20978252,"avatar_url":"https://avatars3.githubusercontent.com/u/20978252?v=4","gravatar_id":"","url":"https://api.github.com/users/jkodu","html_url":"https://github.com/jkodu","followers_url":"https://api.github.com/users/jkodu/followers","following_url":"https://api.github.com/users/jkodu/following{/other_user}","gists_url":"https://api.github.com/users/jkodu/gists{/gist_id}","starred_url":"https://api.github.com/users/jkodu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkodu/subscriptions","organizations_url":"https://api.github.com/users/jkodu/orgs","repos_url":"https://api.github.com/users/jkodu/repos","events_url":"https://api.github.com/users/jkodu/events{/privacy}","received_events_url":"https://api.github.com/users/jkodu/received_events","type":"User","site_admin":false},"body":"You are right. First sentence does the trick","created_at":"2018-05-03T09:57:58Z","updated_at":"2018-05-03T09:57:58Z","html_url":"https://github.com/auto-wcag/auto-wcag/pull/118#discussion_r185748463","pull_request_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/118","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/comments/185748463"},"html":{"href":"https://github.com/auto-wcag/auto-wcag/pull/118#discussion_r185748463"},"pull_request":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/118"}},"in_reply_to_id":185746599},"pull_request":{"url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/118","id":185395738,"html_url":"https://github.com/auto-wcag/auto-wcag/pull/118","diff_url":"https://github.com/auto-wcag/auto-wcag/pull/118.diff","patch_url":"https://github.com/auto-wcag/auto-wcag/pull/118.patch","issue_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/118","number":118,"state":"open","locked":false,"title":"Draft: SC4-1-2-button-has-name","user":{"login":"jkodu","id":20978252,"avatar_url":"https://avatars3.githubusercontent.com/u/20978252?v=4","gravatar_id":"","url":"https://api.github.com/users/jkodu","html_url":"https://github.com/jkodu","followers_url":"https://api.github.com/users/jkodu/followers","following_url":"https://api.github.com/users/jkodu/following{/other_user}","gists_url":"https://api.github.com/users/jkodu/gists{/gist_id}","starred_url":"https://api.github.com/users/jkodu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkodu/subscriptions","organizations_url":"https://api.github.com/users/jkodu/orgs","repos_url":"https://api.github.com/users/jkodu/repos","events_url":"https://api.github.com/users/jkodu/events{/privacy}","received_events_url":"https://api.github.com/users/jkodu/received_events","type":"User","site_admin":false},"body":"Draft rule as discussed in issue - \r\nhttps://github.com/auto-wcag/auto-wcag/issues/100","created_at":"2018-05-02T10:24:17Z","updated_at":"2018-05-03T09:57:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9f4b2bc5edd623b57711affb087501a5573ebf5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/118/commits","review_comments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/118/comments","review_comment_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/comments{/number}","comments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/118/comments","statuses_url":"https://api.github.com/repos/auto-wcag/auto-wcag/statuses/f61f06b64920508ffad078178f1322be1c595fe4","head":{"label":"auto-wcag:draft-SC4-1-2-button-has-name","ref":"draft-SC4-1-2-button-has-name","sha":"f61f06b64920508ffad078178f1322be1c595fe4","user":{"login":"auto-wcag","id":17526379,"avatar_url":"https://avatars1.githubusercontent.com/u/17526379?v=4","gravatar_id":"","url":"https://api.github.com/users/auto-wcag","html_url":"https://github.com/auto-wcag","followers_url":"https://api.github.com/users/auto-wcag/followers","following_url":"https://api.github.com/users/auto-wcag/following{/other_user}","gists_url":"https://api.github.com/users/auto-wcag/gists{/gist_id}","starred_url":"https://api.github.com/users/auto-wcag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auto-wcag/subscriptions","organizations_url":"https://api.github.com/users/auto-wcag/orgs","repos_url":"https://api.github.com/users/auto-wcag/repos","events_url":"https://api.github.com/users/auto-wcag/events{/privacy}","received_events_url":"https://api.github.com/users/auto-wcag/received_events","type":"Organization","site_admin":false},"repo":{"id":52717143,"name":"auto-wcag","full_name":"auto-wcag/auto-wcag","owner":{"login":"auto-wcag","id":17526379,"avatar_url":"https://avatars1.githubusercontent.com/u/17526379?v=4","gravatar_id":"","url":"https://api.github.com/users/auto-wcag","html_url":"https://github.com/auto-wcag","followers_url":"https://api.github.com/users/auto-wcag/followers","following_url":"https://api.github.com/users/auto-wcag/following{/other_user}","gists_url":"https://api.github.com/users/auto-wcag/gists{/gist_id}","starred_url":"https://api.github.com/users/auto-wcag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auto-wcag/subscriptions","organizations_url":"https://api.github.com/users/auto-wcag/orgs","repos_url":"https://api.github.com/users/auto-wcag/repos","events_url":"https://api.github.com/users/auto-wcag/events{/privacy}","received_events_url":"https://api.github.com/users/auto-wcag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auto-wcag/auto-wcag","description":null,"fork":false,"url":"https://api.github.com/repos/auto-wcag/auto-wcag","forks_url":"https://api.github.com/repos/auto-wcag/auto-wcag/forks","keys_url":"https://api.github.com/repos/auto-wcag/auto-wcag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auto-wcag/auto-wcag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auto-wcag/auto-wcag/teams","hooks_url":"https://api.github.com/repos/auto-wcag/auto-wcag/hooks","issue_events_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/events{/number}","events_url":"https://api.github.com/repos/auto-wcag/auto-wcag/events","assignees_url":"https://api.github.com/repos/auto-wcag/auto-wcag/assignees{/user}","branches_url":"https://api.github.com/repos/auto-wcag/auto-wcag/branches{/branch}","tags_url":"https://api.github.com/repos/auto-wcag/auto-wcag/tags","blobs_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/refs{/sha}","trees_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auto-wcag/auto-wcag/statuses/{sha}","languages_url":"https://api.github.com/repos/auto-wcag/auto-wcag/languages","stargazers_url":"https://api.github.com/repos/auto-wcag/auto-wcag/stargazers","contributors_url":"https://api.github.com/repos/auto-wcag/auto-wcag/contributors","subscribers_url":"https://api.github.com/repos/auto-wcag/auto-wcag/subscribers","subscription_url":"https://api.github.com/repos/auto-wcag/auto-wcag/subscription","commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/commits{/sha}","git_commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/commits{/sha}","comments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/comments{/number}","issue_comment_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/comments{/number}","contents_url":"https://api.github.com/repos/auto-wcag/auto-wcag/contents/{+path}","compare_url":"https://api.github.com/repos/auto-wcag/auto-wcag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auto-wcag/auto-wcag/merges","archive_url":"https://api.github.com/repos/auto-wcag/auto-wcag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auto-wcag/auto-wcag/downloads","issues_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues{/number}","pulls_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls{/number}","milestones_url":"https://api.github.com/repos/auto-wcag/auto-wcag/milestones{/number}","notifications_url":"https://api.github.com/repos/auto-wcag/auto-wcag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auto-wcag/auto-wcag/labels{/name}","releases_url":"https://api.github.com/repos/auto-wcag/auto-wcag/releases{/id}","deployments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/deployments","created_at":"2016-02-28T11:08:46Z","updated_at":"2018-04-30T08:04:44Z","pushed_at":"2018-05-03T09:33:47Z","git_url":"git://github.com/auto-wcag/auto-wcag.git","ssh_url":"git@github.com:auto-wcag/auto-wcag.git","clone_url":"https://github.com/auto-wcag/auto-wcag.git","svn_url":"https://github.com/auto-wcag/auto-wcag","homepage":null,"size":27431,"stargazers_count":13,"watchers_count":13,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":18,"open_issues":38,"watchers":13,"default_branch":"master"}},"base":{"label":"auto-wcag:master","ref":"master","sha":"4e75bbe3c1e3e314ccf0c741fed65874cadd0590","user":{"login":"auto-wcag","id":17526379,"avatar_url":"https://avatars1.githubusercontent.com/u/17526379?v=4","gravatar_id":"","url":"https://api.github.com/users/auto-wcag","html_url":"https://github.com/auto-wcag","followers_url":"https://api.github.com/users/auto-wcag/followers","following_url":"https://api.github.com/users/auto-wcag/following{/other_user}","gists_url":"https://api.github.com/users/auto-wcag/gists{/gist_id}","starred_url":"https://api.github.com/users/auto-wcag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auto-wcag/subscriptions","organizations_url":"https://api.github.com/users/auto-wcag/orgs","repos_url":"https://api.github.com/users/auto-wcag/repos","events_url":"https://api.github.com/users/auto-wcag/events{/privacy}","received_events_url":"https://api.github.com/users/auto-wcag/received_events","type":"Organization","site_admin":false},"repo":{"id":52717143,"name":"auto-wcag","full_name":"auto-wcag/auto-wcag","owner":{"login":"auto-wcag","id":17526379,"avatar_url":"https://avatars1.githubusercontent.com/u/17526379?v=4","gravatar_id":"","url":"https://api.github.com/users/auto-wcag","html_url":"https://github.com/auto-wcag","followers_url":"https://api.github.com/users/auto-wcag/followers","following_url":"https://api.github.com/users/auto-wcag/following{/other_user}","gists_url":"https://api.github.com/users/auto-wcag/gists{/gist_id}","starred_url":"https://api.github.com/users/auto-wcag/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/auto-wcag/subscriptions","organizations_url":"https://api.github.com/users/auto-wcag/orgs","repos_url":"https://api.github.com/users/auto-wcag/repos","events_url":"https://api.github.com/users/auto-wcag/events{/privacy}","received_events_url":"https://api.github.com/users/auto-wcag/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/auto-wcag/auto-wcag","description":null,"fork":false,"url":"https://api.github.com/repos/auto-wcag/auto-wcag","forks_url":"https://api.github.com/repos/auto-wcag/auto-wcag/forks","keys_url":"https://api.github.com/repos/auto-wcag/auto-wcag/keys{/key_id}","collaborators_url":"https://api.github.com/repos/auto-wcag/auto-wcag/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/auto-wcag/auto-wcag/teams","hooks_url":"https://api.github.com/repos/auto-wcag/auto-wcag/hooks","issue_events_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/events{/number}","events_url":"https://api.github.com/repos/auto-wcag/auto-wcag/events","assignees_url":"https://api.github.com/repos/auto-wcag/auto-wcag/assignees{/user}","branches_url":"https://api.github.com/repos/auto-wcag/auto-wcag/branches{/branch}","tags_url":"https://api.github.com/repos/auto-wcag/auto-wcag/tags","blobs_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/refs{/sha}","trees_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/trees{/sha}","statuses_url":"https://api.github.com/repos/auto-wcag/auto-wcag/statuses/{sha}","languages_url":"https://api.github.com/repos/auto-wcag/auto-wcag/languages","stargazers_url":"https://api.github.com/repos/auto-wcag/auto-wcag/stargazers","contributors_url":"https://api.github.com/repos/auto-wcag/auto-wcag/contributors","subscribers_url":"https://api.github.com/repos/auto-wcag/auto-wcag/subscribers","subscription_url":"https://api.github.com/repos/auto-wcag/auto-wcag/subscription","commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/commits{/sha}","git_commits_url":"https://api.github.com/repos/auto-wcag/auto-wcag/git/commits{/sha}","comments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/comments{/number}","issue_comment_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/comments{/number}","contents_url":"https://api.github.com/repos/auto-wcag/auto-wcag/contents/{+path}","compare_url":"https://api.github.com/repos/auto-wcag/auto-wcag/compare/{base}...{head}","merges_url":"https://api.github.com/repos/auto-wcag/auto-wcag/merges","archive_url":"https://api.github.com/repos/auto-wcag/auto-wcag/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/auto-wcag/auto-wcag/downloads","issues_url":"https://api.github.com/repos/auto-wcag/auto-wcag/issues{/number}","pulls_url":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls{/number}","milestones_url":"https://api.github.com/repos/auto-wcag/auto-wcag/milestones{/number}","notifications_url":"https://api.github.com/repos/auto-wcag/auto-wcag/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/auto-wcag/auto-wcag/labels{/name}","releases_url":"https://api.github.com/repos/auto-wcag/auto-wcag/releases{/id}","deployments_url":"https://api.github.com/repos/auto-wcag/auto-wcag/deployments","created_at":"2016-02-28T11:08:46Z","updated_at":"2018-04-30T08:04:44Z","pushed_at":"2018-05-03T09:33:47Z","git_url":"git://github.com/auto-wcag/auto-wcag.git","ssh_url":"git@github.com:auto-wcag/auto-wcag.git","clone_url":"https://github.com/auto-wcag/auto-wcag.git","svn_url":"https://github.com/auto-wcag/auto-wcag","homepage":null,"size":27431,"stargazers_count":13,"watchers_count":13,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":38,"license":null,"forks":18,"open_issues":38,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/118"},"html":{"href":"https://github.com/auto-wcag/auto-wcag/pull/118"},"issue":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/118"},"comments":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/issues/118/comments"},"review_comments":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/118/comments"},"review_comment":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/pulls/118/commits"},"statuses":{"href":"https://api.github.com/repos/auto-wcag/auto-wcag/statuses/f61f06b64920508ffad078178f1322be1c595fe4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"jkodu"}}