{"action":"created","comment":{"url":"https://api.github.com/repos/DevrexLabs/memstate/pulls/comments/215084496","pull_request_review_id":152275101,"id":215084496,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTA4NDQ5Ng==","diff_hunk":"@@ -10,40 +10,42 @@ namespace Memstate.Docs.GettingStarted.QuickStart\n {\n     public class QuickStartTests\n     {\n-        private string Filename = \"smoke_test_with_defaults\";\n-        private string JournalFile = \"smoke_test_with_defaults.journal\";\n+        private string WireFileName = \"smoke_test_with_defaults_wire\";\n+        private string WireJournalFile = \"smoke_test_with_defaults_wire.journal\";\n+\n+        private string JsonFileName = \"smoke_test_with_defaults_json\";\n+        private string JsonJournalFile = \"smoke_test_with_defaults_json.journal\";\n \n         [SetUp]\n         [TearDown]\n-        public void Setup()\n+        public void SetupTeardown()\n         {\n-            Config.Reset().SerializerName = \"Wire\";\n-            if (File.Exists(JournalFile)) File.Delete(JournalFile);\n+            if (File.Exists(WireJournalFile)) File.Delete(WireJournalFile);\n+            if (File.Exists(JsonJournalFile)) File.Delete(JsonJournalFile);\n+            Config.Reset();\n         }\n \n-        // Hi all, here's some important notes on writing tests for .net core and standard,\n-        // in case you want to create your own tests.\n-        // https://github.com/nunit/docs/wiki/.NET-Core-and-.NET-Standard\n-\n         [Test]\n-        public async Task Simple_end_to_end_getting_started_using_default_settings_with_filesytem_storage()\n+         public async Task Simple_end_to_end_getting_started_using_default_wire_serializer_with_filesytem_storage()\n         {\n             Print(\"GIVEN I start a new Memstate engine for a LoyaltyDB using default settings\");\n             Print(\"   (using Wire format  & local filesystem storage)\");\n-            var settings = Config.Current.GetSettings<EngineSettings>();\n-            settings.StreamName = Filename;\n+            var config = Config.Current;","path":"src/Memstate.Docs.GettingStarted/QuickStart/QuickStartTests.cs","position":36,"original_position":36,"commit_id":"dd5bc6a3a37728e48c2af088bc1b72c870605d07","original_commit_id":"dd5bc6a3a37728e48c2af088bc1b72c870605d07","user":{"login":"goblinfactory","id":1073487,"node_id":"MDQ6VXNlcjEwNzM0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1073487?v=4","gravatar_id":"","url":"https://api.github.com/users/goblinfactory","html_url":"https://github.com/goblinfactory","followers_url":"https://api.github.com/users/goblinfactory/followers","following_url":"https://api.github.com/users/goblinfactory/following{/other_user}","gists_url":"https://api.github.com/users/goblinfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinfactory/subscriptions","organizations_url":"https://api.github.com/users/goblinfactory/orgs","repos_url":"https://api.github.com/users/goblinfactory/repos","events_url":"https://api.github.com/users/goblinfactory/events{/privacy}","received_events_url":"https://api.github.com/users/goblinfactory/received_events","type":"User","site_admin":false},"body":"I'm not familar with the new Config and settings syntax. Not sure if this is what you had in mind or what the simplest and least amount of code way of setting up is?","created_at":"2018-09-04T22:18:05Z","updated_at":"2018-09-04T22:18:05Z","html_url":"https://github.com/DevrexLabs/memstate/pull/58#discussion_r215084496","pull_request_url":"https://api.github.com/repos/DevrexLabs/memstate/pulls/58","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/DevrexLabs/memstate/pulls/comments/215084496"},"html":{"href":"https://github.com/DevrexLabs/memstate/pull/58#discussion_r215084496"},"pull_request":{"href":"https://api.github.com/repos/DevrexLabs/memstate/pulls/58"}}},"pull_request":{"url":"https://api.github.com/repos/DevrexLabs/memstate/pulls/58","id":213118386,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMTE4Mzg2","html_url":"https://github.com/DevrexLabs/memstate/pull/58","diff_url":"https://github.com/DevrexLabs/memstate/pull/58.diff","patch_url":"https://github.com/DevrexLabs/memstate/pull/58.patch","issue_url":"https://api.github.com/repos/DevrexLabs/memstate/issues/58","number":58,"state":"open","locked":false,"title":"Update getting started tests to bring in line with the latest core changes","user":{"login":"goblinfactory","id":1073487,"node_id":"MDQ6VXNlcjEwNzM0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1073487?v=4","gravatar_id":"","url":"https://api.github.com/users/goblinfactory","html_url":"https://github.com/goblinfactory","followers_url":"https://api.github.com/users/goblinfactory/followers","following_url":"https://api.github.com/users/goblinfactory/following{/other_user}","gists_url":"https://api.github.com/users/goblinfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinfactory/subscriptions","organizations_url":"https://api.github.com/users/goblinfactory/orgs","repos_url":"https://api.github.com/users/goblinfactory/repos","events_url":"https://api.github.com/users/goblinfactory/events{/privacy}","received_events_url":"https://api.github.com/users/goblinfactory/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-09-04T22:13:47Z","updated_at":"2018-09-04T22:18:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"314d1c42519dda6e39821e9c91fb5cf03b969bd5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DevrexLabs/memstate/pulls/58/commits","review_comments_url":"https://api.github.com/repos/DevrexLabs/memstate/pulls/58/comments","review_comment_url":"https://api.github.com/repos/DevrexLabs/memstate/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DevrexLabs/memstate/issues/58/comments","statuses_url":"https://api.github.com/repos/DevrexLabs/memstate/statuses/dd5bc6a3a37728e48c2af088bc1b72c870605d07","head":{"label":"goblinfactory:master","ref":"master","sha":"dd5bc6a3a37728e48c2af088bc1b72c870605d07","user":{"login":"goblinfactory","id":1073487,"node_id":"MDQ6VXNlcjEwNzM0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1073487?v=4","gravatar_id":"","url":"https://api.github.com/users/goblinfactory","html_url":"https://github.com/goblinfactory","followers_url":"https://api.github.com/users/goblinfactory/followers","following_url":"https://api.github.com/users/goblinfactory/following{/other_user}","gists_url":"https://api.github.com/users/goblinfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinfactory/subscriptions","organizations_url":"https://api.github.com/users/goblinfactory/orgs","repos_url":"https://api.github.com/users/goblinfactory/repos","events_url":"https://api.github.com/users/goblinfactory/events{/privacy}","received_events_url":"https://api.github.com/users/goblinfactory/received_events","type":"User","site_admin":false},"repo":{"id":120195997,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAxOTU5OTc=","name":"memstate-fork-alan","full_name":"goblinfactory/memstate-fork-alan","owner":{"login":"goblinfactory","id":1073487,"node_id":"MDQ6VXNlcjEwNzM0ODc=","avatar_url":"https://avatars3.githubusercontent.com/u/1073487?v=4","gravatar_id":"","url":"https://api.github.com/users/goblinfactory","html_url":"https://github.com/goblinfactory","followers_url":"https://api.github.com/users/goblinfactory/followers","following_url":"https://api.github.com/users/goblinfactory/following{/other_user}","gists_url":"https://api.github.com/users/goblinfactory/gists{/gist_id}","starred_url":"https://api.github.com/users/goblinfactory/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/goblinfactory/subscriptions","organizations_url":"https://api.github.com/users/goblinfactory/orgs","repos_url":"https://api.github.com/users/goblinfactory/repos","events_url":"https://api.github.com/users/goblinfactory/events{/privacy}","received_events_url":"https://api.github.com/users/goblinfactory/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/goblinfactory/memstate-fork-alan","description":"In-memory event-sourced ACID-transactional distributed object graph engine for .NET Standard","fork":true,"url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan","forks_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/forks","keys_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/teams","hooks_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/hooks","issue_events_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/issues/events{/number}","events_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/events","assignees_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/assignees{/user}","branches_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/branches{/branch}","tags_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/tags","blobs_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/git/refs{/sha}","trees_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/statuses/{sha}","languages_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/languages","stargazers_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/stargazers","contributors_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/contributors","subscribers_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/subscribers","subscription_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/subscription","commits_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/commits{/sha}","git_commits_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/git/commits{/sha}","comments_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/comments{/number}","issue_comment_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/issues/comments{/number}","contents_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/contents/{+path}","compare_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/merges","archive_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/downloads","issues_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/issues{/number}","pulls_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/pulls{/number}","milestones_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/milestones{/number}","notifications_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/labels{/name}","releases_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/releases{/id}","deployments_url":"https://api.github.com/repos/goblinfactory/memstate-fork-alan/deployments","created_at":"2018-02-04T15:16:08Z","updated_at":"2018-09-04T22:11:11Z","pushed_at":"2018-09-04T22:10:59Z","git_url":"git://github.com/goblinfactory/memstate-fork-alan.git","ssh_url":"git@github.com:goblinfactory/memstate-fork-alan.git","clone_url":"https://github.com/goblinfactory/memstate-fork-alan.git","svn_url":"https://github.com/goblinfactory/memstate-fork-alan","homepage":"https://memstate.io","size":2635,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DevrexLabs:master","ref":"master","sha":"93d9a56cbe54bb17c84ca819adda9269161ebb6c","user":{"login":"DevrexLabs","id":1918013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTgwMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1918013?v=4","gravatar_id":"","url":"https://api.github.com/users/DevrexLabs","html_url":"https://github.com/DevrexLabs","followers_url":"https://api.github.com/users/DevrexLabs/followers","following_url":"https://api.github.com/users/DevrexLabs/following{/other_user}","gists_url":"https://api.github.com/users/DevrexLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DevrexLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevrexLabs/subscriptions","organizations_url":"https://api.github.com/users/DevrexLabs/orgs","repos_url":"https://api.github.com/users/DevrexLabs/repos","events_url":"https://api.github.com/users/DevrexLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DevrexLabs/received_events","type":"Organization","site_admin":false},"repo":{"id":95070401,"node_id":"MDEwOlJlcG9zaXRvcnk5NTA3MDQwMQ==","name":"memstate","full_name":"DevrexLabs/memstate","owner":{"login":"DevrexLabs","id":1918013,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTgwMTM=","avatar_url":"https://avatars2.githubusercontent.com/u/1918013?v=4","gravatar_id":"","url":"https://api.github.com/users/DevrexLabs","html_url":"https://github.com/DevrexLabs","followers_url":"https://api.github.com/users/DevrexLabs/followers","following_url":"https://api.github.com/users/DevrexLabs/following{/other_user}","gists_url":"https://api.github.com/users/DevrexLabs/gists{/gist_id}","starred_url":"https://api.github.com/users/DevrexLabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DevrexLabs/subscriptions","organizations_url":"https://api.github.com/users/DevrexLabs/orgs","repos_url":"https://api.github.com/users/DevrexLabs/repos","events_url":"https://api.github.com/users/DevrexLabs/events{/privacy}","received_events_url":"https://api.github.com/users/DevrexLabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DevrexLabs/memstate","description":"In-memory event-sourced ACID-transactional distributed object graph engine for .NET Standard","fork":false,"url":"https://api.github.com/repos/DevrexLabs/memstate","forks_url":"https://api.github.com/repos/DevrexLabs/memstate/forks","keys_url":"https://api.github.com/repos/DevrexLabs/memstate/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DevrexLabs/memstate/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DevrexLabs/memstate/teams","hooks_url":"https://api.github.com/repos/DevrexLabs/memstate/hooks","issue_events_url":"https://api.github.com/repos/DevrexLabs/memstate/issues/events{/number}","events_url":"https://api.github.com/repos/DevrexLabs/memstate/events","assignees_url":"https://api.github.com/repos/DevrexLabs/memstate/assignees{/user}","branches_url":"https://api.github.com/repos/DevrexLabs/memstate/branches{/branch}","tags_url":"https://api.github.com/repos/DevrexLabs/memstate/tags","blobs_url":"https://api.github.com/repos/DevrexLabs/memstate/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DevrexLabs/memstate/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DevrexLabs/memstate/git/refs{/sha}","trees_url":"https://api.github.com/repos/DevrexLabs/memstate/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DevrexLabs/memstate/statuses/{sha}","languages_url":"https://api.github.com/repos/DevrexLabs/memstate/languages","stargazers_url":"https://api.github.com/repos/DevrexLabs/memstate/stargazers","contributors_url":"https://api.github.com/repos/DevrexLabs/memstate/contributors","subscribers_url":"https://api.github.com/repos/DevrexLabs/memstate/subscribers","subscription_url":"https://api.github.com/repos/DevrexLabs/memstate/subscription","commits_url":"https://api.github.com/repos/DevrexLabs/memstate/commits{/sha}","git_commits_url":"https://api.github.com/repos/DevrexLabs/memstate/git/commits{/sha}","comments_url":"https://api.github.com/repos/DevrexLabs/memstate/comments{/number}","issue_comment_url":"https://api.github.com/repos/DevrexLabs/memstate/issues/comments{/number}","contents_url":"https://api.github.com/repos/DevrexLabs/memstate/contents/{+path}","compare_url":"https://api.github.com/repos/DevrexLabs/memstate/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DevrexLabs/memstate/merges","archive_url":"https://api.github.com/repos/DevrexLabs/memstate/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DevrexLabs/memstate/downloads","issues_url":"https://api.github.com/repos/DevrexLabs/memstate/issues{/number}","pulls_url":"https://api.github.com/repos/DevrexLabs/memstate/pulls{/number}","milestones_url":"https://api.github.com/repos/DevrexLabs/memstate/milestones{/number}","notifications_url":"https://api.github.com/repos/DevrexLabs/memstate/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DevrexLabs/memstate/labels{/name}","releases_url":"https://api.github.com/repos/DevrexLabs/memstate/releases{/id}","deployments_url":"https://api.github.com/repos/DevrexLabs/memstate/deployments","created_at":"2017-06-22T03:24:57Z","updated_at":"2018-09-04T21:24:04Z","pushed_at":"2018-09-04T22:13:48Z","git_url":"git://github.com/DevrexLabs/memstate.git","ssh_url":"git@github.com:DevrexLabs/memstate.git","clone_url":"https://github.com/DevrexLabs/memstate.git","svn_url":"https://github.com/DevrexLabs/memstate","homepage":"https://memstate.io","size":2832,"stargazers_count":62,"watchers_count":62,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":15,"open_issues":23,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DevrexLabs/memstate/pulls/58"},"html":{"href":"https://github.com/DevrexLabs/memstate/pull/58"},"issue":{"href":"https://api.github.com/repos/DevrexLabs/memstate/issues/58"},"comments":{"href":"https://api.github.com/repos/DevrexLabs/memstate/issues/58/comments"},"review_comments":{"href":"https://api.github.com/repos/DevrexLabs/memstate/pulls/58/comments"},"review_comment":{"href":"https://api.github.com/repos/DevrexLabs/memstate/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DevrexLabs/memstate/pulls/58/commits"},"statuses":{"href":"https://api.github.com/repos/DevrexLabs/memstate/statuses/dd5bc6a3a37728e48c2af088bc1b72c870605d07"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"goblinfactory"}}