{"action":"created","comment":{"url":"https://api.github.com/repos/ReCodEx/api/pulls/comments/207513975","pull_request_review_id":143142724,"id":207513975,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzUxMzk3NQ==","diff_hunk":"@@ -103,7 +103,7 @@ public function actionCreateAccount() {\n \n     // check if the email is free\n     $email = trim($req->getPost(\"email\"));\n-    if ($this->users->getByEmail($email) !== null) {\n+    if ($this->logins->getByUsername($email) !== null) {","path":"app/V1Module/presenters/RegistrationPresenter.php","position":5,"original_position":5,"commit_id":"155078fefc5f2dc84b0543e82279171b836b8c51","original_commit_id":"155078fefc5f2dc84b0543e82279171b836b8c51","user":{"login":"Neloop","id":15379972,"node_id":"MDQ6VXNlcjE1Mzc5OTcy","avatar_url":"https://avatars3.githubusercontent.com/u/15379972?v=4","gravatar_id":"","url":"https://api.github.com/users/Neloop","html_url":"https://github.com/Neloop","followers_url":"https://api.github.com/users/Neloop/followers","following_url":"https://api.github.com/users/Neloop/following{/other_user}","gists_url":"https://api.github.com/users/Neloop/gists{/gist_id}","starred_url":"https://api.github.com/users/Neloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neloop/subscriptions","organizations_url":"https://api.github.com/users/Neloop/orgs","repos_url":"https://api.github.com/users/Neloop/repos","events_url":"https://api.github.com/users/Neloop/events{/privacy}","received_events_url":"https://api.github.com/users/Neloop/received_events","type":"User","site_admin":false},"body":"But the column is `username`, therefore, repository convention says to have this method name...","created_at":"2018-08-03T11:14:34Z","updated_at":"2018-08-03T11:14:34Z","html_url":"https://github.com/ReCodEx/api/pull/230#discussion_r207513975","pull_request_url":"https://api.github.com/repos/ReCodEx/api/pulls/230","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ReCodEx/api/pulls/comments/207513975"},"html":{"href":"https://github.com/ReCodEx/api/pull/230#discussion_r207513975"},"pull_request":{"href":"https://api.github.com/repos/ReCodEx/api/pulls/230"}},"in_reply_to_id":207511364},"pull_request":{"url":"https://api.github.com/repos/ReCodEx/api/pulls/230","id":205726016,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NzI2MDE2","html_url":"https://github.com/ReCodEx/api/pull/230","diff_url":"https://github.com/ReCodEx/api/pull/230.diff","patch_url":"https://github.com/ReCodEx/api/pull/230.patch","issue_url":"https://api.github.com/repos/ReCodEx/api/issues/230","number":230,"state":"open","locked":false,"title":"Single local login","user":{"login":"Neloop","id":15379972,"node_id":"MDQ6VXNlcjE1Mzc5OTcy","avatar_url":"https://avatars3.githubusercontent.com/u/15379972?v=4","gravatar_id":"","url":"https://api.github.com/users/Neloop","html_url":"https://github.com/Neloop","followers_url":"https://api.github.com/users/Neloop/followers","following_url":"https://api.github.com/users/Neloop/following{/other_user}","gists_url":"https://api.github.com/users/Neloop/gists{/gist_id}","starred_url":"https://api.github.com/users/Neloop/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Neloop/subscriptions","organizations_url":"https://api.github.com/users/Neloop/orgs","repos_url":"https://api.github.com/users/Neloop/repos","events_url":"https://api.github.com/users/Neloop/events{/privacy}","received_events_url":"https://api.github.com/users/Neloop/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-02T12:59:37Z","updated_at":"2018-08-03T11:14:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5c74e46f047bf9a70cc0e6a3f288d4a46b7af661","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Teyras","id":461515,"node_id":"MDQ6VXNlcjQ2MTUxNQ==","avatar_url":"https://avatars3.githubusercontent.com/u/461515?v=4","gravatar_id":"","url":"https://api.github.com/users/Teyras","html_url":"https://github.com/Teyras","followers_url":"https://api.github.com/users/Teyras/followers","following_url":"https://api.github.com/users/Teyras/following{/other_user}","gists_url":"https://api.github.com/users/Teyras/gists{/gist_id}","starred_url":"https://api.github.com/users/Teyras/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Teyras/subscriptions","organizations_url":"https://api.github.com/users/Teyras/orgs","repos_url":"https://api.github.com/users/Teyras/repos","events_url":"https://api.github.com/users/Teyras/events{/privacy}","received_events_url":"https://api.github.com/users/Teyras/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ReCodEx/api/pulls/230/commits","review_comments_url":"https://api.github.com/repos/ReCodEx/api/pulls/230/comments","review_comment_url":"https://api.github.com/repos/ReCodEx/api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ReCodEx/api/issues/230/comments","statuses_url":"https://api.github.com/repos/ReCodEx/api/statuses/155078fefc5f2dc84b0543e82279171b836b8c51","head":{"label":"ReCodEx:single-local-login","ref":"single-local-login","sha":"155078fefc5f2dc84b0543e82279171b836b8c51","user":{"login":"ReCodEx","id":15342590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzQyNTkw","avatar_url":"https://avatars0.githubusercontent.com/u/15342590?v=4","gravatar_id":"","url":"https://api.github.com/users/ReCodEx","html_url":"https://github.com/ReCodEx","followers_url":"https://api.github.com/users/ReCodEx/followers","following_url":"https://api.github.com/users/ReCodEx/following{/other_user}","gists_url":"https://api.github.com/users/ReCodEx/gists{/gist_id}","starred_url":"https://api.github.com/users/ReCodEx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReCodEx/subscriptions","organizations_url":"https://api.github.com/users/ReCodEx/orgs","repos_url":"https://api.github.com/users/ReCodEx/repos","events_url":"https://api.github.com/users/ReCodEx/events{/privacy}","received_events_url":"https://api.github.com/users/ReCodEx/received_events","type":"Organization","site_admin":false},"repo":{"id":64029948,"node_id":"MDEwOlJlcG9zaXRvcnk2NDAyOTk0OA==","name":"api","full_name":"ReCodEx/api","owner":{"login":"ReCodEx","id":15342590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzQyNTkw","avatar_url":"https://avatars0.githubusercontent.com/u/15342590?v=4","gravatar_id":"","url":"https://api.github.com/users/ReCodEx","html_url":"https://github.com/ReCodEx","followers_url":"https://api.github.com/users/ReCodEx/followers","following_url":"https://api.github.com/users/ReCodEx/following{/other_user}","gists_url":"https://api.github.com/users/ReCodEx/gists{/gist_id}","starred_url":"https://api.github.com/users/ReCodEx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReCodEx/subscriptions","organizations_url":"https://api.github.com/users/ReCodEx/orgs","repos_url":"https://api.github.com/users/ReCodEx/repos","events_url":"https://api.github.com/users/ReCodEx/events{/privacy}","received_events_url":"https://api.github.com/users/ReCodEx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReCodEx/api","description":"Publicly accessible REST API for ReCodEx system","fork":false,"url":"https://api.github.com/repos/ReCodEx/api","forks_url":"https://api.github.com/repos/ReCodEx/api/forks","keys_url":"https://api.github.com/repos/ReCodEx/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReCodEx/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReCodEx/api/teams","hooks_url":"https://api.github.com/repos/ReCodEx/api/hooks","issue_events_url":"https://api.github.com/repos/ReCodEx/api/issues/events{/number}","events_url":"https://api.github.com/repos/ReCodEx/api/events","assignees_url":"https://api.github.com/repos/ReCodEx/api/assignees{/user}","branches_url":"https://api.github.com/repos/ReCodEx/api/branches{/branch}","tags_url":"https://api.github.com/repos/ReCodEx/api/tags","blobs_url":"https://api.github.com/repos/ReCodEx/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReCodEx/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReCodEx/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReCodEx/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReCodEx/api/statuses/{sha}","languages_url":"https://api.github.com/repos/ReCodEx/api/languages","stargazers_url":"https://api.github.com/repos/ReCodEx/api/stargazers","contributors_url":"https://api.github.com/repos/ReCodEx/api/contributors","subscribers_url":"https://api.github.com/repos/ReCodEx/api/subscribers","subscription_url":"https://api.github.com/repos/ReCodEx/api/subscription","commits_url":"https://api.github.com/repos/ReCodEx/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReCodEx/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReCodEx/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReCodEx/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReCodEx/api/contents/{+path}","compare_url":"https://api.github.com/repos/ReCodEx/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReCodEx/api/merges","archive_url":"https://api.github.com/repos/ReCodEx/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReCodEx/api/downloads","issues_url":"https://api.github.com/repos/ReCodEx/api/issues{/number}","pulls_url":"https://api.github.com/repos/ReCodEx/api/pulls{/number}","milestones_url":"https://api.github.com/repos/ReCodEx/api/milestones{/number}","notifications_url":"https://api.github.com/repos/ReCodEx/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReCodEx/api/labels{/name}","releases_url":"https://api.github.com/repos/ReCodEx/api/releases{/id}","deployments_url":"https://api.github.com/repos/ReCodEx/api/deployments","created_at":"2016-07-23T18:30:47Z","updated_at":"2018-08-02T15:48:24Z","pushed_at":"2018-08-03T08:44:15Z","git_url":"git://github.com/ReCodEx/api.git","ssh_url":"git@github.com:ReCodEx/api.git","clone_url":"https://github.com/ReCodEx/api.git","svn_url":"https://github.com/ReCodEx/api","homepage":"https://recodex.mff.cuni.cz/api/v1","size":5822,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"base":{"label":"ReCodEx:master","ref":"master","sha":"f898ff1aa0ed2ee9b59a3fe02a180592aafa5cab","user":{"login":"ReCodEx","id":15342590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzQyNTkw","avatar_url":"https://avatars0.githubusercontent.com/u/15342590?v=4","gravatar_id":"","url":"https://api.github.com/users/ReCodEx","html_url":"https://github.com/ReCodEx","followers_url":"https://api.github.com/users/ReCodEx/followers","following_url":"https://api.github.com/users/ReCodEx/following{/other_user}","gists_url":"https://api.github.com/users/ReCodEx/gists{/gist_id}","starred_url":"https://api.github.com/users/ReCodEx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReCodEx/subscriptions","organizations_url":"https://api.github.com/users/ReCodEx/orgs","repos_url":"https://api.github.com/users/ReCodEx/repos","events_url":"https://api.github.com/users/ReCodEx/events{/privacy}","received_events_url":"https://api.github.com/users/ReCodEx/received_events","type":"Organization","site_admin":false},"repo":{"id":64029948,"node_id":"MDEwOlJlcG9zaXRvcnk2NDAyOTk0OA==","name":"api","full_name":"ReCodEx/api","owner":{"login":"ReCodEx","id":15342590,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MzQyNTkw","avatar_url":"https://avatars0.githubusercontent.com/u/15342590?v=4","gravatar_id":"","url":"https://api.github.com/users/ReCodEx","html_url":"https://github.com/ReCodEx","followers_url":"https://api.github.com/users/ReCodEx/followers","following_url":"https://api.github.com/users/ReCodEx/following{/other_user}","gists_url":"https://api.github.com/users/ReCodEx/gists{/gist_id}","starred_url":"https://api.github.com/users/ReCodEx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ReCodEx/subscriptions","organizations_url":"https://api.github.com/users/ReCodEx/orgs","repos_url":"https://api.github.com/users/ReCodEx/repos","events_url":"https://api.github.com/users/ReCodEx/events{/privacy}","received_events_url":"https://api.github.com/users/ReCodEx/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ReCodEx/api","description":"Publicly accessible REST API for ReCodEx system","fork":false,"url":"https://api.github.com/repos/ReCodEx/api","forks_url":"https://api.github.com/repos/ReCodEx/api/forks","keys_url":"https://api.github.com/repos/ReCodEx/api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ReCodEx/api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ReCodEx/api/teams","hooks_url":"https://api.github.com/repos/ReCodEx/api/hooks","issue_events_url":"https://api.github.com/repos/ReCodEx/api/issues/events{/number}","events_url":"https://api.github.com/repos/ReCodEx/api/events","assignees_url":"https://api.github.com/repos/ReCodEx/api/assignees{/user}","branches_url":"https://api.github.com/repos/ReCodEx/api/branches{/branch}","tags_url":"https://api.github.com/repos/ReCodEx/api/tags","blobs_url":"https://api.github.com/repos/ReCodEx/api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ReCodEx/api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ReCodEx/api/git/refs{/sha}","trees_url":"https://api.github.com/repos/ReCodEx/api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ReCodEx/api/statuses/{sha}","languages_url":"https://api.github.com/repos/ReCodEx/api/languages","stargazers_url":"https://api.github.com/repos/ReCodEx/api/stargazers","contributors_url":"https://api.github.com/repos/ReCodEx/api/contributors","subscribers_url":"https://api.github.com/repos/ReCodEx/api/subscribers","subscription_url":"https://api.github.com/repos/ReCodEx/api/subscription","commits_url":"https://api.github.com/repos/ReCodEx/api/commits{/sha}","git_commits_url":"https://api.github.com/repos/ReCodEx/api/git/commits{/sha}","comments_url":"https://api.github.com/repos/ReCodEx/api/comments{/number}","issue_comment_url":"https://api.github.com/repos/ReCodEx/api/issues/comments{/number}","contents_url":"https://api.github.com/repos/ReCodEx/api/contents/{+path}","compare_url":"https://api.github.com/repos/ReCodEx/api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ReCodEx/api/merges","archive_url":"https://api.github.com/repos/ReCodEx/api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ReCodEx/api/downloads","issues_url":"https://api.github.com/repos/ReCodEx/api/issues{/number}","pulls_url":"https://api.github.com/repos/ReCodEx/api/pulls{/number}","milestones_url":"https://api.github.com/repos/ReCodEx/api/milestones{/number}","notifications_url":"https://api.github.com/repos/ReCodEx/api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ReCodEx/api/labels{/name}","releases_url":"https://api.github.com/repos/ReCodEx/api/releases{/id}","deployments_url":"https://api.github.com/repos/ReCodEx/api/deployments","created_at":"2016-07-23T18:30:47Z","updated_at":"2018-08-02T15:48:24Z","pushed_at":"2018-08-03T08:44:15Z","git_url":"git://github.com/ReCodEx/api.git","ssh_url":"git@github.com:ReCodEx/api.git","clone_url":"https://github.com/ReCodEx/api.git","svn_url":"https://github.com/ReCodEx/api","homepage":"https://recodex.mff.cuni.cz/api/v1","size":5822,"stargazers_count":4,"watchers_count":4,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ReCodEx/api/pulls/230"},"html":{"href":"https://github.com/ReCodEx/api/pull/230"},"issue":{"href":"https://api.github.com/repos/ReCodEx/api/issues/230"},"comments":{"href":"https://api.github.com/repos/ReCodEx/api/issues/230/comments"},"review_comments":{"href":"https://api.github.com/repos/ReCodEx/api/pulls/230/comments"},"review_comment":{"href":"https://api.github.com/repos/ReCodEx/api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ReCodEx/api/pulls/230/commits"},"statuses":{"href":"https://api.github.com/repos/ReCodEx/api/statuses/155078fefc5f2dc84b0543e82279171b836b8c51"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"Neloop"}}