{"action":"created","issue":{"url":"https://api.github.com/repos/projectfluent/fluent/issues/144","repository_url":"https://api.github.com/repos/projectfluent/fluent","labels_url":"https://api.github.com/repos/projectfluent/fluent/issues/144/labels{/name}","comments_url":"https://api.github.com/repos/projectfluent/fluent/issues/144/comments","events_url":"https://api.github.com/repos/projectfluent/fluent/issues/144/events","html_url":"https://github.com/projectfluent/fluent/issues/144","id":329345337,"node_id":"MDU6SXNzdWUzMjkzNDUzMzc=","number":144,"title":"Remove the Identifier node","user":{"login":"stasm","id":265818,"node_id":"MDQ6VXNlcjI2NTgxOA==","avatar_url":"https://avatars3.githubusercontent.com/u/265818?v=4","gravatar_id":"","url":"https://api.github.com/users/stasm","html_url":"https://github.com/stasm","followers_url":"https://api.github.com/users/stasm/followers","following_url":"https://api.github.com/users/stasm/following{/other_user}","gists_url":"https://api.github.com/users/stasm/gists{/gist_id}","starred_url":"https://api.github.com/users/stasm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stasm/subscriptions","organizations_url":"https://api.github.com/users/stasm/orgs","repos_url":"https://api.github.com/users/stasm/repos","events_url":"https://api.github.com/users/stasm/events{/privacy}","received_events_url":"https://api.github.com/users/stasm/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-05T08:09:26Z","updated_at":"2018-06-05T09:37:31Z","closed_at":null,"author_association":"MEMBER","body":"Right now we have:\r\n\r\n```\r\n{\r\n    \"type\": \"Message\",\r\n    \"id\": {\r\n        \"type\": \"Identifier\",\r\n        \"name\": \"message-id\"\r\n    },\r\n    \"value\": …\r\n}\r\n```\r\n```\r\n{\r\n    \"type\": \"Term\",\r\n    \"id\": {\r\n        \"type\": \"Identifier\",\r\n        \"name\": \"-term-id\"\r\n    },\r\n    \"value\": …\r\n}\r\n```\r\n```\r\n{\r\n    \"type\": \"MessageReference\",\r\n    \"identifier\": {\r\n        \"type\": \"Identifier\",\r\n        \"name\": \"message-id\"\r\n    },\r\n}\r\n```\r\n```\r\n{\r\n    \"type\": \"TermReference\",\r\n    \"identifier\": {\r\n        \"type\": \"Identifier\",\r\n        \"name\": \"-term-id\"\r\n    },\r\n}\r\n```\r\n```\r\n{\r\n    \"type\": \"VariableReference\",\r\n    \"identifier\": {\r\n        \"type\": \"Identifier\",\r\n        \"name\": \"variable-id\"\r\n    },\r\n}\r\n```\r\n\r\nCould we simplify the AST by removing the `Identifier` node? It doesn't seem to add much value. Compare:\r\n\r\n```\r\n{\r\n    \"type\": \"Message\",\r\n    \"id\": \"message-id\",\r\n    \"value\": …\r\n}\r\n```\r\n```\r\n{\r\n    \"type\": \"Term\",\r\n    \"id\": \"-term-id\",\r\n    \"value\": …\r\n}\r\n```\r\n```\r\n{\r\n    \"type\": \"MessageReference\",\r\n    \"identifier\": \"message-id\"\r\n}\r\n```\r\n```\r\n{\r\n    \"type\": \"TermReference\",\r\n    \"identifier\": \"-term-id\"\r\n}\r\n```\r\n```\r\n{\r\n    \"type\": \"VariableReference\",\r\n    \"identifier\": \"$variable-id\"\r\n}\r\n```"},"comment":{"url":"https://api.github.com/repos/projectfluent/fluent/issues/comments/394646671","html_url":"https://github.com/projectfluent/fluent/issues/144#issuecomment-394646671","issue_url":"https://api.github.com/repos/projectfluent/fluent/issues/144","id":394646671,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NDY0NjY3MQ==","user":{"login":"Pike","id":43494,"node_id":"MDQ6VXNlcjQzNDk0","avatar_url":"https://avatars2.githubusercontent.com/u/43494?v=4","gravatar_id":"","url":"https://api.github.com/users/Pike","html_url":"https://github.com/Pike","followers_url":"https://api.github.com/users/Pike/followers","following_url":"https://api.github.com/users/Pike/following{/other_user}","gists_url":"https://api.github.com/users/Pike/gists{/gist_id}","starred_url":"https://api.github.com/users/Pike/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Pike/subscriptions","organizations_url":"https://api.github.com/users/Pike/orgs","repos_url":"https://api.github.com/users/Pike/repos","events_url":"https://api.github.com/users/Pike/events{/privacy}","received_events_url":"https://api.github.com/users/Pike/received_events","type":"User","site_admin":false},"created_at":"2018-06-05T09:37:31Z","updated_at":"2018-06-05T09:37:31Z","author_association":"COLLABORATOR","body":"Also `Attribute` and `FooAttributeExpression`.\r\n\r\nI'd suggest a __needs_pr__ label for this one ;-)"}}
{"actor":{"display_login":"Pike"}}