{"action":"created","comment":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/comments/169088662","pull_request_review_id":97551844,"id":169088662,"diff_hunk":"@@ -25,25 +25,48 @@\n namespace peloton {\n namespace concurrency {\n \n-// timestamp ordering requires a spinlock field for protecting the atomic access\n-// to txn_id field and last_reader_cid field.\n+/**","path":"src/concurrency/timestamp_ordering_transaction_manager.cpp","position":6,"original_position":6,"commit_id":"0634c66a79e5bf30dc4d266e792a662236c7174f","original_commit_id":"0634c66a79e5bf30dc4d266e792a662236c7174f","user":{"login":"pervazea","id":34660288,"avatar_url":"https://avatars2.githubusercontent.com/u/34660288?v=4","gravatar_id":"","url":"https://api.github.com/users/pervazea","html_url":"https://github.com/pervazea","followers_url":"https://api.github.com/users/pervazea/followers","following_url":"https://api.github.com/users/pervazea/following{/other_user}","gists_url":"https://api.github.com/users/pervazea/gists{/gist_id}","starred_url":"https://api.github.com/users/pervazea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pervazea/subscriptions","organizations_url":"https://api.github.com/users/pervazea/orgs","repos_url":"https://api.github.com/users/pervazea/repos","events_url":"https://api.github.com/users/pervazea/events{/privacy}","received_events_url":"https://api.github.com/users/pervazea/received_events","type":"User","site_admin":false},"body":"I'm not seeing how to insert these at the right line numbers. \r\nShall we also add Doxygen comments for the following functions in this file? Line numbers on the left. \r\n\r\n218: AcquireOwnership - missing header\r\n271: PerformRead - missing header\r\n535: PerformInsert\r\n695: PerformDelete\r\n781: PerformDelete\r\n1000: AbortTransaction\r\n","created_at":"2018-02-19T14:21:51Z","updated_at":"2018-02-19T14:38:28Z","html_url":"https://github.com/cmu-db/peloton/pull/1152#discussion_r169088662","pull_request_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1152","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/comments/169088662"},"html":{"href":"https://github.com/cmu-db/peloton/pull/1152#discussion_r169088662"},"pull_request":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1152"}}},"pull_request":{"url":"https://api.github.com/repos/cmu-db/peloton/pulls/1152","id":169186915,"html_url":"https://github.com/cmu-db/peloton/pull/1152","diff_url":"https://github.com/cmu-db/peloton/pull/1152.diff","patch_url":"https://github.com/cmu-db/peloton/pull/1152.patch","issue_url":"https://api.github.com/repos/cmu-db/peloton/issues/1152","number":1152,"state":"open","locked":false,"title":"Doxygen comments for files in concurrency","user":{"login":"aaron-tian","id":7610911,"avatar_url":"https://avatars2.githubusercontent.com/u/7610911?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-tian","html_url":"https://github.com/aaron-tian","followers_url":"https://api.github.com/users/aaron-tian/followers","following_url":"https://api.github.com/users/aaron-tian/following{/other_user}","gists_url":"https://api.github.com/users/aaron-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-tian/subscriptions","organizations_url":"https://api.github.com/users/aaron-tian/orgs","repos_url":"https://api.github.com/users/aaron-tian/repos","events_url":"https://api.github.com/users/aaron-tian/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-tian/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-02-14T18:27:58Z","updated_at":"2018-02-19T14:38:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"669f94bb991c8a71a0fd2d71aeb8d879c5b90ee4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":712539152,"url":"https://api.github.com/repos/cmu-db/peloton/labels/ready_for_review","name":"ready_for_review","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1152/commits","review_comments_url":"https://api.github.com/repos/cmu-db/peloton/pulls/1152/comments","review_comment_url":"https://api.github.com/repos/cmu-db/peloton/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cmu-db/peloton/issues/1152/comments","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/0634c66a79e5bf30dc4d266e792a662236c7174f","head":{"label":"aaron-tian:doxygen","ref":"doxygen","sha":"0634c66a79e5bf30dc4d266e792a662236c7174f","user":{"login":"aaron-tian","id":7610911,"avatar_url":"https://avatars2.githubusercontent.com/u/7610911?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-tian","html_url":"https://github.com/aaron-tian","followers_url":"https://api.github.com/users/aaron-tian/followers","following_url":"https://api.github.com/users/aaron-tian/following{/other_user}","gists_url":"https://api.github.com/users/aaron-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-tian/subscriptions","organizations_url":"https://api.github.com/users/aaron-tian/orgs","repos_url":"https://api.github.com/users/aaron-tian/repos","events_url":"https://api.github.com/users/aaron-tian/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-tian/received_events","type":"User","site_admin":false},"repo":{"id":103526979,"name":"peloton","full_name":"aaron-tian/peloton","owner":{"login":"aaron-tian","id":7610911,"avatar_url":"https://avatars2.githubusercontent.com/u/7610911?v=4","gravatar_id":"","url":"https://api.github.com/users/aaron-tian","html_url":"https://github.com/aaron-tian","followers_url":"https://api.github.com/users/aaron-tian/followers","following_url":"https://api.github.com/users/aaron-tian/following{/other_user}","gists_url":"https://api.github.com/users/aaron-tian/gists{/gist_id}","starred_url":"https://api.github.com/users/aaron-tian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaron-tian/subscriptions","organizations_url":"https://api.github.com/users/aaron-tian/orgs","repos_url":"https://api.github.com/users/aaron-tian/repos","events_url":"https://api.github.com/users/aaron-tian/events{/privacy}","received_events_url":"https://api.github.com/users/aaron-tian/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaron-tian/peloton","description":"The Self-Driving Database Management System","fork":true,"url":"https://api.github.com/repos/aaron-tian/peloton","forks_url":"https://api.github.com/repos/aaron-tian/peloton/forks","keys_url":"https://api.github.com/repos/aaron-tian/peloton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaron-tian/peloton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaron-tian/peloton/teams","hooks_url":"https://api.github.com/repos/aaron-tian/peloton/hooks","issue_events_url":"https://api.github.com/repos/aaron-tian/peloton/issues/events{/number}","events_url":"https://api.github.com/repos/aaron-tian/peloton/events","assignees_url":"https://api.github.com/repos/aaron-tian/peloton/assignees{/user}","branches_url":"https://api.github.com/repos/aaron-tian/peloton/branches{/branch}","tags_url":"https://api.github.com/repos/aaron-tian/peloton/tags","blobs_url":"https://api.github.com/repos/aaron-tian/peloton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaron-tian/peloton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaron-tian/peloton/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaron-tian/peloton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaron-tian/peloton/statuses/{sha}","languages_url":"https://api.github.com/repos/aaron-tian/peloton/languages","stargazers_url":"https://api.github.com/repos/aaron-tian/peloton/stargazers","contributors_url":"https://api.github.com/repos/aaron-tian/peloton/contributors","subscribers_url":"https://api.github.com/repos/aaron-tian/peloton/subscribers","subscription_url":"https://api.github.com/repos/aaron-tian/peloton/subscription","commits_url":"https://api.github.com/repos/aaron-tian/peloton/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaron-tian/peloton/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaron-tian/peloton/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaron-tian/peloton/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaron-tian/peloton/contents/{+path}","compare_url":"https://api.github.com/repos/aaron-tian/peloton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaron-tian/peloton/merges","archive_url":"https://api.github.com/repos/aaron-tian/peloton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaron-tian/peloton/downloads","issues_url":"https://api.github.com/repos/aaron-tian/peloton/issues{/number}","pulls_url":"https://api.github.com/repos/aaron-tian/peloton/pulls{/number}","milestones_url":"https://api.github.com/repos/aaron-tian/peloton/milestones{/number}","notifications_url":"https://api.github.com/repos/aaron-tian/peloton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaron-tian/peloton/labels{/name}","releases_url":"https://api.github.com/repos/aaron-tian/peloton/releases{/id}","deployments_url":"https://api.github.com/repos/aaron-tian/peloton/deployments","created_at":"2017-09-14T12:00:43Z","updated_at":"2017-09-14T12:00:48Z","pushed_at":"2018-02-14T18:59:37Z","git_url":"git://github.com/aaron-tian/peloton.git","ssh_url":"git@github.com:aaron-tian/peloton.git","clone_url":"https://github.com/aaron-tian/peloton.git","svn_url":"https://github.com/aaron-tian/peloton","homepage":"http://pelotondb.io","size":63053,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cmu-db:master","ref":"master","sha":"ab16393d87833b0b580dfac38b9503cb44022de6","user":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"repo":{"id":28202609,"name":"peloton","full_name":"cmu-db/peloton","owner":{"login":"cmu-db","id":6220241,"avatar_url":"https://avatars0.githubusercontent.com/u/6220241?v=4","gravatar_id":"","url":"https://api.github.com/users/cmu-db","html_url":"https://github.com/cmu-db","followers_url":"https://api.github.com/users/cmu-db/followers","following_url":"https://api.github.com/users/cmu-db/following{/other_user}","gists_url":"https://api.github.com/users/cmu-db/gists{/gist_id}","starred_url":"https://api.github.com/users/cmu-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cmu-db/subscriptions","organizations_url":"https://api.github.com/users/cmu-db/orgs","repos_url":"https://api.github.com/users/cmu-db/repos","events_url":"https://api.github.com/users/cmu-db/events{/privacy}","received_events_url":"https://api.github.com/users/cmu-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cmu-db/peloton","description":"The Self-Driving Database Management System","fork":false,"url":"https://api.github.com/repos/cmu-db/peloton","forks_url":"https://api.github.com/repos/cmu-db/peloton/forks","keys_url":"https://api.github.com/repos/cmu-db/peloton/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cmu-db/peloton/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cmu-db/peloton/teams","hooks_url":"https://api.github.com/repos/cmu-db/peloton/hooks","issue_events_url":"https://api.github.com/repos/cmu-db/peloton/issues/events{/number}","events_url":"https://api.github.com/repos/cmu-db/peloton/events","assignees_url":"https://api.github.com/repos/cmu-db/peloton/assignees{/user}","branches_url":"https://api.github.com/repos/cmu-db/peloton/branches{/branch}","tags_url":"https://api.github.com/repos/cmu-db/peloton/tags","blobs_url":"https://api.github.com/repos/cmu-db/peloton/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cmu-db/peloton/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cmu-db/peloton/git/refs{/sha}","trees_url":"https://api.github.com/repos/cmu-db/peloton/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cmu-db/peloton/statuses/{sha}","languages_url":"https://api.github.com/repos/cmu-db/peloton/languages","stargazers_url":"https://api.github.com/repos/cmu-db/peloton/stargazers","contributors_url":"https://api.github.com/repos/cmu-db/peloton/contributors","subscribers_url":"https://api.github.com/repos/cmu-db/peloton/subscribers","subscription_url":"https://api.github.com/repos/cmu-db/peloton/subscription","commits_url":"https://api.github.com/repos/cmu-db/peloton/commits{/sha}","git_commits_url":"https://api.github.com/repos/cmu-db/peloton/git/commits{/sha}","comments_url":"https://api.github.com/repos/cmu-db/peloton/comments{/number}","issue_comment_url":"https://api.github.com/repos/cmu-db/peloton/issues/comments{/number}","contents_url":"https://api.github.com/repos/cmu-db/peloton/contents/{+path}","compare_url":"https://api.github.com/repos/cmu-db/peloton/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cmu-db/peloton/merges","archive_url":"https://api.github.com/repos/cmu-db/peloton/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cmu-db/peloton/downloads","issues_url":"https://api.github.com/repos/cmu-db/peloton/issues{/number}","pulls_url":"https://api.github.com/repos/cmu-db/peloton/pulls{/number}","milestones_url":"https://api.github.com/repos/cmu-db/peloton/milestones{/number}","notifications_url":"https://api.github.com/repos/cmu-db/peloton/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cmu-db/peloton/labels{/name}","releases_url":"https://api.github.com/repos/cmu-db/peloton/releases{/id}","deployments_url":"https://api.github.com/repos/cmu-db/peloton/deployments","created_at":"2014-12-18T21:35:23Z","updated_at":"2018-02-16T17:06:22Z","pushed_at":"2018-02-18T23:36:31Z","git_url":"git://github.com/cmu-db/peloton.git","ssh_url":"git@github.com:cmu-db/peloton.git","clone_url":"https://github.com/cmu-db/peloton.git","svn_url":"https://github.com/cmu-db/peloton","homepage":"http://pelotondb.io","size":63464,"stargazers_count":1124,"watchers_count":1124,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":412,"mirror_url":null,"archived":false,"open_issues_count":123,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":412,"open_issues":123,"watchers":1124,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1152"},"html":{"href":"https://github.com/cmu-db/peloton/pull/1152"},"issue":{"href":"https://api.github.com/repos/cmu-db/peloton/issues/1152"},"comments":{"href":"https://api.github.com/repos/cmu-db/peloton/issues/1152/comments"},"review_comments":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1152/comments"},"review_comment":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cmu-db/peloton/pulls/1152/commits"},"statuses":{"href":"https://api.github.com/repos/cmu-db/peloton/statuses/0634c66a79e5bf30dc4d266e792a662236c7174f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pervazea"}}