{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/che/pulls/comments/208122488","pull_request_review_id":143867341,"id":208122488,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODEyMjQ4OA==","diff_hunk":"@@ -24,7 +24,7 @@ spec:\n   tls:\n   - hosts:\n     - {{ template \"keycloakHost\" . }}\n-    secretName: che-tls\n+    secretName: {{ .Values.global.tls.secretName }}","path":"deploy/kubernetes/helm/che/charts/che-keycloak/templates/ingress.yaml","position":5,"original_position":5,"commit_id":"124a8f18efb38b46365106893dd0af22a9253ba1","original_commit_id":"124a8f18efb38b46365106893dd0af22a9253ba1","user":{"login":"sleshchenko","id":5887312,"node_id":"MDQ6VXNlcjU4ODczMTI=","avatar_url":"https://avatars0.githubusercontent.com/u/5887312?v=4","gravatar_id":"","url":"https://api.github.com/users/sleshchenko","html_url":"https://github.com/sleshchenko","followers_url":"https://api.github.com/users/sleshchenko/followers","following_url":"https://api.github.com/users/sleshchenko/following{/other_user}","gists_url":"https://api.github.com/users/sleshchenko/gists{/gist_id}","starred_url":"https://api.github.com/users/sleshchenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sleshchenko/subscriptions","organizations_url":"https://api.github.com/users/sleshchenko/orgs","repos_url":"https://api.github.com/users/sleshchenko/repos","events_url":"https://api.github.com/users/sleshchenko/events{/privacy}","received_events_url":"https://api.github.com/users/sleshchenko/received_events","type":"User","site_admin":false},"body":"Good catch.\r\n\r\nLooks like one more hardcoded usage of  `che-tls` is missing: [certificate.yaml](https://github.com/i300543/che/blob/master/deploy/kubernetes/helm/che/templates/certificate.yaml#L14)","created_at":"2018-08-07T07:18:52Z","updated_at":"2018-08-07T07:41:59Z","html_url":"https://github.com/eclipse/che/pull/10509#discussion_r208122488","pull_request_url":"https://api.github.com/repos/eclipse/che/pulls/10509","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments/208122488"},"html":{"href":"https://github.com/eclipse/che/pull/10509#discussion_r208122488"},"pull_request":{"href":"https://api.github.com/repos/eclipse/che/pulls/10509"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/che/pulls/10509","id":203201594,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMjAxNTk0","html_url":"https://github.com/eclipse/che/pull/10509","diff_url":"https://github.com/eclipse/che/pull/10509.diff","patch_url":"https://github.com/eclipse/che/pull/10509.patch","issue_url":"https://api.github.com/repos/eclipse/che/issues/10509","number":10509,"state":"open","locked":false,"title":"Make host calculation more short and concise for che master","user":{"login":"i300543","id":11046606,"node_id":"MDQ6VXNlcjExMDQ2NjA2","avatar_url":"https://avatars2.githubusercontent.com/u/11046606?v=4","gravatar_id":"","url":"https://api.github.com/users/i300543","html_url":"https://github.com/i300543","followers_url":"https://api.github.com/users/i300543/followers","following_url":"https://api.github.com/users/i300543/following{/other_user}","gists_url":"https://api.github.com/users/i300543/gists{/gist_id}","starred_url":"https://api.github.com/users/i300543/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i300543/subscriptions","organizations_url":"https://api.github.com/users/i300543/orgs","repos_url":"https://api.github.com/users/i300543/repos","events_url":"https://api.github.com/users/i300543/events{/privacy}","received_events_url":"https://api.github.com/users/i300543/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Sergey Kuperman <sergey.kuperman@sap.com>\r\n\r\n<!-- Please review the following before submitting a PR:\r\nChe's Contributing Guide: https://github.com/eclipse/che/blob/master/CONTRIBUTING.md\r\nPull Request Policy: https://github.com/eclipse/che/wiki/Development-Workflow#pull-requests\r\n\r\nCOMMITTERS: please include labels on each PR. Labels are listed here: https://github.com/eclipse/che/wiki/Labels but at a minimum you should include `kind/..` and `Dev Open Pull Request Status` labels.\r\n-->\r\n\r\n### What does this PR do?\r\nShortens the che master hostname calculated in k8s helm scripts for single-host and default-host server strategies,\r\nmakes tls secret used in all ingresses configurable from values\r\n\r\n","created_at":"2018-07-23T12:22:24Z","updated_at":"2018-08-07T07:41:59Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b8ed00a0faa11223cd1fc2d5f314eb83ed5a7b66","assignee":null,"assignees":[],"requested_reviewers":[{"login":"benoitf","id":436777,"node_id":"MDQ6VXNlcjQzNjc3Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/436777?v=4","gravatar_id":"","url":"https://api.github.com/users/benoitf","html_url":"https://github.com/benoitf","followers_url":"https://api.github.com/users/benoitf/followers","following_url":"https://api.github.com/users/benoitf/following{/other_user}","gists_url":"https://api.github.com/users/benoitf/gists{/gist_id}","starred_url":"https://api.github.com/users/benoitf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/benoitf/subscriptions","organizations_url":"https://api.github.com/users/benoitf/orgs","repos_url":"https://api.github.com/users/benoitf/repos","events_url":"https://api.github.com/users/benoitf/events{/privacy}","received_events_url":"https://api.github.com/users/benoitf/received_events","type":"User","site_admin":false},{"login":"l0rd","id":606959,"node_id":"MDQ6VXNlcjYwNjk1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/606959?v=4","gravatar_id":"","url":"https://api.github.com/users/l0rd","html_url":"https://github.com/l0rd","followers_url":"https://api.github.com/users/l0rd/followers","following_url":"https://api.github.com/users/l0rd/following{/other_user}","gists_url":"https://api.github.com/users/l0rd/gists{/gist_id}","starred_url":"https://api.github.com/users/l0rd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/l0rd/subscriptions","organizations_url":"https://api.github.com/users/l0rd/orgs","repos_url":"https://api.github.com/users/l0rd/repos","events_url":"https://api.github.com/users/l0rd/events{/privacy}","received_events_url":"https://api.github.com/users/l0rd/received_events","type":"User","site_admin":false},{"login":"riuvshin","id":1636732,"node_id":"MDQ6VXNlcjE2MzY3MzI=","avatar_url":"https://avatars2.githubusercontent.com/u/1636732?v=4","gravatar_id":"","url":"https://api.github.com/users/riuvshin","html_url":"https://github.com/riuvshin","followers_url":"https://api.github.com/users/riuvshin/followers","following_url":"https://api.github.com/users/riuvshin/following{/other_user}","gists_url":"https://api.github.com/users/riuvshin/gists{/gist_id}","starred_url":"https://api.github.com/users/riuvshin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/riuvshin/subscriptions","organizations_url":"https://api.github.com/users/riuvshin/orgs","repos_url":"https://api.github.com/users/riuvshin/repos","events_url":"https://api.github.com/users/riuvshin/events{/privacy}","received_events_url":"https://api.github.com/users/riuvshin/received_events","type":"User","site_admin":false},{"login":"eivantsov","id":5337267,"node_id":"MDQ6VXNlcjUzMzcyNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/5337267?v=4","gravatar_id":"","url":"https://api.github.com/users/eivantsov","html_url":"https://github.com/eivantsov","followers_url":"https://api.github.com/users/eivantsov/followers","following_url":"https://api.github.com/users/eivantsov/following{/other_user}","gists_url":"https://api.github.com/users/eivantsov/gists{/gist_id}","starred_url":"https://api.github.com/users/eivantsov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eivantsov/subscriptions","organizations_url":"https://api.github.com/users/eivantsov/orgs","repos_url":"https://api.github.com/users/eivantsov/repos","events_url":"https://api.github.com/users/eivantsov/events{/privacy}","received_events_url":"https://api.github.com/users/eivantsov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":345100523,"node_id":"MDU6TGFiZWwzNDUxMDA1MjM=","url":"https://api.github.com/repos/eclipse/che/labels/status/code-review","name":"status/code-review","color":"0052cc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/che/pulls/10509/commits","review_comments_url":"https://api.github.com/repos/eclipse/che/pulls/10509/comments","review_comment_url":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/che/issues/10509/comments","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/124a8f18efb38b46365106893dd0af22a9253ba1","head":{"label":"i300543:master","ref":"master","sha":"124a8f18efb38b46365106893dd0af22a9253ba1","user":{"login":"i300543","id":11046606,"node_id":"MDQ6VXNlcjExMDQ2NjA2","avatar_url":"https://avatars2.githubusercontent.com/u/11046606?v=4","gravatar_id":"","url":"https://api.github.com/users/i300543","html_url":"https://github.com/i300543","followers_url":"https://api.github.com/users/i300543/followers","following_url":"https://api.github.com/users/i300543/following{/other_user}","gists_url":"https://api.github.com/users/i300543/gists{/gist_id}","starred_url":"https://api.github.com/users/i300543/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i300543/subscriptions","organizations_url":"https://api.github.com/users/i300543/orgs","repos_url":"https://api.github.com/users/i300543/repos","events_url":"https://api.github.com/users/i300543/events{/privacy}","received_events_url":"https://api.github.com/users/i300543/received_events","type":"User","site_admin":false},"repo":{"id":142008843,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwMDg4NDM=","name":"che","full_name":"i300543/che","owner":{"login":"i300543","id":11046606,"node_id":"MDQ6VXNlcjExMDQ2NjA2","avatar_url":"https://avatars2.githubusercontent.com/u/11046606?v=4","gravatar_id":"","url":"https://api.github.com/users/i300543","html_url":"https://github.com/i300543","followers_url":"https://api.github.com/users/i300543/followers","following_url":"https://api.github.com/users/i300543/following{/other_user}","gists_url":"https://api.github.com/users/i300543/gists{/gist_id}","starred_url":"https://api.github.com/users/i300543/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/i300543/subscriptions","organizations_url":"https://api.github.com/users/i300543/orgs","repos_url":"https://api.github.com/users/i300543/repos","events_url":"https://api.github.com/users/i300543/events{/privacy}","received_events_url":"https://api.github.com/users/i300543/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/i300543/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":true,"url":"https://api.github.com/repos/i300543/che","forks_url":"https://api.github.com/repos/i300543/che/forks","keys_url":"https://api.github.com/repos/i300543/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/i300543/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/i300543/che/teams","hooks_url":"https://api.github.com/repos/i300543/che/hooks","issue_events_url":"https://api.github.com/repos/i300543/che/issues/events{/number}","events_url":"https://api.github.com/repos/i300543/che/events","assignees_url":"https://api.github.com/repos/i300543/che/assignees{/user}","branches_url":"https://api.github.com/repos/i300543/che/branches{/branch}","tags_url":"https://api.github.com/repos/i300543/che/tags","blobs_url":"https://api.github.com/repos/i300543/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/i300543/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/i300543/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/i300543/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/i300543/che/statuses/{sha}","languages_url":"https://api.github.com/repos/i300543/che/languages","stargazers_url":"https://api.github.com/repos/i300543/che/stargazers","contributors_url":"https://api.github.com/repos/i300543/che/contributors","subscribers_url":"https://api.github.com/repos/i300543/che/subscribers","subscription_url":"https://api.github.com/repos/i300543/che/subscription","commits_url":"https://api.github.com/repos/i300543/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/i300543/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/i300543/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/i300543/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/i300543/che/contents/{+path}","compare_url":"https://api.github.com/repos/i300543/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/i300543/che/merges","archive_url":"https://api.github.com/repos/i300543/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/i300543/che/downloads","issues_url":"https://api.github.com/repos/i300543/che/issues{/number}","pulls_url":"https://api.github.com/repos/i300543/che/pulls{/number}","milestones_url":"https://api.github.com/repos/i300543/che/milestones{/number}","notifications_url":"https://api.github.com/repos/i300543/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/i300543/che/labels{/name}","releases_url":"https://api.github.com/repos/i300543/che/releases{/id}","deployments_url":"https://api.github.com/repos/i300543/che/deployments","created_at":"2018-07-23T12:06:53Z","updated_at":"2018-08-06T07:58:52Z","pushed_at":"2018-08-07T07:03:03Z","git_url":"git://github.com/i300543/che.git","ssh_url":"git@github.com:i300543/che.git","clone_url":"https://github.com/i300543/che.git","svn_url":"https://github.com/i300543/che","homepage":"http://eclipse.org/che","size":93244,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"daa4441a869631832236454cf0e161639377226c","user":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":32935745,"node_id":"MDEwOlJlcG9zaXRvcnkzMjkzNTc0NQ==","name":"che","full_name":"eclipse/che","owner":{"login":"eclipse","id":56974,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTc0","avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/che","description":"Eclipse Che: Next-generation Eclipse IDE.  Open source workspace server and cloud IDE.","fork":false,"url":"https://api.github.com/repos/eclipse/che","forks_url":"https://api.github.com/repos/eclipse/che/forks","keys_url":"https://api.github.com/repos/eclipse/che/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/che/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/che/teams","hooks_url":"https://api.github.com/repos/eclipse/che/hooks","issue_events_url":"https://api.github.com/repos/eclipse/che/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/che/events","assignees_url":"https://api.github.com/repos/eclipse/che/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/che/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/che/tags","blobs_url":"https://api.github.com/repos/eclipse/che/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/che/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/che/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/che/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/che/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/che/languages","stargazers_url":"https://api.github.com/repos/eclipse/che/stargazers","contributors_url":"https://api.github.com/repos/eclipse/che/contributors","subscribers_url":"https://api.github.com/repos/eclipse/che/subscribers","subscription_url":"https://api.github.com/repos/eclipse/che/subscription","commits_url":"https://api.github.com/repos/eclipse/che/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/che/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/che/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/che/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/che/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/che/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/che/merges","archive_url":"https://api.github.com/repos/eclipse/che/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/che/downloads","issues_url":"https://api.github.com/repos/eclipse/che/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/che/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/che/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/che/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/che/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/che/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/che/deployments","created_at":"2015-03-26T15:31:01Z","updated_at":"2018-08-07T06:03:01Z","pushed_at":"2018-08-07T07:41:13Z","git_url":"git://github.com/eclipse/che.git","ssh_url":"git@github.com:eclipse/che.git","clone_url":"https://github.com/eclipse/che.git","svn_url":"https://github.com/eclipse/che","homepage":"http://eclipse.org/che","size":95715,"stargazers_count":4960,"watchers_count":4960,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":896,"mirror_url":null,"archived":false,"open_issues_count":888,"license":{"key":"epl-2.0","name":"Eclipse Public License 2.0","spdx_id":"EPL-2.0","url":"https://api.github.com/licenses/epl-2.0","node_id":"MDc6TGljZW5zZTMy"},"forks":896,"open_issues":888,"watchers":4960,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/che/pulls/10509"},"html":{"href":"https://github.com/eclipse/che/pull/10509"},"issue":{"href":"https://api.github.com/repos/eclipse/che/issues/10509"},"comments":{"href":"https://api.github.com/repos/eclipse/che/issues/10509/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/che/pulls/10509/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/che/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/che/pulls/10509/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/che/statuses/124a8f18efb38b46365106893dd0af22a9253ba1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sleshchenko"}}