{"action":"created","comment":{"url":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/comments/169202572","pull_request_review_id":97690803,"id":169202572,"diff_hunk":"@@ -0,0 +1,15 @@\n+<launch>\n+  <node pkg=\"rr_platform\" type=\"ultrasonic_array\" name=\"ultrasonic_array_to_pcl\" output=\"screen\" respawn=\"false\">\n+    <param name=\"number_of_sensors\" type=\"int\" value=\"6\" />\n+    <param name=\"baud_rate\" type=\"int\" value=\"9600\" />\n+    <param name=\"serial_port_name\" type=\"string\" value=\"/dev/ttyUSB0\" />\n+    <param name=\"sensor_base_link\" type=\"string\" value= \"/ultrasonic_array_base\" />\n+    <param name=\"sensor_link\" type=\"string\" value= \"ultrasonic_\" />","path":"rr_platform/launch/ultrasonic_array.launch","position":7,"original_position":7,"commit_id":"83ea19e62e8d7bb98cc7003a39505d2c2eaa4c54","original_commit_id":"83ea19e62e8d7bb98cc7003a39505d2c2eaa4c54","user":{"login":"barulicm","id":1761749,"avatar_url":"https://avatars3.githubusercontent.com/u/1761749?v=4","gravatar_id":"","url":"https://api.github.com/users/barulicm","html_url":"https://github.com/barulicm","followers_url":"https://api.github.com/users/barulicm/followers","following_url":"https://api.github.com/users/barulicm/following{/other_user}","gists_url":"https://api.github.com/users/barulicm/gists{/gist_id}","starred_url":"https://api.github.com/users/barulicm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/barulicm/subscriptions","organizations_url":"https://api.github.com/users/barulicm/orgs","repos_url":"https://api.github.com/users/barulicm/repos","events_url":"https://api.github.com/users/barulicm/events{/privacy}","received_events_url":"https://api.github.com/users/barulicm/received_events","type":"User","site_admin":false},"body":"I see what you mean. I like it. \r\n@btdubs Consider naming this parameter \"sensor_link_prefix\"","created_at":"2018-02-20T01:56:22Z","updated_at":"2018-02-20T01:56:22Z","html_url":"https://github.com/RoboJackets/roboracing-software/pull/134#discussion_r169202572","pull_request_url":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/134","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/comments/169202572"},"html":{"href":"https://github.com/RoboJackets/roboracing-software/pull/134#discussion_r169202572"},"pull_request":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/134"}},"in_reply_to_id":169200710},"pull_request":{"url":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/134","id":169855457,"html_url":"https://github.com/RoboJackets/roboracing-software/pull/134","diff_url":"https://github.com/RoboJackets/roboracing-software/pull/134.diff","patch_url":"https://github.com/RoboJackets/roboracing-software/pull/134.patch","issue_url":"https://api.github.com/repos/RoboJackets/roboracing-software/issues/134","number":134,"state":"open","locked":false,"title":"Ultrasonic Array","user":{"login":"btdubs","id":13946288,"avatar_url":"https://avatars2.githubusercontent.com/u/13946288?v=4","gravatar_id":"","url":"https://api.github.com/users/btdubs","html_url":"https://github.com/btdubs","followers_url":"https://api.github.com/users/btdubs/followers","following_url":"https://api.github.com/users/btdubs/following{/other_user}","gists_url":"https://api.github.com/users/btdubs/gists{/gist_id}","starred_url":"https://api.github.com/users/btdubs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/btdubs/subscriptions","organizations_url":"https://api.github.com/users/btdubs/orgs","repos_url":"https://api.github.com/users/btdubs/repos","events_url":"https://api.github.com/users/btdubs/events{/privacy}","received_events_url":"https://api.github.com/users/btdubs/received_events","type":"User","site_admin":false},"body":"Adds ultrasonic array interface node for new ultrasonic hardware to take in distances over serial and output point cloud of obstacles.\r\n\r\nSee also pr in roboracing-firmware.","created_at":"2018-02-18T22:55:39Z","updated_at":"2018-02-20T01:56:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"385799bc769723d94b10fdbc90b8eca9bf856628","assignee":null,"assignees":[],"requested_reviewers":[{"login":"chsahit","id":3252741,"avatar_url":"https://avatars1.githubusercontent.com/u/3252741?v=4","gravatar_id":"","url":"https://api.github.com/users/chsahit","html_url":"https://github.com/chsahit","followers_url":"https://api.github.com/users/chsahit/followers","following_url":"https://api.github.com/users/chsahit/following{/other_user}","gists_url":"https://api.github.com/users/chsahit/gists{/gist_id}","starred_url":"https://api.github.com/users/chsahit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chsahit/subscriptions","organizations_url":"https://api.github.com/users/chsahit/orgs","repos_url":"https://api.github.com/users/chsahit/repos","events_url":"https://api.github.com/users/chsahit/events{/privacy}","received_events_url":"https://api.github.com/users/chsahit/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/134/commits","review_comments_url":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/134/comments","review_comment_url":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/comments{/number}","comments_url":"https://api.github.com/repos/RoboJackets/roboracing-software/issues/134/comments","statuses_url":"https://api.github.com/repos/RoboJackets/roboracing-software/statuses/83ea19e62e8d7bb98cc7003a39505d2c2eaa4c54","head":{"label":"RoboJackets:ultrasonic_array","ref":"ultrasonic_array","sha":"83ea19e62e8d7bb98cc7003a39505d2c2eaa4c54","user":{"login":"RoboJackets","id":3523251,"avatar_url":"https://avatars1.githubusercontent.com/u/3523251?v=4","gravatar_id":"","url":"https://api.github.com/users/RoboJackets","html_url":"https://github.com/RoboJackets","followers_url":"https://api.github.com/users/RoboJackets/followers","following_url":"https://api.github.com/users/RoboJackets/following{/other_user}","gists_url":"https://api.github.com/users/RoboJackets/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboJackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboJackets/subscriptions","organizations_url":"https://api.github.com/users/RoboJackets/orgs","repos_url":"https://api.github.com/users/RoboJackets/repos","events_url":"https://api.github.com/users/RoboJackets/events{/privacy}","received_events_url":"https://api.github.com/users/RoboJackets/received_events","type":"Organization","site_admin":false},"repo":{"id":15688257,"name":"roboracing-software","full_name":"RoboJackets/roboracing-software","owner":{"login":"RoboJackets","id":3523251,"avatar_url":"https://avatars1.githubusercontent.com/u/3523251?v=4","gravatar_id":"","url":"https://api.github.com/users/RoboJackets","html_url":"https://github.com/RoboJackets","followers_url":"https://api.github.com/users/RoboJackets/followers","following_url":"https://api.github.com/users/RoboJackets/following{/other_user}","gists_url":"https://api.github.com/users/RoboJackets/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboJackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboJackets/subscriptions","organizations_url":"https://api.github.com/users/RoboJackets/orgs","repos_url":"https://api.github.com/users/RoboJackets/repos","events_url":"https://api.github.com/users/RoboJackets/events{/privacy}","received_events_url":"https://api.github.com/users/RoboJackets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RoboJackets/roboracing-software","description":"ROS packages for the RoboJackets RoboRacing team.","fork":false,"url":"https://api.github.com/repos/RoboJackets/roboracing-software","forks_url":"https://api.github.com/repos/RoboJackets/roboracing-software/forks","keys_url":"https://api.github.com/repos/RoboJackets/roboracing-software/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RoboJackets/roboracing-software/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RoboJackets/roboracing-software/teams","hooks_url":"https://api.github.com/repos/RoboJackets/roboracing-software/hooks","issue_events_url":"https://api.github.com/repos/RoboJackets/roboracing-software/issues/events{/number}","events_url":"https://api.github.com/repos/RoboJackets/roboracing-software/events","assignees_url":"https://api.github.com/repos/RoboJackets/roboracing-software/assignees{/user}","branches_url":"https://api.github.com/repos/RoboJackets/roboracing-software/branches{/branch}","tags_url":"https://api.github.com/repos/RoboJackets/roboracing-software/tags","blobs_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/refs{/sha}","trees_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RoboJackets/roboracing-software/statuses/{sha}","languages_url":"https://api.github.com/repos/RoboJackets/roboracing-software/languages","stargazers_url":"https://api.github.com/repos/RoboJackets/roboracing-software/stargazers","contributors_url":"https://api.github.com/repos/RoboJackets/roboracing-software/contributors","subscribers_url":"https://api.github.com/repos/RoboJackets/roboracing-software/subscribers","subscription_url":"https://api.github.com/repos/RoboJackets/roboracing-software/subscription","commits_url":"https://api.github.com/repos/RoboJackets/roboracing-software/commits{/sha}","git_commits_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/commits{/sha}","comments_url":"https://api.github.com/repos/RoboJackets/roboracing-software/comments{/number}","issue_comment_url":"https://api.github.com/repos/RoboJackets/roboracing-software/issues/comments{/number}","contents_url":"https://api.github.com/repos/RoboJackets/roboracing-software/contents/{+path}","compare_url":"https://api.github.com/repos/RoboJackets/roboracing-software/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RoboJackets/roboracing-software/merges","archive_url":"https://api.github.com/repos/RoboJackets/roboracing-software/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RoboJackets/roboracing-software/downloads","issues_url":"https://api.github.com/repos/RoboJackets/roboracing-software/issues{/number}","pulls_url":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls{/number}","milestones_url":"https://api.github.com/repos/RoboJackets/roboracing-software/milestones{/number}","notifications_url":"https://api.github.com/repos/RoboJackets/roboracing-software/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RoboJackets/roboracing-software/labels{/name}","releases_url":"https://api.github.com/repos/RoboJackets/roboracing-software/releases{/id}","deployments_url":"https://api.github.com/repos/RoboJackets/roboracing-software/deployments","created_at":"2014-01-06T22:43:52Z","updated_at":"2018-02-20T00:48:27Z","pushed_at":"2018-02-20T01:48:24Z","git_url":"git://github.com/RoboJackets/roboracing-software.git","ssh_url":"git@github.com:RoboJackets/roboracing-software.git","clone_url":"https://github.com/RoboJackets/roboracing-software.git","svn_url":"https://github.com/RoboJackets/roboracing-software","homepage":"http://www.robojackets.org/teams/roboracing/","size":154410,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":36,"open_issues":23,"watchers":25,"default_branch":"master"}},"base":{"label":"RoboJackets:master","ref":"master","sha":"3ed1ad602e5cab6d372dc146dcec5104c99a9679","user":{"login":"RoboJackets","id":3523251,"avatar_url":"https://avatars1.githubusercontent.com/u/3523251?v=4","gravatar_id":"","url":"https://api.github.com/users/RoboJackets","html_url":"https://github.com/RoboJackets","followers_url":"https://api.github.com/users/RoboJackets/followers","following_url":"https://api.github.com/users/RoboJackets/following{/other_user}","gists_url":"https://api.github.com/users/RoboJackets/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboJackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboJackets/subscriptions","organizations_url":"https://api.github.com/users/RoboJackets/orgs","repos_url":"https://api.github.com/users/RoboJackets/repos","events_url":"https://api.github.com/users/RoboJackets/events{/privacy}","received_events_url":"https://api.github.com/users/RoboJackets/received_events","type":"Organization","site_admin":false},"repo":{"id":15688257,"name":"roboracing-software","full_name":"RoboJackets/roboracing-software","owner":{"login":"RoboJackets","id":3523251,"avatar_url":"https://avatars1.githubusercontent.com/u/3523251?v=4","gravatar_id":"","url":"https://api.github.com/users/RoboJackets","html_url":"https://github.com/RoboJackets","followers_url":"https://api.github.com/users/RoboJackets/followers","following_url":"https://api.github.com/users/RoboJackets/following{/other_user}","gists_url":"https://api.github.com/users/RoboJackets/gists{/gist_id}","starred_url":"https://api.github.com/users/RoboJackets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RoboJackets/subscriptions","organizations_url":"https://api.github.com/users/RoboJackets/orgs","repos_url":"https://api.github.com/users/RoboJackets/repos","events_url":"https://api.github.com/users/RoboJackets/events{/privacy}","received_events_url":"https://api.github.com/users/RoboJackets/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/RoboJackets/roboracing-software","description":"ROS packages for the RoboJackets RoboRacing team.","fork":false,"url":"https://api.github.com/repos/RoboJackets/roboracing-software","forks_url":"https://api.github.com/repos/RoboJackets/roboracing-software/forks","keys_url":"https://api.github.com/repos/RoboJackets/roboracing-software/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RoboJackets/roboracing-software/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RoboJackets/roboracing-software/teams","hooks_url":"https://api.github.com/repos/RoboJackets/roboracing-software/hooks","issue_events_url":"https://api.github.com/repos/RoboJackets/roboracing-software/issues/events{/number}","events_url":"https://api.github.com/repos/RoboJackets/roboracing-software/events","assignees_url":"https://api.github.com/repos/RoboJackets/roboracing-software/assignees{/user}","branches_url":"https://api.github.com/repos/RoboJackets/roboracing-software/branches{/branch}","tags_url":"https://api.github.com/repos/RoboJackets/roboracing-software/tags","blobs_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/refs{/sha}","trees_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RoboJackets/roboracing-software/statuses/{sha}","languages_url":"https://api.github.com/repos/RoboJackets/roboracing-software/languages","stargazers_url":"https://api.github.com/repos/RoboJackets/roboracing-software/stargazers","contributors_url":"https://api.github.com/repos/RoboJackets/roboracing-software/contributors","subscribers_url":"https://api.github.com/repos/RoboJackets/roboracing-software/subscribers","subscription_url":"https://api.github.com/repos/RoboJackets/roboracing-software/subscription","commits_url":"https://api.github.com/repos/RoboJackets/roboracing-software/commits{/sha}","git_commits_url":"https://api.github.com/repos/RoboJackets/roboracing-software/git/commits{/sha}","comments_url":"https://api.github.com/repos/RoboJackets/roboracing-software/comments{/number}","issue_comment_url":"https://api.github.com/repos/RoboJackets/roboracing-software/issues/comments{/number}","contents_url":"https://api.github.com/repos/RoboJackets/roboracing-software/contents/{+path}","compare_url":"https://api.github.com/repos/RoboJackets/roboracing-software/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RoboJackets/roboracing-software/merges","archive_url":"https://api.github.com/repos/RoboJackets/roboracing-software/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RoboJackets/roboracing-software/downloads","issues_url":"https://api.github.com/repos/RoboJackets/roboracing-software/issues{/number}","pulls_url":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls{/number}","milestones_url":"https://api.github.com/repos/RoboJackets/roboracing-software/milestones{/number}","notifications_url":"https://api.github.com/repos/RoboJackets/roboracing-software/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RoboJackets/roboracing-software/labels{/name}","releases_url":"https://api.github.com/repos/RoboJackets/roboracing-software/releases{/id}","deployments_url":"https://api.github.com/repos/RoboJackets/roboracing-software/deployments","created_at":"2014-01-06T22:43:52Z","updated_at":"2018-02-20T00:48:27Z","pushed_at":"2018-02-20T01:48:24Z","git_url":"git://github.com/RoboJackets/roboracing-software.git","ssh_url":"git@github.com:RoboJackets/roboracing-software.git","clone_url":"https://github.com/RoboJackets/roboracing-software.git","svn_url":"https://github.com/RoboJackets/roboracing-software","homepage":"http://www.robojackets.org/teams/roboracing/","size":154410,"stargazers_count":25,"watchers_count":25,"language":"C++","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":36,"open_issues":23,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/134"},"html":{"href":"https://github.com/RoboJackets/roboracing-software/pull/134"},"issue":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/issues/134"},"comments":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/issues/134/comments"},"review_comments":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/134/comments"},"review_comment":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/pulls/134/commits"},"statuses":{"href":"https://api.github.com/repos/RoboJackets/roboracing-software/statuses/83ea19e62e8d7bb98cc7003a39505d2c2eaa4c54"}},"author_association":"NONE"}}
{"actor":{"display_login":"barulicm"}}