{"action":"created","issue":{"url":"https://api.github.com/repos/markets/mini_i18n/issues/3","repository_url":"https://api.github.com/repos/markets/mini_i18n","labels_url":"https://api.github.com/repos/markets/mini_i18n/issues/3/labels{/name}","comments_url":"https://api.github.com/repos/markets/mini_i18n/issues/3/comments","events_url":"https://api.github.com/repos/markets/mini_i18n/issues/3/events","html_url":"https://github.com/markets/mini_i18n/pull/3","id":347479618,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDk0NTQ4","number":3,"title":"Refactor: Code for fetching pluralization","user":{"login":"manojmj92","id":4034241,"node_id":"MDQ6VXNlcjQwMzQyNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/4034241?v=4","gravatar_id":"","url":"https://api.github.com/users/manojmj92","html_url":"https://github.com/manojmj92","followers_url":"https://api.github.com/users/manojmj92/followers","following_url":"https://api.github.com/users/manojmj92/following{/other_user}","gists_url":"https://api.github.com/users/manojmj92/gists{/gist_id}","starred_url":"https://api.github.com/users/manojmj92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/manojmj92/subscriptions","organizations_url":"https://api.github.com/users/manojmj92/orgs","repos_url":"https://api.github.com/users/manojmj92/repos","events_url":"https://api.github.com/users/manojmj92/events{/privacy}","received_events_url":"https://api.github.com/users/manojmj92/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-03T17:37:18Z","updated_at":"2018-08-06T11:27:37Z","closed_at":"2018-08-06T11:27:37Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/markets/mini_i18n/pulls/3","html_url":"https://github.com/markets/mini_i18n/pull/3","diff_url":"https://github.com/markets/mini_i18n/pull/3.diff","patch_url":"https://github.com/markets/mini_i18n/pull/3.patch"},"body":"Firstly, thanks for creating the gem. I really like how simple the `pluralization` implementation is.\r\n\r\nI was just reading through the code and found an area for improvement.\r\nIt is just a straight forward refactor.\r\n\r\nThank you."},"comment":{"url":"https://api.github.com/repos/markets/mini_i18n/issues/comments/410677305","html_url":"https://github.com/markets/mini_i18n/pull/3#issuecomment-410677305","issue_url":"https://api.github.com/repos/markets/mini_i18n/issues/3","id":410677305,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDY3NzMwNQ==","user":{"login":"markets","id":576701,"node_id":"MDQ6VXNlcjU3NjcwMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/576701?v=4","gravatar_id":"","url":"https://api.github.com/users/markets","html_url":"https://github.com/markets","followers_url":"https://api.github.com/users/markets/followers","following_url":"https://api.github.com/users/markets/following{/other_user}","gists_url":"https://api.github.com/users/markets/gists{/gist_id}","starred_url":"https://api.github.com/users/markets/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/markets/subscriptions","organizations_url":"https://api.github.com/users/markets/orgs","repos_url":"https://api.github.com/users/markets/repos","events_url":"https://api.github.com/users/markets/events{/privacy}","received_events_url":"https://api.github.com/users/markets/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T11:27:37Z","updated_at":"2018-08-06T11:27:37Z","author_association":"OWNER","body":"Hi @manojmj92 👋 and thanks a lot! I'm trying to keep code for this gem as simple and straightforward as possible. Btw, your changes are wrong, if you pass, for example `count: 5`, it will return `nil` instead of the `many` keyword. I also prefer in general the `hash + fetch` construct, but it doesn't fit/work well in this case. \r\n\r\nThat said, I realized I need to add more tests to catch those cases, because right now we are just checking 0, 1 and 2 values:\r\n\r\nhttps://github.com/markets/mini_i18n/blob/74f0d6ebaadf09eed3bfe5f5075faf06eb7abde1/spec/mini_i18n_spec.rb#L89-L93\r\n\r\nSo, CI is green, but it should fail with these changes.\r\n\r\nThanks!\r\n"}}
{"actor":{"display_login":"markets"}}