{"action":"created","comment":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/240517351","pull_request_review_id":183563298,"id":240517351,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDUxNzM1MQ==","diff_hunk":"@@ -1426,6 +1462,58 @@ def upgrade_compute_nodes(virt)\n         compute_nodes.each do |n|\n           upgrade_compute_node(controller, n)\n         end\n+      end\n+\n+      # Non-disruptive way of upgrading more compute nodes at once.\n+      # Does live-evacuation of each compute node first, then starts parallel upgrade.\n+      # Argument is list of node names.\n+      def non_disruptive_upgrade_compute_nodes(names)","path":"crowbar_framework/app/models/api/upgrade.rb","position":97,"original_position":97,"commit_id":"f39cd7c3e7b0348211e240d1d6536e5e3f00a7e1","original_commit_id":"f39cd7c3e7b0348211e240d1d6536e5e3f00a7e1","user":{"login":"hound[bot]","id":30008653,"node_id":"MDM6Qm90MzAwMDg2NTM=","avatar_url":"https://avatars1.githubusercontent.com/in/3598?v=4","gravatar_id":"","url":"https://api.github.com/users/hound%5Bbot%5D","html_url":"https://github.com/apps/hound","followers_url":"https://api.github.com/users/hound%5Bbot%5D/followers","following_url":"https://api.github.com/users/hound%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/hound%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/hound%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hound%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/hound%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/hound%5Bbot%5D/repos","events_url":"https://api.github.com/users/hound%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/hound%5Bbot%5D/received_events","type":"Bot","site_admin":false},"body":"Metrics/CyclomaticComplexity: Cyclomatic complexity for non_disruptive_upgrade_compute_nodes is too high. [9/6]<br>Metrics/PerceivedComplexity: Perceived complexity for non_disruptive_upgrade_compute_nodes is too high. [9/7]","created_at":"2018-12-11T08:52:53Z","updated_at":"2018-12-11T08:52:54Z","html_url":"https://github.com/crowbar/crowbar-core/pull/1730#discussion_r240517351","pull_request_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1730","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments/240517351"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1730#discussion_r240517351"},"pull_request":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1730"}}},"pull_request":{"url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1730","id":237594700,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NTk0NzAw","html_url":"https://github.com/crowbar/crowbar-core/pull/1730","diff_url":"https://github.com/crowbar/crowbar-core/pull/1730.diff","patch_url":"https://github.com/crowbar/crowbar-core/pull/1730.patch","issue_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1730","number":1730,"state":"open","locked":false,"title":"upgrade: Introduce parallelism into the upgrade of compute nodes","user":{"login":"jsuchome","id":910000,"node_id":"MDQ6VXNlcjkxMDAwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-12-11T08:52:36Z","updated_at":"2018-12-11T08:52:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f06e4bde59386585d1a5304178ae18b5758cd69","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rhafer","id":373399,"node_id":"MDQ6VXNlcjM3MzM5OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/373399?v=4","gravatar_id":"","url":"https://api.github.com/users/rhafer","html_url":"https://github.com/rhafer","followers_url":"https://api.github.com/users/rhafer/followers","following_url":"https://api.github.com/users/rhafer/following{/other_user}","gists_url":"https://api.github.com/users/rhafer/gists{/gist_id}","starred_url":"https://api.github.com/users/rhafer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhafer/subscriptions","organizations_url":"https://api.github.com/users/rhafer/orgs","repos_url":"https://api.github.com/users/rhafer/repos","events_url":"https://api.github.com/users/rhafer/events{/privacy}","received_events_url":"https://api.github.com/users/rhafer/received_events","type":"User","site_admin":false},{"login":"skazi0","id":2458112,"node_id":"MDQ6VXNlcjI0NTgxMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2458112?v=4","gravatar_id":"","url":"https://api.github.com/users/skazi0","html_url":"https://github.com/skazi0","followers_url":"https://api.github.com/users/skazi0/followers","following_url":"https://api.github.com/users/skazi0/following{/other_user}","gists_url":"https://api.github.com/users/skazi0/gists{/gist_id}","starred_url":"https://api.github.com/users/skazi0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skazi0/subscriptions","organizations_url":"https://api.github.com/users/skazi0/orgs","repos_url":"https://api.github.com/users/skazi0/repos","events_url":"https://api.github.com/users/skazi0/events{/privacy}","received_events_url":"https://api.github.com/users/skazi0/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":998465771,"node_id":"MDU6TGFiZWw5OTg0NjU3NzE=","url":"https://api.github.com/repos/crowbar/crowbar-core/labels/forward-port%20from%20SOC8","name":"forward-port from SOC8","color":"009800","default":false},{"id":484249902,"node_id":"MDU6TGFiZWw0ODQyNDk5MDI=","url":"https://api.github.com/repos/crowbar/crowbar-core/labels/upgrade","name":"upgrade","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1730/commits","review_comments_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1730/comments","review_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/1730/comments","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/f39cd7c3e7b0348211e240d1d6536e5e3f00a7e1","head":{"label":"jsuchome:paralel-upgrade-master","ref":"paralel-upgrade-master","sha":"f39cd7c3e7b0348211e240d1d6536e5e3f00a7e1","user":{"login":"jsuchome","id":910000,"node_id":"MDQ6VXNlcjkxMDAwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"repo":{"id":111408424,"node_id":"MDEwOlJlcG9zaXRvcnkxMTE0MDg0MjQ=","name":"crowbar-core","full_name":"jsuchome/crowbar-core","private":false,"owner":{"login":"jsuchome","id":910000,"node_id":"MDQ6VXNlcjkxMDAwMA==","avatar_url":"https://avatars2.githubusercontent.com/u/910000?v=4","gravatar_id":"","url":"https://api.github.com/users/jsuchome","html_url":"https://github.com/jsuchome","followers_url":"https://api.github.com/users/jsuchome/followers","following_url":"https://api.github.com/users/jsuchome/following{/other_user}","gists_url":"https://api.github.com/users/jsuchome/gists{/gist_id}","starred_url":"https://api.github.com/users/jsuchome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsuchome/subscriptions","organizations_url":"https://api.github.com/users/jsuchome/orgs","repos_url":"https://api.github.com/users/jsuchome/repos","events_url":"https://api.github.com/users/jsuchome/events{/privacy}","received_events_url":"https://api.github.com/users/jsuchome/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jsuchome/crowbar-core","description":"Core deployment for Crowbar","fork":true,"url":"https://api.github.com/repos/jsuchome/crowbar-core","forks_url":"https://api.github.com/repos/jsuchome/crowbar-core/forks","keys_url":"https://api.github.com/repos/jsuchome/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jsuchome/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jsuchome/crowbar-core/teams","hooks_url":"https://api.github.com/repos/jsuchome/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/jsuchome/crowbar-core/events","assignees_url":"https://api.github.com/repos/jsuchome/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/jsuchome/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/jsuchome/crowbar-core/tags","blobs_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jsuchome/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/jsuchome/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/jsuchome/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/jsuchome/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/jsuchome/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/jsuchome/crowbar-core/subscription","commits_url":"https://api.github.com/repos/jsuchome/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/jsuchome/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/jsuchome/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/jsuchome/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/jsuchome/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jsuchome/crowbar-core/merges","archive_url":"https://api.github.com/repos/jsuchome/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jsuchome/crowbar-core/downloads","issues_url":"https://api.github.com/repos/jsuchome/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/jsuchome/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/jsuchome/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/jsuchome/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jsuchome/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/jsuchome/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/jsuchome/crowbar-core/deployments","created_at":"2017-11-20T12:35:44Z","updated_at":"2017-11-20T12:35:47Z","pushed_at":"2018-12-11T08:51:53Z","git_url":"git://github.com/jsuchome/crowbar-core.git","ssh_url":"git@github.com:jsuchome/crowbar-core.git","clone_url":"https://github.com/jsuchome/crowbar-core.git","svn_url":"https://github.com/jsuchome/crowbar-core","homepage":null,"size":109376,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crowbar:master","ref":"master","sha":"7142e396ff9e9f4b5ca8d3883d90939b1895ac35","user":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"repo":{"id":39003227,"node_id":"MDEwOlJlcG9zaXRvcnkzOTAwMzIyNw==","name":"crowbar-core","full_name":"crowbar/crowbar-core","private":false,"owner":{"login":"crowbar","id":2910205,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTAyMDU=","avatar_url":"https://avatars2.githubusercontent.com/u/2910205?v=4","gravatar_id":"","url":"https://api.github.com/users/crowbar","html_url":"https://github.com/crowbar","followers_url":"https://api.github.com/users/crowbar/followers","following_url":"https://api.github.com/users/crowbar/following{/other_user}","gists_url":"https://api.github.com/users/crowbar/gists{/gist_id}","starred_url":"https://api.github.com/users/crowbar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowbar/subscriptions","organizations_url":"https://api.github.com/users/crowbar/orgs","repos_url":"https://api.github.com/users/crowbar/repos","events_url":"https://api.github.com/users/crowbar/events{/privacy}","received_events_url":"https://api.github.com/users/crowbar/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crowbar/crowbar-core","description":"Core deployment for Crowbar","fork":false,"url":"https://api.github.com/repos/crowbar/crowbar-core","forks_url":"https://api.github.com/repos/crowbar/crowbar-core/forks","keys_url":"https://api.github.com/repos/crowbar/crowbar-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crowbar/crowbar-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crowbar/crowbar-core/teams","hooks_url":"https://api.github.com/repos/crowbar/crowbar-core/hooks","issue_events_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/events{/number}","events_url":"https://api.github.com/repos/crowbar/crowbar-core/events","assignees_url":"https://api.github.com/repos/crowbar/crowbar-core/assignees{/user}","branches_url":"https://api.github.com/repos/crowbar/crowbar-core/branches{/branch}","tags_url":"https://api.github.com/repos/crowbar/crowbar-core/tags","blobs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crowbar/crowbar-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crowbar/crowbar-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/crowbar/crowbar-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crowbar/crowbar-core/statuses/{sha}","languages_url":"https://api.github.com/repos/crowbar/crowbar-core/languages","stargazers_url":"https://api.github.com/repos/crowbar/crowbar-core/stargazers","contributors_url":"https://api.github.com/repos/crowbar/crowbar-core/contributors","subscribers_url":"https://api.github.com/repos/crowbar/crowbar-core/subscribers","subscription_url":"https://api.github.com/repos/crowbar/crowbar-core/subscription","commits_url":"https://api.github.com/repos/crowbar/crowbar-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/crowbar/crowbar-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/crowbar/crowbar-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/crowbar/crowbar-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/crowbar/crowbar-core/contents/{+path}","compare_url":"https://api.github.com/repos/crowbar/crowbar-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crowbar/crowbar-core/merges","archive_url":"https://api.github.com/repos/crowbar/crowbar-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crowbar/crowbar-core/downloads","issues_url":"https://api.github.com/repos/crowbar/crowbar-core/issues{/number}","pulls_url":"https://api.github.com/repos/crowbar/crowbar-core/pulls{/number}","milestones_url":"https://api.github.com/repos/crowbar/crowbar-core/milestones{/number}","notifications_url":"https://api.github.com/repos/crowbar/crowbar-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crowbar/crowbar-core/labels{/name}","releases_url":"https://api.github.com/repos/crowbar/crowbar-core/releases{/id}","deployments_url":"https://api.github.com/repos/crowbar/crowbar-core/deployments","created_at":"2015-07-13T09:31:28Z","updated_at":"2018-12-06T18:26:53Z","pushed_at":"2018-12-11T08:52:37Z","git_url":"git://github.com/crowbar/crowbar-core.git","ssh_url":"git@github.com:crowbar/crowbar-core.git","clone_url":"https://github.com/crowbar/crowbar-core.git","svn_url":"https://github.com/crowbar/crowbar-core","homepage":null,"size":109490,"stargazers_count":13,"watchers_count":13,"language":"Ruby","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":60,"license":null,"forks":60,"open_issues":60,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1730"},"html":{"href":"https://github.com/crowbar/crowbar-core/pull/1730"},"issue":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1730"},"comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/issues/1730/comments"},"review_comments":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1730/comments"},"review_comment":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crowbar/crowbar-core/pulls/1730/commits"},"statuses":{"href":"https://api.github.com/repos/crowbar/crowbar-core/statuses/f39cd7c3e7b0348211e240d1d6536e5e3f00a7e1"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"hound"}}