{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/219715850","pull_request_review_id":157956319,"id":219715850,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxOTcxNTg1MA==","diff_hunk":"@@ -2,16 +2,16 @@\n \n buildGoPackage rec {\n   name = \"godef-${version}\";\n-  version = \"20170920-${stdenv.lib.strings.substring 0 7 rev}\";\n-  rev = \"b692db1de5229d4248e23c41736b431eb665615d\";\n+  version = \"20180911-${stdenv.lib.strings.substring 0 7 rev}\";","path":"pkgs/development/tools/godef/default.nix","position":6,"original_position":6,"commit_id":"90b201e2a67be546e0a7d8bbe6626b5bf6fb1777","original_commit_id":"90b201e2a67be546e0a7d8bbe6626b5bf6fb1777","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"Please remove the hash from the version number.","created_at":"2018-09-23T23:38:32Z","updated_at":"2018-09-23T23:38:33Z","html_url":"https://github.com/NixOS/nixpkgs/pull/47254#discussion_r219715850","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47254","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/219715850"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/47254#discussion_r219715850"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47254"}}},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47254","id":217533675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3NTMzNjc1","html_url":"https://github.com/NixOS/nixpkgs/pull/47254","diff_url":"https://github.com/NixOS/nixpkgs/pull/47254.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/47254.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47254","number":47254,"state":"open","locked":false,"title":"Update ycmd for go 1.11","user":{"login":"cstrahan","id":143982,"node_id":"MDQ6VXNlcjE0Mzk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/143982?v=4","gravatar_id":"","url":"https://api.github.com/users/cstrahan","html_url":"https://github.com/cstrahan","followers_url":"https://api.github.com/users/cstrahan/followers","following_url":"https://api.github.com/users/cstrahan/following{/other_user}","gists_url":"https://api.github.com/users/cstrahan/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrahan/subscriptions","organizations_url":"https://api.github.com/users/cstrahan/orgs","repos_url":"https://api.github.com/users/cstrahan/repos","events_url":"https://api.github.com/users/cstrahan/events{/privacy}","received_events_url":"https://api.github.com/users/cstrahan/received_events","type":"User","site_admin":false},"body":"###### Motivation for this change\r\n\r\nThis updates `godef` and `ycmd` so that YouCompleteMe can work with Go 1.11 source.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [x] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [x] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [x] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [x] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n","created_at":"2018-09-23T22:01:30Z","updated_at":"2018-09-23T23:38:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":292322837,"node_id":"MDU6TGFiZWwyOTIzMjI4Mzc=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/2.status:%20merge%20conflict","name":"2.status: merge conflict","color":"e6e6e6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47254/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47254/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/47254/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/90b201e2a67be546e0a7d8bbe6626b5bf6fb1777","head":{"label":"cstrahan:update-ycmd-for-go-1.11","ref":"update-ycmd-for-go-1.11","sha":"90b201e2a67be546e0a7d8bbe6626b5bf6fb1777","user":{"login":"cstrahan","id":143982,"node_id":"MDQ6VXNlcjE0Mzk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/143982?v=4","gravatar_id":"","url":"https://api.github.com/users/cstrahan","html_url":"https://github.com/cstrahan","followers_url":"https://api.github.com/users/cstrahan/followers","following_url":"https://api.github.com/users/cstrahan/following{/other_user}","gists_url":"https://api.github.com/users/cstrahan/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrahan/subscriptions","organizations_url":"https://api.github.com/users/cstrahan/orgs","repos_url":"https://api.github.com/users/cstrahan/repos","events_url":"https://api.github.com/users/cstrahan/events{/privacy}","received_events_url":"https://api.github.com/users/cstrahan/received_events","type":"User","site_admin":false},"repo":{"id":19142875,"node_id":"MDEwOlJlcG9zaXRvcnkxOTE0Mjg3NQ==","name":"nixpkgs","full_name":"cstrahan/nixpkgs","private":false,"owner":{"login":"cstrahan","id":143982,"node_id":"MDQ6VXNlcjE0Mzk4Mg==","avatar_url":"https://avatars0.githubusercontent.com/u/143982?v=4","gravatar_id":"","url":"https://api.github.com/users/cstrahan","html_url":"https://github.com/cstrahan","followers_url":"https://api.github.com/users/cstrahan/followers","following_url":"https://api.github.com/users/cstrahan/following{/other_user}","gists_url":"https://api.github.com/users/cstrahan/gists{/gist_id}","starred_url":"https://api.github.com/users/cstrahan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstrahan/subscriptions","organizations_url":"https://api.github.com/users/cstrahan/orgs","repos_url":"https://api.github.com/users/cstrahan/repos","events_url":"https://api.github.com/users/cstrahan/events{/privacy}","received_events_url":"https://api.github.com/users/cstrahan/received_events","type":"User","site_admin":false},"html_url":"https://github.com/cstrahan/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/cstrahan/nixpkgs","forks_url":"https://api.github.com/repos/cstrahan/nixpkgs/forks","keys_url":"https://api.github.com/repos/cstrahan/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cstrahan/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cstrahan/nixpkgs/teams","hooks_url":"https://api.github.com/repos/cstrahan/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/cstrahan/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/cstrahan/nixpkgs/events","assignees_url":"https://api.github.com/repos/cstrahan/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/cstrahan/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/cstrahan/nixpkgs/tags","blobs_url":"https://api.github.com/repos/cstrahan/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cstrahan/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cstrahan/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/cstrahan/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cstrahan/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/cstrahan/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/cstrahan/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/cstrahan/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/cstrahan/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/cstrahan/nixpkgs/subscription","commits_url":"https://api.github.com/repos/cstrahan/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/cstrahan/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/cstrahan/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/cstrahan/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/cstrahan/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/cstrahan/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cstrahan/nixpkgs/merges","archive_url":"https://api.github.com/repos/cstrahan/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cstrahan/nixpkgs/downloads","issues_url":"https://api.github.com/repos/cstrahan/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/cstrahan/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/cstrahan/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/cstrahan/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cstrahan/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/cstrahan/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/cstrahan/nixpkgs/deployments","created_at":"2014-04-25T10:46:40Z","updated_at":"2017-02-04T00:20:52Z","pushed_at":"2018-09-23T21:59:33Z","git_url":"git://github.com/cstrahan/nixpkgs.git","ssh_url":"git@github.com:cstrahan/nixpkgs.git","clone_url":"https://github.com/cstrahan/nixpkgs.git","svn_url":"https://github.com/cstrahan/nixpkgs","homepage":null,"size":780094,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:master","ref":"master","sha":"104014c6bad2ea682ec8e9fdbe8ab460a64a6274","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","private":false,"owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-09-23T22:08:37Z","pushed_at":"2018-09-23T22:54:41Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":857496,"stargazers_count":2822,"watchers_count":2822,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3034,"mirror_url":null,"archived":false,"open_issues_count":3354,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3034,"open_issues":3354,"watchers":2822,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47254"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/47254"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/47254"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/47254/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47254/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/47254/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/90b201e2a67be546e0a7d8bbe6626b5bf6fb1777"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mic92"}}