{"action":"created","issue":{"url":"https://api.github.com/repos/openssl/openssl/issues/5466","repository_url":"https://api.github.com/repos/openssl/openssl","labels_url":"https://api.github.com/repos/openssl/openssl/issues/5466/labels{/name}","comments_url":"https://api.github.com/repos/openssl/openssl/issues/5466/comments","events_url":"https://api.github.com/repos/openssl/openssl/issues/5466/events","html_url":"https://github.com/openssl/openssl/pull/5466","id":300258800,"number":5466,"title":"rec_layer_s3.c:ssl3_read_bytes: Problems with 2-way shutdown if other side manages to send application data before receiving close notify","user":{"login":"vpodobaev","id":36851508,"avatar_url":"https://avatars0.githubusercontent.com/u/36851508?v=4","gravatar_id":"","url":"https://api.github.com/users/vpodobaev","html_url":"https://github.com/vpodobaev","followers_url":"https://api.github.com/users/vpodobaev/followers","following_url":"https://api.github.com/users/vpodobaev/following{/other_user}","gists_url":"https://api.github.com/users/vpodobaev/gists{/gist_id}","starred_url":"https://api.github.com/users/vpodobaev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vpodobaev/subscriptions","organizations_url":"https://api.github.com/users/vpodobaev/orgs","repos_url":"https://api.github.com/users/vpodobaev/repos","events_url":"https://api.github.com/users/vpodobaev/events{/privacy}","received_events_url":"https://api.github.com/users/vpodobaev/received_events","type":"User","site_admin":false},"labels":[{"id":431503371,"url":"https://api.github.com/repos/openssl/openssl/labels/need-cla","name":"need-cla","color":"E11D21","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-26T14:28:49Z","updated_at":"2018-02-27T11:18:42Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/openssl/openssl/pulls/5466","html_url":"https://github.com/openssl/openssl/pull/5466","diff_url":"https://github.com/openssl/openssl/pull/5466.diff","patch_url":"https://github.com/openssl/openssl/pull/5466.patch"},"body":"We found a problem. Steps to reproduce:\r\n1) Make TLS 1.x connection via BIOs (not sockets). Use 4 BIOs: ServerOut, ServerIn, ClientOut, ClientIn.\r\n2) Perform handshake, exchange data via BIOs. (ClientOut->ServerIn, ServerOut->ClientIn, ...).\r\n3) Client performs SSL_shutdown (ret:0).\r\n4) Server performs SSL_write with some data.\r\n5) ServerOut -> ClientIn\r\n6) ClientOut -> ServerIn\r\n7) Server:SSL_read (connection closed).\r\n8) ServerOut -> ClientIn\r\n9) Client:SSL_shutdown. Problem! Returns -1 (instead of 1),\r\nSSL_get_error returns SSL_ERROR_SYSCALL.\r\n\r\nThe problem is that ssl3_read_bytes doesn't handle app_data records correctly when it is\r\nwaiting for shutdown acknowledge.\r\n\r\nOur patch seem to fix the problem, but we are not sure that it doesn't break anything else.\r\n\r\nThank you!\r\n\r\n\r\n##### Checklist\r\n"},"comment":{"url":"https://api.github.com/repos/openssl/openssl/issues/comments/368841487","html_url":"https://github.com/openssl/openssl/pull/5466#issuecomment-368841487","issue_url":"https://api.github.com/repos/openssl/openssl/issues/5466","id":368841487,"user":{"login":"bernd-edlinger","id":17638929,"avatar_url":"https://avatars2.githubusercontent.com/u/17638929?v=4","gravatar_id":"","url":"https://api.github.com/users/bernd-edlinger","html_url":"https://github.com/bernd-edlinger","followers_url":"https://api.github.com/users/bernd-edlinger/followers","following_url":"https://api.github.com/users/bernd-edlinger/following{/other_user}","gists_url":"https://api.github.com/users/bernd-edlinger/gists{/gist_id}","starred_url":"https://api.github.com/users/bernd-edlinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bernd-edlinger/subscriptions","organizations_url":"https://api.github.com/users/bernd-edlinger/orgs","repos_url":"https://api.github.com/users/bernd-edlinger/repos","events_url":"https://api.github.com/users/bernd-edlinger/events{/privacy}","received_events_url":"https://api.github.com/users/bernd-edlinger/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T11:18:42Z","updated_at":"2018-02-27T11:18:42Z","author_association":"CONTRIBUTOR","body":"What happens to the received data in this case?"}}
{"actor":{"display_login":"bernd-edlinger"}}