{"action":"created","issue":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7273","repository_url":"https://api.github.com/repos/mapbox/mapbox-gl-js","labels_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7273/labels{/name}","comments_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7273/comments","events_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7273/events","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/7273","id":359547157,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1MDEzNTI1","number":7273,"title":"fix missing repeats of CanvasSource when it crosses the antimeridian","user":{"login":"ansis","id":1421652,"node_id":"MDQ6VXNlcjE0MjE2NTI=","avatar_url":"https://avatars0.githubusercontent.com/u/1421652?v=4","gravatar_id":"","url":"https://api.github.com/users/ansis","html_url":"https://github.com/ansis","followers_url":"https://api.github.com/users/ansis/followers","following_url":"https://api.github.com/users/ansis/following{/other_user}","gists_url":"https://api.github.com/users/ansis/gists{/gist_id}","starred_url":"https://api.github.com/users/ansis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ansis/subscriptions","organizations_url":"https://api.github.com/users/ansis/orgs","repos_url":"https://api.github.com/users/ansis/repos","events_url":"https://api.github.com/users/ansis/events{/privacy}","received_events_url":"https://api.github.com/users/ansis/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-09-12T15:56:12Z","updated_at":"2018-09-12T17:45:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/pulls/7273","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/7273","diff_url":"https://github.com/mapbox/mapbox-gl-js/pull/7273.diff","patch_url":"https://github.com/mapbox/mapbox-gl-js/pull/7273.patch"},"body":"This fixes #7271 by including an extra copy of image sources and canvas sources on either side of the world. In almost all cases this extra copy is necessary, but it shouldn't add any overhead because rendering two offscreen triangles should be negligible.\r\n\r\nIt might be slightly nicer to have an approach that actually calculates how many copies we need to render but I think this would be significantly more complex and probably slower.\r\n\r\n## Launch Checklist\r\n\r\n<!-- Thanks for the PR! Feel free to add or remove items from the checklist. -->\r\n\r\n<!-- If your PR affects documentation relevant to the currently released version, please use `mb-pages` as the base branch. See https://github.com/mapbox/mapbox-gl-js/blob/master/docs/README.md#committing-and-publishing-documentation -->\r\n\r\n - [x] briefly describe the changes in this PR\r\n - [x] write tests for all new functionality\r\n - [ ] document any changes to public APIs\r\n - [ ] post benchmark scores\r\n - [x] manually test the debug page\r\n - [ ] tagged `@mapbox/studio` and/or `@mapbox/maps-design` if this PR includes style spec changes\r\n"},"comment":{"url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/comments/420737456","html_url":"https://github.com/mapbox/mapbox-gl-js/pull/7273#issuecomment-420737456","issue_url":"https://api.github.com/repos/mapbox/mapbox-gl-js/issues/7273","id":420737456,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDczNzQ1Ng==","user":{"login":"ryanhamley","id":4523080,"node_id":"MDQ6VXNlcjQ1MjMwODA=","avatar_url":"https://avatars1.githubusercontent.com/u/4523080?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanhamley","html_url":"https://github.com/ryanhamley","followers_url":"https://api.github.com/users/ryanhamley/followers","following_url":"https://api.github.com/users/ryanhamley/following{/other_user}","gists_url":"https://api.github.com/users/ryanhamley/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanhamley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanhamley/subscriptions","organizations_url":"https://api.github.com/users/ryanhamley/orgs","repos_url":"https://api.github.com/users/ryanhamley/repos","events_url":"https://api.github.com/users/ryanhamley/events{/privacy}","received_events_url":"https://api.github.com/users/ryanhamley/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T17:45:37Z","updated_at":"2018-09-12T17:45:37Z","author_association":"CONTRIBUTOR","body":"This is probably a major edge case, but I noticed this behavior while just randomly playing around with the map.\r\n\r\n![screen shot 2018-09-12 at 10 27 22 am](https://user-images.githubusercontent.com/4523080/45443080-92cc6680-b678-11e8-96fb-fa9c7b1c66e5.png)\r\n\r\n![screen shot 2018-09-12 at 10 43 47 am](https://user-images.githubusercontent.com/4523080/45443231-f5256700-b678-11e8-86b6-87517722e78e.png)\r\n\r\n\r\nIn fact, it happens on `master` too so it's an existing issue that is not tied to this change. Should this be addressed with this change or maybe just ticket it and investigate it later?"}}
{"actor":{"display_login":"ryanhamley"}}