{"comment":{"url":"https://api.github.com/repos/macports/macports-ports/comments/31770968","html_url":"https://github.com/macports/macports-ports/commit/662fa198e95f3b4afcab9f9edf111b320ec122d8#commitcomment-31770968","id":31770968,"node_id":"MDEzOkNvbW1pdENvbW1lbnQzMTc3MDk2OA==","user":{"login":"RJVB","id":1756884,"node_id":"MDQ6VXNlcjE3NTY4ODQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1756884?v=4","gravatar_id":"","url":"https://api.github.com/users/RJVB","html_url":"https://github.com/RJVB","followers_url":"https://api.github.com/users/RJVB/followers","following_url":"https://api.github.com/users/RJVB/following{/other_user}","gists_url":"https://api.github.com/users/RJVB/gists{/gist_id}","starred_url":"https://api.github.com/users/RJVB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJVB/subscriptions","organizations_url":"https://api.github.com/users/RJVB/orgs","repos_url":"https://api.github.com/users/RJVB/repos","events_url":"https://api.github.com/users/RJVB/events{/privacy}","received_events_url":"https://api.github.com/users/RJVB/received_events","type":"User","site_admin":false},"position":44,"line":34,"path":"_resources/port1.0/group/legacysupport-1.0.tcl","commit_id":"662fa198e95f3b4afcab9f9edf111b320ec122d8","created_at":"2018-12-24T10:13:39Z","updated_at":"2018-12-24T10:13:39Z","author_association":"CONTRIBUTOR","body":"@cjones051073 & @kencu : shouldn't line 20 add to `configure.cxxflags` instead of `configure.cppflags`? The corresponding env. var. suggests that the intention is to add the search path to the C++ compiler options, not the preprocessor options (and indeed, looking at the code I wondered why C++ was being excluded).\r\nShouldn't there also be the ObjC variants, just to be certain?\r\n\r\nAnd also, maybe use -isystem instead of -I?"}}
{"actor":{"display_login":"RJVB"}}