{"action":"created","comment":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/221581551","pull_request_review_id":160261276,"id":221581551,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTU4MTU1MQ==","diff_hunk":"@@ -141,13 +141,13 @@ IPropertyTree* Hardware::addComputer(IPropertyTree *params)\n \n   StringBuffer sbName;\n   sbName.clear();\n-  if ((computerName == NULL) || (computerName == \"\"))\n+  if (!computerName || !*computerName)\n   {\n-    if (ip && (ip == \".\"))\n+    if (ip && !strcmp(ip, \".\"))","path":"deployment/configenv/xml_jlibpt/Hardware.cpp","position":20,"original_position":20,"commit_id":"5df517f06c0dbdcad1b6af7ebf5e064da9b89016","original_commit_id":"5df517f06c0dbdcad1b6af7ebf5e064da9b89016","user":{"login":"xwang2713","id":4911061,"node_id":"MDQ6VXNlcjQ5MTEwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4911061?v=4","gravatar_id":"","url":"https://api.github.com/users/xwang2713","html_url":"https://github.com/xwang2713","followers_url":"https://api.github.com/users/xwang2713/followers","following_url":"https://api.github.com/users/xwang2713/following{/other_user}","gists_url":"https://api.github.com/users/xwang2713/gists{/gist_id}","starred_url":"https://api.github.com/users/xwang2713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwang2713/subscriptions","organizations_url":"https://api.github.com/users/xwang2713/orgs","repos_url":"https://api.github.com/users/xwang2713/repos","events_url":"https://api.github.com/users/xwang2713/events{/privacy}","received_events_url":"https://api.github.com/users/xwang2713/received_events","type":"User","site_admin":false},"body":"Just want set Hardware/Computer name attribute. For the difference between \".\" and \"localhost\" and thought IpAddress doesn't handle \".\". After reading the IpAddress it does look up host ip with \".\". I will make the change. Thanks","created_at":"2018-10-01T11:54:16Z","updated_at":"2018-10-01T11:54:16Z","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/11755#discussion_r221581551","pull_request_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11755","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments/221581551"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/11755#discussion_r221581551"},"pull_request":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11755"}},"in_reply_to_id":220559594},"pull_request":{"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11755","id":218051647,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE4MDUxNjQ3","html_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/11755","diff_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/11755.diff","patch_url":"https://github.com/hpcc-systems/HPCC-Platform/pull/11755.patch","issue_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/11755","number":11755,"state":"open","locked":false,"title":"HPCC-20507  Fix invalid comparison","user":{"login":"xwang2713","id":4911061,"node_id":"MDQ6VXNlcjQ5MTEwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4911061?v=4","gravatar_id":"","url":"https://api.github.com/users/xwang2713","html_url":"https://github.com/xwang2713","followers_url":"https://api.github.com/users/xwang2713/followers","following_url":"https://api.github.com/users/xwang2713/following{/other_user}","gists_url":"https://api.github.com/users/xwang2713/gists{/gist_id}","starred_url":"https://api.github.com/users/xwang2713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwang2713/subscriptions","organizations_url":"https://api.github.com/users/xwang2713/orgs","repos_url":"https://api.github.com/users/xwang2713/repos","events_url":"https://api.github.com/users/xwang2713/events{/privacy}","received_events_url":"https://api.github.com/users/xwang2713/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Xiaoming Wang <xiaoming.wang@lexisnexi.com> \r\n@kenrowland please help reviewing\r\n\r\n\r\n## Type of change:\r\n- [x] This change is a bug fix (non-breaking change which fixes an issue).\r\n- [ ] This change is a new feature (non-breaking change which adds functionality).\r\n- [ ] This change improves the code (refactor or other change that does not change the functionality)\r\n- [ ] This change fixes warnings (the fix does not alter the functionality or the generated code)\r\n- [ ] This change is a breaking change (fix or feature that will cause existing behavior to change).\r\n- [ ] This change alters the query API (existing queries will have to be recompiled)\r\n\r\n## Checklist:\r\n- [x] My code follows the code style of this project.\r\n  - [ ] My code does not create any new warnings from compiler, build system, or lint.\r\n- [ ] The commit message is properly formatted and free of typos.\r\n  - [ ] The commit message title makes sense in a changelog, by itself.\r\n  - [ ] The commit is signed.\r\n- [ ] My change requires a change to the documentation.\r\n  - [ ] I have updated the documentation accordingly, or...\r\n  - [ ] I have created a JIRA ticket to update the documentation.\r\n  - [ ] Any new interfaces or exported functions are appropriately commented.\r\n- [ ] I have read the CONTRIBUTORS document.\r\n- [ ] The change has been fully tested:\r\n  - [ ] I have added tests to cover my changes.\r\n  - [ ] All new and existing tests passed.\r\n  - [ ] I have checked that this change does not introduce memory leaks.\r\n  - [ ] I have used Valgrind or similar tools to check for potential issues.\r\n- [ ] I have given due consideration to all of the following potential concerns:\r\n  - [ ] Scalability\r\n  - [ ] Performance\r\n  - [ ] Security\r\n  - [ ] Thread-safety\r\n  - [ ] Premature optimization\r\n  - [ ] Existing deployed queries will not be broken\r\n  - [ ] This change fixes the problem, not just the symptom\r\n  - [ ] The target branch of this pull request is appropriate for such a change.\r\n- [ ] There are no similar instances of the same problem that should be addressed\r\n  - [ ] I have addressed them here\r\n  - [ ] I have raised JIRA issues to address them separately\r\n- [ ] This is a user interface / front-end modification\r\n  - [ ] I have tested my changes in multiple modern browsers\r\n  - [ ] The component(s) render as expected\r\n\r\n## Testing:\r\n<!-- Please describe how this change has been tested.-->\r\nTest build: http://10.240.32.243/view/custom/job/CE-Platform-JIRA-HPCC-20507/\r\n<!-- Thank you for taking the time to submit this pull request and to answer all of the above-->\r\n","created_at":"2018-09-25T16:57:00Z","updated_at":"2018-10-01T11:54:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"be6746a3af10ef3ffe72df0178679940333daea5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11755/commits","review_comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11755/comments","review_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/11755/comments","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/5df517f06c0dbdcad1b6af7ebf5e064da9b89016","head":{"label":"xwang2713:HPCC_20507-Invalid-comparison","ref":"HPCC_20507-Invalid-comparison","sha":"5df517f06c0dbdcad1b6af7ebf5e064da9b89016","user":{"login":"xwang2713","id":4911061,"node_id":"MDQ6VXNlcjQ5MTEwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4911061?v=4","gravatar_id":"","url":"https://api.github.com/users/xwang2713","html_url":"https://github.com/xwang2713","followers_url":"https://api.github.com/users/xwang2713/followers","following_url":"https://api.github.com/users/xwang2713/following{/other_user}","gists_url":"https://api.github.com/users/xwang2713/gists{/gist_id}","starred_url":"https://api.github.com/users/xwang2713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwang2713/subscriptions","organizations_url":"https://api.github.com/users/xwang2713/orgs","repos_url":"https://api.github.com/users/xwang2713/repos","events_url":"https://api.github.com/users/xwang2713/events{/privacy}","received_events_url":"https://api.github.com/users/xwang2713/received_events","type":"User","site_admin":false},"repo":{"id":11128869,"node_id":"MDEwOlJlcG9zaXRvcnkxMTEyODg2OQ==","name":"HPCC-Platform","full_name":"xwang2713/HPCC-Platform","private":false,"owner":{"login":"xwang2713","id":4911061,"node_id":"MDQ6VXNlcjQ5MTEwNjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4911061?v=4","gravatar_id":"","url":"https://api.github.com/users/xwang2713","html_url":"https://github.com/xwang2713","followers_url":"https://api.github.com/users/xwang2713/followers","following_url":"https://api.github.com/users/xwang2713/following{/other_user}","gists_url":"https://api.github.com/users/xwang2713/gists{/gist_id}","starred_url":"https://api.github.com/users/xwang2713/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xwang2713/subscriptions","organizations_url":"https://api.github.com/users/xwang2713/orgs","repos_url":"https://api.github.com/users/xwang2713/repos","events_url":"https://api.github.com/users/xwang2713/events{/privacy}","received_events_url":"https://api.github.com/users/xwang2713/received_events","type":"User","site_admin":false},"html_url":"https://github.com/xwang2713/HPCC-Platform","description":"IMPORTANT - Issue tracking has been migrated to JIRA - use your github ID and password reset mechanism to log in","fork":true,"url":"https://api.github.com/repos/xwang2713/HPCC-Platform","forks_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/xwang2713/HPCC-Platform/deployments","created_at":"2013-07-02T16:04:17Z","updated_at":"2018-09-28T00:14:18Z","pushed_at":"2018-09-30T04:24:43Z","git_url":"git://github.com/xwang2713/HPCC-Platform.git","ssh_url":"git@github.com:xwang2713/HPCC-Platform.git","clone_url":"https://github.com/xwang2713/HPCC-Platform.git","svn_url":"https://github.com/xwang2713/HPCC-Platform","homepage":"track.hpccsystems.com","size":223923,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hpcc-systems:master","ref":"master","sha":"a947c0a93e6ce9452e3e0797587f5226f1a2ddad","user":{"login":"hpcc-systems","id":900867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMDg2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/900867?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"repo":{"id":2030681,"node_id":"MDEwOlJlcG9zaXRvcnkyMDMwNjgx","name":"HPCC-Platform","full_name":"hpcc-systems/HPCC-Platform","private":false,"owner":{"login":"hpcc-systems","id":900867,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMDg2Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/900867?v=4","gravatar_id":"","url":"https://api.github.com/users/hpcc-systems","html_url":"https://github.com/hpcc-systems","followers_url":"https://api.github.com/users/hpcc-systems/followers","following_url":"https://api.github.com/users/hpcc-systems/following{/other_user}","gists_url":"https://api.github.com/users/hpcc-systems/gists{/gist_id}","starred_url":"https://api.github.com/users/hpcc-systems/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hpcc-systems/subscriptions","organizations_url":"https://api.github.com/users/hpcc-systems/orgs","repos_url":"https://api.github.com/users/hpcc-systems/repos","events_url":"https://api.github.com/users/hpcc-systems/events{/privacy}","received_events_url":"https://api.github.com/users/hpcc-systems/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hpcc-systems/HPCC-Platform","description":"HPCC Systems (High Performance Computing Cluster) is an open source, massive parallel-processing computing platform for big data processing and analytics.","fork":false,"url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform","forks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/forks","keys_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/teams","hooks_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/hooks","issue_events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/events{/number}","events_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/events","assignees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/assignees{/user}","branches_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/branches{/branch}","tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/tags","blobs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/{sha}","languages_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/languages","stargazers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/stargazers","contributors_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contributors","subscribers_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscribers","subscription_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/subscription","commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/contents/{+path}","compare_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/merges","archive_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/downloads","issues_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues{/number}","pulls_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls{/number}","milestones_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/milestones{/number}","notifications_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/labels{/name}","releases_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/releases{/id}","deployments_url":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/deployments","created_at":"2011-07-11T14:29:51Z","updated_at":"2018-10-01T11:45:29Z","pushed_at":"2018-10-01T11:45:22Z","git_url":"git://github.com/hpcc-systems/HPCC-Platform.git","ssh_url":"git@github.com:hpcc-systems/HPCC-Platform.git","clone_url":"https://github.com/hpcc-systems/HPCC-Platform.git","svn_url":"https://github.com/hpcc-systems/HPCC-Platform","homepage":"http://hpccsystems.com","size":195392,"stargazers_count":352,"watchers_count":352,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":207,"mirror_url":null,"archived":false,"open_issues_count":446,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":207,"open_issues":446,"watchers":352,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11755"},"html":{"href":"https://github.com/hpcc-systems/HPCC-Platform/pull/11755"},"issue":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/11755"},"comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/issues/11755/comments"},"review_comments":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11755/comments"},"review_comment":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/pulls/11755/commits"},"statuses":{"href":"https://api.github.com/repos/hpcc-systems/HPCC-Platform/statuses/5df517f06c0dbdcad1b6af7ebf5e064da9b89016"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"xwang2713"}}