{"action":"created","comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/227192590","pull_request_review_id":167175290,"id":227192590,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzE5MjU5MA==","diff_hunk":"@@ -10,6 +10,8 @@\n  */\n LocalCoords::LocalCoords(double x, double y, double z, bool first) {\n   _coords.setCoords(x, y, z);\n+  _phi = 0.;\n+  _polar = 0.;","path":"src/LocalCoords.cpp","position":5,"original_position":5,"commit_id":"7f0043a01296c69858905156b9cfc942fd240c95","original_commit_id":"96d813cbd47d345b9c420f0e51e534cdc50252fe","user":{"login":"wuwenbin2006","id":34581354,"node_id":"MDQ6VXNlcjM0NTgxMzU0","avatar_url":"https://avatars2.githubusercontent.com/u/34581354?v=4","gravatar_id":"","url":"https://api.github.com/users/wuwenbin2006","html_url":"https://github.com/wuwenbin2006","followers_url":"https://api.github.com/users/wuwenbin2006/followers","following_url":"https://api.github.com/users/wuwenbin2006/following{/other_user}","gists_url":"https://api.github.com/users/wuwenbin2006/gists{/gist_id}","starred_url":"https://api.github.com/users/wuwenbin2006/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wuwenbin2006/subscriptions","organizations_url":"https://api.github.com/users/wuwenbin2006/orgs","repos_url":"https://api.github.com/users/wuwenbin2006/repos","events_url":"https://api.github.com/users/wuwenbin2006/events{/privacy}","received_events_url":"https://api.github.com/users/wuwenbin2006/received_events","type":"User","site_admin":false},"body":"For 2D case, better to set pi/2 default.","created_at":"2018-10-23T01:30:17Z","updated_at":"2018-10-23T01:30:17Z","html_url":"https://github.com/mit-crpg/OpenMOC/pull/366#discussion_r227192590","pull_request_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/366","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments/227192590"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/366#discussion_r227192590"},"pull_request":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/366"}}},"pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/366","id":224146928,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTQ2OTI4","html_url":"https://github.com/mit-crpg/OpenMOC/pull/366","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/366.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/366.patch","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/366","number":366,"state":"open","locked":false,"title":"Adding OpenMC MGXS capability to 3D-MOC","user":{"login":"GiudGiud","id":25037151,"node_id":"MDQ6VXNlcjI1MDM3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/25037151?v=4","gravatar_id":"","url":"https://api.github.com/users/GiudGiud","html_url":"https://github.com/GiudGiud","followers_url":"https://api.github.com/users/GiudGiud/followers","following_url":"https://api.github.com/users/GiudGiud/following{/other_user}","gists_url":"https://api.github.com/users/GiudGiud/gists{/gist_id}","starred_url":"https://api.github.com/users/GiudGiud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiudGiud/subscriptions","organizations_url":"https://api.github.com/users/GiudGiud/orgs","repos_url":"https://api.github.com/users/GiudGiud/repos","events_url":"https://api.github.com/users/GiudGiud/events{/privacy}","received_events_url":"https://api.github.com/users/GiudGiud/received_events","type":"User","site_admin":false},"body":"This PR fixes the capability to load MGXS cross sections from OpenMC.\r\nIt also includes a few bug fixes (issue #226 is almost fully addressed) and a lot of fixed typos.\r\n\r\n- getMinDistance() returns the minimum distance to any surface used to define a Cell. This is the intended use. A shift to a routine that would get the distance to leave the cell (can be higher if the cell's region is a Union of Halfspace for example) may be desirable.\r\n- A number of routines are overloaded to support using localCoords or Point, azimuthal, polar angles. This is not a big issue but we might want to trim that down to reduce clutter\r\n\r\nStill to do\r\n- [ ] Add a test for reading a geometry from a .geo file\r\n- [ ] Add a test for a complex cell\r\n\r\nAcknowledgments : Most of the added code for Regions came from develop and was written by @wbinventor ","created_at":"2018-10-19T01:39:09Z","updated_at":"2018-10-23T01:30:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f29ad8f7d740a3618f906c5b37b9ff105dfcb03","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":48078506,"node_id":"MDU6TGFiZWw0ODA3ODUwNg==","url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels/Geometry","name":"Geometry","color":"CD6600","default":false},{"id":1097317329,"node_id":"MDU6TGFiZWwxMDk3MzE3MzI5","url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels/MGXS","name":"MGXS","color":"bfdadc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/366/commits","review_comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/366/comments","review_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/366/comments","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/7f0043a01296c69858905156b9cfc942fd240c95","head":{"label":"GiudGiud:PR_MGXS","ref":"PR_MGXS","sha":"7f0043a01296c69858905156b9cfc942fd240c95","user":{"login":"GiudGiud","id":25037151,"node_id":"MDQ6VXNlcjI1MDM3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/25037151?v=4","gravatar_id":"","url":"https://api.github.com/users/GiudGiud","html_url":"https://github.com/GiudGiud","followers_url":"https://api.github.com/users/GiudGiud/followers","following_url":"https://api.github.com/users/GiudGiud/following{/other_user}","gists_url":"https://api.github.com/users/GiudGiud/gists{/gist_id}","starred_url":"https://api.github.com/users/GiudGiud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiudGiud/subscriptions","organizations_url":"https://api.github.com/users/GiudGiud/orgs","repos_url":"https://api.github.com/users/GiudGiud/repos","events_url":"https://api.github.com/users/GiudGiud/events{/privacy}","received_events_url":"https://api.github.com/users/GiudGiud/received_events","type":"User","site_admin":false},"repo":{"id":86852717,"node_id":"MDEwOlJlcG9zaXRvcnk4Njg1MjcxNw==","name":"OpenMOC","full_name":"GiudGiud/OpenMOC","private":false,"owner":{"login":"GiudGiud","id":25037151,"node_id":"MDQ6VXNlcjI1MDM3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/25037151?v=4","gravatar_id":"","url":"https://api.github.com/users/GiudGiud","html_url":"https://github.com/GiudGiud","followers_url":"https://api.github.com/users/GiudGiud/followers","following_url":"https://api.github.com/users/GiudGiud/following{/other_user}","gists_url":"https://api.github.com/users/GiudGiud/gists{/gist_id}","starred_url":"https://api.github.com/users/GiudGiud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiudGiud/subscriptions","organizations_url":"https://api.github.com/users/GiudGiud/orgs","repos_url":"https://api.github.com/users/GiudGiud/repos","events_url":"https://api.github.com/users/GiudGiud/events{/privacy}","received_events_url":"https://api.github.com/users/GiudGiud/received_events","type":"User","site_admin":false},"html_url":"https://github.com/GiudGiud/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":true,"url":"https://api.github.com/repos/GiudGiud/OpenMOC","forks_url":"https://api.github.com/repos/GiudGiud/OpenMOC/forks","keys_url":"https://api.github.com/repos/GiudGiud/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/GiudGiud/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/GiudGiud/OpenMOC/teams","hooks_url":"https://api.github.com/repos/GiudGiud/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/GiudGiud/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/GiudGiud/OpenMOC/events","assignees_url":"https://api.github.com/repos/GiudGiud/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/GiudGiud/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/GiudGiud/OpenMOC/tags","blobs_url":"https://api.github.com/repos/GiudGiud/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/GiudGiud/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/GiudGiud/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/GiudGiud/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/GiudGiud/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/GiudGiud/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/GiudGiud/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/GiudGiud/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/GiudGiud/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/GiudGiud/OpenMOC/subscription","commits_url":"https://api.github.com/repos/GiudGiud/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/GiudGiud/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/GiudGiud/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/GiudGiud/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/GiudGiud/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/GiudGiud/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/GiudGiud/OpenMOC/merges","archive_url":"https://api.github.com/repos/GiudGiud/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/GiudGiud/OpenMOC/downloads","issues_url":"https://api.github.com/repos/GiudGiud/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/GiudGiud/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/GiudGiud/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/GiudGiud/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/GiudGiud/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/GiudGiud/OpenMOC/releases{/id}","deployments_url":"https://api.github.com/repos/GiudGiud/OpenMOC/deployments","created_at":"2017-03-31T19:18:08Z","updated_at":"2018-07-03T01:58:08Z","pushed_at":"2018-10-22T23:51:20Z","git_url":"git://github.com/GiudGiud/OpenMOC.git","ssh_url":"git@github.com:GiudGiud/OpenMOC.git","clone_url":"https://github.com/GiudGiud/OpenMOC.git","svn_url":"https://github.com/GiudGiud/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":130363,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"mit-crpg:3D-MOC","ref":"3D-MOC","sha":"f05648bfc764cd03ff441efe6a4a7b97003b0ef5","user":{"login":"mit-crpg","id":1247634,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDc2MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1247634?v=4","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"repo":{"id":8780988,"node_id":"MDEwOlJlcG9zaXRvcnk4NzgwOTg4","name":"OpenMOC","full_name":"mit-crpg/OpenMOC","private":false,"owner":{"login":"mit-crpg","id":1247634,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyNDc2MzQ=","avatar_url":"https://avatars3.githubusercontent.com/u/1247634?v=4","gravatar_id":"","url":"https://api.github.com/users/mit-crpg","html_url":"https://github.com/mit-crpg","followers_url":"https://api.github.com/users/mit-crpg/followers","following_url":"https://api.github.com/users/mit-crpg/following{/other_user}","gists_url":"https://api.github.com/users/mit-crpg/gists{/gist_id}","starred_url":"https://api.github.com/users/mit-crpg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mit-crpg/subscriptions","organizations_url":"https://api.github.com/users/mit-crpg/orgs","repos_url":"https://api.github.com/users/mit-crpg/repos","events_url":"https://api.github.com/users/mit-crpg/events{/privacy}","received_events_url":"https://api.github.com/users/mit-crpg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mit-crpg/OpenMOC","description":"A method of characteristics code for nuclear reactor physics calculations.","fork":false,"url":"https://api.github.com/repos/mit-crpg/OpenMOC","forks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/forks","keys_url":"https://api.github.com/repos/mit-crpg/OpenMOC/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mit-crpg/OpenMOC/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mit-crpg/OpenMOC/teams","hooks_url":"https://api.github.com/repos/mit-crpg/OpenMOC/hooks","issue_events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/events{/number}","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/events","assignees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/assignees{/user}","branches_url":"https://api.github.com/repos/mit-crpg/OpenMOC/branches{/branch}","tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/tags","blobs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/refs{/sha}","trees_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/{sha}","languages_url":"https://api.github.com/repos/mit-crpg/OpenMOC/languages","stargazers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/stargazers","contributors_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contributors","subscribers_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscribers","subscription_url":"https://api.github.com/repos/mit-crpg/OpenMOC/subscription","commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/commits{/sha}","git_commits_url":"https://api.github.com/repos/mit-crpg/OpenMOC/git/commits{/sha}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/comments{/number}","issue_comment_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments{/number}","contents_url":"https://api.github.com/repos/mit-crpg/OpenMOC/contents/{+path}","compare_url":"https://api.github.com/repos/mit-crpg/OpenMOC/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mit-crpg/OpenMOC/merges","archive_url":"https://api.github.com/repos/mit-crpg/OpenMOC/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mit-crpg/OpenMOC/downloads","issues_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues{/number}","pulls_url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls{/number}","milestones_url":"https://api.github.com/repos/mit-crpg/OpenMOC/milestones{/number}","notifications_url":"https://api.github.com/repos/mit-crpg/OpenMOC/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels{/name}","releases_url":"https://api.github.com/repos/mit-crpg/OpenMOC/releases{/id}","deployments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/deployments","created_at":"2013-03-14T17:19:26Z","updated_at":"2018-10-09T00:22:15Z","pushed_at":"2018-10-22T23:51:22Z","git_url":"git://github.com/mit-crpg/OpenMOC.git","ssh_url":"git@github.com:mit-crpg/OpenMOC.git","clone_url":"https://github.com/mit-crpg/OpenMOC.git","svn_url":"https://github.com/mit-crpg/OpenMOC","homepage":"https://mit-crpg.github.io/OpenMOC/","size":129736,"stargazers_count":52,"watchers_count":52,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":48,"open_issues":28,"watchers":52,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/366"},"html":{"href":"https://github.com/mit-crpg/OpenMOC/pull/366"},"issue":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/366"},"comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/366/comments"},"review_comments":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/366/comments"},"review_comment":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/366/commits"},"statuses":{"href":"https://api.github.com/repos/mit-crpg/OpenMOC/statuses/7f0043a01296c69858905156b9cfc942fd240c95"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wuwenbin2006"}}