{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/magenta-js/pulls/comments/184170076","pull_request_review_id":115310201,"id":184170076,"diff_hunk":"@@ -170,10 +183,18 @@ export class MusicRNN<A extends controls.ControlSignalUserArgs> {\n       const inputs = this.dataConverter.toTensor(sequence);\n       const length: number = inputs.shape[0];\n       const outputSize: number = inputs.shape[1];\n-      const controls = this.controlSignal ?\n-          this.controlSignal.getTensors(length + steps, controlSignalArgs) :\n+      const controls = this.chordEncoder ?\n+          this.chordEncoder.encodeProgression(\n+              chordProgression, length + steps) :\n           undefined;\n-      const samples = this.sampleRnn(inputs, steps, temperature, controls);\n+      const auxInputs = this.auxInputs ?","path":"music/src/music_rnn/model.ts","position":88,"original_position":88,"commit_id":"58306327480fccf9bc2c2158a416bddaf0c5cb8c","original_commit_id":"58306327480fccf9bc2c2158a416bddaf0c5cb8c","user":{"login":"iansimon","id":1361775,"avatar_url":"https://avatars2.githubusercontent.com/u/1361775?v=4","gravatar_id":"","url":"https://api.github.com/users/iansimon","html_url":"https://github.com/iansimon","followers_url":"https://api.github.com/users/iansimon/followers","following_url":"https://api.github.com/users/iansimon/following{/other_user}","gists_url":"https://api.github.com/users/iansimon/gists{/gist_id}","starred_url":"https://api.github.com/users/iansimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iansimon/subscriptions","organizations_url":"https://api.github.com/users/iansimon/orgs","repos_url":"https://api.github.com/users/iansimon/repos","events_url":"https://api.github.com/users/iansimon/events{/privacy}","received_events_url":"https://api.github.com/users/iansimon/received_events","type":"User","site_admin":false},"body":"They're on different axes.","created_at":"2018-04-25T18:52:37Z","updated_at":"2018-04-25T18:52:38Z","html_url":"https://github.com/tensorflow/magenta-js/pull/52#discussion_r184170076","pull_request_url":"https://api.github.com/repos/tensorflow/magenta-js/pulls/52","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/magenta-js/pulls/comments/184170076"},"html":{"href":"https://github.com/tensorflow/magenta-js/pull/52#discussion_r184170076"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/magenta-js/pulls/52"}},"in_reply_to_id":184158065},"pull_request":{"url":"https://api.github.com/repos/tensorflow/magenta-js/pulls/52","id":183875227,"html_url":"https://github.com/tensorflow/magenta-js/pull/52","diff_url":"https://github.com/tensorflow/magenta-js/pull/52.diff","patch_url":"https://github.com/tensorflow/magenta-js/pull/52.patch","issue_url":"https://api.github.com/repos/tensorflow/magenta-js/issues/52","number":52,"state":"open","locked":false,"title":"refactor control signals into chords and auxiliary inputs","user":{"login":"iansimon","id":1361775,"avatar_url":"https://avatars2.githubusercontent.com/u/1361775?v=4","gravatar_id":"","url":"https://api.github.com/users/iansimon","html_url":"https://github.com/iansimon","followers_url":"https://api.github.com/users/iansimon/followers","following_url":"https://api.github.com/users/iansimon/following{/other_user}","gists_url":"https://api.github.com/users/iansimon/gists{/gist_id}","starred_url":"https://api.github.com/users/iansimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iansimon/subscriptions","organizations_url":"https://api.github.com/users/iansimon/orgs","repos_url":"https://api.github.com/users/iansimon/repos","events_url":"https://api.github.com/users/iansimon/events{/privacy}","received_events_url":"https://api.github.com/users/iansimon/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-24T21:54:45Z","updated_at":"2018-04-25T18:52:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3bf8bf2f2d54d28fa70cc3e6bbfa7451b00c2bd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/magenta-js/pulls/52/commits","review_comments_url":"https://api.github.com/repos/tensorflow/magenta-js/pulls/52/comments","review_comment_url":"https://api.github.com/repos/tensorflow/magenta-js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/magenta-js/issues/52/comments","statuses_url":"https://api.github.com/repos/tensorflow/magenta-js/statuses/58306327480fccf9bc2c2158a416bddaf0c5cb8c","head":{"label":"iansimon:simplify_controls","ref":"simplify_controls","sha":"58306327480fccf9bc2c2158a416bddaf0c5cb8c","user":{"login":"iansimon","id":1361775,"avatar_url":"https://avatars2.githubusercontent.com/u/1361775?v=4","gravatar_id":"","url":"https://api.github.com/users/iansimon","html_url":"https://github.com/iansimon","followers_url":"https://api.github.com/users/iansimon/followers","following_url":"https://api.github.com/users/iansimon/following{/other_user}","gists_url":"https://api.github.com/users/iansimon/gists{/gist_id}","starred_url":"https://api.github.com/users/iansimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iansimon/subscriptions","organizations_url":"https://api.github.com/users/iansimon/orgs","repos_url":"https://api.github.com/users/iansimon/repos","events_url":"https://api.github.com/users/iansimon/events{/privacy}","received_events_url":"https://api.github.com/users/iansimon/received_events","type":"User","site_admin":false},"repo":{"id":128421763,"name":"magenta-js","full_name":"iansimon/magenta-js","owner":{"login":"iansimon","id":1361775,"avatar_url":"https://avatars2.githubusercontent.com/u/1361775?v=4","gravatar_id":"","url":"https://api.github.com/users/iansimon","html_url":"https://github.com/iansimon","followers_url":"https://api.github.com/users/iansimon/followers","following_url":"https://api.github.com/users/iansimon/following{/other_user}","gists_url":"https://api.github.com/users/iansimon/gists{/gist_id}","starred_url":"https://api.github.com/users/iansimon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iansimon/subscriptions","organizations_url":"https://api.github.com/users/iansimon/orgs","repos_url":"https://api.github.com/users/iansimon/repos","events_url":"https://api.github.com/users/iansimon/events{/privacy}","received_events_url":"https://api.github.com/users/iansimon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/iansimon/magenta-js","description":"Magenta.js: Music and Art Generation with Machine Intelligence in the Browser","fork":true,"url":"https://api.github.com/repos/iansimon/magenta-js","forks_url":"https://api.github.com/repos/iansimon/magenta-js/forks","keys_url":"https://api.github.com/repos/iansimon/magenta-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/iansimon/magenta-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/iansimon/magenta-js/teams","hooks_url":"https://api.github.com/repos/iansimon/magenta-js/hooks","issue_events_url":"https://api.github.com/repos/iansimon/magenta-js/issues/events{/number}","events_url":"https://api.github.com/repos/iansimon/magenta-js/events","assignees_url":"https://api.github.com/repos/iansimon/magenta-js/assignees{/user}","branches_url":"https://api.github.com/repos/iansimon/magenta-js/branches{/branch}","tags_url":"https://api.github.com/repos/iansimon/magenta-js/tags","blobs_url":"https://api.github.com/repos/iansimon/magenta-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/iansimon/magenta-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/iansimon/magenta-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/iansimon/magenta-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/iansimon/magenta-js/statuses/{sha}","languages_url":"https://api.github.com/repos/iansimon/magenta-js/languages","stargazers_url":"https://api.github.com/repos/iansimon/magenta-js/stargazers","contributors_url":"https://api.github.com/repos/iansimon/magenta-js/contributors","subscribers_url":"https://api.github.com/repos/iansimon/magenta-js/subscribers","subscription_url":"https://api.github.com/repos/iansimon/magenta-js/subscription","commits_url":"https://api.github.com/repos/iansimon/magenta-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/iansimon/magenta-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/iansimon/magenta-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/iansimon/magenta-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/iansimon/magenta-js/contents/{+path}","compare_url":"https://api.github.com/repos/iansimon/magenta-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/iansimon/magenta-js/merges","archive_url":"https://api.github.com/repos/iansimon/magenta-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/iansimon/magenta-js/downloads","issues_url":"https://api.github.com/repos/iansimon/magenta-js/issues{/number}","pulls_url":"https://api.github.com/repos/iansimon/magenta-js/pulls{/number}","milestones_url":"https://api.github.com/repos/iansimon/magenta-js/milestones{/number}","notifications_url":"https://api.github.com/repos/iansimon/magenta-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/iansimon/magenta-js/labels{/name}","releases_url":"https://api.github.com/repos/iansimon/magenta-js/releases{/id}","deployments_url":"https://api.github.com/repos/iansimon/magenta-js/deployments","created_at":"2018-04-06T16:55:23Z","updated_at":"2018-04-24T21:46:34Z","pushed_at":"2018-04-25T16:59:17Z","git_url":"git://github.com/iansimon/magenta-js.git","ssh_url":"git@github.com:iansimon/magenta-js.git","clone_url":"https://github.com/iansimon/magenta-js.git","svn_url":"https://github.com/iansimon/magenta-js","homepage":"https://magenta.tensorflow.org","size":310,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"608450b197df4d74bd9d85e6114537492b2b4b7b","user":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":126883328,"name":"magenta-js","full_name":"tensorflow/magenta-js","owner":{"login":"tensorflow","id":15658638,"avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/magenta-js","description":"Magenta.js: Music and Art Generation with Machine Intelligence in the Browser","fork":false,"url":"https://api.github.com/repos/tensorflow/magenta-js","forks_url":"https://api.github.com/repos/tensorflow/magenta-js/forks","keys_url":"https://api.github.com/repos/tensorflow/magenta-js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/magenta-js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/magenta-js/teams","hooks_url":"https://api.github.com/repos/tensorflow/magenta-js/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/magenta-js/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/magenta-js/events","assignees_url":"https://api.github.com/repos/tensorflow/magenta-js/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/magenta-js/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/magenta-js/tags","blobs_url":"https://api.github.com/repos/tensorflow/magenta-js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/magenta-js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/magenta-js/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/magenta-js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/magenta-js/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/magenta-js/languages","stargazers_url":"https://api.github.com/repos/tensorflow/magenta-js/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/magenta-js/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/magenta-js/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/magenta-js/subscription","commits_url":"https://api.github.com/repos/tensorflow/magenta-js/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/magenta-js/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/magenta-js/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/magenta-js/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/magenta-js/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/magenta-js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/magenta-js/merges","archive_url":"https://api.github.com/repos/tensorflow/magenta-js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/magenta-js/downloads","issues_url":"https://api.github.com/repos/tensorflow/magenta-js/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/magenta-js/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/magenta-js/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/magenta-js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/magenta-js/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/magenta-js/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/magenta-js/deployments","created_at":"2018-03-26T20:02:28Z","updated_at":"2018-04-25T18:20:10Z","pushed_at":"2018-04-25T18:41:30Z","git_url":"git://github.com/tensorflow/magenta-js.git","ssh_url":"git@github.com:tensorflow/magenta-js.git","clone_url":"https://github.com/tensorflow/magenta-js.git","svn_url":"https://github.com/tensorflow/magenta-js","homepage":"https://magenta.tensorflow.org","size":304,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":11,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":11,"watchers":62,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/magenta-js/pulls/52"},"html":{"href":"https://github.com/tensorflow/magenta-js/pull/52"},"issue":{"href":"https://api.github.com/repos/tensorflow/magenta-js/issues/52"},"comments":{"href":"https://api.github.com/repos/tensorflow/magenta-js/issues/52/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/magenta-js/pulls/52/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/magenta-js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/magenta-js/pulls/52/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/magenta-js/statuses/58306327480fccf9bc2c2158a416bddaf0c5cb8c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"iansimon"}}