{"action":"closed","issue":{"url":"https://api.github.com/repos/MahApps/MahApps.Metro/issues/3412","repository_url":"https://api.github.com/repos/MahApps/MahApps.Metro","labels_url":"https://api.github.com/repos/MahApps/MahApps.Metro/issues/3412/labels{/name}","comments_url":"https://api.github.com/repos/MahApps/MahApps.Metro/issues/3412/comments","events_url":"https://api.github.com/repos/MahApps/MahApps.Metro/issues/3412/events","html_url":"https://github.com/MahApps/MahApps.Metro/issues/3412","id":392140960,"node_id":"MDU6SXNzdWUzOTIxNDA5NjA=","number":3412,"title":"BaseMetroDialog DialogBottom: CommandBinding doesn't work","user":{"login":"pfattisc","id":11867529,"node_id":"MDQ6VXNlcjExODY3NTI5","avatar_url":"https://avatars1.githubusercontent.com/u/11867529?v=4","gravatar_id":"","url":"https://api.github.com/users/pfattisc","html_url":"https://github.com/pfattisc","followers_url":"https://api.github.com/users/pfattisc/followers","following_url":"https://api.github.com/users/pfattisc/following{/other_user}","gists_url":"https://api.github.com/users/pfattisc/gists{/gist_id}","starred_url":"https://api.github.com/users/pfattisc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pfattisc/subscriptions","organizations_url":"https://api.github.com/users/pfattisc/orgs","repos_url":"https://api.github.com/users/pfattisc/repos","events_url":"https://api.github.com/users/pfattisc/events{/privacy}","received_events_url":"https://api.github.com/users/pfattisc/received_events","type":"User","site_admin":false},"labels":[{"id":171652,"node_id":"MDU6TGFiZWwxNzE2NTI=","url":"https://api.github.com/repos/MahApps/MahApps.Metro/labels/Bug","name":"Bug","color":"e11d21","default":false}],"state":"closed","locked":false,"assignee":{"login":"punker76","id":658431,"node_id":"MDQ6VXNlcjY1ODQzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/658431?v=4","gravatar_id":"","url":"https://api.github.com/users/punker76","html_url":"https://github.com/punker76","followers_url":"https://api.github.com/users/punker76/followers","following_url":"https://api.github.com/users/punker76/following{/other_user}","gists_url":"https://api.github.com/users/punker76/gists{/gist_id}","starred_url":"https://api.github.com/users/punker76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punker76/subscriptions","organizations_url":"https://api.github.com/users/punker76/orgs","repos_url":"https://api.github.com/users/punker76/repos","events_url":"https://api.github.com/users/punker76/events{/privacy}","received_events_url":"https://api.github.com/users/punker76/received_events","type":"User","site_admin":false},"assignees":[{"login":"punker76","id":658431,"node_id":"MDQ6VXNlcjY1ODQzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/658431?v=4","gravatar_id":"","url":"https://api.github.com/users/punker76","html_url":"https://github.com/punker76","followers_url":"https://api.github.com/users/punker76/followers","following_url":"https://api.github.com/users/punker76/following{/other_user}","gists_url":"https://api.github.com/users/punker76/gists{/gist_id}","starred_url":"https://api.github.com/users/punker76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punker76/subscriptions","organizations_url":"https://api.github.com/users/punker76/orgs","repos_url":"https://api.github.com/users/punker76/repos","events_url":"https://api.github.com/users/punker76/events{/privacy}","received_events_url":"https://api.github.com/users/punker76/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/MahApps/MahApps.Metro/milestones/18","html_url":"https://github.com/MahApps/MahApps.Metro/milestone/18","labels_url":"https://api.github.com/repos/MahApps/MahApps.Metro/milestones/18/labels","id":1484973,"node_id":"MDk6TWlsZXN0b25lMTQ4NDk3Mw==","number":18,"title":"2.0.0","description":"","creator":{"login":"punker76","id":658431,"node_id":"MDQ6VXNlcjY1ODQzMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/658431?v=4","gravatar_id":"","url":"https://api.github.com/users/punker76","html_url":"https://github.com/punker76","followers_url":"https://api.github.com/users/punker76/followers","following_url":"https://api.github.com/users/punker76/following{/other_user}","gists_url":"https://api.github.com/users/punker76/gists{/gist_id}","starred_url":"https://api.github.com/users/punker76/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punker76/subscriptions","organizations_url":"https://api.github.com/users/punker76/orgs","repos_url":"https://api.github.com/users/punker76/repos","events_url":"https://api.github.com/users/punker76/events{/privacy}","received_events_url":"https://api.github.com/users/punker76/received_events","type":"User","site_admin":false},"open_issues":13,"closed_issues":74,"state":"open","created_at":"2016-01-05T14:29:29Z","updated_at":"2018-12-19T21:22:27Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-12-18T12:46:51Z","updated_at":"2018-12-19T21:22:26Z","closed_at":"2018-12-19T21:22:26Z","author_association":"NONE","body":"**Describe the bug**\r\nI have a [demo](https://github.com/pfattisc/DialogBottomBug) with a custom dialog. Within the custom dialog's DialogBottom there are two buttons OK and Cancel (to accept resp. cancel).\r\nThe button's commands are bound to the CloseCommand of the dialog. This is a relative source binding.\r\nQuite often this binding doesn't work while the same binding of a button within the dialog's content does always work.\r\n\r\n**To Reproduce**\r\nSteps to reproduce the behavior:\r\n1. Get & Run [demo](https://github.com/pfattisc/DialogBottomBug) \r\n2. Click on the (big) button 'start demo' in the main window. This will show a CustomDialog with a button as content and two buttons (OK, Cancel) in the DialogBottom.\r\n3. Press the OK button in the bottom. Normally this should close the dialog, but most of the times it doesn't. Now press the button in the dialog content, which is bound the same way => And notice that this time the binding works and the dialog closes as expected\r\n\r\nI also attached a gif that demonstrates the behaviour.\r\nNote: That time when the OK button doesn't seem to work and you snoop the binding two things will happen:\r\n1. First the bound command is NULL\r\n2. Snooping it will refresh the binding and it will magically work.\r\n\r\nTrivia: When the dialog first comes up and you close it with the 'ESC' Key and reopen it, most of the times the OK button binding will work as expected.\r\n\r\n**Expected behavior**\r\n(RelativeSource) Bindings of buttons within the DialogBottom part should always work.\r\n\r\n**Screenshots**\r\n![dialogbottom_bug](https://user-images.githubusercontent.com/11867529/50154145-c8609b80-02c8-11e9-98a2-9b69e66746f1.gif)\r\n\r\n\r\n**Environment(please complete the following information):**\r\n - MahApps.Metro version 1.6.5\r\n - OS: Win10 1607 (N 2016 LTSB)\r\n - Visual Studio 2017\r\n - .NET Framework 4.7.2\r\n\r\n**Repo**\r\n[demo](https://github.com/pfattisc/DialogBottomBug)\r\n\r\n**Additional context**\r\nOriginally this problem occurs in a desktop application. Interestingly the reported issue occurs in this application quite sporadically. This led me to the conclusion that the problem might be triggered by a race condition. The more I was surprised that the demo app demonstrates the problem quite constantly...\r\n"}}
{"actor":{"display_login":"punker76"}}