{"action":"created","comment":{"url":"https://api.github.com/repos/magento/architecture/pulls/comments/245449273","pull_request_review_id":189564733,"id":245449273,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQ0OTI3Mw==","diff_hunk":"@@ -0,0 +1,140 @@\n+# Front-End Technical Vision\r\n+\r\n+The following document is a guide for all future Magento front-end applications, for which we should be mindful of the following values:\r\n+\r\n+- Portability\r\n+- Extensibility\r\n+- Maintainability\r\n+- Consistency\r\n+- Performance\r\n+- Accessibility\r\n+- Internationalization\r\n+- Productivity (Efficiency)\r\n+- Quality (Reliability)\r\n+\r\n+## [React](https://reactjs.org/)\r\n+\r\n+_Portability, Performance, Productivity, Quality, Internationalization._\r\n+\r\n+React's [continued growth and popularity](https://www.npmtrends.com/@angular/core-vs-react-vs-vue) coupled with its [solid documentation](https://reactjs.org/docs/getting-started.html) make it an excellent choice for building user interfaces. If written appropriately, it enables **portability** by [crossing over into native applications](http://jkaufman.io/react-web-native-codesharing/) with [React Native](https://facebook.github.io/react-native/).\r\n+\r\n+**Performance** is easy to achieve with React, because it only re-renders DOM elements where and when necessary. That's not to say that React prevents you from creating **performance** problems, but the docs do well at explaining [what to avoid and how to profile](https://reactjs.org/docs/optimizing-performance.html).\r\n+\r\n+Creating a new React project has never been easier with [CRA][], which comes out-of-the-box with [hot reloading](https://webpack.js.org/concepts/hot-module-replacement/). This increases **productivity** by giving developers [short, positive feedback loops](https://www.youtube.com/watch?v=avKBrgIQXzk). Hot reloading is [also achievable in React Native](https://facebook.github.io/react-native/blog/2016/03/24/introducing-hot-reloading.html). Another opportunity for short, positive feedback loops is testing with [Jest][] and [Enzyme](https://airbnb.io/enzyme/). Tests are fastest when writing unit tests with the [Shallow Rendering API](https://airbnb.io/enzyme/docs/api/shallow.html) and reserving the [Full Rendering API](https://airbnb.io/enzyme/docs/api/mount.html) for integration tests. The better the development experience in these cycles, the better **quality** we achieve as a result. [Jest's snapshot testing](https://jestjs.io/docs/en/snapshot-testing) is another way to ensure **quality** in that we don't inadvertently introduce breaking changes.\r","path":"design-documents/frontend/technical-vision.md","position":23,"original_position":23,"commit_id":"c95bf306d5322437c1efcb6bdf0d34783c7bc3e2","original_commit_id":"c95bf306d5322437c1efcb6bdf0d34783c7bc3e2","user":{"login":"DrewML","id":5233399,"node_id":"MDQ6VXNlcjUyMzMzOTk=","avatar_url":"https://avatars2.githubusercontent.com/u/5233399?v=4","gravatar_id":"","url":"https://api.github.com/users/DrewML","html_url":"https://github.com/DrewML","followers_url":"https://api.github.com/users/DrewML/followers","following_url":"https://api.github.com/users/DrewML/following{/other_user}","gists_url":"https://api.github.com/users/DrewML/gists{/gist_id}","starred_url":"https://api.github.com/users/DrewML/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DrewML/subscriptions","organizations_url":"https://api.github.com/users/DrewML/orgs","repos_url":"https://api.github.com/users/DrewML/repos","events_url":"https://api.github.com/users/DrewML/events{/privacy}","received_events_url":"https://api.github.com/users/DrewML/received_events","type":"User","site_admin":false},"body":"`[CRA][]` here is missing the link value","created_at":"2019-01-04T23:32:24Z","updated_at":"2019-01-04T23:32:24Z","html_url":"https://github.com/magento/architecture/pull/49#discussion_r245449273","pull_request_url":"https://api.github.com/repos/magento/architecture/pulls/49","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/magento/architecture/pulls/comments/245449273"},"html":{"href":"https://github.com/magento/architecture/pull/49#discussion_r245449273"},"pull_request":{"href":"https://api.github.com/repos/magento/architecture/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/magento/architecture/pulls/49","id":235074030,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MDc0MDMw","html_url":"https://github.com/magento/architecture/pull/49","diff_url":"https://github.com/magento/architecture/pull/49.diff","patch_url":"https://github.com/magento/architecture/pull/49.patch","issue_url":"https://api.github.com/repos/magento/architecture/issues/49","number":49,"state":"open","locked":false,"title":"Add front-end tech vision doc","user":{"login":"jedmao","id":1058243,"node_id":"MDQ6VXNlcjEwNTgyNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1058243?v=4","gravatar_id":"","url":"https://api.github.com/users/jedmao","html_url":"https://github.com/jedmao","followers_url":"https://api.github.com/users/jedmao/followers","following_url":"https://api.github.com/users/jedmao/following{/other_user}","gists_url":"https://api.github.com/users/jedmao/gists{/gist_id}","starred_url":"https://api.github.com/users/jedmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedmao/subscriptions","organizations_url":"https://api.github.com/users/jedmao/orgs","repos_url":"https://api.github.com/users/jedmao/repos","events_url":"https://api.github.com/users/jedmao/events{/privacy}","received_events_url":"https://api.github.com/users/jedmao/received_events","type":"User","site_admin":false},"body":"The JavaScript ecosystem can be daunting when presented with so many options. Which libraries do you choose and why this one over that one?\r\n\r\n<a href=\"https://hackernoon.com/how-it-feels-to-learn-javascript-in-2016-d3a717dd577f\"><img src=\"https://cdn-images-1.medium.com/max/1600/1*raWO3dhM4jMjf9VY-kZzNg.png\" alt=\"so many JavaScript options\"></a>\r\n\r\nThis document is intended to set you off on the right foot. Think of it as a generic guide for new front-end applications. Your specific project will most likely have needs of its own that deviate from this guide. That's totally fine and expected.","created_at":"2018-11-30T18:19:34Z","updated_at":"2019-01-04T23:32:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a530a5fc5261951bb5a500ea99e2998c49b3c77a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/magento/architecture/pulls/49/commits","review_comments_url":"https://api.github.com/repos/magento/architecture/pulls/49/comments","review_comment_url":"https://api.github.com/repos/magento/architecture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/magento/architecture/issues/49/comments","statuses_url":"https://api.github.com/repos/magento/architecture/statuses/c95bf306d5322437c1efcb6bdf0d34783c7bc3e2","head":{"label":"jedmao:tech-vision","ref":"tech-vision","sha":"c95bf306d5322437c1efcb6bdf0d34783c7bc3e2","user":{"login":"jedmao","id":1058243,"node_id":"MDQ6VXNlcjEwNTgyNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1058243?v=4","gravatar_id":"","url":"https://api.github.com/users/jedmao","html_url":"https://github.com/jedmao","followers_url":"https://api.github.com/users/jedmao/followers","following_url":"https://api.github.com/users/jedmao/following{/other_user}","gists_url":"https://api.github.com/users/jedmao/gists{/gist_id}","starred_url":"https://api.github.com/users/jedmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedmao/subscriptions","organizations_url":"https://api.github.com/users/jedmao/orgs","repos_url":"https://api.github.com/users/jedmao/repos","events_url":"https://api.github.com/users/jedmao/events{/privacy}","received_events_url":"https://api.github.com/users/jedmao/received_events","type":"User","site_admin":false},"repo":{"id":159855608,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk4NTU2MDg=","name":"architecture","full_name":"jedmao/architecture","private":false,"owner":{"login":"jedmao","id":1058243,"node_id":"MDQ6VXNlcjEwNTgyNDM=","avatar_url":"https://avatars2.githubusercontent.com/u/1058243?v=4","gravatar_id":"","url":"https://api.github.com/users/jedmao","html_url":"https://github.com/jedmao","followers_url":"https://api.github.com/users/jedmao/followers","following_url":"https://api.github.com/users/jedmao/following{/other_user}","gists_url":"https://api.github.com/users/jedmao/gists{/gist_id}","starred_url":"https://api.github.com/users/jedmao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jedmao/subscriptions","organizations_url":"https://api.github.com/users/jedmao/orgs","repos_url":"https://api.github.com/users/jedmao/repos","events_url":"https://api.github.com/users/jedmao/events{/privacy}","received_events_url":"https://api.github.com/users/jedmao/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jedmao/architecture","description":"A place where Magento architectural discussions happen","fork":true,"url":"https://api.github.com/repos/jedmao/architecture","forks_url":"https://api.github.com/repos/jedmao/architecture/forks","keys_url":"https://api.github.com/repos/jedmao/architecture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jedmao/architecture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jedmao/architecture/teams","hooks_url":"https://api.github.com/repos/jedmao/architecture/hooks","issue_events_url":"https://api.github.com/repos/jedmao/architecture/issues/events{/number}","events_url":"https://api.github.com/repos/jedmao/architecture/events","assignees_url":"https://api.github.com/repos/jedmao/architecture/assignees{/user}","branches_url":"https://api.github.com/repos/jedmao/architecture/branches{/branch}","tags_url":"https://api.github.com/repos/jedmao/architecture/tags","blobs_url":"https://api.github.com/repos/jedmao/architecture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jedmao/architecture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jedmao/architecture/git/refs{/sha}","trees_url":"https://api.github.com/repos/jedmao/architecture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jedmao/architecture/statuses/{sha}","languages_url":"https://api.github.com/repos/jedmao/architecture/languages","stargazers_url":"https://api.github.com/repos/jedmao/architecture/stargazers","contributors_url":"https://api.github.com/repos/jedmao/architecture/contributors","subscribers_url":"https://api.github.com/repos/jedmao/architecture/subscribers","subscription_url":"https://api.github.com/repos/jedmao/architecture/subscription","commits_url":"https://api.github.com/repos/jedmao/architecture/commits{/sha}","git_commits_url":"https://api.github.com/repos/jedmao/architecture/git/commits{/sha}","comments_url":"https://api.github.com/repos/jedmao/architecture/comments{/number}","issue_comment_url":"https://api.github.com/repos/jedmao/architecture/issues/comments{/number}","contents_url":"https://api.github.com/repos/jedmao/architecture/contents/{+path}","compare_url":"https://api.github.com/repos/jedmao/architecture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jedmao/architecture/merges","archive_url":"https://api.github.com/repos/jedmao/architecture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jedmao/architecture/downloads","issues_url":"https://api.github.com/repos/jedmao/architecture/issues{/number}","pulls_url":"https://api.github.com/repos/jedmao/architecture/pulls{/number}","milestones_url":"https://api.github.com/repos/jedmao/architecture/milestones{/number}","notifications_url":"https://api.github.com/repos/jedmao/architecture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jedmao/architecture/labels{/name}","releases_url":"https://api.github.com/repos/jedmao/architecture/releases{/id}","deployments_url":"https://api.github.com/repos/jedmao/architecture/deployments","created_at":"2018-11-30T17:17:28Z","updated_at":"2018-11-30T17:17:30Z","pushed_at":"2018-11-30T18:34:44Z","git_url":"git://github.com/jedmao/architecture.git","ssh_url":"git@github.com:jedmao/architecture.git","clone_url":"https://github.com/jedmao/architecture.git","svn_url":"https://github.com/jedmao/architecture","homepage":"","size":1724,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"magento:master","ref":"master","sha":"29ab7eb8bce6cd47b5cb24d4d2f9b30cdb7204e6","user":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"repo":{"id":128087944,"node_id":"MDEwOlJlcG9zaXRvcnkxMjgwODc5NDQ=","name":"architecture","full_name":"magento/architecture","private":false,"owner":{"login":"magento","id":168457,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2ODQ1Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/168457?v=4","gravatar_id":"","url":"https://api.github.com/users/magento","html_url":"https://github.com/magento","followers_url":"https://api.github.com/users/magento/followers","following_url":"https://api.github.com/users/magento/following{/other_user}","gists_url":"https://api.github.com/users/magento/gists{/gist_id}","starred_url":"https://api.github.com/users/magento/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/magento/subscriptions","organizations_url":"https://api.github.com/users/magento/orgs","repos_url":"https://api.github.com/users/magento/repos","events_url":"https://api.github.com/users/magento/events{/privacy}","received_events_url":"https://api.github.com/users/magento/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/magento/architecture","description":"A place where Magento architectural discussions happen","fork":false,"url":"https://api.github.com/repos/magento/architecture","forks_url":"https://api.github.com/repos/magento/architecture/forks","keys_url":"https://api.github.com/repos/magento/architecture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/magento/architecture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/magento/architecture/teams","hooks_url":"https://api.github.com/repos/magento/architecture/hooks","issue_events_url":"https://api.github.com/repos/magento/architecture/issues/events{/number}","events_url":"https://api.github.com/repos/magento/architecture/events","assignees_url":"https://api.github.com/repos/magento/architecture/assignees{/user}","branches_url":"https://api.github.com/repos/magento/architecture/branches{/branch}","tags_url":"https://api.github.com/repos/magento/architecture/tags","blobs_url":"https://api.github.com/repos/magento/architecture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/magento/architecture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/magento/architecture/git/refs{/sha}","trees_url":"https://api.github.com/repos/magento/architecture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/magento/architecture/statuses/{sha}","languages_url":"https://api.github.com/repos/magento/architecture/languages","stargazers_url":"https://api.github.com/repos/magento/architecture/stargazers","contributors_url":"https://api.github.com/repos/magento/architecture/contributors","subscribers_url":"https://api.github.com/repos/magento/architecture/subscribers","subscription_url":"https://api.github.com/repos/magento/architecture/subscription","commits_url":"https://api.github.com/repos/magento/architecture/commits{/sha}","git_commits_url":"https://api.github.com/repos/magento/architecture/git/commits{/sha}","comments_url":"https://api.github.com/repos/magento/architecture/comments{/number}","issue_comment_url":"https://api.github.com/repos/magento/architecture/issues/comments{/number}","contents_url":"https://api.github.com/repos/magento/architecture/contents/{+path}","compare_url":"https://api.github.com/repos/magento/architecture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/magento/architecture/merges","archive_url":"https://api.github.com/repos/magento/architecture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/magento/architecture/downloads","issues_url":"https://api.github.com/repos/magento/architecture/issues{/number}","pulls_url":"https://api.github.com/repos/magento/architecture/pulls{/number}","milestones_url":"https://api.github.com/repos/magento/architecture/milestones{/number}","notifications_url":"https://api.github.com/repos/magento/architecture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/magento/architecture/labels{/name}","releases_url":"https://api.github.com/repos/magento/architecture/releases{/id}","deployments_url":"https://api.github.com/repos/magento/architecture/deployments","created_at":"2018-04-04T16:11:31Z","updated_at":"2019-01-04T08:48:11Z","pushed_at":"2019-01-04T16:50:47Z","git_url":"git://github.com/magento/architecture.git","ssh_url":"git@github.com:magento/architecture.git","clone_url":"https://github.com/magento/architecture.git","svn_url":"https://github.com/magento/architecture","homepage":"","size":2506,"stargazers_count":58,"watchers_count":58,"language":null,"has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":28,"mirror_url":null,"archived":false,"open_issues_count":20,"license":null,"forks":28,"open_issues":20,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/magento/architecture/pulls/49"},"html":{"href":"https://github.com/magento/architecture/pull/49"},"issue":{"href":"https://api.github.com/repos/magento/architecture/issues/49"},"comments":{"href":"https://api.github.com/repos/magento/architecture/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/magento/architecture/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/magento/architecture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/magento/architecture/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/magento/architecture/statuses/c95bf306d5322437c1efcb6bdf0d34783c7bc3e2"}},"author_association":"NONE"}}
{"actor":{"display_login":"DrewML"}}