{"action":"created","issue":{"url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/227","repository_url":"https://api.github.com/repos/open-ephys/plugin-GUI","labels_url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/227/labels{/name}","comments_url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/227/comments","events_url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/227/events","html_url":"https://github.com/open-ephys/plugin-GUI/pull/227","id":330723537,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzNjY0MDky","number":227,"title":"Add AUX chans toggle button to RhythmNode, improve editor layout","user":{"login":"mspacek","id":799467,"node_id":"MDQ6VXNlcjc5OTQ2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/799467?v=4","gravatar_id":"","url":"https://api.github.com/users/mspacek","html_url":"https://github.com/mspacek","followers_url":"https://api.github.com/users/mspacek/followers","following_url":"https://api.github.com/users/mspacek/following{/other_user}","gists_url":"https://api.github.com/users/mspacek/gists{/gist_id}","starred_url":"https://api.github.com/users/mspacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspacek/subscriptions","organizations_url":"https://api.github.com/users/mspacek/orgs","repos_url":"https://api.github.com/users/mspacek/repos","events_url":"https://api.github.com/users/mspacek/events{/privacy}","received_events_url":"https://api.github.com/users/mspacek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-06-08T16:26:56Z","updated_at":"2018-06-10T17:13:59Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/open-ephys/plugin-GUI/pulls/227","html_url":"https://github.com/open-ephys/plugin-GUI/pull/227","diff_url":"https://github.com/open-ephys/plugin-GUI/pull/227.diff","patch_url":"https://github.com/open-ephys/plugin-GUI/pull/227.patch"},"body":"* Complements the ADC chans toggle button, and allows for multiples of 64 instead of 67 channels throughout\r\n* Improve consistency of widget sizing and spacing\r\n\r\nI haven't thoroughly tested this on the dev branch (I'm mostly working off the master branch), but it seems to work."},"comment":{"url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/comments/396065569","html_url":"https://github.com/open-ephys/plugin-GUI/pull/227#issuecomment-396065569","issue_url":"https://api.github.com/repos/open-ephys/plugin-GUI/issues/227","id":396065569,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NjA2NTU2OQ==","user":{"login":"mspacek","id":799467,"node_id":"MDQ6VXNlcjc5OTQ2Nw==","avatar_url":"https://avatars0.githubusercontent.com/u/799467?v=4","gravatar_id":"","url":"https://api.github.com/users/mspacek","html_url":"https://github.com/mspacek","followers_url":"https://api.github.com/users/mspacek/followers","following_url":"https://api.github.com/users/mspacek/following{/other_user}","gists_url":"https://api.github.com/users/mspacek/gists{/gist_id}","starred_url":"https://api.github.com/users/mspacek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mspacek/subscriptions","organizations_url":"https://api.github.com/users/mspacek/orgs","repos_url":"https://api.github.com/users/mspacek/repos","events_url":"https://api.github.com/users/mspacek/events{/privacy}","received_events_url":"https://api.github.com/users/mspacek/received_events","type":"User","site_admin":false},"created_at":"2018-06-10T17:13:59Z","updated_at":"2018-06-10T17:13:59Z","author_association":"CONTRIBUTOR","body":"OK, I've overwritten what I previously pushed, 3 separate commits now for clarity. Now when aux chans are disabled, they're no longer copied in `RHD2000Thread::updateBuffer()`\r\n\r\nI also added some new comments to `RHD2000Thread::updateBuffer()`. Could you please check that they're accurate?\r\n\r\nI'm unclear about this line, [1570 in RHD2000Thread.cpp](https://github.com/open-ephys/plugin-GUI/pull/227/files#diff-07ad4d2eb89a2f3a2cab536ba57b586aR1570), right before the aux chans are copied:\r\n```C++\r\nauxIndex += 2 * numStreams; // mspacek: not clear why this is here\r\n```\r\nWhen I comment it out, everything seems to run fine, with all combinations of aux and adc toggles. I don't currently have any real signals on either aux or adc chans to test with, so everything looks identical in both cases (50 Hz line noise on the neural channels, positive saturation on the aux chans, 0V on the adc chans. I think).\r\n\r\nI'm actually very unclear about the whole block of aux chan copying code that follows. Could someone clarify it for me so I can add some comments to the code?"}}
{"actor":{"display_login":"mspacek"}}