{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/comments/206660664","pull_request_review_id":142114060,"id":206660664,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjY2MDY2NA==","diff_hunk":"@@ -290,3 +292,44 @@ resource \"google_storage_bucket_iam_member\" \"api_s_account_storage_admin_on_proj\n \n   depends_on = [\"google_project_service.project_services\"]\n }\n+\n+/******************************************\n+  compute.networkUser role granted to API and GKE service accounts for GKE on shared VPC \n+ *****************************************/\n+resource \"google_project_iam_binding\" \"gke_shared_vpc_project\" {\n+  count = \"${(var.shared_vpc != \"\" && contains(var.activate_apis, \"container.googleapis.com\") && length(compact(var.shared_vpc_subnets)) == 0) ? 1 : 0}\"","path":"main.tf","position":36,"original_position":36,"commit_id":"21a080b35bdc59a52c370c2f811875560b0c4305","original_commit_id":"21a080b35bdc59a52c370c2f811875560b0c4305","user":{"login":"morgante","id":1627801,"node_id":"MDQ6VXNlcjE2Mjc4MDE=","avatar_url":"https://avatars0.githubusercontent.com/u/1627801?v=4","gravatar_id":"","url":"https://api.github.com/users/morgante","html_url":"https://github.com/morgante","followers_url":"https://api.github.com/users/morgante/followers","following_url":"https://api.github.com/users/morgante/following{/other_user}","gists_url":"https://api.github.com/users/morgante/gists{/gist_id}","starred_url":"https://api.github.com/users/morgante/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morgante/subscriptions","organizations_url":"https://api.github.com/users/morgante/orgs","repos_url":"https://api.github.com/users/morgante/repos","events_url":"https://api.github.com/users/morgante/events{/privacy}","received_events_url":"https://api.github.com/users/morgante/received_events","type":"User","site_admin":false},"body":"Let's consolidate `var.shared_vpc != \"\" && contains(var.activate_apis, \"container.googleapis.com\")` in a single local boolean test at the top.","created_at":"2018-07-31T19:49:27Z","updated_at":"2018-07-31T19:51:51Z","html_url":"https://github.com/terraform-google-modules/terraform-google-project-factory/pull/7#discussion_r206660664","pull_request_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/7","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/comments/206660664"},"html":{"href":"https://github.com/terraform-google-modules/terraform-google-project-factory/pull/7#discussion_r206660664"},"pull_request":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/7"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/7","id":205219797,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjE5Nzk3","html_url":"https://github.com/terraform-google-modules/terraform-google-project-factory/pull/7","diff_url":"https://github.com/terraform-google-modules/terraform-google-project-factory/pull/7.diff","patch_url":"https://github.com/terraform-google-modules/terraform-google-project-factory/pull/7.patch","issue_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/issues/7","number":7,"state":"open","locked":false,"title":"Add support for GKE shared VPC functionality","user":{"login":"CPearring","id":5456037,"node_id":"MDQ6VXNlcjU0NTYwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5456037?v=4","gravatar_id":"","url":"https://api.github.com/users/CPearring","html_url":"https://github.com/CPearring","followers_url":"https://api.github.com/users/CPearring/followers","following_url":"https://api.github.com/users/CPearring/following{/other_user}","gists_url":"https://api.github.com/users/CPearring/gists{/gist_id}","starred_url":"https://api.github.com/users/CPearring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPearring/subscriptions","organizations_url":"https://api.github.com/users/CPearring/orgs","repos_url":"https://api.github.com/users/CPearring/repos","events_url":"https://api.github.com/users/CPearring/events{/privacy}","received_events_url":"https://api.github.com/users/CPearring/received_events","type":"User","site_admin":false},"body":"Added IAM resources for GKE/API SAs to allow GKE shared VPC if wanted. \r\n\r\nAdded a conditional for the group email to be optional, as currently it defaults to \"@\" with an empty string","created_at":"2018-07-31T19:37:18Z","updated_at":"2018-07-31T19:51:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d689fd1d37e1ebcf3c98f67ca32d91855525d122","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/7/commits","review_comments_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/7/comments","review_comment_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/issues/7/comments","statuses_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/statuses/21a080b35bdc59a52c370c2f811875560b0c4305","head":{"label":"CPearring:master","ref":"master","sha":"21a080b35bdc59a52c370c2f811875560b0c4305","user":{"login":"CPearring","id":5456037,"node_id":"MDQ6VXNlcjU0NTYwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5456037?v=4","gravatar_id":"","url":"https://api.github.com/users/CPearring","html_url":"https://github.com/CPearring","followers_url":"https://api.github.com/users/CPearring/followers","following_url":"https://api.github.com/users/CPearring/following{/other_user}","gists_url":"https://api.github.com/users/CPearring/gists{/gist_id}","starred_url":"https://api.github.com/users/CPearring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPearring/subscriptions","organizations_url":"https://api.github.com/users/CPearring/orgs","repos_url":"https://api.github.com/users/CPearring/repos","events_url":"https://api.github.com/users/CPearring/events{/privacy}","received_events_url":"https://api.github.com/users/CPearring/received_events","type":"User","site_admin":false},"repo":{"id":143045164,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwNDUxNjQ=","name":"terraform-google-project-factory","full_name":"CPearring/terraform-google-project-factory","owner":{"login":"CPearring","id":5456037,"node_id":"MDQ6VXNlcjU0NTYwMzc=","avatar_url":"https://avatars1.githubusercontent.com/u/5456037?v=4","gravatar_id":"","url":"https://api.github.com/users/CPearring","html_url":"https://github.com/CPearring","followers_url":"https://api.github.com/users/CPearring/followers","following_url":"https://api.github.com/users/CPearring/following{/other_user}","gists_url":"https://api.github.com/users/CPearring/gists{/gist_id}","starred_url":"https://api.github.com/users/CPearring/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CPearring/subscriptions","organizations_url":"https://api.github.com/users/CPearring/orgs","repos_url":"https://api.github.com/users/CPearring/repos","events_url":"https://api.github.com/users/CPearring/events{/privacy}","received_events_url":"https://api.github.com/users/CPearring/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/CPearring/terraform-google-project-factory","description":"Opinionated Google Cloud Platform project creation and configuration with Shared VPC, IAM, APIs, etc.","fork":true,"url":"https://api.github.com/repos/CPearring/terraform-google-project-factory","forks_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/forks","keys_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/teams","hooks_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/hooks","issue_events_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/issues/events{/number}","events_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/events","assignees_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/assignees{/user}","branches_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/branches{/branch}","tags_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/tags","blobs_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/git/refs{/sha}","trees_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/statuses/{sha}","languages_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/languages","stargazers_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/stargazers","contributors_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/contributors","subscribers_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/subscribers","subscription_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/subscription","commits_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/commits{/sha}","git_commits_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/git/commits{/sha}","comments_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/comments{/number}","issue_comment_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/issues/comments{/number}","contents_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/contents/{+path}","compare_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/merges","archive_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/downloads","issues_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/issues{/number}","pulls_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/pulls{/number}","milestones_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/milestones{/number}","notifications_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/labels{/name}","releases_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/releases{/id}","deployments_url":"https://api.github.com/repos/CPearring/terraform-google-project-factory/deployments","created_at":"2018-07-31T17:21:53Z","updated_at":"2018-07-31T19:29:51Z","pushed_at":"2018-07-31T19:29:50Z","git_url":"git://github.com/CPearring/terraform-google-project-factory.git","ssh_url":"git@github.com:CPearring/terraform-google-project-factory.git","clone_url":"https://github.com/CPearring/terraform-google-project-factory.git","svn_url":"https://github.com/CPearring/terraform-google-project-factory","homepage":null,"size":63,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-google-modules:master","ref":"master","sha":"b2cef1cff2720f0a91fc859e4c497d1686eee454","user":{"login":"terraform-google-modules","id":37194493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTk0NDkz","avatar_url":"https://avatars3.githubusercontent.com/u/37194493?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-google-modules","html_url":"https://github.com/terraform-google-modules","followers_url":"https://api.github.com/users/terraform-google-modules/followers","following_url":"https://api.github.com/users/terraform-google-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-google-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-google-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-google-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-google-modules/orgs","repos_url":"https://api.github.com/users/terraform-google-modules/repos","events_url":"https://api.github.com/users/terraform-google-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-google-modules/received_events","type":"Organization","site_admin":false},"repo":{"id":136937187,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MzcxODc=","name":"terraform-google-project-factory","full_name":"terraform-google-modules/terraform-google-project-factory","owner":{"login":"terraform-google-modules","id":37194493,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3MTk0NDkz","avatar_url":"https://avatars3.githubusercontent.com/u/37194493?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-google-modules","html_url":"https://github.com/terraform-google-modules","followers_url":"https://api.github.com/users/terraform-google-modules/followers","following_url":"https://api.github.com/users/terraform-google-modules/following{/other_user}","gists_url":"https://api.github.com/users/terraform-google-modules/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-google-modules/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-google-modules/subscriptions","organizations_url":"https://api.github.com/users/terraform-google-modules/orgs","repos_url":"https://api.github.com/users/terraform-google-modules/repos","events_url":"https://api.github.com/users/terraform-google-modules/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-google-modules/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-google-modules/terraform-google-project-factory","description":"Opinionated Google Cloud Platform project creation and configuration with Shared VPC, IAM, APIs, etc.","fork":false,"url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory","forks_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/forks","keys_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/teams","hooks_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/hooks","issue_events_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/events","assignees_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/tags","blobs_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/languages","stargazers_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/stargazers","contributors_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/contributors","subscribers_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/subscribers","subscription_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/subscription","commits_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/merges","archive_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/downloads","issues_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/labels{/name}","releases_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/deployments","created_at":"2018-06-11T14:22:48Z","updated_at":"2018-07-30T21:57:23Z","pushed_at":"2018-07-31T19:37:18Z","git_url":"git://github.com/terraform-google-modules/terraform-google-project-factory.git","ssh_url":"git@github.com:terraform-google-modules/terraform-google-project-factory.git","clone_url":"https://github.com/terraform-google-modules/terraform-google-project-factory.git","svn_url":"https://github.com/terraform-google-modules/terraform-google-project-factory","homepage":null,"size":63,"stargazers_count":1,"watchers_count":1,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":5,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/7"},"html":{"href":"https://github.com/terraform-google-modules/terraform-google-project-factory/pull/7"},"issue":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/issues/7"},"comments":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/issues/7/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/7/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/pulls/7/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-google-modules/terraform-google-project-factory/statuses/21a080b35bdc59a52c370c2f811875560b0c4305"}},"author_association":"NONE"}}
{"actor":{"display_login":"morgante"}}