{"action":"created","comment":{"url":"https://api.github.com/repos/getsentry/raven-node/pulls/comments/188240931","pull_request_review_id":120175595,"id":188240931,"diff_hunk":"@@ -45,10 +45,12 @@ module.exports.parseError = function parseError(err, kwargs, cb) {\n       kwargs.extra[name] = extraErrorProps;\n     }\n \n-    for (var n = frames.length - 1; n >= 0; n--) {\n-      if (frames[n].in_app) {\n-        kwargs.culprit = kwargs.culprit || utils.getCulprit(frames[n]);\n-        break;\n+    if (!kwargs.transaction && !kwargs.culprit) {\n+      for (var n = frames.length - 1; n >= 0; n--) {\n+        if (frames[n].in_app) {\n+          kwargs.transaction = utils.getTransaction(frames[n]);","path":"lib/parsers.js","position":11,"original_position":11,"commit_id":"f23998e72110a32d1e09adeb3993989c73a1afe5","original_commit_id":"f23998e72110a32d1e09adeb3993989c73a1afe5","user":{"login":"jan-auer","id":1433023,"avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false},"body":"Changed the logic here to only include a `transaction` if the user hasn't set a `culprit` manually. \r\n@mitsuhiko  should we add the transaction always - even if a manual culprit is given?","created_at":"2018-05-15T10:38:07Z","updated_at":"2018-05-15T10:38:07Z","html_url":"https://github.com/getsentry/raven-node/pull/458#discussion_r188240931","pull_request_url":"https://api.github.com/repos/getsentry/raven-node/pulls/458","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/getsentry/raven-node/pulls/comments/188240931"},"html":{"href":"https://github.com/getsentry/raven-node/pull/458#discussion_r188240931"},"pull_request":{"href":"https://api.github.com/repos/getsentry/raven-node/pulls/458"}}},"pull_request":{"url":"https://api.github.com/repos/getsentry/raven-node/pulls/458","id":188078456,"html_url":"https://github.com/getsentry/raven-node/pull/458","diff_url":"https://github.com/getsentry/raven-node/pull/458.diff","patch_url":"https://github.com/getsentry/raven-node/pull/458.patch","issue_url":"https://api.github.com/repos/getsentry/raven-node/issues/458","number":458,"state":"open","locked":false,"title":"ref: Emit transaction instead of culprit","user":{"login":"jan-auer","id":1433023,"avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false},"body":"By default, we emit a `transaction` now instead of the culprit. ","created_at":"2018-05-15T10:14:03Z","updated_at":"2018-05-15T10:38:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8db106089bfec67f18dc608f287d894842b16655","assignee":{"login":"jan-auer","id":1433023,"avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false},"assignees":[{"login":"jan-auer","id":1433023,"avatar_url":"https://avatars0.githubusercontent.com/u/1433023?v=4","gravatar_id":"","url":"https://api.github.com/users/jan-auer","html_url":"https://github.com/jan-auer","followers_url":"https://api.github.com/users/jan-auer/followers","following_url":"https://api.github.com/users/jan-auer/following{/other_user}","gists_url":"https://api.github.com/users/jan-auer/gists{/gist_id}","starred_url":"https://api.github.com/users/jan-auer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jan-auer/subscriptions","organizations_url":"https://api.github.com/users/jan-auer/orgs","repos_url":"https://api.github.com/users/jan-auer/repos","events_url":"https://api.github.com/users/jan-auer/events{/privacy}","received_events_url":"https://api.github.com/users/jan-auer/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"kamilogorek","id":1523305,"avatar_url":"https://avatars3.githubusercontent.com/u/1523305?v=4","gravatar_id":"","url":"https://api.github.com/users/kamilogorek","html_url":"https://github.com/kamilogorek","followers_url":"https://api.github.com/users/kamilogorek/followers","following_url":"https://api.github.com/users/kamilogorek/following{/other_user}","gists_url":"https://api.github.com/users/kamilogorek/gists{/gist_id}","starred_url":"https://api.github.com/users/kamilogorek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kamilogorek/subscriptions","organizations_url":"https://api.github.com/users/kamilogorek/orgs","repos_url":"https://api.github.com/users/kamilogorek/repos","events_url":"https://api.github.com/users/kamilogorek/events{/privacy}","received_events_url":"https://api.github.com/users/kamilogorek/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/getsentry/raven-node/pulls/458/commits","review_comments_url":"https://api.github.com/repos/getsentry/raven-node/pulls/458/comments","review_comment_url":"https://api.github.com/repos/getsentry/raven-node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/getsentry/raven-node/issues/458/comments","statuses_url":"https://api.github.com/repos/getsentry/raven-node/statuses/f23998e72110a32d1e09adeb3993989c73a1afe5","head":{"label":"getsentry:ref/transaction","ref":"ref/transaction","sha":"f23998e72110a32d1e09adeb3993989c73a1afe5","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":2872812,"name":"raven-node","full_name":"getsentry/raven-node","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/raven-node","description":"A standalone (Node.js) client for Sentry","fork":false,"url":"https://api.github.com/repos/getsentry/raven-node","forks_url":"https://api.github.com/repos/getsentry/raven-node/forks","keys_url":"https://api.github.com/repos/getsentry/raven-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/raven-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/raven-node/teams","hooks_url":"https://api.github.com/repos/getsentry/raven-node/hooks","issue_events_url":"https://api.github.com/repos/getsentry/raven-node/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/raven-node/events","assignees_url":"https://api.github.com/repos/getsentry/raven-node/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/raven-node/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/raven-node/tags","blobs_url":"https://api.github.com/repos/getsentry/raven-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/raven-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/raven-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/raven-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/raven-node/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/raven-node/languages","stargazers_url":"https://api.github.com/repos/getsentry/raven-node/stargazers","contributors_url":"https://api.github.com/repos/getsentry/raven-node/contributors","subscribers_url":"https://api.github.com/repos/getsentry/raven-node/subscribers","subscription_url":"https://api.github.com/repos/getsentry/raven-node/subscription","commits_url":"https://api.github.com/repos/getsentry/raven-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/raven-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/raven-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/raven-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/raven-node/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/raven-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/raven-node/merges","archive_url":"https://api.github.com/repos/getsentry/raven-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/raven-node/downloads","issues_url":"https://api.github.com/repos/getsentry/raven-node/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/raven-node/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/raven-node/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/raven-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/raven-node/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/raven-node/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/raven-node/deployments","created_at":"2011-11-29T05:26:23Z","updated_at":"2018-05-15T04:54:44Z","pushed_at":"2018-05-15T10:29:20Z","git_url":"git://github.com/getsentry/raven-node.git","ssh_url":"git@github.com:getsentry/raven-node.git","clone_url":"https://github.com/getsentry/raven-node.git","svn_url":"https://github.com/getsentry/raven-node","homepage":"https://sentry.io/","size":934,"stargazers_count":444,"watchers_count":444,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":152,"open_issues":22,"watchers":444,"default_branch":"master"}},"base":{"label":"getsentry:master","ref":"master","sha":"63734643e40ac22d952838b397cb721a411bcf52","user":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"repo":{"id":2872812,"name":"raven-node","full_name":"getsentry/raven-node","owner":{"login":"getsentry","id":1396951,"avatar_url":"https://avatars0.githubusercontent.com/u/1396951?v=4","gravatar_id":"","url":"https://api.github.com/users/getsentry","html_url":"https://github.com/getsentry","followers_url":"https://api.github.com/users/getsentry/followers","following_url":"https://api.github.com/users/getsentry/following{/other_user}","gists_url":"https://api.github.com/users/getsentry/gists{/gist_id}","starred_url":"https://api.github.com/users/getsentry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/getsentry/subscriptions","organizations_url":"https://api.github.com/users/getsentry/orgs","repos_url":"https://api.github.com/users/getsentry/repos","events_url":"https://api.github.com/users/getsentry/events{/privacy}","received_events_url":"https://api.github.com/users/getsentry/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/getsentry/raven-node","description":"A standalone (Node.js) client for Sentry","fork":false,"url":"https://api.github.com/repos/getsentry/raven-node","forks_url":"https://api.github.com/repos/getsentry/raven-node/forks","keys_url":"https://api.github.com/repos/getsentry/raven-node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/getsentry/raven-node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/getsentry/raven-node/teams","hooks_url":"https://api.github.com/repos/getsentry/raven-node/hooks","issue_events_url":"https://api.github.com/repos/getsentry/raven-node/issues/events{/number}","events_url":"https://api.github.com/repos/getsentry/raven-node/events","assignees_url":"https://api.github.com/repos/getsentry/raven-node/assignees{/user}","branches_url":"https://api.github.com/repos/getsentry/raven-node/branches{/branch}","tags_url":"https://api.github.com/repos/getsentry/raven-node/tags","blobs_url":"https://api.github.com/repos/getsentry/raven-node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/getsentry/raven-node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/getsentry/raven-node/git/refs{/sha}","trees_url":"https://api.github.com/repos/getsentry/raven-node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/getsentry/raven-node/statuses/{sha}","languages_url":"https://api.github.com/repos/getsentry/raven-node/languages","stargazers_url":"https://api.github.com/repos/getsentry/raven-node/stargazers","contributors_url":"https://api.github.com/repos/getsentry/raven-node/contributors","subscribers_url":"https://api.github.com/repos/getsentry/raven-node/subscribers","subscription_url":"https://api.github.com/repos/getsentry/raven-node/subscription","commits_url":"https://api.github.com/repos/getsentry/raven-node/commits{/sha}","git_commits_url":"https://api.github.com/repos/getsentry/raven-node/git/commits{/sha}","comments_url":"https://api.github.com/repos/getsentry/raven-node/comments{/number}","issue_comment_url":"https://api.github.com/repos/getsentry/raven-node/issues/comments{/number}","contents_url":"https://api.github.com/repos/getsentry/raven-node/contents/{+path}","compare_url":"https://api.github.com/repos/getsentry/raven-node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/getsentry/raven-node/merges","archive_url":"https://api.github.com/repos/getsentry/raven-node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/getsentry/raven-node/downloads","issues_url":"https://api.github.com/repos/getsentry/raven-node/issues{/number}","pulls_url":"https://api.github.com/repos/getsentry/raven-node/pulls{/number}","milestones_url":"https://api.github.com/repos/getsentry/raven-node/milestones{/number}","notifications_url":"https://api.github.com/repos/getsentry/raven-node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/getsentry/raven-node/labels{/name}","releases_url":"https://api.github.com/repos/getsentry/raven-node/releases{/id}","deployments_url":"https://api.github.com/repos/getsentry/raven-node/deployments","created_at":"2011-11-29T05:26:23Z","updated_at":"2018-05-15T04:54:44Z","pushed_at":"2018-05-15T10:29:20Z","git_url":"git://github.com/getsentry/raven-node.git","ssh_url":"git@github.com:getsentry/raven-node.git","clone_url":"https://github.com/getsentry/raven-node.git","svn_url":"https://github.com/getsentry/raven-node","homepage":"https://sentry.io/","size":934,"stargazers_count":444,"watchers_count":444,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":152,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"bsd-2-clause","name":"BSD 2-Clause \"Simplified\" License","spdx_id":"BSD-2-Clause","url":"https://api.github.com/licenses/bsd-2-clause"},"forks":152,"open_issues":22,"watchers":444,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/getsentry/raven-node/pulls/458"},"html":{"href":"https://github.com/getsentry/raven-node/pull/458"},"issue":{"href":"https://api.github.com/repos/getsentry/raven-node/issues/458"},"comments":{"href":"https://api.github.com/repos/getsentry/raven-node/issues/458/comments"},"review_comments":{"href":"https://api.github.com/repos/getsentry/raven-node/pulls/458/comments"},"review_comment":{"href":"https://api.github.com/repos/getsentry/raven-node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/getsentry/raven-node/pulls/458/commits"},"statuses":{"href":"https://api.github.com/repos/getsentry/raven-node/statuses/f23998e72110a32d1e09adeb3993989c73a1afe5"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"jan-auer"}}