{"action":"created","comment":{"url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments/194487887","pull_request_review_id":127669770,"id":194487887,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDQ4Nzg4Nw==","diff_hunk":"@@ -0,0 +1,98 @@\n+// Copyright (c) .NET Foundation and contributors. All rights reserved.\n+// Licensed under the MIT license. See LICENSE file in the project root for full license information.\n+\n+#pragma once\n+\n+#include \"stdafx.h\"\n+#include <map>\n+\n+class ConfigUtility\n+{\n+    #define CS_ASPNETCORE_HANDLER_SETTINGS                   L\"handlerSettings\"\n+    #define CS_ASPNETCORE_HANDLER_VERSION                    L\"handlerVersion\"\n+    #define CS_ASPNETCORE_HANDLER_SETTINGS_NAME              L\"name\"\n+    #define CS_ASPNETCORE_HANDLER_SETTINGS_VALUE             L\"value\"\n+\n+public:\n+    static\n+    HRESULT\n+    FindHandlerVersion(IAppHostElement* pElement, STRU* strHandlerVersionValue)\n+    {\n+        HRESULT hr = S_OK;\n+        IAppHostElement                *pHandlerSettings = NULL;\n+        IAppHostElementCollection      *pHandlerSettingsCollection = NULL;\n+        ENUM_INDEX                      index;\n+        IAppHostElement                *pHandlerVar = NULL;\n+        STRU strHandlerName;\n+        STRU strHandlerValue;\n+\n+        hr = GetElementChildByName(pElement,\n+            CS_ASPNETCORE_HANDLER_SETTINGS,\n+            &pHandlerSettings);\n+        if (FAILED(hr))\n+        {\n+            goto Finished;\n+        }\n+\n+        hr = pHandlerSettings->get_Collection(&pHandlerSettingsCollection);\n+        if (FAILED(hr))\n+        {\n+            goto Finished;\n+        }\n+\n+        for (hr = FindFirstElement(pHandlerSettingsCollection, &index, &pHandlerVar);\n+            SUCCEEDED(hr);\n+            hr = FindNextElement(pHandlerSettingsCollection, &index, &pHandlerVar))\n+        {\n+            if (hr == S_FALSE)\n+            {\n+                hr = S_OK;\n+                break;\n+            }\n+\n+            hr = hr = GetElementStringProperty(pHandlerVar,\n+                CS_ASPNETCORE_HANDLER_SETTINGS_NAME,\n+                &strHandlerName);\n+\n+            if (FAILED(hr))\n+            {\n+                goto Finished;\n+            }\n+\n+            hr = GetElementStringProperty(pHandlerVar,\n+                CS_ASPNETCORE_HANDLER_SETTINGS_VALUE,\n+                &strHandlerValue);\n+\n+            if (FAILED(hr))\n+            {\n+                goto Finished;\n+\n+            }\n+\n+            if (strHandlerName.Equals(CS_ASPNETCORE_HANDLER_VERSION))\n+            {\n+                hr = strHandlerVersionValue->Copy(strHandlerValue);\n+                goto Finished;\n+            }\n+\n+            strHandlerName.Reset();\n+            strHandlerValue.Reset();","path":"src/AspNetCoreModuleV2/CommonLib/config_utility.h","position":79,"original_position":79,"commit_id":"dab65284e2ea9f875c4c96abc046a446345e21c3","original_commit_id":"dab65284e2ea9f875c4c96abc046a446345e21c3","user":{"login":"pan-wang","id":18172635,"node_id":"MDQ6VXNlcjE4MTcyNjM1","avatar_url":"https://avatars0.githubusercontent.com/u/18172635?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-wang","html_url":"https://github.com/pan-wang","followers_url":"https://api.github.com/users/pan-wang/followers","following_url":"https://api.github.com/users/pan-wang/following{/other_user}","gists_url":"https://api.github.com/users/pan-wang/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-wang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-wang/subscriptions","organizations_url":"https://api.github.com/users/pan-wang/orgs","repos_url":"https://api.github.com/users/pan-wang/repos","events_url":"https://api.github.com/users/pan-wang/events{/privacy}","received_events_url":"https://api.github.com/users/pan-wang/received_events","type":"User","site_admin":false},"body":"please call pHandlerVar->Release here as you reuse the pointer in the loop","created_at":"2018-06-11T17:43:00Z","updated_at":"2018-06-11T17:44:03Z","html_url":"https://github.com/aspnet/IISIntegration/pull/895#discussion_r194487887","pull_request_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/895","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments/194487887"},"html":{"href":"https://github.com/aspnet/IISIntegration/pull/895#discussion_r194487887"},"pull_request":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/895"}}},"pull_request":{"url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/895","id":193152776,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzMTUyNzc2","html_url":"https://github.com/aspnet/IISIntegration/pull/895","diff_url":"https://github.com/aspnet/IISIntegration/pull/895.diff","patch_url":"https://github.com/aspnet/IISIntegration/pull/895.patch","issue_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/895","number":895,"state":"open","locked":false,"title":"Load ANCM out of process via global versioning","user":{"login":"jkotalik","id":8302101,"node_id":"MDQ6VXNlcjgzMDIxMDE=","avatar_url":"https://avatars0.githubusercontent.com/u/8302101?v=4","gravatar_id":"","url":"https://api.github.com/users/jkotalik","html_url":"https://github.com/jkotalik","followers_url":"https://api.github.com/users/jkotalik/followers","following_url":"https://api.github.com/users/jkotalik/following{/other_user}","gists_url":"https://api.github.com/users/jkotalik/gists{/gist_id}","starred_url":"https://api.github.com/users/jkotalik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jkotalik/subscriptions","organizations_url":"https://api.github.com/users/jkotalik/orgs","repos_url":"https://api.github.com/users/jkotalik/repos","events_url":"https://api.github.com/users/jkotalik/events{/privacy}","received_events_url":"https://api.github.com/users/jkotalik/received_events","type":"User","site_admin":false},"body":"For #859 . There is still some cleanup I need to do but I will be most likely offline the rest of the night. cc/ @muratg ","created_at":"2018-06-06T21:59:54Z","updated_at":"2018-06-11T17:44:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c2670d1dee370fff3fdcdbb6673d7b6c6c4e391","assignee":null,"assignees":[],"requested_reviewers":[{"login":"shirhatti","id":4734691,"node_id":"MDQ6VXNlcjQ3MzQ2OTE=","avatar_url":"https://avatars1.githubusercontent.com/u/4734691?v=4","gravatar_id":"","url":"https://api.github.com/users/shirhatti","html_url":"https://github.com/shirhatti","followers_url":"https://api.github.com/users/shirhatti/followers","following_url":"https://api.github.com/users/shirhatti/following{/other_user}","gists_url":"https://api.github.com/users/shirhatti/gists{/gist_id}","starred_url":"https://api.github.com/users/shirhatti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shirhatti/subscriptions","organizations_url":"https://api.github.com/users/shirhatti/orgs","repos_url":"https://api.github.com/users/shirhatti/repos","events_url":"https://api.github.com/users/shirhatti/events{/privacy}","received_events_url":"https://api.github.com/users/shirhatti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/895/commits","review_comments_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/895/comments","review_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/895/comments","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/dab65284e2ea9f875c4c96abc046a446345e21c3","head":{"label":"aspnet:jkotalik/oopVersion","ref":"jkotalik/oopVersion","sha":"dab65284e2ea9f875c4c96abc046a446345e21c3","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42883699,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg4MzY5OQ==","name":"IISIntegration","full_name":"aspnet/IISIntegration","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/IISIntegration","description":"ASP.NET Core IIS integration","fork":false,"url":"https://api.github.com/repos/aspnet/IISIntegration","forks_url":"https://api.github.com/repos/aspnet/IISIntegration/forks","keys_url":"https://api.github.com/repos/aspnet/IISIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/IISIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/IISIntegration/teams","hooks_url":"https://api.github.com/repos/aspnet/IISIntegration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/IISIntegration/events","assignees_url":"https://api.github.com/repos/aspnet/IISIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/IISIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/IISIntegration/tags","blobs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/IISIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/IISIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/IISIntegration/languages","stargazers_url":"https://api.github.com/repos/aspnet/IISIntegration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/IISIntegration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/IISIntegration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/IISIntegration/subscription","commits_url":"https://api.github.com/repos/aspnet/IISIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/IISIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/IISIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/IISIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/IISIntegration/merges","archive_url":"https://api.github.com/repos/aspnet/IISIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/IISIntegration/downloads","issues_url":"https://api.github.com/repos/aspnet/IISIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/IISIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/IISIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/IISIntegration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/IISIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/IISIntegration/deployments","created_at":"2015-09-21T17:55:09Z","updated_at":"2018-06-08T09:13:34Z","pushed_at":"2018-06-11T17:00:21Z","git_url":"git://github.com/aspnet/IISIntegration.git","ssh_url":"git@github.com:aspnet/IISIntegration.git","clone_url":"https://github.com/aspnet/IISIntegration.git","svn_url":"https://github.com/aspnet/IISIntegration","homepage":"","size":11283,"stargazers_count":96,"watchers_count":96,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":43,"open_issues":103,"watchers":96,"default_branch":"dev"}},"base":{"label":"aspnet:dev","ref":"dev","sha":"4debd23b1b30989b2ff49823d801ce3d83327336","user":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"repo":{"id":42883699,"node_id":"MDEwOlJlcG9zaXRvcnk0Mjg4MzY5OQ==","name":"IISIntegration","full_name":"aspnet/IISIntegration","owner":{"login":"aspnet","id":6476660,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzY2NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/6476660?v=4","gravatar_id":"","url":"https://api.github.com/users/aspnet","html_url":"https://github.com/aspnet","followers_url":"https://api.github.com/users/aspnet/followers","following_url":"https://api.github.com/users/aspnet/following{/other_user}","gists_url":"https://api.github.com/users/aspnet/gists{/gist_id}","starred_url":"https://api.github.com/users/aspnet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aspnet/subscriptions","organizations_url":"https://api.github.com/users/aspnet/orgs","repos_url":"https://api.github.com/users/aspnet/repos","events_url":"https://api.github.com/users/aspnet/events{/privacy}","received_events_url":"https://api.github.com/users/aspnet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aspnet/IISIntegration","description":"ASP.NET Core IIS integration","fork":false,"url":"https://api.github.com/repos/aspnet/IISIntegration","forks_url":"https://api.github.com/repos/aspnet/IISIntegration/forks","keys_url":"https://api.github.com/repos/aspnet/IISIntegration/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aspnet/IISIntegration/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aspnet/IISIntegration/teams","hooks_url":"https://api.github.com/repos/aspnet/IISIntegration/hooks","issue_events_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/events{/number}","events_url":"https://api.github.com/repos/aspnet/IISIntegration/events","assignees_url":"https://api.github.com/repos/aspnet/IISIntegration/assignees{/user}","branches_url":"https://api.github.com/repos/aspnet/IISIntegration/branches{/branch}","tags_url":"https://api.github.com/repos/aspnet/IISIntegration/tags","blobs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aspnet/IISIntegration/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aspnet/IISIntegration/git/refs{/sha}","trees_url":"https://api.github.com/repos/aspnet/IISIntegration/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aspnet/IISIntegration/statuses/{sha}","languages_url":"https://api.github.com/repos/aspnet/IISIntegration/languages","stargazers_url":"https://api.github.com/repos/aspnet/IISIntegration/stargazers","contributors_url":"https://api.github.com/repos/aspnet/IISIntegration/contributors","subscribers_url":"https://api.github.com/repos/aspnet/IISIntegration/subscribers","subscription_url":"https://api.github.com/repos/aspnet/IISIntegration/subscription","commits_url":"https://api.github.com/repos/aspnet/IISIntegration/commits{/sha}","git_commits_url":"https://api.github.com/repos/aspnet/IISIntegration/git/commits{/sha}","comments_url":"https://api.github.com/repos/aspnet/IISIntegration/comments{/number}","issue_comment_url":"https://api.github.com/repos/aspnet/IISIntegration/issues/comments{/number}","contents_url":"https://api.github.com/repos/aspnet/IISIntegration/contents/{+path}","compare_url":"https://api.github.com/repos/aspnet/IISIntegration/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aspnet/IISIntegration/merges","archive_url":"https://api.github.com/repos/aspnet/IISIntegration/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aspnet/IISIntegration/downloads","issues_url":"https://api.github.com/repos/aspnet/IISIntegration/issues{/number}","pulls_url":"https://api.github.com/repos/aspnet/IISIntegration/pulls{/number}","milestones_url":"https://api.github.com/repos/aspnet/IISIntegration/milestones{/number}","notifications_url":"https://api.github.com/repos/aspnet/IISIntegration/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aspnet/IISIntegration/labels{/name}","releases_url":"https://api.github.com/repos/aspnet/IISIntegration/releases{/id}","deployments_url":"https://api.github.com/repos/aspnet/IISIntegration/deployments","created_at":"2015-09-21T17:55:09Z","updated_at":"2018-06-08T09:13:34Z","pushed_at":"2018-06-11T17:00:21Z","git_url":"git://github.com/aspnet/IISIntegration.git","ssh_url":"git@github.com:aspnet/IISIntegration.git","clone_url":"https://github.com/aspnet/IISIntegration.git","svn_url":"https://github.com/aspnet/IISIntegration","homepage":"","size":11283,"stargazers_count":96,"watchers_count":96,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":43,"mirror_url":null,"archived":false,"open_issues_count":103,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":43,"open_issues":103,"watchers":96,"default_branch":"dev"}},"_links":{"self":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/895"},"html":{"href":"https://github.com/aspnet/IISIntegration/pull/895"},"issue":{"href":"https://api.github.com/repos/aspnet/IISIntegration/issues/895"},"comments":{"href":"https://api.github.com/repos/aspnet/IISIntegration/issues/895/comments"},"review_comments":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/895/comments"},"review_comment":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aspnet/IISIntegration/pulls/895/commits"},"statuses":{"href":"https://api.github.com/repos/aspnet/IISIntegration/statuses/dab65284e2ea9f875c4c96abc046a446345e21c3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pan-wang"}}