{"action":"created","issue":{"url":"https://api.github.com/repos/Segs/Segs/issues/388","repository_url":"https://api.github.com/repos/Segs/Segs","labels_url":"https://api.github.com/repos/Segs/Segs/issues/388/labels{/name}","comments_url":"https://api.github.com/repos/Segs/Segs/issues/388/comments","events_url":"https://api.github.com/repos/Segs/Segs/issues/388/events","html_url":"https://github.com/Segs/Segs/issues/388","id":318855592,"number":388,"title":"Catch cereal exceptions","user":{"login":"nemerle","id":96597,"avatar_url":"https://avatars1.githubusercontent.com/u/96597?v=4","gravatar_id":"","url":"https://api.github.com/users/nemerle","html_url":"https://github.com/nemerle","followers_url":"https://api.github.com/users/nemerle/followers","following_url":"https://api.github.com/users/nemerle/following{/other_user}","gists_url":"https://api.github.com/users/nemerle/gists{/gist_id}","starred_url":"https://api.github.com/users/nemerle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nemerle/subscriptions","organizations_url":"https://api.github.com/users/nemerle/orgs","repos_url":"https://api.github.com/users/nemerle/repos","events_url":"https://api.github.com/users/nemerle/events{/privacy}","received_events_url":"https://api.github.com/users/nemerle/received_events","type":"User","site_admin":false},"labels":[{"id":28453034,"url":"https://api.github.com/repos/Segs/Segs/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":726522672,"url":"https://api.github.com/repos/Segs/Segs/labels/good%20first%20issue","name":"good first issue","color":"a36ff2","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/Segs/Segs/milestones/6","html_url":"https://github.com/Segs/Segs/milestone/6","labels_url":"https://api.github.com/repos/Segs/Segs/milestones/6/labels","id":2489407,"number":6,"title":"Version 0.5: The Unsilencer","description":"Our next public release.","creator":{"login":"ldilley","id":3323717,"avatar_url":"https://avatars3.githubusercontent.com/u/3323717?v=4","gravatar_id":"","url":"https://api.github.com/users/ldilley","html_url":"https://github.com/ldilley","followers_url":"https://api.github.com/users/ldilley/followers","following_url":"https://api.github.com/users/ldilley/following{/other_user}","gists_url":"https://api.github.com/users/ldilley/gists{/gist_id}","starred_url":"https://api.github.com/users/ldilley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldilley/subscriptions","organizations_url":"https://api.github.com/users/ldilley/orgs","repos_url":"https://api.github.com/users/ldilley/repos","events_url":"https://api.github.com/users/ldilley/events{/privacy}","received_events_url":"https://api.github.com/users/ldilley/received_events","type":"User","site_admin":false},"open_issues":16,"closed_issues":4,"state":"open","created_at":"2017-04-29T03:27:22Z","updated_at":"2018-05-01T23:33:07Z","due_on":"2018-05-31T07:00:00Z","closed_at":null},"comments":0,"created_at":"2018-04-30T11:10:32Z","updated_at":"2018-05-01T23:45:43Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Cereal will throw exceptions during serialization of invalid data\r\nWe should wrap all cereal functions to gracefully accept those failures, and log the errors.\r\nlooking at this https://uscilab.github.io/cereal/assets/doxygen/structcereal_1_1Exception.html\r\ncatching cereal::Exception should be enough.\r\n"},"comment":{"url":"https://api.github.com/repos/Segs/Segs/issues/comments/385822888","html_url":"https://github.com/Segs/Segs/issues/388#issuecomment-385822888","issue_url":"https://api.github.com/repos/Segs/Segs/issues/388","id":385822888,"user":{"login":"ldilley","id":3323717,"avatar_url":"https://avatars3.githubusercontent.com/u/3323717?v=4","gravatar_id":"","url":"https://api.github.com/users/ldilley","html_url":"https://github.com/ldilley","followers_url":"https://api.github.com/users/ldilley/followers","following_url":"https://api.github.com/users/ldilley/following{/other_user}","gists_url":"https://api.github.com/users/ldilley/gists{/gist_id}","starred_url":"https://api.github.com/users/ldilley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ldilley/subscriptions","organizations_url":"https://api.github.com/users/ldilley/orgs","repos_url":"https://api.github.com/users/ldilley/repos","events_url":"https://api.github.com/users/ldilley/events{/privacy}","received_events_url":"https://api.github.com/users/ldilley/received_events","type":"User","site_admin":false},"created_at":"2018-05-01T23:45:43Z","updated_at":"2018-05-01T23:45:43Z","author_association":"OWNER","body":"For an example of exception handling, [see the following lines from binConverter.cpp](https://github.com/Segs/Segs/blob/master/Projects/CoX/Utilities/BinConverter/binConverter.cpp#L182-L218). Rather than catch any/all exceptions however, we want to specifically look for `cereal::RapidJSONException` and wrap the necessary statements that might throw such an exception in a try block. We also do not want to exit in all cases, but continue on and log/note the warning as previously mentioned."}}
{"actor":{"display_login":"ldilley"}}