{"action":"created","comment":{"url":"https://api.github.com/repos/ulysseB/telamon/pulls/comments/224832165","pull_request_review_id":164301857,"id":224832165,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDgzMjE2NQ==","diff_hunk":"@@ -140,6 +140,8 @@ fn gen_flat_filter(\n             .iter()\n             .map(|x: &(_, _)| &x.1)\n             .chain(&foralls)\n+            .map(|set| set.as_ref())\n+            .chain(foralls.iter().flat_map(|set| set.reverse_constraint()))","path":"telamon-gen/src/constraint.rs","position":5,"original_position":5,"commit_id":"8414d82a7d0886d0c2210c0e5125ab7dd19fb7a0","original_commit_id":"8414d82a7d0886d0c2210c0e5125ab7dd19fb7a0","user":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"body":"Yes.","created_at":"2018-10-12T15:46:09Z","updated_at":"2018-10-12T15:46:09Z","html_url":"https://github.com/ulysseB/telamon/pull/147#discussion_r224832165","pull_request_url":"https://api.github.com/repos/ulysseB/telamon/pulls/147","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/comments/224832165"},"html":{"href":"https://github.com/ulysseB/telamon/pull/147#discussion_r224832165"},"pull_request":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/147"}},"in_reply_to_id":224750183},"pull_request":{"url":"https://api.github.com/repos/ulysseB/telamon/pulls/147","id":222325493,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMzI1NDkz","html_url":"https://github.com/ulysseB/telamon/pull/147","diff_url":"https://github.com/ulysseB/telamon/pull/147.diff","patch_url":"https://github.com/ulysseB/telamon/pull/147.patch","issue_url":"https://api.github.com/repos/ulysseB/telamon/issues/147","number":147,"state":"open","locked":false,"title":"Fix two bugs in telamon-gen.","user":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"body":"1. Correctly run the filters when allocating new objects, even if the\r\nfiltered choice was already existing. This involves creating and\r\npopulating a structure to store such filters and generating code for\r\nthe filter calls. The printing part is awkward because the old template\r\nsystem we used to generated code is only partially removed, so one part of\r\nthe printing uses rust Ast while the other use templates compiled to\r\nstrings.\r\n\r\n2. Move some set constraints outside the forall loops nest when reverse\r\nconstraints depends on them.\r\n\r\nThis PR also makes a few small changes on the side:\r\n- Fix a small mistake in `fail.rs`. The changes made it fail to compile.\r\n- Fix `ir_gen`. A variable was wrongly named, but this macro case was never\r\n  used before.\r\n\r\nFixes #138 ","created_at":"2018-10-12T01:35:46Z","updated_at":"2018-10-12T15:46:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"800deb658ba8b58e6378eda28a6ad76c8ba4d14a","assignee":null,"assignees":[],"requested_reviewers":[{"login":"nicoTolly","id":11578932,"node_id":"MDQ6VXNlcjExNTc4OTMy","avatar_url":"https://avatars2.githubusercontent.com/u/11578932?v=4","gravatar_id":"","url":"https://api.github.com/users/nicoTolly","html_url":"https://github.com/nicoTolly","followers_url":"https://api.github.com/users/nicoTolly/followers","following_url":"https://api.github.com/users/nicoTolly/following{/other_user}","gists_url":"https://api.github.com/users/nicoTolly/gists{/gist_id}","starred_url":"https://api.github.com/users/nicoTolly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicoTolly/subscriptions","organizations_url":"https://api.github.com/users/nicoTolly/orgs","repos_url":"https://api.github.com/users/nicoTolly/repos","events_url":"https://api.github.com/users/nicoTolly/events{/privacy}","received_events_url":"https://api.github.com/users/nicoTolly/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ulysseB/telamon/pulls/147/commits","review_comments_url":"https://api.github.com/repos/ulysseB/telamon/pulls/147/comments","review_comment_url":"https://api.github.com/repos/ulysseB/telamon/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ulysseB/telamon/issues/147/comments","statuses_url":"https://api.github.com/repos/ulysseB/telamon/statuses/8414d82a7d0886d0c2210c0e5125ab7dd19fb7a0","head":{"label":"ulysseB:telamon_gen_fix","ref":"telamon_gen_fix","sha":"8414d82a7d0886d0c2210c0e5125ab7dd19fb7a0","user":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"repo":{"id":125530367,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1MzAzNjc=","name":"telamon","full_name":"ulysseB/telamon","private":false,"owner":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ulysseB/telamon","description":"A framework to find good combinations of optimizations for computational kernels on GPUs.","fork":false,"url":"https://api.github.com/repos/ulysseB/telamon","forks_url":"https://api.github.com/repos/ulysseB/telamon/forks","keys_url":"https://api.github.com/repos/ulysseB/telamon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ulysseB/telamon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ulysseB/telamon/teams","hooks_url":"https://api.github.com/repos/ulysseB/telamon/hooks","issue_events_url":"https://api.github.com/repos/ulysseB/telamon/issues/events{/number}","events_url":"https://api.github.com/repos/ulysseB/telamon/events","assignees_url":"https://api.github.com/repos/ulysseB/telamon/assignees{/user}","branches_url":"https://api.github.com/repos/ulysseB/telamon/branches{/branch}","tags_url":"https://api.github.com/repos/ulysseB/telamon/tags","blobs_url":"https://api.github.com/repos/ulysseB/telamon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ulysseB/telamon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ulysseB/telamon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ulysseB/telamon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ulysseB/telamon/statuses/{sha}","languages_url":"https://api.github.com/repos/ulysseB/telamon/languages","stargazers_url":"https://api.github.com/repos/ulysseB/telamon/stargazers","contributors_url":"https://api.github.com/repos/ulysseB/telamon/contributors","subscribers_url":"https://api.github.com/repos/ulysseB/telamon/subscribers","subscription_url":"https://api.github.com/repos/ulysseB/telamon/subscription","commits_url":"https://api.github.com/repos/ulysseB/telamon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ulysseB/telamon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ulysseB/telamon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ulysseB/telamon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ulysseB/telamon/contents/{+path}","compare_url":"https://api.github.com/repos/ulysseB/telamon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ulysseB/telamon/merges","archive_url":"https://api.github.com/repos/ulysseB/telamon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ulysseB/telamon/downloads","issues_url":"https://api.github.com/repos/ulysseB/telamon/issues{/number}","pulls_url":"https://api.github.com/repos/ulysseB/telamon/pulls{/number}","milestones_url":"https://api.github.com/repos/ulysseB/telamon/milestones{/number}","notifications_url":"https://api.github.com/repos/ulysseB/telamon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ulysseB/telamon/labels{/name}","releases_url":"https://api.github.com/repos/ulysseB/telamon/releases{/id}","deployments_url":"https://api.github.com/repos/ulysseB/telamon/deployments","created_at":"2018-03-16T14:52:10Z","updated_at":"2018-10-11T08:13:57Z","pushed_at":"2018-10-12T15:38:00Z","git_url":"git://github.com/ulysseB/telamon.git","ssh_url":"git@github.com:ulysseB/telamon.git","clone_url":"https://github.com/ulysseB/telamon.git","svn_url":"https://github.com/ulysseB/telamon","homepage":"https://ulysseb.github.io/telamon/telamon","size":48797,"stargazers_count":6,"watchers_count":6,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":18,"watchers":6,"default_branch":"master"}},"base":{"label":"ulysseB:master","ref":"master","sha":"5700b76cfb65d384b5f64bc0eac55362493b068f","user":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"repo":{"id":125530367,"node_id":"MDEwOlJlcG9zaXRvcnkxMjU1MzAzNjc=","name":"telamon","full_name":"ulysseB/telamon","private":false,"owner":{"login":"ulysseB","id":1461855,"node_id":"MDQ6VXNlcjE0NjE4NTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1461855?v=4","gravatar_id":"","url":"https://api.github.com/users/ulysseB","html_url":"https://github.com/ulysseB","followers_url":"https://api.github.com/users/ulysseB/followers","following_url":"https://api.github.com/users/ulysseB/following{/other_user}","gists_url":"https://api.github.com/users/ulysseB/gists{/gist_id}","starred_url":"https://api.github.com/users/ulysseB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ulysseB/subscriptions","organizations_url":"https://api.github.com/users/ulysseB/orgs","repos_url":"https://api.github.com/users/ulysseB/repos","events_url":"https://api.github.com/users/ulysseB/events{/privacy}","received_events_url":"https://api.github.com/users/ulysseB/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ulysseB/telamon","description":"A framework to find good combinations of optimizations for computational kernels on GPUs.","fork":false,"url":"https://api.github.com/repos/ulysseB/telamon","forks_url":"https://api.github.com/repos/ulysseB/telamon/forks","keys_url":"https://api.github.com/repos/ulysseB/telamon/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ulysseB/telamon/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ulysseB/telamon/teams","hooks_url":"https://api.github.com/repos/ulysseB/telamon/hooks","issue_events_url":"https://api.github.com/repos/ulysseB/telamon/issues/events{/number}","events_url":"https://api.github.com/repos/ulysseB/telamon/events","assignees_url":"https://api.github.com/repos/ulysseB/telamon/assignees{/user}","branches_url":"https://api.github.com/repos/ulysseB/telamon/branches{/branch}","tags_url":"https://api.github.com/repos/ulysseB/telamon/tags","blobs_url":"https://api.github.com/repos/ulysseB/telamon/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ulysseB/telamon/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ulysseB/telamon/git/refs{/sha}","trees_url":"https://api.github.com/repos/ulysseB/telamon/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ulysseB/telamon/statuses/{sha}","languages_url":"https://api.github.com/repos/ulysseB/telamon/languages","stargazers_url":"https://api.github.com/repos/ulysseB/telamon/stargazers","contributors_url":"https://api.github.com/repos/ulysseB/telamon/contributors","subscribers_url":"https://api.github.com/repos/ulysseB/telamon/subscribers","subscription_url":"https://api.github.com/repos/ulysseB/telamon/subscription","commits_url":"https://api.github.com/repos/ulysseB/telamon/commits{/sha}","git_commits_url":"https://api.github.com/repos/ulysseB/telamon/git/commits{/sha}","comments_url":"https://api.github.com/repos/ulysseB/telamon/comments{/number}","issue_comment_url":"https://api.github.com/repos/ulysseB/telamon/issues/comments{/number}","contents_url":"https://api.github.com/repos/ulysseB/telamon/contents/{+path}","compare_url":"https://api.github.com/repos/ulysseB/telamon/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ulysseB/telamon/merges","archive_url":"https://api.github.com/repos/ulysseB/telamon/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ulysseB/telamon/downloads","issues_url":"https://api.github.com/repos/ulysseB/telamon/issues{/number}","pulls_url":"https://api.github.com/repos/ulysseB/telamon/pulls{/number}","milestones_url":"https://api.github.com/repos/ulysseB/telamon/milestones{/number}","notifications_url":"https://api.github.com/repos/ulysseB/telamon/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ulysseB/telamon/labels{/name}","releases_url":"https://api.github.com/repos/ulysseB/telamon/releases{/id}","deployments_url":"https://api.github.com/repos/ulysseB/telamon/deployments","created_at":"2018-03-16T14:52:10Z","updated_at":"2018-10-11T08:13:57Z","pushed_at":"2018-10-12T15:38:00Z","git_url":"git://github.com/ulysseB/telamon.git","ssh_url":"git@github.com:ulysseB/telamon.git","clone_url":"https://github.com/ulysseB/telamon.git","svn_url":"https://github.com/ulysseB/telamon","homepage":"https://ulysseb.github.io/telamon/telamon","size":48797,"stargazers_count":6,"watchers_count":6,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":3,"open_issues":18,"watchers":6,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/147"},"html":{"href":"https://github.com/ulysseB/telamon/pull/147"},"issue":{"href":"https://api.github.com/repos/ulysseB/telamon/issues/147"},"comments":{"href":"https://api.github.com/repos/ulysseB/telamon/issues/147/comments"},"review_comments":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/147/comments"},"review_comment":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ulysseB/telamon/pulls/147/commits"},"statuses":{"href":"https://api.github.com/repos/ulysseB/telamon/statuses/8414d82a7d0886d0c2210c0e5125ab7dd19fb7a0"}},"author_association":"OWNER"}}
{"actor":{"display_login":"ulysseB"}}