{"action":"created","comment":{"url":"https://api.github.com/repos/eth-cscs/arbor/pulls/comments/185490847","pull_request_review_id":116889298,"id":185490847,"diff_hunk":"@@ -53,20 +69,21 @@ std::string emit_cuda_cpp_source(const Module& module_, const std::string& ns) {\n \n     out <<\n         \"#include <\" << arb_header_prefix() << \"backends/gpu/mechanism.hpp>\\n\"\n-        \"#include <\" << arb_header_prefix() << \"backends/gpu/mechanism_ppack_base.hpp>\\n\"\n-        \"\\n\" << namespace_declaration_open(ns_components) <<\n-        \"\\n\";\n+        \"#include <\" << arb_header_prefix() << \"backends/gpu/mechanism_ppack_base.hpp>\\n\";\n+\n+    out << \"\\n\" << namespace_declaration_open(ns_components) << \"\\n\";\n \n     emit_common_defs(out, module_);\n \n     out <<\n-        \"void \" << class_name << \"_nrn_init_(int, \" << ppack_name << \"&);\\n\"\n-        \"void \" << class_name << \"_nrn_state_(int, \" << ppack_name << \"&);\\n\"\n-        \"void \" << class_name << \"_nrn_current_(int, \" << ppack_name << \"&);\\n\"\n-        \"void \" << class_name << \"_write_ions_(int, \" << ppack_name << \"&);\\n\";\n+        \"void \" << class_name << \"_nrn_init_(\" << ppack_name << \"&);\\n\"","path":"modcc/printer/cudaprinter.cpp","position":65,"original_position":65,"commit_id":"09c88e4e3a916e38fa9dd8dfe89e0aa655343101","original_commit_id":"06beb6255014571074e16d24158fdfab20baadc9","user":{"login":"halfflat","id":556816,"avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false},"body":"I think we should change them, but in a separate PR.","created_at":"2018-05-02T13:14:47Z","updated_at":"2018-05-02T13:14:47Z","html_url":"https://github.com/eth-cscs/arbor/pull/483#discussion_r185490847","pull_request_url":"https://api.github.com/repos/eth-cscs/arbor/pulls/483","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/comments/185490847"},"html":{"href":"https://github.com/eth-cscs/arbor/pull/483#discussion_r185490847"},"pull_request":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/483"}},"in_reply_to_id":184948067},"pull_request":{"url":"https://api.github.com/repos/eth-cscs/arbor/pulls/483","id":184633659,"html_url":"https://github.com/eth-cscs/arbor/pull/483","diff_url":"https://github.com/eth-cscs/arbor/pull/483.diff","patch_url":"https://github.com/eth-cscs/arbor/pull/483.patch","issue_url":"https://api.github.com/repos/eth-cscs/arbor/issues/483","number":483,"state":"open","locked":false,"title":"Complete CUDA back end for the new mechanism infrastructure.","user":{"login":"bcumming","id":384605,"avatar_url":"https://avatars0.githubusercontent.com/u/384605?v=4","gravatar_id":"","url":"https://api.github.com/users/bcumming","html_url":"https://github.com/bcumming","followers_url":"https://api.github.com/users/bcumming/followers","following_url":"https://api.github.com/users/bcumming/following{/other_user}","gists_url":"https://api.github.com/users/bcumming/gists{/gist_id}","starred_url":"https://api.github.com/users/bcumming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcumming/subscriptions","organizations_url":"https://api.github.com/users/bcumming/orgs","repos_url":"https://api.github.com/users/bcumming/repos","events_url":"https://api.github.com/users/bcumming/events{/privacy}","received_events_url":"https://api.github.com/users/bcumming/received_events","type":"User","site_admin":false},"body":"- Add CudaPrinter\r\n    * Use the CPrinter as a base and provide overrides for calls and variables.\r\n    * Reuse the other printer visitors and `cexpr_emit`.\r\n    * Small refactorings to expose some of the CPrinter code to CUDAPrinter\r\n    * Remove the `namespace_components` to simplify code.\r\n\r\n- Add std::ostream support for printing gpu `arb::gpu::shared_state`\r\n  (similar to existing printer for multicore shared state).\r\n\r\n- Fix bugs in the refactoring of the GPU back end.\r\n\r\n- Added `std::ostream` support for `device_view` types.\r\n    * For debugging convenience.","created_at":"2018-04-27T14:11:34Z","updated_at":"2018-05-02T13:14:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6909cfad3ee64d489a29bf1f1865ff2582548115","assignee":null,"assignees":[],"requested_reviewers":[{"login":"halfflat","id":556816,"avatar_url":"https://avatars1.githubusercontent.com/u/556816?v=4","gravatar_id":"","url":"https://api.github.com/users/halfflat","html_url":"https://github.com/halfflat","followers_url":"https://api.github.com/users/halfflat/followers","following_url":"https://api.github.com/users/halfflat/following{/other_user}","gists_url":"https://api.github.com/users/halfflat/gists{/gist_id}","starred_url":"https://api.github.com/users/halfflat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfflat/subscriptions","organizations_url":"https://api.github.com/users/halfflat/orgs","repos_url":"https://api.github.com/users/halfflat/repos","events_url":"https://api.github.com/users/halfflat/events{/privacy}","received_events_url":"https://api.github.com/users/halfflat/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eth-cscs/arbor/pulls/483/commits","review_comments_url":"https://api.github.com/repos/eth-cscs/arbor/pulls/483/comments","review_comment_url":"https://api.github.com/repos/eth-cscs/arbor/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eth-cscs/arbor/issues/483/comments","statuses_url":"https://api.github.com/repos/eth-cscs/arbor/statuses/09c88e4e3a916e38fa9dd8dfe89e0aa655343101","head":{"label":"bcumming:mech-refactor","ref":"mech-refactor","sha":"09c88e4e3a916e38fa9dd8dfe89e0aa655343101","user":{"login":"bcumming","id":384605,"avatar_url":"https://avatars0.githubusercontent.com/u/384605?v=4","gravatar_id":"","url":"https://api.github.com/users/bcumming","html_url":"https://github.com/bcumming","followers_url":"https://api.github.com/users/bcumming/followers","following_url":"https://api.github.com/users/bcumming/following{/other_user}","gists_url":"https://api.github.com/users/bcumming/gists{/gist_id}","starred_url":"https://api.github.com/users/bcumming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcumming/subscriptions","organizations_url":"https://api.github.com/users/bcumming/orgs","repos_url":"https://api.github.com/users/bcumming/repos","events_url":"https://api.github.com/users/bcumming/events{/privacy}","received_events_url":"https://api.github.com/users/bcumming/received_events","type":"User","site_admin":false},"repo":{"id":73794288,"name":"arbor","full_name":"bcumming/arbor","owner":{"login":"bcumming","id":384605,"avatar_url":"https://avatars0.githubusercontent.com/u/384605?v=4","gravatar_id":"","url":"https://api.github.com/users/bcumming","html_url":"https://github.com/bcumming","followers_url":"https://api.github.com/users/bcumming/followers","following_url":"https://api.github.com/users/bcumming/following{/other_user}","gists_url":"https://api.github.com/users/bcumming/gists{/gist_id}","starred_url":"https://api.github.com/users/bcumming/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bcumming/subscriptions","organizations_url":"https://api.github.com/users/bcumming/orgs","repos_url":"https://api.github.com/users/bcumming/repos","events_url":"https://api.github.com/users/bcumming/events{/privacy}","received_events_url":"https://api.github.com/users/bcumming/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bcumming/arbor","description":null,"fork":true,"url":"https://api.github.com/repos/bcumming/arbor","forks_url":"https://api.github.com/repos/bcumming/arbor/forks","keys_url":"https://api.github.com/repos/bcumming/arbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bcumming/arbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bcumming/arbor/teams","hooks_url":"https://api.github.com/repos/bcumming/arbor/hooks","issue_events_url":"https://api.github.com/repos/bcumming/arbor/issues/events{/number}","events_url":"https://api.github.com/repos/bcumming/arbor/events","assignees_url":"https://api.github.com/repos/bcumming/arbor/assignees{/user}","branches_url":"https://api.github.com/repos/bcumming/arbor/branches{/branch}","tags_url":"https://api.github.com/repos/bcumming/arbor/tags","blobs_url":"https://api.github.com/repos/bcumming/arbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bcumming/arbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bcumming/arbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/bcumming/arbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bcumming/arbor/statuses/{sha}","languages_url":"https://api.github.com/repos/bcumming/arbor/languages","stargazers_url":"https://api.github.com/repos/bcumming/arbor/stargazers","contributors_url":"https://api.github.com/repos/bcumming/arbor/contributors","subscribers_url":"https://api.github.com/repos/bcumming/arbor/subscribers","subscription_url":"https://api.github.com/repos/bcumming/arbor/subscription","commits_url":"https://api.github.com/repos/bcumming/arbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/bcumming/arbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/bcumming/arbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/bcumming/arbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/bcumming/arbor/contents/{+path}","compare_url":"https://api.github.com/repos/bcumming/arbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bcumming/arbor/merges","archive_url":"https://api.github.com/repos/bcumming/arbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bcumming/arbor/downloads","issues_url":"https://api.github.com/repos/bcumming/arbor/issues{/number}","pulls_url":"https://api.github.com/repos/bcumming/arbor/pulls{/number}","milestones_url":"https://api.github.com/repos/bcumming/arbor/milestones{/number}","notifications_url":"https://api.github.com/repos/bcumming/arbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bcumming/arbor/labels{/name}","releases_url":"https://api.github.com/repos/bcumming/arbor/releases{/id}","deployments_url":"https://api.github.com/repos/bcumming/arbor/deployments","created_at":"2016-11-15T08:47:50Z","updated_at":"2017-09-27T13:33:54Z","pushed_at":"2018-05-02T12:44:52Z","git_url":"git://github.com/bcumming/arbor.git","ssh_url":"git@github.com:bcumming/arbor.git","clone_url":"https://github.com/bcumming/arbor.git","svn_url":"https://github.com/bcumming/arbor","homepage":"","size":5139,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eth-cscs:mech-refactor","ref":"mech-refactor","sha":"1de7b378feaf2ab4159c636683c770cb22af0329","user":{"login":"eth-cscs","id":5744410,"avatar_url":"https://avatars0.githubusercontent.com/u/5744410?v=4","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"repo":{"id":69863074,"name":"arbor","full_name":"eth-cscs/arbor","owner":{"login":"eth-cscs","id":5744410,"avatar_url":"https://avatars0.githubusercontent.com/u/5744410?v=4","gravatar_id":"","url":"https://api.github.com/users/eth-cscs","html_url":"https://github.com/eth-cscs","followers_url":"https://api.github.com/users/eth-cscs/followers","following_url":"https://api.github.com/users/eth-cscs/following{/other_user}","gists_url":"https://api.github.com/users/eth-cscs/gists{/gist_id}","starred_url":"https://api.github.com/users/eth-cscs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eth-cscs/subscriptions","organizations_url":"https://api.github.com/users/eth-cscs/orgs","repos_url":"https://api.github.com/users/eth-cscs/repos","events_url":"https://api.github.com/users/eth-cscs/events{/privacy}","received_events_url":"https://api.github.com/users/eth-cscs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eth-cscs/arbor","description":"The Arbor multi-compartment neural network simulation library.","fork":false,"url":"https://api.github.com/repos/eth-cscs/arbor","forks_url":"https://api.github.com/repos/eth-cscs/arbor/forks","keys_url":"https://api.github.com/repos/eth-cscs/arbor/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eth-cscs/arbor/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eth-cscs/arbor/teams","hooks_url":"https://api.github.com/repos/eth-cscs/arbor/hooks","issue_events_url":"https://api.github.com/repos/eth-cscs/arbor/issues/events{/number}","events_url":"https://api.github.com/repos/eth-cscs/arbor/events","assignees_url":"https://api.github.com/repos/eth-cscs/arbor/assignees{/user}","branches_url":"https://api.github.com/repos/eth-cscs/arbor/branches{/branch}","tags_url":"https://api.github.com/repos/eth-cscs/arbor/tags","blobs_url":"https://api.github.com/repos/eth-cscs/arbor/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eth-cscs/arbor/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eth-cscs/arbor/git/refs{/sha}","trees_url":"https://api.github.com/repos/eth-cscs/arbor/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eth-cscs/arbor/statuses/{sha}","languages_url":"https://api.github.com/repos/eth-cscs/arbor/languages","stargazers_url":"https://api.github.com/repos/eth-cscs/arbor/stargazers","contributors_url":"https://api.github.com/repos/eth-cscs/arbor/contributors","subscribers_url":"https://api.github.com/repos/eth-cscs/arbor/subscribers","subscription_url":"https://api.github.com/repos/eth-cscs/arbor/subscription","commits_url":"https://api.github.com/repos/eth-cscs/arbor/commits{/sha}","git_commits_url":"https://api.github.com/repos/eth-cscs/arbor/git/commits{/sha}","comments_url":"https://api.github.com/repos/eth-cscs/arbor/comments{/number}","issue_comment_url":"https://api.github.com/repos/eth-cscs/arbor/issues/comments{/number}","contents_url":"https://api.github.com/repos/eth-cscs/arbor/contents/{+path}","compare_url":"https://api.github.com/repos/eth-cscs/arbor/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eth-cscs/arbor/merges","archive_url":"https://api.github.com/repos/eth-cscs/arbor/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eth-cscs/arbor/downloads","issues_url":"https://api.github.com/repos/eth-cscs/arbor/issues{/number}","pulls_url":"https://api.github.com/repos/eth-cscs/arbor/pulls{/number}","milestones_url":"https://api.github.com/repos/eth-cscs/arbor/milestones{/number}","notifications_url":"https://api.github.com/repos/eth-cscs/arbor/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eth-cscs/arbor/labels{/name}","releases_url":"https://api.github.com/repos/eth-cscs/arbor/releases{/id}","deployments_url":"https://api.github.com/repos/eth-cscs/arbor/deployments","created_at":"2016-10-03T11:03:22Z","updated_at":"2018-04-20T11:11:47Z","pushed_at":"2018-05-02T12:17:52Z","git_url":"git://github.com/eth-cscs/arbor.git","ssh_url":"git@github.com:eth-cscs/arbor.git","clone_url":"https://github.com/eth-cscs/arbor.git","svn_url":"https://github.com/eth-cscs/arbor","homepage":"","size":3435,"stargazers_count":15,"watchers_count":15,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":76,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":14,"open_issues":76,"watchers":15,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/483"},"html":{"href":"https://github.com/eth-cscs/arbor/pull/483"},"issue":{"href":"https://api.github.com/repos/eth-cscs/arbor/issues/483"},"comments":{"href":"https://api.github.com/repos/eth-cscs/arbor/issues/483/comments"},"review_comments":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/483/comments"},"review_comment":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eth-cscs/arbor/pulls/483/commits"},"statuses":{"href":"https://api.github.com/repos/eth-cscs/arbor/statuses/09c88e4e3a916e38fa9dd8dfe89e0aa655343101"}},"author_association":"OWNER"}}
{"actor":{"display_login":"halfflat"}}