{"action":"created","comment":{"url":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/comments/233202718","pull_request_review_id":174562082,"id":233202718,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzIwMjcxOA==","diff_hunk":"@@ -107,6 +101,40 @@ private void validateParameter(ParameterModel parameterModel, String ownerName,\n \n     }\n \n+    private void validateDefaultValue(ParameterModel parameterModel, String ownerName, String ownerModelType) {\n+      if (parameterModel.isOverrideFromConfig() &&\n+          !ownerModelType.equals(CONFIGURATION) && !ownerModelType.equals(CONNECTION_PROVIDER)) {\n+        // We skip failing for configs and connection here since a different error is thrown in their own validators\n+        addError(parameterModel,\n+                 \"Parameter '%s' in the %s '%s' is declared as a config override,\"\n+                     + \" and must not provide a default value since one is already provided by the value\"\n+                     + \" declared in the config parameter\",\n+                 parameterModel.getName(), ownerModelType, ownerName);\n+      } else if (parameterModel.isRequired()) {\n+        addError(parameterModel,\n+                 \"Parameter '%s' in the %s '%s' is required, and must not provide a default value\",\n+                 parameterModel.getName(), ownerModelType, ownerName);\n+      }\n+\n+      if (!hasExpressionDefaultValue(parameterModel)) {\n+        parameterModel.getType().accept(new MetadataTypeVisitor() {","path":"mule-extensions-api/src/main/java/org/mule/runtime/extension/internal/loader/validator/ParameterModelValidator.java","position":69,"original_position":69,"commit_id":"b94822d5c2e13dc05e2fccb8eb2c6ad2b2a9916d","original_commit_id":"e262f04eafaae5d9de9276709c646469698f9e5f","user":{"login":"ndinu","id":13604295,"node_id":"MDQ6VXNlcjEzNjA0Mjk1","avatar_url":"https://avatars2.githubusercontent.com/u/13604295?v=4","gravatar_id":"","url":"https://api.github.com/users/ndinu","html_url":"https://github.com/ndinu","followers_url":"https://api.github.com/users/ndinu/followers","following_url":"https://api.github.com/users/ndinu/following{/other_user}","gists_url":"https://api.github.com/users/ndinu/gists{/gist_id}","starred_url":"https://api.github.com/users/ndinu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ndinu/subscriptions","organizations_url":"https://api.github.com/users/ndinu/orgs","repos_url":"https://api.github.com/users/ndinu/repos","events_url":"https://api.github.com/users/ndinu/events{/privacy}","received_events_url":"https://api.github.com/users/ndinu/received_events","type":"User","site_admin":false},"body":"disregard","created_at":"2018-11-13T20:05:09Z","updated_at":"2018-11-13T20:05:09Z","html_url":"https://github.com/mulesoft/mule-extensions-api/pull/615#discussion_r233202718","pull_request_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/615","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/comments/233202718"},"html":{"href":"https://github.com/mulesoft/mule-extensions-api/pull/615#discussion_r233202718"},"pull_request":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/615"}},"in_reply_to_id":233189868},"pull_request":{"url":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/615","id":230592585,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNTkyNTg1","html_url":"https://github.com/mulesoft/mule-extensions-api/pull/615","diff_url":"https://github.com/mulesoft/mule-extensions-api/pull/615.diff","patch_url":"https://github.com/mulesoft/mule-extensions-api/pull/615.patch","issue_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues/615","number":615,"state":"open","locked":false,"title":"MULE-14844: SDK should validate that the given default value of an En…","user":{"login":"pangelani","id":2547079,"node_id":"MDQ6VXNlcjI1NDcwNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/2547079?v=4","gravatar_id":"","url":"https://api.github.com/users/pangelani","html_url":"https://github.com/pangelani","followers_url":"https://api.github.com/users/pangelani/followers","following_url":"https://api.github.com/users/pangelani/following{/other_user}","gists_url":"https://api.github.com/users/pangelani/gists{/gist_id}","starred_url":"https://api.github.com/users/pangelani/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pangelani/subscriptions","organizations_url":"https://api.github.com/users/pangelani/orgs","repos_url":"https://api.github.com/users/pangelani/repos","events_url":"https://api.github.com/users/pangelani/events{/privacy}","received_events_url":"https://api.github.com/users/pangelani/received_events","type":"User","site_admin":false},"body":"…um parameter is a valid value.","created_at":"2018-11-13T19:12:39Z","updated_at":"2018-11-13T20:05:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"97799c87813fffe506e47cf4a30a5cba7d975862","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/615/commits","review_comments_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/615/comments","review_comment_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues/615/comments","statuses_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/statuses/b94822d5c2e13dc05e2fccb8eb2c6ad2b2a9916d","head":{"label":"mulesoft:MULE-14844","ref":"MULE-14844","sha":"b94822d5c2e13dc05e2fccb8eb2c6ad2b2a9916d","user":{"login":"mulesoft","id":185740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/185740?v=4","gravatar_id":"","url":"https://api.github.com/users/mulesoft","html_url":"https://github.com/mulesoft","followers_url":"https://api.github.com/users/mulesoft/followers","following_url":"https://api.github.com/users/mulesoft/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft/subscriptions","organizations_url":"https://api.github.com/users/mulesoft/orgs","repos_url":"https://api.github.com/users/mulesoft/repos","events_url":"https://api.github.com/users/mulesoft/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft/received_events","type":"Organization","site_admin":false},"repo":{"id":26641628,"node_id":"MDEwOlJlcG9zaXRvcnkyNjY0MTYyOA==","name":"mule-extensions-api","full_name":"mulesoft/mule-extensions-api","private":false,"owner":{"login":"mulesoft","id":185740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/185740?v=4","gravatar_id":"","url":"https://api.github.com/users/mulesoft","html_url":"https://github.com/mulesoft","followers_url":"https://api.github.com/users/mulesoft/followers","following_url":"https://api.github.com/users/mulesoft/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft/subscriptions","organizations_url":"https://api.github.com/users/mulesoft/orgs","repos_url":"https://api.github.com/users/mulesoft/repos","events_url":"https://api.github.com/users/mulesoft/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mulesoft/mule-extensions-api","description":"Mule Extensions API","fork":false,"url":"https://api.github.com/repos/mulesoft/mule-extensions-api","forks_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/forks","keys_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/teams","hooks_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/hooks","issue_events_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues/events{/number}","events_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/events","assignees_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/assignees{/user}","branches_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/branches{/branch}","tags_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/tags","blobs_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/statuses/{sha}","languages_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/languages","stargazers_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/stargazers","contributors_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/contributors","subscribers_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/subscribers","subscription_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/subscription","commits_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/contents/{+path}","compare_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/merges","archive_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/downloads","issues_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues{/number}","pulls_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls{/number}","milestones_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/milestones{/number}","notifications_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/labels{/name}","releases_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/releases{/id}","deployments_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/deployments","created_at":"2014-11-14T14:18:37Z","updated_at":"2018-11-05T15:28:24Z","pushed_at":"2018-11-13T19:47:52Z","git_url":"git://github.com/mulesoft/mule-extensions-api.git","ssh_url":"git@github.com:mulesoft/mule-extensions-api.git","clone_url":"https://github.com/mulesoft/mule-extensions-api.git","svn_url":"https://github.com/mulesoft/mule-extensions-api","homepage":null,"size":2951,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":4,"watchers":1,"default_branch":"master"}},"base":{"label":"mulesoft:master","ref":"master","sha":"dc23ad245621c1034c9fa02e506965933d945612","user":{"login":"mulesoft","id":185740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/185740?v=4","gravatar_id":"","url":"https://api.github.com/users/mulesoft","html_url":"https://github.com/mulesoft","followers_url":"https://api.github.com/users/mulesoft/followers","following_url":"https://api.github.com/users/mulesoft/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft/subscriptions","organizations_url":"https://api.github.com/users/mulesoft/orgs","repos_url":"https://api.github.com/users/mulesoft/repos","events_url":"https://api.github.com/users/mulesoft/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft/received_events","type":"Organization","site_admin":false},"repo":{"id":26641628,"node_id":"MDEwOlJlcG9zaXRvcnkyNjY0MTYyOA==","name":"mule-extensions-api","full_name":"mulesoft/mule-extensions-api","private":false,"owner":{"login":"mulesoft","id":185740,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/185740?v=4","gravatar_id":"","url":"https://api.github.com/users/mulesoft","html_url":"https://github.com/mulesoft","followers_url":"https://api.github.com/users/mulesoft/followers","following_url":"https://api.github.com/users/mulesoft/following{/other_user}","gists_url":"https://api.github.com/users/mulesoft/gists{/gist_id}","starred_url":"https://api.github.com/users/mulesoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mulesoft/subscriptions","organizations_url":"https://api.github.com/users/mulesoft/orgs","repos_url":"https://api.github.com/users/mulesoft/repos","events_url":"https://api.github.com/users/mulesoft/events{/privacy}","received_events_url":"https://api.github.com/users/mulesoft/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/mulesoft/mule-extensions-api","description":"Mule Extensions API","fork":false,"url":"https://api.github.com/repos/mulesoft/mule-extensions-api","forks_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/forks","keys_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/teams","hooks_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/hooks","issue_events_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues/events{/number}","events_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/events","assignees_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/assignees{/user}","branches_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/branches{/branch}","tags_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/tags","blobs_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/statuses/{sha}","languages_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/languages","stargazers_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/stargazers","contributors_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/contributors","subscribers_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/subscribers","subscription_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/subscription","commits_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/contents/{+path}","compare_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/merges","archive_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/downloads","issues_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues{/number}","pulls_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls{/number}","milestones_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/milestones{/number}","notifications_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/labels{/name}","releases_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/releases{/id}","deployments_url":"https://api.github.com/repos/mulesoft/mule-extensions-api/deployments","created_at":"2014-11-14T14:18:37Z","updated_at":"2018-11-05T15:28:24Z","pushed_at":"2018-11-13T19:47:52Z","git_url":"git://github.com/mulesoft/mule-extensions-api.git","ssh_url":"git@github.com:mulesoft/mule-extensions-api.git","clone_url":"https://github.com/mulesoft/mule-extensions-api.git","svn_url":"https://github.com/mulesoft/mule-extensions-api","homepage":null,"size":2951,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":3,"open_issues":4,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/615"},"html":{"href":"https://github.com/mulesoft/mule-extensions-api/pull/615"},"issue":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues/615"},"comments":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/issues/615/comments"},"review_comments":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/615/comments"},"review_comment":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/pulls/615/commits"},"statuses":{"href":"https://api.github.com/repos/mulesoft/mule-extensions-api/statuses/b94822d5c2e13dc05e2fccb8eb2c6ad2b2a9916d"}},"author_association":"NONE"}}
{"actor":{"display_login":"ndinu"}}