{"action":"created","issue":{"url":"https://api.github.com/repos/odoo/odoo/issues/23144","repository_url":"https://api.github.com/repos/odoo/odoo","labels_url":"https://api.github.com/repos/odoo/odoo/issues/23144/labels{/name}","comments_url":"https://api.github.com/repos/odoo/odoo/issues/23144/comments","events_url":"https://api.github.com/repos/odoo/odoo/issues/23144/events","html_url":"https://github.com/odoo/odoo/pull/23144","id":298207302,"number":23144,"title":"[FIX] web: prevent breaking backend w/ xml format\n","user":{"login":"nle-odoo","id":9977887,"avatar_url":"https://avatars2.githubusercontent.com/u/9977887?v=4","gravatar_id":"","url":"https://api.github.com/users/nle-odoo","html_url":"https://github.com/nle-odoo","followers_url":"https://api.github.com/users/nle-odoo/followers","following_url":"https://api.github.com/users/nle-odoo/following{/other_user}","gists_url":"https://api.github.com/users/nle-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/nle-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nle-odoo/subscriptions","organizations_url":"https://api.github.com/users/nle-odoo/orgs","repos_url":"https://api.github.com/users/nle-odoo/repos","events_url":"https://api.github.com/users/nle-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/nle-odoo/received_events","type":"User","site_admin":false},"labels":[{"id":106174181,"url":"https://api.github.com/repos/odoo/odoo/labels/OE","name":"OE","color":"a24689","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-19T09:25:02Z","updated_at":"2018-02-20T10:03:37Z","closed_at":"2018-02-20T10:03:37Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/odoo/odoo/pulls/23144","html_url":"https://github.com/odoo/odoo/pull/23144","diff_url":"https://github.com/odoo/odoo/pull/23144.diff","patch_url":"https://github.com/odoo/odoo/pull/23144.patch"},"body":"[FIX] web: prevent breaking backend w/ xml format\r\n\r\nIt happen from time to time that someone use \"Format\" on the web.layout\r\ntemplate. Thus:\r\n\r\n```\r\n  <script type=\"text/javascript\">\r\n      var odoo = {\r\n          csrf_token: \"<t t-esc=\"request.csrf_token(None)\"/>\",\r\n      };\r\n  </script>\r\n```\r\n\r\nbecomes:\r\n\r\n```\r\n  <script type=\"text/javascript\">\r\n      var odoo = {\r\n          csrf_token: \"\r\n      <t t-esc=\"request.csrf_token(None)\"/>\",\r\n      };\r\n  </script>\r\n```\r\n\r\nbreaking a number of things on the frontend and everything on the\r\nbackend.\r\n\r\nOn a pure javascript content, we could wrap it with:\r\n\r\n```\r\n  //<![CDATA[\r\n  /* javascript content */\r\n  //]]>\r\n```\r\n\r\nbut in this instance we still want the xml to be processed and the\r\nformatting is done in an external library we don't want to modify.\r\n\r\nSo this fix just avoids the issue.\r\n\r\nopw-815865\r\ncloses #23144"},"comment":{"url":"https://api.github.com/repos/odoo/odoo/issues/comments/366927645","html_url":"https://github.com/odoo/odoo/pull/23144#issuecomment-366927645","issue_url":"https://api.github.com/repos/odoo/odoo/issues/23144","id":366927645,"user":{"login":"nle-odoo","id":9977887,"avatar_url":"https://avatars2.githubusercontent.com/u/9977887?v=4","gravatar_id":"","url":"https://api.github.com/users/nle-odoo","html_url":"https://github.com/nle-odoo","followers_url":"https://api.github.com/users/nle-odoo/followers","following_url":"https://api.github.com/users/nle-odoo/following{/other_user}","gists_url":"https://api.github.com/users/nle-odoo/gists{/gist_id}","starred_url":"https://api.github.com/users/nle-odoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nle-odoo/subscriptions","organizations_url":"https://api.github.com/users/nle-odoo/orgs","repos_url":"https://api.github.com/users/nle-odoo/repos","events_url":"https://api.github.com/users/nle-odoo/events{/privacy}","received_events_url":"https://api.github.com/users/nle-odoo/received_events","type":"User","site_admin":false},"created_at":"2018-02-20T10:03:37Z","updated_at":"2018-02-20T10:03:37Z","author_association":"CONTRIBUTOR","body":"closed and the XML formatting behavior will be changed with #23164"}}
{"actor":{"display_login":"nle-odoo"}}