{"action":"created","comment":{"url":"https://api.github.com/repos/osrf/gzdev/pulls/comments/207187289","pull_request_review_id":142745593,"id":207187289,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzE4NzI4OQ==","diff_hunk":"@@ -17,8 +17,18 @@ RUN bash -c 'source /etc/os-release && \\\n RUN curl https://xpra.org/gpg.asc | apt-key add -\n RUN curl http://packages.osrfoundation.org/gazebo.key | apt-key add -\n RUN apt-get update && apt-get install -y xpra=2.3.*\n-RUN apt-get update && apt-get install -y gazebo$GZV\n-RUN apt-get clean && rm -rf /var/lib/apt/lists/* /tmp/* /var/tmp/*\n+RUN apt-get update && apt-get install -y build-essential cmake debhelper mesa-utils cppcheck xsltproc python-lxml python-psutil python bc netcat-openbsd gnupg2 net-tools locales\n+RUN apt-get update && apt-get install -y libfreeimage-dev libprotoc-dev libprotobuf-dev protobuf-compiler freeglut3-dev libcurl4-openssl-dev libtinyxml-dev libtar-dev libtbb-dev libogre-1.9-dev libxml2-dev pkg-config qtbase5-dev libqwt-qt5-dev libltdl-dev libgts-dev libboost-thread-dev libboost-signals-dev libboost-system-dev libboost-filesystem-dev libboost-program-options-dev libboost-regex-dev libboost-iostreams-dev libbullet-dev libsimbody-dev libignition-common-dev libignition-fuel-tools-dev libignition-transport4-dev libignition-math4-dev libignition-msgs-dev libtinyxml2-dev libsdformat6-dev","path":"docker/gazebo/gzsource/Dockerfile","position":7,"original_position":7,"commit_id":"598b6c84cc285ea0028ec159cbaa3ba48a400e5b","original_commit_id":"598b6c84cc285ea0028ec159cbaa3ba48a400e5b","user":{"login":"j-rivero","id":2098802,"node_id":"MDQ6VXNlcjIwOTg4MDI=","avatar_url":"https://avatars3.githubusercontent.com/u/2098802?v=4","gravatar_id":"","url":"https://api.github.com/users/j-rivero","html_url":"https://github.com/j-rivero","followers_url":"https://api.github.com/users/j-rivero/followers","following_url":"https://api.github.com/users/j-rivero/following{/other_user}","gists_url":"https://api.github.com/users/j-rivero/gists{/gist_id}","starred_url":"https://api.github.com/users/j-rivero/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/j-rivero/subscriptions","organizations_url":"https://api.github.com/users/j-rivero/orgs","repos_url":"https://api.github.com/users/j-rivero/repos","events_url":"https://api.github.com/users/j-rivero/events{/privacy}","received_events_url":"https://api.github.com/users/j-rivero/received_events","type":"User","site_admin":false},"body":"these are probably the dependencies for gazebo9. If we hardcoded them here directly, how are we going to handle the different versions of Gazebo supported?\r\n\r\nAlso please note that the .repos file will bring the sources for ignition, sdformat and gazebo so we probably don't want to have the binary packages installed.","created_at":"2018-08-02T11:09:56Z","updated_at":"2018-08-02T11:10:25Z","html_url":"https://github.com/osrf/gzdev/pull/4#discussion_r207187289","pull_request_url":"https://api.github.com/repos/osrf/gzdev/pulls/4","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/osrf/gzdev/pulls/comments/207187289"},"html":{"href":"https://github.com/osrf/gzdev/pull/4#discussion_r207187289"},"pull_request":{"href":"https://api.github.com/repos/osrf/gzdev/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/osrf/gzdev/pulls/4","id":205673490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NjczNDkw","html_url":"https://github.com/osrf/gzdev/pull/4","diff_url":"https://github.com/osrf/gzdev/pull/4.diff","patch_url":"https://github.com/osrf/gzdev/pull/4.patch","issue_url":"https://api.github.com/repos/osrf/gzdev/issues/4","number":4,"state":"open","locked":false,"title":"[Feature] Implement option to install Gazebo from source.","user":{"login":"rosatamsen","id":2343554,"node_id":"MDQ6VXNlcjIzNDM1NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2343554?v=4","gravatar_id":"","url":"https://api.github.com/users/rosatamsen","html_url":"https://github.com/rosatamsen","followers_url":"https://api.github.com/users/rosatamsen/followers","following_url":"https://api.github.com/users/rosatamsen/following{/other_user}","gists_url":"https://api.github.com/users/rosatamsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rosatamsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosatamsen/subscriptions","organizations_url":"https://api.github.com/users/rosatamsen/orgs","repos_url":"https://api.github.com/users/rosatamsen/repos","events_url":"https://api.github.com/users/rosatamsen/events{/privacy}","received_events_url":"https://api.github.com/users/rosatamsen/received_events","type":"User","site_admin":false},"body":"- [X] Create basic Dockerfile that builds dependencies and sets up source repos for Gazebo 9\r\n- [ ] Add shared volume between container and host file system for the source code directory\r\n- [ ] Add `--source` option to gzdev command\r\n- [ ] Support Gazebo 7, 8, and 9 source install utilizing a more generic Dockerfile as template\r\n\r\n\r\n<!-- Reviewable:start -->\r\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/osrf/gzdev/4)\r\n<!-- Reviewable:end -->\r\n","created_at":"2018-08-02T09:34:40Z","updated_at":"2018-08-02T11:10:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"14ef8f6699bd2fb55d06331f5927474301ce9b3f","assignee":{"login":"rosatamsen","id":2343554,"node_id":"MDQ6VXNlcjIzNDM1NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2343554?v=4","gravatar_id":"","url":"https://api.github.com/users/rosatamsen","html_url":"https://github.com/rosatamsen","followers_url":"https://api.github.com/users/rosatamsen/followers","following_url":"https://api.github.com/users/rosatamsen/following{/other_user}","gists_url":"https://api.github.com/users/rosatamsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rosatamsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosatamsen/subscriptions","organizations_url":"https://api.github.com/users/rosatamsen/orgs","repos_url":"https://api.github.com/users/rosatamsen/repos","events_url":"https://api.github.com/users/rosatamsen/events{/privacy}","received_events_url":"https://api.github.com/users/rosatamsen/received_events","type":"User","site_admin":false},"assignees":[{"login":"rosatamsen","id":2343554,"node_id":"MDQ6VXNlcjIzNDM1NTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2343554?v=4","gravatar_id":"","url":"https://api.github.com/users/rosatamsen","html_url":"https://github.com/rosatamsen","followers_url":"https://api.github.com/users/rosatamsen/followers","following_url":"https://api.github.com/users/rosatamsen/following{/other_user}","gists_url":"https://api.github.com/users/rosatamsen/gists{/gist_id}","starred_url":"https://api.github.com/users/rosatamsen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rosatamsen/subscriptions","organizations_url":"https://api.github.com/users/rosatamsen/orgs","repos_url":"https://api.github.com/users/rosatamsen/repos","events_url":"https://api.github.com/users/rosatamsen/events{/privacy}","received_events_url":"https://api.github.com/users/rosatamsen/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/osrf/gzdev/pulls/4/commits","review_comments_url":"https://api.github.com/repos/osrf/gzdev/pulls/4/comments","review_comment_url":"https://api.github.com/repos/osrf/gzdev/pulls/comments{/number}","comments_url":"https://api.github.com/repos/osrf/gzdev/issues/4/comments","statuses_url":"https://api.github.com/repos/osrf/gzdev/statuses/598b6c84cc285ea0028ec159cbaa3ba48a400e5b","head":{"label":"osrf:gz-src-install","ref":"gz-src-install","sha":"598b6c84cc285ea0028ec159cbaa3ba48a400e5b","user":{"login":"osrf","id":3999730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTk3MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3999730?v=4","gravatar_id":"","url":"https://api.github.com/users/osrf","html_url":"https://github.com/osrf","followers_url":"https://api.github.com/users/osrf/followers","following_url":"https://api.github.com/users/osrf/following{/other_user}","gists_url":"https://api.github.com/users/osrf/gists{/gist_id}","starred_url":"https://api.github.com/users/osrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrf/subscriptions","organizations_url":"https://api.github.com/users/osrf/orgs","repos_url":"https://api.github.com/users/osrf/repos","events_url":"https://api.github.com/users/osrf/events{/privacy}","received_events_url":"https://api.github.com/users/osrf/received_events","type":"Organization","site_admin":false},"repo":{"id":135458600,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0NTg2MDA=","name":"gzdev","full_name":"osrf/gzdev","owner":{"login":"osrf","id":3999730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTk3MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3999730?v=4","gravatar_id":"","url":"https://api.github.com/users/osrf","html_url":"https://github.com/osrf","followers_url":"https://api.github.com/users/osrf/followers","following_url":"https://api.github.com/users/osrf/following{/other_user}","gists_url":"https://api.github.com/users/osrf/gists{/gist_id}","starred_url":"https://api.github.com/users/osrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrf/subscriptions","organizations_url":"https://api.github.com/users/osrf/orgs","repos_url":"https://api.github.com/users/osrf/repos","events_url":"https://api.github.com/users/osrf/events{/privacy}","received_events_url":"https://api.github.com/users/osrf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osrf/gzdev","description":"Gazebo developers tool is an Outreachy project designed to facilitate many of the usual tasks that Gazebo developers face daily","fork":false,"url":"https://api.github.com/repos/osrf/gzdev","forks_url":"https://api.github.com/repos/osrf/gzdev/forks","keys_url":"https://api.github.com/repos/osrf/gzdev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osrf/gzdev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osrf/gzdev/teams","hooks_url":"https://api.github.com/repos/osrf/gzdev/hooks","issue_events_url":"https://api.github.com/repos/osrf/gzdev/issues/events{/number}","events_url":"https://api.github.com/repos/osrf/gzdev/events","assignees_url":"https://api.github.com/repos/osrf/gzdev/assignees{/user}","branches_url":"https://api.github.com/repos/osrf/gzdev/branches{/branch}","tags_url":"https://api.github.com/repos/osrf/gzdev/tags","blobs_url":"https://api.github.com/repos/osrf/gzdev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osrf/gzdev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osrf/gzdev/git/refs{/sha}","trees_url":"https://api.github.com/repos/osrf/gzdev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osrf/gzdev/statuses/{sha}","languages_url":"https://api.github.com/repos/osrf/gzdev/languages","stargazers_url":"https://api.github.com/repos/osrf/gzdev/stargazers","contributors_url":"https://api.github.com/repos/osrf/gzdev/contributors","subscribers_url":"https://api.github.com/repos/osrf/gzdev/subscribers","subscription_url":"https://api.github.com/repos/osrf/gzdev/subscription","commits_url":"https://api.github.com/repos/osrf/gzdev/commits{/sha}","git_commits_url":"https://api.github.com/repos/osrf/gzdev/git/commits{/sha}","comments_url":"https://api.github.com/repos/osrf/gzdev/comments{/number}","issue_comment_url":"https://api.github.com/repos/osrf/gzdev/issues/comments{/number}","contents_url":"https://api.github.com/repos/osrf/gzdev/contents/{+path}","compare_url":"https://api.github.com/repos/osrf/gzdev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osrf/gzdev/merges","archive_url":"https://api.github.com/repos/osrf/gzdev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osrf/gzdev/downloads","issues_url":"https://api.github.com/repos/osrf/gzdev/issues{/number}","pulls_url":"https://api.github.com/repos/osrf/gzdev/pulls{/number}","milestones_url":"https://api.github.com/repos/osrf/gzdev/milestones{/number}","notifications_url":"https://api.github.com/repos/osrf/gzdev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osrf/gzdev/labels{/name}","releases_url":"https://api.github.com/repos/osrf/gzdev/releases{/id}","deployments_url":"https://api.github.com/repos/osrf/gzdev/deployments","created_at":"2018-05-30T14:56:48Z","updated_at":"2018-07-26T20:56:05Z","pushed_at":"2018-08-02T09:36:15Z","git_url":"git://github.com/osrf/gzdev.git","ssh_url":"git@github.com:osrf/gzdev.git","clone_url":"https://github.com/osrf/gzdev.git","svn_url":"https://github.com/osrf/gzdev","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"osrf:alpha","ref":"alpha","sha":"9ad76f4aadaf07dabed35c1d498c158a1a1225ab","user":{"login":"osrf","id":3999730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTk3MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3999730?v=4","gravatar_id":"","url":"https://api.github.com/users/osrf","html_url":"https://github.com/osrf","followers_url":"https://api.github.com/users/osrf/followers","following_url":"https://api.github.com/users/osrf/following{/other_user}","gists_url":"https://api.github.com/users/osrf/gists{/gist_id}","starred_url":"https://api.github.com/users/osrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrf/subscriptions","organizations_url":"https://api.github.com/users/osrf/orgs","repos_url":"https://api.github.com/users/osrf/repos","events_url":"https://api.github.com/users/osrf/events{/privacy}","received_events_url":"https://api.github.com/users/osrf/received_events","type":"Organization","site_admin":false},"repo":{"id":135458600,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU0NTg2MDA=","name":"gzdev","full_name":"osrf/gzdev","owner":{"login":"osrf","id":3999730,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5OTk3MzA=","avatar_url":"https://avatars0.githubusercontent.com/u/3999730?v=4","gravatar_id":"","url":"https://api.github.com/users/osrf","html_url":"https://github.com/osrf","followers_url":"https://api.github.com/users/osrf/followers","following_url":"https://api.github.com/users/osrf/following{/other_user}","gists_url":"https://api.github.com/users/osrf/gists{/gist_id}","starred_url":"https://api.github.com/users/osrf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/osrf/subscriptions","organizations_url":"https://api.github.com/users/osrf/orgs","repos_url":"https://api.github.com/users/osrf/repos","events_url":"https://api.github.com/users/osrf/events{/privacy}","received_events_url":"https://api.github.com/users/osrf/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/osrf/gzdev","description":"Gazebo developers tool is an Outreachy project designed to facilitate many of the usual tasks that Gazebo developers face daily","fork":false,"url":"https://api.github.com/repos/osrf/gzdev","forks_url":"https://api.github.com/repos/osrf/gzdev/forks","keys_url":"https://api.github.com/repos/osrf/gzdev/keys{/key_id}","collaborators_url":"https://api.github.com/repos/osrf/gzdev/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/osrf/gzdev/teams","hooks_url":"https://api.github.com/repos/osrf/gzdev/hooks","issue_events_url":"https://api.github.com/repos/osrf/gzdev/issues/events{/number}","events_url":"https://api.github.com/repos/osrf/gzdev/events","assignees_url":"https://api.github.com/repos/osrf/gzdev/assignees{/user}","branches_url":"https://api.github.com/repos/osrf/gzdev/branches{/branch}","tags_url":"https://api.github.com/repos/osrf/gzdev/tags","blobs_url":"https://api.github.com/repos/osrf/gzdev/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/osrf/gzdev/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/osrf/gzdev/git/refs{/sha}","trees_url":"https://api.github.com/repos/osrf/gzdev/git/trees{/sha}","statuses_url":"https://api.github.com/repos/osrf/gzdev/statuses/{sha}","languages_url":"https://api.github.com/repos/osrf/gzdev/languages","stargazers_url":"https://api.github.com/repos/osrf/gzdev/stargazers","contributors_url":"https://api.github.com/repos/osrf/gzdev/contributors","subscribers_url":"https://api.github.com/repos/osrf/gzdev/subscribers","subscription_url":"https://api.github.com/repos/osrf/gzdev/subscription","commits_url":"https://api.github.com/repos/osrf/gzdev/commits{/sha}","git_commits_url":"https://api.github.com/repos/osrf/gzdev/git/commits{/sha}","comments_url":"https://api.github.com/repos/osrf/gzdev/comments{/number}","issue_comment_url":"https://api.github.com/repos/osrf/gzdev/issues/comments{/number}","contents_url":"https://api.github.com/repos/osrf/gzdev/contents/{+path}","compare_url":"https://api.github.com/repos/osrf/gzdev/compare/{base}...{head}","merges_url":"https://api.github.com/repos/osrf/gzdev/merges","archive_url":"https://api.github.com/repos/osrf/gzdev/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/osrf/gzdev/downloads","issues_url":"https://api.github.com/repos/osrf/gzdev/issues{/number}","pulls_url":"https://api.github.com/repos/osrf/gzdev/pulls{/number}","milestones_url":"https://api.github.com/repos/osrf/gzdev/milestones{/number}","notifications_url":"https://api.github.com/repos/osrf/gzdev/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/osrf/gzdev/labels{/name}","releases_url":"https://api.github.com/repos/osrf/gzdev/releases{/id}","deployments_url":"https://api.github.com/repos/osrf/gzdev/deployments","created_at":"2018-05-30T14:56:48Z","updated_at":"2018-07-26T20:56:05Z","pushed_at":"2018-08-02T09:36:15Z","git_url":"git://github.com/osrf/gzdev.git","ssh_url":"git@github.com:osrf/gzdev.git","clone_url":"https://github.com/osrf/gzdev.git","svn_url":"https://github.com/osrf/gzdev","homepage":null,"size":67,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/osrf/gzdev/pulls/4"},"html":{"href":"https://github.com/osrf/gzdev/pull/4"},"issue":{"href":"https://api.github.com/repos/osrf/gzdev/issues/4"},"comments":{"href":"https://api.github.com/repos/osrf/gzdev/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/osrf/gzdev/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/osrf/gzdev/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/osrf/gzdev/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/osrf/gzdev/statuses/598b6c84cc285ea0028ec159cbaa3ba48a400e5b"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"j-rivero"}}