{"action":"created","comment":{"url":"https://api.github.com/repos/paypal/downshift/pulls/comments/185030154","pull_request_review_id":116339446,"id":185030154,"diff_hunk":"@@ -161,32 +167,74 @@ test(`getItemProps doesn't include event handlers when disabled is passed (for I\n   }\n })\n \n+test(`disabled item can't be selected by pressing enter`, () => {\n+  const items = [\n+    {item: 'Chess', disabled: true},\n+    {item: 'Dominion', disabled: true},\n+    {item: 'Checkers', disabled: true},\n+  ]\n+  const utils = renderDownshift({items})\n+  const {input, arrowDownInput, enterOnInput, changeInputValue} = utils\n+\n+  const firstItem = utils.queryByTestId('item-0')\n+  expect(firstItem.hasAttribute('disabled')).toBe(true)\n+\n+  // input.simulate('keydown')","path":"src/__tests__/downshift.get-item-props.js","position":50,"original_position":50,"commit_id":"49e9d0f462d9a191c52cb9dfdee98a2a0b6070e6","original_commit_id":"49e9d0f462d9a191c52cb9dfdee98a2a0b6070e6","user":{"login":"kentcdodds","id":1500684,"avatar_url":"https://avatars0.githubusercontent.com/u/1500684?v=4","gravatar_id":"","url":"https://api.github.com/users/kentcdodds","html_url":"https://github.com/kentcdodds","followers_url":"https://api.github.com/users/kentcdodds/followers","following_url":"https://api.github.com/users/kentcdodds/following{/other_user}","gists_url":"https://api.github.com/users/kentcdodds/gists{/gist_id}","starred_url":"https://api.github.com/users/kentcdodds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kentcdodds/subscriptions","organizations_url":"https://api.github.com/users/kentcdodds/orgs","repos_url":"https://api.github.com/users/kentcdodds/repos","events_url":"https://api.github.com/users/kentcdodds/events{/privacy}","received_events_url":"https://api.github.com/users/kentcdodds/received_events","type":"User","site_admin":false},"body":"This comment here doesn't add anything I think. The name of the function is sufficient documentation :)","created_at":"2018-04-30T15:59:33Z","updated_at":"2018-04-30T16:01:35Z","html_url":"https://github.com/paypal/downshift/pull/436#discussion_r185030154","pull_request_url":"https://api.github.com/repos/paypal/downshift/pulls/436","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/paypal/downshift/pulls/comments/185030154"},"html":{"href":"https://github.com/paypal/downshift/pull/436#discussion_r185030154"},"pull_request":{"href":"https://api.github.com/repos/paypal/downshift/pulls/436"}}},"pull_request":{"url":"https://api.github.com/repos/paypal/downshift/pulls/436","id":184934512,"html_url":"https://github.com/paypal/downshift/pull/436","diff_url":"https://github.com/paypal/downshift/pull/436.diff","patch_url":"https://github.com/paypal/downshift/pull/436.patch","issue_url":"https://api.github.com/repos/paypal/downshift/issues/436","number":436,"state":"open","locked":false,"title":"fix: disabled items should not be selectable(#434)","user":{"login":"aknaus","id":36954707,"avatar_url":"https://avatars2.githubusercontent.com/u/36954707?v=4","gravatar_id":"","url":"https://api.github.com/users/aknaus","html_url":"https://github.com/aknaus","followers_url":"https://api.github.com/users/aknaus/followers","following_url":"https://api.github.com/users/aknaus/following{/other_user}","gists_url":"https://api.github.com/users/aknaus/gists{/gist_id}","starred_url":"https://api.github.com/users/aknaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknaus/subscriptions","organizations_url":"https://api.github.com/users/aknaus/orgs","repos_url":"https://api.github.com/users/aknaus/repos","events_url":"https://api.github.com/users/aknaus/events{/privacy}","received_events_url":"https://api.github.com/users/aknaus/received_events","type":"User","site_admin":false},"body":"## Problem #434 \r\nAt the moment it is possible to select a disabled item by pressing enter although selection by click is disabled. Personally, I think it should not be possible to select a disabled item (at least not for the user).\r\n\r\n## Solution\r\nThe event handler checks the DOM-node of the item for the disabled prop.\r\n\r\n- fixed faulty behaviour\r\n- updated react-test-renderer\r\n- updated react-testing-library\r\n- added test for fix","created_at":"2018-04-30T11:35:01Z","updated_at":"2018-04-30T16:01:35Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6438e8f63d7db18a031cb37a0948018c2306fe65","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/paypal/downshift/pulls/436/commits","review_comments_url":"https://api.github.com/repos/paypal/downshift/pulls/436/comments","review_comment_url":"https://api.github.com/repos/paypal/downshift/pulls/comments{/number}","comments_url":"https://api.github.com/repos/paypal/downshift/issues/436/comments","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/49e9d0f462d9a191c52cb9dfdee98a2a0b6070e6","head":{"label":"aknaus:master","ref":"master","sha":"49e9d0f462d9a191c52cb9dfdee98a2a0b6070e6","user":{"login":"aknaus","id":36954707,"avatar_url":"https://avatars2.githubusercontent.com/u/36954707?v=4","gravatar_id":"","url":"https://api.github.com/users/aknaus","html_url":"https://github.com/aknaus","followers_url":"https://api.github.com/users/aknaus/followers","following_url":"https://api.github.com/users/aknaus/following{/other_user}","gists_url":"https://api.github.com/users/aknaus/gists{/gist_id}","starred_url":"https://api.github.com/users/aknaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknaus/subscriptions","organizations_url":"https://api.github.com/users/aknaus/orgs","repos_url":"https://api.github.com/users/aknaus/repos","events_url":"https://api.github.com/users/aknaus/events{/privacy}","received_events_url":"https://api.github.com/users/aknaus/received_events","type":"User","site_admin":false},"repo":{"id":131571937,"name":"downshift","full_name":"aknaus/downshift","owner":{"login":"aknaus","id":36954707,"avatar_url":"https://avatars2.githubusercontent.com/u/36954707?v=4","gravatar_id":"","url":"https://api.github.com/users/aknaus","html_url":"https://github.com/aknaus","followers_url":"https://api.github.com/users/aknaus/followers","following_url":"https://api.github.com/users/aknaus/following{/other_user}","gists_url":"https://api.github.com/users/aknaus/gists{/gist_id}","starred_url":"https://api.github.com/users/aknaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aknaus/subscriptions","organizations_url":"https://api.github.com/users/aknaus/orgs","repos_url":"https://api.github.com/users/aknaus/repos","events_url":"https://api.github.com/users/aknaus/events{/privacy}","received_events_url":"https://api.github.com/users/aknaus/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aknaus/downshift","description":"🏎 Primitives to build simple, flexible, WAI-ARIA compliant enhanced input React components","fork":true,"url":"https://api.github.com/repos/aknaus/downshift","forks_url":"https://api.github.com/repos/aknaus/downshift/forks","keys_url":"https://api.github.com/repos/aknaus/downshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aknaus/downshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aknaus/downshift/teams","hooks_url":"https://api.github.com/repos/aknaus/downshift/hooks","issue_events_url":"https://api.github.com/repos/aknaus/downshift/issues/events{/number}","events_url":"https://api.github.com/repos/aknaus/downshift/events","assignees_url":"https://api.github.com/repos/aknaus/downshift/assignees{/user}","branches_url":"https://api.github.com/repos/aknaus/downshift/branches{/branch}","tags_url":"https://api.github.com/repos/aknaus/downshift/tags","blobs_url":"https://api.github.com/repos/aknaus/downshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aknaus/downshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aknaus/downshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/aknaus/downshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aknaus/downshift/statuses/{sha}","languages_url":"https://api.github.com/repos/aknaus/downshift/languages","stargazers_url":"https://api.github.com/repos/aknaus/downshift/stargazers","contributors_url":"https://api.github.com/repos/aknaus/downshift/contributors","subscribers_url":"https://api.github.com/repos/aknaus/downshift/subscribers","subscription_url":"https://api.github.com/repos/aknaus/downshift/subscription","commits_url":"https://api.github.com/repos/aknaus/downshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/aknaus/downshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/aknaus/downshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/aknaus/downshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/aknaus/downshift/contents/{+path}","compare_url":"https://api.github.com/repos/aknaus/downshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aknaus/downshift/merges","archive_url":"https://api.github.com/repos/aknaus/downshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aknaus/downshift/downloads","issues_url":"https://api.github.com/repos/aknaus/downshift/issues{/number}","pulls_url":"https://api.github.com/repos/aknaus/downshift/pulls{/number}","milestones_url":"https://api.github.com/repos/aknaus/downshift/milestones{/number}","notifications_url":"https://api.github.com/repos/aknaus/downshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aknaus/downshift/labels{/name}","releases_url":"https://api.github.com/repos/aknaus/downshift/releases{/id}","deployments_url":"https://api.github.com/repos/aknaus/downshift/deployments","created_at":"2018-04-30T08:24:28Z","updated_at":"2018-04-30T11:28:49Z","pushed_at":"2018-04-30T11:28:48Z","git_url":"git://github.com/aknaus/downshift.git","ssh_url":"git@github.com:aknaus/downshift.git","clone_url":"https://github.com/aknaus/downshift.git","svn_url":"https://github.com/aknaus/downshift","homepage":"http://downshift.netlify.com/","size":697,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"paypal:master","ref":"master","sha":"a9f17d01fd39f09d65f2ebd753df320a46f1d478","user":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"repo":{"id":98315735,"name":"downshift","full_name":"paypal/downshift","owner":{"login":"paypal","id":476675,"avatar_url":"https://avatars1.githubusercontent.com/u/476675?v=4","gravatar_id":"","url":"https://api.github.com/users/paypal","html_url":"https://github.com/paypal","followers_url":"https://api.github.com/users/paypal/followers","following_url":"https://api.github.com/users/paypal/following{/other_user}","gists_url":"https://api.github.com/users/paypal/gists{/gist_id}","starred_url":"https://api.github.com/users/paypal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/paypal/subscriptions","organizations_url":"https://api.github.com/users/paypal/orgs","repos_url":"https://api.github.com/users/paypal/repos","events_url":"https://api.github.com/users/paypal/events{/privacy}","received_events_url":"https://api.github.com/users/paypal/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/paypal/downshift","description":"🏎 Primitives to build simple, flexible, WAI-ARIA compliant enhanced input React components","fork":false,"url":"https://api.github.com/repos/paypal/downshift","forks_url":"https://api.github.com/repos/paypal/downshift/forks","keys_url":"https://api.github.com/repos/paypal/downshift/keys{/key_id}","collaborators_url":"https://api.github.com/repos/paypal/downshift/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/paypal/downshift/teams","hooks_url":"https://api.github.com/repos/paypal/downshift/hooks","issue_events_url":"https://api.github.com/repos/paypal/downshift/issues/events{/number}","events_url":"https://api.github.com/repos/paypal/downshift/events","assignees_url":"https://api.github.com/repos/paypal/downshift/assignees{/user}","branches_url":"https://api.github.com/repos/paypal/downshift/branches{/branch}","tags_url":"https://api.github.com/repos/paypal/downshift/tags","blobs_url":"https://api.github.com/repos/paypal/downshift/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/paypal/downshift/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/paypal/downshift/git/refs{/sha}","trees_url":"https://api.github.com/repos/paypal/downshift/git/trees{/sha}","statuses_url":"https://api.github.com/repos/paypal/downshift/statuses/{sha}","languages_url":"https://api.github.com/repos/paypal/downshift/languages","stargazers_url":"https://api.github.com/repos/paypal/downshift/stargazers","contributors_url":"https://api.github.com/repos/paypal/downshift/contributors","subscribers_url":"https://api.github.com/repos/paypal/downshift/subscribers","subscription_url":"https://api.github.com/repos/paypal/downshift/subscription","commits_url":"https://api.github.com/repos/paypal/downshift/commits{/sha}","git_commits_url":"https://api.github.com/repos/paypal/downshift/git/commits{/sha}","comments_url":"https://api.github.com/repos/paypal/downshift/comments{/number}","issue_comment_url":"https://api.github.com/repos/paypal/downshift/issues/comments{/number}","contents_url":"https://api.github.com/repos/paypal/downshift/contents/{+path}","compare_url":"https://api.github.com/repos/paypal/downshift/compare/{base}...{head}","merges_url":"https://api.github.com/repos/paypal/downshift/merges","archive_url":"https://api.github.com/repos/paypal/downshift/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/paypal/downshift/downloads","issues_url":"https://api.github.com/repos/paypal/downshift/issues{/number}","pulls_url":"https://api.github.com/repos/paypal/downshift/pulls{/number}","milestones_url":"https://api.github.com/repos/paypal/downshift/milestones{/number}","notifications_url":"https://api.github.com/repos/paypal/downshift/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/paypal/downshift/labels{/name}","releases_url":"https://api.github.com/repos/paypal/downshift/releases{/id}","deployments_url":"https://api.github.com/repos/paypal/downshift/deployments","created_at":"2017-07-25T14:31:42Z","updated_at":"2018-04-30T13:24:20Z","pushed_at":"2018-04-30T11:35:02Z","git_url":"git://github.com/paypal/downshift.git","ssh_url":"git@github.com:paypal/downshift.git","clone_url":"https://github.com/paypal/downshift.git","svn_url":"https://github.com/paypal/downshift","homepage":"http://downshift.netlify.com/","size":684,"stargazers_count":4089,"watchers_count":4089,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":270,"mirror_url":null,"archived":false,"open_issues_count":17,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":270,"open_issues":17,"watchers":4089,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/paypal/downshift/pulls/436"},"html":{"href":"https://github.com/paypal/downshift/pull/436"},"issue":{"href":"https://api.github.com/repos/paypal/downshift/issues/436"},"comments":{"href":"https://api.github.com/repos/paypal/downshift/issues/436/comments"},"review_comments":{"href":"https://api.github.com/repos/paypal/downshift/pulls/436/comments"},"review_comment":{"href":"https://api.github.com/repos/paypal/downshift/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/paypal/downshift/pulls/436/commits"},"statuses":{"href":"https://api.github.com/repos/paypal/downshift/statuses/49e9d0f462d9a191c52cb9dfdee98a2a0b6070e6"}},"author_association":"NONE"}}
{"actor":{"display_login":"kentcdodds"}}