{"action":"closed","number":12,"pull_request":{"url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls/12","id":165101904,"html_url":"https://github.com/greenplum-db/gpdb-postgres-merge/pull/12","diff_url":"https://github.com/greenplum-db/gpdb-postgres-merge/pull/12.diff","patch_url":"https://github.com/greenplum-db/gpdb-postgres-merge/pull/12.patch","issue_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues/12","number":12,"state":"closed","locked":false,"title":"(WIP) Initial fix for single row insertion optimization.","user":{"login":"macroyuyang","id":9679273,"avatar_url":"https://avatars2.githubusercontent.com/u/9679273?v=4","gravatar_id":"","url":"https://api.github.com/users/macroyuyang","html_url":"https://github.com/macroyuyang","followers_url":"https://api.github.com/users/macroyuyang/followers","following_url":"https://api.github.com/users/macroyuyang/following{/other_user}","gists_url":"https://api.github.com/users/macroyuyang/gists{/gist_id}","starred_url":"https://api.github.com/users/macroyuyang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/macroyuyang/subscriptions","organizations_url":"https://api.github.com/users/macroyuyang/orgs","repos_url":"https://api.github.com/users/macroyuyang/repos","events_url":"https://api.github.com/users/macroyuyang/events{/privacy}","received_events_url":"https://api.github.com/users/macroyuyang/received_events","type":"User","site_admin":false},"body":"We just get back of single row insertion optimization. But current\r\nparse tree struture is different and there is a fromlist in it.\r\nOur old logic is generating result node if fromlist is NIL, but planner\r\ngenerate subqueryscan due to non empty fromlist.\r\n\r\nAnother fix will come later is we assign gangType as wrong so we execute\r\nconst sub select like 'select generate_series(1, 10)' on each segment.\r\nWe need to fix it by assign it as GANGTYPE_SINGLETON_READER later.","created_at":"2018-01-25T12:09:34Z","updated_at":"2018-02-08T02:07:10Z","closed_at":"2018-02-08T02:07:10Z","merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls/12/commits","review_comments_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls/12/comments","review_comment_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls/comments{/number}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues/12/comments","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/statuses/7d442494ba8567c128aa2171f74edd51f8c6f377","head":{"label":"greenplum-db:modify_table_1st_fix","ref":"modify_table_1st_fix","sha":"7d442494ba8567c128aa2171f74edd51f8c6f377","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":101664763,"name":"gpdb-postgres-merge","full_name":"greenplum-db/gpdb-postgres-merge","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb-postgres-merge","description":"Scratch repository for merging upstream Postgres into GPDB","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge","forks_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/deployments","created_at":"2017-08-28T16:40:12Z","updated_at":"2017-09-14T15:18:28Z","pushed_at":"2018-02-07T21:48:20Z","git_url":"git://github.com/greenplum-db/gpdb-postgres-merge.git","ssh_url":"git@github.com:greenplum-db/gpdb-postgres-merge.git","clone_url":"https://github.com/greenplum-db/gpdb-postgres-merge.git","svn_url":"https://github.com/greenplum-db/gpdb-postgres-merge","homepage":null,"size":236113,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"greenplum-db:iteration_6","ref":"iteration_6","sha":"419199b47b3ae80cfb36ec700dfd9164323f6452","user":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"repo":{"id":101664763,"name":"gpdb-postgres-merge","full_name":"greenplum-db/gpdb-postgres-merge","owner":{"login":"greenplum-db","id":14097842,"avatar_url":"https://avatars2.githubusercontent.com/u/14097842?v=4","gravatar_id":"","url":"https://api.github.com/users/greenplum-db","html_url":"https://github.com/greenplum-db","followers_url":"https://api.github.com/users/greenplum-db/followers","following_url":"https://api.github.com/users/greenplum-db/following{/other_user}","gists_url":"https://api.github.com/users/greenplum-db/gists{/gist_id}","starred_url":"https://api.github.com/users/greenplum-db/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/greenplum-db/subscriptions","organizations_url":"https://api.github.com/users/greenplum-db/orgs","repos_url":"https://api.github.com/users/greenplum-db/repos","events_url":"https://api.github.com/users/greenplum-db/events{/privacy}","received_events_url":"https://api.github.com/users/greenplum-db/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/greenplum-db/gpdb-postgres-merge","description":"Scratch repository for merging upstream Postgres into GPDB","fork":false,"url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge","forks_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/forks","keys_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/keys{/key_id}","collaborators_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/teams","hooks_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/hooks","issue_events_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues/events{/number}","events_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/events","assignees_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/assignees{/user}","branches_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/branches{/branch}","tags_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/tags","blobs_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/refs{/sha}","trees_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/trees{/sha}","statuses_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/statuses/{sha}","languages_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/languages","stargazers_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/stargazers","contributors_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/contributors","subscribers_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/subscribers","subscription_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/subscription","commits_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/commits{/sha}","git_commits_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/git/commits{/sha}","comments_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/comments{/number}","issue_comment_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues/comments{/number}","contents_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/contents/{+path}","compare_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/compare/{base}...{head}","merges_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/merges","archive_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/downloads","issues_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues{/number}","pulls_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls{/number}","milestones_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/milestones{/number}","notifications_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/labels{/name}","releases_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/releases{/id}","deployments_url":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/deployments","created_at":"2017-08-28T16:40:12Z","updated_at":"2017-09-14T15:18:28Z","pushed_at":"2018-02-07T21:48:20Z","git_url":"git://github.com/greenplum-db/gpdb-postgres-merge.git","ssh_url":"git@github.com:greenplum-db/gpdb-postgres-merge.git","clone_url":"https://github.com/greenplum-db/gpdb-postgres-merge.git","svn_url":"https://github.com/greenplum-db/gpdb-postgres-merge","homepage":null,"size":236113,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":5,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls/12"},"html":{"href":"https://github.com/greenplum-db/gpdb-postgres-merge/pull/12"},"issue":{"href":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues/12"},"comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/greenplum-db/gpdb-postgres-merge/statuses/7d442494ba8567c128aa2171f74edd51f8c6f377"}},"author_association":"MEMBER","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":227,"deletions":13,"changed_files":3}}
{"actor":{"display_login":"macroyuyang"}}