{"action":"created","issue":{"url":"https://api.github.com/repos/90milesbridge/react-rainbow/issues/377","repository_url":"https://api.github.com/repos/90milesbridge/react-rainbow","labels_url":"https://api.github.com/repos/90milesbridge/react-rainbow/issues/377/labels{/name}","comments_url":"https://api.github.com/repos/90milesbridge/react-rainbow/issues/377/comments","events_url":"https://api.github.com/repos/90milesbridge/react-rainbow/issues/377/events","html_url":"https://github.com/90milesbridge/react-rainbow/pull/377","id":376988335,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MDc0OTk0","number":377,"title":"feat: implement chart component","user":{"login":"AlejandroYanes","id":17990846,"node_id":"MDQ6VXNlcjE3OTkwODQ2","avatar_url":"https://avatars0.githubusercontent.com/u/17990846?v=4","gravatar_id":"","url":"https://api.github.com/users/AlejandroYanes","html_url":"https://github.com/AlejandroYanes","followers_url":"https://api.github.com/users/AlejandroYanes/followers","following_url":"https://api.github.com/users/AlejandroYanes/following{/other_user}","gists_url":"https://api.github.com/users/AlejandroYanes/gists{/gist_id}","starred_url":"https://api.github.com/users/AlejandroYanes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AlejandroYanes/subscriptions","organizations_url":"https://api.github.com/users/AlejandroYanes/orgs","repos_url":"https://api.github.com/users/AlejandroYanes/repos","events_url":"https://api.github.com/users/AlejandroYanes/events{/privacy}","received_events_url":"https://api.github.com/users/AlejandroYanes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-02T22:34:40Z","updated_at":"2018-11-02T23:01:36Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/90milesbridge/react-rainbow/pulls/377","html_url":"https://github.com/90milesbridge/react-rainbow/pull/377","diff_url":"https://github.com/90milesbridge/react-rainbow/pull/377.diff","patch_url":"https://github.com/90milesbridge/react-rainbow/pull/377.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/90milesbridge/react-rainbow/issues/comments/435533700","html_url":"https://github.com/90milesbridge/react-rainbow/pull/377#issuecomment-435533700","issue_url":"https://api.github.com/repos/90milesbridge/react-rainbow/issues/377","id":435533700,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNTUzMzcwMA==","user":{"login":"reiniergs","id":3241179,"node_id":"MDQ6VXNlcjMyNDExNzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3241179?v=4","gravatar_id":"","url":"https://api.github.com/users/reiniergs","html_url":"https://github.com/reiniergs","followers_url":"https://api.github.com/users/reiniergs/followers","following_url":"https://api.github.com/users/reiniergs/following{/other_user}","gists_url":"https://api.github.com/users/reiniergs/gists{/gist_id}","starred_url":"https://api.github.com/users/reiniergs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/reiniergs/subscriptions","organizations_url":"https://api.github.com/users/reiniergs/orgs","repos_url":"https://api.github.com/users/reiniergs/repos","events_url":"https://api.github.com/users/reiniergs/events{/privacy}","received_events_url":"https://api.github.com/users/reiniergs/received_events","type":"User","site_admin":false},"created_at":"2018-11-02T23:01:36Z","updated_at":"2018-11-02T23:01:36Z","author_association":"COLLABORATOR","body":"can we implement this without React context, since inside of <Chart /> component you can pass <DataSet /> We can just iterate for the dataset in componentDidUpdate ... get the data passed then update the charts\r\n\r\nthis implementation does not guarantee reactivity since the charts only is created and updated one time. Every time props values change in Chart or DataSet the chart must be updated.\r\n\r\n## tips:\r\n- the charts instance doesn't need to be created multiple times check: https://www.chartjs.org/docs/latest/developers/updates.html\r\n\r\n  "}}
{"actor":{"display_login":"reiniergs"}}