{"action":"created","comment":{"url":"https://api.github.com/repos/ARM-software/lisa/pulls/comments/239098617","pull_request_review_id":181797963,"id":239098617,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzOTA5ODYxNw==","diff_hunk":"@@ -139,7 +145,7 @@ def freq_list(group):\n         info = {\n             'clusters': clusters,\n             'topology': topology,\n-            'freqs': freqs,\n+            # 'freqs': freqs,","path":"lisa/platforms/platinfo.py","position":null,"original_position":27,"commit_id":"359499dd6456cdc5c19daf7d34fa0769e8e9b205","original_commit_id":"ff6586268fa6b175cacfedb247002b892aa6b6b6","user":{"login":"qais-yousef","id":16548712,"node_id":"MDQ6VXNlcjE2NTQ4NzEy","avatar_url":"https://avatars2.githubusercontent.com/u/16548712?v=4","gravatar_id":"","url":"https://api.github.com/users/qais-yousef","html_url":"https://github.com/qais-yousef","followers_url":"https://api.github.com/users/qais-yousef/followers","following_url":"https://api.github.com/users/qais-yousef/following{/other_user}","gists_url":"https://api.github.com/users/qais-yousef/gists{/gist_id}","starred_url":"https://api.github.com/users/qais-yousef/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qais-yousef/subscriptions","organizations_url":"https://api.github.com/users/qais-yousef/orgs","repos_url":"https://api.github.com/users/qais-yousef/repos","events_url":"https://api.github.com/users/qais-yousef/events{/privacy}","received_events_url":"https://api.github.com/users/qais-yousef/received_events","type":"User","site_admin":false},"body":"Any reason not to remove the line instead of commenting it out?","created_at":"2018-12-05T14:57:57Z","updated_at":"2018-12-05T14:57:57Z","html_url":"https://github.com/ARM-software/lisa/pull/672#discussion_r239098617","pull_request_url":"https://api.github.com/repos/ARM-software/lisa/pulls/672","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/comments/239098617"},"html":{"href":"https://github.com/ARM-software/lisa/pull/672#discussion_r239098617"},"pull_request":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/672"}}},"pull_request":{"url":"https://api.github.com/repos/ARM-software/lisa/pulls/672","id":234756987,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzU2OTg3","html_url":"https://github.com/ARM-software/lisa/pull/672","diff_url":"https://github.com/ARM-software/lisa/pull/672.diff","patch_url":"https://github.com/ARM-software/lisa/pull/672.patch","issue_url":"https://api.github.com/repos/ARM-software/lisa/issues/672","number":672,"state":"open","locked":false,"title":"Analysis refactorizing","user":{"login":"valschneider","id":5830891,"node_id":"MDQ6VXNlcjU4MzA4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5830891?v=4","gravatar_id":"","url":"https://api.github.com/users/valschneider","html_url":"https://github.com/valschneider","followers_url":"https://api.github.com/users/valschneider/followers","following_url":"https://api.github.com/users/valschneider/following{/other_user}","gists_url":"https://api.github.com/users/valschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/valschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valschneider/subscriptions","organizations_url":"https://api.github.com/users/valschneider/orgs","repos_url":"https://api.github.com/users/valschneider/repos","events_url":"https://api.github.com/users/valschneider/events{/privacy}","received_events_url":"https://api.github.com/users/valschneider/received_events","type":"User","site_admin":false},"body":"Here's a notebook containing every analysis dataframe/plot that are working: https://gist.github.com/valschneider/fe7ee87e4ff3a6e3e443a316d21c04c0\r\n\r\nChangelog:\r\n- Instored a colourblind-friendly colour cycle, so that we don't have to think about which colours to use\r\n- Added a `requires_events` decorator that both asserts trace events are available and add them to the method documentation.\r\n- Factorized plotting code (creation/saving to file)\r\n- Documented the shape of the returned DataFrame for all `df_*` methods.\r\n- Made all plotting methods return the `matplotlib.axes.Axes` they created/manipulated\r\n- Added a `load_tracking` analysis module for... load-tracking related analysis\r\n- Un-camelCased some methods\r\n- Incinerated the other analysis modules and factorized their ashes.\r\n\r\nThings left to do:\r\n- Assert that some analysis methods haven't been broken (notably check that master.df_latency == next.df_task_states)\r\n- Status analysis\r\n- Thermal analysis\r\n- Update uses of the analysis API in lisa/tests/kernel\r\n- Update uses of the analysis API in lisa/tests/lisa\r\n- Un-camelCase the remaining offenders\r\n- (probably in a later PR) Make sphinx generate an example plot for plotting methods' documentation.","created_at":"2018-11-29T19:24:38Z","updated_at":"2018-12-05T14:57:57Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e1d228123d9655c2af9845f46403b3eca75f4824","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ARM-software/lisa/pulls/672/commits","review_comments_url":"https://api.github.com/repos/ARM-software/lisa/pulls/672/comments","review_comment_url":"https://api.github.com/repos/ARM-software/lisa/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARM-software/lisa/issues/672/comments","statuses_url":"https://api.github.com/repos/ARM-software/lisa/statuses/359499dd6456cdc5c19daf7d34fa0769e8e9b205","head":{"label":"valschneider:next-analysis-refactor","ref":"next-analysis-refactor","sha":"359499dd6456cdc5c19daf7d34fa0769e8e9b205","user":{"login":"valschneider","id":5830891,"node_id":"MDQ6VXNlcjU4MzA4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5830891?v=4","gravatar_id":"","url":"https://api.github.com/users/valschneider","html_url":"https://github.com/valschneider","followers_url":"https://api.github.com/users/valschneider/followers","following_url":"https://api.github.com/users/valschneider/following{/other_user}","gists_url":"https://api.github.com/users/valschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/valschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valschneider/subscriptions","organizations_url":"https://api.github.com/users/valschneider/orgs","repos_url":"https://api.github.com/users/valschneider/repos","events_url":"https://api.github.com/users/valschneider/events{/privacy}","received_events_url":"https://api.github.com/users/valschneider/received_events","type":"User","site_admin":false},"repo":{"id":84053505,"node_id":"MDEwOlJlcG9zaXRvcnk4NDA1MzUwNQ==","name":"lisa","full_name":"valschneider/lisa","private":false,"owner":{"login":"valschneider","id":5830891,"node_id":"MDQ6VXNlcjU4MzA4OTE=","avatar_url":"https://avatars3.githubusercontent.com/u/5830891?v=4","gravatar_id":"","url":"https://api.github.com/users/valschneider","html_url":"https://github.com/valschneider","followers_url":"https://api.github.com/users/valschneider/followers","following_url":"https://api.github.com/users/valschneider/following{/other_user}","gists_url":"https://api.github.com/users/valschneider/gists{/gist_id}","starred_url":"https://api.github.com/users/valschneider/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valschneider/subscriptions","organizations_url":"https://api.github.com/users/valschneider/orgs","repos_url":"https://api.github.com/users/valschneider/repos","events_url":"https://api.github.com/users/valschneider/events{/privacy}","received_events_url":"https://api.github.com/users/valschneider/received_events","type":"User","site_admin":false},"html_url":"https://github.com/valschneider/lisa","description":"Linux Integrated System Analysis","fork":true,"url":"https://api.github.com/repos/valschneider/lisa","forks_url":"https://api.github.com/repos/valschneider/lisa/forks","keys_url":"https://api.github.com/repos/valschneider/lisa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/valschneider/lisa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/valschneider/lisa/teams","hooks_url":"https://api.github.com/repos/valschneider/lisa/hooks","issue_events_url":"https://api.github.com/repos/valschneider/lisa/issues/events{/number}","events_url":"https://api.github.com/repos/valschneider/lisa/events","assignees_url":"https://api.github.com/repos/valschneider/lisa/assignees{/user}","branches_url":"https://api.github.com/repos/valschneider/lisa/branches{/branch}","tags_url":"https://api.github.com/repos/valschneider/lisa/tags","blobs_url":"https://api.github.com/repos/valschneider/lisa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/valschneider/lisa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/valschneider/lisa/git/refs{/sha}","trees_url":"https://api.github.com/repos/valschneider/lisa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/valschneider/lisa/statuses/{sha}","languages_url":"https://api.github.com/repos/valschneider/lisa/languages","stargazers_url":"https://api.github.com/repos/valschneider/lisa/stargazers","contributors_url":"https://api.github.com/repos/valschneider/lisa/contributors","subscribers_url":"https://api.github.com/repos/valschneider/lisa/subscribers","subscription_url":"https://api.github.com/repos/valschneider/lisa/subscription","commits_url":"https://api.github.com/repos/valschneider/lisa/commits{/sha}","git_commits_url":"https://api.github.com/repos/valschneider/lisa/git/commits{/sha}","comments_url":"https://api.github.com/repos/valschneider/lisa/comments{/number}","issue_comment_url":"https://api.github.com/repos/valschneider/lisa/issues/comments{/number}","contents_url":"https://api.github.com/repos/valschneider/lisa/contents/{+path}","compare_url":"https://api.github.com/repos/valschneider/lisa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/valschneider/lisa/merges","archive_url":"https://api.github.com/repos/valschneider/lisa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/valschneider/lisa/downloads","issues_url":"https://api.github.com/repos/valschneider/lisa/issues{/number}","pulls_url":"https://api.github.com/repos/valschneider/lisa/pulls{/number}","milestones_url":"https://api.github.com/repos/valschneider/lisa/milestones{/number}","notifications_url":"https://api.github.com/repos/valschneider/lisa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/valschneider/lisa/labels{/name}","releases_url":"https://api.github.com/repos/valschneider/lisa/releases{/id}","deployments_url":"https://api.github.com/repos/valschneider/lisa/deployments","created_at":"2017-03-06T09:18:28Z","updated_at":"2017-03-06T09:18:33Z","pushed_at":"2018-12-04T18:36:16Z","git_url":"git://github.com/valschneider/lisa.git","ssh_url":"git@github.com:valschneider/lisa.git","clone_url":"https://github.com/valschneider/lisa.git","svn_url":"https://github.com/valschneider/lisa","homepage":"","size":161883,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ARM-software:next","ref":"next","sha":"81df4f899a4c2a5a175b996c0c738793a0425e76","user":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"repo":{"id":47548304,"node_id":"MDEwOlJlcG9zaXRvcnk0NzU0ODMwNA==","name":"lisa","full_name":"ARM-software/lisa","private":false,"owner":{"login":"ARM-software","id":5690313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU2OTAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/5690313?v=4","gravatar_id":"","url":"https://api.github.com/users/ARM-software","html_url":"https://github.com/ARM-software","followers_url":"https://api.github.com/users/ARM-software/followers","following_url":"https://api.github.com/users/ARM-software/following{/other_user}","gists_url":"https://api.github.com/users/ARM-software/gists{/gist_id}","starred_url":"https://api.github.com/users/ARM-software/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARM-software/subscriptions","organizations_url":"https://api.github.com/users/ARM-software/orgs","repos_url":"https://api.github.com/users/ARM-software/repos","events_url":"https://api.github.com/users/ARM-software/events{/privacy}","received_events_url":"https://api.github.com/users/ARM-software/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARM-software/lisa","description":"Linux Integrated System Analysis","fork":false,"url":"https://api.github.com/repos/ARM-software/lisa","forks_url":"https://api.github.com/repos/ARM-software/lisa/forks","keys_url":"https://api.github.com/repos/ARM-software/lisa/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARM-software/lisa/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARM-software/lisa/teams","hooks_url":"https://api.github.com/repos/ARM-software/lisa/hooks","issue_events_url":"https://api.github.com/repos/ARM-software/lisa/issues/events{/number}","events_url":"https://api.github.com/repos/ARM-software/lisa/events","assignees_url":"https://api.github.com/repos/ARM-software/lisa/assignees{/user}","branches_url":"https://api.github.com/repos/ARM-software/lisa/branches{/branch}","tags_url":"https://api.github.com/repos/ARM-software/lisa/tags","blobs_url":"https://api.github.com/repos/ARM-software/lisa/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARM-software/lisa/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARM-software/lisa/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARM-software/lisa/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARM-software/lisa/statuses/{sha}","languages_url":"https://api.github.com/repos/ARM-software/lisa/languages","stargazers_url":"https://api.github.com/repos/ARM-software/lisa/stargazers","contributors_url":"https://api.github.com/repos/ARM-software/lisa/contributors","subscribers_url":"https://api.github.com/repos/ARM-software/lisa/subscribers","subscription_url":"https://api.github.com/repos/ARM-software/lisa/subscription","commits_url":"https://api.github.com/repos/ARM-software/lisa/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARM-software/lisa/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARM-software/lisa/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARM-software/lisa/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARM-software/lisa/contents/{+path}","compare_url":"https://api.github.com/repos/ARM-software/lisa/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARM-software/lisa/merges","archive_url":"https://api.github.com/repos/ARM-software/lisa/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARM-software/lisa/downloads","issues_url":"https://api.github.com/repos/ARM-software/lisa/issues{/number}","pulls_url":"https://api.github.com/repos/ARM-software/lisa/pulls{/number}","milestones_url":"https://api.github.com/repos/ARM-software/lisa/milestones{/number}","notifications_url":"https://api.github.com/repos/ARM-software/lisa/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARM-software/lisa/labels{/name}","releases_url":"https://api.github.com/repos/ARM-software/lisa/releases{/id}","deployments_url":"https://api.github.com/repos/ARM-software/lisa/deployments","created_at":"2015-12-07T11:32:56Z","updated_at":"2018-12-05T02:00:59Z","pushed_at":"2018-12-04T18:45:51Z","git_url":"git://github.com/ARM-software/lisa.git","ssh_url":"git@github.com:ARM-software/lisa.git","clone_url":"https://github.com/ARM-software/lisa.git","svn_url":"https://github.com/ARM-software/lisa","homepage":"","size":163513,"stargazers_count":66,"watchers_count":66,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":58,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":58,"open_issues":66,"watchers":66,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/672"},"html":{"href":"https://github.com/ARM-software/lisa/pull/672"},"issue":{"href":"https://api.github.com/repos/ARM-software/lisa/issues/672"},"comments":{"href":"https://api.github.com/repos/ARM-software/lisa/issues/672/comments"},"review_comments":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/672/comments"},"review_comment":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARM-software/lisa/pulls/672/commits"},"statuses":{"href":"https://api.github.com/repos/ARM-software/lisa/statuses/359499dd6456cdc5c19daf7d34fa0769e8e9b205"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"qais-yousef"}}