{"action":"created","comment":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/195708174","pull_request_review_id":129131924,"id":195708174,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTcwODE3NA==","diff_hunk":"@@ -30,15 +30,15 @@ public function _before(AcceptanceTester $I)\n     /**\n      * @param \\AcceptanceTester $I\n      * @param \\Step\\Acceptance\\ListView $listView\n-     * @param \\Step\\Acceptance\\Targets $targets\n+     * @param \\Step\\Acceptance\\TargetList $targetList\n      * @param \\Helper\\WebDriverHelper $webDriverHelper\n      *\n      * As an administrator I want to view the targets module.\n      */\n     public function testScenarioViewTargetsModule(\n         \\AcceptanceTester $I,\n         \\Step\\Acceptance\\ListView $listView,\n-        \\Step\\Acceptance\\Targets $targets,","path":"tests/acceptance/modules/TargetLists/TargetListsCest.php","position":13,"original_position":13,"commit_id":"4af4edeec87407f18d66a0be04d41fbc64d82330","original_commit_id":"4af4edeec87407f18d66a0be04d41fbc64d82330","user":{"login":"Dillon-Brown","id":26431166,"node_id":"MDQ6VXNlcjI2NDMxMTY2","avatar_url":"https://avatars0.githubusercontent.com/u/26431166?v=4","gravatar_id":"","url":"https://api.github.com/users/Dillon-Brown","html_url":"https://github.com/Dillon-Brown","followers_url":"https://api.github.com/users/Dillon-Brown/followers","following_url":"https://api.github.com/users/Dillon-Brown/following{/other_user}","gists_url":"https://api.github.com/users/Dillon-Brown/gists{/gist_id}","starred_url":"https://api.github.com/users/Dillon-Brown/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Dillon-Brown/subscriptions","organizations_url":"https://api.github.com/users/Dillon-Brown/orgs","repos_url":"https://api.github.com/users/Dillon-Brown/repos","events_url":"https://api.github.com/users/Dillon-Brown/events{/privacy}","received_events_url":"https://api.github.com/users/Dillon-Brown/received_events","type":"User","site_admin":false},"body":"Yes, the ViewTargetModule test was previously looking at the \"Targets\" module instead of \"Targets - List\". ","created_at":"2018-06-15T11:47:33Z","updated_at":"2018-06-15T11:47:34Z","html_url":"https://github.com/salesagility/SuiteCRM/pull/6034#discussion_r195708174","pull_request_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6034","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments/195708174"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/6034#discussion_r195708174"},"pull_request":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6034"}},"in_reply_to_id":195707526},"pull_request":{"url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6034","id":194946038,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTQ2MDM4","html_url":"https://github.com/salesagility/SuiteCRM/pull/6034","diff_url":"https://github.com/salesagility/SuiteCRM/pull/6034.diff","patch_url":"https://github.com/salesagility/SuiteCRM/pull/6034.patch","issue_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6034","number":6034,"state":"open","locked":false,"title":"Fixed #6025 - Fix for issue #6025 - Newsletter campaign target list selection broken","user":{"login":"gymad","id":13831178,"node_id":"MDQ6VXNlcjEzODMxMTc4","avatar_url":"https://avatars0.githubusercontent.com/u/13831178?v=4","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"body":"<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here unless your commit contains the issue number -->\r\nProvide a fix for issue #6025 - Newsletter campaign target list selection broken\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\nTarget list selection should works\r\n\r\n## How To Test This\r\n<!--- Please describe in detail how to test your changes. -->\r\nsee everything in the related issue above\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n### Final checklist\r\n<!--- Go over all the following points and check all the boxes that apply. --->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --->\r\n- [x] My code follows the code style of this project found [here](https://docs.suitecrm.com/community/contributing-code/coding-standards/).\r\n- [x] My change requires a change to the documentation.\r\n- [x] I have read the [**How to Contribute**](https://docs.suitecrm.com/community/contributing-code/) guidelines.\r\n\r\n<!--- Your pull request will be tested via Travis CI to automatically indicate that your changes do not prevent compilation. --->\r\n\r\n<!--- If it reports back that there are problems, you can log into the Travis system and check the log report for your pull request to see what the problem was. --->","created_at":"2018-06-14T16:12:07Z","updated_at":"2018-06-15T11:47:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"49a183664c42c36103368dbb4df12a58d56190cf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"JimMackin","id":1968785,"node_id":"MDQ6VXNlcjE5Njg3ODU=","avatar_url":"https://avatars1.githubusercontent.com/u/1968785?v=4","gravatar_id":"","url":"https://api.github.com/users/JimMackin","html_url":"https://github.com/JimMackin","followers_url":"https://api.github.com/users/JimMackin/followers","following_url":"https://api.github.com/users/JimMackin/following{/other_user}","gists_url":"https://api.github.com/users/JimMackin/gists{/gist_id}","starred_url":"https://api.github.com/users/JimMackin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JimMackin/subscriptions","organizations_url":"https://api.github.com/users/JimMackin/orgs","repos_url":"https://api.github.com/users/JimMackin/repos","events_url":"https://api.github.com/users/JimMackin/events{/privacy}","received_events_url":"https://api.github.com/users/JimMackin/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6034/commits","review_comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6034/comments","review_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6034/comments","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/4af4edeec87407f18d66a0be04d41fbc64d82330","head":{"label":"gymad:hotfix_issue_6025","ref":"hotfix_issue_6025","sha":"4af4edeec87407f18d66a0be04d41fbc64d82330","user":{"login":"gymad","id":13831178,"node_id":"MDQ6VXNlcjEzODMxMTc4","avatar_url":"https://avatars0.githubusercontent.com/u/13831178?v=4","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"repo":{"id":41494060,"node_id":"MDEwOlJlcG9zaXRvcnk0MTQ5NDA2MA==","name":"SuiteCRM","full_name":"gymad/SuiteCRM","owner":{"login":"gymad","id":13831178,"node_id":"MDQ6VXNlcjEzODMxMTc4","avatar_url":"https://avatars0.githubusercontent.com/u/13831178?v=4","gravatar_id":"","url":"https://api.github.com/users/gymad","html_url":"https://github.com/gymad","followers_url":"https://api.github.com/users/gymad/followers","following_url":"https://api.github.com/users/gymad/following{/other_user}","gists_url":"https://api.github.com/users/gymad/gists{/gist_id}","starred_url":"https://api.github.com/users/gymad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gymad/subscriptions","organizations_url":"https://api.github.com/users/gymad/orgs","repos_url":"https://api.github.com/users/gymad/repos","events_url":"https://api.github.com/users/gymad/events{/privacy}","received_events_url":"https://api.github.com/users/gymad/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gymad/SuiteCRM","description":"SuiteCRM is SugarCRM Supercharged. It's the Free Open Source alternative to SugarCRM Professional.","fork":true,"url":"https://api.github.com/repos/gymad/SuiteCRM","forks_url":"https://api.github.com/repos/gymad/SuiteCRM/forks","keys_url":"https://api.github.com/repos/gymad/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gymad/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gymad/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/gymad/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/gymad/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/gymad/SuiteCRM/events","assignees_url":"https://api.github.com/repos/gymad/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/gymad/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/gymad/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/gymad/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gymad/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gymad/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/gymad/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gymad/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/gymad/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/gymad/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/gymad/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/gymad/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/gymad/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/gymad/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/gymad/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/gymad/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/gymad/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/gymad/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/gymad/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gymad/SuiteCRM/merges","archive_url":"https://api.github.com/repos/gymad/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gymad/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/gymad/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/gymad/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/gymad/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/gymad/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gymad/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/gymad/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/gymad/SuiteCRM/deployments","created_at":"2015-08-27T15:11:18Z","updated_at":"2016-06-30T11:24:42Z","pushed_at":"2018-06-15T11:40:22Z","git_url":"git://github.com/gymad/SuiteCRM.git","ssh_url":"git@github.com:gymad/SuiteCRM.git","clone_url":"https://github.com/gymad/SuiteCRM.git","svn_url":"https://github.com/gymad/SuiteCRM","homepage":"http://www.suitecrm.com","size":94931,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":14,"watchers":0,"default_branch":"master"}},"base":{"label":"salesagility:hotfix","ref":"hotfix","sha":"2a881af35ebcb84335fd91e37347110737b749e5","user":{"login":"salesagility","id":1450870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTA4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"repo":{"id":13044600,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA0NDYwMA==","name":"SuiteCRM","full_name":"salesagility/SuiteCRM","owner":{"login":"salesagility","id":1450870,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0NTA4NzA=","avatar_url":"https://avatars1.githubusercontent.com/u/1450870?v=4","gravatar_id":"","url":"https://api.github.com/users/salesagility","html_url":"https://github.com/salesagility","followers_url":"https://api.github.com/users/salesagility/followers","following_url":"https://api.github.com/users/salesagility/following{/other_user}","gists_url":"https://api.github.com/users/salesagility/gists{/gist_id}","starred_url":"https://api.github.com/users/salesagility/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesagility/subscriptions","organizations_url":"https://api.github.com/users/salesagility/orgs","repos_url":"https://api.github.com/users/salesagility/repos","events_url":"https://api.github.com/users/salesagility/events{/privacy}","received_events_url":"https://api.github.com/users/salesagility/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesagility/SuiteCRM","description":"SuiteCRM - Open source CRM for the world","fork":false,"url":"https://api.github.com/repos/salesagility/SuiteCRM","forks_url":"https://api.github.com/repos/salesagility/SuiteCRM/forks","keys_url":"https://api.github.com/repos/salesagility/SuiteCRM/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesagility/SuiteCRM/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesagility/SuiteCRM/teams","hooks_url":"https://api.github.com/repos/salesagility/SuiteCRM/hooks","issue_events_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/events{/number}","events_url":"https://api.github.com/repos/salesagility/SuiteCRM/events","assignees_url":"https://api.github.com/repos/salesagility/SuiteCRM/assignees{/user}","branches_url":"https://api.github.com/repos/salesagility/SuiteCRM/branches{/branch}","tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/tags","blobs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/{sha}","languages_url":"https://api.github.com/repos/salesagility/SuiteCRM/languages","stargazers_url":"https://api.github.com/repos/salesagility/SuiteCRM/stargazers","contributors_url":"https://api.github.com/repos/salesagility/SuiteCRM/contributors","subscribers_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscribers","subscription_url":"https://api.github.com/repos/salesagility/SuiteCRM/subscription","commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesagility/SuiteCRM/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesagility/SuiteCRM/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesagility/SuiteCRM/contents/{+path}","compare_url":"https://api.github.com/repos/salesagility/SuiteCRM/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesagility/SuiteCRM/merges","archive_url":"https://api.github.com/repos/salesagility/SuiteCRM/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesagility/SuiteCRM/downloads","issues_url":"https://api.github.com/repos/salesagility/SuiteCRM/issues{/number}","pulls_url":"https://api.github.com/repos/salesagility/SuiteCRM/pulls{/number}","milestones_url":"https://api.github.com/repos/salesagility/SuiteCRM/milestones{/number}","notifications_url":"https://api.github.com/repos/salesagility/SuiteCRM/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesagility/SuiteCRM/labels{/name}","releases_url":"https://api.github.com/repos/salesagility/SuiteCRM/releases{/id}","deployments_url":"https://api.github.com/repos/salesagility/SuiteCRM/deployments","created_at":"2013-09-23T19:10:08Z","updated_at":"2018-06-13T18:40:15Z","pushed_at":"2018-06-15T11:40:24Z","git_url":"git://github.com/salesagility/SuiteCRM.git","ssh_url":"git@github.com:salesagility/SuiteCRM.git","clone_url":"https://github.com/salesagility/SuiteCRM.git","svn_url":"https://github.com/salesagility/SuiteCRM","homepage":"http://www.suitecrm.com","size":92415,"stargazers_count":1028,"watchers_count":1028,"language":"PHP","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":810,"mirror_url":null,"archived":false,"open_issues_count":979,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":810,"open_issues":979,"watchers":1028,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6034"},"html":{"href":"https://github.com/salesagility/SuiteCRM/pull/6034"},"issue":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6034"},"comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/issues/6034/comments"},"review_comments":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6034/comments"},"review_comment":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/pulls/6034/commits"},"statuses":{"href":"https://api.github.com/repos/salesagility/SuiteCRM/statuses/4af4edeec87407f18d66a0be04d41fbc64d82330"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Dillon-Brown"}}