{"action":"created","comment":{"url":"https://api.github.com/repos/flutter/flutter/pulls/comments/233136668","pull_request_review_id":174478441,"id":233136668,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzEzNjY2OA==","diff_hunk":"@@ -339,9 +347,19 @@ class _TextFieldState extends State<TextField> with AutomaticKeepAliveClientMixi\n       return effectiveDecoration;\n \n     final int currentLength = _effectiveController.value.text.runes.length;\n-    final String counterText = '$currentLength/${widget.maxLength}';\n-    final int remaining = (widget.maxLength - currentLength).clamp(0, widget.maxLength);\n-    final String semanticCounterText = localizations.remainingTextFieldCharacterCount(remaining);\n+    String counterText = '$currentLength';\n+    String semanticCounterText = '';\n+\n+    // See if we are showing the maxLength or hiding it and therefore\n+    // if not hiding the semanticCounterText should be the remaining length\n+    if (widget.maxLength != TextField.noMaxLength) {\n+      // Show the maxLength on display and semanticCounterText","path":"packages/flutter/lib/src/material/text_field.dart","position":37,"original_position":37,"commit_id":"5483cb895593f98716cee2689ff4df499b29ae85","original_commit_id":"5483cb895593f98716cee2689ff4df499b29ae85","user":{"login":"HansMuller","id":1377460,"node_id":"MDQ6VXNlcjEzNzc0NjA=","avatar_url":"https://avatars2.githubusercontent.com/u/1377460?v=4","gravatar_id":"","url":"https://api.github.com/users/HansMuller","html_url":"https://github.com/HansMuller","followers_url":"https://api.github.com/users/HansMuller/followers","following_url":"https://api.github.com/users/HansMuller/following{/other_user}","gists_url":"https://api.github.com/users/HansMuller/gists{/gist_id}","starred_url":"https://api.github.com/users/HansMuller/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HansMuller/subscriptions","organizations_url":"https://api.github.com/users/HansMuller/orgs","repos_url":"https://api.github.com/users/HansMuller/repos","events_url":"https://api.github.com/users/HansMuller/events{/privacy}","received_events_url":"https://api.github.com/users/HansMuller/received_events","type":"User","site_admin":false},"body":"Similarly, this comment probably isn't needed","created_at":"2018-11-13T17:05:19Z","updated_at":"2018-11-13T17:07:12Z","html_url":"https://github.com/flutter/flutter/pull/24183#discussion_r233136668","pull_request_url":"https://api.github.com/repos/flutter/flutter/pulls/24183","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments/233136668"},"html":{"href":"https://github.com/flutter/flutter/pull/24183#discussion_r233136668"},"pull_request":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24183"}}},"pull_request":{"url":"https://api.github.com/repos/flutter/flutter/pulls/24183","id":229827593,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODI3NTkz","html_url":"https://github.com/flutter/flutter/pull/24183","diff_url":"https://github.com/flutter/flutter/pull/24183.diff","patch_url":"https://github.com/flutter/flutter/pull/24183.patch","issue_url":"https://api.github.com/repos/flutter/flutter/issues/24183","number":24183,"state":"open","locked":false,"title":"Optionally show the text field length but not the max","user":{"login":"sjmcdowall","id":2034925,"node_id":"MDQ6VXNlcjIwMzQ5MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2034925?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmcdowall","html_url":"https://github.com/sjmcdowall","followers_url":"https://api.github.com/users/sjmcdowall/followers","following_url":"https://api.github.com/users/sjmcdowall/following{/other_user}","gists_url":"https://api.github.com/users/sjmcdowall/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmcdowall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmcdowall/subscriptions","organizations_url":"https://api.github.com/users/sjmcdowall/orgs","repos_url":"https://api.github.com/users/sjmcdowall/repos","events_url":"https://api.github.com/users/sjmcdowall/events{/privacy}","received_events_url":"https://api.github.com/users/sjmcdowall/received_events","type":"User","site_admin":false},"body":"If maxLength is set to TextField.noMaxLength (pow(2,59)) then continue to show the character counter but do not show the max length.","created_at":"2018-11-09T21:44:11Z","updated_at":"2018-11-13T17:07:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96c3eda804b69383d81d13fc8c39b3765128d0de","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":487496476,"node_id":"MDU6TGFiZWw0ODc0OTY0NzY=","url":"https://api.github.com/repos/flutter/flutter/labels/cla:%20yes","name":"cla: yes","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/flutter/flutter/pulls/24183/commits","review_comments_url":"https://api.github.com/repos/flutter/flutter/pulls/24183/comments","review_comment_url":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/flutter/flutter/issues/24183/comments","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/5483cb895593f98716cee2689ff4df499b29ae85","head":{"label":"sjmcdowall:i23791_show_counter_without_max","ref":"i23791_show_counter_without_max","sha":"5483cb895593f98716cee2689ff4df499b29ae85","user":{"login":"sjmcdowall","id":2034925,"node_id":"MDQ6VXNlcjIwMzQ5MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2034925?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmcdowall","html_url":"https://github.com/sjmcdowall","followers_url":"https://api.github.com/users/sjmcdowall/followers","following_url":"https://api.github.com/users/sjmcdowall/following{/other_user}","gists_url":"https://api.github.com/users/sjmcdowall/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmcdowall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmcdowall/subscriptions","organizations_url":"https://api.github.com/users/sjmcdowall/orgs","repos_url":"https://api.github.com/users/sjmcdowall/repos","events_url":"https://api.github.com/users/sjmcdowall/events{/privacy}","received_events_url":"https://api.github.com/users/sjmcdowall/received_events","type":"User","site_admin":false},"repo":{"id":156218436,"node_id":"MDEwOlJlcG9zaXRvcnkxNTYyMTg0MzY=","name":"flutter","full_name":"sjmcdowall/flutter","private":false,"owner":{"login":"sjmcdowall","id":2034925,"node_id":"MDQ6VXNlcjIwMzQ5MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/2034925?v=4","gravatar_id":"","url":"https://api.github.com/users/sjmcdowall","html_url":"https://github.com/sjmcdowall","followers_url":"https://api.github.com/users/sjmcdowall/followers","following_url":"https://api.github.com/users/sjmcdowall/following{/other_user}","gists_url":"https://api.github.com/users/sjmcdowall/gists{/gist_id}","starred_url":"https://api.github.com/users/sjmcdowall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sjmcdowall/subscriptions","organizations_url":"https://api.github.com/users/sjmcdowall/orgs","repos_url":"https://api.github.com/users/sjmcdowall/repos","events_url":"https://api.github.com/users/sjmcdowall/events{/privacy}","received_events_url":"https://api.github.com/users/sjmcdowall/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sjmcdowall/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":true,"url":"https://api.github.com/repos/sjmcdowall/flutter","forks_url":"https://api.github.com/repos/sjmcdowall/flutter/forks","keys_url":"https://api.github.com/repos/sjmcdowall/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sjmcdowall/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sjmcdowall/flutter/teams","hooks_url":"https://api.github.com/repos/sjmcdowall/flutter/hooks","issue_events_url":"https://api.github.com/repos/sjmcdowall/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/sjmcdowall/flutter/events","assignees_url":"https://api.github.com/repos/sjmcdowall/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/sjmcdowall/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/sjmcdowall/flutter/tags","blobs_url":"https://api.github.com/repos/sjmcdowall/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sjmcdowall/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sjmcdowall/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/sjmcdowall/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sjmcdowall/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/sjmcdowall/flutter/languages","stargazers_url":"https://api.github.com/repos/sjmcdowall/flutter/stargazers","contributors_url":"https://api.github.com/repos/sjmcdowall/flutter/contributors","subscribers_url":"https://api.github.com/repos/sjmcdowall/flutter/subscribers","subscription_url":"https://api.github.com/repos/sjmcdowall/flutter/subscription","commits_url":"https://api.github.com/repos/sjmcdowall/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/sjmcdowall/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/sjmcdowall/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/sjmcdowall/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/sjmcdowall/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/sjmcdowall/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sjmcdowall/flutter/merges","archive_url":"https://api.github.com/repos/sjmcdowall/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sjmcdowall/flutter/downloads","issues_url":"https://api.github.com/repos/sjmcdowall/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/sjmcdowall/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/sjmcdowall/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/sjmcdowall/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sjmcdowall/flutter/labels{/name}","releases_url":"https://api.github.com/repos/sjmcdowall/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/sjmcdowall/flutter/deployments","created_at":"2018-11-05T12:59:47Z","updated_at":"2018-11-09T21:36:08Z","pushed_at":"2018-11-13T12:43:29Z","git_url":"git://github.com/sjmcdowall/flutter.git","ssh_url":"git@github.com:sjmcdowall/flutter.git","clone_url":"https://github.com/sjmcdowall/flutter.git","svn_url":"https://github.com/sjmcdowall/flutter","homepage":"https://flutter.io","size":48528,"stargazers_count":0,"watchers_count":0,"language":"Dart","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"flutter:master","ref":"master","sha":"43407e4e01d4ca6eadd5d76715fa58f5d4c78395","user":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"repo":{"id":31792824,"node_id":"MDEwOlJlcG9zaXRvcnkzMTc5MjgyNA==","name":"flutter","full_name":"flutter/flutter","private":false,"owner":{"login":"flutter","id":14101776,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTAxNzc2","avatar_url":"https://avatars3.githubusercontent.com/u/14101776?v=4","gravatar_id":"","url":"https://api.github.com/users/flutter","html_url":"https://github.com/flutter","followers_url":"https://api.github.com/users/flutter/followers","following_url":"https://api.github.com/users/flutter/following{/other_user}","gists_url":"https://api.github.com/users/flutter/gists{/gist_id}","starred_url":"https://api.github.com/users/flutter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/flutter/subscriptions","organizations_url":"https://api.github.com/users/flutter/orgs","repos_url":"https://api.github.com/users/flutter/repos","events_url":"https://api.github.com/users/flutter/events{/privacy}","received_events_url":"https://api.github.com/users/flutter/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/flutter/flutter","description":"Flutter makes it easy and fast to build beautiful mobile apps.","fork":false,"url":"https://api.github.com/repos/flutter/flutter","forks_url":"https://api.github.com/repos/flutter/flutter/forks","keys_url":"https://api.github.com/repos/flutter/flutter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/flutter/flutter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/flutter/flutter/teams","hooks_url":"https://api.github.com/repos/flutter/flutter/hooks","issue_events_url":"https://api.github.com/repos/flutter/flutter/issues/events{/number}","events_url":"https://api.github.com/repos/flutter/flutter/events","assignees_url":"https://api.github.com/repos/flutter/flutter/assignees{/user}","branches_url":"https://api.github.com/repos/flutter/flutter/branches{/branch}","tags_url":"https://api.github.com/repos/flutter/flutter/tags","blobs_url":"https://api.github.com/repos/flutter/flutter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/flutter/flutter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/flutter/flutter/git/refs{/sha}","trees_url":"https://api.github.com/repos/flutter/flutter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/flutter/flutter/statuses/{sha}","languages_url":"https://api.github.com/repos/flutter/flutter/languages","stargazers_url":"https://api.github.com/repos/flutter/flutter/stargazers","contributors_url":"https://api.github.com/repos/flutter/flutter/contributors","subscribers_url":"https://api.github.com/repos/flutter/flutter/subscribers","subscription_url":"https://api.github.com/repos/flutter/flutter/subscription","commits_url":"https://api.github.com/repos/flutter/flutter/commits{/sha}","git_commits_url":"https://api.github.com/repos/flutter/flutter/git/commits{/sha}","comments_url":"https://api.github.com/repos/flutter/flutter/comments{/number}","issue_comment_url":"https://api.github.com/repos/flutter/flutter/issues/comments{/number}","contents_url":"https://api.github.com/repos/flutter/flutter/contents/{+path}","compare_url":"https://api.github.com/repos/flutter/flutter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/flutter/flutter/merges","archive_url":"https://api.github.com/repos/flutter/flutter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/flutter/flutter/downloads","issues_url":"https://api.github.com/repos/flutter/flutter/issues{/number}","pulls_url":"https://api.github.com/repos/flutter/flutter/pulls{/number}","milestones_url":"https://api.github.com/repos/flutter/flutter/milestones{/number}","notifications_url":"https://api.github.com/repos/flutter/flutter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/flutter/flutter/labels{/name}","releases_url":"https://api.github.com/repos/flutter/flutter/releases{/id}","deployments_url":"https://api.github.com/repos/flutter/flutter/deployments","created_at":"2015-03-06T22:54:58Z","updated_at":"2018-11-13T15:53:52Z","pushed_at":"2018-11-13T16:38:49Z","git_url":"git://github.com/flutter/flutter.git","ssh_url":"git@github.com:flutter/flutter.git","clone_url":"https://github.com/flutter/flutter.git","svn_url":"https://github.com/flutter/flutter","homepage":"https://flutter.io","size":48979,"stargazers_count":41109,"watchers_count":41109,"language":"Dart","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4113,"mirror_url":null,"archived":false,"open_issues_count":4353,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4113,"open_issues":4353,"watchers":41109,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24183"},"html":{"href":"https://github.com/flutter/flutter/pull/24183"},"issue":{"href":"https://api.github.com/repos/flutter/flutter/issues/24183"},"comments":{"href":"https://api.github.com/repos/flutter/flutter/issues/24183/comments"},"review_comments":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24183/comments"},"review_comment":{"href":"https://api.github.com/repos/flutter/flutter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/flutter/flutter/pulls/24183/commits"},"statuses":{"href":"https://api.github.com/repos/flutter/flutter/statuses/5483cb895593f98716cee2689ff4df499b29ae85"}},"author_association":"NONE"}}
{"actor":{"display_login":"HansMuller"}}