{"action":"created","comment":{"url":"https://api.github.com/repos/pypa/pipenv/pulls/comments/224319747","pull_request_review_id":163655332,"id":224319747,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDMxOTc0Nw==","diff_hunk":"@@ -1344,7 +1345,8 @@ def pip_install(\n             index_source = index_source.copy()\n         except SourceNotFound:\n             src_name = project.src_name_from_url(index)\n-            verify_ssl = True if index not in trusted_hosts else False\n+            index_url = parse_url(index)\n+            verify_ssl = True if index_url.host not in trusted_hosts else False","path":"pipenv/core.py","position":14,"original_position":14,"commit_id":"272e98cb6749089341dd05e509a283d358cf2a59","original_commit_id":"272e98cb6749089341dd05e509a283d358cf2a59","user":{"login":"techalchemy","id":954310,"node_id":"MDQ6VXNlcjk1NDMxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/954310?v=4","gravatar_id":"","url":"https://api.github.com/users/techalchemy","html_url":"https://github.com/techalchemy","followers_url":"https://api.github.com/users/techalchemy/followers","following_url":"https://api.github.com/users/techalchemy/following{/other_user}","gists_url":"https://api.github.com/users/techalchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/techalchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techalchemy/subscriptions","organizations_url":"https://api.github.com/users/techalchemy/orgs","repos_url":"https://api.github.com/users/techalchemy/repos","events_url":"https://api.github.com/users/techalchemy/events{/privacy}","received_events_url":"https://api.github.com/users/techalchemy/received_events","type":"User","site_admin":false},"body":"bigger fish to fry on this one -- VCS installs are throwing permissions errors :(","created_at":"2018-10-11T05:38:48Z","updated_at":"2018-10-11T05:38:48Z","html_url":"https://github.com/pypa/pipenv/pull/2993#discussion_r224319747","pull_request_url":"https://api.github.com/repos/pypa/pipenv/pulls/2993","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pypa/pipenv/pulls/comments/224319747"},"html":{"href":"https://github.com/pypa/pipenv/pull/2993#discussion_r224319747"},"pull_request":{"href":"https://api.github.com/repos/pypa/pipenv/pulls/2993"}},"in_reply_to_id":224300488},"pull_request":{"url":"https://api.github.com/repos/pypa/pipenv/pulls/2993","id":221967744,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxOTY3NzQ0","html_url":"https://github.com/pypa/pipenv/pull/2993","diff_url":"https://github.com/pypa/pipenv/pull/2993.diff","patch_url":"https://github.com/pypa/pipenv/pull/2993.patch","issue_url":"https://api.github.com/repos/pypa/pipenv/issues/2993","number":2993,"state":"open","locked":false,"title":"Add spinner during locking","user":{"login":"techalchemy","id":954310,"node_id":"MDQ6VXNlcjk1NDMxMA==","avatar_url":"https://avatars0.githubusercontent.com/u/954310?v=4","gravatar_id":"","url":"https://api.github.com/users/techalchemy","html_url":"https://github.com/techalchemy","followers_url":"https://api.github.com/users/techalchemy/followers","following_url":"https://api.github.com/users/techalchemy/following{/other_user}","gists_url":"https://api.github.com/users/techalchemy/gists{/gist_id}","starred_url":"https://api.github.com/users/techalchemy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/techalchemy/subscriptions","organizations_url":"https://api.github.com/users/techalchemy/orgs","repos_url":"https://api.github.com/users/techalchemy/repos","events_url":"https://api.github.com/users/techalchemy/events{/privacy}","received_events_url":"https://api.github.com/users/techalchemy/received_events","type":"User","site_admin":false},"body":"Signed-off-by: Dan Ryan <dan@danryan.co>\r\n","created_at":"2018-10-10T23:56:06Z","updated_at":"2018-10-11T05:38:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4ef9be328cc5b2ca44cf88297db75047b80ed449","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pypa/pipenv/pulls/2993/commits","review_comments_url":"https://api.github.com/repos/pypa/pipenv/pulls/2993/comments","review_comment_url":"https://api.github.com/repos/pypa/pipenv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pypa/pipenv/issues/2993/comments","statuses_url":"https://api.github.com/repos/pypa/pipenv/statuses/272e98cb6749089341dd05e509a283d358cf2a59","head":{"label":"pypa:add-locking-spinner","ref":"add-locking-spinner","sha":"272e98cb6749089341dd05e509a283d358cf2a59","user":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":79510167,"node_id":"MDEwOlJlcG9zaXRvcnk3OTUxMDE2Nw==","name":"pipenv","full_name":"pypa/pipenv","private":false,"owner":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pypa/pipenv","description":" Python Development Workflow for Humans.","fork":false,"url":"https://api.github.com/repos/pypa/pipenv","forks_url":"https://api.github.com/repos/pypa/pipenv/forks","keys_url":"https://api.github.com/repos/pypa/pipenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/pipenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/pipenv/teams","hooks_url":"https://api.github.com/repos/pypa/pipenv/hooks","issue_events_url":"https://api.github.com/repos/pypa/pipenv/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/pipenv/events","assignees_url":"https://api.github.com/repos/pypa/pipenv/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/pipenv/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/pipenv/tags","blobs_url":"https://api.github.com/repos/pypa/pipenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/pipenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/pipenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/pipenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/pipenv/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/pipenv/languages","stargazers_url":"https://api.github.com/repos/pypa/pipenv/stargazers","contributors_url":"https://api.github.com/repos/pypa/pipenv/contributors","subscribers_url":"https://api.github.com/repos/pypa/pipenv/subscribers","subscription_url":"https://api.github.com/repos/pypa/pipenv/subscription","commits_url":"https://api.github.com/repos/pypa/pipenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/pipenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/pipenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/pipenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/pipenv/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/pipenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/pipenv/merges","archive_url":"https://api.github.com/repos/pypa/pipenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/pipenv/downloads","issues_url":"https://api.github.com/repos/pypa/pipenv/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/pipenv/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/pipenv/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/pipenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/pipenv/labels{/name}","releases_url":"https://api.github.com/repos/pypa/pipenv/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/pipenv/deployments","created_at":"2017-01-20T00:44:02Z","updated_at":"2018-10-11T05:32:45Z","pushed_at":"2018-10-11T03:55:02Z","git_url":"git://github.com/pypa/pipenv.git","ssh_url":"git@github.com:pypa/pipenv.git","clone_url":"https://github.com/pypa/pipenv.git","svn_url":"https://github.com/pypa/pipenv","homepage":"https://docs.pipenv.org/","size":220022,"stargazers_count":13880,"watchers_count":13880,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":985,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":985,"open_issues":170,"watchers":13880,"default_branch":"master"}},"base":{"label":"pypa:master","ref":"master","sha":"cae8bad0a86d8459a837d385c6d7863229e6e0b8","user":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"repo":{"id":79510167,"node_id":"MDEwOlJlcG9zaXRvcnk3OTUxMDE2Nw==","name":"pipenv","full_name":"pypa/pipenv","private":false,"owner":{"login":"pypa","id":647025,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzAyNQ==","avatar_url":"https://avatars2.githubusercontent.com/u/647025?v=4","gravatar_id":"","url":"https://api.github.com/users/pypa","html_url":"https://github.com/pypa","followers_url":"https://api.github.com/users/pypa/followers","following_url":"https://api.github.com/users/pypa/following{/other_user}","gists_url":"https://api.github.com/users/pypa/gists{/gist_id}","starred_url":"https://api.github.com/users/pypa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pypa/subscriptions","organizations_url":"https://api.github.com/users/pypa/orgs","repos_url":"https://api.github.com/users/pypa/repos","events_url":"https://api.github.com/users/pypa/events{/privacy}","received_events_url":"https://api.github.com/users/pypa/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pypa/pipenv","description":" Python Development Workflow for Humans.","fork":false,"url":"https://api.github.com/repos/pypa/pipenv","forks_url":"https://api.github.com/repos/pypa/pipenv/forks","keys_url":"https://api.github.com/repos/pypa/pipenv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pypa/pipenv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pypa/pipenv/teams","hooks_url":"https://api.github.com/repos/pypa/pipenv/hooks","issue_events_url":"https://api.github.com/repos/pypa/pipenv/issues/events{/number}","events_url":"https://api.github.com/repos/pypa/pipenv/events","assignees_url":"https://api.github.com/repos/pypa/pipenv/assignees{/user}","branches_url":"https://api.github.com/repos/pypa/pipenv/branches{/branch}","tags_url":"https://api.github.com/repos/pypa/pipenv/tags","blobs_url":"https://api.github.com/repos/pypa/pipenv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pypa/pipenv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pypa/pipenv/git/refs{/sha}","trees_url":"https://api.github.com/repos/pypa/pipenv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pypa/pipenv/statuses/{sha}","languages_url":"https://api.github.com/repos/pypa/pipenv/languages","stargazers_url":"https://api.github.com/repos/pypa/pipenv/stargazers","contributors_url":"https://api.github.com/repos/pypa/pipenv/contributors","subscribers_url":"https://api.github.com/repos/pypa/pipenv/subscribers","subscription_url":"https://api.github.com/repos/pypa/pipenv/subscription","commits_url":"https://api.github.com/repos/pypa/pipenv/commits{/sha}","git_commits_url":"https://api.github.com/repos/pypa/pipenv/git/commits{/sha}","comments_url":"https://api.github.com/repos/pypa/pipenv/comments{/number}","issue_comment_url":"https://api.github.com/repos/pypa/pipenv/issues/comments{/number}","contents_url":"https://api.github.com/repos/pypa/pipenv/contents/{+path}","compare_url":"https://api.github.com/repos/pypa/pipenv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pypa/pipenv/merges","archive_url":"https://api.github.com/repos/pypa/pipenv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pypa/pipenv/downloads","issues_url":"https://api.github.com/repos/pypa/pipenv/issues{/number}","pulls_url":"https://api.github.com/repos/pypa/pipenv/pulls{/number}","milestones_url":"https://api.github.com/repos/pypa/pipenv/milestones{/number}","notifications_url":"https://api.github.com/repos/pypa/pipenv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pypa/pipenv/labels{/name}","releases_url":"https://api.github.com/repos/pypa/pipenv/releases{/id}","deployments_url":"https://api.github.com/repos/pypa/pipenv/deployments","created_at":"2017-01-20T00:44:02Z","updated_at":"2018-10-11T05:32:45Z","pushed_at":"2018-10-11T03:55:02Z","git_url":"git://github.com/pypa/pipenv.git","ssh_url":"git@github.com:pypa/pipenv.git","clone_url":"https://github.com/pypa/pipenv.git","svn_url":"https://github.com/pypa/pipenv","homepage":"https://docs.pipenv.org/","size":220022,"stargazers_count":13880,"watchers_count":13880,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":985,"mirror_url":null,"archived":false,"open_issues_count":170,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":985,"open_issues":170,"watchers":13880,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pypa/pipenv/pulls/2993"},"html":{"href":"https://github.com/pypa/pipenv/pull/2993"},"issue":{"href":"https://api.github.com/repos/pypa/pipenv/issues/2993"},"comments":{"href":"https://api.github.com/repos/pypa/pipenv/issues/2993/comments"},"review_comments":{"href":"https://api.github.com/repos/pypa/pipenv/pulls/2993/comments"},"review_comment":{"href":"https://api.github.com/repos/pypa/pipenv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pypa/pipenv/pulls/2993/commits"},"statuses":{"href":"https://api.github.com/repos/pypa/pipenv/statuses/272e98cb6749089341dd05e509a283d358cf2a59"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"techalchemy"}}