{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/community/pulls/comments/206907592","pull_request_review_id":142401978,"id":206907592,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjkwNzU5Mg==","diff_hunk":"@@ -0,0 +1,55 @@\n+# SIG Instrumentation Charter\n+\n+This charter adheres to the conventions described in the [Kubernetes Charter README] and uses\n+the Roles and Organization Management outlined in [sig-governance].\n+\n+## Scope\n+\n+Owns best practices for cluster observability through metrics, logging, and\n+events across all Kubernetes components and development of relevant components.\n+\n+### In scope\n+\n+Coordinating metric requirements of different SIGs for other components through finding common APIs.\n+\n+#### Code, Binaries and Services\n+\n+[List of subprojects](https://github.com/kubernetes/community/tree/master/sig-instrumentation#subprojects)\n+\n+- Components required for any Kubernetes cluster in regards to observability. ([kubernetes-incubator/metrics-server](https://github.com/kubernetes-incubator/metrics-server), [kubenernetes/heapster](https://github.com/kubernetes/heapster))\n+- Interfaces/API definitions required for any Kubernetes cluster in regards to observability. ([kubernetes/metrics](https://github.com/kubernetes/metrics), [kubernetes-incubator/custom-metrics-apiserver](https://github.com/kubernetes-incubator/custom-metrics-apiserver))\n+- Well established but optional components or adapters for Kubernetes clusters, if endorsed by members. Each component must have two or more members as maintainers. ([kubernetes/kube-state-metrics](https://github.com/kubernetes/kube-state-metrics), not yet officially owned by SIG Instrumentation, but an example prospect for this category: [DirectXMan12/k8s-prometheus-adapter](https://github.com/DirectXMan12/k8s-prometheus-adapter))\n+\n+#### Cross-cutting and Externally Facing Processes\n+\n+- Guidance for instrumentation in order to ensure consistent and high quality instrumentation of core Kubernetes components. This includes:\n+  - Reviewing any instrumentation related changes and additions.\n+  - Guidance on what should be instrumented as well as dimensions of the same.\n+  - Creating, adding and maintaining the Kubernetes instrumentation guidelines.\n+  - Coordinate cross SIG instrumentation efforts.\n+\n+### Out of scope\n+\n+- Processing of signals. For example ingesting metrics, logs, events into external systems.\n+- Dictating what states must result in an alert. Suggestions or opt-in alerts may be in scope.\n+","path":"sig-instrumentation/charter.md","position":35,"original_position":35,"commit_id":"bd7b6950fecb0cf87ff8734b64f6a2305370737e","original_commit_id":"bd7b6950fecb0cf87ff8734b64f6a2305370737e","user":{"login":"derekwaynecarr","id":6233452,"node_id":"MDQ6VXNlcjYyMzM0NTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6233452?v=4","gravatar_id":"","url":"https://api.github.com/users/derekwaynecarr","html_url":"https://github.com/derekwaynecarr","followers_url":"https://api.github.com/users/derekwaynecarr/followers","following_url":"https://api.github.com/users/derekwaynecarr/following{/other_user}","gists_url":"https://api.github.com/users/derekwaynecarr/gists{/gist_id}","starred_url":"https://api.github.com/users/derekwaynecarr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/derekwaynecarr/subscriptions","organizations_url":"https://api.github.com/users/derekwaynecarr/orgs","repos_url":"https://api.github.com/users/derekwaynecarr/repos","events_url":"https://api.github.com/users/derekwaynecarr/events{/privacy}","received_events_url":"https://api.github.com/users/derekwaynecarr/received_events","type":"User","site_admin":false},"body":"i would say alert management is outside the scope entirely?","created_at":"2018-08-01T14:42:44Z","updated_at":"2018-08-01T14:43:12Z","html_url":"https://github.com/kubernetes/community/pull/2266#discussion_r206907592","pull_request_url":"https://api.github.com/repos/kubernetes/community/pulls/2266","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/community/pulls/comments/206907592"},"html":{"href":"https://github.com/kubernetes/community/pull/2266#discussion_r206907592"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/community/pulls/2266"}},"in_reply_to_id":205896799},"pull_request":{"url":"https://api.github.com/repos/kubernetes/community/pulls/2266","id":194945019,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0OTQ1MDE5","html_url":"https://github.com/kubernetes/community/pull/2266","diff_url":"https://github.com/kubernetes/community/pull/2266.diff","patch_url":"https://github.com/kubernetes/community/pull/2266.patch","issue_url":"https://api.github.com/repos/kubernetes/community/issues/2266","number":2266,"state":"open","locked":false,"title":"sig-instrumentation: Add charter document","user":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"body":"This PR is currently work in progress and meant for sig-instrumentation to iterate on its charter document.\r\n\r\n@kubernetes/sig-instrumentation-misc ","created_at":"2018-06-14T16:08:35Z","updated_at":"2018-08-01T14:43:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf62af2c9362116eb379c2a5a4cef39f78d7a1ae","assignee":null,"assignees":[],"requested_reviewers":[{"login":"idvoretskyi","id":118459,"node_id":"MDQ6VXNlcjExODQ1OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/118459?v=4","gravatar_id":"","url":"https://api.github.com/users/idvoretskyi","html_url":"https://github.com/idvoretskyi","followers_url":"https://api.github.com/users/idvoretskyi/followers","following_url":"https://api.github.com/users/idvoretskyi/following{/other_user}","gists_url":"https://api.github.com/users/idvoretskyi/gists{/gist_id}","starred_url":"https://api.github.com/users/idvoretskyi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/idvoretskyi/subscriptions","organizations_url":"https://api.github.com/users/idvoretskyi/orgs","repos_url":"https://api.github.com/users/idvoretskyi/repos","events_url":"https://api.github.com/users/idvoretskyi/events{/privacy}","received_events_url":"https://api.github.com/users/idvoretskyi/received_events","type":"User","site_admin":false},{"login":"piosz","id":10819974,"node_id":"MDQ6VXNlcjEwODE5OTc0","avatar_url":"https://avatars0.githubusercontent.com/u/10819974?v=4","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":486032367,"node_id":"MDU6TGFiZWw0ODYwMzIzNjc=","url":"https://api.github.com/repos/kubernetes/community/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":670302793,"node_id":"MDU6TGFiZWw2NzAzMDI3OTM=","url":"https://api.github.com/repos/kubernetes/community/labels/committee/steering","name":"committee/steering","color":"c0ff4a","default":false},{"id":653942889,"node_id":"MDU6TGFiZWw2NTM5NDI4ODk=","url":"https://api.github.com/repos/kubernetes/community/labels/sig/instrumentation","name":"sig/instrumentation","color":"d2b48c","default":false},{"id":653942911,"node_id":"MDU6TGFiZWw2NTM5NDI5MTE=","url":"https://api.github.com/repos/kubernetes/community/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/community/pulls/2266/commits","review_comments_url":"https://api.github.com/repos/kubernetes/community/pulls/2266/comments","review_comment_url":"https://api.github.com/repos/kubernetes/community/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/community/issues/2266/comments","statuses_url":"https://api.github.com/repos/kubernetes/community/statuses/bd7b6950fecb0cf87ff8734b64f6a2305370737e","head":{"label":"brancz:sig-instrumentation-charter","ref":"sig-instrumentation-charter","sha":"bd7b6950fecb0cf87ff8734b64f6a2305370737e","user":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"repo":{"id":110873644,"node_id":"MDEwOlJlcG9zaXRvcnkxMTA4NzM2NDQ=","name":"community","full_name":"brancz/community","owner":{"login":"brancz","id":4546722,"node_id":"MDQ6VXNlcjQ1NDY3MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/4546722?v=4","gravatar_id":"","url":"https://api.github.com/users/brancz","html_url":"https://github.com/brancz","followers_url":"https://api.github.com/users/brancz/followers","following_url":"https://api.github.com/users/brancz/following{/other_user}","gists_url":"https://api.github.com/users/brancz/gists{/gist_id}","starred_url":"https://api.github.com/users/brancz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brancz/subscriptions","organizations_url":"https://api.github.com/users/brancz/orgs","repos_url":"https://api.github.com/users/brancz/repos","events_url":"https://api.github.com/users/brancz/events{/privacy}","received_events_url":"https://api.github.com/users/brancz/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brancz/community","description":"Kubernetes community content","fork":true,"url":"https://api.github.com/repos/brancz/community","forks_url":"https://api.github.com/repos/brancz/community/forks","keys_url":"https://api.github.com/repos/brancz/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brancz/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brancz/community/teams","hooks_url":"https://api.github.com/repos/brancz/community/hooks","issue_events_url":"https://api.github.com/repos/brancz/community/issues/events{/number}","events_url":"https://api.github.com/repos/brancz/community/events","assignees_url":"https://api.github.com/repos/brancz/community/assignees{/user}","branches_url":"https://api.github.com/repos/brancz/community/branches{/branch}","tags_url":"https://api.github.com/repos/brancz/community/tags","blobs_url":"https://api.github.com/repos/brancz/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brancz/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brancz/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/brancz/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brancz/community/statuses/{sha}","languages_url":"https://api.github.com/repos/brancz/community/languages","stargazers_url":"https://api.github.com/repos/brancz/community/stargazers","contributors_url":"https://api.github.com/repos/brancz/community/contributors","subscribers_url":"https://api.github.com/repos/brancz/community/subscribers","subscription_url":"https://api.github.com/repos/brancz/community/subscription","commits_url":"https://api.github.com/repos/brancz/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/brancz/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/brancz/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/brancz/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/brancz/community/contents/{+path}","compare_url":"https://api.github.com/repos/brancz/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brancz/community/merges","archive_url":"https://api.github.com/repos/brancz/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brancz/community/downloads","issues_url":"https://api.github.com/repos/brancz/community/issues{/number}","pulls_url":"https://api.github.com/repos/brancz/community/pulls{/number}","milestones_url":"https://api.github.com/repos/brancz/community/milestones{/number}","notifications_url":"https://api.github.com/repos/brancz/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brancz/community/labels{/name}","releases_url":"https://api.github.com/repos/brancz/community/releases{/id}","deployments_url":"https://api.github.com/repos/brancz/community/deployments","created_at":"2017-11-15T18:56:20Z","updated_at":"2017-11-15T18:56:23Z","pushed_at":"2018-07-27T07:12:02Z","git_url":"git://github.com/brancz/community.git","ssh_url":"git@github.com:brancz/community.git","clone_url":"https://github.com/brancz/community.git","svn_url":"https://github.com/brancz/community","homepage":"","size":20447,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"3baee89a4b0fce89b7ab81d8709857874f6c2937","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":57939112,"node_id":"MDEwOlJlcG9zaXRvcnk1NzkzOTExMg==","name":"community","full_name":"kubernetes/community","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/community","description":"Kubernetes community content","fork":false,"url":"https://api.github.com/repos/kubernetes/community","forks_url":"https://api.github.com/repos/kubernetes/community/forks","keys_url":"https://api.github.com/repos/kubernetes/community/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/community/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/community/teams","hooks_url":"https://api.github.com/repos/kubernetes/community/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/community/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/community/events","assignees_url":"https://api.github.com/repos/kubernetes/community/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/community/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/community/tags","blobs_url":"https://api.github.com/repos/kubernetes/community/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/community/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/community/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/community/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/community/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/community/languages","stargazers_url":"https://api.github.com/repos/kubernetes/community/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/community/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/community/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/community/subscription","commits_url":"https://api.github.com/repos/kubernetes/community/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/community/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/community/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/community/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/community/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/community/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/community/merges","archive_url":"https://api.github.com/repos/kubernetes/community/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/community/downloads","issues_url":"https://api.github.com/repos/kubernetes/community/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/community/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/community/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/community/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/community/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/community/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/community/deployments","created_at":"2016-05-03T03:36:05Z","updated_at":"2018-08-01T07:40:24Z","pushed_at":"2018-08-01T14:08:11Z","git_url":"git://github.com/kubernetes/community.git","ssh_url":"git@github.com:kubernetes/community.git","clone_url":"https://github.com/kubernetes/community.git","svn_url":"https://github.com/kubernetes/community","homepage":"","size":29087,"stargazers_count":2262,"watchers_count":2262,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1350,"mirror_url":null,"archived":false,"open_issues_count":226,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1350,"open_issues":226,"watchers":2262,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/community/pulls/2266"},"html":{"href":"https://github.com/kubernetes/community/pull/2266"},"issue":{"href":"https://api.github.com/repos/kubernetes/community/issues/2266"},"comments":{"href":"https://api.github.com/repos/kubernetes/community/issues/2266/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/community/pulls/2266/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/community/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/community/pulls/2266/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/community/statuses/bd7b6950fecb0cf87ff8734b64f6a2305370737e"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"derekwaynecarr"}}