{"action":"closed","number":260,"pull_request":{"url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls/260","id":240385121,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQwMzg1MTIx","html_url":"https://github.com/bradzacher/eslint-plugin-typescript/pull/260","diff_url":"https://github.com/bradzacher/eslint-plugin-typescript/pull/260.diff","patch_url":"https://github.com/bradzacher/eslint-plugin-typescript/pull/260.patch","issue_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues/260","number":260,"state":"closed","locked":false,"title":"[FEAT] [BREAKING] [no-unused-vars] remove implicit dep on base rule","user":{"login":"bradzacher","id":7462525,"node_id":"MDQ6VXNlcjc0NjI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7462525?v=4","gravatar_id":"","url":"https://api.github.com/users/bradzacher","html_url":"https://github.com/bradzacher","followers_url":"https://api.github.com/users/bradzacher/followers","following_url":"https://api.github.com/users/bradzacher/following{/other_user}","gists_url":"https://api.github.com/users/bradzacher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradzacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradzacher/subscriptions","organizations_url":"https://api.github.com/users/bradzacher/orgs","repos_url":"https://api.github.com/users/bradzacher/repos","events_url":"https://api.github.com/users/bradzacher/events{/privacy}","received_events_url":"https://api.github.com/users/bradzacher/received_events","type":"User","site_admin":false},"body":"Similar to what we've done with both indent, and camelcase.\r\nRather than forcing users to configure both our rule and the base rule (which has been a source of confusion), this lets users just use our rule.\r\n\r\n```diff\r\n {\r\n-    \"no-unused-vars\": [\"error\", { config }],\r\n+    \"no-unused-vars\": \"off\",\r\n-    \"typescript/no-unused-vars\": \"error\",\r\n+    \"typescript/no-unused-vars\": [\"error\", { config }],\r\n }\r\n```","created_at":"2018-12-21T06:38:47Z","updated_at":"2018-12-21T17:17:58Z","closed_at":"2018-12-21T17:17:58Z","merged_at":"2018-12-21T17:17:58Z","merge_commit_sha":"787d5e3a2664d5ebe8b3e1385dab3bcc43ba1392","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls/260/commits","review_comments_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls/260/comments","review_comment_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls/comments{/number}","comments_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues/260/comments","statuses_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/statuses/6cb7e699311242b68fa82464fa0b3dbb747ca99e","head":{"label":"bradzacher:no-unused-vars-extension","ref":"no-unused-vars-extension","sha":"6cb7e699311242b68fa82464fa0b3dbb747ca99e","user":{"login":"bradzacher","id":7462525,"node_id":"MDQ6VXNlcjc0NjI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7462525?v=4","gravatar_id":"","url":"https://api.github.com/users/bradzacher","html_url":"https://github.com/bradzacher","followers_url":"https://api.github.com/users/bradzacher/followers","following_url":"https://api.github.com/users/bradzacher/following{/other_user}","gists_url":"https://api.github.com/users/bradzacher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradzacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradzacher/subscriptions","organizations_url":"https://api.github.com/users/bradzacher/orgs","repos_url":"https://api.github.com/users/bradzacher/repos","events_url":"https://api.github.com/users/bradzacher/events{/privacy}","received_events_url":"https://api.github.com/users/bradzacher/received_events","type":"User","site_admin":false},"repo":{"id":66300346,"node_id":"MDEwOlJlcG9zaXRvcnk2NjMwMDM0Ng==","name":"eslint-plugin-typescript","full_name":"bradzacher/eslint-plugin-typescript","private":false,"owner":{"login":"bradzacher","id":7462525,"node_id":"MDQ6VXNlcjc0NjI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7462525?v=4","gravatar_id":"","url":"https://api.github.com/users/bradzacher","html_url":"https://github.com/bradzacher","followers_url":"https://api.github.com/users/bradzacher/followers","following_url":"https://api.github.com/users/bradzacher/following{/other_user}","gists_url":"https://api.github.com/users/bradzacher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradzacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradzacher/subscriptions","organizations_url":"https://api.github.com/users/bradzacher/orgs","repos_url":"https://api.github.com/users/bradzacher/repos","events_url":"https://api.github.com/users/bradzacher/events{/privacy}","received_events_url":"https://api.github.com/users/bradzacher/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bradzacher/eslint-plugin-typescript","description":"TypeScript plugin for ESLint","fork":false,"url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript","forks_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/forks","keys_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/teams","hooks_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/hooks","issue_events_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/events","assignees_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/tags","blobs_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/languages","stargazers_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/stargazers","contributors_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/contributors","subscribers_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/subscribers","subscription_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/subscription","commits_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/merges","archive_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/downloads","issues_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/labels{/name}","releases_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/deployments","created_at":"2016-08-22T19:05:14Z","updated_at":"2018-12-21T17:09:52Z","pushed_at":"2018-12-21T17:17:58Z","git_url":"git://github.com/bradzacher/eslint-plugin-typescript.git","ssh_url":"git@github.com:bradzacher/eslint-plugin-typescript.git","clone_url":"https://github.com/bradzacher/eslint-plugin-typescript.git","svn_url":"https://github.com/bradzacher/eslint-plugin-typescript","homepage":null,"size":667,"stargazers_count":308,"watchers_count":308,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":50,"open_issues":25,"watchers":308,"default_branch":"master"}},"base":{"label":"bradzacher:master","ref":"master","sha":"1085a6b6368c338fb2ed4c91c900969229a75739","user":{"login":"bradzacher","id":7462525,"node_id":"MDQ6VXNlcjc0NjI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7462525?v=4","gravatar_id":"","url":"https://api.github.com/users/bradzacher","html_url":"https://github.com/bradzacher","followers_url":"https://api.github.com/users/bradzacher/followers","following_url":"https://api.github.com/users/bradzacher/following{/other_user}","gists_url":"https://api.github.com/users/bradzacher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradzacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradzacher/subscriptions","organizations_url":"https://api.github.com/users/bradzacher/orgs","repos_url":"https://api.github.com/users/bradzacher/repos","events_url":"https://api.github.com/users/bradzacher/events{/privacy}","received_events_url":"https://api.github.com/users/bradzacher/received_events","type":"User","site_admin":false},"repo":{"id":66300346,"node_id":"MDEwOlJlcG9zaXRvcnk2NjMwMDM0Ng==","name":"eslint-plugin-typescript","full_name":"bradzacher/eslint-plugin-typescript","private":false,"owner":{"login":"bradzacher","id":7462525,"node_id":"MDQ6VXNlcjc0NjI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7462525?v=4","gravatar_id":"","url":"https://api.github.com/users/bradzacher","html_url":"https://github.com/bradzacher","followers_url":"https://api.github.com/users/bradzacher/followers","following_url":"https://api.github.com/users/bradzacher/following{/other_user}","gists_url":"https://api.github.com/users/bradzacher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradzacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradzacher/subscriptions","organizations_url":"https://api.github.com/users/bradzacher/orgs","repos_url":"https://api.github.com/users/bradzacher/repos","events_url":"https://api.github.com/users/bradzacher/events{/privacy}","received_events_url":"https://api.github.com/users/bradzacher/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bradzacher/eslint-plugin-typescript","description":"TypeScript plugin for ESLint","fork":false,"url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript","forks_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/forks","keys_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/teams","hooks_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/hooks","issue_events_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues/events{/number}","events_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/events","assignees_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/assignees{/user}","branches_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/branches{/branch}","tags_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/tags","blobs_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/refs{/sha}","trees_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/statuses/{sha}","languages_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/languages","stargazers_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/stargazers","contributors_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/contributors","subscribers_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/subscribers","subscription_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/subscription","commits_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/commits{/sha}","git_commits_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/git/commits{/sha}","comments_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/comments{/number}","issue_comment_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues/comments{/number}","contents_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/contents/{+path}","compare_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/merges","archive_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/downloads","issues_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues{/number}","pulls_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls{/number}","milestones_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/milestones{/number}","notifications_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/labels{/name}","releases_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/releases{/id}","deployments_url":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/deployments","created_at":"2016-08-22T19:05:14Z","updated_at":"2018-12-21T17:09:52Z","pushed_at":"2018-12-21T17:17:58Z","git_url":"git://github.com/bradzacher/eslint-plugin-typescript.git","ssh_url":"git@github.com:bradzacher/eslint-plugin-typescript.git","clone_url":"https://github.com/bradzacher/eslint-plugin-typescript.git","svn_url":"https://github.com/bradzacher/eslint-plugin-typescript","homepage":null,"size":667,"stargazers_count":308,"watchers_count":308,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":50,"open_issues":25,"watchers":308,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls/260"},"html":{"href":"https://github.com/bradzacher/eslint-plugin-typescript/pull/260"},"issue":{"href":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues/260"},"comments":{"href":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/issues/260/comments"},"review_comments":{"href":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls/260/comments"},"review_comment":{"href":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/pulls/260/commits"},"statuses":{"href":"https://api.github.com/repos/bradzacher/eslint-plugin-typescript/statuses/6cb7e699311242b68fa82464fa0b3dbb747ca99e"}},"author_association":"OWNER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bradzacher","id":7462525,"node_id":"MDQ6VXNlcjc0NjI1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/7462525?v=4","gravatar_id":"","url":"https://api.github.com/users/bradzacher","html_url":"https://github.com/bradzacher","followers_url":"https://api.github.com/users/bradzacher/followers","following_url":"https://api.github.com/users/bradzacher/following{/other_user}","gists_url":"https://api.github.com/users/bradzacher/gists{/gist_id}","starred_url":"https://api.github.com/users/bradzacher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bradzacher/subscriptions","organizations_url":"https://api.github.com/users/bradzacher/orgs","repos_url":"https://api.github.com/users/bradzacher/repos","events_url":"https://api.github.com/users/bradzacher/events{/privacy}","received_events_url":"https://api.github.com/users/bradzacher/received_events","type":"User","site_admin":false},"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":297,"deletions":34,"changed_files":6}}
{"actor":{"display_login":"bradzacher"}}