{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/184015774","pull_request_review_id":115123130,"id":184015774,"diff_hunk":"@@ -10,4 +10,15 @@\n \n public interface ElasticsearchIndexFamily extends IndexFamily {\n \n+\t/**\n+\t * Retrieve the underlying, low-level client used to communicate with the Elasticsearch cluster.\n+\t * <p>\n+\t * <strong>WARNING - Unsupported API:</strong> the underlying client class may change without notice.\n+\t *\n+\t * @param clientClass The {@link Class} representing the expected client type\n+\t * @return The client.\n+\t * @throws SecurityException if the underlying client does not implement the given class.","path":"elasticsearch/src/main/java/org/hibernate/search/elasticsearch/indexes/spi/ElasticsearchIndexFamily.java","position":null,"original_position":11,"commit_id":"5ef5424bd814e09630ec4402e8dd7a6d7617114a","original_commit_id":"947b408a23391c161a52ff4a564a0cb076469fb4","user":{"login":"gsmet","id":1279749,"avatar_url":"https://avatars1.githubusercontent.com/u/1279749?v=4","gravatar_id":"","url":"https://api.github.com/users/gsmet","html_url":"https://github.com/gsmet","followers_url":"https://api.github.com/users/gsmet/followers","following_url":"https://api.github.com/users/gsmet/following{/other_user}","gists_url":"https://api.github.com/users/gsmet/gists{/gist_id}","starred_url":"https://api.github.com/users/gsmet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gsmet/subscriptions","organizations_url":"https://api.github.com/users/gsmet/orgs","repos_url":"https://api.github.com/users/gsmet/repos","events_url":"https://api.github.com/users/gsmet/events{/privacy}","received_events_url":"https://api.github.com/users/gsmet/received_events","type":"User","site_admin":false},"body":"`SecurityException`?","created_at":"2018-04-25T10:49:04Z","updated_at":"2018-04-25T10:56:49Z","html_url":"https://github.com/hibernate/hibernate-search/pull/1661#discussion_r184015774","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1661","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments/184015774"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/1661#discussion_r184015774"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1661"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1661","id":183378281,"html_url":"https://github.com/hibernate/hibernate-search/pull/1661","diff_url":"https://github.com/hibernate/hibernate-search/pull/1661.diff","patch_url":"https://github.com/hibernate/hibernate-search/pull/1661.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1661","number":1661,"state":"open","locked":false,"title":"HSEARCH-3125 Allow native access to the Elasticsearch RestClient","user":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars1.githubusercontent.com/u/412878?v=4","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"body":"https://hibernate.atlassian.net//browse/HSEARCH-3125\r\nAlso fixes https://hibernate.atlassian.net/browse/HSEARCH-3133\r\n\r\nI tried to do something conceptually similar to [what will be available in Search 6](https://github.com/hibernate/hibernate-search-6-poc/pull/41). See the [test in Search 6](https://github.com/hibernate/hibernate-search-6-poc/pull/41/files#diff-9524dadfd8aa7e1f285ef679979ca04eR284) vs. the test in this PR (`ElasticsearchLowLevelClientAccessIT#indexFamily_getClient()`).\r\n\r\nUnfortunately, I couldn't use the same wording as in Search 6, since the term \"backend\" has a very different meaning in Search 5. I chose to borrow Sanne's idea of \"index families\".\r\n\r\n### About IndexManagerType\r\n\r\nFor now I used a trick to expose `IndexFamilyType` on the API side while still relying on `IndexManagerType` internally, because the concept of `IndexManagerType` did not seem to make sense from an API point of view:\r\n\r\n1. Index managers are an SPI concept, rarely even seen on the API side\r\n2. I find the term `IndexManagerType` way too generic and confusing to use this wording in APIs\r\n\r\n`IndexManagerType` is really more of a `IndexFamilyTypeImplementor`:\r\n\r\n1. the very javadoc of `IndexManagerType` states it \"avoid susing the class type of an IndexManager to allow creating multiple custom implementations for the same type of technology\", so there could actually be multiple `IndexManager` classes (types) for a given `IndexManagerType`.\r\n2. if you have a look at how `IndexManagerType` is used, it's generally to refer to an index family (either Lucene or Elasticsearch).\r\n3. after this PR, `IndexManagerType` extends `IndexFamilyType` by adding some SPI-specific methods. Thus it's really the implementor side of `IndexFamilyType`.\r\n\r\nHowever, I didn't rename the (SPI only) concept of `IndexManagerType`, because that would lead to even more changes in our code, and I don't think it would bring much, since I don't expect we will be using this concept a lot in 5.","created_at":"2018-04-23T09:43:11Z","updated_at":"2018-04-25T10:56:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"411be211278ed72608824a0812d72d401c3ebb70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1661/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1661/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/1661/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/5ef5424bd814e09630ec4402e8dd7a6d7617114a","head":{"label":"yrodiere:HSEARCH-3125","ref":"HSEARCH-3125","sha":"5ef5424bd814e09630ec4402e8dd7a6d7617114a","user":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars1.githubusercontent.com/u/412878?v=4","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"repo":{"id":56803577,"name":"hibernate-search","full_name":"yrodiere/hibernate-search","owner":{"login":"yrodiere","id":412878,"avatar_url":"https://avatars1.githubusercontent.com/u/412878?v=4","gravatar_id":"","url":"https://api.github.com/users/yrodiere","html_url":"https://github.com/yrodiere","followers_url":"https://api.github.com/users/yrodiere/followers","following_url":"https://api.github.com/users/yrodiere/following{/other_user}","gists_url":"https://api.github.com/users/yrodiere/gists{/gist_id}","starred_url":"https://api.github.com/users/yrodiere/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yrodiere/subscriptions","organizations_url":"https://api.github.com/users/yrodiere/orgs","repos_url":"https://api.github.com/users/yrodiere/repos","events_url":"https://api.github.com/users/yrodiere/events{/privacy}","received_events_url":"https://api.github.com/users/yrodiere/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yrodiere/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":true,"url":"https://api.github.com/repos/yrodiere/hibernate-search","forks_url":"https://api.github.com/repos/yrodiere/hibernate-search/forks","keys_url":"https://api.github.com/repos/yrodiere/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yrodiere/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yrodiere/hibernate-search/teams","hooks_url":"https://api.github.com/repos/yrodiere/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/yrodiere/hibernate-search/events","assignees_url":"https://api.github.com/repos/yrodiere/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/yrodiere/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/yrodiere/hibernate-search/tags","blobs_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yrodiere/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/yrodiere/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/yrodiere/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/yrodiere/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/yrodiere/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/yrodiere/hibernate-search/subscription","commits_url":"https://api.github.com/repos/yrodiere/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/yrodiere/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/yrodiere/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/yrodiere/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/yrodiere/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yrodiere/hibernate-search/merges","archive_url":"https://api.github.com/repos/yrodiere/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yrodiere/hibernate-search/downloads","issues_url":"https://api.github.com/repos/yrodiere/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/yrodiere/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/yrodiere/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/yrodiere/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yrodiere/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/yrodiere/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/yrodiere/hibernate-search/deployments","created_at":"2016-04-21T20:27:30Z","updated_at":"2018-04-10T07:34:11Z","pushed_at":"2018-04-25T10:40:59Z","git_url":"git://github.com/yrodiere/hibernate-search.git","ssh_url":"git@github.com:yrodiere/hibernate-search.git","clone_url":"https://github.com/yrodiere/hibernate-search.git","svn_url":"https://github.com/yrodiere/hibernate-search","homepage":"http://search.hibernate.org","size":56579,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"75323d9e4de89ba6be63ed60a29c53ee56df577c","user":{"login":"hibernate","id":348262,"avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":990281,"name":"hibernate-search","full_name":"hibernate/hibernate-search","owner":{"login":"hibernate","id":348262,"avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hibernate/hibernate-search","description":"Hibernate Search: full-text search for domain model","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-search","forks_url":"https://api.github.com/repos/hibernate/hibernate-search/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-search/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-search/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-search/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-search/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-search/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-search/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-search/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-search/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-search/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-search/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-search/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-search/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-search/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-search/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-search/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-search/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-search/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-search/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-search/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-search/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-search/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-search/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-search/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-search/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-search/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-search/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-search/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-search/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-search/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-search/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-search/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-search/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-search/deployments","created_at":"2010-10-15T15:55:09Z","updated_at":"2018-04-19T14:54:42Z","pushed_at":"2018-04-25T10:41:00Z","git_url":"git://github.com/hibernate/hibernate-search.git","ssh_url":"git@github.com:hibernate/hibernate-search.git","clone_url":"https://github.com/hibernate/hibernate-search.git","svn_url":"https://github.com/hibernate/hibernate-search","homepage":"http://hibernate.org/search/","size":53889,"stargazers_count":273,"watchers_count":273,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":183,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":183,"open_issues":10,"watchers":273,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1661"},"html":{"href":"https://github.com/hibernate/hibernate-search/pull/1661"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1661"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/issues/1661/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1661/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-search/pulls/1661/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-search/statuses/5ef5424bd814e09630ec4402e8dd7a6d7617114a"}},"author_association":"OWNER"}}
{"actor":{"display_login":"gsmet"}}