{"push_id":2788937686,"size":9,"distinct_size":9,"ref":"refs/heads/improve-mc-copy","head":"9c0bea7e776d316d4dc80618f94378f181fce244","before":"8540b1feaf1de48d1adaae6df65cb30f191eb43b","commits":[{"sha":"89819a4ba947b5a144fca4afe09b450839f08262","author":{"name":"Andrew Laing","email":"4ef75a97462d6535a13de83c35c957d957ab5786@gmail.com"},"message":"Add padding around above threshold SiPM samples\n\nMakes the baseline calculation more reliable\nand MC more similar to data.\n\nFixes bug noticed in MC runs.","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/89819a4ba947b5a144fca4afe09b450839f08262"},{"sha":"899a92b3a21a37b0f7127e3aff0f0aad62bda291","author":{"name":"Andrew Laing","email":"4ef75a97462d6535a13de83c35c957d957ab5786@gmail.com"},"message":"Slight change to clip commands","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/899a92b3a21a37b0f7127e3aff0f0aad62bda291"},{"sha":"1cf1e3b4767675b778a69dd8217f751924cd4fc3","author":{"name":"Andrew Laing","email":"4ef75a97462d6535a13de83c35c957d957ab5786@gmail.com"},"message":"Fixed error with thresholds\n\nAddition was not performed cleanly and\nthresholds increased with time.","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/1cf1e3b4767675b778a69dd8217f751924cd4fc3"},{"sha":"26109939eebf1d39218cc0bb0ca1dc307eed2f35","author":{"name":"J.J. Gomez-Cadenas","email":"1bf4f83063e74e8995539bdb98cbe05aab5a9be2@gmail.com"},"message":"516 Add padding around above threshold SiPM samples\n\nhttps://github.com/nextic/IC/pull/516\n\n[author: andLaing]\n\nMakes the baseline calculation more reliable and MC more similar to\ndata.\n\nFixes bug noticed in MC runs.\n\nThis didn't leave enough information to calculate the baselines so it\ntended to be overestimated, sometimes by a large amount. The change is\nto take a bit before and after each identified above threshold sample\nwhich is also more similar to what the FPGA does for the SiPMs in zero\nsuppression mode. As a default I've put ±50 samples in the example\nconfigs like the current settings of the Java do for data although the\nthresholds are not identical. This results in larger output files for\nthe same data and slower running (not by much I don't think but I've\nonly checked 5 events)\n\nI ran over a full MC data file of 9200 events and the basic plots look\ngood.\n\n[reviewers: paolafer,  msorel, jjgomezcadenas]\n\npaolafer: andLaing and myself have passed a bunch of events through\ndiomira and irene, and the bug seems solved: the SiPM waveforms looks\nfine (while before they were not). Therefore, from the point of view\nof functionality it seems ok.\n\nmsorel: I want to confirm that i am happy with MC outcome of this\nbranch. By processing some background MCRD events through diomira,\nirene, dorothea, penthesilea with this branch, I see, in short all\ngood. We will keep validating MC with more in-depth studies and\nreportresidual oddities. But this is good enough to be merged, as far\nas I am concerned.\n\njjgomezcadenas: Extensively tested first by paolafer then by msorel,\nwith consistent results.","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/26109939eebf1d39218cc0bb0ca1dc307eed2f35"},{"sha":"634dd27569e40c320b355ba1fee252d2a30996da","author":{"name":"Michel Sorel","email":"4f3e4fb6e54a2d5714b836aac5d9db8b4a9d576a@fnal.gov"},"message":"fix copy of MC extents dataset for the case where filtered out events exist, and event numbers are not necessarily in increasing order","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/634dd27569e40c320b355ba1fee252d2a30996da"},{"sha":"b8f9ad0e95155f28d9f456bb4dec5d36d672b12f","author":{"name":"Michel Sorel","email":"4f3e4fb6e54a2d5714b836aac5d9db8b4a9d576a@fnal.gov"},"message":"fix bug with copy of MC generator information: when an event is filtered out, the row being copied is not the last one","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/b8f9ad0e95155f28d9f456bb4dec5d36d672b12f"},{"sha":"fd3c93a9c132726b42dd563e5cc02e68b8480c68","author":{"name":"Michel Sorel","email":"4f3e4fb6e54a2d5714b836aac5d9db8b4a9d576a@fnal.gov"},"message":"expand the test to check the copy of mc info for non consecutive events. the expansion covers the case where event numbers in the file are not ordered in ascending order. This is the case for background MC files, typically","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/fd3c93a9c132726b42dd563e5cc02e68b8480c68"},{"sha":"98a86884baa4b3e51b16861519c10fb4a57192a2","author":{"name":"Michel Sorel","email":"4f3e4fb6e54a2d5714b836aac5d9db8b4a9d576a@fnal.gov"},"message":"add test_mc_info_writer_generatoroutput_non_consecutive_events","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/98a86884baa4b3e51b16861519c10fb4a57192a2"},{"sha":"9c0bea7e776d316d4dc80618f94378f181fce244","author":{"name":"Michel Sorel","email":"4f3e4fb6e54a2d5714b836aac5d9db8b4a9d576a@fnal.gov"},"message":"change test_mc_info_writer_generatoroutput_non_consecutive_events so that it actually fails with current mcinfo_io.py code in nextic:master, while it passes for mcinfo_io.py in msorel:improve-mc-copy","distinct":true,"url":"https://api.github.com/repos/msorel/IC/commits/9c0bea7e776d316d4dc80618f94378f181fce244"}]}
{"actor":{"display_login":"msorel"}}