{"action":"closed","number":302,"pull_request":{"url":"https://api.github.com/repos/leanprover/mathlib/pulls/302","id":212467776,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNDY3Nzc2","html_url":"https://github.com/leanprover/mathlib/pull/302","diff_url":"https://github.com/leanprover/mathlib/pull/302.diff","patch_url":"https://github.com/leanprover/mathlib/pull/302.patch","issue_url":"https://api.github.com/repos/leanprover/mathlib/issues/302","number":302,"state":"closed","locked":false,"title":"feat(data/polynomial): has_repr for polynomials","user":{"login":"dorhinj","id":33847686,"node_id":"MDQ6VXNlcjMzODQ3Njg2","avatar_url":"https://avatars3.githubusercontent.com/u/33847686?v=4","gravatar_id":"","url":"https://api.github.com/users/dorhinj","html_url":"https://github.com/dorhinj","followers_url":"https://api.github.com/users/dorhinj/followers","following_url":"https://api.github.com/users/dorhinj/following{/other_user}","gists_url":"https://api.github.com/users/dorhinj/gists{/gist_id}","starred_url":"https://api.github.com/users/dorhinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dorhinj/subscriptions","organizations_url":"https://api.github.com/users/dorhinj/orgs","repos_url":"https://api.github.com/users/dorhinj/repos","events_url":"https://api.github.com/users/dorhinj/events{/privacy}","received_events_url":"https://api.github.com/users/dorhinj/received_events","type":"User","site_admin":false},"body":"Not sure if I should change this so that it will always return a string that will not cause any problems if copied and pasted into a lemma. It does this for rationals and integers, although for rationals, it returns something equal to the polynomial you would like, but probably not the polynomial you actually want, i.e. `(2 / 3 : polynomial ℚ)` more or less gives you `(C 2 / C 3)`, rather than `C (2 / 3)`. These expressions are def eq, but not in any reasonable amount of time as soon as the size gets slightly larger.\r\n\r\nTO CONTRIBUTORS:\r\n\r\nMake sure you have:\r\n\r\n * [x] reviewed and applied the coding style: [coding](./docs/style.md), [naming](./docs/naming.md)\r\n * [ ] for tactics:\r\n     * [ ] added or adapted documentation in [tactics.md](./docs/tactics.md)\r\n     * [ ] write an example of use of the new feature in [tactics.lean](./tests/tactics.lean)\r\n  * [x] make sure definitions and lemmas are put in the right files\r\n  * [x] make sure definitions and lemmas are not redundant\r\n\r\nFor reviewers: [code review check list](./docs/code-review.md)\r\n","created_at":"2018-08-31T18:54:23Z","updated_at":"2018-09-02T17:58:42Z","closed_at":"2018-09-02T17:58:42Z","merged_at":"2018-09-02T17:58:42Z","merge_commit_sha":"8c19da7e4ca6f9e0678c582e5db28401e682480d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/leanprover/mathlib/pulls/302/commits","review_comments_url":"https://api.github.com/repos/leanprover/mathlib/pulls/302/comments","review_comment_url":"https://api.github.com/repos/leanprover/mathlib/pulls/comments{/number}","comments_url":"https://api.github.com/repos/leanprover/mathlib/issues/302/comments","statuses_url":"https://api.github.com/repos/leanprover/mathlib/statuses/fbee6fcab48138b87cd42e62c817600e243ae4de","head":{"label":"dorhinj:patch-3","ref":"patch-3","sha":"fbee6fcab48138b87cd42e62c817600e243ae4de","user":{"login":"dorhinj","id":33847686,"node_id":"MDQ6VXNlcjMzODQ3Njg2","avatar_url":"https://avatars3.githubusercontent.com/u/33847686?v=4","gravatar_id":"","url":"https://api.github.com/users/dorhinj","html_url":"https://github.com/dorhinj","followers_url":"https://api.github.com/users/dorhinj/followers","following_url":"https://api.github.com/users/dorhinj/following{/other_user}","gists_url":"https://api.github.com/users/dorhinj/gists{/gist_id}","starred_url":"https://api.github.com/users/dorhinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dorhinj/subscriptions","organizations_url":"https://api.github.com/users/dorhinj/orgs","repos_url":"https://api.github.com/users/dorhinj/repos","events_url":"https://api.github.com/users/dorhinj/events{/privacy}","received_events_url":"https://api.github.com/users/dorhinj/received_events","type":"User","site_admin":false},"repo":{"id":129409993,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk0MDk5OTM=","name":"mathlib","full_name":"dorhinj/mathlib","owner":{"login":"dorhinj","id":33847686,"node_id":"MDQ6VXNlcjMzODQ3Njg2","avatar_url":"https://avatars3.githubusercontent.com/u/33847686?v=4","gravatar_id":"","url":"https://api.github.com/users/dorhinj","html_url":"https://github.com/dorhinj","followers_url":"https://api.github.com/users/dorhinj/followers","following_url":"https://api.github.com/users/dorhinj/following{/other_user}","gists_url":"https://api.github.com/users/dorhinj/gists{/gist_id}","starred_url":"https://api.github.com/users/dorhinj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dorhinj/subscriptions","organizations_url":"https://api.github.com/users/dorhinj/orgs","repos_url":"https://api.github.com/users/dorhinj/repos","events_url":"https://api.github.com/users/dorhinj/events{/privacy}","received_events_url":"https://api.github.com/users/dorhinj/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dorhinj/mathlib","description":"Lean mathematical components library","fork":true,"url":"https://api.github.com/repos/dorhinj/mathlib","forks_url":"https://api.github.com/repos/dorhinj/mathlib/forks","keys_url":"https://api.github.com/repos/dorhinj/mathlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dorhinj/mathlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dorhinj/mathlib/teams","hooks_url":"https://api.github.com/repos/dorhinj/mathlib/hooks","issue_events_url":"https://api.github.com/repos/dorhinj/mathlib/issues/events{/number}","events_url":"https://api.github.com/repos/dorhinj/mathlib/events","assignees_url":"https://api.github.com/repos/dorhinj/mathlib/assignees{/user}","branches_url":"https://api.github.com/repos/dorhinj/mathlib/branches{/branch}","tags_url":"https://api.github.com/repos/dorhinj/mathlib/tags","blobs_url":"https://api.github.com/repos/dorhinj/mathlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dorhinj/mathlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dorhinj/mathlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/dorhinj/mathlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dorhinj/mathlib/statuses/{sha}","languages_url":"https://api.github.com/repos/dorhinj/mathlib/languages","stargazers_url":"https://api.github.com/repos/dorhinj/mathlib/stargazers","contributors_url":"https://api.github.com/repos/dorhinj/mathlib/contributors","subscribers_url":"https://api.github.com/repos/dorhinj/mathlib/subscribers","subscription_url":"https://api.github.com/repos/dorhinj/mathlib/subscription","commits_url":"https://api.github.com/repos/dorhinj/mathlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/dorhinj/mathlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/dorhinj/mathlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/dorhinj/mathlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/dorhinj/mathlib/contents/{+path}","compare_url":"https://api.github.com/repos/dorhinj/mathlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dorhinj/mathlib/merges","archive_url":"https://api.github.com/repos/dorhinj/mathlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dorhinj/mathlib/downloads","issues_url":"https://api.github.com/repos/dorhinj/mathlib/issues{/number}","pulls_url":"https://api.github.com/repos/dorhinj/mathlib/pulls{/number}","milestones_url":"https://api.github.com/repos/dorhinj/mathlib/milestones{/number}","notifications_url":"https://api.github.com/repos/dorhinj/mathlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dorhinj/mathlib/labels{/name}","releases_url":"https://api.github.com/repos/dorhinj/mathlib/releases{/id}","deployments_url":"https://api.github.com/repos/dorhinj/mathlib/deployments","created_at":"2018-04-13T14:00:59Z","updated_at":"2018-08-28T22:35:19Z","pushed_at":"2018-09-02T17:19:29Z","git_url":"git://github.com/dorhinj/mathlib.git","ssh_url":"git@github.com:dorhinj/mathlib.git","clone_url":"https://github.com/dorhinj/mathlib.git","svn_url":"https://github.com/dorhinj/mathlib","homepage":"","size":4205,"stargazers_count":0,"watchers_count":0,"language":"Lean","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"leanprover:master","ref":"master","sha":"20b4143976dad48e664c4847b75a85237dca0a89","user":{"login":"leanprover","id":7233018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMzMwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7233018?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover","html_url":"https://github.com/leanprover","followers_url":"https://api.github.com/users/leanprover/followers","following_url":"https://api.github.com/users/leanprover/following{/other_user}","gists_url":"https://api.github.com/users/leanprover/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover/subscriptions","organizations_url":"https://api.github.com/users/leanprover/orgs","repos_url":"https://api.github.com/users/leanprover/repos","events_url":"https://api.github.com/users/leanprover/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover/received_events","type":"Organization","site_admin":false},"repo":{"id":97922418,"node_id":"MDEwOlJlcG9zaXRvcnk5NzkyMjQxOA==","name":"mathlib","full_name":"leanprover/mathlib","owner":{"login":"leanprover","id":7233018,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcyMzMwMTg=","avatar_url":"https://avatars3.githubusercontent.com/u/7233018?v=4","gravatar_id":"","url":"https://api.github.com/users/leanprover","html_url":"https://github.com/leanprover","followers_url":"https://api.github.com/users/leanprover/followers","following_url":"https://api.github.com/users/leanprover/following{/other_user}","gists_url":"https://api.github.com/users/leanprover/gists{/gist_id}","starred_url":"https://api.github.com/users/leanprover/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leanprover/subscriptions","organizations_url":"https://api.github.com/users/leanprover/orgs","repos_url":"https://api.github.com/users/leanprover/repos","events_url":"https://api.github.com/users/leanprover/events{/privacy}","received_events_url":"https://api.github.com/users/leanprover/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/leanprover/mathlib","description":"Lean mathematical components library","fork":false,"url":"https://api.github.com/repos/leanprover/mathlib","forks_url":"https://api.github.com/repos/leanprover/mathlib/forks","keys_url":"https://api.github.com/repos/leanprover/mathlib/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leanprover/mathlib/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leanprover/mathlib/teams","hooks_url":"https://api.github.com/repos/leanprover/mathlib/hooks","issue_events_url":"https://api.github.com/repos/leanprover/mathlib/issues/events{/number}","events_url":"https://api.github.com/repos/leanprover/mathlib/events","assignees_url":"https://api.github.com/repos/leanprover/mathlib/assignees{/user}","branches_url":"https://api.github.com/repos/leanprover/mathlib/branches{/branch}","tags_url":"https://api.github.com/repos/leanprover/mathlib/tags","blobs_url":"https://api.github.com/repos/leanprover/mathlib/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leanprover/mathlib/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leanprover/mathlib/git/refs{/sha}","trees_url":"https://api.github.com/repos/leanprover/mathlib/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leanprover/mathlib/statuses/{sha}","languages_url":"https://api.github.com/repos/leanprover/mathlib/languages","stargazers_url":"https://api.github.com/repos/leanprover/mathlib/stargazers","contributors_url":"https://api.github.com/repos/leanprover/mathlib/contributors","subscribers_url":"https://api.github.com/repos/leanprover/mathlib/subscribers","subscription_url":"https://api.github.com/repos/leanprover/mathlib/subscription","commits_url":"https://api.github.com/repos/leanprover/mathlib/commits{/sha}","git_commits_url":"https://api.github.com/repos/leanprover/mathlib/git/commits{/sha}","comments_url":"https://api.github.com/repos/leanprover/mathlib/comments{/number}","issue_comment_url":"https://api.github.com/repos/leanprover/mathlib/issues/comments{/number}","contents_url":"https://api.github.com/repos/leanprover/mathlib/contents/{+path}","compare_url":"https://api.github.com/repos/leanprover/mathlib/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leanprover/mathlib/merges","archive_url":"https://api.github.com/repos/leanprover/mathlib/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leanprover/mathlib/downloads","issues_url":"https://api.github.com/repos/leanprover/mathlib/issues{/number}","pulls_url":"https://api.github.com/repos/leanprover/mathlib/pulls{/number}","milestones_url":"https://api.github.com/repos/leanprover/mathlib/milestones{/number}","notifications_url":"https://api.github.com/repos/leanprover/mathlib/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leanprover/mathlib/labels{/name}","releases_url":"https://api.github.com/repos/leanprover/mathlib/releases{/id}","deployments_url":"https://api.github.com/repos/leanprover/mathlib/deployments","created_at":"2017-07-21T08:02:10Z","updated_at":"2018-09-02T17:54:27Z","pushed_at":"2018-09-02T17:58:42Z","git_url":"git://github.com/leanprover/mathlib.git","ssh_url":"git@github.com:leanprover/mathlib.git","clone_url":"https://github.com/leanprover/mathlib.git","svn_url":"https://github.com/leanprover/mathlib","homepage":"","size":4081,"stargazers_count":53,"watchers_count":53,"language":"Lean","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":32,"open_issues":21,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/302"},"html":{"href":"https://github.com/leanprover/mathlib/pull/302"},"issue":{"href":"https://api.github.com/repos/leanprover/mathlib/issues/302"},"comments":{"href":"https://api.github.com/repos/leanprover/mathlib/issues/302/comments"},"review_comments":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/302/comments"},"review_comment":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/leanprover/mathlib/pulls/302/commits"},"statuses":{"href":"https://api.github.com/repos/leanprover/mathlib/statuses/fbee6fcab48138b87cd42e62c817600e243ae4de"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"johoelzl","id":5176109,"node_id":"MDQ6VXNlcjUxNzYxMDk=","avatar_url":"https://avatars0.githubusercontent.com/u/5176109?v=4","gravatar_id":"","url":"https://api.github.com/users/johoelzl","html_url":"https://github.com/johoelzl","followers_url":"https://api.github.com/users/johoelzl/followers","following_url":"https://api.github.com/users/johoelzl/following{/other_user}","gists_url":"https://api.github.com/users/johoelzl/gists{/gist_id}","starred_url":"https://api.github.com/users/johoelzl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johoelzl/subscriptions","organizations_url":"https://api.github.com/users/johoelzl/orgs","repos_url":"https://api.github.com/users/johoelzl/repos","events_url":"https://api.github.com/users/johoelzl/events{/privacy}","received_events_url":"https://api.github.com/users/johoelzl/received_events","type":"User","site_admin":false},"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":11,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"johoelzl"}}