{"action":"created","issue":{"url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/746","repository_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet","labels_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/746/labels{/name}","comments_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/746/comments","events_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/746/events","html_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/746","id":391005115,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NjM5NDcy","number":746,"title":"refactor: wallet transactions & delegate table sorting","user":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-12-14T08:03:53Z","updated_at":"2018-12-14T10:42:35Z","closed_at":"2018-12-14T10:42:35Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/pulls/746","html_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/746","diff_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/746.diff","patch_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/746.patch"},"body":"## Proposed changes\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n-->\r\n\r\nImho sorting should not trigger a potential change of the dataset, but only manipulate the order of the data already present. The current implementation fetches the delegates in the `onSortChange` method.\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/guidebook/contribution-guidelines/contributing.html) documentation\r\n- [x] Lint and unit tests pass locally with my changes"},"comment":{"url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/comments/447287018","html_url":"https://github.com/ArkEcosystem/desktop-wallet/pull/746#issuecomment-447287018","issue_url":"https://api.github.com/repos/ArkEcosystem/desktop-wallet/issues/746","id":447287018,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzI4NzAxOA==","user":{"login":"alexbarnsley","id":8069294,"node_id":"MDQ6VXNlcjgwNjkyOTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/8069294?v=4","gravatar_id":"","url":"https://api.github.com/users/alexbarnsley","html_url":"https://github.com/alexbarnsley","followers_url":"https://api.github.com/users/alexbarnsley/followers","following_url":"https://api.github.com/users/alexbarnsley/following{/other_user}","gists_url":"https://api.github.com/users/alexbarnsley/gists{/gist_id}","starred_url":"https://api.github.com/users/alexbarnsley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexbarnsley/subscriptions","organizations_url":"https://api.github.com/users/alexbarnsley/orgs","repos_url":"https://api.github.com/users/alexbarnsley/repos","events_url":"https://api.github.com/users/alexbarnsley/events{/privacy}","received_events_url":"https://api.github.com/users/alexbarnsley/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T10:42:35Z","updated_at":"2018-12-14T10:42:35Z","author_association":"MEMBER","body":"There a few issues with this:\r\n\r\n1 - Going to page 2 and sorting resets the page to 1, but shows page 2's sorted data\r\n2 - If i sort date ascending on page one it sorts locally. When i then go to page 2, it shows page 2 of my very early transactions, because sorting is also done on the API\r\n3 - Assuming you removed the API sorting, your change means I may never be able to see my very first transactions if I have a lot\r\n\r\nI agree with @j-a-m-l that this should be done remotely, as I would expect to see my first transaction on page 1 if i sorted locally."}}
{"actor":{"display_login":"alexbarnsley"}}