{"action":"closed","issue":{"url":"https://api.github.com/repos/gap-system/gap/issues/1089","repository_url":"https://api.github.com/repos/gap-system/gap","labels_url":"https://api.github.com/repos/gap-system/gap/issues/1089/labels{/name}","comments_url":"https://api.github.com/repos/gap-system/gap/issues/1089/comments","events_url":"https://api.github.com/repos/gap-system/gap/issues/1089/events","html_url":"https://github.com/gap-system/gap/issues/1089","id":201527970,"node_id":"MDU6SXNzdWUyMDE1Mjc5NzA=","number":1089,"title":"Tighten up rules on loading workspaces","user":{"login":"ChrisJefferson","id":811527,"node_id":"MDQ6VXNlcjgxMTUyNw==","avatar_url":"https://avatars2.githubusercontent.com/u/811527?v=4","gravatar_id":"","url":"https://api.github.com/users/ChrisJefferson","html_url":"https://github.com/ChrisJefferson","followers_url":"https://api.github.com/users/ChrisJefferson/followers","following_url":"https://api.github.com/users/ChrisJefferson/following{/other_user}","gists_url":"https://api.github.com/users/ChrisJefferson/gists{/gist_id}","starred_url":"https://api.github.com/users/ChrisJefferson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ChrisJefferson/subscriptions","organizations_url":"https://api.github.com/users/ChrisJefferson/orgs","repos_url":"https://api.github.com/users/ChrisJefferson/repos","events_url":"https://api.github.com/users/ChrisJefferson/events{/privacy}","received_events_url":"https://api.github.com/users/ChrisJefferson/received_events","type":"User","site_admin":false},"labels":[{"id":180442296,"node_id":"MDU6TGFiZWwxODA0NDIyOTY=","url":"https://api.github.com/repos/gap-system/gap/labels/kind:%20enhancement","name":"kind: enhancement","color":"84b6eb","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-01-18T10:05:03Z","updated_at":"2018-08-29T09:46:01Z","closed_at":"2018-08-29T09:46:01Z","author_association":"CONTRIBUTOR","body":"At the moment GAP checks the kernel version when loading workspaces (so for example 4.4.11 won't load a 4.4.10 workspace). I would like to suggest the following tightening of the rules:\r\n\r\n* Reject if `HAVE_LIBREADLINE` is different\r\n* Reject if `BUILD_VERSION` is different (that is, the git version the kernel was build from)\r\n\r\nOnly the last one I imagine might be controversial, but I think we should do it, as a few times I have found it can produce hard-to-debug errors. We could instead in this last case just produce a warning if people really want to be able to try it.\r\n\r\nEDIT: I wondered about rejecting if `GMP_VERSION` is different, but I don't think that should effect workspaces, and would break workspaces when the OS updates the GMP version.\r\n\r\nThe coding for this is easy, but I wanted to get thoughts before starting.\r\n\r\nWould fix #1079 "}}
{"actor":{"display_login":"fingolfin"}}