{"action":"closed","number":27,"pull_request":{"url":"https://api.github.com/repos/geotopmodel/geotop/pulls/27","id":173164606,"html_url":"https://github.com/geotopmodel/geotop/pull/27","diff_url":"https://github.com/geotopmodel/geotop/pull/27.diff","patch_url":"https://github.com/geotopmodel/geotop/pull/27.patch","issue_url":"https://api.github.com/repos/geotopmodel/geotop/issues/27","number":27,"state":"closed","locked":false,"title":"Some improvements on CMake","user":{"login":"asartori86","id":10710861,"avatar_url":"https://avatars3.githubusercontent.com/u/10710861?v=4","gravatar_id":"","url":"https://api.github.com/users/asartori86","html_url":"https://github.com/asartori86","followers_url":"https://api.github.com/users/asartori86/followers","following_url":"https://api.github.com/users/asartori86/following{/other_user}","gists_url":"https://api.github.com/users/asartori86/gists{/gist_id}","starred_url":"https://api.github.com/users/asartori86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asartori86/subscriptions","organizations_url":"https://api.github.com/users/asartori86/orgs","repos_url":"https://api.github.com/users/asartori86/repos","events_url":"https://api.github.com/users/asartori86/events{/privacy}","received_events_url":"https://api.github.com/users/asartori86/received_events","type":"User","site_admin":false},"body":"The current build system has several issues:\r\n1. once you compile, it changes **a tracked** file, namely `version.h`, leaving your git repo in a dirty state. \r\n2. the directories `bin` and `lib` appear at the top dir of the repo. This is an issue because if you want to test the library with different compile options (and having different build directories) the same executable and libraries are overwritten\r\n3. the runpath was set only for apple environment and not for linux\r\n\r\nThis PR addresses all the above points with the following strategies\r\n1. the file `version.h` is now **untracked** and a new one is generated in a **subfolder** of the build directory\r\n2. the `bin` and `lib` directories are now **subfolders** of the build directory\r\n3. what was done just for apple, it is done also for linux\r\n\r\nI also ask the developers if we can avoid installing all the headers, since `geotop` is an executable, and unless someone links against the libraries, they are useless. \r\n\r\nI would like also to remove the `distclean` custom target since it is more effectively accomplished by the removal of the build directory. \r\n\r\nLet me know what do you think, and please test if it works or I broke something :)","created_at":"2018-03-06T13:55:39Z","updated_at":"2018-03-06T15:44:58Z","closed_at":"2018-03-06T15:44:58Z","merged_at":"2018-03-06T15:44:58Z","merge_commit_sha":"a413e68e4c29adef81555453e5d259130f12edbd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/geotopmodel/geotop/pulls/27/commits","review_comments_url":"https://api.github.com/repos/geotopmodel/geotop/pulls/27/comments","review_comment_url":"https://api.github.com/repos/geotopmodel/geotop/pulls/comments{/number}","comments_url":"https://api.github.com/repos/geotopmodel/geotop/issues/27/comments","statuses_url":"https://api.github.com/repos/geotopmodel/geotop/statuses/a61c5b46b04414e0b97476be5f11aa6f57f255e0","head":{"label":"asartori86:fix_cmake","ref":"fix_cmake","sha":"a61c5b46b04414e0b97476be5f11aa6f57f255e0","user":{"login":"asartori86","id":10710861,"avatar_url":"https://avatars3.githubusercontent.com/u/10710861?v=4","gravatar_id":"","url":"https://api.github.com/users/asartori86","html_url":"https://github.com/asartori86","followers_url":"https://api.github.com/users/asartori86/followers","following_url":"https://api.github.com/users/asartori86/following{/other_user}","gists_url":"https://api.github.com/users/asartori86/gists{/gist_id}","starred_url":"https://api.github.com/users/asartori86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asartori86/subscriptions","organizations_url":"https://api.github.com/users/asartori86/orgs","repos_url":"https://api.github.com/users/asartori86/repos","events_url":"https://api.github.com/users/asartori86/events{/privacy}","received_events_url":"https://api.github.com/users/asartori86/received_events","type":"User","site_admin":false},"repo":{"id":121153155,"name":"geotop","full_name":"asartori86/geotop","owner":{"login":"asartori86","id":10710861,"avatar_url":"https://avatars3.githubusercontent.com/u/10710861?v=4","gravatar_id":"","url":"https://api.github.com/users/asartori86","html_url":"https://github.com/asartori86","followers_url":"https://api.github.com/users/asartori86/followers","following_url":"https://api.github.com/users/asartori86/following{/other_user}","gists_url":"https://api.github.com/users/asartori86/gists{/gist_id}","starred_url":"https://api.github.com/users/asartori86/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/asartori86/subscriptions","organizations_url":"https://api.github.com/users/asartori86/orgs","repos_url":"https://api.github.com/users/asartori86/repos","events_url":"https://api.github.com/users/asartori86/events{/privacy}","received_events_url":"https://api.github.com/users/asartori86/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/asartori86/geotop","description":"GEOtop is a distributed model of the mass and energy balance of the hydrological cycle, which is applicable to simulations in continuum in small catchments. GEOtop deals with the effects of topography on the interaction between energy balance and hydrological cycle with peculiar solutions.","fork":true,"url":"https://api.github.com/repos/asartori86/geotop","forks_url":"https://api.github.com/repos/asartori86/geotop/forks","keys_url":"https://api.github.com/repos/asartori86/geotop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/asartori86/geotop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/asartori86/geotop/teams","hooks_url":"https://api.github.com/repos/asartori86/geotop/hooks","issue_events_url":"https://api.github.com/repos/asartori86/geotop/issues/events{/number}","events_url":"https://api.github.com/repos/asartori86/geotop/events","assignees_url":"https://api.github.com/repos/asartori86/geotop/assignees{/user}","branches_url":"https://api.github.com/repos/asartori86/geotop/branches{/branch}","tags_url":"https://api.github.com/repos/asartori86/geotop/tags","blobs_url":"https://api.github.com/repos/asartori86/geotop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/asartori86/geotop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/asartori86/geotop/git/refs{/sha}","trees_url":"https://api.github.com/repos/asartori86/geotop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/asartori86/geotop/statuses/{sha}","languages_url":"https://api.github.com/repos/asartori86/geotop/languages","stargazers_url":"https://api.github.com/repos/asartori86/geotop/stargazers","contributors_url":"https://api.github.com/repos/asartori86/geotop/contributors","subscribers_url":"https://api.github.com/repos/asartori86/geotop/subscribers","subscription_url":"https://api.github.com/repos/asartori86/geotop/subscription","commits_url":"https://api.github.com/repos/asartori86/geotop/commits{/sha}","git_commits_url":"https://api.github.com/repos/asartori86/geotop/git/commits{/sha}","comments_url":"https://api.github.com/repos/asartori86/geotop/comments{/number}","issue_comment_url":"https://api.github.com/repos/asartori86/geotop/issues/comments{/number}","contents_url":"https://api.github.com/repos/asartori86/geotop/contents/{+path}","compare_url":"https://api.github.com/repos/asartori86/geotop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/asartori86/geotop/merges","archive_url":"https://api.github.com/repos/asartori86/geotop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/asartori86/geotop/downloads","issues_url":"https://api.github.com/repos/asartori86/geotop/issues{/number}","pulls_url":"https://api.github.com/repos/asartori86/geotop/pulls{/number}","milestones_url":"https://api.github.com/repos/asartori86/geotop/milestones{/number}","notifications_url":"https://api.github.com/repos/asartori86/geotop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/asartori86/geotop/labels{/name}","releases_url":"https://api.github.com/repos/asartori86/geotop/releases{/id}","deployments_url":"https://api.github.com/repos/asartori86/geotop/deployments","created_at":"2018-02-11T18:22:55Z","updated_at":"2018-02-11T18:23:33Z","pushed_at":"2018-03-06T14:55:10Z","git_url":"git://github.com/asartori86/geotop.git","ssh_url":"git@github.com:asartori86/geotop.git","clone_url":"https://github.com/asartori86/geotop.git","svn_url":"https://github.com/asartori86/geotop","homepage":"","size":239708,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"geotopmodel:master","ref":"master","sha":"bed4ca8bc85f4b708601832e0d5fd70506184611","user":{"login":"geotopmodel","id":13872384,"avatar_url":"https://avatars2.githubusercontent.com/u/13872384?v=4","gravatar_id":"","url":"https://api.github.com/users/geotopmodel","html_url":"https://github.com/geotopmodel","followers_url":"https://api.github.com/users/geotopmodel/followers","following_url":"https://api.github.com/users/geotopmodel/following{/other_user}","gists_url":"https://api.github.com/users/geotopmodel/gists{/gist_id}","starred_url":"https://api.github.com/users/geotopmodel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotopmodel/subscriptions","organizations_url":"https://api.github.com/users/geotopmodel/orgs","repos_url":"https://api.github.com/users/geotopmodel/repos","events_url":"https://api.github.com/users/geotopmodel/events{/privacy}","received_events_url":"https://api.github.com/users/geotopmodel/received_events","type":"Organization","site_admin":false},"repo":{"id":24495842,"name":"geotop","full_name":"geotopmodel/geotop","owner":{"login":"geotopmodel","id":13872384,"avatar_url":"https://avatars2.githubusercontent.com/u/13872384?v=4","gravatar_id":"","url":"https://api.github.com/users/geotopmodel","html_url":"https://github.com/geotopmodel","followers_url":"https://api.github.com/users/geotopmodel/followers","following_url":"https://api.github.com/users/geotopmodel/following{/other_user}","gists_url":"https://api.github.com/users/geotopmodel/gists{/gist_id}","starred_url":"https://api.github.com/users/geotopmodel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/geotopmodel/subscriptions","organizations_url":"https://api.github.com/users/geotopmodel/orgs","repos_url":"https://api.github.com/users/geotopmodel/repos","events_url":"https://api.github.com/users/geotopmodel/events{/privacy}","received_events_url":"https://api.github.com/users/geotopmodel/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/geotopmodel/geotop","description":"GEOtop is a distributed model of the mass and energy balance of the hydrological cycle, which is applicable to simulations in continuum in small catchments. GEOtop deals with the effects of topography on the interaction between energy balance and hydrological cycle with peculiar solutions.","fork":false,"url":"https://api.github.com/repos/geotopmodel/geotop","forks_url":"https://api.github.com/repos/geotopmodel/geotop/forks","keys_url":"https://api.github.com/repos/geotopmodel/geotop/keys{/key_id}","collaborators_url":"https://api.github.com/repos/geotopmodel/geotop/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/geotopmodel/geotop/teams","hooks_url":"https://api.github.com/repos/geotopmodel/geotop/hooks","issue_events_url":"https://api.github.com/repos/geotopmodel/geotop/issues/events{/number}","events_url":"https://api.github.com/repos/geotopmodel/geotop/events","assignees_url":"https://api.github.com/repos/geotopmodel/geotop/assignees{/user}","branches_url":"https://api.github.com/repos/geotopmodel/geotop/branches{/branch}","tags_url":"https://api.github.com/repos/geotopmodel/geotop/tags","blobs_url":"https://api.github.com/repos/geotopmodel/geotop/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/geotopmodel/geotop/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/geotopmodel/geotop/git/refs{/sha}","trees_url":"https://api.github.com/repos/geotopmodel/geotop/git/trees{/sha}","statuses_url":"https://api.github.com/repos/geotopmodel/geotop/statuses/{sha}","languages_url":"https://api.github.com/repos/geotopmodel/geotop/languages","stargazers_url":"https://api.github.com/repos/geotopmodel/geotop/stargazers","contributors_url":"https://api.github.com/repos/geotopmodel/geotop/contributors","subscribers_url":"https://api.github.com/repos/geotopmodel/geotop/subscribers","subscription_url":"https://api.github.com/repos/geotopmodel/geotop/subscription","commits_url":"https://api.github.com/repos/geotopmodel/geotop/commits{/sha}","git_commits_url":"https://api.github.com/repos/geotopmodel/geotop/git/commits{/sha}","comments_url":"https://api.github.com/repos/geotopmodel/geotop/comments{/number}","issue_comment_url":"https://api.github.com/repos/geotopmodel/geotop/issues/comments{/number}","contents_url":"https://api.github.com/repos/geotopmodel/geotop/contents/{+path}","compare_url":"https://api.github.com/repos/geotopmodel/geotop/compare/{base}...{head}","merges_url":"https://api.github.com/repos/geotopmodel/geotop/merges","archive_url":"https://api.github.com/repos/geotopmodel/geotop/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/geotopmodel/geotop/downloads","issues_url":"https://api.github.com/repos/geotopmodel/geotop/issues{/number}","pulls_url":"https://api.github.com/repos/geotopmodel/geotop/pulls{/number}","milestones_url":"https://api.github.com/repos/geotopmodel/geotop/milestones{/number}","notifications_url":"https://api.github.com/repos/geotopmodel/geotop/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/geotopmodel/geotop/labels{/name}","releases_url":"https://api.github.com/repos/geotopmodel/geotop/releases{/id}","deployments_url":"https://api.github.com/repos/geotopmodel/geotop/deployments","created_at":"2014-09-26T10:36:39Z","updated_at":"2018-01-29T17:17:29Z","pushed_at":"2018-03-06T15:44:58Z","git_url":"git://github.com/geotopmodel/geotop.git","ssh_url":"git@github.com:geotopmodel/geotop.git","clone_url":"https://github.com/geotopmodel/geotop.git","svn_url":"https://github.com/geotopmodel/geotop","homepage":"","size":239698,"stargazers_count":11,"watchers_count":11,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":12,"open_issues":4,"watchers":11,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/geotopmodel/geotop/pulls/27"},"html":{"href":"https://github.com/geotopmodel/geotop/pull/27"},"issue":{"href":"https://api.github.com/repos/geotopmodel/geotop/issues/27"},"comments":{"href":"https://api.github.com/repos/geotopmodel/geotop/issues/27/comments"},"review_comments":{"href":"https://api.github.com/repos/geotopmodel/geotop/pulls/27/comments"},"review_comment":{"href":"https://api.github.com/repos/geotopmodel/geotop/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/geotopmodel/geotop/pulls/27/commits"},"statuses":{"href":"https://api.github.com/repos/geotopmodel/geotop/statuses/a61c5b46b04414e0b97476be5f11aa6f57f255e0"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"cozzini","id":3002111,"avatar_url":"https://avatars2.githubusercontent.com/u/3002111?v=4","gravatar_id":"","url":"https://api.github.com/users/cozzini","html_url":"https://github.com/cozzini","followers_url":"https://api.github.com/users/cozzini/followers","following_url":"https://api.github.com/users/cozzini/following{/other_user}","gists_url":"https://api.github.com/users/cozzini/gists{/gist_id}","starred_url":"https://api.github.com/users/cozzini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cozzini/subscriptions","organizations_url":"https://api.github.com/users/cozzini/orgs","repos_url":"https://api.github.com/users/cozzini/repos","events_url":"https://api.github.com/users/cozzini/events{/privacy}","received_events_url":"https://api.github.com/users/cozzini/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":8,"additions":86,"deletions":120,"changed_files":8}}
{"actor":{"display_login":"cozzini"}}