{"action":"closed","number":2969,"pull_request":{"url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2969","id":195226026,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MjI2MDI2","html_url":"https://github.com/jwplayer/jwplayer/pull/2969","diff_url":"https://github.com/jwplayer/jwplayer/pull/2969.diff","patch_url":"https://github.com/jwplayer/jwplayer/pull/2969.patch","issue_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2969","number":2969,"state":"closed","locked":false,"title":"Lazy instantiate video blob and guard against URL being overwritten","user":{"login":"robwalch","id":333258,"node_id":"MDQ6VXNlcjMzMzI1OA==","avatar_url":"https://avatars1.githubusercontent.com/u/333258?v=4","gravatar_id":"","url":"https://api.github.com/users/robwalch","html_url":"https://github.com/robwalch","followers_url":"https://api.github.com/users/robwalch/followers","following_url":"https://api.github.com/users/robwalch/following{/other_user}","gists_url":"https://api.github.com/users/robwalch/gists{/gist_id}","starred_url":"https://api.github.com/users/robwalch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robwalch/subscriptions","organizations_url":"https://api.github.com/users/robwalch/orgs","repos_url":"https://api.github.com/users/robwalch/repos","events_url":"https://api.github.com/users/robwalch/events{/privacy}","received_events_url":"https://api.github.com/users/robwalch/received_events","type":"User","site_admin":false},"body":"### This PR will...\r\n\r\n- Lazy instantiat video blob\r\n- Guard against URL being overwritten\r\n\r\n### Why is this Pull Request needed?\r\n\r\nWe've found setup errors caused by sites overwritting the `URL` global. This results in a TypeError that fails setup with code `100000` on Android where we perform a video play test before preloading.\r\n\r\n```js\r\nJW Player Error 100000. For more information see https://developer.jwplayer.com/jw-player/docs/developer-guide/api/errors-reference#100000\r\n\r\nTypeError: URL.createObjectURL is not a function\r\nat Je (https://ssl.p.jwpcdn.com/player/v/8.4.0-beta.2/jwplayer.core.controls.html5.js:10:63924)\r\n```\r\n\r\n`URL` is critical to this test and to MSE usage in hls.js and shaka. Catching it here won't help video playback, but it prevents setup from failing. mp4s will play fine, and DASH and HLS engines should surface the issue.\r\n\r\n#### Addresses Issue(s):\r\n\r\nJW8-1363\r\n\r\n","created_at":"2018-06-15T16:29:59Z","updated_at":"2018-06-15T19:22:44Z","closed_at":"2018-06-15T19:22:44Z","merged_at":"2018-06-15T19:22:44Z","merge_commit_sha":"9772870f4dd242cf95ccf1a88c4d26ded70b43d7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"johnBartos","id":5042276,"node_id":"MDQ6VXNlcjUwNDIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},{"login":"dannyfinks","id":9535273,"node_id":"MDQ6VXNlcjk1MzUyNzM=","avatar_url":"https://avatars2.githubusercontent.com/u/9535273?v=4","gravatar_id":"","url":"https://api.github.com/users/dannyfinks","html_url":"https://github.com/dannyfinks","followers_url":"https://api.github.com/users/dannyfinks/followers","following_url":"https://api.github.com/users/dannyfinks/following{/other_user}","gists_url":"https://api.github.com/users/dannyfinks/gists{/gist_id}","starred_url":"https://api.github.com/users/dannyfinks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannyfinks/subscriptions","organizations_url":"https://api.github.com/users/dannyfinks/orgs","repos_url":"https://api.github.com/users/dannyfinks/repos","events_url":"https://api.github.com/users/dannyfinks/events{/privacy}","received_events_url":"https://api.github.com/users/dannyfinks/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/92","html_url":"https://github.com/jwplayer/jwplayer/milestone/92","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones/92/labels","id":3291183,"node_id":"MDk6TWlsZXN0b25lMzI5MTE4Mw==","number":92,"title":"v8.4.0","description":"","creator":{"login":"johnBartos","id":5042276,"node_id":"MDQ6VXNlcjUwNDIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":49,"state":"open","created_at":"2018-04-23T22:20:21Z","updated_at":"2018-06-15T19:22:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2969/commits","review_comments_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2969/comments","review_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/2969/comments","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/ebda078671b7c8d1e29ea53059163dad299f88b4","head":{"label":"jwplayer:feature/handle-overwritten-url","ref":"feature/handle-overwritten-url","sha":"ebda078671b7c8d1e29ea53059163dad299f88b4","user":{"login":"jwplayer","id":5090060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTAwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"node_id":"MDEwOlJlcG9zaXRvcnkxODMwNzE3NQ==","name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTAwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2018-06-15T17:58:52Z","pushed_at":"2018-06-15T19:22:44Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":86060,"stargazers_count":1646,"watchers_count":1646,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":732,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":732,"open_issues":83,"watchers":1646,"default_branch":"master"}},"base":{"label":"jwplayer:master","ref":"master","sha":"ac69aed9a6f17baa82438d3c04c413699af419b6","user":{"login":"jwplayer","id":5090060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTAwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"repo":{"id":18307175,"node_id":"MDEwOlJlcG9zaXRvcnkxODMwNzE3NQ==","name":"jwplayer","full_name":"jwplayer/jwplayer","owner":{"login":"jwplayer","id":5090060,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwOTAwNjA=","avatar_url":"https://avatars3.githubusercontent.com/u/5090060?v=4","gravatar_id":"","url":"https://api.github.com/users/jwplayer","html_url":"https://github.com/jwplayer","followers_url":"https://api.github.com/users/jwplayer/followers","following_url":"https://api.github.com/users/jwplayer/following{/other_user}","gists_url":"https://api.github.com/users/jwplayer/gists{/gist_id}","starred_url":"https://api.github.com/users/jwplayer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwplayer/subscriptions","organizations_url":"https://api.github.com/users/jwplayer/orgs","repos_url":"https://api.github.com/users/jwplayer/repos","events_url":"https://api.github.com/users/jwplayer/events{/privacy}","received_events_url":"https://api.github.com/users/jwplayer/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jwplayer/jwplayer","description":"JW Player is the world's most popular embeddable media player.","fork":false,"url":"https://api.github.com/repos/jwplayer/jwplayer","forks_url":"https://api.github.com/repos/jwplayer/jwplayer/forks","keys_url":"https://api.github.com/repos/jwplayer/jwplayer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jwplayer/jwplayer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jwplayer/jwplayer/teams","hooks_url":"https://api.github.com/repos/jwplayer/jwplayer/hooks","issue_events_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/events{/number}","events_url":"https://api.github.com/repos/jwplayer/jwplayer/events","assignees_url":"https://api.github.com/repos/jwplayer/jwplayer/assignees{/user}","branches_url":"https://api.github.com/repos/jwplayer/jwplayer/branches{/branch}","tags_url":"https://api.github.com/repos/jwplayer/jwplayer/tags","blobs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jwplayer/jwplayer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jwplayer/jwplayer/git/refs{/sha}","trees_url":"https://api.github.com/repos/jwplayer/jwplayer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jwplayer/jwplayer/statuses/{sha}","languages_url":"https://api.github.com/repos/jwplayer/jwplayer/languages","stargazers_url":"https://api.github.com/repos/jwplayer/jwplayer/stargazers","contributors_url":"https://api.github.com/repos/jwplayer/jwplayer/contributors","subscribers_url":"https://api.github.com/repos/jwplayer/jwplayer/subscribers","subscription_url":"https://api.github.com/repos/jwplayer/jwplayer/subscription","commits_url":"https://api.github.com/repos/jwplayer/jwplayer/commits{/sha}","git_commits_url":"https://api.github.com/repos/jwplayer/jwplayer/git/commits{/sha}","comments_url":"https://api.github.com/repos/jwplayer/jwplayer/comments{/number}","issue_comment_url":"https://api.github.com/repos/jwplayer/jwplayer/issues/comments{/number}","contents_url":"https://api.github.com/repos/jwplayer/jwplayer/contents/{+path}","compare_url":"https://api.github.com/repos/jwplayer/jwplayer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jwplayer/jwplayer/merges","archive_url":"https://api.github.com/repos/jwplayer/jwplayer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jwplayer/jwplayer/downloads","issues_url":"https://api.github.com/repos/jwplayer/jwplayer/issues{/number}","pulls_url":"https://api.github.com/repos/jwplayer/jwplayer/pulls{/number}","milestones_url":"https://api.github.com/repos/jwplayer/jwplayer/milestones{/number}","notifications_url":"https://api.github.com/repos/jwplayer/jwplayer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jwplayer/jwplayer/labels{/name}","releases_url":"https://api.github.com/repos/jwplayer/jwplayer/releases{/id}","deployments_url":"https://api.github.com/repos/jwplayer/jwplayer/deployments","created_at":"2014-03-31T20:34:20Z","updated_at":"2018-06-15T17:58:52Z","pushed_at":"2018-06-15T19:22:44Z","git_url":"git://github.com/jwplayer/jwplayer.git","ssh_url":"git@github.com:jwplayer/jwplayer.git","clone_url":"https://github.com/jwplayer/jwplayer.git","svn_url":"https://github.com/jwplayer/jwplayer","homepage":"https://developer.jwplayer.com/","size":86060,"stargazers_count":1646,"watchers_count":1646,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":732,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":732,"open_issues":83,"watchers":1646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2969"},"html":{"href":"https://github.com/jwplayer/jwplayer/pull/2969"},"issue":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2969"},"comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/issues/2969/comments"},"review_comments":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2969/comments"},"review_comment":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jwplayer/jwplayer/pulls/2969/commits"},"statuses":{"href":"https://api.github.com/repos/jwplayer/jwplayer/statuses/ebda078671b7c8d1e29ea53059163dad299f88b4"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"johnBartos","id":5042276,"node_id":"MDQ6VXNlcjUwNDIyNzY=","avatar_url":"https://avatars1.githubusercontent.com/u/5042276?v=4","gravatar_id":"","url":"https://api.github.com/users/johnBartos","html_url":"https://github.com/johnBartos","followers_url":"https://api.github.com/users/johnBartos/followers","following_url":"https://api.github.com/users/johnBartos/following{/other_user}","gists_url":"https://api.github.com/users/johnBartos/gists{/gist_id}","starred_url":"https://api.github.com/users/johnBartos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/johnBartos/subscriptions","organizations_url":"https://api.github.com/users/johnBartos/orgs","repos_url":"https://api.github.com/users/johnBartos/repos","events_url":"https://api.github.com/users/johnBartos/events{/privacy}","received_events_url":"https://api.github.com/users/johnBartos/received_events","type":"User","site_admin":false},"comments":3,"review_comments":3,"maintainer_can_modify":false,"commits":2,"additions":19,"deletions":11,"changed_files":2}}
{"actor":{"display_login":"johnBartos"}}