{"action":"created","comment":{"url":"https://api.github.com/repos/atom/apm/pulls/comments/202685884","pull_request_review_id":137430070,"id":202685884,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMjY4NTg4NA==","diff_hunk":"@@ -386,7 +425,10 @@ class Install extends Command\n     for name, version of @getPackageDependencies()\n       do (name, version) =>\n         commands.push (next) =>\n-          @installRegisteredPackage({name, version}, options, next)\n+          if version.indexOf('file:.') is 0","path":"src/install.coffee","position":51,"original_position":51,"commit_id":"1f3284f2182a04f618ecb04c191dbf8527d1a7a3","original_commit_id":"1f3284f2182a04f618ecb04c191dbf8527d1a7a3","user":{"login":"daviwil","id":79405,"node_id":"MDQ6VXNlcjc5NDA1","avatar_url":"https://avatars3.githubusercontent.com/u/79405?v=4","gravatar_id":"","url":"https://api.github.com/users/daviwil","html_url":"https://github.com/daviwil","followers_url":"https://api.github.com/users/daviwil/followers","following_url":"https://api.github.com/users/daviwil/following{/other_user}","gists_url":"https://api.github.com/users/daviwil/gists{/gist_id}","starred_url":"https://api.github.com/users/daviwil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviwil/subscriptions","organizations_url":"https://api.github.com/users/daviwil/orgs","repos_url":"https://api.github.com/users/daviwil/repos","events_url":"https://api.github.com/users/daviwil/events{/privacy}","received_events_url":"https://api.github.com/users/daviwil/received_events","type":"User","site_admin":true},"body":"Thanks!  I think my brain goes sideways when I start looking at Coffeescript","created_at":"2018-07-16T13:41:34Z","updated_at":"2018-07-16T13:41:34Z","html_url":"https://github.com/atom/apm/pull/797#discussion_r202685884","pull_request_url":"https://api.github.com/repos/atom/apm/pulls/797","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/atom/apm/pulls/comments/202685884"},"html":{"href":"https://github.com/atom/apm/pull/797#discussion_r202685884"},"pull_request":{"href":"https://api.github.com/repos/atom/apm/pulls/797"}},"in_reply_to_id":202565862},"pull_request":{"url":"https://api.github.com/repos/atom/apm/pulls/797","id":201416038,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDE2MDM4","html_url":"https://github.com/atom/apm/pull/797","diff_url":"https://github.com/atom/apm/pull/797.diff","patch_url":"https://github.com/atom/apm/pull/797.patch","issue_url":"https://api.github.com/repos/atom/apm/issues/797","number":797,"state":"open","locked":false,"title":"WIP: Add support for repo-local packageDependencies in Atom's package.json","user":{"login":"daviwil","id":79405,"node_id":"MDQ6VXNlcjc5NDA1","avatar_url":"https://avatars3.githubusercontent.com/u/79405?v=4","gravatar_id":"","url":"https://api.github.com/users/daviwil","html_url":"https://github.com/daviwil","followers_url":"https://api.github.com/users/daviwil/followers","following_url":"https://api.github.com/users/daviwil/following{/other_user}","gists_url":"https://api.github.com/users/daviwil/gists{/gist_id}","starred_url":"https://api.github.com/users/daviwil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daviwil/subscriptions","organizations_url":"https://api.github.com/users/daviwil/orgs","repos_url":"https://api.github.com/users/daviwil/repos","events_url":"https://api.github.com/users/daviwil/events{/privacy}","received_events_url":"https://api.github.com/users/daviwil/received_events","type":"User","site_admin":true},"body":"### Description of the Change\r\n\r\nThis change adds support for npm's `file:` syntax for `packageDependencies` in Atom's `package.json` file.  When a package dependency uses such a string with a relative path, we use a special code path that knows to pass along that path to npm so that the package can be installed from the local folder into `node_modules`.\r\n\r\n### Alternate Designs\r\n\r\nI don't know of any other way to accomplish this with `apm` currently, but I'd be happy to learn of alternatives!\r\n\r\n### Benefits\r\n\r\nThis allows Atom to easily use core packages which live inside a subfolder of Atom's own repository instead of having to ship core packages to apm and then reference them with version numbers in `packageDependencies`.\r\n\r\n### Possible Drawbacks\r\n\r\nCurrently there's no way to determine that a package from a local path and its \"installed\" copy under `node_modules` are the same and don't require another install.  This is mainly due to the fact that we no longer change the version in the package's `package.json` file, so it's hard to know for certain whether the package code has changed between builds.\r\n\r\n### Applicable Issues\r\n\r\n- RFC 003: https://github.com/atom/atom/pull/17674\r\n- PR to Atom that consumes this change: https://github.com/atom/atom/pull/17686\r\n","created_at":"2018-07-13T22:44:56Z","updated_at":"2018-07-16T13:41:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bc603852da10b67076228281056a156503c1b45a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/atom/apm/pulls/797/commits","review_comments_url":"https://api.github.com/repos/atom/apm/pulls/797/comments","review_comment_url":"https://api.github.com/repos/atom/apm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/atom/apm/issues/797/comments","statuses_url":"https://api.github.com/repos/atom/apm/statuses/1f3284f2182a04f618ecb04c191dbf8527d1a7a3","head":{"label":"atom:dw-repo-local-core-packages","ref":"dw-repo-local-core-packages","sha":"1f3284f2182a04f618ecb04c191dbf8527d1a7a3","user":{"login":"atom","id":1089146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODkxNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9916379,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE2Mzc5","name":"apm","full_name":"atom/apm","owner":{"login":"atom","id":1089146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODkxNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/apm","description":"Atom Package Manager","fork":false,"url":"https://api.github.com/repos/atom/apm","forks_url":"https://api.github.com/repos/atom/apm/forks","keys_url":"https://api.github.com/repos/atom/apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/apm/teams","hooks_url":"https://api.github.com/repos/atom/apm/hooks","issue_events_url":"https://api.github.com/repos/atom/apm/issues/events{/number}","events_url":"https://api.github.com/repos/atom/apm/events","assignees_url":"https://api.github.com/repos/atom/apm/assignees{/user}","branches_url":"https://api.github.com/repos/atom/apm/branches{/branch}","tags_url":"https://api.github.com/repos/atom/apm/tags","blobs_url":"https://api.github.com/repos/atom/apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/apm/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/apm/languages","stargazers_url":"https://api.github.com/repos/atom/apm/stargazers","contributors_url":"https://api.github.com/repos/atom/apm/contributors","subscribers_url":"https://api.github.com/repos/atom/apm/subscribers","subscription_url":"https://api.github.com/repos/atom/apm/subscription","commits_url":"https://api.github.com/repos/atom/apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/apm/contents/{+path}","compare_url":"https://api.github.com/repos/atom/apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/apm/merges","archive_url":"https://api.github.com/repos/atom/apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/apm/downloads","issues_url":"https://api.github.com/repos/atom/apm/issues{/number}","pulls_url":"https://api.github.com/repos/atom/apm/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/apm/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/apm/labels{/name}","releases_url":"https://api.github.com/repos/atom/apm/releases{/id}","deployments_url":"https://api.github.com/repos/atom/apm/deployments","created_at":"2013-05-07T16:27:05Z","updated_at":"2018-07-15T01:00:37Z","pushed_at":"2018-07-16T13:07:30Z","git_url":"git://github.com/atom/apm.git","ssh_url":"git@github.com:atom/apm.git","clone_url":"https://github.com/atom/apm.git","svn_url":"https://github.com/atom/apm","homepage":"https://atom.io/packages","size":5708,"stargazers_count":1116,"watchers_count":1116,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":254,"open_issues":171,"watchers":1116,"default_branch":"master"}},"base":{"label":"atom:master","ref":"master","sha":"478f7be389cdb1bf38c6f284d7631cad04e62e91","user":{"login":"atom","id":1089146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODkxNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"repo":{"id":9916379,"node_id":"MDEwOlJlcG9zaXRvcnk5OTE2Mzc5","name":"apm","full_name":"atom/apm","owner":{"login":"atom","id":1089146,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODkxNDY=","avatar_url":"https://avatars2.githubusercontent.com/u/1089146?v=4","gravatar_id":"","url":"https://api.github.com/users/atom","html_url":"https://github.com/atom","followers_url":"https://api.github.com/users/atom/followers","following_url":"https://api.github.com/users/atom/following{/other_user}","gists_url":"https://api.github.com/users/atom/gists{/gist_id}","starred_url":"https://api.github.com/users/atom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/atom/subscriptions","organizations_url":"https://api.github.com/users/atom/orgs","repos_url":"https://api.github.com/users/atom/repos","events_url":"https://api.github.com/users/atom/events{/privacy}","received_events_url":"https://api.github.com/users/atom/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/atom/apm","description":"Atom Package Manager","fork":false,"url":"https://api.github.com/repos/atom/apm","forks_url":"https://api.github.com/repos/atom/apm/forks","keys_url":"https://api.github.com/repos/atom/apm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/atom/apm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/atom/apm/teams","hooks_url":"https://api.github.com/repos/atom/apm/hooks","issue_events_url":"https://api.github.com/repos/atom/apm/issues/events{/number}","events_url":"https://api.github.com/repos/atom/apm/events","assignees_url":"https://api.github.com/repos/atom/apm/assignees{/user}","branches_url":"https://api.github.com/repos/atom/apm/branches{/branch}","tags_url":"https://api.github.com/repos/atom/apm/tags","blobs_url":"https://api.github.com/repos/atom/apm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/atom/apm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/atom/apm/git/refs{/sha}","trees_url":"https://api.github.com/repos/atom/apm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/atom/apm/statuses/{sha}","languages_url":"https://api.github.com/repos/atom/apm/languages","stargazers_url":"https://api.github.com/repos/atom/apm/stargazers","contributors_url":"https://api.github.com/repos/atom/apm/contributors","subscribers_url":"https://api.github.com/repos/atom/apm/subscribers","subscription_url":"https://api.github.com/repos/atom/apm/subscription","commits_url":"https://api.github.com/repos/atom/apm/commits{/sha}","git_commits_url":"https://api.github.com/repos/atom/apm/git/commits{/sha}","comments_url":"https://api.github.com/repos/atom/apm/comments{/number}","issue_comment_url":"https://api.github.com/repos/atom/apm/issues/comments{/number}","contents_url":"https://api.github.com/repos/atom/apm/contents/{+path}","compare_url":"https://api.github.com/repos/atom/apm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/atom/apm/merges","archive_url":"https://api.github.com/repos/atom/apm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/atom/apm/downloads","issues_url":"https://api.github.com/repos/atom/apm/issues{/number}","pulls_url":"https://api.github.com/repos/atom/apm/pulls{/number}","milestones_url":"https://api.github.com/repos/atom/apm/milestones{/number}","notifications_url":"https://api.github.com/repos/atom/apm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/atom/apm/labels{/name}","releases_url":"https://api.github.com/repos/atom/apm/releases{/id}","deployments_url":"https://api.github.com/repos/atom/apm/deployments","created_at":"2013-05-07T16:27:05Z","updated_at":"2018-07-15T01:00:37Z","pushed_at":"2018-07-16T13:07:30Z","git_url":"git://github.com/atom/apm.git","ssh_url":"git@github.com:atom/apm.git","clone_url":"https://github.com/atom/apm.git","svn_url":"https://github.com/atom/apm","homepage":"https://atom.io/packages","size":5708,"stargazers_count":1116,"watchers_count":1116,"language":"CoffeeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":254,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":254,"open_issues":171,"watchers":1116,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/atom/apm/pulls/797"},"html":{"href":"https://github.com/atom/apm/pull/797"},"issue":{"href":"https://api.github.com/repos/atom/apm/issues/797"},"comments":{"href":"https://api.github.com/repos/atom/apm/issues/797/comments"},"review_comments":{"href":"https://api.github.com/repos/atom/apm/pulls/797/comments"},"review_comment":{"href":"https://api.github.com/repos/atom/apm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/atom/apm/pulls/797/commits"},"statuses":{"href":"https://api.github.com/repos/atom/apm/statuses/1f3284f2182a04f618ecb04c191dbf8527d1a7a3"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"daviwil"}}