{"action":"created","comment":{"url":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments/176502114","pull_request_review_id":106217818,"id":176502114,"diff_hunk":"@@ -1,135 +1,169 @@\n-import React from 'react';\n import PropTypes from 'prop-types';\n import styled, { css } from 'react-emotion';\n+import { includes } from 'lodash';\n \n-import { textKilo } from '../../styles/style-helpers';\n+import {\n+  textKilo,\n+  centerAlign,\n+  shadowSingle\n+} from '../../styles/style-helpers';\n \n const CENTER = 'center';\n+const TOP = 'top';\n const RIGHT = 'right';\n+const BOTTOM = 'bottom';\n const LEFT = 'left';\n \n-const baseStyles = css`\n+const backgroundColor = ({ theme }) => theme.colors.n900;","path":"src/components/Tooltip/Tooltip.js","position":20,"original_position":20,"commit_id":"a13b512eb9cd1c7aae943b1fef048c4a3067ba34","original_commit_id":"a13b512eb9cd1c7aae943b1fef048c4a3067ba34","user":{"login":"connor-baer","id":11017722,"avatar_url":"https://avatars0.githubusercontent.com/u/11017722?v=4","gravatar_id":"","url":"https://api.github.com/users/connor-baer","html_url":"https://github.com/connor-baer","followers_url":"https://api.github.com/users/connor-baer/followers","following_url":"https://api.github.com/users/connor-baer/following{/other_user}","gists_url":"https://api.github.com/users/connor-baer/gists{/gist_id}","starred_url":"https://api.github.com/users/connor-baer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connor-baer/subscriptions","organizations_url":"https://api.github.com/users/connor-baer/orgs","repos_url":"https://api.github.com/users/connor-baer/repos","events_url":"https://api.github.com/users/connor-baer/events{/privacy}","received_events_url":"https://api.github.com/users/connor-baer/received_events","type":"User","site_admin":false},"body":"`theme` would be undefined.","created_at":"2018-03-22T17:15:48Z","updated_at":"2018-03-22T17:15:48Z","html_url":"https://github.com/sumup/circuit-ui/pull/121#discussion_r176502114","pull_request_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/121","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments/176502114"},"html":{"href":"https://github.com/sumup/circuit-ui/pull/121#discussion_r176502114"},"pull_request":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/121"}},"in_reply_to_id":176498994},"pull_request":{"url":"https://api.github.com/repos/sumup/circuit-ui/pulls/121","id":175646245,"html_url":"https://github.com/sumup/circuit-ui/pull/121","diff_url":"https://github.com/sumup/circuit-ui/pull/121.diff","patch_url":"https://github.com/sumup/circuit-ui/pull/121.patch","issue_url":"https://api.github.com/repos/sumup/circuit-ui/issues/121","number":121,"state":"open","locked":false,"title":"Add form validation hints","user":{"login":"connor-baer","id":11017722,"avatar_url":"https://avatars0.githubusercontent.com/u/11017722?v=4","gravatar_id":"","url":"https://api.github.com/users/connor-baer","html_url":"https://github.com/connor-baer","followers_url":"https://api.github.com/users/connor-baer/followers","following_url":"https://api.github.com/users/connor-baer/following{/other_user}","gists_url":"https://api.github.com/users/connor-baer/gists{/gist_id}","starred_url":"https://api.github.com/users/connor-baer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connor-baer/subscriptions","organizations_url":"https://api.github.com/users/connor-baer/orgs","repos_url":"https://api.github.com/users/connor-baer/repos","events_url":"https://api.github.com/users/connor-baer/events{/privacy}","received_events_url":"https://api.github.com/users/connor-baer/received_events","type":"User","site_admin":false},"body":"## Changes\r\n\r\n- Rewrite Tooltip component to make it more flexible\r\n- Incorporate prefix and suffix into `<Input>` component (i.e. merge `<IconInput>` and `<Input>`)\r\n- Add validation icons to `<Input>`\r\n- Add `<InputTooltip>` for validation message\r\n\r\n## Questions\r\n\r\n- How are validation hints displayed on other form elements, such as selects, checkboxes, or toggles?\r\n- What's the most straightforward way of ensuring that the tooltips are always positioned within the viewport?\r\n- Do we need an abstraction à la `<ValidatedInput>` that takes care of the positioning and visibility of the tooltip? Where would that component go, Circuit UI or Dashboard?","created_at":"2018-03-16T21:07:06Z","updated_at":"2018-03-22T17:15:48Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb1bedb7b7d2defd6769c81fff445b43e35bc8fb","assignee":{"login":"connor-baer","id":11017722,"avatar_url":"https://avatars0.githubusercontent.com/u/11017722?v=4","gravatar_id":"","url":"https://api.github.com/users/connor-baer","html_url":"https://github.com/connor-baer","followers_url":"https://api.github.com/users/connor-baer/followers","following_url":"https://api.github.com/users/connor-baer/following{/other_user}","gists_url":"https://api.github.com/users/connor-baer/gists{/gist_id}","starred_url":"https://api.github.com/users/connor-baer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connor-baer/subscriptions","organizations_url":"https://api.github.com/users/connor-baer/orgs","repos_url":"https://api.github.com/users/connor-baer/repos","events_url":"https://api.github.com/users/connor-baer/events{/privacy}","received_events_url":"https://api.github.com/users/connor-baer/received_events","type":"User","site_admin":false},"assignees":[{"login":"connor-baer","id":11017722,"avatar_url":"https://avatars0.githubusercontent.com/u/11017722?v=4","gravatar_id":"","url":"https://api.github.com/users/connor-baer","html_url":"https://github.com/connor-baer","followers_url":"https://api.github.com/users/connor-baer/followers","following_url":"https://api.github.com/users/connor-baer/following{/other_user}","gists_url":"https://api.github.com/users/connor-baer/gists{/gist_id}","starred_url":"https://api.github.com/users/connor-baer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/connor-baer/subscriptions","organizations_url":"https://api.github.com/users/connor-baer/orgs","repos_url":"https://api.github.com/users/connor-baer/repos","events_url":"https://api.github.com/users/connor-baer/events{/privacy}","received_events_url":"https://api.github.com/users/connor-baer/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"mlent","id":1771845,"avatar_url":"https://avatars0.githubusercontent.com/u/1771845?v=4","gravatar_id":"","url":"https://api.github.com/users/mlent","html_url":"https://github.com/mlent","followers_url":"https://api.github.com/users/mlent/followers","following_url":"https://api.github.com/users/mlent/following{/other_user}","gists_url":"https://api.github.com/users/mlent/gists{/gist_id}","starred_url":"https://api.github.com/users/mlent/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mlent/subscriptions","organizations_url":"https://api.github.com/users/mlent/orgs","repos_url":"https://api.github.com/users/mlent/repos","events_url":"https://api.github.com/users/mlent/events{/privacy}","received_events_url":"https://api.github.com/users/mlent/received_events","type":"User","site_admin":false},{"login":"cristianoliveira","id":3959744,"avatar_url":"https://avatars0.githubusercontent.com/u/3959744?v=4","gravatar_id":"","url":"https://api.github.com/users/cristianoliveira","html_url":"https://github.com/cristianoliveira","followers_url":"https://api.github.com/users/cristianoliveira/followers","following_url":"https://api.github.com/users/cristianoliveira/following{/other_user}","gists_url":"https://api.github.com/users/cristianoliveira/gists{/gist_id}","starred_url":"https://api.github.com/users/cristianoliveira/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cristianoliveira/subscriptions","organizations_url":"https://api.github.com/users/cristianoliveira/orgs","repos_url":"https://api.github.com/users/cristianoliveira/repos","events_url":"https://api.github.com/users/cristianoliveira/events{/privacy}","received_events_url":"https://api.github.com/users/cristianoliveira/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":809259911,"url":"https://api.github.com/repos/sumup/circuit-ui/labels/in%20progress","name":"in progress","color":"a5f99d","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/121/commits","review_comments_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/121/comments","review_comment_url":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/issues/121/comments","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/a13b512eb9cd1c7aae943b1fef048c4a3067ba34","head":{"label":"sumup:feature/validation-hints","ref":"feature/validation-hints","sha":"a13b512eb9cd1c7aae943b1fef048c4a3067ba34","user":{"login":"sumup","id":1194464,"avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"repo":{"id":95433249,"name":"circuit-ui","full_name":"sumup/circuit-ui","owner":{"login":"sumup","id":1194464,"avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sumup/circuit-ui","description":"React component library for sumup web apps","fork":false,"url":"https://api.github.com/repos/sumup/circuit-ui","forks_url":"https://api.github.com/repos/sumup/circuit-ui/forks","keys_url":"https://api.github.com/repos/sumup/circuit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumup/circuit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumup/circuit-ui/teams","hooks_url":"https://api.github.com/repos/sumup/circuit-ui/hooks","issue_events_url":"https://api.github.com/repos/sumup/circuit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sumup/circuit-ui/events","assignees_url":"https://api.github.com/repos/sumup/circuit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sumup/circuit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sumup/circuit-ui/tags","blobs_url":"https://api.github.com/repos/sumup/circuit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumup/circuit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumup/circuit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumup/circuit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sumup/circuit-ui/languages","stargazers_url":"https://api.github.com/repos/sumup/circuit-ui/stargazers","contributors_url":"https://api.github.com/repos/sumup/circuit-ui/contributors","subscribers_url":"https://api.github.com/repos/sumup/circuit-ui/subscribers","subscription_url":"https://api.github.com/repos/sumup/circuit-ui/subscription","commits_url":"https://api.github.com/repos/sumup/circuit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumup/circuit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumup/circuit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumup/circuit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sumup/circuit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumup/circuit-ui/merges","archive_url":"https://api.github.com/repos/sumup/circuit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumup/circuit-ui/downloads","issues_url":"https://api.github.com/repos/sumup/circuit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sumup/circuit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sumup/circuit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sumup/circuit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumup/circuit-ui/labels{/name}","releases_url":"https://api.github.com/repos/sumup/circuit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sumup/circuit-ui/deployments","created_at":"2017-06-26T09:57:50Z","updated_at":"2018-03-22T10:54:31Z","pushed_at":"2018-03-22T15:50:45Z","git_url":"git://github.com/sumup/circuit-ui.git","ssh_url":"git@github.com:sumup/circuit-ui.git","clone_url":"https://github.com/sumup/circuit-ui.git","svn_url":"https://github.com/sumup/circuit-ui","homepage":"https://sumup.github.io/circuit-ui","size":4357,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":3,"open_issues":28,"watchers":16,"default_branch":"master"}},"base":{"label":"sumup:master","ref":"master","sha":"11dc023b67c79fd78bc0c0abdd6cd931ccafc705","user":{"login":"sumup","id":1194464,"avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"repo":{"id":95433249,"name":"circuit-ui","full_name":"sumup/circuit-ui","owner":{"login":"sumup","id":1194464,"avatar_url":"https://avatars2.githubusercontent.com/u/1194464?v=4","gravatar_id":"","url":"https://api.github.com/users/sumup","html_url":"https://github.com/sumup","followers_url":"https://api.github.com/users/sumup/followers","following_url":"https://api.github.com/users/sumup/following{/other_user}","gists_url":"https://api.github.com/users/sumup/gists{/gist_id}","starred_url":"https://api.github.com/users/sumup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sumup/subscriptions","organizations_url":"https://api.github.com/users/sumup/orgs","repos_url":"https://api.github.com/users/sumup/repos","events_url":"https://api.github.com/users/sumup/events{/privacy}","received_events_url":"https://api.github.com/users/sumup/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sumup/circuit-ui","description":"React component library for sumup web apps","fork":false,"url":"https://api.github.com/repos/sumup/circuit-ui","forks_url":"https://api.github.com/repos/sumup/circuit-ui/forks","keys_url":"https://api.github.com/repos/sumup/circuit-ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sumup/circuit-ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sumup/circuit-ui/teams","hooks_url":"https://api.github.com/repos/sumup/circuit-ui/hooks","issue_events_url":"https://api.github.com/repos/sumup/circuit-ui/issues/events{/number}","events_url":"https://api.github.com/repos/sumup/circuit-ui/events","assignees_url":"https://api.github.com/repos/sumup/circuit-ui/assignees{/user}","branches_url":"https://api.github.com/repos/sumup/circuit-ui/branches{/branch}","tags_url":"https://api.github.com/repos/sumup/circuit-ui/tags","blobs_url":"https://api.github.com/repos/sumup/circuit-ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sumup/circuit-ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sumup/circuit-ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/sumup/circuit-ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sumup/circuit-ui/statuses/{sha}","languages_url":"https://api.github.com/repos/sumup/circuit-ui/languages","stargazers_url":"https://api.github.com/repos/sumup/circuit-ui/stargazers","contributors_url":"https://api.github.com/repos/sumup/circuit-ui/contributors","subscribers_url":"https://api.github.com/repos/sumup/circuit-ui/subscribers","subscription_url":"https://api.github.com/repos/sumup/circuit-ui/subscription","commits_url":"https://api.github.com/repos/sumup/circuit-ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/sumup/circuit-ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/sumup/circuit-ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/sumup/circuit-ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/sumup/circuit-ui/contents/{+path}","compare_url":"https://api.github.com/repos/sumup/circuit-ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sumup/circuit-ui/merges","archive_url":"https://api.github.com/repos/sumup/circuit-ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sumup/circuit-ui/downloads","issues_url":"https://api.github.com/repos/sumup/circuit-ui/issues{/number}","pulls_url":"https://api.github.com/repos/sumup/circuit-ui/pulls{/number}","milestones_url":"https://api.github.com/repos/sumup/circuit-ui/milestones{/number}","notifications_url":"https://api.github.com/repos/sumup/circuit-ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sumup/circuit-ui/labels{/name}","releases_url":"https://api.github.com/repos/sumup/circuit-ui/releases{/id}","deployments_url":"https://api.github.com/repos/sumup/circuit-ui/deployments","created_at":"2017-06-26T09:57:50Z","updated_at":"2018-03-22T10:54:31Z","pushed_at":"2018-03-22T15:50:45Z","git_url":"git://github.com/sumup/circuit-ui.git","ssh_url":"git@github.com:sumup/circuit-ui.git","clone_url":"https://github.com/sumup/circuit-ui.git","svn_url":"https://github.com/sumup/circuit-ui","homepage":"https://sumup.github.io/circuit-ui","size":4357,"stargazers_count":16,"watchers_count":16,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":28,"license":null,"forks":3,"open_issues":28,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/121"},"html":{"href":"https://github.com/sumup/circuit-ui/pull/121"},"issue":{"href":"https://api.github.com/repos/sumup/circuit-ui/issues/121"},"comments":{"href":"https://api.github.com/repos/sumup/circuit-ui/issues/121/comments"},"review_comments":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/121/comments"},"review_comment":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sumup/circuit-ui/pulls/121/commits"},"statuses":{"href":"https://api.github.com/repos/sumup/circuit-ui/statuses/a13b512eb9cd1c7aae943b1fef048c4a3067ba34"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"connor-baer"}}