{"action":"created","comment":{"url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/comments/212362458","pull_request_review_id":148974049,"id":212362458,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMjM2MjQ1OA==","diff_hunk":"@@ -0,0 +1,87 @@\n+<?php\n+\n+namespace Drupal\\fb_instant_articles\\Normalizer;\n+\n+use Drupal\\Core\\Entity\\ContentEntityInterface;\n+use Drupal\\Core\\Entity\\EntityChangedInterface;\n+use Drupal\\user\\EntityOwnerInterface;\n+\n+/**\n+ * Common entity data getters shared between the normalizers.\n+ */\n+trait EntityHelperTrait {\n+\n+  /**\n+   * Instant articles config.\n+   *\n+   * @var \\Drupal\\Core\\Config\\ImmutableConfig\n+   */\n+  protected $config;","path":"src/Normalizer/EntityHelperTrait.php","position":19,"original_position":19,"commit_id":"abb5c47c7988f13cdda28fbbd52063df6680b46f","original_commit_id":"abb5c47c7988f13cdda28fbbd52063df6680b46f","user":{"login":"vijaycs85","id":1220029,"node_id":"MDQ6VXNlcjEyMjAwMjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1220029?v=4","gravatar_id":"","url":"https://api.github.com/users/vijaycs85","html_url":"https://github.com/vijaycs85","followers_url":"https://api.github.com/users/vijaycs85/followers","following_url":"https://api.github.com/users/vijaycs85/following{/other_user}","gists_url":"https://api.github.com/users/vijaycs85/gists{/gist_id}","starred_url":"https://api.github.com/users/vijaycs85/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vijaycs85/subscriptions","organizations_url":"https://api.github.com/users/vijaycs85/orgs","repos_url":"https://api.github.com/users/vijaycs85/repos","events_url":"https://api.github.com/users/vijaycs85/events{/privacy}","received_events_url":"https://api.github.com/users/vijaycs85/received_events","type":"User","site_admin":false},"body":"Since it's a trait, probably we want to have `config()` so that if the parent class doesn't have it set, we can fallback?\r\n```php\r\nprotected function config() {\r\n  if (!$this->config) {\r\n    $this->config = \\Drupal::config('fb_instant_articles.settings');\r\n  }\r\nreturn $this->config;\r\n}\r\n```","created_at":"2018-08-23T15:51:01Z","updated_at":"2018-08-23T15:53:46Z","html_url":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles/pull/135#discussion_r212362458","pull_request_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/135","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/comments/212362458"},"html":{"href":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles/pull/135#discussion_r212362458"},"pull_request":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/135"}}},"pull_request":{"url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/135","id":210318358,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMzE4MzU4","html_url":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles/pull/135","diff_url":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles/pull/135.diff","patch_url":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles/pull/135.patch","issue_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/issues/135","number":135,"state":"open","locked":false,"title":"Issue #2994506 Class hierarchy ties fbia_rss normalizer to fbia normalizer such that it can't be overriden","user":{"login":"m4olivei","id":191049,"node_id":"MDQ6VXNlcjE5MTA0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/191049?v=4","gravatar_id":"","url":"https://api.github.com/users/m4olivei","html_url":"https://github.com/m4olivei","followers_url":"https://api.github.com/users/m4olivei/followers","following_url":"https://api.github.com/users/m4olivei/following{/other_user}","gists_url":"https://api.github.com/users/m4olivei/gists{/gist_id}","starred_url":"https://api.github.com/users/m4olivei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4olivei/subscriptions","organizations_url":"https://api.github.com/users/m4olivei/orgs","repos_url":"https://api.github.com/users/m4olivei/repos","events_url":"https://api.github.com/users/m4olivei/events{/privacy}","received_events_url":"https://api.github.com/users/m4olivei/received_events","type":"User","site_admin":false},"body":"Resolves https://www.drupal.org/project/fb_instant_articles/issues/2994506","created_at":"2018-08-23T03:07:06Z","updated_at":"2018-08-23T15:53:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"38833b240a412e286fc0eb38531ab5adbcbc54be","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/135/commits","review_comments_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/135/comments","review_comment_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/issues/135/comments","statuses_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/statuses/abb5c47c7988f13cdda28fbbd52063df6680b46f","head":{"label":"m4olivei:2994506-fix-normalizer-class-mess","ref":"2994506-fix-normalizer-class-mess","sha":"abb5c47c7988f13cdda28fbbd52063df6680b46f","user":{"login":"m4olivei","id":191049,"node_id":"MDQ6VXNlcjE5MTA0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/191049?v=4","gravatar_id":"","url":"https://api.github.com/users/m4olivei","html_url":"https://github.com/m4olivei","followers_url":"https://api.github.com/users/m4olivei/followers","following_url":"https://api.github.com/users/m4olivei/following{/other_user}","gists_url":"https://api.github.com/users/m4olivei/gists{/gist_id}","starred_url":"https://api.github.com/users/m4olivei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4olivei/subscriptions","organizations_url":"https://api.github.com/users/m4olivei/orgs","repos_url":"https://api.github.com/users/m4olivei/repos","events_url":"https://api.github.com/users/m4olivei/events{/privacy}","received_events_url":"https://api.github.com/users/m4olivei/received_events","type":"User","site_admin":false},"repo":{"id":120780368,"node_id":"MDEwOlJlcG9zaXRvcnkxMjA3ODAzNjg=","name":"module-fb_instant_articles","full_name":"m4olivei/module-fb_instant_articles","owner":{"login":"m4olivei","id":191049,"node_id":"MDQ6VXNlcjE5MTA0OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/191049?v=4","gravatar_id":"","url":"https://api.github.com/users/m4olivei","html_url":"https://github.com/m4olivei","followers_url":"https://api.github.com/users/m4olivei/followers","following_url":"https://api.github.com/users/m4olivei/following{/other_user}","gists_url":"https://api.github.com/users/m4olivei/gists{/gist_id}","starred_url":"https://api.github.com/users/m4olivei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/m4olivei/subscriptions","organizations_url":"https://api.github.com/users/m4olivei/orgs","repos_url":"https://api.github.com/users/m4olivei/repos","events_url":"https://api.github.com/users/m4olivei/events{/privacy}","received_events_url":"https://api.github.com/users/m4olivei/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/m4olivei/module-fb_instant_articles","description":"Facebook Instant Articles Drupal integration module.","fork":true,"url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles","forks_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/forks","keys_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/teams","hooks_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/hooks","issue_events_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/issues/events{/number}","events_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/events","assignees_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/assignees{/user}","branches_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/branches{/branch}","tags_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/tags","blobs_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/git/refs{/sha}","trees_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/statuses/{sha}","languages_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/languages","stargazers_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/stargazers","contributors_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/contributors","subscribers_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/subscribers","subscription_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/subscription","commits_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/commits{/sha}","git_commits_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/git/commits{/sha}","comments_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/comments{/number}","issue_comment_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/issues/comments{/number}","contents_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/contents/{+path}","compare_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/merges","archive_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/downloads","issues_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/issues{/number}","pulls_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/pulls{/number}","milestones_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/milestones{/number}","notifications_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/labels{/name}","releases_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/releases{/id}","deployments_url":"https://api.github.com/repos/m4olivei/module-fb_instant_articles/deployments","created_at":"2018-02-08T15:36:35Z","updated_at":"2018-04-08T00:03:10Z","pushed_at":"2018-08-23T03:05:30Z","git_url":"git://github.com/m4olivei/module-fb_instant_articles.git","ssh_url":"git@github.com:m4olivei/module-fb_instant_articles.git","clone_url":"https://github.com/m4olivei/module-fb_instant_articles.git","svn_url":"https://github.com/m4olivei/module-fb_instant_articles","homepage":"https://www.drupal.org/project/fb_instant_articles","size":582,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"8.x-2.x"}},"base":{"label":"BurdaMagazinOrg:8.x-2.x","ref":"8.x-2.x","sha":"871bc9cc431bf296ffa403e360bad73dd192fd1a","user":{"login":"BurdaMagazinOrg","id":13872637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODcyNjM3","avatar_url":"https://avatars2.githubusercontent.com/u/13872637?v=4","gravatar_id":"","url":"https://api.github.com/users/BurdaMagazinOrg","html_url":"https://github.com/BurdaMagazinOrg","followers_url":"https://api.github.com/users/BurdaMagazinOrg/followers","following_url":"https://api.github.com/users/BurdaMagazinOrg/following{/other_user}","gists_url":"https://api.github.com/users/BurdaMagazinOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/BurdaMagazinOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurdaMagazinOrg/subscriptions","organizations_url":"https://api.github.com/users/BurdaMagazinOrg/orgs","repos_url":"https://api.github.com/users/BurdaMagazinOrg/repos","events_url":"https://api.github.com/users/BurdaMagazinOrg/events{/privacy}","received_events_url":"https://api.github.com/users/BurdaMagazinOrg/received_events","type":"Organization","site_admin":false},"repo":{"id":51014912,"node_id":"MDEwOlJlcG9zaXRvcnk1MTAxNDkxMg==","name":"module-fb_instant_articles","full_name":"BurdaMagazinOrg/module-fb_instant_articles","owner":{"login":"BurdaMagazinOrg","id":13872637,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzODcyNjM3","avatar_url":"https://avatars2.githubusercontent.com/u/13872637?v=4","gravatar_id":"","url":"https://api.github.com/users/BurdaMagazinOrg","html_url":"https://github.com/BurdaMagazinOrg","followers_url":"https://api.github.com/users/BurdaMagazinOrg/followers","following_url":"https://api.github.com/users/BurdaMagazinOrg/following{/other_user}","gists_url":"https://api.github.com/users/BurdaMagazinOrg/gists{/gist_id}","starred_url":"https://api.github.com/users/BurdaMagazinOrg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BurdaMagazinOrg/subscriptions","organizations_url":"https://api.github.com/users/BurdaMagazinOrg/orgs","repos_url":"https://api.github.com/users/BurdaMagazinOrg/repos","events_url":"https://api.github.com/users/BurdaMagazinOrg/events{/privacy}","received_events_url":"https://api.github.com/users/BurdaMagazinOrg/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles","description":"Facebook Instant Articles Drupal integration module.","fork":false,"url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles","forks_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/forks","keys_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/teams","hooks_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/hooks","issue_events_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/issues/events{/number}","events_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/events","assignees_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/assignees{/user}","branches_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/branches{/branch}","tags_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/tags","blobs_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/git/refs{/sha}","trees_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/statuses/{sha}","languages_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/languages","stargazers_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/stargazers","contributors_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/contributors","subscribers_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/subscribers","subscription_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/subscription","commits_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/commits{/sha}","git_commits_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/git/commits{/sha}","comments_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/comments{/number}","issue_comment_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/issues/comments{/number}","contents_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/contents/{+path}","compare_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/merges","archive_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/downloads","issues_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/issues{/number}","pulls_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls{/number}","milestones_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/milestones{/number}","notifications_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/labels{/name}","releases_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/releases{/id}","deployments_url":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/deployments","created_at":"2016-02-03T16:55:07Z","updated_at":"2018-04-08T00:02:29Z","pushed_at":"2018-08-23T03:07:07Z","git_url":"git://github.com/BurdaMagazinOrg/module-fb_instant_articles.git","ssh_url":"git@github.com:BurdaMagazinOrg/module-fb_instant_articles.git","clone_url":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles.git","svn_url":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles","homepage":"https://www.drupal.org/project/fb_instant_articles","size":581,"stargazers_count":16,"watchers_count":16,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":9,"license":null,"forks":24,"open_issues":9,"watchers":16,"default_branch":"8.x-2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/135"},"html":{"href":"https://github.com/BurdaMagazinOrg/module-fb_instant_articles/pull/135"},"issue":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/issues/135"},"comments":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/issues/135/comments"},"review_comments":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/135/comments"},"review_comment":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/pulls/135/commits"},"statuses":{"href":"https://api.github.com/repos/BurdaMagazinOrg/module-fb_instant_articles/statuses/abb5c47c7988f13cdda28fbbd52063df6680b46f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"vijaycs85"}}