{"action":"created","issue":{"url":"https://api.github.com/repos/gitgitgadget/git/issues/76","repository_url":"https://api.github.com/repos/gitgitgadget/git","labels_url":"https://api.github.com/repos/gitgitgadget/git/issues/76/labels{/name}","comments_url":"https://api.github.com/repos/gitgitgadget/git/issues/76/comments","events_url":"https://api.github.com/repos/gitgitgadget/git/issues/76/events","html_url":"https://github.com/gitgitgadget/git/pull/76","id":380167799,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwNDMwMzcw","number":76,"title":"rebase: understand -C<n> again, refactor","user":{"login":"dscho","id":127790,"node_id":"MDQ6VXNlcjEyNzc5MA==","avatar_url":"https://avatars0.githubusercontent.com/u/127790?v=4","gravatar_id":"","url":"https://api.github.com/users/dscho","html_url":"https://github.com/dscho","followers_url":"https://api.github.com/users/dscho/followers","following_url":"https://api.github.com/users/dscho/following{/other_user}","gists_url":"https://api.github.com/users/dscho/gists{/gist_id}","starred_url":"https://api.github.com/users/dscho/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dscho/subscriptions","organizations_url":"https://api.github.com/users/dscho/orgs","repos_url":"https://api.github.com/users/dscho/repos","events_url":"https://api.github.com/users/dscho/events{/privacy}","received_events_url":"https://api.github.com/users/dscho/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-11-13T10:55:18Z","updated_at":"2018-11-14T16:26:17Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/gitgitgadget/git/pulls/76","html_url":"https://github.com/gitgitgadget/git/pull/76","diff_url":"https://github.com/gitgitgadget/git/pull/76.diff","patch_url":"https://github.com/gitgitgadget/git/pull/76.patch"},"body":"Phillip Wood reported a problem where the built-in rebase did not understand options like `-C1`, i.e. it did not expect the option argument.\r\n\r\nWhile investigating how to address this best, I stumbled upon `OPT_PASSTHRU_ARGV` (which I was so far happily unaware of).\r\n\r\nInstead of just fixing the `-C<n>` bug, I decided to simply convert all of the options intended for `git am` (or, eventually, for `git apply`). This happens to fix that bug, and does so much more: it simplifies the entire logic (and removes more lines than it adds).\r\n\r\nChange since v1:\r\n\r\n- Introduce early parameter validation for the options passed through to `git am`.\r\n\r\nCc: Phillip Wood <phillip.wood@dunelm.org.uk>"},"comment":{"url":"https://api.github.com/repos/gitgitgadget/git/issues/comments/438724783","html_url":"https://github.com/gitgitgadget/git/pull/76#issuecomment-438724783","issue_url":"https://api.github.com/repos/gitgitgadget/git/issues/76","id":438724783,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODcyNDc4Mw==","user":{"login":"gitgitgadget[bot]","id":39766333,"node_id":"MDM6Qm90Mzk3NjYzMzM=","avatar_url":"https://avatars3.githubusercontent.com/in/12836?v=4","gravatar_id":"","url":"https://api.github.com/users/gitgitgadget%5Bbot%5D","html_url":"https://github.com/apps/gitgitgadget","followers_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/followers","following_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/repos","events_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/gitgitgadget%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-14T16:26:17Z","updated_at":"2018-11-14T16:26:17Z","author_association":"NONE","body":"Submitted as [pull.76.v2.git.gitgitgadget@gmail.com](https://public-inbox.org/git/pull.76.v2.git.gitgitgadget@gmail.com)"}}
{"actor":{"display_login":"gitgitgadget"}}