{"action":"created","comment":{"url":"https://api.github.com/repos/gonum/gonum/pulls/comments/186274558","pull_request_review_id":117827208,"id":186274558,"diff_hunk":"@@ -616,3 +616,827 @@ var cfftTests = []struct {\n \t\twantiifac: []int{2, 1, 2, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0},\n \t},\n }\n+\n+func TestSint(t *testing.T) {\n+\tconst tol = 1e-12\n+\tfor _, test := range sintTests {\n+\t\twork := make([]float64, 5*(test.n)/2)\n+\t\tifac := make([]int, 15)\n+\n+\t\tSinti(test.n-1, work, ifac)\n+\t\tvar failed bool\n+\t\tif !floats.EqualApprox(work, test.wantiwork, 1e-6) {\n+\t\t\tfailed = true\n+\t\t\tt.Errorf(\"unexpected work after call to sinti for n=%d\", test.n)\n+\t\t}\n+\t\tif !reflect.DeepEqual(ifac, test.wantiifac) {\n+\t\t\tfailed = true\n+\t\t\tt.Errorf(\"unexpected ifac after call to sinti for n=%d\", test.n)\n+\t\t}\n+\t\tif failed {\n+\t\t\tcontinue\n+\t\t}\n+\n+\t\tfn := float64(test.n)","path":"fourier/internal/fftpack/fftpack_test.go","position":null,"original_position":25,"commit_id":"84faf854c29f056421e5762b0ee721e64b4c0156","original_commit_id":"103e716fbd7c84ddb47bd10dde669e97128497c4","user":{"login":"kortschak","id":275221,"avatar_url":"https://avatars1.githubusercontent.com/u/275221?v=4","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false},"body":"Done","created_at":"2018-05-05T23:13:12Z","updated_at":"2018-05-05T23:13:12Z","html_url":"https://github.com/gonum/gonum/pull/465#discussion_r186274558","pull_request_url":"https://api.github.com/repos/gonum/gonum/pulls/465","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/gonum/gonum/pulls/comments/186274558"},"html":{"href":"https://github.com/gonum/gonum/pull/465#discussion_r186274558"},"pull_request":{"href":"https://api.github.com/repos/gonum/gonum/pulls/465"}},"in_reply_to_id":186115618},"pull_request":{"url":"https://api.github.com/repos/gonum/gonum/pulls/465","id":181671035,"html_url":"https://github.com/gonum/gonum/pull/465","diff_url":"https://github.com/gonum/gonum/pull/465.diff","patch_url":"https://github.com/gonum/gonum/pull/465.patch","issue_url":"https://api.github.com/repos/gonum/gonum/issues/465","number":465,"state":"open","locked":false,"title":"fourier: add quarterwave functions","user":{"login":"kortschak","id":275221,"avatar_url":"https://avatars1.githubusercontent.com/u/275221?v=4","gravatar_id":"","url":"https://api.github.com/users/kortschak","html_url":"https://github.com/kortschak","followers_url":"https://api.github.com/users/kortschak/followers","following_url":"https://api.github.com/users/kortschak/following{/other_user}","gists_url":"https://api.github.com/users/kortschak/gists{/gist_id}","starred_url":"https://api.github.com/users/kortschak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kortschak/subscriptions","organizations_url":"https://api.github.com/users/kortschak/orgs","repos_url":"https://api.github.com/users/kortschak/repos","events_url":"https://api.github.com/users/kortschak/events{/privacy}","received_events_url":"https://api.github.com/users/kortschak/received_events","type":"User","site_admin":false},"body":"Please take a look.\r\n\r\nAt this point the change of `.*FFT` -> `.*Coefficients` and `.*IFFT` -> `.*Sequence` methods names should make sense.\r\n\r\n<!--\r\nChecklist:\r\n\r\n- API changes have been discussed\r\n- code is goformated correctly (goimports)\r\n- packages with generated code have had code generation run\r\n- tests pass locally\r\n- linked to relevant issues\r\n\r\nPlease make sure your commit message summary line and pull request\r\ntitle match the Go convention; a one-line summary of the change,\r\nprefixed by the primary affected package that should complete the\r\nsentence, \"This change modifies Gonum to _____.\"\r\n-->\r\n","created_at":"2018-04-14T22:53:59Z","updated_at":"2018-05-05T23:13:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0bf2caeb6158a6490371a0818fc94bd8daa9b5bd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"sbinet","id":1070920,"avatar_url":"https://avatars2.githubusercontent.com/u/1070920?v=4","gravatar_id":"","url":"https://api.github.com/users/sbinet","html_url":"https://github.com/sbinet","followers_url":"https://api.github.com/users/sbinet/followers","following_url":"https://api.github.com/users/sbinet/following{/other_user}","gists_url":"https://api.github.com/users/sbinet/gists{/gist_id}","starred_url":"https://api.github.com/users/sbinet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbinet/subscriptions","organizations_url":"https://api.github.com/users/sbinet/orgs","repos_url":"https://api.github.com/users/sbinet/repos","events_url":"https://api.github.com/users/sbinet/events{/privacy}","received_events_url":"https://api.github.com/users/sbinet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gonum/gonum/pulls/465/commits","review_comments_url":"https://api.github.com/repos/gonum/gonum/pulls/465/comments","review_comment_url":"https://api.github.com/repos/gonum/gonum/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gonum/gonum/issues/465/comments","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/84faf854c29f056421e5762b0ee721e64b4c0156","head":{"label":"gonum:fourier/quarterwave","ref":"fourier/quarterwave","sha":"84faf854c29f056421e5762b0ee721e64b4c0156","user":{"login":"gonum","id":3771091,"avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":86164982,"name":"gonum","full_name":"gonum/gonum","owner":{"login":"gonum","id":3771091,"avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/gonum","description":"Gonum is a set of numeric libraries for the Go programming language. It contains libraries for matrices, statistics, optimization, and more","fork":false,"url":"https://api.github.com/repos/gonum/gonum","forks_url":"https://api.github.com/repos/gonum/gonum/forks","keys_url":"https://api.github.com/repos/gonum/gonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/gonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/gonum/teams","hooks_url":"https://api.github.com/repos/gonum/gonum/hooks","issue_events_url":"https://api.github.com/repos/gonum/gonum/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/gonum/events","assignees_url":"https://api.github.com/repos/gonum/gonum/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/gonum/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/gonum/tags","blobs_url":"https://api.github.com/repos/gonum/gonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/gonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/gonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/gonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/gonum/languages","stargazers_url":"https://api.github.com/repos/gonum/gonum/stargazers","contributors_url":"https://api.github.com/repos/gonum/gonum/contributors","subscribers_url":"https://api.github.com/repos/gonum/gonum/subscribers","subscription_url":"https://api.github.com/repos/gonum/gonum/subscription","commits_url":"https://api.github.com/repos/gonum/gonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/gonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/gonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/gonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonum/gonum/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/gonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/gonum/merges","archive_url":"https://api.github.com/repos/gonum/gonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/gonum/downloads","issues_url":"https://api.github.com/repos/gonum/gonum/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/gonum/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/gonum/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/gonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/gonum/labels{/name}","releases_url":"https://api.github.com/repos/gonum/gonum/releases{/id}","deployments_url":"https://api.github.com/repos/gonum/gonum/deployments","created_at":"2017-03-25T14:54:38Z","updated_at":"2018-05-05T22:24:49Z","pushed_at":"2018-05-05T23:12:45Z","git_url":"git://github.com/gonum/gonum.git","ssh_url":"git@github.com:gonum/gonum.git","clone_url":"https://github.com/gonum/gonum.git","svn_url":"https://github.com/gonum/gonum","homepage":"https://www.gonum.org/","size":10923,"stargazers_count":1655,"watchers_count":1655,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":102,"open_issues":96,"watchers":1655,"default_branch":"master"}},"base":{"label":"gonum:master","ref":"master","sha":"7b0fe8702cfbd13dcd10eeb7accbdc6f094d9af4","user":{"login":"gonum","id":3771091,"avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"repo":{"id":86164982,"name":"gonum","full_name":"gonum/gonum","owner":{"login":"gonum","id":3771091,"avatar_url":"https://avatars0.githubusercontent.com/u/3771091?v=4","gravatar_id":"","url":"https://api.github.com/users/gonum","html_url":"https://github.com/gonum","followers_url":"https://api.github.com/users/gonum/followers","following_url":"https://api.github.com/users/gonum/following{/other_user}","gists_url":"https://api.github.com/users/gonum/gists{/gist_id}","starred_url":"https://api.github.com/users/gonum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gonum/subscriptions","organizations_url":"https://api.github.com/users/gonum/orgs","repos_url":"https://api.github.com/users/gonum/repos","events_url":"https://api.github.com/users/gonum/events{/privacy}","received_events_url":"https://api.github.com/users/gonum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gonum/gonum","description":"Gonum is a set of numeric libraries for the Go programming language. It contains libraries for matrices, statistics, optimization, and more","fork":false,"url":"https://api.github.com/repos/gonum/gonum","forks_url":"https://api.github.com/repos/gonum/gonum/forks","keys_url":"https://api.github.com/repos/gonum/gonum/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gonum/gonum/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gonum/gonum/teams","hooks_url":"https://api.github.com/repos/gonum/gonum/hooks","issue_events_url":"https://api.github.com/repos/gonum/gonum/issues/events{/number}","events_url":"https://api.github.com/repos/gonum/gonum/events","assignees_url":"https://api.github.com/repos/gonum/gonum/assignees{/user}","branches_url":"https://api.github.com/repos/gonum/gonum/branches{/branch}","tags_url":"https://api.github.com/repos/gonum/gonum/tags","blobs_url":"https://api.github.com/repos/gonum/gonum/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gonum/gonum/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gonum/gonum/git/refs{/sha}","trees_url":"https://api.github.com/repos/gonum/gonum/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gonum/gonum/statuses/{sha}","languages_url":"https://api.github.com/repos/gonum/gonum/languages","stargazers_url":"https://api.github.com/repos/gonum/gonum/stargazers","contributors_url":"https://api.github.com/repos/gonum/gonum/contributors","subscribers_url":"https://api.github.com/repos/gonum/gonum/subscribers","subscription_url":"https://api.github.com/repos/gonum/gonum/subscription","commits_url":"https://api.github.com/repos/gonum/gonum/commits{/sha}","git_commits_url":"https://api.github.com/repos/gonum/gonum/git/commits{/sha}","comments_url":"https://api.github.com/repos/gonum/gonum/comments{/number}","issue_comment_url":"https://api.github.com/repos/gonum/gonum/issues/comments{/number}","contents_url":"https://api.github.com/repos/gonum/gonum/contents/{+path}","compare_url":"https://api.github.com/repos/gonum/gonum/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gonum/gonum/merges","archive_url":"https://api.github.com/repos/gonum/gonum/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gonum/gonum/downloads","issues_url":"https://api.github.com/repos/gonum/gonum/issues{/number}","pulls_url":"https://api.github.com/repos/gonum/gonum/pulls{/number}","milestones_url":"https://api.github.com/repos/gonum/gonum/milestones{/number}","notifications_url":"https://api.github.com/repos/gonum/gonum/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gonum/gonum/labels{/name}","releases_url":"https://api.github.com/repos/gonum/gonum/releases{/id}","deployments_url":"https://api.github.com/repos/gonum/gonum/deployments","created_at":"2017-03-25T14:54:38Z","updated_at":"2018-05-05T22:24:49Z","pushed_at":"2018-05-05T23:12:45Z","git_url":"git://github.com/gonum/gonum.git","ssh_url":"git@github.com:gonum/gonum.git","clone_url":"https://github.com/gonum/gonum.git","svn_url":"https://github.com/gonum/gonum","homepage":"https://www.gonum.org/","size":10923,"stargazers_count":1655,"watchers_count":1655,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":102,"mirror_url":null,"archived":false,"open_issues_count":96,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":102,"open_issues":96,"watchers":1655,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gonum/gonum/pulls/465"},"html":{"href":"https://github.com/gonum/gonum/pull/465"},"issue":{"href":"https://api.github.com/repos/gonum/gonum/issues/465"},"comments":{"href":"https://api.github.com/repos/gonum/gonum/issues/465/comments"},"review_comments":{"href":"https://api.github.com/repos/gonum/gonum/pulls/465/comments"},"review_comment":{"href":"https://api.github.com/repos/gonum/gonum/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gonum/gonum/pulls/465/commits"},"statuses":{"href":"https://api.github.com/repos/gonum/gonum/statuses/84faf854c29f056421e5762b0ee721e64b4c0156"}},"author_association":"OWNER"}}
{"actor":{"display_login":"kortschak"}}