{"action":"closed","number":656,"pull_request":{"url":"https://api.github.com/repos/airbnb/streamalert/pulls/656","id":177815552,"html_url":"https://github.com/airbnb/streamalert/pull/656","diff_url":"https://github.com/airbnb/streamalert/pull/656.diff","patch_url":"https://github.com/airbnb/streamalert/pull/656.patch","issue_url":"https://api.github.com/repos/airbnb/streamalert/issues/656","number":656,"state":"closed","locked":false,"title":"[tf] refactor apps terraform module to use the new `tf_lambda` module","user":{"login":"ryandeivert","id":13773789,"avatar_url":"https://avatars3.githubusercontent.com/u/13773789?v=4","gravatar_id":"","url":"https://api.github.com/users/ryandeivert","html_url":"https://github.com/ryandeivert","followers_url":"https://api.github.com/users/ryandeivert/followers","following_url":"https://api.github.com/users/ryandeivert/following{/other_user}","gists_url":"https://api.github.com/users/ryandeivert/gists{/gist_id}","starred_url":"https://api.github.com/users/ryandeivert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryandeivert/subscriptions","organizations_url":"https://api.github.com/users/ryandeivert/orgs","repos_url":"https://api.github.com/users/ryandeivert/repos","events_url":"https://api.github.com/users/ryandeivert/events{/privacy}","received_events_url":"https://api.github.com/users/ryandeivert/received_events","type":"User","site_admin":false},"body":"to: @austinbyers \r\ncc: @airbnb/streamalert-maintainers\r\nsize: medium\r\n\r\n## Background\r\n\r\nWith @austinbyers' great addition of a `tf_lambda` terraform module, we have the ability to reduce a lot of redundancy with our lambda terraform modules.\r\n\r\n## Changes\r\n\r\n* Refactor apps terraform module to use tf_lambda module\r\n  * This is now split into two parts - most of the module has been removed and will use the `tf_lambda` module for generation.\r\n  * IAM and SSM configuration settings are what remain in the renamed `stream_alert_app_iam` module.\r\n* Updates to the cli manage code for new app config format\r\n  * This also includes updates for creating a new app with the new config format\r\n\r\n## Other\r\n\r\n* This has the added benefit of introducing support for `metric_alarms` into the apps functions.\r\n  * These will be enabled by default when adding a new app.\r\n\r\n## Testing\r\n* Updating unit tests for new app config format\r\n* Ran `terraform validate` on the newly pared down `stream_alert_app_iam` module.\r\n* Performed `python manage.py terraform generate` and `terraform validate` on the files in `terraform`","created_at":"2018-03-27T17:45:25Z","updated_at":"2018-03-27T20:53:37Z","closed_at":"2018-03-27T20:53:37Z","merged_at":"2018-03-27T20:53:37Z","merge_commit_sha":"28f84e97f6b92c45a4ac001c348f8a6a9e0265fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/airbnb/streamalert/pulls/656/commits","review_comments_url":"https://api.github.com/repos/airbnb/streamalert/pulls/656/comments","review_comment_url":"https://api.github.com/repos/airbnb/streamalert/pulls/comments{/number}","comments_url":"https://api.github.com/repos/airbnb/streamalert/issues/656/comments","statuses_url":"https://api.github.com/repos/airbnb/streamalert/statuses/abdfa81b908152940692868e005cfe6d2eec05b8","head":{"label":"airbnb:ryandeivert-add-app-alarms","ref":"ryandeivert-add-app-alarms","sha":"abdfa81b908152940692868e005cfe6d2eec05b8","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":79683936,"name":"streamalert","full_name":"airbnb/streamalert","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/streamalert","description":"StreamAlert is a serverless, realtime data analysis framework which empowers you to ingest, analyze, and alert on data from any environment, using datasources and alerting logic you define.","fork":false,"url":"https://api.github.com/repos/airbnb/streamalert","forks_url":"https://api.github.com/repos/airbnb/streamalert/forks","keys_url":"https://api.github.com/repos/airbnb/streamalert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/streamalert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/streamalert/teams","hooks_url":"https://api.github.com/repos/airbnb/streamalert/hooks","issue_events_url":"https://api.github.com/repos/airbnb/streamalert/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/streamalert/events","assignees_url":"https://api.github.com/repos/airbnb/streamalert/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/streamalert/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/streamalert/tags","blobs_url":"https://api.github.com/repos/airbnb/streamalert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/streamalert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/streamalert/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/streamalert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/streamalert/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/streamalert/languages","stargazers_url":"https://api.github.com/repos/airbnb/streamalert/stargazers","contributors_url":"https://api.github.com/repos/airbnb/streamalert/contributors","subscribers_url":"https://api.github.com/repos/airbnb/streamalert/subscribers","subscription_url":"https://api.github.com/repos/airbnb/streamalert/subscription","commits_url":"https://api.github.com/repos/airbnb/streamalert/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/streamalert/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/streamalert/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/streamalert/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/streamalert/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/streamalert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/streamalert/merges","archive_url":"https://api.github.com/repos/airbnb/streamalert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/streamalert/downloads","issues_url":"https://api.github.com/repos/airbnb/streamalert/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/streamalert/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/streamalert/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/streamalert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/streamalert/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/streamalert/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/streamalert/deployments","created_at":"2017-01-22T01:10:56Z","updated_at":"2018-03-27T19:19:28Z","pushed_at":"2018-03-27T20:53:37Z","git_url":"git://github.com/airbnb/streamalert.git","ssh_url":"git@github.com:airbnb/streamalert.git","clone_url":"https://github.com/airbnb/streamalert.git","svn_url":"https://github.com/airbnb/streamalert","homepage":"","size":7921,"stargazers_count":1191,"watchers_count":1191,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":122,"open_issues":58,"watchers":1191,"default_branch":"master"}},"base":{"label":"airbnb:master","ref":"master","sha":"8955b416f0fdbbb88bc86038b2338f6ca7b3eef0","user":{"login":"airbnb","id":698437,"avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"repo":{"id":79683936,"name":"streamalert","full_name":"airbnb/streamalert","owner":{"login":"airbnb","id":698437,"avatar_url":"https://avatars3.githubusercontent.com/u/698437?v=4","gravatar_id":"","url":"https://api.github.com/users/airbnb","html_url":"https://github.com/airbnb","followers_url":"https://api.github.com/users/airbnb/followers","following_url":"https://api.github.com/users/airbnb/following{/other_user}","gists_url":"https://api.github.com/users/airbnb/gists{/gist_id}","starred_url":"https://api.github.com/users/airbnb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/airbnb/subscriptions","organizations_url":"https://api.github.com/users/airbnb/orgs","repos_url":"https://api.github.com/users/airbnb/repos","events_url":"https://api.github.com/users/airbnb/events{/privacy}","received_events_url":"https://api.github.com/users/airbnb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/airbnb/streamalert","description":"StreamAlert is a serverless, realtime data analysis framework which empowers you to ingest, analyze, and alert on data from any environment, using datasources and alerting logic you define.","fork":false,"url":"https://api.github.com/repos/airbnb/streamalert","forks_url":"https://api.github.com/repos/airbnb/streamalert/forks","keys_url":"https://api.github.com/repos/airbnb/streamalert/keys{/key_id}","collaborators_url":"https://api.github.com/repos/airbnb/streamalert/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/airbnb/streamalert/teams","hooks_url":"https://api.github.com/repos/airbnb/streamalert/hooks","issue_events_url":"https://api.github.com/repos/airbnb/streamalert/issues/events{/number}","events_url":"https://api.github.com/repos/airbnb/streamalert/events","assignees_url":"https://api.github.com/repos/airbnb/streamalert/assignees{/user}","branches_url":"https://api.github.com/repos/airbnb/streamalert/branches{/branch}","tags_url":"https://api.github.com/repos/airbnb/streamalert/tags","blobs_url":"https://api.github.com/repos/airbnb/streamalert/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/airbnb/streamalert/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/airbnb/streamalert/git/refs{/sha}","trees_url":"https://api.github.com/repos/airbnb/streamalert/git/trees{/sha}","statuses_url":"https://api.github.com/repos/airbnb/streamalert/statuses/{sha}","languages_url":"https://api.github.com/repos/airbnb/streamalert/languages","stargazers_url":"https://api.github.com/repos/airbnb/streamalert/stargazers","contributors_url":"https://api.github.com/repos/airbnb/streamalert/contributors","subscribers_url":"https://api.github.com/repos/airbnb/streamalert/subscribers","subscription_url":"https://api.github.com/repos/airbnb/streamalert/subscription","commits_url":"https://api.github.com/repos/airbnb/streamalert/commits{/sha}","git_commits_url":"https://api.github.com/repos/airbnb/streamalert/git/commits{/sha}","comments_url":"https://api.github.com/repos/airbnb/streamalert/comments{/number}","issue_comment_url":"https://api.github.com/repos/airbnb/streamalert/issues/comments{/number}","contents_url":"https://api.github.com/repos/airbnb/streamalert/contents/{+path}","compare_url":"https://api.github.com/repos/airbnb/streamalert/compare/{base}...{head}","merges_url":"https://api.github.com/repos/airbnb/streamalert/merges","archive_url":"https://api.github.com/repos/airbnb/streamalert/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/airbnb/streamalert/downloads","issues_url":"https://api.github.com/repos/airbnb/streamalert/issues{/number}","pulls_url":"https://api.github.com/repos/airbnb/streamalert/pulls{/number}","milestones_url":"https://api.github.com/repos/airbnb/streamalert/milestones{/number}","notifications_url":"https://api.github.com/repos/airbnb/streamalert/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/airbnb/streamalert/labels{/name}","releases_url":"https://api.github.com/repos/airbnb/streamalert/releases{/id}","deployments_url":"https://api.github.com/repos/airbnb/streamalert/deployments","created_at":"2017-01-22T01:10:56Z","updated_at":"2018-03-27T19:19:28Z","pushed_at":"2018-03-27T20:53:37Z","git_url":"git://github.com/airbnb/streamalert.git","ssh_url":"git@github.com:airbnb/streamalert.git","clone_url":"https://github.com/airbnb/streamalert.git","svn_url":"https://github.com/airbnb/streamalert","homepage":"","size":7921,"stargazers_count":1191,"watchers_count":1191,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":122,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":122,"open_issues":58,"watchers":1191,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/656"},"html":{"href":"https://github.com/airbnb/streamalert/pull/656"},"issue":{"href":"https://api.github.com/repos/airbnb/streamalert/issues/656"},"comments":{"href":"https://api.github.com/repos/airbnb/streamalert/issues/656/comments"},"review_comments":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/656/comments"},"review_comment":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/airbnb/streamalert/pulls/656/commits"},"statuses":{"href":"https://api.github.com/repos/airbnb/streamalert/statuses/abdfa81b908152940692868e005cfe6d2eec05b8"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ryandeivert","id":13773789,"avatar_url":"https://avatars3.githubusercontent.com/u/13773789?v=4","gravatar_id":"","url":"https://api.github.com/users/ryandeivert","html_url":"https://github.com/ryandeivert","followers_url":"https://api.github.com/users/ryandeivert/followers","following_url":"https://api.github.com/users/ryandeivert/following{/other_user}","gists_url":"https://api.github.com/users/ryandeivert/gists{/gist_id}","starred_url":"https://api.github.com/users/ryandeivert/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryandeivert/subscriptions","organizations_url":"https://api.github.com/users/ryandeivert/orgs","repos_url":"https://api.github.com/users/ryandeivert/repos","events_url":"https://api.github.com/users/ryandeivert/events{/privacy}","received_events_url":"https://api.github.com/users/ryandeivert/received_events","type":"User","site_admin":false},"comments":1,"review_comments":6,"maintainer_can_modify":false,"commits":6,"additions":347,"deletions":498,"changed_files":22}}
{"actor":{"display_login":"ryandeivert"}}