{"action":"closed","number":37,"pull_request":{"url":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls/37","id":170365540,"html_url":"https://github.com/graphhopper/directions-api-js-client/pull/37","diff_url":"https://github.com/graphhopper/directions-api-js-client/pull/37.diff","patch_url":"https://github.com/graphhopper/directions-api-js-client/pull/37.patch","issue_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/issues/37","number":37,"state":"closed","locked":false,"title":"Store key for tests in an environment variable","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"body":"Fixes #34. \r\n\r\nCurrently our Travis tests are failing, because we don't have a valid API KEY registered. This PR proposes to store the key in an environment variable on Travis, but not encrypted, because encrypted environment variables don't work for [PRs](https://docs.travis-ci.com/user/environment-variables/#Defining-encrypted-variables-in-.travis.yml). I registered the variable in travis, so no code changes are required to change the key.","created_at":"2018-02-21T02:59:15Z","updated_at":"2018-02-21T10:16:38Z","closed_at":"2018-02-21T10:16:38Z","merged_at":"2018-02-21T10:16:37Z","merge_commit_sha":"56ef88797bfaacde913e31cda16774b3727aacca","assignee":null,"assignees":[],"requested_reviewers":[{"login":"karussell","id":129644,"avatar_url":"https://avatars0.githubusercontent.com/u/129644?v=4","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":176070813,"url":"https://api.github.com/repos/graphhopper/directions-api-js-client/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls/37/commits","review_comments_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls/37/comments","review_comment_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls/comments{/number}","comments_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/issues/37/comments","statuses_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/statuses/4a3f2cac656006b99b09ff439832a7f41f5e3f68","head":{"label":"boldtrn:test_key_env_var","ref":"test_key_env_var","sha":"4a3f2cac656006b99b09ff439832a7f41f5e3f68","user":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"repo":{"id":77198322,"name":"directions-api-js-client","full_name":"boldtrn/directions-api-js-client","owner":{"login":"boldtrn","id":1553525,"avatar_url":"https://avatars3.githubusercontent.com/u/1553525?v=4","gravatar_id":"","url":"https://api.github.com/users/boldtrn","html_url":"https://github.com/boldtrn","followers_url":"https://api.github.com/users/boldtrn/followers","following_url":"https://api.github.com/users/boldtrn/following{/other_user}","gists_url":"https://api.github.com/users/boldtrn/gists{/gist_id}","starred_url":"https://api.github.com/users/boldtrn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/boldtrn/subscriptions","organizations_url":"https://api.github.com/users/boldtrn/orgs","repos_url":"https://api.github.com/users/boldtrn/repos","events_url":"https://api.github.com/users/boldtrn/events{/privacy}","received_events_url":"https://api.github.com/users/boldtrn/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/boldtrn/directions-api-js-client","description":"JavaScript client for the GraphHopper Directions API","fork":true,"url":"https://api.github.com/repos/boldtrn/directions-api-js-client","forks_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/forks","keys_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/teams","hooks_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/hooks","issue_events_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/issues/events{/number}","events_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/events","assignees_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/assignees{/user}","branches_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/branches{/branch}","tags_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/tags","blobs_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/statuses/{sha}","languages_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/languages","stargazers_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/stargazers","contributors_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/contributors","subscribers_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/subscribers","subscription_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/subscription","commits_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/contents/{+path}","compare_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/merges","archive_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/downloads","issues_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/issues{/number}","pulls_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/pulls{/number}","milestones_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/milestones{/number}","notifications_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/labels{/name}","releases_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/releases{/id}","deployments_url":"https://api.github.com/repos/boldtrn/directions-api-js-client/deployments","created_at":"2016-12-23T04:44:43Z","updated_at":"2016-12-23T04:44:46Z","pushed_at":"2018-02-21T02:49:56Z","git_url":"git://github.com/boldtrn/directions-api-js-client.git","ssh_url":"git@github.com:boldtrn/directions-api-js-client.git","clone_url":"https://github.com/boldtrn/directions-api-js-client.git","svn_url":"https://github.com/boldtrn/directions-api-js-client","homepage":"https://graphhopper.com/api/1/examples","size":3477,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"graphhopper:master","ref":"master","sha":"d89926ded4b5fdace195e115d1a7fcf3486a6085","user":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"repo":{"id":30650201,"name":"directions-api-js-client","full_name":"graphhopper/directions-api-js-client","owner":{"login":"graphhopper","id":2264498,"avatar_url":"https://avatars1.githubusercontent.com/u/2264498?v=4","gravatar_id":"","url":"https://api.github.com/users/graphhopper","html_url":"https://github.com/graphhopper","followers_url":"https://api.github.com/users/graphhopper/followers","following_url":"https://api.github.com/users/graphhopper/following{/other_user}","gists_url":"https://api.github.com/users/graphhopper/gists{/gist_id}","starred_url":"https://api.github.com/users/graphhopper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/graphhopper/subscriptions","organizations_url":"https://api.github.com/users/graphhopper/orgs","repos_url":"https://api.github.com/users/graphhopper/repos","events_url":"https://api.github.com/users/graphhopper/events{/privacy}","received_events_url":"https://api.github.com/users/graphhopper/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/graphhopper/directions-api-js-client","description":"JavaScript client for the GraphHopper Directions API","fork":false,"url":"https://api.github.com/repos/graphhopper/directions-api-js-client","forks_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/forks","keys_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/keys{/key_id}","collaborators_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/teams","hooks_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/hooks","issue_events_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/issues/events{/number}","events_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/events","assignees_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/assignees{/user}","branches_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/branches{/branch}","tags_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/tags","blobs_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/git/refs{/sha}","trees_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/git/trees{/sha}","statuses_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/statuses/{sha}","languages_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/languages","stargazers_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/stargazers","contributors_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/contributors","subscribers_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/subscribers","subscription_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/subscription","commits_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/commits{/sha}","git_commits_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/git/commits{/sha}","comments_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/comments{/number}","issue_comment_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/issues/comments{/number}","contents_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/contents/{+path}","compare_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/compare/{base}...{head}","merges_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/merges","archive_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/downloads","issues_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/issues{/number}","pulls_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls{/number}","milestones_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/milestones{/number}","notifications_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/labels{/name}","releases_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/releases{/id}","deployments_url":"https://api.github.com/repos/graphhopper/directions-api-js-client/deployments","created_at":"2015-02-11T13:59:58Z","updated_at":"2018-02-19T18:27:14Z","pushed_at":"2018-02-21T10:16:37Z","git_url":"git://github.com/graphhopper/directions-api-js-client.git","ssh_url":"git@github.com:graphhopper/directions-api-js-client.git","clone_url":"https://github.com/graphhopper/directions-api-js-client.git","svn_url":"https://github.com/graphhopper/directions-api-js-client","homepage":"https://graphhopper.com/api/1/examples","size":3510,"stargazers_count":35,"watchers_count":35,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":36,"mirror_url":null,"archived":false,"open_issues_count":6,"license":null,"forks":36,"open_issues":6,"watchers":35,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls/37"},"html":{"href":"https://github.com/graphhopper/directions-api-js-client/pull/37"},"issue":{"href":"https://api.github.com/repos/graphhopper/directions-api-js-client/issues/37"},"comments":{"href":"https://api.github.com/repos/graphhopper/directions-api-js-client/issues/37/comments"},"review_comments":{"href":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls/37/comments"},"review_comment":{"href":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/graphhopper/directions-api-js-client/pulls/37/commits"},"statuses":{"href":"https://api.github.com/repos/graphhopper/directions-api-js-client/statuses/4a3f2cac656006b99b09ff439832a7f41f5e3f68"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"karussell","id":129644,"avatar_url":"https://avatars0.githubusercontent.com/u/129644?v=4","gravatar_id":"","url":"https://api.github.com/users/karussell","html_url":"https://github.com/karussell","followers_url":"https://api.github.com/users/karussell/followers","following_url":"https://api.github.com/users/karussell/following{/other_user}","gists_url":"https://api.github.com/users/karussell/gists{/gist_id}","starred_url":"https://api.github.com/users/karussell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/karussell/subscriptions","organizations_url":"https://api.github.com/users/karussell/orgs","repos_url":"https://api.github.com/users/karussell/repos","events_url":"https://api.github.com/users/karussell/events{/privacy}","received_events_url":"https://api.github.com/users/karussell/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":6,"deletions":5,"changed_files":3}}
{"actor":{"display_login":"karussell"}}