{"action":"created","issue":{"url":"https://api.github.com/repos/storybooks/storybook/issues/3527","repository_url":"https://api.github.com/repos/storybooks/storybook","labels_url":"https://api.github.com/repos/storybooks/storybook/issues/3527/labels{/name}","comments_url":"https://api.github.com/repos/storybooks/storybook/issues/3527/comments","events_url":"https://api.github.com/repos/storybooks/storybook/issues/3527/events","html_url":"https://github.com/storybooks/storybook/pull/3527","id":319904416,"number":3527,"title":"Updates storybook-start.js to use child_process instead of shelljs","user":{"login":"sky-franciscogoncalves","id":33831763,"avatar_url":"https://avatars1.githubusercontent.com/u/33831763?v=4","gravatar_id":"","url":"https://api.github.com/users/sky-franciscogoncalves","html_url":"https://github.com/sky-franciscogoncalves","followers_url":"https://api.github.com/users/sky-franciscogoncalves/followers","following_url":"https://api.github.com/users/sky-franciscogoncalves/following{/other_user}","gists_url":"https://api.github.com/users/sky-franciscogoncalves/gists{/gist_id}","starred_url":"https://api.github.com/users/sky-franciscogoncalves/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sky-franciscogoncalves/subscriptions","organizations_url":"https://api.github.com/users/sky-franciscogoncalves/orgs","repos_url":"https://api.github.com/users/sky-franciscogoncalves/repos","events_url":"https://api.github.com/users/sky-franciscogoncalves/events{/privacy}","received_events_url":"https://api.github.com/users/sky-franciscogoncalves/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-03T12:43:19Z","updated_at":"2018-05-03T13:04:55Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/storybooks/storybook/pulls/3527","html_url":"https://github.com/storybooks/storybook/pull/3527","diff_url":"https://github.com/storybooks/storybook/pull/3527.diff","patch_url":"https://github.com/storybooks/storybook/pull/3527.patch"},"body":"## Issue\r\n```\r\nERROR  Error running yarn run storybook -- --config haul.config.js --platform all\r\nError: Given stream is not a TTY\r\nat makeTTYAdapter (node_modules/react-stream-renderer/src/adapters/TTY/makeTTYAdapter.js:13:11)\r\nat initUI (node_modules/haul/src/server/ui.js:72:9)\r\nat createServer (node_modules/haul/src/server/index.js:54:28)\r\nat Object.start [as action] (node_modules/haul/src/commands/start.js:51:3)\r\nat <anonymous>\r\nat process._tickCallback (internal/process/next_tick.js:188:7)\r\nat Function.Module.runMain (module.js:678:11)\r\nat startup (bootstrap_node.js:187:16)\r\nat bootstrap_node.js:608:3\r\n```\r\n## What I did\r\nUpdated react-native's `storybook-start.js` to use `child_process` instead of ShellJS. This is because the later does not support running commands that require interactive input, as you can see [here](https://github.com/shelljs/shelljs/wiki/FAQ#running-interactive-programs-with-exec).\r\n\r\nThe need to use these type of commands, started when I updated both Haul and Storybook to their last versions. \r\n\r\n## How to test\r\n\r\nTo test this you should update Haul to v1.0.0-rc.0 and Storybook to v4.0.0-alpha.4. Then you should perform `storybook start -p 7007 --haul haul.config.js --platform all`. Where the config file follows Haul's new configuration style.\r\n\r\nPlease let me know if I can improve this PR in anyway."},"comment":{"url":"https://api.github.com/repos/storybooks/storybook/issues/comments/386288417","html_url":"https://github.com/storybooks/storybook/pull/3527#issuecomment-386288417","issue_url":"https://api.github.com/repos/storybooks/storybook/issues/3527","id":386288417,"user":{"login":"storybook-safe-bot","id":37472152,"avatar_url":"https://avatars2.githubusercontent.com/u/37472152?v=4","gravatar_id":"","url":"https://api.github.com/users/storybook-safe-bot","html_url":"https://github.com/storybook-safe-bot","followers_url":"https://api.github.com/users/storybook-safe-bot/followers","following_url":"https://api.github.com/users/storybook-safe-bot/following{/other_user}","gists_url":"https://api.github.com/users/storybook-safe-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/storybook-safe-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/storybook-safe-bot/subscriptions","organizations_url":"https://api.github.com/users/storybook-safe-bot/orgs","repos_url":"https://api.github.com/users/storybook-safe-bot/repos","events_url":"https://api.github.com/users/storybook-safe-bot/events{/privacy}","received_events_url":"https://api.github.com/users/storybook-safe-bot/received_events","type":"User","site_admin":false},"created_at":"2018-05-03T13:04:55Z","updated_at":"2018-05-03T13:04:55Z","author_association":"CONTRIBUTOR","body":"\n<!--\n  1 failure:  PR is not labeled...\n  0 warning: \n  \n  \n  DangerID: danger-id-default;\n-->\n\n<table>\n  <thead>\n    <tr>\n      <th width=\"50\"></th>\n      <th width=\"100%\" data-danger-table=\"true\">Fails</th>\n    </tr>\n  </thead>\n  <tbody><tr>\n      <td>:no_entry_sign:</td>\n      <td>\n\n  PR is not labeled with one of: [\"cleanup\",\"BREAKING CHANGE\",\"feature request\",\"bug\",\"documentation\",\"maintenance\",\"dependencies:update\",\"dependencies\",\"other\"]\n  </td>\n    </tr>\n  </tbody>\n</table>\n\n\n\n\n<p align=\"right\">\n  Generated by :no_entry_sign: <a href=\"http://github.com/danger/danger-js/\">dangerJS</a>\n</p>\n"}}
{"actor":{"display_login":"storybook-safe-bot"}}