{"action":"created","issue":{"url":"https://api.github.com/repos/mbuhot/open_api_spex/issues/9","repository_url":"https://api.github.com/repos/mbuhot/open_api_spex","labels_url":"https://api.github.com/repos/mbuhot/open_api_spex/issues/9/labels{/name}","comments_url":"https://api.github.com/repos/mbuhot/open_api_spex/issues/9/comments","events_url":"https://api.github.com/repos/mbuhot/open_api_spex/issues/9/events","html_url":"https://github.com/mbuhot/open_api_spex/pull/9","id":317616883,"number":9,"title":"Basic checks for undefined parameters","user":{"login":"cstaud","id":2623220,"avatar_url":"https://avatars2.githubusercontent.com/u/2623220?v=4","gravatar_id":"","url":"https://api.github.com/users/cstaud","html_url":"https://github.com/cstaud","followers_url":"https://api.github.com/users/cstaud/followers","following_url":"https://api.github.com/users/cstaud/following{/other_user}","gists_url":"https://api.github.com/users/cstaud/gists{/gist_id}","starred_url":"https://api.github.com/users/cstaud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cstaud/subscriptions","organizations_url":"https://api.github.com/users/cstaud/orgs","repos_url":"https://api.github.com/users/cstaud/repos","events_url":"https://api.github.com/users/cstaud/events{/privacy}","received_events_url":"https://api.github.com/users/cstaud/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-04-25T12:58:27Z","updated_at":"2018-05-18T08:18:22Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/mbuhot/open_api_spex/pulls/9","html_url":"https://github.com/mbuhot/open_api_spex/pull/9","diff_url":"https://github.com/mbuhot/open_api_spex/pull/9.diff","patch_url":"https://github.com/mbuhot/open_api_spex/pull/9.patch"},"body":"Fixed #8 \r\nWe updated the swagger UI version and implemented a basic functionality to check for undefined parameters (query parameters only)"},"comment":{"url":"https://api.github.com/repos/mbuhot/open_api_spex/issues/comments/390132290","html_url":"https://github.com/mbuhot/open_api_spex/pull/9#issuecomment-390132290","issue_url":"https://api.github.com/repos/mbuhot/open_api_spex/issues/9","id":390132290,"user":{"login":"mbuhot","id":336840,"avatar_url":"https://avatars3.githubusercontent.com/u/336840?v=4","gravatar_id":"","url":"https://api.github.com/users/mbuhot","html_url":"https://github.com/mbuhot","followers_url":"https://api.github.com/users/mbuhot/followers","following_url":"https://api.github.com/users/mbuhot/following{/other_user}","gists_url":"https://api.github.com/users/mbuhot/gists{/gist_id}","starred_url":"https://api.github.com/users/mbuhot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbuhot/subscriptions","organizations_url":"https://api.github.com/users/mbuhot/orgs","repos_url":"https://api.github.com/users/mbuhot/repos","events_url":"https://api.github.com/users/mbuhot/events{/privacy}","received_events_url":"https://api.github.com/users/mbuhot/received_events","type":"User","site_admin":false},"created_at":"2018-05-18T08:18:22Z","updated_at":"2018-05-18T08:18:22Z","author_association":"OWNER","body":"@ctaud sorry for the delayed response. Looks like I'm missing some tests in `open_api_spex`.\r\nIf you run the tests in `examples/phoenix_app` there's some errors:\r\n\r\n```\r\n  1) test create user (PhoenixAppWeb.UserControllerTest)\r\n     test/phoenix_app_web/controllers/user_controller_test.exs:9\r\n     ** (FunctionClauseError) no function clause matching in OpenApiSpex.Operation.validate_parameters/2\r\n\r\n     The following arguments were given to OpenApiSpex.Operation.validate_parameters/2:\r\n     \r\n         # 1\r\n         %Plug.Conn{}\r\n\r\n         # 2\r\n         nil\r\n     \r\n     Attempted function clauses (showing 1 out of 1):\r\n     \r\n         defp validate_parameters(%Plug.Conn{} = conn, defined_params) when is_list(defined_params)\r\n     \r\n     code: |> post(user_path(conn, :create, %{\"user\" => %{\"name\" => \"Joe\", \"email\" => \"joe@gmail.com\"}}))\r\n     stacktrace:\r\n       (open_api_spex) lib/open_api_spex/operation.ex:134: OpenApiSpex.Operation.validate_parameters/2\r\n       (open_api_spex) lib/open_api_spex/operation.ex:126: OpenApiSpex.Operation.cast/4\r\n       (open_api_spex) lib/open_api_spex/plug/cast.ex:33: OpenApiSpex.Plug.Cast.call/2\r\n       (phoenix_app) lib/phoenix_app_web/controllers/user_controller.ex:1: PhoenixAppWeb.UserController.phoenix_controller_pipeline/2\r\n```\r\n\r\n"}}
{"actor":{"display_login":"mbuhot"}}