{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/comments/188502477","pull_request_review_id":120492251,"id":188502477,"diff_hunk":"@@ -26,11 +26,7 @@ spec:\n         imagePullPolicy: {{ .Values.image.pullPolicy | quote }}\n         env:\n         - name: ALLOW_EMPTY_PASSWORD\n-        {{- if .Values.allowEmptyPassword }}\n-          value: \"yes\"\n-        {{- else }}\n-          value: \"no\"\n-        {{- end }}\n+          value: {{ .Values.allowEmptyPassword | quote }}","path":"stable/wordpress/templates/deployment.yaml","position":9,"original_position":9,"commit_id":"3690abc7729519b1a5600ba80d29d297bf702a7b","original_commit_id":"8618fd584ebbe2fdfdcf67c0d1d18eda267a9b90","user":{"login":"sameersbn","id":410147,"avatar_url":"https://avatars0.githubusercontent.com/u/410147?v=4","gravatar_id":"","url":"https://api.github.com/users/sameersbn","html_url":"https://github.com/sameersbn","followers_url":"https://api.github.com/users/sameersbn/followers","following_url":"https://api.github.com/users/sameersbn/following{/other_user}","gists_url":"https://api.github.com/users/sameersbn/gists{/gist_id}","starred_url":"https://api.github.com/users/sameersbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameersbn/subscriptions","organizations_url":"https://api.github.com/users/sameersbn/orgs","repos_url":"https://api.github.com/users/sameersbn/repos","events_url":"https://api.github.com/users/sameersbn/events{/privacy}","received_events_url":"https://api.github.com/users/sameersbn/received_events","type":"User","site_admin":false},"body":"Having `allowedEmptyPassword: yes` (without quotes) in the `values.yaml` will treat the `allowedEmptyPassword` as a boolean and result in the value `true` for the `ALLOW_EMPTY_PASSWORD` env variable.  The `bitnami/wordpress` image only accepts the value `yes/no` and hence the container launch will fail.\r\n\r\nThis if block also ensures that `ALLOW_EMPTY_PASSWORD` is assigned the correct value when users specify `--set allowedEmptyPassword=yes` on the helm command line.","created_at":"2018-05-16T04:49:47Z","updated_at":"2018-05-16T04:49:55Z","html_url":"https://github.com/kubernetes/charts/pull/5550#discussion_r188502477","pull_request_url":"https://api.github.com/repos/kubernetes/charts/pulls/5550","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments/188502477"},"html":{"href":"https://github.com/kubernetes/charts/pull/5550#discussion_r188502477"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5550"}},"in_reply_to_id":188184005},"pull_request":{"url":"https://api.github.com/repos/kubernetes/charts/pulls/5550","id":187810127,"html_url":"https://github.com/kubernetes/charts/pull/5550","diff_url":"https://github.com/kubernetes/charts/pull/5550.diff","patch_url":"https://github.com/kubernetes/charts/pull/5550.patch","issue_url":"https://api.github.com/repos/kubernetes/charts/issues/5550","number":5550,"state":"open","locked":false,"title":"Fix ingress metadata.name bug.","user":{"login":"ismailbaskin","id":358830,"avatar_url":"https://avatars3.githubusercontent.com/u/358830?v=4","gravatar_id":"","url":"https://api.github.com/users/ismailbaskin","html_url":"https://github.com/ismailbaskin","followers_url":"https://api.github.com/users/ismailbaskin/followers","following_url":"https://api.github.com/users/ismailbaskin/following{/other_user}","gists_url":"https://api.github.com/users/ismailbaskin/gists{/gist_id}","starred_url":"https://api.github.com/users/ismailbaskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismailbaskin/subscriptions","organizations_url":"https://api.github.com/users/ismailbaskin/orgs","repos_url":"https://api.github.com/users/ismailbaskin/repos","events_url":"https://api.github.com/users/ismailbaskin/events{/privacy}","received_events_url":"https://api.github.com/users/ismailbaskin/received_events","type":"User","site_admin":false},"body":"It simply fixes #2920 issue and corrects allowEmptyPassword value usage.","created_at":"2018-05-14T12:25:23Z","updated_at":"2018-05-16T04:49:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cf42d196d460bfe1816094dcc5e928fb8f2c27e","assignee":{"login":"carrodher","id":13216600,"avatar_url":"https://avatars1.githubusercontent.com/u/13216600?v=4","gravatar_id":"","url":"https://api.github.com/users/carrodher","html_url":"https://github.com/carrodher","followers_url":"https://api.github.com/users/carrodher/followers","following_url":"https://api.github.com/users/carrodher/following{/other_user}","gists_url":"https://api.github.com/users/carrodher/gists{/gist_id}","starred_url":"https://api.github.com/users/carrodher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrodher/subscriptions","organizations_url":"https://api.github.com/users/carrodher/orgs","repos_url":"https://api.github.com/users/carrodher/repos","events_url":"https://api.github.com/users/carrodher/events{/privacy}","received_events_url":"https://api.github.com/users/carrodher/received_events","type":"User","site_admin":false},"assignees":[{"login":"sameersbn","id":410147,"avatar_url":"https://avatars0.githubusercontent.com/u/410147?v=4","gravatar_id":"","url":"https://api.github.com/users/sameersbn","html_url":"https://github.com/sameersbn","followers_url":"https://api.github.com/users/sameersbn/followers","following_url":"https://api.github.com/users/sameersbn/following{/other_user}","gists_url":"https://api.github.com/users/sameersbn/gists{/gist_id}","starred_url":"https://api.github.com/users/sameersbn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sameersbn/subscriptions","organizations_url":"https://api.github.com/users/sameersbn/orgs","repos_url":"https://api.github.com/users/sameersbn/repos","events_url":"https://api.github.com/users/sameersbn/events{/privacy}","received_events_url":"https://api.github.com/users/sameersbn/received_events","type":"User","site_admin":false},{"login":"prydonius","id":1544861,"avatar_url":"https://avatars3.githubusercontent.com/u/1544861?v=4","gravatar_id":"","url":"https://api.github.com/users/prydonius","html_url":"https://github.com/prydonius","followers_url":"https://api.github.com/users/prydonius/followers","following_url":"https://api.github.com/users/prydonius/following{/other_user}","gists_url":"https://api.github.com/users/prydonius/gists{/gist_id}","starred_url":"https://api.github.com/users/prydonius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/prydonius/subscriptions","organizations_url":"https://api.github.com/users/prydonius/orgs","repos_url":"https://api.github.com/users/prydonius/repos","events_url":"https://api.github.com/users/prydonius/events{/privacy}","received_events_url":"https://api.github.com/users/prydonius/received_events","type":"User","site_admin":false},{"login":"carrodher","id":13216600,"avatar_url":"https://avatars1.githubusercontent.com/u/13216600?v=4","gravatar_id":"","url":"https://api.github.com/users/carrodher","html_url":"https://github.com/carrodher","followers_url":"https://api.github.com/users/carrodher/followers","following_url":"https://api.github.com/users/carrodher/following{/other_user}","gists_url":"https://api.github.com/users/carrodher/gists{/gist_id}","starred_url":"https://api.github.com/users/carrodher/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carrodher/subscriptions","organizations_url":"https://api.github.com/users/carrodher/orgs","repos_url":"https://api.github.com/users/carrodher/repos","events_url":"https://api.github.com/users/carrodher/events{/privacy}","received_events_url":"https://api.github.com/users/carrodher/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"tompizmor","id":4026184,"avatar_url":"https://avatars1.githubusercontent.com/u/4026184?v=4","gravatar_id":"","url":"https://api.github.com/users/tompizmor","html_url":"https://github.com/tompizmor","followers_url":"https://api.github.com/users/tompizmor/followers","following_url":"https://api.github.com/users/tompizmor/following{/other_user}","gists_url":"https://api.github.com/users/tompizmor/gists{/gist_id}","starred_url":"https://api.github.com/users/tompizmor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tompizmor/subscriptions","organizations_url":"https://api.github.com/users/tompizmor/orgs","repos_url":"https://api.github.com/users/tompizmor/repos","events_url":"https://api.github.com/users/tompizmor/events{/privacy}","received_events_url":"https://api.github.com/users/tompizmor/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":484586588,"url":"https://api.github.com/repos/kubernetes/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676009699,"url":"https://api.github.com/repos/kubernetes/charts/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/charts/pulls/5550/commits","review_comments_url":"https://api.github.com/repos/kubernetes/charts/pulls/5550/comments","review_comment_url":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/charts/issues/5550/comments","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/3690abc7729519b1a5600ba80d29d297bf702a7b","head":{"label":"ismailbaskin:master","ref":"master","sha":"3690abc7729519b1a5600ba80d29d297bf702a7b","user":{"login":"ismailbaskin","id":358830,"avatar_url":"https://avatars3.githubusercontent.com/u/358830?v=4","gravatar_id":"","url":"https://api.github.com/users/ismailbaskin","html_url":"https://github.com/ismailbaskin","followers_url":"https://api.github.com/users/ismailbaskin/followers","following_url":"https://api.github.com/users/ismailbaskin/following{/other_user}","gists_url":"https://api.github.com/users/ismailbaskin/gists{/gist_id}","starred_url":"https://api.github.com/users/ismailbaskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismailbaskin/subscriptions","organizations_url":"https://api.github.com/users/ismailbaskin/orgs","repos_url":"https://api.github.com/users/ismailbaskin/repos","events_url":"https://api.github.com/users/ismailbaskin/events{/privacy}","received_events_url":"https://api.github.com/users/ismailbaskin/received_events","type":"User","site_admin":false},"repo":{"id":133355584,"name":"charts","full_name":"ismailbaskin/charts","owner":{"login":"ismailbaskin","id":358830,"avatar_url":"https://avatars3.githubusercontent.com/u/358830?v=4","gravatar_id":"","url":"https://api.github.com/users/ismailbaskin","html_url":"https://github.com/ismailbaskin","followers_url":"https://api.github.com/users/ismailbaskin/followers","following_url":"https://api.github.com/users/ismailbaskin/following{/other_user}","gists_url":"https://api.github.com/users/ismailbaskin/gists{/gist_id}","starred_url":"https://api.github.com/users/ismailbaskin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ismailbaskin/subscriptions","organizations_url":"https://api.github.com/users/ismailbaskin/orgs","repos_url":"https://api.github.com/users/ismailbaskin/repos","events_url":"https://api.github.com/users/ismailbaskin/events{/privacy}","received_events_url":"https://api.github.com/users/ismailbaskin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ismailbaskin/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/ismailbaskin/charts","forks_url":"https://api.github.com/repos/ismailbaskin/charts/forks","keys_url":"https://api.github.com/repos/ismailbaskin/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ismailbaskin/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ismailbaskin/charts/teams","hooks_url":"https://api.github.com/repos/ismailbaskin/charts/hooks","issue_events_url":"https://api.github.com/repos/ismailbaskin/charts/issues/events{/number}","events_url":"https://api.github.com/repos/ismailbaskin/charts/events","assignees_url":"https://api.github.com/repos/ismailbaskin/charts/assignees{/user}","branches_url":"https://api.github.com/repos/ismailbaskin/charts/branches{/branch}","tags_url":"https://api.github.com/repos/ismailbaskin/charts/tags","blobs_url":"https://api.github.com/repos/ismailbaskin/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ismailbaskin/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ismailbaskin/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/ismailbaskin/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ismailbaskin/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/ismailbaskin/charts/languages","stargazers_url":"https://api.github.com/repos/ismailbaskin/charts/stargazers","contributors_url":"https://api.github.com/repos/ismailbaskin/charts/contributors","subscribers_url":"https://api.github.com/repos/ismailbaskin/charts/subscribers","subscription_url":"https://api.github.com/repos/ismailbaskin/charts/subscription","commits_url":"https://api.github.com/repos/ismailbaskin/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/ismailbaskin/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/ismailbaskin/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/ismailbaskin/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/ismailbaskin/charts/contents/{+path}","compare_url":"https://api.github.com/repos/ismailbaskin/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ismailbaskin/charts/merges","archive_url":"https://api.github.com/repos/ismailbaskin/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ismailbaskin/charts/downloads","issues_url":"https://api.github.com/repos/ismailbaskin/charts/issues{/number}","pulls_url":"https://api.github.com/repos/ismailbaskin/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/ismailbaskin/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/ismailbaskin/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ismailbaskin/charts/labels{/name}","releases_url":"https://api.github.com/repos/ismailbaskin/charts/releases{/id}","deployments_url":"https://api.github.com/repos/ismailbaskin/charts/deployments","created_at":"2018-05-14T12:13:03Z","updated_at":"2018-05-15T15:57:32Z","pushed_at":"2018-05-15T15:57:29Z","git_url":"git://github.com/ismailbaskin/charts.git","ssh_url":"git@github.com:ismailbaskin/charts.git","clone_url":"https://github.com/ismailbaskin/charts.git","svn_url":"https://github.com/ismailbaskin/charts","homepage":"","size":7311,"stargazers_count":0,"watchers_count":0,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"0934e936ac76f529bede80df1e9fa2c7a8d85a1b","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"name":"charts","full_name":"kubernetes/charts","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/charts","forks_url":"https://api.github.com/repos/kubernetes/charts/forks","keys_url":"https://api.github.com/repos/kubernetes/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/charts/teams","hooks_url":"https://api.github.com/repos/kubernetes/charts/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/charts/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/charts/events","assignees_url":"https://api.github.com/repos/kubernetes/charts/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/charts/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/charts/tags","blobs_url":"https://api.github.com/repos/kubernetes/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/charts/languages","stargazers_url":"https://api.github.com/repos/kubernetes/charts/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/charts/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/charts/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/charts/subscription","commits_url":"https://api.github.com/repos/kubernetes/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/charts/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/charts/merges","archive_url":"https://api.github.com/repos/kubernetes/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/charts/downloads","issues_url":"https://api.github.com/repos/kubernetes/charts/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/charts/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/charts/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-05-16T04:47:04Z","pushed_at":"2018-05-16T04:46:29Z","git_url":"git://github.com/kubernetes/charts.git","ssh_url":"git@github.com:kubernetes/charts.git","clone_url":"https://github.com/kubernetes/charts.git","svn_url":"https://github.com/kubernetes/charts","homepage":"","size":7351,"stargazers_count":3140,"watchers_count":3140,"language":"Smarty","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2667,"mirror_url":null,"archived":false,"open_issues_count":620,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":2667,"open_issues":620,"watchers":3140,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5550"},"html":{"href":"https://github.com/kubernetes/charts/pull/5550"},"issue":{"href":"https://api.github.com/repos/kubernetes/charts/issues/5550"},"comments":{"href":"https://api.github.com/repos/kubernetes/charts/issues/5550/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5550/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/charts/pulls/5550/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/charts/statuses/3690abc7729519b1a5600ba80d29d297bf702a7b"}},"author_association":"NONE"}}
{"actor":{"display_login":"sameersbn"}}