{"action":"created","comment":{"url":"https://api.github.com/repos/wolox-training/abh-react/pulls/comments/228903024","pull_request_review_id":169272375,"id":228903024,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODkwMzAyNA==","diff_hunk":"@@ -11,10 +11,15 @@ import GameLayout from './layout';\n class Game extends Component {\n   componentDidMount() {\n     this.props.loadGameInfo();\n-    store.subscribe(() => {\n+    this.unsuscribe = store.subscribe(() => {\n       saveGameState(store.getState().game);\n     });\n   }\n+\n+  componentWillUnmount() {\n+    this.unsuscribe();","path":"react/game/src/app/screens/Game/index.js","position":11,"original_position":11,"commit_id":"3a67ad380d44cca1604b9f4f389cac382c9afbc4","original_commit_id":"3a67ad380d44cca1604b9f4f389cac382c9afbc4","user":{"login":"WFolini","id":12822259,"node_id":"MDQ6VXNlcjEyODIyMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/12822259?v=4","gravatar_id":"","url":"https://api.github.com/users/WFolini","html_url":"https://github.com/WFolini","followers_url":"https://api.github.com/users/WFolini/followers","following_url":"https://api.github.com/users/WFolini/following{/other_user}","gists_url":"https://api.github.com/users/WFolini/gists{/gist_id}","starred_url":"https://api.github.com/users/WFolini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WFolini/subscriptions","organizations_url":"https://api.github.com/users/WFolini/orgs","repos_url":"https://api.github.com/users/WFolini/repos","events_url":"https://api.github.com/users/WFolini/events{/privacy}","received_events_url":"https://api.github.com/users/WFolini/received_events","type":"User","site_admin":false},"body":"👌 ","created_at":"2018-10-29T12:22:51Z","updated_at":"2018-10-29T12:47:40Z","html_url":"https://github.com/wolox-training/abh-react/pull/23#discussion_r228903024","pull_request_url":"https://api.github.com/repos/wolox-training/abh-react/pulls/23","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/wolox-training/abh-react/pulls/comments/228903024"},"html":{"href":"https://github.com/wolox-training/abh-react/pull/23#discussion_r228903024"},"pull_request":{"href":"https://api.github.com/repos/wolox-training/abh-react/pulls/23"}}},"pull_request":{"url":"https://api.github.com/repos/wolox-training/abh-react/pulls/23","id":226338062,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MzM4MDYy","html_url":"https://github.com/wolox-training/abh-react/pull/23","diff_url":"https://github.com/wolox-training/abh-react/pull/23.diff","patch_url":"https://github.com/wolox-training/abh-react/pull/23.patch","issue_url":"https://api.github.com/repos/wolox-training/abh-react/issues/23","number":23,"state":"open","locked":false,"title":"Redux recompose","user":{"login":"alejobh","id":15016271,"node_id":"MDQ6VXNlcjE1MDE2Mjcx","avatar_url":"https://avatars0.githubusercontent.com/u/15016271?v=4","gravatar_id":"","url":"https://api.github.com/users/alejobh","html_url":"https://github.com/alejobh","followers_url":"https://api.github.com/users/alejobh/followers","following_url":"https://api.github.com/users/alejobh/following{/other_user}","gists_url":"https://api.github.com/users/alejobh/gists{/gist_id}","starred_url":"https://api.github.com/users/alejobh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejobh/subscriptions","organizations_url":"https://api.github.com/users/alejobh/orgs","repos_url":"https://api.github.com/users/alejobh/repos","events_url":"https://api.github.com/users/alejobh/events{/privacy}","received_events_url":"https://api.github.com/users/alejobh/received_events","type":"User","site_admin":false},"body":"## Summary\r\nAdded redux code refactory to Wolox's redux recompose code.\r\nChanged some internal logic of components that needs a Loading state avoiding to re-render everything according to the React's reconcilier philosophy.\r\nChanged some variables and functions names to a better approach.\r\n\r\n## Trello Cards\r\nhttps://trello.com/c/AGtQH4il","created_at":"2018-10-28T02:24:53Z","updated_at":"2018-10-29T12:47:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1f489b789200dcd15b6e9a831d2ad6b77e860700","assignee":{"login":"jmtov","id":3473831,"node_id":"MDQ6VXNlcjM0NzM4MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3473831?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtov","html_url":"https://github.com/jmtov","followers_url":"https://api.github.com/users/jmtov/followers","following_url":"https://api.github.com/users/jmtov/following{/other_user}","gists_url":"https://api.github.com/users/jmtov/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtov/subscriptions","organizations_url":"https://api.github.com/users/jmtov/orgs","repos_url":"https://api.github.com/users/jmtov/repos","events_url":"https://api.github.com/users/jmtov/events{/privacy}","received_events_url":"https://api.github.com/users/jmtov/received_events","type":"User","site_admin":false},"assignees":[{"login":"jmtov","id":3473831,"node_id":"MDQ6VXNlcjM0NzM4MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3473831?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtov","html_url":"https://github.com/jmtov","followers_url":"https://api.github.com/users/jmtov/followers","following_url":"https://api.github.com/users/jmtov/following{/other_user}","gists_url":"https://api.github.com/users/jmtov/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtov/subscriptions","organizations_url":"https://api.github.com/users/jmtov/orgs","repos_url":"https://api.github.com/users/jmtov/repos","events_url":"https://api.github.com/users/jmtov/events{/privacy}","received_events_url":"https://api.github.com/users/jmtov/received_events","type":"User","site_admin":false},{"login":"WFolini","id":12822259,"node_id":"MDQ6VXNlcjEyODIyMjU5","avatar_url":"https://avatars2.githubusercontent.com/u/12822259?v=4","gravatar_id":"","url":"https://api.github.com/users/WFolini","html_url":"https://github.com/WFolini","followers_url":"https://api.github.com/users/WFolini/followers","following_url":"https://api.github.com/users/WFolini/following{/other_user}","gists_url":"https://api.github.com/users/WFolini/gists{/gist_id}","starred_url":"https://api.github.com/users/WFolini/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/WFolini/subscriptions","organizations_url":"https://api.github.com/users/WFolini/orgs","repos_url":"https://api.github.com/users/WFolini/repos","events_url":"https://api.github.com/users/WFolini/events{/privacy}","received_events_url":"https://api.github.com/users/WFolini/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"jmtov","id":3473831,"node_id":"MDQ6VXNlcjM0NzM4MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/3473831?v=4","gravatar_id":"","url":"https://api.github.com/users/jmtov","html_url":"https://github.com/jmtov","followers_url":"https://api.github.com/users/jmtov/followers","following_url":"https://api.github.com/users/jmtov/following{/other_user}","gists_url":"https://api.github.com/users/jmtov/gists{/gist_id}","starred_url":"https://api.github.com/users/jmtov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmtov/subscriptions","organizations_url":"https://api.github.com/users/jmtov/orgs","repos_url":"https://api.github.com/users/jmtov/repos","events_url":"https://api.github.com/users/jmtov/events{/privacy}","received_events_url":"https://api.github.com/users/jmtov/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wolox-training/abh-react/pulls/23/commits","review_comments_url":"https://api.github.com/repos/wolox-training/abh-react/pulls/23/comments","review_comment_url":"https://api.github.com/repos/wolox-training/abh-react/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wolox-training/abh-react/issues/23/comments","statuses_url":"https://api.github.com/repos/wolox-training/abh-react/statuses/3a67ad380d44cca1604b9f4f389cac382c9afbc4","head":{"label":"wolox-training:redux-recompose","ref":"redux-recompose","sha":"3a67ad380d44cca1604b9f4f389cac382c9afbc4","user":{"login":"wolox-training","id":14113351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTEzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/14113351?v=4","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"repo":{"id":149127565,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxMjc1NjU=","name":"abh-react","full_name":"wolox-training/abh-react","private":false,"owner":{"login":"wolox-training","id":14113351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTEzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/14113351?v=4","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wolox-training/abh-react","description":null,"fork":false,"url":"https://api.github.com/repos/wolox-training/abh-react","forks_url":"https://api.github.com/repos/wolox-training/abh-react/forks","keys_url":"https://api.github.com/repos/wolox-training/abh-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolox-training/abh-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolox-training/abh-react/teams","hooks_url":"https://api.github.com/repos/wolox-training/abh-react/hooks","issue_events_url":"https://api.github.com/repos/wolox-training/abh-react/issues/events{/number}","events_url":"https://api.github.com/repos/wolox-training/abh-react/events","assignees_url":"https://api.github.com/repos/wolox-training/abh-react/assignees{/user}","branches_url":"https://api.github.com/repos/wolox-training/abh-react/branches{/branch}","tags_url":"https://api.github.com/repos/wolox-training/abh-react/tags","blobs_url":"https://api.github.com/repos/wolox-training/abh-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolox-training/abh-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolox-training/abh-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolox-training/abh-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolox-training/abh-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wolox-training/abh-react/languages","stargazers_url":"https://api.github.com/repos/wolox-training/abh-react/stargazers","contributors_url":"https://api.github.com/repos/wolox-training/abh-react/contributors","subscribers_url":"https://api.github.com/repos/wolox-training/abh-react/subscribers","subscription_url":"https://api.github.com/repos/wolox-training/abh-react/subscription","commits_url":"https://api.github.com/repos/wolox-training/abh-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolox-training/abh-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolox-training/abh-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolox-training/abh-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolox-training/abh-react/contents/{+path}","compare_url":"https://api.github.com/repos/wolox-training/abh-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolox-training/abh-react/merges","archive_url":"https://api.github.com/repos/wolox-training/abh-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolox-training/abh-react/downloads","issues_url":"https://api.github.com/repos/wolox-training/abh-react/issues{/number}","pulls_url":"https://api.github.com/repos/wolox-training/abh-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wolox-training/abh-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wolox-training/abh-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolox-training/abh-react/labels{/name}","releases_url":"https://api.github.com/repos/wolox-training/abh-react/releases{/id}","deployments_url":"https://api.github.com/repos/wolox-training/abh-react/deployments","created_at":"2018-09-17T13:14:24Z","updated_at":"2018-10-26T21:43:45Z","pushed_at":"2018-10-28T02:24:54Z","git_url":"git://github.com/wolox-training/abh-react.git","ssh_url":"git@github.com:wolox-training/abh-react.git","clone_url":"https://github.com/wolox-training/abh-react.git","svn_url":"https://github.com/wolox-training/abh-react","homepage":null,"size":697,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"wolox-training:master","ref":"master","sha":"a987f3061d8cb927a02976a2a8b254331f94a3ba","user":{"login":"wolox-training","id":14113351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTEzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/14113351?v=4","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"repo":{"id":149127565,"node_id":"MDEwOlJlcG9zaXRvcnkxNDkxMjc1NjU=","name":"abh-react","full_name":"wolox-training/abh-react","private":false,"owner":{"login":"wolox-training","id":14113351,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTEzMzUx","avatar_url":"https://avatars1.githubusercontent.com/u/14113351?v=4","gravatar_id":"","url":"https://api.github.com/users/wolox-training","html_url":"https://github.com/wolox-training","followers_url":"https://api.github.com/users/wolox-training/followers","following_url":"https://api.github.com/users/wolox-training/following{/other_user}","gists_url":"https://api.github.com/users/wolox-training/gists{/gist_id}","starred_url":"https://api.github.com/users/wolox-training/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wolox-training/subscriptions","organizations_url":"https://api.github.com/users/wolox-training/orgs","repos_url":"https://api.github.com/users/wolox-training/repos","events_url":"https://api.github.com/users/wolox-training/events{/privacy}","received_events_url":"https://api.github.com/users/wolox-training/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/wolox-training/abh-react","description":null,"fork":false,"url":"https://api.github.com/repos/wolox-training/abh-react","forks_url":"https://api.github.com/repos/wolox-training/abh-react/forks","keys_url":"https://api.github.com/repos/wolox-training/abh-react/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wolox-training/abh-react/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wolox-training/abh-react/teams","hooks_url":"https://api.github.com/repos/wolox-training/abh-react/hooks","issue_events_url":"https://api.github.com/repos/wolox-training/abh-react/issues/events{/number}","events_url":"https://api.github.com/repos/wolox-training/abh-react/events","assignees_url":"https://api.github.com/repos/wolox-training/abh-react/assignees{/user}","branches_url":"https://api.github.com/repos/wolox-training/abh-react/branches{/branch}","tags_url":"https://api.github.com/repos/wolox-training/abh-react/tags","blobs_url":"https://api.github.com/repos/wolox-training/abh-react/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wolox-training/abh-react/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wolox-training/abh-react/git/refs{/sha}","trees_url":"https://api.github.com/repos/wolox-training/abh-react/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wolox-training/abh-react/statuses/{sha}","languages_url":"https://api.github.com/repos/wolox-training/abh-react/languages","stargazers_url":"https://api.github.com/repos/wolox-training/abh-react/stargazers","contributors_url":"https://api.github.com/repos/wolox-training/abh-react/contributors","subscribers_url":"https://api.github.com/repos/wolox-training/abh-react/subscribers","subscription_url":"https://api.github.com/repos/wolox-training/abh-react/subscription","commits_url":"https://api.github.com/repos/wolox-training/abh-react/commits{/sha}","git_commits_url":"https://api.github.com/repos/wolox-training/abh-react/git/commits{/sha}","comments_url":"https://api.github.com/repos/wolox-training/abh-react/comments{/number}","issue_comment_url":"https://api.github.com/repos/wolox-training/abh-react/issues/comments{/number}","contents_url":"https://api.github.com/repos/wolox-training/abh-react/contents/{+path}","compare_url":"https://api.github.com/repos/wolox-training/abh-react/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wolox-training/abh-react/merges","archive_url":"https://api.github.com/repos/wolox-training/abh-react/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wolox-training/abh-react/downloads","issues_url":"https://api.github.com/repos/wolox-training/abh-react/issues{/number}","pulls_url":"https://api.github.com/repos/wolox-training/abh-react/pulls{/number}","milestones_url":"https://api.github.com/repos/wolox-training/abh-react/milestones{/number}","notifications_url":"https://api.github.com/repos/wolox-training/abh-react/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wolox-training/abh-react/labels{/name}","releases_url":"https://api.github.com/repos/wolox-training/abh-react/releases{/id}","deployments_url":"https://api.github.com/repos/wolox-training/abh-react/deployments","created_at":"2018-09-17T13:14:24Z","updated_at":"2018-10-26T21:43:45Z","pushed_at":"2018-10-28T02:24:54Z","git_url":"git://github.com/wolox-training/abh-react.git","ssh_url":"git@github.com:wolox-training/abh-react.git","clone_url":"https://github.com/wolox-training/abh-react.git","svn_url":"https://github.com/wolox-training/abh-react","homepage":null,"size":697,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wolox-training/abh-react/pulls/23"},"html":{"href":"https://github.com/wolox-training/abh-react/pull/23"},"issue":{"href":"https://api.github.com/repos/wolox-training/abh-react/issues/23"},"comments":{"href":"https://api.github.com/repos/wolox-training/abh-react/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/wolox-training/abh-react/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/wolox-training/abh-react/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wolox-training/abh-react/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/wolox-training/abh-react/statuses/3a67ad380d44cca1604b9f4f389cac382c9afbc4"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"WFolini"}}