{"action":"opened","number":13811,"pull_request":{"url":"https://api.github.com/repos/modxcms/revolution/pulls/13811","id":173995874,"html_url":"https://github.com/modxcms/revolution/pull/13811","diff_url":"https://github.com/modxcms/revolution/pull/13811.diff","patch_url":"https://github.com/modxcms/revolution/pull/13811.patch","issue_url":"https://api.github.com/repos/modxcms/revolution/issues/13811","number":13811,"state":"open","locked":false,"title":"Update media sources","user":{"login":"bezumkin","id":1257284,"avatar_url":"https://avatars0.githubusercontent.com/u/1257284?v=4","gravatar_id":"","url":"https://api.github.com/users/bezumkin","html_url":"https://github.com/bezumkin","followers_url":"https://api.github.com/users/bezumkin/followers","following_url":"https://api.github.com/users/bezumkin/following{/other_user}","gists_url":"https://api.github.com/users/bezumkin/gists{/gist_id}","starred_url":"https://api.github.com/users/bezumkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bezumkin/subscriptions","organizations_url":"https://api.github.com/users/bezumkin/orgs","repos_url":"https://api.github.com/users/bezumkin/repos","events_url":"https://api.github.com/users/bezumkin/events{/privacy}","received_events_url":"https://api.github.com/users/bezumkin/received_events","type":"User","site_admin":false},"body":"I tried to add a new media source after implementing Flysystem and run into some troubles with new \"visibility\" feature.\r\n\r\nI was a little carried away, when I tried to fix it, sorry.\r\n\r\n### What does it do?\r\n- Refactored modMediaSource\r\n- Refactored modS3MediaSource\r\n- Media sources are no longer require modFileHandler\r\n- Added modFtpMedia source (because its adapter is installed by default anyway)\r\n- Replaced \"chmod\" files to FlySystem \"visibility\". Each media source can support it for files and directories separately.\r\n- Removed processor \"directory/browser/chmod\"\r\n- Refactored \"browser/file/unpack\" processor.\r\n- \"Unpack\" menu item displayed only for local media sources.\r\n- Added new ExtJS xtype \"modx-combo-visibility\"\r\n- Added ability to return and display error on ExtJS tree load.\r\n- English lexicons \"file\" and \"source\" was edited, according to changes.\r\n- Fixed every founded error.\r\n\r\n### Why is it needed?\r\nTo fix errors in current media source implementation and provide an ability to add new types of sources.\r\n\r\n### Related issue(s)/PR(s)\r\n#13709","created_at":"2018-03-09T12:40:55Z","updated_at":"2018-03-09T12:40:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/modxcms/revolution/pulls/13811/commits","review_comments_url":"https://api.github.com/repos/modxcms/revolution/pulls/13811/comments","review_comment_url":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modxcms/revolution/issues/13811/comments","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/e0096adf28f3bd5d0edfff8ac2f608c5058e5b45","head":{"label":"bezumkin:3x-filesystems","ref":"3x-filesystems","sha":"e0096adf28f3bd5d0edfff8ac2f608c5058e5b45","user":{"login":"bezumkin","id":1257284,"avatar_url":"https://avatars0.githubusercontent.com/u/1257284?v=4","gravatar_id":"","url":"https://api.github.com/users/bezumkin","html_url":"https://github.com/bezumkin","followers_url":"https://api.github.com/users/bezumkin/followers","following_url":"https://api.github.com/users/bezumkin/following{/other_user}","gists_url":"https://api.github.com/users/bezumkin/gists{/gist_id}","starred_url":"https://api.github.com/users/bezumkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bezumkin/subscriptions","organizations_url":"https://api.github.com/users/bezumkin/orgs","repos_url":"https://api.github.com/users/bezumkin/repos","events_url":"https://api.github.com/users/bezumkin/events{/privacy}","received_events_url":"https://api.github.com/users/bezumkin/received_events","type":"User","site_admin":false},"repo":{"id":121853927,"name":"revolution","full_name":"bezumkin/revolution","owner":{"login":"bezumkin","id":1257284,"avatar_url":"https://avatars0.githubusercontent.com/u/1257284?v=4","gravatar_id":"","url":"https://api.github.com/users/bezumkin","html_url":"https://github.com/bezumkin","followers_url":"https://api.github.com/users/bezumkin/followers","following_url":"https://api.github.com/users/bezumkin/following{/other_user}","gists_url":"https://api.github.com/users/bezumkin/gists{/gist_id}","starred_url":"https://api.github.com/users/bezumkin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bezumkin/subscriptions","organizations_url":"https://api.github.com/users/bezumkin/orgs","repos_url":"https://api.github.com/users/bezumkin/repos","events_url":"https://api.github.com/users/bezumkin/events{/privacy}","received_events_url":"https://api.github.com/users/bezumkin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bezumkin/revolution","description":"MODX Revolution - Content Management Framework","fork":true,"url":"https://api.github.com/repos/bezumkin/revolution","forks_url":"https://api.github.com/repos/bezumkin/revolution/forks","keys_url":"https://api.github.com/repos/bezumkin/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bezumkin/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bezumkin/revolution/teams","hooks_url":"https://api.github.com/repos/bezumkin/revolution/hooks","issue_events_url":"https://api.github.com/repos/bezumkin/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/bezumkin/revolution/events","assignees_url":"https://api.github.com/repos/bezumkin/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/bezumkin/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/bezumkin/revolution/tags","blobs_url":"https://api.github.com/repos/bezumkin/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bezumkin/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bezumkin/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/bezumkin/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bezumkin/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/bezumkin/revolution/languages","stargazers_url":"https://api.github.com/repos/bezumkin/revolution/stargazers","contributors_url":"https://api.github.com/repos/bezumkin/revolution/contributors","subscribers_url":"https://api.github.com/repos/bezumkin/revolution/subscribers","subscription_url":"https://api.github.com/repos/bezumkin/revolution/subscription","commits_url":"https://api.github.com/repos/bezumkin/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/bezumkin/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/bezumkin/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/bezumkin/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/bezumkin/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/bezumkin/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bezumkin/revolution/merges","archive_url":"https://api.github.com/repos/bezumkin/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bezumkin/revolution/downloads","issues_url":"https://api.github.com/repos/bezumkin/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/bezumkin/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/bezumkin/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/bezumkin/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bezumkin/revolution/labels{/name}","releases_url":"https://api.github.com/repos/bezumkin/revolution/releases{/id}","deployments_url":"https://api.github.com/repos/bezumkin/revolution/deployments","created_at":"2018-02-17T12:34:49Z","updated_at":"2018-02-20T09:29:45Z","pushed_at":"2018-03-09T12:35:02Z","git_url":"git://github.com/bezumkin/revolution.git","ssh_url":"git@github.com:bezumkin/revolution.git","clone_url":"https://github.com/bezumkin/revolution.git","svn_url":"https://github.com/bezumkin/revolution","homepage":"https://modx.com/","size":57869,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":false,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":1,"default_branch":"2.x"}},"base":{"label":"modxcms:3.x","ref":"3.x","sha":"72bd301b8c0aa471b1c27127af22cb611f107597","user":{"login":"modxcms","id":232723,"avatar_url":"https://avatars3.githubusercontent.com/u/232723?v=4","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"repo":{"id":806201,"name":"revolution","full_name":"modxcms/revolution","owner":{"login":"modxcms","id":232723,"avatar_url":"https://avatars3.githubusercontent.com/u/232723?v=4","gravatar_id":"","url":"https://api.github.com/users/modxcms","html_url":"https://github.com/modxcms","followers_url":"https://api.github.com/users/modxcms/followers","following_url":"https://api.github.com/users/modxcms/following{/other_user}","gists_url":"https://api.github.com/users/modxcms/gists{/gist_id}","starred_url":"https://api.github.com/users/modxcms/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modxcms/subscriptions","organizations_url":"https://api.github.com/users/modxcms/orgs","repos_url":"https://api.github.com/users/modxcms/repos","events_url":"https://api.github.com/users/modxcms/events{/privacy}","received_events_url":"https://api.github.com/users/modxcms/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modxcms/revolution","description":"MODX Revolution - Content Management Framework","fork":false,"url":"https://api.github.com/repos/modxcms/revolution","forks_url":"https://api.github.com/repos/modxcms/revolution/forks","keys_url":"https://api.github.com/repos/modxcms/revolution/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modxcms/revolution/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modxcms/revolution/teams","hooks_url":"https://api.github.com/repos/modxcms/revolution/hooks","issue_events_url":"https://api.github.com/repos/modxcms/revolution/issues/events{/number}","events_url":"https://api.github.com/repos/modxcms/revolution/events","assignees_url":"https://api.github.com/repos/modxcms/revolution/assignees{/user}","branches_url":"https://api.github.com/repos/modxcms/revolution/branches{/branch}","tags_url":"https://api.github.com/repos/modxcms/revolution/tags","blobs_url":"https://api.github.com/repos/modxcms/revolution/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modxcms/revolution/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modxcms/revolution/git/refs{/sha}","trees_url":"https://api.github.com/repos/modxcms/revolution/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modxcms/revolution/statuses/{sha}","languages_url":"https://api.github.com/repos/modxcms/revolution/languages","stargazers_url":"https://api.github.com/repos/modxcms/revolution/stargazers","contributors_url":"https://api.github.com/repos/modxcms/revolution/contributors","subscribers_url":"https://api.github.com/repos/modxcms/revolution/subscribers","subscription_url":"https://api.github.com/repos/modxcms/revolution/subscription","commits_url":"https://api.github.com/repos/modxcms/revolution/commits{/sha}","git_commits_url":"https://api.github.com/repos/modxcms/revolution/git/commits{/sha}","comments_url":"https://api.github.com/repos/modxcms/revolution/comments{/number}","issue_comment_url":"https://api.github.com/repos/modxcms/revolution/issues/comments{/number}","contents_url":"https://api.github.com/repos/modxcms/revolution/contents/{+path}","compare_url":"https://api.github.com/repos/modxcms/revolution/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modxcms/revolution/merges","archive_url":"https://api.github.com/repos/modxcms/revolution/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modxcms/revolution/downloads","issues_url":"https://api.github.com/repos/modxcms/revolution/issues{/number}","pulls_url":"https://api.github.com/repos/modxcms/revolution/pulls{/number}","milestones_url":"https://api.github.com/repos/modxcms/revolution/milestones{/number}","notifications_url":"https://api.github.com/repos/modxcms/revolution/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modxcms/revolution/labels{/name}","releases_url":"https://api.github.com/repos/modxcms/revolution/releases{/id}","deployments_url":"https://api.github.com/repos/modxcms/revolution/deployments","created_at":"2010-07-29T21:03:57Z","updated_at":"2018-03-08T09:54:45Z","pushed_at":"2018-03-08T10:26:45Z","git_url":"git://github.com/modxcms/revolution.git","ssh_url":"git@github.com:modxcms/revolution.git","clone_url":"https://github.com/modxcms/revolution.git","svn_url":"https://github.com/modxcms/revolution","homepage":"https://modx.com/","size":57800,"stargazers_count":894,"watchers_count":894,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":477,"mirror_url":null,"archived":false,"open_issues_count":609,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":477,"open_issues":609,"watchers":894,"default_branch":"2.x"}},"_links":{"self":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/13811"},"html":{"href":"https://github.com/modxcms/revolution/pull/13811"},"issue":{"href":"https://api.github.com/repos/modxcms/revolution/issues/13811"},"comments":{"href":"https://api.github.com/repos/modxcms/revolution/issues/13811/comments"},"review_comments":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/13811/comments"},"review_comment":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modxcms/revolution/pulls/13811/commits"},"statuses":{"href":"https://api.github.com/repos/modxcms/revolution/statuses/e0096adf28f3bd5d0edfff8ac2f608c5058e5b45"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":1557,"deletions":950,"changed_files":30}}
{"actor":{"display_login":"bezumkin"}}