{"push_id":2897808939,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"7897f9d5beff624590d2fc254d2a7eca6e2b1e8f","before":"eb68211270c6deb66eb928799a75e6af3b8db1b0","commits":[{"sha":"7897f9d5beff624590d2fc254d2a7eca6e2b1e8f","author":{"name":"jugglinmike","email":"a17fed27eaa842282862ff7c1b9c8395a26ac320@mikepennisi.com"},"message":"[service-workers] Return value in cleanup (#13163)\n\nPreviously, many tests un-registered service workers using the\r\ntestharness.js API `add_cleanup` without returning the promise which\r\ntracked the operation. While this ensured the operation was started at\r\nthe completion of the test, it did not guarantee that the operation\r\nwould be completed before the test was considered \"complete.\"\r\n\r\nIn automation scenarios where many tests are executed in rapid\r\nsuccession, this enabled a race condition: the navigation could\r\ninterrupt the un-registration process. In order to account for the\r\npossibility of registrations that persisted from previous test failures,\r\nthe tests included \"setup\" code to defensively un-register such workers.\r\n\r\nThe `Test#add_cleanup` method was recently extended to support\r\nasynchronous \"clean up\" operations [1]. Use that API to ensure tests are\r\nnot considered \"complete\" until after service worker un-registration is\r\ndone.\r\n\r\n[1] https://github.com/web-platform-tests/wpt/pull/8748","distinct":true,"url":"https://api.github.com/repos/web-platform-tests/wpt/commits/7897f9d5beff624590d2fc254d2a7eca6e2b1e8f"}]}
{"actor":{"display_login":"mkruisselbrink"}}