{"action":"opened","number":23964,"pull_request":{"url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23964","id":175630931,"html_url":"https://github.com/cockroachdb/cockroach/pull/23964","diff_url":"https://github.com/cockroachdb/cockroach/pull/23964.diff","patch_url":"https://github.com/cockroachdb/cockroach/pull/23964.patch","issue_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23964","number":23964,"state":"open","locked":false,"title":"sql: Modify sql_bench to work with new optimizer","user":{"login":"andy-kimball","id":32096062,"avatar_url":"https://avatars0.githubusercontent.com/u/32096062?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-kimball","html_url":"https://github.com/andy-kimball","followers_url":"https://api.github.com/users/andy-kimball/followers","following_url":"https://api.github.com/users/andy-kimball/following{/other_user}","gists_url":"https://api.github.com/users/andy-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-kimball/subscriptions","organizations_url":"https://api.github.com/users/andy-kimball/orgs","repos_url":"https://api.github.com/users/andy-kimball/repos","events_url":"https://api.github.com/users/andy-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/andy-kimball/received_events","type":"User","site_admin":false},"body":"There were a couple issues with sql_bench that were preventing some\r\nof the benchmarks from running against the new optimizer:\r\n\r\n1. The OrderBy benchmark was sorting on columns which shouldn't exist\r\n   when DISTINCT is present. Cockroach (probably mistakenly) allows\r\n   this, but Postgres and other SQL implementations do not. This PR\r\n   just adds the additional needed columns.\r\n\r\n2. The Planning and IndexJoin benchmarks were not running against\r\n   other db configurations. This PR changes it to use ForEachDB like\r\n   the other benchmarks do.\r\n\r\nRelease note: None","created_at":"2018-03-16T19:53:25Z","updated_at":"2018-03-16T19:53:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23964/commits","review_comments_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23964/comments","review_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/23964/comments","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/f22c67458f0347b7eac1fecb9ea1b2dd185af8ee","head":{"label":"andy-kimball:bench","ref":"bench","sha":"f22c67458f0347b7eac1fecb9ea1b2dd185af8ee","user":{"login":"andy-kimball","id":32096062,"avatar_url":"https://avatars0.githubusercontent.com/u/32096062?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-kimball","html_url":"https://github.com/andy-kimball","followers_url":"https://api.github.com/users/andy-kimball/followers","following_url":"https://api.github.com/users/andy-kimball/following{/other_user}","gists_url":"https://api.github.com/users/andy-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-kimball/subscriptions","organizations_url":"https://api.github.com/users/andy-kimball/orgs","repos_url":"https://api.github.com/users/andy-kimball/repos","events_url":"https://api.github.com/users/andy-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/andy-kimball/received_events","type":"User","site_admin":false},"repo":{"id":117270021,"name":"cockroach","full_name":"andy-kimball/cockroach","owner":{"login":"andy-kimball","id":32096062,"avatar_url":"https://avatars0.githubusercontent.com/u/32096062?v=4","gravatar_id":"","url":"https://api.github.com/users/andy-kimball","html_url":"https://github.com/andy-kimball","followers_url":"https://api.github.com/users/andy-kimball/followers","following_url":"https://api.github.com/users/andy-kimball/following{/other_user}","gists_url":"https://api.github.com/users/andy-kimball/gists{/gist_id}","starred_url":"https://api.github.com/users/andy-kimball/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andy-kimball/subscriptions","organizations_url":"https://api.github.com/users/andy-kimball/orgs","repos_url":"https://api.github.com/users/andy-kimball/repos","events_url":"https://api.github.com/users/andy-kimball/events{/privacy}","received_events_url":"https://api.github.com/users/andy-kimball/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andy-kimball/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":true,"url":"https://api.github.com/repos/andy-kimball/cockroach","forks_url":"https://api.github.com/repos/andy-kimball/cockroach/forks","keys_url":"https://api.github.com/repos/andy-kimball/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andy-kimball/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andy-kimball/cockroach/teams","hooks_url":"https://api.github.com/repos/andy-kimball/cockroach/hooks","issue_events_url":"https://api.github.com/repos/andy-kimball/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/andy-kimball/cockroach/events","assignees_url":"https://api.github.com/repos/andy-kimball/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/andy-kimball/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/andy-kimball/cockroach/tags","blobs_url":"https://api.github.com/repos/andy-kimball/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andy-kimball/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andy-kimball/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/andy-kimball/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andy-kimball/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/andy-kimball/cockroach/languages","stargazers_url":"https://api.github.com/repos/andy-kimball/cockroach/stargazers","contributors_url":"https://api.github.com/repos/andy-kimball/cockroach/contributors","subscribers_url":"https://api.github.com/repos/andy-kimball/cockroach/subscribers","subscription_url":"https://api.github.com/repos/andy-kimball/cockroach/subscription","commits_url":"https://api.github.com/repos/andy-kimball/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/andy-kimball/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/andy-kimball/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/andy-kimball/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/andy-kimball/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/andy-kimball/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andy-kimball/cockroach/merges","archive_url":"https://api.github.com/repos/andy-kimball/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andy-kimball/cockroach/downloads","issues_url":"https://api.github.com/repos/andy-kimball/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/andy-kimball/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/andy-kimball/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/andy-kimball/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andy-kimball/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/andy-kimball/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/andy-kimball/cockroach/deployments","created_at":"2018-01-12T17:35:15Z","updated_at":"2018-01-12T17:35:25Z","pushed_at":"2018-03-16T19:52:46Z","git_url":"git://github.com/andy-kimball/cockroach.git","ssh_url":"git@github.com:andy-kimball/cockroach.git","clone_url":"https://github.com/andy-kimball/cockroach.git","svn_url":"https://github.com/andy-kimball/cockroach","homepage":"https://www.cockroachlabs.com","size":525218,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"cockroachdb:master","ref":"master","sha":"d23c18ad82bb79c26bde98b38365af65af5b7cfb","user":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"repo":{"id":16563587,"name":"cockroach","full_name":"cockroachdb/cockroach","owner":{"login":"cockroachdb","id":6748139,"avatar_url":"https://avatars3.githubusercontent.com/u/6748139?v=4","gravatar_id":"","url":"https://api.github.com/users/cockroachdb","html_url":"https://github.com/cockroachdb","followers_url":"https://api.github.com/users/cockroachdb/followers","following_url":"https://api.github.com/users/cockroachdb/following{/other_user}","gists_url":"https://api.github.com/users/cockroachdb/gists{/gist_id}","starred_url":"https://api.github.com/users/cockroachdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockroachdb/subscriptions","organizations_url":"https://api.github.com/users/cockroachdb/orgs","repos_url":"https://api.github.com/users/cockroachdb/repos","events_url":"https://api.github.com/users/cockroachdb/events{/privacy}","received_events_url":"https://api.github.com/users/cockroachdb/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockroachdb/cockroach","description":"CockroachDB - the open source, cloud-native SQL database.","fork":false,"url":"https://api.github.com/repos/cockroachdb/cockroach","forks_url":"https://api.github.com/repos/cockroachdb/cockroach/forks","keys_url":"https://api.github.com/repos/cockroachdb/cockroach/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockroachdb/cockroach/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockroachdb/cockroach/teams","hooks_url":"https://api.github.com/repos/cockroachdb/cockroach/hooks","issue_events_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/events{/number}","events_url":"https://api.github.com/repos/cockroachdb/cockroach/events","assignees_url":"https://api.github.com/repos/cockroachdb/cockroach/assignees{/user}","branches_url":"https://api.github.com/repos/cockroachdb/cockroach/branches{/branch}","tags_url":"https://api.github.com/repos/cockroachdb/cockroach/tags","blobs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockroachdb/cockroach/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockroachdb/cockroach/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockroachdb/cockroach/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockroachdb/cockroach/statuses/{sha}","languages_url":"https://api.github.com/repos/cockroachdb/cockroach/languages","stargazers_url":"https://api.github.com/repos/cockroachdb/cockroach/stargazers","contributors_url":"https://api.github.com/repos/cockroachdb/cockroach/contributors","subscribers_url":"https://api.github.com/repos/cockroachdb/cockroach/subscribers","subscription_url":"https://api.github.com/repos/cockroachdb/cockroach/subscription","commits_url":"https://api.github.com/repos/cockroachdb/cockroach/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockroachdb/cockroach/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockroachdb/cockroach/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockroachdb/cockroach/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockroachdb/cockroach/contents/{+path}","compare_url":"https://api.github.com/repos/cockroachdb/cockroach/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockroachdb/cockroach/merges","archive_url":"https://api.github.com/repos/cockroachdb/cockroach/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockroachdb/cockroach/downloads","issues_url":"https://api.github.com/repos/cockroachdb/cockroach/issues{/number}","pulls_url":"https://api.github.com/repos/cockroachdb/cockroach/pulls{/number}","milestones_url":"https://api.github.com/repos/cockroachdb/cockroach/milestones{/number}","notifications_url":"https://api.github.com/repos/cockroachdb/cockroach/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockroachdb/cockroach/labels{/name}","releases_url":"https://api.github.com/repos/cockroachdb/cockroach/releases{/id}","deployments_url":"https://api.github.com/repos/cockroachdb/cockroach/deployments","created_at":"2014-02-06T00:18:47Z","updated_at":"2018-03-16T19:02:48Z","pushed_at":"2018-03-16T19:06:00Z","git_url":"git://github.com/cockroachdb/cockroach.git","ssh_url":"git@github.com:cockroachdb/cockroach.git","clone_url":"https://github.com/cockroachdb/cockroach.git","svn_url":"https://github.com/cockroachdb/cockroach","homepage":"https://www.cockroachlabs.com","size":973699,"stargazers_count":12811,"watchers_count":12811,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1306,"mirror_url":null,"archived":false,"open_issues_count":1578,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1306,"open_issues":1578,"watchers":12811,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23964"},"html":{"href":"https://github.com/cockroachdb/cockroach/pull/23964"},"issue":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/23964"},"comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/issues/23964/comments"},"review_comments":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23964/comments"},"review_comment":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockroachdb/cockroach/pulls/23964/commits"},"statuses":{"href":"https://api.github.com/repos/cockroachdb/cockroach/statuses/f22c67458f0347b7eac1fecb9ea1b2dd185af8ee"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":51,"deletions":47,"changed_files":1}}
{"actor":{"display_login":"andy-kimball"}}