{"action":"closed","number":25,"pull_request":{"url":"https://api.github.com/repos/freenet/pyFreenet/pulls/25","id":208226949,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4MjI2OTQ5","html_url":"https://github.com/freenet/pyFreenet/pull/25","diff_url":"https://github.com/freenet/pyFreenet/pull/25.diff","patch_url":"https://github.com/freenet/pyFreenet/pull/25.patch","issue_url":"https://api.github.com/repos/freenet/pyFreenet/issues/25","number":25,"state":"closed","locked":false,"title":"Fixing bugs that prevented the -d (--disk) flag from working.","user":{"login":"PeterVerzijl","id":5670225,"node_id":"MDQ6VXNlcjU2NzAyMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5670225?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterVerzijl","html_url":"https://github.com/PeterVerzijl","followers_url":"https://api.github.com/users/PeterVerzijl/followers","following_url":"https://api.github.com/users/PeterVerzijl/following{/other_user}","gists_url":"https://api.github.com/users/PeterVerzijl/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterVerzijl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterVerzijl/subscriptions","organizations_url":"https://api.github.com/users/PeterVerzijl/orgs","repos_url":"https://api.github.com/users/PeterVerzijl/repos","events_url":"https://api.github.com/users/PeterVerzijl/events{/privacy}","received_events_url":"https://api.github.com/users/PeterVerzijl/received_events","type":"User","site_admin":false},"body":"`With(Read/Write)Directory` is not accepted by the node, and gives an error in verbose mode. It thinks that both `Want(Read/Write)Directory` are set to False and asks what to do. Changing the keys to `Want(Read/Write)Directory` fixes this. \r\n\r\nThere is also a loose `TestDDARequest=False` after parsing argument flags. This prevented the DDARequest to be done at all. I figured it was a bug as it also prevents DDA requests from being done even if the `--data` flag is set.\r\n\r\nThere was also a consistency mistake where **T**rue and **f**alse capitalization was used interchangeably.","created_at":"2018-08-14T09:52:42Z","updated_at":"2018-10-25T22:08:21Z","closed_at":"2018-10-25T22:08:21Z","merged_at":"2018-10-25T22:08:21Z","merge_commit_sha":"09118d12df04b21527830334fcbc5490ad225c53","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/freenet/pyFreenet/pulls/25/commits","review_comments_url":"https://api.github.com/repos/freenet/pyFreenet/pulls/25/comments","review_comment_url":"https://api.github.com/repos/freenet/pyFreenet/pulls/comments{/number}","comments_url":"https://api.github.com/repos/freenet/pyFreenet/issues/25/comments","statuses_url":"https://api.github.com/repos/freenet/pyFreenet/statuses/4261a78673ab68725ffa5d85f1ce02fd6106bcda","head":{"label":"PeterVerzijl:master","ref":"master","sha":"4261a78673ab68725ffa5d85f1ce02fd6106bcda","user":{"login":"PeterVerzijl","id":5670225,"node_id":"MDQ6VXNlcjU2NzAyMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5670225?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterVerzijl","html_url":"https://github.com/PeterVerzijl","followers_url":"https://api.github.com/users/PeterVerzijl/followers","following_url":"https://api.github.com/users/PeterVerzijl/following{/other_user}","gists_url":"https://api.github.com/users/PeterVerzijl/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterVerzijl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterVerzijl/subscriptions","organizations_url":"https://api.github.com/users/PeterVerzijl/orgs","repos_url":"https://api.github.com/users/PeterVerzijl/repos","events_url":"https://api.github.com/users/PeterVerzijl/events{/privacy}","received_events_url":"https://api.github.com/users/PeterVerzijl/received_events","type":"User","site_admin":false},"repo":{"id":144699249,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ2OTkyNDk=","name":"pyFreenet","full_name":"PeterVerzijl/pyFreenet","private":false,"owner":{"login":"PeterVerzijl","id":5670225,"node_id":"MDQ6VXNlcjU2NzAyMjU=","avatar_url":"https://avatars1.githubusercontent.com/u/5670225?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterVerzijl","html_url":"https://github.com/PeterVerzijl","followers_url":"https://api.github.com/users/PeterVerzijl/followers","following_url":"https://api.github.com/users/PeterVerzijl/following{/other_user}","gists_url":"https://api.github.com/users/PeterVerzijl/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterVerzijl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterVerzijl/subscriptions","organizations_url":"https://api.github.com/users/PeterVerzijl/orgs","repos_url":"https://api.github.com/users/PeterVerzijl/repos","events_url":"https://api.github.com/users/PeterVerzijl/events{/privacy}","received_events_url":"https://api.github.com/users/PeterVerzijl/received_events","type":"User","site_admin":false},"html_url":"https://github.com/PeterVerzijl/pyFreenet","description":"Python FCPv2 library and utilities","fork":true,"url":"https://api.github.com/repos/PeterVerzijl/pyFreenet","forks_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/forks","keys_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/teams","hooks_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/hooks","issue_events_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/issues/events{/number}","events_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/events","assignees_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/assignees{/user}","branches_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/branches{/branch}","tags_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/tags","blobs_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/statuses/{sha}","languages_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/languages","stargazers_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/stargazers","contributors_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/contributors","subscribers_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/subscribers","subscription_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/subscription","commits_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/contents/{+path}","compare_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/merges","archive_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/downloads","issues_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/issues{/number}","pulls_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/pulls{/number}","milestones_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/milestones{/number}","notifications_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/labels{/name}","releases_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/releases{/id}","deployments_url":"https://api.github.com/repos/PeterVerzijl/pyFreenet/deployments","created_at":"2018-08-14T09:33:29Z","updated_at":"2018-08-14T09:46:39Z","pushed_at":"2018-08-14T09:46:37Z","git_url":"git://github.com/PeterVerzijl/pyFreenet.git","ssh_url":"git@github.com:PeterVerzijl/pyFreenet.git","clone_url":"https://github.com/PeterVerzijl/pyFreenet.git","svn_url":"https://github.com/PeterVerzijl/pyFreenet","homepage":"https://freenetproject.org/","size":1696,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"freenet:master","ref":"master","sha":"a20a8cc0b92740503b8a16d90049f8b1ba4acd2a","user":{"login":"freenet","id":77513,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NTEz","avatar_url":"https://avatars0.githubusercontent.com/u/77513?v=4","gravatar_id":"","url":"https://api.github.com/users/freenet","html_url":"https://github.com/freenet","followers_url":"https://api.github.com/users/freenet/followers","following_url":"https://api.github.com/users/freenet/following{/other_user}","gists_url":"https://api.github.com/users/freenet/gists{/gist_id}","starred_url":"https://api.github.com/users/freenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenet/subscriptions","organizations_url":"https://api.github.com/users/freenet/orgs","repos_url":"https://api.github.com/users/freenet/repos","events_url":"https://api.github.com/users/freenet/events{/privacy}","received_events_url":"https://api.github.com/users/freenet/received_events","type":"Organization","site_admin":false},"repo":{"id":185386,"node_id":"MDEwOlJlcG9zaXRvcnkxODUzODY=","name":"pyFreenet","full_name":"freenet/pyFreenet","private":false,"owner":{"login":"freenet","id":77513,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc3NTEz","avatar_url":"https://avatars0.githubusercontent.com/u/77513?v=4","gravatar_id":"","url":"https://api.github.com/users/freenet","html_url":"https://github.com/freenet","followers_url":"https://api.github.com/users/freenet/followers","following_url":"https://api.github.com/users/freenet/following{/other_user}","gists_url":"https://api.github.com/users/freenet/gists{/gist_id}","starred_url":"https://api.github.com/users/freenet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/freenet/subscriptions","organizations_url":"https://api.github.com/users/freenet/orgs","repos_url":"https://api.github.com/users/freenet/repos","events_url":"https://api.github.com/users/freenet/events{/privacy}","received_events_url":"https://api.github.com/users/freenet/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/freenet/pyFreenet","description":"Python FCPv2 library and utilities","fork":false,"url":"https://api.github.com/repos/freenet/pyFreenet","forks_url":"https://api.github.com/repos/freenet/pyFreenet/forks","keys_url":"https://api.github.com/repos/freenet/pyFreenet/keys{/key_id}","collaborators_url":"https://api.github.com/repos/freenet/pyFreenet/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/freenet/pyFreenet/teams","hooks_url":"https://api.github.com/repos/freenet/pyFreenet/hooks","issue_events_url":"https://api.github.com/repos/freenet/pyFreenet/issues/events{/number}","events_url":"https://api.github.com/repos/freenet/pyFreenet/events","assignees_url":"https://api.github.com/repos/freenet/pyFreenet/assignees{/user}","branches_url":"https://api.github.com/repos/freenet/pyFreenet/branches{/branch}","tags_url":"https://api.github.com/repos/freenet/pyFreenet/tags","blobs_url":"https://api.github.com/repos/freenet/pyFreenet/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/freenet/pyFreenet/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/freenet/pyFreenet/git/refs{/sha}","trees_url":"https://api.github.com/repos/freenet/pyFreenet/git/trees{/sha}","statuses_url":"https://api.github.com/repos/freenet/pyFreenet/statuses/{sha}","languages_url":"https://api.github.com/repos/freenet/pyFreenet/languages","stargazers_url":"https://api.github.com/repos/freenet/pyFreenet/stargazers","contributors_url":"https://api.github.com/repos/freenet/pyFreenet/contributors","subscribers_url":"https://api.github.com/repos/freenet/pyFreenet/subscribers","subscription_url":"https://api.github.com/repos/freenet/pyFreenet/subscription","commits_url":"https://api.github.com/repos/freenet/pyFreenet/commits{/sha}","git_commits_url":"https://api.github.com/repos/freenet/pyFreenet/git/commits{/sha}","comments_url":"https://api.github.com/repos/freenet/pyFreenet/comments{/number}","issue_comment_url":"https://api.github.com/repos/freenet/pyFreenet/issues/comments{/number}","contents_url":"https://api.github.com/repos/freenet/pyFreenet/contents/{+path}","compare_url":"https://api.github.com/repos/freenet/pyFreenet/compare/{base}...{head}","merges_url":"https://api.github.com/repos/freenet/pyFreenet/merges","archive_url":"https://api.github.com/repos/freenet/pyFreenet/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/freenet/pyFreenet/downloads","issues_url":"https://api.github.com/repos/freenet/pyFreenet/issues{/number}","pulls_url":"https://api.github.com/repos/freenet/pyFreenet/pulls{/number}","milestones_url":"https://api.github.com/repos/freenet/pyFreenet/milestones{/number}","notifications_url":"https://api.github.com/repos/freenet/pyFreenet/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/freenet/pyFreenet/labels{/name}","releases_url":"https://api.github.com/repos/freenet/pyFreenet/releases{/id}","deployments_url":"https://api.github.com/repos/freenet/pyFreenet/deployments","created_at":"2009-04-25T14:03:03Z","updated_at":"2018-10-22T14:32:00Z","pushed_at":"2018-10-25T22:08:21Z","git_url":"git://github.com/freenet/pyFreenet.git","ssh_url":"git@github.com:freenet/pyFreenet.git","clone_url":"https://github.com/freenet/pyFreenet.git","svn_url":"https://github.com/freenet/pyFreenet","homepage":"https://freenetproject.org/","size":1702,"stargazers_count":38,"watchers_count":38,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":18,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":18,"open_issues":7,"watchers":38,"default_branch":"py3"}},"_links":{"self":{"href":"https://api.github.com/repos/freenet/pyFreenet/pulls/25"},"html":{"href":"https://github.com/freenet/pyFreenet/pull/25"},"issue":{"href":"https://api.github.com/repos/freenet/pyFreenet/issues/25"},"comments":{"href":"https://api.github.com/repos/freenet/pyFreenet/issues/25/comments"},"review_comments":{"href":"https://api.github.com/repos/freenet/pyFreenet/pulls/25/comments"},"review_comment":{"href":"https://api.github.com/repos/freenet/pyFreenet/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/freenet/pyFreenet/pulls/25/commits"},"statuses":{"href":"https://api.github.com/repos/freenet/pyFreenet/statuses/4261a78673ab68725ffa5d85f1ce02fd6106bcda"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ArneBab","id":96777,"node_id":"MDQ6VXNlcjk2Nzc3","avatar_url":"https://avatars0.githubusercontent.com/u/96777?v=4","gravatar_id":"","url":"https://api.github.com/users/ArneBab","html_url":"https://github.com/ArneBab","followers_url":"https://api.github.com/users/ArneBab/followers","following_url":"https://api.github.com/users/ArneBab/following{/other_user}","gists_url":"https://api.github.com/users/ArneBab/gists{/gist_id}","starred_url":"https://api.github.com/users/ArneBab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArneBab/subscriptions","organizations_url":"https://api.github.com/users/ArneBab/orgs","repos_url":"https://api.github.com/users/ArneBab/repos","events_url":"https://api.github.com/users/ArneBab/events{/privacy}","received_events_url":"https://api.github.com/users/ArneBab/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":5,"deletions":8,"changed_files":3}}
{"actor":{"display_login":"ArneBab"}}