{"action":"created","comment":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/165277244","pull_request_review_id":93186924,"id":165277244,"diff_hunk":"@@ -270,6 +272,23 @@ public void setPriorityLevel(int priorityLevel) {\n         this.priorityLevel = priorityLevel;\n     }\n \n+    public boolean getReadCompacted() {\n+        return readCompacted;\n+    }\n+\n+    /**\n+     * If enabled, the consumer will read messages from the compacted topic rather than reading the full message\n+     * backlog of the topic. This means that, if the topic has been compacted, the consumer will only see the latest\n+     * value for each key in the topic, up until the point in the topic message backlog that has been compacted.\n+     * Beyond that point, the messages will be sent as normal.\n+     *\n+     * @param readCompacted whether to read from the compacted topic\n+     */\n+    public ConsumerConfiguration setReadCompacted(boolean readCompacted) {","path":"pulsar-client/src/main/java/org/apache/pulsar/client/api/ConsumerConfiguration.java","position":25,"original_position":25,"commit_id":"303876daa72aaf3fa8a42aced847d4d12f572c94","original_commit_id":"303876daa72aaf3fa8a42aced847d4d12f572c94","user":{"login":"sijie","id":1217863,"avatar_url":"https://avatars2.githubusercontent.com/u/1217863?v=4","gravatar_id":"","url":"https://api.github.com/users/sijie","html_url":"https://github.com/sijie","followers_url":"https://api.github.com/users/sijie/followers","following_url":"https://api.github.com/users/sijie/following{/other_user}","gists_url":"https://api.github.com/users/sijie/gists{/gist_id}","starred_url":"https://api.github.com/users/sijie/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sijie/subscriptions","organizations_url":"https://api.github.com/users/sijie/orgs","repos_url":"https://api.github.com/users/sijie/repos","events_url":"https://api.github.com/users/sijie/events{/privacy}","received_events_url":"https://api.github.com/users/sijie/received_events","type":"User","site_admin":false},"body":"\r\n\r\nif this is controlled at the consumer side (not at subscription level), how does it work (or what application would expect) for shared subscription vs failover subscription?","created_at":"2018-02-01T07:34:26Z","updated_at":"2018-02-01T07:34:26Z","html_url":"https://github.com/apache/incubator-pulsar/pull/1136#discussion_r165277244","pull_request_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1136","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments/165277244"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/1136#discussion_r165277244"},"pull_request":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1136"}}},"pull_request":{"url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1136","id":165814925,"html_url":"https://github.com/apache/incubator-pulsar/pull/1136","diff_url":"https://github.com/apache/incubator-pulsar/pull/1136.diff","patch_url":"https://github.com/apache/incubator-pulsar/pull/1136.patch","issue_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/1136","number":1136,"state":"open","locked":false,"title":"Read compacted consumer flag","user":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"body":"When enabled, a consumer will read messages from a compacted topic\r\nledger if available. When disabled, the consumer will read from the\r\nmessage backlog as before, even if the topic has been compacted.\r\n\r\nThe logic for actually reading from the compacted topic will be\r\nsubmitted in following patch.\r\n","created_at":"2018-01-29T20:54:23Z","updated_at":"2018-02-01T07:34:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d681f1840fc7b4a74bd369cf5b76c096d48ac57","assignee":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"assignees":[{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":{"url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/12","html_url":"https://github.com/apache/incubator-pulsar/milestone/12","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones/12/labels","id":2870587,"number":12,"title":"2.0.0-incubating","description":"","creator":{"login":"merlimat","id":62500,"avatar_url":"https://avatars2.githubusercontent.com/u/62500?v=4","gravatar_id":"","url":"https://api.github.com/users/merlimat","html_url":"https://github.com/merlimat","followers_url":"https://api.github.com/users/merlimat/followers","following_url":"https://api.github.com/users/merlimat/following{/other_user}","gists_url":"https://api.github.com/users/merlimat/gists{/gist_id}","starred_url":"https://api.github.com/users/merlimat/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/merlimat/subscriptions","organizations_url":"https://api.github.com/users/merlimat/orgs","repos_url":"https://api.github.com/users/merlimat/repos","events_url":"https://api.github.com/users/merlimat/events{/privacy}","received_events_url":"https://api.github.com/users/merlimat/received_events","type":"User","site_admin":false},"open_issues":20,"closed_issues":2,"state":"open","created_at":"2017-10-27T18:58:50Z","updated_at":"2018-01-31T19:42:47Z","due_on":"2018-02-28T08:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1136/commits","review_comments_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1136/comments","review_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/1136/comments","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/303876daa72aaf3fa8a42aced847d4d12f572c94","head":{"label":"ivankelly:compact-flag","ref":"compact-flag","sha":"303876daa72aaf3fa8a42aced847d4d12f572c94","user":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"repo":{"id":110581105,"name":"incubator-pulsar","full_name":"ivankelly/incubator-pulsar","owner":{"login":"ivankelly","id":54955,"avatar_url":"https://avatars3.githubusercontent.com/u/54955?v=4","gravatar_id":"","url":"https://api.github.com/users/ivankelly","html_url":"https://github.com/ivankelly","followers_url":"https://api.github.com/users/ivankelly/followers","following_url":"https://api.github.com/users/ivankelly/following{/other_user}","gists_url":"https://api.github.com/users/ivankelly/gists{/gist_id}","starred_url":"https://api.github.com/users/ivankelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ivankelly/subscriptions","organizations_url":"https://api.github.com/users/ivankelly/orgs","repos_url":"https://api.github.com/users/ivankelly/repos","events_url":"https://api.github.com/users/ivankelly/events{/privacy}","received_events_url":"https://api.github.com/users/ivankelly/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ivankelly/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":true,"url":"https://api.github.com/repos/ivankelly/incubator-pulsar","forks_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/ivankelly/incubator-pulsar/deployments","created_at":"2017-11-13T17:46:25Z","updated_at":"2017-11-13T17:46:31Z","pushed_at":"2018-01-31T23:47:32Z","git_url":"git://github.com/ivankelly/incubator-pulsar.git","ssh_url":"git@github.com:ivankelly/incubator-pulsar.git","clone_url":"https://github.com/ivankelly/incubator-pulsar.git","svn_url":"https://github.com/ivankelly/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":17544,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"e82be833c04c9e7325dfe5d86eda4d5dc375f9eb","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":62117812,"name":"incubator-pulsar","full_name":"apache/incubator-pulsar","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/incubator-pulsar","description":"Pulsar - distributed pub-sub messaging system","fork":false,"url":"https://api.github.com/repos/apache/incubator-pulsar","forks_url":"https://api.github.com/repos/apache/incubator-pulsar/forks","keys_url":"https://api.github.com/repos/apache/incubator-pulsar/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/incubator-pulsar/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/incubator-pulsar/teams","hooks_url":"https://api.github.com/repos/apache/incubator-pulsar/hooks","issue_events_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/events{/number}","events_url":"https://api.github.com/repos/apache/incubator-pulsar/events","assignees_url":"https://api.github.com/repos/apache/incubator-pulsar/assignees{/user}","branches_url":"https://api.github.com/repos/apache/incubator-pulsar/branches{/branch}","tags_url":"https://api.github.com/repos/apache/incubator-pulsar/tags","blobs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/incubator-pulsar/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/incubator-pulsar/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/incubator-pulsar/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/incubator-pulsar/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/incubator-pulsar/languages","stargazers_url":"https://api.github.com/repos/apache/incubator-pulsar/stargazers","contributors_url":"https://api.github.com/repos/apache/incubator-pulsar/contributors","subscribers_url":"https://api.github.com/repos/apache/incubator-pulsar/subscribers","subscription_url":"https://api.github.com/repos/apache/incubator-pulsar/subscription","commits_url":"https://api.github.com/repos/apache/incubator-pulsar/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/incubator-pulsar/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/incubator-pulsar/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/incubator-pulsar/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/incubator-pulsar/contents/{+path}","compare_url":"https://api.github.com/repos/apache/incubator-pulsar/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/incubator-pulsar/merges","archive_url":"https://api.github.com/repos/apache/incubator-pulsar/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/incubator-pulsar/downloads","issues_url":"https://api.github.com/repos/apache/incubator-pulsar/issues{/number}","pulls_url":"https://api.github.com/repos/apache/incubator-pulsar/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/incubator-pulsar/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/incubator-pulsar/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/incubator-pulsar/labels{/name}","releases_url":"https://api.github.com/repos/apache/incubator-pulsar/releases{/id}","deployments_url":"https://api.github.com/repos/apache/incubator-pulsar/deployments","created_at":"2016-06-28T07:00:03Z","updated_at":"2018-02-01T07:21:49Z","pushed_at":"2018-02-01T06:54:51Z","git_url":"git://github.com/apache/incubator-pulsar.git","ssh_url":"git@github.com:apache/incubator-pulsar.git","clone_url":"https://github.com/apache/incubator-pulsar.git","svn_url":"https://github.com/apache/incubator-pulsar","homepage":"https://pulsar.incubator.apache.org","size":19044,"stargazers_count":1549,"watchers_count":1549,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":316,"mirror_url":null,"archived":false,"open_issues_count":171,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":316,"open_issues":171,"watchers":1549,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1136"},"html":{"href":"https://github.com/apache/incubator-pulsar/pull/1136"},"issue":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/1136"},"comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/issues/1136/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1136/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/incubator-pulsar/pulls/1136/commits"},"statuses":{"href":"https://api.github.com/repos/apache/incubator-pulsar/statuses/303876daa72aaf3fa8a42aced847d4d12f572c94"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sijie"}}