{"action":"opened","number":973,"pull_request":{"url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/973","id":194546725,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTQ2NzI1","html_url":"https://github.com/input-output-hk/daedalus/pull/973","diff_url":"https://github.com/input-output-hk/daedalus/pull/973.diff","patch_url":"https://github.com/input-output-hk/daedalus/pull/973.patch","issue_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/973","number":973,"state":"open","locked":false,"title":"[DDW-317] Font display improvements","user":{"login":"nikolaglumac","id":376611,"node_id":"MDQ6VXNlcjM3NjYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/376611?v=4","gravatar_id":"","url":"https://api.github.com/users/nikolaglumac","html_url":"https://github.com/nikolaglumac","followers_url":"https://api.github.com/users/nikolaglumac/followers","following_url":"https://api.github.com/users/nikolaglumac/following{/other_user}","gists_url":"https://api.github.com/users/nikolaglumac/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolaglumac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolaglumac/subscriptions","organizations_url":"https://api.github.com/users/nikolaglumac/orgs","repos_url":"https://api.github.com/users/nikolaglumac/repos","events_url":"https://api.github.com/users/nikolaglumac/events{/privacy}","received_events_url":"https://api.github.com/users/nikolaglumac/received_events","type":"User","site_admin":false},"body":"This PR improves text display by reducing letter-spacing.\r\n\r\nSince a new NotoSans font was introduced we need to slightly modify the letter-spacing in order to make the new font look more compact and to save space.\r\nWe need to do the following:\r\n- remove global body CSS letter-spacing: 1px rule\r\n- change Dialog title CSS letter-spacing from 2px to 1px\r\n- add word-spacing: 2px to Mnemonics box on both Wallet create and Paper wallet create dialogs\r\n\r\n## Screenshots:\r\n\r\n### Old\r\n![screen shot 2018-06-13 at 12 44 47](https://user-images.githubusercontent.com/376611/41347102-efaeccce-6f08-11e8-9de3-743f6fd37886.png)\r\n\r\n### New\r\n![screen shot 2018-06-13 at 12 51 59](https://user-images.githubusercontent.com/376611/41347106-f1b4e03a-6f08-11e8-93a7-2fc5aa32e52c.png)\r\n\r\n### Old\r\n![screen shot 2018-06-13 at 12 44 52](https://user-images.githubusercontent.com/376611/41347111-f3dbd116-6f08-11e8-82f0-65b7f260516b.png)\r\n\r\n### New\r\n![screen shot 2018-06-13 at 12 52 10](https://user-images.githubusercontent.com/376611/41347116-f738a4a6-6f08-11e8-9d36-10f8fdb451da.png)\r\n\r\n### Old\r\n![screen shot 2018-06-13 at 12 44 58](https://user-images.githubusercontent.com/376611/41347120-fd424a6e-6f08-11e8-9f65-2e42ba38a942.png)\r\n\r\n### New\r\n![screen shot 2018-06-13 at 12 52 20](https://user-images.githubusercontent.com/376611/41347133-03ad11fe-6f09-11e8-8051-7a6ec6225287.png)\r\n\r\n### Old\r\n![screen shot 2018-06-13 at 12 45 04](https://user-images.githubusercontent.com/376611/41347141-08bde7f4-6f09-11e8-8c5a-910600913831.png)\r\n\r\n### New\r\n![screen shot 2018-06-13 at 12 52 26](https://user-images.githubusercontent.com/376611/41347146-0bbb8f9c-6f09-11e8-9ec4-e68cfd0b94eb.png)\r\n\r\n---\r\n\r\n## Review Checklist:\r\n\r\n### Basics\r\n\r\n- [ ] PR is updated to the most recent version of target branch (and there are no conflicts)\r\n- [ ] PR has good description that summarizes all changes and shows some screenshots or animated GIFs of important UI changes\r\n- [ ] CHANGELOG entry has been added and is linked to the correct PR on GitHub\r\n- [ ] Automated tests: All acceptance tests are passing (`npm run test`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *development* build (`npm run dev`)\r\n- [ ] Manual tests (minimum tests should cover newly added feature/fix): App works correctly in *production* build (`npm run package` / CI builds)\r\n- [ ] There are no *flow* errors or warnings (`npm run flow:test`)\r\n- [ ] There are no *lint* errors or warnings (`npm run lint`)\r\n- [ ] Text changes are proofread and approved (Jane Wild)\r\n- [ ] There are no missing translations (running `npm run manage:translations` produces no changes)\r\n- [ ] UI changes look good in all themes (Alexander Rukin)\r\n- [ ] Storybook works and no stories are broken (`npm run storybook`)\r\n- [ ] In case of npm dependency changes both `package-lock.json` and `yarn.lock` files are updated\r\n\r\n### Code Quality\r\n- [ ] Important parts of the code are properly documented and commented\r\n- [ ] Code is properly typed with flow\r\n- [ ] React components are split-up enough to avoid unnecessary re-rendering\r\n- [ ] Any code that only works in Electron is neatly separated from components\r\n\r\n### Testing\r\n- [ ] New feature / change is covered by acceptance tests\r\n- [ ] All existing acceptance tests are still up-to-date\r\n- [ ] New feature / change is covered by Daedalus Testing scenario\r\n- [ ] All existing Daedalus Testing scenarios are still up-to-date\r\n\r\n### After Review:\r\n- [ ] Merge PR\r\n- [ ] Delete source branch\r\n- [ ] Move ticket to `done` on the Youtrack board\r\n","created_at":"2018-06-13T10:55:49Z","updated_at":"2018-06-13T10:55:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":{"login":"nikolaglumac","id":376611,"node_id":"MDQ6VXNlcjM3NjYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/376611?v=4","gravatar_id":"","url":"https://api.github.com/users/nikolaglumac","html_url":"https://github.com/nikolaglumac","followers_url":"https://api.github.com/users/nikolaglumac/followers","following_url":"https://api.github.com/users/nikolaglumac/following{/other_user}","gists_url":"https://api.github.com/users/nikolaglumac/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolaglumac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolaglumac/subscriptions","organizations_url":"https://api.github.com/users/nikolaglumac/orgs","repos_url":"https://api.github.com/users/nikolaglumac/repos","events_url":"https://api.github.com/users/nikolaglumac/events{/privacy}","received_events_url":"https://api.github.com/users/nikolaglumac/received_events","type":"User","site_admin":false},"assignees":[{"login":"nikolaglumac","id":376611,"node_id":"MDQ6VXNlcjM3NjYxMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/376611?v=4","gravatar_id":"","url":"https://api.github.com/users/nikolaglumac","html_url":"https://github.com/nikolaglumac","followers_url":"https://api.github.com/users/nikolaglumac/followers","following_url":"https://api.github.com/users/nikolaglumac/following{/other_user}","gists_url":"https://api.github.com/users/nikolaglumac/gists{/gist_id}","starred_url":"https://api.github.com/users/nikolaglumac/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nikolaglumac/subscriptions","organizations_url":"https://api.github.com/users/nikolaglumac/orgs","repos_url":"https://api.github.com/users/nikolaglumac/repos","events_url":"https://api.github.com/users/nikolaglumac/events{/privacy}","received_events_url":"https://api.github.com/users/nikolaglumac/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":570282890,"node_id":"MDU6TGFiZWw1NzAyODI4OTA=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/chore","name":"chore","color":"5f5f5f","default":false},{"id":962482865,"node_id":"MDU6TGFiZWw5NjI0ODI4NjU=","url":"https://api.github.com/repos/input-output-hk/daedalus/labels/release-0.11.0","name":"release-0.11.0","color":"a6e2ed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/973/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/973/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/973/comments","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/62972561e3212d087833fceacbc820377766038b","head":{"label":"input-output-hk:chore/ddw-317-font-display-improvements","ref":"chore/ddw-317-font-display-improvements","sha":"62972561e3212d087833fceacbc820377766038b","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70064828,"node_id":"MDEwOlJlcG9zaXRvcnk3MDA2NDgyOA==","name":"daedalus","full_name":"input-output-hk/daedalus","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/daedalus","description":"Daedalus - cryptocurrency wallet","fork":false,"url":"https://api.github.com/repos/input-output-hk/daedalus","forks_url":"https://api.github.com/repos/input-output-hk/daedalus/forks","keys_url":"https://api.github.com/repos/input-output-hk/daedalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/daedalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/daedalus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/daedalus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/daedalus/events","assignees_url":"https://api.github.com/repos/input-output-hk/daedalus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/daedalus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/daedalus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/daedalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/daedalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/daedalus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/daedalus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/daedalus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/daedalus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/daedalus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/daedalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/daedalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/daedalus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/daedalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/daedalus/merges","archive_url":"https://api.github.com/repos/input-output-hk/daedalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/daedalus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/daedalus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/daedalus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/daedalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/daedalus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/daedalus/deployments","created_at":"2016-10-05T13:48:54Z","updated_at":"2018-06-13T09:46:45Z","pushed_at":"2018-06-13T10:53:16Z","git_url":"git://github.com/input-output-hk/daedalus.git","ssh_url":"git@github.com:input-output-hk/daedalus.git","clone_url":"https://github.com/input-output-hk/daedalus.git","svn_url":"https://github.com/input-output-hk/daedalus","homepage":null,"size":124543,"stargazers_count":446,"watchers_count":446,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":141,"open_issues":108,"watchers":446,"default_branch":"develop"}},"base":{"label":"input-output-hk:develop","ref":"develop","sha":"daa5e32c63877585b15c7b614c9c75ea4a3e58ee","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":70064828,"node_id":"MDEwOlJlcG9zaXRvcnk3MDA2NDgyOA==","name":"daedalus","full_name":"input-output-hk/daedalus","owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/input-output-hk/daedalus","description":"Daedalus - cryptocurrency wallet","fork":false,"url":"https://api.github.com/repos/input-output-hk/daedalus","forks_url":"https://api.github.com/repos/input-output-hk/daedalus/forks","keys_url":"https://api.github.com/repos/input-output-hk/daedalus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/daedalus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/daedalus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/daedalus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/daedalus/events","assignees_url":"https://api.github.com/repos/input-output-hk/daedalus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/daedalus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/daedalus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/daedalus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/daedalus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/daedalus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/daedalus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/daedalus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/daedalus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/daedalus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/daedalus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/daedalus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/daedalus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/daedalus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/daedalus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/daedalus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/daedalus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/daedalus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/daedalus/merges","archive_url":"https://api.github.com/repos/input-output-hk/daedalus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/daedalus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/daedalus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/daedalus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/daedalus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/daedalus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/daedalus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/daedalus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/daedalus/deployments","created_at":"2016-10-05T13:48:54Z","updated_at":"2018-06-13T09:46:45Z","pushed_at":"2018-06-13T10:53:16Z","git_url":"git://github.com/input-output-hk/daedalus.git","ssh_url":"git@github.com:input-output-hk/daedalus.git","clone_url":"https://github.com/input-output-hk/daedalus.git","svn_url":"https://github.com/input-output-hk/daedalus","homepage":null,"size":124543,"stargazers_count":446,"watchers_count":446,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":141,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":141,"open_issues":108,"watchers":446,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/973"},"html":{"href":"https://github.com/input-output-hk/daedalus/pull/973"},"issue":{"href":"https://api.github.com/repos/input-output-hk/daedalus/issues/973"},"comments":{"href":"https://api.github.com/repos/input-output-hk/daedalus/issues/973/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/973/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/daedalus/pulls/973/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/daedalus/statuses/62972561e3212d087833fceacbc820377766038b"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":4,"deletions":2,"changed_files":5}}
{"actor":{"display_login":"nikolaglumac"}}