{"action":"created","issue":{"url":"https://api.github.com/repos/iTowns/itowns/issues/754","repository_url":"https://api.github.com/repos/iTowns/itowns","labels_url":"https://api.github.com/repos/iTowns/itowns/issues/754/labels{/name}","comments_url":"https://api.github.com/repos/iTowns/itowns/issues/754/comments","events_url":"https://api.github.com/repos/iTowns/itowns/issues/754/events","html_url":"https://github.com/iTowns/itowns/pull/754","id":323275114,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg4MTcyMTY1","number":754,"title":"refactor: align Feature2Mesh and Feature2Texture","user":{"login":"zarov","id":741255,"node_id":"MDQ6VXNlcjc0MTI1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/741255?v=4","gravatar_id":"","url":"https://api.github.com/users/zarov","html_url":"https://github.com/zarov","followers_url":"https://api.github.com/users/zarov/followers","following_url":"https://api.github.com/users/zarov/following{/other_user}","gists_url":"https://api.github.com/users/zarov/gists{/gist_id}","starred_url":"https://api.github.com/users/zarov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zarov/subscriptions","organizations_url":"https://api.github.com/users/zarov/orgs","repos_url":"https://api.github.com/users/zarov/repos","events_url":"https://api.github.com/users/zarov/events{/privacy}","received_events_url":"https://api.github.com/users/zarov/received_events","type":"User","site_admin":false},"labels":[{"id":264615066,"node_id":"MDU6TGFiZWwyNjQ2MTUwNjY=","url":"https://api.github.com/repos/iTowns/itowns/labels/in%20progress","name":"in progress","color":"d65d4a","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-05-15T15:42:08Z","updated_at":"2018-05-31T07:18:18Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/iTowns/itowns/pulls/754","html_url":"https://github.com/iTowns/itowns/pull/754","diff_url":"https://github.com/iTowns/itowns/pull/754.diff","patch_url":"https://github.com/iTowns/itowns/pull/754.patch"},"body":"## Description\r\n\r\nThe two modules are very similar: they take a feature or an array of feature as arguments, and return either a mesh or a texture. It makes sense to regroup them under the same scheme.\r\n\r\nThe documentation was completed in the same time.\r\n\r\nNo breaking change as the old function has been marked as deprecated.\r\n\r\n## Question\r\n\r\nI'm not quite happy with the name of the common method (`convert`), and I wish to find a better name. In the same vein, I would like to take the opportunity to move those two module in `src/Core/newFolder` to start the gathering of all \"stylizing/symbolizing\" modules (as in #695 maybe). Any suggestion ?"},"comment":{"url":"https://api.github.com/repos/iTowns/itowns/issues/comments/393433365","html_url":"https://github.com/iTowns/itowns/pull/754#issuecomment-393433365","issue_url":"https://api.github.com/repos/iTowns/itowns/issues/754","id":393433365,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzQzMzM2NQ==","user":{"login":"autra","id":1576598,"node_id":"MDQ6VXNlcjE1NzY1OTg=","avatar_url":"https://avatars3.githubusercontent.com/u/1576598?v=4","gravatar_id":"","url":"https://api.github.com/users/autra","html_url":"https://github.com/autra","followers_url":"https://api.github.com/users/autra/followers","following_url":"https://api.github.com/users/autra/following{/other_user}","gists_url":"https://api.github.com/users/autra/gists{/gist_id}","starred_url":"https://api.github.com/users/autra/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/autra/subscriptions","organizations_url":"https://api.github.com/users/autra/orgs","repos_url":"https://api.github.com/users/autra/repos","events_url":"https://api.github.com/users/autra/events{/privacy}","received_events_url":"https://api.github.com/users/autra/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T07:18:17Z","updated_at":"2018-05-31T07:18:17Z","author_association":"CONTRIBUTOR","body":"> I would like to take the opportunity to move those two module in src/Core/newFolder to start the gathering of all \"stylizing/symbolizing\" modules (as in #695 maybe).\r\n\r\nGood idea! I think you can drop the `Core` part, and put them directly into src/newFolder. We must find a balance between too many top level folders and too many folder level of course, but I think iTowns currently needs a flatter hierarchy (and I generally find them easier for newcomers, ex THREE.js has 15 folders under `src/`, and it' actually quite easy to find what you're looking for imho).\r\n\r\n(a little detail, but I'd also like to drop folder capitalization `Core` -> `core` etc... I don't see the point of having them capitalized)\r\n\r\nAs for `newFolder`, I don't have any really great idea. Are these 2 files already stylizer according to you? Or will the styling process be after this transformation?\r\n\r\n"}}
{"actor":{"display_login":"autra"}}