{"action":"created","comment":{"url":"https://api.github.com/repos/weldr/welder-web/pulls/comments/220002245","pull_request_review_id":158311731,"id":220002245,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMDAwMjI0NQ==","diff_hunk":"@@ -182,6 +175,31 @@ function* commitToWorkspace(action) {\n   }\n }\n \n+function* deleteWorkspace(action) {","path":"core/sagas/blueprints.js","position":90,"original_position":90,"commit_id":"ba4cb131f5d2c53e79146d434c16aa5ffecd26d3","original_commit_id":"ba4cb131f5d2c53e79146d434c16aa5ffecd26d3","user":{"login":"jgiardino","id":21063328,"node_id":"MDQ6VXNlcjIxMDYzMzI4","avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"body":"There's a lot of duplication between this function and fetchBlueprintContents, and I couldn't figure out a simple way to handle that without making major changes. Any recommendations are welcome.","created_at":"2018-09-24T21:57:02Z","updated_at":"2018-09-24T21:57:02Z","html_url":"https://github.com/weldr/welder-web/pull/359#discussion_r220002245","pull_request_url":"https://api.github.com/repos/weldr/welder-web/pulls/359","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/weldr/welder-web/pulls/comments/220002245"},"html":{"href":"https://github.com/weldr/welder-web/pull/359#discussion_r220002245"},"pull_request":{"href":"https://api.github.com/repos/weldr/welder-web/pulls/359"}}},"pull_request":{"url":"https://api.github.com/repos/weldr/welder-web/pulls/359","id":217799762,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3Nzk5NzYy","html_url":"https://github.com/weldr/welder-web/pull/359","diff_url":"https://github.com/weldr/welder-web/pull/359.diff","patch_url":"https://github.com/weldr/welder-web/pull/359.patch","issue_url":"https://api.github.com/repos/weldr/welder-web/issues/359","number":359,"state":"open","locked":false,"title":"Update Discard Changes to delete workspace","user":{"login":"jgiardino","id":21063328,"node_id":"MDQ6VXNlcjIxMDYzMzI4","avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"body":"This closes #327.\r\n\r\nThese updates will delete a workspace if one exists when the user selects an action to discard the changes in a workspace, using either the Discard Changes button or the Undo button.\r\n\r\nAfter the workspace is deleted, an additional api call is made to get the blueprint so that we can load the correct blueprint contents in the UI.\r\n\r\nA couple of things to note:\r\n- I'd like for the user to be able to hit Redo to get changes back that were discarded. I think this could be a simple change, but will open a separate PR for that.\r\n- While working on this, I noticed that there are other places where we don't handle components that are stored in the blueprint as 'modules' very well, like removing components that are modules, or reloading the blueprint when changes are made. I will open a separate PR for those updates.","created_at":"2018-09-24T21:54:39Z","updated_at":"2018-09-24T21:57:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"63ef18fd00dd5883144428e48e8a4d5e6b17f31f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/weldr/welder-web/pulls/359/commits","review_comments_url":"https://api.github.com/repos/weldr/welder-web/pulls/359/comments","review_comment_url":"https://api.github.com/repos/weldr/welder-web/pulls/comments{/number}","comments_url":"https://api.github.com/repos/weldr/welder-web/issues/359/comments","statuses_url":"https://api.github.com/repos/weldr/welder-web/statuses/ba4cb131f5d2c53e79146d434c16aa5ffecd26d3","head":{"label":"jgiardino:blueprintWorkspace","ref":"blueprintWorkspace","sha":"ba4cb131f5d2c53e79146d434c16aa5ffecd26d3","user":{"login":"jgiardino","id":21063328,"node_id":"MDQ6VXNlcjIxMDYzMzI4","avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"repo":{"id":82688464,"node_id":"MDEwOlJlcG9zaXRvcnk4MjY4ODQ2NA==","name":"welder-web","full_name":"jgiardino/welder-web","private":false,"owner":{"login":"jgiardino","id":21063328,"node_id":"MDQ6VXNlcjIxMDYzMzI4","avatar_url":"https://avatars1.githubusercontent.com/u/21063328?v=4","gravatar_id":"","url":"https://api.github.com/users/jgiardino","html_url":"https://github.com/jgiardino","followers_url":"https://api.github.com/users/jgiardino/followers","following_url":"https://api.github.com/users/jgiardino/following{/other_user}","gists_url":"https://api.github.com/users/jgiardino/gists{/gist_id}","starred_url":"https://api.github.com/users/jgiardino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgiardino/subscriptions","organizations_url":"https://api.github.com/users/jgiardino/orgs","repos_url":"https://api.github.com/users/jgiardino/repos","events_url":"https://api.github.com/users/jgiardino/events{/privacy}","received_events_url":"https://api.github.com/users/jgiardino/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jgiardino/welder-web","description":null,"fork":true,"url":"https://api.github.com/repos/jgiardino/welder-web","forks_url":"https://api.github.com/repos/jgiardino/welder-web/forks","keys_url":"https://api.github.com/repos/jgiardino/welder-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgiardino/welder-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgiardino/welder-web/teams","hooks_url":"https://api.github.com/repos/jgiardino/welder-web/hooks","issue_events_url":"https://api.github.com/repos/jgiardino/welder-web/issues/events{/number}","events_url":"https://api.github.com/repos/jgiardino/welder-web/events","assignees_url":"https://api.github.com/repos/jgiardino/welder-web/assignees{/user}","branches_url":"https://api.github.com/repos/jgiardino/welder-web/branches{/branch}","tags_url":"https://api.github.com/repos/jgiardino/welder-web/tags","blobs_url":"https://api.github.com/repos/jgiardino/welder-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgiardino/welder-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgiardino/welder-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgiardino/welder-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgiardino/welder-web/statuses/{sha}","languages_url":"https://api.github.com/repos/jgiardino/welder-web/languages","stargazers_url":"https://api.github.com/repos/jgiardino/welder-web/stargazers","contributors_url":"https://api.github.com/repos/jgiardino/welder-web/contributors","subscribers_url":"https://api.github.com/repos/jgiardino/welder-web/subscribers","subscription_url":"https://api.github.com/repos/jgiardino/welder-web/subscription","commits_url":"https://api.github.com/repos/jgiardino/welder-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgiardino/welder-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgiardino/welder-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgiardino/welder-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgiardino/welder-web/contents/{+path}","compare_url":"https://api.github.com/repos/jgiardino/welder-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgiardino/welder-web/merges","archive_url":"https://api.github.com/repos/jgiardino/welder-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgiardino/welder-web/downloads","issues_url":"https://api.github.com/repos/jgiardino/welder-web/issues{/number}","pulls_url":"https://api.github.com/repos/jgiardino/welder-web/pulls{/number}","milestones_url":"https://api.github.com/repos/jgiardino/welder-web/milestones{/number}","notifications_url":"https://api.github.com/repos/jgiardino/welder-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgiardino/welder-web/labels{/name}","releases_url":"https://api.github.com/repos/jgiardino/welder-web/releases{/id}","deployments_url":"https://api.github.com/repos/jgiardino/welder-web/deployments","created_at":"2017-02-21T14:22:48Z","updated_at":"2018-07-12T19:12:06Z","pushed_at":"2018-09-24T21:22:44Z","git_url":"git://github.com/jgiardino/welder-web.git","ssh_url":"git@github.com:jgiardino/welder-web.git","clone_url":"https://github.com/jgiardino/welder-web.git","svn_url":"https://github.com/jgiardino/welder-web","homepage":null,"size":18670,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"weldr:master","ref":"master","sha":"fe143f929ddebcc2156019230f31a17c7e26dc1b","user":{"login":"weldr","id":22615983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjE1OTgz","avatar_url":"https://avatars0.githubusercontent.com/u/22615983?v=4","gravatar_id":"","url":"https://api.github.com/users/weldr","html_url":"https://github.com/weldr","followers_url":"https://api.github.com/users/weldr/followers","following_url":"https://api.github.com/users/weldr/following{/other_user}","gists_url":"https://api.github.com/users/weldr/gists{/gist_id}","starred_url":"https://api.github.com/users/weldr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weldr/subscriptions","organizations_url":"https://api.github.com/users/weldr/orgs","repos_url":"https://api.github.com/users/weldr/repos","events_url":"https://api.github.com/users/weldr/events{/privacy}","received_events_url":"https://api.github.com/users/weldr/received_events","type":"Organization","site_admin":false},"repo":{"id":69981456,"node_id":"MDEwOlJlcG9zaXRvcnk2OTk4MTQ1Ng==","name":"welder-web","full_name":"weldr/welder-web","private":false,"owner":{"login":"weldr","id":22615983,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNjE1OTgz","avatar_url":"https://avatars0.githubusercontent.com/u/22615983?v=4","gravatar_id":"","url":"https://api.github.com/users/weldr","html_url":"https://github.com/weldr","followers_url":"https://api.github.com/users/weldr/followers","following_url":"https://api.github.com/users/weldr/following{/other_user}","gists_url":"https://api.github.com/users/weldr/gists{/gist_id}","starred_url":"https://api.github.com/users/weldr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weldr/subscriptions","organizations_url":"https://api.github.com/users/weldr/orgs","repos_url":"https://api.github.com/users/weldr/repos","events_url":"https://api.github.com/users/weldr/events{/privacy}","received_events_url":"https://api.github.com/users/weldr/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/weldr/welder-web","description":null,"fork":false,"url":"https://api.github.com/repos/weldr/welder-web","forks_url":"https://api.github.com/repos/weldr/welder-web/forks","keys_url":"https://api.github.com/repos/weldr/welder-web/keys{/key_id}","collaborators_url":"https://api.github.com/repos/weldr/welder-web/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/weldr/welder-web/teams","hooks_url":"https://api.github.com/repos/weldr/welder-web/hooks","issue_events_url":"https://api.github.com/repos/weldr/welder-web/issues/events{/number}","events_url":"https://api.github.com/repos/weldr/welder-web/events","assignees_url":"https://api.github.com/repos/weldr/welder-web/assignees{/user}","branches_url":"https://api.github.com/repos/weldr/welder-web/branches{/branch}","tags_url":"https://api.github.com/repos/weldr/welder-web/tags","blobs_url":"https://api.github.com/repos/weldr/welder-web/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/weldr/welder-web/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/weldr/welder-web/git/refs{/sha}","trees_url":"https://api.github.com/repos/weldr/welder-web/git/trees{/sha}","statuses_url":"https://api.github.com/repos/weldr/welder-web/statuses/{sha}","languages_url":"https://api.github.com/repos/weldr/welder-web/languages","stargazers_url":"https://api.github.com/repos/weldr/welder-web/stargazers","contributors_url":"https://api.github.com/repos/weldr/welder-web/contributors","subscribers_url":"https://api.github.com/repos/weldr/welder-web/subscribers","subscription_url":"https://api.github.com/repos/weldr/welder-web/subscription","commits_url":"https://api.github.com/repos/weldr/welder-web/commits{/sha}","git_commits_url":"https://api.github.com/repos/weldr/welder-web/git/commits{/sha}","comments_url":"https://api.github.com/repos/weldr/welder-web/comments{/number}","issue_comment_url":"https://api.github.com/repos/weldr/welder-web/issues/comments{/number}","contents_url":"https://api.github.com/repos/weldr/welder-web/contents/{+path}","compare_url":"https://api.github.com/repos/weldr/welder-web/compare/{base}...{head}","merges_url":"https://api.github.com/repos/weldr/welder-web/merges","archive_url":"https://api.github.com/repos/weldr/welder-web/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/weldr/welder-web/downloads","issues_url":"https://api.github.com/repos/weldr/welder-web/issues{/number}","pulls_url":"https://api.github.com/repos/weldr/welder-web/pulls{/number}","milestones_url":"https://api.github.com/repos/weldr/welder-web/milestones{/number}","notifications_url":"https://api.github.com/repos/weldr/welder-web/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/weldr/welder-web/labels{/name}","releases_url":"https://api.github.com/repos/weldr/welder-web/releases{/id}","deployments_url":"https://api.github.com/repos/weldr/welder-web/deployments","created_at":"2016-10-04T15:56:43Z","updated_at":"2018-09-21T08:08:53Z","pushed_at":"2018-09-24T21:54:40Z","git_url":"git://github.com/weldr/welder-web.git","ssh_url":"git@github.com:weldr/welder-web.git","clone_url":"https://github.com/weldr/welder-web.git","svn_url":"https://github.com/weldr/welder-web","homepage":null,"size":18655,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":17,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":17,"open_issues":36,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/weldr/welder-web/pulls/359"},"html":{"href":"https://github.com/weldr/welder-web/pull/359"},"issue":{"href":"https://api.github.com/repos/weldr/welder-web/issues/359"},"comments":{"href":"https://api.github.com/repos/weldr/welder-web/issues/359/comments"},"review_comments":{"href":"https://api.github.com/repos/weldr/welder-web/pulls/359/comments"},"review_comment":{"href":"https://api.github.com/repos/weldr/welder-web/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/weldr/welder-web/pulls/359/commits"},"statuses":{"href":"https://api.github.com/repos/weldr/welder-web/statuses/ba4cb131f5d2c53e79146d434c16aa5ffecd26d3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jgiardino"}}