{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/pontoon/issues/1113","repository_url":"https://api.github.com/repos/mozilla/pontoon","labels_url":"https://api.github.com/repos/mozilla/pontoon/issues/1113/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/pontoon/issues/1113/comments","events_url":"https://api.github.com/repos/mozilla/pontoon/issues/1113/events","html_url":"https://github.com/mozilla/pontoon/pull/1113","id":374010687,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1ODA5MjMy","number":1113,"title":" Fix bug 1486500 - Make the Translate UI localizable. ","user":{"login":"adngdb","id":328790,"node_id":"MDQ6VXNlcjMyODc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/328790?v=4","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-10-25T15:39:25Z","updated_at":"2018-10-31T17:18:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mozilla/pontoon/pulls/1113","html_url":"https://github.com/mozilla/pontoon/pull/1113","diff_url":"https://github.com/mozilla/pontoon/pull/1113.diff","patch_url":"https://github.com/mozilla/pontoon/pull/1113.patch"},"body":"Pontoon in French, ladies and gentlemen! :sparkles: \r\n\r\nI think this one requires extensive review. I have never done this before, and it's an area that is nothing near new, so there are others who have a lot more experience than I do. I thus fear I am making a lot of mistakes with my approach.\r\n\r\nThere are also a lot of decisions made here. Not that they cannot be changed later, but we should at least identify which ones we know will have to evolve. Among those decisions: \r\n\r\n- where to put localization files (`/frontend/public/static/locale/${locale}/`). I believe that should change and be pushed to a different repo, so that we do not pollute our commit history with translations ([mozilla/addons-frontend](https://github.com/mozilla/addons-frontend) does it and it puzzles me).\r\n- how to do language negotiation. I made the decision to do it in the server, so that we can benefit from user settings. Right now, the `preferred homepage` setting takes precedence over everything else (which makes this easy to test, just changed your team page to `fr`). It doesn't necessarily makes sense, as users might work primarily on a locale but prefer to see the UI in another one (for example, I expect some people, myself included, will want to keep the UI in `en-US`).\r\n- what locales to fall back to. Right now, there is only one fallback, and that's the default content from the code (not even the content of the `en-US` file). That is very likely wrong, but I don't know what it should actually be.\r\n- what IDs to use for strings. I'm not sure we need to have strict rules, but my instinct tells me we should. What do Firefox developers do? Other Fluent users? And is the rule I proposed good? \r\n\r\nI'm also concerned that I might be using Fluent incorrectly in some cases.\r\n\r\nFor all these reasons, I'd like to request review from @mathjazz, @stas and @Pike. Anyone else interested in this conversation is very welcome to join."},"comment":{"url":"https://api.github.com/repos/mozilla/pontoon/issues/comments/434773573","html_url":"https://github.com/mozilla/pontoon/pull/1113#issuecomment-434773573","issue_url":"https://api.github.com/repos/mozilla/pontoon/issues/1113","id":434773573,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDc3MzU3Mw==","user":{"login":"adngdb","id":328790,"node_id":"MDQ6VXNlcjMyODc5MA==","avatar_url":"https://avatars1.githubusercontent.com/u/328790?v=4","gravatar_id":"","url":"https://api.github.com/users/adngdb","html_url":"https://github.com/adngdb","followers_url":"https://api.github.com/users/adngdb/followers","following_url":"https://api.github.com/users/adngdb/following{/other_user}","gists_url":"https://api.github.com/users/adngdb/gists{/gist_id}","starred_url":"https://api.github.com/users/adngdb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adngdb/subscriptions","organizations_url":"https://api.github.com/users/adngdb/orgs","repos_url":"https://api.github.com/users/adngdb/repos","events_url":"https://api.github.com/users/adngdb/events{/privacy}","received_events_url":"https://api.github.com/users/adngdb/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T17:18:37Z","updated_at":"2018-10-31T17:18:37Z","author_association":"MEMBER","body":"Remaining things to address here: \r\n\r\n - [ ] Update README according to Axel's comment\r\n - [ ] Consider options for langneg (new user setting or just classic langneg)\r\n - [ ] Start conversations or bugs about sudo locale, where to put FTL files, and adding Pontoon on Pontoon"}}
{"actor":{"display_login":"adngdb"}}