{"action":"created","comment":{"url":"https://api.github.com/repos/status-im/status-go/pulls/comments/175299474","pull_request_review_id":104807282,"id":175299474,"diff_hunk":"@@ -98,12 +98,6 @@ func (m *NodeManager) startNode(config *params.NodeConfig) error {\n \t\tlog.Error(\"Failed to create an RPC client\", \"error\", err)\n \t\treturn RPCClientError(err)\n \t}\n-\t// populate static peers exits when node stopped\n-\tgo func() {","path":"geth/node/manager.go","position":5,"original_position":5,"commit_id":"617e512eeab10ef2c05e1b5bfae79d4b6a984518","original_commit_id":"617e512eeab10ef2c05e1b5bfae79d4b6a984518","user":{"login":"themue","id":1633981,"avatar_url":"https://avatars0.githubusercontent.com/u/1633981?v=4","gravatar_id":"","url":"https://api.github.com/users/themue","html_url":"https://github.com/themue","followers_url":"https://api.github.com/users/themue/followers","following_url":"https://api.github.com/users/themue/following{/other_user}","gists_url":"https://api.github.com/users/themue/gists{/gist_id}","starred_url":"https://api.github.com/users/themue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themue/subscriptions","organizations_url":"https://api.github.com/users/themue/orgs","repos_url":"https://api.github.com/users/themue/repos","events_url":"https://api.github.com/users/themue/events{/privacy}","received_events_url":"https://api.github.com/users/themue/received_events","type":"User","site_admin":false},"body":"See discussion in #708. It's in https://github.com/status-im/status-go/blob/develop/geth/node/node.go called in `MakeNode()` which is called in line 74 here.","created_at":"2018-03-18T18:53:00Z","updated_at":"2018-03-18T18:53:00Z","html_url":"https://github.com/status-im/status-go/pull/738#discussion_r175299474","pull_request_url":"https://api.github.com/repos/status-im/status-go/pulls/738","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments/175299474"},"html":{"href":"https://github.com/status-im/status-go/pull/738#discussion_r175299474"},"pull_request":{"href":"https://api.github.com/repos/status-im/status-go/pulls/738"}},"in_reply_to_id":175297856},"pull_request":{"url":"https://api.github.com/repos/status-im/status-go/pulls/738","id":175489004,"html_url":"https://github.com/status-im/status-go/pull/738","diff_url":"https://github.com/status-im/status-go/pull/738.diff","patch_url":"https://github.com/status-im/status-go/pull/738.patch","issue_url":"https://api.github.com/repos/status-im/status-go/issues/738","number":738,"state":"open","locked":false,"title":"Static peers are now also optionally configurable","user":{"login":"themue","id":1633981,"avatar_url":"https://avatars0.githubusercontent.com/u/1633981?v=4","gravatar_id":"","url":"https://api.github.com/users/themue","html_url":"https://github.com/themue","followers_url":"https://api.github.com/users/themue/followers","following_url":"https://api.github.com/users/themue/following{/other_user}","gists_url":"https://api.github.com/users/themue/gists{/gist_id}","starred_url":"https://api.github.com/users/themue/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/themue/subscriptions","organizations_url":"https://api.github.com/users/themue/orgs","repos_url":"https://api.github.com/users/themue/repos","events_url":"https://api.github.com/users/themue/events{/privacy}","received_events_url":"https://api.github.com/users/themue/received_events","type":"User","site_admin":false},"body":"So far the file `staticpeers.json` has been included statically. Beside renaming as we're talking about boot nodes here those now optionally can be loaded during startup time out of an external file.\r\n\r\nImportant changes:\r\n\r\n- [x] Renaming from static peers to cluster configuration and boot nodes.\r\n- [x] Adding of argument to pass the file name of a cluster configuration file to be used.\r\n- [x] If argument isn't used fallback is the still statically included `cluster.json`.\r\n\r\nCloses #708\r\n","created_at":"2018-03-16T10:10:23Z","updated_at":"2018-03-18T18:53:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8c9b48de860281567d10949af87191ea3b082f97","assignee":null,"assignees":[],"requested_reviewers":[{"login":"dshulyak","id":1964576,"avatar_url":"https://avatars2.githubusercontent.com/u/1964576?v=4","gravatar_id":"","url":"https://api.github.com/users/dshulyak","html_url":"https://github.com/dshulyak","followers_url":"https://api.github.com/users/dshulyak/followers","following_url":"https://api.github.com/users/dshulyak/following{/other_user}","gists_url":"https://api.github.com/users/dshulyak/gists{/gist_id}","starred_url":"https://api.github.com/users/dshulyak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dshulyak/subscriptions","organizations_url":"https://api.github.com/users/dshulyak/orgs","repos_url":"https://api.github.com/users/dshulyak/repos","events_url":"https://api.github.com/users/dshulyak/events{/privacy}","received_events_url":"https://api.github.com/users/dshulyak/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/status-im/status-go/pulls/738/commits","review_comments_url":"https://api.github.com/repos/status-im/status-go/pulls/738/comments","review_comment_url":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/status-im/status-go/issues/738/comments","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/617e512eeab10ef2c05e1b5bfae79d4b6a984518","head":{"label":"status-im:maintenance/static-peer-handing-708","ref":"maintenance/static-peer-handing-708","sha":"617e512eeab10ef2c05e1b5bfae79d4b6a984518","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-03-18T14:33:28Z","pushed_at":"2018-03-18T13:50:15Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":37395,"stargazers_count":356,"watchers_count":356,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":113,"open_issues":70,"watchers":356,"default_branch":"develop"}},"base":{"label":"status-im:develop","ref":"develop","sha":"3b92b61ef1dfb4dca7c64deff232c578fd45a9b1","user":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"repo":{"id":61047867,"name":"status-go","full_name":"status-im/status-go","owner":{"login":"status-im","id":11767950,"avatar_url":"https://avatars1.githubusercontent.com/u/11767950?v=4","gravatar_id":"","url":"https://api.github.com/users/status-im","html_url":"https://github.com/status-im","followers_url":"https://api.github.com/users/status-im/followers","following_url":"https://api.github.com/users/status-im/following{/other_user}","gists_url":"https://api.github.com/users/status-im/gists{/gist_id}","starred_url":"https://api.github.com/users/status-im/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/status-im/subscriptions","organizations_url":"https://api.github.com/users/status-im/orgs","repos_url":"https://api.github.com/users/status-im/repos","events_url":"https://api.github.com/users/status-im/events{/privacy}","received_events_url":"https://api.github.com/users/status-im/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/status-im/status-go","description":"The Status module that consumes go-ethereum","fork":false,"url":"https://api.github.com/repos/status-im/status-go","forks_url":"https://api.github.com/repos/status-im/status-go/forks","keys_url":"https://api.github.com/repos/status-im/status-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/status-im/status-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/status-im/status-go/teams","hooks_url":"https://api.github.com/repos/status-im/status-go/hooks","issue_events_url":"https://api.github.com/repos/status-im/status-go/issues/events{/number}","events_url":"https://api.github.com/repos/status-im/status-go/events","assignees_url":"https://api.github.com/repos/status-im/status-go/assignees{/user}","branches_url":"https://api.github.com/repos/status-im/status-go/branches{/branch}","tags_url":"https://api.github.com/repos/status-im/status-go/tags","blobs_url":"https://api.github.com/repos/status-im/status-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/status-im/status-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/status-im/status-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/status-im/status-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/status-im/status-go/statuses/{sha}","languages_url":"https://api.github.com/repos/status-im/status-go/languages","stargazers_url":"https://api.github.com/repos/status-im/status-go/stargazers","contributors_url":"https://api.github.com/repos/status-im/status-go/contributors","subscribers_url":"https://api.github.com/repos/status-im/status-go/subscribers","subscription_url":"https://api.github.com/repos/status-im/status-go/subscription","commits_url":"https://api.github.com/repos/status-im/status-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/status-im/status-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/status-im/status-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/status-im/status-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/status-im/status-go/contents/{+path}","compare_url":"https://api.github.com/repos/status-im/status-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/status-im/status-go/merges","archive_url":"https://api.github.com/repos/status-im/status-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/status-im/status-go/downloads","issues_url":"https://api.github.com/repos/status-im/status-go/issues{/number}","pulls_url":"https://api.github.com/repos/status-im/status-go/pulls{/number}","milestones_url":"https://api.github.com/repos/status-im/status-go/milestones{/number}","notifications_url":"https://api.github.com/repos/status-im/status-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/status-im/status-go/labels{/name}","releases_url":"https://api.github.com/repos/status-im/status-go/releases{/id}","deployments_url":"https://api.github.com/repos/status-im/status-go/deployments","created_at":"2016-06-13T15:32:03Z","updated_at":"2018-03-18T14:33:28Z","pushed_at":"2018-03-18T13:50:15Z","git_url":"git://github.com/status-im/status-go.git","ssh_url":"git@github.com:status-im/status-go.git","clone_url":"https://github.com/status-im/status-go.git","svn_url":"https://github.com/status-im/status-go","homepage":"https://status.im","size":37395,"stargazers_count":356,"watchers_count":356,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":113,"mirror_url":null,"archived":false,"open_issues_count":70,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":113,"open_issues":70,"watchers":356,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/status-im/status-go/pulls/738"},"html":{"href":"https://github.com/status-im/status-go/pull/738"},"issue":{"href":"https://api.github.com/repos/status-im/status-go/issues/738"},"comments":{"href":"https://api.github.com/repos/status-im/status-go/issues/738/comments"},"review_comments":{"href":"https://api.github.com/repos/status-im/status-go/pulls/738/comments"},"review_comment":{"href":"https://api.github.com/repos/status-im/status-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/status-im/status-go/pulls/738/commits"},"statuses":{"href":"https://api.github.com/repos/status-im/status-go/statuses/617e512eeab10ef2c05e1b5bfae79d4b6a984518"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"themue"}}