{"action":"created","comment":{"url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments/165437753","pull_request_review_id":93368152,"id":165437753,"diff_hunk":"@@ -882,39 +877,40 @@ private function mapAliasToTarget($alias, $target)\n      */\n     private function mapAliasesToTargets()\n     {\n+        // localize to avoid continous dereferencing","path":"src/ServiceManager.php","position":534,"original_position":534,"commit_id":"f967b6b3e2d5e9f4a8f55bb725f5573c98c93cf8","original_commit_id":"f967b6b3e2d5e9f4a8f55bb725f5573c98c93cf8","user":{"login":"Ocramius","id":154256,"avatar_url":"https://avatars2.githubusercontent.com/u/154256?v=4","gravatar_id":"","url":"https://api.github.com/users/Ocramius","html_url":"https://github.com/Ocramius","followers_url":"https://api.github.com/users/Ocramius/followers","following_url":"https://api.github.com/users/Ocramius/following{/other_user}","gists_url":"https://api.github.com/users/Ocramius/gists{/gist_id}","starred_url":"https://api.github.com/users/Ocramius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ocramius/subscriptions","organizations_url":"https://api.github.com/users/Ocramius/orgs","repos_url":"https://api.github.com/users/Ocramius/repos","events_url":"https://api.github.com/users/Ocramius/events{/privacy}","received_events_url":"https://api.github.com/users/Ocramius/received_events","type":"User","site_admin":false},"body":"Continuous dereferencing is how the engine works. Adding references to it just adds extremely big complexity, including possible JIT bailout if that ever lands in `master`/`7.3` :-\\","created_at":"2018-02-01T17:57:40Z","updated_at":"2018-02-01T18:00:01Z","html_url":"https://github.com/zendframework/zend-servicemanager/pull/231#discussion_r165437753","pull_request_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/231","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments/165437753"},"html":{"href":"https://github.com/zendframework/zend-servicemanager/pull/231#discussion_r165437753"},"pull_request":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/231"}}},"pull_request":{"url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/231","id":163842503,"html_url":"https://github.com/zendframework/zend-servicemanager/pull/231","diff_url":"https://github.com/zendframework/zend-servicemanager/pull/231.diff","patch_url":"https://github.com/zendframework/zend-servicemanager/pull/231.patch","issue_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/231","number":231,"state":"open","locked":false,"title":"Bugfixes as of #242 applied to develop","user":{"login":"fhein","id":4722654,"avatar_url":"https://avatars2.githubusercontent.com/u/4722654?v=4","gravatar_id":"","url":"https://api.github.com/users/fhein","html_url":"https://github.com/fhein","followers_url":"https://api.github.com/users/fhein/followers","following_url":"https://api.github.com/users/fhein/following{/other_user}","gists_url":"https://api.github.com/users/fhein/gists{/gist_id}","starred_url":"https://api.github.com/users/fhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhein/subscriptions","organizations_url":"https://api.github.com/users/fhein/orgs","repos_url":"https://api.github.com/users/fhein/repos","events_url":"https://api.github.com/users/fhein/events{/privacy}","received_events_url":"https://api.github.com/users/fhein/received_events","type":"User","site_admin":false},"body":"This PR initially delivered the rest of #221. As several bugs were unrevealed in the process I created according tests and fixes for master with #242.\r\n\r\nThis PR applies the same fixes to develop recognizing that #221 and #230 were already merged. The issuese fixed are in particular \r\n\r\n1. Preconfigured abstract factories are not resolved.\r\n2. Preconfigured initializers are not resolved.\r\n3. Preconfigured invokables are not resolved.\r\n4. Invokables defined as name => InvokableClass can override delegators and factories.\r\n\r\nA performance gain of more than 100% in FetchNewServiceManagerBench.php is a welcome side effect. \r\n\r\nBtw, I should have named this branch initially 'Rest-Of-#221'. 211 was wrong right from the beginning. :(","created_at":"2018-01-18T22:46:35Z","updated_at":"2018-02-01T18:00:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7f497b75f46c9f6193e102be8b32ff919b5ec029","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/231/commits","review_comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/231/comments","review_comment_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/231/comments","statuses_url":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/f967b6b3e2d5e9f4a8f55bb725f5573c98c93cf8","head":{"label":"fhein:Rest-of-#211","ref":"Rest-of-#211","sha":"f967b6b3e2d5e9f4a8f55bb725f5573c98c93cf8","user":{"login":"fhein","id":4722654,"avatar_url":"https://avatars2.githubusercontent.com/u/4722654?v=4","gravatar_id":"","url":"https://api.github.com/users/fhein","html_url":"https://github.com/fhein","followers_url":"https://api.github.com/users/fhein/followers","following_url":"https://api.github.com/users/fhein/following{/other_user}","gists_url":"https://api.github.com/users/fhein/gists{/gist_id}","starred_url":"https://api.github.com/users/fhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhein/subscriptions","organizations_url":"https://api.github.com/users/fhein/orgs","repos_url":"https://api.github.com/users/fhein/repos","events_url":"https://api.github.com/users/fhein/events{/privacy}","received_events_url":"https://api.github.com/users/fhein/received_events","type":"User","site_admin":false},"repo":{"id":115551428,"name":"zend-servicemanager","full_name":"fhein/zend-servicemanager","owner":{"login":"fhein","id":4722654,"avatar_url":"https://avatars2.githubusercontent.com/u/4722654?v=4","gravatar_id":"","url":"https://api.github.com/users/fhein","html_url":"https://github.com/fhein","followers_url":"https://api.github.com/users/fhein/followers","following_url":"https://api.github.com/users/fhein/following{/other_user}","gists_url":"https://api.github.com/users/fhein/gists{/gist_id}","starred_url":"https://api.github.com/users/fhein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fhein/subscriptions","organizations_url":"https://api.github.com/users/fhein/orgs","repos_url":"https://api.github.com/users/fhein/repos","events_url":"https://api.github.com/users/fhein/events{/privacy}","received_events_url":"https://api.github.com/users/fhein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fhein/zend-servicemanager","description":"ServiceManager component from Zend Framework","fork":true,"url":"https://api.github.com/repos/fhein/zend-servicemanager","forks_url":"https://api.github.com/repos/fhein/zend-servicemanager/forks","keys_url":"https://api.github.com/repos/fhein/zend-servicemanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fhein/zend-servicemanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fhein/zend-servicemanager/teams","hooks_url":"https://api.github.com/repos/fhein/zend-servicemanager/hooks","issue_events_url":"https://api.github.com/repos/fhein/zend-servicemanager/issues/events{/number}","events_url":"https://api.github.com/repos/fhein/zend-servicemanager/events","assignees_url":"https://api.github.com/repos/fhein/zend-servicemanager/assignees{/user}","branches_url":"https://api.github.com/repos/fhein/zend-servicemanager/branches{/branch}","tags_url":"https://api.github.com/repos/fhein/zend-servicemanager/tags","blobs_url":"https://api.github.com/repos/fhein/zend-servicemanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fhein/zend-servicemanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fhein/zend-servicemanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/fhein/zend-servicemanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fhein/zend-servicemanager/statuses/{sha}","languages_url":"https://api.github.com/repos/fhein/zend-servicemanager/languages","stargazers_url":"https://api.github.com/repos/fhein/zend-servicemanager/stargazers","contributors_url":"https://api.github.com/repos/fhein/zend-servicemanager/contributors","subscribers_url":"https://api.github.com/repos/fhein/zend-servicemanager/subscribers","subscription_url":"https://api.github.com/repos/fhein/zend-servicemanager/subscription","commits_url":"https://api.github.com/repos/fhein/zend-servicemanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/fhein/zend-servicemanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/fhein/zend-servicemanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/fhein/zend-servicemanager/issues/comments{/number}","contents_url":"https://api.github.com/repos/fhein/zend-servicemanager/contents/{+path}","compare_url":"https://api.github.com/repos/fhein/zend-servicemanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fhein/zend-servicemanager/merges","archive_url":"https://api.github.com/repos/fhein/zend-servicemanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fhein/zend-servicemanager/downloads","issues_url":"https://api.github.com/repos/fhein/zend-servicemanager/issues{/number}","pulls_url":"https://api.github.com/repos/fhein/zend-servicemanager/pulls{/number}","milestones_url":"https://api.github.com/repos/fhein/zend-servicemanager/milestones{/number}","notifications_url":"https://api.github.com/repos/fhein/zend-servicemanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fhein/zend-servicemanager/labels{/name}","releases_url":"https://api.github.com/repos/fhein/zend-servicemanager/releases{/id}","deployments_url":"https://api.github.com/repos/fhein/zend-servicemanager/deployments","created_at":"2017-12-27T19:32:24Z","updated_at":"2017-12-27T19:32:25Z","pushed_at":"2018-02-01T16:26:34Z","git_url":"git://github.com/fhein/zend-servicemanager.git","ssh_url":"git@github.com:fhein/zend-servicemanager.git","clone_url":"https://github.com/fhein/zend-servicemanager.git","svn_url":"https://github.com/fhein/zend-servicemanager","homepage":"https://github.com/zendframework/zf2","size":3404,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zendframework:develop","ref":"develop","sha":"586e94da734d97e63ed1b83f73c03016cd836d79","user":{"login":"zendframework","id":296074,"avatar_url":"https://avatars2.githubusercontent.com/u/296074?v=4","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"repo":{"id":35280826,"name":"zend-servicemanager","full_name":"zendframework/zend-servicemanager","owner":{"login":"zendframework","id":296074,"avatar_url":"https://avatars2.githubusercontent.com/u/296074?v=4","gravatar_id":"","url":"https://api.github.com/users/zendframework","html_url":"https://github.com/zendframework","followers_url":"https://api.github.com/users/zendframework/followers","following_url":"https://api.github.com/users/zendframework/following{/other_user}","gists_url":"https://api.github.com/users/zendframework/gists{/gist_id}","starred_url":"https://api.github.com/users/zendframework/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zendframework/subscriptions","organizations_url":"https://api.github.com/users/zendframework/orgs","repos_url":"https://api.github.com/users/zendframework/repos","events_url":"https://api.github.com/users/zendframework/events{/privacy}","received_events_url":"https://api.github.com/users/zendframework/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zendframework/zend-servicemanager","description":"ServiceManager component from Zend Framework","fork":false,"url":"https://api.github.com/repos/zendframework/zend-servicemanager","forks_url":"https://api.github.com/repos/zendframework/zend-servicemanager/forks","keys_url":"https://api.github.com/repos/zendframework/zend-servicemanager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zendframework/zend-servicemanager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zendframework/zend-servicemanager/teams","hooks_url":"https://api.github.com/repos/zendframework/zend-servicemanager/hooks","issue_events_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/events{/number}","events_url":"https://api.github.com/repos/zendframework/zend-servicemanager/events","assignees_url":"https://api.github.com/repos/zendframework/zend-servicemanager/assignees{/user}","branches_url":"https://api.github.com/repos/zendframework/zend-servicemanager/branches{/branch}","tags_url":"https://api.github.com/repos/zendframework/zend-servicemanager/tags","blobs_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/refs{/sha}","trees_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/{sha}","languages_url":"https://api.github.com/repos/zendframework/zend-servicemanager/languages","stargazers_url":"https://api.github.com/repos/zendframework/zend-servicemanager/stargazers","contributors_url":"https://api.github.com/repos/zendframework/zend-servicemanager/contributors","subscribers_url":"https://api.github.com/repos/zendframework/zend-servicemanager/subscribers","subscription_url":"https://api.github.com/repos/zendframework/zend-servicemanager/subscription","commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/commits{/sha}","git_commits_url":"https://api.github.com/repos/zendframework/zend-servicemanager/git/commits{/sha}","comments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/comments{/number}","issue_comment_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/comments{/number}","contents_url":"https://api.github.com/repos/zendframework/zend-servicemanager/contents/{+path}","compare_url":"https://api.github.com/repos/zendframework/zend-servicemanager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zendframework/zend-servicemanager/merges","archive_url":"https://api.github.com/repos/zendframework/zend-servicemanager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zendframework/zend-servicemanager/downloads","issues_url":"https://api.github.com/repos/zendframework/zend-servicemanager/issues{/number}","pulls_url":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls{/number}","milestones_url":"https://api.github.com/repos/zendframework/zend-servicemanager/milestones{/number}","notifications_url":"https://api.github.com/repos/zendframework/zend-servicemanager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zendframework/zend-servicemanager/labels{/name}","releases_url":"https://api.github.com/repos/zendframework/zend-servicemanager/releases{/id}","deployments_url":"https://api.github.com/repos/zendframework/zend-servicemanager/deployments","created_at":"2015-05-08T13:28:10Z","updated_at":"2018-01-29T22:56:52Z","pushed_at":"2018-02-01T17:22:14Z","git_url":"git://github.com/zendframework/zend-servicemanager.git","ssh_url":"git@github.com:zendframework/zend-servicemanager.git","clone_url":"https://github.com/zendframework/zend-servicemanager.git","svn_url":"https://github.com/zendframework/zend-servicemanager","homepage":"https://github.com/zendframework/zf2","size":3315,"stargazers_count":112,"watchers_count":112,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":88,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":88,"open_issues":23,"watchers":112,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/231"},"html":{"href":"https://github.com/zendframework/zend-servicemanager/pull/231"},"issue":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/231"},"comments":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/issues/231/comments"},"review_comments":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/231/comments"},"review_comment":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/pulls/231/commits"},"statuses":{"href":"https://api.github.com/repos/zendframework/zend-servicemanager/statuses/f967b6b3e2d5e9f4a8f55bb725f5573c98c93cf8"}},"author_association":"NONE"}}
{"actor":{"display_login":"Ocramius"}}