{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments/240611268","pull_request_review_id":183677486,"id":240611268,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDYxMTI2OA==","diff_hunk":"@@ -398,6 +403,110 @@ func (a *StaticAutoscaler) RunOnce(currentTime time.Time) errors.AutoscalerError\n \treturn nil\n }\n \n+func (a *StaticAutoscaler) handleQuotaAndStockoutErrors(currentTime time.Time) {\n+\tcurrentInstancesPerNodeGroup := a.clusterStateRegistry.GetCloudProviderNodeInstances()\n+\tpreviousInstancesPerNodeGroup := a.clusterStateRegistry.GetPreviousCloudProviderNodeInstances()","path":"cluster-autoscaler/core/static_autoscaler.go","position":32,"original_position":32,"commit_id":"81d342b0f230f69daccab3109ec6de18dfffb065","original_commit_id":"81d342b0f230f69daccab3109ec6de18dfffb065","user":{"login":"aleksandra-malinowska","id":4884414,"node_id":"MDQ6VXNlcjQ4ODQ0MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/4884414?v=4","gravatar_id":"","url":"https://api.github.com/users/aleksandra-malinowska","html_url":"https://github.com/aleksandra-malinowska","followers_url":"https://api.github.com/users/aleksandra-malinowska/followers","following_url":"https://api.github.com/users/aleksandra-malinowska/following{/other_user}","gists_url":"https://api.github.com/users/aleksandra-malinowska/gists{/gist_id}","starred_url":"https://api.github.com/users/aleksandra-malinowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aleksandra-malinowska/subscriptions","organizations_url":"https://api.github.com/users/aleksandra-malinowska/orgs","repos_url":"https://api.github.com/users/aleksandra-malinowska/repos","events_url":"https://api.github.com/users/aleksandra-malinowska/events{/privacy}","received_events_url":"https://api.github.com/users/aleksandra-malinowska/received_events","type":"User","site_admin":false},"body":"Did you mean move it to clusterstate?","created_at":"2018-12-11T13:36:00Z","updated_at":"2018-12-11T13:36:01Z","html_url":"https://github.com/kubernetes/autoscaler/pull/1464#discussion_r240611268","pull_request_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/1464","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments/240611268"},"html":{"href":"https://github.com/kubernetes/autoscaler/pull/1464#discussion_r240611268"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/1464"}},"in_reply_to_id":240610271},"pull_request":{"url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/1464","id":234741587,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0NzQxNTg3","html_url":"https://github.com/kubernetes/autoscaler/pull/1464","diff_url":"https://github.com/kubernetes/autoscaler/pull/1464.diff","patch_url":"https://github.com/kubernetes/autoscaler/pull/1464.patch","issue_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/1464","number":1464,"state":"open","locked":false,"title":"Better quota-exceeded/stockout handling","user":{"login":"losipiuk","id":890111,"node_id":"MDQ6VXNlcjg5MDExMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-29T18:31:23Z","updated_at":"2018-12-11T13:36:01Z","closed_at":null,"merged_at":null,"merge_commit_sha":"108c750a36c24284fae63bb14e56897259cb4b06","assignee":null,"assignees":[],"requested_reviewers":[{"login":"feiskyer","id":676637,"node_id":"MDQ6VXNlcjY3NjYzNw==","avatar_url":"https://avatars2.githubusercontent.com/u/676637?v=4","gravatar_id":"","url":"https://api.github.com/users/feiskyer","html_url":"https://github.com/feiskyer","followers_url":"https://api.github.com/users/feiskyer/followers","following_url":"https://api.github.com/users/feiskyer/following{/other_user}","gists_url":"https://api.github.com/users/feiskyer/gists{/gist_id}","starred_url":"https://api.github.com/users/feiskyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/feiskyer/subscriptions","organizations_url":"https://api.github.com/users/feiskyer/orgs","repos_url":"https://api.github.com/users/feiskyer/repos","events_url":"https://api.github.com/users/feiskyer/events{/privacy}","received_events_url":"https://api.github.com/users/feiskyer/received_events","type":"User","site_admin":false},{"login":"piosz","id":10819974,"node_id":"MDQ6VXNlcjEwODE5OTc0","avatar_url":"https://avatars0.githubusercontent.com/u/10819974?v=4","gravatar_id":"","url":"https://api.github.com/users/piosz","html_url":"https://github.com/piosz","followers_url":"https://api.github.com/users/piosz/followers","following_url":"https://api.github.com/users/piosz/following{/other_user}","gists_url":"https://api.github.com/users/piosz/gists{/gist_id}","starred_url":"https://api.github.com/users/piosz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/piosz/subscriptions","organizations_url":"https://api.github.com/users/piosz/orgs","repos_url":"https://api.github.com/users/piosz/repos","events_url":"https://api.github.com/users/piosz/events{/privacy}","received_events_url":"https://api.github.com/users/piosz/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":587167715,"node_id":"MDU6TGFiZWw1ODcxNjc3MTU=","url":"https://api.github.com/repos/kubernetes/autoscaler/labels/cluster-autoscaler","name":"cluster-autoscaler","color":"d4c5f9","default":false},{"id":586404823,"node_id":"MDU6TGFiZWw1ODY0MDQ4MjM=","url":"https://api.github.com/repos/kubernetes/autoscaler/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":686884578,"node_id":"MDU6TGFiZWw2ODY4ODQ1Nzg=","url":"https://api.github.com/repos/kubernetes/autoscaler/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/1464/commits","review_comments_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/1464/comments","review_comment_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/1464/comments","statuses_url":"https://api.github.com/repos/kubernetes/autoscaler/statuses/81d342b0f230f69daccab3109ec6de18dfffb065","head":{"label":"losipiuk:lo/stockouts2","ref":"lo/stockouts2","sha":"81d342b0f230f69daccab3109ec6de18dfffb065","user":{"login":"losipiuk","id":890111,"node_id":"MDQ6VXNlcjg5MDExMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"repo":{"id":130706569,"node_id":"MDEwOlJlcG9zaXRvcnkxMzA3MDY1Njk=","name":"autoscaler","full_name":"losipiuk/autoscaler","private":false,"owner":{"login":"losipiuk","id":890111,"node_id":"MDQ6VXNlcjg5MDExMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/890111?v=4","gravatar_id":"","url":"https://api.github.com/users/losipiuk","html_url":"https://github.com/losipiuk","followers_url":"https://api.github.com/users/losipiuk/followers","following_url":"https://api.github.com/users/losipiuk/following{/other_user}","gists_url":"https://api.github.com/users/losipiuk/gists{/gist_id}","starred_url":"https://api.github.com/users/losipiuk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/losipiuk/subscriptions","organizations_url":"https://api.github.com/users/losipiuk/orgs","repos_url":"https://api.github.com/users/losipiuk/repos","events_url":"https://api.github.com/users/losipiuk/events{/privacy}","received_events_url":"https://api.github.com/users/losipiuk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/losipiuk/autoscaler","description":"Autoscaling components for Kubernetes","fork":true,"url":"https://api.github.com/repos/losipiuk/autoscaler","forks_url":"https://api.github.com/repos/losipiuk/autoscaler/forks","keys_url":"https://api.github.com/repos/losipiuk/autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/losipiuk/autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/losipiuk/autoscaler/teams","hooks_url":"https://api.github.com/repos/losipiuk/autoscaler/hooks","issue_events_url":"https://api.github.com/repos/losipiuk/autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/losipiuk/autoscaler/events","assignees_url":"https://api.github.com/repos/losipiuk/autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/losipiuk/autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/losipiuk/autoscaler/tags","blobs_url":"https://api.github.com/repos/losipiuk/autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/losipiuk/autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/losipiuk/autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/losipiuk/autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/losipiuk/autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/losipiuk/autoscaler/languages","stargazers_url":"https://api.github.com/repos/losipiuk/autoscaler/stargazers","contributors_url":"https://api.github.com/repos/losipiuk/autoscaler/contributors","subscribers_url":"https://api.github.com/repos/losipiuk/autoscaler/subscribers","subscription_url":"https://api.github.com/repos/losipiuk/autoscaler/subscription","commits_url":"https://api.github.com/repos/losipiuk/autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/losipiuk/autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/losipiuk/autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/losipiuk/autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/losipiuk/autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/losipiuk/autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/losipiuk/autoscaler/merges","archive_url":"https://api.github.com/repos/losipiuk/autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/losipiuk/autoscaler/downloads","issues_url":"https://api.github.com/repos/losipiuk/autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/losipiuk/autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/losipiuk/autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/losipiuk/autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/losipiuk/autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/losipiuk/autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/losipiuk/autoscaler/deployments","created_at":"2018-04-23T14:10:25Z","updated_at":"2018-04-23T14:10:30Z","pushed_at":"2018-12-07T15:21:42Z","git_url":"git://github.com/losipiuk/autoscaler.git","ssh_url":"git@github.com:losipiuk/autoscaler.git","clone_url":"https://github.com/losipiuk/autoscaler.git","svn_url":"https://github.com/losipiuk/autoscaler","homepage":"","size":64999,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"b68e4d99849ec91d2c90e8260f7d3a8f6bf3e189","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":87990209,"node_id":"MDEwOlJlcG9zaXRvcnk4Nzk5MDIwOQ==","name":"autoscaler","full_name":"kubernetes/autoscaler","private":false,"owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes/autoscaler","description":"Autoscaling components for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes/autoscaler","forks_url":"https://api.github.com/repos/kubernetes/autoscaler/forks","keys_url":"https://api.github.com/repos/kubernetes/autoscaler/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/autoscaler/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/autoscaler/teams","hooks_url":"https://api.github.com/repos/kubernetes/autoscaler/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/autoscaler/events","assignees_url":"https://api.github.com/repos/kubernetes/autoscaler/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/autoscaler/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/autoscaler/tags","blobs_url":"https://api.github.com/repos/kubernetes/autoscaler/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/autoscaler/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/autoscaler/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/autoscaler/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/autoscaler/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/autoscaler/languages","stargazers_url":"https://api.github.com/repos/kubernetes/autoscaler/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/autoscaler/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/autoscaler/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/autoscaler/subscription","commits_url":"https://api.github.com/repos/kubernetes/autoscaler/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/autoscaler/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/autoscaler/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/autoscaler/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/autoscaler/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/autoscaler/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/autoscaler/merges","archive_url":"https://api.github.com/repos/kubernetes/autoscaler/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/autoscaler/downloads","issues_url":"https://api.github.com/repos/kubernetes/autoscaler/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/autoscaler/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/autoscaler/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/autoscaler/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/autoscaler/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/autoscaler/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/autoscaler/deployments","created_at":"2017-04-12T00:03:40Z","updated_at":"2018-12-11T13:07:47Z","pushed_at":"2018-12-11T12:07:06Z","git_url":"git://github.com/kubernetes/autoscaler.git","ssh_url":"git@github.com:kubernetes/autoscaler.git","clone_url":"https://github.com/kubernetes/autoscaler.git","svn_url":"https://github.com/kubernetes/autoscaler","homepage":"","size":65071,"stargazers_count":1325,"watchers_count":1325,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":562,"mirror_url":null,"archived":false,"open_issues_count":94,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":562,"open_issues":94,"watchers":1325,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/1464"},"html":{"href":"https://github.com/kubernetes/autoscaler/pull/1464"},"issue":{"href":"https://api.github.com/repos/kubernetes/autoscaler/issues/1464"},"comments":{"href":"https://api.github.com/repos/kubernetes/autoscaler/issues/1464/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/1464/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/autoscaler/pulls/1464/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/autoscaler/statuses/81d342b0f230f69daccab3109ec6de18dfffb065"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"aleksandra-malinowska"}}