{"action":"created","comment":{"url":"https://api.github.com/repos/elifesciences/builder/pulls/comments/227707995","pull_request_review_id":167808477,"id":227707995,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzcwNzk5NQ==","diff_hunk":"@@ -1,2 +1,5 @@\n import logging\n-logging.disable(logging.CRITICAL)\n+\n+from buildercore.config import CONSOLE_HANDLER\n+\n+CONSOLE_HANDLER.setLevel(logging.CRITICAL)","path":"src/tests/__init__.py","position":null,"original_position":6,"commit_id":"eb8de1a896df389e025050fbabb6eb0c651b3196","original_commit_id":"b8f93ee3dcf3b288d9c592e00849f94acf799fd7","user":{"login":"de-code","id":1016473,"node_id":"MDQ6VXNlcjEwMTY0NzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1016473?v=4","gravatar_id":"","url":"https://api.github.com/users/de-code","html_url":"https://github.com/de-code","followers_url":"https://api.github.com/users/de-code/followers","following_url":"https://api.github.com/users/de-code/following{/other_user}","gists_url":"https://api.github.com/users/de-code/gists{/gist_id}","starred_url":"https://api.github.com/users/de-code/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/de-code/subscriptions","organizations_url":"https://api.github.com/users/de-code/orgs","repos_url":"https://api.github.com/users/de-code/repos","events_url":"https://api.github.com/users/de-code/events{/privacy}","received_events_url":"https://api.github.com/users/de-code/received_events","type":"User","site_admin":false},"body":"> Essentially there is too much output, so we disable most of the `CONSOLE_HANDLER` logs and leave `FILE_HANDLER` in place so that the logs can be seen in a file after the test run.\r\n\r\nWhen you say too much output, you mean too much shown or was it making it too slow? Because if it's failing, it seems good to have a lot of output. Usually it shouldn't fail and have no output. The file log however will have everything in it, for passing and failing tests.\r\nIf you see console output for passing tests, then there may be something wrong with the setup.\r\n\r\n> Yes, it could be, although maybe `src/tests/conftest.py` rather than the main one.\r\n\r\nBy that you mean the default logging level DEBUG? Yes, for tests I meant (i.e. in conftest). When running the application the default logging level would usually be INFO.\r\nOr do you mean another `conftest.py`?","created_at":"2018-10-24T09:21:24Z","updated_at":"2018-10-24T09:21:25Z","html_url":"https://github.com/elifesciences/builder/pull/290#discussion_r227707995","pull_request_url":"https://api.github.com/repos/elifesciences/builder/pulls/290","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/comments/227707995"},"html":{"href":"https://github.com/elifesciences/builder/pull/290#discussion_r227707995"},"pull_request":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/290"}},"in_reply_to_id":227469918},"pull_request":{"url":"https://api.github.com/repos/elifesciences/builder/pulls/290","id":183458081,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzNDU4MDgx","html_url":"https://github.com/elifesciences/builder/pull/290","diff_url":"https://github.com/elifesciences/builder/pull/290.diff","patch_url":"https://github.com/elifesciences/builder/pull/290.patch","issue_url":"https://api.github.com/repos/elifesciences/builder/issues/290","number":290,"state":"open","locked":false,"title":"Run tests in parallel","user":{"login":"giorgiosironi","id":160299,"node_id":"MDQ6VXNlcjE2MDI5OQ==","avatar_url":"https://avatars3.githubusercontent.com/u/160299?v=4","gravatar_id":"","url":"https://api.github.com/users/giorgiosironi","html_url":"https://github.com/giorgiosironi","followers_url":"https://api.github.com/users/giorgiosironi/followers","following_url":"https://api.github.com/users/giorgiosironi/following{/other_user}","gists_url":"https://api.github.com/users/giorgiosironi/gists{/gist_id}","starred_url":"https://api.github.com/users/giorgiosironi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giorgiosironi/subscriptions","organizations_url":"https://api.github.com/users/giorgiosironi/orgs","repos_url":"https://api.github.com/users/giorgiosironi/repos","events_url":"https://api.github.com/users/giorgiosironi/events{/privacy}","received_events_url":"https://api.github.com/users/giorgiosironi/received_events","type":"User","site_admin":false},"body":"~If this works and assuming CloudFormation rate limiting has been correctly solved, this could shave off 6-7 minutes in each build.~\r\n\r\nFinal result is 13-14 minutes rather than 30 per build.","created_at":"2018-04-23T14:43:59Z","updated_at":"2018-10-24T09:21:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"edb37c802f97f66712c37420d0420b4f541ce8d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/elifesciences/builder/pulls/290/commits","review_comments_url":"https://api.github.com/repos/elifesciences/builder/pulls/290/comments","review_comment_url":"https://api.github.com/repos/elifesciences/builder/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elifesciences/builder/issues/290/comments","statuses_url":"https://api.github.com/repos/elifesciences/builder/statuses/eb8de1a896df389e025050fbabb6eb0c651b3196","head":{"label":"elifesciences:parallel_testing","ref":"parallel_testing","sha":"eb8de1a896df389e025050fbabb6eb0c651b3196","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":56778863,"node_id":"MDEwOlJlcG9zaXRvcnk1Njc3ODg2Mw==","name":"builder","full_name":"elifesciences/builder","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/builder","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/builder","forks_url":"https://api.github.com/repos/elifesciences/builder/forks","keys_url":"https://api.github.com/repos/elifesciences/builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/builder/teams","hooks_url":"https://api.github.com/repos/elifesciences/builder/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/builder/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/builder/events","assignees_url":"https://api.github.com/repos/elifesciences/builder/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/builder/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/builder/tags","blobs_url":"https://api.github.com/repos/elifesciences/builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/builder/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/builder/languages","stargazers_url":"https://api.github.com/repos/elifesciences/builder/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/builder/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/builder/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/builder/subscription","commits_url":"https://api.github.com/repos/elifesciences/builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/builder/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/builder/merges","archive_url":"https://api.github.com/repos/elifesciences/builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/builder/downloads","issues_url":"https://api.github.com/repos/elifesciences/builder/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/builder/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/builder/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/builder/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/builder/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/builder/deployments","created_at":"2016-04-21T14:08:05Z","updated_at":"2018-10-23T10:03:25Z","pushed_at":"2018-10-24T09:15:40Z","git_url":"git://github.com/elifesciences/builder.git","ssh_url":"git@github.com:elifesciences/builder.git","clone_url":"https://github.com/elifesciences/builder.git","svn_url":"https://github.com/elifesciences/builder","homepage":null,"size":2632,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":8,"watchers":4,"default_branch":"master"}},"base":{"label":"elifesciences:master","ref":"master","sha":"86c8c3c854c7807537618207e6e6758cc2d303d2","user":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"repo":{"id":56778863,"node_id":"MDEwOlJlcG9zaXRvcnk1Njc3ODg2Mw==","name":"builder","full_name":"elifesciences/builder","private":false,"owner":{"login":"elifesciences","id":1777367,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3NzczNjc=","avatar_url":"https://avatars2.githubusercontent.com/u/1777367?v=4","gravatar_id":"","url":"https://api.github.com/users/elifesciences","html_url":"https://github.com/elifesciences","followers_url":"https://api.github.com/users/elifesciences/followers","following_url":"https://api.github.com/users/elifesciences/following{/other_user}","gists_url":"https://api.github.com/users/elifesciences/gists{/gist_id}","starred_url":"https://api.github.com/users/elifesciences/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elifesciences/subscriptions","organizations_url":"https://api.github.com/users/elifesciences/orgs","repos_url":"https://api.github.com/users/elifesciences/repos","events_url":"https://api.github.com/users/elifesciences/events{/privacy}","received_events_url":"https://api.github.com/users/elifesciences/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elifesciences/builder","description":null,"fork":false,"url":"https://api.github.com/repos/elifesciences/builder","forks_url":"https://api.github.com/repos/elifesciences/builder/forks","keys_url":"https://api.github.com/repos/elifesciences/builder/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elifesciences/builder/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elifesciences/builder/teams","hooks_url":"https://api.github.com/repos/elifesciences/builder/hooks","issue_events_url":"https://api.github.com/repos/elifesciences/builder/issues/events{/number}","events_url":"https://api.github.com/repos/elifesciences/builder/events","assignees_url":"https://api.github.com/repos/elifesciences/builder/assignees{/user}","branches_url":"https://api.github.com/repos/elifesciences/builder/branches{/branch}","tags_url":"https://api.github.com/repos/elifesciences/builder/tags","blobs_url":"https://api.github.com/repos/elifesciences/builder/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elifesciences/builder/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elifesciences/builder/git/refs{/sha}","trees_url":"https://api.github.com/repos/elifesciences/builder/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elifesciences/builder/statuses/{sha}","languages_url":"https://api.github.com/repos/elifesciences/builder/languages","stargazers_url":"https://api.github.com/repos/elifesciences/builder/stargazers","contributors_url":"https://api.github.com/repos/elifesciences/builder/contributors","subscribers_url":"https://api.github.com/repos/elifesciences/builder/subscribers","subscription_url":"https://api.github.com/repos/elifesciences/builder/subscription","commits_url":"https://api.github.com/repos/elifesciences/builder/commits{/sha}","git_commits_url":"https://api.github.com/repos/elifesciences/builder/git/commits{/sha}","comments_url":"https://api.github.com/repos/elifesciences/builder/comments{/number}","issue_comment_url":"https://api.github.com/repos/elifesciences/builder/issues/comments{/number}","contents_url":"https://api.github.com/repos/elifesciences/builder/contents/{+path}","compare_url":"https://api.github.com/repos/elifesciences/builder/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elifesciences/builder/merges","archive_url":"https://api.github.com/repos/elifesciences/builder/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elifesciences/builder/downloads","issues_url":"https://api.github.com/repos/elifesciences/builder/issues{/number}","pulls_url":"https://api.github.com/repos/elifesciences/builder/pulls{/number}","milestones_url":"https://api.github.com/repos/elifesciences/builder/milestones{/number}","notifications_url":"https://api.github.com/repos/elifesciences/builder/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elifesciences/builder/labels{/name}","releases_url":"https://api.github.com/repos/elifesciences/builder/releases{/id}","deployments_url":"https://api.github.com/repos/elifesciences/builder/deployments","created_at":"2016-04-21T14:08:05Z","updated_at":"2018-10-23T10:03:25Z","pushed_at":"2018-10-24T09:15:40Z","git_url":"git://github.com/elifesciences/builder.git","ssh_url":"git@github.com:elifesciences/builder.git","clone_url":"https://github.com/elifesciences/builder.git","svn_url":"https://github.com/elifesciences/builder","homepage":null,"size":2632,"stargazers_count":4,"watchers_count":4,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":8,"open_issues":8,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/290"},"html":{"href":"https://github.com/elifesciences/builder/pull/290"},"issue":{"href":"https://api.github.com/repos/elifesciences/builder/issues/290"},"comments":{"href":"https://api.github.com/repos/elifesciences/builder/issues/290/comments"},"review_comments":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/290/comments"},"review_comment":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elifesciences/builder/pulls/290/commits"},"statuses":{"href":"https://api.github.com/repos/elifesciences/builder/statuses/eb8de1a896df389e025050fbabb6eb0c651b3196"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"de-code"}}