{"action":"created","comment":{"url":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/comments/167031325","pull_request_review_id":95189369,"id":167031325,"diff_hunk":"@@ -8,23 +8,14 @@ terraform {\n }\n \n # ---------------------------------------------------------------------------------------------------------------------\n-# CREATE A GCE INSTANCE GROUP TO RUN CONSUL SERVER\n-# Ideally, we would run a \"regional\" Managed Instance Group that spans many Zones, but the Terraform GCP provider has\n-# not yet implemented https://github.com/terraform-providers/terraform-provider-google/issues/45, so we settle for a\n-# single-zone Managed Instance Group.\n+# CREATE A GCE REGION GROUP TO RUN CONSUL SERVER\n # ---------------------------------------------------------------------------------------------------------------------\n-\n-# Create the single-zone Managed Instance Group where Consul Server will live.\n-resource \"google_compute_instance_group_manager\" \"consul_server\" {\n+resource \"google_compute_region_instance_group_manager\" \"consul_server\" {\n   name = \"${var.cluster_name}-ig\"\n \n   base_instance_name = \"${var.cluster_name}\"\n   instance_template  = \"${data.template_file.compute_instance_template_self_link.rendered}\"\n-  zone               = \"${var.gcp_zone}\"\n-\n-  # Consul Server is a stateful cluster, so the update strategy used to roll out a new GCE Instance Template must be\n-  # a rolling update. But since Terraform does not yet support ROLLING_UPDATE, such updates must be manually rolled out.\n-  update_strategy = \"${var.instance_group_update_strategy}\"","path":"modules/consul-cluster/main.tf","position":22,"original_position":22,"commit_id":"cee03b2e5b72da37f854fc1f902a54bdfc455da8","original_commit_id":"cee03b2e5b72da37f854fc1f902a54bdfc455da8","user":{"login":"apenney","id":9492,"avatar_url":"https://avatars1.githubusercontent.com/u/9492?v=4","gravatar_id":"","url":"https://api.github.com/users/apenney","html_url":"https://github.com/apenney","followers_url":"https://api.github.com/users/apenney/followers","following_url":"https://api.github.com/users/apenney/following{/other_user}","gists_url":"https://api.github.com/users/apenney/gists{/gist_id}","starred_url":"https://api.github.com/users/apenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apenney/subscriptions","organizations_url":"https://api.github.com/users/apenney/orgs","repos_url":"https://api.github.com/users/apenney/repos","events_url":"https://api.github.com/users/apenney/events{/privacy}","received_events_url":"https://api.github.com/users/apenney/received_events","type":"User","site_admin":false},"body":"I don't I'm afraid.  I'm brand new to GCP.  I've been using rolling-replacement when tesing consul out and it's worked pretty well for me so far.  I'm still getting up to speed on GCP however. :/","created_at":"2018-02-08T18:48:14Z","updated_at":"2018-02-08T18:48:14Z","html_url":"https://github.com/hashicorp/terraform-google-consul/pull/3#discussion_r167031325","pull_request_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/3","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/comments/167031325"},"html":{"href":"https://github.com/hashicorp/terraform-google-consul/pull/3#discussion_r167031325"},"pull_request":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/3"}},"in_reply_to_id":164923298},"pull_request":{"url":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/3","id":165789888,"html_url":"https://github.com/hashicorp/terraform-google-consul/pull/3","diff_url":"https://github.com/hashicorp/terraform-google-consul/pull/3.diff","patch_url":"https://github.com/hashicorp/terraform-google-consul/pull/3.patch","issue_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/issues/3","number":3,"state":"open","locked":false,"title":"Switch to regional","user":{"login":"apenney","id":9492,"avatar_url":"https://avatars1.githubusercontent.com/u/9492?v=4","gravatar_id":"","url":"https://api.github.com/users/apenney","html_url":"https://github.com/apenney","followers_url":"https://api.github.com/users/apenney/followers","following_url":"https://api.github.com/users/apenney/following{/other_user}","gists_url":"https://api.github.com/users/apenney/gists{/gist_id}","starred_url":"https://api.github.com/users/apenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apenney/subscriptions","organizations_url":"https://api.github.com/users/apenney/orgs","repos_url":"https://api.github.com/users/apenney/repos","events_url":"https://api.github.com/users/apenney/events{/privacy}","received_events_url":"https://api.github.com/users/apenney/received_events","type":"User","site_admin":false},"body":"Hi!\r\n\r\nThanks for the module, first of all.  I took a stab at updating this to use a regional instance manager instead of zonal.  This is the first infra I've deployed into GCP so hopefully this makes sense.  I was able to test that my changes actually `apply` but that's the limit of my testing so far.","created_at":"2018-01-29T19:04:11Z","updated_at":"2018-02-08T18:48:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6a03c5fd9526c5309e53b4883e5fb0f16285f097","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/3/commits","review_comments_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/3/comments","review_comment_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/issues/3/comments","statuses_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/statuses/cee03b2e5b72da37f854fc1f902a54bdfc455da8","head":{"label":"apenney:switch-to-regional","ref":"switch-to-regional","sha":"cee03b2e5b72da37f854fc1f902a54bdfc455da8","user":{"login":"apenney","id":9492,"avatar_url":"https://avatars1.githubusercontent.com/u/9492?v=4","gravatar_id":"","url":"https://api.github.com/users/apenney","html_url":"https://github.com/apenney","followers_url":"https://api.github.com/users/apenney/followers","following_url":"https://api.github.com/users/apenney/following{/other_user}","gists_url":"https://api.github.com/users/apenney/gists{/gist_id}","starred_url":"https://api.github.com/users/apenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apenney/subscriptions","organizations_url":"https://api.github.com/users/apenney/orgs","repos_url":"https://api.github.com/users/apenney/repos","events_url":"https://api.github.com/users/apenney/events{/privacy}","received_events_url":"https://api.github.com/users/apenney/received_events","type":"User","site_admin":false},"repo":{"id":119425726,"name":"terraform-google-consul","full_name":"apenney/terraform-google-consul","owner":{"login":"apenney","id":9492,"avatar_url":"https://avatars1.githubusercontent.com/u/9492?v=4","gravatar_id":"","url":"https://api.github.com/users/apenney","html_url":"https://github.com/apenney","followers_url":"https://api.github.com/users/apenney/followers","following_url":"https://api.github.com/users/apenney/following{/other_user}","gists_url":"https://api.github.com/users/apenney/gists{/gist_id}","starred_url":"https://api.github.com/users/apenney/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apenney/subscriptions","organizations_url":"https://api.github.com/users/apenney/orgs","repos_url":"https://api.github.com/users/apenney/repos","events_url":"https://api.github.com/users/apenney/events{/privacy}","received_events_url":"https://api.github.com/users/apenney/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/apenney/terraform-google-consul","description":"A Terraform Module for how to run Consul on Google Cloud using Terraform and Packer","fork":true,"url":"https://api.github.com/repos/apenney/terraform-google-consul","forks_url":"https://api.github.com/repos/apenney/terraform-google-consul/forks","keys_url":"https://api.github.com/repos/apenney/terraform-google-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apenney/terraform-google-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apenney/terraform-google-consul/teams","hooks_url":"https://api.github.com/repos/apenney/terraform-google-consul/hooks","issue_events_url":"https://api.github.com/repos/apenney/terraform-google-consul/issues/events{/number}","events_url":"https://api.github.com/repos/apenney/terraform-google-consul/events","assignees_url":"https://api.github.com/repos/apenney/terraform-google-consul/assignees{/user}","branches_url":"https://api.github.com/repos/apenney/terraform-google-consul/branches{/branch}","tags_url":"https://api.github.com/repos/apenney/terraform-google-consul/tags","blobs_url":"https://api.github.com/repos/apenney/terraform-google-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apenney/terraform-google-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apenney/terraform-google-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/apenney/terraform-google-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apenney/terraform-google-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/apenney/terraform-google-consul/languages","stargazers_url":"https://api.github.com/repos/apenney/terraform-google-consul/stargazers","contributors_url":"https://api.github.com/repos/apenney/terraform-google-consul/contributors","subscribers_url":"https://api.github.com/repos/apenney/terraform-google-consul/subscribers","subscription_url":"https://api.github.com/repos/apenney/terraform-google-consul/subscription","commits_url":"https://api.github.com/repos/apenney/terraform-google-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/apenney/terraform-google-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/apenney/terraform-google-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/apenney/terraform-google-consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/apenney/terraform-google-consul/contents/{+path}","compare_url":"https://api.github.com/repos/apenney/terraform-google-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apenney/terraform-google-consul/merges","archive_url":"https://api.github.com/repos/apenney/terraform-google-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apenney/terraform-google-consul/downloads","issues_url":"https://api.github.com/repos/apenney/terraform-google-consul/issues{/number}","pulls_url":"https://api.github.com/repos/apenney/terraform-google-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/apenney/terraform-google-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/apenney/terraform-google-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apenney/terraform-google-consul/labels{/name}","releases_url":"https://api.github.com/repos/apenney/terraform-google-consul/releases{/id}","deployments_url":"https://api.github.com/repos/apenney/terraform-google-consul/deployments","created_at":"2018-01-29T18:50:54Z","updated_at":"2018-01-29T18:50:56Z","pushed_at":"2018-01-29T19:17:49Z","git_url":"git://github.com/apenney/terraform-google-consul.git","ssh_url":"git@github.com:apenney/terraform-google-consul.git","clone_url":"https://github.com/apenney/terraform-google-consul.git","svn_url":"https://github.com/apenney/terraform-google-consul","homepage":null,"size":336,"stargazers_count":0,"watchers_count":0,"language":"HCL","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hashicorp:master","ref":"master","sha":"dbd3a015385762eff0514ee885724dce740b0cb6","user":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"repo":{"id":103200834,"name":"terraform-google-consul","full_name":"hashicorp/terraform-google-consul","owner":{"login":"hashicorp","id":761456,"avatar_url":"https://avatars2.githubusercontent.com/u/761456?v=4","gravatar_id":"","url":"https://api.github.com/users/hashicorp","html_url":"https://github.com/hashicorp","followers_url":"https://api.github.com/users/hashicorp/followers","following_url":"https://api.github.com/users/hashicorp/following{/other_user}","gists_url":"https://api.github.com/users/hashicorp/gists{/gist_id}","starred_url":"https://api.github.com/users/hashicorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hashicorp/subscriptions","organizations_url":"https://api.github.com/users/hashicorp/orgs","repos_url":"https://api.github.com/users/hashicorp/repos","events_url":"https://api.github.com/users/hashicorp/events{/privacy}","received_events_url":"https://api.github.com/users/hashicorp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hashicorp/terraform-google-consul","description":"A Terraform Module for how to run Consul on Google Cloud using Terraform and Packer","fork":false,"url":"https://api.github.com/repos/hashicorp/terraform-google-consul","forks_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/forks","keys_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/teams","hooks_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/hooks","issue_events_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/issues/events{/number}","events_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/events","assignees_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/assignees{/user}","branches_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/branches{/branch}","tags_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/tags","blobs_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/git/refs{/sha}","trees_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/statuses/{sha}","languages_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/languages","stargazers_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/stargazers","contributors_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/contributors","subscribers_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/subscribers","subscription_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/subscription","commits_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/commits{/sha}","git_commits_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/git/commits{/sha}","comments_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/comments{/number}","issue_comment_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/issues/comments{/number}","contents_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/contents/{+path}","compare_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/merges","archive_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/downloads","issues_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/issues{/number}","pulls_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls{/number}","milestones_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/milestones{/number}","notifications_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/labels{/name}","releases_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/releases{/id}","deployments_url":"https://api.github.com/repos/hashicorp/terraform-google-consul/deployments","created_at":"2017-09-12T00:10:37Z","updated_at":"2018-01-28T12:34:21Z","pushed_at":"2018-01-29T19:17:50Z","git_url":"git://github.com/hashicorp/terraform-google-consul.git","ssh_url":"git@github.com:hashicorp/terraform-google-consul.git","clone_url":"https://github.com/hashicorp/terraform-google-consul.git","svn_url":"https://github.com/hashicorp/terraform-google-consul","homepage":null,"size":334,"stargazers_count":10,"watchers_count":10,"language":"HCL","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":3,"watchers":10,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/3"},"html":{"href":"https://github.com/hashicorp/terraform-google-consul/pull/3"},"issue":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/issues/3"},"comments":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/issues/3/comments"},"review_comments":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/3/comments"},"review_comment":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/pulls/3/commits"},"statuses":{"href":"https://api.github.com/repos/hashicorp/terraform-google-consul/statuses/cee03b2e5b72da37f854fc1f902a54bdfc455da8"}},"author_association":"NONE"}}
{"actor":{"display_login":"apenney"}}