{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/236272794","pull_request_review_id":178309602,"id":236272794,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNjI3Mjc5NA==","diff_hunk":"@@ -342,7 +342,7 @@ int execute_tests( int args, const char ** argv )\n     void ** params = NULL;\n     uint8_t * data = NULL, * p = NULL;\n \n-    GREENTEA_SETUP( 180, \"mbedtls_test\" );\n+    GREENTEA_SETUP( 800, \"mbedtls_test\" );","path":"tests/suites/target_test.function","position":5,"original_position":5,"commit_id":"ff131e51eb8b66cc23ec87b6579459b37eb49967","original_commit_id":"cc533fa80ec9c1bdffa66a96a9c48302462322c4","user":{"login":"Patater","id":410816,"node_id":"MDQ6VXNlcjQxMDgxNg==","avatar_url":"https://avatars0.githubusercontent.com/u/410816?v=4","gravatar_id":"","url":"https://api.github.com/users/Patater","html_url":"https://github.com/Patater","followers_url":"https://api.github.com/users/Patater/followers","following_url":"https://api.github.com/users/Patater/following{/other_user}","gists_url":"https://api.github.com/users/Patater/gists{/gist_id}","starred_url":"https://api.github.com/users/Patater/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Patater/subscriptions","organizations_url":"https://api.github.com/users/Patater/orgs","repos_url":"https://api.github.com/users/Patater/repos","events_url":"https://api.github.com/users/Patater/events{/privacy}","received_events_url":"https://api.github.com/users/Patater/received_events","type":"User","site_admin":false},"body":"What's the smallest timeout that works today for the platforms in our CI? 800 seems really long. Over 10 minutes!","created_at":"2018-11-26T14:22:18Z","updated_at":"2018-11-26T14:22:24Z","html_url":"https://github.com/ARMmbed/mbedtls/pull/2230#discussion_r236272794","pull_request_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2230","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments/236272794"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/2230#discussion_r236272794"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2230"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2230","id":233375824,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzMzc1ODI0","html_url":"https://github.com/ARMmbed/mbedtls/pull/2230","diff_url":"https://github.com/ARMmbed/mbedtls/pull/2230.diff","patch_url":"https://github.com/ARMmbed/mbedtls/pull/2230.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/2230","number":2230,"state":"open","locked":false,"title":"Address RSA related tests","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"body":"## Description\r\n4 RSA related tests fail on target because of stack overflows and timeouts.\r\nThis PR, reduces the crease stack usage of these tests, and increases the timeout used in the test suites.\r\nresolves most of the issues in #2194 \r\n\r\n## Status\r\n**READY**\r\n\r\n## Requires Backporting\r\nSince On Target Tests feature was introduced on version 2.13, and there hasn't been an LTS branch since,  this feature is not mandatory to be backported, but it would be nice to have it backported.\r\n\r\n\r\n## Additional comments\r\nThe tests would succeed only when setting `MBEDTLS_MPI_MAX_SIZE` to 512, in contrast of the default 1012 bytes.\r\nTested on K54F and on NRF52840_DK\r\n\r\n## Todos\r\n- [x] Tests\r\n- [ ] Documentation\r\n- [ ] Changelog updated\r\n- [ ] Backported\r\n\r\n\r\n## Steps to test or reproduce\r\nRun the `features-mbedtls-tests-mbedtls-test_suite_pk`, `features-mbedtls-tests-mbedtls-test_suite_pkcs1_v21`, `features-mbedtls-tests-mbedtls-test_suite_pkcs1_v15` and `features-mbedtls-tests-mbedtls-test_suite_rsa` on target. \r\n","created_at":"2018-11-25T13:33:53Z","updated_at":"2018-11-26T14:22:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f62f7147954587fd8c35face599f4a8decabcac3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":19280384,"node_id":"MDU6TGFiZWwxOTI4MDM4NA==","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/bug","name":"bug","color":"d93f0b","default":true},{"id":937148743,"node_id":"MDU6TGFiZWw5MzcxNDg3NDM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/component:%20Crypto","name":"component: Crypto","color":"F5F6CE","default":false},{"id":408190313,"node_id":"MDU6TGFiZWw0MDgxOTAzMTM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/mbed%20TLS%20team","name":"mbed TLS team","color":"66e0ff","default":false},{"id":705358813,"node_id":"MDU6TGFiZWw3MDUzNTg4MTM=","url":"https://api.github.com/repos/ARMmbed/mbedtls/labels/needs:%20review","name":"needs: review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2230/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2230/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/2230/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/ff131e51eb8b66cc23ec87b6579459b37eb49967","head":{"label":"RonEld:2629","ref":"2629","sha":"ff131e51eb8b66cc23ec87b6579459b37eb49967","user":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"repo":{"id":76245223,"node_id":"MDEwOlJlcG9zaXRvcnk3NjI0NTIyMw==","name":"mbedtls","full_name":"RonEld/mbedtls","private":false,"owner":{"login":"RonEld","id":22030476,"node_id":"MDQ6VXNlcjIyMDMwNDc2","avatar_url":"https://avatars0.githubusercontent.com/u/22030476?v=4","gravatar_id":"","url":"https://api.github.com/users/RonEld","html_url":"https://github.com/RonEld","followers_url":"https://api.github.com/users/RonEld/followers","following_url":"https://api.github.com/users/RonEld/following{/other_user}","gists_url":"https://api.github.com/users/RonEld/gists{/gist_id}","starred_url":"https://api.github.com/users/RonEld/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RonEld/subscriptions","organizations_url":"https://api.github.com/users/RonEld/orgs","repos_url":"https://api.github.com/users/RonEld/repos","events_url":"https://api.github.com/users/RonEld/events{/privacy}","received_events_url":"https://api.github.com/users/RonEld/received_events","type":"User","site_admin":false},"html_url":"https://github.com/RonEld/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":true,"url":"https://api.github.com/repos/RonEld/mbedtls","forks_url":"https://api.github.com/repos/RonEld/mbedtls/forks","keys_url":"https://api.github.com/repos/RonEld/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RonEld/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RonEld/mbedtls/teams","hooks_url":"https://api.github.com/repos/RonEld/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/RonEld/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/RonEld/mbedtls/events","assignees_url":"https://api.github.com/repos/RonEld/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/RonEld/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/RonEld/mbedtls/tags","blobs_url":"https://api.github.com/repos/RonEld/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RonEld/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RonEld/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/RonEld/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RonEld/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/RonEld/mbedtls/languages","stargazers_url":"https://api.github.com/repos/RonEld/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/RonEld/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/RonEld/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/RonEld/mbedtls/subscription","commits_url":"https://api.github.com/repos/RonEld/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/RonEld/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/RonEld/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/RonEld/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/RonEld/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/RonEld/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RonEld/mbedtls/merges","archive_url":"https://api.github.com/repos/RonEld/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RonEld/mbedtls/downloads","issues_url":"https://api.github.com/repos/RonEld/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/RonEld/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/RonEld/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/RonEld/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RonEld/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/RonEld/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/RonEld/mbedtls/deployments","created_at":"2016-12-12T10:14:13Z","updated_at":"2018-11-05T14:00:17Z","pushed_at":"2018-11-26T12:25:55Z","git_url":"git://github.com/RonEld/mbedtls.git","ssh_url":"git@github.com:RonEld/mbedtls.git","clone_url":"https://github.com/RonEld/mbedtls.git","svn_url":"https://github.com/RonEld/mbedtls","homepage":"https://tls.mbed.org","size":31520,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"ARMmbed:development","ref":"development","sha":"556d7d9e3b09157555310466a47e25a9ebfd8f4e","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":6687936,"node_id":"MDEwOlJlcG9zaXRvcnk2Njg3OTM2","name":"mbedtls","full_name":"ARMmbed/mbedtls","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbedtls","description":"An open source, portable, easy to use, readable and flexible SSL library","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbedtls","forks_url":"https://api.github.com/repos/ARMmbed/mbedtls/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbedtls/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbedtls/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbedtls/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbedtls/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbedtls/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbedtls/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbedtls/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbedtls/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbedtls/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbedtls/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbedtls/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbedtls/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbedtls/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbedtls/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbedtls/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbedtls/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbedtls/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbedtls/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbedtls/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbedtls/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbedtls/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbedtls/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbedtls/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbedtls/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbedtls/deployments","created_at":"2012-11-14T13:13:13Z","updated_at":"2018-11-25T11:47:39Z","pushed_at":"2018-11-26T14:21:34Z","git_url":"git://github.com/ARMmbed/mbedtls.git","ssh_url":"git@github.com:ARMmbed/mbedtls.git","clone_url":"https://github.com/ARMmbed/mbedtls.git","svn_url":"https://github.com/ARMmbed/mbedtls","homepage":"https://tls.mbed.org","size":32203,"stargazers_count":1658,"watchers_count":1658,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":973,"mirror_url":null,"archived":false,"open_issues_count":599,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":973,"open_issues":599,"watchers":1658,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2230"},"html":{"href":"https://github.com/ARMmbed/mbedtls/pull/2230"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/2230"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/issues/2230/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2230/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/pulls/2230/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbedtls/statuses/ff131e51eb8b66cc23ec87b6579459b37eb49967"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Patater"}}