{"action":"closed","number":4622,"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4622","id":213665365,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzNjY1MzY1","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4622","diff_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4622.diff","patch_url":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4622.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4622","number":4622,"state":"closed","locked":false,"title":"global pack - move angular, and all npm angular modules to the globals pack","user":{"login":"himdel","id":289743,"node_id":"MDQ6VXNlcjI4OTc0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"body":"Angular modules which need to be compiled via webpack must be loaded from the globals pack, not the asset pipeline.\r\nBut, angular modules also need to be loaded after angular.\r\n\r\nThus, we need to load angular in the globals pack too :).\r\n\r\nMoving that, and any npmfied angular modules there. (with the exception of angular-bootstrap-switch which depends on bootstrap-switch)\r\n\r\n(and added FIXME annotations to the relevant angular module dependencies (angular validators is missing the index.js file so far))\r\n\r\nIssue #3734 ","created_at":"2018-09-06T15:45:17Z","updated_at":"2018-09-07T09:36:33Z","closed_at":"2018-09-07T09:36:33Z","merged_at":"2018-09-07T09:36:33Z","merge_commit_sha":"0a8a9f44c9cabce4da8da9483201165b3496471c","assignee":{"login":"mzazrivec","id":6648365,"node_id":"MDQ6VXNlcjY2NDgzNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6648365?v=4","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false},"assignees":[{"login":"mzazrivec","id":6648365,"node_id":"MDQ6VXNlcjY2NDgzNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6648365?v=4","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":544439308,"node_id":"MDU6TGFiZWw1NDQ0MzkzMDg=","url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels/dependencies","name":"dependencies","color":"b4a8d1","default":false}],"milestone":{"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones/52","html_url":"https://github.com/ManageIQ/manageiq-ui-classic/milestone/52","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones/52/labels","id":3604088,"node_id":"MDk6TWlsZXN0b25lMzYwNDA4OA==","number":52,"title":"Sprint 94 Ending Sep 10, 2018","description":"","creator":{"login":"simaishi","id":12955530,"node_id":"MDQ6VXNlcjEyOTU1NTMw","avatar_url":"https://avatars2.githubusercontent.com/u/12955530?v=4","gravatar_id":"","url":"https://api.github.com/users/simaishi","html_url":"https://github.com/simaishi","followers_url":"https://api.github.com/users/simaishi/followers","following_url":"https://api.github.com/users/simaishi/following{/other_user}","gists_url":"https://api.github.com/users/simaishi/gists{/gist_id}","starred_url":"https://api.github.com/users/simaishi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simaishi/subscriptions","organizations_url":"https://api.github.com/users/simaishi/orgs","repos_url":"https://api.github.com/users/simaishi/repos","events_url":"https://api.github.com/users/simaishi/events{/privacy}","received_events_url":"https://api.github.com/users/simaishi/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":68,"state":"open","created_at":"2018-08-28T14:07:17Z","updated_at":"2018-09-07T09:36:33Z","due_on":"2018-09-10T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4622/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4622/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4622/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/a3cf77ede96caaac632e2f6c3365c99025083783","head":{"label":"himdel:global-angular","ref":"global-angular","sha":"a3cf77ede96caaac632e2f6c3365c99025083783","user":{"login":"himdel","id":289743,"node_id":"MDQ6VXNlcjI4OTc0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"repo":{"id":77144144,"node_id":"MDEwOlJlcG9zaXRvcnk3NzE0NDE0NA==","name":"manageiq-ui-classic","full_name":"himdel/manageiq-ui-classic","owner":{"login":"himdel","id":289743,"node_id":"MDQ6VXNlcjI4OTc0Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/289743?v=4","gravatar_id":"","url":"https://api.github.com/users/himdel","html_url":"https://github.com/himdel","followers_url":"https://api.github.com/users/himdel/followers","following_url":"https://api.github.com/users/himdel/following{/other_user}","gists_url":"https://api.github.com/users/himdel/gists{/gist_id}","starred_url":"https://api.github.com/users/himdel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/himdel/subscriptions","organizations_url":"https://api.github.com/users/himdel/orgs","repos_url":"https://api.github.com/users/himdel/repos","events_url":"https://api.github.com/users/himdel/events{/privacy}","received_events_url":"https://api.github.com/users/himdel/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/himdel/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":true,"url":"https://api.github.com/repos/himdel/manageiq-ui-classic","forks_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/himdel/manageiq-ui-classic/deployments","created_at":"2016-12-22T12:48:46Z","updated_at":"2018-08-27T11:58:10Z","pushed_at":"2018-09-07T09:00:51Z","git_url":"git://github.com/himdel/manageiq-ui-classic.git","ssh_url":"git@github.com:himdel/manageiq-ui-classic.git","clone_url":"https://github.com/himdel/manageiq-ui-classic.git","svn_url":"https://github.com/himdel/manageiq-ui-classic","homepage":null,"size":65792,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"2d7b2da2bf7c4834f6944550e85bf7171c2390e9","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":77085298,"node_id":"MDEwOlJlcG9zaXRvcnk3NzA4NTI5OA==","name":"manageiq-ui-classic","full_name":"ManageIQ/manageiq-ui-classic","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-ui-classic","description":"Classic UI of ManageIQ","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/deployments","created_at":"2016-12-21T20:53:08Z","updated_at":"2018-09-07T08:56:19Z","pushed_at":"2018-09-07T09:36:33Z","git_url":"git://github.com/ManageIQ/manageiq-ui-classic.git","ssh_url":"git@github.com:ManageIQ/manageiq-ui-classic.git","clone_url":"https://github.com/ManageIQ/manageiq-ui-classic.git","svn_url":"https://github.com/ManageIQ/manageiq-ui-classic","homepage":null,"size":67101,"stargazers_count":30,"watchers_count":30,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":253,"mirror_url":null,"archived":false,"open_issues_count":265,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":253,"open_issues":265,"watchers":30,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4622"},"html":{"href":"https://github.com/ManageIQ/manageiq-ui-classic/pull/4622"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4622"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/issues/4622/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4622/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/pulls/4622/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-ui-classic/statuses/a3cf77ede96caaac632e2f6c3365c99025083783"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"mzazrivec","id":6648365,"node_id":"MDQ6VXNlcjY2NDgzNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/6648365?v=4","gravatar_id":"","url":"https://api.github.com/users/mzazrivec","html_url":"https://github.com/mzazrivec","followers_url":"https://api.github.com/users/mzazrivec/followers","following_url":"https://api.github.com/users/mzazrivec/following{/other_user}","gists_url":"https://api.github.com/users/mzazrivec/gists{/gist_id}","starred_url":"https://api.github.com/users/mzazrivec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzazrivec/subscriptions","organizations_url":"https://api.github.com/users/mzazrivec/orgs","repos_url":"https://api.github.com/users/mzazrivec/repos","events_url":"https://api.github.com/users/mzazrivec/events{/privacy}","received_events_url":"https://api.github.com/users/mzazrivec/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":7,"deletions":6,"changed_files":3}}
{"actor":{"display_login":"mzazrivec"}}