{"action":"created","issue":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/5741","repository_url":"https://api.github.com/repos/mozilla/addons-frontend","labels_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/5741/labels{/name}","comments_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/5741/comments","events_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/5741/events","html_url":"https://github.com/mozilla/addons-frontend/pull/5741","id":344861937,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MTU2MjA1","number":5741,"title":"Add Hybrid Content Telemetry","user":{"login":"muffinresearch","id":1514,"node_id":"MDQ6VXNlcjE1MTQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1514?v=4","gravatar_id":"","url":"https://api.github.com/users/muffinresearch","html_url":"https://github.com/muffinresearch","followers_url":"https://api.github.com/users/muffinresearch/followers","following_url":"https://api.github.com/users/muffinresearch/following{/other_user}","gists_url":"https://api.github.com/users/muffinresearch/gists{/gist_id}","starred_url":"https://api.github.com/users/muffinresearch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/muffinresearch/subscriptions","organizations_url":"https://api.github.com/users/muffinresearch/orgs","repos_url":"https://api.github.com/users/muffinresearch/repos","events_url":"https://api.github.com/users/muffinresearch/events{/privacy}","received_events_url":"https://api.github.com/users/muffinresearch/received_events","type":"User","site_admin":false},"labels":[{"id":389820033,"node_id":"MDU6TGFiZWwzODk4MjAwMzM=","url":"https://api.github.com/repos/mozilla/addons-frontend/labels/state:%20blocked%20by%20upstream","name":"state: blocked by upstream","color":"ffa500","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-26T14:12:47Z","updated_at":"2018-07-30T16:57:50Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/mozilla/addons-frontend/pulls/5741","html_url":"https://github.com/mozilla/addons-frontend/pull/5741","diff_url":"https://github.com/mozilla/addons-frontend/pull/5741.diff","patch_url":"https://github.com/mozilla/addons-frontend/pull/5741.patch"},"body":"Fixes #4528 \r\n\r\nThis branch adds support for Hybrid Content Telemetry tracking on the discovery pane. It's currently configured off, but once this passes review I'll enable it on -dev and it will need a data review before we turn it on in production.\r\n\r\nIf enabled it loads a separate library asset (it could be merged into the disco bundle if preferred.\r\n\r\nIn addition to the core HCT parts and tests along the way it implements:\r\n\r\n* Adds handling of dynamic imports (from a node perspective) to prevent build and test errors. This uses the es6 dynamic import syntax which is now preferred over things like require.ensure.\r\n* Adds some tests to protect tracking constants from modification.\r\n\r\nThe main tracking call is based on an initialization promise. This way if called too soon it will wait until the promise is resolved."},"comment":{"url":"https://api.github.com/repos/mozilla/addons-frontend/issues/comments/408935176","html_url":"https://github.com/mozilla/addons-frontend/pull/5741#issuecomment-408935176","issue_url":"https://api.github.com/repos/mozilla/addons-frontend/issues/5741","id":408935176,"node_id":"MDEyOklzc3VlQ29tbWVudDQwODkzNTE3Ng==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T16:57:50Z","updated_at":"2018-07-30T16:57:50Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/mozilla/addons-frontend/pull/5741?src=pr&el=h1) Report\n> Merging [#5741](https://codecov.io/gh/mozilla/addons-frontend/pull/5741?src=pr&el=desc) into [master](https://codecov.io/gh/mozilla/addons-frontend/commit/bf90b9c16421c3507be4e1b8e00d57a4b2068c04?src=pr&el=desc) will **decrease** coverage by `0.11%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/graphs/tree.svg?token=2sUjLSbTcC&src=pr&height=150&width=650)](https://codecov.io/gh/mozilla/addons-frontend/pull/5741?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #5741      +/-   ##\n==========================================\n- Coverage   97.25%   97.14%   -0.12%     \n==========================================\n  Files         228      226       -2     \n  Lines        5678     5700      +22     \n  Branches     1093     1095       +2     \n==========================================\n+ Hits         5522     5537      +15     \n- Misses        136      145       +9     \n+ Partials       20       18       -2\n```\n\n\n| [Impacted Files](https://codecov.io/gh/mozilla/addons-frontend/pull/5741?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [src/disco/client.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2Rpc2NvL2NsaWVudC5qcw==) | `0% <ø> (ø)` | :arrow_up: |\n| [src/core/tracking.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2NvcmUvdHJhY2tpbmcuanM=) | `100% <100%> (+1.69%)` | :arrow_up: |\n| [src/core/server/base.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2NvcmUvc2VydmVyL2Jhc2UuanM=) | `57.29% <0%> (-0.33%)` | :arrow_down: |\n| [src/amo/components/CategoriesPage/index.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2Ftby9jb21wb25lbnRzL0NhdGVnb3JpZXNQYWdlL2luZGV4Lmpz) | `100% <0%> (ø)` | :arrow_up: |\n| [src/amo/client.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2Ftby9jbGllbnQuanM=) | `0% <0%> (ø)` | :arrow_up: |\n| [src/disco/components/App/index.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2Rpc2NvL2NvbXBvbmVudHMvQXBwL2luZGV4Lmpz) | `100% <0%> (ø)` | :arrow_up: |\n| [src/core/components/InstallButton/index.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2NvcmUvY29tcG9uZW50cy9JbnN0YWxsQnV0dG9uL2luZGV4Lmpz) | `100% <0%> (ø)` | :arrow_up: |\n| [src/disco/store.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2Rpc2NvL3N0b3JlLmpz) | `100% <0%> (ø)` | :arrow_up: |\n| [src/core/client/base.js](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree#diff-c3JjL2NvcmUvY2xpZW50L2Jhc2UuanM=) | `0% <0%> (ø)` | :arrow_up: |\n| ... and [25 more](https://codecov.io/gh/mozilla/addons-frontend/pull/5741/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/mozilla/addons-frontend/pull/5741?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/mozilla/addons-frontend/pull/5741?src=pr&el=footer). Last update [bf90b9c...bf97272](https://codecov.io/gh/mozilla/addons-frontend/pull/5741?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}