{"action":"created","issue":{"url":"https://api.github.com/repos/fmtlib/fmt/issues/674","repository_url":"https://api.github.com/repos/fmtlib/fmt","labels_url":"https://api.github.com/repos/fmtlib/fmt/issues/674/labels{/name}","comments_url":"https://api.github.com/repos/fmtlib/fmt/issues/674/comments","events_url":"https://api.github.com/repos/fmtlib/fmt/issues/674/events","html_url":"https://github.com/fmtlib/fmt/issues/674","id":303779841,"number":674,"title":"Build error \"fmt/bundled/format.h:447:58: error: ‘_ecvt_s’ was not declared in this scope\" on Unbuntu 17.10 (glibc 2.26)","user":{"login":"svadum","id":22641386,"avatar_url":"https://avatars3.githubusercontent.com/u/22641386?v=4","gravatar_id":"","url":"https://api.github.com/users/svadum","html_url":"https://github.com/svadum","followers_url":"https://api.github.com/users/svadum/followers","following_url":"https://api.github.com/users/svadum/following{/other_user}","gists_url":"https://api.github.com/users/svadum/gists{/gist_id}","starred_url":"https://api.github.com/users/svadum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/svadum/subscriptions","organizations_url":"https://api.github.com/users/svadum/orgs","repos_url":"https://api.github.com/users/svadum/repos","events_url":"https://api.github.com/users/svadum/events{/privacy}","received_events_url":"https://api.github.com/users/svadum/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-03-09T09:41:06Z","updated_at":"2018-03-17T18:27:38Z","closed_at":null,"author_association":"NONE","body":"```\r\nstatic bool isnegative(double x)\r\n    {\r\n        using namespace fmt::internal;\r\n        if (const_check(sizeof(signbit(x)) == sizeof(bool) ||\r\n                        sizeof(signbit(x)) == sizeof(int)))\r\n        {\r\n            return signbit(x) != 0;\r\n        }\r\n        if (x < 0) return true;\r\n        if (!isnotanumber(x)) return false;\r\n        int dec = 0, sign = 0;\r\n        char buffer[2];  // The buffer size must be >= 2 or _ecvt_s will fail.\r\n        _ecvt_s(buffer, sizeof(buffer), x, 0, &dec, &sign); // glibc 2.26 - error: ‘_ecvt_s’ was not declared in this scope\r\n        return sign != 0;\r\n    }\r\n```"},"comment":{"url":"https://api.github.com/repos/fmtlib/fmt/issues/comments/373942060","html_url":"https://github.com/fmtlib/fmt/issues/674#issuecomment-373942060","issue_url":"https://api.github.com/repos/fmtlib/fmt/issues/674","id":373942060,"user":{"login":"Kronuz","id":56894,"avatar_url":"https://avatars1.githubusercontent.com/u/56894?v=4","gravatar_id":"","url":"https://api.github.com/users/Kronuz","html_url":"https://github.com/Kronuz","followers_url":"https://api.github.com/users/Kronuz/followers","following_url":"https://api.github.com/users/Kronuz/following{/other_user}","gists_url":"https://api.github.com/users/Kronuz/gists{/gist_id}","starred_url":"https://api.github.com/users/Kronuz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kronuz/subscriptions","organizations_url":"https://api.github.com/users/Kronuz/orgs","repos_url":"https://api.github.com/users/Kronuz/repos","events_url":"https://api.github.com/users/Kronuz/events{/privacy}","received_events_url":"https://api.github.com/users/Kronuz/received_events","type":"User","site_admin":false},"created_at":"2018-03-17T18:27:38Z","updated_at":"2018-03-17T18:27:38Z","author_association":"NONE","body":"Apparently, the dummy implementations of system functions such as `_ecvt_s` are declared inside the namespace `fmt::internal`, but used inside `std`. If the system functions are not available, maybe it should use those, but instead `error: ‘_ecvt_s’ was not declared in this scope` error will be emitted."}}
{"actor":{"display_login":"Kronuz"}}