{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/175918691","pull_request_review_id":105531792,"id":175918691,"diff_hunk":"@@ -24,8 +24,10 @@ be emitted either by client-side code or server-side code.\n \n ### Server-side example\n \n-The following illustrates a simple, plain-text HTTP/2 server using the\n-Core API:\n+The following illustrates a simple HTTP/2 server using the Core API.\n+Since there are no browsers known that support [unencrypted HTTP/2](HTTP/2 Unencrypted),","path":"doc/api/http2.md","position":null,"original_position":7,"commit_id":"7d2ff3842d51d1031fa2dedb36c424e28e98b274","original_commit_id":"c83205dcf8e9c5f497974039a879c13c383abee3","user":{"login":"styfle","id":229881,"avatar_url":"https://avatars1.githubusercontent.com/u/229881?v=4","gravatar_id":"","url":"https://api.github.com/users/styfle","html_url":"https://github.com/styfle","followers_url":"https://api.github.com/users/styfle/followers","following_url":"https://api.github.com/users/styfle/following{/other_user}","gists_url":"https://api.github.com/users/styfle/gists{/gist_id}","starred_url":"https://api.github.com/users/styfle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styfle/subscriptions","organizations_url":"https://api.github.com/users/styfle/orgs","repos_url":"https://api.github.com/users/styfle/repos","events_url":"https://api.github.com/users/styfle/events{/privacy}","received_events_url":"https://api.github.com/users/styfle/received_events","type":"User","site_admin":false},"body":"Whoa good catch, I just copy/pasted the code review comment so there must have been a typo.","created_at":"2018-03-20T20:53:30Z","updated_at":"2018-03-20T20:53:30Z","html_url":"https://github.com/nodejs/node/pull/19476#discussion_r175918691","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/19476","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/175918691"},"html":{"href":"https://github.com/nodejs/node/pull/19476#discussion_r175918691"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/19476"}},"in_reply_to_id":175893827},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19476","id":176184650,"html_url":"https://github.com/nodejs/node/pull/19476","diff_url":"https://github.com/nodejs/node/pull/19476.diff","patch_url":"https://github.com/nodejs/node/pull/19476.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/19476","number":19476,"state":"open","locked":false,"title":"doc: add note about browsers and HTTP/2","user":{"login":"styfle","id":229881,"avatar_url":"https://avatars1.githubusercontent.com/u/229881?v=4","gravatar_id":"","url":"https://api.github.com/users/styfle","html_url":"https://github.com/styfle","followers_url":"https://api.github.com/users/styfle/followers","following_url":"https://api.github.com/users/styfle/following{/other_user}","gists_url":"https://api.github.com/users/styfle/gists{/gist_id}","starred_url":"https://api.github.com/users/styfle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styfle/subscriptions","organizations_url":"https://api.github.com/users/styfle/orgs","repos_url":"https://api.github.com/users/styfle/repos","events_url":"https://api.github.com/users/styfle/events{/privacy}","received_events_url":"https://api.github.com/users/styfle/received_events","type":"User","site_admin":false},"body":"The docs were not clear for new users of HTTP/2 requires TLS in most browsers.\r\nThis adds a couple notes to direct new users to `http2.createSecureServer()`.\r\n\r\nFixes #19406\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n#### Affected core subsystem(s)\r\ndoc","created_at":"2018-03-20T13:09:20Z","updated_at":"2018-03-20T20:53:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"346c0c120c0268032026c06d7be36fb714236ade","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":754449534,"url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":155267517,"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false},{"id":746808418,"url":"https://api.github.com/repos/nodejs/node/labels/fast-track","name":"fast-track","color":"a989e5","default":false},{"id":647282877,"url":"https://api.github.com/repos/nodejs/node/labels/http2","name":"http2","color":"c2e0c6","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/19476/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/19476/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19476/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/7d2ff3842d51d1031fa2dedb36c424e28e98b274","head":{"label":"styfle:patch-2","ref":"patch-2","sha":"7d2ff3842d51d1031fa2dedb36c424e28e98b274","user":{"login":"styfle","id":229881,"avatar_url":"https://avatars1.githubusercontent.com/u/229881?v=4","gravatar_id":"","url":"https://api.github.com/users/styfle","html_url":"https://github.com/styfle","followers_url":"https://api.github.com/users/styfle/followers","following_url":"https://api.github.com/users/styfle/following{/other_user}","gists_url":"https://api.github.com/users/styfle/gists{/gist_id}","starred_url":"https://api.github.com/users/styfle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styfle/subscriptions","organizations_url":"https://api.github.com/users/styfle/orgs","repos_url":"https://api.github.com/users/styfle/repos","events_url":"https://api.github.com/users/styfle/events{/privacy}","received_events_url":"https://api.github.com/users/styfle/received_events","type":"User","site_admin":false},"repo":{"id":87324921,"name":"node","full_name":"styfle/node","owner":{"login":"styfle","id":229881,"avatar_url":"https://avatars1.githubusercontent.com/u/229881?v=4","gravatar_id":"","url":"https://api.github.com/users/styfle","html_url":"https://github.com/styfle","followers_url":"https://api.github.com/users/styfle/followers","following_url":"https://api.github.com/users/styfle/following{/other_user}","gists_url":"https://api.github.com/users/styfle/gists{/gist_id}","starred_url":"https://api.github.com/users/styfle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styfle/subscriptions","organizations_url":"https://api.github.com/users/styfle/orgs","repos_url":"https://api.github.com/users/styfle/repos","events_url":"https://api.github.com/users/styfle/events{/privacy}","received_events_url":"https://api.github.com/users/styfle/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/styfle/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/styfle/node","forks_url":"https://api.github.com/repos/styfle/node/forks","keys_url":"https://api.github.com/repos/styfle/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/styfle/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/styfle/node/teams","hooks_url":"https://api.github.com/repos/styfle/node/hooks","issue_events_url":"https://api.github.com/repos/styfle/node/issues/events{/number}","events_url":"https://api.github.com/repos/styfle/node/events","assignees_url":"https://api.github.com/repos/styfle/node/assignees{/user}","branches_url":"https://api.github.com/repos/styfle/node/branches{/branch}","tags_url":"https://api.github.com/repos/styfle/node/tags","blobs_url":"https://api.github.com/repos/styfle/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/styfle/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/styfle/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/styfle/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/styfle/node/statuses/{sha}","languages_url":"https://api.github.com/repos/styfle/node/languages","stargazers_url":"https://api.github.com/repos/styfle/node/stargazers","contributors_url":"https://api.github.com/repos/styfle/node/contributors","subscribers_url":"https://api.github.com/repos/styfle/node/subscribers","subscription_url":"https://api.github.com/repos/styfle/node/subscription","commits_url":"https://api.github.com/repos/styfle/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/styfle/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/styfle/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/styfle/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/styfle/node/contents/{+path}","compare_url":"https://api.github.com/repos/styfle/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/styfle/node/merges","archive_url":"https://api.github.com/repos/styfle/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/styfle/node/downloads","issues_url":"https://api.github.com/repos/styfle/node/issues{/number}","pulls_url":"https://api.github.com/repos/styfle/node/pulls{/number}","milestones_url":"https://api.github.com/repos/styfle/node/milestones{/number}","notifications_url":"https://api.github.com/repos/styfle/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/styfle/node/labels{/name}","releases_url":"https://api.github.com/repos/styfle/node/releases{/id}","deployments_url":"https://api.github.com/repos/styfle/node/deployments","created_at":"2017-04-05T15:18:48Z","updated_at":"2017-04-05T15:19:16Z","pushed_at":"2018-03-20T20:53:08Z","git_url":"git://github.com/styfle/node.git","ssh_url":"git@github.com:styfle/node.git","clone_url":"https://github.com/styfle/node.git","svn_url":"https://github.com/styfle/node","homepage":"https://nodejs.org","size":342463,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"5a4a1cba2445d71aadf4ebf4350090dfdb32d871","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-03-20T20:17:29Z","pushed_at":"2018-03-20T20:53:23Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":357809,"stargazers_count":46617,"watchers_count":46617,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9774,"mirror_url":null,"archived":false,"open_issues_count":893,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9774,"open_issues":893,"watchers":46617,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/19476"},"html":{"href":"https://github.com/nodejs/node/pull/19476"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/19476"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/19476/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/19476/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/19476/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/7d2ff3842d51d1031fa2dedb36c424e28e98b274"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"styfle"}}