{"action":"created","comment":{"url":"https://api.github.com/repos/PanDAWMS/dkb/pulls/comments/166236565","pull_request_review_id":94279236,"id":166236565,"diff_hunk":"@@ -1769,9 +1772,10 @@ def show_paper_visual(self, window, paper, e=False):\n                     else:\n                         header_row = False\n                         color = \"black\"\n-                    for l in row:\n-                        cnvs.create_rectangle((l.left, l.top + 10, l.right,\n-                                               l.bottom + 10), outline=color)\n+                    for line in row:\n+                        cnvs.create_rectangle((line.left, line.top + 10,\n+                                               line.right, line.bottom + 10),\n+                                              outline=color)","path":"Utils/Dataflow/030_PDFAnalyzer/manager.py","position":524,"original_position":429,"commit_id":"df41dc839d2843b40bedfad19eb56971583a31f1","original_commit_id":"5ba7a8f73bff4cb2c0425774e30840259adf66d0","user":{"login":"konvpalto","id":1582968,"avatar_url":"https://avatars1.githubusercontent.com/u/1582968?v=4","gravatar_id":"","url":"https://api.github.com/users/konvpalto","html_url":"https://github.com/konvpalto","followers_url":"https://api.github.com/users/konvpalto/followers","following_url":"https://api.github.com/users/konvpalto/following{/other_user}","gists_url":"https://api.github.com/users/konvpalto/gists{/gist_id}","starred_url":"https://api.github.com/users/konvpalto/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konvpalto/subscriptions","organizations_url":"https://api.github.com/users/konvpalto/orgs","repos_url":"https://api.github.com/users/konvpalto/repos","events_url":"https://api.github.com/users/konvpalto/events{/privacy}","received_events_url":"https://api.github.com/users/konvpalto/received_events","type":"User","site_admin":false},"body":"Yep, I was wrong here, thanks for revealing my mistake!","created_at":"2018-02-06T09:48:17Z","updated_at":"2018-02-06T09:48:17Z","html_url":"https://github.com/PanDAWMS/dkb/pull/96#discussion_r166236565","pull_request_url":"https://api.github.com/repos/PanDAWMS/dkb/pulls/96","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/PanDAWMS/dkb/pulls/comments/166236565"},"html":{"href":"https://github.com/PanDAWMS/dkb/pull/96#discussion_r166236565"},"pull_request":{"href":"https://api.github.com/repos/PanDAWMS/dkb/pulls/96"}},"in_reply_to_id":165084723},"pull_request":{"url":"https://api.github.com/repos/PanDAWMS/dkb/pulls/96","id":158031162,"html_url":"https://github.com/PanDAWMS/dkb/pull/96","diff_url":"https://github.com/PanDAWMS/dkb/pull/96.diff","patch_url":"https://github.com/PanDAWMS/dkb/pull/96.patch","issue_url":"https://api.github.com/repos/PanDAWMS/dkb/issues/96","number":96,"state":"open","locked":false,"title":"Travis: pep8 checks update","user":{"login":"mgolosova","id":10220547,"avatar_url":"https://avatars1.githubusercontent.com/u/10220547?v=4","gravatar_id":"","url":"https://api.github.com/users/mgolosova","html_url":"https://github.com/mgolosova","followers_url":"https://api.github.com/users/mgolosova/followers","following_url":"https://api.github.com/users/mgolosova/following{/other_user}","gists_url":"https://api.github.com/users/mgolosova/gists{/gist_id}","starred_url":"https://api.github.com/users/mgolosova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgolosova/subscriptions","organizations_url":"https://api.github.com/users/mgolosova/orgs","repos_url":"https://api.github.com/users/mgolosova/repos","events_url":"https://api.github.com/users/mgolosova/events{/privacy}","received_events_url":"https://api.github.com/users/mgolosova/received_events","type":"User","site_admin":false},"body":"As `pep8` is obsolete, we may switch to the recomended `pycodestyle`.\r\nHowever `pycodestyle` is a bit more strict about some things (see the Travis checks for this PR).\r\nParticularly, it suggests to:\r\n* E741: avoid ambiguous variable names (like 'l', 'O', 'I');\r\n* E722: avoid \"bare except\".\r\n\r\nThe first, I think, need no additional explaination. It is just a question of \"shell we pretend there`s no ambiguity\" or fix it now.\r\n\r\nFor the second I would refer to the PEP-8 itself:\r\n\r\n    A bare \"except:\" clause will catch SystemExit and KeyboardInterrupt exceptions,\r\n    making it harder to interrupt a program with Control-C, and can disguise other problems.\r\n    If you want to catch all exceptions that signal program errors, use \"except Exception:\"\r\n    (bare except is equivalent to \"except BaseException:\").\r\n\r\n    A good rule of thumb is to limit use of bare 'except' clauses to two cases:\r\n\r\n    1. If the exception handler will be printing out or logging the traceback;\r\n       at least the user will be aware that an error has occurred.\r\n    2. If the code needs to do some cleanup work, but then lets the exception\r\n       propagate upwards with raise. try...finally can be a better way to handle this case.\r\n\r\nIn those cases `pycodestyle` catches none of these two variants is not the case.\r\n\r\nI can fix both codestyle issues here (or authors could do it themselves, as I can ruin something by accident, especially in case of variable naming).\r\nOr I can add these two codes to ignore list of Travis checks, if there are any reasons we do intend to ignore it.\r\n\r\n---\r\n\r\n@Evildoor, mostly it affects the Stage 030, so I would like to hear from you in the comments.","created_at":"2017-12-13T08:34:16Z","updated_at":"2018-02-06T09:48:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b3d89a8ae3c58d7bce2ec3175de7db63c32bf0d9","assignee":{"login":"mgolosova","id":10220547,"avatar_url":"https://avatars1.githubusercontent.com/u/10220547?v=4","gravatar_id":"","url":"https://api.github.com/users/mgolosova","html_url":"https://github.com/mgolosova","followers_url":"https://api.github.com/users/mgolosova/followers","following_url":"https://api.github.com/users/mgolosova/following{/other_user}","gists_url":"https://api.github.com/users/mgolosova/gists{/gist_id}","starred_url":"https://api.github.com/users/mgolosova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgolosova/subscriptions","organizations_url":"https://api.github.com/users/mgolosova/orgs","repos_url":"https://api.github.com/users/mgolosova/repos","events_url":"https://api.github.com/users/mgolosova/events{/privacy}","received_events_url":"https://api.github.com/users/mgolosova/received_events","type":"User","site_admin":false},"assignees":[{"login":"mgolosova","id":10220547,"avatar_url":"https://avatars1.githubusercontent.com/u/10220547?v=4","gravatar_id":"","url":"https://api.github.com/users/mgolosova","html_url":"https://github.com/mgolosova","followers_url":"https://api.github.com/users/mgolosova/followers","following_url":"https://api.github.com/users/mgolosova/following{/other_user}","gists_url":"https://api.github.com/users/mgolosova/gists{/gist_id}","starred_url":"https://api.github.com/users/mgolosova/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgolosova/subscriptions","organizations_url":"https://api.github.com/users/mgolosova/orgs","repos_url":"https://api.github.com/users/mgolosova/repos","events_url":"https://api.github.com/users/mgolosova/events{/privacy}","received_events_url":"https://api.github.com/users/mgolosova/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/PanDAWMS/dkb/pulls/96/commits","review_comments_url":"https://api.github.com/repos/PanDAWMS/dkb/pulls/96/comments","review_comment_url":"https://api.github.com/repos/PanDAWMS/dkb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PanDAWMS/dkb/issues/96/comments","statuses_url":"https://api.github.com/repos/PanDAWMS/dkb/statuses/df41dc839d2843b40bedfad19eb56971583a31f1","head":{"label":"PanDAWMS:travis-pep8-update","ref":"travis-pep8-update","sha":"df41dc839d2843b40bedfad19eb56971583a31f1","user":{"login":"PanDAWMS","id":6588296,"avatar_url":"https://avatars0.githubusercontent.com/u/6588296?v=4","gravatar_id":"","url":"https://api.github.com/users/PanDAWMS","html_url":"https://github.com/PanDAWMS","followers_url":"https://api.github.com/users/PanDAWMS/followers","following_url":"https://api.github.com/users/PanDAWMS/following{/other_user}","gists_url":"https://api.github.com/users/PanDAWMS/gists{/gist_id}","starred_url":"https://api.github.com/users/PanDAWMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanDAWMS/subscriptions","organizations_url":"https://api.github.com/users/PanDAWMS/orgs","repos_url":"https://api.github.com/users/PanDAWMS/repos","events_url":"https://api.github.com/users/PanDAWMS/events{/privacy}","received_events_url":"https://api.github.com/users/PanDAWMS/received_events","type":"Organization","site_admin":false},"repo":{"id":89468107,"name":"dkb","full_name":"PanDAWMS/dkb","owner":{"login":"PanDAWMS","id":6588296,"avatar_url":"https://avatars0.githubusercontent.com/u/6588296?v=4","gravatar_id":"","url":"https://api.github.com/users/PanDAWMS","html_url":"https://github.com/PanDAWMS","followers_url":"https://api.github.com/users/PanDAWMS/followers","following_url":"https://api.github.com/users/PanDAWMS/following{/other_user}","gists_url":"https://api.github.com/users/PanDAWMS/gists{/gist_id}","starred_url":"https://api.github.com/users/PanDAWMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanDAWMS/subscriptions","organizations_url":"https://api.github.com/users/PanDAWMS/orgs","repos_url":"https://api.github.com/users/PanDAWMS/repos","events_url":"https://api.github.com/users/PanDAWMS/events{/privacy}","received_events_url":"https://api.github.com/users/PanDAWMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PanDAWMS/dkb","description":"Data Knowledge Base for HENP experiments","fork":false,"url":"https://api.github.com/repos/PanDAWMS/dkb","forks_url":"https://api.github.com/repos/PanDAWMS/dkb/forks","keys_url":"https://api.github.com/repos/PanDAWMS/dkb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PanDAWMS/dkb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PanDAWMS/dkb/teams","hooks_url":"https://api.github.com/repos/PanDAWMS/dkb/hooks","issue_events_url":"https://api.github.com/repos/PanDAWMS/dkb/issues/events{/number}","events_url":"https://api.github.com/repos/PanDAWMS/dkb/events","assignees_url":"https://api.github.com/repos/PanDAWMS/dkb/assignees{/user}","branches_url":"https://api.github.com/repos/PanDAWMS/dkb/branches{/branch}","tags_url":"https://api.github.com/repos/PanDAWMS/dkb/tags","blobs_url":"https://api.github.com/repos/PanDAWMS/dkb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PanDAWMS/dkb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PanDAWMS/dkb/git/refs{/sha}","trees_url":"https://api.github.com/repos/PanDAWMS/dkb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PanDAWMS/dkb/statuses/{sha}","languages_url":"https://api.github.com/repos/PanDAWMS/dkb/languages","stargazers_url":"https://api.github.com/repos/PanDAWMS/dkb/stargazers","contributors_url":"https://api.github.com/repos/PanDAWMS/dkb/contributors","subscribers_url":"https://api.github.com/repos/PanDAWMS/dkb/subscribers","subscription_url":"https://api.github.com/repos/PanDAWMS/dkb/subscription","commits_url":"https://api.github.com/repos/PanDAWMS/dkb/commits{/sha}","git_commits_url":"https://api.github.com/repos/PanDAWMS/dkb/git/commits{/sha}","comments_url":"https://api.github.com/repos/PanDAWMS/dkb/comments{/number}","issue_comment_url":"https://api.github.com/repos/PanDAWMS/dkb/issues/comments{/number}","contents_url":"https://api.github.com/repos/PanDAWMS/dkb/contents/{+path}","compare_url":"https://api.github.com/repos/PanDAWMS/dkb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PanDAWMS/dkb/merges","archive_url":"https://api.github.com/repos/PanDAWMS/dkb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PanDAWMS/dkb/downloads","issues_url":"https://api.github.com/repos/PanDAWMS/dkb/issues{/number}","pulls_url":"https://api.github.com/repos/PanDAWMS/dkb/pulls{/number}","milestones_url":"https://api.github.com/repos/PanDAWMS/dkb/milestones{/number}","notifications_url":"https://api.github.com/repos/PanDAWMS/dkb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PanDAWMS/dkb/labels{/name}","releases_url":"https://api.github.com/repos/PanDAWMS/dkb/releases{/id}","deployments_url":"https://api.github.com/repos/PanDAWMS/dkb/deployments","created_at":"2017-04-26T10:22:17Z","updated_at":"2017-05-26T11:13:20Z","pushed_at":"2018-02-05T14:12:26Z","git_url":"git://github.com/PanDAWMS/dkb.git","ssh_url":"git@github.com:PanDAWMS/dkb.git","clone_url":"https://github.com/PanDAWMS/dkb.git","svn_url":"https://github.com/PanDAWMS/dkb","homepage":"","size":37168,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":3,"open_issues":29,"watchers":0,"default_branch":"master"}},"base":{"label":"PanDAWMS:master","ref":"master","sha":"780a679b3f30c72b3f7641b5f23eb765b41304aa","user":{"login":"PanDAWMS","id":6588296,"avatar_url":"https://avatars0.githubusercontent.com/u/6588296?v=4","gravatar_id":"","url":"https://api.github.com/users/PanDAWMS","html_url":"https://github.com/PanDAWMS","followers_url":"https://api.github.com/users/PanDAWMS/followers","following_url":"https://api.github.com/users/PanDAWMS/following{/other_user}","gists_url":"https://api.github.com/users/PanDAWMS/gists{/gist_id}","starred_url":"https://api.github.com/users/PanDAWMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanDAWMS/subscriptions","organizations_url":"https://api.github.com/users/PanDAWMS/orgs","repos_url":"https://api.github.com/users/PanDAWMS/repos","events_url":"https://api.github.com/users/PanDAWMS/events{/privacy}","received_events_url":"https://api.github.com/users/PanDAWMS/received_events","type":"Organization","site_admin":false},"repo":{"id":89468107,"name":"dkb","full_name":"PanDAWMS/dkb","owner":{"login":"PanDAWMS","id":6588296,"avatar_url":"https://avatars0.githubusercontent.com/u/6588296?v=4","gravatar_id":"","url":"https://api.github.com/users/PanDAWMS","html_url":"https://github.com/PanDAWMS","followers_url":"https://api.github.com/users/PanDAWMS/followers","following_url":"https://api.github.com/users/PanDAWMS/following{/other_user}","gists_url":"https://api.github.com/users/PanDAWMS/gists{/gist_id}","starred_url":"https://api.github.com/users/PanDAWMS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PanDAWMS/subscriptions","organizations_url":"https://api.github.com/users/PanDAWMS/orgs","repos_url":"https://api.github.com/users/PanDAWMS/repos","events_url":"https://api.github.com/users/PanDAWMS/events{/privacy}","received_events_url":"https://api.github.com/users/PanDAWMS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/PanDAWMS/dkb","description":"Data Knowledge Base for HENP experiments","fork":false,"url":"https://api.github.com/repos/PanDAWMS/dkb","forks_url":"https://api.github.com/repos/PanDAWMS/dkb/forks","keys_url":"https://api.github.com/repos/PanDAWMS/dkb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PanDAWMS/dkb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PanDAWMS/dkb/teams","hooks_url":"https://api.github.com/repos/PanDAWMS/dkb/hooks","issue_events_url":"https://api.github.com/repos/PanDAWMS/dkb/issues/events{/number}","events_url":"https://api.github.com/repos/PanDAWMS/dkb/events","assignees_url":"https://api.github.com/repos/PanDAWMS/dkb/assignees{/user}","branches_url":"https://api.github.com/repos/PanDAWMS/dkb/branches{/branch}","tags_url":"https://api.github.com/repos/PanDAWMS/dkb/tags","blobs_url":"https://api.github.com/repos/PanDAWMS/dkb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PanDAWMS/dkb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PanDAWMS/dkb/git/refs{/sha}","trees_url":"https://api.github.com/repos/PanDAWMS/dkb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PanDAWMS/dkb/statuses/{sha}","languages_url":"https://api.github.com/repos/PanDAWMS/dkb/languages","stargazers_url":"https://api.github.com/repos/PanDAWMS/dkb/stargazers","contributors_url":"https://api.github.com/repos/PanDAWMS/dkb/contributors","subscribers_url":"https://api.github.com/repos/PanDAWMS/dkb/subscribers","subscription_url":"https://api.github.com/repos/PanDAWMS/dkb/subscription","commits_url":"https://api.github.com/repos/PanDAWMS/dkb/commits{/sha}","git_commits_url":"https://api.github.com/repos/PanDAWMS/dkb/git/commits{/sha}","comments_url":"https://api.github.com/repos/PanDAWMS/dkb/comments{/number}","issue_comment_url":"https://api.github.com/repos/PanDAWMS/dkb/issues/comments{/number}","contents_url":"https://api.github.com/repos/PanDAWMS/dkb/contents/{+path}","compare_url":"https://api.github.com/repos/PanDAWMS/dkb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PanDAWMS/dkb/merges","archive_url":"https://api.github.com/repos/PanDAWMS/dkb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PanDAWMS/dkb/downloads","issues_url":"https://api.github.com/repos/PanDAWMS/dkb/issues{/number}","pulls_url":"https://api.github.com/repos/PanDAWMS/dkb/pulls{/number}","milestones_url":"https://api.github.com/repos/PanDAWMS/dkb/milestones{/number}","notifications_url":"https://api.github.com/repos/PanDAWMS/dkb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PanDAWMS/dkb/labels{/name}","releases_url":"https://api.github.com/repos/PanDAWMS/dkb/releases{/id}","deployments_url":"https://api.github.com/repos/PanDAWMS/dkb/deployments","created_at":"2017-04-26T10:22:17Z","updated_at":"2017-05-26T11:13:20Z","pushed_at":"2018-02-05T14:12:26Z","git_url":"git://github.com/PanDAWMS/dkb.git","ssh_url":"git@github.com:PanDAWMS/dkb.git","clone_url":"https://github.com/PanDAWMS/dkb.git","svn_url":"https://github.com/PanDAWMS/dkb","homepage":"","size":37168,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":29,"license":null,"forks":3,"open_issues":29,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PanDAWMS/dkb/pulls/96"},"html":{"href":"https://github.com/PanDAWMS/dkb/pull/96"},"issue":{"href":"https://api.github.com/repos/PanDAWMS/dkb/issues/96"},"comments":{"href":"https://api.github.com/repos/PanDAWMS/dkb/issues/96/comments"},"review_comments":{"href":"https://api.github.com/repos/PanDAWMS/dkb/pulls/96/comments"},"review_comment":{"href":"https://api.github.com/repos/PanDAWMS/dkb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PanDAWMS/dkb/pulls/96/commits"},"statuses":{"href":"https://api.github.com/repos/PanDAWMS/dkb/statuses/df41dc839d2843b40bedfad19eb56971583a31f1"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"konvpalto"}}