{"action":"created","issue":{"url":"https://api.github.com/repos/aws/aws-dotnet-extensions-configuration/issues/19","repository_url":"https://api.github.com/repos/aws/aws-dotnet-extensions-configuration","labels_url":"https://api.github.com/repos/aws/aws-dotnet-extensions-configuration/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/aws/aws-dotnet-extensions-configuration/issues/19/comments","events_url":"https://api.github.com/repos/aws/aws-dotnet-extensions-configuration/issues/19/events","html_url":"https://github.com/aws/aws-dotnet-extensions-configuration/pull/19","id":389094092,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTczODQ0","number":19,"title":"Implement IAsyncLifetime in integ test","user":{"login":"sstevenkang","id":19806888,"node_id":"MDQ6VXNlcjE5ODA2ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/19806888?v=4","gravatar_id":"","url":"https://api.github.com/users/sstevenkang","html_url":"https://github.com/sstevenkang","followers_url":"https://api.github.com/users/sstevenkang/followers","following_url":"https://api.github.com/users/sstevenkang/following{/other_user}","gists_url":"https://api.github.com/users/sstevenkang/gists{/gist_id}","starred_url":"https://api.github.com/users/sstevenkang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sstevenkang/subscriptions","organizations_url":"https://api.github.com/users/sstevenkang/orgs","repos_url":"https://api.github.com/users/sstevenkang/repos","events_url":"https://api.github.com/users/sstevenkang/events{/privacy}","received_events_url":"https://api.github.com/users/sstevenkang/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"costleya","id":1572163,"node_id":"MDQ6VXNlcjE1NzIxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1572163?v=4","gravatar_id":"","url":"https://api.github.com/users/costleya","html_url":"https://github.com/costleya","followers_url":"https://api.github.com/users/costleya/followers","following_url":"https://api.github.com/users/costleya/following{/other_user}","gists_url":"https://api.github.com/users/costleya/gists{/gist_id}","starred_url":"https://api.github.com/users/costleya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costleya/subscriptions","organizations_url":"https://api.github.com/users/costleya/orgs","repos_url":"https://api.github.com/users/costleya/repos","events_url":"https://api.github.com/users/costleya/events{/privacy}","received_events_url":"https://api.github.com/users/costleya/received_events","type":"User","site_admin":false},"assignees":[{"login":"costleya","id":1572163,"node_id":"MDQ6VXNlcjE1NzIxNjM=","avatar_url":"https://avatars2.githubusercontent.com/u/1572163?v=4","gravatar_id":"","url":"https://api.github.com/users/costleya","html_url":"https://github.com/costleya","followers_url":"https://api.github.com/users/costleya/followers","following_url":"https://api.github.com/users/costleya/following{/other_user}","gists_url":"https://api.github.com/users/costleya/gists{/gist_id}","starred_url":"https://api.github.com/users/costleya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costleya/subscriptions","organizations_url":"https://api.github.com/users/costleya/orgs","repos_url":"https://api.github.com/users/costleya/repos","events_url":"https://api.github.com/users/costleya/events{/privacy}","received_events_url":"https://api.github.com/users/costleya/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-12-10T01:20:02Z","updated_at":"2019-01-02T17:03:52Z","closed_at":"2018-12-10T22:31:14Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/aws/aws-dotnet-extensions-configuration/pulls/19","html_url":"https://github.com/aws/aws-dotnet-extensions-configuration/pull/19","diff_url":"https://github.com/aws/aws-dotnet-extensions-configuration/pull/19.diff","patch_url":"https://github.com/aws/aws-dotnet-extensions-configuration/pull/19.patch"},"body":"## Description\r\nImplement IAsyncLifetime instead of IDisposable to simplify the test fixture as pointed out in https://github.com/aws/aws-dotnet-extensions-configuration/issues/16.\r\n\r\n## Testing\r\nInteg test passes.\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project\r\n- [ ] My change requires a change to the documentation\r\n- [ ] I have updated the documentation accordingly\r\n- [x] I have read the **README** document\r\n- [x] I have added tests to cover my changes\r\n- [x] All new and existing tests passed\r\n\r\n## License\r\n<!--- The SDK is released under the [Apache 2.0 license][license], so any code you submit will be released under that license -->\r\n<!--- For substantial contributions, we may ask you to sign a [Contributor License Agreement (CLA)][cla] -->\r\n<!--- Put an `x` in the below box if you confirm that this request can be released under the Apache 2 license -->\r\n- [x] I confirm that this pull request can be released under the Apache 2 license\r\n\r\n[issues]: https://github.com/aws/aws-dotnet-extensions-configuration/issues\r\n[license]: http://aws.amazon.com/apache2.0/\r\n[cla]: http://en.wikipedia.org/wiki/Contributor_License_Agreement\r\n"},"comment":{"url":"https://api.github.com/repos/aws/aws-dotnet-extensions-configuration/issues/comments/450921475","html_url":"https://github.com/aws/aws-dotnet-extensions-configuration/pull/19#issuecomment-450921475","issue_url":"https://api.github.com/repos/aws/aws-dotnet-extensions-configuration/issues/19","id":450921475,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDkyMTQ3NQ==","user":{"login":"normj","id":1653751,"node_id":"MDQ6VXNlcjE2NTM3NTE=","avatar_url":"https://avatars1.githubusercontent.com/u/1653751?v=4","gravatar_id":"","url":"https://api.github.com/users/normj","html_url":"https://github.com/normj","followers_url":"https://api.github.com/users/normj/followers","following_url":"https://api.github.com/users/normj/following{/other_user}","gists_url":"https://api.github.com/users/normj/gists{/gist_id}","starred_url":"https://api.github.com/users/normj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/normj/subscriptions","organizations_url":"https://api.github.com/users/normj/orgs","repos_url":"https://api.github.com/users/normj/repos","events_url":"https://api.github.com/users/normj/events{/privacy}","received_events_url":"https://api.github.com/users/normj/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T17:03:52Z","updated_at":"2019-01-02T17:03:52Z","author_association":"MEMBER","body":"@jingrah1 You are correct those dependencies should not be there. I created the following issue to track the issue. https://github.com/aws/aws-dotnet-extensions-configuration/issues/26"}}
{"actor":{"display_login":"normj"}}