{"action":"reopened","number":1795,"pull_request":{"url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1795","id":103534502,"node_id":"MDExOlB1bGxSZXF1ZXN0MTAzNTM0NTAy","html_url":"https://github.com/PCSX2/pcsx2/pull/1795","diff_url":"https://github.com/PCSX2/pcsx2/pull/1795.diff","patch_url":"https://github.com/PCSX2/pcsx2/pull/1795.patch","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1795","number":1795,"state":"open","locked":false,"title":"GSdx: Integrate software renderers","user":{"login":"ssakash","id":8477408,"node_id":"MDQ6VXNlcjg0Nzc0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/8477408?v=4","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"body":"**Summary of changes**:\r\n\r\n* Integrate all the software renderers into a single item in renderer combobox.\r\n* Slightly modify the F9 toggle behavior to make it suitable with the new integration of software renderers.\r\n* I've update the enumeration values in GSRendererType, I prefer to keep the code clean in cost of temporarily breaking the INI compatibility.\r\n\r\n**TODO**:\r\n\r\n* Missing logo for software renderer?\r\n* Maybe ``DX1011_HW``, ``DX9_HW``... could be converted to ``DX1011``, ``DX9`` respectively as there's only one software renderer right now? (I mean the enumeration in code, _nothing to see here for end users_)\r\n\r\nI remember having a discussion with Gregory on IRC before and the consensus was to use D3D9 for SW rendering on Windows and OpenGL for Linux if there was a plan to integrate the software renderers. I did that approach on this PR, actually I was planning on making this change [**last year**](https://github.com/PCSX2/pcsx2/pull/1284#issuecomment-207447845) but I only got the time to do it now. :P\r\n\r\n\r\n_**Master branch**_:\r\n\r\n![Before](http://i.imgur.com/GETEWPk.png)\r\n\r\n_**Pull request branch**_:\r\n\r\n![Now](http://i.imgur.com/zzE4i71.png)","created_at":"2017-01-27T17:37:33Z","updated_at":"2018-10-22T17:45:36Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2d217e2415f960fe4789b909577a73eeab7b340","assignee":{"login":"gregory38","id":1569559,"node_id":"MDQ6VXNlcjE1Njk1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1569559?v=4","gravatar_id":"","url":"https://api.github.com/users/gregory38","html_url":"https://github.com/gregory38","followers_url":"https://api.github.com/users/gregory38/followers","following_url":"https://api.github.com/users/gregory38/following{/other_user}","gists_url":"https://api.github.com/users/gregory38/gists{/gist_id}","starred_url":"https://api.github.com/users/gregory38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregory38/subscriptions","organizations_url":"https://api.github.com/users/gregory38/orgs","repos_url":"https://api.github.com/users/gregory38/repos","events_url":"https://api.github.com/users/gregory38/events{/privacy}","received_events_url":"https://api.github.com/users/gregory38/received_events","type":"User","site_admin":false},"assignees":[{"login":"gregory38","id":1569559,"node_id":"MDQ6VXNlcjE1Njk1NTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1569559?v=4","gravatar_id":"","url":"https://api.github.com/users/gregory38","html_url":"https://github.com/gregory38","followers_url":"https://api.github.com/users/gregory38/followers","following_url":"https://api.github.com/users/gregory38/following{/other_user}","gists_url":"https://api.github.com/users/gregory38/gists{/gist_id}","starred_url":"https://api.github.com/users/gregory38/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregory38/subscriptions","organizations_url":"https://api.github.com/users/gregory38/orgs","repos_url":"https://api.github.com/users/gregory38/repos","events_url":"https://api.github.com/users/gregory38/events{/privacy}","received_events_url":"https://api.github.com/users/gregory38/received_events","type":"User","site_admin":false},{"login":"turtleli","id":10976277,"node_id":"MDQ6VXNlcjEwOTc2Mjc3","avatar_url":"https://avatars2.githubusercontent.com/u/10976277?v=4","gravatar_id":"","url":"https://api.github.com/users/turtleli","html_url":"https://github.com/turtleli","followers_url":"https://api.github.com/users/turtleli/followers","following_url":"https://api.github.com/users/turtleli/following{/other_user}","gists_url":"https://api.github.com/users/turtleli/gists{/gist_id}","starred_url":"https://api.github.com/users/turtleli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtleli/subscriptions","organizations_url":"https://api.github.com/users/turtleli/orgs","repos_url":"https://api.github.com/users/turtleli/repos","events_url":"https://api.github.com/users/turtleli/events{/privacy}","received_events_url":"https://api.github.com/users/turtleli/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"turtleli","id":10976277,"node_id":"MDQ6VXNlcjEwOTc2Mjc3","avatar_url":"https://avatars2.githubusercontent.com/u/10976277?v=4","gravatar_id":"","url":"https://api.github.com/users/turtleli","html_url":"https://github.com/turtleli","followers_url":"https://api.github.com/users/turtleli/followers","following_url":"https://api.github.com/users/turtleli/following{/other_user}","gists_url":"https://api.github.com/users/turtleli/gists{/gist_id}","starred_url":"https://api.github.com/users/turtleli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/turtleli/subscriptions","organizations_url":"https://api.github.com/users/turtleli/orgs","repos_url":"https://api.github.com/users/turtleli/repos","events_url":"https://api.github.com/users/turtleli/events{/privacy}","received_events_url":"https://api.github.com/users/turtleli/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":71791771,"node_id":"MDU6TGFiZWw3MTc5MTc3MQ==","url":"https://api.github.com/repos/PCSX2/pcsx2/labels/Enhancement%20/%20Feature%20Request","name":"Enhancement / Feature Request","color":"84b6eb","default":false},{"id":155524562,"node_id":"MDU6TGFiZWwxNTU1MjQ1NjI=","url":"https://api.github.com/repos/PCSX2/pcsx2/labels/Needs%20Linux%20testing","name":"Needs Linux testing","color":"f7c6c7","default":false},{"id":88826549,"node_id":"MDU6TGFiZWw4ODgyNjU0OQ==","url":"https://api.github.com/repos/PCSX2/pcsx2/labels/Plugin:%20GSdx","name":"Plugin: GSdx","color":"fbca04","default":false},{"id":245533234,"node_id":"MDU6TGFiZWwyNDU1MzMyMzQ=","url":"https://api.github.com/repos/PCSX2/pcsx2/labels/Postponed","name":"Postponed","color":"fc2929","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1795/commits","review_comments_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1795/comments","review_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/1795/comments","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/cd1655f3af0bc7ce7f2d77d4f8f3068ec70b509b","head":{"label":"ssakash:sw_integration","ref":"sw_integration","sha":"cd1655f3af0bc7ce7f2d77d4f8f3068ec70b509b","user":{"login":"ssakash","id":8477408,"node_id":"MDQ6VXNlcjg0Nzc0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/8477408?v=4","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"repo":{"id":34851284,"node_id":"MDEwOlJlcG9zaXRvcnkzNDg1MTI4NA==","name":"pcsx2","full_name":"ssakash/pcsx2","private":false,"owner":{"login":"ssakash","id":8477408,"node_id":"MDQ6VXNlcjg0Nzc0MDg=","avatar_url":"https://avatars2.githubusercontent.com/u/8477408?v=4","gravatar_id":"","url":"https://api.github.com/users/ssakash","html_url":"https://github.com/ssakash","followers_url":"https://api.github.com/users/ssakash/followers","following_url":"https://api.github.com/users/ssakash/following{/other_user}","gists_url":"https://api.github.com/users/ssakash/gists{/gist_id}","starred_url":"https://api.github.com/users/ssakash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssakash/subscriptions","organizations_url":"https://api.github.com/users/ssakash/orgs","repos_url":"https://api.github.com/users/ssakash/repos","events_url":"https://api.github.com/users/ssakash/events{/privacy}","received_events_url":"https://api.github.com/users/ssakash/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ssakash/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":true,"url":"https://api.github.com/repos/ssakash/pcsx2","forks_url":"https://api.github.com/repos/ssakash/pcsx2/forks","keys_url":"https://api.github.com/repos/ssakash/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ssakash/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ssakash/pcsx2/teams","hooks_url":"https://api.github.com/repos/ssakash/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/ssakash/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/ssakash/pcsx2/events","assignees_url":"https://api.github.com/repos/ssakash/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/ssakash/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/ssakash/pcsx2/tags","blobs_url":"https://api.github.com/repos/ssakash/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ssakash/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ssakash/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/ssakash/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ssakash/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/ssakash/pcsx2/languages","stargazers_url":"https://api.github.com/repos/ssakash/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/ssakash/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/ssakash/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/ssakash/pcsx2/subscription","commits_url":"https://api.github.com/repos/ssakash/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/ssakash/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/ssakash/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/ssakash/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/ssakash/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/ssakash/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ssakash/pcsx2/merges","archive_url":"https://api.github.com/repos/ssakash/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ssakash/pcsx2/downloads","issues_url":"https://api.github.com/repos/ssakash/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/ssakash/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/ssakash/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/ssakash/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ssakash/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/ssakash/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/ssakash/pcsx2/deployments","created_at":"2015-04-30T11:36:34Z","updated_at":"2016-12-12T09:04:37Z","pushed_at":"2017-12-12T17:41:44Z","git_url":"git://github.com/ssakash/pcsx2.git","ssh_url":"git@github.com:ssakash/pcsx2.git","clone_url":"https://github.com/ssakash/pcsx2.git","svn_url":"https://github.com/ssakash/pcsx2","homepage":"http://pcsx2.net/","size":87179,"stargazers_count":2,"watchers_count":2,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":0,"watchers":2,"default_branch":"master"}},"base":{"label":"PCSX2:master","ref":"master","sha":"f86ea9f19bd58f24271a5864e4b19ea7f6bc90e7","user":{"login":"PCSX2","id":6278711,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNzg3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6278711?v=4","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"repo":{"id":15379620,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM3OTYyMA==","name":"pcsx2","full_name":"PCSX2/pcsx2","private":false,"owner":{"login":"PCSX2","id":6278711,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYyNzg3MTE=","avatar_url":"https://avatars2.githubusercontent.com/u/6278711?v=4","gravatar_id":"","url":"https://api.github.com/users/PCSX2","html_url":"https://github.com/PCSX2","followers_url":"https://api.github.com/users/PCSX2/followers","following_url":"https://api.github.com/users/PCSX2/following{/other_user}","gists_url":"https://api.github.com/users/PCSX2/gists{/gist_id}","starred_url":"https://api.github.com/users/PCSX2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PCSX2/subscriptions","organizations_url":"https://api.github.com/users/PCSX2/orgs","repos_url":"https://api.github.com/users/PCSX2/repos","events_url":"https://api.github.com/users/PCSX2/events{/privacy}","received_events_url":"https://api.github.com/users/PCSX2/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PCSX2/pcsx2","description":"PCSX2 - The Playstation 2 Emulator","fork":false,"url":"https://api.github.com/repos/PCSX2/pcsx2","forks_url":"https://api.github.com/repos/PCSX2/pcsx2/forks","keys_url":"https://api.github.com/repos/PCSX2/pcsx2/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PCSX2/pcsx2/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PCSX2/pcsx2/teams","hooks_url":"https://api.github.com/repos/PCSX2/pcsx2/hooks","issue_events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/events{/number}","events_url":"https://api.github.com/repos/PCSX2/pcsx2/events","assignees_url":"https://api.github.com/repos/PCSX2/pcsx2/assignees{/user}","branches_url":"https://api.github.com/repos/PCSX2/pcsx2/branches{/branch}","tags_url":"https://api.github.com/repos/PCSX2/pcsx2/tags","blobs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PCSX2/pcsx2/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PCSX2/pcsx2/git/refs{/sha}","trees_url":"https://api.github.com/repos/PCSX2/pcsx2/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PCSX2/pcsx2/statuses/{sha}","languages_url":"https://api.github.com/repos/PCSX2/pcsx2/languages","stargazers_url":"https://api.github.com/repos/PCSX2/pcsx2/stargazers","contributors_url":"https://api.github.com/repos/PCSX2/pcsx2/contributors","subscribers_url":"https://api.github.com/repos/PCSX2/pcsx2/subscribers","subscription_url":"https://api.github.com/repos/PCSX2/pcsx2/subscription","commits_url":"https://api.github.com/repos/PCSX2/pcsx2/commits{/sha}","git_commits_url":"https://api.github.com/repos/PCSX2/pcsx2/git/commits{/sha}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/comments{/number}","issue_comment_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments{/number}","contents_url":"https://api.github.com/repos/PCSX2/pcsx2/contents/{+path}","compare_url":"https://api.github.com/repos/PCSX2/pcsx2/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PCSX2/pcsx2/merges","archive_url":"https://api.github.com/repos/PCSX2/pcsx2/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PCSX2/pcsx2/downloads","issues_url":"https://api.github.com/repos/PCSX2/pcsx2/issues{/number}","pulls_url":"https://api.github.com/repos/PCSX2/pcsx2/pulls{/number}","milestones_url":"https://api.github.com/repos/PCSX2/pcsx2/milestones{/number}","notifications_url":"https://api.github.com/repos/PCSX2/pcsx2/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/labels{/name}","releases_url":"https://api.github.com/repos/PCSX2/pcsx2/releases{/id}","deployments_url":"https://api.github.com/repos/PCSX2/pcsx2/deployments","created_at":"2013-12-22T17:56:48Z","updated_at":"2018-10-22T00:59:20Z","pushed_at":"2018-10-22T03:13:55Z","git_url":"git://github.com/PCSX2/pcsx2.git","ssh_url":"git@github.com:PCSX2/pcsx2.git","clone_url":"https://github.com/PCSX2/pcsx2.git","svn_url":"https://github.com/PCSX2/pcsx2","homepage":"http://pcsx2.net/","size":94188,"stargazers_count":2606,"watchers_count":2606,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":518,"mirror_url":null,"archived":false,"open_issues_count":438,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":518,"open_issues":438,"watchers":2606,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1795"},"html":{"href":"https://github.com/PCSX2/pcsx2/pull/1795"},"issue":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1795"},"comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/issues/1795/comments"},"review_comments":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1795/comments"},"review_comment":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PCSX2/pcsx2/pulls/1795/commits"},"statuses":{"href":"https://api.github.com/repos/PCSX2/pcsx2/statuses/cd1655f3af0bc7ce7f2d77d4f8f3068ec70b509b"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":56,"review_comments":1,"maintainer_can_modify":true,"commits":2,"additions":114,"deletions":98,"changed_files":9}}
{"actor":{"display_login":"lightningterror"}}