{"action":"created","comment":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/186963806","pull_request_review_id":118642406,"id":186963806,"diff_hunk":"@@ -0,0 +1,26 @@\n+package awsservice","path":"service/controller/v10/context/awsservice/context.go","position":1,"original_position":1,"commit_id":"c1e625fe1fc961597e9f2d6148f836d95510b4ac","original_commit_id":"c1e625fe1fc961597e9f2d6148f836d95510b4ac","user":{"login":"kopiczko","id":4608994,"avatar_url":"https://avatars0.githubusercontent.com/u/4608994?v=4","gravatar_id":"","url":"https://api.github.com/users/kopiczko","html_url":"https://github.com/kopiczko","followers_url":"https://api.github.com/users/kopiczko/followers","following_url":"https://api.github.com/users/kopiczko/following{/other_user}","gists_url":"https://api.github.com/users/kopiczko/gists{/gist_id}","starred_url":"https://api.github.com/users/kopiczko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kopiczko/subscriptions","organizations_url":"https://api.github.com/users/kopiczko/orgs","repos_url":"https://api.github.com/users/kopiczko/repos","events_url":"https://api.github.com/users/kopiczko/events{/privacy}","received_events_url":"https://api.github.com/users/kopiczko/received_events","type":"User","site_admin":false},"body":"Instead of all this context packages, can't we have one struct which holds all of those and store it inside the context?","created_at":"2018-05-09T08:12:33Z","updated_at":"2018-05-09T08:14:16Z","html_url":"https://github.com/giantswarm/aws-operator/pull/933#discussion_r186963806","pull_request_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/933","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments/186963806"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/933#discussion_r186963806"},"pull_request":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/933"}}},"pull_request":{"url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/933","id":186616705,"html_url":"https://github.com/giantswarm/aws-operator/pull/933","diff_url":"https://github.com/giantswarm/aws-operator/pull/933.diff","patch_url":"https://github.com/giantswarm/aws-operator/pull/933.patch","issue_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/933","number":933,"state":"open","locked":false,"title":"BYOC/guest cluster scoped aws client - resources implementation","user":{"login":"TheoBrigitte","id":6536819,"avatar_url":"https://avatars1.githubusercontent.com/u/6536819?v=4","gravatar_id":"","url":"https://api.github.com/users/TheoBrigitte","html_url":"https://github.com/TheoBrigitte","followers_url":"https://api.github.com/users/TheoBrigitte/followers","following_url":"https://api.github.com/users/TheoBrigitte/following{/other_user}","gists_url":"https://api.github.com/users/TheoBrigitte/gists{/gist_id}","starred_url":"https://api.github.com/users/TheoBrigitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheoBrigitte/subscriptions","organizations_url":"https://api.github.com/users/TheoBrigitte/orgs","repos_url":"https://api.github.com/users/TheoBrigitte/repos","events_url":"https://api.github.com/users/TheoBrigitte/events{/privacy}","received_events_url":"https://api.github.com/users/TheoBrigitte/received_events","type":"User","site_admin":false},"body":"Towards: https://github.com/giantswarm/giantswarm/issues/2947\r\n\r\nResources are now using guest cluster scoped aws client (provided by https://github.com/giantswarm/aws-operator/pull/916).\r\nUpdated resources:\r\n* kmsKeyResource\r\n* s3BucketResource\r\n* s3BucketObjectResource\r\n* loadBalancerResource\r\n* ebsVolumeResource\r\n* cloudformationResource\r\n* endpointsResource\r\n\r\nAll services we use to communicate with aws (`awsService`, `cloudConfig`, `ebsService`, `cloudFormationService`) are now created in the `initCtxFunc` function\r\nhttps://github.com/giantswarm/aws-operator/blob/byoc/guest-cluster-scoped-aws-client-resources/service/controller/v10/cluster_resource_set.go#L317\r\n\r\nMajor changes is adoption of aws services interfaces for `client/aws` and aws mocks.\r\ne.g. https://godoc.org/github.com/aws/aws-sdk-go/service/ec2/ec2iface","created_at":"2018-05-08T12:22:02Z","updated_at":"2018-05-09T08:14:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ac071a79666cfc9471ee06ce565e7f873a632e14","assignee":{"login":"TheoBrigitte","id":6536819,"avatar_url":"https://avatars1.githubusercontent.com/u/6536819?v=4","gravatar_id":"","url":"https://api.github.com/users/TheoBrigitte","html_url":"https://github.com/TheoBrigitte","followers_url":"https://api.github.com/users/TheoBrigitte/followers","following_url":"https://api.github.com/users/TheoBrigitte/following{/other_user}","gists_url":"https://api.github.com/users/TheoBrigitte/gists{/gist_id}","starred_url":"https://api.github.com/users/TheoBrigitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheoBrigitte/subscriptions","organizations_url":"https://api.github.com/users/TheoBrigitte/orgs","repos_url":"https://api.github.com/users/TheoBrigitte/repos","events_url":"https://api.github.com/users/TheoBrigitte/events{/privacy}","received_events_url":"https://api.github.com/users/TheoBrigitte/received_events","type":"User","site_admin":false},"assignees":[{"login":"TheoBrigitte","id":6536819,"avatar_url":"https://avatars1.githubusercontent.com/u/6536819?v=4","gravatar_id":"","url":"https://api.github.com/users/TheoBrigitte","html_url":"https://github.com/TheoBrigitte","followers_url":"https://api.github.com/users/TheoBrigitte/followers","following_url":"https://api.github.com/users/TheoBrigitte/following{/other_user}","gists_url":"https://api.github.com/users/TheoBrigitte/gists{/gist_id}","starred_url":"https://api.github.com/users/TheoBrigitte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheoBrigitte/subscriptions","organizations_url":"https://api.github.com/users/TheoBrigitte/orgs","repos_url":"https://api.github.com/users/TheoBrigitte/repos","events_url":"https://api.github.com/users/TheoBrigitte/events{/privacy}","received_events_url":"https://api.github.com/users/TheoBrigitte/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/933/commits","review_comments_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/933/comments","review_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/933/comments","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/c1e625fe1fc961597e9f2d6148f836d95510b4ac","head":{"label":"giantswarm:byoc/guest-cluster-scoped-aws-client-resources","ref":"byoc/guest-cluster-scoped-aws-client-resources","sha":"c1e625fe1fc961597e9f2d6148f836d95510b4ac","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"name":"aws-operator","full_name":"giantswarm/aws-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/aws-operator","description":"The aws-operator manages Kubernetes clusters running on AWS","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-05-07T14:59:24Z","pushed_at":"2018-05-09T07:36:21Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":"https://giantswarm.io/","size":60527,"stargazers_count":39,"watchers_count":39,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14,"open_issues":8,"watchers":39,"default_branch":"master"}},"base":{"label":"giantswarm:byoc/guest-cluster-scoped-aws-client","ref":"byoc/guest-cluster-scoped-aws-client","sha":"ba0f310ca549c6f5aea5e55bc7b58a1632f7fe82","user":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"repo":{"id":80619275,"name":"aws-operator","full_name":"giantswarm/aws-operator","owner":{"login":"giantswarm","id":7556340,"avatar_url":"https://avatars3.githubusercontent.com/u/7556340?v=4","gravatar_id":"","url":"https://api.github.com/users/giantswarm","html_url":"https://github.com/giantswarm","followers_url":"https://api.github.com/users/giantswarm/followers","following_url":"https://api.github.com/users/giantswarm/following{/other_user}","gists_url":"https://api.github.com/users/giantswarm/gists{/gist_id}","starred_url":"https://api.github.com/users/giantswarm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giantswarm/subscriptions","organizations_url":"https://api.github.com/users/giantswarm/orgs","repos_url":"https://api.github.com/users/giantswarm/repos","events_url":"https://api.github.com/users/giantswarm/events{/privacy}","received_events_url":"https://api.github.com/users/giantswarm/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/giantswarm/aws-operator","description":"The aws-operator manages Kubernetes clusters running on AWS","fork":false,"url":"https://api.github.com/repos/giantswarm/aws-operator","forks_url":"https://api.github.com/repos/giantswarm/aws-operator/forks","keys_url":"https://api.github.com/repos/giantswarm/aws-operator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/giantswarm/aws-operator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/giantswarm/aws-operator/teams","hooks_url":"https://api.github.com/repos/giantswarm/aws-operator/hooks","issue_events_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/events{/number}","events_url":"https://api.github.com/repos/giantswarm/aws-operator/events","assignees_url":"https://api.github.com/repos/giantswarm/aws-operator/assignees{/user}","branches_url":"https://api.github.com/repos/giantswarm/aws-operator/branches{/branch}","tags_url":"https://api.github.com/repos/giantswarm/aws-operator/tags","blobs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/giantswarm/aws-operator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/giantswarm/aws-operator/git/refs{/sha}","trees_url":"https://api.github.com/repos/giantswarm/aws-operator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/giantswarm/aws-operator/statuses/{sha}","languages_url":"https://api.github.com/repos/giantswarm/aws-operator/languages","stargazers_url":"https://api.github.com/repos/giantswarm/aws-operator/stargazers","contributors_url":"https://api.github.com/repos/giantswarm/aws-operator/contributors","subscribers_url":"https://api.github.com/repos/giantswarm/aws-operator/subscribers","subscription_url":"https://api.github.com/repos/giantswarm/aws-operator/subscription","commits_url":"https://api.github.com/repos/giantswarm/aws-operator/commits{/sha}","git_commits_url":"https://api.github.com/repos/giantswarm/aws-operator/git/commits{/sha}","comments_url":"https://api.github.com/repos/giantswarm/aws-operator/comments{/number}","issue_comment_url":"https://api.github.com/repos/giantswarm/aws-operator/issues/comments{/number}","contents_url":"https://api.github.com/repos/giantswarm/aws-operator/contents/{+path}","compare_url":"https://api.github.com/repos/giantswarm/aws-operator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/giantswarm/aws-operator/merges","archive_url":"https://api.github.com/repos/giantswarm/aws-operator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/giantswarm/aws-operator/downloads","issues_url":"https://api.github.com/repos/giantswarm/aws-operator/issues{/number}","pulls_url":"https://api.github.com/repos/giantswarm/aws-operator/pulls{/number}","milestones_url":"https://api.github.com/repos/giantswarm/aws-operator/milestones{/number}","notifications_url":"https://api.github.com/repos/giantswarm/aws-operator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/giantswarm/aws-operator/labels{/name}","releases_url":"https://api.github.com/repos/giantswarm/aws-operator/releases{/id}","deployments_url":"https://api.github.com/repos/giantswarm/aws-operator/deployments","created_at":"2017-02-01T12:47:41Z","updated_at":"2018-05-07T14:59:24Z","pushed_at":"2018-05-09T07:36:21Z","git_url":"git://github.com/giantswarm/aws-operator.git","ssh_url":"git@github.com:giantswarm/aws-operator.git","clone_url":"https://github.com/giantswarm/aws-operator.git","svn_url":"https://github.com/giantswarm/aws-operator","homepage":"https://giantswarm.io/","size":60527,"stargazers_count":39,"watchers_count":39,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":14,"open_issues":8,"watchers":39,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/933"},"html":{"href":"https://github.com/giantswarm/aws-operator/pull/933"},"issue":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/933"},"comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/issues/933/comments"},"review_comments":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/933/comments"},"review_comment":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/giantswarm/aws-operator/pulls/933/commits"},"statuses":{"href":"https://api.github.com/repos/giantswarm/aws-operator/statuses/c1e625fe1fc961597e9f2d6148f836d95510b4ac"}},"author_association":"NONE"}}
{"actor":{"display_login":"kopiczko"}}