{"action":"created","comment":{"url":"https://api.github.com/repos/Talend/ui/pulls/comments/168745633","pull_request_review_id":97164508,"id":168745633,"diff_hunk":"@@ -67,21 +72,29 @@ Actions are [redux actions](http://redux.js.org/docs/basics/Actions.html).\n ### ComponentState Management\n \n Component state can be easily stored in cmf state, each are identified by their name and an unique key,\n-so component state can be stored and reused later\n+so component state can be stored and reused later.\n+\n+We give you the choice to use either:\n+\n+* React component state (this.state && this.setState)","path":"packages/cmf/README.md","position":60,"original_position":60,"commit_id":"a03bdd34d5f452c6edc94d528a3e60ef5cd1d7ea","original_commit_id":"a03bdd34d5f452c6edc94d528a3e60ef5cd1d7ea","user":{"login":"cateland","id":1081670,"avatar_url":"https://avatars3.githubusercontent.com/u/1081670?v=4","gravatar_id":"","url":"https://api.github.com/users/cateland","html_url":"https://github.com/cateland","followers_url":"https://api.github.com/users/cateland/followers","following_url":"https://api.github.com/users/cateland/following{/other_user}","gists_url":"https://api.github.com/users/cateland/gists{/gist_id}","starred_url":"https://api.github.com/users/cateland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cateland/subscriptions","organizations_url":"https://api.github.com/users/cateland/orgs","repos_url":"https://api.github.com/users/cateland/repos","events_url":"https://api.github.com/users/cateland/events{/privacy}","received_events_url":"https://api.github.com/users/cateland/received_events","type":"User","site_admin":false},"body":"Should add warning that you should use CMF redux state before even thinking about local component state","created_at":"2018-02-16T12:38:04Z","updated_at":"2018-02-16T12:39:40Z","html_url":"https://github.com/Talend/ui/pull/1079#discussion_r168745633","pull_request_url":"https://api.github.com/repos/Talend/ui/pulls/1079","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments/168745633"},"html":{"href":"https://github.com/Talend/ui/pull/1079#discussion_r168745633"},"pull_request":{"href":"https://api.github.com/repos/Talend/ui/pulls/1079"}}},"pull_request":{"url":"https://api.github.com/repos/Talend/ui/pulls/1079","id":169599040,"html_url":"https://github.com/Talend/ui/pull/1079","diff_url":"https://github.com/Talend/ui/pull/1079.diff","patch_url":"https://github.com/Talend/ui/pull/1079.patch","issue_url":"https://api.github.com/repos/Talend/ui/issues/1079","number":1079,"state":"open","locked":false,"title":"doc(cmf): update readme","user":{"login":"jmfrancois","id":19857479,"avatar_url":"https://avatars2.githubusercontent.com/u/19857479?v=4","gravatar_id":"","url":"https://api.github.com/users/jmfrancois","html_url":"https://github.com/jmfrancois","followers_url":"https://api.github.com/users/jmfrancois/followers","following_url":"https://api.github.com/users/jmfrancois/following{/other_user}","gists_url":"https://api.github.com/users/jmfrancois/gists{/gist_id}","starred_url":"https://api.github.com/users/jmfrancois/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmfrancois/subscriptions","organizations_url":"https://api.github.com/users/jmfrancois/orgs","repos_url":"https://api.github.com/users/jmfrancois/repos","events_url":"https://api.github.com/users/jmfrancois/events{/privacy}","received_events_url":"https://api.github.com/users/jmfrancois/received_events","type":"User","site_admin":false},"body":"**What is the problem this PR is trying to solve?**\r\n\r\nsome part of the doc are broken\r\n\r\n**What is the chosen solution to this problem?**\r\n\r\nupdate to give it more sens\r\n\r\n**Please check if the PR fulfills these requirements**\r\n- [x] The PR commit message follows our [guidelines](https://github.com/talend/tools/blob/master/tools-root-github/CONTRIBUTING.md)\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [x] Docs have been added / updated (for bug fixes / features)\r\n- [ ] Related design / discussions / pages (not in jira), if any, are all linked or available in the PR\r\n\r\n<!-- You can add more checkboxes here -->\r\n\r\n**[ ] This PR introduces a breaking change**\r\n\r\n<!-- **Original Template** -->\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n\r\n","created_at":"2018-02-16T11:13:27Z","updated_at":"2018-02-16T12:39:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c2a07654948d4e524930f2b86438082b93e3ebfd","assignee":null,"assignees":[],"requested_reviewers":[{"login":"frassinier","id":18534166,"avatar_url":"https://avatars0.githubusercontent.com/u/18534166?v=4","gravatar_id":"","url":"https://api.github.com/users/frassinier","html_url":"https://github.com/frassinier","followers_url":"https://api.github.com/users/frassinier/followers","following_url":"https://api.github.com/users/frassinier/following{/other_user}","gists_url":"https://api.github.com/users/frassinier/gists{/gist_id}","starred_url":"https://api.github.com/users/frassinier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frassinier/subscriptions","organizations_url":"https://api.github.com/users/frassinier/orgs","repos_url":"https://api.github.com/users/frassinier/repos","events_url":"https://api.github.com/users/frassinier/events{/privacy}","received_events_url":"https://api.github.com/users/frassinier/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":530809343,"url":"https://api.github.com/repos/Talend/ui/labels/easy%20review","name":"easy review","color":"ff69b4","default":false},{"id":521021722,"url":"https://api.github.com/repos/Talend/ui/labels/need%20review","name":"need review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Talend/ui/pulls/1079/commits","review_comments_url":"https://api.github.com/repos/Talend/ui/pulls/1079/comments","review_comment_url":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Talend/ui/issues/1079/comments","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/a03bdd34d5f452c6edc94d528a3e60ef5cd1d7ea","head":{"label":"Talend:jmfrancois/doc/cmf-update-readme","ref":"jmfrancois/doc/cmf-update-readme","sha":"a03bdd34d5f452c6edc94d528a3e60ef5cd1d7ea","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-02-15T18:16:47Z","pushed_at":"2018-02-16T12:26:46Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":23120,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":19,"open_issues":45,"watchers":40,"default_branch":"master"}},"base":{"label":"Talend:master","ref":"master","sha":"0459cdd75c8d1804aa2f29693755c83eab5652a2","user":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"repo":{"id":79343946,"name":"ui","full_name":"Talend/ui","owner":{"login":"Talend","id":459687,"avatar_url":"https://avatars2.githubusercontent.com/u/459687?v=4","gravatar_id":"","url":"https://api.github.com/users/Talend","html_url":"https://github.com/Talend","followers_url":"https://api.github.com/users/Talend/followers","following_url":"https://api.github.com/users/Talend/following{/other_user}","gists_url":"https://api.github.com/users/Talend/gists{/gist_id}","starred_url":"https://api.github.com/users/Talend/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Talend/subscriptions","organizations_url":"https://api.github.com/users/Talend/orgs","repos_url":"https://api.github.com/users/Talend/repos","events_url":"https://api.github.com/users/Talend/events{/privacy}","received_events_url":"https://api.github.com/users/Talend/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Talend/ui","description":"Talend's unified web UI repository.","fork":false,"url":"https://api.github.com/repos/Talend/ui","forks_url":"https://api.github.com/repos/Talend/ui/forks","keys_url":"https://api.github.com/repos/Talend/ui/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Talend/ui/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Talend/ui/teams","hooks_url":"https://api.github.com/repos/Talend/ui/hooks","issue_events_url":"https://api.github.com/repos/Talend/ui/issues/events{/number}","events_url":"https://api.github.com/repos/Talend/ui/events","assignees_url":"https://api.github.com/repos/Talend/ui/assignees{/user}","branches_url":"https://api.github.com/repos/Talend/ui/branches{/branch}","tags_url":"https://api.github.com/repos/Talend/ui/tags","blobs_url":"https://api.github.com/repos/Talend/ui/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Talend/ui/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Talend/ui/git/refs{/sha}","trees_url":"https://api.github.com/repos/Talend/ui/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Talend/ui/statuses/{sha}","languages_url":"https://api.github.com/repos/Talend/ui/languages","stargazers_url":"https://api.github.com/repos/Talend/ui/stargazers","contributors_url":"https://api.github.com/repos/Talend/ui/contributors","subscribers_url":"https://api.github.com/repos/Talend/ui/subscribers","subscription_url":"https://api.github.com/repos/Talend/ui/subscription","commits_url":"https://api.github.com/repos/Talend/ui/commits{/sha}","git_commits_url":"https://api.github.com/repos/Talend/ui/git/commits{/sha}","comments_url":"https://api.github.com/repos/Talend/ui/comments{/number}","issue_comment_url":"https://api.github.com/repos/Talend/ui/issues/comments{/number}","contents_url":"https://api.github.com/repos/Talend/ui/contents/{+path}","compare_url":"https://api.github.com/repos/Talend/ui/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Talend/ui/merges","archive_url":"https://api.github.com/repos/Talend/ui/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Talend/ui/downloads","issues_url":"https://api.github.com/repos/Talend/ui/issues{/number}","pulls_url":"https://api.github.com/repos/Talend/ui/pulls{/number}","milestones_url":"https://api.github.com/repos/Talend/ui/milestones{/number}","notifications_url":"https://api.github.com/repos/Talend/ui/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Talend/ui/labels{/name}","releases_url":"https://api.github.com/repos/Talend/ui/releases{/id}","deployments_url":"https://api.github.com/repos/Talend/ui/deployments","created_at":"2017-01-18T13:45:58Z","updated_at":"2018-02-15T18:16:47Z","pushed_at":"2018-02-16T12:26:46Z","git_url":"git://github.com/Talend/ui.git","ssh_url":"git@github.com:Talend/ui.git","clone_url":"https://github.com/Talend/ui.git","svn_url":"https://github.com/Talend/ui","homepage":"http://talend.surge.sh","size":23120,"stargazers_count":40,"watchers_count":40,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":45,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":19,"open_issues":45,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Talend/ui/pulls/1079"},"html":{"href":"https://github.com/Talend/ui/pull/1079"},"issue":{"href":"https://api.github.com/repos/Talend/ui/issues/1079"},"comments":{"href":"https://api.github.com/repos/Talend/ui/issues/1079/comments"},"review_comments":{"href":"https://api.github.com/repos/Talend/ui/pulls/1079/comments"},"review_comment":{"href":"https://api.github.com/repos/Talend/ui/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Talend/ui/pulls/1079/commits"},"statuses":{"href":"https://api.github.com/repos/Talend/ui/statuses/a03bdd34d5f452c6edc94d528a3e60ef5cd1d7ea"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"cateland"}}