{"action":"created","comment":{"url":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments/245314286","pull_request_review_id":189389153,"id":245314286,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTMxNDI4Ng==","diff_hunk":"@@ -41,205 +49,124 @@ constexpr int kTestDataSize = 10;\n  * 1 -> reference data horizontally flipped\n  * 2 -> reference data vertically flipped\n  */\n-using TestData = std::array<std::tuple<Roi, Roi, Roi>, kTestDataSize>;\n-\n-constexpr TestData wh_rois{\n-        {\n-                std::tuple<Roi, Roi, Roi>{{.2, .2, .4, .3},\n-                                          {.4, .2, .4, .3},\n-                                          {.2, .5, .4, .3}},\n-                std::tuple<Roi, Roi, Roi>{{.0, .0, .5, .5},\n-                                          {.5, .0, .5, .5},\n-                                          {.0, .5, .5, .5}},\n-                std::tuple<Roi, Roi, Roi>{{.3, .2, .1, .1},\n-                                          {.6, .2, .1, .1},\n-                                          {.3, .7, .1, .1}},\n-                std::tuple<Roi, Roi, Roi>{{.0, .0, .2, .3},\n-                                          {.8, .0, .2, .3},\n-                                          {.0, .7, .2, .3}},\n-                std::tuple<Roi, Roi, Roi>{{.0, .0, .1, .1},\n-                                          {.9, .0, .1, .1},\n-                                          {.0, .9, .1, .1}},\n-                std::tuple<Roi, Roi, Roi>{{.5, .5, .1, .1},\n-                                          {.4, .5, .1, .1},\n-                                          {.5, .4, .1, .1}},\n-                std::tuple<Roi, Roi, Roi>{{.0, .6, .7, .4},\n-                                          {.3, .6, .7, .4},\n-                                          {.0, .0, .7, .4}},\n-                std::tuple<Roi, Roi, Roi>{{.6, .2, .3, .3},\n-                                          {.1, .2, .3, .3},\n-                                          {.6, .5, .3, .3}},\n-                std::tuple<Roi, Roi, Roi>{{.4, .3, .5, .5},\n-                                          {.1, .3, .5, .5},\n-                                          {.4, .2, .5, .5}},\n-                std::tuple<Roi, Roi, Roi>{{.25, .25, .5, .5},\n-                                          {.25, .25, .5, .5},\n-                                          {.25, .25, .5, .5}},\n-        }\n-};\n+using TestData = std::array<std::array<Roi, 3>, kTestDataSize>;\n+\n+const TestData rois_wh = {{","path":"dali/pipeline/operators/geometric/bb_flip_test.cc","position":82,"original_position":82,"commit_id":"9f7db535dc38ff10df077d4dab7b8c75dc077fda","original_commit_id":"9f7db535dc38ff10df077d4dab7b8c75dc077fda","user":{"login":"mzient","id":17044837,"node_id":"MDQ6VXNlcjE3MDQ0ODM3","avatar_url":"https://avatars3.githubusercontent.com/u/17044837?v=4","gravatar_id":"","url":"https://api.github.com/users/mzient","html_url":"https://github.com/mzient","followers_url":"https://api.github.com/users/mzient/followers","following_url":"https://api.github.com/users/mzient/following{/other_user}","gists_url":"https://api.github.com/users/mzient/gists{/gist_id}","starred_url":"https://api.github.com/users/mzient/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mzient/subscriptions","organizations_url":"https://api.github.com/users/mzient/orgs","repos_url":"https://api.github.com/users/mzient/repos","events_url":"https://api.github.com/users/mzient/events{/privacy}","received_events_url":"https://api.github.com/users/mzient/received_events","type":"User","site_admin":false},"body":"You use a hidden constant defined elsewhere (in the definition of TestData type) and then have to have exactly that number of entries. If you specify fewer entries, the compiler will not complain! This is worse than a magic constant - it's a magic constant defined far away.\r\nIf you used a C-style array, the size would be adjusted automatically.\r\nAlso, the number of curly braces is mind-boggling - C-style arrays don't need double braces.\r\n\r\nFYI: The code below compiles\r\n```\r\n    using A = std::array<int, 5>;\r\n    A a = {{ 1, 2 }};\r\n```\r\n\r\n","created_at":"2019-01-04T14:38:09Z","updated_at":"2019-01-04T14:38:10Z","html_url":"https://github.com/NVIDIA/DALI/pull/404#discussion_r245314286","pull_request_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/404","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments/245314286"},"html":{"href":"https://github.com/NVIDIA/DALI/pull/404#discussion_r245314286"},"pull_request":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/404"}}},"pull_request":{"url":"https://api.github.com/repos/NVIDIA/DALI/pulls/404","id":242154766,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMTU0NzY2","html_url":"https://github.com/NVIDIA/DALI/pull/404","diff_url":"https://github.com/NVIDIA/DALI/pull/404.diff","patch_url":"https://github.com/NVIDIA/DALI/pull/404.patch","issue_url":"https://api.github.com/repos/NVIDIA/DALI/issues/404","number":404,"state":"open","locked":false,"title":"Implementation of DaliOperatorTest","user":{"login":"szalpal","id":7101064,"node_id":"MDQ6VXNlcjcxMDEwNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7101064?v=4","gravatar_id":"","url":"https://api.github.com/users/szalpal","html_url":"https://github.com/szalpal","followers_url":"https://api.github.com/users/szalpal/followers","following_url":"https://api.github.com/users/szalpal/following{/other_user}","gists_url":"https://api.github.com/users/szalpal/gists{/gist_id}","starred_url":"https://api.github.com/users/szalpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szalpal/subscriptions","organizations_url":"https://api.github.com/users/szalpal/orgs","repos_url":"https://api.github.com/users/szalpal/repos","events_url":"https://api.github.com/users/szalpal/events{/privacy}","received_events_url":"https://api.github.com/users/szalpal/received_events","type":"User","site_admin":false},"body":"Stuff yet to do (in future PRs, so that this one isn't too huge):\r\n1. Multi-input\r\n2. Using operator graph\r\n3. Argument type generalization (`boost::any, dali::Value`...)","created_at":"2019-01-04T01:24:30Z","updated_at":"2019-01-04T14:38:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09452e5370914a63259740f4d966554562b66d51","assignee":null,"assignees":[],"requested_reviewers":[{"login":"Kh4L","id":3193578,"node_id":"MDQ6VXNlcjMxOTM1Nzg=","avatar_url":"https://avatars2.githubusercontent.com/u/3193578?v=4","gravatar_id":"","url":"https://api.github.com/users/Kh4L","html_url":"https://github.com/Kh4L","followers_url":"https://api.github.com/users/Kh4L/followers","following_url":"https://api.github.com/users/Kh4L/following{/other_user}","gists_url":"https://api.github.com/users/Kh4L/gists{/gist_id}","starred_url":"https://api.github.com/users/Kh4L/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kh4L/subscriptions","organizations_url":"https://api.github.com/users/Kh4L/orgs","repos_url":"https://api.github.com/users/Kh4L/repos","events_url":"https://api.github.com/users/Kh4L/events{/privacy}","received_events_url":"https://api.github.com/users/Kh4L/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/404/commits","review_comments_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/404/comments","review_comment_url":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NVIDIA/DALI/issues/404/comments","statuses_url":"https://api.github.com/repos/NVIDIA/DALI/statuses/9f7db535dc38ff10df077d4dab7b8c75dc077fda","head":{"label":"szalpal:dalioptest_impl","ref":"dalioptest_impl","sha":"9f7db535dc38ff10df077d4dab7b8c75dc077fda","user":{"login":"szalpal","id":7101064,"node_id":"MDQ6VXNlcjcxMDEwNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7101064?v=4","gravatar_id":"","url":"https://api.github.com/users/szalpal","html_url":"https://github.com/szalpal","followers_url":"https://api.github.com/users/szalpal/followers","following_url":"https://api.github.com/users/szalpal/following{/other_user}","gists_url":"https://api.github.com/users/szalpal/gists{/gist_id}","starred_url":"https://api.github.com/users/szalpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szalpal/subscriptions","organizations_url":"https://api.github.com/users/szalpal/orgs","repos_url":"https://api.github.com/users/szalpal/repos","events_url":"https://api.github.com/users/szalpal/events{/privacy}","received_events_url":"https://api.github.com/users/szalpal/received_events","type":"User","site_admin":false},"repo":{"id":148139188,"node_id":"MDEwOlJlcG9zaXRvcnkxNDgxMzkxODg=","name":"DALI","full_name":"szalpal/DALI","private":false,"owner":{"login":"szalpal","id":7101064,"node_id":"MDQ6VXNlcjcxMDEwNjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/7101064?v=4","gravatar_id":"","url":"https://api.github.com/users/szalpal","html_url":"https://github.com/szalpal","followers_url":"https://api.github.com/users/szalpal/followers","following_url":"https://api.github.com/users/szalpal/following{/other_user}","gists_url":"https://api.github.com/users/szalpal/gists{/gist_id}","starred_url":"https://api.github.com/users/szalpal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/szalpal/subscriptions","organizations_url":"https://api.github.com/users/szalpal/orgs","repos_url":"https://api.github.com/users/szalpal/repos","events_url":"https://api.github.com/users/szalpal/events{/privacy}","received_events_url":"https://api.github.com/users/szalpal/received_events","type":"User","site_admin":false},"html_url":"https://github.com/szalpal/DALI","description":"A library containing both highly optimized building blocks and an execution engine for data pre-processing in deep learning applications","fork":true,"url":"https://api.github.com/repos/szalpal/DALI","forks_url":"https://api.github.com/repos/szalpal/DALI/forks","keys_url":"https://api.github.com/repos/szalpal/DALI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/szalpal/DALI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/szalpal/DALI/teams","hooks_url":"https://api.github.com/repos/szalpal/DALI/hooks","issue_events_url":"https://api.github.com/repos/szalpal/DALI/issues/events{/number}","events_url":"https://api.github.com/repos/szalpal/DALI/events","assignees_url":"https://api.github.com/repos/szalpal/DALI/assignees{/user}","branches_url":"https://api.github.com/repos/szalpal/DALI/branches{/branch}","tags_url":"https://api.github.com/repos/szalpal/DALI/tags","blobs_url":"https://api.github.com/repos/szalpal/DALI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/szalpal/DALI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/szalpal/DALI/git/refs{/sha}","trees_url":"https://api.github.com/repos/szalpal/DALI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/szalpal/DALI/statuses/{sha}","languages_url":"https://api.github.com/repos/szalpal/DALI/languages","stargazers_url":"https://api.github.com/repos/szalpal/DALI/stargazers","contributors_url":"https://api.github.com/repos/szalpal/DALI/contributors","subscribers_url":"https://api.github.com/repos/szalpal/DALI/subscribers","subscription_url":"https://api.github.com/repos/szalpal/DALI/subscription","commits_url":"https://api.github.com/repos/szalpal/DALI/commits{/sha}","git_commits_url":"https://api.github.com/repos/szalpal/DALI/git/commits{/sha}","comments_url":"https://api.github.com/repos/szalpal/DALI/comments{/number}","issue_comment_url":"https://api.github.com/repos/szalpal/DALI/issues/comments{/number}","contents_url":"https://api.github.com/repos/szalpal/DALI/contents/{+path}","compare_url":"https://api.github.com/repos/szalpal/DALI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/szalpal/DALI/merges","archive_url":"https://api.github.com/repos/szalpal/DALI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/szalpal/DALI/downloads","issues_url":"https://api.github.com/repos/szalpal/DALI/issues{/number}","pulls_url":"https://api.github.com/repos/szalpal/DALI/pulls{/number}","milestones_url":"https://api.github.com/repos/szalpal/DALI/milestones{/number}","notifications_url":"https://api.github.com/repos/szalpal/DALI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/szalpal/DALI/labels{/name}","releases_url":"https://api.github.com/repos/szalpal/DALI/releases{/id}","deployments_url":"https://api.github.com/repos/szalpal/DALI/deployments","created_at":"2018-09-10T10:33:14Z","updated_at":"2018-11-20T09:51:58Z","pushed_at":"2019-01-04T10:19:52Z","git_url":"git://github.com/szalpal/DALI.git","ssh_url":"git@github.com:szalpal/DALI.git","clone_url":"https://github.com/szalpal/DALI.git","svn_url":"https://github.com/szalpal/DALI","homepage":"https://docs.nvidia.com/deeplearning/sdk/dali-developer-guide/index.html","size":41821,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NVIDIA:master","ref":"master","sha":"397ed2db25392cb11932d27bb53863750864b23f","user":{"login":"NVIDIA","id":1728152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjgxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"repo":{"id":135768037,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU3NjgwMzc=","name":"DALI","full_name":"NVIDIA/DALI","private":false,"owner":{"login":"NVIDIA","id":1728152,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3MjgxNTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1728152?v=4","gravatar_id":"","url":"https://api.github.com/users/NVIDIA","html_url":"https://github.com/NVIDIA","followers_url":"https://api.github.com/users/NVIDIA/followers","following_url":"https://api.github.com/users/NVIDIA/following{/other_user}","gists_url":"https://api.github.com/users/NVIDIA/gists{/gist_id}","starred_url":"https://api.github.com/users/NVIDIA/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NVIDIA/subscriptions","organizations_url":"https://api.github.com/users/NVIDIA/orgs","repos_url":"https://api.github.com/users/NVIDIA/repos","events_url":"https://api.github.com/users/NVIDIA/events{/privacy}","received_events_url":"https://api.github.com/users/NVIDIA/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NVIDIA/DALI","description":"A library containing both highly optimized building blocks and an execution engine for data pre-processing in deep learning applications","fork":false,"url":"https://api.github.com/repos/NVIDIA/DALI","forks_url":"https://api.github.com/repos/NVIDIA/DALI/forks","keys_url":"https://api.github.com/repos/NVIDIA/DALI/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NVIDIA/DALI/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NVIDIA/DALI/teams","hooks_url":"https://api.github.com/repos/NVIDIA/DALI/hooks","issue_events_url":"https://api.github.com/repos/NVIDIA/DALI/issues/events{/number}","events_url":"https://api.github.com/repos/NVIDIA/DALI/events","assignees_url":"https://api.github.com/repos/NVIDIA/DALI/assignees{/user}","branches_url":"https://api.github.com/repos/NVIDIA/DALI/branches{/branch}","tags_url":"https://api.github.com/repos/NVIDIA/DALI/tags","blobs_url":"https://api.github.com/repos/NVIDIA/DALI/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NVIDIA/DALI/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NVIDIA/DALI/git/refs{/sha}","trees_url":"https://api.github.com/repos/NVIDIA/DALI/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NVIDIA/DALI/statuses/{sha}","languages_url":"https://api.github.com/repos/NVIDIA/DALI/languages","stargazers_url":"https://api.github.com/repos/NVIDIA/DALI/stargazers","contributors_url":"https://api.github.com/repos/NVIDIA/DALI/contributors","subscribers_url":"https://api.github.com/repos/NVIDIA/DALI/subscribers","subscription_url":"https://api.github.com/repos/NVIDIA/DALI/subscription","commits_url":"https://api.github.com/repos/NVIDIA/DALI/commits{/sha}","git_commits_url":"https://api.github.com/repos/NVIDIA/DALI/git/commits{/sha}","comments_url":"https://api.github.com/repos/NVIDIA/DALI/comments{/number}","issue_comment_url":"https://api.github.com/repos/NVIDIA/DALI/issues/comments{/number}","contents_url":"https://api.github.com/repos/NVIDIA/DALI/contents/{+path}","compare_url":"https://api.github.com/repos/NVIDIA/DALI/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NVIDIA/DALI/merges","archive_url":"https://api.github.com/repos/NVIDIA/DALI/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NVIDIA/DALI/downloads","issues_url":"https://api.github.com/repos/NVIDIA/DALI/issues{/number}","pulls_url":"https://api.github.com/repos/NVIDIA/DALI/pulls{/number}","milestones_url":"https://api.github.com/repos/NVIDIA/DALI/milestones{/number}","notifications_url":"https://api.github.com/repos/NVIDIA/DALI/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NVIDIA/DALI/labels{/name}","releases_url":"https://api.github.com/repos/NVIDIA/DALI/releases{/id}","deployments_url":"https://api.github.com/repos/NVIDIA/DALI/deployments","created_at":"2018-06-01T22:18:01Z","updated_at":"2019-01-04T10:51:18Z","pushed_at":"2019-01-04T13:38:14Z","git_url":"git://github.com/NVIDIA/DALI.git","ssh_url":"git@github.com:NVIDIA/DALI.git","clone_url":"https://github.com/NVIDIA/DALI.git","svn_url":"https://github.com/NVIDIA/DALI","homepage":"https://docs.nvidia.com/deeplearning/sdk/dali-developer-guide/index.html","size":41524,"stargazers_count":915,"watchers_count":915,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":44,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":103,"open_issues":44,"watchers":915,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/404"},"html":{"href":"https://github.com/NVIDIA/DALI/pull/404"},"issue":{"href":"https://api.github.com/repos/NVIDIA/DALI/issues/404"},"comments":{"href":"https://api.github.com/repos/NVIDIA/DALI/issues/404/comments"},"review_comments":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/404/comments"},"review_comment":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NVIDIA/DALI/pulls/404/commits"},"statuses":{"href":"https://api.github.com/repos/NVIDIA/DALI/statuses/9f7db535dc38ff10df077d4dab7b8c75dc077fda"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mzient"}}