{"action":"closed","issue":{"url":"https://api.github.com/repos/AlexMV3/Project-Codecademy-SQL/issues/1","repository_url":"https://api.github.com/repos/AlexMV3/Project-Codecademy-SQL","labels_url":"https://api.github.com/repos/AlexMV3/Project-Codecademy-SQL/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/AlexMV3/Project-Codecademy-SQL/issues/1/comments","events_url":"https://api.github.com/repos/AlexMV3/Project-Codecademy-SQL/issues/1/events","html_url":"https://github.com/AlexMV3/Project-Codecademy-SQL/issues/1","id":392563103,"node_id":"MDU6SXNzdWUzOTI1NjMxMDM=","number":1,"title":"Summary","user":{"login":"cyouh95","id":25449416,"node_id":"MDQ6VXNlcjI1NDQ5NDE2","avatar_url":"https://avatars2.githubusercontent.com/u/25449416?v=4","gravatar_id":"","url":"https://api.github.com/users/cyouh95","html_url":"https://github.com/cyouh95","followers_url":"https://api.github.com/users/cyouh95/followers","following_url":"https://api.github.com/users/cyouh95/following{/other_user}","gists_url":"https://api.github.com/users/cyouh95/gists{/gist_id}","starred_url":"https://api.github.com/users/cyouh95/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cyouh95/subscriptions","organizations_url":"https://api.github.com/users/cyouh95/orgs","repos_url":"https://api.github.com/users/cyouh95/repos","events_url":"https://api.github.com/users/cyouh95/events{/privacy}","received_events_url":"https://api.github.com/users/cyouh95/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-12-19T11:44:32Z","updated_at":"2018-12-19T16:39:46Z","closed_at":"2018-12-19T16:39:46Z","author_association":"NONE","body":"### Criteria 1: Report\r\n* _Score Level:_ 4 (Exceeds Expectations)\r\n* _Comment(s):_ Excellent job presenting your query results and thoroughly addressing each question! \r\n \r\n### Criteria 2: Query Accuracy\r\n* _Score Level:_ 4 (Exceeds Expectations)\r\n* _Comment(s):_ All queries accurately retrieve the data intended.\r\n \r\n### Criteria 3: Query Formatting\r\n* _Score Level:_ 3 (Meets Expectations)\r\n* _Comment(s):_ Overall great job on the formatting! Although one thing that may help improve readability of code is to consistently use spaces instead of tabs for the indentation (e.g. [[x](https://github.com/AlexMV3/Project-Codecademy-SQL/blob/94680e7c23bc24c0b280a1a2371448cd5cd72861/code.sql.txt#L25-L71)]). If you're not already, try using a text editor such as [these](https://www.codecademy.com/articles/text-editors-sublime-atom), where you can configure it to insert spaces when you hit the `tab` key.  \r\n\r\n   Separately, the [style guide](https://s3.amazonaws.com/codecademy-content/programs/learn-sql-from-scratch/SQL+Style+Guide+for+Learn+SQL+from+Scratch.pdf) also recommends that you refer to columns by their col number in `GROUP BY` or `ORDER BY` clause (e.g. [[x](https://github.com/AlexMV3/Project-Codecademy-SQL/blob/94680e7c23bc24c0b280a1a2371448cd5cd72861/code.sql.txt#L150)]).\r\n \r\n### Criteria 4: Understanding underlying concepts and terminology\r\n* _Score Level:_ 4 (Exceeds Expectations)\r\n* _Comment(s):_ Report demonstrates clear understanding​ of churn rates.\r\n \r\n ### Overall Score: 15/16\r\nWell done on this project! You definitely have a good understanding of churn rates as well as great grasp on all the SQL commands. \r\n\r\nThe queries are well-written, and your presentation slides are beautifully put together and showcases the results nicely! I also really like how you've plotted out the trend in churn rates with the line graphs! (although it seems you may want to double check the placement of the `churn_rate_30` and `churn_rate_87` lines on your last slide)\r\n\r\nA couple more tips:\r\n- [Here](https://github.com/AlexMV3/Project-Codecademy-SQL/blob/94680e7c23bc24c0b280a1a2371448cd5cd72861/code.sql.txt#L9-L13): Alternatively, we could more efficiently get both min and max date in a single query:\r\n```sql\r\nSELECT MIN(subscription_start) AS min_date,\r\n  MAX(subscription_end) AS max_date\r\nFROM subscriptions;\r\n```\r\n- [Here](https://github.com/AlexMV3/Project-Codecademy-SQL/blob/94680e7c23bc24c0b280a1a2371448cd5cd72861/code.sql.txt#L18-L20): The `SELECT DISTINCT` statement would also be great to use:\r\n```sql\r\nSELECT DISTINCT segment\r\nFROM subscriptions;\r\n```\r\n \r\nAs a further challenge, continue exploring different SQL commands and test writing queries using this dataset. For example, see if you can modify this code to support a large number of segments. Have fun! :)\r\n"}}
{"actor":{"display_login":"AlexMV3"}}