{"action":"created","comment":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/207678281","pull_request_review_id":143347915,"id":207678281,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzY3ODI4MQ==","diff_hunk":"@@ -163,16 +164,15 @@ func resourceArmRoleDefinitionDelete(d *schema.ResourceData, meta interface{}) e\n \tclient := meta.(*ArmClient).roleDefinitionsClient\n \tctx := meta.(*ArmClient).StopContext\n \n-\troleDefinitionId := d.Get(\"role_definition_id\").(string)\n \tscope := d.Get(\"scope\").(string)\n \n-\tresp, err := client.Delete(ctx, scope, roleDefinitionId)\n+\tresp, err := client.Delete(ctx, scope, filepath.Base(d.Id()))","path":"azurerm/resource_arm_role_definition.go","position":27,"original_position":27,"commit_id":"a9efd4ab5fd6247761d8e299a7508278b214ebfa","original_commit_id":"a9efd4ab5fd6247761d8e299a7508278b214ebfa","user":{"login":"katbyte","id":1638467,"node_id":"MDQ6VXNlcjE2Mzg0Njc=","avatar_url":"https://avatars2.githubusercontent.com/u/1638467?v=4","gravatar_id":"","url":"https://api.github.com/users/katbyte","html_url":"https://github.com/katbyte","followers_url":"https://api.github.com/users/katbyte/followers","following_url":"https://api.github.com/users/katbyte/following{/other_user}","gists_url":"https://api.github.com/users/katbyte/gists{/gist_id}","starred_url":"https://api.github.com/users/katbyte/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/katbyte/subscriptions","organizations_url":"https://api.github.com/users/katbyte/orgs","repos_url":"https://api.github.com/users/katbyte/repos","events_url":"https://api.github.com/users/katbyte/events{/privacy}","received_events_url":"https://api.github.com/users/katbyte/received_events","type":"User","site_admin":false},"body":"as above","created_at":"2018-08-03T22:05:06Z","updated_at":"2018-08-03T22:07:52Z","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1724#discussion_r207678281","pull_request_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1724","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments/207678281"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1724#discussion_r207678281"},"pull_request":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1724"}}},"pull_request":{"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1724","id":206081808,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MDgxODA4","html_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1724","diff_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1724.diff","patch_url":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1724.patch","issue_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/1724","number":1724,"state":"open","locked":false,"title":"Modify Update and Delete azurerm_role_definition","user":{"login":"shelleybess","id":24594686,"node_id":"MDQ6VXNlcjI0NTk0Njg2","avatar_url":"https://avatars3.githubusercontent.com/u/24594686?v=4","gravatar_id":"","url":"https://api.github.com/users/shelleybess","html_url":"https://github.com/shelleybess","followers_url":"https://api.github.com/users/shelleybess/followers","following_url":"https://api.github.com/users/shelleybess/following{/other_user}","gists_url":"https://api.github.com/users/shelleybess/gists{/gist_id}","starred_url":"https://api.github.com/users/shelleybess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shelleybess/subscriptions","organizations_url":"https://api.github.com/users/shelleybess/orgs","repos_url":"https://api.github.com/users/shelleybess/repos","events_url":"https://api.github.com/users/shelleybess/events{/privacy}","received_events_url":"https://api.github.com/users/shelleybess/received_events","type":"User","site_admin":false},"body":"This pull request addresses the issue described in https://github.com/terraform-providers/terraform-provider-azurerm/issues/1540 where the azurerm_role_definition was unable to be updated or deleted.\r\n\r\nChanges to Delete:\r\nChanges have been made to get the path of the resource and pull the id from the end.\r\n\r\nChanges to CreateOrUpdate:\r\nNow retrieves the id from the end of the path if it exists or generates one if the resource path is empty.","created_at":"2018-08-03T16:37:16Z","updated_at":"2018-08-03T22:07:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"93578c45f75e433642495e5f501cd836eca10f59","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1724/commits","review_comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1724/comments","review_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/1724/comments","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/a9efd4ab5fd6247761d8e299a7508278b214ebfa","head":{"label":"VertivSRE:role-definition-create-delete","ref":"role-definition-create-delete","sha":"a9efd4ab5fd6247761d8e299a7508278b214ebfa","user":{"login":"VertivSRE","id":35744678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzQ0Njc4","avatar_url":"https://avatars2.githubusercontent.com/u/35744678?v=4","gravatar_id":"","url":"https://api.github.com/users/VertivSRE","html_url":"https://github.com/VertivSRE","followers_url":"https://api.github.com/users/VertivSRE/followers","following_url":"https://api.github.com/users/VertivSRE/following{/other_user}","gists_url":"https://api.github.com/users/VertivSRE/gists{/gist_id}","starred_url":"https://api.github.com/users/VertivSRE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VertivSRE/subscriptions","organizations_url":"https://api.github.com/users/VertivSRE/orgs","repos_url":"https://api.github.com/users/VertivSRE/repos","events_url":"https://api.github.com/users/VertivSRE/events{/privacy}","received_events_url":"https://api.github.com/users/VertivSRE/received_events","type":"Organization","site_admin":false},"repo":{"id":122666583,"node_id":"MDEwOlJlcG9zaXRvcnkxMjI2NjY1ODM=","name":"terraform-provider-azurerm","full_name":"VertivSRE/terraform-provider-azurerm","owner":{"login":"VertivSRE","id":35744678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM1NzQ0Njc4","avatar_url":"https://avatars2.githubusercontent.com/u/35744678?v=4","gravatar_id":"","url":"https://api.github.com/users/VertivSRE","html_url":"https://github.com/VertivSRE","followers_url":"https://api.github.com/users/VertivSRE/followers","following_url":"https://api.github.com/users/VertivSRE/following{/other_user}","gists_url":"https://api.github.com/users/VertivSRE/gists{/gist_id}","starred_url":"https://api.github.com/users/VertivSRE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/VertivSRE/subscriptions","organizations_url":"https://api.github.com/users/VertivSRE/orgs","repos_url":"https://api.github.com/users/VertivSRE/repos","events_url":"https://api.github.com/users/VertivSRE/events{/privacy}","received_events_url":"https://api.github.com/users/VertivSRE/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/VertivSRE/terraform-provider-azurerm","description":"Terraform Azure Resource Manager provider","fork":true,"url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/VertivSRE/terraform-provider-azurerm/deployments","created_at":"2018-02-23T19:58:22Z","updated_at":"2018-02-23T19:58:25Z","pushed_at":"2018-08-03T16:28:38Z","git_url":"git://github.com/VertivSRE/terraform-provider-azurerm.git","ssh_url":"git@github.com:VertivSRE/terraform-provider-azurerm.git","clone_url":"https://github.com/VertivSRE/terraform-provider-azurerm.git","svn_url":"https://github.com/VertivSRE/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":18627,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"terraform-providers:master","ref":"master","sha":"58056f0cdc74290ee040825d477c0f0532d07eed","user":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"repo":{"id":93446042,"node_id":"MDEwOlJlcG9zaXRvcnk5MzQ0NjA0Mg==","name":"terraform-provider-azurerm","full_name":"terraform-providers/terraform-provider-azurerm","owner":{"login":"terraform-providers","id":29154831,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI5MTU0ODMx","avatar_url":"https://avatars0.githubusercontent.com/u/29154831?v=4","gravatar_id":"","url":"https://api.github.com/users/terraform-providers","html_url":"https://github.com/terraform-providers","followers_url":"https://api.github.com/users/terraform-providers/followers","following_url":"https://api.github.com/users/terraform-providers/following{/other_user}","gists_url":"https://api.github.com/users/terraform-providers/gists{/gist_id}","starred_url":"https://api.github.com/users/terraform-providers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/terraform-providers/subscriptions","organizations_url":"https://api.github.com/users/terraform-providers/orgs","repos_url":"https://api.github.com/users/terraform-providers/repos","events_url":"https://api.github.com/users/terraform-providers/events{/privacy}","received_events_url":"https://api.github.com/users/terraform-providers/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/terraform-providers/terraform-provider-azurerm","description":"Terraform Azure Resource Manager provider","fork":false,"url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm","forks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/forks","keys_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/teams","hooks_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/hooks","issue_events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/events{/number}","events_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/events","assignees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/assignees{/user}","branches_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/branches{/branch}","tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/tags","blobs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/refs{/sha}","trees_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/{sha}","languages_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/languages","stargazers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/stargazers","contributors_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contributors","subscribers_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscribers","subscription_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/subscription","commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/commits{/sha}","git_commits_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/git/commits{/sha}","comments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/comments{/number}","issue_comment_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/comments{/number}","contents_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/contents/{+path}","compare_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/merges","archive_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/downloads","issues_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues{/number}","pulls_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls{/number}","milestones_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/milestones{/number}","notifications_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/labels{/name}","releases_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/releases{/id}","deployments_url":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/deployments","created_at":"2017-06-05T20:53:54Z","updated_at":"2018-08-03T20:44:35Z","pushed_at":"2018-08-03T17:18:33Z","git_url":"git://github.com/terraform-providers/terraform-provider-azurerm.git","ssh_url":"git@github.com:terraform-providers/terraform-provider-azurerm.git","clone_url":"https://github.com/terraform-providers/terraform-provider-azurerm.git","svn_url":"https://github.com/terraform-providers/terraform-provider-azurerm","homepage":"https://www.terraform.io/docs/providers/azurerm/","size":18910,"stargazers_count":409,"watchers_count":409,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":369,"mirror_url":null,"archived":false,"open_issues_count":269,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":369,"open_issues":269,"watchers":409,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1724"},"html":{"href":"https://github.com/terraform-providers/terraform-provider-azurerm/pull/1724"},"issue":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/1724"},"comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/issues/1724/comments"},"review_comments":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1724/comments"},"review_comment":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/pulls/1724/commits"},"statuses":{"href":"https://api.github.com/repos/terraform-providers/terraform-provider-azurerm/statuses/a9efd4ab5fd6247761d8e299a7508278b214ebfa"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"katbyte"}}