{"action":"created","comment":{"url":"https://api.github.com/repos/jendrikseipp/vulture/pulls/comments/205512661","pull_request_review_id":140797328,"id":205512661,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTUxMjY2MQ==","diff_hunk":"@@ -0,0 +1,134 @@\n+import pytest\n+\n+from vulture import core\n+\n+from . import check, skip_if_not_has_async\n+\n+\n+@pytest.fixture","path":"tests/test_ignore.py","position":8,"original_position":8,"commit_id":"e199948e347687d92fefb97d46746b0d3ecec382","original_commit_id":"e199948e347687d92fefb97d46746b0d3ecec382","user":{"login":"jendrikseipp","id":213955,"node_id":"MDQ6VXNlcjIxMzk1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/213955?v=4","gravatar_id":"","url":"https://api.github.com/users/jendrikseipp","html_url":"https://github.com/jendrikseipp","followers_url":"https://api.github.com/users/jendrikseipp/followers","following_url":"https://api.github.com/users/jendrikseipp/following{/other_user}","gists_url":"https://api.github.com/users/jendrikseipp/gists{/gist_id}","starred_url":"https://api.github.com/users/jendrikseipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendrikseipp/subscriptions","organizations_url":"https://api.github.com/users/jendrikseipp/orgs","repos_url":"https://api.github.com/users/jendrikseipp/repos","events_url":"https://api.github.com/users/jendrikseipp/events{/privacy}","received_events_url":"https://api.github.com/users/jendrikseipp/received_events","type":"User","site_admin":false},"body":"Can't we just use the `examine` function without the pytest.fixture? The new function can still be called `check_ignore`.","created_at":"2018-07-26T16:00:00Z","updated_at":"2018-07-26T16:29:46Z","html_url":"https://github.com/jendrikseipp/vulture/pull/142#discussion_r205512661","pull_request_url":"https://api.github.com/repos/jendrikseipp/vulture/pulls/142","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jendrikseipp/vulture/pulls/comments/205512661"},"html":{"href":"https://github.com/jendrikseipp/vulture/pull/142#discussion_r205512661"},"pull_request":{"href":"https://api.github.com/repos/jendrikseipp/vulture/pulls/142"}}},"pull_request":{"url":"https://api.github.com/repos/jendrikseipp/vulture/pulls/142","id":203528218,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzNTI4MjE4","html_url":"https://github.com/jendrikseipp/vulture/pull/142","diff_url":"https://github.com/jendrikseipp/vulture/pull/142.diff","patch_url":"https://github.com/jendrikseipp/vulture/pull/142.patch","issue_url":"https://api.github.com/repos/jendrikseipp/vulture/issues/142","number":142,"state":"open","locked":false,"title":"Compare functions' decorator against ignore names","user":{"login":"RJ722","id":15556382,"node_id":"MDQ6VXNlcjE1NTU2Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/15556382?v=4","gravatar_id":"","url":"https://api.github.com/users/RJ722","html_url":"https://github.com/RJ722","followers_url":"https://api.github.com/users/RJ722/followers","following_url":"https://api.github.com/users/RJ722/following{/other_user}","gists_url":"https://api.github.com/users/RJ722/gists{/gist_id}","starred_url":"https://api.github.com/users/RJ722/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJ722/subscriptions","organizations_url":"https://api.github.com/users/RJ722/orgs","repos_url":"https://api.github.com/users/RJ722/repos","events_url":"https://api.github.com/users/RJ722/events{/privacy}","received_events_url":"https://api.github.com/users/RJ722/received_events","type":"User","site_admin":false},"body":"Currently, the ``--ignore-names`` flag only ignores names of entities whose names matches with the given input. After this PR is merged, users would be able to ignore functions on the basis of their decorators. For example, `vulture myproject.py --ignore-names \"@app.route\"` ignores all the functions which are decorated with `app.route`.\r\n\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project.\r\n- [X] My change requires a change to the documentation in the README file.\r\n- [X] I have updated the documentation accordingly.\r\n- [X] I have added an entry in NEWS.rst.\r\n- [X] I have added tests to cover my changes.\r\n- [ ] Add tests for `get_decorator_name`\r\n- [X] All new and existing tests passed.\r\n","created_at":"2018-07-24T13:33:12Z","updated_at":"2018-07-26T16:29:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7b6b7e7818b27a6fea988e23710cf390fb5effc5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jendrikseipp/vulture/pulls/142/commits","review_comments_url":"https://api.github.com/repos/jendrikseipp/vulture/pulls/142/comments","review_comment_url":"https://api.github.com/repos/jendrikseipp/vulture/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jendrikseipp/vulture/issues/142/comments","statuses_url":"https://api.github.com/repos/jendrikseipp/vulture/statuses/e199948e347687d92fefb97d46746b0d3ecec382","head":{"label":"RJ722:ignore-decorator-glob","ref":"ignore-decorator-glob","sha":"e199948e347687d92fefb97d46746b0d3ecec382","user":{"login":"RJ722","id":15556382,"node_id":"MDQ6VXNlcjE1NTU2Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/15556382?v=4","gravatar_id":"","url":"https://api.github.com/users/RJ722","html_url":"https://github.com/RJ722","followers_url":"https://api.github.com/users/RJ722/followers","following_url":"https://api.github.com/users/RJ722/following{/other_user}","gists_url":"https://api.github.com/users/RJ722/gists{/gist_id}","starred_url":"https://api.github.com/users/RJ722/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJ722/subscriptions","organizations_url":"https://api.github.com/users/RJ722/orgs","repos_url":"https://api.github.com/users/RJ722/repos","events_url":"https://api.github.com/users/RJ722/events{/privacy}","received_events_url":"https://api.github.com/users/RJ722/received_events","type":"User","site_admin":false},"repo":{"id":86101574,"node_id":"MDEwOlJlcG9zaXRvcnk4NjEwMTU3NA==","name":"vulture","full_name":"RJ722/vulture","owner":{"login":"RJ722","id":15556382,"node_id":"MDQ6VXNlcjE1NTU2Mzgy","avatar_url":"https://avatars1.githubusercontent.com/u/15556382?v=4","gravatar_id":"","url":"https://api.github.com/users/RJ722","html_url":"https://github.com/RJ722","followers_url":"https://api.github.com/users/RJ722/followers","following_url":"https://api.github.com/users/RJ722/following{/other_user}","gists_url":"https://api.github.com/users/RJ722/gists{/gist_id}","starred_url":"https://api.github.com/users/RJ722/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RJ722/subscriptions","organizations_url":"https://api.github.com/users/RJ722/orgs","repos_url":"https://api.github.com/users/RJ722/repos","events_url":"https://api.github.com/users/RJ722/events{/privacy}","received_events_url":"https://api.github.com/users/RJ722/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RJ722/vulture","description":"Find dead Python code","fork":true,"url":"https://api.github.com/repos/RJ722/vulture","forks_url":"https://api.github.com/repos/RJ722/vulture/forks","keys_url":"https://api.github.com/repos/RJ722/vulture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RJ722/vulture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RJ722/vulture/teams","hooks_url":"https://api.github.com/repos/RJ722/vulture/hooks","issue_events_url":"https://api.github.com/repos/RJ722/vulture/issues/events{/number}","events_url":"https://api.github.com/repos/RJ722/vulture/events","assignees_url":"https://api.github.com/repos/RJ722/vulture/assignees{/user}","branches_url":"https://api.github.com/repos/RJ722/vulture/branches{/branch}","tags_url":"https://api.github.com/repos/RJ722/vulture/tags","blobs_url":"https://api.github.com/repos/RJ722/vulture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RJ722/vulture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RJ722/vulture/git/refs{/sha}","trees_url":"https://api.github.com/repos/RJ722/vulture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RJ722/vulture/statuses/{sha}","languages_url":"https://api.github.com/repos/RJ722/vulture/languages","stargazers_url":"https://api.github.com/repos/RJ722/vulture/stargazers","contributors_url":"https://api.github.com/repos/RJ722/vulture/contributors","subscribers_url":"https://api.github.com/repos/RJ722/vulture/subscribers","subscription_url":"https://api.github.com/repos/RJ722/vulture/subscription","commits_url":"https://api.github.com/repos/RJ722/vulture/commits{/sha}","git_commits_url":"https://api.github.com/repos/RJ722/vulture/git/commits{/sha}","comments_url":"https://api.github.com/repos/RJ722/vulture/comments{/number}","issue_comment_url":"https://api.github.com/repos/RJ722/vulture/issues/comments{/number}","contents_url":"https://api.github.com/repos/RJ722/vulture/contents/{+path}","compare_url":"https://api.github.com/repos/RJ722/vulture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RJ722/vulture/merges","archive_url":"https://api.github.com/repos/RJ722/vulture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RJ722/vulture/downloads","issues_url":"https://api.github.com/repos/RJ722/vulture/issues{/number}","pulls_url":"https://api.github.com/repos/RJ722/vulture/pulls{/number}","milestones_url":"https://api.github.com/repos/RJ722/vulture/milestones{/number}","notifications_url":"https://api.github.com/repos/RJ722/vulture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RJ722/vulture/labels{/name}","releases_url":"https://api.github.com/repos/RJ722/vulture/releases{/id}","deployments_url":"https://api.github.com/repos/RJ722/vulture/deployments","created_at":"2017-03-24T18:59:29Z","updated_at":"2018-07-24T12:23:09Z","pushed_at":"2018-07-26T15:49:50Z","git_url":"git://github.com/RJ722/vulture.git","ssh_url":"git@github.com:RJ722/vulture.git","clone_url":"https://github.com/RJ722/vulture.git","svn_url":"https://github.com/RJ722/vulture","homepage":null,"size":495,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":2,"watchers":2,"default_branch":"master"}},"base":{"label":"jendrikseipp:master","ref":"master","sha":"806638804d8d98a54f3fe9c3fd2851b79d7bdb5a","user":{"login":"jendrikseipp","id":213955,"node_id":"MDQ6VXNlcjIxMzk1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/213955?v=4","gravatar_id":"","url":"https://api.github.com/users/jendrikseipp","html_url":"https://github.com/jendrikseipp","followers_url":"https://api.github.com/users/jendrikseipp/followers","following_url":"https://api.github.com/users/jendrikseipp/following{/other_user}","gists_url":"https://api.github.com/users/jendrikseipp/gists{/gist_id}","starred_url":"https://api.github.com/users/jendrikseipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendrikseipp/subscriptions","organizations_url":"https://api.github.com/users/jendrikseipp/orgs","repos_url":"https://api.github.com/users/jendrikseipp/repos","events_url":"https://api.github.com/users/jendrikseipp/events{/privacy}","received_events_url":"https://api.github.com/users/jendrikseipp/received_events","type":"User","site_admin":false},"repo":{"id":84045805,"node_id":"MDEwOlJlcG9zaXRvcnk4NDA0NTgwNQ==","name":"vulture","full_name":"jendrikseipp/vulture","owner":{"login":"jendrikseipp","id":213955,"node_id":"MDQ6VXNlcjIxMzk1NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/213955?v=4","gravatar_id":"","url":"https://api.github.com/users/jendrikseipp","html_url":"https://github.com/jendrikseipp","followers_url":"https://api.github.com/users/jendrikseipp/followers","following_url":"https://api.github.com/users/jendrikseipp/following{/other_user}","gists_url":"https://api.github.com/users/jendrikseipp/gists{/gist_id}","starred_url":"https://api.github.com/users/jendrikseipp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jendrikseipp/subscriptions","organizations_url":"https://api.github.com/users/jendrikseipp/orgs","repos_url":"https://api.github.com/users/jendrikseipp/repos","events_url":"https://api.github.com/users/jendrikseipp/events{/privacy}","received_events_url":"https://api.github.com/users/jendrikseipp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jendrikseipp/vulture","description":"Find dead Python code","fork":false,"url":"https://api.github.com/repos/jendrikseipp/vulture","forks_url":"https://api.github.com/repos/jendrikseipp/vulture/forks","keys_url":"https://api.github.com/repos/jendrikseipp/vulture/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jendrikseipp/vulture/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jendrikseipp/vulture/teams","hooks_url":"https://api.github.com/repos/jendrikseipp/vulture/hooks","issue_events_url":"https://api.github.com/repos/jendrikseipp/vulture/issues/events{/number}","events_url":"https://api.github.com/repos/jendrikseipp/vulture/events","assignees_url":"https://api.github.com/repos/jendrikseipp/vulture/assignees{/user}","branches_url":"https://api.github.com/repos/jendrikseipp/vulture/branches{/branch}","tags_url":"https://api.github.com/repos/jendrikseipp/vulture/tags","blobs_url":"https://api.github.com/repos/jendrikseipp/vulture/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jendrikseipp/vulture/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jendrikseipp/vulture/git/refs{/sha}","trees_url":"https://api.github.com/repos/jendrikseipp/vulture/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jendrikseipp/vulture/statuses/{sha}","languages_url":"https://api.github.com/repos/jendrikseipp/vulture/languages","stargazers_url":"https://api.github.com/repos/jendrikseipp/vulture/stargazers","contributors_url":"https://api.github.com/repos/jendrikseipp/vulture/contributors","subscribers_url":"https://api.github.com/repos/jendrikseipp/vulture/subscribers","subscription_url":"https://api.github.com/repos/jendrikseipp/vulture/subscription","commits_url":"https://api.github.com/repos/jendrikseipp/vulture/commits{/sha}","git_commits_url":"https://api.github.com/repos/jendrikseipp/vulture/git/commits{/sha}","comments_url":"https://api.github.com/repos/jendrikseipp/vulture/comments{/number}","issue_comment_url":"https://api.github.com/repos/jendrikseipp/vulture/issues/comments{/number}","contents_url":"https://api.github.com/repos/jendrikseipp/vulture/contents/{+path}","compare_url":"https://api.github.com/repos/jendrikseipp/vulture/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jendrikseipp/vulture/merges","archive_url":"https://api.github.com/repos/jendrikseipp/vulture/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jendrikseipp/vulture/downloads","issues_url":"https://api.github.com/repos/jendrikseipp/vulture/issues{/number}","pulls_url":"https://api.github.com/repos/jendrikseipp/vulture/pulls{/number}","milestones_url":"https://api.github.com/repos/jendrikseipp/vulture/milestones{/number}","notifications_url":"https://api.github.com/repos/jendrikseipp/vulture/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jendrikseipp/vulture/labels{/name}","releases_url":"https://api.github.com/repos/jendrikseipp/vulture/releases{/id}","deployments_url":"https://api.github.com/repos/jendrikseipp/vulture/deployments","created_at":"2017-03-06T08:00:18Z","updated_at":"2018-07-26T11:35:11Z","pushed_at":"2018-07-26T15:49:51Z","git_url":"git://github.com/jendrikseipp/vulture.git","ssh_url":"git@github.com:jendrikseipp/vulture.git","clone_url":"https://github.com/jendrikseipp/vulture.git","svn_url":"https://github.com/jendrikseipp/vulture","homepage":null,"size":438,"stargazers_count":270,"watchers_count":270,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":21,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":21,"open_issues":3,"watchers":270,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jendrikseipp/vulture/pulls/142"},"html":{"href":"https://github.com/jendrikseipp/vulture/pull/142"},"issue":{"href":"https://api.github.com/repos/jendrikseipp/vulture/issues/142"},"comments":{"href":"https://api.github.com/repos/jendrikseipp/vulture/issues/142/comments"},"review_comments":{"href":"https://api.github.com/repos/jendrikseipp/vulture/pulls/142/comments"},"review_comment":{"href":"https://api.github.com/repos/jendrikseipp/vulture/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jendrikseipp/vulture/pulls/142/commits"},"statuses":{"href":"https://api.github.com/repos/jendrikseipp/vulture/statuses/e199948e347687d92fefb97d46746b0d3ecec382"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jendrikseipp"}}