{"action":"created","comment":{"url":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/comments/229776485","pull_request_review_id":170167680,"id":229776485,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTc3NjQ4NQ==","diff_hunk":"@@ -484,4 +483,58 @@ private Attributes validateAttributes(Attributes ret, String serverType) {\n \t\t}\n \t\treturn null;\n \t}\n+\t\n+\tpublic IStatus addDeployable(IServer server, DeployableReference reference) {\n+\t\tIServerDelegate s = serverDelegates.get(server.getId());\n+\t\tif( s != null ) {\n+\t\t\tIStatus canAdd = s.canAddDeployable(reference);\n+\t\t\tif( canAdd.isOK()) {\n+\t\t\t\ts.getServerPublishModel().addDeployable(reference);\n+\t\t\t\treturn Status.OK_STATUS;\n+\t\t\t} else {\n+\t\t\t\treturn canAdd;\n+\t\t\t}\n+\t\t}\n+\t\treturn new Status(IStatus.ERROR, ServerCoreActivator.BUNDLE_ID, \n+\t\t\t\t\"Server \" + server.getId() + \" not found.\");\n+\t}\n+\n+\tpublic IStatus removeDeployable(IServer server, DeployableReference reference) {\n+\t\tIServerDelegate s = serverDelegates.get(server.getId());\n+\t\tif( s != null ) {\n+\t\t\tIStatus canRemove = s.canRemoveDeployable(reference);\n+\t\t\tif( canRemove.isOK()) {\n+\t\t\t\ts.getServerPublishModel().removeDeployable(reference);\n+\t\t\t\treturn Status.OK_STATUS;\n+\t\t\t} else {\n+\t\t\t\treturn canRemove;\n+\t\t\t}\n+\t\t}\n+\t\treturn new Status(IStatus.ERROR, ServerCoreActivator.BUNDLE_ID, \n+\t\t\t\t\"Server \" + server.getId() + \" not found.\");\n+\t}\n+\n+\tpublic List<DeployableState> getDeployables(IServer server) {\n+\t\tIServerDelegate s = serverDelegates.get(server.getId());\n+\t\tif( s != null ) {\n+\t\t\treturn s.getServerPublishModel().getDeployables();\n+\t\t}\n+\t\treturn new ArrayList<DeployableState>();","path":"framework/bundles/org.jboss.tools.rsp.server/src/main/java/org/jboss/tools/rsp/server/model/ServerModel.java","position":142,"original_position":141,"commit_id":"26fcc1493b5d7ee8fa296d180efcd5c795ecef03","original_commit_id":"2df1b6206322a4d8054674f4f0ba5d99c03c464f","user":{"login":"adietish","id":25126,"node_id":"MDQ6VXNlcjI1MTI2","avatar_url":"https://avatars3.githubusercontent.com/u/25126?v=4","gravatar_id":"","url":"https://api.github.com/users/adietish","html_url":"https://github.com/adietish","followers_url":"https://api.github.com/users/adietish/followers","following_url":"https://api.github.com/users/adietish/following{/other_user}","gists_url":"https://api.github.com/users/adietish/gists{/gist_id}","starred_url":"https://api.github.com/users/adietish/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adietish/subscriptions","organizations_url":"https://api.github.com/users/adietish/orgs","repos_url":"https://api.github.com/users/adietish/repos","events_url":"https://api.github.com/users/adietish/events{/privacy}","received_events_url":"https://api.github.com/users/adietish/received_events","type":"User","site_admin":false},"body":"List.emtpyList() would be more expressive.","created_at":"2018-10-31T16:43:15Z","updated_at":"2018-10-31T16:48:03Z","html_url":"https://github.com/redhat-developer/rsp-server/pull/141#discussion_r229776485","pull_request_url":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/141","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/comments/229776485"},"html":{"href":"https://github.com/redhat-developer/rsp-server/pull/141#discussion_r229776485"},"pull_request":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/141"}}},"pull_request":{"url":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/141","id":226928565,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTI4NTY1","html_url":"https://github.com/redhat-developer/rsp-server/pull/141","diff_url":"https://github.com/redhat-developer/rsp-server/pull/141.diff","patch_url":"https://github.com/redhat-developer/rsp-server/pull/141.patch","issue_url":"https://api.github.com/repos/redhat-developer/rsp-server/issues/141","number":141,"state":"open","locked":false,"title":"Publishing API / SPI - initial Impl","user":{"login":"robstryker","id":630383,"node_id":"MDQ6VXNlcjYzMDM4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/630383?v=4","gravatar_id":"","url":"https://api.github.com/users/robstryker","html_url":"https://github.com/robstryker","followers_url":"https://api.github.com/users/robstryker/followers","following_url":"https://api.github.com/users/robstryker/following{/other_user}","gists_url":"https://api.github.com/users/robstryker/gists{/gist_id}","starred_url":"https://api.github.com/users/robstryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstryker/subscriptions","organizations_url":"https://api.github.com/users/robstryker/orgs","repos_url":"https://api.github.com/users/robstryker/repos","events_url":"https://api.github.com/users/robstryker/events{/privacy}","received_events_url":"https://api.github.com/users/robstryker/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-30T13:48:06Z","updated_at":"2018-10-31T16:48:03Z","closed_at":null,"merged_at":null,"merge_commit_sha":"966b9f844e2d03b9e3e7a5db2ff562b49f7a0e2a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":1040615876,"node_id":"MDU6TGFiZWwxMDQwNjE1ODc2","url":"https://api.github.com/repos/redhat-developer/rsp-server/labels/review","name":"review","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/141/commits","review_comments_url":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/141/comments","review_comment_url":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/comments{/number}","comments_url":"https://api.github.com/repos/redhat-developer/rsp-server/issues/141/comments","statuses_url":"https://api.github.com/repos/redhat-developer/rsp-server/statuses/26fcc1493b5d7ee8fa296d180efcd5c795ecef03","head":{"label":"robstryker:publishing","ref":"publishing","sha":"26fcc1493b5d7ee8fa296d180efcd5c795ecef03","user":{"login":"robstryker","id":630383,"node_id":"MDQ6VXNlcjYzMDM4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/630383?v=4","gravatar_id":"","url":"https://api.github.com/users/robstryker","html_url":"https://github.com/robstryker","followers_url":"https://api.github.com/users/robstryker/followers","following_url":"https://api.github.com/users/robstryker/following{/other_user}","gists_url":"https://api.github.com/users/robstryker/gists{/gist_id}","starred_url":"https://api.github.com/users/robstryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstryker/subscriptions","organizations_url":"https://api.github.com/users/robstryker/orgs","repos_url":"https://api.github.com/users/robstryker/repos","events_url":"https://api.github.com/users/robstryker/events{/privacy}","received_events_url":"https://api.github.com/users/robstryker/received_events","type":"User","site_admin":false},"repo":{"id":144902202,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQ5MDIyMDI=","name":"rsp-server","full_name":"robstryker/rsp-server","private":false,"owner":{"login":"robstryker","id":630383,"node_id":"MDQ6VXNlcjYzMDM4Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/630383?v=4","gravatar_id":"","url":"https://api.github.com/users/robstryker","html_url":"https://github.com/robstryker","followers_url":"https://api.github.com/users/robstryker/followers","following_url":"https://api.github.com/users/robstryker/following{/other_user}","gists_url":"https://api.github.com/users/robstryker/gists{/gist_id}","starred_url":"https://api.github.com/users/robstryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstryker/subscriptions","organizations_url":"https://api.github.com/users/robstryker/orgs","repos_url":"https://api.github.com/users/robstryker/repos","events_url":"https://api.github.com/users/robstryker/events{/privacy}","received_events_url":"https://api.github.com/users/robstryker/received_events","type":"User","site_admin":false},"html_url":"https://github.com/robstryker/rsp-server","description":"A server management protocol based on LSP4J","fork":true,"url":"https://api.github.com/repos/robstryker/rsp-server","forks_url":"https://api.github.com/repos/robstryker/rsp-server/forks","keys_url":"https://api.github.com/repos/robstryker/rsp-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/robstryker/rsp-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/robstryker/rsp-server/teams","hooks_url":"https://api.github.com/repos/robstryker/rsp-server/hooks","issue_events_url":"https://api.github.com/repos/robstryker/rsp-server/issues/events{/number}","events_url":"https://api.github.com/repos/robstryker/rsp-server/events","assignees_url":"https://api.github.com/repos/robstryker/rsp-server/assignees{/user}","branches_url":"https://api.github.com/repos/robstryker/rsp-server/branches{/branch}","tags_url":"https://api.github.com/repos/robstryker/rsp-server/tags","blobs_url":"https://api.github.com/repos/robstryker/rsp-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/robstryker/rsp-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/robstryker/rsp-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/robstryker/rsp-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/robstryker/rsp-server/statuses/{sha}","languages_url":"https://api.github.com/repos/robstryker/rsp-server/languages","stargazers_url":"https://api.github.com/repos/robstryker/rsp-server/stargazers","contributors_url":"https://api.github.com/repos/robstryker/rsp-server/contributors","subscribers_url":"https://api.github.com/repos/robstryker/rsp-server/subscribers","subscription_url":"https://api.github.com/repos/robstryker/rsp-server/subscription","commits_url":"https://api.github.com/repos/robstryker/rsp-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/robstryker/rsp-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/robstryker/rsp-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/robstryker/rsp-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/robstryker/rsp-server/contents/{+path}","compare_url":"https://api.github.com/repos/robstryker/rsp-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/robstryker/rsp-server/merges","archive_url":"https://api.github.com/repos/robstryker/rsp-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/robstryker/rsp-server/downloads","issues_url":"https://api.github.com/repos/robstryker/rsp-server/issues{/number}","pulls_url":"https://api.github.com/repos/robstryker/rsp-server/pulls{/number}","milestones_url":"https://api.github.com/repos/robstryker/rsp-server/milestones{/number}","notifications_url":"https://api.github.com/repos/robstryker/rsp-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/robstryker/rsp-server/labels{/name}","releases_url":"https://api.github.com/repos/robstryker/rsp-server/releases{/id}","deployments_url":"https://api.github.com/repos/robstryker/rsp-server/deployments","created_at":"2018-08-15T20:51:51Z","updated_at":"2018-08-22T16:11:09Z","pushed_at":"2018-10-31T16:35:24Z","git_url":"git://github.com/robstryker/rsp-server.git","ssh_url":"git@github.com:robstryker/rsp-server.git","clone_url":"https://github.com/robstryker/rsp-server.git","svn_url":"https://github.com/robstryker/rsp-server","homepage":"","size":1489,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"redhat-developer:master","ref":"master","sha":"ceef6bcd5d1363d45f0cf8bb61ec12c09e44002a","user":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"repo":{"id":129792995,"node_id":"MDEwOlJlcG9zaXRvcnkxMjk3OTI5OTU=","name":"rsp-server","full_name":"redhat-developer/rsp-server","private":false,"owner":{"login":"redhat-developer","id":11033755,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMDMzNzU1","avatar_url":"https://avatars0.githubusercontent.com/u/11033755?v=4","gravatar_id":"","url":"https://api.github.com/users/redhat-developer","html_url":"https://github.com/redhat-developer","followers_url":"https://api.github.com/users/redhat-developer/followers","following_url":"https://api.github.com/users/redhat-developer/following{/other_user}","gists_url":"https://api.github.com/users/redhat-developer/gists{/gist_id}","starred_url":"https://api.github.com/users/redhat-developer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/redhat-developer/subscriptions","organizations_url":"https://api.github.com/users/redhat-developer/orgs","repos_url":"https://api.github.com/users/redhat-developer/repos","events_url":"https://api.github.com/users/redhat-developer/events{/privacy}","received_events_url":"https://api.github.com/users/redhat-developer/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/redhat-developer/rsp-server","description":"A server management protocol based on LSP4J","fork":false,"url":"https://api.github.com/repos/redhat-developer/rsp-server","forks_url":"https://api.github.com/repos/redhat-developer/rsp-server/forks","keys_url":"https://api.github.com/repos/redhat-developer/rsp-server/keys{/key_id}","collaborators_url":"https://api.github.com/repos/redhat-developer/rsp-server/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/redhat-developer/rsp-server/teams","hooks_url":"https://api.github.com/repos/redhat-developer/rsp-server/hooks","issue_events_url":"https://api.github.com/repos/redhat-developer/rsp-server/issues/events{/number}","events_url":"https://api.github.com/repos/redhat-developer/rsp-server/events","assignees_url":"https://api.github.com/repos/redhat-developer/rsp-server/assignees{/user}","branches_url":"https://api.github.com/repos/redhat-developer/rsp-server/branches{/branch}","tags_url":"https://api.github.com/repos/redhat-developer/rsp-server/tags","blobs_url":"https://api.github.com/repos/redhat-developer/rsp-server/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/redhat-developer/rsp-server/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/redhat-developer/rsp-server/git/refs{/sha}","trees_url":"https://api.github.com/repos/redhat-developer/rsp-server/git/trees{/sha}","statuses_url":"https://api.github.com/repos/redhat-developer/rsp-server/statuses/{sha}","languages_url":"https://api.github.com/repos/redhat-developer/rsp-server/languages","stargazers_url":"https://api.github.com/repos/redhat-developer/rsp-server/stargazers","contributors_url":"https://api.github.com/repos/redhat-developer/rsp-server/contributors","subscribers_url":"https://api.github.com/repos/redhat-developer/rsp-server/subscribers","subscription_url":"https://api.github.com/repos/redhat-developer/rsp-server/subscription","commits_url":"https://api.github.com/repos/redhat-developer/rsp-server/commits{/sha}","git_commits_url":"https://api.github.com/repos/redhat-developer/rsp-server/git/commits{/sha}","comments_url":"https://api.github.com/repos/redhat-developer/rsp-server/comments{/number}","issue_comment_url":"https://api.github.com/repos/redhat-developer/rsp-server/issues/comments{/number}","contents_url":"https://api.github.com/repos/redhat-developer/rsp-server/contents/{+path}","compare_url":"https://api.github.com/repos/redhat-developer/rsp-server/compare/{base}...{head}","merges_url":"https://api.github.com/repos/redhat-developer/rsp-server/merges","archive_url":"https://api.github.com/repos/redhat-developer/rsp-server/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/redhat-developer/rsp-server/downloads","issues_url":"https://api.github.com/repos/redhat-developer/rsp-server/issues{/number}","pulls_url":"https://api.github.com/repos/redhat-developer/rsp-server/pulls{/number}","milestones_url":"https://api.github.com/repos/redhat-developer/rsp-server/milestones{/number}","notifications_url":"https://api.github.com/repos/redhat-developer/rsp-server/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/redhat-developer/rsp-server/labels{/name}","releases_url":"https://api.github.com/repos/redhat-developer/rsp-server/releases{/id}","deployments_url":"https://api.github.com/repos/redhat-developer/rsp-server/deployments","created_at":"2018-04-16T19:11:05Z","updated_at":"2018-10-30T16:30:12Z","pushed_at":"2018-10-31T16:35:26Z","git_url":"git://github.com/redhat-developer/rsp-server.git","ssh_url":"git@github.com:redhat-developer/rsp-server.git","clone_url":"https://github.com/redhat-developer/rsp-server.git","svn_url":"https://github.com/redhat-developer/rsp-server","homepage":"","size":1396,"stargazers_count":3,"watchers_count":3,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":7,"license":null,"forks":13,"open_issues":7,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/141"},"html":{"href":"https://github.com/redhat-developer/rsp-server/pull/141"},"issue":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/issues/141"},"comments":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/issues/141/comments"},"review_comments":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/141/comments"},"review_comment":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/pulls/141/commits"},"statuses":{"href":"https://api.github.com/repos/redhat-developer/rsp-server/statuses/26fcc1493b5d7ee8fa296d180efcd5c795ecef03"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"adietish"}}