{"action":"created","issue":{"url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/183","repository_url":"https://api.github.com/repos/flatpak/flatpak-builder","labels_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/183/labels{/name}","comments_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/183/comments","events_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/183/events","html_url":"https://github.com/flatpak/flatpak-builder/pull/183","id":340941558,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxMjMxMjA1","number":183,"title":"builder: Ensure committer is set when running git-commit","user":{"login":"hadess","id":769861,"node_id":"MDQ6VXNlcjc2OTg2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/769861?v=4","gravatar_id":"","url":"https://api.github.com/users/hadess","html_url":"https://github.com/hadess","followers_url":"https://api.github.com/users/hadess/followers","following_url":"https://api.github.com/users/hadess/following{/other_user}","gists_url":"https://api.github.com/users/hadess/gists{/gist_id}","starred_url":"https://api.github.com/users/hadess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadess/subscriptions","organizations_url":"https://api.github.com/users/hadess/orgs","repos_url":"https://api.github.com/users/hadess/repos","events_url":"https://api.github.com/users/hadess/events{/privacy}","received_events_url":"https://api.github.com/users/hadess/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-13T09:11:47Z","updated_at":"2018-08-08T10:39:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/flatpak/flatpak-builder/pulls/183","html_url":"https://github.com/flatpak/flatpak-builder/pull/183","diff_url":"https://github.com/flatpak/flatpak-builder/pull/183.diff","patch_url":"https://github.com/flatpak/flatpak-builder/pull/183.patch"},"body":"Otherwise buildbots, and other non-interactive/clean-room builds might\r\nnot have git committer information set, and make it impossible to\r\nsuccessfully commit, and git erroring out with:\r\n*** Please tell me who you are.\r\n\r\nThis should fix https://github.com/flathub/flathub/pull/443#issuecomment-402062013"},"comment":{"url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/comments/411363359","html_url":"https://github.com/flatpak/flatpak-builder/pull/183#issuecomment-411363359","issue_url":"https://api.github.com/repos/flatpak/flatpak-builder/issues/183","id":411363359,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMTM2MzM1OQ==","user":{"login":"hadess","id":769861,"node_id":"MDQ6VXNlcjc2OTg2MQ==","avatar_url":"https://avatars1.githubusercontent.com/u/769861?v=4","gravatar_id":"","url":"https://api.github.com/users/hadess","html_url":"https://github.com/hadess","followers_url":"https://api.github.com/users/hadess/followers","following_url":"https://api.github.com/users/hadess/following{/other_user}","gists_url":"https://api.github.com/users/hadess/gists{/gist_id}","starred_url":"https://api.github.com/users/hadess/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hadess/subscriptions","organizations_url":"https://api.github.com/users/hadess/orgs","repos_url":"https://api.github.com/users/hadess/repos","events_url":"https://api.github.com/users/hadess/events{/privacy}","received_events_url":"https://api.github.com/users/hadess/received_events","type":"User","site_admin":false},"created_at":"2018-08-08T10:39:43Z","updated_at":"2018-08-08T10:39:43Z","author_association":"CONTRIBUTOR","body":"> I think just forcing GIT_AUTHOR_EMAIL and GIT_COMMITTER_EMAIL to be set in main() is the right approach. Then we're guaranteeing this to work for all git invocations, and we make the result more reproducible than sometimes using the real authors name. No created commits from flatpak-builder are persistent, except possibly flatpak-builder --run, so we should not set it there.\r\n\r\nIf I do that, we don't have a `GIT_AUTHOR_NAME` that corresponds to the package name, but that's not really a big deal."}}
{"actor":{"display_login":"hadess"}}