{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/45107","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/45107/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/45107/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/45107/events","html_url":"https://github.com/Microsoft/vscode/issues/45107","id":302548971,"number":45107,"title":"Line wrapping breaks custom problem matchers","user":{"login":"kendfrey","id":1657228,"avatar_url":"https://avatars1.githubusercontent.com/u/1657228?v=4","gravatar_id":"","url":"https://api.github.com/users/kendfrey","html_url":"https://github.com/kendfrey","followers_url":"https://api.github.com/users/kendfrey/followers","following_url":"https://api.github.com/users/kendfrey/following{/other_user}","gists_url":"https://api.github.com/users/kendfrey/gists{/gist_id}","starred_url":"https://api.github.com/users/kendfrey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kendfrey/subscriptions","organizations_url":"https://api.github.com/users/kendfrey/orgs","repos_url":"https://api.github.com/users/kendfrey/repos","events_url":"https://api.github.com/users/kendfrey/events{/privacy}","received_events_url":"https://api.github.com/users/kendfrey/received_events","type":"User","site_admin":false},"labels":[{"id":362694632,"url":"https://api.github.com/repos/Microsoft/vscode/labels/integrated-terminal","name":"integrated-terminal","color":"1d76db","default":false},{"id":578047123,"url":"https://api.github.com/repos/Microsoft/vscode/labels/under-discussion","name":"under-discussion","color":"dcdcdc","default":false},{"id":374931321,"url":"https://api.github.com/repos/Microsoft/vscode/labels/windows","name":"windows","color":"006b75","default":false}],"state":"open","locked":false,"assignee":{"login":"dbaeumer","id":1931590,"avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"assignees":[{"login":"dbaeumer","id":1931590,"avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},{"login":"Tyriar","id":2193314,"avatar_url":"https://avatars0.githubusercontent.com/u/2193314?v=4","gravatar_id":"","url":"https://api.github.com/users/Tyriar","html_url":"https://github.com/Tyriar","followers_url":"https://api.github.com/users/Tyriar/followers","following_url":"https://api.github.com/users/Tyriar/following{/other_user}","gists_url":"https://api.github.com/users/Tyriar/gists{/gist_id}","starred_url":"https://api.github.com/users/Tyriar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Tyriar/subscriptions","organizations_url":"https://api.github.com/users/Tyriar/orgs","repos_url":"https://api.github.com/users/Tyriar/repos","events_url":"https://api.github.com/users/Tyriar/events{/privacy}","received_events_url":"https://api.github.com/users/Tyriar/received_events","type":"User","site_admin":false}],"milestone":null,"comments":9,"created_at":"2018-03-06T03:15:26Z","updated_at":"2018-03-26T07:47:41Z","closed_at":null,"author_association":"NONE","body":"### Issue Type\r\nBug\r\n\r\n### Description\r\n\r\n#### Steps to reproduce:\r\nBuild task with custom problem matcher:\r\n```json\r\n{\r\n\t\"label\": \"build\",\r\n\t\"type\": \"shell\",\r\n\t\"command\": \"make\",\r\n\t\"group\": {\r\n\t\t\"kind\": \"build\",\r\n\t\t\"isDefault\": true\r\n\t},\r\n\t\"problemMatcher\": {\r\n\t\t\"owner\": \"tslint\",\r\n\t\t\"fileLocation\": \"absolute\",\r\n\t\t\"pattern\": {\r\n\t\t\t\"regexp\": \"^(ERROR|WARNING): \\\\((.+?)\\\\) (.+?)\\\\[(\\\\d+),\\\\D*(\\\\d+)\\\\]: (.+)$\",\r\n\t\t\t\"severity\": 1,\r\n\t\t\t\"code\": 2,\r\n\t\t\t\"file\": 3,\r\n\t\t\t\"line\": 4,\r\n\t\t\t\"column\": 5,\r\n\t\t\t\"message\": 6\r\n\t\t}\r\n\t}\r\n}\r\n```\r\nBuild output:\r\n```\r\n> Executing task: make <\r\n\r\ntsc\r\ntslint -t verbose -p tsconfig.json\r\nERROR: (typedef) C:/Users/Kendall/Source/ncre/src/ncre.ts[77, 20]: expected arrow-call-signature to have a typedef\r\n\r\nmake: *** [lint] Error 2\r\nThe terminal process terminated with exit code: 2\r\n\r\nTerminal will be reused by tasks, press any key to close it.\r\n```\r\nThe bug appears for certain widths of the terminal panel and how they wrap output (see screenshots).\r\n\r\n#### Screenshots:\r\n1:\r\n![1](https://i.imgur.com/MiEvRs4.png)\r\n2:\r\n![2](https://i.imgur.com/IFz0tQq.png)\r\n3:\r\n![3](https://i.imgur.com/bMT0bdi.png)\r\n(Note the extra space in 2 that is missing from 3, because 3 has the panel slightly wider.)\r\n\r\n#### Result:\r\nWrapping as in screenshots 1 and 2 cause the error to appear in the Problems panel. Screenshot 3 results in an empty Problems panel (the problem matcher does not match that error).\r\n\r\n#### Expected result:\r\nAll three cases should result in the error appearing in the Problems panel.\r\n\r\n#### Workaround (temporary):\r\nResize the Terminal panel.\r\n\r\n#### Notes:\r\nThis looks nearly identical to #32042. I don't know if it's a regression, a missed edge case, or just a similar problem somewhere else.\r\n\r\n### VS Code Info\r\n\r\nVS Code version: Code 1.20.1 (f88bbf9137d24d36d968ea6b2911786bfe103002, 2018-02-13T15:34:36.336Z)\r\nOS version: Windows_NT x64 10.0.16299\r\n\r\n<details>\r\n<summary>System Info</summary>\r\n\r\n|Item|Value|\r\n|---|---|\r\n|CPUs|Intel(R) Core(TM) i7-4790K CPU @ 4.00GHz (8 x 4000)|\r\n|Memory (System)|15.95GB (9.16GB free)|\r\n|Process Argv|C:\\Program Files\\Microsoft VS Code\\Code.exe|\r\n|Screen Reader|no|\r\n|VM|50%|\r\n\r\n</details>Extensions: none\r\nReproduces without extensions"},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/376075829","html_url":"https://github.com/Microsoft/vscode/issues/45107#issuecomment-376075829","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/45107","id":376075829,"user":{"login":"dbaeumer","id":1931590,"avatar_url":"https://avatars1.githubusercontent.com/u/1931590?v=4","gravatar_id":"","url":"https://api.github.com/users/dbaeumer","html_url":"https://github.com/dbaeumer","followers_url":"https://api.github.com/users/dbaeumer/followers","following_url":"https://api.github.com/users/dbaeumer/following{/other_user}","gists_url":"https://api.github.com/users/dbaeumer/gists{/gist_id}","starred_url":"https://api.github.com/users/dbaeumer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbaeumer/subscriptions","organizations_url":"https://api.github.com/users/dbaeumer/orgs","repos_url":"https://api.github.com/users/dbaeumer/repos","events_url":"https://api.github.com/users/dbaeumer/events{/privacy}","received_events_url":"https://api.github.com/users/dbaeumer/received_events","type":"User","site_admin":false},"created_at":"2018-03-26T07:47:41Z","updated_at":"2018-03-26T07:47:41Z","author_association":"MEMBER","body":"@Tyriar ok. I wasn't aware that this only works on Mac/Linux. Just to make sure to understand it correctly: under Windows you don't know that the last cell has a space or was not written at all. That is why you can't 'un-wrap' the line correctly under Windows.\r\n\r\nIf this is true and given #43664 I only see one solution to fix this for now until we have better API under Windows as well. I would need to give you a hint if a line is a new line even if the last line runs to the end. Or we go back to having un-wrapped lines and I do some smartness on the matcher side since I know the regular expression that matches stuff. \r\n\r\nDo you have a feel for when the additional API might be available under Windows ?"}}
{"actor":{"display_login":"dbaeumer"}}