{"action":"created","comment":{"url":"https://api.github.com/repos/NREL/openstudio-standards/pulls/comments/227052216","pull_request_review_id":167006651,"id":227052216,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNzA1MjIxNg==","diff_hunk":"@@ -1211,11 +1211,14 @@ def model_eliminate_outlier_zones(model, array_of_zones, key_to_inspect, toleran\n     OpenStudio.logFree(OpenStudio::Debug, 'openstudio.standards.Model', \"names #{all_zn_names.join(', ')}\")\n \n     # Calculate the biggest delta and the index of the biggest delta\n-    biggest_delta_i = nil\n+    biggest_delta_i = 0 # array at first item in case delta is 0\n     biggest_delta = 0.0\n     worst = nil\n     array_of_zones.each_with_index do |zn, i|\n       val = zn[key_to_inspect]\n+      if worst.nil? # array at first item in case delta is 0\n+        worst = val\n+      end\n       delta = (val - avg).abs","path":"lib/openstudio-standards/standards/Standards.Model.rb","position":35,"original_position":22,"commit_id":"799da22473162984a0e641cfce9a6433cf7f158f","original_commit_id":"4138efe2b506af3edb7f1b33b0791ffc0525fee1","user":{"login":"mdahlhausen","id":2249271,"node_id":"MDQ6VXNlcjIyNDkyNzE=","avatar_url":"https://avatars1.githubusercontent.com/u/2249271?v=4","gravatar_id":"","url":"https://api.github.com/users/mdahlhausen","html_url":"https://github.com/mdahlhausen","followers_url":"https://api.github.com/users/mdahlhausen/followers","following_url":"https://api.github.com/users/mdahlhausen/following{/other_user}","gists_url":"https://api.github.com/users/mdahlhausen/gists{/gist_id}","starred_url":"https://api.github.com/users/mdahlhausen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdahlhausen/subscriptions","organizations_url":"https://api.github.com/users/mdahlhausen/orgs","repos_url":"https://api.github.com/users/mdahlhausen/repos","events_url":"https://api.github.com/users/mdahlhausen/events{/privacy}","received_events_url":"https://api.github.com/users/mdahlhausen/received_events","type":"User","site_admin":false},"body":"added a guard clause","created_at":"2018-10-22T16:53:04Z","updated_at":"2018-10-22T16:53:04Z","html_url":"https://github.com/NREL/openstudio-standards/pull/515#discussion_r227052216","pull_request_url":"https://api.github.com/repos/NREL/openstudio-standards/pulls/515","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/NREL/openstudio-standards/pulls/comments/227052216"},"html":{"href":"https://github.com/NREL/openstudio-standards/pull/515#discussion_r227052216"},"pull_request":{"href":"https://api.github.com/repos/NREL/openstudio-standards/pulls/515"}},"in_reply_to_id":226803254},"pull_request":{"url":"https://api.github.com/repos/NREL/openstudio-standards/pulls/515","id":224429675,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDI5Njc1","html_url":"https://github.com/NREL/openstudio-standards/pull/515","diff_url":"https://github.com/NREL/openstudio-standards/pull/515.diff","patch_url":"https://github.com/NREL/openstudio-standards/pull/515.patch","issue_url":"https://api.github.com/repos/NREL/openstudio-standards/issues/515","number":515,"state":"open","locked":false,"title":"zone splitting bug fix","user":{"login":"mdahlhausen","id":2249271,"node_id":"MDQ6VXNlcjIyNDkyNzE=","avatar_url":"https://avatars1.githubusercontent.com/u/2249271?v=4","gravatar_id":"","url":"https://api.github.com/users/mdahlhausen","html_url":"https://github.com/mdahlhausen","followers_url":"https://api.github.com/users/mdahlhausen/followers","following_url":"https://api.github.com/users/mdahlhausen/following{/other_user}","gists_url":"https://api.github.com/users/mdahlhausen/gists{/gist_id}","starred_url":"https://api.github.com/users/mdahlhausen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdahlhausen/subscriptions","organizations_url":"https://api.github.com/users/mdahlhausen/orgs","repos_url":"https://api.github.com/users/mdahlhausen/repos","events_url":"https://api.github.com/users/mdahlhausen/events{/privacy}","received_events_url":"https://api.github.com/users/mdahlhausen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-10-19T22:55:53Z","updated_at":"2018-10-22T16:53:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bf05877981e6bac5503a903e44c085dadc3aac8f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/NREL/openstudio-standards/pulls/515/commits","review_comments_url":"https://api.github.com/repos/NREL/openstudio-standards/pulls/515/comments","review_comment_url":"https://api.github.com/repos/NREL/openstudio-standards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NREL/openstudio-standards/issues/515/comments","statuses_url":"https://api.github.com/repos/NREL/openstudio-standards/statuses/799da22473162984a0e641cfce9a6433cf7f158f","head":{"label":"NREL:fix/zone_splitting","ref":"fix/zone_splitting","sha":"799da22473162984a0e641cfce9a6433cf7f158f","user":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":15783073,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4MzA3Mw==","name":"openstudio-standards","full_name":"NREL/openstudio-standards","private":false,"owner":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NREL/openstudio-standards","description":null,"fork":false,"url":"https://api.github.com/repos/NREL/openstudio-standards","forks_url":"https://api.github.com/repos/NREL/openstudio-standards/forks","keys_url":"https://api.github.com/repos/NREL/openstudio-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/openstudio-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/openstudio-standards/teams","hooks_url":"https://api.github.com/repos/NREL/openstudio-standards/hooks","issue_events_url":"https://api.github.com/repos/NREL/openstudio-standards/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/openstudio-standards/events","assignees_url":"https://api.github.com/repos/NREL/openstudio-standards/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/openstudio-standards/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/openstudio-standards/tags","blobs_url":"https://api.github.com/repos/NREL/openstudio-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/openstudio-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/openstudio-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/openstudio-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/openstudio-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/openstudio-standards/languages","stargazers_url":"https://api.github.com/repos/NREL/openstudio-standards/stargazers","contributors_url":"https://api.github.com/repos/NREL/openstudio-standards/contributors","subscribers_url":"https://api.github.com/repos/NREL/openstudio-standards/subscribers","subscription_url":"https://api.github.com/repos/NREL/openstudio-standards/subscription","commits_url":"https://api.github.com/repos/NREL/openstudio-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/openstudio-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/openstudio-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/openstudio-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/openstudio-standards/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/openstudio-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/openstudio-standards/merges","archive_url":"https://api.github.com/repos/NREL/openstudio-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/openstudio-standards/downloads","issues_url":"https://api.github.com/repos/NREL/openstudio-standards/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/openstudio-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/openstudio-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/openstudio-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/openstudio-standards/labels{/name}","releases_url":"https://api.github.com/repos/NREL/openstudio-standards/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/openstudio-standards/deployments","created_at":"2014-01-09T23:40:42Z","updated_at":"2018-10-11T17:27:11Z","pushed_at":"2018-10-22T16:52:41Z","git_url":"git://github.com/NREL/openstudio-standards.git","ssh_url":"git@github.com:NREL/openstudio-standards.git","clone_url":"https://github.com/NREL/openstudio-standards.git","svn_url":"https://github.com/NREL/openstudio-standards","homepage":null,"size":1007173,"stargazers_count":23,"watchers_count":23,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":120,"watchers":23,"default_branch":"master"}},"base":{"label":"NREL:master","ref":"master","sha":"feaec6da1c8d055b8495a023fe5514091ea1fe7c","user":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"repo":{"id":15783073,"node_id":"MDEwOlJlcG9zaXRvcnkxNTc4MzA3Mw==","name":"openstudio-standards","full_name":"NREL/openstudio-standards","private":false,"owner":{"login":"NREL","id":1906800,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MDY4MDA=","avatar_url":"https://avatars1.githubusercontent.com/u/1906800?v=4","gravatar_id":"","url":"https://api.github.com/users/NREL","html_url":"https://github.com/NREL","followers_url":"https://api.github.com/users/NREL/followers","following_url":"https://api.github.com/users/NREL/following{/other_user}","gists_url":"https://api.github.com/users/NREL/gists{/gist_id}","starred_url":"https://api.github.com/users/NREL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NREL/subscriptions","organizations_url":"https://api.github.com/users/NREL/orgs","repos_url":"https://api.github.com/users/NREL/repos","events_url":"https://api.github.com/users/NREL/events{/privacy}","received_events_url":"https://api.github.com/users/NREL/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/NREL/openstudio-standards","description":null,"fork":false,"url":"https://api.github.com/repos/NREL/openstudio-standards","forks_url":"https://api.github.com/repos/NREL/openstudio-standards/forks","keys_url":"https://api.github.com/repos/NREL/openstudio-standards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NREL/openstudio-standards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NREL/openstudio-standards/teams","hooks_url":"https://api.github.com/repos/NREL/openstudio-standards/hooks","issue_events_url":"https://api.github.com/repos/NREL/openstudio-standards/issues/events{/number}","events_url":"https://api.github.com/repos/NREL/openstudio-standards/events","assignees_url":"https://api.github.com/repos/NREL/openstudio-standards/assignees{/user}","branches_url":"https://api.github.com/repos/NREL/openstudio-standards/branches{/branch}","tags_url":"https://api.github.com/repos/NREL/openstudio-standards/tags","blobs_url":"https://api.github.com/repos/NREL/openstudio-standards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NREL/openstudio-standards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NREL/openstudio-standards/git/refs{/sha}","trees_url":"https://api.github.com/repos/NREL/openstudio-standards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NREL/openstudio-standards/statuses/{sha}","languages_url":"https://api.github.com/repos/NREL/openstudio-standards/languages","stargazers_url":"https://api.github.com/repos/NREL/openstudio-standards/stargazers","contributors_url":"https://api.github.com/repos/NREL/openstudio-standards/contributors","subscribers_url":"https://api.github.com/repos/NREL/openstudio-standards/subscribers","subscription_url":"https://api.github.com/repos/NREL/openstudio-standards/subscription","commits_url":"https://api.github.com/repos/NREL/openstudio-standards/commits{/sha}","git_commits_url":"https://api.github.com/repos/NREL/openstudio-standards/git/commits{/sha}","comments_url":"https://api.github.com/repos/NREL/openstudio-standards/comments{/number}","issue_comment_url":"https://api.github.com/repos/NREL/openstudio-standards/issues/comments{/number}","contents_url":"https://api.github.com/repos/NREL/openstudio-standards/contents/{+path}","compare_url":"https://api.github.com/repos/NREL/openstudio-standards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NREL/openstudio-standards/merges","archive_url":"https://api.github.com/repos/NREL/openstudio-standards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NREL/openstudio-standards/downloads","issues_url":"https://api.github.com/repos/NREL/openstudio-standards/issues{/number}","pulls_url":"https://api.github.com/repos/NREL/openstudio-standards/pulls{/number}","milestones_url":"https://api.github.com/repos/NREL/openstudio-standards/milestones{/number}","notifications_url":"https://api.github.com/repos/NREL/openstudio-standards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NREL/openstudio-standards/labels{/name}","releases_url":"https://api.github.com/repos/NREL/openstudio-standards/releases{/id}","deployments_url":"https://api.github.com/repos/NREL/openstudio-standards/deployments","created_at":"2014-01-09T23:40:42Z","updated_at":"2018-10-11T17:27:11Z","pushed_at":"2018-10-22T16:52:41Z","git_url":"git://github.com/NREL/openstudio-standards.git","ssh_url":"git@github.com:NREL/openstudio-standards.git","clone_url":"https://github.com/NREL/openstudio-standards.git","svn_url":"https://github.com/NREL/openstudio-standards","homepage":null,"size":1007173,"stargazers_count":23,"watchers_count":23,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":120,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":24,"open_issues":120,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NREL/openstudio-standards/pulls/515"},"html":{"href":"https://github.com/NREL/openstudio-standards/pull/515"},"issue":{"href":"https://api.github.com/repos/NREL/openstudio-standards/issues/515"},"comments":{"href":"https://api.github.com/repos/NREL/openstudio-standards/issues/515/comments"},"review_comments":{"href":"https://api.github.com/repos/NREL/openstudio-standards/pulls/515/comments"},"review_comment":{"href":"https://api.github.com/repos/NREL/openstudio-standards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NREL/openstudio-standards/pulls/515/commits"},"statuses":{"href":"https://api.github.com/repos/NREL/openstudio-standards/statuses/799da22473162984a0e641cfce9a6433cf7f158f"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mdahlhausen"}}