{"action":"created","comment":{"url":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/comments/191083922","pull_request_review_id":123591243,"id":191083922,"diff_hunk":"@@ -10,11 +10,18 @@ import isNaN from 'lodash/isNaN';\n  * @returns {object}\n  */\n export default function getInfoFromHash(hash) {\n-\tif (hash.substr(0, 3) === '#!/') {\n-\t\tconst tokens = hash.substr(3).split('/');\n-\t\tconst index = parseInt(tokens[1], 10);\n+\tconst shouldIsolate = hash.substr(0, 3) === '#!/';\n+\tif (shouldIsolate || hash.substr(0, 2) === '#/') {\n+\t\tconst path = hash.replace(/\\?id=[^]*/, '');\n+\t\tconst tokens = path","path":"src/utils/getInfoFromHash.js","position":10,"original_position":10,"commit_id":"a1f3903827a4bfda4d65700c8d258d2360e300d3","original_commit_id":"a1f3903827a4bfda4d65700c8d258d2360e300d3","user":{"login":"okonet","id":11071,"avatar_url":"https://avatars3.githubusercontent.com/u/11071?v=4","gravatar_id":"","url":"https://api.github.com/users/okonet","html_url":"https://github.com/okonet","followers_url":"https://api.github.com/users/okonet/followers","following_url":"https://api.github.com/users/okonet/following{/other_user}","gists_url":"https://api.github.com/users/okonet/gists{/gist_id}","starred_url":"https://api.github.com/users/okonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okonet/subscriptions","organizations_url":"https://api.github.com/users/okonet/orgs","repos_url":"https://api.github.com/users/okonet/repos","events_url":"https://api.github.com/users/okonet/events{/privacy}","received_events_url":"https://api.github.com/users/okonet/received_events","type":"User","site_admin":false},"body":"I’m wondering why not introduce a routing solution to the project? It would simplify thing a lot since we won’t need parse location ourselves I guess. ","created_at":"2018-05-27T18:03:45Z","updated_at":"2018-05-27T18:03:45Z","html_url":"https://github.com/styleguidist/react-styleguidist/pull/993#discussion_r191083922","pull_request_url":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/993","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/comments/191083922"},"html":{"href":"https://github.com/styleguidist/react-styleguidist/pull/993#discussion_r191083922"},"pull_request":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/993"}},"in_reply_to_id":191081826},"pull_request":{"url":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/993","id":190693245,"html_url":"https://github.com/styleguidist/react-styleguidist/pull/993","diff_url":"https://github.com/styleguidist/react-styleguidist/pull/993.diff","patch_url":"https://github.com/styleguidist/react-styleguidist/pull/993.patch","issue_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/993","number":993,"state":"open","locked":false,"title":"Feat: Page per section upgraded with page not found","user":{"login":"rafaesc","id":10201025,"avatar_url":"https://avatars3.githubusercontent.com/u/10201025?v=4","gravatar_id":"","url":"https://api.github.com/users/rafaesc","html_url":"https://github.com/rafaesc","followers_url":"https://api.github.com/users/rafaesc/followers","following_url":"https://api.github.com/users/rafaesc/following{/other_user}","gists_url":"https://api.github.com/users/rafaesc/gists{/gist_id}","starred_url":"https://api.github.com/users/rafaesc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rafaesc/subscriptions","organizations_url":"https://api.github.com/users/rafaesc/orgs","repos_url":"https://api.github.com/users/rafaesc/repos","events_url":"https://api.github.com/users/rafaesc/events{/privacy}","received_events_url":"https://api.github.com/users/rafaesc/received_events","type":"User","site_admin":false},"body":"\r\nThis PR is a feature of this issue:\r\nhttps://github.com/styleguidist/react-styleguidist/issues/892\r\n\r\nAnd started with this branch\r\nhttps://github.com/styleguidist/react-styleguidist/pull/989\r\n\r\nAlso added a page not found\r\n![image](https://user-images.githubusercontent.com/10201025/40565894-ecbd4c5e-6033-11e8-90a3-eef5eee6aa2f.png)\r\n\r\n","created_at":"2018-05-25T21:00:57Z","updated_at":"2018-05-27T18:03:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"649d12331e077d26a475ef2ea0f09d1efebe5040","assignee":null,"assignees":[],"requested_reviewers":[{"login":"okonet","id":11071,"avatar_url":"https://avatars3.githubusercontent.com/u/11071?v=4","gravatar_id":"","url":"https://api.github.com/users/okonet","html_url":"https://github.com/okonet","followers_url":"https://api.github.com/users/okonet/followers","following_url":"https://api.github.com/users/okonet/following{/other_user}","gists_url":"https://api.github.com/users/okonet/gists{/gist_id}","starred_url":"https://api.github.com/users/okonet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/okonet/subscriptions","organizations_url":"https://api.github.com/users/okonet/orgs","repos_url":"https://api.github.com/users/okonet/repos","events_url":"https://api.github.com/users/okonet/events{/privacy}","received_events_url":"https://api.github.com/users/okonet/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/993/commits","review_comments_url":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/993/comments","review_comment_url":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/comments{/number}","comments_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/993/comments","statuses_url":"https://api.github.com/repos/styleguidist/react-styleguidist/statuses/a1f3903827a4bfda4d65700c8d258d2360e300d3","head":{"label":"styleguidist:feat-page-per-section","ref":"feat-page-per-section","sha":"a1f3903827a4bfda4d65700c8d258d2360e300d3","user":{"login":"styleguidist","id":23550189,"avatar_url":"https://avatars1.githubusercontent.com/u/23550189?v=4","gravatar_id":"","url":"https://api.github.com/users/styleguidist","html_url":"https://github.com/styleguidist","followers_url":"https://api.github.com/users/styleguidist/followers","following_url":"https://api.github.com/users/styleguidist/following{/other_user}","gists_url":"https://api.github.com/users/styleguidist/gists{/gist_id}","starred_url":"https://api.github.com/users/styleguidist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styleguidist/subscriptions","organizations_url":"https://api.github.com/users/styleguidist/orgs","repos_url":"https://api.github.com/users/styleguidist/repos","events_url":"https://api.github.com/users/styleguidist/events{/privacy}","received_events_url":"https://api.github.com/users/styleguidist/received_events","type":"Organization","site_admin":false},"repo":{"id":42033086,"name":"react-styleguidist","full_name":"styleguidist/react-styleguidist","owner":{"login":"styleguidist","id":23550189,"avatar_url":"https://avatars1.githubusercontent.com/u/23550189?v=4","gravatar_id":"","url":"https://api.github.com/users/styleguidist","html_url":"https://github.com/styleguidist","followers_url":"https://api.github.com/users/styleguidist/followers","following_url":"https://api.github.com/users/styleguidist/following{/other_user}","gists_url":"https://api.github.com/users/styleguidist/gists{/gist_id}","starred_url":"https://api.github.com/users/styleguidist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styleguidist/subscriptions","organizations_url":"https://api.github.com/users/styleguidist/orgs","repos_url":"https://api.github.com/users/styleguidist/repos","events_url":"https://api.github.com/users/styleguidist/events{/privacy}","received_events_url":"https://api.github.com/users/styleguidist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/styleguidist/react-styleguidist","description":"Isolated React component development environment with a living style guide","fork":false,"url":"https://api.github.com/repos/styleguidist/react-styleguidist","forks_url":"https://api.github.com/repos/styleguidist/react-styleguidist/forks","keys_url":"https://api.github.com/repos/styleguidist/react-styleguidist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/styleguidist/react-styleguidist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/styleguidist/react-styleguidist/teams","hooks_url":"https://api.github.com/repos/styleguidist/react-styleguidist/hooks","issue_events_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/events{/number}","events_url":"https://api.github.com/repos/styleguidist/react-styleguidist/events","assignees_url":"https://api.github.com/repos/styleguidist/react-styleguidist/assignees{/user}","branches_url":"https://api.github.com/repos/styleguidist/react-styleguidist/branches{/branch}","tags_url":"https://api.github.com/repos/styleguidist/react-styleguidist/tags","blobs_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/refs{/sha}","trees_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/styleguidist/react-styleguidist/statuses/{sha}","languages_url":"https://api.github.com/repos/styleguidist/react-styleguidist/languages","stargazers_url":"https://api.github.com/repos/styleguidist/react-styleguidist/stargazers","contributors_url":"https://api.github.com/repos/styleguidist/react-styleguidist/contributors","subscribers_url":"https://api.github.com/repos/styleguidist/react-styleguidist/subscribers","subscription_url":"https://api.github.com/repos/styleguidist/react-styleguidist/subscription","commits_url":"https://api.github.com/repos/styleguidist/react-styleguidist/commits{/sha}","git_commits_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/commits{/sha}","comments_url":"https://api.github.com/repos/styleguidist/react-styleguidist/comments{/number}","issue_comment_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/comments{/number}","contents_url":"https://api.github.com/repos/styleguidist/react-styleguidist/contents/{+path}","compare_url":"https://api.github.com/repos/styleguidist/react-styleguidist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/styleguidist/react-styleguidist/merges","archive_url":"https://api.github.com/repos/styleguidist/react-styleguidist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/styleguidist/react-styleguidist/downloads","issues_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues{/number}","pulls_url":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls{/number}","milestones_url":"https://api.github.com/repos/styleguidist/react-styleguidist/milestones{/number}","notifications_url":"https://api.github.com/repos/styleguidist/react-styleguidist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/styleguidist/react-styleguidist/labels{/name}","releases_url":"https://api.github.com/repos/styleguidist/react-styleguidist/releases{/id}","deployments_url":"https://api.github.com/repos/styleguidist/react-styleguidist/deployments","created_at":"2015-09-07T05:30:30Z","updated_at":"2018-05-27T14:56:15Z","pushed_at":"2018-05-25T22:47:54Z","git_url":"git://github.com/styleguidist/react-styleguidist.git","ssh_url":"git@github.com:styleguidist/react-styleguidist.git","clone_url":"https://github.com/styleguidist/react-styleguidist.git","svn_url":"https://github.com/styleguidist/react-styleguidist","homepage":"https://react-styleguidist.js.org/","size":5218,"stargazers_count":4772,"watchers_count":4772,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":643,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":643,"open_issues":68,"watchers":4772,"default_branch":"master"}},"base":{"label":"styleguidist:master","ref":"master","sha":"f5b0057eee4c171d695d6d2d766f318c74b9c608","user":{"login":"styleguidist","id":23550189,"avatar_url":"https://avatars1.githubusercontent.com/u/23550189?v=4","gravatar_id":"","url":"https://api.github.com/users/styleguidist","html_url":"https://github.com/styleguidist","followers_url":"https://api.github.com/users/styleguidist/followers","following_url":"https://api.github.com/users/styleguidist/following{/other_user}","gists_url":"https://api.github.com/users/styleguidist/gists{/gist_id}","starred_url":"https://api.github.com/users/styleguidist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styleguidist/subscriptions","organizations_url":"https://api.github.com/users/styleguidist/orgs","repos_url":"https://api.github.com/users/styleguidist/repos","events_url":"https://api.github.com/users/styleguidist/events{/privacy}","received_events_url":"https://api.github.com/users/styleguidist/received_events","type":"Organization","site_admin":false},"repo":{"id":42033086,"name":"react-styleguidist","full_name":"styleguidist/react-styleguidist","owner":{"login":"styleguidist","id":23550189,"avatar_url":"https://avatars1.githubusercontent.com/u/23550189?v=4","gravatar_id":"","url":"https://api.github.com/users/styleguidist","html_url":"https://github.com/styleguidist","followers_url":"https://api.github.com/users/styleguidist/followers","following_url":"https://api.github.com/users/styleguidist/following{/other_user}","gists_url":"https://api.github.com/users/styleguidist/gists{/gist_id}","starred_url":"https://api.github.com/users/styleguidist/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/styleguidist/subscriptions","organizations_url":"https://api.github.com/users/styleguidist/orgs","repos_url":"https://api.github.com/users/styleguidist/repos","events_url":"https://api.github.com/users/styleguidist/events{/privacy}","received_events_url":"https://api.github.com/users/styleguidist/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/styleguidist/react-styleguidist","description":"Isolated React component development environment with a living style guide","fork":false,"url":"https://api.github.com/repos/styleguidist/react-styleguidist","forks_url":"https://api.github.com/repos/styleguidist/react-styleguidist/forks","keys_url":"https://api.github.com/repos/styleguidist/react-styleguidist/keys{/key_id}","collaborators_url":"https://api.github.com/repos/styleguidist/react-styleguidist/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/styleguidist/react-styleguidist/teams","hooks_url":"https://api.github.com/repos/styleguidist/react-styleguidist/hooks","issue_events_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/events{/number}","events_url":"https://api.github.com/repos/styleguidist/react-styleguidist/events","assignees_url":"https://api.github.com/repos/styleguidist/react-styleguidist/assignees{/user}","branches_url":"https://api.github.com/repos/styleguidist/react-styleguidist/branches{/branch}","tags_url":"https://api.github.com/repos/styleguidist/react-styleguidist/tags","blobs_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/refs{/sha}","trees_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/trees{/sha}","statuses_url":"https://api.github.com/repos/styleguidist/react-styleguidist/statuses/{sha}","languages_url":"https://api.github.com/repos/styleguidist/react-styleguidist/languages","stargazers_url":"https://api.github.com/repos/styleguidist/react-styleguidist/stargazers","contributors_url":"https://api.github.com/repos/styleguidist/react-styleguidist/contributors","subscribers_url":"https://api.github.com/repos/styleguidist/react-styleguidist/subscribers","subscription_url":"https://api.github.com/repos/styleguidist/react-styleguidist/subscription","commits_url":"https://api.github.com/repos/styleguidist/react-styleguidist/commits{/sha}","git_commits_url":"https://api.github.com/repos/styleguidist/react-styleguidist/git/commits{/sha}","comments_url":"https://api.github.com/repos/styleguidist/react-styleguidist/comments{/number}","issue_comment_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/comments{/number}","contents_url":"https://api.github.com/repos/styleguidist/react-styleguidist/contents/{+path}","compare_url":"https://api.github.com/repos/styleguidist/react-styleguidist/compare/{base}...{head}","merges_url":"https://api.github.com/repos/styleguidist/react-styleguidist/merges","archive_url":"https://api.github.com/repos/styleguidist/react-styleguidist/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/styleguidist/react-styleguidist/downloads","issues_url":"https://api.github.com/repos/styleguidist/react-styleguidist/issues{/number}","pulls_url":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls{/number}","milestones_url":"https://api.github.com/repos/styleguidist/react-styleguidist/milestones{/number}","notifications_url":"https://api.github.com/repos/styleguidist/react-styleguidist/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/styleguidist/react-styleguidist/labels{/name}","releases_url":"https://api.github.com/repos/styleguidist/react-styleguidist/releases{/id}","deployments_url":"https://api.github.com/repos/styleguidist/react-styleguidist/deployments","created_at":"2015-09-07T05:30:30Z","updated_at":"2018-05-27T14:56:15Z","pushed_at":"2018-05-25T22:47:54Z","git_url":"git://github.com/styleguidist/react-styleguidist.git","ssh_url":"git@github.com:styleguidist/react-styleguidist.git","clone_url":"https://github.com/styleguidist/react-styleguidist.git","svn_url":"https://github.com/styleguidist/react-styleguidist","homepage":"https://react-styleguidist.js.org/","size":5218,"stargazers_count":4772,"watchers_count":4772,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":643,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":643,"open_issues":68,"watchers":4772,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/993"},"html":{"href":"https://github.com/styleguidist/react-styleguidist/pull/993"},"issue":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/993"},"comments":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/issues/993/comments"},"review_comments":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/993/comments"},"review_comment":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/pulls/993/commits"},"statuses":{"href":"https://api.github.com/repos/styleguidist/react-styleguidist/statuses/a1f3903827a4bfda4d65700c8d258d2360e300d3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"okonet"}}