{"action":"created","issue":{"url":"https://api.github.com/repos/sagemath/binary-pkg/issues/16","repository_url":"https://api.github.com/repos/sagemath/binary-pkg","labels_url":"https://api.github.com/repos/sagemath/binary-pkg/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/sagemath/binary-pkg/issues/16/comments","events_url":"https://api.github.com/repos/sagemath/binary-pkg/issues/16/events","html_url":"https://github.com/sagemath/binary-pkg/issues/16","id":341240838,"node_id":"MDU6SXNzdWUzNDEyNDA4Mzg=","number":16,"title":"relocate-once.py is not compatible with Python 3","user":{"login":"jhpalmieri","id":1843877,"node_id":"MDQ6VXNlcjE4NDM4Nzc=","avatar_url":"https://avatars3.githubusercontent.com/u/1843877?v=4","gravatar_id":"","url":"https://api.github.com/users/jhpalmieri","html_url":"https://github.com/jhpalmieri","followers_url":"https://api.github.com/users/jhpalmieri/followers","following_url":"https://api.github.com/users/jhpalmieri/following{/other_user}","gists_url":"https://api.github.com/users/jhpalmieri/gists{/gist_id}","starred_url":"https://api.github.com/users/jhpalmieri/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jhpalmieri/subscriptions","organizations_url":"https://api.github.com/users/jhpalmieri/orgs","repos_url":"https://api.github.com/users/jhpalmieri/repos","events_url":"https://api.github.com/users/jhpalmieri/events{/privacy}","received_events_url":"https://api.github.com/users/jhpalmieri/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-07-14T14:37:07Z","updated_at":"2018-12-11T14:54:12Z","closed_at":"2018-12-11T14:31:09Z","author_association":"NONE","body":"On systems where `/usr/bin/env python` runs Python 3, `relocate-once.py` breaks. The immediate fix is error checking when running `relocate-once.py` (see https://trac.sagemath.org/ticket/25668), but longer term, the script should be made compatible with Python 3.\r\n\r\nThere are two types of incompatibility:\r\n\r\n1. the line starting `p('local/lib/libflint-13.5.2.dylib').patch(1552, 1684)...` is very long, and more to the point (I think) has over 1500 method/attribute calls. In any case, that line yields\r\n\r\n`RecursionError: maximum recursion depth exceeded during compilation`\r\n\r\n2. After removing that line, we get:\r\n```\r\nTraceback (most recent call last):\r\n  File \"/Users/jpalmier/Downloads/SageMath/relocate-once.py\", line 145, in <module>\r\n    p('build/make/Makefile-auto').substitute().save()\r\n  File \"/Users/jpalmier/Downloads/SageMath/relocate-once.py\", line 133, in __call__\r\n    filename = os.path.join(self.root_path, filename)\r\n  File \"/anaconda3/lib/python3.6/posixpath.py\", line 94, in join\r\n    genericpath._check_arg_types('join', a, *p)\r\n  File \"/anaconda3/lib/python3.6/genericpath.py\", line 151, in _check_arg_types\r\n    raise TypeError(\"Can't mix strings and bytes in path components\") from None\r\nTypeError: Can't mix strings and bytes in path components\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/sagemath/binary-pkg/issues/comments/446230443","html_url":"https://github.com/sagemath/binary-pkg/issues/16#issuecomment-446230443","issue_url":"https://api.github.com/repos/sagemath/binary-pkg/issues/16","id":446230443,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NjIzMDQ0Mw==","user":{"login":"embray","id":676149,"node_id":"MDQ6VXNlcjY3NjE0OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/676149?v=4","gravatar_id":"","url":"https://api.github.com/users/embray","html_url":"https://github.com/embray","followers_url":"https://api.github.com/users/embray/followers","following_url":"https://api.github.com/users/embray/following{/other_user}","gists_url":"https://api.github.com/users/embray/gists{/gist_id}","starred_url":"https://api.github.com/users/embray/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/embray/subscriptions","organizations_url":"https://api.github.com/users/embray/orgs","repos_url":"https://api.github.com/users/embray/repos","events_url":"https://api.github.com/users/embray/events{/privacy}","received_events_url":"https://api.github.com/users/embray/received_events","type":"User","site_admin":false},"created_at":"2018-12-11T14:54:12Z","updated_at":"2018-12-11T14:54:12Z","author_association":"NONE","body":"My point was that this script could just live permanently in the Sage sources somewhere and consume a data file containing patches; then just the data file could be removed if needed.  Outputting a gigantic generated script doesn't make a whole lot of sense IMO."}}
{"actor":{"display_login":"embray"}}