{"action":"closed","number":65,"pull_request":{"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/65","id":220689987,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjg5OTg3","html_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/65","diff_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/65.diff","patch_url":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/65.patch","issue_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/65","number":65,"state":"closed","locked":false,"title":"C51-250: Disable autofill for crmUiSelect","user":{"login":"deb1990","id":5058867,"node_id":"MDQ6VXNlcjUwNTg4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/5058867?v=4","gravatar_id":"","url":"https://api.github.com/users/deb1990","html_url":"https://github.com/deb1990","followers_url":"https://api.github.com/users/deb1990/followers","following_url":"https://api.github.com/users/deb1990/following{/other_user}","gists_url":"https://api.github.com/users/deb1990/gists{/gist_id}","starred_url":"https://api.github.com/users/deb1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deb1990/subscriptions","organizations_url":"https://api.github.com/users/deb1990/orgs","repos_url":"https://api.github.com/users/deb1990/repos","events_url":"https://api.github.com/users/deb1990/events{/privacy}","received_events_url":"https://api.github.com/users/deb1990/received_events","type":"User","site_admin":false},"body":"## Overview\r\nAs part of this PR the autofill has been disabled for all `crmUiSelect`.\r\n\r\n## Before\r\n![2018-10-05 at 6 17 pm](https://user-images.githubusercontent.com/5058867/46536072-f1c57a00-c8ca-11e8-87b0-0adc28b6ca1e.png)\r\n\r\n## After\r\n![2018-10-05 at 6 16 pm](https://user-images.githubusercontent.com/5058867/46536037-dd817d00-c8ca-11e8-84c6-f30c6b499534.png)\r\n\r\n## Technical Details\r\n1. Added a decorator to disable the autofill for the `crmUiSelect` directive.\r\n2. Removed similar code from `Search.js`","created_at":"2018-10-05T12:47:48Z","updated_at":"2018-10-05T12:56:44Z","closed_at":"2018-10-05T12:56:44Z","merged_at":"2018-10-05T12:56:44Z","merge_commit_sha":"f735a51b4b37fb13e978bfaefe95e01858adcf16","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/65/commits","review_comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/65/comments","review_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/65/comments","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/statuses/c2752b16a678532b8295c95963086e9573ac27ec","head":{"label":"compucorp:C51-250-disable-autofill","ref":"C51-250-disable-autofill","sha":"c2752b16a678532b8295c95963086e9573ac27ec","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":143011708,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMTE3MDg=","name":"uk.co.compucorp.civicase","full_name":"compucorp/uk.co.compucorp.civicase","private":false,"owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/compucorp/uk.co.compucorp.civicase","description":"CiviCase Extension","fork":true,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/deployments","created_at":"2018-07-31T12:33:33Z","updated_at":"2018-08-15T11:40:22Z","pushed_at":"2018-10-05T12:56:44Z","git_url":"git://github.com/compucorp/uk.co.compucorp.civicase.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.civicase.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.civicase.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.civicase","homepage":null,"size":2108,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"base":{"label":"compucorp:develop","ref":"develop","sha":"abb7549345353d85890aa8d3aed4b60e7f065e10","user":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"repo":{"id":143011708,"node_id":"MDEwOlJlcG9zaXRvcnkxNDMwMTE3MDg=","name":"uk.co.compucorp.civicase","full_name":"compucorp/uk.co.compucorp.civicase","private":false,"owner":{"login":"compucorp","id":2040164,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwNDAxNjQ=","avatar_url":"https://avatars3.githubusercontent.com/u/2040164?v=4","gravatar_id":"","url":"https://api.github.com/users/compucorp","html_url":"https://github.com/compucorp","followers_url":"https://api.github.com/users/compucorp/followers","following_url":"https://api.github.com/users/compucorp/following{/other_user}","gists_url":"https://api.github.com/users/compucorp/gists{/gist_id}","starred_url":"https://api.github.com/users/compucorp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/compucorp/subscriptions","organizations_url":"https://api.github.com/users/compucorp/orgs","repos_url":"https://api.github.com/users/compucorp/repos","events_url":"https://api.github.com/users/compucorp/events{/privacy}","received_events_url":"https://api.github.com/users/compucorp/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/compucorp/uk.co.compucorp.civicase","description":"CiviCase Extension","fork":true,"url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase","forks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/forks","keys_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/teams","hooks_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/hooks","issue_events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/events{/number}","events_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/events","assignees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/assignees{/user}","branches_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/branches{/branch}","tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/tags","blobs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/refs{/sha}","trees_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/statuses/{sha}","languages_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/languages","stargazers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/stargazers","contributors_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/contributors","subscribers_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/subscribers","subscription_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/subscription","commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/commits{/sha}","git_commits_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/git/commits{/sha}","comments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/comments{/number}","issue_comment_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/comments{/number}","contents_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/contents/{+path}","compare_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/merges","archive_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/downloads","issues_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues{/number}","pulls_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls{/number}","milestones_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/milestones{/number}","notifications_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/labels{/name}","releases_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/releases{/id}","deployments_url":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/deployments","created_at":"2018-07-31T12:33:33Z","updated_at":"2018-08-15T11:40:22Z","pushed_at":"2018-10-05T12:56:44Z","git_url":"git://github.com/compucorp/uk.co.compucorp.civicase.git","ssh_url":"git@github.com:compucorp/uk.co.compucorp.civicase.git","clone_url":"https://github.com/compucorp/uk.co.compucorp.civicase.git","svn_url":"https://github.com/compucorp/uk.co.compucorp.civicase","homepage":null,"size":2108,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/65"},"html":{"href":"https://github.com/compucorp/uk.co.compucorp.civicase/pull/65"},"issue":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/65"},"comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/compucorp/uk.co.compucorp.civicase/statuses/c2752b16a678532b8295c95963086e9573ac27ec"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"deb1990","id":5058867,"node_id":"MDQ6VXNlcjUwNTg4Njc=","avatar_url":"https://avatars1.githubusercontent.com/u/5058867?v=4","gravatar_id":"","url":"https://api.github.com/users/deb1990","html_url":"https://github.com/deb1990","followers_url":"https://api.github.com/users/deb1990/followers","following_url":"https://api.github.com/users/deb1990/following{/other_user}","gists_url":"https://api.github.com/users/deb1990/gists{/gist_id}","starred_url":"https://api.github.com/users/deb1990/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deb1990/subscriptions","organizations_url":"https://api.github.com/users/deb1990/orgs","repos_url":"https://api.github.com/users/deb1990/repos","events_url":"https://api.github.com/users/deb1990/events{/privacy}","received_events_url":"https://api.github.com/users/deb1990/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":26,"deletions":21,"changed_files":2}}
{"actor":{"display_login":"deb1990"}}