{"action":"created","comment":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/comments/176581363","pull_request_review_id":106310264,"id":176581363,"diff_hunk":"@@ -56,6 +56,15 @@ ClasspathEntryItem::initialize(const char* path_, U_16 pathLen_, UDATA protocol_\n \n \tpath = (char*)path_;\n \tpathLen = pathLen_;\n+\tlocationPathLen = pathLen_;\n+\tif (protocol == PROTO_JAR) {\n+\t\tif (NULL != path) {\n+\t\t\tchar* jarPath = strstr(path,\".jar!/\");","path":"runtime/shared_common/ClasspathItem.cpp","position":14,"original_position":14,"commit_id":"cfbac79510d6a14069557fcdb1bcb3bdace1a986","original_commit_id":"cfbac79510d6a14069557fcdb1bcb3bdace1a986","user":{"login":"pshipton","id":18122812,"avatar_url":"https://avatars1.githubusercontent.com/u/18122812?v=4","gravatar_id":"","url":"https://api.github.com/users/pshipton","html_url":"https://github.com/pshipton","followers_url":"https://api.github.com/users/pshipton/followers","following_url":"https://api.github.com/users/pshipton/following{/other_user}","gists_url":"https://api.github.com/users/pshipton/gists{/gist_id}","starred_url":"https://api.github.com/users/pshipton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pshipton/subscriptions","organizations_url":"https://api.github.com/users/pshipton/orgs","repos_url":"https://api.github.com/users/pshipton/repos","events_url":"https://api.github.com/users/pshipton/events{/privacy}","received_events_url":"https://api.github.com/users/pshipton/received_events","type":"User","site_admin":false},"body":"Should also support .zip","created_at":"2018-03-22T21:43:52Z","updated_at":"2018-03-22T21:48:53Z","html_url":"https://github.com/eclipse/openj9/pull/1500#discussion_r176581363","pull_request_url":"https://api.github.com/repos/eclipse/openj9/pulls/1500","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments/176581363"},"html":{"href":"https://github.com/eclipse/openj9/pull/1500#discussion_r176581363"},"pull_request":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1500"}}},"pull_request":{"url":"https://api.github.com/repos/eclipse/openj9/pulls/1500","id":176583247,"html_url":"https://github.com/eclipse/openj9/pull/1500","diff_url":"https://github.com/eclipse/openj9/pull/1500.diff","patch_url":"https://github.com/eclipse/openj9/pull/1500.patch","issue_url":"https://api.github.com/repos/eclipse/openj9/issues/1500","number":1500,"state":"open","locked":false,"title":"Add shared classes support for nested jar","user":{"login":"hangshao0","id":18008382,"avatar_url":"https://avatars3.githubusercontent.com/u/18008382?v=4","gravatar_id":"","url":"https://api.github.com/users/hangshao0","html_url":"https://github.com/hangshao0","followers_url":"https://api.github.com/users/hangshao0/followers","following_url":"https://api.github.com/users/hangshao0/following{/other_user}","gists_url":"https://api.github.com/users/hangshao0/gists{/gist_id}","starred_url":"https://api.github.com/users/hangshao0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hangshao0/subscriptions","organizations_url":"https://api.github.com/users/hangshao0/orgs","repos_url":"https://api.github.com/users/hangshao0/repos","events_url":"https://api.github.com/users/hangshao0/events{/privacy}","received_events_url":"https://api.github.com/users/hangshao0/received_events","type":"User","site_admin":false},"body":"1. When constructing URL using recursiveJarTrim() for a nested jar, do\r\nnot trim the entry within the external jar so that it is kept in the\r\nURL. For example, /path/A.jar!/lib/B.jar won't be trimmed to /path/A.jar\r\nanymore.\r\n2. Add a new API ClasspathEntryItem::getLocation() to return the path\r\nfor the external jar file. For example, in the case of\r\n/path/A.jar!/lib/B.jar, getLocation() returns /path/A.jar, which will be\r\nused in time stamping and stale marking operations. The full path\r\n/path/A.jar!/lib/B.jar, returned by ClasspathEntryItem::getPath() will\r\nbe used in ClasspathEntryItem comparison, and trace/verbose/statistic\r\nmessages.\r\n\r\nSigned-off-by: hangshao <hangshao@ca.ibm.com>","created_at":"2018-03-21T19:17:58Z","updated_at":"2018-03-22T21:48:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c9e5dee9afe3ca2bae6270b24f0dd41f1b18cec5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/eclipse/openj9/pulls/1500/commits","review_comments_url":"https://api.github.com/repos/eclipse/openj9/pulls/1500/comments","review_comment_url":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}","comments_url":"https://api.github.com/repos/eclipse/openj9/issues/1500/comments","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/cfbac79510d6a14069557fcdb1bcb3bdace1a986","head":{"label":"hangshao0:work","ref":"work","sha":"cfbac79510d6a14069557fcdb1bcb3bdace1a986","user":{"login":"hangshao0","id":18008382,"avatar_url":"https://avatars3.githubusercontent.com/u/18008382?v=4","gravatar_id":"","url":"https://api.github.com/users/hangshao0","html_url":"https://github.com/hangshao0","followers_url":"https://api.github.com/users/hangshao0/followers","following_url":"https://api.github.com/users/hangshao0/following{/other_user}","gists_url":"https://api.github.com/users/hangshao0/gists{/gist_id}","starred_url":"https://api.github.com/users/hangshao0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hangshao0/subscriptions","organizations_url":"https://api.github.com/users/hangshao0/orgs","repos_url":"https://api.github.com/users/hangshao0/repos","events_url":"https://api.github.com/users/hangshao0/events{/privacy}","received_events_url":"https://api.github.com/users/hangshao0/received_events","type":"User","site_admin":false},"repo":{"id":103542655,"name":"openj9","full_name":"hangshao0/openj9","owner":{"login":"hangshao0","id":18008382,"avatar_url":"https://avatars3.githubusercontent.com/u/18008382?v=4","gravatar_id":"","url":"https://api.github.com/users/hangshao0","html_url":"https://github.com/hangshao0","followers_url":"https://api.github.com/users/hangshao0/followers","following_url":"https://api.github.com/users/hangshao0/following{/other_user}","gists_url":"https://api.github.com/users/hangshao0/gists{/gist_id}","starred_url":"https://api.github.com/users/hangshao0/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hangshao0/subscriptions","organizations_url":"https://api.github.com/users/hangshao0/orgs","repos_url":"https://api.github.com/users/hangshao0/repos","events_url":"https://api.github.com/users/hangshao0/events{/privacy}","received_events_url":"https://api.github.com/users/hangshao0/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hangshao0/openj9","description":"OpenJ9","fork":true,"url":"https://api.github.com/repos/hangshao0/openj9","forks_url":"https://api.github.com/repos/hangshao0/openj9/forks","keys_url":"https://api.github.com/repos/hangshao0/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hangshao0/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hangshao0/openj9/teams","hooks_url":"https://api.github.com/repos/hangshao0/openj9/hooks","issue_events_url":"https://api.github.com/repos/hangshao0/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/hangshao0/openj9/events","assignees_url":"https://api.github.com/repos/hangshao0/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/hangshao0/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/hangshao0/openj9/tags","blobs_url":"https://api.github.com/repos/hangshao0/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hangshao0/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hangshao0/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/hangshao0/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hangshao0/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/hangshao0/openj9/languages","stargazers_url":"https://api.github.com/repos/hangshao0/openj9/stargazers","contributors_url":"https://api.github.com/repos/hangshao0/openj9/contributors","subscribers_url":"https://api.github.com/repos/hangshao0/openj9/subscribers","subscription_url":"https://api.github.com/repos/hangshao0/openj9/subscription","commits_url":"https://api.github.com/repos/hangshao0/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/hangshao0/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/hangshao0/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/hangshao0/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/hangshao0/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/hangshao0/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hangshao0/openj9/merges","archive_url":"https://api.github.com/repos/hangshao0/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hangshao0/openj9/downloads","issues_url":"https://api.github.com/repos/hangshao0/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/hangshao0/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/hangshao0/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/hangshao0/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hangshao0/openj9/labels{/name}","releases_url":"https://api.github.com/repos/hangshao0/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/hangshao0/openj9/deployments","created_at":"2017-09-14T14:29:08Z","updated_at":"2018-03-15T18:17:34Z","pushed_at":"2018-03-20T20:39:18Z","git_url":"git://github.com/hangshao0/openj9.git","ssh_url":"git@github.com:hangshao0/openj9.git","clone_url":"https://github.com/hangshao0/openj9.git","svn_url":"https://github.com/hangshao0/openj9","homepage":null,"size":27204,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"eclipse:master","ref":"master","sha":"85ceb64894d65d4da2c9f0fd22c0d029104cddbe","user":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"repo":{"id":101408117,"name":"openj9","full_name":"eclipse/openj9","owner":{"login":"eclipse","id":56974,"avatar_url":"https://avatars1.githubusercontent.com/u/56974?v=4","gravatar_id":"","url":"https://api.github.com/users/eclipse","html_url":"https://github.com/eclipse","followers_url":"https://api.github.com/users/eclipse/followers","following_url":"https://api.github.com/users/eclipse/following{/other_user}","gists_url":"https://api.github.com/users/eclipse/gists{/gist_id}","starred_url":"https://api.github.com/users/eclipse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eclipse/subscriptions","organizations_url":"https://api.github.com/users/eclipse/orgs","repos_url":"https://api.github.com/users/eclipse/repos","events_url":"https://api.github.com/users/eclipse/events{/privacy}","received_events_url":"https://api.github.com/users/eclipse/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/eclipse/openj9","description":"Eclipse OpenJ9: A Java Virtual Machine for OpenJDK that's optimized for small footprint, fast start-up, and high throughput.   Builds on Eclipse OMR (https://github.com/eclipse/omr) and combines with the Extensions for OpenJDK for OpenJ9 repo.","fork":false,"url":"https://api.github.com/repos/eclipse/openj9","forks_url":"https://api.github.com/repos/eclipse/openj9/forks","keys_url":"https://api.github.com/repos/eclipse/openj9/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eclipse/openj9/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eclipse/openj9/teams","hooks_url":"https://api.github.com/repos/eclipse/openj9/hooks","issue_events_url":"https://api.github.com/repos/eclipse/openj9/issues/events{/number}","events_url":"https://api.github.com/repos/eclipse/openj9/events","assignees_url":"https://api.github.com/repos/eclipse/openj9/assignees{/user}","branches_url":"https://api.github.com/repos/eclipse/openj9/branches{/branch}","tags_url":"https://api.github.com/repos/eclipse/openj9/tags","blobs_url":"https://api.github.com/repos/eclipse/openj9/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eclipse/openj9/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eclipse/openj9/git/refs{/sha}","trees_url":"https://api.github.com/repos/eclipse/openj9/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eclipse/openj9/statuses/{sha}","languages_url":"https://api.github.com/repos/eclipse/openj9/languages","stargazers_url":"https://api.github.com/repos/eclipse/openj9/stargazers","contributors_url":"https://api.github.com/repos/eclipse/openj9/contributors","subscribers_url":"https://api.github.com/repos/eclipse/openj9/subscribers","subscription_url":"https://api.github.com/repos/eclipse/openj9/subscription","commits_url":"https://api.github.com/repos/eclipse/openj9/commits{/sha}","git_commits_url":"https://api.github.com/repos/eclipse/openj9/git/commits{/sha}","comments_url":"https://api.github.com/repos/eclipse/openj9/comments{/number}","issue_comment_url":"https://api.github.com/repos/eclipse/openj9/issues/comments{/number}","contents_url":"https://api.github.com/repos/eclipse/openj9/contents/{+path}","compare_url":"https://api.github.com/repos/eclipse/openj9/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eclipse/openj9/merges","archive_url":"https://api.github.com/repos/eclipse/openj9/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eclipse/openj9/downloads","issues_url":"https://api.github.com/repos/eclipse/openj9/issues{/number}","pulls_url":"https://api.github.com/repos/eclipse/openj9/pulls{/number}","milestones_url":"https://api.github.com/repos/eclipse/openj9/milestones{/number}","notifications_url":"https://api.github.com/repos/eclipse/openj9/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eclipse/openj9/labels{/name}","releases_url":"https://api.github.com/repos/eclipse/openj9/releases{/id}","deployments_url":"https://api.github.com/repos/eclipse/openj9/deployments","created_at":"2017-08-25T13:46:07Z","updated_at":"2018-03-22T20:39:39Z","pushed_at":"2018-03-22T20:09:39Z","git_url":"git://github.com/eclipse/openj9.git","ssh_url":"git@github.com:eclipse/openj9.git","clone_url":"https://github.com/eclipse/openj9.git","svn_url":"https://github.com/eclipse/openj9","homepage":"","size":27266,"stargazers_count":1209,"watchers_count":1209,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":235,"mirror_url":null,"archived":false,"open_issues_count":289,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":235,"open_issues":289,"watchers":1209,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1500"},"html":{"href":"https://github.com/eclipse/openj9/pull/1500"},"issue":{"href":"https://api.github.com/repos/eclipse/openj9/issues/1500"},"comments":{"href":"https://api.github.com/repos/eclipse/openj9/issues/1500/comments"},"review_comments":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1500/comments"},"review_comment":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/eclipse/openj9/pulls/1500/commits"},"statuses":{"href":"https://api.github.com/repos/eclipse/openj9/statuses/cfbac79510d6a14069557fcdb1bcb3bdace1a986"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pshipton"}}