{"action":"created","comment":{"url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/comments/176957998","pull_request_review_id":106747478,"id":176957998,"diff_hunk":"@@ -75,6 +75,15 @@ The default timeout for your Headless JS task is 5 minutes (300000ms). If you wa\n <string name=\"rnsb_default_timeout\" translatable=\"false\">600000</string>\n ```\n \n+### User visible\n+\n+By default the user will not be able to manually request a sync from the settings. If you want the user to have the option to request a sync from the settings, you have to override `strings.xml` again:\n+\n+```xml\n+<!-- Allows user to manually request a sync from settings -->","path":"README.md","position":9,"original_position":9,"commit_id":"bcd3ee75749d3aff4f80721acacd60ffabff96dd","original_commit_id":"bcd3ee75749d3aff4f80721acacd60ffabff96dd","user":{"login":"ferrannp","id":774577,"avatar_url":"https://avatars2.githubusercontent.com/u/774577?v=4","gravatar_id":"","url":"https://api.github.com/users/ferrannp","html_url":"https://github.com/ferrannp","followers_url":"https://api.github.com/users/ferrannp/followers","following_url":"https://api.github.com/users/ferrannp/following{/other_user}","gists_url":"https://api.github.com/users/ferrannp/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrannp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrannp/subscriptions","organizations_url":"https://api.github.com/users/ferrannp/orgs","repos_url":"https://api.github.com/users/ferrannp/repos","events_url":"https://api.github.com/users/ferrannp/events{/privacy}","received_events_url":"https://api.github.com/users/ferrannp/received_events","type":"User","site_admin":false},"body":"We would change this comment to:\r\n\r\n> Allows the user to enable/disable the sync functionality through the Account settings.","created_at":"2018-03-25T23:08:25Z","updated_at":"2018-03-25T23:08:37Z","html_url":"https://github.com/ferrannp/react-native-sync-adapter/pull/13#discussion_r176957998","pull_request_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/13","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/comments/176957998"},"html":{"href":"https://github.com/ferrannp/react-native-sync-adapter/pull/13#discussion_r176957998"},"pull_request":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/13"}}},"pull_request":{"url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/13","id":176344393,"html_url":"https://github.com/ferrannp/react-native-sync-adapter/pull/13","diff_url":"https://github.com/ferrannp/react-native-sync-adapter/pull/13.diff","patch_url":"https://github.com/ferrannp/react-native-sync-adapter/pull/13.patch","issue_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/issues/13","number":13,"state":"open","locked":false,"title":"Allow user to choose userVisible value","user":{"login":"nvlbg","id":1997273,"avatar_url":"https://avatars2.githubusercontent.com/u/1997273?v=4","gravatar_id":"","url":"https://api.github.com/users/nvlbg","html_url":"https://github.com/nvlbg","followers_url":"https://api.github.com/users/nvlbg/followers","following_url":"https://api.github.com/users/nvlbg/following{/other_user}","gists_url":"https://api.github.com/users/nvlbg/gists{/gist_id}","starred_url":"https://api.github.com/users/nvlbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvlbg/subscriptions","organizations_url":"https://api.github.com/users/nvlbg/orgs","repos_url":"https://api.github.com/users/nvlbg/repos","events_url":"https://api.github.com/users/nvlbg/events{/privacy}","received_events_url":"https://api.github.com/users/nvlbg/received_events","type":"User","site_admin":false},"body":"This should allow for an app to choose if the user can request a sync from settings.","created_at":"2018-03-20T22:52:27Z","updated_at":"2018-03-25T23:08:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eafddd3d0d72815edb7bce9244a5e9f46868402a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/13/commits","review_comments_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/13/comments","review_comment_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/issues/13/comments","statuses_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/statuses/bcd3ee75749d3aff4f80721acacd60ffabff96dd","head":{"label":"nvlbg:user_visible","ref":"user_visible","sha":"bcd3ee75749d3aff4f80721acacd60ffabff96dd","user":{"login":"nvlbg","id":1997273,"avatar_url":"https://avatars2.githubusercontent.com/u/1997273?v=4","gravatar_id":"","url":"https://api.github.com/users/nvlbg","html_url":"https://github.com/nvlbg","followers_url":"https://api.github.com/users/nvlbg/followers","following_url":"https://api.github.com/users/nvlbg/following{/other_user}","gists_url":"https://api.github.com/users/nvlbg/gists{/gist_id}","starred_url":"https://api.github.com/users/nvlbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvlbg/subscriptions","organizations_url":"https://api.github.com/users/nvlbg/orgs","repos_url":"https://api.github.com/users/nvlbg/repos","events_url":"https://api.github.com/users/nvlbg/events{/privacy}","received_events_url":"https://api.github.com/users/nvlbg/received_events","type":"User","site_admin":false},"repo":{"id":126091856,"name":"react-native-sync-adapter","full_name":"nvlbg/react-native-sync-adapter","owner":{"login":"nvlbg","id":1997273,"avatar_url":"https://avatars2.githubusercontent.com/u/1997273?v=4","gravatar_id":"","url":"https://api.github.com/users/nvlbg","html_url":"https://github.com/nvlbg","followers_url":"https://api.github.com/users/nvlbg/followers","following_url":"https://api.github.com/users/nvlbg/following{/other_user}","gists_url":"https://api.github.com/users/nvlbg/gists{/gist_id}","starred_url":"https://api.github.com/users/nvlbg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nvlbg/subscriptions","organizations_url":"https://api.github.com/users/nvlbg/orgs","repos_url":"https://api.github.com/users/nvlbg/repos","events_url":"https://api.github.com/users/nvlbg/events{/privacy}","received_events_url":"https://api.github.com/users/nvlbg/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/nvlbg/react-native-sync-adapter","description":"Schedule background data synchronization using React Native.","fork":true,"url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter","forks_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/forks","keys_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/teams","hooks_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/hooks","issue_events_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/events","assignees_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/tags","blobs_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/languages","stargazers_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/stargazers","contributors_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/contributors","subscribers_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/subscribers","subscription_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/subscription","commits_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/merges","archive_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/downloads","issues_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/labels{/name}","releases_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/nvlbg/react-native-sync-adapter/deployments","created_at":"2018-03-20T22:41:57Z","updated_at":"2018-03-20T22:41:59Z","pushed_at":"2018-03-22T20:34:04Z","git_url":"git://github.com/nvlbg/react-native-sync-adapter.git","ssh_url":"git@github.com:nvlbg/react-native-sync-adapter.git","clone_url":"https://github.com/nvlbg/react-native-sync-adapter.git","svn_url":"https://github.com/nvlbg/react-native-sync-adapter","homepage":"","size":263,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ferrannp:master","ref":"master","sha":"ba3926906f892e994a8c1142c7f46f877ca876d9","user":{"login":"ferrannp","id":774577,"avatar_url":"https://avatars2.githubusercontent.com/u/774577?v=4","gravatar_id":"","url":"https://api.github.com/users/ferrannp","html_url":"https://github.com/ferrannp","followers_url":"https://api.github.com/users/ferrannp/followers","following_url":"https://api.github.com/users/ferrannp/following{/other_user}","gists_url":"https://api.github.com/users/ferrannp/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrannp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrannp/subscriptions","organizations_url":"https://api.github.com/users/ferrannp/orgs","repos_url":"https://api.github.com/users/ferrannp/repos","events_url":"https://api.github.com/users/ferrannp/events{/privacy}","received_events_url":"https://api.github.com/users/ferrannp/received_events","type":"User","site_admin":false},"repo":{"id":79607636,"name":"react-native-sync-adapter","full_name":"ferrannp/react-native-sync-adapter","owner":{"login":"ferrannp","id":774577,"avatar_url":"https://avatars2.githubusercontent.com/u/774577?v=4","gravatar_id":"","url":"https://api.github.com/users/ferrannp","html_url":"https://github.com/ferrannp","followers_url":"https://api.github.com/users/ferrannp/followers","following_url":"https://api.github.com/users/ferrannp/following{/other_user}","gists_url":"https://api.github.com/users/ferrannp/gists{/gist_id}","starred_url":"https://api.github.com/users/ferrannp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferrannp/subscriptions","organizations_url":"https://api.github.com/users/ferrannp/orgs","repos_url":"https://api.github.com/users/ferrannp/repos","events_url":"https://api.github.com/users/ferrannp/events{/privacy}","received_events_url":"https://api.github.com/users/ferrannp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferrannp/react-native-sync-adapter","description":"Schedule background data synchronization using React Native.","fork":false,"url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter","forks_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/forks","keys_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/teams","hooks_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/hooks","issue_events_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/issues/events{/number}","events_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/events","assignees_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/assignees{/user}","branches_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/branches{/branch}","tags_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/tags","blobs_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/statuses/{sha}","languages_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/languages","stargazers_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/stargazers","contributors_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/contributors","subscribers_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/subscribers","subscription_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/subscription","commits_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/contents/{+path}","compare_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/merges","archive_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/downloads","issues_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/issues{/number}","pulls_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls{/number}","milestones_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/milestones{/number}","notifications_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/labels{/name}","releases_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/releases{/id}","deployments_url":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/deployments","created_at":"2017-01-20T22:54:36Z","updated_at":"2018-03-23T15:51:35Z","pushed_at":"2018-03-21T11:21:01Z","git_url":"git://github.com/ferrannp/react-native-sync-adapter.git","ssh_url":"git@github.com:ferrannp/react-native-sync-adapter.git","clone_url":"https://github.com/ferrannp/react-native-sync-adapter.git","svn_url":"https://github.com/ferrannp/react-native-sync-adapter","homepage":"","size":258,"stargazers_count":54,"watchers_count":54,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":2,"watchers":54,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/13"},"html":{"href":"https://github.com/ferrannp/react-native-sync-adapter/pull/13"},"issue":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/issues/13"},"comments":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/issues/13/comments"},"review_comments":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/13/comments"},"review_comment":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/pulls/13/commits"},"statuses":{"href":"https://api.github.com/repos/ferrannp/react-native-sync-adapter/statuses/bcd3ee75749d3aff4f80721acacd60ffabff96dd"}},"author_association":"NONE"}}
{"actor":{"display_login":"ferrannp"}}