{"action":"closed","number":63,"pull_request":{"url":"https://api.github.com/repos/sebastianbergmann/comparator/pulls/63","id":223695715,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNjk1NzE1","html_url":"https://github.com/sebastianbergmann/comparator/pull/63","diff_url":"https://github.com/sebastianbergmann/comparator/pull/63.diff","patch_url":"https://github.com/sebastianbergmann/comparator/pull/63.patch","issue_url":"https://api.github.com/repos/sebastianbergmann/comparator/issues/63","number":63,"state":"closed","locked":false,"title":"Avoid converting an object to an array when checking equality","user":{"login":"rtheunissen","id":809191,"node_id":"MDQ6VXNlcjgwOTE5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/809191?v=4","gravatar_id":"","url":"https://api.github.com/users/rtheunissen","html_url":"https://github.com/rtheunissen","followers_url":"https://api.github.com/users/rtheunissen/followers","following_url":"https://api.github.com/users/rtheunissen/following{/other_user}","gists_url":"https://api.github.com/users/rtheunissen/gists{/gist_id}","starred_url":"https://api.github.com/users/rtheunissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtheunissen/subscriptions","organizations_url":"https://api.github.com/users/rtheunissen/orgs","repos_url":"https://api.github.com/users/rtheunissen/repos","events_url":"https://api.github.com/users/rtheunissen/events{/privacy}","received_events_url":"https://api.github.com/users/rtheunissen/received_events","type":"User","site_admin":false},"body":"This has come up where `assertEquals` fails for internal objects that override comparison using the `compare` or `compare_objects` handlers. Internally, PHP compares object properties when using `==`, which is effectively what the array cast was doing.\r\n\r\nThis change allows for objects that override equality to work as expected with `assertEquals`. \r\n\r\nIt's also worth mentioning that a future Comparable interface would most likely override the behaviour of `==` and is therefore also some future-proofing here.","created_at":"2018-10-17T17:45:23Z","updated_at":"2018-10-17T21:46:13Z","closed_at":"2018-10-17T21:46:13Z","merged_at":null,"merge_commit_sha":"3c19b1e72adda99252157047aafdf556487a431f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sebastianbergmann/comparator/pulls/63/commits","review_comments_url":"https://api.github.com/repos/sebastianbergmann/comparator/pulls/63/comments","review_comment_url":"https://api.github.com/repos/sebastianbergmann/comparator/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sebastianbergmann/comparator/issues/63/comments","statuses_url":"https://api.github.com/repos/sebastianbergmann/comparator/statuses/daa763da23645f3d9abef3c6047302015583885f","head":{"label":"rtheunissen:rt-object-equals-no-array","ref":"rt-object-equals-no-array","sha":"daa763da23645f3d9abef3c6047302015583885f","user":{"login":"rtheunissen","id":809191,"node_id":"MDQ6VXNlcjgwOTE5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/809191?v=4","gravatar_id":"","url":"https://api.github.com/users/rtheunissen","html_url":"https://github.com/rtheunissen","followers_url":"https://api.github.com/users/rtheunissen/followers","following_url":"https://api.github.com/users/rtheunissen/following{/other_user}","gists_url":"https://api.github.com/users/rtheunissen/gists{/gist_id}","starred_url":"https://api.github.com/users/rtheunissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtheunissen/subscriptions","organizations_url":"https://api.github.com/users/rtheunissen/orgs","repos_url":"https://api.github.com/users/rtheunissen/repos","events_url":"https://api.github.com/users/rtheunissen/events{/privacy}","received_events_url":"https://api.github.com/users/rtheunissen/received_events","type":"User","site_admin":false},"repo":{"id":153497768,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM0OTc3Njg=","name":"comparator","full_name":"rtheunissen/comparator","private":false,"owner":{"login":"rtheunissen","id":809191,"node_id":"MDQ6VXNlcjgwOTE5MQ==","avatar_url":"https://avatars0.githubusercontent.com/u/809191?v=4","gravatar_id":"","url":"https://api.github.com/users/rtheunissen","html_url":"https://github.com/rtheunissen","followers_url":"https://api.github.com/users/rtheunissen/followers","following_url":"https://api.github.com/users/rtheunissen/following{/other_user}","gists_url":"https://api.github.com/users/rtheunissen/gists{/gist_id}","starred_url":"https://api.github.com/users/rtheunissen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rtheunissen/subscriptions","organizations_url":"https://api.github.com/users/rtheunissen/orgs","repos_url":"https://api.github.com/users/rtheunissen/repos","events_url":"https://api.github.com/users/rtheunissen/events{/privacy}","received_events_url":"https://api.github.com/users/rtheunissen/received_events","type":"User","site_admin":false},"html_url":"https://github.com/rtheunissen/comparator","description":"Provides the functionality to compare PHP values for equality.","fork":true,"url":"https://api.github.com/repos/rtheunissen/comparator","forks_url":"https://api.github.com/repos/rtheunissen/comparator/forks","keys_url":"https://api.github.com/repos/rtheunissen/comparator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rtheunissen/comparator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rtheunissen/comparator/teams","hooks_url":"https://api.github.com/repos/rtheunissen/comparator/hooks","issue_events_url":"https://api.github.com/repos/rtheunissen/comparator/issues/events{/number}","events_url":"https://api.github.com/repos/rtheunissen/comparator/events","assignees_url":"https://api.github.com/repos/rtheunissen/comparator/assignees{/user}","branches_url":"https://api.github.com/repos/rtheunissen/comparator/branches{/branch}","tags_url":"https://api.github.com/repos/rtheunissen/comparator/tags","blobs_url":"https://api.github.com/repos/rtheunissen/comparator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rtheunissen/comparator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rtheunissen/comparator/git/refs{/sha}","trees_url":"https://api.github.com/repos/rtheunissen/comparator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rtheunissen/comparator/statuses/{sha}","languages_url":"https://api.github.com/repos/rtheunissen/comparator/languages","stargazers_url":"https://api.github.com/repos/rtheunissen/comparator/stargazers","contributors_url":"https://api.github.com/repos/rtheunissen/comparator/contributors","subscribers_url":"https://api.github.com/repos/rtheunissen/comparator/subscribers","subscription_url":"https://api.github.com/repos/rtheunissen/comparator/subscription","commits_url":"https://api.github.com/repos/rtheunissen/comparator/commits{/sha}","git_commits_url":"https://api.github.com/repos/rtheunissen/comparator/git/commits{/sha}","comments_url":"https://api.github.com/repos/rtheunissen/comparator/comments{/number}","issue_comment_url":"https://api.github.com/repos/rtheunissen/comparator/issues/comments{/number}","contents_url":"https://api.github.com/repos/rtheunissen/comparator/contents/{+path}","compare_url":"https://api.github.com/repos/rtheunissen/comparator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rtheunissen/comparator/merges","archive_url":"https://api.github.com/repos/rtheunissen/comparator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rtheunissen/comparator/downloads","issues_url":"https://api.github.com/repos/rtheunissen/comparator/issues{/number}","pulls_url":"https://api.github.com/repos/rtheunissen/comparator/pulls{/number}","milestones_url":"https://api.github.com/repos/rtheunissen/comparator/milestones{/number}","notifications_url":"https://api.github.com/repos/rtheunissen/comparator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rtheunissen/comparator/labels{/name}","releases_url":"https://api.github.com/repos/rtheunissen/comparator/releases{/id}","deployments_url":"https://api.github.com/repos/rtheunissen/comparator/deployments","created_at":"2018-10-17T17:34:53Z","updated_at":"2018-10-17T17:40:23Z","pushed_at":"2018-10-17T18:31:44Z","git_url":"git://github.com/rtheunissen/comparator.git","ssh_url":"git@github.com:rtheunissen/comparator.git","clone_url":"https://github.com/rtheunissen/comparator.git","svn_url":"https://github.com/rtheunissen/comparator","homepage":null,"size":217,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sebastianbergmann:master","ref":"master","sha":"2256ef8e824cc494ddeebaa00fabe7ab4d83fc75","user":{"login":"sebastianbergmann","id":25218,"node_id":"MDQ6VXNlcjI1MjE4","avatar_url":"https://avatars1.githubusercontent.com/u/25218?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastianbergmann","html_url":"https://github.com/sebastianbergmann","followers_url":"https://api.github.com/users/sebastianbergmann/followers","following_url":"https://api.github.com/users/sebastianbergmann/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbergmann/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbergmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbergmann/subscriptions","organizations_url":"https://api.github.com/users/sebastianbergmann/orgs","repos_url":"https://api.github.com/users/sebastianbergmann/repos","events_url":"https://api.github.com/users/sebastianbergmann/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbergmann/received_events","type":"User","site_admin":false},"repo":{"id":14127912,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEyNzkxMg==","name":"comparator","full_name":"sebastianbergmann/comparator","private":false,"owner":{"login":"sebastianbergmann","id":25218,"node_id":"MDQ6VXNlcjI1MjE4","avatar_url":"https://avatars1.githubusercontent.com/u/25218?v=4","gravatar_id":"","url":"https://api.github.com/users/sebastianbergmann","html_url":"https://github.com/sebastianbergmann","followers_url":"https://api.github.com/users/sebastianbergmann/followers","following_url":"https://api.github.com/users/sebastianbergmann/following{/other_user}","gists_url":"https://api.github.com/users/sebastianbergmann/gists{/gist_id}","starred_url":"https://api.github.com/users/sebastianbergmann/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sebastianbergmann/subscriptions","organizations_url":"https://api.github.com/users/sebastianbergmann/orgs","repos_url":"https://api.github.com/users/sebastianbergmann/repos","events_url":"https://api.github.com/users/sebastianbergmann/events{/privacy}","received_events_url":"https://api.github.com/users/sebastianbergmann/received_events","type":"User","site_admin":false},"html_url":"https://github.com/sebastianbergmann/comparator","description":"Provides the functionality to compare PHP values for equality.","fork":false,"url":"https://api.github.com/repos/sebastianbergmann/comparator","forks_url":"https://api.github.com/repos/sebastianbergmann/comparator/forks","keys_url":"https://api.github.com/repos/sebastianbergmann/comparator/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sebastianbergmann/comparator/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sebastianbergmann/comparator/teams","hooks_url":"https://api.github.com/repos/sebastianbergmann/comparator/hooks","issue_events_url":"https://api.github.com/repos/sebastianbergmann/comparator/issues/events{/number}","events_url":"https://api.github.com/repos/sebastianbergmann/comparator/events","assignees_url":"https://api.github.com/repos/sebastianbergmann/comparator/assignees{/user}","branches_url":"https://api.github.com/repos/sebastianbergmann/comparator/branches{/branch}","tags_url":"https://api.github.com/repos/sebastianbergmann/comparator/tags","blobs_url":"https://api.github.com/repos/sebastianbergmann/comparator/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sebastianbergmann/comparator/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sebastianbergmann/comparator/git/refs{/sha}","trees_url":"https://api.github.com/repos/sebastianbergmann/comparator/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sebastianbergmann/comparator/statuses/{sha}","languages_url":"https://api.github.com/repos/sebastianbergmann/comparator/languages","stargazers_url":"https://api.github.com/repos/sebastianbergmann/comparator/stargazers","contributors_url":"https://api.github.com/repos/sebastianbergmann/comparator/contributors","subscribers_url":"https://api.github.com/repos/sebastianbergmann/comparator/subscribers","subscription_url":"https://api.github.com/repos/sebastianbergmann/comparator/subscription","commits_url":"https://api.github.com/repos/sebastianbergmann/comparator/commits{/sha}","git_commits_url":"https://api.github.com/repos/sebastianbergmann/comparator/git/commits{/sha}","comments_url":"https://api.github.com/repos/sebastianbergmann/comparator/comments{/number}","issue_comment_url":"https://api.github.com/repos/sebastianbergmann/comparator/issues/comments{/number}","contents_url":"https://api.github.com/repos/sebastianbergmann/comparator/contents/{+path}","compare_url":"https://api.github.com/repos/sebastianbergmann/comparator/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sebastianbergmann/comparator/merges","archive_url":"https://api.github.com/repos/sebastianbergmann/comparator/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sebastianbergmann/comparator/downloads","issues_url":"https://api.github.com/repos/sebastianbergmann/comparator/issues{/number}","pulls_url":"https://api.github.com/repos/sebastianbergmann/comparator/pulls{/number}","milestones_url":"https://api.github.com/repos/sebastianbergmann/comparator/milestones{/number}","notifications_url":"https://api.github.com/repos/sebastianbergmann/comparator/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sebastianbergmann/comparator/labels{/name}","releases_url":"https://api.github.com/repos/sebastianbergmann/comparator/releases{/id}","deployments_url":"https://api.github.com/repos/sebastianbergmann/comparator/deployments","created_at":"2013-11-05T00:36:12Z","updated_at":"2018-10-17T19:06:51Z","pushed_at":"2018-10-17T18:31:45Z","git_url":"git://github.com/sebastianbergmann/comparator.git","ssh_url":"git@github.com:sebastianbergmann/comparator.git","clone_url":"https://github.com/sebastianbergmann/comparator.git","svn_url":"https://github.com/sebastianbergmann/comparator","homepage":null,"size":210,"stargazers_count":3860,"watchers_count":3860,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":42,"open_issues":3,"watchers":3860,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sebastianbergmann/comparator/pulls/63"},"html":{"href":"https://github.com/sebastianbergmann/comparator/pull/63"},"issue":{"href":"https://api.github.com/repos/sebastianbergmann/comparator/issues/63"},"comments":{"href":"https://api.github.com/repos/sebastianbergmann/comparator/issues/63/comments"},"review_comments":{"href":"https://api.github.com/repos/sebastianbergmann/comparator/pulls/63/comments"},"review_comment":{"href":"https://api.github.com/repos/sebastianbergmann/comparator/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sebastianbergmann/comparator/pulls/63/commits"},"statuses":{"href":"https://api.github.com/repos/sebastianbergmann/comparator/statuses/daa763da23645f3d9abef3c6047302015583885f"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":true,"mergeable_state":"unstable","merged_by":null,"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":17,"deletions":66,"changed_files":2}}
{"actor":{"display_login":"rtheunissen"}}