{"action":"created","comment":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/231498104","pull_request_review_id":172480668,"id":231498104,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTQ5ODEwNA==","diff_hunk":"@@ -1,5 +1,21 @@\n FactoryGirl.define do\n   factory :totp, class: Carto::UserMultifactorAuth do\n     type Carto::UserMultifactorAuth::TYPE_TOTP\n+\n+    trait :needs_setup do\n+      enabled false\n+    end\n+\n+    trait :active do\n+      enabled true\n+    end\n+\n+    trait :disabled do","path":"spec/factories/user_multifactor_auths.rb","position":13,"original_position":13,"commit_id":"4616acf6232ba7b8c8570179e20bf1355fab4308","original_commit_id":"4616acf6232ba7b8c8570179e20bf1355fab4308","user":{"login":"javitonino","id":7569673,"node_id":"MDQ6VXNlcjc1Njk2NzM=","avatar_url":"https://avatars3.githubusercontent.com/u/7569673?v=4","gravatar_id":"","url":"https://api.github.com/users/javitonino","html_url":"https://github.com/javitonino","followers_url":"https://api.github.com/users/javitonino/followers","following_url":"https://api.github.com/users/javitonino/following{/other_user}","gists_url":"https://api.github.com/users/javitonino/gists{/gist_id}","starred_url":"https://api.github.com/users/javitonino/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/javitonino/subscriptions","organizations_url":"https://api.github.com/users/javitonino/orgs","repos_url":"https://api.github.com/users/javitonino/repos","events_url":"https://api.github.com/users/javitonino/events{/privacy}","received_events_url":"https://api.github.com/users/javitonino/received_events","type":"User","site_admin":false},"body":":+1: although maybe we don't need that field after all. Looking at this PR it's solved like:\r\n- No MFA model -> disabled\r\n- MFA model enabled = false -> needs_setup\r\n- MFA model enabled = true -> enabled\r\n\r\nand it looks like it works OK (from the CR view)","created_at":"2018-11-07T13:13:57Z","updated_at":"2018-11-07T13:13:58Z","html_url":"https://github.com/CartoDB/cartodb/pull/14396#discussion_r231498104","pull_request_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/14396","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments/231498104"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/14396#discussion_r231498104"},"pull_request":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/14396"}},"in_reply_to_id":231475435},"pull_request":{"url":"https://api.github.com/repos/CartoDB/cartodb/pulls/14396","id":228281944,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MjgxOTQ0","html_url":"https://github.com/CartoDB/cartodb/pull/14396","diff_url":"https://github.com/CartoDB/cartodb/pull/14396.diff","patch_url":"https://github.com/CartoDB/cartodb/pull/14396.patch","issue_url":"https://api.github.com/repos/CartoDB/cartodb/issues/14396","number":14396,"state":"open","locked":false,"title":"MFA login","user":{"login":"alrocar","id":623650,"node_id":"MDQ6VXNlcjYyMzY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/623650?v=4","gravatar_id":"","url":"https://api.github.com/users/alrocar","html_url":"https://github.com/alrocar","followers_url":"https://api.github.com/users/alrocar/followers","following_url":"https://api.github.com/users/alrocar/following{/other_user}","gists_url":"https://api.github.com/users/alrocar/gists{/gist_id}","starred_url":"https://api.github.com/users/alrocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrocar/subscriptions","organizations_url":"https://api.github.com/users/alrocar/orgs","repos_url":"https://api.github.com/users/alrocar/repos","events_url":"https://api.github.com/users/alrocar/events{/privacy}","received_events_url":"https://api.github.com/users/alrocar/received_events","type":"User","site_admin":false},"body":"Closes #14336","created_at":"2018-11-05T09:05:39Z","updated_at":"2018-11-07T13:13:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d6c07fe3cff91c7e5e8f5e3e70f3c330acd0ac90","assignee":{"login":"alrocar","id":623650,"node_id":"MDQ6VXNlcjYyMzY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/623650?v=4","gravatar_id":"","url":"https://api.github.com/users/alrocar","html_url":"https://github.com/alrocar","followers_url":"https://api.github.com/users/alrocar/followers","following_url":"https://api.github.com/users/alrocar/following{/other_user}","gists_url":"https://api.github.com/users/alrocar/gists{/gist_id}","starred_url":"https://api.github.com/users/alrocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrocar/subscriptions","organizations_url":"https://api.github.com/users/alrocar/orgs","repos_url":"https://api.github.com/users/alrocar/repos","events_url":"https://api.github.com/users/alrocar/events{/privacy}","received_events_url":"https://api.github.com/users/alrocar/received_events","type":"User","site_admin":false},"assignees":[{"login":"alrocar","id":623650,"node_id":"MDQ6VXNlcjYyMzY1MA==","avatar_url":"https://avatars0.githubusercontent.com/u/623650?v=4","gravatar_id":"","url":"https://api.github.com/users/alrocar","html_url":"https://github.com/alrocar","followers_url":"https://api.github.com/users/alrocar/followers","following_url":"https://api.github.com/users/alrocar/following{/other_user}","gists_url":"https://api.github.com/users/alrocar/gists{/gist_id}","starred_url":"https://api.github.com/users/alrocar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alrocar/subscriptions","organizations_url":"https://api.github.com/users/alrocar/orgs","repos_url":"https://api.github.com/users/alrocar/repos","events_url":"https://api.github.com/users/alrocar/events{/privacy}","received_events_url":"https://api.github.com/users/alrocar/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/14396/commits","review_comments_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/14396/comments","review_comment_url":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/issues/14396/comments","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/4616acf6232ba7b8c8570179e20bf1355fab4308","head":{"label":"CartoDB:14336_mfa_login","ref":"14336_mfa_login","sha":"4616acf6232ba7b8c8570179e20bf1355fab4308","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzU1","name":"cartodb","full_name":"CartoDB/cartodb","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-11-07T11:23:31Z","pushed_at":"2018-11-07T12:14:44Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":383946,"stargazers_count":1988,"watchers_count":1988,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":549,"mirror_url":null,"archived":false,"open_issues_count":377,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":549,"open_issues":377,"watchers":1988,"default_branch":"master"}},"base":{"label":"CartoDB:master","ref":"master","sha":"778e15cfa5c34750b5c036030571efa485ee42ac","user":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"repo":{"id":4909355,"node_id":"MDEwOlJlcG9zaXRvcnk0OTA5MzU1","name":"cartodb","full_name":"CartoDB/cartodb","private":false,"owner":{"login":"CartoDB","id":1799254,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTkyNTQ=","avatar_url":"https://avatars0.githubusercontent.com/u/1799254?v=4","gravatar_id":"","url":"https://api.github.com/users/CartoDB","html_url":"https://github.com/CartoDB","followers_url":"https://api.github.com/users/CartoDB/followers","following_url":"https://api.github.com/users/CartoDB/following{/other_user}","gists_url":"https://api.github.com/users/CartoDB/gists{/gist_id}","starred_url":"https://api.github.com/users/CartoDB/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/CartoDB/subscriptions","organizations_url":"https://api.github.com/users/CartoDB/orgs","repos_url":"https://api.github.com/users/CartoDB/repos","events_url":"https://api.github.com/users/CartoDB/events{/privacy}","received_events_url":"https://api.github.com/users/CartoDB/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/CartoDB/cartodb","description":"Location Intelligence & Data Visualization tool","fork":false,"url":"https://api.github.com/repos/CartoDB/cartodb","forks_url":"https://api.github.com/repos/CartoDB/cartodb/forks","keys_url":"https://api.github.com/repos/CartoDB/cartodb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/CartoDB/cartodb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/CartoDB/cartodb/teams","hooks_url":"https://api.github.com/repos/CartoDB/cartodb/hooks","issue_events_url":"https://api.github.com/repos/CartoDB/cartodb/issues/events{/number}","events_url":"https://api.github.com/repos/CartoDB/cartodb/events","assignees_url":"https://api.github.com/repos/CartoDB/cartodb/assignees{/user}","branches_url":"https://api.github.com/repos/CartoDB/cartodb/branches{/branch}","tags_url":"https://api.github.com/repos/CartoDB/cartodb/tags","blobs_url":"https://api.github.com/repos/CartoDB/cartodb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/CartoDB/cartodb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/CartoDB/cartodb/git/refs{/sha}","trees_url":"https://api.github.com/repos/CartoDB/cartodb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/CartoDB/cartodb/statuses/{sha}","languages_url":"https://api.github.com/repos/CartoDB/cartodb/languages","stargazers_url":"https://api.github.com/repos/CartoDB/cartodb/stargazers","contributors_url":"https://api.github.com/repos/CartoDB/cartodb/contributors","subscribers_url":"https://api.github.com/repos/CartoDB/cartodb/subscribers","subscription_url":"https://api.github.com/repos/CartoDB/cartodb/subscription","commits_url":"https://api.github.com/repos/CartoDB/cartodb/commits{/sha}","git_commits_url":"https://api.github.com/repos/CartoDB/cartodb/git/commits{/sha}","comments_url":"https://api.github.com/repos/CartoDB/cartodb/comments{/number}","issue_comment_url":"https://api.github.com/repos/CartoDB/cartodb/issues/comments{/number}","contents_url":"https://api.github.com/repos/CartoDB/cartodb/contents/{+path}","compare_url":"https://api.github.com/repos/CartoDB/cartodb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/CartoDB/cartodb/merges","archive_url":"https://api.github.com/repos/CartoDB/cartodb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/CartoDB/cartodb/downloads","issues_url":"https://api.github.com/repos/CartoDB/cartodb/issues{/number}","pulls_url":"https://api.github.com/repos/CartoDB/cartodb/pulls{/number}","milestones_url":"https://api.github.com/repos/CartoDB/cartodb/milestones{/number}","notifications_url":"https://api.github.com/repos/CartoDB/cartodb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/CartoDB/cartodb/labels{/name}","releases_url":"https://api.github.com/repos/CartoDB/cartodb/releases{/id}","deployments_url":"https://api.github.com/repos/CartoDB/cartodb/deployments","created_at":"2012-07-05T15:23:45Z","updated_at":"2018-11-07T11:23:31Z","pushed_at":"2018-11-07T12:14:44Z","git_url":"git://github.com/CartoDB/cartodb.git","ssh_url":"git@github.com:CartoDB/cartodb.git","clone_url":"https://github.com/CartoDB/cartodb.git","svn_url":"https://github.com/CartoDB/cartodb","homepage":"http://carto.com","size":383946,"stargazers_count":1988,"watchers_count":1988,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":549,"mirror_url":null,"archived":false,"open_issues_count":377,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":549,"open_issues":377,"watchers":1988,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/14396"},"html":{"href":"https://github.com/CartoDB/cartodb/pull/14396"},"issue":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/14396"},"comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/issues/14396/comments"},"review_comments":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/14396/comments"},"review_comment":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/CartoDB/cartodb/pulls/14396/commits"},"statuses":{"href":"https://api.github.com/repos/CartoDB/cartodb/statuses/4616acf6232ba7b8c8570179e20bf1355fab4308"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"javitonino"}}