{"action":"closed","number":5842,"pull_request":{"url":"https://api.github.com/repos/rust-lang/cargo/pulls/5842","id":205229019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1MjI5MDE5","html_url":"https://github.com/rust-lang/cargo/pull/5842","diff_url":"https://github.com/rust-lang/cargo/pull/5842.diff","patch_url":"https://github.com/rust-lang/cargo/pull/5842.patch","issue_url":"https://api.github.com/repos/rust-lang/cargo/issues/5842","number":5842,"state":"closed","locked":false,"title":"fix: Iteratively apply suggestions from the compiler","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"body":"This commit updates the `cargo fix` implementation to iteratively apply fixes\r\nfrom the compiler instead of only once. Currently the compiler can sometimes\r\nemit overlapping suggestions, such as in the case of transitioning\r\n\r\n    ::foo::<::Bar>();\r\n\r\nto ...\r\n\r\n    crate::foo::<crate::Bar>();\r\n\r\nand `rustfix` rightfully can't handle overlapping suggestions as there's no\r\nclear way of how to disambiguate the fixes. To fix this problem Cargo will now\r\nrun `rustc` and `rustfix` multiple times, attempting to reach a steady state\r\nwhere no fixes failed to apply.\r\n\r\nNaturally this is a pretty tricky thing to do and we want to be sure that Cargo\r\ndoesn't loop forever, for example. A number of safeguards are in place to\r\nprevent Cargo from going off into the weeds when fixing files, notably avoiding\r\nto reattempt fixes if no successful fixes ended up being applied.\r\n\r\nCloses #5813\r\nCloses rust-lang/rust#52754","created_at":"2018-07-31T20:14:42Z","updated_at":"2018-08-01T03:52:50Z","closed_at":"2018-08-01T03:52:50Z","merged_at":"2018-08-01T03:52:50Z","merge_commit_sha":"876a50366b71cf3c8ce917110fa37a1478de8348","assignee":{"login":"ehuss","id":43198,"node_id":"MDQ6VXNlcjQzMTk4","avatar_url":"https://avatars0.githubusercontent.com/u/43198?v=4","gravatar_id":"","url":"https://api.github.com/users/ehuss","html_url":"https://github.com/ehuss","followers_url":"https://api.github.com/users/ehuss/followers","following_url":"https://api.github.com/users/ehuss/following{/other_user}","gists_url":"https://api.github.com/users/ehuss/gists{/gist_id}","starred_url":"https://api.github.com/users/ehuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehuss/subscriptions","organizations_url":"https://api.github.com/users/ehuss/orgs","repos_url":"https://api.github.com/users/ehuss/repos","events_url":"https://api.github.com/users/ehuss/events{/privacy}","received_events_url":"https://api.github.com/users/ehuss/received_events","type":"User","site_admin":false},"assignees":[{"login":"ehuss","id":43198,"node_id":"MDQ6VXNlcjQzMTk4","avatar_url":"https://avatars0.githubusercontent.com/u/43198?v=4","gravatar_id":"","url":"https://api.github.com/users/ehuss","html_url":"https://github.com/ehuss","followers_url":"https://api.github.com/users/ehuss/followers","following_url":"https://api.github.com/users/ehuss/following{/other_user}","gists_url":"https://api.github.com/users/ehuss/gists{/gist_id}","starred_url":"https://api.github.com/users/ehuss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ehuss/subscriptions","organizations_url":"https://api.github.com/users/ehuss/orgs","repos_url":"https://api.github.com/users/ehuss/repos","events_url":"https://api.github.com/users/ehuss/events{/privacy}","received_events_url":"https://api.github.com/users/ehuss/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/rust-lang/cargo/milestones/1","html_url":"https://github.com/rust-lang/cargo/milestone/1","labels_url":"https://api.github.com/repos/rust-lang/cargo/milestones/1/labels","id":3503838,"node_id":"MDk6TWlsZXN0b25lMzUwMzgzOA==","number":1,"title":"Edition Preview 2","description":"Deliverables set for the 2018 Edition Preview 2","creator":{"login":"aturon","id":709807,"node_id":"MDQ6VXNlcjcwOTgwNw==","avatar_url":"https://avatars2.githubusercontent.com/u/709807?v=4","gravatar_id":"","url":"https://api.github.com/users/aturon","html_url":"https://github.com/aturon","followers_url":"https://api.github.com/users/aturon/followers","following_url":"https://api.github.com/users/aturon/following{/other_user}","gists_url":"https://api.github.com/users/aturon/gists{/gist_id}","starred_url":"https://api.github.com/users/aturon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aturon/subscriptions","organizations_url":"https://api.github.com/users/aturon/orgs","repos_url":"https://api.github.com/users/aturon/repos","events_url":"https://api.github.com/users/aturon/events{/privacy}","received_events_url":"https://api.github.com/users/aturon/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":10,"state":"open","created_at":"2018-07-17T19:26:48Z","updated_at":"2018-08-01T03:52:50Z","due_on":"2018-08-02T07:00:00Z","closed_at":null},"commits_url":"https://api.github.com/repos/rust-lang/cargo/pulls/5842/commits","review_comments_url":"https://api.github.com/repos/rust-lang/cargo/pulls/5842/comments","review_comment_url":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang/cargo/issues/5842/comments","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/876a50366b71cf3c8ce917110fa37a1478de8348","head":{"label":"alexcrichton:fix-lots","ref":"fix-lots","sha":"876a50366b71cf3c8ce917110fa37a1478de8348","user":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"repo":{"id":20969258,"node_id":"MDEwOlJlcG9zaXRvcnkyMDk2OTI1OA==","name":"cargo","full_name":"alexcrichton/cargo","owner":{"login":"alexcrichton","id":64996,"node_id":"MDQ6VXNlcjY0OTk2","avatar_url":"https://avatars1.githubusercontent.com/u/64996?v=4","gravatar_id":"","url":"https://api.github.com/users/alexcrichton","html_url":"https://github.com/alexcrichton","followers_url":"https://api.github.com/users/alexcrichton/followers","following_url":"https://api.github.com/users/alexcrichton/following{/other_user}","gists_url":"https://api.github.com/users/alexcrichton/gists{/gist_id}","starred_url":"https://api.github.com/users/alexcrichton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexcrichton/subscriptions","organizations_url":"https://api.github.com/users/alexcrichton/orgs","repos_url":"https://api.github.com/users/alexcrichton/repos","events_url":"https://api.github.com/users/alexcrichton/events{/privacy}","received_events_url":"https://api.github.com/users/alexcrichton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/alexcrichton/cargo","description":"Cargo Experiments","fork":true,"url":"https://api.github.com/repos/alexcrichton/cargo","forks_url":"https://api.github.com/repos/alexcrichton/cargo/forks","keys_url":"https://api.github.com/repos/alexcrichton/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/alexcrichton/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/alexcrichton/cargo/teams","hooks_url":"https://api.github.com/repos/alexcrichton/cargo/hooks","issue_events_url":"https://api.github.com/repos/alexcrichton/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/alexcrichton/cargo/events","assignees_url":"https://api.github.com/repos/alexcrichton/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/alexcrichton/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/alexcrichton/cargo/tags","blobs_url":"https://api.github.com/repos/alexcrichton/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/alexcrichton/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/alexcrichton/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/alexcrichton/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/alexcrichton/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/alexcrichton/cargo/languages","stargazers_url":"https://api.github.com/repos/alexcrichton/cargo/stargazers","contributors_url":"https://api.github.com/repos/alexcrichton/cargo/contributors","subscribers_url":"https://api.github.com/repos/alexcrichton/cargo/subscribers","subscription_url":"https://api.github.com/repos/alexcrichton/cargo/subscription","commits_url":"https://api.github.com/repos/alexcrichton/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/alexcrichton/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/alexcrichton/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/alexcrichton/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/alexcrichton/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/alexcrichton/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/alexcrichton/cargo/merges","archive_url":"https://api.github.com/repos/alexcrichton/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/alexcrichton/cargo/downloads","issues_url":"https://api.github.com/repos/alexcrichton/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/alexcrichton/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/alexcrichton/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/alexcrichton/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/alexcrichton/cargo/labels{/name}","releases_url":"https://api.github.com/repos/alexcrichton/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/alexcrichton/cargo/deployments","created_at":"2014-06-18T16:22:37Z","updated_at":"2014-06-25T22:54:56Z","pushed_at":"2018-08-01T00:19:38Z","git_url":"git://github.com/alexcrichton/cargo.git","ssh_url":"git@github.com:alexcrichton/cargo.git","clone_url":"https://github.com/alexcrichton/cargo.git","svn_url":"https://github.com/alexcrichton/cargo","homepage":null,"size":17115,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang:master","ref":"master","sha":"9bbab73a756e2cc0a044ca038cddec2ee12e01bd","user":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"repo":{"id":17420913,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQyMDkxMw==","name":"cargo","full_name":"rust-lang/cargo","owner":{"login":"rust-lang","id":5430905,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU0MzA5MDU=","avatar_url":"https://avatars1.githubusercontent.com/u/5430905?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang","html_url":"https://github.com/rust-lang","followers_url":"https://api.github.com/users/rust-lang/followers","following_url":"https://api.github.com/users/rust-lang/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang/subscriptions","organizations_url":"https://api.github.com/users/rust-lang/orgs","repos_url":"https://api.github.com/users/rust-lang/repos","events_url":"https://api.github.com/users/rust-lang/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang/cargo","description":"The Rust package manager","fork":false,"url":"https://api.github.com/repos/rust-lang/cargo","forks_url":"https://api.github.com/repos/rust-lang/cargo/forks","keys_url":"https://api.github.com/repos/rust-lang/cargo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang/cargo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang/cargo/teams","hooks_url":"https://api.github.com/repos/rust-lang/cargo/hooks","issue_events_url":"https://api.github.com/repos/rust-lang/cargo/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang/cargo/events","assignees_url":"https://api.github.com/repos/rust-lang/cargo/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang/cargo/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang/cargo/tags","blobs_url":"https://api.github.com/repos/rust-lang/cargo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang/cargo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang/cargo/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang/cargo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang/cargo/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang/cargo/languages","stargazers_url":"https://api.github.com/repos/rust-lang/cargo/stargazers","contributors_url":"https://api.github.com/repos/rust-lang/cargo/contributors","subscribers_url":"https://api.github.com/repos/rust-lang/cargo/subscribers","subscription_url":"https://api.github.com/repos/rust-lang/cargo/subscription","commits_url":"https://api.github.com/repos/rust-lang/cargo/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang/cargo/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang/cargo/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang/cargo/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang/cargo/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang/cargo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang/cargo/merges","archive_url":"https://api.github.com/repos/rust-lang/cargo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang/cargo/downloads","issues_url":"https://api.github.com/repos/rust-lang/cargo/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang/cargo/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang/cargo/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang/cargo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang/cargo/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang/cargo/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang/cargo/deployments","created_at":"2014-03-04T23:20:42Z","updated_at":"2018-08-01T02:52:37Z","pushed_at":"2018-08-01T03:52:48Z","git_url":"git://github.com/rust-lang/cargo.git","ssh_url":"git@github.com:rust-lang/cargo.git","clone_url":"https://github.com/rust-lang/cargo.git","svn_url":"https://github.com/rust-lang/cargo","homepage":"https://doc.rust-lang.org/cargo","size":19496,"stargazers_count":3376,"watchers_count":3376,"language":"Rust","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":794,"mirror_url":null,"archived":false,"open_issues_count":730,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":794,"open_issues":730,"watchers":3376,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/5842"},"html":{"href":"https://github.com/rust-lang/cargo/pull/5842"},"issue":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/5842"},"comments":{"href":"https://api.github.com/repos/rust-lang/cargo/issues/5842/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/5842/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang/cargo/pulls/5842/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang/cargo/statuses/876a50366b71cf3c8ce917110fa37a1478de8348"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bors","id":3372342,"node_id":"MDQ6VXNlcjMzNzIzNDI=","avatar_url":"https://avatars2.githubusercontent.com/u/3372342?v=4","gravatar_id":"","url":"https://api.github.com/users/bors","html_url":"https://github.com/bors","followers_url":"https://api.github.com/users/bors/followers","following_url":"https://api.github.com/users/bors/following{/other_user}","gists_url":"https://api.github.com/users/bors/gists{/gist_id}","starred_url":"https://api.github.com/users/bors/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bors/subscriptions","organizations_url":"https://api.github.com/users/bors/orgs","repos_url":"https://api.github.com/users/bors/repos","events_url":"https://api.github.com/users/bors/events{/privacy}","received_events_url":"https://api.github.com/users/bors/received_events","type":"User","site_admin":false},"comments":7,"review_comments":9,"maintainer_can_modify":false,"commits":1,"additions":173,"deletions":45,"changed_files":4}}
{"actor":{"display_login":"bors"}}