{"action":"created","issue":{"url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/809","repository_url":"https://api.github.com/repos/18F/e-QIP-prototype","labels_url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/809/labels{/name}","comments_url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/809/comments","events_url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/809/events","html_url":"https://github.com/18F/e-QIP-prototype/pull/809","id":361045958,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MTE1OTMy","number":809,"title":"Ask for National Guard service state","user":{"login":"hursey013","id":1178494,"node_id":"MDQ6VXNlcjExNzg0OTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1178494?v=4","gravatar_id":"","url":"https://api.github.com/users/hursey013","html_url":"https://github.com/hursey013","followers_url":"https://api.github.com/users/hursey013/followers","following_url":"https://api.github.com/users/hursey013/following{/other_user}","gists_url":"https://api.github.com/users/hursey013/gists{/gist_id}","starred_url":"https://api.github.com/users/hursey013/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hursey013/subscriptions","organizations_url":"https://api.github.com/users/hursey013/orgs","repos_url":"https://api.github.com/users/hursey013/repos","events_url":"https://api.github.com/users/hursey013/events{/privacy}","received_events_url":"https://api.github.com/users/hursey013/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-09-17T21:10:03Z","updated_at":"2018-09-18T20:03:22Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/18F/e-QIP-prototype/pulls/809","html_url":"https://github.com/18F/e-QIP-prototype/pull/809","diff_url":"https://github.com/18F/e-QIP-prototype/pull/809.diff","patch_url":"https://github.com/18F/e-QIP-prototype/pull/809.patch"},"body":"Fixes #752\r\n\r\nAdds a `State of Service` field when Army or Air National Guard are selected in military history. Also created a new location layout for `State` only.\r\n\r\n<img width=\"685\" alt=\"screen shot 2018-09-18 at 11 24 22 am\" src=\"https://user-images.githubusercontent.com/1178494/45698114-4def7680-bb35-11e8-95df-790b56e873b9.png\">\r\n"},"comment":{"url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/comments/422532005","html_url":"https://github.com/18F/e-QIP-prototype/pull/809#issuecomment-422532005","issue_url":"https://api.github.com/repos/18F/e-QIP-prototype/issues/809","id":422532005,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjUzMjAwNQ==","user":{"login":"ryanhofdotgov","id":37100189,"node_id":"MDQ6VXNlcjM3MTAwMTg5","avatar_url":"https://avatars1.githubusercontent.com/u/37100189?v=4","gravatar_id":"","url":"https://api.github.com/users/ryanhofdotgov","html_url":"https://github.com/ryanhofdotgov","followers_url":"https://api.github.com/users/ryanhofdotgov/followers","following_url":"https://api.github.com/users/ryanhofdotgov/following{/other_user}","gists_url":"https://api.github.com/users/ryanhofdotgov/gists{/gist_id}","starred_url":"https://api.github.com/users/ryanhofdotgov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ryanhofdotgov/subscriptions","organizations_url":"https://api.github.com/users/ryanhofdotgov/orgs","repos_url":"https://api.github.com/users/ryanhofdotgov/repos","events_url":"https://api.github.com/users/ryanhofdotgov/events{/privacy}","received_events_url":"https://api.github.com/users/ryanhofdotgov/received_events","type":"User","site_admin":false},"created_at":"2018-09-18T20:03:22Z","updated_at":"2018-09-18T20:03:22Z","author_association":"MEMBER","body":"@hursey013 I think we will need to tag team these types issues for the next few weeks, as fully completing this type of changes requires:\r\n1) Access to NITSL (so you can submit XML to e-QIP)\r\n2) Access to e-QIP AV\r\n\r\nAlso requires a little bit of knowledge on how to clear database, load up test cases into system from command-line, etc. that I've developed over past few weeks, but haven't documented yet – Doh!\r\n\r\nFinally, I think for any new field we are adding or changing, we need to make sure it is represented in one of the 5 full test cases (or a new one) where we can easily visually inspect the output and submit it to e-QIP. The other tiny, self-contained test case snippets only exercise so much.\r\n\r\nAfter you review my commit contribution, would you merge in?"}}
{"actor":{"display_login":"ryanhofdotgov"}}