{"action":"created","comment":{"url":"https://api.github.com/repos/openthread/wpantund/pulls/comments/198977547","pull_request_review_id":133010534,"id":198977547,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODk3NzU0Nw==","diff_hunk":"@@ -48,6 +48,7 @@ doxygen.cfg\n src/wpantund/wpantund\n src/wpanctl/wpanctl\n .dirstamp\n+src/version.c","path":".gitignore","position":4,"original_position":4,"commit_id":"b27a601d4289321507b0b62ad2f1537d53f59a56","original_commit_id":"b27a601d4289321507b0b62ad2f1537d53f59a56","user":{"login":"EugeneGonzalez","id":16311843,"node_id":"MDQ6VXNlcjE2MzExODQz","avatar_url":"https://avatars3.githubusercontent.com/u/16311843?v=4","gravatar_id":"","url":"https://api.github.com/users/EugeneGonzalez","html_url":"https://github.com/EugeneGonzalez","followers_url":"https://api.github.com/users/EugeneGonzalez/followers","following_url":"https://api.github.com/users/EugeneGonzalez/following{/other_user}","gists_url":"https://api.github.com/users/EugeneGonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/EugeneGonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EugeneGonzalez/subscriptions","organizations_url":"https://api.github.com/users/EugeneGonzalez/orgs","repos_url":"https://api.github.com/users/EugeneGonzalez/repos","events_url":"https://api.github.com/users/EugeneGonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/EugeneGonzalez/received_events","type":"User","site_admin":false},"body":"Ah, I think this is caused by the difference between Android.mk and src/Makefile.am.\r\nAndroid.mk generates src/version.c on line 75 where as src/Makefile.am generates  $(top_builddir)/$(subdir)/version.c on line 47. I can update the PR to include both locations.","created_at":"2018-06-28T20:37:31Z","updated_at":"2018-06-28T20:37:31Z","html_url":"https://github.com/openthread/wpantund/pull/319#discussion_r198977547","pull_request_url":"https://api.github.com/repos/openthread/wpantund/pulls/319","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/openthread/wpantund/pulls/comments/198977547"},"html":{"href":"https://github.com/openthread/wpantund/pull/319#discussion_r198977547"},"pull_request":{"href":"https://api.github.com/repos/openthread/wpantund/pulls/319"}},"in_reply_to_id":198674045},"pull_request":{"url":"https://api.github.com/repos/openthread/wpantund/pulls/319","id":197543780,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NTQzNzgw","html_url":"https://github.com/openthread/wpantund/pull/319","diff_url":"https://github.com/openthread/wpantund/pull/319.diff","patch_url":"https://github.com/openthread/wpantund/pull/319.patch","issue_url":"https://api.github.com/repos/openthread/wpantund/issues/319","number":319,"state":"open","locked":false,"title":"Add autogenerated version file to git ignore","user":{"login":"EugeneGonzalez","id":16311843,"node_id":"MDQ6VXNlcjE2MzExODQz","avatar_url":"https://avatars3.githubusercontent.com/u/16311843?v=4","gravatar_id":"","url":"https://api.github.com/users/EugeneGonzalez","html_url":"https://github.com/EugeneGonzalez","followers_url":"https://api.github.com/users/EugeneGonzalez/followers","following_url":"https://api.github.com/users/EugeneGonzalez/following{/other_user}","gists_url":"https://api.github.com/users/EugeneGonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/EugeneGonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EugeneGonzalez/subscriptions","organizations_url":"https://api.github.com/users/EugeneGonzalez/orgs","repos_url":"https://api.github.com/users/EugeneGonzalez/repos","events_url":"https://api.github.com/users/EugeneGonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/EugeneGonzalez/received_events","type":"User","site_admin":false},"body":"src/version.c isn't in gitignore, which can cause issues for automatic\r\nsyncs. The automatic sync fail will due to uncommitted changes even though\r\nthis file is generated by the build system and should be ignored.","created_at":"2018-06-26T20:37:32Z","updated_at":"2018-06-28T20:37:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c4e4a63e58ae9653c9df0348da268c301fe01e7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/openthread/wpantund/pulls/319/commits","review_comments_url":"https://api.github.com/repos/openthread/wpantund/pulls/319/comments","review_comment_url":"https://api.github.com/repos/openthread/wpantund/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openthread/wpantund/issues/319/comments","statuses_url":"https://api.github.com/repos/openthread/wpantund/statuses/b27a601d4289321507b0b62ad2f1537d53f59a56","head":{"label":"EugeneGonzalez:master","ref":"master","sha":"b27a601d4289321507b0b62ad2f1537d53f59a56","user":{"login":"EugeneGonzalez","id":16311843,"node_id":"MDQ6VXNlcjE2MzExODQz","avatar_url":"https://avatars3.githubusercontent.com/u/16311843?v=4","gravatar_id":"","url":"https://api.github.com/users/EugeneGonzalez","html_url":"https://github.com/EugeneGonzalez","followers_url":"https://api.github.com/users/EugeneGonzalez/followers","following_url":"https://api.github.com/users/EugeneGonzalez/following{/other_user}","gists_url":"https://api.github.com/users/EugeneGonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/EugeneGonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EugeneGonzalez/subscriptions","organizations_url":"https://api.github.com/users/EugeneGonzalez/orgs","repos_url":"https://api.github.com/users/EugeneGonzalez/repos","events_url":"https://api.github.com/users/EugeneGonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/EugeneGonzalez/received_events","type":"User","site_admin":false},"repo":{"id":138789340,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg3ODkzNDA=","name":"wpantund","full_name":"EugeneGonzalez/wpantund","owner":{"login":"EugeneGonzalez","id":16311843,"node_id":"MDQ6VXNlcjE2MzExODQz","avatar_url":"https://avatars3.githubusercontent.com/u/16311843?v=4","gravatar_id":"","url":"https://api.github.com/users/EugeneGonzalez","html_url":"https://github.com/EugeneGonzalez","followers_url":"https://api.github.com/users/EugeneGonzalez/followers","following_url":"https://api.github.com/users/EugeneGonzalez/following{/other_user}","gists_url":"https://api.github.com/users/EugeneGonzalez/gists{/gist_id}","starred_url":"https://api.github.com/users/EugeneGonzalez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/EugeneGonzalez/subscriptions","organizations_url":"https://api.github.com/users/EugeneGonzalez/orgs","repos_url":"https://api.github.com/users/EugeneGonzalez/repos","events_url":"https://api.github.com/users/EugeneGonzalez/events{/privacy}","received_events_url":"https://api.github.com/users/EugeneGonzalez/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/EugeneGonzalez/wpantund","description":"Wireless Network Interface Daemon for Low-Power Wireless SoCs","fork":true,"url":"https://api.github.com/repos/EugeneGonzalez/wpantund","forks_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/forks","keys_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/keys{/key_id}","collaborators_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/teams","hooks_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/hooks","issue_events_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/issues/events{/number}","events_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/events","assignees_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/assignees{/user}","branches_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/branches{/branch}","tags_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/tags","blobs_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/git/refs{/sha}","trees_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/git/trees{/sha}","statuses_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/statuses/{sha}","languages_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/languages","stargazers_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/stargazers","contributors_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/contributors","subscribers_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/subscribers","subscription_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/subscription","commits_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/commits{/sha}","git_commits_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/git/commits{/sha}","comments_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/comments{/number}","issue_comment_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/issues/comments{/number}","contents_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/contents/{+path}","compare_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/compare/{base}...{head}","merges_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/merges","archive_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/downloads","issues_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/issues{/number}","pulls_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/pulls{/number}","milestones_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/milestones{/number}","notifications_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/labels{/name}","releases_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/releases{/id}","deployments_url":"https://api.github.com/repos/EugeneGonzalez/wpantund/deployments","created_at":"2018-06-26T20:25:38Z","updated_at":"2018-06-26T20:36:42Z","pushed_at":"2018-06-26T20:36:41Z","git_url":"git://github.com/EugeneGonzalez/wpantund.git","ssh_url":"git@github.com:EugeneGonzalez/wpantund.git","clone_url":"https://github.com/EugeneGonzalez/wpantund.git","svn_url":"https://github.com/EugeneGonzalez/wpantund","homepage":"","size":3182,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openthread:master","ref":"master","sha":"3869ec31160a9afd30184fe618f0fcc7b951a94e","user":{"login":"openthread","id":16142269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTQyMjY5","avatar_url":"https://avatars2.githubusercontent.com/u/16142269?v=4","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"repo":{"id":60717054,"node_id":"MDEwOlJlcG9zaXRvcnk2MDcxNzA1NA==","name":"wpantund","full_name":"openthread/wpantund","owner":{"login":"openthread","id":16142269,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2MTQyMjY5","avatar_url":"https://avatars2.githubusercontent.com/u/16142269?v=4","gravatar_id":"","url":"https://api.github.com/users/openthread","html_url":"https://github.com/openthread","followers_url":"https://api.github.com/users/openthread/followers","following_url":"https://api.github.com/users/openthread/following{/other_user}","gists_url":"https://api.github.com/users/openthread/gists{/gist_id}","starred_url":"https://api.github.com/users/openthread/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openthread/subscriptions","organizations_url":"https://api.github.com/users/openthread/orgs","repos_url":"https://api.github.com/users/openthread/repos","events_url":"https://api.github.com/users/openthread/events{/privacy}","received_events_url":"https://api.github.com/users/openthread/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/openthread/wpantund","description":"Wireless Network Interface Daemon for Low-Power Wireless SoCs","fork":false,"url":"https://api.github.com/repos/openthread/wpantund","forks_url":"https://api.github.com/repos/openthread/wpantund/forks","keys_url":"https://api.github.com/repos/openthread/wpantund/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openthread/wpantund/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openthread/wpantund/teams","hooks_url":"https://api.github.com/repos/openthread/wpantund/hooks","issue_events_url":"https://api.github.com/repos/openthread/wpantund/issues/events{/number}","events_url":"https://api.github.com/repos/openthread/wpantund/events","assignees_url":"https://api.github.com/repos/openthread/wpantund/assignees{/user}","branches_url":"https://api.github.com/repos/openthread/wpantund/branches{/branch}","tags_url":"https://api.github.com/repos/openthread/wpantund/tags","blobs_url":"https://api.github.com/repos/openthread/wpantund/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openthread/wpantund/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openthread/wpantund/git/refs{/sha}","trees_url":"https://api.github.com/repos/openthread/wpantund/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openthread/wpantund/statuses/{sha}","languages_url":"https://api.github.com/repos/openthread/wpantund/languages","stargazers_url":"https://api.github.com/repos/openthread/wpantund/stargazers","contributors_url":"https://api.github.com/repos/openthread/wpantund/contributors","subscribers_url":"https://api.github.com/repos/openthread/wpantund/subscribers","subscription_url":"https://api.github.com/repos/openthread/wpantund/subscription","commits_url":"https://api.github.com/repos/openthread/wpantund/commits{/sha}","git_commits_url":"https://api.github.com/repos/openthread/wpantund/git/commits{/sha}","comments_url":"https://api.github.com/repos/openthread/wpantund/comments{/number}","issue_comment_url":"https://api.github.com/repos/openthread/wpantund/issues/comments{/number}","contents_url":"https://api.github.com/repos/openthread/wpantund/contents/{+path}","compare_url":"https://api.github.com/repos/openthread/wpantund/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openthread/wpantund/merges","archive_url":"https://api.github.com/repos/openthread/wpantund/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openthread/wpantund/downloads","issues_url":"https://api.github.com/repos/openthread/wpantund/issues{/number}","pulls_url":"https://api.github.com/repos/openthread/wpantund/pulls{/number}","milestones_url":"https://api.github.com/repos/openthread/wpantund/milestones{/number}","notifications_url":"https://api.github.com/repos/openthread/wpantund/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openthread/wpantund/labels{/name}","releases_url":"https://api.github.com/repos/openthread/wpantund/releases{/id}","deployments_url":"https://api.github.com/repos/openthread/wpantund/deployments","created_at":"2016-06-08T17:32:11Z","updated_at":"2018-06-27T17:44:38Z","pushed_at":"2018-06-28T19:11:11Z","git_url":"git://github.com/openthread/wpantund.git","ssh_url":"git@github.com:openthread/wpantund.git","clone_url":"https://github.com/openthread/wpantund.git","svn_url":"https://github.com/openthread/wpantund","homepage":"","size":3193,"stargazers_count":73,"watchers_count":73,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":52,"mirror_url":null,"archived":false,"open_issues_count":40,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":52,"open_issues":40,"watchers":73,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openthread/wpantund/pulls/319"},"html":{"href":"https://github.com/openthread/wpantund/pull/319"},"issue":{"href":"https://api.github.com/repos/openthread/wpantund/issues/319"},"comments":{"href":"https://api.github.com/repos/openthread/wpantund/issues/319/comments"},"review_comments":{"href":"https://api.github.com/repos/openthread/wpantund/pulls/319/comments"},"review_comment":{"href":"https://api.github.com/repos/openthread/wpantund/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openthread/wpantund/pulls/319/commits"},"statuses":{"href":"https://api.github.com/repos/openthread/wpantund/statuses/b27a601d4289321507b0b62ad2f1537d53f59a56"}},"author_association":"NONE"}}
{"actor":{"display_login":"EugeneGonzalez"}}