{"action":"closed","number":477,"pull_request":{"url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/477","id":198633082,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4NjMzMDgy","html_url":"https://github.com/NationalBankBelgium/stark/pull/477","diff_url":"https://github.com/NationalBankBelgium/stark/pull/477.diff","patch_url":"https://github.com/NationalBankBelgium/stark/pull/477.patch","issue_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/477","number":477,"state":"closed","locked":false,"title":"fix(stark-demo): revert PR #471. Adapt baseHref/deployUrl via Node script to fix Showcase publication on GitHub pages","user":{"login":"christophercr","id":5698318,"node_id":"MDQ6VXNlcjU2OTgzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5698318?v=4","gravatar_id":"","url":"https://api.github.com/users/christophercr","html_url":"https://github.com/christophercr","followers_url":"https://api.github.com/users/christophercr/followers","following_url":"https://api.github.com/users/christophercr/following{/other_user}","gists_url":"https://api.github.com/users/christophercr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophercr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophercr/subscriptions","organizations_url":"https://api.github.com/users/christophercr/orgs","repos_url":"https://api.github.com/users/christophercr/repos","events_url":"https://api.github.com/users/christophercr/events{/privacy}","received_events_url":"https://api.github.com/users/christophercr/received_events","type":"User","site_admin":false},"body":"ISSUES CLOSED: 466\r\n\r\n## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [X] The commit message follows our guidelines: https://github.com/NationalBankBelgium/stark/blob/master/CONTRIBUTING.md#-commit-message-guidelines\r\n- [ ] Tests for the changes have been added (for bug fixes / features)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[X] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[X] CI related changes\r\n[ ] Documentation content changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\n<!-- Please describe the current behavior that you are modifying, or link to a relevant issue. -->\r\nAlthough the baseHref can be dynamically changed via the Angular APP_BASE_HREF provider, the CSS and other assets are imported from the wrong folder since the deployUrl is used during the bundle building by Wepack to generate such imports. The issue is that the deployUrl cannot be defined dynamically.\r\n\r\nIssue Number: #466 \r\n\r\n\r\n## What is the new behavior?\r\nReverted the changes made in #471 related to the definiton of the APP_BASE_HREF as an environment provider.\r\n\r\nThe final baseHref and deploy URL are adapted via a Node script before the showcase is copied to the GH-Pages branch.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[X] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n","created_at":"2018-07-02T10:15:17Z","updated_at":"2018-07-02T11:05:00Z","closed_at":"2018-07-02T11:04:59Z","merged_at":"2018-07-02T11:04:59Z","merge_commit_sha":"6fc4fb38e06fb254e321741137c612e2d367b9d9","assignee":null,"assignees":[],"requested_reviewers":[{"login":"SuperITMan","id":10333565,"node_id":"MDQ6VXNlcjEwMzMzNTY1","avatar_url":"https://avatars0.githubusercontent.com/u/10333565?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperITMan","html_url":"https://github.com/SuperITMan","followers_url":"https://api.github.com/users/SuperITMan/followers","following_url":"https://api.github.com/users/SuperITMan/following{/other_user}","gists_url":"https://api.github.com/users/SuperITMan/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperITMan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperITMan/subscriptions","organizations_url":"https://api.github.com/users/SuperITMan/orgs","repos_url":"https://api.github.com/users/SuperITMan/repos","events_url":"https://api.github.com/users/SuperITMan/events{/privacy}","received_events_url":"https://api.github.com/users/SuperITMan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":853796648,"node_id":"MDU6TGFiZWw4NTM3OTY2NDg=","url":"https://api.github.com/repos/NationalBankBelgium/stark/labels/PR%20action:%20review","name":"PR action: review","color":"fbca04","default":false}],"milestone":{"url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones/8","html_url":"https://github.com/NationalBankBelgium/stark/milestone/8","labels_url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones/8/labels","id":3304077,"node_id":"MDk6TWlsZXN0b25lMzMwNDA3Nw==","number":8,"title":"10.0.0-alpha.4","description":"","creator":{"login":"dsebastien","id":89887,"node_id":"MDQ6VXNlcjg5ODg3","avatar_url":"https://avatars3.githubusercontent.com/u/89887?v=4","gravatar_id":"","url":"https://api.github.com/users/dsebastien","html_url":"https://github.com/dsebastien","followers_url":"https://api.github.com/users/dsebastien/followers","following_url":"https://api.github.com/users/dsebastien/following{/other_user}","gists_url":"https://api.github.com/users/dsebastien/gists{/gist_id}","starred_url":"https://api.github.com/users/dsebastien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsebastien/subscriptions","organizations_url":"https://api.github.com/users/dsebastien/orgs","repos_url":"https://api.github.com/users/dsebastien/repos","events_url":"https://api.github.com/users/dsebastien/events{/privacy}","received_events_url":"https://api.github.com/users/dsebastien/received_events","type":"User","site_admin":false},"open_issues":43,"closed_issues":11,"state":"open","created_at":"2018-04-27T12:06:54Z","updated_at":"2018-07-02T11:05:00Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/477/commits","review_comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/477/comments","review_comment_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/477/comments","statuses_url":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/f9dadfda37cc1ffd4ef5fbd095a8f37116d5f7fe","head":{"label":"christophercr:feature/showcase-base-href","ref":"feature/showcase-base-href","sha":"f9dadfda37cc1ffd4ef5fbd095a8f37116d5f7fe","user":{"login":"christophercr","id":5698318,"node_id":"MDQ6VXNlcjU2OTgzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5698318?v=4","gravatar_id":"","url":"https://api.github.com/users/christophercr","html_url":"https://github.com/christophercr","followers_url":"https://api.github.com/users/christophercr/followers","following_url":"https://api.github.com/users/christophercr/following{/other_user}","gists_url":"https://api.github.com/users/christophercr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophercr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophercr/subscriptions","organizations_url":"https://api.github.com/users/christophercr/orgs","repos_url":"https://api.github.com/users/christophercr/repos","events_url":"https://api.github.com/users/christophercr/events{/privacy}","received_events_url":"https://api.github.com/users/christophercr/received_events","type":"User","site_admin":false},"repo":{"id":121400392,"node_id":"MDEwOlJlcG9zaXRvcnkxMjE0MDAzOTI=","name":"stark","full_name":"christophercr/stark","owner":{"login":"christophercr","id":5698318,"node_id":"MDQ6VXNlcjU2OTgzMTg=","avatar_url":"https://avatars1.githubusercontent.com/u/5698318?v=4","gravatar_id":"","url":"https://api.github.com/users/christophercr","html_url":"https://github.com/christophercr","followers_url":"https://api.github.com/users/christophercr/followers","following_url":"https://api.github.com/users/christophercr/following{/other_user}","gists_url":"https://api.github.com/users/christophercr/gists{/gist_id}","starred_url":"https://api.github.com/users/christophercr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/christophercr/subscriptions","organizations_url":"https://api.github.com/users/christophercr/orgs","repos_url":"https://api.github.com/users/christophercr/repos","events_url":"https://api.github.com/users/christophercr/events{/privacy}","received_events_url":"https://api.github.com/users/christophercr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/christophercr/stark","description":"Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...","fork":true,"url":"https://api.github.com/repos/christophercr/stark","forks_url":"https://api.github.com/repos/christophercr/stark/forks","keys_url":"https://api.github.com/repos/christophercr/stark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/christophercr/stark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/christophercr/stark/teams","hooks_url":"https://api.github.com/repos/christophercr/stark/hooks","issue_events_url":"https://api.github.com/repos/christophercr/stark/issues/events{/number}","events_url":"https://api.github.com/repos/christophercr/stark/events","assignees_url":"https://api.github.com/repos/christophercr/stark/assignees{/user}","branches_url":"https://api.github.com/repos/christophercr/stark/branches{/branch}","tags_url":"https://api.github.com/repos/christophercr/stark/tags","blobs_url":"https://api.github.com/repos/christophercr/stark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/christophercr/stark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/christophercr/stark/git/refs{/sha}","trees_url":"https://api.github.com/repos/christophercr/stark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/christophercr/stark/statuses/{sha}","languages_url":"https://api.github.com/repos/christophercr/stark/languages","stargazers_url":"https://api.github.com/repos/christophercr/stark/stargazers","contributors_url":"https://api.github.com/repos/christophercr/stark/contributors","subscribers_url":"https://api.github.com/repos/christophercr/stark/subscribers","subscription_url":"https://api.github.com/repos/christophercr/stark/subscription","commits_url":"https://api.github.com/repos/christophercr/stark/commits{/sha}","git_commits_url":"https://api.github.com/repos/christophercr/stark/git/commits{/sha}","comments_url":"https://api.github.com/repos/christophercr/stark/comments{/number}","issue_comment_url":"https://api.github.com/repos/christophercr/stark/issues/comments{/number}","contents_url":"https://api.github.com/repos/christophercr/stark/contents/{+path}","compare_url":"https://api.github.com/repos/christophercr/stark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/christophercr/stark/merges","archive_url":"https://api.github.com/repos/christophercr/stark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/christophercr/stark/downloads","issues_url":"https://api.github.com/repos/christophercr/stark/issues{/number}","pulls_url":"https://api.github.com/repos/christophercr/stark/pulls{/number}","milestones_url":"https://api.github.com/repos/christophercr/stark/milestones{/number}","notifications_url":"https://api.github.com/repos/christophercr/stark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/christophercr/stark/labels{/name}","releases_url":"https://api.github.com/repos/christophercr/stark/releases{/id}","deployments_url":"https://api.github.com/repos/christophercr/stark/deployments","created_at":"2018-02-13T15:38:02Z","updated_at":"2018-07-02T10:36:57Z","pushed_at":"2018-07-02T10:44:59Z","git_url":"git://github.com/christophercr/stark.git","ssh_url":"git@github.com:christophercr/stark.git","clone_url":"https://github.com/christophercr/stark.git","svn_url":"https://github.com/christophercr/stark","homepage":"","size":12143,"stargazers_count":0,"watchers_count":0,"language":"TypeScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NationalBankBelgium:master","ref":"master","sha":"946b9253a8b2ce92615c585b6566bec4954a776f","user":{"login":"NationalBankBelgium","id":22069913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDY5OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/22069913?v=4","gravatar_id":"","url":"https://api.github.com/users/NationalBankBelgium","html_url":"https://github.com/NationalBankBelgium","followers_url":"https://api.github.com/users/NationalBankBelgium/followers","following_url":"https://api.github.com/users/NationalBankBelgium/following{/other_user}","gists_url":"https://api.github.com/users/NationalBankBelgium/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalBankBelgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalBankBelgium/subscriptions","organizations_url":"https://api.github.com/users/NationalBankBelgium/orgs","repos_url":"https://api.github.com/users/NationalBankBelgium/repos","events_url":"https://api.github.com/users/NationalBankBelgium/events{/privacy}","received_events_url":"https://api.github.com/users/NationalBankBelgium/received_events","type":"Organization","site_admin":false},"repo":{"id":105157749,"node_id":"MDEwOlJlcG9zaXRvcnkxMDUxNTc3NDk=","name":"stark","full_name":"NationalBankBelgium/stark","owner":{"login":"NationalBankBelgium","id":22069913,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMDY5OTEz","avatar_url":"https://avatars1.githubusercontent.com/u/22069913?v=4","gravatar_id":"","url":"https://api.github.com/users/NationalBankBelgium","html_url":"https://github.com/NationalBankBelgium","followers_url":"https://api.github.com/users/NationalBankBelgium/followers","following_url":"https://api.github.com/users/NationalBankBelgium/following{/other_user}","gists_url":"https://api.github.com/users/NationalBankBelgium/gists{/gist_id}","starred_url":"https://api.github.com/users/NationalBankBelgium/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NationalBankBelgium/subscriptions","organizations_url":"https://api.github.com/users/NationalBankBelgium/orgs","repos_url":"https://api.github.com/users/NationalBankBelgium/repos","events_url":"https://api.github.com/users/NationalBankBelgium/events{/privacy}","received_events_url":"https://api.github.com/users/NationalBankBelgium/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NationalBankBelgium/stark","description":"Modern client-side Web application framework based on Angular, Angular Material / Material Design, TypeScript, Redux, RxJS, ...","fork":false,"url":"https://api.github.com/repos/NationalBankBelgium/stark","forks_url":"https://api.github.com/repos/NationalBankBelgium/stark/forks","keys_url":"https://api.github.com/repos/NationalBankBelgium/stark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NationalBankBelgium/stark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NationalBankBelgium/stark/teams","hooks_url":"https://api.github.com/repos/NationalBankBelgium/stark/hooks","issue_events_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/events{/number}","events_url":"https://api.github.com/repos/NationalBankBelgium/stark/events","assignees_url":"https://api.github.com/repos/NationalBankBelgium/stark/assignees{/user}","branches_url":"https://api.github.com/repos/NationalBankBelgium/stark/branches{/branch}","tags_url":"https://api.github.com/repos/NationalBankBelgium/stark/tags","blobs_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/refs{/sha}","trees_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/{sha}","languages_url":"https://api.github.com/repos/NationalBankBelgium/stark/languages","stargazers_url":"https://api.github.com/repos/NationalBankBelgium/stark/stargazers","contributors_url":"https://api.github.com/repos/NationalBankBelgium/stark/contributors","subscribers_url":"https://api.github.com/repos/NationalBankBelgium/stark/subscribers","subscription_url":"https://api.github.com/repos/NationalBankBelgium/stark/subscription","commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/commits{/sha}","git_commits_url":"https://api.github.com/repos/NationalBankBelgium/stark/git/commits{/sha}","comments_url":"https://api.github.com/repos/NationalBankBelgium/stark/comments{/number}","issue_comment_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues/comments{/number}","contents_url":"https://api.github.com/repos/NationalBankBelgium/stark/contents/{+path}","compare_url":"https://api.github.com/repos/NationalBankBelgium/stark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NationalBankBelgium/stark/merges","archive_url":"https://api.github.com/repos/NationalBankBelgium/stark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NationalBankBelgium/stark/downloads","issues_url":"https://api.github.com/repos/NationalBankBelgium/stark/issues{/number}","pulls_url":"https://api.github.com/repos/NationalBankBelgium/stark/pulls{/number}","milestones_url":"https://api.github.com/repos/NationalBankBelgium/stark/milestones{/number}","notifications_url":"https://api.github.com/repos/NationalBankBelgium/stark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NationalBankBelgium/stark/labels{/name}","releases_url":"https://api.github.com/repos/NationalBankBelgium/stark/releases{/id}","deployments_url":"https://api.github.com/repos/NationalBankBelgium/stark/deployments","created_at":"2017-09-28T14:20:05Z","updated_at":"2018-07-02T10:08:04Z","pushed_at":"2018-07-02T11:04:59Z","git_url":"git://github.com/NationalBankBelgium/stark.git","ssh_url":"git@github.com:NationalBankBelgium/stark.git","clone_url":"https://github.com/NationalBankBelgium/stark.git","svn_url":"https://github.com/NationalBankBelgium/stark","homepage":"","size":11937,"stargazers_count":7,"watchers_count":7,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":217,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":10,"open_issues":217,"watchers":7,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/477"},"html":{"href":"https://github.com/NationalBankBelgium/stark/pull/477"},"issue":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/issues/477"},"comments":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/issues/477/comments"},"review_comments":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/477/comments"},"review_comment":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/pulls/477/commits"},"statuses":{"href":"https://api.github.com/repos/NationalBankBelgium/stark/statuses/f9dadfda37cc1ffd4ef5fbd095a8f37116d5f7fe"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"dsebastien","id":89887,"node_id":"MDQ6VXNlcjg5ODg3","avatar_url":"https://avatars3.githubusercontent.com/u/89887?v=4","gravatar_id":"","url":"https://api.github.com/users/dsebastien","html_url":"https://github.com/dsebastien","followers_url":"https://api.github.com/users/dsebastien/followers","following_url":"https://api.github.com/users/dsebastien/following{/other_user}","gists_url":"https://api.github.com/users/dsebastien/gists{/gist_id}","starred_url":"https://api.github.com/users/dsebastien/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dsebastien/subscriptions","organizations_url":"https://api.github.com/users/dsebastien/orgs","repos_url":"https://api.github.com/users/dsebastien/repos","events_url":"https://api.github.com/users/dsebastien/events{/privacy}","received_events_url":"https://api.github.com/users/dsebastien/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":140,"deletions":54,"changed_files":10}}
{"actor":{"display_login":"dsebastien"}}