{"action":"created","issue":{"url":"https://api.github.com/repos/haskell/cabal/issues/5446","repository_url":"https://api.github.com/repos/haskell/cabal","labels_url":"https://api.github.com/repos/haskell/cabal/issues/5446/labels{/name}","comments_url":"https://api.github.com/repos/haskell/cabal/issues/5446/comments","events_url":"https://api.github.com/repos/haskell/cabal/issues/5446/events","html_url":"https://github.com/haskell/cabal/pull/5446","id":342522184,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyNDAzOTQ1","number":5446,"title":"Add `--enable-executable-static` flag for fully static linking","user":{"login":"nh2","id":399535,"node_id":"MDQ6VXNlcjM5OTUzNQ==","avatar_url":"https://avatars1.githubusercontent.com/u/399535?v=4","gravatar_id":"","url":"https://api.github.com/users/nh2","html_url":"https://github.com/nh2","followers_url":"https://api.github.com/users/nh2/followers","following_url":"https://api.github.com/users/nh2/following{/other_user}","gists_url":"https://api.github.com/users/nh2/gists{/gist_id}","starred_url":"https://api.github.com/users/nh2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nh2/subscriptions","organizations_url":"https://api.github.com/users/nh2/orgs","repos_url":"https://api.github.com/users/nh2/repos","events_url":"https://api.github.com/users/nh2/events{/privacy}","received_events_url":"https://api.github.com/users/nh2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":11,"created_at":"2018-07-18T23:06:40Z","updated_at":"2018-12-06T08:47:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/haskell/cabal/pulls/5446","html_url":"https://github.com/haskell/cabal/pull/5446","diff_url":"https://github.com/haskell/cabal/pull/5446.diff","patch_url":"https://github.com/haskell/cabal/pull/5446.patch"},"body":"Fixes #391.\r\n\r\nAlso update the docs for `--enable-executable-dynamic`\r\nas they were slightly misleading.\r\n\r\nPlease include the following checklist in your PR:\r\n\r\n* [X] Patches conform to the [coding conventions](https://github.com/haskell/cabal/#conventions).\r\n* [X] Any changes that could be relevant to users have been recorded in the changelog.\r\n* [X] The documentation has been updated, if necessary.\r\n* [ ] If the change is docs-only, `[ci skip]` is used to avoid triggering the build bots.\r\n\r\nPlease also shortly describe how you tested your change. Bonus points for added tests!\r\n\r\n* I tested this by successfully building a big project (`stack`) with `musl` via nix using this new flag\r\n\r\n---\r\n\r\n### My TODO list I kept when writing this code:\r\n\r\n- [x] check if handling of `withFullyStaticExe` in `Cabal/Distribution/Simple/GHCJS.hs` is necessary (consider ocurrences of `withDynExe`)\r\n  - @nh2 thinks not\r\n- exclusiveness checks:\r\n  - [x] how to ensure that `withFullyStaticExe` and `withDynExe` in `LocalBuildInfo` are mutually exclusive?\r\n    - done\r\n  - [ ] how to ensure that `configFullyStaticExe` and `configDynExe` in `ConfigFlags` are mutually exclusive?\r\n  - [ ] add tests for the above\r\n    - would appreciate feedback where those should go; can I even do that in Cabal's test suite if I need e.g. `musl` to test it?\r\n\r\nInputs appreciated for the above."},"comment":{"url":"https://api.github.com/repos/haskell/cabal/issues/comments/444794283","html_url":"https://github.com/haskell/cabal/pull/5446#issuecomment-444794283","issue_url":"https://api.github.com/repos/haskell/cabal/issues/5446","id":444794283,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NDc5NDI4Mw==","user":{"login":"23Skidoo","id":47439,"node_id":"MDQ6VXNlcjQ3NDM5","avatar_url":"https://avatars3.githubusercontent.com/u/47439?v=4","gravatar_id":"","url":"https://api.github.com/users/23Skidoo","html_url":"https://github.com/23Skidoo","followers_url":"https://api.github.com/users/23Skidoo/followers","following_url":"https://api.github.com/users/23Skidoo/following{/other_user}","gists_url":"https://api.github.com/users/23Skidoo/gists{/gist_id}","starred_url":"https://api.github.com/users/23Skidoo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/23Skidoo/subscriptions","organizations_url":"https://api.github.com/users/23Skidoo/orgs","repos_url":"https://api.github.com/users/23Skidoo/repos","events_url":"https://api.github.com/users/23Skidoo/events{/privacy}","received_events_url":"https://api.github.com/users/23Skidoo/received_events","type":"User","site_admin":false},"created_at":"2018-12-06T08:47:52Z","updated_at":"2018-12-06T08:47:52Z","author_association":"MEMBER","body":"@nh2 I tried rebasing, and it didn't require manual intervention, but put the changelog note into the 2.4.0.0 section."}}
{"actor":{"display_login":"23Skidoo"}}