{"action":"created","comment":{"url":"https://api.github.com/repos/PaperMC/Paper/pulls/comments/224940912","pull_request_review_id":164440934,"id":224940912,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDk0MDkxMg==","diff_hunk":"@@ -0,0 +1,148 @@\n+From 1694e2ab433eae0411d0e1f3bcc9edfd2486e7dc Mon Sep 17 00:00:00 2001\n+From: wherkamp <wherkamp@kingtux.me>\n+Date: Fri, 12 Oct 2018 19:47:26 -0400\n+Subject: [PATCH] small improvements\n+\n+\n+diff --git a/src/main/java/org/bukkit/ChatColor.java b/src/main/java/org/bukkit/ChatColor.java\n+index adbae51a..ed33077c 100644\n+--- a/src/main/java/org/bukkit/ChatColor.java\n++++ b/src/main/java/org/bukkit/ChatColor.java\n+@@ -215,6 +215,9 @@ public enum ChatColor{\n+      * you need to dynamically convert colour codes from your custom format.\n+      */\n+     public static final char COLOR_CHAR = '\\u00A7';\n++    //Paper Start\n++    public static final char DEFAULT_COLOR_CODE = '&';\n++    //Paper End\n+     private static final Pattern STRIP_COLOR_PATTERN = Pattern.compile(\"(?i)\" + String.valueOf(COLOR_CHAR) + \"[0-9A-FK-OR]\");\n+ \n+     private final int intCode;\n+@@ -330,6 +333,18 @@ public enum ChatColor{\n+         }\n+         return new String(b);\n+     }\n++    /**\n++     * Translates a string using an alternate color code character into a\n++     * string that uses the internal ChatColor.COLOR_CODE color code\n++     * character. The alternate color code character will only be replaced if\n++     * it is immediately followed by 0-9, A-F, a-f, K-O, k-o, R or r.\n++     *\n++     * @param textToTranslate Text containing the alternate color code character.\n++     * @return Text containing the ChatColor.COLOR_CODE color code character.\n++     */\n++    public static String translateAlternateColorCodes(String textToTranslate) {\n++        return translateAlternateColorCodes(DEFAULT_COLOR_CODE, textToTranslate);\n++    }\n+ \n+     /**\n+      * Gets the ChatColors used at the end of the given input string.\n+diff --git a/src/main/java/org/bukkit/plugin/java/PluginClassLoader.java b/src/main/java/org/bukkit/plugin/java/PluginClassLoader.java\n+index ab79b71b..12aaf13a 100644\n+--- a/src/main/java/org/bukkit/plugin/java/PluginClassLoader.java\n++++ b/src/main/java/org/bukkit/plugin/java/PluginClassLoader.java\n+@@ -1,30 +1,33 @@\n+ package org.bukkit.plugin.java;\n+ \n+ import com.google.common.io.ByteStreams;\n++import org.apache.commons.lang.Validate;\n++import org.bukkit.plugin.InvalidPluginException;\n++import org.bukkit.plugin.PluginDescriptionFile;\n++\n+ import java.io.File;\n+ import java.io.IOException;\n+ import java.io.InputStream;\n++import java.lang.reflect.InvocationTargetException;\n+ import java.net.MalformedURLException;\n+ import java.net.URL;\n+ import java.net.URLClassLoader;\n+ import java.security.CodeSigner;\n+ import java.security.CodeSource;\n+-import java.util.HashMap;\n+ import java.util.Map;\n+ import java.util.Set;\n+ import java.util.jar.JarEntry;\n+ import java.util.jar.JarFile;\n+ import java.util.jar.Manifest;\n+ \n+-import org.apache.commons.lang.Validate;\n+-import org.bukkit.plugin.InvalidPluginException;\n+-import org.bukkit.plugin.PluginDescriptionFile;\n+-\n+ /**\n+  * A ClassLoader for plugins, to allow shared classes across multiple plugins\n+  */\n+ public final class PluginClassLoader extends URLClassLoader { // Spigot\n+-    public JavaPlugin getPlugin() { return plugin; } // Spigot","path":"Spigot-API-Patches/0164-small-improvements.patch","position":76,"original_position":76,"commit_id":"554cfded6d84a94f19693ff00741c1152da18256","original_commit_id":"554cfded6d84a94f19693ff00741c1152da18256","user":{"login":"astei","id":16436212,"node_id":"MDQ6VXNlcjE2NDM2MjEy","avatar_url":"https://avatars0.githubusercontent.com/u/16436212?v=4","gravatar_id":"","url":"https://api.github.com/users/astei","html_url":"https://github.com/astei","followers_url":"https://api.github.com/users/astei/followers","following_url":"https://api.github.com/users/astei/following{/other_user}","gists_url":"https://api.github.com/users/astei/gists{/gist_id}","starred_url":"https://api.github.com/users/astei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/astei/subscriptions","organizations_url":"https://api.github.com/users/astei/orgs","repos_url":"https://api.github.com/users/astei/repos","events_url":"https://api.github.com/users/astei/events{/privacy}","received_events_url":"https://api.github.com/users/astei/received_events","type":"User","site_admin":false},"body":"Formatting change that isn't needed.","created_at":"2018-10-13T00:00:15Z","updated_at":"2018-10-13T00:01:50Z","html_url":"https://github.com/PaperMC/Paper/pull/1568#discussion_r224940912","pull_request_url":"https://api.github.com/repos/PaperMC/Paper/pulls/1568","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/comments/224940912"},"html":{"href":"https://github.com/PaperMC/Paper/pull/1568#discussion_r224940912"},"pull_request":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/1568"}}},"pull_request":{"url":"https://api.github.com/repos/PaperMC/Paper/pulls/1568","id":222612619,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyNjEyNjE5","html_url":"https://github.com/PaperMC/Paper/pull/1568","diff_url":"https://github.com/PaperMC/Paper/pull/1568.diff","patch_url":"https://github.com/PaperMC/Paper/pull/1568.patch","issue_url":"https://api.github.com/repos/PaperMC/Paper/issues/1568","number":1568,"state":"open","locked":false,"title":"Small Changes","user":{"login":"wherkamp","id":11785959,"node_id":"MDQ6VXNlcjExNzg1OTU5","avatar_url":"https://avatars3.githubusercontent.com/u/11785959?v=4","gravatar_id":"","url":"https://api.github.com/users/wherkamp","html_url":"https://github.com/wherkamp","followers_url":"https://api.github.com/users/wherkamp/followers","following_url":"https://api.github.com/users/wherkamp/following{/other_user}","gists_url":"https://api.github.com/users/wherkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/wherkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wherkamp/subscriptions","organizations_url":"https://api.github.com/users/wherkamp/orgs","repos_url":"https://api.github.com/users/wherkamp/repos","events_url":"https://api.github.com/users/wherkamp/events{/privacy}","received_events_url":"https://api.github.com/users/wherkamp/received_events","type":"User","site_admin":false},"body":"I am not sure how to exactly do this. \r\n\r\nWhy should this happen?\r\nA. Class.newInstance is deprecated\r\nB. ChatColor.translateAlternateColorCodes(\"&1Is Easy :)\"); I questioned making DEFAULT_COLOR_CODE editable so it can be different depending on what the Server Owner wanted? Or you could do ChatColor.DEFAULT_COLOR_CODE = '!'; if you wanted it changed? ","created_at":"2018-10-12T23:57:33Z","updated_at":"2018-10-13T00:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80d7a8e8a4ff7d563751cfcad28cc6767442d600","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PaperMC/Paper/pulls/1568/commits","review_comments_url":"https://api.github.com/repos/PaperMC/Paper/pulls/1568/comments","review_comment_url":"https://api.github.com/repos/PaperMC/Paper/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PaperMC/Paper/issues/1568/comments","statuses_url":"https://api.github.com/repos/PaperMC/Paper/statuses/554cfded6d84a94f19693ff00741c1152da18256","head":{"label":"wherkamp:master","ref":"master","sha":"554cfded6d84a94f19693ff00741c1152da18256","user":{"login":"wherkamp","id":11785959,"node_id":"MDQ6VXNlcjExNzg1OTU5","avatar_url":"https://avatars3.githubusercontent.com/u/11785959?v=4","gravatar_id":"","url":"https://api.github.com/users/wherkamp","html_url":"https://github.com/wherkamp","followers_url":"https://api.github.com/users/wherkamp/followers","following_url":"https://api.github.com/users/wherkamp/following{/other_user}","gists_url":"https://api.github.com/users/wherkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/wherkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wherkamp/subscriptions","organizations_url":"https://api.github.com/users/wherkamp/orgs","repos_url":"https://api.github.com/users/wherkamp/repos","events_url":"https://api.github.com/users/wherkamp/events{/privacy}","received_events_url":"https://api.github.com/users/wherkamp/received_events","type":"User","site_admin":false},"repo":{"id":152817338,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI4MTczMzg=","name":"Paper","full_name":"wherkamp/Paper","private":false,"owner":{"login":"wherkamp","id":11785959,"node_id":"MDQ6VXNlcjExNzg1OTU5","avatar_url":"https://avatars3.githubusercontent.com/u/11785959?v=4","gravatar_id":"","url":"https://api.github.com/users/wherkamp","html_url":"https://github.com/wherkamp","followers_url":"https://api.github.com/users/wherkamp/followers","following_url":"https://api.github.com/users/wherkamp/following{/other_user}","gists_url":"https://api.github.com/users/wherkamp/gists{/gist_id}","starred_url":"https://api.github.com/users/wherkamp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wherkamp/subscriptions","organizations_url":"https://api.github.com/users/wherkamp/orgs","repos_url":"https://api.github.com/users/wherkamp/repos","events_url":"https://api.github.com/users/wherkamp/events{/privacy}","received_events_url":"https://api.github.com/users/wherkamp/received_events","type":"User","site_admin":false},"html_url":"https://github.com/wherkamp/Paper","description":"High performance Spigot fork that aims to fix gameplay and mechanics inconsistencies","fork":true,"url":"https://api.github.com/repos/wherkamp/Paper","forks_url":"https://api.github.com/repos/wherkamp/Paper/forks","keys_url":"https://api.github.com/repos/wherkamp/Paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wherkamp/Paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wherkamp/Paper/teams","hooks_url":"https://api.github.com/repos/wherkamp/Paper/hooks","issue_events_url":"https://api.github.com/repos/wherkamp/Paper/issues/events{/number}","events_url":"https://api.github.com/repos/wherkamp/Paper/events","assignees_url":"https://api.github.com/repos/wherkamp/Paper/assignees{/user}","branches_url":"https://api.github.com/repos/wherkamp/Paper/branches{/branch}","tags_url":"https://api.github.com/repos/wherkamp/Paper/tags","blobs_url":"https://api.github.com/repos/wherkamp/Paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wherkamp/Paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wherkamp/Paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/wherkamp/Paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wherkamp/Paper/statuses/{sha}","languages_url":"https://api.github.com/repos/wherkamp/Paper/languages","stargazers_url":"https://api.github.com/repos/wherkamp/Paper/stargazers","contributors_url":"https://api.github.com/repos/wherkamp/Paper/contributors","subscribers_url":"https://api.github.com/repos/wherkamp/Paper/subscribers","subscription_url":"https://api.github.com/repos/wherkamp/Paper/subscription","commits_url":"https://api.github.com/repos/wherkamp/Paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/wherkamp/Paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/wherkamp/Paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/wherkamp/Paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/wherkamp/Paper/contents/{+path}","compare_url":"https://api.github.com/repos/wherkamp/Paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wherkamp/Paper/merges","archive_url":"https://api.github.com/repos/wherkamp/Paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wherkamp/Paper/downloads","issues_url":"https://api.github.com/repos/wherkamp/Paper/issues{/number}","pulls_url":"https://api.github.com/repos/wherkamp/Paper/pulls{/number}","milestones_url":"https://api.github.com/repos/wherkamp/Paper/milestones{/number}","notifications_url":"https://api.github.com/repos/wherkamp/Paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wherkamp/Paper/labels{/name}","releases_url":"https://api.github.com/repos/wherkamp/Paper/releases{/id}","deployments_url":"https://api.github.com/repos/wherkamp/Paper/deployments","created_at":"2018-10-12T23:27:57Z","updated_at":"2018-10-12T23:52:56Z","pushed_at":"2018-10-12T23:52:54Z","git_url":"git://github.com/wherkamp/Paper.git","ssh_url":"git@github.com:wherkamp/Paper.git","clone_url":"https://github.com/wherkamp/Paper.git","svn_url":"https://github.com/wherkamp/Paper","homepage":"https://papermc.io/","size":14667,"stargazers_count":0,"watchers_count":0,"language":"Shell","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"PaperMC:master","ref":"master","sha":"c4c9984906fce65feacb931e45eebb348b6b0e07","user":{"login":"PaperMC","id":7608950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDg5NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7608950?v=4","gravatar_id":"","url":"https://api.github.com/users/PaperMC","html_url":"https://github.com/PaperMC","followers_url":"https://api.github.com/users/PaperMC/followers","following_url":"https://api.github.com/users/PaperMC/following{/other_user}","gists_url":"https://api.github.com/users/PaperMC/gists{/gist_id}","starred_url":"https://api.github.com/users/PaperMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaperMC/subscriptions","organizations_url":"https://api.github.com/users/PaperMC/orgs","repos_url":"https://api.github.com/users/PaperMC/repos","events_url":"https://api.github.com/users/PaperMC/events{/privacy}","received_events_url":"https://api.github.com/users/PaperMC/received_events","type":"Organization","site_admin":false},"repo":{"id":50160261,"node_id":"MDEwOlJlcG9zaXRvcnk1MDE2MDI2MQ==","name":"Paper","full_name":"PaperMC/Paper","private":false,"owner":{"login":"PaperMC","id":7608950,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc2MDg5NTA=","avatar_url":"https://avatars2.githubusercontent.com/u/7608950?v=4","gravatar_id":"","url":"https://api.github.com/users/PaperMC","html_url":"https://github.com/PaperMC","followers_url":"https://api.github.com/users/PaperMC/followers","following_url":"https://api.github.com/users/PaperMC/following{/other_user}","gists_url":"https://api.github.com/users/PaperMC/gists{/gist_id}","starred_url":"https://api.github.com/users/PaperMC/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PaperMC/subscriptions","organizations_url":"https://api.github.com/users/PaperMC/orgs","repos_url":"https://api.github.com/users/PaperMC/repos","events_url":"https://api.github.com/users/PaperMC/events{/privacy}","received_events_url":"https://api.github.com/users/PaperMC/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PaperMC/Paper","description":"High performance Spigot fork that aims to fix gameplay and mechanics inconsistencies","fork":false,"url":"https://api.github.com/repos/PaperMC/Paper","forks_url":"https://api.github.com/repos/PaperMC/Paper/forks","keys_url":"https://api.github.com/repos/PaperMC/Paper/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PaperMC/Paper/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PaperMC/Paper/teams","hooks_url":"https://api.github.com/repos/PaperMC/Paper/hooks","issue_events_url":"https://api.github.com/repos/PaperMC/Paper/issues/events{/number}","events_url":"https://api.github.com/repos/PaperMC/Paper/events","assignees_url":"https://api.github.com/repos/PaperMC/Paper/assignees{/user}","branches_url":"https://api.github.com/repos/PaperMC/Paper/branches{/branch}","tags_url":"https://api.github.com/repos/PaperMC/Paper/tags","blobs_url":"https://api.github.com/repos/PaperMC/Paper/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PaperMC/Paper/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PaperMC/Paper/git/refs{/sha}","trees_url":"https://api.github.com/repos/PaperMC/Paper/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PaperMC/Paper/statuses/{sha}","languages_url":"https://api.github.com/repos/PaperMC/Paper/languages","stargazers_url":"https://api.github.com/repos/PaperMC/Paper/stargazers","contributors_url":"https://api.github.com/repos/PaperMC/Paper/contributors","subscribers_url":"https://api.github.com/repos/PaperMC/Paper/subscribers","subscription_url":"https://api.github.com/repos/PaperMC/Paper/subscription","commits_url":"https://api.github.com/repos/PaperMC/Paper/commits{/sha}","git_commits_url":"https://api.github.com/repos/PaperMC/Paper/git/commits{/sha}","comments_url":"https://api.github.com/repos/PaperMC/Paper/comments{/number}","issue_comment_url":"https://api.github.com/repos/PaperMC/Paper/issues/comments{/number}","contents_url":"https://api.github.com/repos/PaperMC/Paper/contents/{+path}","compare_url":"https://api.github.com/repos/PaperMC/Paper/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PaperMC/Paper/merges","archive_url":"https://api.github.com/repos/PaperMC/Paper/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PaperMC/Paper/downloads","issues_url":"https://api.github.com/repos/PaperMC/Paper/issues{/number}","pulls_url":"https://api.github.com/repos/PaperMC/Paper/pulls{/number}","milestones_url":"https://api.github.com/repos/PaperMC/Paper/milestones{/number}","notifications_url":"https://api.github.com/repos/PaperMC/Paper/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PaperMC/Paper/labels{/name}","releases_url":"https://api.github.com/repos/PaperMC/Paper/releases{/id}","deployments_url":"https://api.github.com/repos/PaperMC/Paper/deployments","created_at":"2016-01-22T05:40:19Z","updated_at":"2018-10-12T23:07:36Z","pushed_at":"2018-10-12T23:57:33Z","git_url":"git://github.com/PaperMC/Paper.git","ssh_url":"git@github.com:PaperMC/Paper.git","clone_url":"https://github.com/PaperMC/Paper.git","svn_url":"https://github.com/PaperMC/Paper","homepage":"https://papermc.io/","size":14688,"stargazers_count":477,"watchers_count":477,"language":"Shell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":229,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":229,"open_issues":83,"watchers":477,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/1568"},"html":{"href":"https://github.com/PaperMC/Paper/pull/1568"},"issue":{"href":"https://api.github.com/repos/PaperMC/Paper/issues/1568"},"comments":{"href":"https://api.github.com/repos/PaperMC/Paper/issues/1568/comments"},"review_comments":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/1568/comments"},"review_comment":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PaperMC/Paper/pulls/1568/commits"},"statuses":{"href":"https://api.github.com/repos/PaperMC/Paper/statuses/554cfded6d84a94f19693ff00741c1152da18256"}},"author_association":"NONE"}}
{"actor":{"display_login":"astei"}}