{"action":"created","issue":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28936","repository_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped","labels_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28936/labels{/name}","comments_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28936/comments","events_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28936/events","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28936","id":360796429,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1OTI3MTgy","number":28936,"title":"[react-dom] there is no type named `Text`","user":{"login":"JounQin","id":8336744,"node_id":"MDQ6VXNlcjgzMzY3NDQ=","avatar_url":"https://avatars3.githubusercontent.com/u/8336744?v=4","gravatar_id":"","url":"https://api.github.com/users/JounQin","html_url":"https://github.com/JounQin","followers_url":"https://api.github.com/users/JounQin/followers","following_url":"https://api.github.com/users/JounQin/following{/other_user}","gists_url":"https://api.github.com/users/JounQin/gists{/gist_id}","starred_url":"https://api.github.com/users/JounQin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JounQin/subscriptions","organizations_url":"https://api.github.com/users/JounQin/orgs","repos_url":"https://api.github.com/users/JounQin/repos","events_url":"https://api.github.com/users/JounQin/events{/privacy}","received_events_url":"https://api.github.com/users/JounQin/received_events","type":"User","site_admin":false},"labels":[{"id":397523192,"node_id":"MDU6TGFiZWwzOTc1MjMxOTI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Awaiting%20reviewer%20feedback","name":"Awaiting reviewer feedback","color":"0052cc","default":false},{"id":644095882,"node_id":"MDU6TGFiZWw2NDQwOTU4ODI=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Merge:YSYL","name":"Merge:YSYL","color":"bfdadc","default":false},{"id":684321576,"node_id":"MDU6TGFiZWw2ODQzMjE1NzY=","url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/labels/Popular%20package","name":"Popular package","color":"fbca04","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-09-17T09:57:24Z","updated_at":"2018-10-05T17:58:07Z","closed_at":"2018-09-26T20:28:20Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/pulls/28936","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28936","diff_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28936.diff","patch_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28936.patch"},"body":"It should be string instead.\r\n\r\nPlease fill in this template.\r\n\r\n- [x] Use a meaningful title for the pull request. Include the name of the package modified.\r\n- [x] Test the change in your own code. (Compile and run.)\r\n- [ ] Add or edit tests to reflect the change. (Run with `npm test`.)\r\n- [x] Follow the advice from the [readme](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#make-a-pull-request).\r\n- [x] Avoid [common mistakes](https://github.com/DefinitelyTyped/DefinitelyTyped/blob/master/README.md#common-mistakes).\r\n- [x] Run `npm run lint package-name` (or `tsc` if no `tslint.json` is present).\r\n\r\nSelect one of these and delete the others:\r\n\r\nIf adding a new definition:\r\n- [ ] The package does not already provide its own types, or cannot have its `.d.ts` files generated via `--declaration`\r\n- [ ] If this is for an NPM package, match the name. If not, do not conflict with the name of an NPM package.\r\n- [ ] Create it with `dts-gen --dt`, not by basing it on an existing project.\r\n- [ ] `tslint.json` should be present, and `tsconfig.json` should have `noImplicitAny`, `noImplicitThis`, `strictNullChecks`, and `strictFunctionTypes` set to `true`.\r\n\r\nIf changing an existing definition:\r\n- [ ] Provide a URL to documentation or source code which provides context for the suggested changes: <<url here>>\r\n- [ ] Increase the version number in the header if appropriate.\r\n- [ ] If you are making substantial changes, consider adding a `tslint.json` containing `{ \"extends\": \"dtslint/dt.json\" }`.\r\n\r\nIf removing a declaration:\r\n- [ ] If a package was never on DefinitelyTyped, you don't need to do anything. (If you wrote a package and provided types, you don't need to register it with us.)\r\n- [ ] Delete the package's directory.\r\n- [ ] Add it to `notNeededPackages.json`.\r\n"},"comment":{"url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/comments/427449252","html_url":"https://github.com/DefinitelyTyped/DefinitelyTyped/pull/28936#issuecomment-427449252","issue_url":"https://api.github.com/repos/DefinitelyTyped/DefinitelyTyped/issues/28936","id":427449252,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNzQ0OTI1Mg==","user":{"login":"meyer","id":13781,"node_id":"MDQ6VXNlcjEzNzgx","avatar_url":"https://avatars1.githubusercontent.com/u/13781?v=4","gravatar_id":"","url":"https://api.github.com/users/meyer","html_url":"https://github.com/meyer","followers_url":"https://api.github.com/users/meyer/followers","following_url":"https://api.github.com/users/meyer/following{/other_user}","gists_url":"https://api.github.com/users/meyer/gists{/gist_id}","starred_url":"https://api.github.com/users/meyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/meyer/subscriptions","organizations_url":"https://api.github.com/users/meyer/orgs","repos_url":"https://api.github.com/users/meyer/repos","events_url":"https://api.github.com/users/meyer/events{/privacy}","received_events_url":"https://api.github.com/users/meyer/received_events","type":"User","site_admin":false},"created_at":"2018-10-05T17:58:07Z","updated_at":"2018-10-05T17:58:07Z","author_association":"NONE","body":"@JounQin I don’t think this is correct. The return type for `ReactDOM.findDOMNode` is either `null`, an `Element`, or a `Text` _element_:\r\n\r\nhttps://github.com/facebook/react/blob/0dc0ddc/packages/react-dom/src/client/ReactDOM.js#L591-L593\r\n\r\n`string` is not equivalent to a `Text` element.\r\n\r\nFlow types for `Text` element:\r\n\r\nhttps://github.com/facebook/flow/blob/08f8548/lib/dom.js#L3613-L3618"}}
{"actor":{"display_login":"meyer"}}