{"action":"closed","number":115,"pull_request":{"url":"https://api.github.com/repos/code-squad/javascript-json/pulls/115","id":231456348,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxNDU2MzQ4","html_url":"https://github.com/code-squad/javascript-json/pull/115","diff_url":"https://github.com/code-squad/javascript-json/pull/115.diff","patch_url":"https://github.com/code-squad/javascript-json/pull/115.patch","issue_url":"https://api.github.com/repos/code-squad/javascript-json/issues/115","number":115,"state":"closed","locked":false,"title":"lec4-Step5.객체 Type","user":{"login":"HTMLhead","id":40166539,"node_id":"MDQ6VXNlcjQwMTY2NTM5","avatar_url":"https://avatars0.githubusercontent.com/u/40166539?v=4","gravatar_id":"","url":"https://api.github.com/users/HTMLhead","html_url":"https://github.com/HTMLhead","followers_url":"https://api.github.com/users/HTMLhead/followers","following_url":"https://api.github.com/users/HTMLhead/following{/other_user}","gists_url":"https://api.github.com/users/HTMLhead/gists{/gist_id}","starred_url":"https://api.github.com/users/HTMLhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTMLhead/subscriptions","organizations_url":"https://api.github.com/users/HTMLhead/orgs","repos_url":"https://api.github.com/users/HTMLhead/repos","events_url":"https://api.github.com/users/HTMLhead/events{/privacy}","received_events_url":"https://api.github.com/users/HTMLhead/received_events","type":"User","site_admin":false},"body":"* 코드맥락\r\n 1. 객체타입 데이터의 key값과 value값을 나누어 제이슨데이터객체를 만들도록 하였습니다. \r\n 1. ErrorCheck클래스 내에 오류를 체크하는 함수가 실행될 때, 오류메세지를 출력할 수 있도록 하였습니다.\r\n\r\n* 노력한 점\r\n 1. 객체타입을 어떻게 변환시켜야 할 지 고민을 많이 했습니다.\r\n\r\n* 궁금한 점\r\n 1. getChild함수가 제가보기엔 복잡한 것 같습니다. 그런데 이 함수를 어떻게 어떤 기준으로 뜯어나가야 할지 잘 모르겠습니다. \r\n\r\n🆘 피드백 부탁드립니다!!\r\n","created_at":"2018-11-16T08:52:20Z","updated_at":"2018-11-18T15:10:19Z","closed_at":"2018-11-18T15:10:19Z","merged_at":"2018-11-18T15:10:19Z","merge_commit_sha":"e3e980a8230c97a646069bb2db5054e2c47ba6a5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/code-squad/javascript-json/pulls/115/commits","review_comments_url":"https://api.github.com/repos/code-squad/javascript-json/pulls/115/comments","review_comment_url":"https://api.github.com/repos/code-squad/javascript-json/pulls/comments{/number}","comments_url":"https://api.github.com/repos/code-squad/javascript-json/issues/115/comments","statuses_url":"https://api.github.com/repos/code-squad/javascript-json/statuses/e922b9ecd9c0e672b2c35d30f94f42a887870083","head":{"label":"HTMLhead:step5","ref":"step5","sha":"e922b9ecd9c0e672b2c35d30f94f42a887870083","user":{"login":"HTMLhead","id":40166539,"node_id":"MDQ6VXNlcjQwMTY2NTM5","avatar_url":"https://avatars0.githubusercontent.com/u/40166539?v=4","gravatar_id":"","url":"https://api.github.com/users/HTMLhead","html_url":"https://github.com/HTMLhead","followers_url":"https://api.github.com/users/HTMLhead/followers","following_url":"https://api.github.com/users/HTMLhead/following{/other_user}","gists_url":"https://api.github.com/users/HTMLhead/gists{/gist_id}","starred_url":"https://api.github.com/users/HTMLhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTMLhead/subscriptions","organizations_url":"https://api.github.com/users/HTMLhead/orgs","repos_url":"https://api.github.com/users/HTMLhead/repos","events_url":"https://api.github.com/users/HTMLhead/events{/privacy}","received_events_url":"https://api.github.com/users/HTMLhead/received_events","type":"User","site_admin":false},"repo":{"id":154443045,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ0NDMwNDU=","name":"javascript-json","full_name":"HTMLhead/javascript-json","private":false,"owner":{"login":"HTMLhead","id":40166539,"node_id":"MDQ6VXNlcjQwMTY2NTM5","avatar_url":"https://avatars0.githubusercontent.com/u/40166539?v=4","gravatar_id":"","url":"https://api.github.com/users/HTMLhead","html_url":"https://github.com/HTMLhead","followers_url":"https://api.github.com/users/HTMLhead/followers","following_url":"https://api.github.com/users/HTMLhead/following{/other_user}","gists_url":"https://api.github.com/users/HTMLhead/gists{/gist_id}","starred_url":"https://api.github.com/users/HTMLhead/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HTMLhead/subscriptions","organizations_url":"https://api.github.com/users/HTMLhead/orgs","repos_url":"https://api.github.com/users/HTMLhead/repos","events_url":"https://api.github.com/users/HTMLhead/events{/privacy}","received_events_url":"https://api.github.com/users/HTMLhead/received_events","type":"User","site_admin":false},"html_url":"https://github.com/HTMLhead/javascript-json","description":"레벨2","fork":true,"url":"https://api.github.com/repos/HTMLhead/javascript-json","forks_url":"https://api.github.com/repos/HTMLhead/javascript-json/forks","keys_url":"https://api.github.com/repos/HTMLhead/javascript-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HTMLhead/javascript-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HTMLhead/javascript-json/teams","hooks_url":"https://api.github.com/repos/HTMLhead/javascript-json/hooks","issue_events_url":"https://api.github.com/repos/HTMLhead/javascript-json/issues/events{/number}","events_url":"https://api.github.com/repos/HTMLhead/javascript-json/events","assignees_url":"https://api.github.com/repos/HTMLhead/javascript-json/assignees{/user}","branches_url":"https://api.github.com/repos/HTMLhead/javascript-json/branches{/branch}","tags_url":"https://api.github.com/repos/HTMLhead/javascript-json/tags","blobs_url":"https://api.github.com/repos/HTMLhead/javascript-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HTMLhead/javascript-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HTMLhead/javascript-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/HTMLhead/javascript-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HTMLhead/javascript-json/statuses/{sha}","languages_url":"https://api.github.com/repos/HTMLhead/javascript-json/languages","stargazers_url":"https://api.github.com/repos/HTMLhead/javascript-json/stargazers","contributors_url":"https://api.github.com/repos/HTMLhead/javascript-json/contributors","subscribers_url":"https://api.github.com/repos/HTMLhead/javascript-json/subscribers","subscription_url":"https://api.github.com/repos/HTMLhead/javascript-json/subscription","commits_url":"https://api.github.com/repos/HTMLhead/javascript-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/HTMLhead/javascript-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/HTMLhead/javascript-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/HTMLhead/javascript-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/HTMLhead/javascript-json/contents/{+path}","compare_url":"https://api.github.com/repos/HTMLhead/javascript-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HTMLhead/javascript-json/merges","archive_url":"https://api.github.com/repos/HTMLhead/javascript-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HTMLhead/javascript-json/downloads","issues_url":"https://api.github.com/repos/HTMLhead/javascript-json/issues{/number}","pulls_url":"https://api.github.com/repos/HTMLhead/javascript-json/pulls{/number}","milestones_url":"https://api.github.com/repos/HTMLhead/javascript-json/milestones{/number}","notifications_url":"https://api.github.com/repos/HTMLhead/javascript-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HTMLhead/javascript-json/labels{/name}","releases_url":"https://api.github.com/repos/HTMLhead/javascript-json/releases{/id}","deployments_url":"https://api.github.com/repos/HTMLhead/javascript-json/deployments","created_at":"2018-10-24T05:16:38Z","updated_at":"2018-11-12T02:43:53Z","pushed_at":"2018-11-16T08:31:23Z","git_url":"git://github.com/HTMLhead/javascript-json.git","ssh_url":"git@github.com:HTMLhead/javascript-json.git","clone_url":"https://github.com/HTMLhead/javascript-json.git","svn_url":"https://github.com/HTMLhead/javascript-json","homepage":"","size":6547,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"code-squad:HTMLhead","ref":"HTMLhead","sha":"e3d2a197208363b57f909c8dc24c321f40d70d66","user":{"login":"code-squad","id":22832280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODMyMjgw","avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"repo":{"id":107010155,"node_id":"MDEwOlJlcG9zaXRvcnkxMDcwMTAxNTU=","name":"javascript-json","full_name":"code-squad/javascript-json","private":false,"owner":{"login":"code-squad","id":22832280,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODMyMjgw","avatar_url":"https://avatars2.githubusercontent.com/u/22832280?v=4","gravatar_id":"","url":"https://api.github.com/users/code-squad","html_url":"https://github.com/code-squad","followers_url":"https://api.github.com/users/code-squad/followers","following_url":"https://api.github.com/users/code-squad/following{/other_user}","gists_url":"https://api.github.com/users/code-squad/gists{/gist_id}","starred_url":"https://api.github.com/users/code-squad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/code-squad/subscriptions","organizations_url":"https://api.github.com/users/code-squad/orgs","repos_url":"https://api.github.com/users/code-squad/repos","events_url":"https://api.github.com/users/code-squad/events{/privacy}","received_events_url":"https://api.github.com/users/code-squad/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/code-squad/javascript-json","description":"레벨2","fork":false,"url":"https://api.github.com/repos/code-squad/javascript-json","forks_url":"https://api.github.com/repos/code-squad/javascript-json/forks","keys_url":"https://api.github.com/repos/code-squad/javascript-json/keys{/key_id}","collaborators_url":"https://api.github.com/repos/code-squad/javascript-json/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/code-squad/javascript-json/teams","hooks_url":"https://api.github.com/repos/code-squad/javascript-json/hooks","issue_events_url":"https://api.github.com/repos/code-squad/javascript-json/issues/events{/number}","events_url":"https://api.github.com/repos/code-squad/javascript-json/events","assignees_url":"https://api.github.com/repos/code-squad/javascript-json/assignees{/user}","branches_url":"https://api.github.com/repos/code-squad/javascript-json/branches{/branch}","tags_url":"https://api.github.com/repos/code-squad/javascript-json/tags","blobs_url":"https://api.github.com/repos/code-squad/javascript-json/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/code-squad/javascript-json/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/code-squad/javascript-json/git/refs{/sha}","trees_url":"https://api.github.com/repos/code-squad/javascript-json/git/trees{/sha}","statuses_url":"https://api.github.com/repos/code-squad/javascript-json/statuses/{sha}","languages_url":"https://api.github.com/repos/code-squad/javascript-json/languages","stargazers_url":"https://api.github.com/repos/code-squad/javascript-json/stargazers","contributors_url":"https://api.github.com/repos/code-squad/javascript-json/contributors","subscribers_url":"https://api.github.com/repos/code-squad/javascript-json/subscribers","subscription_url":"https://api.github.com/repos/code-squad/javascript-json/subscription","commits_url":"https://api.github.com/repos/code-squad/javascript-json/commits{/sha}","git_commits_url":"https://api.github.com/repos/code-squad/javascript-json/git/commits{/sha}","comments_url":"https://api.github.com/repos/code-squad/javascript-json/comments{/number}","issue_comment_url":"https://api.github.com/repos/code-squad/javascript-json/issues/comments{/number}","contents_url":"https://api.github.com/repos/code-squad/javascript-json/contents/{+path}","compare_url":"https://api.github.com/repos/code-squad/javascript-json/compare/{base}...{head}","merges_url":"https://api.github.com/repos/code-squad/javascript-json/merges","archive_url":"https://api.github.com/repos/code-squad/javascript-json/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/code-squad/javascript-json/downloads","issues_url":"https://api.github.com/repos/code-squad/javascript-json/issues{/number}","pulls_url":"https://api.github.com/repos/code-squad/javascript-json/pulls{/number}","milestones_url":"https://api.github.com/repos/code-squad/javascript-json/milestones{/number}","notifications_url":"https://api.github.com/repos/code-squad/javascript-json/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/code-squad/javascript-json/labels{/name}","releases_url":"https://api.github.com/repos/code-squad/javascript-json/releases{/id}","deployments_url":"https://api.github.com/repos/code-squad/javascript-json/deployments","created_at":"2017-10-15T12:28:38Z","updated_at":"2018-03-13T05:43:41Z","pushed_at":"2018-11-18T15:10:19Z","git_url":"git://github.com/code-squad/javascript-json.git","ssh_url":"git@github.com:code-squad/javascript-json.git","clone_url":"https://github.com/code-squad/javascript-json.git","svn_url":"https://github.com/code-squad/javascript-json","homepage":null,"size":6665,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":22,"mirror_url":null,"archived":false,"open_issues_count":4,"license":null,"forks":22,"open_issues":4,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/115"},"html":{"href":"https://github.com/code-squad/javascript-json/pull/115"},"issue":{"href":"https://api.github.com/repos/code-squad/javascript-json/issues/115"},"comments":{"href":"https://api.github.com/repos/code-squad/javascript-json/issues/115/comments"},"review_comments":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/115/comments"},"review_comment":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/code-squad/javascript-json/pulls/115/commits"},"statuses":{"href":"https://api.github.com/repos/code-squad/javascript-json/statuses/e922b9ecd9c0e672b2c35d30f94f42a887870083"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"nigayo","id":1456761,"node_id":"MDQ6VXNlcjE0NTY3NjE=","avatar_url":"https://avatars2.githubusercontent.com/u/1456761?v=4","gravatar_id":"","url":"https://api.github.com/users/nigayo","html_url":"https://github.com/nigayo","followers_url":"https://api.github.com/users/nigayo/followers","following_url":"https://api.github.com/users/nigayo/following{/other_user}","gists_url":"https://api.github.com/users/nigayo/gists{/gist_id}","starred_url":"https://api.github.com/users/nigayo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nigayo/subscriptions","organizations_url":"https://api.github.com/users/nigayo/orgs","repos_url":"https://api.github.com/users/nigayo/repos","events_url":"https://api.github.com/users/nigayo/events{/privacy}","received_events_url":"https://api.github.com/users/nigayo/received_events","type":"User","site_admin":false},"comments":0,"review_comments":3,"maintainer_can_modify":false,"commits":32,"additions":69,"deletions":35,"changed_files":2}}
{"actor":{"display_login":"nigayo"}}