{"action":"created","issue":{"url":"https://api.github.com/repos/nos/client/issues/342","repository_url":"https://api.github.com/repos/nos/client","labels_url":"https://api.github.com/repos/nos/client/issues/342/labels{/name}","comments_url":"https://api.github.com/repos/nos/client/issues/342/comments","events_url":"https://api.github.com/repos/nos/client/issues/342/events","html_url":"https://github.com/nos/client/issues/342","id":343415276,"node_id":"MDU6SXNzdWUzNDM0MTUyNzY=","number":342,"title":"Separate sessions by account address","user":{"login":"mhuggins","id":169093,"node_id":"MDQ6VXNlcjE2OTA5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169093?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false},"labels":[{"id":835230502,"node_id":"MDU6TGFiZWw4MzUyMzA1MDI=","url":"https://api.github.com/repos/nos/client/labels/enhancement","name":"enhancement","color":"a2eeef","default":true},{"id":919543250,"node_id":"MDU6TGFiZWw5MTk1NDMyNTA=","url":"https://api.github.com/repos/nos/client/labels/team%20issue","name":"team issue","color":"3f6ba8","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/nos/client/milestones/5","html_url":"https://github.com/nos/client/milestone/5","labels_url":"https://api.github.com/repos/nos/client/milestones/5/labels","id":3697681,"node_id":"MDk6TWlsZXN0b25lMzY5NzY4MQ==","number":5,"title":"0.5.0","description":"","creator":{"login":"mhuggins","id":169093,"node_id":"MDQ6VXNlcjE2OTA5Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/169093?v=4","gravatar_id":"","url":"https://api.github.com/users/mhuggins","html_url":"https://github.com/mhuggins","followers_url":"https://api.github.com/users/mhuggins/followers","following_url":"https://api.github.com/users/mhuggins/following{/other_user}","gists_url":"https://api.github.com/users/mhuggins/gists{/gist_id}","starred_url":"https://api.github.com/users/mhuggins/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhuggins/subscriptions","organizations_url":"https://api.github.com/users/mhuggins/orgs","repos_url":"https://api.github.com/users/mhuggins/repos","events_url":"https://api.github.com/users/mhuggins/events{/privacy}","received_events_url":"https://api.github.com/users/mhuggins/received_events","type":"User","site_admin":false},"open_issues":19,"closed_issues":8,"state":"open","created_at":"2018-09-28T22:22:49Z","updated_at":"2018-11-16T15:01:16Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-07-22T15:33:34Z","updated_at":"2018-11-16T15:02:01Z","closed_at":null,"author_association":"MEMBER","body":"## Describe the solution you'd like and the expected behavior\r\nIf the same client is used for multiple addresses, then separate sessions should be used.\r\n\r\n## Is your feature request related to a problem? Please describe.\r\nSwitching between addresses maintains a session from a prior address, which is not ideal for security and privacy reasons.\r\n\r\n## Possible implementation / References\r\nThe `webview` element provides a [`partition` attribute](https://electronjs.org/docs/api/webview-tag#partition), which could be set to the currently authenticated NEO address.\r\n\r\nBefore doing so, some research should be done to ensure that the session can't easily be spoofed by simply changing the redux store to a different address in memory.  One option might be to use a hash based upon the private key, as long as the existing partitions can't be determined by looking through chrome/electron cache files."},"comment":{"url":"https://api.github.com/repos/nos/client/issues/comments/439420117","html_url":"https://github.com/nos/client/issues/342#issuecomment-439420117","issue_url":"https://api.github.com/repos/nos/client/issues/342","id":439420117,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTQyMDExNw==","user":{"login":"deanpress","id":31391056,"node_id":"MDQ6VXNlcjMxMzkxMDU2","avatar_url":"https://avatars1.githubusercontent.com/u/31391056?v=4","gravatar_id":"","url":"https://api.github.com/users/deanpress","html_url":"https://github.com/deanpress","followers_url":"https://api.github.com/users/deanpress/followers","following_url":"https://api.github.com/users/deanpress/following{/other_user}","gists_url":"https://api.github.com/users/deanpress/gists{/gist_id}","starred_url":"https://api.github.com/users/deanpress/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deanpress/subscriptions","organizations_url":"https://api.github.com/users/deanpress/orgs","repos_url":"https://api.github.com/users/deanpress/repos","events_url":"https://api.github.com/users/deanpress/events{/privacy}","received_events_url":"https://api.github.com/users/deanpress/received_events","type":"User","site_admin":false},"created_at":"2018-11-16T15:02:01Z","updated_at":"2018-11-16T15:02:01Z","author_association":"MEMBER","body":"Anonymous sessions should also be an option. I think this will become more readily available with this feature?"}}
{"actor":{"display_login":"deanpress"}}