{"action":"created","comment":{"url":"https://api.github.com/repos/algolia/search-insights.js/pulls/comments/237091456","pull_request_review_id":179305101,"id":237091456,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzA5MTQ1Ng==","diff_hunk":"@@ -1,123 +1,195 @@\n-import * as testServer from '../../server/server.js';\n-import AlgoliaInsights from './../insights'\n-const puppeteer = require('puppeteer');\n+import * as testServer from \"../../server/server.js\";","path":"lib/__tests__/harvest.test.ts","position":4,"original_position":4,"commit_id":"47b47c22247e18f5dcd303ee987b79ee939ce184","original_commit_id":"e0cce8bf7efdd1bb14e9be309778ec29ded4ce54","user":{"login":"Haroenv","id":6270048,"node_id":"MDQ6VXNlcjYyNzAwNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6270048?v=4","gravatar_id":"","url":"https://api.github.com/users/Haroenv","html_url":"https://github.com/Haroenv","followers_url":"https://api.github.com/users/Haroenv/followers","following_url":"https://api.github.com/users/Haroenv/following{/other_user}","gists_url":"https://api.github.com/users/Haroenv/gists{/gist_id}","starred_url":"https://api.github.com/users/Haroenv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haroenv/subscriptions","organizations_url":"https://api.github.com/users/Haroenv/orgs","repos_url":"https://api.github.com/users/Haroenv/repos","events_url":"https://api.github.com/users/Haroenv/events{/privacy}","received_events_url":"https://api.github.com/users/Haroenv/received_events","type":"User","site_admin":false},"body":"can you remove this diff from this PR and do it in #20 instead? (or maybe merge that one before we review this one)","created_at":"2018-11-28T13:53:12Z","updated_at":"2018-11-28T13:53:12Z","html_url":"https://github.com/algolia/search-insights.js/pull/19#discussion_r237091456","pull_request_url":"https://api.github.com/repos/algolia/search-insights.js/pulls/19","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/algolia/search-insights.js/pulls/comments/237091456"},"html":{"href":"https://github.com/algolia/search-insights.js/pull/19#discussion_r237091456"},"pull_request":{"href":"https://api.github.com/repos/algolia/search-insights.js/pulls/19"}},"in_reply_to_id":236790196},"pull_request":{"url":"https://api.github.com/repos/algolia/search-insights.js/pulls/19","id":233658350,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzNjU4MzUw","html_url":"https://github.com/algolia/search-insights.js/pull/19","diff_url":"https://github.com/algolia/search-insights.js/pull/19.diff","patch_url":"https://github.com/algolia/search-insights.js/pull/19.patch","issue_url":"https://api.github.com/repos/algolia/search-insights.js/issues/19","number":19,"state":"open","locked":false,"title":"feat(v2): update endpoint","user":{"login":"tkrugg","id":2982512,"node_id":"MDQ6VXNlcjI5ODI1MTI=","avatar_url":"https://avatars3.githubusercontent.com/u/2982512?v=4","gravatar_id":"","url":"https://api.github.com/users/tkrugg","html_url":"https://github.com/tkrugg","followers_url":"https://api.github.com/users/tkrugg/followers","following_url":"https://api.github.com/users/tkrugg/following{/other_user}","gists_url":"https://api.github.com/users/tkrugg/gists{/gist_id}","starred_url":"https://api.github.com/users/tkrugg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tkrugg/subscriptions","organizations_url":"https://api.github.com/users/tkrugg/orgs","repos_url":"https://api.github.com/users/tkrugg/repos","events_url":"https://api.github.com/users/tkrugg/events{/privacy}","received_events_url":"https://api.github.com/users/tkrugg/received_events","type":"User","site_admin":false},"body":"- changed endpoint to `/1/events/`\r\n- introduced sendBulkEvents that formats the payload according to new spec\r\n\r\nOther minor changes: \r\n- removed unused .search method\r\n- updated tests to reflect changes \r\n- added body-parser as it to have been missing in the dependencies","created_at":"2018-11-26T18:43:25Z","updated_at":"2018-11-28T13:53:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0fc4e51f62ab03fb961eccb6025cffe1b37e65dc","assignee":null,"assignees":[],"requested_reviewers":[{"login":"francoischalifour","id":6137112,"node_id":"MDQ6VXNlcjYxMzcxMTI=","avatar_url":"https://avatars3.githubusercontent.com/u/6137112?v=4","gravatar_id":"","url":"https://api.github.com/users/francoischalifour","html_url":"https://github.com/francoischalifour","followers_url":"https://api.github.com/users/francoischalifour/followers","following_url":"https://api.github.com/users/francoischalifour/following{/other_user}","gists_url":"https://api.github.com/users/francoischalifour/gists{/gist_id}","starred_url":"https://api.github.com/users/francoischalifour/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/francoischalifour/subscriptions","organizations_url":"https://api.github.com/users/francoischalifour/orgs","repos_url":"https://api.github.com/users/francoischalifour/repos","events_url":"https://api.github.com/users/francoischalifour/events{/privacy}","received_events_url":"https://api.github.com/users/francoischalifour/received_events","type":"User","site_admin":false},{"login":"Haroenv","id":6270048,"node_id":"MDQ6VXNlcjYyNzAwNDg=","avatar_url":"https://avatars3.githubusercontent.com/u/6270048?v=4","gravatar_id":"","url":"https://api.github.com/users/Haroenv","html_url":"https://github.com/Haroenv","followers_url":"https://api.github.com/users/Haroenv/followers","following_url":"https://api.github.com/users/Haroenv/following{/other_user}","gists_url":"https://api.github.com/users/Haroenv/gists{/gist_id}","starred_url":"https://api.github.com/users/Haroenv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Haroenv/subscriptions","organizations_url":"https://api.github.com/users/Haroenv/orgs","repos_url":"https://api.github.com/users/Haroenv/repos","events_url":"https://api.github.com/users/Haroenv/events{/privacy}","received_events_url":"https://api.github.com/users/Haroenv/received_events","type":"User","site_admin":false},{"login":"samouss","id":6513513,"node_id":"MDQ6VXNlcjY1MTM1MTM=","avatar_url":"https://avatars2.githubusercontent.com/u/6513513?v=4","gravatar_id":"","url":"https://api.github.com/users/samouss","html_url":"https://github.com/samouss","followers_url":"https://api.github.com/users/samouss/followers","following_url":"https://api.github.com/users/samouss/following{/other_user}","gists_url":"https://api.github.com/users/samouss/gists{/gist_id}","starred_url":"https://api.github.com/users/samouss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samouss/subscriptions","organizations_url":"https://api.github.com/users/samouss/orgs","repos_url":"https://api.github.com/users/samouss/repos","events_url":"https://api.github.com/users/samouss/events{/privacy}","received_events_url":"https://api.github.com/users/samouss/received_events","type":"User","site_admin":false},{"login":"JonasBa","id":9317857,"node_id":"MDQ6VXNlcjkzMTc4NTc=","avatar_url":"https://avatars3.githubusercontent.com/u/9317857?v=4","gravatar_id":"","url":"https://api.github.com/users/JonasBa","html_url":"https://github.com/JonasBa","followers_url":"https://api.github.com/users/JonasBa/followers","following_url":"https://api.github.com/users/JonasBa/following{/other_user}","gists_url":"https://api.github.com/users/JonasBa/gists{/gist_id}","starred_url":"https://api.github.com/users/JonasBa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonasBa/subscriptions","organizations_url":"https://api.github.com/users/JonasBa/orgs","repos_url":"https://api.github.com/users/JonasBa/repos","events_url":"https://api.github.com/users/JonasBa/events{/privacy}","received_events_url":"https://api.github.com/users/JonasBa/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/algolia/search-insights.js/pulls/19/commits","review_comments_url":"https://api.github.com/repos/algolia/search-insights.js/pulls/19/comments","review_comment_url":"https://api.github.com/repos/algolia/search-insights.js/pulls/comments{/number}","comments_url":"https://api.github.com/repos/algolia/search-insights.js/issues/19/comments","statuses_url":"https://api.github.com/repos/algolia/search-insights.js/statuses/47b47c22247e18f5dcd303ee987b79ee939ce184","head":{"label":"algolia:v2/wip","ref":"v2/wip","sha":"47b47c22247e18f5dcd303ee987b79ee939ce184","user":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":120300805,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDA4MDU=","name":"search-insights.js","full_name":"algolia/search-insights.js","private":false,"owner":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/algolia/search-insights.js","description":null,"fork":false,"url":"https://api.github.com/repos/algolia/search-insights.js","forks_url":"https://api.github.com/repos/algolia/search-insights.js/forks","keys_url":"https://api.github.com/repos/algolia/search-insights.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/search-insights.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/search-insights.js/teams","hooks_url":"https://api.github.com/repos/algolia/search-insights.js/hooks","issue_events_url":"https://api.github.com/repos/algolia/search-insights.js/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/search-insights.js/events","assignees_url":"https://api.github.com/repos/algolia/search-insights.js/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/search-insights.js/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/search-insights.js/tags","blobs_url":"https://api.github.com/repos/algolia/search-insights.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/search-insights.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/search-insights.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/search-insights.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/search-insights.js/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/search-insights.js/languages","stargazers_url":"https://api.github.com/repos/algolia/search-insights.js/stargazers","contributors_url":"https://api.github.com/repos/algolia/search-insights.js/contributors","subscribers_url":"https://api.github.com/repos/algolia/search-insights.js/subscribers","subscription_url":"https://api.github.com/repos/algolia/search-insights.js/subscription","commits_url":"https://api.github.com/repos/algolia/search-insights.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/search-insights.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/search-insights.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/search-insights.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/search-insights.js/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/search-insights.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/search-insights.js/merges","archive_url":"https://api.github.com/repos/algolia/search-insights.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/search-insights.js/downloads","issues_url":"https://api.github.com/repos/algolia/search-insights.js/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/search-insights.js/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/search-insights.js/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/search-insights.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/search-insights.js/labels{/name}","releases_url":"https://api.github.com/repos/algolia/search-insights.js/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/search-insights.js/deployments","created_at":"2018-02-05T12:19:05Z","updated_at":"2018-11-27T14:43:56Z","pushed_at":"2018-11-28T13:41:14Z","git_url":"git://github.com/algolia/search-insights.js.git","ssh_url":"git@github.com:algolia/search-insights.js.git","clone_url":"https://github.com/algolia/search-insights.js.git","svn_url":"https://github.com/algolia/search-insights.js","homepage":null,"size":353,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":6,"watchers":6,"default_branch":"develop"}},"base":{"label":"algolia:develop","ref":"develop","sha":"519dbcb7cd67fb128d07704c654d8010fbb84bd4","user":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"repo":{"id":120300805,"node_id":"MDEwOlJlcG9zaXRvcnkxMjAzMDA4MDU=","name":"search-insights.js","full_name":"algolia/search-insights.js","private":false,"owner":{"login":"algolia","id":2034458,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwMzQ0NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2034458?v=4","gravatar_id":"","url":"https://api.github.com/users/algolia","html_url":"https://github.com/algolia","followers_url":"https://api.github.com/users/algolia/followers","following_url":"https://api.github.com/users/algolia/following{/other_user}","gists_url":"https://api.github.com/users/algolia/gists{/gist_id}","starred_url":"https://api.github.com/users/algolia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/algolia/subscriptions","organizations_url":"https://api.github.com/users/algolia/orgs","repos_url":"https://api.github.com/users/algolia/repos","events_url":"https://api.github.com/users/algolia/events{/privacy}","received_events_url":"https://api.github.com/users/algolia/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/algolia/search-insights.js","description":null,"fork":false,"url":"https://api.github.com/repos/algolia/search-insights.js","forks_url":"https://api.github.com/repos/algolia/search-insights.js/forks","keys_url":"https://api.github.com/repos/algolia/search-insights.js/keys{/key_id}","collaborators_url":"https://api.github.com/repos/algolia/search-insights.js/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/algolia/search-insights.js/teams","hooks_url":"https://api.github.com/repos/algolia/search-insights.js/hooks","issue_events_url":"https://api.github.com/repos/algolia/search-insights.js/issues/events{/number}","events_url":"https://api.github.com/repos/algolia/search-insights.js/events","assignees_url":"https://api.github.com/repos/algolia/search-insights.js/assignees{/user}","branches_url":"https://api.github.com/repos/algolia/search-insights.js/branches{/branch}","tags_url":"https://api.github.com/repos/algolia/search-insights.js/tags","blobs_url":"https://api.github.com/repos/algolia/search-insights.js/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/algolia/search-insights.js/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/algolia/search-insights.js/git/refs{/sha}","trees_url":"https://api.github.com/repos/algolia/search-insights.js/git/trees{/sha}","statuses_url":"https://api.github.com/repos/algolia/search-insights.js/statuses/{sha}","languages_url":"https://api.github.com/repos/algolia/search-insights.js/languages","stargazers_url":"https://api.github.com/repos/algolia/search-insights.js/stargazers","contributors_url":"https://api.github.com/repos/algolia/search-insights.js/contributors","subscribers_url":"https://api.github.com/repos/algolia/search-insights.js/subscribers","subscription_url":"https://api.github.com/repos/algolia/search-insights.js/subscription","commits_url":"https://api.github.com/repos/algolia/search-insights.js/commits{/sha}","git_commits_url":"https://api.github.com/repos/algolia/search-insights.js/git/commits{/sha}","comments_url":"https://api.github.com/repos/algolia/search-insights.js/comments{/number}","issue_comment_url":"https://api.github.com/repos/algolia/search-insights.js/issues/comments{/number}","contents_url":"https://api.github.com/repos/algolia/search-insights.js/contents/{+path}","compare_url":"https://api.github.com/repos/algolia/search-insights.js/compare/{base}...{head}","merges_url":"https://api.github.com/repos/algolia/search-insights.js/merges","archive_url":"https://api.github.com/repos/algolia/search-insights.js/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/algolia/search-insights.js/downloads","issues_url":"https://api.github.com/repos/algolia/search-insights.js/issues{/number}","pulls_url":"https://api.github.com/repos/algolia/search-insights.js/pulls{/number}","milestones_url":"https://api.github.com/repos/algolia/search-insights.js/milestones{/number}","notifications_url":"https://api.github.com/repos/algolia/search-insights.js/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/algolia/search-insights.js/labels{/name}","releases_url":"https://api.github.com/repos/algolia/search-insights.js/releases{/id}","deployments_url":"https://api.github.com/repos/algolia/search-insights.js/deployments","created_at":"2018-02-05T12:19:05Z","updated_at":"2018-11-27T14:43:56Z","pushed_at":"2018-11-28T13:41:14Z","git_url":"git://github.com/algolia/search-insights.js.git","ssh_url":"git@github.com:algolia/search-insights.js.git","clone_url":"https://github.com/algolia/search-insights.js.git","svn_url":"https://github.com/algolia/search-insights.js","homepage":null,"size":353,"stargazers_count":6,"watchers_count":6,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":2,"open_issues":6,"watchers":6,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/algolia/search-insights.js/pulls/19"},"html":{"href":"https://github.com/algolia/search-insights.js/pull/19"},"issue":{"href":"https://api.github.com/repos/algolia/search-insights.js/issues/19"},"comments":{"href":"https://api.github.com/repos/algolia/search-insights.js/issues/19/comments"},"review_comments":{"href":"https://api.github.com/repos/algolia/search-insights.js/pulls/19/comments"},"review_comment":{"href":"https://api.github.com/repos/algolia/search-insights.js/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/algolia/search-insights.js/pulls/19/commits"},"statuses":{"href":"https://api.github.com/repos/algolia/search-insights.js/statuses/47b47c22247e18f5dcd303ee987b79ee939ce184"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"Haroenv"}}