{"action":"created","comment":{"url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/comments/244409548","pull_request_review_id":188370872,"id":244409548,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQwOTU0OA==","diff_hunk":"@@ -0,0 +1,14 @@\n+class AnswersController < ApplicationController\n+  def answer\n+    @question = Question.find(params[:question])","path":"app/controllers/answers_controller.rb","position":3,"original_position":3,"commit_id":"0b1ca1f719afa051a35e1337748d16a140cebf81","original_commit_id":"0b1ca1f719afa051a35e1337748d16a140cebf81","user":{"login":"iliabylich","id":1265492,"node_id":"MDQ6VXNlcjEyNjU0OTI=","avatar_url":"https://avatars3.githubusercontent.com/u/1265492?v=4","gravatar_id":"","url":"https://api.github.com/users/iliabylich","html_url":"https://github.com/iliabylich","followers_url":"https://api.github.com/users/iliabylich/followers","following_url":"https://api.github.com/users/iliabylich/following{/other_user}","gists_url":"https://api.github.com/users/iliabylich/gists{/gist_id}","starred_url":"https://api.github.com/users/iliabylich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iliabylich/subscriptions","organizations_url":"https://api.github.com/users/iliabylich/orgs","repos_url":"https://api.github.com/users/iliabylich/repos","events_url":"https://api.github.com/users/iliabylich/events{/privacy}","received_events_url":"https://api.github.com/users/iliabylich/received_events","type":"User","site_admin":false},"body":"1. You don't need instance variables anymore.\r\n2. `is_*` is not the right name in the Ruby world (for both method names and variables). Also `right` feels a bit weird, how about just `correct`?\r\n3. Names of your parameters are semantically incorrect. `question` -> `question_id`, `ans` -> `answer`, `test` -> `test_id`. Don't forget to apply corresponding changes to your form","created_at":"2018-12-28T21:17:44Z","updated_at":"2018-12-28T21:33:32Z","html_url":"https://github.com/jekapulpit/knowledge-tracker/pull/4#discussion_r244409548","pull_request_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/4","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/comments/244409548"},"html":{"href":"https://github.com/jekapulpit/knowledge-tracker/pull/4#discussion_r244409548"},"pull_request":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/4"}}},"pull_request":{"url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/4","id":241193175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMTkzMTc1","html_url":"https://github.com/jekapulpit/knowledge-tracker/pull/4","diff_url":"https://github.com/jekapulpit/knowledge-tracker/pull/4.diff","patch_url":"https://github.com/jekapulpit/knowledge-tracker/pull/4.patch","issue_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues/4","number":4,"state":"open","locked":false,"title":"Profile","user":{"login":"jekapulpit","id":31817365,"node_id":"MDQ6VXNlcjMxODE3MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/31817365?v=4","gravatar_id":"","url":"https://api.github.com/users/jekapulpit","html_url":"https://github.com/jekapulpit","followers_url":"https://api.github.com/users/jekapulpit/followers","following_url":"https://api.github.com/users/jekapulpit/following{/other_user}","gists_url":"https://api.github.com/users/jekapulpit/gists{/gist_id}","starred_url":"https://api.github.com/users/jekapulpit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekapulpit/subscriptions","organizations_url":"https://api.github.com/users/jekapulpit/orgs","repos_url":"https://api.github.com/users/jekapulpit/repos","events_url":"https://api.github.com/users/jekapulpit/events{/privacy}","received_events_url":"https://api.github.com/users/jekapulpit/received_events","type":"User","site_admin":false},"body":"i did the most important features like passing tests and adding technology to user\r\n\r\n","created_at":"2018-12-27T17:18:56Z","updated_at":"2018-12-28T21:33:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c468564521bc57afdd1ea5cc99a3faea4b4df2c9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/4/commits","review_comments_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/4/comments","review_comment_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues/4/comments","statuses_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/statuses/0b1ca1f719afa051a35e1337748d16a140cebf81","head":{"label":"jekapulpit:profile","ref":"profile","sha":"0b1ca1f719afa051a35e1337748d16a140cebf81","user":{"login":"jekapulpit","id":31817365,"node_id":"MDQ6VXNlcjMxODE3MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/31817365?v=4","gravatar_id":"","url":"https://api.github.com/users/jekapulpit","html_url":"https://github.com/jekapulpit","followers_url":"https://api.github.com/users/jekapulpit/followers","following_url":"https://api.github.com/users/jekapulpit/following{/other_user}","gists_url":"https://api.github.com/users/jekapulpit/gists{/gist_id}","starred_url":"https://api.github.com/users/jekapulpit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekapulpit/subscriptions","organizations_url":"https://api.github.com/users/jekapulpit/orgs","repos_url":"https://api.github.com/users/jekapulpit/repos","events_url":"https://api.github.com/users/jekapulpit/events{/privacy}","received_events_url":"https://api.github.com/users/jekapulpit/received_events","type":"User","site_admin":false},"repo":{"id":159955222,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk5NTUyMjI=","name":"knowledge-tracker","full_name":"jekapulpit/knowledge-tracker","private":false,"owner":{"login":"jekapulpit","id":31817365,"node_id":"MDQ6VXNlcjMxODE3MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/31817365?v=4","gravatar_id":"","url":"https://api.github.com/users/jekapulpit","html_url":"https://github.com/jekapulpit","followers_url":"https://api.github.com/users/jekapulpit/followers","following_url":"https://api.github.com/users/jekapulpit/following{/other_user}","gists_url":"https://api.github.com/users/jekapulpit/gists{/gist_id}","starred_url":"https://api.github.com/users/jekapulpit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekapulpit/subscriptions","organizations_url":"https://api.github.com/users/jekapulpit/orgs","repos_url":"https://api.github.com/users/jekapulpit/repos","events_url":"https://api.github.com/users/jekapulpit/events{/privacy}","received_events_url":"https://api.github.com/users/jekapulpit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jekapulpit/knowledge-tracker","description":"web-app that helps you to test your programming skills","fork":false,"url":"https://api.github.com/repos/jekapulpit/knowledge-tracker","forks_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/forks","keys_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/teams","hooks_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/hooks","issue_events_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/events","assignees_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/tags","blobs_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/languages","stargazers_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/stargazers","contributors_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/contributors","subscribers_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/subscribers","subscription_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/subscription","commits_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/merges","archive_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/downloads","issues_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/labels{/name}","releases_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/deployments","created_at":"2018-12-01T14:56:53Z","updated_at":"2018-12-18T21:00:28Z","pushed_at":"2018-12-28T20:43:20Z","git_url":"git://github.com/jekapulpit/knowledge-tracker.git","ssh_url":"git@github.com:jekapulpit/knowledge-tracker.git","clone_url":"https://github.com/jekapulpit/knowledge-tracker.git","svn_url":"https://github.com/jekapulpit/knowledge-tracker","homepage":null,"size":7453,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"jekapulpit:master","ref":"master","sha":"cc03822363195d2d434a6429045d8e3536e76ca4","user":{"login":"jekapulpit","id":31817365,"node_id":"MDQ6VXNlcjMxODE3MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/31817365?v=4","gravatar_id":"","url":"https://api.github.com/users/jekapulpit","html_url":"https://github.com/jekapulpit","followers_url":"https://api.github.com/users/jekapulpit/followers","following_url":"https://api.github.com/users/jekapulpit/following{/other_user}","gists_url":"https://api.github.com/users/jekapulpit/gists{/gist_id}","starred_url":"https://api.github.com/users/jekapulpit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekapulpit/subscriptions","organizations_url":"https://api.github.com/users/jekapulpit/orgs","repos_url":"https://api.github.com/users/jekapulpit/repos","events_url":"https://api.github.com/users/jekapulpit/events{/privacy}","received_events_url":"https://api.github.com/users/jekapulpit/received_events","type":"User","site_admin":false},"repo":{"id":159955222,"node_id":"MDEwOlJlcG9zaXRvcnkxNTk5NTUyMjI=","name":"knowledge-tracker","full_name":"jekapulpit/knowledge-tracker","private":false,"owner":{"login":"jekapulpit","id":31817365,"node_id":"MDQ6VXNlcjMxODE3MzY1","avatar_url":"https://avatars2.githubusercontent.com/u/31817365?v=4","gravatar_id":"","url":"https://api.github.com/users/jekapulpit","html_url":"https://github.com/jekapulpit","followers_url":"https://api.github.com/users/jekapulpit/followers","following_url":"https://api.github.com/users/jekapulpit/following{/other_user}","gists_url":"https://api.github.com/users/jekapulpit/gists{/gist_id}","starred_url":"https://api.github.com/users/jekapulpit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jekapulpit/subscriptions","organizations_url":"https://api.github.com/users/jekapulpit/orgs","repos_url":"https://api.github.com/users/jekapulpit/repos","events_url":"https://api.github.com/users/jekapulpit/events{/privacy}","received_events_url":"https://api.github.com/users/jekapulpit/received_events","type":"User","site_admin":false},"html_url":"https://github.com/jekapulpit/knowledge-tracker","description":"web-app that helps you to test your programming skills","fork":false,"url":"https://api.github.com/repos/jekapulpit/knowledge-tracker","forks_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/forks","keys_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/teams","hooks_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/hooks","issue_events_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues/events{/number}","events_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/events","assignees_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/assignees{/user}","branches_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/branches{/branch}","tags_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/tags","blobs_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/refs{/sha}","trees_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/statuses/{sha}","languages_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/languages","stargazers_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/stargazers","contributors_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/contributors","subscribers_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/subscribers","subscription_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/subscription","commits_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/commits{/sha}","git_commits_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/git/commits{/sha}","comments_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/comments{/number}","issue_comment_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues/comments{/number}","contents_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/contents/{+path}","compare_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/merges","archive_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/downloads","issues_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues{/number}","pulls_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls{/number}","milestones_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/milestones{/number}","notifications_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/labels{/name}","releases_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/releases{/id}","deployments_url":"https://api.github.com/repos/jekapulpit/knowledge-tracker/deployments","created_at":"2018-12-01T14:56:53Z","updated_at":"2018-12-18T21:00:28Z","pushed_at":"2018-12-28T20:43:20Z","git_url":"git://github.com/jekapulpit/knowledge-tracker.git","ssh_url":"git@github.com:jekapulpit/knowledge-tracker.git","clone_url":"https://github.com/jekapulpit/knowledge-tracker.git","svn_url":"https://github.com/jekapulpit/knowledge-tracker","homepage":null,"size":7453,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":null,"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/4"},"html":{"href":"https://github.com/jekapulpit/knowledge-tracker/pull/4"},"issue":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues/4"},"comments":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/issues/4/comments"},"review_comments":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/4/comments"},"review_comment":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/pulls/4/commits"},"statuses":{"href":"https://api.github.com/repos/jekapulpit/knowledge-tracker/statuses/0b1ca1f719afa051a35e1337748d16a140cebf81"}},"author_association":"OWNER"}}
{"actor":{"display_login":"iliabylich"}}