{"action":"closed","number":338,"pull_request":{"url":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls/338","id":171494319,"html_url":"https://github.com/coreos/alb-ingress-controller/pull/338","diff_url":"https://github.com/coreos/alb-ingress-controller/pull/338.diff","patch_url":"https://github.com/coreos/alb-ingress-controller/pull/338.patch","issue_url":"https://api.github.com/repos/coreos/alb-ingress-controller/issues/338","number":338,"state":"closed","locked":false,"title":"empty attributes bug fix","user":{"login":"r0fls","id":1858004,"avatar_url":"https://avatars1.githubusercontent.com/u/1858004?v=4","gravatar_id":"","url":"https://api.github.com/users/r0fls","html_url":"https://github.com/r0fls","followers_url":"https://api.github.com/users/r0fls/followers","following_url":"https://api.github.com/users/r0fls/following{/other_user}","gists_url":"https://api.github.com/users/r0fls/gists{/gist_id}","starred_url":"https://api.github.com/users/r0fls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0fls/subscriptions","organizations_url":"https://api.github.com/users/r0fls/orgs","repos_url":"https://api.github.com/users/r0fls/repos","events_url":"https://api.github.com/users/r0fls/events{/privacy}","received_events_url":"https://api.github.com/users/r0fls/received_events","type":"User","site_admin":false},"body":"After the changes to allow modifying ALB attributes, there is a bug that leads to a segfault when the attributes are empty in certain cases. Particularly this was observed when there was an invalid FQDN:\r\n\r\n```\r\npanic: runtime error: invalid memory address or nil pointer dereference\r\n[signal SIGSEGV: segmentation violation code=0x1 addr=0x30 pc=0x15f38be]\r\n\r\ngoroutine 2839 [running]:\r\ngithub.com/coreos/alb-ingress-controller/pkg/alb/listeners.Listeners.Reconcile(0xc42000c940, 0x1, 0x1, 0xc4214d9ed8, 0xc42000c558, 0x1, 0x1, 0xc42000c538, 0x1)\r\n        /home/travis/gopath/src/github.com/coreos/alb-ingress-controller/pkg/alb/listeners/listeners.go:53 +0x18e\r\ngithub.com/coreos/alb-ingress-controller/pkg/alb/loadbalancer.(*LoadBalancer).Reconcile(0xc422885680, 0xc4214d9f60, 0xc42288e838, 0x7f56650db000, 0x0)\r\n        /home/travis/gopath/src/github.com/coreos/alb-ingress-controller/pkg/alb/loadbalancer/loadbalancer.go:233 +0x284\r\ngithub.com/coreos/alb-ingress-controller/pkg/albingress.(*ALBIngress).Reconcile(0xc4228b04d0, 0xc420029fb8)\r\n        /home/travis/gopath/src/github.com/coreos/alb-ingress-controller/pkg/albingress/albingress.go:324 +0xb4\r\ngithub.com/coreos/alb-ingress-controller/pkg/controller.(*ALBController).update.func1(0xc4202c49d0, 0xc4228b04d0)\r\n        /home/travis/gopath/src/github.com/coreos/alb-ingress-controller/pkg/controller/alb-controller.go:180 +0xa9\r\ncreated by github.com/coreos/alb-ingress-controller/pkg/controller.(*ALBController).update\r\n        /home/travis/gopath/src/github.com/coreos/alb-ingress-controller/pkg/controller/alb-controller.go:181 +0x4cd\r\n```\r\n\r\nThe segfault was only observed when there were other invalid configurations, for instance the FQDN being invalid. This explains why it didn't get noticed during validation.","created_at":"2018-02-26T21:18:24Z","updated_at":"2018-02-26T21:20:34Z","closed_at":"2018-02-26T21:20:34Z","merged_at":"2018-02-26T21:20:34Z","merge_commit_sha":"5907a6048fe86f35efa85f669fb8d04b6a1c7a43","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls/338/commits","review_comments_url":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls/338/comments","review_comment_url":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/coreos/alb-ingress-controller/issues/338/comments","statuses_url":"https://api.github.com/repos/coreos/alb-ingress-controller/statuses/3b15d090f633c5a4aa30bc73b23cb05a70c235cc","head":{"label":"r0fls:attribute-bug-fix","ref":"attribute-bug-fix","sha":"3b15d090f633c5a4aa30bc73b23cb05a70c235cc","user":{"login":"r0fls","id":1858004,"avatar_url":"https://avatars1.githubusercontent.com/u/1858004?v=4","gravatar_id":"","url":"https://api.github.com/users/r0fls","html_url":"https://github.com/r0fls","followers_url":"https://api.github.com/users/r0fls/followers","following_url":"https://api.github.com/users/r0fls/following{/other_user}","gists_url":"https://api.github.com/users/r0fls/gists{/gist_id}","starred_url":"https://api.github.com/users/r0fls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0fls/subscriptions","organizations_url":"https://api.github.com/users/r0fls/orgs","repos_url":"https://api.github.com/users/r0fls/repos","events_url":"https://api.github.com/users/r0fls/events{/privacy}","received_events_url":"https://api.github.com/users/r0fls/received_events","type":"User","site_admin":false},"repo":{"id":111057928,"name":"alb-ingress-controller","full_name":"r0fls/alb-ingress-controller","owner":{"login":"r0fls","id":1858004,"avatar_url":"https://avatars1.githubusercontent.com/u/1858004?v=4","gravatar_id":"","url":"https://api.github.com/users/r0fls","html_url":"https://github.com/r0fls","followers_url":"https://api.github.com/users/r0fls/followers","following_url":"https://api.github.com/users/r0fls/following{/other_user}","gists_url":"https://api.github.com/users/r0fls/gists{/gist_id}","starred_url":"https://api.github.com/users/r0fls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r0fls/subscriptions","organizations_url":"https://api.github.com/users/r0fls/orgs","repos_url":"https://api.github.com/users/r0fls/repos","events_url":"https://api.github.com/users/r0fls/events{/privacy}","received_events_url":"https://api.github.com/users/r0fls/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/r0fls/alb-ingress-controller","description":"Kubernetes Ingress Controller for AWS ALB","fork":true,"url":"https://api.github.com/repos/r0fls/alb-ingress-controller","forks_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/forks","keys_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/teams","hooks_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/hooks","issue_events_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/issues/events{/number}","events_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/events","assignees_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/assignees{/user}","branches_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/branches{/branch}","tags_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/tags","blobs_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/languages","stargazers_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/stargazers","contributors_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/contributors","subscribers_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/subscribers","subscription_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/subscription","commits_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/contents/{+path}","compare_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/merges","archive_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/downloads","issues_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/issues{/number}","pulls_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/labels{/name}","releases_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/releases{/id}","deployments_url":"https://api.github.com/repos/r0fls/alb-ingress-controller/deployments","created_at":"2017-11-17T04:29:11Z","updated_at":"2017-11-17T04:29:14Z","pushed_at":"2018-02-26T21:13:54Z","git_url":"git://github.com/r0fls/alb-ingress-controller.git","ssh_url":"git@github.com:r0fls/alb-ingress-controller.git","clone_url":"https://github.com/r0fls/alb-ingress-controller.git","svn_url":"https://github.com/r0fls/alb-ingress-controller","homepage":"https://coreos.com/blog/alb-ingress-controller-intro","size":92884,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"coreos:master","ref":"master","sha":"5f0ece36b93309b49765cd2bc776bfa0f9abe55b","user":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"repo":{"id":84610043,"name":"alb-ingress-controller","full_name":"coreos/alb-ingress-controller","owner":{"login":"coreos","id":3730757,"avatar_url":"https://avatars3.githubusercontent.com/u/3730757?v=4","gravatar_id":"","url":"https://api.github.com/users/coreos","html_url":"https://github.com/coreos","followers_url":"https://api.github.com/users/coreos/followers","following_url":"https://api.github.com/users/coreos/following{/other_user}","gists_url":"https://api.github.com/users/coreos/gists{/gist_id}","starred_url":"https://api.github.com/users/coreos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coreos/subscriptions","organizations_url":"https://api.github.com/users/coreos/orgs","repos_url":"https://api.github.com/users/coreos/repos","events_url":"https://api.github.com/users/coreos/events{/privacy}","received_events_url":"https://api.github.com/users/coreos/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/coreos/alb-ingress-controller","description":"Kubernetes Ingress Controller for AWS ALB","fork":false,"url":"https://api.github.com/repos/coreos/alb-ingress-controller","forks_url":"https://api.github.com/repos/coreos/alb-ingress-controller/forks","keys_url":"https://api.github.com/repos/coreos/alb-ingress-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/coreos/alb-ingress-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/coreos/alb-ingress-controller/teams","hooks_url":"https://api.github.com/repos/coreos/alb-ingress-controller/hooks","issue_events_url":"https://api.github.com/repos/coreos/alb-ingress-controller/issues/events{/number}","events_url":"https://api.github.com/repos/coreos/alb-ingress-controller/events","assignees_url":"https://api.github.com/repos/coreos/alb-ingress-controller/assignees{/user}","branches_url":"https://api.github.com/repos/coreos/alb-ingress-controller/branches{/branch}","tags_url":"https://api.github.com/repos/coreos/alb-ingress-controller/tags","blobs_url":"https://api.github.com/repos/coreos/alb-ingress-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/coreos/alb-ingress-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/coreos/alb-ingress-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/coreos/alb-ingress-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/coreos/alb-ingress-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/coreos/alb-ingress-controller/languages","stargazers_url":"https://api.github.com/repos/coreos/alb-ingress-controller/stargazers","contributors_url":"https://api.github.com/repos/coreos/alb-ingress-controller/contributors","subscribers_url":"https://api.github.com/repos/coreos/alb-ingress-controller/subscribers","subscription_url":"https://api.github.com/repos/coreos/alb-ingress-controller/subscription","commits_url":"https://api.github.com/repos/coreos/alb-ingress-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/coreos/alb-ingress-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/coreos/alb-ingress-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/coreos/alb-ingress-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/coreos/alb-ingress-controller/contents/{+path}","compare_url":"https://api.github.com/repos/coreos/alb-ingress-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/coreos/alb-ingress-controller/merges","archive_url":"https://api.github.com/repos/coreos/alb-ingress-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/coreos/alb-ingress-controller/downloads","issues_url":"https://api.github.com/repos/coreos/alb-ingress-controller/issues{/number}","pulls_url":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/coreos/alb-ingress-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/coreos/alb-ingress-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/coreos/alb-ingress-controller/labels{/name}","releases_url":"https://api.github.com/repos/coreos/alb-ingress-controller/releases{/id}","deployments_url":"https://api.github.com/repos/coreos/alb-ingress-controller/deployments","created_at":"2017-03-10T23:45:09Z","updated_at":"2018-02-26T11:12:11Z","pushed_at":"2018-02-26T21:20:34Z","git_url":"git://github.com/coreos/alb-ingress-controller.git","ssh_url":"git@github.com:coreos/alb-ingress-controller.git","clone_url":"https://github.com/coreos/alb-ingress-controller.git","svn_url":"https://github.com/coreos/alb-ingress-controller","homepage":"https://coreos.com/blog/alb-ingress-controller-intro","size":92880,"stargazers_count":421,"watchers_count":421,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":109,"mirror_url":null,"archived":false,"open_issues_count":66,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":109,"open_issues":66,"watchers":421,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls/338"},"html":{"href":"https://github.com/coreos/alb-ingress-controller/pull/338"},"issue":{"href":"https://api.github.com/repos/coreos/alb-ingress-controller/issues/338"},"comments":{"href":"https://api.github.com/repos/coreos/alb-ingress-controller/issues/338/comments"},"review_comments":{"href":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls/338/comments"},"review_comment":{"href":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/coreos/alb-ingress-controller/pulls/338/commits"},"statuses":{"href":"https://api.github.com/repos/coreos/alb-ingress-controller/statuses/3b15d090f633c5a4aa30bc73b23cb05a70c235cc"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"bigkraig","id":508403,"avatar_url":"https://avatars1.githubusercontent.com/u/508403?v=4","gravatar_id":"","url":"https://api.github.com/users/bigkraig","html_url":"https://github.com/bigkraig","followers_url":"https://api.github.com/users/bigkraig/followers","following_url":"https://api.github.com/users/bigkraig/following{/other_user}","gists_url":"https://api.github.com/users/bigkraig/gists{/gist_id}","starred_url":"https://api.github.com/users/bigkraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigkraig/subscriptions","organizations_url":"https://api.github.com/users/bigkraig/orgs","repos_url":"https://api.github.com/users/bigkraig/repos","events_url":"https://api.github.com/users/bigkraig/events{/privacy}","received_events_url":"https://api.github.com/users/bigkraig/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":12,"deletions":9,"changed_files":1}}
{"actor":{"display_login":"bigkraig"}}