{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60466","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60466/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60466/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60466/events","html_url":"https://github.com/kubernetes/kubernetes/issues/60466","id":300453104,"number":60466,"title":"Confusion around node name: providerID, externalID ","user":{"login":"jingxu97","id":19172805,"avatar_url":"https://avatars3.githubusercontent.com/u/19172805?v=4","gravatar_id":"","url":"https://api.github.com/users/jingxu97","html_url":"https://github.com/jingxu97","followers_url":"https://api.github.com/users/jingxu97/followers","following_url":"https://api.github.com/users/jingxu97/following{/other_user}","gists_url":"https://api.github.com/users/jingxu97/gists{/gist_id}","starred_url":"https://api.github.com/users/jingxu97/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jingxu97/subscriptions","organizations_url":"https://api.github.com/users/jingxu97/orgs","repos_url":"https://api.github.com/users/jingxu97/repos","events_url":"https://api.github.com/users/jingxu97/events{/privacy}","received_events_url":"https://api.github.com/users/jingxu97/received_events","type":"User","site_admin":false},"labels":[{"id":567844235,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/node-lifecycle","name":"area/node-lifecycle","color":"0052cc","default":false},{"id":140091046,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/nodecontroller","name":"area/nodecontroller","color":"0052cc","default":false},{"id":173493665,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/node","name":"sig/node","color":"d2b48c","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-02-27T00:52:32Z","updated_at":"2018-02-27T21:59:39Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"Currently both node_controller in cloudprovider and node_life_cycle controller checks whether node exists in cloudprovider or not. They are using different ways of checking the cloudprovider.\r\nnode_controlelr: InstanceExistsByProviderID by passing node's providerID. If there is an error, it will try to use ExternalID()\r\nnode_lifecycle_controller: Uses ExternalID() by passing nodeName.\r\n\r\nHowever, according to this PR https://github.com/kubernetes/kubernetes/pull/7775, ExternalID is marked as deprecated three years ago. Should we continue to use this way?\r\n\r\ncc @yujuhong @Random-Liu "},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/369041624","html_url":"https://github.com/kubernetes/kubernetes/issues/60466#issuecomment-369041624","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/60466","id":369041624,"user":{"login":"yujuhong","id":10524058,"avatar_url":"https://avatars1.githubusercontent.com/u/10524058?v=4","gravatar_id":"","url":"https://api.github.com/users/yujuhong","html_url":"https://github.com/yujuhong","followers_url":"https://api.github.com/users/yujuhong/followers","following_url":"https://api.github.com/users/yujuhong/following{/other_user}","gists_url":"https://api.github.com/users/yujuhong/gists{/gist_id}","starred_url":"https://api.github.com/users/yujuhong/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yujuhong/subscriptions","organizations_url":"https://api.github.com/users/yujuhong/orgs","repos_url":"https://api.github.com/users/yujuhong/repos","events_url":"https://api.github.com/users/yujuhong/events{/privacy}","received_events_url":"https://api.github.com/users/yujuhong/received_events","type":"User","site_admin":false},"created_at":"2018-02-27T21:59:39Z","updated_at":"2018-02-27T21:59:39Z","author_association":"CONTRIBUTOR","body":"> However, according to this PR #7775, ExternalID is marked as deprecated three years ago. Should we continue to use this way?\r\n\r\nLooks like https://github.com/kubernetes/kubernetes/pull/7775/files#r31184254 never happened.\r\n@bgrant0607 @roberthbailey do we want to clean up the use of ExternalID in our codebase?\r\n"}}
{"actor":{"display_login":"yujuhong"}}