{"action":"created","issue":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/55450","repository_url":"https://api.github.com/repos/Microsoft/vscode","labels_url":"https://api.github.com/repos/Microsoft/vscode/issues/55450/labels{/name}","comments_url":"https://api.github.com/repos/Microsoft/vscode/issues/55450/comments","events_url":"https://api.github.com/repos/Microsoft/vscode/issues/55450/events","html_url":"https://github.com/Microsoft/vscode/issues/55450","id":346123069,"node_id":"MDU6SXNzdWUzNDYxMjMwNjk=","number":55450,"title":"Completion commits unwanted completions that don't matched typed prefixes","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"labels":[{"id":366106217,"node_id":"MDU6TGFiZWwzNjYxMDYyMTc=","url":"https://api.github.com/repos/Microsoft/vscode/labels/*duplicate","name":"*duplicate","color":"E2A1C2","default":false}],"state":"closed","locked":false,"assignee":{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false},"assignees":[{"login":"mjbvz","id":12821956,"node_id":"MDQ6VXNlcjEyODIxOTU2","avatar_url":"https://avatars2.githubusercontent.com/u/12821956?v=4","gravatar_id":"","url":"https://api.github.com/users/mjbvz","html_url":"https://github.com/mjbvz","followers_url":"https://api.github.com/users/mjbvz/followers","following_url":"https://api.github.com/users/mjbvz/following{/other_user}","gists_url":"https://api.github.com/users/mjbvz/gists{/gist_id}","starred_url":"https://api.github.com/users/mjbvz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjbvz/subscriptions","organizations_url":"https://api.github.com/users/mjbvz/orgs","repos_url":"https://api.github.com/users/mjbvz/repos","events_url":"https://api.github.com/users/mjbvz/events{/privacy}","received_events_url":"https://api.github.com/users/mjbvz/received_events","type":"User","site_admin":false}],"milestone":null,"comments":6,"created_at":"2018-07-31T10:14:48Z","updated_at":"2018-08-24T15:15:42Z","closed_at":"2018-08-24T12:59:54Z","author_association":"NONE","body":"I was writing this code that calls `sortBy` in lodash. The second argument is a function/lambda and the completion opened when I started typing a variable name. I don't want to complete here because I'm typing a new variable name - however when I pressed `,` it automatically committed, and resulted in `SSL_OP_NO_TLSv1_1` being inserted.\r\n\r\nSorry the gif is slow, happened when I converted to GIF!\r\n\r\n![completion](https://user-images.githubusercontent.com/1078012/43453646-81aeef36-94b2-11e8-8c29-ae608347e372.gif)\r\n\r\nHere the characters I typed are `matches, t1,`. The comma is a commit character in TypeScript.\r\n\r\nThis happens quite a lot and is rather frustrating. I don't think it ever makes sense to honour the commit character on a completion if the proceeding text doesn't match (or at least, it should be optional). I have a similar issue in my Dart extension and tried to solve it by only setting completion characters when the proceeding text matches, however since VS Code doesn't re-call the completion provider on every key stroke (it filters \"client-side\") this doesn't work correctly.\r\n\r\nI know I could turn probably turn this behaviour off entirely, but I think it's really useful in the right context. If I've typed `sort` and the top item is `sortBy` then pressing `(` to complete is great. What's described above however, is not. I don't *think* this is fixable in the TypeScript, I think it needs support from VS Code."},"comment":{"url":"https://api.github.com/repos/Microsoft/vscode/issues/comments/415790583","html_url":"https://github.com/Microsoft/vscode/issues/55450#issuecomment-415790583","issue_url":"https://api.github.com/repos/Microsoft/vscode/issues/55450","id":415790583,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTc5MDU4Mw==","user":{"login":"DanTup","id":1078012,"node_id":"MDQ6VXNlcjEwNzgwMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1078012?v=4","gravatar_id":"","url":"https://api.github.com/users/DanTup","html_url":"https://github.com/DanTup","followers_url":"https://api.github.com/users/DanTup/followers","following_url":"https://api.github.com/users/DanTup/following{/other_user}","gists_url":"https://api.github.com/users/DanTup/gists{/gist_id}","starred_url":"https://api.github.com/users/DanTup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DanTup/subscriptions","organizations_url":"https://api.github.com/users/DanTup/orgs","repos_url":"https://api.github.com/users/DanTup/repos","events_url":"https://api.github.com/users/DanTup/events{/privacy}","received_events_url":"https://api.github.com/users/DanTup/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T15:15:42Z","updated_at":"2018-08-24T15:15:42Z","author_association":"NONE","body":"Aha, that makes sense - I'll open an issue to see if we can get something similar back from Dart, thanks!"}}
{"actor":{"display_login":"DanTup"}}