{"action":"closed","number":166,"pull_request":{"url":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls/166","id":201469267,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDY5MjY3","html_url":"https://github.com/modoboa/modoboa-webmail/pull/166","diff_url":"https://github.com/modoboa/modoboa-webmail/pull/166.diff","patch_url":"https://github.com/modoboa/modoboa-webmail/pull/166.patch","issue_url":"https://api.github.com/repos/modoboa/modoboa-webmail/issues/166","number":166,"state":"closed","locked":false,"title":"Attachment fixes","user":{"login":"lefta","id":2159458,"node_id":"MDQ6VXNlcjIxNTk0NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2159458?v=4","gravatar_id":"","url":"https://api.github.com/users/lefta","html_url":"https://github.com/lefta","followers_url":"https://api.github.com/users/lefta/followers","following_url":"https://api.github.com/users/lefta/following{/other_user}","gists_url":"https://api.github.com/users/lefta/gists{/gist_id}","starred_url":"https://api.github.com/users/lefta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefta/subscriptions","organizations_url":"https://api.github.com/users/lefta/orgs","repos_url":"https://api.github.com/users/lefta/repos","events_url":"https://api.github.com/users/lefta/events{/privacy}","received_events_url":"https://api.github.com/users/lefta/received_events","type":"User","site_admin":false},"body":"This PR is made of three commits.\r\n\r\nThe first one is pretty straightforward. It sets `__version__` to avoid crashing in development mode with python 3.\r\n\r\nThe second one fixes a crash when uploading an attachment containing non ascii characters in its file name ( #165 ). The problem came from `rfc6266.build_header()` which returns a bytes object in this case :astonished: , making the python header builder crash. So I just decode it when it is the case.\r\n\r\nThe third one allows to upload empty attachments. I agree that there is no point in doing this, but as much as I know this is not forbidden in mail transport specifications. And the resulting error, `None`, is ... not really an error in fact :smile: \r\n\r\nNote that I did not test it with python 2, but there should not be any problem, these are small changes.\r\n\r\nIf these changes are accepted, may I ask for a release soon ? As I said in the bug report, I really need it to be fixed. ( Just asking, feel free to answer no if this bothers you )","created_at":"2018-07-14T21:09:42Z","updated_at":"2018-07-16T06:50:24Z","closed_at":"2018-07-16T06:50:24Z","merged_at":"2018-07-16T06:50:24Z","merge_commit_sha":"bd5d932918396897610690e61e4f2d8465fa1dab","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/modoboa/modoboa-webmail/milestones/17","html_url":"https://github.com/modoboa/modoboa-webmail/milestone/17","labels_url":"https://api.github.com/repos/modoboa/modoboa-webmail/milestones/17/labels","id":3304331,"node_id":"MDk6TWlsZXN0b25lMzMwNDMzMQ==","number":17,"title":"1.4.3","description":"","creator":{"login":"tonioo","id":531694,"node_id":"MDQ6VXNlcjUzMTY5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/531694?v=4","gravatar_id":"","url":"https://api.github.com/users/tonioo","html_url":"https://github.com/tonioo","followers_url":"https://api.github.com/users/tonioo/followers","following_url":"https://api.github.com/users/tonioo/following{/other_user}","gists_url":"https://api.github.com/users/tonioo/gists{/gist_id}","starred_url":"https://api.github.com/users/tonioo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonioo/subscriptions","organizations_url":"https://api.github.com/users/tonioo/orgs","repos_url":"https://api.github.com/users/tonioo/repos","events_url":"https://api.github.com/users/tonioo/events{/privacy}","received_events_url":"https://api.github.com/users/tonioo/received_events","type":"User","site_admin":false},"open_issues":0,"closed_issues":3,"state":"open","created_at":"2018-04-27T13:58:59Z","updated_at":"2018-07-16T06:50:24Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls/166/commits","review_comments_url":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls/166/comments","review_comment_url":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/modoboa/modoboa-webmail/issues/166/comments","statuses_url":"https://api.github.com/repos/modoboa/modoboa-webmail/statuses/dc9e6d576c79aa3b7168c885a9b1586ebda50240","head":{"label":"lefta:attachments","ref":"attachments","sha":"dc9e6d576c79aa3b7168c885a9b1586ebda50240","user":{"login":"lefta","id":2159458,"node_id":"MDQ6VXNlcjIxNTk0NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2159458?v=4","gravatar_id":"","url":"https://api.github.com/users/lefta","html_url":"https://github.com/lefta","followers_url":"https://api.github.com/users/lefta/followers","following_url":"https://api.github.com/users/lefta/following{/other_user}","gists_url":"https://api.github.com/users/lefta/gists{/gist_id}","starred_url":"https://api.github.com/users/lefta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefta/subscriptions","organizations_url":"https://api.github.com/users/lefta/orgs","repos_url":"https://api.github.com/users/lefta/repos","events_url":"https://api.github.com/users/lefta/events{/privacy}","received_events_url":"https://api.github.com/users/lefta/received_events","type":"User","site_admin":false},"repo":{"id":140975433,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA5NzU0MzM=","name":"modoboa-webmail","full_name":"lefta/modoboa-webmail","owner":{"login":"lefta","id":2159458,"node_id":"MDQ6VXNlcjIxNTk0NTg=","avatar_url":"https://avatars1.githubusercontent.com/u/2159458?v=4","gravatar_id":"","url":"https://api.github.com/users/lefta","html_url":"https://github.com/lefta","followers_url":"https://api.github.com/users/lefta/followers","following_url":"https://api.github.com/users/lefta/following{/other_user}","gists_url":"https://api.github.com/users/lefta/gists{/gist_id}","starred_url":"https://api.github.com/users/lefta/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lefta/subscriptions","organizations_url":"https://api.github.com/users/lefta/orgs","repos_url":"https://api.github.com/users/lefta/repos","events_url":"https://api.github.com/users/lefta/events{/privacy}","received_events_url":"https://api.github.com/users/lefta/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/lefta/modoboa-webmail","description":"The webmail of Modoboa","fork":true,"url":"https://api.github.com/repos/lefta/modoboa-webmail","forks_url":"https://api.github.com/repos/lefta/modoboa-webmail/forks","keys_url":"https://api.github.com/repos/lefta/modoboa-webmail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lefta/modoboa-webmail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lefta/modoboa-webmail/teams","hooks_url":"https://api.github.com/repos/lefta/modoboa-webmail/hooks","issue_events_url":"https://api.github.com/repos/lefta/modoboa-webmail/issues/events{/number}","events_url":"https://api.github.com/repos/lefta/modoboa-webmail/events","assignees_url":"https://api.github.com/repos/lefta/modoboa-webmail/assignees{/user}","branches_url":"https://api.github.com/repos/lefta/modoboa-webmail/branches{/branch}","tags_url":"https://api.github.com/repos/lefta/modoboa-webmail/tags","blobs_url":"https://api.github.com/repos/lefta/modoboa-webmail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lefta/modoboa-webmail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lefta/modoboa-webmail/git/refs{/sha}","trees_url":"https://api.github.com/repos/lefta/modoboa-webmail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lefta/modoboa-webmail/statuses/{sha}","languages_url":"https://api.github.com/repos/lefta/modoboa-webmail/languages","stargazers_url":"https://api.github.com/repos/lefta/modoboa-webmail/stargazers","contributors_url":"https://api.github.com/repos/lefta/modoboa-webmail/contributors","subscribers_url":"https://api.github.com/repos/lefta/modoboa-webmail/subscribers","subscription_url":"https://api.github.com/repos/lefta/modoboa-webmail/subscription","commits_url":"https://api.github.com/repos/lefta/modoboa-webmail/commits{/sha}","git_commits_url":"https://api.github.com/repos/lefta/modoboa-webmail/git/commits{/sha}","comments_url":"https://api.github.com/repos/lefta/modoboa-webmail/comments{/number}","issue_comment_url":"https://api.github.com/repos/lefta/modoboa-webmail/issues/comments{/number}","contents_url":"https://api.github.com/repos/lefta/modoboa-webmail/contents/{+path}","compare_url":"https://api.github.com/repos/lefta/modoboa-webmail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lefta/modoboa-webmail/merges","archive_url":"https://api.github.com/repos/lefta/modoboa-webmail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lefta/modoboa-webmail/downloads","issues_url":"https://api.github.com/repos/lefta/modoboa-webmail/issues{/number}","pulls_url":"https://api.github.com/repos/lefta/modoboa-webmail/pulls{/number}","milestones_url":"https://api.github.com/repos/lefta/modoboa-webmail/milestones{/number}","notifications_url":"https://api.github.com/repos/lefta/modoboa-webmail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lefta/modoboa-webmail/labels{/name}","releases_url":"https://api.github.com/repos/lefta/modoboa-webmail/releases{/id}","deployments_url":"https://api.github.com/repos/lefta/modoboa-webmail/deployments","created_at":"2018-07-14T20:18:53Z","updated_at":"2018-07-14T20:18:55Z","pushed_at":"2018-07-14T20:52:56Z","git_url":"git://github.com/lefta/modoboa-webmail.git","ssh_url":"git@github.com:lefta/modoboa-webmail.git","clone_url":"https://github.com/lefta/modoboa-webmail.git","svn_url":"https://github.com/lefta/modoboa-webmail","homepage":null,"size":445,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"modoboa:master","ref":"master","sha":"4963ad4b14515d86e6c75a492ca4f128f5d1a9d2","user":{"login":"modoboa","id":10832897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODMyODk3","avatar_url":"https://avatars0.githubusercontent.com/u/10832897?v=4","gravatar_id":"","url":"https://api.github.com/users/modoboa","html_url":"https://github.com/modoboa","followers_url":"https://api.github.com/users/modoboa/followers","following_url":"https://api.github.com/users/modoboa/following{/other_user}","gists_url":"https://api.github.com/users/modoboa/gists{/gist_id}","starred_url":"https://api.github.com/users/modoboa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modoboa/subscriptions","organizations_url":"https://api.github.com/users/modoboa/orgs","repos_url":"https://api.github.com/users/modoboa/repos","events_url":"https://api.github.com/users/modoboa/events{/privacy}","received_events_url":"https://api.github.com/users/modoboa/received_events","type":"Organization","site_admin":false},"repo":{"id":30639899,"node_id":"MDEwOlJlcG9zaXRvcnkzMDYzOTg5OQ==","name":"modoboa-webmail","full_name":"modoboa/modoboa-webmail","owner":{"login":"modoboa","id":10832897,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwODMyODk3","avatar_url":"https://avatars0.githubusercontent.com/u/10832897?v=4","gravatar_id":"","url":"https://api.github.com/users/modoboa","html_url":"https://github.com/modoboa","followers_url":"https://api.github.com/users/modoboa/followers","following_url":"https://api.github.com/users/modoboa/following{/other_user}","gists_url":"https://api.github.com/users/modoboa/gists{/gist_id}","starred_url":"https://api.github.com/users/modoboa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/modoboa/subscriptions","organizations_url":"https://api.github.com/users/modoboa/orgs","repos_url":"https://api.github.com/users/modoboa/repos","events_url":"https://api.github.com/users/modoboa/events{/privacy}","received_events_url":"https://api.github.com/users/modoboa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/modoboa/modoboa-webmail","description":"The webmail of Modoboa","fork":false,"url":"https://api.github.com/repos/modoboa/modoboa-webmail","forks_url":"https://api.github.com/repos/modoboa/modoboa-webmail/forks","keys_url":"https://api.github.com/repos/modoboa/modoboa-webmail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/modoboa/modoboa-webmail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/modoboa/modoboa-webmail/teams","hooks_url":"https://api.github.com/repos/modoboa/modoboa-webmail/hooks","issue_events_url":"https://api.github.com/repos/modoboa/modoboa-webmail/issues/events{/number}","events_url":"https://api.github.com/repos/modoboa/modoboa-webmail/events","assignees_url":"https://api.github.com/repos/modoboa/modoboa-webmail/assignees{/user}","branches_url":"https://api.github.com/repos/modoboa/modoboa-webmail/branches{/branch}","tags_url":"https://api.github.com/repos/modoboa/modoboa-webmail/tags","blobs_url":"https://api.github.com/repos/modoboa/modoboa-webmail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/modoboa/modoboa-webmail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/modoboa/modoboa-webmail/git/refs{/sha}","trees_url":"https://api.github.com/repos/modoboa/modoboa-webmail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/modoboa/modoboa-webmail/statuses/{sha}","languages_url":"https://api.github.com/repos/modoboa/modoboa-webmail/languages","stargazers_url":"https://api.github.com/repos/modoboa/modoboa-webmail/stargazers","contributors_url":"https://api.github.com/repos/modoboa/modoboa-webmail/contributors","subscribers_url":"https://api.github.com/repos/modoboa/modoboa-webmail/subscribers","subscription_url":"https://api.github.com/repos/modoboa/modoboa-webmail/subscription","commits_url":"https://api.github.com/repos/modoboa/modoboa-webmail/commits{/sha}","git_commits_url":"https://api.github.com/repos/modoboa/modoboa-webmail/git/commits{/sha}","comments_url":"https://api.github.com/repos/modoboa/modoboa-webmail/comments{/number}","issue_comment_url":"https://api.github.com/repos/modoboa/modoboa-webmail/issues/comments{/number}","contents_url":"https://api.github.com/repos/modoboa/modoboa-webmail/contents/{+path}","compare_url":"https://api.github.com/repos/modoboa/modoboa-webmail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/modoboa/modoboa-webmail/merges","archive_url":"https://api.github.com/repos/modoboa/modoboa-webmail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/modoboa/modoboa-webmail/downloads","issues_url":"https://api.github.com/repos/modoboa/modoboa-webmail/issues{/number}","pulls_url":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls{/number}","milestones_url":"https://api.github.com/repos/modoboa/modoboa-webmail/milestones{/number}","notifications_url":"https://api.github.com/repos/modoboa/modoboa-webmail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/modoboa/modoboa-webmail/labels{/name}","releases_url":"https://api.github.com/repos/modoboa/modoboa-webmail/releases{/id}","deployments_url":"https://api.github.com/repos/modoboa/modoboa-webmail/deployments","created_at":"2015-02-11T09:16:23Z","updated_at":"2018-07-16T06:49:36Z","pushed_at":"2018-07-16T06:50:23Z","git_url":"git://github.com/modoboa/modoboa-webmail.git","ssh_url":"git@github.com:modoboa/modoboa-webmail.git","clone_url":"https://github.com/modoboa/modoboa-webmail.git","svn_url":"https://github.com/modoboa/modoboa-webmail","homepage":null,"size":445,"stargazers_count":24,"watchers_count":24,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":26,"mirror_url":null,"archived":false,"open_issues_count":36,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":26,"open_issues":36,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls/166"},"html":{"href":"https://github.com/modoboa/modoboa-webmail/pull/166"},"issue":{"href":"https://api.github.com/repos/modoboa/modoboa-webmail/issues/166"},"comments":{"href":"https://api.github.com/repos/modoboa/modoboa-webmail/issues/166/comments"},"review_comments":{"href":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls/166/comments"},"review_comment":{"href":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/modoboa/modoboa-webmail/pulls/166/commits"},"statuses":{"href":"https://api.github.com/repos/modoboa/modoboa-webmail/statuses/dc9e6d576c79aa3b7168c885a9b1586ebda50240"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tonioo","id":531694,"node_id":"MDQ6VXNlcjUzMTY5NA==","avatar_url":"https://avatars2.githubusercontent.com/u/531694?v=4","gravatar_id":"","url":"https://api.github.com/users/tonioo","html_url":"https://github.com/tonioo","followers_url":"https://api.github.com/users/tonioo/followers","following_url":"https://api.github.com/users/tonioo/following{/other_user}","gists_url":"https://api.github.com/users/tonioo/gists{/gist_id}","starred_url":"https://api.github.com/users/tonioo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tonioo/subscriptions","organizations_url":"https://api.github.com/users/tonioo/orgs","repos_url":"https://api.github.com/users/tonioo/repos","events_url":"https://api.github.com/users/tonioo/events{/privacy}","received_events_url":"https://api.github.com/users/tonioo/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":7,"deletions":3,"changed_files":3}}
{"actor":{"display_login":"tonioo"}}