{"action":"created","comment":{"url":"https://api.github.com/repos/apache/rocketmq-externals/pulls/comments/231545689","pull_request_review_id":172535001,"id":231545689,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMTU0NTY4OQ==","diff_hunk":"@@ -0,0 +1,27 @@\n+/*\n+ * Licensed to the Apache Software Foundation (ASF) under one or more\n+ * contributor license agreements.  See the NOTICE file distributed with\n+ * this work for additional information regarding copyright ownership.\n+ * The ASF licenses this file to You under the Apache License, Version 2.0\n+ * (the \"License\"); you may not use this file except in compliance with\n+ * the License.  You may obtain a copy of the License at\n+ *\n+ *     http://www.apache.org/licenses/LICENSE-2.0\n+ *\n+ * Unless required by applicable law or agreed to in writing, software\n+ * distributed under the License is distributed on an \"AS IS\" BASIS,\n+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.\n+ * See the License for the specific language governing permissions and\n+ * limitations under the License.\n+ */\n+\n+package org.apache.rocketmq.spring.starter.core;\n+\n+public enum RocketMQLocalTransactionState {","path":"rocketmq-spring-boot-starter/src/main/java/org/apache/rocketmq/spring/starter/core/RocketMQLocalTransactionState.java","position":20,"original_position":20,"commit_id":"ce8f34c505813cbe79d98fdbca386da4542ead8f","original_commit_id":"ce8f34c505813cbe79d98fdbca386da4542ead8f","user":{"login":"vongosling","id":635581,"node_id":"MDQ6VXNlcjYzNTU4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/635581?v=4","gravatar_id":"","url":"https://api.github.com/users/vongosling","html_url":"https://github.com/vongosling","followers_url":"https://api.github.com/users/vongosling/followers","following_url":"https://api.github.com/users/vongosling/following{/other_user}","gists_url":"https://api.github.com/users/vongosling/gists{/gist_id}","starred_url":"https://api.github.com/users/vongosling/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vongosling/subscriptions","organizations_url":"https://api.github.com/users/vongosling/orgs","repos_url":"https://api.github.com/users/vongosling/repos","events_url":"https://api.github.com/users/vongosling/events{/privacy}","received_events_url":"https://api.github.com/users/vongosling/received_events","type":"User","site_admin":false},"body":"Why could we re-define the state instead of the native state in RocketMQ","created_at":"2018-11-07T15:15:58Z","updated_at":"2018-11-07T15:17:20Z","html_url":"https://github.com/apache/rocketmq-externals/pull/139#discussion_r231545689","pull_request_url":"https://api.github.com/repos/apache/rocketmq-externals/pulls/139","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/apache/rocketmq-externals/pulls/comments/231545689"},"html":{"href":"https://github.com/apache/rocketmq-externals/pull/139#discussion_r231545689"},"pull_request":{"href":"https://api.github.com/repos/apache/rocketmq-externals/pulls/139"}}},"pull_request":{"url":"https://api.github.com/repos/apache/rocketmq-externals/pulls/139","id":228913238,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4OTEzMjM4","html_url":"https://github.com/apache/rocketmq-externals/pull/139","diff_url":"https://github.com/apache/rocketmq-externals/pull/139.diff","patch_url":"https://github.com/apache/rocketmq-externals/pull/139.patch","issue_url":"https://api.github.com/repos/apache/rocketmq-externals/issues/139","number":139,"state":"open","locked":false,"title":"Code Refactor, decouple API from native RocketMQ","user":{"login":"walking98","id":19318111,"node_id":"MDQ6VXNlcjE5MzE4MTEx","avatar_url":"https://avatars2.githubusercontent.com/u/19318111?v=4","gravatar_id":"","url":"https://api.github.com/users/walking98","html_url":"https://github.com/walking98","followers_url":"https://api.github.com/users/walking98/followers","following_url":"https://api.github.com/users/walking98/following{/other_user}","gists_url":"https://api.github.com/users/walking98/gists{/gist_id}","starred_url":"https://api.github.com/users/walking98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walking98/subscriptions","organizations_url":"https://api.github.com/users/walking98/orgs","repos_url":"https://api.github.com/users/walking98/repos","events_url":"https://api.github.com/users/walking98/events{/privacy}","received_events_url":"https://api.github.com/users/walking98/received_events","type":"User","site_admin":false},"body":"Please do not create a Pull Request without creating an issue first. \r\n\r\n## What is the purpose of the change\r\n\r\n1. Wrapper the RocketMQ API and expose in spring-boot-starter;\r\n2. Use Spring Message instead of RocketMQ Message;\r\n3. Refactor code of transactional message sending  and the related sample.\r\n\r\n## Brief changelog\r\n\r\n\r\n\r\n## Verifying this change\r\n\r\nTested pass with unit and sample testing.\r\n\r\nFollow this checklist to help us incorporate your contribution quickly and easily:\r\n\r\n- [x] Make sure there is a Github issue filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue. \r\n- [ ] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.\r\n- [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.\r\n- [ ] Write necessary unit-test to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).\r\n- [ ] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test`  to make sure integration-test pass.\r\n- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).\r\n","created_at":"2018-11-07T04:15:33Z","updated_at":"2018-11-07T15:17:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f85cd121b3cf0e7cdafcc8fb9e88dea730e9e57e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/rocketmq-externals/pulls/139/commits","review_comments_url":"https://api.github.com/repos/apache/rocketmq-externals/pulls/139/comments","review_comment_url":"https://api.github.com/repos/apache/rocketmq-externals/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/rocketmq-externals/issues/139/comments","statuses_url":"https://api.github.com/repos/apache/rocketmq-externals/statuses/ce8f34c505813cbe79d98fdbca386da4542ead8f","head":{"label":"walking98:develop","ref":"develop","sha":"ce8f34c505813cbe79d98fdbca386da4542ead8f","user":{"login":"walking98","id":19318111,"node_id":"MDQ6VXNlcjE5MzE4MTEx","avatar_url":"https://avatars2.githubusercontent.com/u/19318111?v=4","gravatar_id":"","url":"https://api.github.com/users/walking98","html_url":"https://github.com/walking98","followers_url":"https://api.github.com/users/walking98/followers","following_url":"https://api.github.com/users/walking98/following{/other_user}","gists_url":"https://api.github.com/users/walking98/gists{/gist_id}","starred_url":"https://api.github.com/users/walking98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walking98/subscriptions","organizations_url":"https://api.github.com/users/walking98/orgs","repos_url":"https://api.github.com/users/walking98/repos","events_url":"https://api.github.com/users/walking98/events{/privacy}","received_events_url":"https://api.github.com/users/walking98/received_events","type":"User","site_admin":false},"repo":{"id":144250524,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyNTA1MjQ=","name":"rocketmq-externals","full_name":"walking98/rocketmq-externals","private":false,"owner":{"login":"walking98","id":19318111,"node_id":"MDQ6VXNlcjE5MzE4MTEx","avatar_url":"https://avatars2.githubusercontent.com/u/19318111?v=4","gravatar_id":"","url":"https://api.github.com/users/walking98","html_url":"https://github.com/walking98","followers_url":"https://api.github.com/users/walking98/followers","following_url":"https://api.github.com/users/walking98/following{/other_user}","gists_url":"https://api.github.com/users/walking98/gists{/gist_id}","starred_url":"https://api.github.com/users/walking98/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/walking98/subscriptions","organizations_url":"https://api.github.com/users/walking98/orgs","repos_url":"https://api.github.com/users/walking98/repos","events_url":"https://api.github.com/users/walking98/events{/privacy}","received_events_url":"https://api.github.com/users/walking98/received_events","type":"User","site_admin":false},"html_url":"https://github.com/walking98/rocketmq-externals","description":"Mirror of Apache RocketMQ (Incubating)","fork":true,"url":"https://api.github.com/repos/walking98/rocketmq-externals","forks_url":"https://api.github.com/repos/walking98/rocketmq-externals/forks","keys_url":"https://api.github.com/repos/walking98/rocketmq-externals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/walking98/rocketmq-externals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/walking98/rocketmq-externals/teams","hooks_url":"https://api.github.com/repos/walking98/rocketmq-externals/hooks","issue_events_url":"https://api.github.com/repos/walking98/rocketmq-externals/issues/events{/number}","events_url":"https://api.github.com/repos/walking98/rocketmq-externals/events","assignees_url":"https://api.github.com/repos/walking98/rocketmq-externals/assignees{/user}","branches_url":"https://api.github.com/repos/walking98/rocketmq-externals/branches{/branch}","tags_url":"https://api.github.com/repos/walking98/rocketmq-externals/tags","blobs_url":"https://api.github.com/repos/walking98/rocketmq-externals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/walking98/rocketmq-externals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/walking98/rocketmq-externals/git/refs{/sha}","trees_url":"https://api.github.com/repos/walking98/rocketmq-externals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/walking98/rocketmq-externals/statuses/{sha}","languages_url":"https://api.github.com/repos/walking98/rocketmq-externals/languages","stargazers_url":"https://api.github.com/repos/walking98/rocketmq-externals/stargazers","contributors_url":"https://api.github.com/repos/walking98/rocketmq-externals/contributors","subscribers_url":"https://api.github.com/repos/walking98/rocketmq-externals/subscribers","subscription_url":"https://api.github.com/repos/walking98/rocketmq-externals/subscription","commits_url":"https://api.github.com/repos/walking98/rocketmq-externals/commits{/sha}","git_commits_url":"https://api.github.com/repos/walking98/rocketmq-externals/git/commits{/sha}","comments_url":"https://api.github.com/repos/walking98/rocketmq-externals/comments{/number}","issue_comment_url":"https://api.github.com/repos/walking98/rocketmq-externals/issues/comments{/number}","contents_url":"https://api.github.com/repos/walking98/rocketmq-externals/contents/{+path}","compare_url":"https://api.github.com/repos/walking98/rocketmq-externals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/walking98/rocketmq-externals/merges","archive_url":"https://api.github.com/repos/walking98/rocketmq-externals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/walking98/rocketmq-externals/downloads","issues_url":"https://api.github.com/repos/walking98/rocketmq-externals/issues{/number}","pulls_url":"https://api.github.com/repos/walking98/rocketmq-externals/pulls{/number}","milestones_url":"https://api.github.com/repos/walking98/rocketmq-externals/milestones{/number}","notifications_url":"https://api.github.com/repos/walking98/rocketmq-externals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/walking98/rocketmq-externals/labels{/name}","releases_url":"https://api.github.com/repos/walking98/rocketmq-externals/releases{/id}","deployments_url":"https://api.github.com/repos/walking98/rocketmq-externals/deployments","created_at":"2018-08-10T07:11:24Z","updated_at":"2018-10-22T02:33:40Z","pushed_at":"2018-11-07T04:10:23Z","git_url":"git://github.com/walking98/rocketmq-externals.git","ssh_url":"git@github.com:walking98/rocketmq-externals.git","clone_url":"https://github.com/walking98/rocketmq-externals.git","svn_url":"https://github.com/walking98/rocketmq-externals","homepage":null,"size":12061,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"9a7075dd10e696419a371e2c7c498b35a16db420","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":84916374,"node_id":"MDEwOlJlcG9zaXRvcnk4NDkxNjM3NA==","name":"rocketmq-externals","full_name":"apache/rocketmq-externals","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/rocketmq-externals","description":"Mirror of Apache RocketMQ (Incubating)","fork":false,"url":"https://api.github.com/repos/apache/rocketmq-externals","forks_url":"https://api.github.com/repos/apache/rocketmq-externals/forks","keys_url":"https://api.github.com/repos/apache/rocketmq-externals/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/rocketmq-externals/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/rocketmq-externals/teams","hooks_url":"https://api.github.com/repos/apache/rocketmq-externals/hooks","issue_events_url":"https://api.github.com/repos/apache/rocketmq-externals/issues/events{/number}","events_url":"https://api.github.com/repos/apache/rocketmq-externals/events","assignees_url":"https://api.github.com/repos/apache/rocketmq-externals/assignees{/user}","branches_url":"https://api.github.com/repos/apache/rocketmq-externals/branches{/branch}","tags_url":"https://api.github.com/repos/apache/rocketmq-externals/tags","blobs_url":"https://api.github.com/repos/apache/rocketmq-externals/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/rocketmq-externals/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/rocketmq-externals/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/rocketmq-externals/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/rocketmq-externals/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/rocketmq-externals/languages","stargazers_url":"https://api.github.com/repos/apache/rocketmq-externals/stargazers","contributors_url":"https://api.github.com/repos/apache/rocketmq-externals/contributors","subscribers_url":"https://api.github.com/repos/apache/rocketmq-externals/subscribers","subscription_url":"https://api.github.com/repos/apache/rocketmq-externals/subscription","commits_url":"https://api.github.com/repos/apache/rocketmq-externals/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/rocketmq-externals/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/rocketmq-externals/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/rocketmq-externals/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/rocketmq-externals/contents/{+path}","compare_url":"https://api.github.com/repos/apache/rocketmq-externals/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/rocketmq-externals/merges","archive_url":"https://api.github.com/repos/apache/rocketmq-externals/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/rocketmq-externals/downloads","issues_url":"https://api.github.com/repos/apache/rocketmq-externals/issues{/number}","pulls_url":"https://api.github.com/repos/apache/rocketmq-externals/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/rocketmq-externals/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/rocketmq-externals/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/rocketmq-externals/labels{/name}","releases_url":"https://api.github.com/repos/apache/rocketmq-externals/releases{/id}","deployments_url":"https://api.github.com/repos/apache/rocketmq-externals/deployments","created_at":"2017-03-14T07:00:06Z","updated_at":"2018-11-07T08:23:55Z","pushed_at":"2018-11-07T05:28:49Z","git_url":"git://github.com/apache/rocketmq-externals.git","ssh_url":"git@github.com:apache/rocketmq-externals.git","clone_url":"https://github.com/apache/rocketmq-externals.git","svn_url":"https://github.com/apache/rocketmq-externals","homepage":null,"size":12031,"stargazers_count":1025,"watchers_count":1025,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":761,"mirror_url":null,"archived":false,"open_issues_count":16,"license":null,"forks":761,"open_issues":16,"watchers":1025,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/rocketmq-externals/pulls/139"},"html":{"href":"https://github.com/apache/rocketmq-externals/pull/139"},"issue":{"href":"https://api.github.com/repos/apache/rocketmq-externals/issues/139"},"comments":{"href":"https://api.github.com/repos/apache/rocketmq-externals/issues/139/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/rocketmq-externals/pulls/139/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/rocketmq-externals/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/rocketmq-externals/pulls/139/commits"},"statuses":{"href":"https://api.github.com/repos/apache/rocketmq-externals/statuses/ce8f34c505813cbe79d98fdbca386da4542ead8f"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"vongosling"}}