{"action":"closed","number":69,"pull_request":{"url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls/69","id":190864717,"html_url":"https://github.com/jaegertracing/jaeger-client-csharp/pull/69","diff_url":"https://github.com/jaegertracing/jaeger-client-csharp/pull/69.diff","patch_url":"https://github.com/jaegertracing/jaeger-client-csharp/pull/69.patch","issue_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues/69","number":69,"state":"closed","locked":false,"title":"Fixed logging of active span","user":{"login":"Falco20019","id":940619,"avatar_url":"https://avatars3.githubusercontent.com/u/940619?v=4","gravatar_id":"","url":"https://api.github.com/users/Falco20019","html_url":"https://github.com/Falco20019","followers_url":"https://api.github.com/users/Falco20019/followers","following_url":"https://api.github.com/users/Falco20019/following{/other_user}","gists_url":"https://api.github.com/users/Falco20019/gists{/gist_id}","starred_url":"https://api.github.com/users/Falco20019/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Falco20019/subscriptions","organizations_url":"https://api.github.com/users/Falco20019/orgs","repos_url":"https://api.github.com/users/Falco20019/repos","events_url":"https://api.github.com/users/Falco20019/events{/privacy}","received_events_url":"https://api.github.com/users/Falco20019/received_events","type":"User","site_admin":false},"body":"Fixes #68 \r\n\r\nI added the missing `JsonIgnore` attribute directly. I first wanted to do it through a through an `ContractResolver` but later saw that it's only defined in the implementation and not by the interface in `OpenTracing`. So just ignore the first commit, it will be squashed together before merging.\r\n\r\nI also added a test case for regression.","created_at":"2018-05-28T08:15:23Z","updated_at":"2018-05-28T13:32:34Z","closed_at":"2018-05-28T13:32:34Z","merged_at":"2018-05-28T13:32:33Z","merge_commit_sha":"dbcb90456eb867532d056d0622329e329b32278e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls/69/commits","review_comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls/69/comments","review_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues/69/comments","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/statuses/e52c532210b6ebd0832a91f7dfe3331732e60ade","head":{"label":"jaegertracing:Falco20019/json-loop","ref":"Falco20019/json-loop","sha":"e52c532210b6ebd0832a91f7dfe3331732e60ade","user":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":122382522,"name":"jaeger-client-csharp","full_name":"jaegertracing/jaeger-client-csharp","owner":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-client-csharp","description":"C# client (tracer) for Jaeger","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/deployments","created_at":"2018-02-21T19:25:24Z","updated_at":"2018-05-28T12:30:36Z","pushed_at":"2018-05-28T13:32:33Z","git_url":"git://github.com/jaegertracing/jaeger-client-csharp.git","ssh_url":"git@github.com:jaegertracing/jaeger-client-csharp.git","clone_url":"https://github.com/jaegertracing/jaeger-client-csharp.git","svn_url":"https://github.com/jaegertracing/jaeger-client-csharp","homepage":"https://jaegertracing.io/","size":583,"stargazers_count":37,"watchers_count":37,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":7,"watchers":37,"default_branch":"master"}},"base":{"label":"jaegertracing:master","ref":"master","sha":"9814b7a2be12318eef1b4ef44a9006594ab2e6fb","user":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"repo":{"id":122382522,"name":"jaeger-client-csharp","full_name":"jaegertracing/jaeger-client-csharp","owner":{"login":"jaegertracing","id":28545596,"avatar_url":"https://avatars1.githubusercontent.com/u/28545596?v=4","gravatar_id":"","url":"https://api.github.com/users/jaegertracing","html_url":"https://github.com/jaegertracing","followers_url":"https://api.github.com/users/jaegertracing/followers","following_url":"https://api.github.com/users/jaegertracing/following{/other_user}","gists_url":"https://api.github.com/users/jaegertracing/gists{/gist_id}","starred_url":"https://api.github.com/users/jaegertracing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jaegertracing/subscriptions","organizations_url":"https://api.github.com/users/jaegertracing/orgs","repos_url":"https://api.github.com/users/jaegertracing/repos","events_url":"https://api.github.com/users/jaegertracing/events{/privacy}","received_events_url":"https://api.github.com/users/jaegertracing/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jaegertracing/jaeger-client-csharp","description":"C# client (tracer) for Jaeger","fork":false,"url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp","forks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/forks","keys_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/teams","hooks_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/hooks","issue_events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues/events{/number}","events_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/events","assignees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/assignees{/user}","branches_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/branches{/branch}","tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/tags","blobs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/refs{/sha}","trees_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/statuses/{sha}","languages_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/languages","stargazers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/stargazers","contributors_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/contributors","subscribers_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/subscribers","subscription_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/subscription","commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/commits{/sha}","git_commits_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/git/commits{/sha}","comments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/comments{/number}","issue_comment_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues/comments{/number}","contents_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/contents/{+path}","compare_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/merges","archive_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/downloads","issues_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues{/number}","pulls_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls{/number}","milestones_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/milestones{/number}","notifications_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/labels{/name}","releases_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/releases{/id}","deployments_url":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/deployments","created_at":"2018-02-21T19:25:24Z","updated_at":"2018-05-28T12:30:36Z","pushed_at":"2018-05-28T13:32:33Z","git_url":"git://github.com/jaegertracing/jaeger-client-csharp.git","ssh_url":"git@github.com:jaegertracing/jaeger-client-csharp.git","clone_url":"https://github.com/jaegertracing/jaeger-client-csharp.git","svn_url":"https://github.com/jaegertracing/jaeger-client-csharp","homepage":"https://jaegertracing.io/","size":583,"stargazers_count":37,"watchers_count":37,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":7,"open_issues":7,"watchers":37,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls/69"},"html":{"href":"https://github.com/jaegertracing/jaeger-client-csharp/pull/69"},"issue":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues/69"},"comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/issues/69/comments"},"review_comments":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls/69/comments"},"review_comment":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/pulls/69/commits"},"statuses":{"href":"https://api.github.com/repos/jaegertracing/jaeger-client-csharp/statuses/e52c532210b6ebd0832a91f7dfe3331732e60ade"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"Falco20019","id":940619,"avatar_url":"https://avatars3.githubusercontent.com/u/940619?v=4","gravatar_id":"","url":"https://api.github.com/users/Falco20019","html_url":"https://github.com/Falco20019","followers_url":"https://api.github.com/users/Falco20019/followers","following_url":"https://api.github.com/users/Falco20019/following{/other_user}","gists_url":"https://api.github.com/users/Falco20019/gists{/gist_id}","starred_url":"https://api.github.com/users/Falco20019/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Falco20019/subscriptions","organizations_url":"https://api.github.com/users/Falco20019/orgs","repos_url":"https://api.github.com/users/Falco20019/repos","events_url":"https://api.github.com/users/Falco20019/events{/privacy}","received_events_url":"https://api.github.com/users/Falco20019/received_events","type":"User","site_admin":false},"comments":2,"review_comments":0,"maintainer_can_modify":false,"commits":6,"additions":22,"deletions":2,"changed_files":2}}
{"actor":{"display_login":"Falco20019"}}