{"action":"closed","number":1295,"pull_request":{"url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1295","id":173810447,"html_url":"https://github.com/fcrepo4/fcrepo4/pull/1295","diff_url":"https://github.com/fcrepo4/fcrepo4/pull/1295.diff","patch_url":"https://github.com/fcrepo4/fcrepo4/pull/1295.patch","issue_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1295","number":1295,"state":"closed","locked":false,"title":"Implements ACL linking on resource creation as defined in","user":{"login":"dbernstein","id":344939,"avatar_url":"https://avatars2.githubusercontent.com/u/344939?v=4","gravatar_id":"","url":"https://api.github.com/users/dbernstein","html_url":"https://github.com/dbernstein","followers_url":"https://api.github.com/users/dbernstein/followers","following_url":"https://api.github.com/users/dbernstein/following{/other_user}","gists_url":"https://api.github.com/users/dbernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dbernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbernstein/subscriptions","organizations_url":"https://api.github.com/users/dbernstein/orgs","repos_url":"https://api.github.com/users/dbernstein/repos","events_url":"https://api.github.com/users/dbernstein/events{/privacy}","received_events_url":"https://api.github.com/users/dbernstein/received_events","type":"User","site_admin":false},"body":" https://fcrepo.github.io/fcrepo-specification/#link-acl-on-create for PUTs and POSTs.\r\n\r\nAdds the following five tests to FedoraLdpIT.\r\n* testPostCreateNonRDFSourceWithAcl\r\n* testPutCreateNonRDFSourceWithAcl\r\n* testPostCreateRDFSourceWithAcl\r\n* testPutCreateRDFSourceWithAcl\r\n* testPutCreateRDFSourceWithNonExistentAcl\r\n\r\n\r\n**JIRA Ticket**: Resolves: https://jira.duraspace.org/browse/FCREPO-2688\r\n\r\n\r\n# What does this Pull Request do?\r\n\r\nImplements acl assignment on new resources using PUT and POST according to  https://fcrepo.github.io/fcrepo-specification/#link-acl-on-create\r\n\r\n# How should this be tested?\r\n```\r\n# create acl\r\ncurl -v -XPUT  \"http://localhost:8080/rest/acl1\" -u fedoraAdmin:fedoraAdmin\r\n\r\n# create binary resource with acl on POST\r\ncurl -v -XPOST  -H \"ContentType: text/plain\" -H \"Link: <http://localhost:8080/rest/acl1>; rel=\\\"acl\\\"\" \"http://localhost:8080/rest/\" -H \"Slug: test1\" -u fedoraAdmin:fedoraAdmin --data-binary \"test\"\r\n# ensure the acl triple  is present in the fcr:metadata\r\ncurl -v http://localhost:8080/rest/test1/fcr:metadata\r\n\r\n# create binary resource with acl on PUT\r\ncurl -v -XPUT -H \"ContentType: text/plain\"  -H \"Link: <http://localhost:8080/rest/acl1>; rel=\\\"acl\\\"\" \"http://localhost:8080/rest/test2\" --data-binary \"test\" -u fedoraAdmin:fedoraAdmin \r\n\r\n# ensure the acl triple  is present in fcr:metatata response\r\ncurl -v http://localhost:8080/rest/test2/fcr:metadata\r\n\r\n# create rdf resource with acl on POST\r\ncurl -v -XPOST  -H \"Link: <http://localhost:8080/rest/acl1>; rel=\\\"acl\\\"\" \"http://localhost:8080/rest/\" -H \"Slug: test3\" -u fedoraAdmin:fedoraAdmin \r\n# ensure the acl triple and link header is present response\r\ncurl -v http://localhost:8080/rest/test3\r\n\r\n# create rdf resource with acl on PUT\r\ncurl -v -XPUT   -H \"Link: <http://localhost:8080/rest/acl1>; rel=\\\"acl\\\"\" \"http://localhost:8080/rest/test4\" -u fedoraAdmin:fedoraAdmin \r\n\r\n# ensure the acl triple and link header is present in response\r\ncurl -v http://localhost:8080/rest/test4\r\n\r\n# return 400 if  acl does not exist on PUT\r\ncurl -v -XPUT   -H \"Link: <http://localhost:8080/rest/aclx>; rel=\\\"acl\\\"\" \"http://localhost:8080/rest/test5\" -u fedoraAdmin:fedoraAdmin \r\n```\r\n\r\n# Additional Notes:\r\nThere is a follow on ticket to flesh out the error handling for this issue.\r\n * https://jira.duraspace.org/browse/FCREPO-2705 - ensures that constrainedBy links are returned when the acl link does not exist or is not properly typed.\r\n\r\nThis bug addresses a gap in existing GET / HEAD responses for acl controlled resources.\r\n * https://jira.duraspace.org/browse/FCREPO-2704 - Identifies the lack of an acl link in the HEAD and GET response on a binary with an acl set in the fcr:metadata.\r\n\r\n","created_at":"2018-03-08T18:13:39Z","updated_at":"2018-03-09T01:22:35Z","closed_at":"2018-03-09T01:22:34Z","merged_at":"2018-03-09T01:22:34Z","merge_commit_sha":"bc64fd321f9b9b08f1650aff1233f4c995bc94fb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"awoods","id":149283,"avatar_url":"https://avatars2.githubusercontent.com/u/149283?v=4","gravatar_id":"","url":"https://api.github.com/users/awoods","html_url":"https://github.com/awoods","followers_url":"https://api.github.com/users/awoods/followers","following_url":"https://api.github.com/users/awoods/following{/other_user}","gists_url":"https://api.github.com/users/awoods/gists{/gist_id}","starred_url":"https://api.github.com/users/awoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awoods/subscriptions","organizations_url":"https://api.github.com/users/awoods/orgs","repos_url":"https://api.github.com/users/awoods/repos","events_url":"https://api.github.com/users/awoods/events{/privacy}","received_events_url":"https://api.github.com/users/awoods/received_events","type":"User","site_admin":false},{"login":"escowles","id":856924,"avatar_url":"https://avatars3.githubusercontent.com/u/856924?v=4","gravatar_id":"","url":"https://api.github.com/users/escowles","html_url":"https://github.com/escowles","followers_url":"https://api.github.com/users/escowles/followers","following_url":"https://api.github.com/users/escowles/following{/other_user}","gists_url":"https://api.github.com/users/escowles/gists{/gist_id}","starred_url":"https://api.github.com/users/escowles/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/escowles/subscriptions","organizations_url":"https://api.github.com/users/escowles/orgs","repos_url":"https://api.github.com/users/escowles/repos","events_url":"https://api.github.com/users/escowles/events{/privacy}","received_events_url":"https://api.github.com/users/escowles/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1295/commits","review_comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1295/comments","review_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1295/comments","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/60d997ee672bf4c8e3e7b7da61bdb43f21c5b4da","head":{"label":"dbernstein:fcrepo-2688","ref":"fcrepo-2688","sha":"60d997ee672bf4c8e3e7b7da61bdb43f21c5b4da","user":{"login":"dbernstein","id":344939,"avatar_url":"https://avatars2.githubusercontent.com/u/344939?v=4","gravatar_id":"","url":"https://api.github.com/users/dbernstein","html_url":"https://github.com/dbernstein","followers_url":"https://api.github.com/users/dbernstein/followers","following_url":"https://api.github.com/users/dbernstein/following{/other_user}","gists_url":"https://api.github.com/users/dbernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dbernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbernstein/subscriptions","organizations_url":"https://api.github.com/users/dbernstein/orgs","repos_url":"https://api.github.com/users/dbernstein/repos","events_url":"https://api.github.com/users/dbernstein/events{/privacy}","received_events_url":"https://api.github.com/users/dbernstein/received_events","type":"User","site_admin":false},"repo":{"id":70508115,"name":"fcrepo4","full_name":"dbernstein/fcrepo4","owner":{"login":"dbernstein","id":344939,"avatar_url":"https://avatars2.githubusercontent.com/u/344939?v=4","gravatar_id":"","url":"https://api.github.com/users/dbernstein","html_url":"https://github.com/dbernstein","followers_url":"https://api.github.com/users/dbernstein/followers","following_url":"https://api.github.com/users/dbernstein/following{/other_user}","gists_url":"https://api.github.com/users/dbernstein/gists{/gist_id}","starred_url":"https://api.github.com/users/dbernstein/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbernstein/subscriptions","organizations_url":"https://api.github.com/users/dbernstein/orgs","repos_url":"https://api.github.com/users/dbernstein/repos","events_url":"https://api.github.com/users/dbernstein/events{/privacy}","received_events_url":"https://api.github.com/users/dbernstein/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dbernstein/fcrepo4","description":"Fedora 4","fork":true,"url":"https://api.github.com/repos/dbernstein/fcrepo4","forks_url":"https://api.github.com/repos/dbernstein/fcrepo4/forks","keys_url":"https://api.github.com/repos/dbernstein/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dbernstein/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dbernstein/fcrepo4/teams","hooks_url":"https://api.github.com/repos/dbernstein/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/dbernstein/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/dbernstein/fcrepo4/events","assignees_url":"https://api.github.com/repos/dbernstein/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/dbernstein/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/dbernstein/fcrepo4/tags","blobs_url":"https://api.github.com/repos/dbernstein/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dbernstein/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dbernstein/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/dbernstein/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dbernstein/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/dbernstein/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/dbernstein/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/dbernstein/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/dbernstein/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/dbernstein/fcrepo4/subscription","commits_url":"https://api.github.com/repos/dbernstein/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/dbernstein/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/dbernstein/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/dbernstein/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/dbernstein/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/dbernstein/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dbernstein/fcrepo4/merges","archive_url":"https://api.github.com/repos/dbernstein/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dbernstein/fcrepo4/downloads","issues_url":"https://api.github.com/repos/dbernstein/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/dbernstein/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/dbernstein/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/dbernstein/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dbernstein/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/dbernstein/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/dbernstein/fcrepo4/deployments","created_at":"2016-10-10T16:42:42Z","updated_at":"2016-10-10T16:42:45Z","pushed_at":"2018-03-08T18:20:51Z","git_url":"git://github.com/dbernstein/fcrepo4.git","ssh_url":"git@github.com:dbernstein/fcrepo4.git","clone_url":"https://github.com/dbernstein/fcrepo4.git","svn_url":"https://github.com/dbernstein/fcrepo4","homepage":"https://wiki.duraspace.org/display/FF/Fedora+Repository+Home","size":85984,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fcrepo4:master","ref":"master","sha":"3b915f1c76d3d14876050868f9d1ece884f762fa","user":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars2.githubusercontent.com/u/3057565?v=4","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"repo":{"id":7992797,"name":"fcrepo4","full_name":"fcrepo4/fcrepo4","owner":{"login":"fcrepo4","id":3057565,"avatar_url":"https://avatars2.githubusercontent.com/u/3057565?v=4","gravatar_id":"","url":"https://api.github.com/users/fcrepo4","html_url":"https://github.com/fcrepo4","followers_url":"https://api.github.com/users/fcrepo4/followers","following_url":"https://api.github.com/users/fcrepo4/following{/other_user}","gists_url":"https://api.github.com/users/fcrepo4/gists{/gist_id}","starred_url":"https://api.github.com/users/fcrepo4/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fcrepo4/subscriptions","organizations_url":"https://api.github.com/users/fcrepo4/orgs","repos_url":"https://api.github.com/users/fcrepo4/repos","events_url":"https://api.github.com/users/fcrepo4/events{/privacy}","received_events_url":"https://api.github.com/users/fcrepo4/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fcrepo4/fcrepo4","description":"Fedora 4","fork":false,"url":"https://api.github.com/repos/fcrepo4/fcrepo4","forks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/forks","keys_url":"https://api.github.com/repos/fcrepo4/fcrepo4/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fcrepo4/fcrepo4/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fcrepo4/fcrepo4/teams","hooks_url":"https://api.github.com/repos/fcrepo4/fcrepo4/hooks","issue_events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/events{/number}","events_url":"https://api.github.com/repos/fcrepo4/fcrepo4/events","assignees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/assignees{/user}","branches_url":"https://api.github.com/repos/fcrepo4/fcrepo4/branches{/branch}","tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/tags","blobs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/refs{/sha}","trees_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/{sha}","languages_url":"https://api.github.com/repos/fcrepo4/fcrepo4/languages","stargazers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/stargazers","contributors_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contributors","subscribers_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscribers","subscription_url":"https://api.github.com/repos/fcrepo4/fcrepo4/subscription","commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/commits{/sha}","git_commits_url":"https://api.github.com/repos/fcrepo4/fcrepo4/git/commits{/sha}","comments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/comments{/number}","issue_comment_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/comments{/number}","contents_url":"https://api.github.com/repos/fcrepo4/fcrepo4/contents/{+path}","compare_url":"https://api.github.com/repos/fcrepo4/fcrepo4/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fcrepo4/fcrepo4/merges","archive_url":"https://api.github.com/repos/fcrepo4/fcrepo4/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fcrepo4/fcrepo4/downloads","issues_url":"https://api.github.com/repos/fcrepo4/fcrepo4/issues{/number}","pulls_url":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls{/number}","milestones_url":"https://api.github.com/repos/fcrepo4/fcrepo4/milestones{/number}","notifications_url":"https://api.github.com/repos/fcrepo4/fcrepo4/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fcrepo4/fcrepo4/labels{/name}","releases_url":"https://api.github.com/repos/fcrepo4/fcrepo4/releases{/id}","deployments_url":"https://api.github.com/repos/fcrepo4/fcrepo4/deployments","created_at":"2013-02-03T16:18:55Z","updated_at":"2018-03-08T12:24:35Z","pushed_at":"2018-03-09T01:22:34Z","git_url":"git://github.com/fcrepo4/fcrepo4.git","ssh_url":"git@github.com:fcrepo4/fcrepo4.git","clone_url":"https://github.com/fcrepo4/fcrepo4.git","svn_url":"https://github.com/fcrepo4/fcrepo4","homepage":"https://wiki.duraspace.org/display/FF/Fedora+Repository+Home","size":101015,"stargazers_count":93,"watchers_count":93,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":100,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":100,"open_issues":14,"watchers":93,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1295"},"html":{"href":"https://github.com/fcrepo4/fcrepo4/pull/1295"},"issue":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1295"},"comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/issues/1295/comments"},"review_comments":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1295/comments"},"review_comment":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/pulls/1295/commits"},"statuses":{"href":"https://api.github.com/repos/fcrepo4/fcrepo4/statuses/60d997ee672bf4c8e3e7b7da61bdb43f21c5b4da"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"awoods","id":149283,"avatar_url":"https://avatars2.githubusercontent.com/u/149283?v=4","gravatar_id":"","url":"https://api.github.com/users/awoods","html_url":"https://github.com/awoods","followers_url":"https://api.github.com/users/awoods/followers","following_url":"https://api.github.com/users/awoods/following{/other_user}","gists_url":"https://api.github.com/users/awoods/gists{/gist_id}","starred_url":"https://api.github.com/users/awoods/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awoods/subscriptions","organizations_url":"https://api.github.com/users/awoods/orgs","repos_url":"https://api.github.com/users/awoods/repos","events_url":"https://api.github.com/users/awoods/events{/privacy}","received_events_url":"https://api.github.com/users/awoods/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":157,"deletions":4,"changed_files":5}}
{"actor":{"display_login":"awoods"}}