{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/166586595","pull_request_review_id":94670886,"id":166586595,"diff_hunk":"@@ -36,17 +36,16 @@ public void UseNodeSettingsConfiguresNodeBuilderWithNodeSettings()\n             Assert.Equal(NodeSettings.Default().ConfigurationFile, this.fullNodeBuilder.NodeSettings.ConfigurationFile);\n             Assert.Equal(NodeSettings.Default().DataDir, this.fullNodeBuilder.NodeSettings.DataDir);\n             Assert.NotNull(this.fullNodeBuilder.Network);\n-            Assert.Equal(NodeSettings.Default().GetNetwork(), this.fullNodeBuilder.Network);\n+            Assert.Equal(NodeSettings.Default().Network, this.fullNodeBuilder.Network);\n             Assert.Single(this.serviceCollectionDelegates);\n         }\n \n         [Fact]\n         public void UseDefaultNodeSettingsConfiguresNodeBuilderWithDefaultSettings()\n         {\n-            var nodeSettings = NodeSettings.Default();\n+            var nodeSettings = new NodeSettings();","path":"src/Stratis.Bitcoin.Tests/Builder/FullNodeBuilderExtensionsTest.cs","position":13,"original_position":13,"commit_id":"316ebe9eddf6227509c7ecfd3f3ef1accc9db124","original_commit_id":"316ebe9eddf6227509c7ecfd3f3ef1accc9db124","user":{"login":"bokobza","id":1867877,"avatar_url":"https://avatars3.githubusercontent.com/u/1867877?v=4","gravatar_id":"","url":"https://api.github.com/users/bokobza","html_url":"https://github.com/bokobza","followers_url":"https://api.github.com/users/bokobza/followers","following_url":"https://api.github.com/users/bokobza/following{/other_user}","gists_url":"https://api.github.com/users/bokobza/gists{/gist_id}","starred_url":"https://api.github.com/users/bokobza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bokobza/subscriptions","organizations_url":"https://api.github.com/users/bokobza/orgs","repos_url":"https://api.github.com/users/bokobza/repos","events_url":"https://api.github.com/users/bokobza/events{/privacy}","received_events_url":"https://api.github.com/users/bokobza/received_events","type":"User","site_admin":false},"body":"Why the change? You could have `NodeSettings.Default(Network.TestNet);`","created_at":"2018-02-07T11:12:39Z","updated_at":"2018-02-07T11:12:39Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1146#discussion_r166586595","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1146","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/166586595"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1146#discussion_r166586595"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1146"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1146","id":167634982,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1146","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1146.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1146.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1146","number":1146,"state":"open","locked":false,"title":"Remove public TestNet, RegTest and GetNetwork from NodeSettings (Refactor)","user":{"login":"quantumagi","id":29645989,"avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"body":"This PR removes unnecessary public methods and variables from `NodeSettings`.\r\n\r\nHaving the public / member `TestNet` and `RegTest` variables can allow contradictions to arise between the values of the variables and the current `this.Network` variable.","created_at":"2018-02-07T09:14:27Z","updated_at":"2018-02-07T11:12:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"975aa58b87f6c743acc7ff95815e79c22a72aa82","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1146/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1146/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1146/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/316ebe9eddf6227509c7ecfd3f3ef1accc9db124","head":{"label":"quantumagi:trimnodeset","ref":"trimnodeset","sha":"316ebe9eddf6227509c7ecfd3f3ef1accc9db124","user":{"login":"quantumagi","id":29645989,"avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"repo":{"id":95172741,"name":"StratisBitcoinFullNode","full_name":"quantumagi/StratisBitcoinFullNode","owner":{"login":"quantumagi","id":29645989,"avatar_url":"https://avatars2.githubusercontent.com/u/29645989?v=4","gravatar_id":"","url":"https://api.github.com/users/quantumagi","html_url":"https://github.com/quantumagi","followers_url":"https://api.github.com/users/quantumagi/followers","following_url":"https://api.github.com/users/quantumagi/following{/other_user}","gists_url":"https://api.github.com/users/quantumagi/gists{/gist_id}","starred_url":"https://api.github.com/users/quantumagi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/quantumagi/subscriptions","organizations_url":"https://api.github.com/users/quantumagi/orgs","repos_url":"https://api.github.com/users/quantumagi/repos","events_url":"https://api.github.com/users/quantumagi/events{/privacy}","received_events_url":"https://api.github.com/users/quantumagi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/quantumagi/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/quantumagi/StratisBitcoinFullNode/deployments","created_at":"2017-06-23T01:50:53Z","updated_at":"2017-06-23T01:50:55Z","pushed_at":"2018-02-07T09:52:24Z","git_url":"git://github.com/quantumagi/StratisBitcoinFullNode.git","ssh_url":"git@github.com:quantumagi/StratisBitcoinFullNode.git","clone_url":"https://github.com/quantumagi/StratisBitcoinFullNode.git","svn_url":"https://github.com/quantumagi/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":14617,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"35a3e917007d1d7456549976bd31089229f80f80","user":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-02-07T10:28:56Z","pushed_at":"2018-02-07T09:52:25Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":10051,"stargazers_count":367,"watchers_count":367,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":145,"mirror_url":null,"archived":false,"open_issues_count":82,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":145,"open_issues":82,"watchers":367,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1146"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1146"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1146"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1146/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1146/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1146/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/316ebe9eddf6227509c7ecfd3f3ef1accc9db124"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"bokobza"}}