{"action":"created","comment":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/229398533","pull_request_review_id":169882221,"id":229398533,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTM5ODUzMw==","diff_hunk":"@@ -109,7 +110,8 @@ class DiscoveredService {\n         UUID uuidIn,\n         GattAttribute::Handle_t startHandleIn,\n         GattAttribute::Handle_t endHandleIn\n-    ) {\n+    )\n+    {","path":"features/FEATURE_BLE/ble/DiscoveredService.h","position":34,"original_position":34,"commit_id":"2a333563bc23ad3a2e427396cffd885fd648b09c","original_commit_id":"2a333563bc23ad3a2e427396cffd885fd648b09c","user":{"login":"pan-","id":409941,"node_id":"MDQ6VXNlcjQwOTk0MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/409941?v=4","gravatar_id":"","url":"https://api.github.com/users/pan-","html_url":"https://github.com/pan-","followers_url":"https://api.github.com/users/pan-/followers","following_url":"https://api.github.com/users/pan-/following{/other_user}","gists_url":"https://api.github.com/users/pan-/gists{/gist_id}","starred_url":"https://api.github.com/users/pan-/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pan-/subscriptions","organizations_url":"https://api.github.com/users/pan-/orgs","repos_url":"https://api.github.com/users/pan-/repos","events_url":"https://api.github.com/users/pan-/events{/privacy}","received_events_url":"https://api.github.com/users/pan-/received_events","type":"User","site_admin":false},"body":"same as above.","created_at":"2018-10-30T17:02:44Z","updated_at":"2018-10-30T17:23:06Z","html_url":"https://github.com/ARMmbed/mbed-os/pull/8591#discussion_r229398533","pull_request_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8591","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments/229398533"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8591#discussion_r229398533"},"pull_request":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8591"}}},"pull_request":{"url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8591","id":226963314,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2OTYzMzE0","html_url":"https://github.com/ARMmbed/mbed-os/pull/8591","diff_url":"https://github.com/ARMmbed/mbed-os/pull/8591.diff","patch_url":"https://github.com/ARMmbed/mbed-os/pull/8591.patch","issue_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8591","number":8591,"state":"open","locked":false,"title":"features: fix coding style","user":{"login":"0xc0170","id":2963726,"node_id":"MDQ6VXNlcjI5NjM3MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"body":"### Description\r\n\r\n<!-- \r\n    Required\r\n    Add here detailed changes summary, testing results, dependencies \r\n    Good example: https://os.mbed.com/docs/latest/reference/workflow.html (Pull request template)\r\n-->\r\n\r\nAStyle run on all features that we have (ignored folders are not being checked). This needs further work (we might not have ignore folders up to date, or some features might need update upstream). Let's review what can be updated and how. \r\n\r\n I'll add reviewers with questions about the features and its style (some might need some edits).\r\n\r\n\r\n### Pull request type\r\n\r\n<!-- \r\n    Required\r\n    Please add only one X to one of the following types. Do not fill multiple types (split the pull request otherwise).\r\n    Please note this is not a GitHub task list, indenting the boxes or changing the format to add a '.' or '*' in front\r\n    of them would change the meaning incorrectly. The only changes to be made are to add a description text under the\r\n    description heading and to add a 'x' to the correct box.\r\n-->\r\n    [X] Fix\r\n    [ ] Refactor\r\n    [ ] Target update\r\n    [ ] Functionality change\r\n    [ ] Docs update\r\n    [ ] Test update\r\n    [ ] Breaking change\r\n\r\n","created_at":"2018-10-30T15:13:22Z","updated_at":"2018-10-30T17:23:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"228042d85a36491ba98eef00231f2933a81892ff","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":407548740,"node_id":"MDU6TGFiZWw0MDc1NDg3NDA=","url":"https://api.github.com/repos/ARMmbed/mbed-os/labels/do%20not%20merge","name":"do not merge","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8591/commits","review_comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8591/comments","review_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8591/comments","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/2a333563bc23ad3a2e427396cffd885fd648b09c","head":{"label":"0xc0170:fix_coding_style_features","ref":"fix_coding_style_features","sha":"2a333563bc23ad3a2e427396cffd885fd648b09c","user":{"login":"0xc0170","id":2963726,"node_id":"MDQ6VXNlcjI5NjM3MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"repo":{"id":10604206,"node_id":"MDEwOlJlcG9zaXRvcnkxMDYwNDIwNg==","name":"mbed-os","full_name":"0xc0170/mbed-os","private":false,"owner":{"login":"0xc0170","id":2963726,"node_id":"MDQ6VXNlcjI5NjM3MjY=","avatar_url":"https://avatars0.githubusercontent.com/u/2963726?v=4","gravatar_id":"","url":"https://api.github.com/users/0xc0170","html_url":"https://github.com/0xc0170","followers_url":"https://api.github.com/users/0xc0170/followers","following_url":"https://api.github.com/users/0xc0170/following{/other_user}","gists_url":"https://api.github.com/users/0xc0170/gists{/gist_id}","starred_url":"https://api.github.com/users/0xc0170/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xc0170/subscriptions","organizations_url":"https://api.github.com/users/0xc0170/orgs","repos_url":"https://api.github.com/users/0xc0170/repos","events_url":"https://api.github.com/users/0xc0170/events{/privacy}","received_events_url":"https://api.github.com/users/0xc0170/received_events","type":"User","site_admin":false},"html_url":"https://github.com/0xc0170/mbed-os","description":"mbed libraries and tools","fork":true,"url":"https://api.github.com/repos/0xc0170/mbed-os","forks_url":"https://api.github.com/repos/0xc0170/mbed-os/forks","keys_url":"https://api.github.com/repos/0xc0170/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xc0170/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xc0170/mbed-os/teams","hooks_url":"https://api.github.com/repos/0xc0170/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/0xc0170/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/0xc0170/mbed-os/events","assignees_url":"https://api.github.com/repos/0xc0170/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/0xc0170/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/0xc0170/mbed-os/tags","blobs_url":"https://api.github.com/repos/0xc0170/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xc0170/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xc0170/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xc0170/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xc0170/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/0xc0170/mbed-os/languages","stargazers_url":"https://api.github.com/repos/0xc0170/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/0xc0170/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/0xc0170/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/0xc0170/mbed-os/subscription","commits_url":"https://api.github.com/repos/0xc0170/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xc0170/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xc0170/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xc0170/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xc0170/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/0xc0170/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xc0170/mbed-os/merges","archive_url":"https://api.github.com/repos/0xc0170/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xc0170/mbed-os/downloads","issues_url":"https://api.github.com/repos/0xc0170/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/0xc0170/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/0xc0170/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/0xc0170/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xc0170/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/0xc0170/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/0xc0170/mbed-os/deployments","created_at":"2013-06-10T16:09:18Z","updated_at":"2018-10-09T19:21:55Z","pushed_at":"2018-10-30T15:11:17Z","git_url":"git://github.com/0xc0170/mbed-os.git","ssh_url":"git@github.com:0xc0170/mbed-os.git","clone_url":"https://github.com/0xc0170/mbed-os.git","svn_url":"https://github.com/0xc0170/mbed-os","homepage":null,"size":231025,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"ARMmbed:master","ref":"master","sha":"1bbcfff8f331c2e00a3883ea27ca3c91461bc7a9","user":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"repo":{"id":8270972,"node_id":"MDEwOlJlcG9zaXRvcnk4MjcwOTcy","name":"mbed-os","full_name":"ARMmbed/mbed-os","private":false,"owner":{"login":"ARMmbed","id":8916057,"node_id":"MDEyOk9yZ2FuaXphdGlvbjg5MTYwNTc=","avatar_url":"https://avatars3.githubusercontent.com/u/8916057?v=4","gravatar_id":"","url":"https://api.github.com/users/ARMmbed","html_url":"https://github.com/ARMmbed","followers_url":"https://api.github.com/users/ARMmbed/followers","following_url":"https://api.github.com/users/ARMmbed/following{/other_user}","gists_url":"https://api.github.com/users/ARMmbed/gists{/gist_id}","starred_url":"https://api.github.com/users/ARMmbed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ARMmbed/subscriptions","organizations_url":"https://api.github.com/users/ARMmbed/orgs","repos_url":"https://api.github.com/users/ARMmbed/repos","events_url":"https://api.github.com/users/ARMmbed/events{/privacy}","received_events_url":"https://api.github.com/users/ARMmbed/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ARMmbed/mbed-os","description":"Arm Mbed OS is a platform operating system designed for the internet of things","fork":false,"url":"https://api.github.com/repos/ARMmbed/mbed-os","forks_url":"https://api.github.com/repos/ARMmbed/mbed-os/forks","keys_url":"https://api.github.com/repos/ARMmbed/mbed-os/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ARMmbed/mbed-os/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ARMmbed/mbed-os/teams","hooks_url":"https://api.github.com/repos/ARMmbed/mbed-os/hooks","issue_events_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/events{/number}","events_url":"https://api.github.com/repos/ARMmbed/mbed-os/events","assignees_url":"https://api.github.com/repos/ARMmbed/mbed-os/assignees{/user}","branches_url":"https://api.github.com/repos/ARMmbed/mbed-os/branches{/branch}","tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/tags","blobs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/refs{/sha}","trees_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/{sha}","languages_url":"https://api.github.com/repos/ARMmbed/mbed-os/languages","stargazers_url":"https://api.github.com/repos/ARMmbed/mbed-os/stargazers","contributors_url":"https://api.github.com/repos/ARMmbed/mbed-os/contributors","subscribers_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscribers","subscription_url":"https://api.github.com/repos/ARMmbed/mbed-os/subscription","commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/commits{/sha}","git_commits_url":"https://api.github.com/repos/ARMmbed/mbed-os/git/commits{/sha}","comments_url":"https://api.github.com/repos/ARMmbed/mbed-os/comments{/number}","issue_comment_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues/comments{/number}","contents_url":"https://api.github.com/repos/ARMmbed/mbed-os/contents/{+path}","compare_url":"https://api.github.com/repos/ARMmbed/mbed-os/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ARMmbed/mbed-os/merges","archive_url":"https://api.github.com/repos/ARMmbed/mbed-os/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ARMmbed/mbed-os/downloads","issues_url":"https://api.github.com/repos/ARMmbed/mbed-os/issues{/number}","pulls_url":"https://api.github.com/repos/ARMmbed/mbed-os/pulls{/number}","milestones_url":"https://api.github.com/repos/ARMmbed/mbed-os/milestones{/number}","notifications_url":"https://api.github.com/repos/ARMmbed/mbed-os/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ARMmbed/mbed-os/labels{/name}","releases_url":"https://api.github.com/repos/ARMmbed/mbed-os/releases{/id}","deployments_url":"https://api.github.com/repos/ARMmbed/mbed-os/deployments","created_at":"2013-02-18T15:23:11Z","updated_at":"2018-10-30T13:48:11Z","pushed_at":"2018-10-30T16:52:05Z","git_url":"git://github.com/ARMmbed/mbed-os.git","ssh_url":"git@github.com:ARMmbed/mbed-os.git","clone_url":"https://github.com/ARMmbed/mbed-os.git","svn_url":"https://github.com/ARMmbed/mbed-os","homepage":"https://mbed.com","size":234003,"stargazers_count":2019,"watchers_count":2019,"language":"C","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1654,"mirror_url":null,"archived":false,"open_issues_count":397,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1654,"open_issues":397,"watchers":2019,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8591"},"html":{"href":"https://github.com/ARMmbed/mbed-os/pull/8591"},"issue":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8591"},"comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/issues/8591/comments"},"review_comments":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8591/comments"},"review_comment":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/pulls/8591/commits"},"statuses":{"href":"https://api.github.com/repos/ARMmbed/mbed-os/statuses/2a333563bc23ad3a2e427396cffd885fd648b09c"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"pan-"}}