{"action":"created","comment":{"url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/comments/194281679","pull_request_review_id":127422067,"id":194281679,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NDI4MTY3OQ==","diff_hunk":"@@ -61,17 +61,22 @@ After these a number of fields will exist.\n | Y resolution | 4      | 'Y'   | uint32  | Frame Y resolution (rows)\n | Compression  | 1      | 'C'   | uint8   | Compression scheme in use (0 = uncompressed)\n \n+### Optional Header Field\n+\n+| Name         | Length | Code  | Type    | Description\n+| ------------ | ------ | ----- | ------- | ---------------------------------------------\n+| Device name  | ???    | 'D'   | string  | Device name e.g. camera model.\n+\n ### Future Header Fields\n \n Unsupported for now but likely to get added as optional fields soon:\n \n * Latitude\n * Longitude\n-* Camera model","path":"SPEC.md","position":16,"original_position":16,"commit_id":"2c95414cb9c25b32651d9e9b2d6dc1c21814657d","original_commit_id":"2c95414cb9c25b32651d9e9b2d6dc1c21814657d","user":{"login":"mjs","id":14993,"node_id":"MDQ6VXNlcjE0OTkz","avatar_url":"https://avatars0.githubusercontent.com/u/14993?v=4","gravatar_id":"","url":"https://api.github.com/users/mjs","html_url":"https://github.com/mjs","followers_url":"https://api.github.com/users/mjs/followers","following_url":"https://api.github.com/users/mjs/following{/other_user}","gists_url":"https://api.github.com/users/mjs/gists{/gist_id}","starred_url":"https://api.github.com/users/mjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mjs/subscriptions","organizations_url":"https://api.github.com/users/mjs/orgs","repos_url":"https://api.github.com/users/mjs/repos","events_url":"https://api.github.com/users/mjs/events{/privacy}","received_events_url":"https://api.github.com/users/mjs/received_events","type":"User","site_admin":false},"body":"as above, this doesn't need to go","created_at":"2018-06-11T02:25:53Z","updated_at":"2018-06-11T02:37:34Z","html_url":"https://github.com/TheCacophonyProject/go-cptv/pull/8#discussion_r194281679","pull_request_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/8","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/comments/194281679"},"html":{"href":"https://github.com/TheCacophonyProject/go-cptv/pull/8#discussion_r194281679"},"pull_request":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/8"}}},"pull_request":{"url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/8","id":193854282,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkzODU0Mjgy","html_url":"https://github.com/TheCacophonyProject/go-cptv/pull/8","diff_url":"https://github.com/TheCacophonyProject/go-cptv/pull/8.diff","patch_url":"https://github.com/TheCacophonyProject/go-cptv/pull/8.patch","issue_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/issues/8","number":8,"state":"open","locked":false,"title":"Added support for a device name field","user":{"login":"Davo36","id":8573616,"node_id":"MDQ6VXNlcjg1NzM2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8573616?v=4","gravatar_id":"","url":"https://api.github.com/users/Davo36","html_url":"https://github.com/Davo36","followers_url":"https://api.github.com/users/Davo36/followers","following_url":"https://api.github.com/users/Davo36/following{/other_user}","gists_url":"https://api.github.com/users/Davo36/gists{/gist_id}","starred_url":"https://api.github.com/users/Davo36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Davo36/subscriptions","organizations_url":"https://api.github.com/users/Davo36/orgs","repos_url":"https://api.github.com/users/Davo36/repos","events_url":"https://api.github.com/users/Davo36/events{/privacy}","received_events_url":"https://api.github.com/users/Davo36/received_events","type":"User","site_admin":false},"body":"Hi Menno, had a bit of a go at this over the weekend.\r\n\r\nNot sure if I've done it the way you would want or not...\r\n\r\nDid you want the version to be incremented?\r\n\r\nI don't have any of these files and so can't read any in to see if it will still read in the old ones.\r\n\r\nSo haven't tested any of this...\r\n\r\nAnd you said something about including an issue number with the pull request? Don't remember that bit sorry.\r\n\r\n\r\n","created_at":"2018-06-11T00:17:46Z","updated_at":"2018-06-11T02:37:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8134aa0e48eff3185029246decf1436de1370722","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/8/commits","review_comments_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/8/comments","review_comment_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/issues/8/comments","statuses_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/statuses/2c95414cb9c25b32651d9e9b2d6dc1c21814657d","head":{"label":"Davo36:add-device-name-field","ref":"add-device-name-field","sha":"2c95414cb9c25b32651d9e9b2d6dc1c21814657d","user":{"login":"Davo36","id":8573616,"node_id":"MDQ6VXNlcjg1NzM2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8573616?v=4","gravatar_id":"","url":"https://api.github.com/users/Davo36","html_url":"https://github.com/Davo36","followers_url":"https://api.github.com/users/Davo36/followers","following_url":"https://api.github.com/users/Davo36/following{/other_user}","gists_url":"https://api.github.com/users/Davo36/gists{/gist_id}","starred_url":"https://api.github.com/users/Davo36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Davo36/subscriptions","organizations_url":"https://api.github.com/users/Davo36/orgs","repos_url":"https://api.github.com/users/Davo36/repos","events_url":"https://api.github.com/users/Davo36/events{/privacy}","received_events_url":"https://api.github.com/users/Davo36/received_events","type":"User","site_admin":false},"repo":{"id":136761869,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY3NjE4Njk=","name":"go-cptv","full_name":"Davo36/go-cptv","owner":{"login":"Davo36","id":8573616,"node_id":"MDQ6VXNlcjg1NzM2MTY=","avatar_url":"https://avatars3.githubusercontent.com/u/8573616?v=4","gravatar_id":"","url":"https://api.github.com/users/Davo36","html_url":"https://github.com/Davo36","followers_url":"https://api.github.com/users/Davo36/followers","following_url":"https://api.github.com/users/Davo36/following{/other_user}","gists_url":"https://api.github.com/users/Davo36/gists{/gist_id}","starred_url":"https://api.github.com/users/Davo36/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Davo36/subscriptions","organizations_url":"https://api.github.com/users/Davo36/orgs","repos_url":"https://api.github.com/users/Davo36/repos","events_url":"https://api.github.com/users/Davo36/events{/privacy}","received_events_url":"https://api.github.com/users/Davo36/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Davo36/go-cptv","description":"Go package for creating and reading Cacophony Project Thermal Video (CPTV) files","fork":true,"url":"https://api.github.com/repos/Davo36/go-cptv","forks_url":"https://api.github.com/repos/Davo36/go-cptv/forks","keys_url":"https://api.github.com/repos/Davo36/go-cptv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Davo36/go-cptv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Davo36/go-cptv/teams","hooks_url":"https://api.github.com/repos/Davo36/go-cptv/hooks","issue_events_url":"https://api.github.com/repos/Davo36/go-cptv/issues/events{/number}","events_url":"https://api.github.com/repos/Davo36/go-cptv/events","assignees_url":"https://api.github.com/repos/Davo36/go-cptv/assignees{/user}","branches_url":"https://api.github.com/repos/Davo36/go-cptv/branches{/branch}","tags_url":"https://api.github.com/repos/Davo36/go-cptv/tags","blobs_url":"https://api.github.com/repos/Davo36/go-cptv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Davo36/go-cptv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Davo36/go-cptv/git/refs{/sha}","trees_url":"https://api.github.com/repos/Davo36/go-cptv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Davo36/go-cptv/statuses/{sha}","languages_url":"https://api.github.com/repos/Davo36/go-cptv/languages","stargazers_url":"https://api.github.com/repos/Davo36/go-cptv/stargazers","contributors_url":"https://api.github.com/repos/Davo36/go-cptv/contributors","subscribers_url":"https://api.github.com/repos/Davo36/go-cptv/subscribers","subscription_url":"https://api.github.com/repos/Davo36/go-cptv/subscription","commits_url":"https://api.github.com/repos/Davo36/go-cptv/commits{/sha}","git_commits_url":"https://api.github.com/repos/Davo36/go-cptv/git/commits{/sha}","comments_url":"https://api.github.com/repos/Davo36/go-cptv/comments{/number}","issue_comment_url":"https://api.github.com/repos/Davo36/go-cptv/issues/comments{/number}","contents_url":"https://api.github.com/repos/Davo36/go-cptv/contents/{+path}","compare_url":"https://api.github.com/repos/Davo36/go-cptv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Davo36/go-cptv/merges","archive_url":"https://api.github.com/repos/Davo36/go-cptv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Davo36/go-cptv/downloads","issues_url":"https://api.github.com/repos/Davo36/go-cptv/issues{/number}","pulls_url":"https://api.github.com/repos/Davo36/go-cptv/pulls{/number}","milestones_url":"https://api.github.com/repos/Davo36/go-cptv/milestones{/number}","notifications_url":"https://api.github.com/repos/Davo36/go-cptv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Davo36/go-cptv/labels{/name}","releases_url":"https://api.github.com/repos/Davo36/go-cptv/releases{/id}","deployments_url":"https://api.github.com/repos/Davo36/go-cptv/deployments","created_at":"2018-06-09T22:16:33Z","updated_at":"2018-06-09T22:16:35Z","pushed_at":"2018-06-11T00:09:19Z","git_url":"git://github.com/Davo36/go-cptv.git","ssh_url":"git@github.com:Davo36/go-cptv.git","clone_url":"https://github.com/Davo36/go-cptv.git","svn_url":"https://github.com/Davo36/go-cptv","homepage":null,"size":186,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TheCacophonyProject:master","ref":"master","sha":"1c46f1b86aa474833885988bad51f33ba49ac664","user":{"login":"TheCacophonyProject","id":9919710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk3MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9919710?v=4","gravatar_id":"","url":"https://api.github.com/users/TheCacophonyProject","html_url":"https://github.com/TheCacophonyProject","followers_url":"https://api.github.com/users/TheCacophonyProject/followers","following_url":"https://api.github.com/users/TheCacophonyProject/following{/other_user}","gists_url":"https://api.github.com/users/TheCacophonyProject/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCacophonyProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCacophonyProject/subscriptions","organizations_url":"https://api.github.com/users/TheCacophonyProject/orgs","repos_url":"https://api.github.com/users/TheCacophonyProject/repos","events_url":"https://api.github.com/users/TheCacophonyProject/events{/privacy}","received_events_url":"https://api.github.com/users/TheCacophonyProject/received_events","type":"Organization","site_admin":false},"repo":{"id":106466986,"node_id":"MDEwOlJlcG9zaXRvcnkxMDY0NjY5ODY=","name":"go-cptv","full_name":"TheCacophonyProject/go-cptv","owner":{"login":"TheCacophonyProject","id":9919710,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5MTk3MTA=","avatar_url":"https://avatars3.githubusercontent.com/u/9919710?v=4","gravatar_id":"","url":"https://api.github.com/users/TheCacophonyProject","html_url":"https://github.com/TheCacophonyProject","followers_url":"https://api.github.com/users/TheCacophonyProject/followers","following_url":"https://api.github.com/users/TheCacophonyProject/following{/other_user}","gists_url":"https://api.github.com/users/TheCacophonyProject/gists{/gist_id}","starred_url":"https://api.github.com/users/TheCacophonyProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheCacophonyProject/subscriptions","organizations_url":"https://api.github.com/users/TheCacophonyProject/orgs","repos_url":"https://api.github.com/users/TheCacophonyProject/repos","events_url":"https://api.github.com/users/TheCacophonyProject/events{/privacy}","received_events_url":"https://api.github.com/users/TheCacophonyProject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TheCacophonyProject/go-cptv","description":"Go package for creating and reading Cacophony Project Thermal Video (CPTV) files","fork":false,"url":"https://api.github.com/repos/TheCacophonyProject/go-cptv","forks_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/forks","keys_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/teams","hooks_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/hooks","issue_events_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/issues/events{/number}","events_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/events","assignees_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/assignees{/user}","branches_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/branches{/branch}","tags_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/tags","blobs_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/git/refs{/sha}","trees_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/statuses/{sha}","languages_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/languages","stargazers_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/stargazers","contributors_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/contributors","subscribers_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/subscribers","subscription_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/subscription","commits_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/commits{/sha}","git_commits_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/git/commits{/sha}","comments_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/comments{/number}","issue_comment_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/issues/comments{/number}","contents_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/contents/{+path}","compare_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/merges","archive_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/downloads","issues_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/issues{/number}","pulls_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls{/number}","milestones_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/milestones{/number}","notifications_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/labels{/name}","releases_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/releases{/id}","deployments_url":"https://api.github.com/repos/TheCacophonyProject/go-cptv/deployments","created_at":"2017-10-10T20:20:58Z","updated_at":"2018-05-25T02:18:43Z","pushed_at":"2018-06-11T00:17:46Z","git_url":"git://github.com/TheCacophonyProject/go-cptv.git","ssh_url":"git@github.com:TheCacophonyProject/go-cptv.git","clone_url":"https://github.com/TheCacophonyProject/go-cptv.git","svn_url":"https://github.com/TheCacophonyProject/go-cptv","homepage":null,"size":185,"stargazers_count":1,"watchers_count":1,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/8"},"html":{"href":"https://github.com/TheCacophonyProject/go-cptv/pull/8"},"issue":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/issues/8"},"comments":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/TheCacophonyProject/go-cptv/statuses/2c95414cb9c25b32651d9e9b2d6dc1c21814657d"}},"author_association":"NONE"}}
{"actor":{"display_login":"mjs"}}