{"action":"created","issue":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17912","repository_url":"https://api.github.com/repos/ManageIQ/manageiq","labels_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17912/labels{/name}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17912/comments","events_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17912/events","html_url":"https://github.com/ManageIQ/manageiq/pull/17912","id":354448901,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMjA4NDY2","number":17912,"title":"Adds task to subservices for correct retirement completion","user":{"login":"d-m-u","id":16326669,"node_id":"MDQ6VXNlcjE2MzI2NjY5","avatar_url":"https://avatars0.githubusercontent.com/u/16326669?v=4","gravatar_id":"","url":"https://api.github.com/users/d-m-u","html_url":"https://github.com/d-m-u","followers_url":"https://api.github.com/users/d-m-u/followers","following_url":"https://api.github.com/users/d-m-u/following{/other_user}","gists_url":"https://api.github.com/users/d-m-u/gists{/gist_id}","starred_url":"https://api.github.com/users/d-m-u/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/d-m-u/subscriptions","organizations_url":"https://api.github.com/users/d-m-u/orgs","repos_url":"https://api.github.com/users/d-m-u/repos","events_url":"https://api.github.com/users/d-m-u/events{/privacy}","received_events_url":"https://api.github.com/users/d-m-u/received_events","type":"User","site_admin":false},"labels":[{"id":382968361,"node_id":"MDU6TGFiZWwzODI5NjgzNjE=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/blocker","name":"blocker","color":"000000","default":false},{"id":106615676,"node_id":"MDU6TGFiZWwxMDY2MTU2NzY=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/bug","name":"bug","color":"ee0701","default":true},{"id":351114487,"node_id":"MDU6TGFiZWwzNTExMTQ0ODc=","url":"https://api.github.com/repos/ManageIQ/manageiq/labels/retirement","name":"retirement","color":"5319e7","default":false}],"state":"open","locked":false,"assignee":{"login":"gmcculloug","id":2591569,"node_id":"MDQ6VXNlcjI1OTE1Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/2591569?v=4","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false},"assignees":[{"login":"gmcculloug","id":2591569,"node_id":"MDQ6VXNlcjI1OTE1Njk=","avatar_url":"https://avatars0.githubusercontent.com/u/2591569?v=4","gravatar_id":"","url":"https://api.github.com/users/gmcculloug","html_url":"https://github.com/gmcculloug","followers_url":"https://api.github.com/users/gmcculloug/followers","following_url":"https://api.github.com/users/gmcculloug/following{/other_user}","gists_url":"https://api.github.com/users/gmcculloug/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcculloug/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcculloug/subscriptions","organizations_url":"https://api.github.com/users/gmcculloug/orgs","repos_url":"https://api.github.com/users/gmcculloug/repos","events_url":"https://api.github.com/users/gmcculloug/events{/privacy}","received_events_url":"https://api.github.com/users/gmcculloug/received_events","type":"User","site_admin":false}],"milestone":null,"comments":14,"created_at":"2018-08-27T19:36:05Z","updated_at":"2018-09-19T18:47:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq/pulls/17912","html_url":"https://github.com/ManageIQ/manageiq/pull/17912","diff_url":"https://github.com/ManageIQ/manageiq/pull/17912.diff","patch_url":"https://github.com/ManageIQ/manageiq/pull/17912.patch"},"body":"This changes the signature of the create_retire_subtask method to include the task, per the conversation @tinaafitz and @mkanoor and I had a week or so ago. \r\n\r\nIt's a fix for https://bugzilla.redhat.com/show_bug.cgi?id=1608958\r\n\r\nIssue #17993 opened to track virtual attributes occasionally returned by `attributes` method.\r\nhttps://github.com/ManageIQ/manageiq/pull/17996 opened by Keenan to fix 17993.\r\nTested with 17996, works as expected. Yay. So the workaround for excluding virtual attributes directly from the service task creation was removed because we could just get 17996 in and not have the TODO ... to do.\r\n\r\nThere's no point in opening the rails pr as mentioned because it's fixed in 5.2 and a bunch of the attribute stuff changed.  \r\n\r\n## Depends on\r\nhttps://github.com/ManageIQ/manageiq/pull/17996"},"comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq/issues/comments/422916216","html_url":"https://github.com/ManageIQ/manageiq/pull/17912#issuecomment-422916216","issue_url":"https://api.github.com/repos/ManageIQ/manageiq/issues/17912","id":422916216,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMjkxNjIxNg==","user":{"login":"miq-bot","id":7806257,"node_id":"MDQ6VXNlcjc4MDYyNTc=","avatar_url":"https://avatars1.githubusercontent.com/u/7806257?v=4","gravatar_id":"","url":"https://api.github.com/users/miq-bot","html_url":"https://github.com/miq-bot","followers_url":"https://api.github.com/users/miq-bot/followers","following_url":"https://api.github.com/users/miq-bot/following{/other_user}","gists_url":"https://api.github.com/users/miq-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/miq-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/miq-bot/subscriptions","organizations_url":"https://api.github.com/users/miq-bot/orgs","repos_url":"https://api.github.com/users/miq-bot/repos","events_url":"https://api.github.com/users/miq-bot/events{/privacy}","received_events_url":"https://api.github.com/users/miq-bot/received_events","type":"User","site_admin":false},"created_at":"2018-09-19T18:47:02Z","updated_at":"2018-09-19T18:47:02Z","author_association":"MEMBER","body":"<rubocop />Checked commits https://github.com/d-m-u/manageiq/compare/fd5f912461fb2dee816551ca7083e058d7557201~...3e9766e50cf4f9e25ac7dfee9b4ca8024c08716e with ruby 2.3.3, rubocop 0.52.1, haml-lint 0.20.0, and yamllint 1.10.0\n2 files checked, 0 offenses detected\nEverything looks fine. :cake:\n"}}
{"actor":{"display_login":"miq-bot"}}