{"action":"created","comment":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/comments/216057343","pull_request_review_id":153464973,"id":216057343,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjA1NzM0Mw==","diff_hunk":"@@ -0,0 +1,84 @@\n+require 'net/ftp'\n+require 'logger'\n+\n+# Helper methods for net/ftp based classes and files.\n+#\n+# Will setup a `@ftp` attr_accessor to be used as the return value for\n+# `.connect`, the main method being provided in this class.  Will also setup\n+# logging if not already done for the particular class (that follows the\n+# VmdbLogger conventions, and setup a `uri` attr_accessor if that doesn't\n+# already exist.\n+module MiqFtpLib","path":"lib/gems/pending/util/miq_ftp_lib.rb","position":11,"original_position":11,"commit_id":"afa483213714acbec170d1d0f77fd97fb4b91d2f","original_commit_id":"965cc702a574e224d707b2bedcaf101fe2d6f912","user":{"login":"NickLaMuro","id":314014,"node_id":"MDQ6VXNlcjMxNDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/314014?v=4","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"body":"Done.  I kept `attr_accessor :ftp` in since it has next to no meta-programming, but still tries to reach peak minimum LOC added, to appease @jrafanie ...","created_at":"2018-09-07T18:58:00Z","updated_at":"2018-09-07T18:58:00Z","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/360#discussion_r216057343","pull_request_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/360","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/comments/216057343"},"html":{"href":"https://github.com/ManageIQ/manageiq-gems-pending/pull/360#discussion_r216057343"},"pull_request":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/360"}},"in_reply_to_id":215637390},"pull_request":{"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/360","id":206552099,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTUyMDk5","html_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/360","diff_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/360.diff","patch_url":"https://github.com/ManageIQ/manageiq-gems-pending/pull/360.patch","issue_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/360","number":360,"state":"open","locked":false,"title":"Adds MiqFtpLib","user":{"login":"NickLaMuro","id":314014,"node_id":"MDQ6VXNlcjMxNDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/314014?v=4","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"body":"Helper module for common FTP interactions that will be shared in multiple parts of the `manageiq` codebase.\n\nLifted from `FileDepotFtp`, and will eventually replace some of the methods there (follow up PR).\n\n\nLinks\n-----\n\n* Originally extracted in https://github.com/ManageIQ/manageiq/pull/17549","created_at":"2018-08-07T00:47:55Z","updated_at":"2018-09-07T18:58:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"2cf808155209a44281138af319b5ad3cbca2c54c","assignee":{"login":"carbonin","id":12697904,"node_id":"MDQ6VXNlcjEyNjk3OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/12697904?v=4","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false},"assignees":[{"login":"carbonin","id":12697904,"node_id":"MDQ6VXNlcjEyNjk3OTA0","avatar_url":"https://avatars0.githubusercontent.com/u/12697904?v=4","gravatar_id":"","url":"https://api.github.com/users/carbonin","html_url":"https://github.com/carbonin","followers_url":"https://api.github.com/users/carbonin/followers","following_url":"https://api.github.com/users/carbonin/following{/other_user}","gists_url":"https://api.github.com/users/carbonin/gists{/gist_id}","starred_url":"https://api.github.com/users/carbonin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carbonin/subscriptions","organizations_url":"https://api.github.com/users/carbonin/orgs","repos_url":"https://api.github.com/users/carbonin/repos","events_url":"https://api.github.com/users/carbonin/events{/privacy}","received_events_url":"https://api.github.com/users/carbonin/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/360/commits","review_comments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/360/comments","review_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/360/comments","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/statuses/afa483213714acbec170d1d0f77fd97fb4b91d2f","head":{"label":"NickLaMuro:miq_ftp_lib","ref":"miq_ftp_lib","sha":"afa483213714acbec170d1d0f77fd97fb4b91d2f","user":{"login":"NickLaMuro","id":314014,"node_id":"MDQ6VXNlcjMxNDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/314014?v=4","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"repo":{"id":94137442,"node_id":"MDEwOlJlcG9zaXRvcnk5NDEzNzQ0Mg==","name":"manageiq-gems-pending","full_name":"NickLaMuro/manageiq-gems-pending","owner":{"login":"NickLaMuro","id":314014,"node_id":"MDQ6VXNlcjMxNDAxNA==","avatar_url":"https://avatars0.githubusercontent.com/u/314014?v=4","gravatar_id":"","url":"https://api.github.com/users/NickLaMuro","html_url":"https://github.com/NickLaMuro","followers_url":"https://api.github.com/users/NickLaMuro/followers","following_url":"https://api.github.com/users/NickLaMuro/following{/other_user}","gists_url":"https://api.github.com/users/NickLaMuro/gists{/gist_id}","starred_url":"https://api.github.com/users/NickLaMuro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NickLaMuro/subscriptions","organizations_url":"https://api.github.com/users/NickLaMuro/orgs","repos_url":"https://api.github.com/users/NickLaMuro/repos","events_url":"https://api.github.com/users/NickLaMuro/events{/privacy}","received_events_url":"https://api.github.com/users/NickLaMuro/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/NickLaMuro/manageiq-gems-pending","description":"Gems Pending to be extracted for ManageIQ project.","fork":true,"url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending","forks_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/forks","keys_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/teams","hooks_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/hooks","issue_events_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/issues/events{/number}","events_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/events","assignees_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/assignees{/user}","branches_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/branches{/branch}","tags_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/tags","blobs_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/git/refs{/sha}","trees_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/statuses/{sha}","languages_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/languages","stargazers_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/stargazers","contributors_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/contributors","subscribers_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/subscribers","subscription_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/subscription","commits_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/commits{/sha}","git_commits_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/git/commits{/sha}","comments_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/comments{/number}","issue_comment_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/issues/comments{/number}","contents_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/contents/{+path}","compare_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/merges","archive_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/downloads","issues_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/issues{/number}","pulls_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/pulls{/number}","milestones_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/milestones{/number}","notifications_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/labels{/name}","releases_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/releases{/id}","deployments_url":"https://api.github.com/repos/NickLaMuro/manageiq-gems-pending/deployments","created_at":"2017-06-12T20:27:20Z","updated_at":"2018-08-30T20:39:15Z","pushed_at":"2018-09-07T18:55:02Z","git_url":"git://github.com/NickLaMuro/manageiq-gems-pending.git","ssh_url":"git@github.com:NickLaMuro/manageiq-gems-pending.git","clone_url":"https://github.com/NickLaMuro/manageiq-gems-pending.git","svn_url":"https://github.com/NickLaMuro/manageiq-gems-pending","homepage":"","size":32705,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ManageIQ:master","ref":"master","sha":"eb3febfc890c6292493182e7586d2c8681640d3c","user":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"repo":{"id":72789777,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjc4OTc3Nw==","name":"manageiq-gems-pending","full_name":"ManageIQ/manageiq-gems-pending","owner":{"login":"ManageIQ","id":1125575,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExMjU1NzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1125575?v=4","gravatar_id":"","url":"https://api.github.com/users/ManageIQ","html_url":"https://github.com/ManageIQ","followers_url":"https://api.github.com/users/ManageIQ/followers","following_url":"https://api.github.com/users/ManageIQ/following{/other_user}","gists_url":"https://api.github.com/users/ManageIQ/gists{/gist_id}","starred_url":"https://api.github.com/users/ManageIQ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ManageIQ/subscriptions","organizations_url":"https://api.github.com/users/ManageIQ/orgs","repos_url":"https://api.github.com/users/ManageIQ/repos","events_url":"https://api.github.com/users/ManageIQ/events{/privacy}","received_events_url":"https://api.github.com/users/ManageIQ/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ManageIQ/manageiq-gems-pending","description":"Gems Pending to be extracted for ManageIQ project.","fork":false,"url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending","forks_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/forks","keys_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/teams","hooks_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/hooks","issue_events_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/events{/number}","events_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/events","assignees_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/assignees{/user}","branches_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/branches{/branch}","tags_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/tags","blobs_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/refs{/sha}","trees_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/statuses/{sha}","languages_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/languages","stargazers_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/stargazers","contributors_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/contributors","subscribers_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/subscribers","subscription_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/subscription","commits_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/commits{/sha}","git_commits_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/git/commits{/sha}","comments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/comments{/number}","issue_comment_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/comments{/number}","contents_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/contents/{+path}","compare_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/merges","archive_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/downloads","issues_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues{/number}","pulls_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls{/number}","milestones_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/milestones{/number}","notifications_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/labels{/name}","releases_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/releases{/id}","deployments_url":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/deployments","created_at":"2016-11-03T21:46:14Z","updated_at":"2018-08-30T17:52:40Z","pushed_at":"2018-09-07T18:55:03Z","git_url":"git://github.com/ManageIQ/manageiq-gems-pending.git","ssh_url":"git@github.com:ManageIQ/manageiq-gems-pending.git","clone_url":"https://github.com/ManageIQ/manageiq-gems-pending.git","svn_url":"https://github.com/ManageIQ/manageiq-gems-pending","homepage":"","size":32940,"stargazers_count":2,"watchers_count":2,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":63,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":63,"open_issues":7,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/360"},"html":{"href":"https://github.com/ManageIQ/manageiq-gems-pending/pull/360"},"issue":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/360"},"comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/issues/360/comments"},"review_comments":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/360/comments"},"review_comment":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/pulls/360/commits"},"statuses":{"href":"https://api.github.com/repos/ManageIQ/manageiq-gems-pending/statuses/afa483213714acbec170d1d0f77fd97fb4b91d2f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"NickLaMuro"}}