{"action":"created","comment":{"url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/comments/168048101","pull_request_review_id":96353144,"id":168048101,"diff_hunk":"@@ -0,0 +1,104 @@\n+import React, { Component } from 'react';\n+import PropTypes from 'prop-types';\n+import classnames from 'classnames';\n+\n+const propTypes = {\n+  /**\n+   * Children provided to the List component\n+   */\n+  children: PropTypes.node,\n+  /**\n+   * classname for the Dropdown\n+   */\n+  className: PropTypes.string,\n+  /**\n+   * The function when the Dropdown Item is disabled or not \n+   */\n+  isDisabled: PropTypes.bool,\n+  /**\n+   * The function to handle the click of the MenuItem\n+   */\n+  onBlur: PropTypes.func,\n+  /**\n+   * The function to handle the click of the MenuItem\n+   */\n+  onClick: PropTypes.func,\n+  /**\n+   * The tabIndex\n+   */\n+  tabIndex: PropTypes.number,\n+};\n+\n+const defaultProps = {\n+  children: [],\n+  className: '',\n+  isDisabled: false,\n+  onBlur: () => {},\n+  onClick: () => {},\n+  tabIndex: null,","path":"lib/components/Menu/MenuItem.js","position":38,"original_position":38,"commit_id":"d04107075668b269344acf3111c9dd394b9e79b2","original_commit_id":"d04107075668b269344acf3111c9dd394b9e79b2","user":{"login":"maxsonar","id":31537096,"avatar_url":"https://avatars0.githubusercontent.com/u/31537096?v=4","gravatar_id":"","url":"https://api.github.com/users/maxsonar","html_url":"https://github.com/maxsonar","followers_url":"https://api.github.com/users/maxsonar/followers","following_url":"https://api.github.com/users/maxsonar/following{/other_user}","gists_url":"https://api.github.com/users/maxsonar/gists{/gist_id}","starred_url":"https://api.github.com/users/maxsonar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/maxsonar/subscriptions","organizations_url":"https://api.github.com/users/maxsonar/orgs","repos_url":"https://api.github.com/users/maxsonar/repos","events_url":"https://api.github.com/users/maxsonar/events{/privacy}","received_events_url":"https://api.github.com/users/maxsonar/received_events","type":"User","site_admin":false},"body":"![BLOCKER](https://sonarsource.github.io/sonar-github/severity-blocker.png 'Severity: BLOCKER') Remove this trailing comma. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarqube.servicemax.io/coding_rules#rule_key=javascript%3ATrailingComma)\n","created_at":"2018-02-14T00:37:46Z","updated_at":"2018-02-14T00:37:46Z","html_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/21#discussion_r168048101","pull_request_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/21","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/comments/168048101"},"html":{"href":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/21#discussion_r168048101"},"pull_request":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/21"}}},"pull_request":{"url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/21","id":168634329,"html_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/21","diff_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/21.diff","patch_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/21.patch","issue_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/21","number":21,"state":"open","locked":false,"title":"Ui 429 dropdown","user":{"login":"sheela-svmx","id":34457496,"avatar_url":"https://avatars1.githubusercontent.com/u/34457496?v=4","gravatar_id":"","url":"https://api.github.com/users/sheela-svmx","html_url":"https://github.com/sheela-svmx","followers_url":"https://api.github.com/users/sheela-svmx/followers","following_url":"https://api.github.com/users/sheela-svmx/following{/other_user}","gists_url":"https://api.github.com/users/sheela-svmx/gists{/gist_id}","starred_url":"https://api.github.com/users/sheela-svmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheela-svmx/subscriptions","organizations_url":"https://api.github.com/users/sheela-svmx/orgs","repos_url":"https://api.github.com/users/sheela-svmx/repos","events_url":"https://api.github.com/users/sheela-svmx/events{/privacy}","received_events_url":"https://api.github.com/users/sheela-svmx/received_events","type":"User","site_admin":false},"body":"*Renames to Drop down \r\n* The way drop down works is it provides a default dropdown and a custom dropdown \r\n* updated Storybook\r\nTODO: I am updating the tests to add a few more tests\r\nJira for reference https://servicemax.atlassian.net/browse/UI-429 \r\n\r\n~~```~~\r\n~~<Dropdown>~~\r\n  ~~<Button type='small'>\r\n     ~~<Icon icon='down'> </Icon>~~\r\n  ~~</Button>~~\r\n  ~~<DropdownItem> Item1 ~~\r\n    ~~ <Icon type=\"cog\" /~~\r\n  ~~</DropdownItems>~~\r\n  ~~<DropdownItem> Item2 </DropdownItem>~~\r\n  ~~<DropdownItem> Item3 </DropdownItem>~~\r\n~~</Dropdown>~~\r\n~~```~~\r\n\r\n~~```~~\r\n~~<Dropdown items=[{'name': 'item1'}, {'name': 'item2'}]>  ~~\r\n~~```~~\r\n\r\nDefault \r\n```\r\n<Dropdown\r\n        display=\"Dropdown Button Default\"\r\n        items={[\r\n          { id: '1', name: 'Drop down item 1' },\r\n          { id: '2', name: 'Drop down item 2' },\r\n          { id: '3', name: 'Drop down item 3' }\r\n        ]}\r\n        onClick={action('dropdownClick')}\r\n      />\r\n```\r\n\r\nCustom\r\n``` \r\n<Dropdown>\r\n        <Button type=\"icon-container\" onClick={action('dropdownClick')} onBlur={action('dropdownClick')}>\r\n          <Icon icon=\"settings\" align=\"right\" />\r\n        </Button>\r\n        <Menu>\r\n          <MenuHeader> List </MenuHeader>\r\n          <MenuItem>Menu Item One</MenuItem>\r\n          <MenuItem disabled>Menu Item Two</MenuItem>\r\n          <MenuItem>Menu Item Three</MenuItem>\r\n          <MenuItem divider=\"top\">Menu Item Four</MenuItem>\r\n        </Menu>\r\n      </Dropdown>\r\n```\r\n","created_at":"2018-02-12T17:00:27Z","updated_at":"2018-02-14T00:37:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b9b8f5e798c3337547b73e6ad942379cd78e4b13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/21/commits","review_comments_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/21/comments","review_comment_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/21/comments","statuses_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/statuses/d04107075668b269344acf3111c9dd394b9e79b2","head":{"label":"sheela-svmx:UI-429-dropdown","ref":"UI-429-dropdown","sha":"d04107075668b269344acf3111c9dd394b9e79b2","user":{"login":"sheela-svmx","id":34457496,"avatar_url":"https://avatars1.githubusercontent.com/u/34457496?v=4","gravatar_id":"","url":"https://api.github.com/users/sheela-svmx","html_url":"https://github.com/sheela-svmx","followers_url":"https://api.github.com/users/sheela-svmx/followers","following_url":"https://api.github.com/users/sheela-svmx/following{/other_user}","gists_url":"https://api.github.com/users/sheela-svmx/gists{/gist_id}","starred_url":"https://api.github.com/users/sheela-svmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheela-svmx/subscriptions","organizations_url":"https://api.github.com/users/sheela-svmx/orgs","repos_url":"https://api.github.com/users/sheela-svmx/repos","events_url":"https://api.github.com/users/sheela-svmx/events{/privacy}","received_events_url":"https://api.github.com/users/sheela-svmx/received_events","type":"User","site_admin":false},"repo":{"id":118053707,"name":"ui-components-lightning","full_name":"sheela-svmx/ui-components-lightning","owner":{"login":"sheela-svmx","id":34457496,"avatar_url":"https://avatars1.githubusercontent.com/u/34457496?v=4","gravatar_id":"","url":"https://api.github.com/users/sheela-svmx","html_url":"https://github.com/sheela-svmx","followers_url":"https://api.github.com/users/sheela-svmx/followers","following_url":"https://api.github.com/users/sheela-svmx/following{/other_user}","gists_url":"https://api.github.com/users/sheela-svmx/gists{/gist_id}","starred_url":"https://api.github.com/users/sheela-svmx/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sheela-svmx/subscriptions","organizations_url":"https://api.github.com/users/sheela-svmx/orgs","repos_url":"https://api.github.com/users/sheela-svmx/repos","events_url":"https://api.github.com/users/sheela-svmx/events{/privacy}","received_events_url":"https://api.github.com/users/sheela-svmx/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sheela-svmx/ui-components-lightning","description":"UI 2.0 Lightning NPM repository for all Salesforce Lightning Design System components","fork":true,"url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning","forks_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/forks","keys_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/teams","hooks_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/hooks","issue_events_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/issues/events{/number}","events_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/events","assignees_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/assignees{/user}","branches_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/branches{/branch}","tags_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/tags","blobs_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/languages","stargazers_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/stargazers","contributors_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/contributors","subscribers_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/subscribers","subscription_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/subscription","commits_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/contents/{+path}","compare_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/merges","archive_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/downloads","issues_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/issues{/number}","pulls_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/labels{/name}","releases_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/releases{/id}","deployments_url":"https://api.github.com/repos/sheela-svmx/ui-components-lightning/deployments","created_at":"2018-01-19T00:08:40Z","updated_at":"2018-01-19T00:08:42Z","pushed_at":"2018-02-14T00:35:23Z","git_url":"git://github.com/sheela-svmx/ui-components-lightning.git","ssh_url":"git@github.com:sheela-svmx/ui-components-lightning.git","clone_url":"https://github.com/sheela-svmx/ui-components-lightning.git","svn_url":"https://github.com/sheela-svmx/ui-components-lightning","homepage":"","size":17121,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ServiceMax-Engineering:master","ref":"master","sha":"82a616a492cffb0428d1d55a90c5c4d8031c21b0","user":{"login":"ServiceMax-Engineering","id":13987655,"avatar_url":"https://avatars0.githubusercontent.com/u/13987655?v=4","gravatar_id":"","url":"https://api.github.com/users/ServiceMax-Engineering","html_url":"https://github.com/ServiceMax-Engineering","followers_url":"https://api.github.com/users/ServiceMax-Engineering/followers","following_url":"https://api.github.com/users/ServiceMax-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/ServiceMax-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/ServiceMax-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ServiceMax-Engineering/subscriptions","organizations_url":"https://api.github.com/users/ServiceMax-Engineering/orgs","repos_url":"https://api.github.com/users/ServiceMax-Engineering/repos","events_url":"https://api.github.com/users/ServiceMax-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/ServiceMax-Engineering/received_events","type":"Organization","site_admin":false},"repo":{"id":117293842,"name":"ui-components-lightning","full_name":"ServiceMax-Engineering/ui-components-lightning","owner":{"login":"ServiceMax-Engineering","id":13987655,"avatar_url":"https://avatars0.githubusercontent.com/u/13987655?v=4","gravatar_id":"","url":"https://api.github.com/users/ServiceMax-Engineering","html_url":"https://github.com/ServiceMax-Engineering","followers_url":"https://api.github.com/users/ServiceMax-Engineering/followers","following_url":"https://api.github.com/users/ServiceMax-Engineering/following{/other_user}","gists_url":"https://api.github.com/users/ServiceMax-Engineering/gists{/gist_id}","starred_url":"https://api.github.com/users/ServiceMax-Engineering/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ServiceMax-Engineering/subscriptions","organizations_url":"https://api.github.com/users/ServiceMax-Engineering/orgs","repos_url":"https://api.github.com/users/ServiceMax-Engineering/repos","events_url":"https://api.github.com/users/ServiceMax-Engineering/events{/privacy}","received_events_url":"https://api.github.com/users/ServiceMax-Engineering/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning","description":"UI 2.0 Lightning NPM repository for all Salesforce Lightning Design System components","fork":true,"url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning","forks_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/forks","keys_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/teams","hooks_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/hooks","issue_events_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/events{/number}","events_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/events","assignees_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/assignees{/user}","branches_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/branches{/branch}","tags_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/tags","blobs_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/refs{/sha}","trees_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/statuses/{sha}","languages_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/languages","stargazers_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/stargazers","contributors_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/contributors","subscribers_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/subscribers","subscription_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/subscription","commits_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/commits{/sha}","git_commits_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/git/commits{/sha}","comments_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/comments{/number}","issue_comment_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/comments{/number}","contents_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/contents/{+path}","compare_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/merges","archive_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/downloads","issues_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues{/number}","pulls_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls{/number}","milestones_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/milestones{/number}","notifications_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/labels{/name}","releases_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/releases{/id}","deployments_url":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/deployments","created_at":"2018-01-12T22:28:07Z","updated_at":"2018-01-19T17:49:02Z","pushed_at":"2018-02-14T00:35:24Z","git_url":"git://github.com/ServiceMax-Engineering/ui-components-lightning.git","ssh_url":"git@github.com:ServiceMax-Engineering/ui-components-lightning.git","clone_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning.git","svn_url":"https://github.com/ServiceMax-Engineering/ui-components-lightning","homepage":"","size":17120,"stargazers_count":1,"watchers_count":1,"language":"JavaScript","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":2,"license":null,"forks":5,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/21"},"html":{"href":"https://github.com/ServiceMax-Engineering/ui-components-lightning/pull/21"},"issue":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/21"},"comments":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/issues/21/comments"},"review_comments":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/21/comments"},"review_comment":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/pulls/21/commits"},"statuses":{"href":"https://api.github.com/repos/ServiceMax-Engineering/ui-components-lightning/statuses/d04107075668b269344acf3111c9dd394b9e79b2"}},"author_association":"NONE"}}
{"actor":{"display_login":"maxsonar"}}