{"action":"created","comment":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments/238121721","pull_request_review_id":180585812,"id":238121721,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzODEyMTcyMQ==","diff_hunk":"@@ -0,0 +1,80 @@\n+/*\n+ * Hibernate OGM, Domain model persistence for NoSQL datastores\n+ *\n+ * License: GNU Lesser General Public License (LGPL), version 2.1 or later\n+ * See the lgpl.txt file in the root directory or <http://www.gnu.org/licenses/lgpl-2.1.html>.\n+ */\n+package org.hibernate.ogm.backendtck.associations.order;\n+\n+import static org.fest.assertions.Assertions.assertThat;\n+\n+import javax.persistence.OrderBy;\n+\n+import org.hibernate.ogm.utils.OgmTestCase;\n+\n+import org.junit.After;\n+import org.junit.Test;\n+\n+/**\n+ * Tests the use of {@link OrderBy} qualifier, on load association list.\n+ *\n+ * @author Fabio Massimo Ercoli\n+ */\n+public class OrderByQualifierTest extends OgmTestCase {\n+\n+\tpublic static final String PROJECT_NAME = \"Hibernate OGM\";\n+\n+\tpublic static final String UNCLEBOB_ID = \"unclebob\";\n+\tpublic static final String DDALTO_ID = \"ddalto\";\n+\tpublic static final String TELEGRAPH_4_ETERNITY_ID = \"telegraph4eternity\";\n+\tpublic static final String FAX_4_EVER_ID = \"fax4ever\";\n+\tpublic static final String PHONE_4_INDUCTION_ID = \"phone4induction\";\n+\n+\tpublic static final Contributor UNCLEBOB = new Contributor( UNCLEBOB_ID, 370000 );\n+\tpublic static final Contributor DDALTO = new Contributor( DDALTO_ID, 23999 );\n+\tpublic static final Contributor TELEGRAPH_4_ETERNITY = new Contributor( TELEGRAPH_4_ETERNITY_ID, 5 );\n+\tpublic static final Contributor FAX_4_EVER = new Contributor( FAX_4_EVER_ID, 27 );\n+\tpublic static final Contributor PHONE_4_INDUCTION = new Contributor( PHONE_4_INDUCTION_ID, 9 );\n+\n+\t@Test\n+\tpublic void testOrderByQualifier() {\n+\t\tOpenSourceProject project = new OpenSourceProject();\n+\t\tproject.setName( PROJECT_NAME );\n+\n+\t\t// that's the original order:\n+\t\tproject.addContributor( UNCLEBOB );\n+\t\tproject.addContributor( DDALTO );\n+\t\tproject.addContributor( TELEGRAPH_4_ETERNITY );\n+\t\tproject.addContributor( FAX_4_EVER );\n+\t\tproject.addContributor( PHONE_4_INDUCTION );\n+\n+\t\tinTransaction( session -> persistAll( session, UNCLEBOB, DDALTO, TELEGRAPH_4_ETERNITY, FAX_4_EVER, PHONE_4_INDUCTION, project ) );\n+\n+\t\tinTransaction( session -> {\n+\t\t\tOpenSourceProject load = session.load( OpenSourceProject.class, PROJECT_NAME );\n+\n+\t\t\t// TODO: Switch to AssertJ, so that we will able to do something like that:\n+\t\t\t// assertThat( load.getContributors() ).containsExactly( ... );","path":"core/src/test/java/org/hibernate/ogm/backendtck/associations/order/OrderByQualifierTest.java","position":57,"original_position":57,"commit_id":"9bbf1f71f4fd1d86095f99c491946f7c9fc66336","original_commit_id":"9bbf1f71f4fd1d86095f99c491946f7c9fc66336","user":{"login":"DavideD","id":559221,"node_id":"MDQ6VXNlcjU1OTIyMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/559221?v=4","gravatar_id":"","url":"https://api.github.com/users/DavideD","html_url":"https://github.com/DavideD","followers_url":"https://api.github.com/users/DavideD/followers","following_url":"https://api.github.com/users/DavideD/following{/other_user}","gists_url":"https://api.github.com/users/DavideD/gists{/gist_id}","starred_url":"https://api.github.com/users/DavideD/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DavideD/subscriptions","organizations_url":"https://api.github.com/users/DavideD/orgs","repos_url":"https://api.github.com/users/DavideD/repos","events_url":"https://api.github.com/users/DavideD/events{/privacy}","received_events_url":"https://api.github.com/users/DavideD/received_events","type":"User","site_admin":false},"body":"This comment is misleading, you can already use containsExactly ","created_at":"2018-12-03T00:01:57Z","updated_at":"2018-12-03T00:01:58Z","html_url":"https://github.com/hibernate/hibernate-ogm/pull/1096#discussion_r238121721","pull_request_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/1096","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments/238121721"},"html":{"href":"https://github.com/hibernate/hibernate-ogm/pull/1096#discussion_r238121721"},"pull_request":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/1096"}}},"pull_request":{"url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/1096","id":227981913,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTgxOTEz","html_url":"https://github.com/hibernate/hibernate-ogm/pull/1096","diff_url":"https://github.com/hibernate/hibernate-ogm/pull/1096.diff","patch_url":"https://github.com/hibernate/hibernate-ogm/pull/1096.patch","issue_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/1096","number":1096,"state":"open","locked":false,"title":"OGM-1538 Support @OrderBy qualifier","user":{"login":"fax4ever","id":1748775,"node_id":"MDQ6VXNlcjE3NDg3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1748775?v=4","gravatar_id":"","url":"https://api.github.com/users/fax4ever","html_url":"https://github.com/fax4ever","followers_url":"https://api.github.com/users/fax4ever/followers","following_url":"https://api.github.com/users/fax4ever/following{/other_user}","gists_url":"https://api.github.com/users/fax4ever/gists{/gist_id}","starred_url":"https://api.github.com/users/fax4ever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fax4ever/subscriptions","organizations_url":"https://api.github.com/users/fax4ever/orgs","repos_url":"https://api.github.com/users/fax4ever/repos","events_url":"https://api.github.com/users/fax4ever/events{/privacy}","received_events_url":"https://api.github.com/users/fax4ever/received_events","type":"User","site_admin":false},"body":"https://hibernate.atlassian.net/browse/OGM-1538","created_at":"2018-11-02T15:55:04Z","updated_at":"2018-12-03T00:01:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"1d4b19fcb8d977f0ae24c128a390d42a751688bc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/1096/commits","review_comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/1096/comments","review_comment_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/1096/comments","statuses_url":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/9bbf1f71f4fd1d86095f99c491946f7c9fc66336","head":{"label":"fax4ever:1538-association-order-by","ref":"1538-association-order-by","sha":"9bbf1f71f4fd1d86095f99c491946f7c9fc66336","user":{"login":"fax4ever","id":1748775,"node_id":"MDQ6VXNlcjE3NDg3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1748775?v=4","gravatar_id":"","url":"https://api.github.com/users/fax4ever","html_url":"https://github.com/fax4ever","followers_url":"https://api.github.com/users/fax4ever/followers","following_url":"https://api.github.com/users/fax4ever/following{/other_user}","gists_url":"https://api.github.com/users/fax4ever/gists{/gist_id}","starred_url":"https://api.github.com/users/fax4ever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fax4ever/subscriptions","organizations_url":"https://api.github.com/users/fax4ever/orgs","repos_url":"https://api.github.com/users/fax4ever/repos","events_url":"https://api.github.com/users/fax4ever/events{/privacy}","received_events_url":"https://api.github.com/users/fax4ever/received_events","type":"User","site_admin":false},"repo":{"id":113314356,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzMTQzNTY=","name":"hibernate-ogm","full_name":"fax4ever/hibernate-ogm","private":false,"owner":{"login":"fax4ever","id":1748775,"node_id":"MDQ6VXNlcjE3NDg3NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/1748775?v=4","gravatar_id":"","url":"https://api.github.com/users/fax4ever","html_url":"https://github.com/fax4ever","followers_url":"https://api.github.com/users/fax4ever/followers","following_url":"https://api.github.com/users/fax4ever/following{/other_user}","gists_url":"https://api.github.com/users/fax4ever/gists{/gist_id}","starred_url":"https://api.github.com/users/fax4ever/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fax4ever/subscriptions","organizations_url":"https://api.github.com/users/fax4ever/orgs","repos_url":"https://api.github.com/users/fax4ever/repos","events_url":"https://api.github.com/users/fax4ever/events{/privacy}","received_events_url":"https://api.github.com/users/fax4ever/received_events","type":"User","site_admin":false},"html_url":"https://github.com/fax4ever/hibernate-ogm","description":"Hibernate OGM - Domain model persistence for NoSQL datastores","fork":true,"url":"https://api.github.com/repos/fax4ever/hibernate-ogm","forks_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/forks","keys_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/teams","hooks_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/hooks","issue_events_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/issues/events{/number}","events_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/events","assignees_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/assignees{/user}","branches_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/branches{/branch}","tags_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/tags","blobs_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/git/refs{/sha}","trees_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/statuses/{sha}","languages_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/languages","stargazers_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/stargazers","contributors_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/contributors","subscribers_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/subscribers","subscription_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/subscription","commits_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/commits{/sha}","git_commits_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/git/commits{/sha}","comments_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/comments{/number}","issue_comment_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/issues/comments{/number}","contents_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/contents/{+path}","compare_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/merges","archive_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/downloads","issues_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/issues{/number}","pulls_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/pulls{/number}","milestones_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/milestones{/number}","notifications_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/labels{/name}","releases_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/releases{/id}","deployments_url":"https://api.github.com/repos/fax4ever/hibernate-ogm/deployments","created_at":"2017-12-06T12:37:26Z","updated_at":"2018-11-26T07:30:01Z","pushed_at":"2018-11-28T14:19:36Z","git_url":"git://github.com/fax4ever/hibernate-ogm.git","ssh_url":"git@github.com:fax4ever/hibernate-ogm.git","clone_url":"https://github.com/fax4ever/hibernate-ogm.git","svn_url":"https://github.com/fax4ever/hibernate-ogm","homepage":"http://hibernate.org/ogm/","size":17302,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hibernate:master","ref":"master","sha":"a62ee2dd74d24894b519320fa18b68e7506c11f8","user":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"repo":{"id":1608936,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA4OTM2","name":"hibernate-ogm","full_name":"hibernate/hibernate-ogm","private":false,"owner":{"login":"hibernate","id":348262,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM0ODI2Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/348262?v=4","gravatar_id":"","url":"https://api.github.com/users/hibernate","html_url":"https://github.com/hibernate","followers_url":"https://api.github.com/users/hibernate/followers","following_url":"https://api.github.com/users/hibernate/following{/other_user}","gists_url":"https://api.github.com/users/hibernate/gists{/gist_id}","starred_url":"https://api.github.com/users/hibernate/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hibernate/subscriptions","organizations_url":"https://api.github.com/users/hibernate/orgs","repos_url":"https://api.github.com/users/hibernate/repos","events_url":"https://api.github.com/users/hibernate/events{/privacy}","received_events_url":"https://api.github.com/users/hibernate/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hibernate/hibernate-ogm","description":"Hibernate OGM - Domain model persistence for NoSQL datastores","fork":false,"url":"https://api.github.com/repos/hibernate/hibernate-ogm","forks_url":"https://api.github.com/repos/hibernate/hibernate-ogm/forks","keys_url":"https://api.github.com/repos/hibernate/hibernate-ogm/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hibernate/hibernate-ogm/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hibernate/hibernate-ogm/teams","hooks_url":"https://api.github.com/repos/hibernate/hibernate-ogm/hooks","issue_events_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/events{/number}","events_url":"https://api.github.com/repos/hibernate/hibernate-ogm/events","assignees_url":"https://api.github.com/repos/hibernate/hibernate-ogm/assignees{/user}","branches_url":"https://api.github.com/repos/hibernate/hibernate-ogm/branches{/branch}","tags_url":"https://api.github.com/repos/hibernate/hibernate-ogm/tags","blobs_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/refs{/sha}","trees_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/{sha}","languages_url":"https://api.github.com/repos/hibernate/hibernate-ogm/languages","stargazers_url":"https://api.github.com/repos/hibernate/hibernate-ogm/stargazers","contributors_url":"https://api.github.com/repos/hibernate/hibernate-ogm/contributors","subscribers_url":"https://api.github.com/repos/hibernate/hibernate-ogm/subscribers","subscription_url":"https://api.github.com/repos/hibernate/hibernate-ogm/subscription","commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/commits{/sha}","git_commits_url":"https://api.github.com/repos/hibernate/hibernate-ogm/git/commits{/sha}","comments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/comments{/number}","issue_comment_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/comments{/number}","contents_url":"https://api.github.com/repos/hibernate/hibernate-ogm/contents/{+path}","compare_url":"https://api.github.com/repos/hibernate/hibernate-ogm/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hibernate/hibernate-ogm/merges","archive_url":"https://api.github.com/repos/hibernate/hibernate-ogm/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hibernate/hibernate-ogm/downloads","issues_url":"https://api.github.com/repos/hibernate/hibernate-ogm/issues{/number}","pulls_url":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls{/number}","milestones_url":"https://api.github.com/repos/hibernate/hibernate-ogm/milestones{/number}","notifications_url":"https://api.github.com/repos/hibernate/hibernate-ogm/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hibernate/hibernate-ogm/labels{/name}","releases_url":"https://api.github.com/repos/hibernate/hibernate-ogm/releases{/id}","deployments_url":"https://api.github.com/repos/hibernate/hibernate-ogm/deployments","created_at":"2011-04-13T11:40:56Z","updated_at":"2018-11-29T22:07:58Z","pushed_at":"2018-11-28T13:41:13Z","git_url":"git://github.com/hibernate/hibernate-ogm.git","ssh_url":"git@github.com:hibernate/hibernate-ogm.git","clone_url":"https://github.com/hibernate/hibernate-ogm.git","svn_url":"https://github.com/hibernate/hibernate-ogm","homepage":"http://hibernate.org/ogm/","size":17312,"stargazers_count":267,"watchers_count":267,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":191,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":191,"open_issues":2,"watchers":267,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/1096"},"html":{"href":"https://github.com/hibernate/hibernate-ogm/pull/1096"},"issue":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/1096"},"comments":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/issues/1096/comments"},"review_comments":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/1096/comments"},"review_comment":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/pulls/1096/commits"},"statuses":{"href":"https://api.github.com/repos/hibernate/hibernate-ogm/statuses/9bbf1f71f4fd1d86095f99c491946f7c9fc66336"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"DavideD"}}