{"action":"created","issue":{"url":"https://api.github.com/repos/ironhack-labs/lab-react-ironcontacts/issues/28","repository_url":"https://api.github.com/repos/ironhack-labs/lab-react-ironcontacts","labels_url":"https://api.github.com/repos/ironhack-labs/lab-react-ironcontacts/issues/28/labels{/name}","comments_url":"https://api.github.com/repos/ironhack-labs/lab-react-ironcontacts/issues/28/comments","events_url":"https://api.github.com/repos/ironhack-labs/lab-react-ironcontacts/issues/28/events","html_url":"https://github.com/ironhack-labs/lab-react-ironcontacts/pull/28","id":365962934,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NzU0MjA2","number":28,"title":"[MAD PP] Raúl Martín + Laura Migueláñez","user":{"login":"lauramiguelanez","id":33348659,"node_id":"MDQ6VXNlcjMzMzQ4NjU5","avatar_url":"https://avatars3.githubusercontent.com/u/33348659?v=4","gravatar_id":"","url":"https://api.github.com/users/lauramiguelanez","html_url":"https://github.com/lauramiguelanez","followers_url":"https://api.github.com/users/lauramiguelanez/followers","following_url":"https://api.github.com/users/lauramiguelanez/following{/other_user}","gists_url":"https://api.github.com/users/lauramiguelanez/gists{/gist_id}","starred_url":"https://api.github.com/users/lauramiguelanez/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lauramiguelanez/subscriptions","organizations_url":"https://api.github.com/users/lauramiguelanez/orgs","repos_url":"https://api.github.com/users/lauramiguelanez/repos","events_url":"https://api.github.com/users/lauramiguelanez/events{/privacy}","received_events_url":"https://api.github.com/users/lauramiguelanez/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-02T15:48:09Z","updated_at":"2018-10-03T08:30:45Z","closed_at":"2018-10-03T08:30:45Z","author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/ironhack-labs/lab-react-ironcontacts/pulls/28","html_url":"https://github.com/ironhack-labs/lab-react-ironcontacts/pull/28","diff_url":"https://github.com/ironhack-labs/lab-react-ironcontacts/pull/28.diff","patch_url":"https://github.com/ironhack-labs/lab-react-ironcontacts/pull/28.patch"},"body":"Bien"},"comment":{"url":"https://api.github.com/repos/ironhack-labs/lab-react-ironcontacts/issues/comments/426554075","html_url":"https://github.com/ironhack-labs/lab-react-ironcontacts/pull/28#issuecomment-426554075","issue_url":"https://api.github.com/repos/ironhack-labs/lab-react-ironcontacts/issues/28","id":426554075,"node_id":"MDEyOklzc3VlQ29tbWVudDQyNjU1NDA3NQ==","user":{"login":"ta-web-mad","id":26923217,"node_id":"MDQ6VXNlcjI2OTIzMjE3","avatar_url":"https://avatars3.githubusercontent.com/u/26923217?v=4","gravatar_id":"","url":"https://api.github.com/users/ta-web-mad","html_url":"https://github.com/ta-web-mad","followers_url":"https://api.github.com/users/ta-web-mad/followers","following_url":"https://api.github.com/users/ta-web-mad/following{/other_user}","gists_url":"https://api.github.com/users/ta-web-mad/gists{/gist_id}","starred_url":"https://api.github.com/users/ta-web-mad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ta-web-mad/subscriptions","organizations_url":"https://api.github.com/users/ta-web-mad/orgs","repos_url":"https://api.github.com/users/ta-web-mad/repos","events_url":"https://api.github.com/users/ta-web-mad/events{/privacy}","received_events_url":"https://api.github.com/users/ta-web-mad/received_events","type":"User","site_admin":false},"created_at":"2018-10-03T08:30:45Z","updated_at":"2018-10-03T08:30:45Z","author_association":"NONE","body":"Buen trabajo chicos, lo único que podríais modificar es agrupar las dos funciones de ordenación en una sola ya que como veis hacen lo mismo.\r\nOs pongo un ejemplo de la posible solución:\r\n```\r\n  sortContacts = (type) => {\r\n    let ordered = this.state.selectedContacts.sort((a,b) => {\r\n    \r\n    return type==\"name\" ? b.name.localeCompare(a.name) :  b.popularity - a.popularity\r\n    })\r\n    this.setState({\r\n      selectedContacts: ordered\r\n    })\r\n  }  \r\n```\r\nPor lo demás el ejercicio está completo y muy bien resuelto, me ha gustado mucho la modularización en componentes que os va a venir genial de cara al resto de semana y al tercer proyecto.\r\nSeguid así 💯 \r\n#checked#closed#dʒiego 👌"}}
{"actor":{"display_login":"ta-web-mad"}}