{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37012","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37012/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37012/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37012/events","html_url":"https://github.com/NixOS/nixpkgs/pull/37012","id":305296783,"number":37012,"title":"Make \"localizations\" sane again","user":{"login":"matthewbauer","id":19036,"avatar_url":"https://avatars0.githubusercontent.com/u/19036?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewbauer","html_url":"https://github.com/matthewbauer","followers_url":"https://api.github.com/users/matthewbauer/followers","following_url":"https://api.github.com/users/matthewbauer/following{/other_user}","gists_url":"https://api.github.com/users/matthewbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewbauer/subscriptions","organizations_url":"https://api.github.com/users/matthewbauer/orgs","repos_url":"https://api.github.com/users/matthewbauer/repos","events_url":"https://api.github.com/users/matthewbauer/events{/privacy}","received_events_url":"https://api.github.com/users/matthewbauer/received_events","type":"User","site_admin":false},"labels":[{"id":737692408,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin-stdenv","name":"10.rebuild-darwin-stdenv","color":"b60205","default":false},{"id":731735740,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%20501+","name":"10.rebuild-darwin: 501+","color":"b60205","default":false},{"id":737692313,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux-stdenv","name":"10.rebuild-linux-stdenv","color":"b60205","default":false},{"id":731734523,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false},{"id":854046194,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/6.topic:%20portability","name":"6.topic: portability","color":"fef2c0","default":false},{"id":290122988,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20clean-up","name":"8.has: clean-up","color":"009800","default":false},{"id":290122734,"url":"https://api.github.com/repos/NixOS/nixpkgs/labels/8.has:%20package%20(new)","name":"8.has: package (new)","color":"009800","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/NixOS/nixpkgs/milestones/13","html_url":"https://github.com/NixOS/nixpkgs/milestone/13","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones/13/labels","id":2676453,"number":13,"title":"18.09","description":"Nixpkgs/NixOS 18.09 stable release.\r\n\r\nRelease managers are @vcunat and ???.","creator":{"login":"globin","id":1447245,"avatar_url":"https://avatars3.githubusercontent.com/u/1447245?v=4","gravatar_id":"","url":"https://api.github.com/users/globin","html_url":"https://github.com/globin","followers_url":"https://api.github.com/users/globin/followers","following_url":"https://api.github.com/users/globin/following{/other_user}","gists_url":"https://api.github.com/users/globin/gists{/gist_id}","starred_url":"https://api.github.com/users/globin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/globin/subscriptions","organizations_url":"https://api.github.com/users/globin/orgs","repos_url":"https://api.github.com/users/globin/repos","events_url":"https://api.github.com/users/globin/events{/privacy}","received_events_url":"https://api.github.com/users/globin/received_events","type":"User","site_admin":false},"open_issues":14,"closed_issues":1,"state":"open","created_at":"2017-08-02T12:18:49Z","updated_at":"2018-03-23T11:25:41Z","due_on":"2018-09-27T07:00:00Z","closed_at":null},"comments":40,"created_at":"2018-03-14T19:24:27Z","updated_at":"2018-03-25T02:58:30Z","closed_at":"2018-03-23T01:39:31Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/37012","html_url":"https://github.com/NixOS/nixpkgs/pull/37012","diff_url":"https://github.com/NixOS/nixpkgs/pull/37012.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/37012.patch"},"body":"###### Motivation for this change\r\nThis is a fairly big PR, so I'll list out what it does:\r\n\r\n- deprecate \"libintlOrEmpty\". This was an ugly name for an attribute. Instead you can just use \"libintl\" which is an alias to gettext when libc != glibc. It now acts similarly to \"libiconv\" and you can add it to any derivation needing libintl (no need to use stdenv.isDarwin anymore!)\r\n- adds setup-hook to gettext to add \"-lintl\" to LDFLAGS\r\n- adds setup-hook to iconv to add \"-liconv\" to LDFLAGS\r\n- removes all of the hacks adding \"-liconv\" and \"-lintl\", treewide\r\n\r\nI'm interested in comments on whether this is a good idea!\r\n\r\n/cc @Ericson2314 @LnL7 @copumpkin @NixOS/darwin-maintainers "},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/375941609","html_url":"https://github.com/NixOS/nixpkgs/pull/37012#issuecomment-375941609","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/37012","id":375941609,"user":{"login":"matthewbauer","id":19036,"avatar_url":"https://avatars0.githubusercontent.com/u/19036?v=4","gravatar_id":"","url":"https://api.github.com/users/matthewbauer","html_url":"https://github.com/matthewbauer","followers_url":"https://api.github.com/users/matthewbauer/followers","following_url":"https://api.github.com/users/matthewbauer/following{/other_user}","gists_url":"https://api.github.com/users/matthewbauer/gists{/gist_id}","starred_url":"https://api.github.com/users/matthewbauer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthewbauer/subscriptions","organizations_url":"https://api.github.com/users/matthewbauer/orgs","repos_url":"https://api.github.com/users/matthewbauer/repos","events_url":"https://api.github.com/users/matthewbauer/events{/privacy}","received_events_url":"https://api.github.com/users/matthewbauer/received_events","type":"User","site_admin":false},"created_at":"2018-03-25T02:58:30Z","updated_at":"2018-03-25T02:58:30Z","author_association":"MEMBER","body":"@Ericson2314 Looks like there is some breakage, but hopefully it's not too bad:\r\n\r\ngobject-introspection is now failing: https://hydra.nixos.org/build/71894082/nixlog/1\r\n\r\n```\r\nld: library not found for -liconv\r\n```\r\n\r\nAny idea why it can't find libiconv?"}}
{"actor":{"display_login":"matthewbauer"}}