{"push_id":2344198897,"size":4,"distinct_size":0,"ref":"refs/heads/deployed-to-staging","head":"6448fdd081f282488d0e7532879b91ad3b037b48","before":"7de9e0a00a8664ea777cbcb52cb82b2c4ad66c6d","commits":[{"sha":"8b600d662df01fc4be07384a011530134ab0b546","author":{"name":"Chris Lowis","email":"16773d64d16306a118f94167139f1f8aaf3bbac5@gmail.com"},"message":"Use worker for asset size migration\n\nIn 16e323e we added a rake task to set the `size` field for all\nexisting assets. When we ran the task in integration however, we\nestimated that it would take around 12 hours to complete. This runs\nthe risk of the rake task being killed and leaving the database in a\nsomewhat inconsistent state.\n\nThis commit moves the work of the rake task into a worker. Hopefully\nthis will improve the run time as the workers run with concurrency,\nand the rake task that queues up the jobs will complete more quickly.","distinct":false,"url":"https://api.github.com/repos/alphagov/asset-manager/commits/8b600d662df01fc4be07384a011530134ab0b546"},{"sha":"b65c83a70213c34685947be056c115931d719e7f","author":{"name":"Chris Lowis","email":"16773d64d16306a118f94167139f1f8aaf3bbac5@gmail.com"},"message":"Use `set` instead of `save` to set size\n\nAs per @floehopper's suggestion[1], this avoids the risk of any\nunintended side-effects from calling `save`.\n\n[1] https://github.com/alphagov/asset-manager/pull/484#discussion_r169308928","distinct":false,"url":"https://api.github.com/repos/alphagov/asset-manager/commits/b65c83a70213c34685947be056c115931d719e7f"},{"sha":"02fdaba787e35f31518cfa94e7517acab89be4b8","author":{"name":"Chris Lowis","email":"16773d64d16306a118f94167139f1f8aaf3bbac5@gmail.com"},"message":"Inline Asset#set_size_from_etag\n\nThis method is only called from SetAssetSizeWorker, which is called as\npart of a migration. We don't intend to use it in any production code\nso it makes sense to inline it in the worker and remove it once the\nmigration has run.","distinct":false,"url":"https://api.github.com/repos/alphagov/asset-manager/commits/02fdaba787e35f31518cfa94e7517acab89be4b8"},{"sha":"6448fdd081f282488d0e7532879b91ad3b037b48","author":{"name":"Chris Lowis","email":"16773d64d16306a118f94167139f1f8aaf3bbac5@gmail.com"},"message":"Merge pull request #484 from alphagov/move-set-size-rake-task-to-worker\n\nUse worker for asset size migration","distinct":false,"url":"https://api.github.com/repos/alphagov/asset-manager/commits/6448fdd081f282488d0e7532879b91ad3b037b48"}]}
{"actor":{"display_login":"govuk-ci"}}