{"action":"created","issue":{"url":"https://api.github.com/repos/angular/angular/issues/22209","repository_url":"https://api.github.com/repos/angular/angular","labels_url":"https://api.github.com/repos/angular/angular/issues/22209/labels{/name}","comments_url":"https://api.github.com/repos/angular/angular/issues/22209/comments","events_url":"https://api.github.com/repos/angular/angular/issues/22209/events","html_url":"https://github.com/angular/angular/pull/22209","id":296907286,"number":22209,"title":"fix(upgrade): need to call markForCheck on child changeDetectorRef","user":{"login":"smdunn","id":14301831,"avatar_url":"https://avatars1.githubusercontent.com/u/14301831?v=4","gravatar_id":"","url":"https://api.github.com/users/smdunn","html_url":"https://github.com/smdunn","followers_url":"https://api.github.com/users/smdunn/followers","following_url":"https://api.github.com/users/smdunn/following{/other_user}","gists_url":"https://api.github.com/users/smdunn/gists{/gist_id}","starred_url":"https://api.github.com/users/smdunn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smdunn/subscriptions","organizations_url":"https://api.github.com/users/smdunn/orgs","repos_url":"https://api.github.com/users/smdunn/repos","events_url":"https://api.github.com/users/smdunn/events{/privacy}","received_events_url":"https://api.github.com/users/smdunn/received_events","type":"User","site_admin":false},"labels":[{"id":133556520,"url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge","name":"PR action: merge","color":"99ff66","default":false},{"id":770639208,"url":"https://api.github.com/repos/angular/angular/labels/PR%20action:%20merge-assistance","name":"PR action: merge-assistance","color":"d93f0b","default":false},{"id":655699838,"url":"https://api.github.com/repos/angular/angular/labels/PR%20target:%20master%20&%20patch","name":"PR target: master & patch","color":"5319e7","default":false},{"id":149476251,"url":"https://api.github.com/repos/angular/angular/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false},{"id":375501288,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20core%20&%20compiler","name":"comp: core & compiler","color":"c7def8","default":false},{"id":488329172,"url":"https://api.github.com/repos/angular/angular/labels/comp:%20upgrade/static","name":"comp: upgrade/static","color":"c5def5","default":false},{"id":130606843,"url":"https://api.github.com/repos/angular/angular/labels/type:%20bug/fix","name":"type: bug/fix","color":"EEEEEE","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-02-13T22:22:08Z","updated_at":"2018-03-22T13:19:43Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/angular/angular/pulls/22209","html_url":"https://github.com/angular/angular/pull/22209","diff_url":"https://github.com/angular/angular/pull/22209.diff","patch_url":"https://github.com/angular/angular/pull/22209.patch"},"body":"## PR Checklist\r\nPlease check if your PR fulfills the following requirements:\r\n\r\n- [x ] The commit message follows our guidelines: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#commit\r\n- [n/a ] Tests for the changes have been added (for bug fixes / features)\r\n- [n/a ] Docs have been added / updated (for bug fixes / features)\r\n\r\n\r\n## PR Type\r\nWhat kind of change does this PR introduce?\r\n\r\n<!-- Please check the one that applies to this PR using \"x\". -->\r\n```\r\n[ x] Bugfix\r\n[ ] Feature\r\n[ ] Code style update (formatting, local variables)\r\n[ ] Refactoring (no functional changes, no api changes)\r\n[ ] Build related changes\r\n[ ] CI related changes\r\n[ ] Documentation content changes\r\n[ ] angular.io application / infrastructure changes\r\n[ ] Other... Please describe:\r\n```\r\n\r\n## What is the current behavior?\r\nI found a bug within matCheckbox. I added a disabled class to the checkbox based on a method call. When disabled, the checkbox had class disabled and therefore had grey css etc, but if it was still clicked on, it had a click event which added a disabled class to the input within the checkbox. When the disabled class was removed from the outer matCheckbox, the disabled class remained on the input, so even though the checkbox appeared not to be disabled, it couldn't accept any more input.\r\n\r\nIssue Number: 9763\r\n\r\n\r\n## What is the new behavior?\r\nClicking on a disabled checkbox should not change it in any way.\r\n\r\n## Does this PR introduce a breaking change?\r\n```\r\n[ ] Yes\r\n[x ] No\r\n```\r\n\r\n<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->\r\n\r\n\r\n## Other information\r\n"},"comment":{"url":"https://api.github.com/repos/angular/angular/issues/comments/375302756","html_url":"https://github.com/angular/angular/pull/22209#issuecomment-375302756","issue_url":"https://api.github.com/repos/angular/angular/issues/22209","id":375302756,"user":{"login":"ngbot[bot]","id":33250855,"avatar_url":"https://avatars0.githubusercontent.com/in/6359?v=4","gravatar_id":"","url":"https://api.github.com/users/ngbot%5Bbot%5D","html_url":"https://github.com/apps/ngbot","followers_url":"https://api.github.com/users/ngbot%5Bbot%5D/followers","following_url":"https://api.github.com/users/ngbot%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/ngbot%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/ngbot%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngbot%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/ngbot%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/ngbot%5Bbot%5D/repos","events_url":"https://api.github.com/users/ngbot%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/ngbot%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-22T13:19:43Z","updated_at":"2018-03-22T13:19:43Z","author_association":"NONE","body":"I see that you just added the `PR action: merge` label, but the following checks are still failing: \n&nbsp;&nbsp;&nbsp;&nbsp;![failure](https://raw.githubusercontent.com/angular/github-robot/master/assets/failing.png) status \"cla/google\" is failing\n&nbsp;&nbsp;&nbsp;&nbsp;![pending](https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png) status \"google3\" is pending\n&nbsp;&nbsp;&nbsp;&nbsp;![pending](https://raw.githubusercontent.com/angular/github-robot/master/assets/pending.png) 1 pending code review \n \n**If you want your PR to be merged, it has to pass all the CI checks.** \n \nIf you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help."}}
{"actor":{"display_login":"ngbot"}}