{"action":"created","comment":{"url":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments/183985630","pull_request_review_id":115079277,"id":183985630,"diff_hunk":"@@ -372,8 +375,28 @@ public void prohibitTransactionProcessing() {\n         eth.disableTransactions();\n     }\n \n-    public void sendTransaction(List<Transaction> tx) {\n-        eth.sendTransaction(tx);\n+    /**\n+     * Send transactions from input to peer corresponded with channel\n+     * Using {@link #sendTransactionsSafely(List)} is recommended instead\n+     * @param txs   Transactions\n+     */\n+    public void sendTransactions(List<Transaction> txs) {\n+        eth.sendTransaction(txs);\n+    }\n+\n+    /**\n+     * Sames as {@link #sendTransactions(List)} but input list is randomly sliced to\n+     * contain not more than {@link MAX_SAFE_TXS} if needed\n+     * @param txs   List of txs to send\n+     */\n+    public void sendTransactionsSafely(List<Transaction> txs) {","path":"ethereumj-core/src/main/java/org/ethereum/net/server/Channel.java","position":37,"original_position":37,"commit_id":"d054e394e59e84a3448d39317003f6d0bd195861","original_commit_id":"d054e394e59e84a3448d39317003f6d0bd195861","user":{"login":"mkalinin","id":1892772,"avatar_url":"https://avatars3.githubusercontent.com/u/1892772?v=4","gravatar_id":"","url":"https://api.github.com/users/mkalinin","html_url":"https://github.com/mkalinin","followers_url":"https://api.github.com/users/mkalinin/followers","following_url":"https://api.github.com/users/mkalinin/following{/other_user}","gists_url":"https://api.github.com/users/mkalinin/gists{/gist_id}","starred_url":"https://api.github.com/users/mkalinin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mkalinin/subscriptions","organizations_url":"https://api.github.com/users/mkalinin/orgs","repos_url":"https://api.github.com/users/mkalinin/repos","events_url":"https://api.github.com/users/mkalinin/events{/privacy}","received_events_url":"https://api.github.com/users/mkalinin/received_events","type":"User","site_admin":false},"body":"`Safely` sounds too abstract for me and confusing on the other hand (is regular `sendTransactions` unsafe??)","created_at":"2018-04-25T08:56:46Z","updated_at":"2018-04-25T09:00:49Z","html_url":"https://github.com/ethereum/ethereumj/pull/1057#discussion_r183985630","pull_request_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1057","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments/183985630"},"html":{"href":"https://github.com/ethereum/ethereumj/pull/1057#discussion_r183985630"},"pull_request":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1057"}}},"pull_request":{"url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1057","id":183300161,"html_url":"https://github.com/ethereum/ethereumj/pull/1057","diff_url":"https://github.com/ethereum/ethereumj/pull/1057.diff","patch_url":"https://github.com/ethereum/ethereumj/pull/1057.patch","issue_url":"https://api.github.com/repos/ethereum/ethereumj/issues/1057","number":1057,"state":"open","locked":false,"title":"Memory usage limited for outgoing eth responses","user":{"login":"zilm13","id":6196452,"avatar_url":"https://avatars2.githubusercontent.com/u/6196452?v=4","gravatar_id":"","url":"https://api.github.com/users/zilm13","html_url":"https://github.com/zilm13","followers_url":"https://api.github.com/users/zilm13/followers","following_url":"https://api.github.com/users/zilm13/following{/other_user}","gists_url":"https://api.github.com/users/zilm13/gists{/gist_id}","starred_url":"https://api.github.com/users/zilm13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zilm13/subscriptions","organizations_url":"https://api.github.com/users/zilm13/orgs","repos_url":"https://api.github.com/users/zilm13/repos","events_url":"https://api.github.com/users/zilm13/events{/privacy}","received_events_url":"https://api.github.com/users/zilm13/received_events","type":"User","site_admin":false},"body":"@mkalinin please, take a look","created_at":"2018-04-22T23:19:40Z","updated_at":"2018-04-25T09:00:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09818faab3e448038845d8b120ff8586d7e812f8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1057/commits","review_comments_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/1057/comments","review_comment_url":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereum/ethereumj/issues/1057/comments","statuses_url":"https://api.github.com/repos/ethereum/ethereumj/statuses/d054e394e59e84a3448d39317003f6d0bd195861","head":{"label":"ethereum:fix/limit-outgoing-msg","ref":"fix/limit-outgoing-msg","sha":"d054e394e59e84a3448d39317003f6d0bd195861","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":19730456,"name":"ethereumj","full_name":"ethereum/ethereumj","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/ethereumj","description":"Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony","fork":false,"url":"https://api.github.com/repos/ethereum/ethereumj","forks_url":"https://api.github.com/repos/ethereum/ethereumj/forks","keys_url":"https://api.github.com/repos/ethereum/ethereumj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/ethereumj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/ethereumj/teams","hooks_url":"https://api.github.com/repos/ethereum/ethereumj/hooks","issue_events_url":"https://api.github.com/repos/ethereum/ethereumj/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/ethereumj/events","assignees_url":"https://api.github.com/repos/ethereum/ethereumj/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/ethereumj/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/ethereumj/tags","blobs_url":"https://api.github.com/repos/ethereum/ethereumj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/ethereumj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/ethereumj/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/ethereumj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/ethereumj/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/ethereumj/languages","stargazers_url":"https://api.github.com/repos/ethereum/ethereumj/stargazers","contributors_url":"https://api.github.com/repos/ethereum/ethereumj/contributors","subscribers_url":"https://api.github.com/repos/ethereum/ethereumj/subscribers","subscription_url":"https://api.github.com/repos/ethereum/ethereumj/subscription","commits_url":"https://api.github.com/repos/ethereum/ethereumj/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/ethereumj/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/ethereumj/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/ethereumj/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/ethereumj/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/ethereumj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/ethereumj/merges","archive_url":"https://api.github.com/repos/ethereum/ethereumj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/ethereumj/downloads","issues_url":"https://api.github.com/repos/ethereum/ethereumj/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/ethereumj/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/ethereumj/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/ethereumj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/ethereumj/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/ethereumj/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/ethereumj/deployments","created_at":"2014-05-13T07:50:14Z","updated_at":"2018-04-25T06:44:41Z","pushed_at":"2018-04-25T07:20:21Z","git_url":"git://github.com/ethereum/ethereumj.git","ssh_url":"git@github.com:ethereum/ethereumj.git","clone_url":"https://github.com/ethereum/ethereumj.git","svn_url":"https://github.com/ethereum/ethereumj","homepage":"","size":46145,"stargazers_count":1468,"watchers_count":1468,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":763,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":763,"open_issues":83,"watchers":1468,"default_branch":"develop"}},"base":{"label":"ethereum:develop","ref":"develop","sha":"f761be5ba09b1c9188cd643ee0eedf4c87f03912","user":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"repo":{"id":19730456,"name":"ethereumj","full_name":"ethereum/ethereumj","owner":{"login":"ethereum","id":6250754,"avatar_url":"https://avatars3.githubusercontent.com/u/6250754?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereum","html_url":"https://github.com/ethereum","followers_url":"https://api.github.com/users/ethereum/followers","following_url":"https://api.github.com/users/ethereum/following{/other_user}","gists_url":"https://api.github.com/users/ethereum/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereum/subscriptions","organizations_url":"https://api.github.com/users/ethereum/orgs","repos_url":"https://api.github.com/users/ethereum/repos","events_url":"https://api.github.com/users/ethereum/events{/privacy}","received_events_url":"https://api.github.com/users/ethereum/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ethereum/ethereumj","description":"Java implementation of the Ethereum yellowpaper. For JSON-RPC and other client features check Ethereum Harmony","fork":false,"url":"https://api.github.com/repos/ethereum/ethereumj","forks_url":"https://api.github.com/repos/ethereum/ethereumj/forks","keys_url":"https://api.github.com/repos/ethereum/ethereumj/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereum/ethereumj/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereum/ethereumj/teams","hooks_url":"https://api.github.com/repos/ethereum/ethereumj/hooks","issue_events_url":"https://api.github.com/repos/ethereum/ethereumj/issues/events{/number}","events_url":"https://api.github.com/repos/ethereum/ethereumj/events","assignees_url":"https://api.github.com/repos/ethereum/ethereumj/assignees{/user}","branches_url":"https://api.github.com/repos/ethereum/ethereumj/branches{/branch}","tags_url":"https://api.github.com/repos/ethereum/ethereumj/tags","blobs_url":"https://api.github.com/repos/ethereum/ethereumj/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereum/ethereumj/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereum/ethereumj/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereum/ethereumj/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereum/ethereumj/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereum/ethereumj/languages","stargazers_url":"https://api.github.com/repos/ethereum/ethereumj/stargazers","contributors_url":"https://api.github.com/repos/ethereum/ethereumj/contributors","subscribers_url":"https://api.github.com/repos/ethereum/ethereumj/subscribers","subscription_url":"https://api.github.com/repos/ethereum/ethereumj/subscription","commits_url":"https://api.github.com/repos/ethereum/ethereumj/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereum/ethereumj/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereum/ethereumj/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereum/ethereumj/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereum/ethereumj/contents/{+path}","compare_url":"https://api.github.com/repos/ethereum/ethereumj/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereum/ethereumj/merges","archive_url":"https://api.github.com/repos/ethereum/ethereumj/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereum/ethereumj/downloads","issues_url":"https://api.github.com/repos/ethereum/ethereumj/issues{/number}","pulls_url":"https://api.github.com/repos/ethereum/ethereumj/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereum/ethereumj/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereum/ethereumj/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereum/ethereumj/labels{/name}","releases_url":"https://api.github.com/repos/ethereum/ethereumj/releases{/id}","deployments_url":"https://api.github.com/repos/ethereum/ethereumj/deployments","created_at":"2014-05-13T07:50:14Z","updated_at":"2018-04-25T06:44:41Z","pushed_at":"2018-04-25T07:20:21Z","git_url":"git://github.com/ethereum/ethereumj.git","ssh_url":"git@github.com:ethereum/ethereumj.git","clone_url":"https://github.com/ethereum/ethereumj.git","svn_url":"https://github.com/ethereum/ethereumj","homepage":"","size":46145,"stargazers_count":1468,"watchers_count":1468,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":763,"mirror_url":null,"archived":false,"open_issues_count":83,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0"},"forks":763,"open_issues":83,"watchers":1468,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1057"},"html":{"href":"https://github.com/ethereum/ethereumj/pull/1057"},"issue":{"href":"https://api.github.com/repos/ethereum/ethereumj/issues/1057"},"comments":{"href":"https://api.github.com/repos/ethereum/ethereumj/issues/1057/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1057/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereum/ethereumj/pulls/1057/commits"},"statuses":{"href":"https://api.github.com/repos/ethereum/ethereumj/statuses/d054e394e59e84a3448d39317003f6d0bd195861"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mkalinin"}}