{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments/200441241","pull_request_review_id":134760024,"id":200441241,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDQ0MTI0MQ==","diff_hunk":"@@ -283,14 +283,23 @@ cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_TESTING=OFF ..\n make\n make install\n \n-# build zipkin lib\n+# build jaeger lib\n cd \"$BUILD_PATH/jaeger-client-cpp-$JAEGER_VERSION\"\n sed -i 's/-Werror//' CMakeLists.txt\n mkdir .build\n cd .build\n-cmake -DCMAKE_BUILD_TYPE=Release -DBUILD_SHARED_LIBS=1 -DBUILD_TESTING=OFF -DJAEGERTRACING_WITH_YAML_CPP=OFF -DJAEGERTRACING_BUILD_EXAMPLES=OFF ..\n+# Taken from https://github.com/jaegertracing/jaeger-client-cpp/blob/v0.4.1/scripts/build-plugin.sh","path":"images/nginx/build.sh","position":11,"original_position":11,"commit_id":"2c4e49eddf2f65dda5cd74f09f1caf7b9f002d96","original_commit_id":"2c4e49eddf2f65dda5cd74f09f1caf7b9f002d96","user":{"login":"mikebryant","id":1478103,"node_id":"MDQ6VXNlcjE0NzgxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1478103?v=4","gravatar_id":"","url":"https://api.github.com/users/mikebryant","html_url":"https://github.com/mikebryant","followers_url":"https://api.github.com/users/mikebryant/followers","following_url":"https://api.github.com/users/mikebryant/following{/other_user}","gists_url":"https://api.github.com/users/mikebryant/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebryant/subscriptions","organizations_url":"https://api.github.com/users/mikebryant/orgs","repos_url":"https://api.github.com/users/mikebryant/repos","events_url":"https://api.github.com/users/mikebryant/events{/privacy}","received_events_url":"https://api.github.com/users/mikebryant/received_events","type":"User","site_admin":false},"body":"Ah, I see, sure","created_at":"2018-07-05T18:06:39Z","updated_at":"2018-07-05T18:06:39Z","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2744#discussion_r200441241","pull_request_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2744","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments/200441241"},"html":{"href":"https://github.com/kubernetes/ingress-nginx/pull/2744#discussion_r200441241"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2744"}},"in_reply_to_id":200360911},"pull_request":{"url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2744","id":199463393,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NDYzMzkz","html_url":"https://github.com/kubernetes/ingress-nginx/pull/2744","diff_url":"https://github.com/kubernetes/ingress-nginx/pull/2744.diff","patch_url":"https://github.com/kubernetes/ingress-nginx/pull/2744.patch","issue_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2744","number":2744,"state":"open","locked":false,"title":"fix: Use the correct opentracing plugin for Jaeger","user":{"login":"mikebryant","id":1478103,"node_id":"MDQ6VXNlcjE0NzgxMDM=","avatar_url":"https://avatars1.githubusercontent.com/u/1478103?v=4","gravatar_id":"","url":"https://api.github.com/users/mikebryant","html_url":"https://github.com/mikebryant","followers_url":"https://api.github.com/users/mikebryant/followers","following_url":"https://api.github.com/users/mikebryant/following{/other_user}","gists_url":"https://api.github.com/users/mikebryant/gists{/gist_id}","starred_url":"https://api.github.com/users/mikebryant/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikebryant/subscriptions","organizations_url":"https://api.github.com/users/mikebryant/orgs","repos_url":"https://api.github.com/users/mikebryant/repos","events_url":"https://api.github.com/users/mikebryant/events{/privacy}","received_events_url":"https://api.github.com/users/mikebryant/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/guide/pull-requests.md#the-pull-request-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/guide/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**: Uses the correct opentracing plugin for Jaeger - without this there is a regression and that feature doesn't work in 0.16.2\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: part of #2738\r\n\r\n**Special notes for your reviewer**:\r\n","created_at":"2018-07-05T13:03:53Z","updated_at":"2018-07-05T18:06:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"e3eb5424d4d89adec9cdeb8fd0c68a883bdfc107","assignee":{"login":"aledbf","id":161571,"node_id":"MDQ6VXNlcjE2MTU3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false},"assignees":[{"login":"aledbf","id":161571,"node_id":"MDQ6VXNlcjE2MTU3MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/161571?v=4","gravatar_id":"","url":"https://api.github.com/users/aledbf","html_url":"https://github.com/aledbf","followers_url":"https://api.github.com/users/aledbf/followers","following_url":"https://api.github.com/users/aledbf/following{/other_user}","gists_url":"https://api.github.com/users/aledbf/gists{/gist_id}","starred_url":"https://api.github.com/users/aledbf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aledbf/subscriptions","organizations_url":"https://api.github.com/users/aledbf/orgs","repos_url":"https://api.github.com/users/aledbf/repos","events_url":"https://api.github.com/users/aledbf/events{/privacy}","received_events_url":"https://api.github.com/users/aledbf/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":486873161,"node_id":"MDU6TGFiZWw0ODY4NzMxNjE=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":676271156,"node_id":"MDU6TGFiZWw2NzYyNzExNTY=","url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2744/commits","review_comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2744/comments","review_comment_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2744/comments","statuses_url":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/2c4e49eddf2f65dda5cd74f09f1caf7b9f002d96","head":{"label":"ocadotechnology:wip-2738","ref":"wip-2738","sha":"2c4e49eddf2f65dda5cd74f09f1caf7b9f002d96","user":{"login":"ocadotechnology","id":2088731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODg3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2088731?v=4","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"repo":{"id":139727380,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk3MjczODA=","name":"ingress-nginx","full_name":"ocadotechnology/ingress-nginx","owner":{"login":"ocadotechnology","id":2088731,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODg3MzE=","avatar_url":"https://avatars3.githubusercontent.com/u/2088731?v=4","gravatar_id":"","url":"https://api.github.com/users/ocadotechnology","html_url":"https://github.com/ocadotechnology","followers_url":"https://api.github.com/users/ocadotechnology/followers","following_url":"https://api.github.com/users/ocadotechnology/following{/other_user}","gists_url":"https://api.github.com/users/ocadotechnology/gists{/gist_id}","starred_url":"https://api.github.com/users/ocadotechnology/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ocadotechnology/subscriptions","organizations_url":"https://api.github.com/users/ocadotechnology/orgs","repos_url":"https://api.github.com/users/ocadotechnology/repos","events_url":"https://api.github.com/users/ocadotechnology/events{/privacy}","received_events_url":"https://api.github.com/users/ocadotechnology/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ocadotechnology/ingress-nginx","description":"NGINX Ingress Controller for Kubernetes https://kubernetes.github.io/ingress-nginx/","fork":true,"url":"https://api.github.com/repos/ocadotechnology/ingress-nginx","forks_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/forks","keys_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/teams","hooks_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/hooks","issue_events_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/events","assignees_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/tags","blobs_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/languages","stargazers_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/stargazers","contributors_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/contributors","subscribers_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/subscribers","subscription_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/subscription","commits_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/merges","archive_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/downloads","issues_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/labels{/name}","releases_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/ocadotechnology/ingress-nginx/deployments","created_at":"2018-07-04T13:41:05Z","updated_at":"2018-07-04T13:41:09Z","pushed_at":"2018-07-05T13:21:42Z","git_url":"git://github.com/ocadotechnology/ingress-nginx.git","ssh_url":"git@github.com:ocadotechnology/ingress-nginx.git","clone_url":"https://github.com/ocadotechnology/ingress-nginx.git","svn_url":"https://github.com/ocadotechnology/ingress-nginx","homepage":"","size":68859,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"5039e770bd3fc1503481f7f3d807c237e1d447de","user":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":72891330,"node_id":"MDEwOlJlcG9zaXRvcnk3Mjg5MTMzMA==","name":"ingress-nginx","full_name":"kubernetes/ingress-nginx","owner":{"login":"kubernetes","id":13629408,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzNjI5NDA4","avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/ingress-nginx","description":"NGINX Ingress Controller for Kubernetes https://kubernetes.github.io/ingress-nginx/","fork":false,"url":"https://api.github.com/repos/kubernetes/ingress-nginx","forks_url":"https://api.github.com/repos/kubernetes/ingress-nginx/forks","keys_url":"https://api.github.com/repos/kubernetes/ingress-nginx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/ingress-nginx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/ingress-nginx/teams","hooks_url":"https://api.github.com/repos/kubernetes/ingress-nginx/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/ingress-nginx/events","assignees_url":"https://api.github.com/repos/kubernetes/ingress-nginx/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/ingress-nginx/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/ingress-nginx/tags","blobs_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/ingress-nginx/languages","stargazers_url":"https://api.github.com/repos/kubernetes/ingress-nginx/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/ingress-nginx/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/ingress-nginx/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/ingress-nginx/subscription","commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/ingress-nginx/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/ingress-nginx/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/ingress-nginx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/ingress-nginx/merges","archive_url":"https://api.github.com/repos/kubernetes/ingress-nginx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/ingress-nginx/downloads","issues_url":"https://api.github.com/repos/kubernetes/ingress-nginx/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/ingress-nginx/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/ingress-nginx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/ingress-nginx/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/ingress-nginx/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/ingress-nginx/deployments","created_at":"2016-11-04T22:54:14Z","updated_at":"2018-07-05T14:04:25Z","pushed_at":"2018-07-05T14:42:39Z","git_url":"git://github.com/kubernetes/ingress-nginx.git","ssh_url":"git@github.com:kubernetes/ingress-nginx.git","clone_url":"https://github.com/kubernetes/ingress-nginx.git","svn_url":"https://github.com/kubernetes/ingress-nginx","homepage":"","size":79594,"stargazers_count":2263,"watchers_count":2263,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1198,"mirror_url":null,"archived":false,"open_issues_count":108,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1198,"open_issues":108,"watchers":2263,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2744"},"html":{"href":"https://github.com/kubernetes/ingress-nginx/pull/2744"},"issue":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2744"},"comments":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/issues/2744/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2744/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/pulls/2744/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/ingress-nginx/statuses/2c4e49eddf2f65dda5cd74f09f1caf7b9f002d96"}},"author_association":"NONE"}}
{"actor":{"display_login":"mikebryant"}}