{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/245431867","pull_request_review_id":189543209,"id":245431867,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQzMTg2Nw==","diff_hunk":"@@ -37,16 +37,16 @@\n     \"preinstall\": \"node ./preinstall_check\",\n     \"kbn\": \"node scripts/kbn\",\n     \"es\": \"node scripts/es\",\n-    \"elasticsearch\": \"echo 'use `yarn es snapshot -E path.data=../data/`'\",\n+    \"elasticsearch\": \"node scripts/es snapshot -E path.data=../data/\",","path":"package.json","position":5,"original_position":5,"commit_id":"577c1f5b2f3a27a2795fc538fddb3c77db4377d4","original_commit_id":"577c1f5b2f3a27a2795fc538fddb3c77db4377d4","user":{"login":"tylersmalley","id":40265,"node_id":"MDQ6VXNlcjQwMjY1","avatar_url":"https://avatars2.githubusercontent.com/u/40265?v=4","gravatar_id":"","url":"https://api.github.com/users/tylersmalley","html_url":"https://github.com/tylersmalley","followers_url":"https://api.github.com/users/tylersmalley/followers","following_url":"https://api.github.com/users/tylersmalley/following{/other_user}","gists_url":"https://api.github.com/users/tylersmalley/gists{/gist_id}","starred_url":"https://api.github.com/users/tylersmalley/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tylersmalley/subscriptions","organizations_url":"https://api.github.com/users/tylersmalley/orgs","repos_url":"https://api.github.com/users/tylersmalley/repos","events_url":"https://api.github.com/users/tylersmalley/events{/privacy}","received_events_url":"https://api.github.com/users/tylersmalley/received_events","type":"User","site_admin":false},"body":"Lets either remove this command, or leave it how it was. This was added to provide similar compatibility to what was prior to kbn-es, but it should not be how folks are running ES.","created_at":"2019-01-04T21:56:40Z","updated_at":"2019-01-04T21:56:40Z","html_url":"https://github.com/elastic/kibana/pull/27850#discussion_r245431867","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/27850","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/245431867"},"html":{"href":"https://github.com/elastic/kibana/pull/27850#discussion_r245431867"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/27850"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/27850","id":241392711,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMzkyNzEx","html_url":"https://github.com/elastic/kibana/pull/27850","diff_url":"https://github.com/elastic/kibana/pull/27850.diff","patch_url":"https://github.com/elastic/kibana/pull/27850.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/27850","number":27850,"state":"open","locked":false,"title":"undeprecate calling scripts from npm / yarn run","user":{"login":"mattkime","id":216176,"node_id":"MDQ6VXNlcjIxNjE3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/216176?v=4","gravatar_id":"","url":"https://api.github.com/users/mattkime","html_url":"https://github.com/mattkime","followers_url":"https://api.github.com/users/mattkime/followers","following_url":"https://api.github.com/users/mattkime/following{/other_user}","gists_url":"https://api.github.com/users/mattkime/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkime/subscriptions","organizations_url":"https://api.github.com/users/mattkime/orgs","repos_url":"https://api.github.com/users/mattkime/repos","events_url":"https://api.github.com/users/mattkime/events{/privacy}","received_events_url":"https://api.github.com/users/mattkime/received_events","type":"User","site_admin":false},"body":"## Summary\r\n\r\nA number of `(yarn|npm) run` commands just told the user how to run the script. Its okay to run scripts from yarn without nagging.\r\n\r\nAlso added `lint:fix`, `lint:es`, `lint:ts`, `lint:fix`, `lint:es:fix`, `lint:ts:fix` commands which I hope are self explanatory.\r\n\r\n### Checklist\r\n\r\nUse ~~strikethroughs~~ to remove checklist items you don't feel are applicable to this PR.\r\n\r\n- ~~[ ] This was checked for cross-browser compatibility, [including a check against IE11](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility)~~\r\n- ~~[ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/master/packages/kbn-i18n/README.md)~~\r\n- ~~[ ] [Documentation](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#writing-documentation) was added for features that require explanation or tutorials~~\r\n- ~~[ ] [Unit or functional tests](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#cross-browser-compatibility) were updated or added to match the most common scenarios~~\r\n- ~~[ ] This was checked for [keyboard-only and screenreader accessibility](https://developer.mozilla.org/en-US/docs/Learn/Tools_and_testing/Cross_browser_testing/Accessibility#Accessibility_testing_checklist)~~\r\n\r\n### For maintainers\r\n\r\n- ~~[ ] This was checked for breaking API changes and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~\r\n- ~~[ ] This includes a feature addition or change that requires a release note and was [labeled appropriately](https://github.com/elastic/kibana/blob/master/CONTRIBUTING.md#release-notes-process)~~\r\n\r\n","created_at":"2018-12-28T20:39:32Z","updated_at":"2019-01-04T21:56:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9f2064d4b1b1af3be6535fde3f15f639ef511569","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":470241741,"node_id":"MDU6TGFiZWw0NzAyNDE3NDE=","url":"https://api.github.com/repos/elastic/kibana/labels/:Dev%20Tools","name":":Dev Tools","color":"0e8a16","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/27850/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/27850/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/27850/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/577c1f5b2f3a27a2795fc538fddb3c77db4377d4","head":{"label":"mattkime:undeprecate_scripts_as_tasks","ref":"undeprecate_scripts_as_tasks","sha":"577c1f5b2f3a27a2795fc538fddb3c77db4377d4","user":{"login":"mattkime","id":216176,"node_id":"MDQ6VXNlcjIxNjE3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/216176?v=4","gravatar_id":"","url":"https://api.github.com/users/mattkime","html_url":"https://github.com/mattkime","followers_url":"https://api.github.com/users/mattkime/followers","following_url":"https://api.github.com/users/mattkime/following{/other_user}","gists_url":"https://api.github.com/users/mattkime/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkime/subscriptions","organizations_url":"https://api.github.com/users/mattkime/orgs","repos_url":"https://api.github.com/users/mattkime/repos","events_url":"https://api.github.com/users/mattkime/events{/privacy}","received_events_url":"https://api.github.com/users/mattkime/received_events","type":"User","site_admin":false},"repo":{"id":152427618,"node_id":"MDEwOlJlcG9zaXRvcnkxNTI0Mjc2MTg=","name":"kibana","full_name":"mattkime/kibana","private":false,"owner":{"login":"mattkime","id":216176,"node_id":"MDQ6VXNlcjIxNjE3Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/216176?v=4","gravatar_id":"","url":"https://api.github.com/users/mattkime","html_url":"https://github.com/mattkime","followers_url":"https://api.github.com/users/mattkime/followers","following_url":"https://api.github.com/users/mattkime/following{/other_user}","gists_url":"https://api.github.com/users/mattkime/gists{/gist_id}","starred_url":"https://api.github.com/users/mattkime/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mattkime/subscriptions","organizations_url":"https://api.github.com/users/mattkime/orgs","repos_url":"https://api.github.com/users/mattkime/repos","events_url":"https://api.github.com/users/mattkime/events{/privacy}","received_events_url":"https://api.github.com/users/mattkime/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mattkime/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":true,"url":"https://api.github.com/repos/mattkime/kibana","forks_url":"https://api.github.com/repos/mattkime/kibana/forks","keys_url":"https://api.github.com/repos/mattkime/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mattkime/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mattkime/kibana/teams","hooks_url":"https://api.github.com/repos/mattkime/kibana/hooks","issue_events_url":"https://api.github.com/repos/mattkime/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/mattkime/kibana/events","assignees_url":"https://api.github.com/repos/mattkime/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/mattkime/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/mattkime/kibana/tags","blobs_url":"https://api.github.com/repos/mattkime/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mattkime/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mattkime/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/mattkime/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mattkime/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/mattkime/kibana/languages","stargazers_url":"https://api.github.com/repos/mattkime/kibana/stargazers","contributors_url":"https://api.github.com/repos/mattkime/kibana/contributors","subscribers_url":"https://api.github.com/repos/mattkime/kibana/subscribers","subscription_url":"https://api.github.com/repos/mattkime/kibana/subscription","commits_url":"https://api.github.com/repos/mattkime/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/mattkime/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/mattkime/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/mattkime/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/mattkime/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/mattkime/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mattkime/kibana/merges","archive_url":"https://api.github.com/repos/mattkime/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mattkime/kibana/downloads","issues_url":"https://api.github.com/repos/mattkime/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/mattkime/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/mattkime/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/mattkime/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mattkime/kibana/labels{/name}","releases_url":"https://api.github.com/repos/mattkime/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/mattkime/kibana/deployments","created_at":"2018-10-10T13:24:31Z","updated_at":"2019-01-04T04:54:38Z","pushed_at":"2019-01-04T14:13:09Z","git_url":"git://github.com/mattkime/kibana.git","ssh_url":"git@github.com:mattkime/kibana.git","clone_url":"https://github.com/mattkime/kibana.git","svn_url":"https://github.com/mattkime/kibana","homepage":"https://www.elastic.co/products/kibana","size":580201,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"b491d8790ad30e87eefa8093fb374116bfb84cbd","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"node_id":"MDEwOlJlcG9zaXRvcnk3ODMzMTY4","name":"kibana","full_name":"elastic/kibana","private":false,"owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2019-01-04T21:13:18Z","pushed_at":"2019-01-04T21:56:35Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":526297,"stargazers_count":10802,"watchers_count":10802,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4211,"mirror_url":null,"archived":false,"open_issues_count":4003,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":4211,"open_issues":4003,"watchers":10802,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/27850"},"html":{"href":"https://github.com/elastic/kibana/pull/27850"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/27850"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/27850/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/27850/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/27850/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/577c1f5b2f3a27a2795fc538fddb3c77db4377d4"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tylersmalley"}}