{"action":"created","comment":{"url":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/comments/233909135","pull_request_review_id":175432337,"id":233909135,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzkwOTEzNQ==","diff_hunk":"@@ -203,11 +279,12 @@ def test_reconciliation_query(self):\n                          'Ounconfirmed_sample_4', two_days_ago, two_days_ago)\n \n \n-    # On time order and samples from 10 days ago; shows up in rx\n+    # On time order and samples from 10 days ago; should not shows up in rx or modified","path":"rest-api/test/unit_test/offline_test/biobank_samples_pipeline_mysql_test.py","position":null,"original_position":119,"commit_id":"e825b15e7e822437475e545a819b62126da0d574","original_commit_id":"ba971a7fcb1ff0bf205cad69d70dcbe2a283caba","user":{"login":"wangy70","id":43476466,"node_id":"MDQ6VXNlcjQzNDc2NDY2","avatar_url":"https://avatars0.githubusercontent.com/u/43476466?v=4","gravatar_id":"","url":"https://api.github.com/users/wangy70","html_url":"https://github.com/wangy70","followers_url":"https://api.github.com/users/wangy70/followers","following_url":"https://api.github.com/users/wangy70/following{/other_user}","gists_url":"https://api.github.com/users/wangy70/gists{/gist_id}","starred_url":"https://api.github.com/users/wangy70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangy70/subscriptions","organizations_url":"https://api.github.com/users/wangy70/orgs","repos_url":"https://api.github.com/users/wangy70/repos","events_url":"https://api.github.com/users/wangy70/events{/privacy}","received_events_url":"https://api.github.com/users/wangy70/received_events","type":"User","site_admin":false},"body":"There is already a filter of 7days, but only applied to missing. I kept the logic and change it to 10days. Now it's applied to all reports.\r\nThe logic is `(now - max(received_time, collection_time)).days <= 10`. \r\n\r\n@Seeker1911 Other comments are all done, please review.","created_at":"2018-11-15T16:14:41Z","updated_at":"2018-11-15T16:14:42Z","html_url":"https://github.com/all-of-us/raw-data-repository/pull/840#discussion_r233909135","pull_request_url":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/840","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/comments/233909135"},"html":{"href":"https://github.com/all-of-us/raw-data-repository/pull/840#discussion_r233909135"},"pull_request":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/840"}},"in_reply_to_id":233684306},"pull_request":{"url":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/840","id":230994732,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwOTk0NzMy","html_url":"https://github.com/all-of-us/raw-data-repository/pull/840","diff_url":"https://github.com/all-of-us/raw-data-repository/pull/840.diff","patch_url":"https://github.com/all-of-us/raw-data-repository/pull/840.patch","issue_url":"https://api.github.com/repos/all-of-us/raw-data-repository/issues/840","number":840,"state":"open","locked":false,"title":"[DA-778] Wangy70/implement biobank reconciliation reports","user":{"login":"wangy70","id":43476466,"node_id":"MDQ6VXNlcjQzNDc2NDY2","avatar_url":"https://avatars0.githubusercontent.com/u/43476466?v=4","gravatar_id":"","url":"https://api.github.com/users/wangy70","html_url":"https://github.com/wangy70","followers_url":"https://api.github.com/users/wangy70/followers","following_url":"https://api.github.com/users/wangy70/following{/other_user}","gists_url":"https://api.github.com/users/wangy70/gists{/gist_id}","starred_url":"https://api.github.com/users/wangy70/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wangy70/subscriptions","organizations_url":"https://api.github.com/users/wangy70/orgs","repos_url":"https://api.github.com/users/wangy70/repos","events_url":"https://api.github.com/users/wangy70/events{/privacy}","received_events_url":"https://api.github.com/users/wangy70/received_events","type":"User","site_admin":false},"body":"Remove 24hour report, change received and missing to cover 10 hours. Add a new modified report.","created_at":"2018-11-14T21:53:50Z","updated_at":"2018-11-15T16:14:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"58c8823a595b749b6f19f19729bce16152d85387","assignee":null,"assignees":[],"requested_reviewers":[{"login":"calbach","id":822298,"node_id":"MDQ6VXNlcjgyMjI5OA==","avatar_url":"https://avatars0.githubusercontent.com/u/822298?v=4","gravatar_id":"","url":"https://api.github.com/users/calbach","html_url":"https://github.com/calbach","followers_url":"https://api.github.com/users/calbach/followers","following_url":"https://api.github.com/users/calbach/following{/other_user}","gists_url":"https://api.github.com/users/calbach/gists{/gist_id}","starred_url":"https://api.github.com/users/calbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/calbach/subscriptions","organizations_url":"https://api.github.com/users/calbach/orgs","repos_url":"https://api.github.com/users/calbach/repos","events_url":"https://api.github.com/users/calbach/events{/privacy}","received_events_url":"https://api.github.com/users/calbach/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/840/commits","review_comments_url":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/840/comments","review_comment_url":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/comments{/number}","comments_url":"https://api.github.com/repos/all-of-us/raw-data-repository/issues/840/comments","statuses_url":"https://api.github.com/repos/all-of-us/raw-data-repository/statuses/e825b15e7e822437475e545a819b62126da0d574","head":{"label":"all-of-us:wangy70/implement_biobank_reconciliation_reports","ref":"wangy70/implement_biobank_reconciliation_reports","sha":"e825b15e7e822437475e545a819b62126da0d574","user":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":66000771,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAwMDc3MQ==","name":"raw-data-repository","full_name":"all-of-us/raw-data-repository","private":false,"owner":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/all-of-us/raw-data-repository","description":"PMI DRC data repositories and APIs","fork":false,"url":"https://api.github.com/repos/all-of-us/raw-data-repository","forks_url":"https://api.github.com/repos/all-of-us/raw-data-repository/forks","keys_url":"https://api.github.com/repos/all-of-us/raw-data-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/raw-data-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/raw-data-repository/teams","hooks_url":"https://api.github.com/repos/all-of-us/raw-data-repository/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/raw-data-repository/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/raw-data-repository/events","assignees_url":"https://api.github.com/repos/all-of-us/raw-data-repository/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/raw-data-repository/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/raw-data-repository/tags","blobs_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/raw-data-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/raw-data-repository/languages","stargazers_url":"https://api.github.com/repos/all-of-us/raw-data-repository/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/raw-data-repository/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/raw-data-repository/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/raw-data-repository/subscription","commits_url":"https://api.github.com/repos/all-of-us/raw-data-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/raw-data-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/raw-data-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/raw-data-repository/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/raw-data-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/raw-data-repository/merges","archive_url":"https://api.github.com/repos/all-of-us/raw-data-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/raw-data-repository/downloads","issues_url":"https://api.github.com/repos/all-of-us/raw-data-repository/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/raw-data-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/raw-data-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/raw-data-repository/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/raw-data-repository/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/raw-data-repository/deployments","created_at":"2016-08-18T13:47:08Z","updated_at":"2018-11-14T22:17:05Z","pushed_at":"2018-11-15T16:00:18Z","git_url":"git://github.com/all-of-us/raw-data-repository.git","ssh_url":"git@github.com:all-of-us/raw-data-repository.git","clone_url":"https://github.com/all-of-us/raw-data-repository.git","svn_url":"https://github.com/all-of-us/raw-data-repository","homepage":null,"size":2793,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":8,"open_issues":3,"watchers":14,"default_branch":"master"}},"base":{"label":"all-of-us:master","ref":"master","sha":"7e683b8178f7b21f16d62878e03abcbd4db01343","user":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"repo":{"id":66000771,"node_id":"MDEwOlJlcG9zaXRvcnk2NjAwMDc3MQ==","name":"raw-data-repository","full_name":"all-of-us/raw-data-repository","private":false,"owner":{"login":"all-of-us","id":22846942,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyODQ2OTQy","avatar_url":"https://avatars0.githubusercontent.com/u/22846942?v=4","gravatar_id":"","url":"https://api.github.com/users/all-of-us","html_url":"https://github.com/all-of-us","followers_url":"https://api.github.com/users/all-of-us/followers","following_url":"https://api.github.com/users/all-of-us/following{/other_user}","gists_url":"https://api.github.com/users/all-of-us/gists{/gist_id}","starred_url":"https://api.github.com/users/all-of-us/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/all-of-us/subscriptions","organizations_url":"https://api.github.com/users/all-of-us/orgs","repos_url":"https://api.github.com/users/all-of-us/repos","events_url":"https://api.github.com/users/all-of-us/events{/privacy}","received_events_url":"https://api.github.com/users/all-of-us/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/all-of-us/raw-data-repository","description":"PMI DRC data repositories and APIs","fork":false,"url":"https://api.github.com/repos/all-of-us/raw-data-repository","forks_url":"https://api.github.com/repos/all-of-us/raw-data-repository/forks","keys_url":"https://api.github.com/repos/all-of-us/raw-data-repository/keys{/key_id}","collaborators_url":"https://api.github.com/repos/all-of-us/raw-data-repository/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/all-of-us/raw-data-repository/teams","hooks_url":"https://api.github.com/repos/all-of-us/raw-data-repository/hooks","issue_events_url":"https://api.github.com/repos/all-of-us/raw-data-repository/issues/events{/number}","events_url":"https://api.github.com/repos/all-of-us/raw-data-repository/events","assignees_url":"https://api.github.com/repos/all-of-us/raw-data-repository/assignees{/user}","branches_url":"https://api.github.com/repos/all-of-us/raw-data-repository/branches{/branch}","tags_url":"https://api.github.com/repos/all-of-us/raw-data-repository/tags","blobs_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/refs{/sha}","trees_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/trees{/sha}","statuses_url":"https://api.github.com/repos/all-of-us/raw-data-repository/statuses/{sha}","languages_url":"https://api.github.com/repos/all-of-us/raw-data-repository/languages","stargazers_url":"https://api.github.com/repos/all-of-us/raw-data-repository/stargazers","contributors_url":"https://api.github.com/repos/all-of-us/raw-data-repository/contributors","subscribers_url":"https://api.github.com/repos/all-of-us/raw-data-repository/subscribers","subscription_url":"https://api.github.com/repos/all-of-us/raw-data-repository/subscription","commits_url":"https://api.github.com/repos/all-of-us/raw-data-repository/commits{/sha}","git_commits_url":"https://api.github.com/repos/all-of-us/raw-data-repository/git/commits{/sha}","comments_url":"https://api.github.com/repos/all-of-us/raw-data-repository/comments{/number}","issue_comment_url":"https://api.github.com/repos/all-of-us/raw-data-repository/issues/comments{/number}","contents_url":"https://api.github.com/repos/all-of-us/raw-data-repository/contents/{+path}","compare_url":"https://api.github.com/repos/all-of-us/raw-data-repository/compare/{base}...{head}","merges_url":"https://api.github.com/repos/all-of-us/raw-data-repository/merges","archive_url":"https://api.github.com/repos/all-of-us/raw-data-repository/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/all-of-us/raw-data-repository/downloads","issues_url":"https://api.github.com/repos/all-of-us/raw-data-repository/issues{/number}","pulls_url":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls{/number}","milestones_url":"https://api.github.com/repos/all-of-us/raw-data-repository/milestones{/number}","notifications_url":"https://api.github.com/repos/all-of-us/raw-data-repository/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/all-of-us/raw-data-repository/labels{/name}","releases_url":"https://api.github.com/repos/all-of-us/raw-data-repository/releases{/id}","deployments_url":"https://api.github.com/repos/all-of-us/raw-data-repository/deployments","created_at":"2016-08-18T13:47:08Z","updated_at":"2018-11-14T22:17:05Z","pushed_at":"2018-11-15T16:00:18Z","git_url":"git://github.com/all-of-us/raw-data-repository.git","ssh_url":"git@github.com:all-of-us/raw-data-repository.git","clone_url":"https://github.com/all-of-us/raw-data-repository.git","svn_url":"https://github.com/all-of-us/raw-data-repository","homepage":null,"size":2793,"stargazers_count":14,"watchers_count":14,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause","node_id":"MDc6TGljZW5zZTU="},"forks":8,"open_issues":3,"watchers":14,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/840"},"html":{"href":"https://github.com/all-of-us/raw-data-repository/pull/840"},"issue":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/issues/840"},"comments":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/issues/840/comments"},"review_comments":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/840/comments"},"review_comment":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/pulls/840/commits"},"statuses":{"href":"https://api.github.com/repos/all-of-us/raw-data-repository/statuses/e825b15e7e822437475e545a819b62126da0d574"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"wangy70"}}