{"action":"created","comment":{"url":"https://api.github.com/repos/input-output-hk/plutus/pulls/comments/225153270","pull_request_review_id":164689304,"id":225153270,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTE1MzI3MA==","diff_hunk":"@@ -7,30 +7,24 @@\n -- works.\n module Main (main) where\n \n-import           Language.Plutus.TH\n-\n-import           Language.PlutusCore\n-import qualified Language.PlutusCore.Pretty as PLC\n+import           Common\n \n import           TestTH\n \n-import           Language.Haskell.TH.Syntax\n+import           Language.Plutus.TH\n+\n+import qualified Language.PlutusCore.Pretty as PLC\n \n import           Test.Tasty\n-import           Test.Tasty.Golden\n-\n-import qualified Data.ByteString.Lazy as BSL\n-import           Data.Text.Encoding   (encodeUtf8)\n \n main :: IO ()\n-main = defaultMain tests\n-\n-golden :: String -> PlcCode -> TestTree\n-golden name value = (goldenVsString name (\"test/\" ++ name ++ \".plc.golden\") . pure . BSL.fromStrict . encodeUtf8 . PLC.docText . PLC.prettyPlcClassicDebug . getAst) value\n+main = defaultMain $ runTestNestedIn [\"test\"] tests\n \n+golden :: String -> PlcCode -> TestNested\n+golden name value = (nestedGoldenVsDoc name . pure . PLC.prettyPlcClassicDebug . getAst) value\n \n-tests :: TestTree\n-tests = testGroup \"Plutus TH frontend\" [\n+tests :: TestNested\n+tests = testGroup \"plutus-th\" <$> sequence [","path":"plutus-th/test/Spec.hs","position":36,"original_position":36,"commit_id":"89ac853cd53bf8bcb7c3fede4c0da5d03ac2a95c","original_commit_id":"270e9661f8e901a16c0a4a8a7458f42c06063951","user":{"login":"michaelpj","id":1699466,"node_id":"MDQ6VXNlcjE2OTk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1699466?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelpj","html_url":"https://github.com/michaelpj","followers_url":"https://api.github.com/users/michaelpj/followers","following_url":"https://api.github.com/users/michaelpj/following{/other_user}","gists_url":"https://api.github.com/users/michaelpj/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpj/subscriptions","organizations_url":"https://api.github.com/users/michaelpj/orgs","repos_url":"https://api.github.com/users/michaelpj/repos","events_url":"https://api.github.com/users/michaelpj/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpj/received_events","type":"User","site_admin":false},"body":"They are separate - due to the nesting machinery I have `test/a`, `test/b` etc. I just don't see a point in having `test/golden/a`, `test/golden/b`.","created_at":"2018-10-15T12:52:21Z","updated_at":"2018-10-15T12:52:22Z","html_url":"https://github.com/input-output-hk/plutus/pull/189#discussion_r225153270","pull_request_url":"https://api.github.com/repos/input-output-hk/plutus/pulls/189","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/comments/225153270"},"html":{"href":"https://github.com/input-output-hk/plutus/pull/189#discussion_r225153270"},"pull_request":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/189"}},"in_reply_to_id":225136130},"pull_request":{"url":"https://api.github.com/repos/input-output-hk/plutus/pulls/189","id":222872656,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyODcyNjU2","html_url":"https://github.com/input-output-hk/plutus/pull/189","diff_url":"https://github.com/input-output-hk/plutus/pull/189.diff","patch_url":"https://github.com/input-output-hk/plutus/pull/189.patch","issue_url":"https://api.github.com/repos/input-output-hk/plutus/issues/189","number":189,"state":"open","locked":false,"title":"Move more tests to use the test lib","user":{"login":"michaelpj","id":1699466,"node_id":"MDQ6VXNlcjE2OTk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1699466?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelpj","html_url":"https://github.com/michaelpj","followers_url":"https://api.github.com/users/michaelpj/followers","following_url":"https://api.github.com/users/michaelpj/following{/other_user}","gists_url":"https://api.github.com/users/michaelpj/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpj/subscriptions","organizations_url":"https://api.github.com/users/michaelpj/orgs","repos_url":"https://api.github.com/users/michaelpj/repos","events_url":"https://api.github.com/users/michaelpj/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpj/received_events","type":"User","site_admin":false},"body":"- A couple of generalizations to the testlib.\r\n- Move the tests in `core-to-plc` and `plutus-th` to use the testlib.\r\n\r\nI think possibly the testlib should go in its own package...","created_at":"2018-10-15T11:30:58Z","updated_at":"2018-10-15T12:52:22Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c2dbc8047aa51af30a6e8a4f97e1c87e39afd7a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/input-output-hk/plutus/pulls/189/commits","review_comments_url":"https://api.github.com/repos/input-output-hk/plutus/pulls/189/comments","review_comment_url":"https://api.github.com/repos/input-output-hk/plutus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/input-output-hk/plutus/issues/189/comments","statuses_url":"https://api.github.com/repos/input-output-hk/plutus/statuses/89ac853cd53bf8bcb7c3fede4c0da5d03ac2a95c","head":{"label":"michaelpj:imp/use-test-lib","ref":"imp/use-test-lib","sha":"89ac853cd53bf8bcb7c3fede4c0da5d03ac2a95c","user":{"login":"michaelpj","id":1699466,"node_id":"MDQ6VXNlcjE2OTk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1699466?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelpj","html_url":"https://github.com/michaelpj","followers_url":"https://api.github.com/users/michaelpj/followers","following_url":"https://api.github.com/users/michaelpj/following{/other_user}","gists_url":"https://api.github.com/users/michaelpj/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpj/subscriptions","organizations_url":"https://api.github.com/users/michaelpj/orgs","repos_url":"https://api.github.com/users/michaelpj/repos","events_url":"https://api.github.com/users/michaelpj/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpj/received_events","type":"User","site_admin":false},"repo":{"id":141337224,"node_id":"MDEwOlJlcG9zaXRvcnkxNDEzMzcyMjQ=","name":"plutus-prototype","full_name":"michaelpj/plutus-prototype","private":false,"owner":{"login":"michaelpj","id":1699466,"node_id":"MDQ6VXNlcjE2OTk0NjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1699466?v=4","gravatar_id":"","url":"https://api.github.com/users/michaelpj","html_url":"https://github.com/michaelpj","followers_url":"https://api.github.com/users/michaelpj/followers","following_url":"https://api.github.com/users/michaelpj/following{/other_user}","gists_url":"https://api.github.com/users/michaelpj/gists{/gist_id}","starred_url":"https://api.github.com/users/michaelpj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michaelpj/subscriptions","organizations_url":"https://api.github.com/users/michaelpj/orgs","repos_url":"https://api.github.com/users/michaelpj/repos","events_url":"https://api.github.com/users/michaelpj/events{/privacy}","received_events_url":"https://api.github.com/users/michaelpj/received_events","type":"User","site_admin":false},"html_url":"https://github.com/michaelpj/plutus-prototype","description":null,"fork":true,"url":"https://api.github.com/repos/michaelpj/plutus-prototype","forks_url":"https://api.github.com/repos/michaelpj/plutus-prototype/forks","keys_url":"https://api.github.com/repos/michaelpj/plutus-prototype/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michaelpj/plutus-prototype/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michaelpj/plutus-prototype/teams","hooks_url":"https://api.github.com/repos/michaelpj/plutus-prototype/hooks","issue_events_url":"https://api.github.com/repos/michaelpj/plutus-prototype/issues/events{/number}","events_url":"https://api.github.com/repos/michaelpj/plutus-prototype/events","assignees_url":"https://api.github.com/repos/michaelpj/plutus-prototype/assignees{/user}","branches_url":"https://api.github.com/repos/michaelpj/plutus-prototype/branches{/branch}","tags_url":"https://api.github.com/repos/michaelpj/plutus-prototype/tags","blobs_url":"https://api.github.com/repos/michaelpj/plutus-prototype/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michaelpj/plutus-prototype/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michaelpj/plutus-prototype/git/refs{/sha}","trees_url":"https://api.github.com/repos/michaelpj/plutus-prototype/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michaelpj/plutus-prototype/statuses/{sha}","languages_url":"https://api.github.com/repos/michaelpj/plutus-prototype/languages","stargazers_url":"https://api.github.com/repos/michaelpj/plutus-prototype/stargazers","contributors_url":"https://api.github.com/repos/michaelpj/plutus-prototype/contributors","subscribers_url":"https://api.github.com/repos/michaelpj/plutus-prototype/subscribers","subscription_url":"https://api.github.com/repos/michaelpj/plutus-prototype/subscription","commits_url":"https://api.github.com/repos/michaelpj/plutus-prototype/commits{/sha}","git_commits_url":"https://api.github.com/repos/michaelpj/plutus-prototype/git/commits{/sha}","comments_url":"https://api.github.com/repos/michaelpj/plutus-prototype/comments{/number}","issue_comment_url":"https://api.github.com/repos/michaelpj/plutus-prototype/issues/comments{/number}","contents_url":"https://api.github.com/repos/michaelpj/plutus-prototype/contents/{+path}","compare_url":"https://api.github.com/repos/michaelpj/plutus-prototype/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michaelpj/plutus-prototype/merges","archive_url":"https://api.github.com/repos/michaelpj/plutus-prototype/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michaelpj/plutus-prototype/downloads","issues_url":"https://api.github.com/repos/michaelpj/plutus-prototype/issues{/number}","pulls_url":"https://api.github.com/repos/michaelpj/plutus-prototype/pulls{/number}","milestones_url":"https://api.github.com/repos/michaelpj/plutus-prototype/milestones{/number}","notifications_url":"https://api.github.com/repos/michaelpj/plutus-prototype/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michaelpj/plutus-prototype/labels{/name}","releases_url":"https://api.github.com/repos/michaelpj/plutus-prototype/releases{/id}","deployments_url":"https://api.github.com/repos/michaelpj/plutus-prototype/deployments","created_at":"2018-07-17T19:57:14Z","updated_at":"2018-07-17T19:57:16Z","pushed_at":"2018-10-15T11:54:06Z","git_url":"git://github.com/michaelpj/plutus-prototype.git","ssh_url":"git@github.com:michaelpj/plutus-prototype.git","clone_url":"https://github.com/michaelpj/plutus-prototype.git","svn_url":"https://github.com/michaelpj/plutus-prototype","homepage":null,"size":8400,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"input-output-hk:master","ref":"master","sha":"2b4686b73753a070dc5d57cb753a6d8dac03bb23","user":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"repo":{"id":73861563,"node_id":"MDEwOlJlcG9zaXRvcnk3Mzg2MTU2Mw==","name":"plutus","full_name":"input-output-hk/plutus","private":false,"owner":{"login":"input-output-hk","id":12909177,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEyOTA5MTc3","avatar_url":"https://avatars3.githubusercontent.com/u/12909177?v=4","gravatar_id":"","url":"https://api.github.com/users/input-output-hk","html_url":"https://github.com/input-output-hk","followers_url":"https://api.github.com/users/input-output-hk/followers","following_url":"https://api.github.com/users/input-output-hk/following{/other_user}","gists_url":"https://api.github.com/users/input-output-hk/gists{/gist_id}","starred_url":"https://api.github.com/users/input-output-hk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/input-output-hk/subscriptions","organizations_url":"https://api.github.com/users/input-output-hk/orgs","repos_url":"https://api.github.com/users/input-output-hk/repos","events_url":"https://api.github.com/users/input-output-hk/events{/privacy}","received_events_url":"https://api.github.com/users/input-output-hk/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/input-output-hk/plutus","description":"The Plutus language reference implementation and tools","fork":false,"url":"https://api.github.com/repos/input-output-hk/plutus","forks_url":"https://api.github.com/repos/input-output-hk/plutus/forks","keys_url":"https://api.github.com/repos/input-output-hk/plutus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/input-output-hk/plutus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/input-output-hk/plutus/teams","hooks_url":"https://api.github.com/repos/input-output-hk/plutus/hooks","issue_events_url":"https://api.github.com/repos/input-output-hk/plutus/issues/events{/number}","events_url":"https://api.github.com/repos/input-output-hk/plutus/events","assignees_url":"https://api.github.com/repos/input-output-hk/plutus/assignees{/user}","branches_url":"https://api.github.com/repos/input-output-hk/plutus/branches{/branch}","tags_url":"https://api.github.com/repos/input-output-hk/plutus/tags","blobs_url":"https://api.github.com/repos/input-output-hk/plutus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/input-output-hk/plutus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/input-output-hk/plutus/git/refs{/sha}","trees_url":"https://api.github.com/repos/input-output-hk/plutus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/input-output-hk/plutus/statuses/{sha}","languages_url":"https://api.github.com/repos/input-output-hk/plutus/languages","stargazers_url":"https://api.github.com/repos/input-output-hk/plutus/stargazers","contributors_url":"https://api.github.com/repos/input-output-hk/plutus/contributors","subscribers_url":"https://api.github.com/repos/input-output-hk/plutus/subscribers","subscription_url":"https://api.github.com/repos/input-output-hk/plutus/subscription","commits_url":"https://api.github.com/repos/input-output-hk/plutus/commits{/sha}","git_commits_url":"https://api.github.com/repos/input-output-hk/plutus/git/commits{/sha}","comments_url":"https://api.github.com/repos/input-output-hk/plutus/comments{/number}","issue_comment_url":"https://api.github.com/repos/input-output-hk/plutus/issues/comments{/number}","contents_url":"https://api.github.com/repos/input-output-hk/plutus/contents/{+path}","compare_url":"https://api.github.com/repos/input-output-hk/plutus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/input-output-hk/plutus/merges","archive_url":"https://api.github.com/repos/input-output-hk/plutus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/input-output-hk/plutus/downloads","issues_url":"https://api.github.com/repos/input-output-hk/plutus/issues{/number}","pulls_url":"https://api.github.com/repos/input-output-hk/plutus/pulls{/number}","milestones_url":"https://api.github.com/repos/input-output-hk/plutus/milestones{/number}","notifications_url":"https://api.github.com/repos/input-output-hk/plutus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/input-output-hk/plutus/labels{/name}","releases_url":"https://api.github.com/repos/input-output-hk/plutus/releases{/id}","deployments_url":"https://api.github.com/repos/input-output-hk/plutus/deployments","created_at":"2016-11-15T22:38:43Z","updated_at":"2018-10-15T11:56:10Z","pushed_at":"2018-10-15T11:56:08Z","git_url":"git://github.com/input-output-hk/plutus.git","ssh_url":"git@github.com:input-output-hk/plutus.git","clone_url":"https://github.com/input-output-hk/plutus.git","svn_url":"https://github.com/input-output-hk/plutus","homepage":"","size":8448,"stargazers_count":137,"watchers_count":137,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":24,"open_issues":10,"watchers":137,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/189"},"html":{"href":"https://github.com/input-output-hk/plutus/pull/189"},"issue":{"href":"https://api.github.com/repos/input-output-hk/plutus/issues/189"},"comments":{"href":"https://api.github.com/repos/input-output-hk/plutus/issues/189/comments"},"review_comments":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/189/comments"},"review_comment":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/input-output-hk/plutus/pulls/189/commits"},"statuses":{"href":"https://api.github.com/repos/input-output-hk/plutus/statuses/89ac853cd53bf8bcb7c3fede4c0da5d03ac2a95c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"michaelpj"}}