{"action":"created","issue":{"url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/221","repository_url":"https://api.github.com/repos/cta-sst-1m/digicampipe","labels_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/221/labels{/name}","comments_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/221/comments","events_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/221/events","html_url":"https://github.com/cta-sst-1m/digicampipe/pull/221","id":343130938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyODY3NDY5","number":221,"title":"Renaming of some Hillas attributes w.r.t. ctapipe","user":{"login":"jurysek","id":32541111,"node_id":"MDQ6VXNlcjMyNTQxMTEx","avatar_url":"https://avatars2.githubusercontent.com/u/32541111?v=4","gravatar_id":"","url":"https://api.github.com/users/jurysek","html_url":"https://github.com/jurysek","followers_url":"https://api.github.com/users/jurysek/followers","following_url":"https://api.github.com/users/jurysek/following{/other_user}","gists_url":"https://api.github.com/users/jurysek/gists{/gist_id}","starred_url":"https://api.github.com/users/jurysek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jurysek/subscriptions","organizations_url":"https://api.github.com/users/jurysek/orgs","repos_url":"https://api.github.com/users/jurysek/repos","events_url":"https://api.github.com/users/jurysek/events{/privacy}","received_events_url":"https://api.github.com/users/jurysek/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-20T14:33:37Z","updated_at":"2018-07-20T14:33:39Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/cta-sst-1m/digicampipe/pulls/221","html_url":"https://github.com/cta-sst-1m/digicampipe/pull/221","diff_url":"https://github.com/cta-sst-1m/digicampipe/pull/221.diff","patch_url":"https://github.com/cta-sst-1m/digicampipe/pull/221.patch"},"body":"This small pull request is just for renaming of `size`, `x_cen` and `y_cen` attributes of `HillasParameterContainer()` in order to keep up with with ctapipe. See issue #220 . "},"comment":{"url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/comments/406619007","html_url":"https://github.com/cta-sst-1m/digicampipe/pull/221#issuecomment-406619007","issue_url":"https://api.github.com/repos/cta-sst-1m/digicampipe/issues/221","id":406619007,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjYxOTAwNw==","user":{"login":"pep8speaks","id":24736507,"node_id":"MDQ6VXNlcjI0NzM2NTA3","avatar_url":"https://avatars1.githubusercontent.com/u/24736507?v=4","gravatar_id":"","url":"https://api.github.com/users/pep8speaks","html_url":"https://github.com/pep8speaks","followers_url":"https://api.github.com/users/pep8speaks/followers","following_url":"https://api.github.com/users/pep8speaks/following{/other_user}","gists_url":"https://api.github.com/users/pep8speaks/gists{/gist_id}","starred_url":"https://api.github.com/users/pep8speaks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pep8speaks/subscriptions","organizations_url":"https://api.github.com/users/pep8speaks/orgs","repos_url":"https://api.github.com/users/pep8speaks/repos","events_url":"https://api.github.com/users/pep8speaks/events{/privacy}","received_events_url":"https://api.github.com/users/pep8speaks/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T14:33:39Z","updated_at":"2018-07-20T14:33:39Z","author_association":"NONE","body":"Hello @jurysek! Thanks for submitting the PR.\n\n\n\n\n\n - In the file [`simtel_pipeline.py`](https://github.com/cta-sst-1m/digicampipe/blob/8addbac852e71c48e5efa6f83a2ae492f3cfe022/simtel_pipeline.py), following are the PEP8 issues :\n\n> [Line 59:5](https://github.com/cta-sst-1m/digicampipe/blob/8addbac852e71c48e5efa6f83a2ae492f3cfe022/simtel_pipeline.py#L59): [E125](https://duckduckgo.com/?q=pep8%20E125) continuation line with same indent as next logical line\n> [Line 90:80](https://github.com/cta-sst-1m/digicampipe/blob/8addbac852e71c48e5efa6f83a2ae492f3cfe022/simtel_pipeline.py#L90): [E501](https://duckduckgo.com/?q=pep8%20E501) line too long (82 > 79 characters)\n> [Line 216:9](https://github.com/cta-sst-1m/digicampipe/blob/8addbac852e71c48e5efa6f83a2ae492f3cfe022/simtel_pipeline.py#L216): [E265](https://duckduckgo.com/?q=pep8%20E265) block comment should start with '# '\n> [Line 225:5](https://github.com/cta-sst-1m/digicampipe/blob/8addbac852e71c48e5efa6f83a2ae492f3cfe022/simtel_pipeline.py#L225): [E303](https://duckduckgo.com/?q=pep8%20E303) too many blank lines (2)\n\n"}}
{"actor":{"display_login":"pep8speaks"}}