{"action":"closed","number":521,"pull_request":{"url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/521","id":233973938,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTczOTM4","html_url":"https://github.com/SamZiemer/liferay-portal/pull/521","diff_url":"https://github.com/SamZiemer/liferay-portal/pull/521.diff","patch_url":"https://github.com/SamZiemer/liferay-portal/pull/521.patch","issue_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/521","number":521,"state":"closed","locked":false,"title":"LPS-87782","user":{"login":"brianikim","id":35237986,"node_id":"MDQ6VXNlcjM1MjM3OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/35237986?v=4","gravatar_id":"","url":"https://api.github.com/users/brianikim","html_url":"https://github.com/brianikim","followers_url":"https://api.github.com/users/brianikim/followers","following_url":"https://api.github.com/users/brianikim/following{/other_user}","gists_url":"https://api.github.com/users/brianikim/gists{/gist_id}","starred_url":"https://api.github.com/users/brianikim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianikim/subscriptions","organizations_url":"https://api.github.com/users/brianikim/orgs","repos_url":"https://api.github.com/users/brianikim/repos","events_url":"https://api.github.com/users/brianikim/events{/privacy}","received_events_url":"https://api.github.com/users/brianikim/received_events","type":"User","site_admin":false},"body":"https://issues.liferay.com/browse/LPS-87782\r\n\r\nHello @SamZiemer ,\r\n\r\nThe issue here is that, when a user tries to create a calendar event using the simple pop-up window (rather than using the detailed view that appears when you click edit) **and** the user inputs non-string values for the title, the event fails to be saved.\r\n\r\nThe reason for this issue is that, the simple event creation is being handled by scheduler_models.js in which the content attribute will be set to the value of the input title. However, an error will be thrown when the setter function is called because we always expect the title to be of type string.\r\n\r\nThe fix here is simple in that we need to check if the value of the title is a string, and if not, we need to convert it to a string before we allow the value to be passed onto the sanitization method.\r\n\r\nPlease let me know if you have any questions. Thanks.\r\n\r\nSincerely,\r\nBrian Kim","created_at":"2018-11-27T16:19:36Z","updated_at":"2018-11-27T18:53:22Z","closed_at":"2018-11-27T18:53:21Z","merged_at":null,"merge_commit_sha":"a825ec3f676870580a48ef57168bc5aec8c29170","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":930103356,"node_id":"MDU6TGFiZWw5MzAxMDMzNTY=","url":"https://api.github.com/repos/SamZiemer/liferay-portal/labels/ci:test:relevant%20-%20success","name":"ci:test:relevant - success","color":"c7e8cb","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/521/commits","review_comments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/521/comments","review_comment_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/521/comments","statuses_url":"https://api.github.com/repos/SamZiemer/liferay-portal/statuses/a37f8836ff906ec1df81691d6eca4567d9e5d66e","head":{"label":"brianikim:LPS-87782","ref":"LPS-87782","sha":"a37f8836ff906ec1df81691d6eca4567d9e5d66e","user":{"login":"brianikim","id":35237986,"node_id":"MDQ6VXNlcjM1MjM3OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/35237986?v=4","gravatar_id":"","url":"https://api.github.com/users/brianikim","html_url":"https://github.com/brianikim","followers_url":"https://api.github.com/users/brianikim/followers","following_url":"https://api.github.com/users/brianikim/following{/other_user}","gists_url":"https://api.github.com/users/brianikim/gists{/gist_id}","starred_url":"https://api.github.com/users/brianikim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianikim/subscriptions","organizations_url":"https://api.github.com/users/brianikim/orgs","repos_url":"https://api.github.com/users/brianikim/repos","events_url":"https://api.github.com/users/brianikim/events{/privacy}","received_events_url":"https://api.github.com/users/brianikim/received_events","type":"User","site_admin":false},"repo":{"id":116991194,"node_id":"MDEwOlJlcG9zaXRvcnkxMTY5OTExOTQ=","name":"liferay-portal","full_name":"brianikim/liferay-portal","private":false,"owner":{"login":"brianikim","id":35237986,"node_id":"MDQ6VXNlcjM1MjM3OTg2","avatar_url":"https://avatars1.githubusercontent.com/u/35237986?v=4","gravatar_id":"","url":"https://api.github.com/users/brianikim","html_url":"https://github.com/brianikim","followers_url":"https://api.github.com/users/brianikim/followers","following_url":"https://api.github.com/users/brianikim/following{/other_user}","gists_url":"https://api.github.com/users/brianikim/gists{/gist_id}","starred_url":"https://api.github.com/users/brianikim/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brianikim/subscriptions","organizations_url":"https://api.github.com/users/brianikim/orgs","repos_url":"https://api.github.com/users/brianikim/repos","events_url":"https://api.github.com/users/brianikim/events{/privacy}","received_events_url":"https://api.github.com/users/brianikim/received_events","type":"User","site_admin":false},"html_url":"https://github.com/brianikim/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/brianikim/liferay-portal","forks_url":"https://api.github.com/repos/brianikim/liferay-portal/forks","keys_url":"https://api.github.com/repos/brianikim/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brianikim/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brianikim/liferay-portal/teams","hooks_url":"https://api.github.com/repos/brianikim/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/brianikim/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/brianikim/liferay-portal/events","assignees_url":"https://api.github.com/repos/brianikim/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/brianikim/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/brianikim/liferay-portal/tags","blobs_url":"https://api.github.com/repos/brianikim/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brianikim/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brianikim/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/brianikim/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brianikim/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/brianikim/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/brianikim/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/brianikim/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/brianikim/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/brianikim/liferay-portal/subscription","commits_url":"https://api.github.com/repos/brianikim/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/brianikim/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/brianikim/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/brianikim/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/brianikim/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/brianikim/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brianikim/liferay-portal/merges","archive_url":"https://api.github.com/repos/brianikim/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brianikim/liferay-portal/downloads","issues_url":"https://api.github.com/repos/brianikim/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/brianikim/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/brianikim/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/brianikim/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brianikim/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/brianikim/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/brianikim/liferay-portal/deployments","created_at":"2018-01-10T17:49:01Z","updated_at":"2018-10-23T17:17:11Z","pushed_at":"2018-11-27T16:05:36Z","git_url":"git://github.com/brianikim/liferay-portal.git","ssh_url":"git@github.com:brianikim/liferay-portal.git","clone_url":"https://github.com/brianikim/liferay-portal.git","svn_url":"https://github.com/brianikim/liferay-portal","homepage":"http://liferay.com","size":12724843,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SamZiemer:master","ref":"master","sha":"3e63d23e9213b90da5c2cec263038cf282e7a5d2","user":{"login":"SamZiemer","id":8029905,"node_id":"MDQ6VXNlcjgwMjk5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8029905?v=4","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"repo":{"id":21368461,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM2ODQ2MQ==","name":"liferay-portal","full_name":"SamZiemer/liferay-portal","private":false,"owner":{"login":"SamZiemer","id":8029905,"node_id":"MDQ6VXNlcjgwMjk5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8029905?v=4","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SamZiemer/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/SamZiemer/liferay-portal","forks_url":"https://api.github.com/repos/SamZiemer/liferay-portal/forks","keys_url":"https://api.github.com/repos/SamZiemer/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamZiemer/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamZiemer/liferay-portal/teams","hooks_url":"https://api.github.com/repos/SamZiemer/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/SamZiemer/liferay-portal/events","assignees_url":"https://api.github.com/repos/SamZiemer/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/SamZiemer/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/SamZiemer/liferay-portal/tags","blobs_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamZiemer/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/SamZiemer/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/SamZiemer/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/SamZiemer/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/SamZiemer/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/SamZiemer/liferay-portal/subscription","commits_url":"https://api.github.com/repos/SamZiemer/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamZiemer/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/SamZiemer/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamZiemer/liferay-portal/merges","archive_url":"https://api.github.com/repos/SamZiemer/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamZiemer/liferay-portal/downloads","issues_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/SamZiemer/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/SamZiemer/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamZiemer/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/SamZiemer/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/deployments","created_at":"2014-06-30T22:51:45Z","updated_at":"2018-11-27T18:47:04Z","pushed_at":"2018-11-27T18:47:20Z","git_url":"git://github.com/SamZiemer/liferay-portal.git","ssh_url":"git@github.com:SamZiemer/liferay-portal.git","clone_url":"https://github.com/SamZiemer/liferay-portal.git","svn_url":"https://github.com/SamZiemer/liferay-portal","homepage":"http://liferay.com","size":12766931,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/521"},"html":{"href":"https://github.com/SamZiemer/liferay-portal/pull/521"},"issue":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/521"},"comments":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/521/comments"},"review_comments":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/521/comments"},"review_comment":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/521/commits"},"statuses":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/statuses/a37f8836ff906ec1df81691d6eca4567d9e5d66e"}},"author_association":"NONE","merged":false,"mergeable":true,"rebaseable":false,"mergeable_state":"clean","merged_by":null,"comments":4,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":10,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"SamZiemer"}}