{"push_id":2618172342,"size":10,"distinct_size":10,"ref":"refs/heads/branch-4.7","head":"3c5d0960fbec42690932a07aa3df62f13d374f9d","before":"5be2e90942536d58f50c449a729f0ba26096564f","commits":[{"sha":"8ab854f283bb0aa6f04de806b80faf7b1162808a","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"Build stream modules for integration tests\n\nDescriptions of the changes in this PR:\n\n*Motivation*\n\napache/bookkeeper#1422 adds table service as part of integration tests. so we need to build stream modules\nin order to run integration tests for apache/bookkeeper#1422\n\n*Solution*\n\nAdd \"-Dstream\" in the maven commands for `precommit-integrationtests` CI job.\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Jia Zhai <None>\n\nThis closes #1424 from sijie/compile_stream_module","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/8ab854f283bb0aa6f04de806b80faf7b1162808a"},{"sha":"d869f7ca5b8189382deca1a80f00cde608bcbc1c","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"Allow bookie to start if failed to load extra server components\n\nDescriptions of the changes in this PR:\n\n*Motivation*\n\n`extraServerComponents` provides the flexibility to allow bookie to start with extra server components.\nIt acts as a plugin mechanism to extend the functionality of bookies. However it is okay to allow bookie\nstart up when failed to load extra server components.\n\nThis is a change for allowing starting table service as extra components in bookies.\n\n*Solution*\n\nCatch the exception and log it when failed to load extra server components.\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>\n\nThis closes #1420 from sijie/allow_start_bookie","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/d869f7ca5b8189382deca1a80f00cde608bcbc1c"},{"sha":"b25fc5f3414622b4179e8ea24013b8146d7cf9f4","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"[TABLE SERVICE] start table service as an extra component of bookie\n\nDescriptions of the changes in this PR:\n\n*Motivation*\n\ntable service was built over bookkeeper ledgers. it is an extension to bookies' functionalities, so it is much convenient to start the service as one additional component with bookie, just like how we start `AutoRecovery` along with bookie.\n\n*Solution*\n\n- include `stream/server` module as part of bookkeeper server/all binary distributions\n- abstract `StorageServer` to allow controlling whether to start bookie or not\n- provide a ServerLifecycleComponent of `StorageServer`, so it can be used as an extra component of bookie\n\n*Tests*\n\n- improve the integration tests to start table service as part of bookie containers\n- move `LocationClientTest` to container based integration tests\n\nMaster Issue: #1205\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>\n\nThis closes #1422 from sijie/start_table_service","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/b25fc5f3414622b4179e8ea24013b8146d7cf9f4"},{"sha":"86e23c26a51c6ef0b49f6164b3cb22bb44e08564","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"[TABLE SERVICE] Move integration tests under `stream/tests/integration` to `tests/integration/cluster`\n\nDescriptions of the changes in this PR:\n\nThe original integration tests were written based a non-dockerized standalone stream cluster. Moved them to use\nthe dockerized integration test framework. So all the integration tests are actually testing the table service run as part of bookies.\n\nThis change is based on #1422 .\na371ff2 is the change in this PR to be reviewed.\n\nMaster Issue: #1205\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Jia Zhai <None>\n\nThis closes #1423 from sijie/move_more_stream_it_tests","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/86e23c26a51c6ef0b49f6164b3cb22bb44e08564"},{"sha":"609bf4ed7ebd1f043696d600a567f640cac3057f","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"Publish bookkeeper dev image to docker hub\n\nDescriptions of the changes in this PR:\n\n*Motivation*\n\nWe built a `bookkeeper-current` image that reflects latest master for integration tests. However currently we don't publish this docker image to any docker registry. So it is inconvenient to test latest master in dockerized environments.\n\n*Solution*\n\n- Add a dev script to publish `bookkeeper-current` image to configured docker registry specified at `DOCKER_REGISTRY`\n- Update the nightly snapshot job to publish generated `bookkeeper-current` image to docker hub `apachebookkeeper`\n- Add `bin/standalone` script to use `docker-compose` to launch a 3-nodes bookkeeper cluster locally. The script generates docker-compose.yml and handles mounting local volumes and port forwarding. so developers can use that for quick development.\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>\n\nThis closes #1427 from sijie/push_current_docker_image","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/609bf4ed7ebd1f043696d600a567f640cac3057f"},{"sha":"8e8e22ff6922a012d4959b25638f045406701506","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"[TABLE SERVICE] Move grpc services from server module to storage module\n\nDescriptions of the changes in this PR:\n\n*Motivation*\n\nCurrent almost every grpc requests are wrapped into `StorageContainerRequest` and their responses\nare wrapped into `StorageContainerResponse`. It makes things a bit complicated on adding new grpc\nservices.\n\nTo simplify things, we can use grpc ClientInterceptor to stamp container information (e.g. scId)\ninto the request metadata and write a grpc service registry to take the container information from\nrequest metadata and dispatch requests to containers.\n\nIn order to achieve it, we need to move the grpc services to storage container.\n\n*Solution*\n\nThis PR moves grpc services from server module to storage module, so we can simplify the wire protocols.\n\nMaster Issue: #1205\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Enrico Olivelli <eolivelli@gmail.com>, Jia Zhai <None>\n\nThis closes #1428 from sijie/move_grpc_service_to_storage","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/8e8e22ff6922a012d4959b25638f045406701506"},{"sha":"335082bf3c538fc7aa5eae4e67119092973858c5","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"Fix bookkeeper post commit CI\n\nDescriptions of the changes in this PR:\n\n*Motivation*\n\napache/bookkeeper#1422 includes stream storage integration tests in tests/integration.\nso we need to include `-Dstream` on building the tests.\n\n*Solution*\n\nUpdate the bookkeeper post commit CI jobs to include `-Dstream`\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Enrico Olivelli <eolivelli@gmail.com>\n\nThis closes #1429 from sijie/fix_post_commit_ci","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/335082bf3c538fc7aa5eae4e67119092973858c5"},{"sha":"edeeb102f4acb08fa39ae6868c43ca3572bbacce","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"Use maven-exec-plugin to get the maven project version for CI jobs\n\nDescriptions of the changes in this PR:\n\n*Motivation*\n\nThe current approach to get project version isn't reliable on CI environment. It might have garbage output (e.g. exceptions).\n\n*Solution*\n\nChanged to use `exec-maven-plugin` to echo `${project.vesion}`. It provides a more reliable approach to get version on CI environments.\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Enrico Olivelli <eolivelli@gmail.com>\n\nThis closes #1437 from sijie/fix_getversion_problem","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/edeeb102f4acb08fa39ae6868c43ca3572bbacce"},{"sha":"c9b32d7d3cc352dd6fdd998e91ba15f206b7a568","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"[TABLE SERVICE] client interceptor and storage container grpc proxy\n\nDescriptions of the changes in this PR:\n\nThis is a subsequent change after apache/bookkeeper#1428.\n\n*Motivation*\n\nCurrent almost every grpc requests are wrapped into `StorageContainerRequest` and their responses\nare wrapped into `StorageContainerResponse`. It makes things a bit complicated on adding new grpc\nservices.\n\n*Changes*\n\nTo simplify things, this PR introduces two functionalities for simplifying dispatching container requests/responses.\n\n1) *StorageContainerClientInterceptor*: A grpc `ClientInterceptor` that stamps container information (currently is `scId`) into the requests' metadata before sending the requests to the wire.\n\n2) A simple grpc reverse proxy to dispatch grpc requests to the channels provided by a `ChannelFinder`.\n\n*Tests*\n\n1. Existing unit tests covered client interceptor changes.\n2. Introduced a `stream-storage-tests-common` module to include common classes that would be used for testing.\n3. Introduced a `PingPongService` for testing reverse proxy : unary/client-streaming/server-streaming/bidi-streaming.\n\nMaster Issue: #1205\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Jia Zhai <None>\n\nThis closes #1430 from sijie/interceptor_container_requests","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/c9b32d7d3cc352dd6fdd998e91ba15f206b7a568"},{"sha":"3c5d0960fbec42690932a07aa3df62f13d374f9d","author":{"name":"Sijie Guo","email":"1f0a072942b5a6a61c5ea946a8ff638685cedd4a@apache.org"},"message":"Fix checkstyle warnings\n\nDescriptions of the changes in this PR:\n\n*Motivation*\n\nThere were two concurrent PRs merged at the same time.\n\napache/bookkeeper#1435 (checkstyle changes) was merged before apache/bookkeeper#1430. so checkstyle warnings\nintroduced by apache/bookkeeper#1430 were not caught by any CI jobs.\n\n*Solution*\n\nAddress the checkstyle warnings introduced by apache/bookkeeper#1430\n\nAuthor: Sijie Guo <sijie@apache.org>\n\nReviewers: Enrico Olivelli <eolivelli@gmail.com>\n\nThis closes #1444 from sijie/fix_checkstyle_issue","distinct":true,"url":"https://api.github.com/repos/apache/bookkeeper/commits/3c5d0960fbec42690932a07aa3df62f13d374f9d"}]}
{"actor":{"display_login":"sijie"}}