{"action":"created","comment":{"url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/comments/207202266","pull_request_review_id":142763250,"id":207202266,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNzIwMjI2Ng==","diff_hunk":"@@ -3,6 +3,8 @@\n   <%= email_field_tag :email, params[:email] %>\n   <%= label_tag :password, \"Password\" %>\n   <%= password_field_tag :password, params[:password] %>\n-\n-<%= submit_tag \"Log In\" %>\n+  <%= submit_tag \"Log In\" %>\n <% end %>\n+\n+<%= alert ? alert : '' %><br>\n+<%= link_to \"Sign up for Keeping it rails\", \"/users/new\" %>","path":"app/views/session/new.html.erb","position":10,"original_position":10,"commit_id":"bec96aae8063c294aaea21a6c41fd0e3468f8f69","original_commit_id":"bec96aae8063c294aaea21a6c41fd0e3468f8f69","user":{"login":"elishkaflint","id":39162664,"node_id":"MDQ6VXNlcjM5MTYyNjY0","avatar_url":"https://avatars3.githubusercontent.com/u/39162664?v=4","gravatar_id":"","url":"https://api.github.com/users/elishkaflint","html_url":"https://github.com/elishkaflint","followers_url":"https://api.github.com/users/elishkaflint/followers","following_url":"https://api.github.com/users/elishkaflint/following{/other_user}","gists_url":"https://api.github.com/users/elishkaflint/gists{/gist_id}","starred_url":"https://api.github.com/users/elishkaflint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elishkaflint/subscriptions","organizations_url":"https://api.github.com/users/elishkaflint/orgs","repos_url":"https://api.github.com/users/elishkaflint/repos","events_url":"https://api.github.com/users/elishkaflint/events{/privacy}","received_events_url":"https://api.github.com/users/elishkaflint/received_events","type":"User","site_admin":false},"body":"Should it be sign up for Acebook?","created_at":"2018-08-02T12:10:31Z","updated_at":"2018-08-02T12:10:31Z","html_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails/pull/11#discussion_r207202266","pull_request_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/11","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/comments/207202266"},"html":{"href":"https://github.com/jeff1108/acebook-rails-keeping-it-rails/pull/11#discussion_r207202266"},"pull_request":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/11"}}},"pull_request":{"url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/11","id":205491345,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1NDkxMzQ1","html_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails/pull/11","diff_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails/pull/11.diff","patch_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails/pull/11.patch","issue_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues/11","number":11,"state":"open","locked":false,"title":"Password guard sign up","user":{"login":"dct-lau17","id":25831582,"node_id":"MDQ6VXNlcjI1ODMxNTgy","avatar_url":"https://avatars0.githubusercontent.com/u/25831582?v=4","gravatar_id":"","url":"https://api.github.com/users/dct-lau17","html_url":"https://github.com/dct-lau17","followers_url":"https://api.github.com/users/dct-lau17/followers","following_url":"https://api.github.com/users/dct-lau17/following{/other_user}","gists_url":"https://api.github.com/users/dct-lau17/gists{/gist_id}","starred_url":"https://api.github.com/users/dct-lau17/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dct-lau17/subscriptions","organizations_url":"https://api.github.com/users/dct-lau17/orgs","repos_url":"https://api.github.com/users/dct-lau17/repos","events_url":"https://api.github.com/users/dct-lau17/events{/privacy}","received_events_url":"https://api.github.com/users/dct-lau17/received_events","type":"User","site_admin":false},"body":"-Added validation checks so:\r\na) all fields are filled in the sign up form\r\nb) password must be between 6-10 characters\r\nc) email must be in the correct format\r\nd) user cannot enter an email address already in the database\r\n\r\n-introduced some code in the en.yml file customise validation messages\r\n-changed the route to be the sign up form\r\n-updated view to show messages from the yaml file to the user","created_at":"2018-08-01T17:02:43Z","updated_at":"2018-08-02T12:10:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"83c11d95c4488bc3363269220b5a79ad5c337e06","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/11/commits","review_comments_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/11/comments","review_comment_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues/11/comments","statuses_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/statuses/bec96aae8063c294aaea21a6c41fd0e3468f8f69","head":{"label":"jeff1108:password-guard-sign-up","ref":"password-guard-sign-up","sha":"bec96aae8063c294aaea21a6c41fd0e3468f8f69","user":{"login":"jeff1108","id":32879946,"node_id":"MDQ6VXNlcjMyODc5OTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/32879946?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff1108","html_url":"https://github.com/jeff1108","followers_url":"https://api.github.com/users/jeff1108/followers","following_url":"https://api.github.com/users/jeff1108/following{/other_user}","gists_url":"https://api.github.com/users/jeff1108/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff1108/subscriptions","organizations_url":"https://api.github.com/users/jeff1108/orgs","repos_url":"https://api.github.com/users/jeff1108/repos","events_url":"https://api.github.com/users/jeff1108/events{/privacy}","received_events_url":"https://api.github.com/users/jeff1108/received_events","type":"User","site_admin":false},"repo":{"id":142857145,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI4NTcxNDU=","name":"acebook-rails-keeping-it-rails","full_name":"jeff1108/acebook-rails-keeping-it-rails","owner":{"login":"jeff1108","id":32879946,"node_id":"MDQ6VXNlcjMyODc5OTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/32879946?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff1108","html_url":"https://github.com/jeff1108","followers_url":"https://api.github.com/users/jeff1108/followers","following_url":"https://api.github.com/users/jeff1108/following{/other_user}","gists_url":"https://api.github.com/users/jeff1108/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff1108/subscriptions","organizations_url":"https://api.github.com/users/jeff1108/orgs","repos_url":"https://api.github.com/users/jeff1108/repos","events_url":"https://api.github.com/users/jeff1108/events{/privacy}","received_events_url":"https://api.github.com/users/jeff1108/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails","description":"Template for the AceBook project","fork":true,"url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails","forks_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/forks","keys_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/teams","hooks_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/hooks","issue_events_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues/events{/number}","events_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/events","assignees_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/assignees{/user}","branches_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/branches{/branch}","tags_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/tags","blobs_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/languages","stargazers_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/stargazers","contributors_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/contributors","subscribers_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/subscribers","subscription_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/subscription","commits_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/contents/{+path}","compare_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/merges","archive_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/downloads","issues_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues{/number}","pulls_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/labels{/name}","releases_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/releases{/id}","deployments_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/deployments","created_at":"2018-07-30T09:52:15Z","updated_at":"2018-08-01T20:43:56Z","pushed_at":"2018-08-02T11:17:29Z","git_url":"git://github.com/jeff1108/acebook-rails-keeping-it-rails.git","ssh_url":"git@github.com:jeff1108/acebook-rails-keeping-it-rails.git","clone_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails.git","svn_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails","homepage":"","size":101,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"jeff1108:master","ref":"master","sha":"1218f551826681b0e6a8c59e6a85ef5e7af45ea0","user":{"login":"jeff1108","id":32879946,"node_id":"MDQ6VXNlcjMyODc5OTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/32879946?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff1108","html_url":"https://github.com/jeff1108","followers_url":"https://api.github.com/users/jeff1108/followers","following_url":"https://api.github.com/users/jeff1108/following{/other_user}","gists_url":"https://api.github.com/users/jeff1108/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff1108/subscriptions","organizations_url":"https://api.github.com/users/jeff1108/orgs","repos_url":"https://api.github.com/users/jeff1108/repos","events_url":"https://api.github.com/users/jeff1108/events{/privacy}","received_events_url":"https://api.github.com/users/jeff1108/received_events","type":"User","site_admin":false},"repo":{"id":142857145,"node_id":"MDEwOlJlcG9zaXRvcnkxNDI4NTcxNDU=","name":"acebook-rails-keeping-it-rails","full_name":"jeff1108/acebook-rails-keeping-it-rails","owner":{"login":"jeff1108","id":32879946,"node_id":"MDQ6VXNlcjMyODc5OTQ2","avatar_url":"https://avatars2.githubusercontent.com/u/32879946?v=4","gravatar_id":"","url":"https://api.github.com/users/jeff1108","html_url":"https://github.com/jeff1108","followers_url":"https://api.github.com/users/jeff1108/followers","following_url":"https://api.github.com/users/jeff1108/following{/other_user}","gists_url":"https://api.github.com/users/jeff1108/gists{/gist_id}","starred_url":"https://api.github.com/users/jeff1108/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jeff1108/subscriptions","organizations_url":"https://api.github.com/users/jeff1108/orgs","repos_url":"https://api.github.com/users/jeff1108/repos","events_url":"https://api.github.com/users/jeff1108/events{/privacy}","received_events_url":"https://api.github.com/users/jeff1108/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails","description":"Template for the AceBook project","fork":true,"url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails","forks_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/forks","keys_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/teams","hooks_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/hooks","issue_events_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues/events{/number}","events_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/events","assignees_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/assignees{/user}","branches_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/branches{/branch}","tags_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/tags","blobs_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/refs{/sha}","trees_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/statuses/{sha}","languages_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/languages","stargazers_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/stargazers","contributors_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/contributors","subscribers_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/subscribers","subscription_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/subscription","commits_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/commits{/sha}","git_commits_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/git/commits{/sha}","comments_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/comments{/number}","issue_comment_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues/comments{/number}","contents_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/contents/{+path}","compare_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/merges","archive_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/downloads","issues_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues{/number}","pulls_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls{/number}","milestones_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/milestones{/number}","notifications_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/labels{/name}","releases_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/releases{/id}","deployments_url":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/deployments","created_at":"2018-07-30T09:52:15Z","updated_at":"2018-08-01T20:43:56Z","pushed_at":"2018-08-02T11:17:29Z","git_url":"git://github.com/jeff1108/acebook-rails-keeping-it-rails.git","ssh_url":"git@github.com:jeff1108/acebook-rails-keeping-it-rails.git","clone_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails.git","svn_url":"https://github.com/jeff1108/acebook-rails-keeping-it-rails","homepage":"","size":101,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/11"},"html":{"href":"https://github.com/jeff1108/acebook-rails-keeping-it-rails/pull/11"},"issue":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues/11"},"comments":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/issues/11/comments"},"review_comments":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/11/comments"},"review_comment":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/pulls/11/commits"},"statuses":{"href":"https://api.github.com/repos/jeff1108/acebook-rails-keeping-it-rails/statuses/bec96aae8063c294aaea21a6c41fd0e3468f8f69"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"elishkaflint"}}