{"action":"created","comment":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/comments/230952923","pull_request_review_id":171808866,"id":230952923,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDk1MjkyMw==","diff_hunk":"@@ -0,0 +1,18 @@\n+class ImagesController < ApplicationController\n+  def new\n+    @image = Image.new\n+  end\n+\n+  def create\n+    @image = Image.new(params.require(:image).permit(:url))","path":"app/controllers/images_controller.rb","position":7,"original_position":7,"commit_id":"e8cfa3db11430cc4505b989fda9e0e9158c48fe6","original_commit_id":"f2ea0fd36e6b027f936eccfb3ee76445c5388b25","user":{"login":"HaominZhang","id":2638719,"node_id":"MDQ6VXNlcjI2Mzg3MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/2638719?v=4","gravatar_id":"","url":"https://api.github.com/users/HaominZhang","html_url":"https://github.com/HaominZhang","followers_url":"https://api.github.com/users/HaominZhang/followers","following_url":"https://api.github.com/users/HaominZhang/following{/other_user}","gists_url":"https://api.github.com/users/HaominZhang/gists{/gist_id}","starred_url":"https://api.github.com/users/HaominZhang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HaominZhang/subscriptions","organizations_url":"https://api.github.com/users/HaominZhang/orgs","repos_url":"https://api.github.com/users/HaominZhang/repos","events_url":"https://api.github.com/users/HaominZhang/events{/privacy}","received_events_url":"https://api.github.com/users/HaominZhang/received_events","type":"User","site_admin":false},"body":"Can we move `params.require(:image).permit(:url)` into a private method?","created_at":"2018-11-05T23:30:02Z","updated_at":"2018-11-05T23:45:34Z","html_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88/pull/14#discussion_r230952923","pull_request_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/14","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/comments/230952923"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88/pull/14#discussion_r230952923"},"pull_request":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/14","id":228525188,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4NTI1MTg4","html_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88/pull/14","diff_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88/pull/14.diff","patch_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88/pull/14.patch","issue_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues/14","number":14,"state":"open","locked":false,"title":"Add feature to save image link. Validate the image link. Added unit t…","user":{"login":"gauravc88","id":3439862,"node_id":"MDQ6VXNlcjM0Mzk4NjI=","avatar_url":"https://avatars0.githubusercontent.com/u/3439862?v=4","gravatar_id":"","url":"https://api.github.com/users/gauravc88","html_url":"https://github.com/gauravc88","followers_url":"https://api.github.com/users/gauravc88/followers","following_url":"https://api.github.com/users/gauravc88/following{/other_user}","gists_url":"https://api.github.com/users/gauravc88/gists{/gist_id}","starred_url":"https://api.github.com/users/gauravc88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gauravc88/subscriptions","organizations_url":"https://api.github.com/users/gauravc88/orgs","repos_url":"https://api.github.com/users/gauravc88/repos","events_url":"https://api.github.com/users/gauravc88/events{/privacy}","received_events_url":"https://api.github.com/users/gauravc88/received_events","type":"User","site_admin":false},"body":"…ests.\r\n\r\nCloses #X\r\n\r\n---\r\n\r\nThe following is a checklist to remind you of the steps to take when opening a\r\nnew PR. The horizontal line above and everything below can be removed from the\r\npull request description.\r\n\r\n- [ ] I have replaced `X` above with the associated issue number.\r\n- [ ] I have changed the issue's label to \"pull request\".\r\n- [ ] I have assigned the designated reviewer to this PR.\r\n- [ ] I have set the appropriate label on this PR.\r\n- [ ] I have written clear commit messages ([ref](http://chris.beams.io/posts/git-commit/)).\r\n\r\nIf needed, please review the document on the\r\n[Image Sharing Project](https://sites.google.com/a/appfolio.com/eng/new-hire-resources/engineering-academy/ropes/image-sharing-project)\r\nfor information on how labels should be used.\r\n","created_at":"2018-11-05T23:24:04Z","updated_at":"2018-11-05T23:45:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8cd2c0b30ea21a0d0aacd08e0473087e472fefe7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/14/commits","review_comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/14/comments","review_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/comments{/number}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues/14/comments","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/statuses/e8cfa3db11430cc4505b989fda9e0e9158c48fe6","head":{"label":"AppFolioOnboarding:saveImageLink","ref":"saveImageLink","sha":"e8cfa3db11430cc4505b989fda9e0e9158c48fe6","user":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":155779467,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3Nzk0Njc=","name":"image-sharer-gauravc88","full_name":"AppFolioOnboarding/image-sharer-gauravc88","private":false,"owner":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88","description":"image-sharer-gauravc88 created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/deployments","created_at":"2018-11-01T21:42:52Z","updated_at":"2018-11-01T23:42:07Z","pushed_at":"2018-11-05T23:26:46Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-gauravc88.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-gauravc88.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88","homepage":null,"size":358,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"base":{"label":"AppFolioOnboarding:master","ref":"master","sha":"6eb0f48f2fb437f3ddcc16b531b4a4284e42da18","user":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"repo":{"id":155779467,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU3Nzk0Njc=","name":"image-sharer-gauravc88","full_name":"AppFolioOnboarding/image-sharer-gauravc88","private":false,"owner":{"login":"AppFolioOnboarding","id":16782391,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NzgyMzkx","avatar_url":"https://avatars1.githubusercontent.com/u/16782391?v=4","gravatar_id":"","url":"https://api.github.com/users/AppFolioOnboarding","html_url":"https://github.com/AppFolioOnboarding","followers_url":"https://api.github.com/users/AppFolioOnboarding/followers","following_url":"https://api.github.com/users/AppFolioOnboarding/following{/other_user}","gists_url":"https://api.github.com/users/AppFolioOnboarding/gists{/gist_id}","starred_url":"https://api.github.com/users/AppFolioOnboarding/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AppFolioOnboarding/subscriptions","organizations_url":"https://api.github.com/users/AppFolioOnboarding/orgs","repos_url":"https://api.github.com/users/AppFolioOnboarding/repos","events_url":"https://api.github.com/users/AppFolioOnboarding/events{/privacy}","received_events_url":"https://api.github.com/users/AppFolioOnboarding/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88","description":"image-sharer-gauravc88 created by GitHub Classroom","fork":false,"url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88","forks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/forks","keys_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/teams","hooks_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/hooks","issue_events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues/events{/number}","events_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/events","assignees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/assignees{/user}","branches_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/branches{/branch}","tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/tags","blobs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/refs{/sha}","trees_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/statuses/{sha}","languages_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/languages","stargazers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/stargazers","contributors_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/contributors","subscribers_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/subscribers","subscription_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/subscription","commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/commits{/sha}","git_commits_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/git/commits{/sha}","comments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/comments{/number}","issue_comment_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues/comments{/number}","contents_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/contents/{+path}","compare_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/merges","archive_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/downloads","issues_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues{/number}","pulls_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls{/number}","milestones_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/milestones{/number}","notifications_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/labels{/name}","releases_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/releases{/id}","deployments_url":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/deployments","created_at":"2018-11-01T21:42:52Z","updated_at":"2018-11-01T23:42:07Z","pushed_at":"2018-11-05T23:26:46Z","git_url":"git://github.com/AppFolioOnboarding/image-sharer-gauravc88.git","ssh_url":"git@github.com:AppFolioOnboarding/image-sharer-gauravc88.git","clone_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88.git","svn_url":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88","homepage":null,"size":358,"stargazers_count":0,"watchers_count":0,"language":"Ruby","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":12,"license":null,"forks":0,"open_issues":12,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/14"},"html":{"href":"https://github.com/AppFolioOnboarding/image-sharer-gauravc88/pull/14"},"issue":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues/14"},"comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/AppFolioOnboarding/image-sharer-gauravc88/statuses/e8cfa3db11430cc4505b989fda9e0e9158c48fe6"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"HaominZhang"}}