{"action":"created","comment":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/235506584","pull_request_review_id":177389076,"id":235506584,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTUwNjU4NA==","diff_hunk":"@@ -2,126 +2,147 @@ import VTimePickerTitle from '@/components/VTimePicker/VTimePickerTitle'\n import { test } from '@/test'\n \n test('VTimePickerTitle.js', ({ mount }) => {\n-  it('should render component in 24hr', () => {\n-    const wrapper = mount(VTimePickerTitle, {\n-      propsData: {\n-        hour: 14,\n-        minute: 13,\n-        period: 'pm',\n-        ampm: false\n-      }\n+  [true, false].forEach(useSecondsValue => {","path":"packages/vuetify/test/unit/components/VTimePicker/VTimePickerTitle.spec.js","position":14,"original_position":12,"commit_id":"12652f14895856ed9ea1b6ef48190778e12acf4c","original_commit_id":"d5b44e36d4a0329e31ede15866fa2929a83281bc","user":{"login":"toshiroakio","id":16118339,"node_id":"MDQ6VXNlcjE2MTE4MzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16118339?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiroakio","html_url":"https://github.com/toshiroakio","followers_url":"https://api.github.com/users/toshiroakio/followers","following_url":"https://api.github.com/users/toshiroakio/following{/other_user}","gists_url":"https://api.github.com/users/toshiroakio/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiroakio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiroakio/subscriptions","organizations_url":"https://api.github.com/users/toshiroakio/orgs","repos_url":"https://api.github.com/users/toshiroakio/repos","events_url":"https://api.github.com/users/toshiroakio/events{/privacy}","received_events_url":"https://api.github.com/users/toshiroakio/received_events","type":"User","site_admin":false},"body":"I've never worked with unit tests before. \r\nTypeError: describe.each is not a function","created_at":"2018-11-21T18:59:51Z","updated_at":"2018-11-21T18:59:51Z","html_url":"https://github.com/vuetifyjs/vuetify/pull/5674#discussion_r235506584","pull_request_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5674","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments/235506584"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/5674#discussion_r235506584"},"pull_request":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5674"}},"in_reply_to_id":235396600},"pull_request":{"url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5674","id":232441122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNDQxMTIy","html_url":"https://github.com/vuetifyjs/vuetify/pull/5674","diff_url":"https://github.com/vuetifyjs/vuetify/pull/5674.diff","patch_url":"https://github.com/vuetifyjs/vuetify/pull/5674.patch","issue_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/5674","number":5674,"state":"open","locked":false,"title":"Added seconds support to the VTimePicker","user":{"login":"toshiroakio","id":16118339,"node_id":"MDQ6VXNlcjE2MTE4MzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16118339?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiroakio","html_url":"https://github.com/toshiroakio","followers_url":"https://api.github.com/users/toshiroakio/followers","following_url":"https://api.github.com/users/toshiroakio/following{/other_user}","gists_url":"https://api.github.com/users/toshiroakio/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiroakio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiroakio/subscriptions","organizations_url":"https://api.github.com/users/toshiroakio/orgs","repos_url":"https://api.github.com/users/toshiroakio/repos","events_url":"https://api.github.com/users/toshiroakio/events{/privacy}","received_events_url":"https://api.github.com/users/toshiroakio/received_events","type":"User","site_admin":false},"body":"Fixes #5211\r\n\r\n## Added seconds support to the VTimePicker:\r\n- [x] added \"use-seconds\" props (default: false, type: Boolean) - on/off seconds support\r\n- [x] added \"allowed-seconds\" props (default: null, type: Function) - Restricts which minutes can be selected\r\n\r\n\r\n<!-- Provide a general summary of your changes in the Title above -->\r\n<!-- Keep the title short and descriptive, as it will be used as a commit message -->\r\n\r\n## Description\r\nAdded seconds support to the VTimePicker\r\n\r\n## Motivation and Context\r\nThe VTimePicker component did not support seconds. I fixed it.\r\n\r\n## Markup:\r\n<!--- Paste markup for testing your change --->\r\n<details>\r\n\r\n```vue\r\n<template>\r\n  <v-app>\r\n    <v-layout row wrap>\r\n    <v-flex xs11 sm5>\r\n      <v-menu\r\n        ref=\"menu\"\r\n        :close-on-content-click=\"false\"\r\n        v-model=\"menu2\"\r\n        :nudge-right=\"40\"\r\n        :return-value.sync=\"time\"\r\n        lazy\r\n        transition=\"scale-transition\"\r\n        offset-y\r\n        full-width\r\n        max-width=\"290px\"\r\n        min-width=\"290px\"\r\n      >\r\n        <v-text-field\r\n          slot=\"activator\"\r\n          v-model=\"time\"\r\n          label=\"Picker in menu\"\r\n          prepend-icon=\"access_time\"\r\n          readonly\r\n        ></v-text-field>\r\n        <v-time-picker\r\n          v-if=\"menu2\"\r\n          v-model=\"time\"\r\n          :use-seconds=\"useSeconds\"\r\n          :allowed-hours=\"allowedHours\"\r\n          :allowed-minutes=\"allowedMinutes\"\r\n          :allowed-seconds=\"allowedSeconds\"\r\n          min=\"9:30\"\r\n          max=\"22:15\"\r\n          format=\"24hr\"\r\n          full-width\r\n          scrollable\r\n          @change=\"$refs.menu.save(time)\"\r\n        ></v-time-picker>\r\n        <!-- use-seconds -->\r\n      </v-menu>\r\n      <v-btn @click=\"useSeconds = !useSeconds\" color=\"primary\">Seconds {{ useSeconds ? 'on' : 'off' }}</v-btn>\r\n    </v-flex>\r\n  </v-layout>\r\n  </v-app>\r\n</template>\r\n\r\n<script>\r\n  export default {\r\n    data () {\r\n      return {\r\n        useSeconds: false,\r\n        time: null,\r\n        menu2: false,\r\n        modal2: false\r\n      }\r\n    },\r\n    methods: {\r\n      allowedHours: v => v % 2,\r\n      allowedMinutes: v => v >= 10 && v <= 50,\r\n      allowedSeconds: v => v >= 30 && v <= 40,\r\n      allowedStep: (m) => m % 10 === 0\r\n    }\r\n  }\r\n</script>\r\n\r\n```\r\n</details>\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [x] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Improvement/refactoring (non-breaking change that doesn't add any feature but make things better)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [ ] The PR title is no longer than 64 characters.\r\n- [x] The PR is submitted to the correct branch (`master` for bug fixes, `dev` for new features and breaking changes).\r\n- [x] My code follows the code style of this project.\r\n- [x] My change requires a change to the documentation.\r\n- [ ] I have created a PR in the [documentation](https://github.com/vuetifyjs/vuetifyjs.com) with the necessary changes.\r\n","created_at":"2018-11-20T19:56:12Z","updated_at":"2018-11-21T18:59:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9b2aa266e6dc818c14d12c8c962f0167f90f7b1f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":517773512,"node_id":"MDU6TGFiZWw1MTc3NzM1MTI=","url":"https://api.github.com/repos/vuetifyjs/vuetify/labels/T:%20feature","name":"T: feature","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5674/commits","review_comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5674/comments","review_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/5674/comments","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/12652f14895856ed9ea1b6ef48190778e12acf4c","head":{"label":"toshiroakio:feat/v-time-picker-add-seconds-support","ref":"feat/v-time-picker-add-seconds-support","sha":"12652f14895856ed9ea1b6ef48190778e12acf4c","user":{"login":"toshiroakio","id":16118339,"node_id":"MDQ6VXNlcjE2MTE4MzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16118339?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiroakio","html_url":"https://github.com/toshiroakio","followers_url":"https://api.github.com/users/toshiroakio/followers","following_url":"https://api.github.com/users/toshiroakio/following{/other_user}","gists_url":"https://api.github.com/users/toshiroakio/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiroakio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiroakio/subscriptions","organizations_url":"https://api.github.com/users/toshiroakio/orgs","repos_url":"https://api.github.com/users/toshiroakio/repos","events_url":"https://api.github.com/users/toshiroakio/events{/privacy}","received_events_url":"https://api.github.com/users/toshiroakio/received_events","type":"User","site_admin":false},"repo":{"id":158440534,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg0NDA1MzQ=","name":"vuetify","full_name":"toshiroakio/vuetify","private":false,"owner":{"login":"toshiroakio","id":16118339,"node_id":"MDQ6VXNlcjE2MTE4MzM5","avatar_url":"https://avatars2.githubusercontent.com/u/16118339?v=4","gravatar_id":"","url":"https://api.github.com/users/toshiroakio","html_url":"https://github.com/toshiroakio","followers_url":"https://api.github.com/users/toshiroakio/followers","following_url":"https://api.github.com/users/toshiroakio/following{/other_user}","gists_url":"https://api.github.com/users/toshiroakio/gists{/gist_id}","starred_url":"https://api.github.com/users/toshiroakio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toshiroakio/subscriptions","organizations_url":"https://api.github.com/users/toshiroakio/orgs","repos_url":"https://api.github.com/users/toshiroakio/repos","events_url":"https://api.github.com/users/toshiroakio/events{/privacy}","received_events_url":"https://api.github.com/users/toshiroakio/received_events","type":"User","site_admin":false},"html_url":"https://github.com/toshiroakio/vuetify","description":"Material Component Framework for Vue.js 2","fork":true,"url":"https://api.github.com/repos/toshiroakio/vuetify","forks_url":"https://api.github.com/repos/toshiroakio/vuetify/forks","keys_url":"https://api.github.com/repos/toshiroakio/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toshiroakio/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toshiroakio/vuetify/teams","hooks_url":"https://api.github.com/repos/toshiroakio/vuetify/hooks","issue_events_url":"https://api.github.com/repos/toshiroakio/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/toshiroakio/vuetify/events","assignees_url":"https://api.github.com/repos/toshiroakio/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/toshiroakio/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/toshiroakio/vuetify/tags","blobs_url":"https://api.github.com/repos/toshiroakio/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toshiroakio/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toshiroakio/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/toshiroakio/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toshiroakio/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/toshiroakio/vuetify/languages","stargazers_url":"https://api.github.com/repos/toshiroakio/vuetify/stargazers","contributors_url":"https://api.github.com/repos/toshiroakio/vuetify/contributors","subscribers_url":"https://api.github.com/repos/toshiroakio/vuetify/subscribers","subscription_url":"https://api.github.com/repos/toshiroakio/vuetify/subscription","commits_url":"https://api.github.com/repos/toshiroakio/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/toshiroakio/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/toshiroakio/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/toshiroakio/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/toshiroakio/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/toshiroakio/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toshiroakio/vuetify/merges","archive_url":"https://api.github.com/repos/toshiroakio/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toshiroakio/vuetify/downloads","issues_url":"https://api.github.com/repos/toshiroakio/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/toshiroakio/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/toshiroakio/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/toshiroakio/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toshiroakio/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/toshiroakio/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/toshiroakio/vuetify/deployments","created_at":"2018-11-20T19:25:17Z","updated_at":"2018-11-20T19:25:23Z","pushed_at":"2018-11-21T18:56:40Z","git_url":"git://github.com/toshiroakio/vuetify.git","ssh_url":"git@github.com:toshiroakio/vuetify.git","clone_url":"https://github.com/toshiroakio/vuetify.git","svn_url":"https://github.com/toshiroakio/vuetify","homepage":"https://vuetifyjs.com","size":42003,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"vuetifyjs:dev","ref":"dev","sha":"34d25edfef39b8b06f216c63afa314c0d573a7e6","user":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"repo":{"id":67962648,"node_id":"MDEwOlJlcG9zaXRvcnk2Nzk2MjY0OA==","name":"vuetify","full_name":"vuetifyjs/vuetify","private":false,"owner":{"login":"vuetifyjs","id":22138497,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTM4NDk3","avatar_url":"https://avatars3.githubusercontent.com/u/22138497?v=4","gravatar_id":"","url":"https://api.github.com/users/vuetifyjs","html_url":"https://github.com/vuetifyjs","followers_url":"https://api.github.com/users/vuetifyjs/followers","following_url":"https://api.github.com/users/vuetifyjs/following{/other_user}","gists_url":"https://api.github.com/users/vuetifyjs/gists{/gist_id}","starred_url":"https://api.github.com/users/vuetifyjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vuetifyjs/subscriptions","organizations_url":"https://api.github.com/users/vuetifyjs/orgs","repos_url":"https://api.github.com/users/vuetifyjs/repos","events_url":"https://api.github.com/users/vuetifyjs/events{/privacy}","received_events_url":"https://api.github.com/users/vuetifyjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/vuetifyjs/vuetify","description":"Material Component Framework for Vue.js 2","fork":false,"url":"https://api.github.com/repos/vuetifyjs/vuetify","forks_url":"https://api.github.com/repos/vuetifyjs/vuetify/forks","keys_url":"https://api.github.com/repos/vuetifyjs/vuetify/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vuetifyjs/vuetify/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vuetifyjs/vuetify/teams","hooks_url":"https://api.github.com/repos/vuetifyjs/vuetify/hooks","issue_events_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/events{/number}","events_url":"https://api.github.com/repos/vuetifyjs/vuetify/events","assignees_url":"https://api.github.com/repos/vuetifyjs/vuetify/assignees{/user}","branches_url":"https://api.github.com/repos/vuetifyjs/vuetify/branches{/branch}","tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/tags","blobs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/refs{/sha}","trees_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/{sha}","languages_url":"https://api.github.com/repos/vuetifyjs/vuetify/languages","stargazers_url":"https://api.github.com/repos/vuetifyjs/vuetify/stargazers","contributors_url":"https://api.github.com/repos/vuetifyjs/vuetify/contributors","subscribers_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscribers","subscription_url":"https://api.github.com/repos/vuetifyjs/vuetify/subscription","commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/commits{/sha}","git_commits_url":"https://api.github.com/repos/vuetifyjs/vuetify/git/commits{/sha}","comments_url":"https://api.github.com/repos/vuetifyjs/vuetify/comments{/number}","issue_comment_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues/comments{/number}","contents_url":"https://api.github.com/repos/vuetifyjs/vuetify/contents/{+path}","compare_url":"https://api.github.com/repos/vuetifyjs/vuetify/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vuetifyjs/vuetify/merges","archive_url":"https://api.github.com/repos/vuetifyjs/vuetify/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vuetifyjs/vuetify/downloads","issues_url":"https://api.github.com/repos/vuetifyjs/vuetify/issues{/number}","pulls_url":"https://api.github.com/repos/vuetifyjs/vuetify/pulls{/number}","milestones_url":"https://api.github.com/repos/vuetifyjs/vuetify/milestones{/number}","notifications_url":"https://api.github.com/repos/vuetifyjs/vuetify/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vuetifyjs/vuetify/labels{/name}","releases_url":"https://api.github.com/repos/vuetifyjs/vuetify/releases{/id}","deployments_url":"https://api.github.com/repos/vuetifyjs/vuetify/deployments","created_at":"2016-09-12T00:39:35Z","updated_at":"2018-11-21T17:02:35Z","pushed_at":"2018-11-21T18:56:42Z","git_url":"git://github.com/vuetifyjs/vuetify.git","ssh_url":"git@github.com:vuetifyjs/vuetify.git","clone_url":"https://github.com/vuetifyjs/vuetify.git","svn_url":"https://github.com/vuetifyjs/vuetify","homepage":"https://vuetifyjs.com","size":42017,"stargazers_count":14721,"watchers_count":14721,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1343,"mirror_url":null,"archived":false,"open_issues_count":568,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1343,"open_issues":568,"watchers":14721,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5674"},"html":{"href":"https://github.com/vuetifyjs/vuetify/pull/5674"},"issue":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/5674"},"comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/issues/5674/comments"},"review_comments":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5674/comments"},"review_comment":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/pulls/5674/commits"},"statuses":{"href":"https://api.github.com/repos/vuetifyjs/vuetify/statuses/12652f14895856ed9ea1b6ef48190778e12acf4c"}},"author_association":"NONE"}}
{"actor":{"display_login":"toshiroakio"}}