{"action":"opened","number":272,"pull_request":{"url":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls/272","id":170992814,"html_url":"https://github.com/Microsoft/azure-spring-boot/pull/272","diff_url":"https://github.com/Microsoft/azure-spring-boot/pull/272.diff","patch_url":"https://github.com/Microsoft/azure-spring-boot/pull/272.patch","issue_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/issues/272","number":272,"state":"open","locked":false,"title":"Includes AsymmetricKeyCredential/Certificate based authentication to Key Vault Boot Starter ","user":{"login":"fragmadata","id":16283068,"avatar_url":"https://avatars2.githubusercontent.com/u/16283068?v=4","gravatar_id":"","url":"https://api.github.com/users/fragmadata","html_url":"https://github.com/fragmadata","followers_url":"https://api.github.com/users/fragmadata/followers","following_url":"https://api.github.com/users/fragmadata/following{/other_user}","gists_url":"https://api.github.com/users/fragmadata/gists{/gist_id}","starred_url":"https://api.github.com/users/fragmadata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragmadata/subscriptions","organizations_url":"https://api.github.com/users/fragmadata/orgs","repos_url":"https://api.github.com/users/fragmadata/repos","events_url":"https://api.github.com/users/fragmadata/events{/privacy}","received_events_url":"https://api.github.com/users/fragmadata/received_events","type":"User","site_admin":false},"body":"Hi,\r\n\r\nCurrently the class com.microsoft.azure.keyvault.spring.KeyVaultEnvironmentPostProcessorHelper accepts only clientID and clientKey based authentication to KeyVault, and there is no way by which certificates can be used.\r\n\r\nWe are submitting a small code change which will allow users to use PFX certificate.\r\nUsers will have to mention the following attributes if choosing to use PFX certificate:\r\nazure.keyvault.pfx-certificate-path\r\nazure.keyvault.pfx-certificate-password (optional)\r\n\r\nThis is a functionality we require to have for our product using Key Vault.\r\nRequest you to please merge if found appropriate. Please suggest otherwise.\r\n\r\nRegards,\r\nTeam Fragma","created_at":"2018-02-23T11:28:39Z","updated_at":"2018-02-23T11:28:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls/272/commits","review_comments_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls/272/comments","review_comment_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/issues/272/comments","statuses_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/statuses/657ba2d2a3396b206b0bc72eb78545d1952b0cde","head":{"label":"fragmadata:master","ref":"master","sha":"657ba2d2a3396b206b0bc72eb78545d1952b0cde","user":{"login":"fragmadata","id":16283068,"avatar_url":"https://avatars2.githubusercontent.com/u/16283068?v=4","gravatar_id":"","url":"https://api.github.com/users/fragmadata","html_url":"https://github.com/fragmadata","followers_url":"https://api.github.com/users/fragmadata/followers","following_url":"https://api.github.com/users/fragmadata/following{/other_user}","gists_url":"https://api.github.com/users/fragmadata/gists{/gist_id}","starred_url":"https://api.github.com/users/fragmadata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragmadata/subscriptions","organizations_url":"https://api.github.com/users/fragmadata/orgs","repos_url":"https://api.github.com/users/fragmadata/repos","events_url":"https://api.github.com/users/fragmadata/events{/privacy}","received_events_url":"https://api.github.com/users/fragmadata/received_events","type":"User","site_admin":false},"repo":{"id":122583909,"name":"azure-spring-boot","full_name":"fragmadata/azure-spring-boot","owner":{"login":"fragmadata","id":16283068,"avatar_url":"https://avatars2.githubusercontent.com/u/16283068?v=4","gravatar_id":"","url":"https://api.github.com/users/fragmadata","html_url":"https://github.com/fragmadata","followers_url":"https://api.github.com/users/fragmadata/followers","following_url":"https://api.github.com/users/fragmadata/following{/other_user}","gists_url":"https://api.github.com/users/fragmadata/gists{/gist_id}","starred_url":"https://api.github.com/users/fragmadata/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragmadata/subscriptions","organizations_url":"https://api.github.com/users/fragmadata/orgs","repos_url":"https://api.github.com/users/fragmadata/repos","events_url":"https://api.github.com/users/fragmadata/events{/privacy}","received_events_url":"https://api.github.com/users/fragmadata/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/fragmadata/azure-spring-boot","description":"Spring Boot Starters for Azure services","fork":true,"url":"https://api.github.com/repos/fragmadata/azure-spring-boot","forks_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/forks","keys_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/teams","hooks_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/hooks","issue_events_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/events","assignees_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/tags","blobs_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/languages","stargazers_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/stargazers","contributors_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/contributors","subscribers_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/subscribers","subscription_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/subscription","commits_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/merges","archive_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/downloads","issues_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/fragmadata/azure-spring-boot/deployments","created_at":"2018-02-23T06:47:54Z","updated_at":"2018-02-23T06:47:56Z","pushed_at":"2018-02-23T11:18:08Z","git_url":"git://github.com/fragmadata/azure-spring-boot.git","ssh_url":"git@github.com:fragmadata/azure-spring-boot.git","clone_url":"https://github.com/fragmadata/azure-spring-boot.git","svn_url":"https://github.com/fragmadata/azure-spring-boot","homepage":"","size":1573,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"15dd355a767666f5f2d1b23c3b245a18e21dae46","user":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":93699852,"name":"azure-spring-boot","full_name":"Microsoft/azure-spring-boot","owner":{"login":"Microsoft","id":6154722,"avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/azure-spring-boot","description":"Spring Boot Starters for Azure services","fork":false,"url":"https://api.github.com/repos/Microsoft/azure-spring-boot","forks_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/forks","keys_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/teams","hooks_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/events","assignees_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/tags","blobs_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/languages","stargazers_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/subscription","commits_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/merges","archive_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/downloads","issues_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/azure-spring-boot/deployments","created_at":"2017-06-08T02:36:34Z","updated_at":"2018-02-18T18:47:20Z","pushed_at":"2018-02-15T12:32:18Z","git_url":"git://github.com/Microsoft/azure-spring-boot.git","ssh_url":"git@github.com:Microsoft/azure-spring-boot.git","clone_url":"https://github.com/Microsoft/azure-spring-boot.git","svn_url":"https://github.com/Microsoft/azure-spring-boot","homepage":"","size":1570,"stargazers_count":56,"watchers_count":56,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":42,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":42,"open_issues":21,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls/272"},"html":{"href":"https://github.com/Microsoft/azure-spring-boot/pull/272"},"issue":{"href":"https://api.github.com/repos/Microsoft/azure-spring-boot/issues/272"},"comments":{"href":"https://api.github.com/repos/Microsoft/azure-spring-boot/issues/272/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls/272/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/azure-spring-boot/pulls/272/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/azure-spring-boot/statuses/657ba2d2a3396b206b0bc72eb78545d1952b0cde"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":147,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"fragmadata"}}