{"action":"created","issue":{"url":"https://api.github.com/repos/smiths/caseStudies/issues/81","repository_url":"https://api.github.com/repos/smiths/caseStudies","labels_url":"https://api.github.com/repos/smiths/caseStudies/issues/81/labels{/name}","comments_url":"https://api.github.com/repos/smiths/caseStudies/issues/81/comments","events_url":"https://api.github.com/repos/smiths/caseStudies/issues/81/events","html_url":"https://github.com/smiths/caseStudies/issues/81","id":329083440,"node_id":"MDU6SXNzdWUzMjkwODM0NDA=","number":81,"title":"Add Exceptions to Implementation","user":{"login":"samm82","id":35857611,"node_id":"MDQ6VXNlcjM1ODU3NjEx","avatar_url":"https://avatars3.githubusercontent.com/u/35857611?v=4","gravatar_id":"","url":"https://api.github.com/users/samm82","html_url":"https://github.com/samm82","followers_url":"https://api.github.com/users/samm82/followers","following_url":"https://api.github.com/users/samm82/following{/other_user}","gists_url":"https://api.github.com/users/samm82/gists{/gist_id}","starred_url":"https://api.github.com/users/samm82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samm82/subscriptions","organizations_url":"https://api.github.com/users/samm82/orgs","repos_url":"https://api.github.com/users/samm82/repos","events_url":"https://api.github.com/users/samm82/events{/privacy}","received_events_url":"https://api.github.com/users/samm82/received_events","type":"User","site_admin":false},"labels":[{"id":800682820,"node_id":"MDU6TGFiZWw4MDA2ODI4MjA=","url":"https://api.github.com/repos/smiths/caseStudies/labels/GlassBR","name":"GlassBR","color":"3edd98","default":false}],"state":"open","locked":false,"assignee":{"login":"smiths","id":1422000,"node_id":"MDQ6VXNlcjE0MjIwMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1422000?v=4","gravatar_id":"","url":"https://api.github.com/users/smiths","html_url":"https://github.com/smiths","followers_url":"https://api.github.com/users/smiths/followers","following_url":"https://api.github.com/users/smiths/following{/other_user}","gists_url":"https://api.github.com/users/smiths/gists{/gist_id}","starred_url":"https://api.github.com/users/smiths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smiths/subscriptions","organizations_url":"https://api.github.com/users/smiths/orgs","repos_url":"https://api.github.com/users/smiths/repos","events_url":"https://api.github.com/users/smiths/events{/privacy}","received_events_url":"https://api.github.com/users/smiths/received_events","type":"User","site_admin":false},"assignees":[{"login":"smiths","id":1422000,"node_id":"MDQ6VXNlcjE0MjIwMDA=","avatar_url":"https://avatars2.githubusercontent.com/u/1422000?v=4","gravatar_id":"","url":"https://api.github.com/users/smiths","html_url":"https://github.com/smiths","followers_url":"https://api.github.com/users/smiths/followers","following_url":"https://api.github.com/users/smiths/following{/other_user}","gists_url":"https://api.github.com/users/smiths/gists{/gist_id}","starred_url":"https://api.github.com/users/smiths/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/smiths/subscriptions","organizations_url":"https://api.github.com/users/smiths/orgs","repos_url":"https://api.github.com/users/smiths/repos","events_url":"https://api.github.com/users/smiths/events{/privacy}","received_events_url":"https://api.github.com/users/smiths/received_events","type":"User","site_admin":false},{"login":"samm82","id":35857611,"node_id":"MDQ6VXNlcjM1ODU3NjEx","avatar_url":"https://avatars3.githubusercontent.com/u/35857611?v=4","gravatar_id":"","url":"https://api.github.com/users/samm82","html_url":"https://github.com/samm82","followers_url":"https://api.github.com/users/samm82/followers","following_url":"https://api.github.com/users/samm82/following{/other_user}","gists_url":"https://api.github.com/users/samm82/gists{/gist_id}","starred_url":"https://api.github.com/users/samm82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samm82/subscriptions","organizations_url":"https://api.github.com/users/samm82/orgs","repos_url":"https://api.github.com/users/samm82/repos","events_url":"https://api.github.com/users/samm82/events{/privacy}","received_events_url":"https://api.github.com/users/samm82/received_events","type":"User","site_admin":false}],"milestone":null,"comments":4,"created_at":"2018-06-04T14:36:54Z","updated_at":"2018-06-06T15:57:35Z","closed_at":null,"author_association":"COLLABORATOR","body":"The original Python directory removed in 80250c2 had exceptions to check for invalid calculated values, while its replacement (formerly Python_Simplified) does not. We need to add these exceptions to the implementations, for example:\r\n\r\n`raise SystemExit(\"Error: q_hat(DD6 in the SRS) is out of bounds. q_hat is less than the smallest value in q_vec. The input a, b might be too small while t might be too large. Please refer to the data definitions section and the data constraints section in the SRS.\")`\r\n\r\nin calculations.py.\r\n\r\n---\r\n# TODO:\r\n- [ ] Make tests expect wrong thickness value\r\n## Implementations\r\n- [ ] calculations.py     \r\n- [ ] checkConstraints.py   \r\n- [ ] derivedValues.py  \r\n- [ ] inputFormat.py    \r\n- [ ] interp.py        \r\n- [ ] mainfun.py       \r\n- [ ] outputFormat.py\r\n- [ ] param.py\r\n- [ ] readTable.py"},"comment":{"url":"https://api.github.com/repos/smiths/caseStudies/issues/comments/395121083","html_url":"https://github.com/smiths/caseStudies/issues/81#issuecomment-395121083","issue_url":"https://api.github.com/repos/smiths/caseStudies/issues/81","id":395121083,"node_id":"MDEyOklzc3VlQ29tbWVudDM5NTEyMTA4Mw==","user":{"login":"samm82","id":35857611,"node_id":"MDQ6VXNlcjM1ODU3NjEx","avatar_url":"https://avatars3.githubusercontent.com/u/35857611?v=4","gravatar_id":"","url":"https://api.github.com/users/samm82","html_url":"https://github.com/samm82","followers_url":"https://api.github.com/users/samm82/followers","following_url":"https://api.github.com/users/samm82/following{/other_user}","gists_url":"https://api.github.com/users/samm82/gists{/gist_id}","starred_url":"https://api.github.com/users/samm82/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/samm82/subscriptions","organizations_url":"https://api.github.com/users/samm82/orgs","repos_url":"https://api.github.com/users/samm82/repos","events_url":"https://api.github.com/users/samm82/events{/privacy}","received_events_url":"https://api.github.com/users/samm82/received_events","type":"User","site_admin":false},"created_at":"2018-06-06T15:57:35Z","updated_at":"2018-06-06T15:57:35Z","author_association":"COLLABORATOR","body":"Potentially? I mean I wouldn't mind if I was coding something, but I've also never coded anything this big picture or important. 😆 I think it is good to have a \"catch-all\" in the conditionals in derivedValues.py just to have, but I could be totally wrong."}}
{"actor":{"display_login":"samm82"}}