{"action":"created","comment":{"url":"https://api.github.com/repos/canjs/can-stache/pulls/comments/177914325","pull_request_review_id":107879685,"id":177914325,"diff_hunk":"@@ -2015,6 +2016,40 @@ function makeTest(name, doc, mutation) {\n \n \t\tdiv = doc.createElement('div');\n \n+\t\tdiv.appendChild(renderer(data,{partials: partials}));\n+\t\tspan = div.getElementsByTagName('span')[0];\n+\t\tstrictEqual(domDataState.get.call(span, 'attr'), data.get('bar'), 'Nested data 1 should have correct data');\n+\n+\t\tdiv = doc.createElement('div');\n+\t\tdiv.appendChild(renderer2(data,{partials: partials}));\n+\t\tspan = div.getElementsByTagName('span')[0];\n+\t\tstrictEqual(domDataState.get.call(span, 'attr'), data.get('bar'), 'Nested data 2 should have correct data');\n+\n+\t\tdiv = doc.createElement('div');\n+\t\tdiv.appendChild(renderer3(data,{partials: partials}));\n+\t\tspan = div.getElementsByTagName('span')[0];\n+\t\tstrictEqual(domDataState.get.call(span, 'attr'), data.get('bar'), 'Nested data 3 should have correct data');\n+\t});\n+\n+\ttest(\"domData helper should set proper data instead of a context stack\", function () {\n+\t\tvar partials = {\n+\t\t\t'nested_data': stache('<span id=\"has_data\" {{domData \"attr\"}}></span>'),\n+\t\t\t'nested_data2': stache('{{#this}}<span id=\"has_data\" {{domData \"attr\"}}></span>{{/this}}'),\n+\t\t\t'nested_data3': stache('{{#../bar}}<span id=\"has_data\" {{domData \"attr\"}}></span>{{/../bar}}')\n+\t\t};\n+\n+\t\tvar renderer = stache(\"{{#bar}}{{> nested_data}}{{/bar}}\"),\n+\t\t\trenderer2 = stache(\"{{#bar}}{{> nested_data2}}{{/bar}}\"),\n+\t\t\trenderer3 = stache(\"{{#bar}}{{> nested_data3}}{{/bar}}\"),\n+\t\t\tdiv = doc.createElement('div'),\n+\t\t\tdata = new SimpleMap({\n+\t\t\t\tfoo: \"bar\",\n+\t\t\t\tbar: new SimpleMap({})\n+\t\t\t}),\n+\t\t\tspan;\n+\n+\t\tdiv = doc.createElement('div');\n+","path":"test/stache-test.js","position":56,"original_position":56,"commit_id":"c8f956800685988997e4004efb7ecd877d9d75af","original_commit_id":"c8f956800685988997e4004efb7ecd877d9d75af","user":{"login":"chasenlehara","id":10070176,"avatar_url":"https://avatars2.githubusercontent.com/u/10070176?v=4","gravatar_id":"","url":"https://api.github.com/users/chasenlehara","html_url":"https://github.com/chasenlehara","followers_url":"https://api.github.com/users/chasenlehara/followers","following_url":"https://api.github.com/users/chasenlehara/following{/other_user}","gists_url":"https://api.github.com/users/chasenlehara/gists{/gist_id}","starred_url":"https://api.github.com/users/chasenlehara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasenlehara/subscriptions","organizations_url":"https://api.github.com/users/chasenlehara/orgs","repos_url":"https://api.github.com/users/chasenlehara/repos","events_url":"https://api.github.com/users/chasenlehara/events{/privacy}","received_events_url":"https://api.github.com/users/chasenlehara/received_events","type":"User","site_admin":false},"body":"This is a copy of the {{data}} tests, so in 5.x we can just drop the {{data}} tests in favor for these new {{domData}} tests.","created_at":"2018-03-28T22:59:43Z","updated_at":"2018-03-28T22:59:43Z","html_url":"https://github.com/canjs/can-stache/pull/500#discussion_r177914325","pull_request_url":"https://api.github.com/repos/canjs/can-stache/pulls/500","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/canjs/can-stache/pulls/comments/177914325"},"html":{"href":"https://github.com/canjs/can-stache/pull/500#discussion_r177914325"},"pull_request":{"href":"https://api.github.com/repos/canjs/can-stache/pulls/500"}}},"pull_request":{"url":"https://api.github.com/repos/canjs/can-stache/pulls/500","id":178186595,"html_url":"https://github.com/canjs/can-stache/pull/500","diff_url":"https://github.com/canjs/can-stache/pull/500.diff","patch_url":"https://github.com/canjs/can-stache/pull/500.patch","issue_url":"https://api.github.com/repos/canjs/can-stache/issues/500","number":500,"state":"open","locked":false,"title":"Deprecate the {{data}} helper in favor of {{domData}}","user":{"login":"chasenlehara","id":10070176,"avatar_url":"https://avatars2.githubusercontent.com/u/10070176?v=4","gravatar_id":"","url":"https://api.github.com/users/chasenlehara","html_url":"https://github.com/chasenlehara","followers_url":"https://api.github.com/users/chasenlehara/followers","following_url":"https://api.github.com/users/chasenlehara/following{/other_user}","gists_url":"https://api.github.com/users/chasenlehara/gists{/gist_id}","starred_url":"https://api.github.com/users/chasenlehara/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chasenlehara/subscriptions","organizations_url":"https://api.github.com/users/chasenlehara/orgs","repos_url":"https://api.github.com/users/chasenlehara/repos","events_url":"https://api.github.com/users/chasenlehara/events{/privacy}","received_events_url":"https://api.github.com/users/chasenlehara/received_events","type":"User","site_admin":false},"body":"This includes a few changes:\r\n\r\n- Adds the {{domData}} helper that uses can-dom-data\r\n- Adds a deprecation warning when {{data}} is used\r\n- Fixes {{data}} to accept a value as the second argument\r\n- Adds docs for {{domData}}\r\n- Includes tests for all these changes\r\n\r\n<details>\r\n<summary>{{domData}} in the sidebar nav</summary>\r\n<img width=\"209\" alt=\"domdata nav\" src=\"https://user-images.githubusercontent.com/10070176/38060589-37959720-32a0-11e8-9483-f053da336853.png\">\r\n</details>\r\n\r\n<details>\r\n<summary>{{domData}} signatures</summary>\r\n<img width=\"839\" alt=\"domdata signatures\" src=\"https://user-images.githubusercontent.com/10070176/38060588-377c310e-32a0-11e8-94ed-7f29e828c038.png\">\r\n</details>\r\n\r\n<details>\r\n<summary>Docs</summary>\r\n<img width=\"840\" alt=\"domdata use\" src=\"https://user-images.githubusercontent.com/10070176/38060644-7e748bd8-32a0-11e8-8c26-70841877da60.png\">\r\n</details>\r\n\r\n<details>\r\n<summary>Docs for passing a value</summary>\r\n<img width=\"838\" alt=\"domdata pass value\" src=\"https://user-images.githubusercontent.com/10070176/38060586-374d8b42-32a0-11e8-841e-904337953c63.png\">\r\n</details>\r\n\r\n\r\n","created_at":"2018-03-28T22:56:31Z","updated_at":"2018-03-28T22:59:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98c88db76da210e1a06cc834b942a1db654bbc21","assignee":null,"assignees":[],"requested_reviewers":[{"login":"justinbmeyer","id":78602,"avatar_url":"https://avatars0.githubusercontent.com/u/78602?v=4","gravatar_id":"","url":"https://api.github.com/users/justinbmeyer","html_url":"https://github.com/justinbmeyer","followers_url":"https://api.github.com/users/justinbmeyer/followers","following_url":"https://api.github.com/users/justinbmeyer/following{/other_user}","gists_url":"https://api.github.com/users/justinbmeyer/gists{/gist_id}","starred_url":"https://api.github.com/users/justinbmeyer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/justinbmeyer/subscriptions","organizations_url":"https://api.github.com/users/justinbmeyer/orgs","repos_url":"https://api.github.com/users/justinbmeyer/repos","events_url":"https://api.github.com/users/justinbmeyer/events{/privacy}","received_events_url":"https://api.github.com/users/justinbmeyer/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/canjs/can-stache/pulls/500/commits","review_comments_url":"https://api.github.com/repos/canjs/can-stache/pulls/500/comments","review_comment_url":"https://api.github.com/repos/canjs/can-stache/pulls/comments{/number}","comments_url":"https://api.github.com/repos/canjs/can-stache/issues/500/comments","statuses_url":"https://api.github.com/repos/canjs/can-stache/statuses/c8f956800685988997e4004efb7ecd877d9d75af","head":{"label":"canjs:domData-helper","ref":"domData-helper","sha":"c8f956800685988997e4004efb7ecd877d9d75af","user":{"login":"canjs","id":11798761,"avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":57057879,"name":"can-stache","full_name":"canjs/can-stache","owner":{"login":"canjs","id":11798761,"avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canjs/can-stache","description":"Live binding handlebars templates","fork":false,"url":"https://api.github.com/repos/canjs/can-stache","forks_url":"https://api.github.com/repos/canjs/can-stache/forks","keys_url":"https://api.github.com/repos/canjs/can-stache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-stache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-stache/teams","hooks_url":"https://api.github.com/repos/canjs/can-stache/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-stache/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-stache/events","assignees_url":"https://api.github.com/repos/canjs/can-stache/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-stache/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-stache/tags","blobs_url":"https://api.github.com/repos/canjs/can-stache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-stache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-stache/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-stache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-stache/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-stache/languages","stargazers_url":"https://api.github.com/repos/canjs/can-stache/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-stache/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-stache/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-stache/subscription","commits_url":"https://api.github.com/repos/canjs/can-stache/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-stache/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-stache/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-stache/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-stache/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-stache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-stache/merges","archive_url":"https://api.github.com/repos/canjs/can-stache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-stache/downloads","issues_url":"https://api.github.com/repos/canjs/can-stache/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-stache/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-stache/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-stache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-stache/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-stache/releases{/id}","deployments_url":"https://api.github.com/repos/canjs/can-stache/deployments","created_at":"2016-04-25T16:27:45Z","updated_at":"2018-03-20T04:12:47Z","pushed_at":"2018-03-28T22:56:31Z","git_url":"git://github.com/canjs/can-stache.git","ssh_url":"git@github.com:canjs/can-stache.git","clone_url":"https://github.com/canjs/can-stache.git","svn_url":"https://github.com/canjs/can-stache","homepage":"https://canjs.com/doc/can-stache.html","size":3760,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":58,"watchers":8,"default_branch":"master"}},"base":{"label":"canjs:master","ref":"master","sha":"f47cdfad8b7a0cc27507d9bfef05395bb039b0c4","user":{"login":"canjs","id":11798761,"avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"repo":{"id":57057879,"name":"can-stache","full_name":"canjs/can-stache","owner":{"login":"canjs","id":11798761,"avatar_url":"https://avatars3.githubusercontent.com/u/11798761?v=4","gravatar_id":"","url":"https://api.github.com/users/canjs","html_url":"https://github.com/canjs","followers_url":"https://api.github.com/users/canjs/followers","following_url":"https://api.github.com/users/canjs/following{/other_user}","gists_url":"https://api.github.com/users/canjs/gists{/gist_id}","starred_url":"https://api.github.com/users/canjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/canjs/subscriptions","organizations_url":"https://api.github.com/users/canjs/orgs","repos_url":"https://api.github.com/users/canjs/repos","events_url":"https://api.github.com/users/canjs/events{/privacy}","received_events_url":"https://api.github.com/users/canjs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/canjs/can-stache","description":"Live binding handlebars templates","fork":false,"url":"https://api.github.com/repos/canjs/can-stache","forks_url":"https://api.github.com/repos/canjs/can-stache/forks","keys_url":"https://api.github.com/repos/canjs/can-stache/keys{/key_id}","collaborators_url":"https://api.github.com/repos/canjs/can-stache/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/canjs/can-stache/teams","hooks_url":"https://api.github.com/repos/canjs/can-stache/hooks","issue_events_url":"https://api.github.com/repos/canjs/can-stache/issues/events{/number}","events_url":"https://api.github.com/repos/canjs/can-stache/events","assignees_url":"https://api.github.com/repos/canjs/can-stache/assignees{/user}","branches_url":"https://api.github.com/repos/canjs/can-stache/branches{/branch}","tags_url":"https://api.github.com/repos/canjs/can-stache/tags","blobs_url":"https://api.github.com/repos/canjs/can-stache/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/canjs/can-stache/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/canjs/can-stache/git/refs{/sha}","trees_url":"https://api.github.com/repos/canjs/can-stache/git/trees{/sha}","statuses_url":"https://api.github.com/repos/canjs/can-stache/statuses/{sha}","languages_url":"https://api.github.com/repos/canjs/can-stache/languages","stargazers_url":"https://api.github.com/repos/canjs/can-stache/stargazers","contributors_url":"https://api.github.com/repos/canjs/can-stache/contributors","subscribers_url":"https://api.github.com/repos/canjs/can-stache/subscribers","subscription_url":"https://api.github.com/repos/canjs/can-stache/subscription","commits_url":"https://api.github.com/repos/canjs/can-stache/commits{/sha}","git_commits_url":"https://api.github.com/repos/canjs/can-stache/git/commits{/sha}","comments_url":"https://api.github.com/repos/canjs/can-stache/comments{/number}","issue_comment_url":"https://api.github.com/repos/canjs/can-stache/issues/comments{/number}","contents_url":"https://api.github.com/repos/canjs/can-stache/contents/{+path}","compare_url":"https://api.github.com/repos/canjs/can-stache/compare/{base}...{head}","merges_url":"https://api.github.com/repos/canjs/can-stache/merges","archive_url":"https://api.github.com/repos/canjs/can-stache/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/canjs/can-stache/downloads","issues_url":"https://api.github.com/repos/canjs/can-stache/issues{/number}","pulls_url":"https://api.github.com/repos/canjs/can-stache/pulls{/number}","milestones_url":"https://api.github.com/repos/canjs/can-stache/milestones{/number}","notifications_url":"https://api.github.com/repos/canjs/can-stache/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/canjs/can-stache/labels{/name}","releases_url":"https://api.github.com/repos/canjs/can-stache/releases{/id}","deployments_url":"https://api.github.com/repos/canjs/can-stache/deployments","created_at":"2016-04-25T16:27:45Z","updated_at":"2018-03-20T04:12:47Z","pushed_at":"2018-03-28T22:56:31Z","git_url":"git://github.com/canjs/can-stache.git","ssh_url":"git@github.com:canjs/can-stache.git","clone_url":"https://github.com/canjs/can-stache.git","svn_url":"https://github.com/canjs/can-stache","homepage":"https://canjs.com/doc/can-stache.html","size":3760,"stargazers_count":8,"watchers_count":8,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":58,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":9,"open_issues":58,"watchers":8,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/canjs/can-stache/pulls/500"},"html":{"href":"https://github.com/canjs/can-stache/pull/500"},"issue":{"href":"https://api.github.com/repos/canjs/can-stache/issues/500"},"comments":{"href":"https://api.github.com/repos/canjs/can-stache/issues/500/comments"},"review_comments":{"href":"https://api.github.com/repos/canjs/can-stache/pulls/500/comments"},"review_comment":{"href":"https://api.github.com/repos/canjs/can-stache/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/canjs/can-stache/pulls/500/commits"},"statuses":{"href":"https://api.github.com/repos/canjs/can-stache/statuses/c8f956800685988997e4004efb7ecd877d9d75af"}},"author_association":"OWNER"}}
{"actor":{"display_login":"chasenlehara"}}