{"action":"created","issue":{"url":"https://api.github.com/repos/axios/axios/issues/1718","repository_url":"https://api.github.com/repos/axios/axios","labels_url":"https://api.github.com/repos/axios/axios/issues/1718/labels{/name}","comments_url":"https://api.github.com/repos/axios/axios/issues/1718/comments","events_url":"https://api.github.com/repos/axios/axios/issues/1718/events","html_url":"https://github.com/axios/axios/issues/1718","id":349322644,"node_id":"MDU6SXNzdWUzNDkzMjI2NDQ=","number":1718,"title":"#1395 breaks custom config","user":{"login":"rikuayanokozy","id":10336620,"node_id":"MDQ6VXNlcjEwMzM2NjIw","avatar_url":"https://avatars3.githubusercontent.com/u/10336620?v=4","gravatar_id":"","url":"https://api.github.com/users/rikuayanokozy","html_url":"https://github.com/rikuayanokozy","followers_url":"https://api.github.com/users/rikuayanokozy/followers","following_url":"https://api.github.com/users/rikuayanokozy/following{/other_user}","gists_url":"https://api.github.com/users/rikuayanokozy/gists{/gist_id}","starred_url":"https://api.github.com/users/rikuayanokozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikuayanokozy/subscriptions","organizations_url":"https://api.github.com/users/rikuayanokozy/orgs","repos_url":"https://api.github.com/users/rikuayanokozy/repos","events_url":"https://api.github.com/users/rikuayanokozy/events{/privacy}","received_events_url":"https://api.github.com/users/rikuayanokozy/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-08-09T23:11:12Z","updated_at":"2018-08-14T08:26:49Z","closed_at":null,"author_association":"NONE","body":"#### Summary\r\n#1395 launched a fix that instance config may override global config, but it [ignore custom configs](https://github.com/axios/axios/blob/master/lib/core/mergeConfig.js#L36).\r\nSo it will break something we'd like to attach into the config and access in interceptor (e.g. CookieJar).\r\n\r\nFor example (https://codepen.io/anon/pen/gjZRdR?editors=1111):\r\n```js\r\nconst inst = axios.create();\r\ninst.interceptors.request.use(config => {\r\n  console.log('should be \"test\", actual', config.testAttr);\r\n})\r\ninst.get('/', {\r\n  testAttr: 'test',\r\n});\r\n```\r\n\r\n#### Context\r\n\r\n- axios version: v0.19.0-beta.1\r\n- Environment: node & chrome"},"comment":{"url":"https://api.github.com/repos/axios/axios/issues/comments/412794749","html_url":"https://github.com/axios/axios/issues/1718#issuecomment-412794749","issue_url":"https://api.github.com/repos/axios/axios/issues/1718","id":412794749,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjc5NDc0OQ==","user":{"login":"rikuayanokozy","id":10336620,"node_id":"MDQ6VXNlcjEwMzM2NjIw","avatar_url":"https://avatars3.githubusercontent.com/u/10336620?v=4","gravatar_id":"","url":"https://api.github.com/users/rikuayanokozy","html_url":"https://github.com/rikuayanokozy","followers_url":"https://api.github.com/users/rikuayanokozy/followers","following_url":"https://api.github.com/users/rikuayanokozy/following{/other_user}","gists_url":"https://api.github.com/users/rikuayanokozy/gists{/gist_id}","starred_url":"https://api.github.com/users/rikuayanokozy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rikuayanokozy/subscriptions","organizations_url":"https://api.github.com/users/rikuayanokozy/orgs","repos_url":"https://api.github.com/users/rikuayanokozy/repos","events_url":"https://api.github.com/users/rikuayanokozy/events{/privacy}","received_events_url":"https://api.github.com/users/rikuayanokozy/received_events","type":"User","site_admin":false},"created_at":"2018-08-14T08:26:49Z","updated_at":"2018-08-14T08:26:49Z","author_association":"NONE","body":"@zcei \r\nGreat point. Can we just make `config.userData: any` to store user data.\r\nBut since it's a regression, we still need to fix it or put it into breaking changes since it will break some old codes."}}
{"actor":{"display_login":"rikuayanokozy"}}