{"action":"created","comment":{"url":"https://api.github.com/repos/trishume/syntect/pulls/comments/206011505","pull_request_review_id":141388046,"id":206011505,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNjAxMTUwNQ==","diff_hunk":"@@ -185,17 +168,23 @@ impl<'a> ParseState<'a> {\n     /// You can use `ScopeStack#apply` on each operation in succession to get the stack for a given point.\n     /// Look at the code in `highlighter.rs` for an example of doing this for highlighting purposes.\n     ///\n-    /// The vector is in order both by index to apply at (the `usize`) and also by order to apply them at a\n+    /// The returned vector is in order both by index to apply at (the `usize`) and also by order to apply them at a\n     /// given index (e.g popping old scopes before pushing new scopes).\n-    pub fn parse_line(&mut self, line: &str) -> Vec<(usize, ScopeStackOp)> {\n+    ///\n+    /// The `SyntaxSet` has to be the one that contained the syntax that was\n+    /// used to construct this `ParseState`, or an extended version of it.\n+    /// Otherwise the parsing would return the wrong result or even panic. The","path":"src/parsing/parser.rs","position":78,"original_position":78,"commit_id":"913aaf58a2dd288fb190fb91d585d79b55a78de3","original_commit_id":"913aaf58a2dd288fb190fb91d585d79b55a78de3","user":{"login":"robinst","id":16778,"node_id":"MDQ6VXNlcjE2Nzc4","avatar_url":"https://avatars1.githubusercontent.com/u/16778?v=4","gravatar_id":"","url":"https://api.github.com/users/robinst","html_url":"https://github.com/robinst","followers_url":"https://api.github.com/users/robinst/followers","following_url":"https://api.github.com/users/robinst/following{/other_user}","gists_url":"https://api.github.com/users/robinst/gists{/gist_id}","starred_url":"https://api.github.com/users/robinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinst/subscriptions","organizations_url":"https://api.github.com/users/robinst/orgs","repos_url":"https://api.github.com/users/robinst/repos","events_url":"https://api.github.com/users/robinst/events{/privacy}","received_events_url":"https://api.github.com/users/robinst/received_events","type":"User","site_admin":false},"body":"Yeah I think this is something we can easily do after we merge the big PR :).\r\n\r\nAs for the implementation, why wouldn't we just store a copy of the same `u8` on the `SyntaxReference` directly?","created_at":"2018-07-30T04:14:29Z","updated_at":"2018-07-30T04:14:29Z","html_url":"https://github.com/trishume/syntect/pull/190#discussion_r206011505","pull_request_url":"https://api.github.com/repos/trishume/syntect/pulls/190","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/trishume/syntect/pulls/comments/206011505"},"html":{"href":"https://github.com/trishume/syntect/pull/190#discussion_r206011505"},"pull_request":{"href":"https://api.github.com/repos/trishume/syntect/pulls/190"}},"in_reply_to_id":205953658},"pull_request":{"url":"https://api.github.com/repos/trishume/syntect/pulls/190","id":204367102,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzY3MTAy","html_url":"https://github.com/trishume/syntect/pull/190","diff_url":"https://github.com/trishume/syntect/pull/190.diff","patch_url":"https://github.com/trishume/syntect/pull/190.patch","issue_url":"https://api.github.com/repos/trishume/syntect/issues/190","number":190,"state":"open","locked":false,"title":"Store ContextId in ParseState instead of &Context","user":{"login":"robinst","id":16778,"node_id":"MDQ6VXNlcjE2Nzc4","avatar_url":"https://avatars1.githubusercontent.com/u/16778?v=4","gravatar_id":"","url":"https://api.github.com/users/robinst","html_url":"https://github.com/robinst","followers_url":"https://api.github.com/users/robinst/followers","following_url":"https://api.github.com/users/robinst/following{/other_user}","gists_url":"https://api.github.com/users/robinst/gists{/gist_id}","starred_url":"https://api.github.com/users/robinst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robinst/subscriptions","organizations_url":"https://api.github.com/users/robinst/orgs","repos_url":"https://api.github.com/users/robinst/repos","events_url":"https://api.github.com/users/robinst/events{/privacy}","received_events_url":"https://api.github.com/users/robinst/received_events","type":"User","site_admin":false},"body":"This means ParseState doesn't contain a reference to SyntaxSet anymore\r\nand doesn't need a lifetime.\r\n\r\nThis makes it simpler for code that wants to cache it, but it also means\r\nparse_line needs to be called with the SyntaxSet as an argument so that\r\nit can look up contexts.","created_at":"2018-07-27T08:44:42Z","updated_at":"2018-07-30T04:14:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9596f06a4de81adcd888475acfc67f9eb3e0ca70","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/trishume/syntect/pulls/190/commits","review_comments_url":"https://api.github.com/repos/trishume/syntect/pulls/190/comments","review_comment_url":"https://api.github.com/repos/trishume/syntect/pulls/comments{/number}","comments_url":"https://api.github.com/repos/trishume/syntect/issues/190/comments","statuses_url":"https://api.github.com/repos/trishume/syntect/statuses/913aaf58a2dd288fb190fb91d585d79b55a78de3","head":{"label":"trishume:use-arena-for-contexts-parsestate-ids","ref":"use-arena-for-contexts-parsestate-ids","sha":"913aaf58a2dd288fb190fb91d585d79b55a78de3","user":{"login":"trishume","id":887610,"node_id":"MDQ6VXNlcjg4NzYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/887610?v=4","gravatar_id":"","url":"https://api.github.com/users/trishume","html_url":"https://github.com/trishume","followers_url":"https://api.github.com/users/trishume/followers","following_url":"https://api.github.com/users/trishume/following{/other_user}","gists_url":"https://api.github.com/users/trishume/gists{/gist_id}","starred_url":"https://api.github.com/users/trishume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trishume/subscriptions","organizations_url":"https://api.github.com/users/trishume/orgs","repos_url":"https://api.github.com/users/trishume/repos","events_url":"https://api.github.com/users/trishume/events{/privacy}","received_events_url":"https://api.github.com/users/trishume/received_events","type":"User","site_admin":false},"repo":{"id":58836873,"node_id":"MDEwOlJlcG9zaXRvcnk1ODgzNjg3Mw==","name":"syntect","full_name":"trishume/syntect","owner":{"login":"trishume","id":887610,"node_id":"MDQ6VXNlcjg4NzYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/887610?v=4","gravatar_id":"","url":"https://api.github.com/users/trishume","html_url":"https://github.com/trishume","followers_url":"https://api.github.com/users/trishume/followers","following_url":"https://api.github.com/users/trishume/following{/other_user}","gists_url":"https://api.github.com/users/trishume/gists{/gist_id}","starred_url":"https://api.github.com/users/trishume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trishume/subscriptions","organizations_url":"https://api.github.com/users/trishume/orgs","repos_url":"https://api.github.com/users/trishume/repos","events_url":"https://api.github.com/users/trishume/events{/privacy}","received_events_url":"https://api.github.com/users/trishume/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trishume/syntect","description":"Rust library for syntax highlighting using Sublime Text syntax definitions.","fork":false,"url":"https://api.github.com/repos/trishume/syntect","forks_url":"https://api.github.com/repos/trishume/syntect/forks","keys_url":"https://api.github.com/repos/trishume/syntect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trishume/syntect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trishume/syntect/teams","hooks_url":"https://api.github.com/repos/trishume/syntect/hooks","issue_events_url":"https://api.github.com/repos/trishume/syntect/issues/events{/number}","events_url":"https://api.github.com/repos/trishume/syntect/events","assignees_url":"https://api.github.com/repos/trishume/syntect/assignees{/user}","branches_url":"https://api.github.com/repos/trishume/syntect/branches{/branch}","tags_url":"https://api.github.com/repos/trishume/syntect/tags","blobs_url":"https://api.github.com/repos/trishume/syntect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trishume/syntect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trishume/syntect/git/refs{/sha}","trees_url":"https://api.github.com/repos/trishume/syntect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trishume/syntect/statuses/{sha}","languages_url":"https://api.github.com/repos/trishume/syntect/languages","stargazers_url":"https://api.github.com/repos/trishume/syntect/stargazers","contributors_url":"https://api.github.com/repos/trishume/syntect/contributors","subscribers_url":"https://api.github.com/repos/trishume/syntect/subscribers","subscription_url":"https://api.github.com/repos/trishume/syntect/subscription","commits_url":"https://api.github.com/repos/trishume/syntect/commits{/sha}","git_commits_url":"https://api.github.com/repos/trishume/syntect/git/commits{/sha}","comments_url":"https://api.github.com/repos/trishume/syntect/comments{/number}","issue_comment_url":"https://api.github.com/repos/trishume/syntect/issues/comments{/number}","contents_url":"https://api.github.com/repos/trishume/syntect/contents/{+path}","compare_url":"https://api.github.com/repos/trishume/syntect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trishume/syntect/merges","archive_url":"https://api.github.com/repos/trishume/syntect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trishume/syntect/downloads","issues_url":"https://api.github.com/repos/trishume/syntect/issues{/number}","pulls_url":"https://api.github.com/repos/trishume/syntect/pulls{/number}","milestones_url":"https://api.github.com/repos/trishume/syntect/milestones{/number}","notifications_url":"https://api.github.com/repos/trishume/syntect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trishume/syntect/labels{/name}","releases_url":"https://api.github.com/repos/trishume/syntect/releases{/id}","deployments_url":"https://api.github.com/repos/trishume/syntect/deployments","created_at":"2016-05-15T00:37:36Z","updated_at":"2018-07-29T20:14:30Z","pushed_at":"2018-07-29T20:14:36Z","git_url":"git://github.com/trishume/syntect.git","ssh_url":"git@github.com:trishume/syntect.git","clone_url":"https://github.com/trishume/syntect.git","svn_url":"https://github.com/trishume/syntect","homepage":"https://docs.rs/syntect","size":11226,"stargazers_count":396,"watchers_count":396,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":39,"open_issues":30,"watchers":396,"default_branch":"master"}},"base":{"label":"trishume:use-arena-for-contexts","ref":"use-arena-for-contexts","sha":"082a078db2126cd8f3872ef8aeba11fe3ea6b21e","user":{"login":"trishume","id":887610,"node_id":"MDQ6VXNlcjg4NzYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/887610?v=4","gravatar_id":"","url":"https://api.github.com/users/trishume","html_url":"https://github.com/trishume","followers_url":"https://api.github.com/users/trishume/followers","following_url":"https://api.github.com/users/trishume/following{/other_user}","gists_url":"https://api.github.com/users/trishume/gists{/gist_id}","starred_url":"https://api.github.com/users/trishume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trishume/subscriptions","organizations_url":"https://api.github.com/users/trishume/orgs","repos_url":"https://api.github.com/users/trishume/repos","events_url":"https://api.github.com/users/trishume/events{/privacy}","received_events_url":"https://api.github.com/users/trishume/received_events","type":"User","site_admin":false},"repo":{"id":58836873,"node_id":"MDEwOlJlcG9zaXRvcnk1ODgzNjg3Mw==","name":"syntect","full_name":"trishume/syntect","owner":{"login":"trishume","id":887610,"node_id":"MDQ6VXNlcjg4NzYxMA==","avatar_url":"https://avatars1.githubusercontent.com/u/887610?v=4","gravatar_id":"","url":"https://api.github.com/users/trishume","html_url":"https://github.com/trishume","followers_url":"https://api.github.com/users/trishume/followers","following_url":"https://api.github.com/users/trishume/following{/other_user}","gists_url":"https://api.github.com/users/trishume/gists{/gist_id}","starred_url":"https://api.github.com/users/trishume/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/trishume/subscriptions","organizations_url":"https://api.github.com/users/trishume/orgs","repos_url":"https://api.github.com/users/trishume/repos","events_url":"https://api.github.com/users/trishume/events{/privacy}","received_events_url":"https://api.github.com/users/trishume/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/trishume/syntect","description":"Rust library for syntax highlighting using Sublime Text syntax definitions.","fork":false,"url":"https://api.github.com/repos/trishume/syntect","forks_url":"https://api.github.com/repos/trishume/syntect/forks","keys_url":"https://api.github.com/repos/trishume/syntect/keys{/key_id}","collaborators_url":"https://api.github.com/repos/trishume/syntect/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/trishume/syntect/teams","hooks_url":"https://api.github.com/repos/trishume/syntect/hooks","issue_events_url":"https://api.github.com/repos/trishume/syntect/issues/events{/number}","events_url":"https://api.github.com/repos/trishume/syntect/events","assignees_url":"https://api.github.com/repos/trishume/syntect/assignees{/user}","branches_url":"https://api.github.com/repos/trishume/syntect/branches{/branch}","tags_url":"https://api.github.com/repos/trishume/syntect/tags","blobs_url":"https://api.github.com/repos/trishume/syntect/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/trishume/syntect/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/trishume/syntect/git/refs{/sha}","trees_url":"https://api.github.com/repos/trishume/syntect/git/trees{/sha}","statuses_url":"https://api.github.com/repos/trishume/syntect/statuses/{sha}","languages_url":"https://api.github.com/repos/trishume/syntect/languages","stargazers_url":"https://api.github.com/repos/trishume/syntect/stargazers","contributors_url":"https://api.github.com/repos/trishume/syntect/contributors","subscribers_url":"https://api.github.com/repos/trishume/syntect/subscribers","subscription_url":"https://api.github.com/repos/trishume/syntect/subscription","commits_url":"https://api.github.com/repos/trishume/syntect/commits{/sha}","git_commits_url":"https://api.github.com/repos/trishume/syntect/git/commits{/sha}","comments_url":"https://api.github.com/repos/trishume/syntect/comments{/number}","issue_comment_url":"https://api.github.com/repos/trishume/syntect/issues/comments{/number}","contents_url":"https://api.github.com/repos/trishume/syntect/contents/{+path}","compare_url":"https://api.github.com/repos/trishume/syntect/compare/{base}...{head}","merges_url":"https://api.github.com/repos/trishume/syntect/merges","archive_url":"https://api.github.com/repos/trishume/syntect/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/trishume/syntect/downloads","issues_url":"https://api.github.com/repos/trishume/syntect/issues{/number}","pulls_url":"https://api.github.com/repos/trishume/syntect/pulls{/number}","milestones_url":"https://api.github.com/repos/trishume/syntect/milestones{/number}","notifications_url":"https://api.github.com/repos/trishume/syntect/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/trishume/syntect/labels{/name}","releases_url":"https://api.github.com/repos/trishume/syntect/releases{/id}","deployments_url":"https://api.github.com/repos/trishume/syntect/deployments","created_at":"2016-05-15T00:37:36Z","updated_at":"2018-07-29T20:14:30Z","pushed_at":"2018-07-29T20:14:36Z","git_url":"git://github.com/trishume/syntect.git","ssh_url":"git@github.com:trishume/syntect.git","clone_url":"https://github.com/trishume/syntect.git","svn_url":"https://github.com/trishume/syntect","homepage":"https://docs.rs/syntect","size":11226,"stargazers_count":396,"watchers_count":396,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":39,"mirror_url":null,"archived":false,"open_issues_count":30,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":39,"open_issues":30,"watchers":396,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/trishume/syntect/pulls/190"},"html":{"href":"https://github.com/trishume/syntect/pull/190"},"issue":{"href":"https://api.github.com/repos/trishume/syntect/issues/190"},"comments":{"href":"https://api.github.com/repos/trishume/syntect/issues/190/comments"},"review_comments":{"href":"https://api.github.com/repos/trishume/syntect/pulls/190/comments"},"review_comment":{"href":"https://api.github.com/repos/trishume/syntect/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/trishume/syntect/pulls/190/commits"},"statuses":{"href":"https://api.github.com/repos/trishume/syntect/statuses/913aaf58a2dd288fb190fb91d585d79b55a78de3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"robinst"}}