{"action":"closed","number":1217,"pull_request":{"url":"https://api.github.com/repos/pingcap/pd/pulls/1217","id":211187694,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMTg3Njk0","html_url":"https://github.com/pingcap/pd/pull/1217","diff_url":"https://github.com/pingcap/pd/pull/1217.diff","patch_url":"https://github.com/pingcap/pd/pull/1217.patch","issue_url":"https://api.github.com/repos/pingcap/pd/issues/1217","number":1217,"state":"closed","locked":false,"title":"revive linter: exit 1 on failure","user":{"login":"gregwebs","id":1183,"node_id":"MDQ6VXNlcjExODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1183?v=4","gravatar_id":"","url":"https://api.github.com/users/gregwebs","html_url":"https://github.com/gregwebs","followers_url":"https://api.github.com/users/gregwebs/followers","following_url":"https://api.github.com/users/gregwebs/following{/other_user}","gists_url":"https://api.github.com/users/gregwebs/gists{/gist_id}","starred_url":"https://api.github.com/users/gregwebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregwebs/subscriptions","organizations_url":"https://api.github.com/users/gregwebs/orgs","repos_url":"https://api.github.com/users/gregwebs/repos","events_url":"https://api.github.com/users/gregwebs/events{/privacy}","received_events_url":"https://api.github.com/users/gregwebs/received_events","type":"User","site_admin":false},"body":"## What have you changed? (required)\r\n\r\nrevive linter: exit 1 on failure.\r\nI didn't realize it was defaulting to exit with code 0.\r\nWarning still exits with code 0.","created_at":"2018-08-27T18:16:51Z","updated_at":"2018-08-28T05:31:14Z","closed_at":"2018-08-28T05:31:14Z","merged_at":"2018-08-28T05:31:14Z","merge_commit_sha":"f49dfeb9223ce2f3e20c38db24be5fdbc62d5db0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/pd/pulls/1217/commits","review_comments_url":"https://api.github.com/repos/pingcap/pd/pulls/1217/comments","review_comment_url":"https://api.github.com/repos/pingcap/pd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/pd/issues/1217/comments","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/01f80efc4748bf2a42ddf6c783f8ef31c9854bb5","head":{"label":"gregwebs:revive-error-exit","ref":"revive-error-exit","sha":"01f80efc4748bf2a42ddf6c783f8ef31c9854bb5","user":{"login":"gregwebs","id":1183,"node_id":"MDQ6VXNlcjExODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1183?v=4","gravatar_id":"","url":"https://api.github.com/users/gregwebs","html_url":"https://github.com/gregwebs","followers_url":"https://api.github.com/users/gregwebs/followers","following_url":"https://api.github.com/users/gregwebs/following{/other_user}","gists_url":"https://api.github.com/users/gregwebs/gists{/gist_id}","starred_url":"https://api.github.com/users/gregwebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregwebs/subscriptions","organizations_url":"https://api.github.com/users/gregwebs/orgs","repos_url":"https://api.github.com/users/gregwebs/repos","events_url":"https://api.github.com/users/gregwebs/events{/privacy}","received_events_url":"https://api.github.com/users/gregwebs/received_events","type":"User","site_admin":false},"repo":{"id":145763326,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU3NjMzMjY=","name":"pd","full_name":"gregwebs/pd","owner":{"login":"gregwebs","id":1183,"node_id":"MDQ6VXNlcjExODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1183?v=4","gravatar_id":"","url":"https://api.github.com/users/gregwebs","html_url":"https://github.com/gregwebs","followers_url":"https://api.github.com/users/gregwebs/followers","following_url":"https://api.github.com/users/gregwebs/following{/other_user}","gists_url":"https://api.github.com/users/gregwebs/gists{/gist_id}","starred_url":"https://api.github.com/users/gregwebs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gregwebs/subscriptions","organizations_url":"https://api.github.com/users/gregwebs/orgs","repos_url":"https://api.github.com/users/gregwebs/repos","events_url":"https://api.github.com/users/gregwebs/events{/privacy}","received_events_url":"https://api.github.com/users/gregwebs/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gregwebs/pd","description":"Placement driver for TiKV","fork":true,"url":"https://api.github.com/repos/gregwebs/pd","forks_url":"https://api.github.com/repos/gregwebs/pd/forks","keys_url":"https://api.github.com/repos/gregwebs/pd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gregwebs/pd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gregwebs/pd/teams","hooks_url":"https://api.github.com/repos/gregwebs/pd/hooks","issue_events_url":"https://api.github.com/repos/gregwebs/pd/issues/events{/number}","events_url":"https://api.github.com/repos/gregwebs/pd/events","assignees_url":"https://api.github.com/repos/gregwebs/pd/assignees{/user}","branches_url":"https://api.github.com/repos/gregwebs/pd/branches{/branch}","tags_url":"https://api.github.com/repos/gregwebs/pd/tags","blobs_url":"https://api.github.com/repos/gregwebs/pd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gregwebs/pd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gregwebs/pd/git/refs{/sha}","trees_url":"https://api.github.com/repos/gregwebs/pd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gregwebs/pd/statuses/{sha}","languages_url":"https://api.github.com/repos/gregwebs/pd/languages","stargazers_url":"https://api.github.com/repos/gregwebs/pd/stargazers","contributors_url":"https://api.github.com/repos/gregwebs/pd/contributors","subscribers_url":"https://api.github.com/repos/gregwebs/pd/subscribers","subscription_url":"https://api.github.com/repos/gregwebs/pd/subscription","commits_url":"https://api.github.com/repos/gregwebs/pd/commits{/sha}","git_commits_url":"https://api.github.com/repos/gregwebs/pd/git/commits{/sha}","comments_url":"https://api.github.com/repos/gregwebs/pd/comments{/number}","issue_comment_url":"https://api.github.com/repos/gregwebs/pd/issues/comments{/number}","contents_url":"https://api.github.com/repos/gregwebs/pd/contents/{+path}","compare_url":"https://api.github.com/repos/gregwebs/pd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gregwebs/pd/merges","archive_url":"https://api.github.com/repos/gregwebs/pd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gregwebs/pd/downloads","issues_url":"https://api.github.com/repos/gregwebs/pd/issues{/number}","pulls_url":"https://api.github.com/repos/gregwebs/pd/pulls{/number}","milestones_url":"https://api.github.com/repos/gregwebs/pd/milestones{/number}","notifications_url":"https://api.github.com/repos/gregwebs/pd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gregwebs/pd/labels{/name}","releases_url":"https://api.github.com/repos/gregwebs/pd/releases{/id}","deployments_url":"https://api.github.com/repos/gregwebs/pd/deployments","created_at":"2018-08-22T21:12:07Z","updated_at":"2018-08-24T21:48:35Z","pushed_at":"2018-08-27T21:41:46Z","git_url":"git://github.com/gregwebs/pd.git","ssh_url":"git@github.com:gregwebs/pd.git","clone_url":"https://github.com/gregwebs/pd.git","svn_url":"https://github.com/gregwebs/pd","homepage":"","size":11964,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"47a950e6649fa0151a6c5d0fc48a97c080012e3d","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":53311716,"node_id":"MDEwOlJlcG9zaXRvcnk1MzMxMTcxNg==","name":"pd","full_name":"pingcap/pd","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/pd","description":"Placement driver for TiKV","fork":false,"url":"https://api.github.com/repos/pingcap/pd","forks_url":"https://api.github.com/repos/pingcap/pd/forks","keys_url":"https://api.github.com/repos/pingcap/pd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/pd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/pd/teams","hooks_url":"https://api.github.com/repos/pingcap/pd/hooks","issue_events_url":"https://api.github.com/repos/pingcap/pd/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/pd/events","assignees_url":"https://api.github.com/repos/pingcap/pd/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/pd/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/pd/tags","blobs_url":"https://api.github.com/repos/pingcap/pd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/pd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/pd/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/pd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/pd/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/pd/languages","stargazers_url":"https://api.github.com/repos/pingcap/pd/stargazers","contributors_url":"https://api.github.com/repos/pingcap/pd/contributors","subscribers_url":"https://api.github.com/repos/pingcap/pd/subscribers","subscription_url":"https://api.github.com/repos/pingcap/pd/subscription","commits_url":"https://api.github.com/repos/pingcap/pd/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/pd/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/pd/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/pd/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/pd/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/pd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/pd/merges","archive_url":"https://api.github.com/repos/pingcap/pd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/pd/downloads","issues_url":"https://api.github.com/repos/pingcap/pd/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/pd/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/pd/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/pd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/pd/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/pd/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/pd/deployments","created_at":"2016-03-07T09:13:06Z","updated_at":"2018-08-27T08:59:19Z","pushed_at":"2018-08-28T05:31:14Z","git_url":"git://github.com/pingcap/pd.git","ssh_url":"git@github.com:pingcap/pd.git","clone_url":"https://github.com/pingcap/pd.git","svn_url":"https://github.com/pingcap/pd","homepage":"","size":12094,"stargazers_count":238,"watchers_count":238,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":151,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":151,"open_issues":43,"watchers":238,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1217"},"html":{"href":"https://github.com/pingcap/pd/pull/1217"},"issue":{"href":"https://api.github.com/repos/pingcap/pd/issues/1217"},"comments":{"href":"https://api.github.com/repos/pingcap/pd/issues/1217/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1217/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/pd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/pd/pulls/1217/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/pd/statuses/01f80efc4748bf2a42ddf6c783f8ef31c9854bb5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"disksing","id":12077877,"node_id":"MDQ6VXNlcjEyMDc3ODc3","avatar_url":"https://avatars1.githubusercontent.com/u/12077877?v=4","gravatar_id":"","url":"https://api.github.com/users/disksing","html_url":"https://github.com/disksing","followers_url":"https://api.github.com/users/disksing/followers","following_url":"https://api.github.com/users/disksing/following{/other_user}","gists_url":"https://api.github.com/users/disksing/gists{/gist_id}","starred_url":"https://api.github.com/users/disksing/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/disksing/subscriptions","organizations_url":"https://api.github.com/users/disksing/orgs","repos_url":"https://api.github.com/users/disksing/repos","events_url":"https://api.github.com/users/disksing/events{/privacy}","received_events_url":"https://api.github.com/users/disksing/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":1,"deletions":1,"changed_files":1}}
{"actor":{"display_login":"disksing"}}