{"push_id":2320585832,"size":1,"distinct_size":1,"ref":"refs/heads/36255-fix_log_path","head":"4a36a903e42de85cd58a3e085da997077cafbd34","before":"518e9216d48010e0be75bc8f9307ba782cc0d0df","commits":[{"sha":"4a36a903e42de85cd58a3e085da997077cafbd34","author":{"name":"junzhe and mnussbaum","email":"ab3bf20a456957ab3c21b104b37d8a70f0061e3c@getbraintree.com"},"message":"Fix empty LogPath with non-blocking logging mode\n\nThis fixes an issue where the container LogPath was empty when the\nnon-blocking logging mode was enabled. This change sets the LogPath on\nthe container as soon as the path is generated, instead of setting the\nLogPath on a logger struct and then attempting to pull it off that\nlogger at a later point. That attempt to pull the LogPath off the logger\nwas error prone since it assumed that the logger would only ever be a\nsingle type.\n\nPrior to this change docker inspect returned an empty string for\nLogPath. This caused issues with tools that rely on docker inspect\noutput to discover container logs, e.g. Kubernetes.\n\nThis commit also removes some LogPath methods that are now unnecessary\nand are never invoked.\n\nSigned-off-by: junzhe and mnussbaum <code@getbraintree.com>","distinct":true,"url":"https://api.github.com/repos/mnussbaum/moby/commits/4a36a903e42de85cd58a3e085da997077cafbd34"}]}
{"actor":{"display_login":"mnussbaum"}}