{"action":"created","comment":{"url":"https://api.github.com/repos/ethereumjs/rlp/pulls/comments/232939909","pull_request_review_id":174243808,"id":232939909,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjkzOTkwOQ==","diff_hunk":"@@ -0,0 +1,13 @@\n+{\n+  \"extends\": \"typestrict\",\n+  \"rules\": {\n+    \"no-console\": true,\n+    \"no-debugger\": true,\n+    \"mocha-avoid-only\": true,\n+    \"prefer-const\": true,\n+    \"no-var-keyword\": true,\n+    \"interface-name\": [true, \"never-prefix\"],\n+    \"no-commented-code\": true,","path":"tslint.json","position":10,"original_position":10,"commit_id":"d7dbd4b3db64823abaa25fed087c8db5551c93f8","original_commit_id":"d7dbd4b3db64823abaa25fed087c8db5551c93f8","user":{"login":"holgerd77","id":931137,"node_id":"MDQ6VXNlcjkzMTEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/931137?v=4","gravatar_id":"","url":"https://api.github.com/users/holgerd77","html_url":"https://github.com/holgerd77","followers_url":"https://api.github.com/users/holgerd77/followers","following_url":"https://api.github.com/users/holgerd77/following{/other_user}","gists_url":"https://api.github.com/users/holgerd77/gists{/gist_id}","starred_url":"https://api.github.com/users/holgerd77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holgerd77/subscriptions","organizations_url":"https://api.github.com/users/holgerd77/orgs","repos_url":"https://api.github.com/users/holgerd77/repos","events_url":"https://api.github.com/users/holgerd77/events{/privacy}","received_events_url":"https://api.github.com/users/holgerd77/received_events","type":"User","site_admin":false},"body":"Ah no, don't let's bloat up the dev dependencies on this, but we should find ways to make the fact transparent that rules are also coming from there.\r\n\r\nActually I will start on an organizational ReadTheDocs documentation on the ``organization`` repo in the coming days, including things like contribution guidelines and also some tech standards.\r\n\r\nI will also include a TypeScript section there and try to extract from here the common set of practices and tools we agreed upon. This guide can the referenced from the various repos.","created_at":"2018-11-13T08:43:24Z","updated_at":"2018-11-13T08:43:24Z","html_url":"https://github.com/ethereumjs/rlp/pull/41#discussion_r232939909","pull_request_url":"https://api.github.com/repos/ethereumjs/rlp/pulls/41","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/ethereumjs/rlp/pulls/comments/232939909"},"html":{"href":"https://github.com/ethereumjs/rlp/pull/41#discussion_r232939909"},"pull_request":{"href":"https://api.github.com/repos/ethereumjs/rlp/pulls/41"}},"in_reply_to_id":232635266},"pull_request":{"url":"https://api.github.com/repos/ethereumjs/rlp/pulls/41","id":229912756,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTEyNzU2","html_url":"https://github.com/ethereumjs/rlp/pull/41","diff_url":"https://github.com/ethereumjs/rlp/pull/41.diff","patch_url":"https://github.com/ethereumjs/rlp/pull/41.patch","issue_url":"https://api.github.com/repos/ethereumjs/rlp/issues/41","number":41,"state":"open","locked":false,"title":"Kk/linting+prettier","user":{"login":"krzkaczor","id":1814312,"node_id":"MDQ6VXNlcjE4MTQzMTI=","avatar_url":"https://avatars2.githubusercontent.com/u/1814312?v=4","gravatar_id":"","url":"https://api.github.com/users/krzkaczor","html_url":"https://github.com/krzkaczor","followers_url":"https://api.github.com/users/krzkaczor/followers","following_url":"https://api.github.com/users/krzkaczor/following{/other_user}","gists_url":"https://api.github.com/users/krzkaczor/gists{/gist_id}","starred_url":"https://api.github.com/users/krzkaczor/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krzkaczor/subscriptions","organizations_url":"https://api.github.com/users/krzkaczor/orgs","repos_url":"https://api.github.com/users/krzkaczor/repos","events_url":"https://api.github.com/users/krzkaczor/events{/privacy}","received_events_url":"https://api.github.com/users/krzkaczor/received_events","type":"User","site_admin":false},"body":"What's inside:\r\n- autoformatting with prettier (in few places in tests we used fixtures and I used `// prettier-ignore` to ignore these pieces b/c they are looking better in single lines)\r\n- tslint ruleset\r\n- `npm run test` runs linting + tests\r\n- `npm run test:fix` runs linting in autofix mode \r\n- use `test:fix` during development and `test` on CI\r\n\r\nNotes:\r\n- Prettier uses similar settings as `standardjs` (personally i dont care about semicolons and quotes)\r\n- Prettier was used to format MD files into consistent format as well\r\n- Tslint disallows `var`. `const` is prefered but you can use `let` when reassignment is needed\r\n- We can enfore even more rules with tslint - please add you comments","created_at":"2018-11-10T20:53:10Z","updated_at":"2018-11-13T08:43:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"45759910b0b04ac0aa1b9780d3ff8b9ced6fb4d4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"GrandSchtroumpf","id":8143464,"node_id":"MDQ6VXNlcjgxNDM0NjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/8143464?v=4","gravatar_id":"","url":"https://api.github.com/users/GrandSchtroumpf","html_url":"https://github.com/GrandSchtroumpf","followers_url":"https://api.github.com/users/GrandSchtroumpf/followers","following_url":"https://api.github.com/users/GrandSchtroumpf/following{/other_user}","gists_url":"https://api.github.com/users/GrandSchtroumpf/gists{/gist_id}","starred_url":"https://api.github.com/users/GrandSchtroumpf/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GrandSchtroumpf/subscriptions","organizations_url":"https://api.github.com/users/GrandSchtroumpf/orgs","repos_url":"https://api.github.com/users/GrandSchtroumpf/repos","events_url":"https://api.github.com/users/GrandSchtroumpf/events{/privacy}","received_events_url":"https://api.github.com/users/GrandSchtroumpf/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ethereumjs/rlp/pulls/41/commits","review_comments_url":"https://api.github.com/repos/ethereumjs/rlp/pulls/41/comments","review_comment_url":"https://api.github.com/repos/ethereumjs/rlp/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ethereumjs/rlp/issues/41/comments","statuses_url":"https://api.github.com/repos/ethereumjs/rlp/statuses/d7dbd4b3db64823abaa25fed087c8db5551c93f8","head":{"label":"ethereumjs:kk/linting+prettier","ref":"kk/linting+prettier","sha":"d7dbd4b3db64823abaa25fed087c8db5551c93f8","user":{"login":"ethereumjs","id":16297473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"repo":{"id":17426499,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQyNjQ5OQ==","name":"rlp","full_name":"ethereumjs/rlp","private":false,"owner":{"login":"ethereumjs","id":16297473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereumjs/rlp","description":"Recursive Length Prefix Encoding in JavaScript","fork":false,"url":"https://api.github.com/repos/ethereumjs/rlp","forks_url":"https://api.github.com/repos/ethereumjs/rlp/forks","keys_url":"https://api.github.com/repos/ethereumjs/rlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereumjs/rlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereumjs/rlp/teams","hooks_url":"https://api.github.com/repos/ethereumjs/rlp/hooks","issue_events_url":"https://api.github.com/repos/ethereumjs/rlp/issues/events{/number}","events_url":"https://api.github.com/repos/ethereumjs/rlp/events","assignees_url":"https://api.github.com/repos/ethereumjs/rlp/assignees{/user}","branches_url":"https://api.github.com/repos/ethereumjs/rlp/branches{/branch}","tags_url":"https://api.github.com/repos/ethereumjs/rlp/tags","blobs_url":"https://api.github.com/repos/ethereumjs/rlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereumjs/rlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereumjs/rlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereumjs/rlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereumjs/rlp/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereumjs/rlp/languages","stargazers_url":"https://api.github.com/repos/ethereumjs/rlp/stargazers","contributors_url":"https://api.github.com/repos/ethereumjs/rlp/contributors","subscribers_url":"https://api.github.com/repos/ethereumjs/rlp/subscribers","subscription_url":"https://api.github.com/repos/ethereumjs/rlp/subscription","commits_url":"https://api.github.com/repos/ethereumjs/rlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereumjs/rlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereumjs/rlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereumjs/rlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereumjs/rlp/contents/{+path}","compare_url":"https://api.github.com/repos/ethereumjs/rlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereumjs/rlp/merges","archive_url":"https://api.github.com/repos/ethereumjs/rlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereumjs/rlp/downloads","issues_url":"https://api.github.com/repos/ethereumjs/rlp/issues{/number}","pulls_url":"https://api.github.com/repos/ethereumjs/rlp/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereumjs/rlp/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereumjs/rlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereumjs/rlp/labels{/name}","releases_url":"https://api.github.com/repos/ethereumjs/rlp/releases{/id}","deployments_url":"https://api.github.com/repos/ethereumjs/rlp/deployments","created_at":"2014-03-05T03:20:38Z","updated_at":"2018-11-10T15:32:47Z","pushed_at":"2018-11-13T08:32:13Z","git_url":"git://github.com/ethereumjs/rlp.git","ssh_url":"git@github.com:ethereumjs/rlp.git","clone_url":"https://github.com/ethereumjs/rlp.git","svn_url":"https://github.com/ethereumjs/rlp","homepage":"","size":105,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":24,"open_issues":12,"watchers":56,"default_branch":"master"}},"base":{"label":"ethereumjs:typescript","ref":"typescript","sha":"d1272cc145391af6f1001b2092f8d339bf41bede","user":{"login":"ethereumjs","id":16297473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"repo":{"id":17426499,"node_id":"MDEwOlJlcG9zaXRvcnkxNzQyNjQ5OQ==","name":"rlp","full_name":"ethereumjs/rlp","private":false,"owner":{"login":"ethereumjs","id":16297473,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2Mjk3NDcz","avatar_url":"https://avatars0.githubusercontent.com/u/16297473?v=4","gravatar_id":"","url":"https://api.github.com/users/ethereumjs","html_url":"https://github.com/ethereumjs","followers_url":"https://api.github.com/users/ethereumjs/followers","following_url":"https://api.github.com/users/ethereumjs/following{/other_user}","gists_url":"https://api.github.com/users/ethereumjs/gists{/gist_id}","starred_url":"https://api.github.com/users/ethereumjs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ethereumjs/subscriptions","organizations_url":"https://api.github.com/users/ethereumjs/orgs","repos_url":"https://api.github.com/users/ethereumjs/repos","events_url":"https://api.github.com/users/ethereumjs/events{/privacy}","received_events_url":"https://api.github.com/users/ethereumjs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ethereumjs/rlp","description":"Recursive Length Prefix Encoding in JavaScript","fork":false,"url":"https://api.github.com/repos/ethereumjs/rlp","forks_url":"https://api.github.com/repos/ethereumjs/rlp/forks","keys_url":"https://api.github.com/repos/ethereumjs/rlp/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ethereumjs/rlp/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ethereumjs/rlp/teams","hooks_url":"https://api.github.com/repos/ethereumjs/rlp/hooks","issue_events_url":"https://api.github.com/repos/ethereumjs/rlp/issues/events{/number}","events_url":"https://api.github.com/repos/ethereumjs/rlp/events","assignees_url":"https://api.github.com/repos/ethereumjs/rlp/assignees{/user}","branches_url":"https://api.github.com/repos/ethereumjs/rlp/branches{/branch}","tags_url":"https://api.github.com/repos/ethereumjs/rlp/tags","blobs_url":"https://api.github.com/repos/ethereumjs/rlp/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ethereumjs/rlp/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ethereumjs/rlp/git/refs{/sha}","trees_url":"https://api.github.com/repos/ethereumjs/rlp/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ethereumjs/rlp/statuses/{sha}","languages_url":"https://api.github.com/repos/ethereumjs/rlp/languages","stargazers_url":"https://api.github.com/repos/ethereumjs/rlp/stargazers","contributors_url":"https://api.github.com/repos/ethereumjs/rlp/contributors","subscribers_url":"https://api.github.com/repos/ethereumjs/rlp/subscribers","subscription_url":"https://api.github.com/repos/ethereumjs/rlp/subscription","commits_url":"https://api.github.com/repos/ethereumjs/rlp/commits{/sha}","git_commits_url":"https://api.github.com/repos/ethereumjs/rlp/git/commits{/sha}","comments_url":"https://api.github.com/repos/ethereumjs/rlp/comments{/number}","issue_comment_url":"https://api.github.com/repos/ethereumjs/rlp/issues/comments{/number}","contents_url":"https://api.github.com/repos/ethereumjs/rlp/contents/{+path}","compare_url":"https://api.github.com/repos/ethereumjs/rlp/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ethereumjs/rlp/merges","archive_url":"https://api.github.com/repos/ethereumjs/rlp/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ethereumjs/rlp/downloads","issues_url":"https://api.github.com/repos/ethereumjs/rlp/issues{/number}","pulls_url":"https://api.github.com/repos/ethereumjs/rlp/pulls{/number}","milestones_url":"https://api.github.com/repos/ethereumjs/rlp/milestones{/number}","notifications_url":"https://api.github.com/repos/ethereumjs/rlp/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ethereumjs/rlp/labels{/name}","releases_url":"https://api.github.com/repos/ethereumjs/rlp/releases{/id}","deployments_url":"https://api.github.com/repos/ethereumjs/rlp/deployments","created_at":"2014-03-05T03:20:38Z","updated_at":"2018-11-10T15:32:47Z","pushed_at":"2018-11-13T08:32:13Z","git_url":"git://github.com/ethereumjs/rlp.git","ssh_url":"git@github.com:ethereumjs/rlp.git","clone_url":"https://github.com/ethereumjs/rlp.git","svn_url":"https://github.com/ethereumjs/rlp","homepage":"","size":105,"stargazers_count":56,"watchers_count":56,"language":"JavaScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":24,"mirror_url":null,"archived":false,"open_issues_count":12,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0","node_id":"MDc6TGljZW5zZTE0"},"forks":24,"open_issues":12,"watchers":56,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ethereumjs/rlp/pulls/41"},"html":{"href":"https://github.com/ethereumjs/rlp/pull/41"},"issue":{"href":"https://api.github.com/repos/ethereumjs/rlp/issues/41"},"comments":{"href":"https://api.github.com/repos/ethereumjs/rlp/issues/41/comments"},"review_comments":{"href":"https://api.github.com/repos/ethereumjs/rlp/pulls/41/comments"},"review_comment":{"href":"https://api.github.com/repos/ethereumjs/rlp/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ethereumjs/rlp/pulls/41/commits"},"statuses":{"href":"https://api.github.com/repos/ethereumjs/rlp/statuses/d7dbd4b3db64823abaa25fed087c8db5551c93f8"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"holgerd77"}}