{"action":"created","comment":{"url":"https://api.github.com/repos/Autodesk/hig/pulls/comments/208752389","pull_request_review_id":144628066,"id":208752389,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODc1MjM4OQ==","diff_hunk":"@@ -1,6 +1,72 @@\n-import { Modal } from \"hig-react\";\n-import \"./modal.scss\";\n+import React, { Component } from \"react\";\n+import PropTypes from \"prop-types\";\n \n-Modal.displayName = \"Modal\";\n+import ModalPresenter from \"./presenters/ModalPresenter\";\n+import ModalBehavior from \"./behaviors/ModalBehavior\";\n \n-export default Modal;\n+export default class Modal extends Component {\n+  static propTypes = {\n+    /**\n+     * Supports adding any dom content to the body of the modal\n+     */\n+    children: PropTypes.node,\n+    /**\n+     * Supports adding any dom content to the header of the modal\n+     */\n+    headerChildren: PropTypes.node,\n+    /**\n+     * Triggers when you click the close button\n+     */\n+    onCloseClick: PropTypes.func,","path":"packages/modal/src/Modal.js","position":24,"original_position":24,"commit_id":"14ec76648883a35128dcf19df2654a29ac750149","original_commit_id":"0d732814da16c0b34cbba518c9ea0c3c95c93840","user":{"login":"morrisallison","id":3189455,"node_id":"MDQ6VXNlcjMxODk0NTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3189455?v=4","gravatar_id":"","url":"https://api.github.com/users/morrisallison","html_url":"https://github.com/morrisallison","followers_url":"https://api.github.com/users/morrisallison/followers","following_url":"https://api.github.com/users/morrisallison/following{/other_user}","gists_url":"https://api.github.com/users/morrisallison/gists{/gist_id}","starred_url":"https://api.github.com/users/morrisallison/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/morrisallison/subscriptions","organizations_url":"https://api.github.com/users/morrisallison/orgs","repos_url":"https://api.github.com/users/morrisallison/repos","events_url":"https://api.github.com/users/morrisallison/events{/privacy}","received_events_url":"https://api.github.com/users/morrisallison/received_events","type":"User","site_admin":false},"body":"If this component had uncontrolled functionality, more handlers like `onClose` would be nice. In this case, these are fine for now.","created_at":"2018-08-08T22:10:25Z","updated_at":"2018-08-08T22:47:59Z","html_url":"https://github.com/Autodesk/hig/pull/1092#discussion_r208752389","pull_request_url":"https://api.github.com/repos/Autodesk/hig/pulls/1092","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Autodesk/hig/pulls/comments/208752389"},"html":{"href":"https://github.com/Autodesk/hig/pull/1092#discussion_r208752389"},"pull_request":{"href":"https://api.github.com/repos/Autodesk/hig/pulls/1092"}},"in_reply_to_id":208396002},"pull_request":{"url":"https://api.github.com/repos/Autodesk/hig/pulls/1092","id":206784163,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2Nzg0MTYz","html_url":"https://github.com/Autodesk/hig/pull/1092","diff_url":"https://github.com/Autodesk/hig/pull/1092.diff","patch_url":"https://github.com/Autodesk/hig/pull/1092.patch","issue_url":"https://api.github.com/repos/Autodesk/hig/issues/1092","number":1092,"state":"open","locked":false,"title":"React Modal","user":{"login":"arirusso","id":140873,"node_id":"MDQ6VXNlcjE0MDg3Mw==","avatar_url":"https://avatars2.githubusercontent.com/u/140873?v=4","gravatar_id":"","url":"https://api.github.com/users/arirusso","html_url":"https://github.com/arirusso","followers_url":"https://api.github.com/users/arirusso/followers","following_url":"https://api.github.com/users/arirusso/following{/other_user}","gists_url":"https://api.github.com/users/arirusso/gists{/gist_id}","starred_url":"https://api.github.com/users/arirusso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/arirusso/subscriptions","organizations_url":"https://api.github.com/users/arirusso/orgs","repos_url":"https://api.github.com/users/arirusso/repos","events_url":"https://api.github.com/users/arirusso/events{/privacy}","received_events_url":"https://api.github.com/users/arirusso/received_events","type":"User","site_admin":false},"body":"Issue: https://github.com/Autodesk/hig/issues/965\r\n\r\nRevamps React modal package, removing dependency on Vanilla JS.\r\n\r\nAdditionally adds Gemini snapshots, Enzyme snapshots, unit/integration tests and revises Storybook stories\r\n\r\nhttp://spectacular-tiger.surge.sh","created_at":"2018-08-07T18:15:53Z","updated_at":"2018-08-08T22:48:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3c50dee5a18881cf140dd8868ac9d9fb3214e89c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"halfghaninne","id":9288982,"node_id":"MDQ6VXNlcjkyODg5ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/9288982?v=4","gravatar_id":"","url":"https://api.github.com/users/halfghaninne","html_url":"https://github.com/halfghaninne","followers_url":"https://api.github.com/users/halfghaninne/followers","following_url":"https://api.github.com/users/halfghaninne/following{/other_user}","gists_url":"https://api.github.com/users/halfghaninne/gists{/gist_id}","starred_url":"https://api.github.com/users/halfghaninne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halfghaninne/subscriptions","organizations_url":"https://api.github.com/users/halfghaninne/orgs","repos_url":"https://api.github.com/users/halfghaninne/repos","events_url":"https://api.github.com/users/halfghaninne/events{/privacy}","received_events_url":"https://api.github.com/users/halfghaninne/received_events","type":"User","site_admin":false},{"login":"wmui51","id":11857921,"node_id":"MDQ6VXNlcjExODU3OTIx","avatar_url":"https://avatars1.githubusercontent.com/u/11857921?v=4","gravatar_id":"","url":"https://api.github.com/users/wmui51","html_url":"https://github.com/wmui51","followers_url":"https://api.github.com/users/wmui51/followers","following_url":"https://api.github.com/users/wmui51/following{/other_user}","gists_url":"https://api.github.com/users/wmui51/gists{/gist_id}","starred_url":"https://api.github.com/users/wmui51/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wmui51/subscriptions","organizations_url":"https://api.github.com/users/wmui51/orgs","repos_url":"https://api.github.com/users/wmui51/repos","events_url":"https://api.github.com/users/wmui51/events{/privacy}","received_events_url":"https://api.github.com/users/wmui51/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Autodesk/hig/pulls/1092/commits","review_comments_url":"https://api.github.com/repos/Autodesk/hig/pulls/1092/comments","review_comment_url":"https://api.github.com/repos/Autodesk/hig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Autodesk/hig/issues/1092/comments","statuses_url":"https://api.github.com/repos/Autodesk/hig/statuses/14ec76648883a35128dcf19df2654a29ac750149","head":{"label":"Autodesk:chore/modal-965","ref":"chore/modal-965","sha":"14ec76648883a35128dcf19df2654a29ac750149","user":{"login":"Autodesk","id":7914533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7914533?v=4","gravatar_id":"","url":"https://api.github.com/users/Autodesk","html_url":"https://github.com/Autodesk","followers_url":"https://api.github.com/users/Autodesk/followers","following_url":"https://api.github.com/users/Autodesk/following{/other_user}","gists_url":"https://api.github.com/users/Autodesk/gists{/gist_id}","starred_url":"https://api.github.com/users/Autodesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Autodesk/subscriptions","organizations_url":"https://api.github.com/users/Autodesk/orgs","repos_url":"https://api.github.com/users/Autodesk/repos","events_url":"https://api.github.com/users/Autodesk/events{/privacy}","received_events_url":"https://api.github.com/users/Autodesk/received_events","type":"Organization","site_admin":false},"repo":{"id":87124532,"node_id":"MDEwOlJlcG9zaXRvcnk4NzEyNDUzMg==","name":"hig","full_name":"Autodesk/hig","owner":{"login":"Autodesk","id":7914533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7914533?v=4","gravatar_id":"","url":"https://api.github.com/users/Autodesk","html_url":"https://github.com/Autodesk","followers_url":"https://api.github.com/users/Autodesk/followers","following_url":"https://api.github.com/users/Autodesk/following{/other_user}","gists_url":"https://api.github.com/users/Autodesk/gists{/gist_id}","starred_url":"https://api.github.com/users/Autodesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Autodesk/subscriptions","organizations_url":"https://api.github.com/users/Autodesk/orgs","repos_url":"https://api.github.com/users/Autodesk/repos","events_url":"https://api.github.com/users/Autodesk/events{/privacy}","received_events_url":"https://api.github.com/users/Autodesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Autodesk/hig","description":"Autodesk's unified design design system","fork":false,"url":"https://api.github.com/repos/Autodesk/hig","forks_url":"https://api.github.com/repos/Autodesk/hig/forks","keys_url":"https://api.github.com/repos/Autodesk/hig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Autodesk/hig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Autodesk/hig/teams","hooks_url":"https://api.github.com/repos/Autodesk/hig/hooks","issue_events_url":"https://api.github.com/repos/Autodesk/hig/issues/events{/number}","events_url":"https://api.github.com/repos/Autodesk/hig/events","assignees_url":"https://api.github.com/repos/Autodesk/hig/assignees{/user}","branches_url":"https://api.github.com/repos/Autodesk/hig/branches{/branch}","tags_url":"https://api.github.com/repos/Autodesk/hig/tags","blobs_url":"https://api.github.com/repos/Autodesk/hig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Autodesk/hig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Autodesk/hig/git/refs{/sha}","trees_url":"https://api.github.com/repos/Autodesk/hig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Autodesk/hig/statuses/{sha}","languages_url":"https://api.github.com/repos/Autodesk/hig/languages","stargazers_url":"https://api.github.com/repos/Autodesk/hig/stargazers","contributors_url":"https://api.github.com/repos/Autodesk/hig/contributors","subscribers_url":"https://api.github.com/repos/Autodesk/hig/subscribers","subscription_url":"https://api.github.com/repos/Autodesk/hig/subscription","commits_url":"https://api.github.com/repos/Autodesk/hig/commits{/sha}","git_commits_url":"https://api.github.com/repos/Autodesk/hig/git/commits{/sha}","comments_url":"https://api.github.com/repos/Autodesk/hig/comments{/number}","issue_comment_url":"https://api.github.com/repos/Autodesk/hig/issues/comments{/number}","contents_url":"https://api.github.com/repos/Autodesk/hig/contents/{+path}","compare_url":"https://api.github.com/repos/Autodesk/hig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Autodesk/hig/merges","archive_url":"https://api.github.com/repos/Autodesk/hig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Autodesk/hig/downloads","issues_url":"https://api.github.com/repos/Autodesk/hig/issues{/number}","pulls_url":"https://api.github.com/repos/Autodesk/hig/pulls{/number}","milestones_url":"https://api.github.com/repos/Autodesk/hig/milestones{/number}","notifications_url":"https://api.github.com/repos/Autodesk/hig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Autodesk/hig/labels{/name}","releases_url":"https://api.github.com/repos/Autodesk/hig/releases{/id}","deployments_url":"https://api.github.com/repos/Autodesk/hig/deployments","created_at":"2017-04-03T21:55:02Z","updated_at":"2018-08-07T16:49:45Z","pushed_at":"2018-08-08T21:49:10Z","git_url":"git://github.com/Autodesk/hig.git","ssh_url":"git@github.com:Autodesk/hig.git","clone_url":"https://github.com/Autodesk/hig.git","svn_url":"https://github.com/Autodesk/hig","homepage":"http://storybook.hig.autodesk.com/","size":22937,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":29,"open_issues":102,"watchers":62,"default_branch":"development"}},"base":{"label":"Autodesk:development","ref":"development","sha":"145ce1224c8e1695d14290f4ff58297e5c5eebef","user":{"login":"Autodesk","id":7914533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7914533?v=4","gravatar_id":"","url":"https://api.github.com/users/Autodesk","html_url":"https://github.com/Autodesk","followers_url":"https://api.github.com/users/Autodesk/followers","following_url":"https://api.github.com/users/Autodesk/following{/other_user}","gists_url":"https://api.github.com/users/Autodesk/gists{/gist_id}","starred_url":"https://api.github.com/users/Autodesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Autodesk/subscriptions","organizations_url":"https://api.github.com/users/Autodesk/orgs","repos_url":"https://api.github.com/users/Autodesk/repos","events_url":"https://api.github.com/users/Autodesk/events{/privacy}","received_events_url":"https://api.github.com/users/Autodesk/received_events","type":"Organization","site_admin":false},"repo":{"id":87124532,"node_id":"MDEwOlJlcG9zaXRvcnk4NzEyNDUzMg==","name":"hig","full_name":"Autodesk/hig","owner":{"login":"Autodesk","id":7914533,"node_id":"MDEyOk9yZ2FuaXphdGlvbjc5MTQ1MzM=","avatar_url":"https://avatars2.githubusercontent.com/u/7914533?v=4","gravatar_id":"","url":"https://api.github.com/users/Autodesk","html_url":"https://github.com/Autodesk","followers_url":"https://api.github.com/users/Autodesk/followers","following_url":"https://api.github.com/users/Autodesk/following{/other_user}","gists_url":"https://api.github.com/users/Autodesk/gists{/gist_id}","starred_url":"https://api.github.com/users/Autodesk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Autodesk/subscriptions","organizations_url":"https://api.github.com/users/Autodesk/orgs","repos_url":"https://api.github.com/users/Autodesk/repos","events_url":"https://api.github.com/users/Autodesk/events{/privacy}","received_events_url":"https://api.github.com/users/Autodesk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Autodesk/hig","description":"Autodesk's unified design design system","fork":false,"url":"https://api.github.com/repos/Autodesk/hig","forks_url":"https://api.github.com/repos/Autodesk/hig/forks","keys_url":"https://api.github.com/repos/Autodesk/hig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Autodesk/hig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Autodesk/hig/teams","hooks_url":"https://api.github.com/repos/Autodesk/hig/hooks","issue_events_url":"https://api.github.com/repos/Autodesk/hig/issues/events{/number}","events_url":"https://api.github.com/repos/Autodesk/hig/events","assignees_url":"https://api.github.com/repos/Autodesk/hig/assignees{/user}","branches_url":"https://api.github.com/repos/Autodesk/hig/branches{/branch}","tags_url":"https://api.github.com/repos/Autodesk/hig/tags","blobs_url":"https://api.github.com/repos/Autodesk/hig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Autodesk/hig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Autodesk/hig/git/refs{/sha}","trees_url":"https://api.github.com/repos/Autodesk/hig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Autodesk/hig/statuses/{sha}","languages_url":"https://api.github.com/repos/Autodesk/hig/languages","stargazers_url":"https://api.github.com/repos/Autodesk/hig/stargazers","contributors_url":"https://api.github.com/repos/Autodesk/hig/contributors","subscribers_url":"https://api.github.com/repos/Autodesk/hig/subscribers","subscription_url":"https://api.github.com/repos/Autodesk/hig/subscription","commits_url":"https://api.github.com/repos/Autodesk/hig/commits{/sha}","git_commits_url":"https://api.github.com/repos/Autodesk/hig/git/commits{/sha}","comments_url":"https://api.github.com/repos/Autodesk/hig/comments{/number}","issue_comment_url":"https://api.github.com/repos/Autodesk/hig/issues/comments{/number}","contents_url":"https://api.github.com/repos/Autodesk/hig/contents/{+path}","compare_url":"https://api.github.com/repos/Autodesk/hig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Autodesk/hig/merges","archive_url":"https://api.github.com/repos/Autodesk/hig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Autodesk/hig/downloads","issues_url":"https://api.github.com/repos/Autodesk/hig/issues{/number}","pulls_url":"https://api.github.com/repos/Autodesk/hig/pulls{/number}","milestones_url":"https://api.github.com/repos/Autodesk/hig/milestones{/number}","notifications_url":"https://api.github.com/repos/Autodesk/hig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Autodesk/hig/labels{/name}","releases_url":"https://api.github.com/repos/Autodesk/hig/releases{/id}","deployments_url":"https://api.github.com/repos/Autodesk/hig/deployments","created_at":"2017-04-03T21:55:02Z","updated_at":"2018-08-07T16:49:45Z","pushed_at":"2018-08-08T21:49:10Z","git_url":"git://github.com/Autodesk/hig.git","ssh_url":"git@github.com:Autodesk/hig.git","clone_url":"https://github.com/Autodesk/hig.git","svn_url":"https://github.com/Autodesk/hig","homepage":"http://storybook.hig.autodesk.com/","size":22937,"stargazers_count":62,"watchers_count":62,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":29,"mirror_url":null,"archived":false,"open_issues_count":102,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":29,"open_issues":102,"watchers":62,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/Autodesk/hig/pulls/1092"},"html":{"href":"https://github.com/Autodesk/hig/pull/1092"},"issue":{"href":"https://api.github.com/repos/Autodesk/hig/issues/1092"},"comments":{"href":"https://api.github.com/repos/Autodesk/hig/issues/1092/comments"},"review_comments":{"href":"https://api.github.com/repos/Autodesk/hig/pulls/1092/comments"},"review_comment":{"href":"https://api.github.com/repos/Autodesk/hig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Autodesk/hig/pulls/1092/commits"},"statuses":{"href":"https://api.github.com/repos/Autodesk/hig/statuses/14ec76648883a35128dcf19df2654a29ac750149"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"morrisallison"}}