{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cordova-browser/issues/55","repository_url":"https://api.github.com/repos/apache/cordova-browser","labels_url":"https://api.github.com/repos/apache/cordova-browser/issues/55/labels{/name}","comments_url":"https://api.github.com/repos/apache/cordova-browser/issues/55/comments","events_url":"https://api.github.com/repos/apache/cordova-browser/issues/55/events","html_url":"https://github.com/apache/cordova-browser/pull/55","id":345943754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0OTM2NDk3","number":55,"title":"CB-14230 patch release 5.0.4","user":{"login":"brodybits","id":1559888,"node_id":"MDQ6VXNlcjE1NTk4ODg=","avatar_url":"https://avatars0.githubusercontent.com/u/1559888?v=4","gravatar_id":"","url":"https://api.github.com/users/brodybits","html_url":"https://github.com/brodybits","followers_url":"https://api.github.com/users/brodybits/followers","following_url":"https://api.github.com/users/brodybits/following{/other_user}","gists_url":"https://api.github.com/users/brodybits/gists{/gist_id}","starred_url":"https://api.github.com/users/brodybits/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brodybits/subscriptions","organizations_url":"https://api.github.com/users/brodybits/orgs","repos_url":"https://api.github.com/users/brodybits/repos","events_url":"https://api.github.com/users/brodybits/events{/privacy}","received_events_url":"https://api.github.com/users/brodybits/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-30T21:33:30Z","updated_at":"2018-07-30T21:46:08Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/apache/cordova-browser/pulls/55","html_url":"https://github.com/apache/cordova-browser/pull/55","diff_url":"https://github.com/apache/cordova-browser/pull/55.diff","patch_url":"https://github.com/apache/cordova-browser/pull/55.patch"},"body":"<!--\r\nPlease make sure the checklist boxes are all checked before submitting the PR. The checklist\r\nis intended as a quick reference, for complete details please see our Contributor Guidelines:\r\n\r\nhttp://cordova.apache.org/contribute/contribute_guidelines.html\r\n\r\nThanks!\r\n-->\r\n\r\n### Platforms affected\r\n\r\nbrowser\r\n\r\n### What does this PR do?\r\n\r\n- Update RELEASENOTES.md with major changes for `5.0.4`\r\n- Update JS snapshot, VERSION, and version to `5.0.4` on `5.0.x` branch using the following command with updates from apache/cordova-coho#176: `./cordova-coho/coho prepare-platform-release-branch --version 5.0.4 -r browser 5.0.x`\r\n\r\nThis release includes the following changes:\r\n* [CB-9366](https://issues.apache.org/jira/browse/CB-9366) - log `error.stack` in `cordova.js` (update from `cordova-js@4.2.4`) in `5.0.x` (ef012e389996d27f580063a7b271f2ae08c484e9)\r\n* add Node.js 10 to AppVeyor CI and Travis CI in `5.0.x` (57fdfc8735f6aa5b91b397f7822180ea86bdb0bf)\r\n* [CB-14145](https://issues.apache.org/jira/browse/CB-14145) update dependencies to resolve `npm audit` issues, pinned in `5.0.x` only (GH-53)\r\n* GH-54 - pin more added bundled dependencies in 5.0.x only (needed to clear the red highlights in `npm outdated --depth=0`)\r\n\r\n### What testing has been done on this change?\r\n\r\n- [x] `npm audit` shows 0 vulnerabilities (using npm@6.2.0)\r\n- [ ] `npm outdated --depth=0` shows no red entries\r\n- [ ] `coho audit-license-headers -r browser` shows no missing license headers\r\n- [ ] `coho check-license -r browser` shows no incorrect licenses\r\n- [ ] `npm test` succeeds on local machine\r\n- [ ] `npm test` succeeds on AppVeyor CI & Travis CI\r\n- [ ] able to add to <https://github.com/brodybits/cordova-dialogs-bootstrap-test> using `cordova platform add github:brodybits/cordova-browser#5.0.x`, run, and try a couple dialogs with npm@2.15.11 (bundled with deprecated node v4.9.1)\r\n- [ ] able to add to <https://github.com/brodybits/cordova-dialogs-bootstrap-test> using `cordova platform add github:brodybits/cordova-browser#5.0.x`, run, and try a couple dialogs with npm@5.6.0 (bundled with node v8.11.3)\r\n\r\n### Checklist\r\n\r\n- ~~[Reported an issue](http://cordova.apache.org/contribute/issues.html) in the JIRA database~~\r\n- [x] Commit message follows the format: \"CB-3232: (android) Fix bug with resolving file paths\", where CB-xxxx is the JIRA ID & \"android\" is the platform affected. (manual changes only)\r\n- ~~Added automated test coverage as appropriate for this change.~~"},"comment":{"url":"https://api.github.com/repos/apache/cordova-browser/issues/comments/409022282","html_url":"https://github.com/apache/cordova-browser/pull/55#issuecomment-409022282","issue_url":"https://api.github.com/repos/apache/cordova-browser/issues/55","id":409022282,"node_id":"MDEyOklzc3VlQ29tbWVudDQwOTAyMjI4Mg==","user":{"login":"janpio","id":183673,"node_id":"MDQ6VXNlcjE4MzY3Mw==","avatar_url":"https://avatars0.githubusercontent.com/u/183673?v=4","gravatar_id":"","url":"https://api.github.com/users/janpio","html_url":"https://github.com/janpio","followers_url":"https://api.github.com/users/janpio/followers","following_url":"https://api.github.com/users/janpio/following{/other_user}","gists_url":"https://api.github.com/users/janpio/gists{/gist_id}","starred_url":"https://api.github.com/users/janpio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/janpio/subscriptions","organizations_url":"https://api.github.com/users/janpio/orgs","repos_url":"https://api.github.com/users/janpio/repos","events_url":"https://api.github.com/users/janpio/events{/privacy}","received_events_url":"https://api.github.com/users/janpio/received_events","type":"User","site_admin":false},"created_at":"2018-07-30T21:46:07Z","updated_at":"2018-07-30T21:46:07Z","author_association":"NONE","body":"> Update RELEASENOTES.md with major changes for 5.0.4\r\n\r\nmajor changes? Typo?"}}
{"actor":{"display_login":"janpio"}}