{"action":"created","issue":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/941","repository_url":"https://api.github.com/repos/hyperledger/iroha","labels_url":"https://api.github.com/repos/hyperledger/iroha/issues/941/labels{/name}","comments_url":"https://api.github.com/repos/hyperledger/iroha/issues/941/comments","events_url":"https://api.github.com/repos/hyperledger/iroha/issues/941/events","html_url":"https://github.com/hyperledger/iroha/pull/941","id":294098426,"number":941,"title":"Add more verbose comments to TODO messages + tasks in jira","user":{"login":"grimadas","id":5897440,"avatar_url":"https://avatars2.githubusercontent.com/u/5897440?v=4","gravatar_id":"","url":"https://api.github.com/users/grimadas","html_url":"https://github.com/grimadas","followers_url":"https://api.github.com/users/grimadas/followers","following_url":"https://api.github.com/users/grimadas/following{/other_user}","gists_url":"https://api.github.com/users/grimadas/gists{/gist_id}","starred_url":"https://api.github.com/users/grimadas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/grimadas/subscriptions","organizations_url":"https://api.github.com/users/grimadas/orgs","repos_url":"https://api.github.com/users/grimadas/repos","events_url":"https://api.github.com/users/grimadas/events{/privacy}","received_events_url":"https://api.github.com/users/grimadas/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-02-03T09:39:55Z","updated_at":"2018-02-13T09:03:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/hyperledger/iroha/pulls/941","html_url":"https://github.com/hyperledger/iroha/pull/941","diff_url":"https://github.com/hyperledger/iroha/pull/941.diff","patch_url":"https://github.com/hyperledger/iroha/pull/941.patch"},"body":"### Description of the Change\r\n\r\nAdd more verbose comments to TODO messages + tasks in jira\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/hyperledger/iroha/issues/comments/365194076","html_url":"https://github.com/hyperledger/iroha/pull/941#issuecomment-365194076","issue_url":"https://api.github.com/repos/hyperledger/iroha/issues/941","id":365194076,"user":{"login":"sorabot","id":32125183,"avatar_url":"https://avatars0.githubusercontent.com/u/32125183?v=4","gravatar_id":"","url":"https://api.github.com/users/sorabot","html_url":"https://github.com/sorabot","followers_url":"https://api.github.com/users/sorabot/followers","following_url":"https://api.github.com/users/sorabot/following{/other_user}","gists_url":"https://api.github.com/users/sorabot/gists{/gist_id}","starred_url":"https://api.github.com/users/sorabot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sorabot/subscriptions","organizations_url":"https://api.github.com/users/sorabot/orgs","repos_url":"https://api.github.com/users/sorabot/repos","events_url":"https://api.github.com/users/sorabot/events{/privacy}","received_events_url":"https://api.github.com/users/sorabot/received_events","type":"User","site_admin":false},"created_at":"2018-02-13T09:03:17Z","updated_at":"2018-02-13T09:03:17Z","author_association":"NONE","body":"SonarQube analysis reported 19 issues\n* ![MINOR][MINOR] 6 minor\n* ![INFO][INFO] 13 info\n\n#### Top 10 issues\n\n1. ![MINOR][MINOR] [command_executor.cpp#L73](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/execution/impl/command_executor.cpp#L73): Define a constant instead of duplicating this literal \"failed to insert account role\" 2 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3AStringLiteralDuplicated)\n1. ![MINOR][MINOR] [command_executor.cpp#L280](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/execution/impl/command_executor.cpp#L280): Define a constant instead of duplicating this literal \"asset %s is absent\" 2 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3AStringLiteralDuplicated)\n1. ![MINOR][MINOR] [command_executor.cpp#L287](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/execution/impl/command_executor.cpp#L287): Define a constant instead of duplicating this literal \"precision mismatch: expected %d, but got %d\" 2 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3AStringLiteralDuplicated)\n1. ![MINOR][MINOR] [command_executor.cpp#L451](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/execution/impl/command_executor.cpp#L451): Define a constant instead of duplicating this literal \"failed to insert signatory\" 2 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3AStringLiteralDuplicated)\n1. ![MINOR][MINOR] [command_executor.cpp#L455](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/execution/impl/command_executor.cpp#L455): Define a constant instead of duplicating this literal \"failed to insert account signatory\" 2 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3AStringLiteralDuplicated)\n1. ![MINOR][MINOR] [command_executor.cpp#L805](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/execution/impl/command_executor.cpp#L805): Define a constant instead of duplicating this literal \"asset %s is absent of %s\" 2 times. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3AStringLiteralDuplicated)\n1. ![INFO][INFO] [command_executor.cpp#L35](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/execution/impl/command_executor.cpp#L35): Complete the task associated to this TODO comment. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3ATodoTagPresence)\n1. ![INFO][INFO] [command_executor.cpp#L327](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/execution/impl/command_executor.cpp#L327): Complete the task associated to this TODO comment. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3ATodoTagPresence)\n1. ![INFO][INFO] [query_execution.cpp#L80](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/impl/query_execution.cpp#L80): Complete the task associated to this TODO comment. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3ATodoTagPresence)\n1. ![INFO][INFO] [query_execution.cpp#L86](https://github.com/hyperledger/iroha/blob/65f810f22e9f42ade9fca555a7a3becdf660d9af/irohad/model/impl/query_execution.cpp#L86): Complete the task associated to this TODO comment. [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonar.soramitsu.co.jp/coding_rules#rule_key=cxx%3ATodoTagPresence)\n\n[INFO]: https://sonarsource.github.io/sonar-github/severity-info.png 'Severity: INFO'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"sorabot"}}