{"action":"created","issue":{"url":"https://api.github.com/repos/RPTools/maptool/issues/179","repository_url":"https://api.github.com/repos/RPTools/maptool","labels_url":"https://api.github.com/repos/RPTools/maptool/issues/179/labels{/name}","comments_url":"https://api.github.com/repos/RPTools/maptool/issues/179/comments","events_url":"https://api.github.com/repos/RPTools/maptool/issues/179/events","html_url":"https://github.com/RPTools/maptool/pull/179","id":305725341,"number":179,"title":"Z order violation","user":{"login":"Jaggeroth","id":6901191,"avatar_url":"https://avatars0.githubusercontent.com/u/6901191?v=4","gravatar_id":"","url":"https://api.github.com/users/Jaggeroth","html_url":"https://github.com/Jaggeroth","followers_url":"https://api.github.com/users/Jaggeroth/followers","following_url":"https://api.github.com/users/Jaggeroth/following{/other_user}","gists_url":"https://api.github.com/users/Jaggeroth/gists{/gist_id}","starred_url":"https://api.github.com/users/Jaggeroth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jaggeroth/subscriptions","organizations_url":"https://api.github.com/users/Jaggeroth/orgs","repos_url":"https://api.github.com/users/Jaggeroth/repos","events_url":"https://api.github.com/users/Jaggeroth/events{/privacy}","received_events_url":"https://api.github.com/users/Jaggeroth/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-15T21:26:27Z","updated_at":"2018-03-16T09:20:18Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/RPTools/maptool/pulls/179","html_url":"https://github.com/RPTools/maptool/pull/179","diff_url":"https://github.com/RPTools/maptool/pull/179.diff","patch_url":"https://github.com/RPTools/maptool/pull/179.patch"},"body":"This solves the ZOrder sort violation problem by restoring the original comparator and only using the new figure comparator when sorting figure only.\r\n\r\nDifficult to say this absolutely solves the problem as we have never been able to reliably trigger the error.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/rptools/maptool/179)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/RPTools/maptool/issues/comments/373651690","html_url":"https://github.com/RPTools/maptool/pull/179#issuecomment-373651690","issue_url":"https://api.github.com/repos/RPTools/maptool/issues/179","id":373651690,"user":{"login":"irisiflimsi","id":2022972,"avatar_url":"https://avatars2.githubusercontent.com/u/2022972?v=4","gravatar_id":"","url":"https://api.github.com/users/irisiflimsi","html_url":"https://github.com/irisiflimsi","followers_url":"https://api.github.com/users/irisiflimsi/followers","following_url":"https://api.github.com/users/irisiflimsi/following{/other_user}","gists_url":"https://api.github.com/users/irisiflimsi/gists{/gist_id}","starred_url":"https://api.github.com/users/irisiflimsi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/irisiflimsi/subscriptions","organizations_url":"https://api.github.com/users/irisiflimsi/orgs","repos_url":"https://api.github.com/users/irisiflimsi/repos","events_url":"https://api.github.com/users/irisiflimsi/events{/privacy}","received_events_url":"https://api.github.com/users/irisiflimsi/received_events","type":"User","site_admin":false},"created_at":"2018-03-16T09:20:18Z","updated_at":"2018-03-16T09:20:18Z","author_association":"NONE","body":"Looks okay. BTW, the test that I posted reliably triggers the problem:-). The section o1.isStamp && o2.isToken relies on the fact that factually isToken = !isStamp. If this were not the case in the future, we will have the problem again. I advise to change either isToken or isStamp to the reverse of the other.\n\n---\n\n\n\n\n\n\n\n*Comments from [Reviewable](https://reviewable.io:443/reviews/rptools/maptool/179#-:-L7i4jxBodQOp3oAfGdo:b602ybl)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"irisiflimsi"}}