{"action":"created","issue":{"url":"https://api.github.com/repos/Talend/daikon/issues/421","repository_url":"https://api.github.com/repos/Talend/daikon","labels_url":"https://api.github.com/repos/Talend/daikon/issues/421/labels{/name}","comments_url":"https://api.github.com/repos/Talend/daikon/issues/421/comments","events_url":"https://api.github.com/repos/Talend/daikon/issues/421/events","html_url":"https://github.com/Talend/daikon/pull/421","id":375855942,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3MjAyMjQ1","number":421,"title":"chore: make audit context immutable","user":{"login":"tduperron","id":39481831,"node_id":"MDQ6VXNlcjM5NDgxODMx","avatar_url":"https://avatars0.githubusercontent.com/u/39481831?v=4","gravatar_id":"","url":"https://api.github.com/users/tduperron","html_url":"https://github.com/tduperron","followers_url":"https://api.github.com/users/tduperron/followers","following_url":"https://api.github.com/users/tduperron/following{/other_user}","gists_url":"https://api.github.com/users/tduperron/gists{/gist_id}","starred_url":"https://api.github.com/users/tduperron/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tduperron/subscriptions","organizations_url":"https://api.github.com/users/tduperron/orgs","repos_url":"https://api.github.com/users/tduperron/repos","events_url":"https://api.github.com/users/tduperron/events{/privacy}","received_events_url":"https://api.github.com/users/tduperron/received_events","type":"User","site_admin":false},"labels":[{"id":397848096,"node_id":"MDU6TGFiZWwzOTc4NDgwOTY=","url":"https://api.github.com/repos/Talend/daikon/labels/Merged%20build%20passed","name":"Merged build passed","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-31T08:49:30Z","updated_at":"2019-01-02T09:40:52Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/Talend/daikon/pulls/421","html_url":"https://github.com/Talend/daikon/pull/421","diff_url":"https://github.com/Talend/daikon/pull/421.diff","patch_url":"https://github.com/Talend/daikon/pull/421.patch"},"body":"**What is the problem this Pull Request is trying to solve?**\r\n\r\nThe pull request is to avoid bad usage of ContextBuilder like :\r\n`Context context = ContextBuilder.create(\"fieldA\", \"valueA\").build();\r\ncontext.put(\"fieldB\", null\");`\r\n \r\n**What is the chosen solution to this problem?**\r\n\r\nMake context immutable when it has been built.\r\n\r\nI think DefaultContextImpl may also have constructor only accessible by the builder.\r\n \r\n**Link to the JIRA issue**\r\n<!--e.g. https://jira.talendforge.org/browse/XXX -->\r\n \r\n**Please check if the Pull Request fulfills these requirements**\r\n- [x] The PR commit message follows our [guidelines](../CONTRIBUTING.md)\r\n- [x] Tests for the changes have been added (for bug fixes / features, coverage should be over 75% in the new code)\r\n- [ ] Docs have been added / updated (for bug fixes / features)\r\n- [ ] Related design / discussions / pages (not in JIRA), if any, are all linked or available in the Pull Request\r\n\r\n<!-- You can add more checkboxes here -->\r\n \r\n**[x] This Pull Request introduces a breaking change**\r\n \r\nMay break bad usage of the context.\r\n\r\n<!-- **Original Template** -->\r\n<!-- https://github.com/Talend/tools/blob/master/tools-root-github/.github/PULL_REQUEST_TEMPLATE.md -->\r\n"},"comment":{"url":"https://api.github.com/repos/Talend/daikon/issues/comments/450820426","html_url":"https://github.com/Talend/daikon/pull/421#issuecomment-450820426","issue_url":"https://api.github.com/repos/Talend/daikon/issues/421","id":450820426,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDgyMDQyNg==","user":{"login":"build-talend-common","id":24920003,"node_id":"MDQ6VXNlcjI0OTIwMDAz","avatar_url":"https://avatars1.githubusercontent.com/u/24920003?v=4","gravatar_id":"","url":"https://api.github.com/users/build-talend-common","html_url":"https://github.com/build-talend-common","followers_url":"https://api.github.com/users/build-talend-common/followers","following_url":"https://api.github.com/users/build-talend-common/following{/other_user}","gists_url":"https://api.github.com/users/build-talend-common/gists{/gist_id}","starred_url":"https://api.github.com/users/build-talend-common/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/build-talend-common/subscriptions","organizations_url":"https://api.github.com/users/build-talend-common/orgs","repos_url":"https://api.github.com/users/build-talend-common/repos","events_url":"https://api.github.com/users/build-talend-common/events{/privacy}","received_events_url":"https://api.github.com/users/build-talend-common/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T09:40:52Z","updated_at":"2019-01-02T09:40:52Z","author_association":"COLLABORATOR","body":"Pull request test result: [success](https://ci-common.datapwn.com/job/daikon_pull-request_master/94/) [:star:](https://ci-common.datapwn.com/job/daikon_pull-request_master/94/) "}}
{"actor":{"display_login":"build-talend-common"}}