{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/origin/issues/19475","repository_url":"https://api.github.com/repos/openshift/origin","labels_url":"https://api.github.com/repos/openshift/origin/issues/19475/labels{/name}","comments_url":"https://api.github.com/repos/openshift/origin/issues/19475/comments","events_url":"https://api.github.com/repos/openshift/origin/issues/19475/events","html_url":"https://github.com/openshift/origin/pull/19475","id":316927900,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzNTE4NDE2","number":19475,"title":"Add Deny Authorizer","user":{"login":"enj","id":7001223,"node_id":"MDQ6VXNlcjcwMDEyMjM=","avatar_url":"https://avatars0.githubusercontent.com/u/7001223?v=4","gravatar_id":"","url":"https://api.github.com/users/enj","html_url":"https://github.com/enj","followers_url":"https://api.github.com/users/enj/followers","following_url":"https://api.github.com/users/enj/following{/other_user}","gists_url":"https://api.github.com/users/enj/gists{/gist_id}","starred_url":"https://api.github.com/users/enj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/enj/subscriptions","organizations_url":"https://api.github.com/users/enj/orgs","repos_url":"https://api.github.com/users/enj/repos","events_url":"https://api.github.com/users/enj/events{/privacy}","received_events_url":"https://api.github.com/users/enj/received_events","type":"User","site_admin":false},"labels":[{"id":683198191,"node_id":"MDU6TGFiZWw2ODMxOTgxOTE=","url":"https://api.github.com/repos/openshift/origin/labels/do-not-merge/hold","name":"do-not-merge/hold","color":"e11d21","default":false},{"id":364523381,"node_id":"MDU6TGFiZWwzNjQ1MjMzODE=","url":"https://api.github.com/repos/openshift/origin/labels/needs-api-review","name":"needs-api-review","color":"b60205","default":false},{"id":683887368,"node_id":"MDU6TGFiZWw2ODM4ODczNjg=","url":"https://api.github.com/repos/openshift/origin/labels/sig/master","name":"sig/master","color":"f9d0c4","default":false},{"id":657292628,"node_id":"MDU6TGFiZWw2NTcyOTI2Mjg=","url":"https://api.github.com/repos/openshift/origin/labels/sig/security","name":"sig/security","color":"f9d0c4","default":false},{"id":640548662,"node_id":"MDU6TGFiZWw2NDA1NDg2NjI=","url":"https://api.github.com/repos/openshift/origin/labels/size/XXL","name":"size/XXL","color":"ee0000","default":false}],"state":"open","locked":false,"assignee":{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},"assignees":[{"login":"deads2k","id":8225098,"node_id":"MDQ6VXNlcjgyMjUwOTg=","avatar_url":"https://avatars0.githubusercontent.com/u/8225098?v=4","gravatar_id":"","url":"https://api.github.com/users/deads2k","html_url":"https://github.com/deads2k","followers_url":"https://api.github.com/users/deads2k/followers","following_url":"https://api.github.com/users/deads2k/following{/other_user}","gists_url":"https://api.github.com/users/deads2k/gists{/gist_id}","starred_url":"https://api.github.com/users/deads2k/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/deads2k/subscriptions","organizations_url":"https://api.github.com/users/deads2k/orgs","repos_url":"https://api.github.com/users/deads2k/repos","events_url":"https://api.github.com/users/deads2k/events{/privacy}","received_events_url":"https://api.github.com/users/deads2k/received_events","type":"User","site_admin":false},{"login":"simo5","id":8332609,"node_id":"MDQ6VXNlcjgzMzI2MDk=","avatar_url":"https://avatars2.githubusercontent.com/u/8332609?v=4","gravatar_id":"","url":"https://api.github.com/users/simo5","html_url":"https://github.com/simo5","followers_url":"https://api.github.com/users/simo5/followers","following_url":"https://api.github.com/users/simo5/following{/other_user}","gists_url":"https://api.github.com/users/simo5/gists{/gist_id}","starred_url":"https://api.github.com/users/simo5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simo5/subscriptions","organizations_url":"https://api.github.com/users/simo5/orgs","repos_url":"https://api.github.com/users/simo5/repos","events_url":"https://api.github.com/users/simo5/events{/privacy}","received_events_url":"https://api.github.com/users/simo5/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/openshift/origin/milestones/27","html_url":"https://github.com/openshift/origin/milestone/27","labels_url":"https://api.github.com/repos/openshift/origin/milestones/27/labels","id":3248464,"node_id":"MDk6TWlsZXN0b25lMzI0ODQ2NA==","number":27,"title":"v3.11","description":"","creator":{"login":"jwforres","id":1467629,"node_id":"MDQ6VXNlcjE0Njc2Mjk=","avatar_url":"https://avatars2.githubusercontent.com/u/1467629?v=4","gravatar_id":"","url":"https://api.github.com/users/jwforres","html_url":"https://github.com/jwforres","followers_url":"https://api.github.com/users/jwforres/followers","following_url":"https://api.github.com/users/jwforres/following{/other_user}","gists_url":"https://api.github.com/users/jwforres/gists{/gist_id}","starred_url":"https://api.github.com/users/jwforres/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jwforres/subscriptions","organizations_url":"https://api.github.com/users/jwforres/orgs","repos_url":"https://api.github.com/users/jwforres/repos","events_url":"https://api.github.com/users/jwforres/events{/privacy}","received_events_url":"https://api.github.com/users/jwforres/received_events","type":"User","site_admin":false},"open_issues":17,"closed_issues":19,"state":"open","created_at":"2018-04-06T17:29:30Z","updated_at":"2018-07-17T20:47:46Z","due_on":null,"closed_at":null},"comments":6,"created_at":"2018-04-23T18:25:49Z","updated_at":"2018-07-17T20:57:21Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openshift/origin/pulls/19475","html_url":"https://github.com/openshift/origin/pull/19475","diff_url":"https://github.com/openshift/origin/pull/19475.diff","patch_url":"https://github.com/openshift/origin/pull/19475.patch"},"body":"https://trello.com/c/uxG5LtTX\r\n\r\n@openshift/sig-security @openshift/sig-master \r\n\r\n/assign @deads2k @simo5 \r\n\r\ncc @mrogers950 @shawn-hurley \r\n\r\n/hold\r\n\r\nHolding for 3.11.\r\n\r\nThings to review carefully:\r\n\r\n- [ ] UPSTREAM: openshift/api: 0: Add AccessRestriction in authorization v1alpha1\r\n  - Verify changes to shell scripts\r\n- [ ] UPSTREAM: openshift/client-go: 0: Update codegen script to support authorization v1alpha1\r\n  - Verify changes to shell scripts\r\n- [ ] Add Access Restriction internal types\r\n  - Verify changes to shell scripts\r\n- [ ] Add access restriction REST API\r\n  - Check wiring of v1alpha1 storage\r\n  - Check addition of v1alpha1 version for authorization group\r\n- [ ] UPSTREAM: `<carry>`: Access restriction changes for GC and quota\r\n  - Check if this is valid\r\n- [ ] Wrap authorization informer for v1alpha1 access restriction\r\n  - Determine if this hack is OK\r\n- [ ] Add access restriction deny authorizer\r\n  - See one minor TODO item in authorizer logic\r\n\r\nTODO:\r\n\r\n- [ ] Make deny authorizer enablement flag in master config instead of it being active all the time\r\n- [ ] Make deny authorizer ignore cluster scoped resources and all resources in reserved namespaces (`kube-*`, `openshift-*`, etc)"},"comment":{"url":"https://api.github.com/repos/openshift/origin/issues/comments/405725348","html_url":"https://github.com/openshift/origin/pull/19475#issuecomment-405725348","issue_url":"https://api.github.com/repos/openshift/origin/issues/19475","id":405725348,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTcyNTM0OA==","user":{"login":"openshift-ci-robot","id":30189103,"node_id":"MDQ6VXNlcjMwMTg5MTAz","avatar_url":"https://avatars1.githubusercontent.com/u/30189103?v=4","gravatar_id":"","url":"https://api.github.com/users/openshift-ci-robot","html_url":"https://github.com/openshift-ci-robot","followers_url":"https://api.github.com/users/openshift-ci-robot/followers","following_url":"https://api.github.com/users/openshift-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/openshift-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/openshift-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openshift-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/openshift-ci-robot/orgs","repos_url":"https://api.github.com/users/openshift-ci-robot/repos","events_url":"https://api.github.com/users/openshift-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/openshift-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-07-17T20:57:21Z","updated_at":"2018-07-17T20:57:21Z","author_association":"NONE","body":"@enj: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\nci/openshift-jenkins/extended_builds | 768b12a83776d973974429fbef986889f8b5eae1 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19475/test_pull_request_origin_extended_builds/1891/) | `/test extended_builds`\nci/openshift-jenkins/end_to_end | 768b12a83776d973974429fbef986889f8b5eae1 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19475/test_pull_request_origin_end_to_end/14563/) | `/test end_to_end`\nci/openshift-jenkins/cmd | 768b12a83776d973974429fbef986889f8b5eae1 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19475/test_pull_request_origin_cmd/15205/) | `/test cmd`\nci/prow/unit | 6b9704400e943a813891b3571f5ac48345bcc880 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19475/pull-ci-origin-unit/1513/) | `/test unit`\nci/prow/verify | 6b9704400e943a813891b3571f5ac48345bcc880 | [link](https://openshift-gce-devel.appspot.com/build/origin-ci-test/pr-logs/pull/19475/pull-ci-origin-verify/922/) | `/test verify`\n\n\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"openshift-ci-robot"}}