{"action":"closed","number":1305,"pull_request":{"url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls/1305","id":189214468,"html_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/1305","diff_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/1305.diff","patch_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/1305.patch","issue_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues/1305","number":1305,"state":"closed","locked":false,"title":"Fixed an issue where clicking \"Ok\" after editing flag names would cause YNAB to crash.","user":{"login":"joshmadewell","id":3503785,"avatar_url":"https://avatars2.githubusercontent.com/u/3503785?v=4","gravatar_id":"","url":"https://api.github.com/users/joshmadewell","html_url":"https://github.com/joshmadewell","followers_url":"https://api.github.com/users/joshmadewell/followers","following_url":"https://api.github.com/users/joshmadewell/following{/other_user}","gists_url":"https://api.github.com/users/joshmadewell/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmadewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmadewell/subscriptions","organizations_url":"https://api.github.com/users/joshmadewell/orgs","repos_url":"https://api.github.com/users/joshmadewell/repos","events_url":"https://api.github.com/users/joshmadewell/events{/privacy}","received_events_url":"https://api.github.com/users/joshmadewell/received_events","type":"User","site_admin":false},"body":"<!--Thank you for your contribution! Please note that Pull Request titles are used\r\nto generate release notes. So rather than having a \"technical\" title, it's\r\npreferred that you have a title which is descriptive to a normal user.\r\n\r\nExample:\r\n  Instead of:\r\n    - \"Changed the selector to use new YNAB className\"\r\n  Use:\r\n    - \"Fixed an issue with account rows height introduced by YNAB's latest update.\r\n\r\nStarting titles in the following way is also really useful for release notes to have\r\na consistent feeling:\r\n\r\nBug Fix (ie: YNAB changed a class name we depend on):\r\n  - \"Fixed an issue...\"\r\nModification (ie: Removed starting balances from reports):\r\n  - \"Changed the way...\"\r\nFeature (ie: adding a feature that didn't already exist):\r\n  - \"Feature: Name of New Feature\"\r\n\r\nFinally, after properly titling your Pull Request, please fill out the following\r\ninformation to provide context to the reviewer and more technical information\r\nto interested users since this Pull Request will be linked in the release notes.-->\r\n\r\nGithub Issue (if applicable): #1304\r\n\r\nTrello Link (if applicable):\r\n\r\nForum Link (if applicable):\r\n\r\n#### Explanation of Bugfix/Feature/Modification:\r\nWe were simulating a clock on the `modal-overlay` to close the modal. Opt for the safer application action `closeModal`.\r\n","created_at":"2018-05-20T01:34:52Z","updated_at":"2018-05-20T18:17:24Z","closed_at":"2018-05-20T18:17:24Z","merged_at":"2018-05-20T18:17:24Z","merge_commit_sha":"617b54829bc0fe37a989c8148c41c97de95ea2dd","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls/1305/commits","review_comments_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls/1305/comments","review_comment_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls/comments{/number}","comments_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues/1305/comments","statuses_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/statuses/765349a6f1170fa7b7280f0d6fe2d6cb7300a756","head":{"label":"toolkit-for-ynab:issue-1304","ref":"issue-1304","sha":"765349a6f1170fa7b7280f0d6fe2d6cb7300a756","user":{"login":"toolkit-for-ynab","id":17663786,"avatar_url":"https://avatars1.githubusercontent.com/u/17663786?v=4","gravatar_id":"","url":"https://api.github.com/users/toolkit-for-ynab","html_url":"https://github.com/toolkit-for-ynab","followers_url":"https://api.github.com/users/toolkit-for-ynab/followers","following_url":"https://api.github.com/users/toolkit-for-ynab/following{/other_user}","gists_url":"https://api.github.com/users/toolkit-for-ynab/gists{/gist_id}","starred_url":"https://api.github.com/users/toolkit-for-ynab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolkit-for-ynab/subscriptions","organizations_url":"https://api.github.com/users/toolkit-for-ynab/orgs","repos_url":"https://api.github.com/users/toolkit-for-ynab/repos","events_url":"https://api.github.com/users/toolkit-for-ynab/events{/privacy}","received_events_url":"https://api.github.com/users/toolkit-for-ynab/received_events","type":"Organization","site_admin":false},"repo":{"id":48935429,"name":"toolkit-for-ynab","full_name":"toolkit-for-ynab/toolkit-for-ynab","owner":{"login":"toolkit-for-ynab","id":17663786,"avatar_url":"https://avatars1.githubusercontent.com/u/17663786?v=4","gravatar_id":"","url":"https://api.github.com/users/toolkit-for-ynab","html_url":"https://github.com/toolkit-for-ynab","followers_url":"https://api.github.com/users/toolkit-for-ynab/followers","following_url":"https://api.github.com/users/toolkit-for-ynab/following{/other_user}","gists_url":"https://api.github.com/users/toolkit-for-ynab/gists{/gist_id}","starred_url":"https://api.github.com/users/toolkit-for-ynab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolkit-for-ynab/subscriptions","organizations_url":"https://api.github.com/users/toolkit-for-ynab/orgs","repos_url":"https://api.github.com/users/toolkit-for-ynab/repos","events_url":"https://api.github.com/users/toolkit-for-ynab/events{/privacy}","received_events_url":"https://api.github.com/users/toolkit-for-ynab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab","description":"A general purpose YNAB enhancing browser extension for Chrome and Firefox. Have it your way!","fork":false,"url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab","forks_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/forks","keys_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/teams","hooks_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/hooks","issue_events_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues/events{/number}","events_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/events","assignees_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/assignees{/user}","branches_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/branches{/branch}","tags_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/tags","blobs_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/refs{/sha}","trees_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/statuses/{sha}","languages_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/languages","stargazers_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/stargazers","contributors_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/contributors","subscribers_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/subscribers","subscription_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/subscription","commits_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/commits{/sha}","git_commits_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/commits{/sha}","comments_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/comments{/number}","issue_comment_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues/comments{/number}","contents_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/contents/{+path}","compare_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/merges","archive_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/downloads","issues_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues{/number}","pulls_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls{/number}","milestones_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/milestones{/number}","notifications_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/labels{/name}","releases_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/releases{/id}","deployments_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/deployments","created_at":"2016-01-03T05:38:10Z","updated_at":"2018-05-19T02:36:28Z","pushed_at":"2018-05-20T18:17:24Z","git_url":"git://github.com/toolkit-for-ynab/toolkit-for-ynab.git","ssh_url":"git@github.com:toolkit-for-ynab/toolkit-for-ynab.git","clone_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab.git","svn_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab","homepage":"","size":18492,"stargazers_count":537,"watchers_count":537,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":126,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":126,"open_issues":31,"watchers":537,"default_branch":"master"}},"base":{"label":"toolkit-for-ynab:master","ref":"master","sha":"9a768d3523e8787397cf8516020c7ac33bdb34da","user":{"login":"toolkit-for-ynab","id":17663786,"avatar_url":"https://avatars1.githubusercontent.com/u/17663786?v=4","gravatar_id":"","url":"https://api.github.com/users/toolkit-for-ynab","html_url":"https://github.com/toolkit-for-ynab","followers_url":"https://api.github.com/users/toolkit-for-ynab/followers","following_url":"https://api.github.com/users/toolkit-for-ynab/following{/other_user}","gists_url":"https://api.github.com/users/toolkit-for-ynab/gists{/gist_id}","starred_url":"https://api.github.com/users/toolkit-for-ynab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolkit-for-ynab/subscriptions","organizations_url":"https://api.github.com/users/toolkit-for-ynab/orgs","repos_url":"https://api.github.com/users/toolkit-for-ynab/repos","events_url":"https://api.github.com/users/toolkit-for-ynab/events{/privacy}","received_events_url":"https://api.github.com/users/toolkit-for-ynab/received_events","type":"Organization","site_admin":false},"repo":{"id":48935429,"name":"toolkit-for-ynab","full_name":"toolkit-for-ynab/toolkit-for-ynab","owner":{"login":"toolkit-for-ynab","id":17663786,"avatar_url":"https://avatars1.githubusercontent.com/u/17663786?v=4","gravatar_id":"","url":"https://api.github.com/users/toolkit-for-ynab","html_url":"https://github.com/toolkit-for-ynab","followers_url":"https://api.github.com/users/toolkit-for-ynab/followers","following_url":"https://api.github.com/users/toolkit-for-ynab/following{/other_user}","gists_url":"https://api.github.com/users/toolkit-for-ynab/gists{/gist_id}","starred_url":"https://api.github.com/users/toolkit-for-ynab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/toolkit-for-ynab/subscriptions","organizations_url":"https://api.github.com/users/toolkit-for-ynab/orgs","repos_url":"https://api.github.com/users/toolkit-for-ynab/repos","events_url":"https://api.github.com/users/toolkit-for-ynab/events{/privacy}","received_events_url":"https://api.github.com/users/toolkit-for-ynab/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab","description":"A general purpose YNAB enhancing browser extension for Chrome and Firefox. Have it your way!","fork":false,"url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab","forks_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/forks","keys_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/keys{/key_id}","collaborators_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/teams","hooks_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/hooks","issue_events_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues/events{/number}","events_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/events","assignees_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/assignees{/user}","branches_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/branches{/branch}","tags_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/tags","blobs_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/refs{/sha}","trees_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/trees{/sha}","statuses_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/statuses/{sha}","languages_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/languages","stargazers_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/stargazers","contributors_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/contributors","subscribers_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/subscribers","subscription_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/subscription","commits_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/commits{/sha}","git_commits_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/git/commits{/sha}","comments_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/comments{/number}","issue_comment_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues/comments{/number}","contents_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/contents/{+path}","compare_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/compare/{base}...{head}","merges_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/merges","archive_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/downloads","issues_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues{/number}","pulls_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls{/number}","milestones_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/milestones{/number}","notifications_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/labels{/name}","releases_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/releases{/id}","deployments_url":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/deployments","created_at":"2016-01-03T05:38:10Z","updated_at":"2018-05-19T02:36:28Z","pushed_at":"2018-05-20T18:17:24Z","git_url":"git://github.com/toolkit-for-ynab/toolkit-for-ynab.git","ssh_url":"git@github.com:toolkit-for-ynab/toolkit-for-ynab.git","clone_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab.git","svn_url":"https://github.com/toolkit-for-ynab/toolkit-for-ynab","homepage":"","size":18492,"stargazers_count":537,"watchers_count":537,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":126,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":126,"open_issues":31,"watchers":537,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls/1305"},"html":{"href":"https://github.com/toolkit-for-ynab/toolkit-for-ynab/pull/1305"},"issue":{"href":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues/1305"},"comments":{"href":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/issues/1305/comments"},"review_comments":{"href":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls/1305/comments"},"review_comment":{"href":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/pulls/1305/commits"},"statuses":{"href":"https://api.github.com/repos/toolkit-for-ynab/toolkit-for-ynab/statuses/765349a6f1170fa7b7280f0d6fe2d6cb7300a756"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"joshmadewell","id":3503785,"avatar_url":"https://avatars2.githubusercontent.com/u/3503785?v=4","gravatar_id":"","url":"https://api.github.com/users/joshmadewell","html_url":"https://github.com/joshmadewell","followers_url":"https://api.github.com/users/joshmadewell/followers","following_url":"https://api.github.com/users/joshmadewell/following{/other_user}","gists_url":"https://api.github.com/users/joshmadewell/gists{/gist_id}","starred_url":"https://api.github.com/users/joshmadewell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshmadewell/subscriptions","organizations_url":"https://api.github.com/users/joshmadewell/orgs","repos_url":"https://api.github.com/users/joshmadewell/repos","events_url":"https://api.github.com/users/joshmadewell/events{/privacy}","received_events_url":"https://api.github.com/users/joshmadewell/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":28,"deletions":8,"changed_files":1}}
{"actor":{"display_login":"joshmadewell"}}