{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/240914474","pull_request_review_id":184052420,"id":240914474,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDkxNDQ3NA==","diff_hunk":"@@ -0,0 +1,46 @@\n+'use strict';","path":"test/parallel/test-child-process-spawn-args.js","position":1,"original_position":1,"commit_id":"f57a30bc6869e8c074cdb9aa21f758166a90f8b0","original_commit_id":"f57a30bc6869e8c074cdb9aa21f758166a90f8b0","user":{"login":"eduardbcom","id":8774679,"node_id":"MDQ6VXNlcjg3NzQ2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/8774679?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardbcom","html_url":"https://github.com/eduardbcom","followers_url":"https://api.github.com/users/eduardbcom/followers","following_url":"https://api.github.com/users/eduardbcom/following{/other_user}","gists_url":"https://api.github.com/users/eduardbcom/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardbcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardbcom/subscriptions","organizations_url":"https://api.github.com/users/eduardbcom/orgs","repos_url":"https://api.github.com/users/eduardbcom/repos","events_url":"https://api.github.com/users/eduardbcom/events{/privacy}","received_events_url":"https://api.github.com/users/eduardbcom/received_events","type":"User","site_admin":false},"body":"In addition, that fix effects only `spawn` and `spawnSync` methods.","created_at":"2018-12-12T08:12:55Z","updated_at":"2018-12-12T08:12:55Z","html_url":"https://github.com/nodejs/node/pull/24913#discussion_r240914474","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/24913","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/240914474"},"html":{"href":"https://github.com/nodejs/node/pull/24913#discussion_r240914474"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/24913"}},"in_reply_to_id":240301041},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24913","id":237093789,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MDkzNzg5","html_url":"https://github.com/nodejs/node/pull/24913","diff_url":"https://github.com/nodejs/node/pull/24913.diff","patch_url":"https://github.com/nodejs/node/pull/24913.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/24913","number":24913,"state":"open","locked":false,"title":"child_process: spawn ignores options in case args is undefined","user":{"login":"eduardbcom","id":8774679,"node_id":"MDQ6VXNlcjg3NzQ2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/8774679?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardbcom","html_url":"https://github.com/eduardbcom","followers_url":"https://api.github.com/users/eduardbcom/followers","following_url":"https://api.github.com/users/eduardbcom/following{/other_user}","gists_url":"https://api.github.com/users/eduardbcom/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardbcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardbcom/subscriptions","organizations_url":"https://api.github.com/users/eduardbcom/orgs","repos_url":"https://api.github.com/users/eduardbcom/repos","events_url":"https://api.github.com/users/eduardbcom/events{/privacy}","received_events_url":"https://api.github.com/users/eduardbcom/received_events","type":"User","site_admin":false},"body":"spawn method ignores 3-d argument 'options' in case\r\nthe second one 'args' equals to 'undefined'.\r\n\r\nFixes: https://github.com/nodejs/node/issues/24912\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n","created_at":"2018-12-08T21:58:29Z","updated_at":"2018-12-12T08:12:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"09c1127d5f27d90e5d8d74222960ee50687d3a8e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":754449534,"node_id":"MDU6TGFiZWw3NTQ0NDk1MzQ=","url":"https://api.github.com/repos/nodejs/node/labels/author%20ready","name":"author ready","color":"1eca26","default":false},{"id":155267478,"node_id":"MDU6TGFiZWwxNTUyNjc0Nzg=","url":"https://api.github.com/repos/nodejs/node/labels/child_process","name":"child_process","color":"f7c6c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/24913/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/24913/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24913/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/f57a30bc6869e8c074cdb9aa21f758166a90f8b0","head":{"label":"eduardbcom:spawn-ignores-options-when-args-undefined","ref":"spawn-ignores-options-when-args-undefined","sha":"f57a30bc6869e8c074cdb9aa21f758166a90f8b0","user":{"login":"eduardbcom","id":8774679,"node_id":"MDQ6VXNlcjg3NzQ2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/8774679?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardbcom","html_url":"https://github.com/eduardbcom","followers_url":"https://api.github.com/users/eduardbcom/followers","following_url":"https://api.github.com/users/eduardbcom/following{/other_user}","gists_url":"https://api.github.com/users/eduardbcom/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardbcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardbcom/subscriptions","organizations_url":"https://api.github.com/users/eduardbcom/orgs","repos_url":"https://api.github.com/users/eduardbcom/repos","events_url":"https://api.github.com/users/eduardbcom/events{/privacy}","received_events_url":"https://api.github.com/users/eduardbcom/received_events","type":"User","site_admin":false},"repo":{"id":67361755,"node_id":"MDEwOlJlcG9zaXRvcnk2NzM2MTc1NQ==","name":"node","full_name":"eduardbcom/node","private":false,"owner":{"login":"eduardbcom","id":8774679,"node_id":"MDQ6VXNlcjg3NzQ2Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/8774679?v=4","gravatar_id":"","url":"https://api.github.com/users/eduardbcom","html_url":"https://github.com/eduardbcom","followers_url":"https://api.github.com/users/eduardbcom/followers","following_url":"https://api.github.com/users/eduardbcom/following{/other_user}","gists_url":"https://api.github.com/users/eduardbcom/gists{/gist_id}","starred_url":"https://api.github.com/users/eduardbcom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eduardbcom/subscriptions","organizations_url":"https://api.github.com/users/eduardbcom/orgs","repos_url":"https://api.github.com/users/eduardbcom/repos","events_url":"https://api.github.com/users/eduardbcom/events{/privacy}","received_events_url":"https://api.github.com/users/eduardbcom/received_events","type":"User","site_admin":false},"html_url":"https://github.com/eduardbcom/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/eduardbcom/node","forks_url":"https://api.github.com/repos/eduardbcom/node/forks","keys_url":"https://api.github.com/repos/eduardbcom/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/eduardbcom/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/eduardbcom/node/teams","hooks_url":"https://api.github.com/repos/eduardbcom/node/hooks","issue_events_url":"https://api.github.com/repos/eduardbcom/node/issues/events{/number}","events_url":"https://api.github.com/repos/eduardbcom/node/events","assignees_url":"https://api.github.com/repos/eduardbcom/node/assignees{/user}","branches_url":"https://api.github.com/repos/eduardbcom/node/branches{/branch}","tags_url":"https://api.github.com/repos/eduardbcom/node/tags","blobs_url":"https://api.github.com/repos/eduardbcom/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/eduardbcom/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/eduardbcom/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/eduardbcom/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/eduardbcom/node/statuses/{sha}","languages_url":"https://api.github.com/repos/eduardbcom/node/languages","stargazers_url":"https://api.github.com/repos/eduardbcom/node/stargazers","contributors_url":"https://api.github.com/repos/eduardbcom/node/contributors","subscribers_url":"https://api.github.com/repos/eduardbcom/node/subscribers","subscription_url":"https://api.github.com/repos/eduardbcom/node/subscription","commits_url":"https://api.github.com/repos/eduardbcom/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/eduardbcom/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/eduardbcom/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/eduardbcom/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/eduardbcom/node/contents/{+path}","compare_url":"https://api.github.com/repos/eduardbcom/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/eduardbcom/node/merges","archive_url":"https://api.github.com/repos/eduardbcom/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/eduardbcom/node/downloads","issues_url":"https://api.github.com/repos/eduardbcom/node/issues{/number}","pulls_url":"https://api.github.com/repos/eduardbcom/node/pulls{/number}","milestones_url":"https://api.github.com/repos/eduardbcom/node/milestones{/number}","notifications_url":"https://api.github.com/repos/eduardbcom/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/eduardbcom/node/labels{/name}","releases_url":"https://api.github.com/repos/eduardbcom/node/releases{/id}","deployments_url":"https://api.github.com/repos/eduardbcom/node/deployments","created_at":"2016-09-04T18:33:14Z","updated_at":"2018-12-08T18:53:27Z","pushed_at":"2018-12-10T09:04:46Z","git_url":"git://github.com/eduardbcom/node.git","ssh_url":"git@github.com:eduardbcom/node.git","clone_url":"https://github.com/eduardbcom/node.git","svn_url":"https://github.com/eduardbcom/node","homepage":"https://nodejs.org","size":398879,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"4aabd7ed641db5d78fdf7e1c93b93027ffc3a9b4","user":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"node_id":"MDEwOlJlcG9zaXRvcnkyNzE5Mzc3OQ==","name":"node","full_name":"nodejs/node","private":false,"owner":{"login":"nodejs","id":9950313,"node_id":"MDEyOk9yZ2FuaXphdGlvbjk5NTAzMTM=","avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-12-12T08:01:35Z","pushed_at":"2018-12-12T07:20:32Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":440882,"stargazers_count":56328,"watchers_count":56328,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12424,"mirror_url":null,"archived":false,"open_issues_count":727,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":12424,"open_issues":727,"watchers":56328,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/24913"},"html":{"href":"https://github.com/nodejs/node/pull/24913"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/24913"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/24913/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/24913/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/24913/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/f57a30bc6869e8c074cdb9aa21f758166a90f8b0"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"eduardbcom"}}