{"action":"created","comment":{"url":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/comments/165292676","pull_request_review_id":93205394,"id":165292676,"diff_hunk":"@@ -0,0 +1,88 @@\n+﻿using Gpss.Net.Contracts;\n+using Gpss.Net.Core;\n+using Gpss.Net.Core.Visitors;\n+using System;\n+using System.Collections.Generic;\n+using System.Text;\n+\n+namespace Gpss.Net.Generators\n+{\n+\t/// <summary>\n+\t/// Internal class that converts generated random numbers into GPSS transacts.\n+\t/// </summary>\n+\tinternal sealed class GpssGenerator : GpssVisitableObject\n+\t{\n+\t\tprivate readonly IGpssTimeGenerator randomGenerator;\n+\n+\t\tprivate double lastTransactTime = 0;\n+\n+\t\t/// <summary>\n+\t\t/// Creates a <see cref=\"GpssGenerator\"/> instance.\n+\t\t/// </summary>\n+\t\t/// <param name=\"randomGenerator\">Random generator to be used.</param>\n+\t\tpublic GpssGenerator(IGpssTimeGenerator randomGenerator)","path":"Gpss.Net/Generators/GpssGenerator.cs","position":23,"original_position":23,"commit_id":"1aa6a3bac8bd2eb1cab0e76564ac6cc97995cec2","original_commit_id":"1aa6a3bac8bd2eb1cab0e76564ac6cc97995cec2","user":{"login":"ArtemStolyarenko","id":12846639,"avatar_url":"https://avatars0.githubusercontent.com/u/12846639?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtemStolyarenko","html_url":"https://github.com/ArtemStolyarenko","followers_url":"https://api.github.com/users/ArtemStolyarenko/followers","following_url":"https://api.github.com/users/ArtemStolyarenko/following{/other_user}","gists_url":"https://api.github.com/users/ArtemStolyarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtemStolyarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtemStolyarenko/subscriptions","organizations_url":"https://api.github.com/users/ArtemStolyarenko/orgs","repos_url":"https://api.github.com/users/ArtemStolyarenko/repos","events_url":"https://api.github.com/users/ArtemStolyarenko/events{/privacy}","received_events_url":"https://api.github.com/users/ArtemStolyarenko/received_events","type":"User","site_admin":false},"body":"OK, I agree with overall to be generated transact count being passed in the contructor.\r\nIf you want to add overall transact to be generated (in all generators), then:\r\n- I don't understand why we need it here\r\n- I don't understand how are you going to calculate the number, given that stop condition for the model is \r\na certain number of terminated transactions, not generated","created_at":"2018-02-01T09:06:16Z","updated_at":"2018-02-01T09:06:16Z","html_url":"https://github.com/mr-RiP/GPSS.NET/pull/1#discussion_r165292676","pull_request_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/1","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/comments/165292676"},"html":{"href":"https://github.com/mr-RiP/GPSS.NET/pull/1#discussion_r165292676"},"pull_request":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/1"}},"in_reply_to_id":164971041},"pull_request":{"url":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/1","id":165544865,"html_url":"https://github.com/mr-RiP/GPSS.NET/pull/1","diff_url":"https://github.com/mr-RiP/GPSS.NET/pull/1.diff","patch_url":"https://github.com/mr-RiP/GPSS.NET/pull/1.patch","issue_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues/1","number":1,"state":"open","locked":false,"title":"[GPSSNET-1] Added architectuire draft","user":{"login":"ArtemStolyarenko","id":12846639,"avatar_url":"https://avatars0.githubusercontent.com/u/12846639?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtemStolyarenko","html_url":"https://github.com/ArtemStolyarenko","followers_url":"https://api.github.com/users/ArtemStolyarenko/followers","following_url":"https://api.github.com/users/ArtemStolyarenko/following{/other_user}","gists_url":"https://api.github.com/users/ArtemStolyarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtemStolyarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtemStolyarenko/subscriptions","organizations_url":"https://api.github.com/users/ArtemStolyarenko/orgs","repos_url":"https://api.github.com/users/ArtemStolyarenko/repos","events_url":"https://api.github.com/users/ArtemStolyarenko/events{/privacy}","received_events_url":"https://api.github.com/users/ArtemStolyarenko/received_events","type":"User","site_admin":false},"body":"Added base architecture based on Builder & Visitor patterns to solution","created_at":"2018-01-28T00:50:23Z","updated_at":"2018-02-01T09:06:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7127a0a8d924a74c9d62832dd9f53f5dd2721c3","assignee":{"login":"ArtemStolyarenko","id":12846639,"avatar_url":"https://avatars0.githubusercontent.com/u/12846639?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtemStolyarenko","html_url":"https://github.com/ArtemStolyarenko","followers_url":"https://api.github.com/users/ArtemStolyarenko/followers","following_url":"https://api.github.com/users/ArtemStolyarenko/following{/other_user}","gists_url":"https://api.github.com/users/ArtemStolyarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtemStolyarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtemStolyarenko/subscriptions","organizations_url":"https://api.github.com/users/ArtemStolyarenko/orgs","repos_url":"https://api.github.com/users/ArtemStolyarenko/repos","events_url":"https://api.github.com/users/ArtemStolyarenko/events{/privacy}","received_events_url":"https://api.github.com/users/ArtemStolyarenko/received_events","type":"User","site_admin":false},"assignees":[{"login":"ArtemStolyarenko","id":12846639,"avatar_url":"https://avatars0.githubusercontent.com/u/12846639?v=4","gravatar_id":"","url":"https://api.github.com/users/ArtemStolyarenko","html_url":"https://github.com/ArtemStolyarenko","followers_url":"https://api.github.com/users/ArtemStolyarenko/followers","following_url":"https://api.github.com/users/ArtemStolyarenko/following{/other_user}","gists_url":"https://api.github.com/users/ArtemStolyarenko/gists{/gist_id}","starred_url":"https://api.github.com/users/ArtemStolyarenko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArtemStolyarenko/subscriptions","organizations_url":"https://api.github.com/users/ArtemStolyarenko/orgs","repos_url":"https://api.github.com/users/ArtemStolyarenko/repos","events_url":"https://api.github.com/users/ArtemStolyarenko/events{/privacy}","received_events_url":"https://api.github.com/users/ArtemStolyarenko/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/1/commits","review_comments_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/1/comments","review_comment_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues/1/comments","statuses_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/statuses/1aa6a3bac8bd2eb1cab0e76564ac6cc97995cec2","head":{"label":"mr-RiP:feature/GPSSNET-1","ref":"feature/GPSSNET-1","sha":"1aa6a3bac8bd2eb1cab0e76564ac6cc97995cec2","user":{"login":"mr-RiP","id":22458201,"avatar_url":"https://avatars3.githubusercontent.com/u/22458201?v=4","gravatar_id":"","url":"https://api.github.com/users/mr-RiP","html_url":"https://github.com/mr-RiP","followers_url":"https://api.github.com/users/mr-RiP/followers","following_url":"https://api.github.com/users/mr-RiP/following{/other_user}","gists_url":"https://api.github.com/users/mr-RiP/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-RiP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-RiP/subscriptions","organizations_url":"https://api.github.com/users/mr-RiP/orgs","repos_url":"https://api.github.com/users/mr-RiP/repos","events_url":"https://api.github.com/users/mr-RiP/events{/privacy}","received_events_url":"https://api.github.com/users/mr-RiP/received_events","type":"User","site_admin":false},"repo":{"id":119167187,"name":"GPSS.NET","full_name":"mr-RiP/GPSS.NET","owner":{"login":"mr-RiP","id":22458201,"avatar_url":"https://avatars3.githubusercontent.com/u/22458201?v=4","gravatar_id":"","url":"https://api.github.com/users/mr-RiP","html_url":"https://github.com/mr-RiP","followers_url":"https://api.github.com/users/mr-RiP/followers","following_url":"https://api.github.com/users/mr-RiP/following{/other_user}","gists_url":"https://api.github.com/users/mr-RiP/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-RiP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-RiP/subscriptions","organizations_url":"https://api.github.com/users/mr-RiP/orgs","repos_url":"https://api.github.com/users/mr-RiP/repos","events_url":"https://api.github.com/users/mr-RiP/events{/privacy}","received_events_url":"https://api.github.com/users/mr-RiP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mr-RiP/GPSS.NET","description":"GPSS system implementation in C#","fork":false,"url":"https://api.github.com/repos/mr-RiP/GPSS.NET","forks_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/forks","keys_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/teams","hooks_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/hooks","issue_events_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues/events{/number}","events_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/events","assignees_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/assignees{/user}","branches_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/branches{/branch}","tags_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/tags","blobs_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/refs{/sha}","trees_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/statuses/{sha}","languages_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/languages","stargazers_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/stargazers","contributors_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/contributors","subscribers_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/subscribers","subscription_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/subscription","commits_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/commits{/sha}","git_commits_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/commits{/sha}","comments_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/comments{/number}","issue_comment_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues/comments{/number}","contents_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/contents/{+path}","compare_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/merges","archive_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/downloads","issues_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues{/number}","pulls_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls{/number}","milestones_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/milestones{/number}","notifications_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/labels{/name}","releases_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/releases{/id}","deployments_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/deployments","created_at":"2018-01-27T13:34:15Z","updated_at":"2018-01-27T13:39:59Z","pushed_at":"2018-01-29T19:34:37Z","git_url":"git://github.com/mr-RiP/GPSS.NET.git","ssh_url":"git@github.com:mr-RiP/GPSS.NET.git","clone_url":"https://github.com/mr-RiP/GPSS.NET.git","svn_url":"https://github.com/mr-RiP/GPSS.NET","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"mr-RiP:develop","ref":"develop","sha":"03f1c043c11901eaba9b999ba9f4dbc8a9c1f7f7","user":{"login":"mr-RiP","id":22458201,"avatar_url":"https://avatars3.githubusercontent.com/u/22458201?v=4","gravatar_id":"","url":"https://api.github.com/users/mr-RiP","html_url":"https://github.com/mr-RiP","followers_url":"https://api.github.com/users/mr-RiP/followers","following_url":"https://api.github.com/users/mr-RiP/following{/other_user}","gists_url":"https://api.github.com/users/mr-RiP/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-RiP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-RiP/subscriptions","organizations_url":"https://api.github.com/users/mr-RiP/orgs","repos_url":"https://api.github.com/users/mr-RiP/repos","events_url":"https://api.github.com/users/mr-RiP/events{/privacy}","received_events_url":"https://api.github.com/users/mr-RiP/received_events","type":"User","site_admin":false},"repo":{"id":119167187,"name":"GPSS.NET","full_name":"mr-RiP/GPSS.NET","owner":{"login":"mr-RiP","id":22458201,"avatar_url":"https://avatars3.githubusercontent.com/u/22458201?v=4","gravatar_id":"","url":"https://api.github.com/users/mr-RiP","html_url":"https://github.com/mr-RiP","followers_url":"https://api.github.com/users/mr-RiP/followers","following_url":"https://api.github.com/users/mr-RiP/following{/other_user}","gists_url":"https://api.github.com/users/mr-RiP/gists{/gist_id}","starred_url":"https://api.github.com/users/mr-RiP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mr-RiP/subscriptions","organizations_url":"https://api.github.com/users/mr-RiP/orgs","repos_url":"https://api.github.com/users/mr-RiP/repos","events_url":"https://api.github.com/users/mr-RiP/events{/privacy}","received_events_url":"https://api.github.com/users/mr-RiP/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mr-RiP/GPSS.NET","description":"GPSS system implementation in C#","fork":false,"url":"https://api.github.com/repos/mr-RiP/GPSS.NET","forks_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/forks","keys_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/teams","hooks_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/hooks","issue_events_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues/events{/number}","events_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/events","assignees_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/assignees{/user}","branches_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/branches{/branch}","tags_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/tags","blobs_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/refs{/sha}","trees_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/statuses/{sha}","languages_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/languages","stargazers_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/stargazers","contributors_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/contributors","subscribers_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/subscribers","subscription_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/subscription","commits_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/commits{/sha}","git_commits_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/git/commits{/sha}","comments_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/comments{/number}","issue_comment_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues/comments{/number}","contents_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/contents/{+path}","compare_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/merges","archive_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/downloads","issues_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues{/number}","pulls_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls{/number}","milestones_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/milestones{/number}","notifications_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/labels{/name}","releases_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/releases{/id}","deployments_url":"https://api.github.com/repos/mr-RiP/GPSS.NET/deployments","created_at":"2018-01-27T13:34:15Z","updated_at":"2018-01-27T13:39:59Z","pushed_at":"2018-01-29T19:34:37Z","git_url":"git://github.com/mr-RiP/GPSS.NET.git","ssh_url":"git@github.com:mr-RiP/GPSS.NET.git","clone_url":"https://github.com/mr-RiP/GPSS.NET.git","svn_url":"https://github.com/mr-RiP/GPSS.NET","homepage":null,"size":21,"stargazers_count":0,"watchers_count":0,"language":null,"has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/1"},"html":{"href":"https://github.com/mr-RiP/GPSS.NET/pull/1"},"issue":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues/1"},"comments":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/mr-RiP/GPSS.NET/statuses/1aa6a3bac8bd2eb1cab0e76564ac6cc97995cec2"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"ArtemStolyarenko"}}