{"action":"created","comment":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/209497433","pull_request_review_id":145521234,"id":209497433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTQ5NzQzMw==","diff_hunk":"@@ -99,23 +101,31 @@ var _ = Describe(\"Networking\", func() {\n \ttests.BeforeAll(func() {\n \t\ttests.BeforeTestCleanup()\n \n-\t\tprepareVMIs := func(withPodNetwork bool) (*v1.VirtualMachineInstance, *v1.VirtualMachineInstance) {\n+\t\tprepareVMIs := func(withPodNetwork bool) (*v1.VirtualMachineInstance, *v1.VirtualMachineInstance, *v1.VirtualMachineInstance) {\n \t\t\t// Prepare inbound and outbound VMI definitions\n \t\t\tinboundVMI := tests.NewRandomVMIWithEphemeralDiskAndUserdata(tests.RegistryDiskFor(tests.RegistryDiskCirros), \"#!/bin/bash\\necho 'hello'\\n\")\n \t\t\tinboundVMI.Labels = map[string]string{\"expose\": \"me\"}\n \t\t\tinboundVMI.Spec.Subdomain = \"myvmi\"\n \t\t\tinboundVMI.Spec.Hostname = \"my-subdomain\"\n+\n+\t\t\tinboundVMIWithCustomMacAddress = tests.NewRandomVMIWithEphemeralDiskAndUserdata(tests.RegistryDiskFor(tests.RegistryDiskCirros), \"#!/bin/bash\\necho 'hello'\\n\")\n+\t\t\tinboundVMIWithCustomMacAddress.Labels = map[string]string{\"expose\": \"me\"}\n+\t\t\tinboundVMIWithCustomMacAddress.Spec.Subdomain = \"myvmi\"\n+\t\t\tinboundVMIWithCustomMacAddress.Spec.Hostname = \"my-subdomain\"\n+\t\t\tinboundVMIWithCustomMacAddress.Spec.Domain.Devices.Interfaces[0].MacAddress = \"de:ad:00:00:be:af\"","path":"tests/vmi_networking_test.go","position":27,"original_position":27,"commit_id":"58b9ddb5ecbfdfc124508d5653189f4e83aeae7d","original_commit_id":"58b9ddb5ecbfdfc124508d5653189f4e83aeae7d","user":{"login":"booxter","id":90200,"node_id":"MDQ6VXNlcjkwMjAw","avatar_url":"https://avatars0.githubusercontent.com/u/90200?v=4","gravatar_id":"","url":"https://api.github.com/users/booxter","html_url":"https://github.com/booxter","followers_url":"https://api.github.com/users/booxter/followers","following_url":"https://api.github.com/users/booxter/following{/other_user}","gists_url":"https://api.github.com/users/booxter/gists{/gist_id}","starred_url":"https://api.github.com/users/booxter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/booxter/subscriptions","organizations_url":"https://api.github.com/users/booxter/orgs","repos_url":"https://api.github.com/users/booxter/repos","events_url":"https://api.github.com/users/booxter/events{/privacy}","received_events_url":"https://api.github.com/users/booxter/received_events","type":"User","site_admin":false},"body":"You have to call `v1.SetDefaults_NetworkInterface` before accessing the first interface since `NewRandomVMIWithEphemeralDiskAndUserdata` doesn't add it by default.","created_at":"2018-08-13T05:56:19Z","updated_at":"2018-08-13T05:56:19Z","html_url":"https://github.com/kubevirt/kubevirt/pull/1430#discussion_r209497433","pull_request_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1430","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments/209497433"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1430#discussion_r209497433"},"pull_request":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1430"}}},"pull_request":{"url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1430","id":207627819,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjI3ODE5","html_url":"https://github.com/kubevirt/kubevirt/pull/1430","diff_url":"https://github.com/kubevirt/kubevirt/pull/1430.diff","patch_url":"https://github.com/kubevirt/kubevirt/pull/1430.patch","issue_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1430","number":1430,"state":"open","locked":false,"title":"static MAC on VM interfaces for 0.6","user":{"login":"phoracek","id":3493830,"node_id":"MDQ6VXNlcjM0OTM4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3493830?v=4","gravatar_id":"","url":"https://api.github.com/users/phoracek","html_url":"https://github.com/phoracek","followers_url":"https://api.github.com/users/phoracek/followers","following_url":"https://api.github.com/users/phoracek/following{/other_user}","gists_url":"https://api.github.com/users/phoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/phoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoracek/subscriptions","organizations_url":"https://api.github.com/users/phoracek/orgs","repos_url":"https://api.github.com/users/phoracek/repos","events_url":"https://api.github.com/users/phoracek/events{/privacy}","received_events_url":"https://api.github.com/users/phoracek/received_events","type":"User","site_admin":false},"body":"**What this PR does / why we need it**:\r\n Backport of #1213. Depends on #1427 \r\n\r\n**Special notes for your reviewer**:\r\nRebasing of tests was wild, please pay extra attention to that part.\r\n","created_at":"2018-08-10T14:23:27Z","updated_at":"2018-08-13T05:56:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdb1d66b2f90e4eb82432a2796f40fb17f771ecf","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rmohr","id":4534621,"node_id":"MDQ6VXNlcjQ1MzQ2MjE=","avatar_url":"https://avatars3.githubusercontent.com/u/4534621?v=4","gravatar_id":"","url":"https://api.github.com/users/rmohr","html_url":"https://github.com/rmohr","followers_url":"https://api.github.com/users/rmohr/followers","following_url":"https://api.github.com/users/rmohr/following{/other_user}","gists_url":"https://api.github.com/users/rmohr/gists{/gist_id}","starred_url":"https://api.github.com/users/rmohr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmohr/subscriptions","organizations_url":"https://api.github.com/users/rmohr/orgs","repos_url":"https://api.github.com/users/rmohr/repos","events_url":"https://api.github.com/users/rmohr/events{/privacy}","received_events_url":"https://api.github.com/users/rmohr/received_events","type":"User","site_admin":false},{"login":"stu-gott","id":7397746,"node_id":"MDQ6VXNlcjczOTc3NDY=","avatar_url":"https://avatars1.githubusercontent.com/u/7397746?v=4","gravatar_id":"","url":"https://api.github.com/users/stu-gott","html_url":"https://github.com/stu-gott","followers_url":"https://api.github.com/users/stu-gott/followers","following_url":"https://api.github.com/users/stu-gott/following{/other_user}","gists_url":"https://api.github.com/users/stu-gott/gists{/gist_id}","starred_url":"https://api.github.com/users/stu-gott/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stu-gott/subscriptions","organizations_url":"https://api.github.com/users/stu-gott/orgs","repos_url":"https://api.github.com/users/stu-gott/repos","events_url":"https://api.github.com/users/stu-gott/events{/privacy}","received_events_url":"https://api.github.com/users/stu-gott/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":971140815,"node_id":"MDU6TGFiZWw5NzExNDA4MTU=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":583175137,"node_id":"MDU6TGFiZWw1ODMxNzUxMzc=","url":"https://api.github.com/repos/kubevirt/kubevirt/labels/size/L","name":"size/L","color":"ee9900","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1430/commits","review_comments_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1430/comments","review_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/1430/comments","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/58b9ddb5ecbfdfc124508d5653189f4e83aeae7d","head":{"label":"phoracek:mac_06_backport","ref":"mac_06_backport","sha":"58b9ddb5ecbfdfc124508d5653189f4e83aeae7d","user":{"login":"phoracek","id":3493830,"node_id":"MDQ6VXNlcjM0OTM4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3493830?v=4","gravatar_id":"","url":"https://api.github.com/users/phoracek","html_url":"https://github.com/phoracek","followers_url":"https://api.github.com/users/phoracek/followers","following_url":"https://api.github.com/users/phoracek/following{/other_user}","gists_url":"https://api.github.com/users/phoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/phoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoracek/subscriptions","organizations_url":"https://api.github.com/users/phoracek/orgs","repos_url":"https://api.github.com/users/phoracek/repos","events_url":"https://api.github.com/users/phoracek/events{/privacy}","received_events_url":"https://api.github.com/users/phoracek/received_events","type":"User","site_admin":false},"repo":{"id":114942048,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ5NDIwNDg=","name":"kubevirt","full_name":"phoracek/kubevirt","owner":{"login":"phoracek","id":3493830,"node_id":"MDQ6VXNlcjM0OTM4MzA=","avatar_url":"https://avatars1.githubusercontent.com/u/3493830?v=4","gravatar_id":"","url":"https://api.github.com/users/phoracek","html_url":"https://github.com/phoracek","followers_url":"https://api.github.com/users/phoracek/followers","following_url":"https://api.github.com/users/phoracek/following{/other_user}","gists_url":"https://api.github.com/users/phoracek/gists{/gist_id}","starred_url":"https://api.github.com/users/phoracek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phoracek/subscriptions","organizations_url":"https://api.github.com/users/phoracek/orgs","repos_url":"https://api.github.com/users/phoracek/repos","events_url":"https://api.github.com/users/phoracek/events{/privacy}","received_events_url":"https://api.github.com/users/phoracek/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/phoracek/kubevirt","description":"A virtualization API and runtime add-on for Kubernetes in order to define and manage virtual machines.","fork":true,"url":"https://api.github.com/repos/phoracek/kubevirt","forks_url":"https://api.github.com/repos/phoracek/kubevirt/forks","keys_url":"https://api.github.com/repos/phoracek/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/phoracek/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/phoracek/kubevirt/teams","hooks_url":"https://api.github.com/repos/phoracek/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/phoracek/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/phoracek/kubevirt/events","assignees_url":"https://api.github.com/repos/phoracek/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/phoracek/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/phoracek/kubevirt/tags","blobs_url":"https://api.github.com/repos/phoracek/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/phoracek/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/phoracek/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/phoracek/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/phoracek/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/phoracek/kubevirt/languages","stargazers_url":"https://api.github.com/repos/phoracek/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/phoracek/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/phoracek/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/phoracek/kubevirt/subscription","commits_url":"https://api.github.com/repos/phoracek/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/phoracek/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/phoracek/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/phoracek/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/phoracek/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/phoracek/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/phoracek/kubevirt/merges","archive_url":"https://api.github.com/repos/phoracek/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/phoracek/kubevirt/downloads","issues_url":"https://api.github.com/repos/phoracek/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/phoracek/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/phoracek/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/phoracek/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/phoracek/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/phoracek/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/phoracek/kubevirt/deployments","created_at":"2017-12-20T23:55:05Z","updated_at":"2017-12-20T23:55:08Z","pushed_at":"2018-08-10T14:20:11Z","git_url":"git://github.com/phoracek/kubevirt.git","ssh_url":"git@github.com:phoracek/kubevirt.git","clone_url":"https://github.com/phoracek/kubevirt.git","svn_url":"https://github.com/phoracek/kubevirt","homepage":"","size":82212,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubevirt:release-0.6","ref":"release-0.6","sha":"55d70d03381991eeb805ffd9ec4aca6ff67ee43f","user":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"repo":{"id":76686583,"node_id":"MDEwOlJlcG9zaXRvcnk3NjY4NjU4Mw==","name":"kubevirt","full_name":"kubevirt/kubevirt","owner":{"login":"kubevirt","id":18700703,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NzAwNzAz","avatar_url":"https://avatars1.githubusercontent.com/u/18700703?v=4","gravatar_id":"","url":"https://api.github.com/users/kubevirt","html_url":"https://github.com/kubevirt","followers_url":"https://api.github.com/users/kubevirt/followers","following_url":"https://api.github.com/users/kubevirt/following{/other_user}","gists_url":"https://api.github.com/users/kubevirt/gists{/gist_id}","starred_url":"https://api.github.com/users/kubevirt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubevirt/subscriptions","organizations_url":"https://api.github.com/users/kubevirt/orgs","repos_url":"https://api.github.com/users/kubevirt/repos","events_url":"https://api.github.com/users/kubevirt/events{/privacy}","received_events_url":"https://api.github.com/users/kubevirt/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubevirt/kubevirt","description":"Kubernetes Virtualization Operator with API and runtime in order to define and manage virtual machines.","fork":false,"url":"https://api.github.com/repos/kubevirt/kubevirt","forks_url":"https://api.github.com/repos/kubevirt/kubevirt/forks","keys_url":"https://api.github.com/repos/kubevirt/kubevirt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubevirt/kubevirt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubevirt/kubevirt/teams","hooks_url":"https://api.github.com/repos/kubevirt/kubevirt/hooks","issue_events_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/events{/number}","events_url":"https://api.github.com/repos/kubevirt/kubevirt/events","assignees_url":"https://api.github.com/repos/kubevirt/kubevirt/assignees{/user}","branches_url":"https://api.github.com/repos/kubevirt/kubevirt/branches{/branch}","tags_url":"https://api.github.com/repos/kubevirt/kubevirt/tags","blobs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubevirt/kubevirt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubevirt/kubevirt/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubevirt/kubevirt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubevirt/kubevirt/statuses/{sha}","languages_url":"https://api.github.com/repos/kubevirt/kubevirt/languages","stargazers_url":"https://api.github.com/repos/kubevirt/kubevirt/stargazers","contributors_url":"https://api.github.com/repos/kubevirt/kubevirt/contributors","subscribers_url":"https://api.github.com/repos/kubevirt/kubevirt/subscribers","subscription_url":"https://api.github.com/repos/kubevirt/kubevirt/subscription","commits_url":"https://api.github.com/repos/kubevirt/kubevirt/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubevirt/kubevirt/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubevirt/kubevirt/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubevirt/kubevirt/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubevirt/kubevirt/contents/{+path}","compare_url":"https://api.github.com/repos/kubevirt/kubevirt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubevirt/kubevirt/merges","archive_url":"https://api.github.com/repos/kubevirt/kubevirt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubevirt/kubevirt/downloads","issues_url":"https://api.github.com/repos/kubevirt/kubevirt/issues{/number}","pulls_url":"https://api.github.com/repos/kubevirt/kubevirt/pulls{/number}","milestones_url":"https://api.github.com/repos/kubevirt/kubevirt/milestones{/number}","notifications_url":"https://api.github.com/repos/kubevirt/kubevirt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubevirt/kubevirt/labels{/name}","releases_url":"https://api.github.com/repos/kubevirt/kubevirt/releases{/id}","deployments_url":"https://api.github.com/repos/kubevirt/kubevirt/deployments","created_at":"2016-12-16T21:24:26Z","updated_at":"2018-08-13T02:04:21Z","pushed_at":"2018-08-13T02:29:09Z","git_url":"git://github.com/kubevirt/kubevirt.git","ssh_url":"git@github.com:kubevirt/kubevirt.git","clone_url":"https://github.com/kubevirt/kubevirt.git","svn_url":"https://github.com/kubevirt/kubevirt","homepage":"","size":83768,"stargazers_count":799,"watchers_count":799,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":170,"mirror_url":null,"archived":false,"open_issues_count":159,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":170,"open_issues":159,"watchers":799,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1430"},"html":{"href":"https://github.com/kubevirt/kubevirt/pull/1430"},"issue":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1430"},"comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/issues/1430/comments"},"review_comments":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1430/comments"},"review_comment":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubevirt/kubevirt/pulls/1430/commits"},"statuses":{"href":"https://api.github.com/repos/kubevirt/kubevirt/statuses/58b9ddb5ecbfdfc124508d5653189f4e83aeae7d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"booxter"}}