{"action":"created","issue":{"url":"https://api.github.com/repos/silx-kit/silx/issues/2180","repository_url":"https://api.github.com/repos/silx-kit/silx","labels_url":"https://api.github.com/repos/silx-kit/silx/issues/2180/labels{/name}","comments_url":"https://api.github.com/repos/silx-kit/silx/issues/2180/comments","events_url":"https://api.github.com/repos/silx-kit/silx/issues/2180/events","html_url":"https://github.com/silx-kit/silx/pull/2180","id":369158436,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIyMTY3NTk0","number":2180,"title":"Opencl fft","user":{"login":"kif","id":1018880,"node_id":"MDQ6VXNlcjEwMTg4ODA=","avatar_url":"https://avatars3.githubusercontent.com/u/1018880?v=4","gravatar_id":"","url":"https://api.github.com/users/kif","html_url":"https://github.com/kif","followers_url":"https://api.github.com/users/kif/followers","following_url":"https://api.github.com/users/kif/following{/other_user}","gists_url":"https://api.github.com/users/kif/gists{/gist_id}","starred_url":"https://api.github.com/users/kif/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kif/subscriptions","organizations_url":"https://api.github.com/users/kif/orgs","repos_url":"https://api.github.com/users/kif/repos","events_url":"https://api.github.com/users/kif/events{/privacy}","received_events_url":"https://api.github.com/users/kif/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-10-11T14:48:49Z","updated_at":"2018-10-11T18:51:45Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/silx-kit/silx/pulls/2180","html_url":"https://github.com/silx-kit/silx/pull/2180","diff_url":"https://github.com/silx-kit/silx/pull/2180.diff","patch_url":"https://github.com/silx-kit/silx/pull/2180.patch"},"body":"Re-work Pierre's code"},"comment":{"url":"https://api.github.com/repos/silx-kit/silx/issues/comments/429076774","html_url":"https://github.com/silx-kit/silx/pull/2180#issuecomment-429076774","issue_url":"https://api.github.com/repos/silx-kit/silx/issues/2180","id":429076774,"node_id":"MDEyOklzc3VlQ29tbWVudDQyOTA3Njc3NA==","user":{"login":"pierrepaleo","id":4429195,"node_id":"MDQ6VXNlcjQ0MjkxOTU=","avatar_url":"https://avatars2.githubusercontent.com/u/4429195?v=4","gravatar_id":"","url":"https://api.github.com/users/pierrepaleo","html_url":"https://github.com/pierrepaleo","followers_url":"https://api.github.com/users/pierrepaleo/followers","following_url":"https://api.github.com/users/pierrepaleo/following{/other_user}","gists_url":"https://api.github.com/users/pierrepaleo/gists{/gist_id}","starred_url":"https://api.github.com/users/pierrepaleo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pierrepaleo/subscriptions","organizations_url":"https://api.github.com/users/pierrepaleo/orgs","repos_url":"https://api.github.com/users/pierrepaleo/repos","events_url":"https://api.github.com/users/pierrepaleo/events{/privacy}","received_events_url":"https://api.github.com/users/pierrepaleo/received_events","type":"User","site_admin":false},"created_at":"2018-10-11T18:51:45Z","updated_at":"2018-10-11T18:51:45Z","author_association":"CONTRIBUTOR","body":"Looks good. In the tests :\r\n\r\n- [Line 90](https://github.com/silx-kit/silx/pull/2180/files#diff-37c19655baa63e2fc756eee085a5cac3R90): We can use `numpy.fft.rfft2(self.data)` instead of `numpy.fft.fft2(self.data)[:, :self.shape[-1] // 2 + 1]`\r\n- The test precision is low (`1e-3 * max`), but IIRC the \"error\" might be large due to the computations done in float32 (whereas the first thing done by numpy FFT is to cast input data to float64). I don't remember having tested with `double_precision=True`.\r\n\r\nIn the FFT Class, the code logic seems to imply that complex input data might not be \"detected\" properly as complex data (`self.real_fft = not(force_complex)`). Perhaps the input data type (real/complex) should be checked."}}
{"actor":{"display_login":"pierrepaleo"}}