{"action":"closed","number":68,"pull_request":{"url":"https://api.github.com/repos/gnea/grbl-Mega/pulls/68","id":207620899,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3NjIwODk5","html_url":"https://github.com/gnea/grbl-Mega/pull/68","diff_url":"https://github.com/gnea/grbl-Mega/pull/68.diff","patch_url":"https://github.com/gnea/grbl-Mega/pull/68.patch","issue_url":"https://api.github.com/repos/gnea/grbl-Mega/issues/68","number":68,"state":"closed","locked":false,"title":"Fixes gremlin where changing step and direction inversion masks made a mess","user":{"login":"bgort","id":8062568,"node_id":"MDQ6VXNlcjgwNjI1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/8062568?v=4","gravatar_id":"","url":"https://api.github.com/users/bgort","html_url":"https://github.com/bgort","followers_url":"https://api.github.com/users/bgort/followers","following_url":"https://api.github.com/users/bgort/following{/other_user}","gists_url":"https://api.github.com/users/bgort/gists{/gist_id}","starred_url":"https://api.github.com/users/bgort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgort/subscriptions","organizations_url":"https://api.github.com/users/bgort/orgs","repos_url":"https://api.github.com/users/bgort/repos","events_url":"https://api.github.com/users/bgort/events{/privacy}","received_events_url":"https://api.github.com/users/bgort/received_events","type":"User","site_admin":false},"body":"This PR fixes a gremlin where changing the stepper step and direction inversion masks didn't work correctly because step_port_invert_mask[] and dir_port_invert_mask[] (new with the RAMPS modifications) weren't reset to 0 when they should have been (when unset).  \r\n\r\nThis made initial setup more difficult due to likely desynchronization between settings.step_invert_mask and step_port_invert_mask[] and between settings.dir_invert_mask and dir_port_invert_mask[] with a change to $2 or $3, where grbl would ultimately behave as though there was always an inversion.\r\n\r\n(Also, while I might have used a ternary to fix this, the way I did it seemed most consistent with grbl style.  Please advise if you'd rather a ternary - easy fix.)","created_at":"2018-08-10T13:59:32Z","updated_at":"2018-08-10T16:52:49Z","closed_at":"2018-08-10T16:52:49Z","merged_at":"2018-08-10T16:52:49Z","merge_commit_sha":"a311e2dc6ab5724c8e99b25dd9b5e9a1190ceb5f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gnea/grbl-Mega/pulls/68/commits","review_comments_url":"https://api.github.com/repos/gnea/grbl-Mega/pulls/68/comments","review_comment_url":"https://api.github.com/repos/gnea/grbl-Mega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gnea/grbl-Mega/issues/68/comments","statuses_url":"https://api.github.com/repos/gnea/grbl-Mega/statuses/68d91522c67358be9eb0dfef4d688cedee38d9df","head":{"label":"bgort:gremlinfix","ref":"gremlinfix","sha":"68d91522c67358be9eb0dfef4d688cedee38d9df","user":{"login":"bgort","id":8062568,"node_id":"MDQ6VXNlcjgwNjI1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/8062568?v=4","gravatar_id":"","url":"https://api.github.com/users/bgort","html_url":"https://github.com/bgort","followers_url":"https://api.github.com/users/bgort/followers","following_url":"https://api.github.com/users/bgort/following{/other_user}","gists_url":"https://api.github.com/users/bgort/gists{/gist_id}","starred_url":"https://api.github.com/users/bgort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgort/subscriptions","organizations_url":"https://api.github.com/users/bgort/orgs","repos_url":"https://api.github.com/users/bgort/repos","events_url":"https://api.github.com/users/bgort/events{/privacy}","received_events_url":"https://api.github.com/users/bgort/received_events","type":"User","site_admin":false},"repo":{"id":144289719,"node_id":"MDEwOlJlcG9zaXRvcnkxNDQyODk3MTk=","name":"grbl-Mega","full_name":"bgort/grbl-Mega","owner":{"login":"bgort","id":8062568,"node_id":"MDQ6VXNlcjgwNjI1Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/8062568?v=4","gravatar_id":"","url":"https://api.github.com/users/bgort","html_url":"https://github.com/bgort","followers_url":"https://api.github.com/users/bgort/followers","following_url":"https://api.github.com/users/bgort/following{/other_user}","gists_url":"https://api.github.com/users/bgort/gists{/gist_id}","starred_url":"https://api.github.com/users/bgort/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bgort/subscriptions","organizations_url":"https://api.github.com/users/bgort/orgs","repos_url":"https://api.github.com/users/bgort/repos","events_url":"https://api.github.com/users/bgort/events{/privacy}","received_events_url":"https://api.github.com/users/bgort/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bgort/grbl-Mega","description":"An open source, embedded, high performance g-code-parser and CNC milling controller written in optimized C that will run on an Arduino Mega2560","fork":true,"url":"https://api.github.com/repos/bgort/grbl-Mega","forks_url":"https://api.github.com/repos/bgort/grbl-Mega/forks","keys_url":"https://api.github.com/repos/bgort/grbl-Mega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bgort/grbl-Mega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bgort/grbl-Mega/teams","hooks_url":"https://api.github.com/repos/bgort/grbl-Mega/hooks","issue_events_url":"https://api.github.com/repos/bgort/grbl-Mega/issues/events{/number}","events_url":"https://api.github.com/repos/bgort/grbl-Mega/events","assignees_url":"https://api.github.com/repos/bgort/grbl-Mega/assignees{/user}","branches_url":"https://api.github.com/repos/bgort/grbl-Mega/branches{/branch}","tags_url":"https://api.github.com/repos/bgort/grbl-Mega/tags","blobs_url":"https://api.github.com/repos/bgort/grbl-Mega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bgort/grbl-Mega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bgort/grbl-Mega/git/refs{/sha}","trees_url":"https://api.github.com/repos/bgort/grbl-Mega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bgort/grbl-Mega/statuses/{sha}","languages_url":"https://api.github.com/repos/bgort/grbl-Mega/languages","stargazers_url":"https://api.github.com/repos/bgort/grbl-Mega/stargazers","contributors_url":"https://api.github.com/repos/bgort/grbl-Mega/contributors","subscribers_url":"https://api.github.com/repos/bgort/grbl-Mega/subscribers","subscription_url":"https://api.github.com/repos/bgort/grbl-Mega/subscription","commits_url":"https://api.github.com/repos/bgort/grbl-Mega/commits{/sha}","git_commits_url":"https://api.github.com/repos/bgort/grbl-Mega/git/commits{/sha}","comments_url":"https://api.github.com/repos/bgort/grbl-Mega/comments{/number}","issue_comment_url":"https://api.github.com/repos/bgort/grbl-Mega/issues/comments{/number}","contents_url":"https://api.github.com/repos/bgort/grbl-Mega/contents/{+path}","compare_url":"https://api.github.com/repos/bgort/grbl-Mega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bgort/grbl-Mega/merges","archive_url":"https://api.github.com/repos/bgort/grbl-Mega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bgort/grbl-Mega/downloads","issues_url":"https://api.github.com/repos/bgort/grbl-Mega/issues{/number}","pulls_url":"https://api.github.com/repos/bgort/grbl-Mega/pulls{/number}","milestones_url":"https://api.github.com/repos/bgort/grbl-Mega/milestones{/number}","notifications_url":"https://api.github.com/repos/bgort/grbl-Mega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bgort/grbl-Mega/labels{/name}","releases_url":"https://api.github.com/repos/bgort/grbl-Mega/releases{/id}","deployments_url":"https://api.github.com/repos/bgort/grbl-Mega/deployments","created_at":"2018-08-10T13:29:40Z","updated_at":"2018-08-10T13:29:42Z","pushed_at":"2018-08-10T13:47:47Z","git_url":"git://github.com/bgort/grbl-Mega.git","ssh_url":"git@github.com:bgort/grbl-Mega.git","clone_url":"https://github.com/bgort/grbl-Mega.git","svn_url":"https://github.com/bgort/grbl-Mega","homepage":"https://github.com/gnea/grbl/wiki","size":2629,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"edge"}},"base":{"label":"gnea:edge","ref":"edge","sha":"40fd602e0046628d02c65454e2202008f4b0f745","user":{"login":"gnea","id":3977670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzc2NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/3977670?v=4","gravatar_id":"","url":"https://api.github.com/users/gnea","html_url":"https://github.com/gnea","followers_url":"https://api.github.com/users/gnea/followers","following_url":"https://api.github.com/users/gnea/following{/other_user}","gists_url":"https://api.github.com/users/gnea/gists{/gist_id}","starred_url":"https://api.github.com/users/gnea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnea/subscriptions","organizations_url":"https://api.github.com/users/gnea/orgs","repos_url":"https://api.github.com/users/gnea/repos","events_url":"https://api.github.com/users/gnea/events{/privacy}","received_events_url":"https://api.github.com/users/gnea/received_events","type":"Organization","site_admin":false},"repo":{"id":54281743,"node_id":"MDEwOlJlcG9zaXRvcnk1NDI4MTc0Mw==","name":"grbl-Mega","full_name":"gnea/grbl-Mega","owner":{"login":"gnea","id":3977670,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5Nzc2NzA=","avatar_url":"https://avatars2.githubusercontent.com/u/3977670?v=4","gravatar_id":"","url":"https://api.github.com/users/gnea","html_url":"https://github.com/gnea","followers_url":"https://api.github.com/users/gnea/followers","following_url":"https://api.github.com/users/gnea/following{/other_user}","gists_url":"https://api.github.com/users/gnea/gists{/gist_id}","starred_url":"https://api.github.com/users/gnea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gnea/subscriptions","organizations_url":"https://api.github.com/users/gnea/orgs","repos_url":"https://api.github.com/users/gnea/repos","events_url":"https://api.github.com/users/gnea/events{/privacy}","received_events_url":"https://api.github.com/users/gnea/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gnea/grbl-Mega","description":"An open source, embedded, high performance g-code-parser and CNC milling controller written in optimized C that will run on an Arduino Mega2560","fork":true,"url":"https://api.github.com/repos/gnea/grbl-Mega","forks_url":"https://api.github.com/repos/gnea/grbl-Mega/forks","keys_url":"https://api.github.com/repos/gnea/grbl-Mega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gnea/grbl-Mega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gnea/grbl-Mega/teams","hooks_url":"https://api.github.com/repos/gnea/grbl-Mega/hooks","issue_events_url":"https://api.github.com/repos/gnea/grbl-Mega/issues/events{/number}","events_url":"https://api.github.com/repos/gnea/grbl-Mega/events","assignees_url":"https://api.github.com/repos/gnea/grbl-Mega/assignees{/user}","branches_url":"https://api.github.com/repos/gnea/grbl-Mega/branches{/branch}","tags_url":"https://api.github.com/repos/gnea/grbl-Mega/tags","blobs_url":"https://api.github.com/repos/gnea/grbl-Mega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gnea/grbl-Mega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gnea/grbl-Mega/git/refs{/sha}","trees_url":"https://api.github.com/repos/gnea/grbl-Mega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gnea/grbl-Mega/statuses/{sha}","languages_url":"https://api.github.com/repos/gnea/grbl-Mega/languages","stargazers_url":"https://api.github.com/repos/gnea/grbl-Mega/stargazers","contributors_url":"https://api.github.com/repos/gnea/grbl-Mega/contributors","subscribers_url":"https://api.github.com/repos/gnea/grbl-Mega/subscribers","subscription_url":"https://api.github.com/repos/gnea/grbl-Mega/subscription","commits_url":"https://api.github.com/repos/gnea/grbl-Mega/commits{/sha}","git_commits_url":"https://api.github.com/repos/gnea/grbl-Mega/git/commits{/sha}","comments_url":"https://api.github.com/repos/gnea/grbl-Mega/comments{/number}","issue_comment_url":"https://api.github.com/repos/gnea/grbl-Mega/issues/comments{/number}","contents_url":"https://api.github.com/repos/gnea/grbl-Mega/contents/{+path}","compare_url":"https://api.github.com/repos/gnea/grbl-Mega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gnea/grbl-Mega/merges","archive_url":"https://api.github.com/repos/gnea/grbl-Mega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gnea/grbl-Mega/downloads","issues_url":"https://api.github.com/repos/gnea/grbl-Mega/issues{/number}","pulls_url":"https://api.github.com/repos/gnea/grbl-Mega/pulls{/number}","milestones_url":"https://api.github.com/repos/gnea/grbl-Mega/milestones{/number}","notifications_url":"https://api.github.com/repos/gnea/grbl-Mega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gnea/grbl-Mega/labels{/name}","releases_url":"https://api.github.com/repos/gnea/grbl-Mega/releases{/id}","deployments_url":"https://api.github.com/repos/gnea/grbl-Mega/deployments","created_at":"2016-03-19T18:45:50Z","updated_at":"2018-07-31T03:19:06Z","pushed_at":"2018-08-10T16:52:49Z","git_url":"git://github.com/gnea/grbl-Mega.git","ssh_url":"git@github.com:gnea/grbl-Mega.git","clone_url":"https://github.com/gnea/grbl-Mega.git","svn_url":"https://github.com/gnea/grbl-Mega","homepage":"https://github.com/gnea/grbl/wiki","size":2615,"stargazers_count":152,"watchers_count":152,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":91,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":91,"open_issues":23,"watchers":152,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/gnea/grbl-Mega/pulls/68"},"html":{"href":"https://github.com/gnea/grbl-Mega/pull/68"},"issue":{"href":"https://api.github.com/repos/gnea/grbl-Mega/issues/68"},"comments":{"href":"https://api.github.com/repos/gnea/grbl-Mega/issues/68/comments"},"review_comments":{"href":"https://api.github.com/repos/gnea/grbl-Mega/pulls/68/comments"},"review_comment":{"href":"https://api.github.com/repos/gnea/grbl-Mega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gnea/grbl-Mega/pulls/68/commits"},"statuses":{"href":"https://api.github.com/repos/gnea/grbl-Mega/statuses/68d91522c67358be9eb0dfef4d688cedee38d9df"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"chamnit","id":948029,"node_id":"MDQ6VXNlcjk0ODAyOQ==","avatar_url":"https://avatars2.githubusercontent.com/u/948029?v=4","gravatar_id":"","url":"https://api.github.com/users/chamnit","html_url":"https://github.com/chamnit","followers_url":"https://api.github.com/users/chamnit/followers","following_url":"https://api.github.com/users/chamnit/following{/other_user}","gists_url":"https://api.github.com/users/chamnit/gists{/gist_id}","starred_url":"https://api.github.com/users/chamnit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/chamnit/subscriptions","organizations_url":"https://api.github.com/users/chamnit/orgs","repos_url":"https://api.github.com/users/chamnit/repos","events_url":"https://api.github.com/users/chamnit/events{/privacy}","received_events_url":"https://api.github.com/users/chamnit/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":3,"deletions":0,"changed_files":1}}
{"actor":{"display_login":"chamnit"}}