{"action":"created","comment":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/192298354","pull_request_review_id":125047119,"id":192298354,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjI5ODM1NA==","diff_hunk":"@@ -44,11 +44,15 @@\n     </ProjectReference>\n     <ProjectReference Include=\"..\\..\\..\\Externals\\picojson\\picojson.vcxproj\">\n       <Project>{2c0d058e-de35-4471-ad99-e68a2caf9e18}</Project>\n+    </ProjectReference>\n+\t<ProjectReference Include=\"$(ExternalsDir)discord-rpc\\src\\discord-rpc.vcxproj\">","path":"Source/Core/UICommon/UICommon.vcxproj","position":5,"original_position":5,"commit_id":"75c987a5361d808c97d5b8c5555e1cd1d23339d0","original_commit_id":"75c987a5361d808c97d5b8c5555e1cd1d23339d0","user":{"login":"lioncash","id":712067,"node_id":"MDQ6VXNlcjcxMjA2Nw==","avatar_url":"https://avatars1.githubusercontent.com/u/712067?v=4","gravatar_id":"","url":"https://api.github.com/users/lioncash","html_url":"https://github.com/lioncash","followers_url":"https://api.github.com/users/lioncash/followers","following_url":"https://api.github.com/users/lioncash/following{/other_user}","gists_url":"https://api.github.com/users/lioncash/gists{/gist_id}","starred_url":"https://api.github.com/users/lioncash/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lioncash/subscriptions","organizations_url":"https://api.github.com/users/lioncash/orgs","repos_url":"https://api.github.com/users/lioncash/repos","events_url":"https://api.github.com/users/lioncash/events{/privacy}","received_events_url":"https://api.github.com/users/lioncash/received_events","type":"User","site_admin":false},"body":"This should be using spaces, not tabs","created_at":"2018-06-01T04:59:07Z","updated_at":"2018-06-01T04:59:53Z","html_url":"https://github.com/dolphin-emu/dolphin/pull/6983#discussion_r192298354","pull_request_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6983","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments/192298354"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/6983#discussion_r192298354"},"pull_request":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6983"}}},"pull_request":{"url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6983","id":190773315,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNzczMzE1","html_url":"https://github.com/dolphin-emu/dolphin/pull/6983","diff_url":"https://github.com/dolphin-emu/dolphin/pull/6983.diff","patch_url":"https://github.com/dolphin-emu/dolphin/pull/6983.patch","issue_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6983","number":6983,"state":"open","locked":false,"title":"Add Discord Rich Presence support","user":{"login":"yourWaifu","id":16181109,"node_id":"MDQ6VXNlcjE2MTgxMTA5","avatar_url":"https://avatars1.githubusercontent.com/u/16181109?v=4","gravatar_id":"","url":"https://api.github.com/users/yourWaifu","html_url":"https://github.com/yourWaifu","followers_url":"https://api.github.com/users/yourWaifu/followers","following_url":"https://api.github.com/users/yourWaifu/following{/other_user}","gists_url":"https://api.github.com/users/yourWaifu/gists{/gist_id}","starred_url":"https://api.github.com/users/yourWaifu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yourWaifu/subscriptions","organizations_url":"https://api.github.com/users/yourWaifu/orgs","repos_url":"https://api.github.com/users/yourWaifu/repos","events_url":"https://api.github.com/users/yourWaifu/events{/privacy}","received_events_url":"https://api.github.com/users/yourWaifu/received_events","type":"User","site_admin":false},"body":"I thought Discord's Rich Presence would be a nice feature to add to Dolphin.\r\n\r\nA few things though.\r\n * I didn't know where to place the code for this, so I placed both DiscordPresence.h and DiscordPresence.cpp in Source/Core/Core. If this is an issue, it shouldn't be too difficult to move the two files somewhere else.\r\n * I also only have a computer running on Windows, so I havn't tested this on macOS or Linux nor do I know how to write code for them. I was wondering if I should place ``#ifdef``s around the code because of this, but I didn't want to in the case that they did work on macOS.","created_at":"2018-05-27T06:46:31Z","updated_at":"2018-06-01T04:59:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3a56c521aaead80154503a7843bdf33cb5df2ea7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6983/commits","review_comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6983/comments","review_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6983/comments","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/75c987a5361d808c97d5b8c5555e1cd1d23339d0","head":{"label":"yourWaifu:add-discord-rpc-support","ref":"add-discord-rpc-support","sha":"75c987a5361d808c97d5b8c5555e1cd1d23339d0","user":{"login":"yourWaifu","id":16181109,"node_id":"MDQ6VXNlcjE2MTgxMTA5","avatar_url":"https://avatars1.githubusercontent.com/u/16181109?v=4","gravatar_id":"","url":"https://api.github.com/users/yourWaifu","html_url":"https://github.com/yourWaifu","followers_url":"https://api.github.com/users/yourWaifu/followers","following_url":"https://api.github.com/users/yourWaifu/following{/other_user}","gists_url":"https://api.github.com/users/yourWaifu/gists{/gist_id}","starred_url":"https://api.github.com/users/yourWaifu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yourWaifu/subscriptions","organizations_url":"https://api.github.com/users/yourWaifu/orgs","repos_url":"https://api.github.com/users/yourWaifu/repos","events_url":"https://api.github.com/users/yourWaifu/events{/privacy}","received_events_url":"https://api.github.com/users/yourWaifu/received_events","type":"User","site_admin":false},"repo":{"id":135013098,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUwMTMwOTg=","name":"dolphin","full_name":"yourWaifu/dolphin","owner":{"login":"yourWaifu","id":16181109,"node_id":"MDQ6VXNlcjE2MTgxMTA5","avatar_url":"https://avatars1.githubusercontent.com/u/16181109?v=4","gravatar_id":"","url":"https://api.github.com/users/yourWaifu","html_url":"https://github.com/yourWaifu","followers_url":"https://api.github.com/users/yourWaifu/followers","following_url":"https://api.github.com/users/yourWaifu/following{/other_user}","gists_url":"https://api.github.com/users/yourWaifu/gists{/gist_id}","starred_url":"https://api.github.com/users/yourWaifu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yourWaifu/subscriptions","organizations_url":"https://api.github.com/users/yourWaifu/orgs","repos_url":"https://api.github.com/users/yourWaifu/repos","events_url":"https://api.github.com/users/yourWaifu/events{/privacy}","received_events_url":"https://api.github.com/users/yourWaifu/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yourWaifu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":true,"url":"https://api.github.com/repos/yourWaifu/dolphin","forks_url":"https://api.github.com/repos/yourWaifu/dolphin/forks","keys_url":"https://api.github.com/repos/yourWaifu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yourWaifu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yourWaifu/dolphin/teams","hooks_url":"https://api.github.com/repos/yourWaifu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/yourWaifu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/yourWaifu/dolphin/events","assignees_url":"https://api.github.com/repos/yourWaifu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/yourWaifu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/yourWaifu/dolphin/tags","blobs_url":"https://api.github.com/repos/yourWaifu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yourWaifu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yourWaifu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/yourWaifu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yourWaifu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/yourWaifu/dolphin/languages","stargazers_url":"https://api.github.com/repos/yourWaifu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/yourWaifu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/yourWaifu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/yourWaifu/dolphin/subscription","commits_url":"https://api.github.com/repos/yourWaifu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/yourWaifu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/yourWaifu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/yourWaifu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/yourWaifu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/yourWaifu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yourWaifu/dolphin/merges","archive_url":"https://api.github.com/repos/yourWaifu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yourWaifu/dolphin/downloads","issues_url":"https://api.github.com/repos/yourWaifu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/yourWaifu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/yourWaifu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/yourWaifu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yourWaifu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/yourWaifu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/yourWaifu/dolphin/deployments","created_at":"2018-05-27T03:38:10Z","updated_at":"2018-05-27T03:38:33Z","pushed_at":"2018-06-01T03:13:26Z","git_url":"git://github.com/yourWaifu/dolphin.git","ssh_url":"git@github.com:yourWaifu/dolphin.git","clone_url":"https://github.com/yourWaifu/dolphin.git","svn_url":"https://github.com/yourWaifu/dolphin","homepage":"https://dolphin-emu.org/","size":324853,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dolphin-emu:master","ref":"master","sha":"7b07424885fa2a71f8a08e1d86e7fb65dfb815be","user":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"repo":{"id":11577304,"node_id":"MDEwOlJlcG9zaXRvcnkxMTU3NzMwNA==","name":"dolphin","full_name":"dolphin-emu/dolphin","owner":{"login":"dolphin-emu","id":5050316,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUwNTAzMTY=","avatar_url":"https://avatars2.githubusercontent.com/u/5050316?v=4","gravatar_id":"","url":"https://api.github.com/users/dolphin-emu","html_url":"https://github.com/dolphin-emu","followers_url":"https://api.github.com/users/dolphin-emu/followers","following_url":"https://api.github.com/users/dolphin-emu/following{/other_user}","gists_url":"https://api.github.com/users/dolphin-emu/gists{/gist_id}","starred_url":"https://api.github.com/users/dolphin-emu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dolphin-emu/subscriptions","organizations_url":"https://api.github.com/users/dolphin-emu/orgs","repos_url":"https://api.github.com/users/dolphin-emu/repos","events_url":"https://api.github.com/users/dolphin-emu/events{/privacy}","received_events_url":"https://api.github.com/users/dolphin-emu/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dolphin-emu/dolphin","description":"Dolphin is a GameCube / Wii emulator, allowing you to play games for these two platforms on PC with improvements.","fork":false,"url":"https://api.github.com/repos/dolphin-emu/dolphin","forks_url":"https://api.github.com/repos/dolphin-emu/dolphin/forks","keys_url":"https://api.github.com/repos/dolphin-emu/dolphin/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dolphin-emu/dolphin/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dolphin-emu/dolphin/teams","hooks_url":"https://api.github.com/repos/dolphin-emu/dolphin/hooks","issue_events_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/events{/number}","events_url":"https://api.github.com/repos/dolphin-emu/dolphin/events","assignees_url":"https://api.github.com/repos/dolphin-emu/dolphin/assignees{/user}","branches_url":"https://api.github.com/repos/dolphin-emu/dolphin/branches{/branch}","tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/tags","blobs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/refs{/sha}","trees_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/{sha}","languages_url":"https://api.github.com/repos/dolphin-emu/dolphin/languages","stargazers_url":"https://api.github.com/repos/dolphin-emu/dolphin/stargazers","contributors_url":"https://api.github.com/repos/dolphin-emu/dolphin/contributors","subscribers_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscribers","subscription_url":"https://api.github.com/repos/dolphin-emu/dolphin/subscription","commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/commits{/sha}","git_commits_url":"https://api.github.com/repos/dolphin-emu/dolphin/git/commits{/sha}","comments_url":"https://api.github.com/repos/dolphin-emu/dolphin/comments{/number}","issue_comment_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues/comments{/number}","contents_url":"https://api.github.com/repos/dolphin-emu/dolphin/contents/{+path}","compare_url":"https://api.github.com/repos/dolphin-emu/dolphin/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dolphin-emu/dolphin/merges","archive_url":"https://api.github.com/repos/dolphin-emu/dolphin/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dolphin-emu/dolphin/downloads","issues_url":"https://api.github.com/repos/dolphin-emu/dolphin/issues{/number}","pulls_url":"https://api.github.com/repos/dolphin-emu/dolphin/pulls{/number}","milestones_url":"https://api.github.com/repos/dolphin-emu/dolphin/milestones{/number}","notifications_url":"https://api.github.com/repos/dolphin-emu/dolphin/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dolphin-emu/dolphin/labels{/name}","releases_url":"https://api.github.com/repos/dolphin-emu/dolphin/releases{/id}","deployments_url":"https://api.github.com/repos/dolphin-emu/dolphin/deployments","created_at":"2013-07-22T09:07:57Z","updated_at":"2018-05-31T16:06:07Z","pushed_at":"2018-06-01T03:13:28Z","git_url":"git://github.com/dolphin-emu/dolphin.git","ssh_url":"git@github.com:dolphin-emu/dolphin.git","clone_url":"https://github.com/dolphin-emu/dolphin.git","svn_url":"https://github.com/dolphin-emu/dolphin","homepage":"https://dolphin-emu.org/","size":362683,"stargazers_count":4399,"watchers_count":4399,"language":"C++","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1054,"mirror_url":null,"archived":false,"open_issues_count":109,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":1054,"open_issues":109,"watchers":4399,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6983"},"html":{"href":"https://github.com/dolphin-emu/dolphin/pull/6983"},"issue":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6983"},"comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/issues/6983/comments"},"review_comments":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6983/comments"},"review_comment":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/pulls/6983/commits"},"statuses":{"href":"https://api.github.com/repos/dolphin-emu/dolphin/statuses/75c987a5361d808c97d5b8c5555e1cd1d23339d0"}},"author_association":"NONE"}}
{"actor":{"display_login":"lioncash"}}