{"action":"closed","number":380,"pull_request":{"url":"https://api.github.com/repos/ArkEcosystem/explorer/pulls/380","id":217972356,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE3OTcyMzU2","html_url":"https://github.com/ArkEcosystem/explorer/pull/380","diff_url":"https://github.com/ArkEcosystem/explorer/pull/380.diff","patch_url":"https://github.com/ArkEcosystem/explorer/pull/380.patch","issue_url":"https://api.github.com/repos/ArkEcosystem/explorer/issues/380","number":380,"state":"closed","locked":false,"title":"fix: margins in delegate component","user":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"body":"## Proposed changes\r\n<!--\r\nDescribe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.\r\n-->\r\n\r\nThe conditional margin classes did not cover correctly the case in which a delegate had missed blocks but no forged ones yet.\r\n\r\n## Types of changes\r\n<!--\r\nWhat types of changes does your code introduce?\r\n_Put an `x` in the boxes that apply and remove the rest of them: keep this PR as concise, but descriptive, as possible.._\r\n-->\r\n\r\n- [x] Bugfix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [x] Refactoring (improve a current implementation without adding a new feature or fixing a bug)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)\r\n- [ ] Build (changes that affect the build system)\r\n- [ ] Docs (documentation only changes)\r\n- [ ] Test (adding missing tests or fixing existing tests)\r\n- [ ] Other... Please describe:\r\n\r\n## Checklist\r\n<!--\r\n_Put an `x` in the boxes that apply and remove this text and the rest of them. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code._\r\n-->\r\n\r\n- [x] I have read the [CONTRIBUTING](https://docs.ark.io/developers/guidelines/contributing.html) documentation\r\n- [x] Lint and unit tests pass locally with my changes\r\n- [ ] I have added tests that prove my fix is effective or that my feature works\r\n- [ ] I have added necessary documentation (if appropriate)\r\n\r\n## Further comments\r\n\r\nIntegration tests will possibly fail at the current state of the network, as they depend on blocks not getting missed.\r\n\r\n<!--\r\nIf this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...\r\n-->\r\n","created_at":"2018-09-25T13:04:12Z","updated_at":"2018-09-26T04:36:11Z","closed_at":"2018-09-26T04:36:11Z","merged_at":"2018-09-26T04:36:11Z","merge_commit_sha":"3c895ff256f4f0993becd57391c7a61afc357ba8","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ArkEcosystem/explorer/pulls/380/commits","review_comments_url":"https://api.github.com/repos/ArkEcosystem/explorer/pulls/380/comments","review_comment_url":"https://api.github.com/repos/ArkEcosystem/explorer/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArkEcosystem/explorer/issues/380/comments","statuses_url":"https://api.github.com/repos/ArkEcosystem/explorer/statuses/b014fb8401171bddee2e4a0bf7cb405eb104f5e1","head":{"label":"dated:delegate-margins","ref":"delegate-margins","sha":"b014fb8401171bddee2e4a0bf7cb405eb104f5e1","user":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"repo":{"id":139132990,"node_id":"MDEwOlJlcG9zaXRvcnkxMzkxMzI5OTA=","name":"ark-explorer","full_name":"dated/ark-explorer","private":false,"owner":{"login":"dated","id":6547002,"node_id":"MDQ6VXNlcjY1NDcwMDI=","avatar_url":"https://avatars1.githubusercontent.com/u/6547002?v=4","gravatar_id":"","url":"https://api.github.com/users/dated","html_url":"https://github.com/dated","followers_url":"https://api.github.com/users/dated/followers","following_url":"https://api.github.com/users/dated/following{/other_user}","gists_url":"https://api.github.com/users/dated/gists{/gist_id}","starred_url":"https://api.github.com/users/dated/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dated/subscriptions","organizations_url":"https://api.github.com/users/dated/orgs","repos_url":"https://api.github.com/users/dated/repos","events_url":"https://api.github.com/users/dated/events{/privacy}","received_events_url":"https://api.github.com/users/dated/received_events","type":"User","site_admin":false},"html_url":"https://github.com/dated/ark-explorer","description":"A Blockchain Explorer for ARK using Vue.js and Tailwind CSS.","fork":true,"url":"https://api.github.com/repos/dated/ark-explorer","forks_url":"https://api.github.com/repos/dated/ark-explorer/forks","keys_url":"https://api.github.com/repos/dated/ark-explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dated/ark-explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dated/ark-explorer/teams","hooks_url":"https://api.github.com/repos/dated/ark-explorer/hooks","issue_events_url":"https://api.github.com/repos/dated/ark-explorer/issues/events{/number}","events_url":"https://api.github.com/repos/dated/ark-explorer/events","assignees_url":"https://api.github.com/repos/dated/ark-explorer/assignees{/user}","branches_url":"https://api.github.com/repos/dated/ark-explorer/branches{/branch}","tags_url":"https://api.github.com/repos/dated/ark-explorer/tags","blobs_url":"https://api.github.com/repos/dated/ark-explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dated/ark-explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dated/ark-explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/dated/ark-explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dated/ark-explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/dated/ark-explorer/languages","stargazers_url":"https://api.github.com/repos/dated/ark-explorer/stargazers","contributors_url":"https://api.github.com/repos/dated/ark-explorer/contributors","subscribers_url":"https://api.github.com/repos/dated/ark-explorer/subscribers","subscription_url":"https://api.github.com/repos/dated/ark-explorer/subscription","commits_url":"https://api.github.com/repos/dated/ark-explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/dated/ark-explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/dated/ark-explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/dated/ark-explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/dated/ark-explorer/contents/{+path}","compare_url":"https://api.github.com/repos/dated/ark-explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dated/ark-explorer/merges","archive_url":"https://api.github.com/repos/dated/ark-explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dated/ark-explorer/downloads","issues_url":"https://api.github.com/repos/dated/ark-explorer/issues{/number}","pulls_url":"https://api.github.com/repos/dated/ark-explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/dated/ark-explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/dated/ark-explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dated/ark-explorer/labels{/name}","releases_url":"https://api.github.com/repos/dated/ark-explorer/releases{/id}","deployments_url":"https://api.github.com/repos/dated/ark-explorer/deployments","created_at":"2018-06-29T09:56:30Z","updated_at":"2018-09-22T09:22:11Z","pushed_at":"2018-09-26T04:27:13Z","git_url":"git://github.com/dated/ark-explorer.git","ssh_url":"git@github.com:dated/ark-explorer.git","clone_url":"https://github.com/dated/ark-explorer.git","svn_url":"https://github.com/dated/ark-explorer","homepage":"https://explorer.ark.io/","size":8750,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ArkEcosystem:master","ref":"master","sha":"bf85dcf9d7901d4556e06c27eb0d57f0334fc2cf","user":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"repo":{"id":105805172,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU4MDUxNzI=","name":"explorer","full_name":"ArkEcosystem/explorer","private":false,"owner":{"login":"ArkEcosystem","id":22457396,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNDU3Mzk2","avatar_url":"https://avatars3.githubusercontent.com/u/22457396?v=4","gravatar_id":"","url":"https://api.github.com/users/ArkEcosystem","html_url":"https://github.com/ArkEcosystem","followers_url":"https://api.github.com/users/ArkEcosystem/followers","following_url":"https://api.github.com/users/ArkEcosystem/following{/other_user}","gists_url":"https://api.github.com/users/ArkEcosystem/gists{/gist_id}","starred_url":"https://api.github.com/users/ArkEcosystem/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArkEcosystem/subscriptions","organizations_url":"https://api.github.com/users/ArkEcosystem/orgs","repos_url":"https://api.github.com/users/ArkEcosystem/repos","events_url":"https://api.github.com/users/ArkEcosystem/events{/privacy}","received_events_url":"https://api.github.com/users/ArkEcosystem/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArkEcosystem/explorer","description":"A Blockchain Explorer for ARK using Vue.js and Tailwind CSS.","fork":false,"url":"https://api.github.com/repos/ArkEcosystem/explorer","forks_url":"https://api.github.com/repos/ArkEcosystem/explorer/forks","keys_url":"https://api.github.com/repos/ArkEcosystem/explorer/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArkEcosystem/explorer/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArkEcosystem/explorer/teams","hooks_url":"https://api.github.com/repos/ArkEcosystem/explorer/hooks","issue_events_url":"https://api.github.com/repos/ArkEcosystem/explorer/issues/events{/number}","events_url":"https://api.github.com/repos/ArkEcosystem/explorer/events","assignees_url":"https://api.github.com/repos/ArkEcosystem/explorer/assignees{/user}","branches_url":"https://api.github.com/repos/ArkEcosystem/explorer/branches{/branch}","tags_url":"https://api.github.com/repos/ArkEcosystem/explorer/tags","blobs_url":"https://api.github.com/repos/ArkEcosystem/explorer/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArkEcosystem/explorer/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArkEcosystem/explorer/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArkEcosystem/explorer/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArkEcosystem/explorer/statuses/{sha}","languages_url":"https://api.github.com/repos/ArkEcosystem/explorer/languages","stargazers_url":"https://api.github.com/repos/ArkEcosystem/explorer/stargazers","contributors_url":"https://api.github.com/repos/ArkEcosystem/explorer/contributors","subscribers_url":"https://api.github.com/repos/ArkEcosystem/explorer/subscribers","subscription_url":"https://api.github.com/repos/ArkEcosystem/explorer/subscription","commits_url":"https://api.github.com/repos/ArkEcosystem/explorer/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArkEcosystem/explorer/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArkEcosystem/explorer/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArkEcosystem/explorer/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArkEcosystem/explorer/contents/{+path}","compare_url":"https://api.github.com/repos/ArkEcosystem/explorer/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArkEcosystem/explorer/merges","archive_url":"https://api.github.com/repos/ArkEcosystem/explorer/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArkEcosystem/explorer/downloads","issues_url":"https://api.github.com/repos/ArkEcosystem/explorer/issues{/number}","pulls_url":"https://api.github.com/repos/ArkEcosystem/explorer/pulls{/number}","milestones_url":"https://api.github.com/repos/ArkEcosystem/explorer/milestones{/number}","notifications_url":"https://api.github.com/repos/ArkEcosystem/explorer/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArkEcosystem/explorer/labels{/name}","releases_url":"https://api.github.com/repos/ArkEcosystem/explorer/releases{/id}","deployments_url":"https://api.github.com/repos/ArkEcosystem/explorer/deployments","created_at":"2017-10-04T18:46:58Z","updated_at":"2018-09-26T04:27:07Z","pushed_at":"2018-09-26T04:36:11Z","git_url":"git://github.com/ArkEcosystem/explorer.git","ssh_url":"git@github.com:ArkEcosystem/explorer.git","clone_url":"https://github.com/ArkEcosystem/explorer.git","svn_url":"https://github.com/ArkEcosystem/explorer","homepage":"https://explorer.ark.io/","size":8739,"stargazers_count":38,"watchers_count":38,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":54,"mirror_url":null,"archived":false,"open_issues_count":14,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":54,"open_issues":14,"watchers":38,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArkEcosystem/explorer/pulls/380"},"html":{"href":"https://github.com/ArkEcosystem/explorer/pull/380"},"issue":{"href":"https://api.github.com/repos/ArkEcosystem/explorer/issues/380"},"comments":{"href":"https://api.github.com/repos/ArkEcosystem/explorer/issues/380/comments"},"review_comments":{"href":"https://api.github.com/repos/ArkEcosystem/explorer/pulls/380/comments"},"review_comment":{"href":"https://api.github.com/repos/ArkEcosystem/explorer/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArkEcosystem/explorer/pulls/380/commits"},"statuses":{"href":"https://api.github.com/repos/ArkEcosystem/explorer/statuses/b014fb8401171bddee2e4a0bf7cb405eb104f5e1"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"faustbrian","id":22145591,"node_id":"MDQ6VXNlcjIyMTQ1NTkx","avatar_url":"https://avatars3.githubusercontent.com/u/22145591?v=4","gravatar_id":"","url":"https://api.github.com/users/faustbrian","html_url":"https://github.com/faustbrian","followers_url":"https://api.github.com/users/faustbrian/followers","following_url":"https://api.github.com/users/faustbrian/following{/other_user}","gists_url":"https://api.github.com/users/faustbrian/gists{/gist_id}","starred_url":"https://api.github.com/users/faustbrian/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/faustbrian/subscriptions","organizations_url":"https://api.github.com/users/faustbrian/orgs","repos_url":"https://api.github.com/users/faustbrian/repos","events_url":"https://api.github.com/users/faustbrian/events{/privacy}","received_events_url":"https://api.github.com/users/faustbrian/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":3,"changed_files":1}}
{"actor":{"display_login":"faustbrian"}}