{"action":"created","comment":{"url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/comments/192658580","pull_request_review_id":125467560,"id":192658580,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjY1ODU4MA==","diff_hunk":"@@ -1387,4 +1388,8 @@ public static String formatTransactionStatus(Transaction tx) {\n \t\t}\r\n \t\treturn \"TX STATUS UNKNOWN\";\r\n \t}\r\n+\r\n+\tpublic static int daysBetween(Date old, Date later){\r\n+\t\treturn (int)( (later.getTime() - old.getTime()) / (1000 * 60 * 60 * 24));\r","path":"api/src/main/java/org/openmrs/module/sync/SyncUtil.java","position":14,"original_position":14,"commit_id":"415c6b060c8fd59bc4e2314a269e52641fcdc5ef","original_commit_id":"415c6b060c8fd59bc4e2314a269e52641fcdc5ef","user":{"login":"steliomo","id":404506,"node_id":"MDQ6VXNlcjQwNDUwNg==","avatar_url":"https://avatars0.githubusercontent.com/u/404506?v=4","gravatar_id":"","url":"https://api.github.com/users/steliomo","html_url":"https://github.com/steliomo","followers_url":"https://api.github.com/users/steliomo/followers","following_url":"https://api.github.com/users/steliomo/following{/other_user}","gists_url":"https://api.github.com/users/steliomo/gists{/gist_id}","starred_url":"https://api.github.com/users/steliomo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/steliomo/subscriptions","organizations_url":"https://api.github.com/users/steliomo/orgs","repos_url":"https://api.github.com/users/steliomo/repos","events_url":"https://api.github.com/users/steliomo/events{/privacy}","received_events_url":"https://api.github.com/users/steliomo/received_events","type":"User","site_admin":false},"body":"You could also convert (1000 * 60 * 60 * 24) to a method with a clear name.\r\nI know that it is converting a day right?","created_at":"2018-06-04T08:17:30Z","updated_at":"2018-06-04T09:01:45Z","html_url":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync/pull/1#discussion_r192658580","pull_request_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/1","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/comments/192658580"},"html":{"href":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync/pull/1#discussion_r192658580"},"pull_request":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/1"}}},"pull_request":{"url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/1","id":192284854,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkyMjg0ODU0","html_url":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync/pull/1","diff_url":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync/pull/1.diff","patch_url":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync/pull/1.patch","issue_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/issues/1","number":1,"state":"open","locked":false,"title":"FGHSYNC-2: Isolated connection errors from other type of errors.","user":{"login":"mhawila","id":5951420,"node_id":"MDQ6VXNlcjU5NTE0MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5951420?v=4","gravatar_id":"","url":"https://api.github.com/users/mhawila","html_url":"https://github.com/mhawila","followers_url":"https://api.github.com/users/mhawila/followers","following_url":"https://api.github.com/users/mhawila/following{/other_user}","gists_url":"https://api.github.com/users/mhawila/gists{/gist_id}","starred_url":"https://api.github.com/users/mhawila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhawila/subscriptions","organizations_url":"https://api.github.com/users/mhawila/orgs","repos_url":"https://api.github.com/users/mhawila/repos","events_url":"https://api.github.com/users/mhawila/events{/privacy}","received_events_url":"https://api.github.com/users/mhawila/received_events","type":"User","site_admin":false},"body":"Added a page displays transmission error history.\r\nAdded a task to remove old transmission error logs which is configurable via syn maintenance tab.","created_at":"2018-06-04T02:33:38Z","updated_at":"2018-06-04T09:01:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c173c6816626ba336b81ecb49055caa68e0d9b69","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/1/commits","review_comments_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/1/comments","review_comment_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/comments{/number}","comments_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/issues/1/comments","statuses_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/statuses/415c6b060c8fd59bc4e2314a269e52641fcdc5ef","head":{"label":"mhawila:SYNC-2","ref":"SYNC-2","sha":"415c6b060c8fd59bc4e2314a269e52641fcdc5ef","user":{"login":"mhawila","id":5951420,"node_id":"MDQ6VXNlcjU5NTE0MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5951420?v=4","gravatar_id":"","url":"https://api.github.com/users/mhawila","html_url":"https://github.com/mhawila","followers_url":"https://api.github.com/users/mhawila/followers","following_url":"https://api.github.com/users/mhawila/following{/other_user}","gists_url":"https://api.github.com/users/mhawila/gists{/gist_id}","starred_url":"https://api.github.com/users/mhawila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhawila/subscriptions","organizations_url":"https://api.github.com/users/mhawila/orgs","repos_url":"https://api.github.com/users/mhawila/repos","events_url":"https://api.github.com/users/mhawila/events{/privacy}","received_events_url":"https://api.github.com/users/mhawila/received_events","type":"User","site_admin":false},"repo":{"id":134726811,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3MjY4MTE=","name":"openmrs-module-sync","full_name":"mhawila/openmrs-module-sync","owner":{"login":"mhawila","id":5951420,"node_id":"MDQ6VXNlcjU5NTE0MjA=","avatar_url":"https://avatars2.githubusercontent.com/u/5951420?v=4","gravatar_id":"","url":"https://api.github.com/users/mhawila","html_url":"https://github.com/mhawila","followers_url":"https://api.github.com/users/mhawila/followers","following_url":"https://api.github.com/users/mhawila/following{/other_user}","gists_url":"https://api.github.com/users/mhawila/gists{/gist_id}","starred_url":"https://api.github.com/users/mhawila/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhawila/subscriptions","organizations_url":"https://api.github.com/users/mhawila/orgs","repos_url":"https://api.github.com/users/mhawila/repos","events_url":"https://api.github.com/users/mhawila/events{/privacy}","received_events_url":"https://api.github.com/users/mhawila/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mhawila/openmrs-module-sync","description":"Synchronizes data across multiple instances of OpenMRS","fork":true,"url":"https://api.github.com/repos/mhawila/openmrs-module-sync","forks_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/forks","keys_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/teams","hooks_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/hooks","issue_events_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/issues/events{/number}","events_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/events","assignees_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/assignees{/user}","branches_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/branches{/branch}","tags_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/tags","blobs_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/languages","stargazers_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/stargazers","contributors_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/contributors","subscribers_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/subscribers","subscription_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/subscription","commits_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/contents/{+path}","compare_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/merges","archive_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/downloads","issues_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/issues{/number}","pulls_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/labels{/name}","releases_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/releases{/id}","deployments_url":"https://api.github.com/repos/mhawila/openmrs-module-sync/deployments","created_at":"2018-05-24T14:26:49Z","updated_at":"2018-05-24T14:26:51Z","pushed_at":"2018-06-04T02:31:24Z","git_url":"git://github.com/mhawila/openmrs-module-sync.git","ssh_url":"git@github.com:mhawila/openmrs-module-sync.git","clone_url":"https://github.com/mhawila/openmrs-module-sync.git","svn_url":"https://github.com/mhawila/openmrs-module-sync","homepage":null,"size":27320,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"FriendsInGlobalHealth:master","ref":"master","sha":"27e78215e005e1eff0811735b3248f44343e0d93","user":{"login":"FriendsInGlobalHealth","id":18681227,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjgxMjI3","avatar_url":"https://avatars1.githubusercontent.com/u/18681227?v=4","gravatar_id":"","url":"https://api.github.com/users/FriendsInGlobalHealth","html_url":"https://github.com/FriendsInGlobalHealth","followers_url":"https://api.github.com/users/FriendsInGlobalHealth/followers","following_url":"https://api.github.com/users/FriendsInGlobalHealth/following{/other_user}","gists_url":"https://api.github.com/users/FriendsInGlobalHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsInGlobalHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsInGlobalHealth/subscriptions","organizations_url":"https://api.github.com/users/FriendsInGlobalHealth/orgs","repos_url":"https://api.github.com/users/FriendsInGlobalHealth/repos","events_url":"https://api.github.com/users/FriendsInGlobalHealth/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsInGlobalHealth/received_events","type":"Organization","site_admin":false},"repo":{"id":134726403,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3MjY0MDM=","name":"openmrs-module-sync","full_name":"FriendsInGlobalHealth/openmrs-module-sync","owner":{"login":"FriendsInGlobalHealth","id":18681227,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NjgxMjI3","avatar_url":"https://avatars1.githubusercontent.com/u/18681227?v=4","gravatar_id":"","url":"https://api.github.com/users/FriendsInGlobalHealth","html_url":"https://github.com/FriendsInGlobalHealth","followers_url":"https://api.github.com/users/FriendsInGlobalHealth/followers","following_url":"https://api.github.com/users/FriendsInGlobalHealth/following{/other_user}","gists_url":"https://api.github.com/users/FriendsInGlobalHealth/gists{/gist_id}","starred_url":"https://api.github.com/users/FriendsInGlobalHealth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FriendsInGlobalHealth/subscriptions","organizations_url":"https://api.github.com/users/FriendsInGlobalHealth/orgs","repos_url":"https://api.github.com/users/FriendsInGlobalHealth/repos","events_url":"https://api.github.com/users/FriendsInGlobalHealth/events{/privacy}","received_events_url":"https://api.github.com/users/FriendsInGlobalHealth/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync","description":"Synchronizes data across multiple instances of OpenMRS","fork":true,"url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync","forks_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/forks","keys_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/keys{/key_id}","collaborators_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/teams","hooks_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/hooks","issue_events_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/issues/events{/number}","events_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/events","assignees_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/assignees{/user}","branches_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/branches{/branch}","tags_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/tags","blobs_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/git/refs{/sha}","trees_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/git/trees{/sha}","statuses_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/statuses/{sha}","languages_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/languages","stargazers_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/stargazers","contributors_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/contributors","subscribers_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/subscribers","subscription_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/subscription","commits_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/commits{/sha}","git_commits_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/git/commits{/sha}","comments_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/comments{/number}","issue_comment_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/issues/comments{/number}","contents_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/contents/{+path}","compare_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/compare/{base}...{head}","merges_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/merges","archive_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/downloads","issues_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/issues{/number}","pulls_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls{/number}","milestones_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/milestones{/number}","notifications_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/labels{/name}","releases_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/releases{/id}","deployments_url":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/deployments","created_at":"2018-05-24T14:23:42Z","updated_at":"2018-05-24T14:23:44Z","pushed_at":"2018-06-04T02:33:38Z","git_url":"git://github.com/FriendsInGlobalHealth/openmrs-module-sync.git","ssh_url":"git@github.com:FriendsInGlobalHealth/openmrs-module-sync.git","clone_url":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync.git","svn_url":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync","homepage":null,"size":27272,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/1"},"html":{"href":"https://github.com/FriendsInGlobalHealth/openmrs-module-sync/pull/1"},"issue":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/issues/1"},"comments":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/issues/1/comments"},"review_comments":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/1/comments"},"review_comment":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/pulls/1/commits"},"statuses":{"href":"https://api.github.com/repos/FriendsInGlobalHealth/openmrs-module-sync/statuses/415c6b060c8fd59bc4e2314a269e52641fcdc5ef"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"steliomo"}}