{"action":"closed","number":7908,"pull_request":{"url":"https://api.github.com/repos/metabase/metabase/pulls/7908","id":196059017,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MDU5MDE3","html_url":"https://github.com/metabase/metabase/pull/7908","diff_url":"https://github.com/metabase/metabase/pull/7908.diff","patch_url":"https://github.com/metabase/metabase/pull/7908.patch","issue_url":"https://api.github.com/repos/metabase/metabase/issues/7908","number":7908,"state":"closed","locked":false,"title":"Save all x-ray questions into the same collection","user":{"login":"sbelak","id":178038,"node_id":"MDQ6VXNlcjE3ODAzOA==","avatar_url":"https://avatars2.githubusercontent.com/u/178038?v=4","gravatar_id":"","url":"https://api.github.com/users/sbelak","html_url":"https://github.com/sbelak","followers_url":"https://api.github.com/users/sbelak/followers","following_url":"https://api.github.com/users/sbelak/following{/other_user}","gists_url":"https://api.github.com/users/sbelak/gists{/gist_id}","starred_url":"https://api.github.com/users/sbelak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sbelak/subscriptions","organizations_url":"https://api.github.com/users/sbelak/orgs","repos_url":"https://api.github.com/users/sbelak/repos","events_url":"https://api.github.com/users/sbelak/events{/privacy}","received_events_url":"https://api.github.com/users/sbelak/received_events","type":"User","site_admin":false},"body":"Saves all x-ray questions into the same collection. \r\n\r\nNot sure what the correct behaviour is. Should we:\r\n1) create the collection upfront as admin; or\r\n2) create the collection on the first usage of xrays as current user at that time?\r\n\r\nShould we i18n the collection name? If so, what happens if different users have different language set?","created_at":"2018-06-20T08:29:16Z","updated_at":"2018-07-21T15:44:31Z","closed_at":"2018-07-21T15:44:31Z","merged_at":null,"merge_commit_sha":"d04ab40897ce3b8bede4c653089a4643cb5b2932","assignee":null,"assignees":[],"requested_reviewers":[{"login":"salsakran","id":107439,"node_id":"MDQ6VXNlcjEwNzQzOQ==","avatar_url":"https://avatars0.githubusercontent.com/u/107439?v=4","gravatar_id":"","url":"https://api.github.com/users/salsakran","html_url":"https://github.com/salsakran","followers_url":"https://api.github.com/users/salsakran/followers","following_url":"https://api.github.com/users/salsakran/following{/other_user}","gists_url":"https://api.github.com/users/salsakran/gists{/gist_id}","starred_url":"https://api.github.com/users/salsakran/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salsakran/subscriptions","organizations_url":"https://api.github.com/users/salsakran/orgs","repos_url":"https://api.github.com/users/salsakran/repos","events_url":"https://api.github.com/users/salsakran/events{/privacy}","received_events_url":"https://api.github.com/users/salsakran/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/metabase/metabase/pulls/7908/commits","review_comments_url":"https://api.github.com/repos/metabase/metabase/pulls/7908/comments","review_comment_url":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}","comments_url":"https://api.github.com/repos/metabase/metabase/issues/7908/comments","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/0ff42a69ac212f03314d710601aa8ad9b80779c6","head":{"label":"metabase:xray-all-questions-in-same-collection","ref":"xray-all-questions-in-same-collection","sha":"0ff42a69ac212f03314d710601aa8ad9b80779c6","user":{"login":"metabase","id":10520629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTIwNjI5","avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIwMzkzNQ==","name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTIwNjI5","avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2018-07-21T14:19:48Z","pushed_at":"2018-07-21T15:38:50Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"https://metabase.com","size":78647,"stargazers_count":10634,"watchers_count":10634,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1348,"mirror_url":null,"archived":false,"open_issues_count":1819,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1348,"open_issues":1819,"watchers":10634,"default_branch":"master"}},"base":{"label":"metabase:master","ref":"master","sha":"9ea31ab89198337941715896c629359ad1533462","user":{"login":"metabase","id":10520629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTIwNjI5","avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"repo":{"id":30203935,"node_id":"MDEwOlJlcG9zaXRvcnkzMDIwMzkzNQ==","name":"metabase","full_name":"metabase/metabase","owner":{"login":"metabase","id":10520629,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNTIwNjI5","avatar_url":"https://avatars1.githubusercontent.com/u/10520629?v=4","gravatar_id":"","url":"https://api.github.com/users/metabase","html_url":"https://github.com/metabase","followers_url":"https://api.github.com/users/metabase/followers","following_url":"https://api.github.com/users/metabase/following{/other_user}","gists_url":"https://api.github.com/users/metabase/gists{/gist_id}","starred_url":"https://api.github.com/users/metabase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/metabase/subscriptions","organizations_url":"https://api.github.com/users/metabase/orgs","repos_url":"https://api.github.com/users/metabase/repos","events_url":"https://api.github.com/users/metabase/events{/privacy}","received_events_url":"https://api.github.com/users/metabase/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/metabase/metabase","description":"The simplest, fastest way to get business intelligence and analytics  to everyone in your company :yum:","fork":false,"url":"https://api.github.com/repos/metabase/metabase","forks_url":"https://api.github.com/repos/metabase/metabase/forks","keys_url":"https://api.github.com/repos/metabase/metabase/keys{/key_id}","collaborators_url":"https://api.github.com/repos/metabase/metabase/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/metabase/metabase/teams","hooks_url":"https://api.github.com/repos/metabase/metabase/hooks","issue_events_url":"https://api.github.com/repos/metabase/metabase/issues/events{/number}","events_url":"https://api.github.com/repos/metabase/metabase/events","assignees_url":"https://api.github.com/repos/metabase/metabase/assignees{/user}","branches_url":"https://api.github.com/repos/metabase/metabase/branches{/branch}","tags_url":"https://api.github.com/repos/metabase/metabase/tags","blobs_url":"https://api.github.com/repos/metabase/metabase/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/metabase/metabase/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/metabase/metabase/git/refs{/sha}","trees_url":"https://api.github.com/repos/metabase/metabase/git/trees{/sha}","statuses_url":"https://api.github.com/repos/metabase/metabase/statuses/{sha}","languages_url":"https://api.github.com/repos/metabase/metabase/languages","stargazers_url":"https://api.github.com/repos/metabase/metabase/stargazers","contributors_url":"https://api.github.com/repos/metabase/metabase/contributors","subscribers_url":"https://api.github.com/repos/metabase/metabase/subscribers","subscription_url":"https://api.github.com/repos/metabase/metabase/subscription","commits_url":"https://api.github.com/repos/metabase/metabase/commits{/sha}","git_commits_url":"https://api.github.com/repos/metabase/metabase/git/commits{/sha}","comments_url":"https://api.github.com/repos/metabase/metabase/comments{/number}","issue_comment_url":"https://api.github.com/repos/metabase/metabase/issues/comments{/number}","contents_url":"https://api.github.com/repos/metabase/metabase/contents/{+path}","compare_url":"https://api.github.com/repos/metabase/metabase/compare/{base}...{head}","merges_url":"https://api.github.com/repos/metabase/metabase/merges","archive_url":"https://api.github.com/repos/metabase/metabase/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/metabase/metabase/downloads","issues_url":"https://api.github.com/repos/metabase/metabase/issues{/number}","pulls_url":"https://api.github.com/repos/metabase/metabase/pulls{/number}","milestones_url":"https://api.github.com/repos/metabase/metabase/milestones{/number}","notifications_url":"https://api.github.com/repos/metabase/metabase/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/metabase/metabase/labels{/name}","releases_url":"https://api.github.com/repos/metabase/metabase/releases{/id}","deployments_url":"https://api.github.com/repos/metabase/metabase/deployments","created_at":"2015-02-02T19:25:47Z","updated_at":"2018-07-21T14:19:48Z","pushed_at":"2018-07-21T15:38:50Z","git_url":"git://github.com/metabase/metabase.git","ssh_url":"git@github.com:metabase/metabase.git","clone_url":"https://github.com/metabase/metabase.git","svn_url":"https://github.com/metabase/metabase","homepage":"https://metabase.com","size":78647,"stargazers_count":10634,"watchers_count":10634,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1348,"mirror_url":null,"archived":false,"open_issues_count":1819,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":1348,"open_issues":1819,"watchers":10634,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/metabase/metabase/pulls/7908"},"html":{"href":"https://github.com/metabase/metabase/pull/7908"},"issue":{"href":"https://api.github.com/repos/metabase/metabase/issues/7908"},"comments":{"href":"https://api.github.com/repos/metabase/metabase/issues/7908/comments"},"review_comments":{"href":"https://api.github.com/repos/metabase/metabase/pulls/7908/comments"},"review_comment":{"href":"https://api.github.com/repos/metabase/metabase/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/metabase/metabase/pulls/7908/commits"},"statuses":{"href":"https://api.github.com/repos/metabase/metabase/statuses/0ff42a69ac212f03314d710601aa8ad9b80779c6"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":false,"rebaseable":false,"mergeable_state":"dirty","merged_by":null,"comments":8,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":24,"deletions":30,"changed_files":3}}
{"actor":{"display_login":"sbelak"}}