{"action":"created","comment":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/comments/235423745","pull_request_review_id":177285138,"id":235423745,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNTQyMzc0NQ==","diff_hunk":"@@ -331,19 +334,28 @@\n #define SOF_MEM_RO_SIZE\t\t\t0x8\n \n /* code loader */\n-#define BOOT_LDR_TEXT_ENTRY_BASE\t0xBE000000\n+#define BOOT_LDR_TEXT_ENTRY_BASE\tREEF_LOAD_BASE\n #define BOOT_LDR_TEXT_ENTRY_SIZE\t0x400\n #define BOOT_LDR_LIT_BASE\t\t(BOOT_LDR_TEXT_ENTRY_BASE + BOOT_LDR_TEXT_ENTRY_SIZE)\n #define BOOT_LDR_LIT_SIZE\t\t0x400\n #define BOOT_LDR_TEXT_BASE\t\t(BOOT_LDR_LIT_BASE + BOOT_LDR_LIT_SIZE)\n-#define BOOT_LDR_TEXT_SIZE\t\t0x800\n+#define BOOT_LDR_TEXT_SIZE\t\t0x1800\n #define BOOT_LDR_DATA_BASE\t\t(BOOT_LDR_TEXT_BASE + BOOT_LDR_TEXT_SIZE)\n #define BOOT_LDR_DATA_SIZE\t\t0x1000\n #define BOOT_LDR_BSS_BASE\t\t(BOOT_LDR_DATA_BASE + BOOT_LDR_DATA_SIZE)\n #define BOOT_LDR_BSS_SIZE\t\t0x100\n \n /* TODO: set this value */\n-#define BOOT_LDR_MANIFEST_BASE\t\t0x55aa55aa\n+#define MAN_DESC_OFFSET\t\t\t0x2000\t/* from rimage/manifest.h */\n+/*\n+ * This is a temporary hack until rimage is updated to handle Sue Creek:\n+ * currently the resuult of \"xtensa-...-objdump -O binary sof-sue\" is about\n+ * 8250 bytes, reserve 9K for it and create a firmware image with something like\n+ * dd if=/dev/zero bs=1 count=$(expr 9216 - $(stat --print=%s boot_ldr-sue.bin)) >> boot_ldr-sue.bin\n+ * cat boot_ldr-sue.bin sof-sue.ri > /tmp/sue.img","path":"src/platform/suecreek/include/platform/memory.h","position":35,"original_position":35,"commit_id":"b986249be3fd1f372d2de0da3a2c79f340bdb97c","original_commit_id":"b986249be3fd1f372d2de0da3a2c79f340bdb97c","user":{"login":"lgirdwood","id":12020523,"node_id":"MDQ6VXNlcjEyMDIwNTIz","avatar_url":"https://avatars0.githubusercontent.com/u/12020523?v=4","gravatar_id":"","url":"https://api.github.com/users/lgirdwood","html_url":"https://github.com/lgirdwood","followers_url":"https://api.github.com/users/lgirdwood/followers","following_url":"https://api.github.com/users/lgirdwood/following{/other_user}","gists_url":"https://api.github.com/users/lgirdwood/gists{/gist_id}","starred_url":"https://api.github.com/users/lgirdwood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lgirdwood/subscriptions","organizations_url":"https://api.github.com/users/lgirdwood/orgs","repos_url":"https://api.github.com/users/lgirdwood/repos","events_url":"https://api.github.com/users/lgirdwood/events{/privacy}","received_events_url":"https://api.github.com/users/lgirdwood/received_events","type":"User","site_admin":false},"body":"Sorry, can you also include the rimage updates here too so we dont need any hacks.","created_at":"2018-11-21T15:08:18Z","updated_at":"2018-11-21T15:09:00Z","html_url":"https://github.com/thesofproject/sof/pull/602#discussion_r235423745","pull_request_url":"https://api.github.com/repos/thesofproject/sof/pulls/602","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments/235423745"},"html":{"href":"https://github.com/thesofproject/sof/pull/602#discussion_r235423745"},"pull_request":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/602"}}},"pull_request":{"url":"https://api.github.com/repos/thesofproject/sof/pulls/602","id":232620738,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMyNjIwNzM4","html_url":"https://github.com/thesofproject/sof/pull/602","diff_url":"https://github.com/thesofproject/sof/pull/602.diff","patch_url":"https://github.com/thesofproject/sof/pull/602.patch","issue_url":"https://api.github.com/repos/thesofproject/sof/issues/602","number":602,"state":"open","locked":false,"title":"Sue Creek: enable booting by loading over SPI","user":{"login":"lyakh","id":1363683,"node_id":"MDQ6VXNlcjEzNjM2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1363683?v=4","gravatar_id":"","url":"https://api.github.com/users/lyakh","html_url":"https://github.com/lyakh","followers_url":"https://api.github.com/users/lyakh/followers","following_url":"https://api.github.com/users/lyakh/following{/other_user}","gists_url":"https://api.github.com/users/lyakh/gists{/gist_id}","starred_url":"https://api.github.com/users/lyakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyakh/subscriptions","organizations_url":"https://api.github.com/users/lyakh/orgs","repos_url":"https://api.github.com/users/lyakh/repos","events_url":"https://api.github.com/users/lyakh/events{/privacy}","received_events_url":"https://api.github.com/users/lyakh/received_events","type":"User","site_admin":false},"body":"Tested: boots. To create an image something like this can be used:\r\n\r\n```\r\ndd if=/dev/zero bs=1 count=$(expr 9216 - $(stat --print=%s src/arch/xtensa/boot_ldr-sue.bin)) | \\\r\ncat src/arch/xtensa/boot_ldr-sue.bin - > /tmp/boot_ldr-sue.bin\r\ncat /tmp/boot_ldr-sue.bin src/arch/xtensa/sof-sue.ri > /tmp/sue.ri\r\n```","created_at":"2018-11-21T10:59:40Z","updated_at":"2018-11-21T15:09:00Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bb2e7a42f78e337bf1b61d325e019ebcd8fa4767","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/thesofproject/sof/pulls/602/commits","review_comments_url":"https://api.github.com/repos/thesofproject/sof/pulls/602/comments","review_comment_url":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}","comments_url":"https://api.github.com/repos/thesofproject/sof/issues/602/comments","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/b986249be3fd1f372d2de0da3a2c79f340bdb97c","head":{"label":"lyakh:sue-spi-boot","ref":"sue-spi-boot","sha":"b986249be3fd1f372d2de0da3a2c79f340bdb97c","user":{"login":"lyakh","id":1363683,"node_id":"MDQ6VXNlcjEzNjM2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1363683?v=4","gravatar_id":"","url":"https://api.github.com/users/lyakh","html_url":"https://github.com/lyakh","followers_url":"https://api.github.com/users/lyakh/followers","following_url":"https://api.github.com/users/lyakh/following{/other_user}","gists_url":"https://api.github.com/users/lyakh/gists{/gist_id}","starred_url":"https://api.github.com/users/lyakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyakh/subscriptions","organizations_url":"https://api.github.com/users/lyakh/orgs","repos_url":"https://api.github.com/users/lyakh/repos","events_url":"https://api.github.com/users/lyakh/events{/privacy}","received_events_url":"https://api.github.com/users/lyakh/received_events","type":"User","site_admin":false},"repo":{"id":155597902,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU1OTc5MDI=","name":"sof","full_name":"lyakh/sof","private":false,"owner":{"login":"lyakh","id":1363683,"node_id":"MDQ6VXNlcjEzNjM2ODM=","avatar_url":"https://avatars2.githubusercontent.com/u/1363683?v=4","gravatar_id":"","url":"https://api.github.com/users/lyakh","html_url":"https://github.com/lyakh","followers_url":"https://api.github.com/users/lyakh/followers","following_url":"https://api.github.com/users/lyakh/following{/other_user}","gists_url":"https://api.github.com/users/lyakh/gists{/gist_id}","starred_url":"https://api.github.com/users/lyakh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lyakh/subscriptions","organizations_url":"https://api.github.com/users/lyakh/orgs","repos_url":"https://api.github.com/users/lyakh/repos","events_url":"https://api.github.com/users/lyakh/events{/privacy}","received_events_url":"https://api.github.com/users/lyakh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lyakh/sof","description":"Sound Open Firmware","fork":true,"url":"https://api.github.com/repos/lyakh/sof","forks_url":"https://api.github.com/repos/lyakh/sof/forks","keys_url":"https://api.github.com/repos/lyakh/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lyakh/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lyakh/sof/teams","hooks_url":"https://api.github.com/repos/lyakh/sof/hooks","issue_events_url":"https://api.github.com/repos/lyakh/sof/issues/events{/number}","events_url":"https://api.github.com/repos/lyakh/sof/events","assignees_url":"https://api.github.com/repos/lyakh/sof/assignees{/user}","branches_url":"https://api.github.com/repos/lyakh/sof/branches{/branch}","tags_url":"https://api.github.com/repos/lyakh/sof/tags","blobs_url":"https://api.github.com/repos/lyakh/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lyakh/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lyakh/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/lyakh/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lyakh/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/lyakh/sof/languages","stargazers_url":"https://api.github.com/repos/lyakh/sof/stargazers","contributors_url":"https://api.github.com/repos/lyakh/sof/contributors","subscribers_url":"https://api.github.com/repos/lyakh/sof/subscribers","subscription_url":"https://api.github.com/repos/lyakh/sof/subscription","commits_url":"https://api.github.com/repos/lyakh/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/lyakh/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/lyakh/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/lyakh/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/lyakh/sof/contents/{+path}","compare_url":"https://api.github.com/repos/lyakh/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lyakh/sof/merges","archive_url":"https://api.github.com/repos/lyakh/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lyakh/sof/downloads","issues_url":"https://api.github.com/repos/lyakh/sof/issues{/number}","pulls_url":"https://api.github.com/repos/lyakh/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/lyakh/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/lyakh/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lyakh/sof/labels{/name}","releases_url":"https://api.github.com/repos/lyakh/sof/releases{/id}","deployments_url":"https://api.github.com/repos/lyakh/sof/deployments","created_at":"2018-10-31T17:29:31Z","updated_at":"2018-10-31T17:29:36Z","pushed_at":"2018-11-21T10:47:59Z","git_url":"git://github.com/lyakh/sof.git","ssh_url":"git@github.com:lyakh/sof.git","clone_url":"https://github.com/lyakh/sof.git","svn_url":"https://github.com/lyakh/sof","homepage":null,"size":4218,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"thesofproject:master","ref":"master","sha":"43081afa6d54fb539bc73914718813250268ae51","user":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"repo":{"id":135623245,"node_id":"MDEwOlJlcG9zaXRvcnkxMzU2MjMyNDU=","name":"sof","full_name":"thesofproject/sof","private":false,"owner":{"login":"thesofproject","id":39773507,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5NzczNTA3","avatar_url":"https://avatars1.githubusercontent.com/u/39773507?v=4","gravatar_id":"","url":"https://api.github.com/users/thesofproject","html_url":"https://github.com/thesofproject","followers_url":"https://api.github.com/users/thesofproject/followers","following_url":"https://api.github.com/users/thesofproject/following{/other_user}","gists_url":"https://api.github.com/users/thesofproject/gists{/gist_id}","starred_url":"https://api.github.com/users/thesofproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thesofproject/subscriptions","organizations_url":"https://api.github.com/users/thesofproject/orgs","repos_url":"https://api.github.com/users/thesofproject/repos","events_url":"https://api.github.com/users/thesofproject/events{/privacy}","received_events_url":"https://api.github.com/users/thesofproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/thesofproject/sof","description":"Sound Open Firmware","fork":false,"url":"https://api.github.com/repos/thesofproject/sof","forks_url":"https://api.github.com/repos/thesofproject/sof/forks","keys_url":"https://api.github.com/repos/thesofproject/sof/keys{/key_id}","collaborators_url":"https://api.github.com/repos/thesofproject/sof/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/thesofproject/sof/teams","hooks_url":"https://api.github.com/repos/thesofproject/sof/hooks","issue_events_url":"https://api.github.com/repos/thesofproject/sof/issues/events{/number}","events_url":"https://api.github.com/repos/thesofproject/sof/events","assignees_url":"https://api.github.com/repos/thesofproject/sof/assignees{/user}","branches_url":"https://api.github.com/repos/thesofproject/sof/branches{/branch}","tags_url":"https://api.github.com/repos/thesofproject/sof/tags","blobs_url":"https://api.github.com/repos/thesofproject/sof/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/thesofproject/sof/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/thesofproject/sof/git/refs{/sha}","trees_url":"https://api.github.com/repos/thesofproject/sof/git/trees{/sha}","statuses_url":"https://api.github.com/repos/thesofproject/sof/statuses/{sha}","languages_url":"https://api.github.com/repos/thesofproject/sof/languages","stargazers_url":"https://api.github.com/repos/thesofproject/sof/stargazers","contributors_url":"https://api.github.com/repos/thesofproject/sof/contributors","subscribers_url":"https://api.github.com/repos/thesofproject/sof/subscribers","subscription_url":"https://api.github.com/repos/thesofproject/sof/subscription","commits_url":"https://api.github.com/repos/thesofproject/sof/commits{/sha}","git_commits_url":"https://api.github.com/repos/thesofproject/sof/git/commits{/sha}","comments_url":"https://api.github.com/repos/thesofproject/sof/comments{/number}","issue_comment_url":"https://api.github.com/repos/thesofproject/sof/issues/comments{/number}","contents_url":"https://api.github.com/repos/thesofproject/sof/contents/{+path}","compare_url":"https://api.github.com/repos/thesofproject/sof/compare/{base}...{head}","merges_url":"https://api.github.com/repos/thesofproject/sof/merges","archive_url":"https://api.github.com/repos/thesofproject/sof/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/thesofproject/sof/downloads","issues_url":"https://api.github.com/repos/thesofproject/sof/issues{/number}","pulls_url":"https://api.github.com/repos/thesofproject/sof/pulls{/number}","milestones_url":"https://api.github.com/repos/thesofproject/sof/milestones{/number}","notifications_url":"https://api.github.com/repos/thesofproject/sof/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/thesofproject/sof/labels{/name}","releases_url":"https://api.github.com/repos/thesofproject/sof/releases{/id}","deployments_url":"https://api.github.com/repos/thesofproject/sof/deployments","created_at":"2018-05-31T18:51:03Z","updated_at":"2018-11-21T14:57:34Z","pushed_at":"2018-11-21T14:57:29Z","git_url":"git://github.com/thesofproject/sof.git","ssh_url":"git@github.com:thesofproject/sof.git","clone_url":"https://github.com/thesofproject/sof.git","svn_url":"https://github.com/thesofproject/sof","homepage":null,"size":4203,"stargazers_count":24,"watchers_count":24,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":47,"mirror_url":null,"archived":false,"open_issues_count":55,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":47,"open_issues":55,"watchers":24,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/602"},"html":{"href":"https://github.com/thesofproject/sof/pull/602"},"issue":{"href":"https://api.github.com/repos/thesofproject/sof/issues/602"},"comments":{"href":"https://api.github.com/repos/thesofproject/sof/issues/602/comments"},"review_comments":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/602/comments"},"review_comment":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/thesofproject/sof/pulls/602/commits"},"statuses":{"href":"https://api.github.com/repos/thesofproject/sof/statuses/b986249be3fd1f372d2de0da3a2c79f340bdb97c"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"lgirdwood"}}