{"action":"created","comment":{"url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/comments/188256557","pull_request_review_id":120195349,"id":188256557,"diff_hunk":"@@ -41,5 +42,14 @@ public GetAllApprenticeMinimumWagesService(SqlDatabaseService sqlDatabaseService\n                 throw new InfrastructureException(e);\n             }\n         }\n+\n+        public async Task<WageRange> GetWageRangeAsync(DateTime expectedStartDate)\n+        {\n+            var ranges = await GetAllWagesAsync();\n+\n+            return ranges?.FirstOrDefault(range =>\n+                range.ValidFrom.Date <= expectedStartDate.Date &&\n+                range.ValidTo.Date >= expectedStartDate.Date);","path":"src/Esfa.Vacancy.Infrastructure/Services/GetMinimumWagesService.cs","position":null,"original_position":35,"commit_id":"ebd814686740c89bd2920fec92c05d4fad7eb7b3","original_commit_id":"c524d22a0313e78a996f72d20a12b16cab7a39a0","user":{"login":"dev4valtech","id":29398561,"avatar_url":"https://avatars1.githubusercontent.com/u/29398561?v=4","gravatar_id":"","url":"https://api.github.com/users/dev4valtech","html_url":"https://github.com/dev4valtech","followers_url":"https://api.github.com/users/dev4valtech/followers","following_url":"https://api.github.com/users/dev4valtech/following{/other_user}","gists_url":"https://api.github.com/users/dev4valtech/gists{/gist_id}","starred_url":"https://api.github.com/users/dev4valtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev4valtech/subscriptions","organizations_url":"https://api.github.com/users/dev4valtech/orgs","repos_url":"https://api.github.com/users/dev4valtech/repos","events_url":"https://api.github.com/users/dev4valtech/events{/privacy}","received_events_url":"https://api.github.com/users/dev4valtech/received_events","type":"User","site_admin":false},"body":"This method should never be called, but since the interface is shared between cache and actual service I had to put some implementation here. I have changed it to use Single anyway. ","created_at":"2018-05-15T11:46:43Z","updated_at":"2018-05-15T11:46:43Z","html_url":"https://github.com/SkillsFundingAgency/vacancy-register-api/pull/177#discussion_r188256557","pull_request_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/177","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/comments/188256557"},"html":{"href":"https://github.com/SkillsFundingAgency/vacancy-register-api/pull/177#discussion_r188256557"},"pull_request":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/177"}},"in_reply_to_id":188229692},"pull_request":{"url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/177","id":188057887,"html_url":"https://github.com/SkillsFundingAgency/vacancy-register-api/pull/177","diff_url":"https://github.com/SkillsFundingAgency/vacancy-register-api/pull/177.diff","patch_url":"https://github.com/SkillsFundingAgency/vacancy-register-api/pull/177.patch","issue_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues/177","number":177,"state":"open","locked":false,"title":"ER-432 Retrieve Recruit Apprenticeship ","user":{"login":"dev4valtech","id":29398561,"avatar_url":"https://avatars1.githubusercontent.com/u/29398561?v=4","gravatar_id":"","url":"https://api.github.com/users/dev4valtech","html_url":"https://github.com/dev4valtech","followers_url":"https://api.github.com/users/dev4valtech/followers","following_url":"https://api.github.com/users/dev4valtech/following{/other_user}","gists_url":"https://api.github.com/users/dev4valtech/gists{/gist_id}","starred_url":"https://api.github.com/users/dev4valtech/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dev4valtech/subscriptions","organizations_url":"https://api.github.com/users/dev4valtech/orgs","repos_url":"https://api.github.com/users/dev4valtech/repos","events_url":"https://api.github.com/users/dev4valtech/events{/privacy}","received_events_url":"https://api.github.com/users/dev4valtech/received_events","type":"User","site_admin":false},"body":"Apprenticeship Minimum wage services has been refactored to Minimum wage service so it can be used for national minimum as well. This requires a little bit of refactoring in V1 to make it consistent. Also I have copied some of the existing methods from existing Mapper in to Recruit mapper to keep it isolated. A tech debt task has been raised to normalise these properly. ","created_at":"2018-05-15T08:58:58Z","updated_at":"2018-05-15T11:46:43Z","closed_at":null,"merged_at":null,"merge_commit_sha":"27b1c61b204487c80a9d84933a33adf23e37135b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mrpmorris","id":3111981,"avatar_url":"https://avatars3.githubusercontent.com/u/3111981?v=4","gravatar_id":"","url":"https://api.github.com/users/mrpmorris","html_url":"https://github.com/mrpmorris","followers_url":"https://api.github.com/users/mrpmorris/followers","following_url":"https://api.github.com/users/mrpmorris/following{/other_user}","gists_url":"https://api.github.com/users/mrpmorris/gists{/gist_id}","starred_url":"https://api.github.com/users/mrpmorris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrpmorris/subscriptions","organizations_url":"https://api.github.com/users/mrpmorris/orgs","repos_url":"https://api.github.com/users/mrpmorris/repos","events_url":"https://api.github.com/users/mrpmorris/events{/privacy}","received_events_url":"https://api.github.com/users/mrpmorris/received_events","type":"User","site_admin":false},{"login":"mgwilliam","id":3403753,"avatar_url":"https://avatars2.githubusercontent.com/u/3403753?v=4","gravatar_id":"","url":"https://api.github.com/users/mgwilliam","html_url":"https://github.com/mgwilliam","followers_url":"https://api.github.com/users/mgwilliam/followers","following_url":"https://api.github.com/users/mgwilliam/following{/other_user}","gists_url":"https://api.github.com/users/mgwilliam/gists{/gist_id}","starred_url":"https://api.github.com/users/mgwilliam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgwilliam/subscriptions","organizations_url":"https://api.github.com/users/mgwilliam/orgs","repos_url":"https://api.github.com/users/mgwilliam/repos","events_url":"https://api.github.com/users/mgwilliam/events{/privacy}","received_events_url":"https://api.github.com/users/mgwilliam/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/177/commits","review_comments_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/177/comments","review_comment_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues/177/comments","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/statuses/ebd814686740c89bd2920fec92c05d4fad7eb7b3","head":{"label":"SkillsFundingAgency:feature/ER-432-GetVacancyDetailsFromER","ref":"feature/ER-432-GetVacancyDetailsFromER","sha":"ebd814686740c89bd2920fec92c05d4fad7eb7b3","user":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":95564539,"name":"vacancy-register-api","full_name":"SkillsFundingAgency/vacancy-register-api","owner":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SkillsFundingAgency/vacancy-register-api","description":":cloud::newspaper: API for apprenticeship and traineeship vacancies","fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api","forks_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/deployments","created_at":"2017-06-27T14:02:03Z","updated_at":"2018-05-15T08:53:30Z","pushed_at":"2018-05-15T11:42:29Z","git_url":"git://github.com/SkillsFundingAgency/vacancy-register-api.git","ssh_url":"git@github.com:SkillsFundingAgency/vacancy-register-api.git","clone_url":"https://github.com/SkillsFundingAgency/vacancy-register-api.git","svn_url":"https://github.com/SkillsFundingAgency/vacancy-register-api","homepage":"","size":2632,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"base":{"label":"SkillsFundingAgency:master","ref":"master","sha":"c9bcd0cd702f631ad3407585d4cf623cc3bbf284","user":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"repo":{"id":95564539,"name":"vacancy-register-api","full_name":"SkillsFundingAgency/vacancy-register-api","owner":{"login":"SkillsFundingAgency","id":9841374,"avatar_url":"https://avatars1.githubusercontent.com/u/9841374?v=4","gravatar_id":"","url":"https://api.github.com/users/SkillsFundingAgency","html_url":"https://github.com/SkillsFundingAgency","followers_url":"https://api.github.com/users/SkillsFundingAgency/followers","following_url":"https://api.github.com/users/SkillsFundingAgency/following{/other_user}","gists_url":"https://api.github.com/users/SkillsFundingAgency/gists{/gist_id}","starred_url":"https://api.github.com/users/SkillsFundingAgency/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SkillsFundingAgency/subscriptions","organizations_url":"https://api.github.com/users/SkillsFundingAgency/orgs","repos_url":"https://api.github.com/users/SkillsFundingAgency/repos","events_url":"https://api.github.com/users/SkillsFundingAgency/events{/privacy}","received_events_url":"https://api.github.com/users/SkillsFundingAgency/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/SkillsFundingAgency/vacancy-register-api","description":":cloud::newspaper: API for apprenticeship and traineeship vacancies","fork":false,"url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api","forks_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/forks","keys_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/teams","hooks_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/hooks","issue_events_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues/events{/number}","events_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/events","assignees_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/assignees{/user}","branches_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/branches{/branch}","tags_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/tags","blobs_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/refs{/sha}","trees_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/statuses/{sha}","languages_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/languages","stargazers_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/stargazers","contributors_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/contributors","subscribers_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/subscribers","subscription_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/subscription","commits_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/commits{/sha}","git_commits_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/git/commits{/sha}","comments_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/comments{/number}","issue_comment_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues/comments{/number}","contents_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/contents/{+path}","compare_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/merges","archive_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/downloads","issues_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues{/number}","pulls_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls{/number}","milestones_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/milestones{/number}","notifications_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/labels{/name}","releases_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/releases{/id}","deployments_url":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/deployments","created_at":"2017-06-27T14:02:03Z","updated_at":"2018-05-15T08:53:30Z","pushed_at":"2018-05-15T11:42:29Z","git_url":"git://github.com/SkillsFundingAgency/vacancy-register-api.git","ssh_url":"git@github.com:SkillsFundingAgency/vacancy-register-api.git","clone_url":"https://github.com/SkillsFundingAgency/vacancy-register-api.git","svn_url":"https://github.com/SkillsFundingAgency/vacancy-register-api","homepage":"","size":2632,"stargazers_count":3,"watchers_count":3,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":1,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/177"},"html":{"href":"https://github.com/SkillsFundingAgency/vacancy-register-api/pull/177"},"issue":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues/177"},"comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/issues/177/comments"},"review_comments":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/177/comments"},"review_comment":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/pulls/177/commits"},"statuses":{"href":"https://api.github.com/repos/SkillsFundingAgency/vacancy-register-api/statuses/ebd814686740c89bd2920fec92c05d4fad7eb7b3"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"dev4valtech"}}