{"action":"opened","number":3829,"pull_request":{"url":"https://api.github.com/repos/learningequality/kolibri/pulls/3829","id":196301747,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk2MzAxNzQ3","html_url":"https://github.com/learningequality/kolibri/pull/3829","diff_url":"https://github.com/learningequality/kolibri/pull/3829.diff","patch_url":"https://github.com/learningequality/kolibri/pull/3829.patch","issue_url":"https://api.github.com/repos/learningequality/kolibri/issues/3829","number":3829,"state":"open","locked":false,"title":"updated language switcher","user":{"login":"indirectlylit","id":2367265,"node_id":"MDQ6VXNlcjIzNjcyNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"body":"\r\n### Summary\r\n\r\nAs reported in #3652, the language switcher is kind of a mess.\r\n\r\nThis PR simplifies the UI drastically and makes it consistent with the other language switcher in the main app:\r\n\r\n* use a globe icon to indicate the current language\r\n* use a modal which is more effective at handling the large number of languages we now have\r\n\r\n| select 1 | select 2 | modal |\r\n|--|--|--|\r\n| ![image](https://user-images.githubusercontent.com/2367265/41690161-1231083e-74a9-11e8-82a3-5444f33e7dd4.png) | ![image](https://user-images.githubusercontent.com/2367265/41690159-0e220aa4-74a9-11e8-9283-b0f8f0a5d0ff.png) | ![image](https://user-images.githubusercontent.com/2367265/41690163-14f5eecc-74a9-11e8-8819-208fd30f5445.png) |\r\n\r\nThe main downside I can think of is that there's no longer a few other visible languages:\r\n\r\n![image](https://user-images.githubusercontent.com/2367265/41690306-b4fa4a6c-74a9-11e8-9d85-973f32ea2561.png)\r\n\r\nHowever, I'd argue that this is a reasonable thing to give up...\r\n\r\n\r\n### Reviewer guidance\r\n\r\nPlease review both the design and implementation\r\n\r\n### References\r\n\r\n#3652\r\n\r\n----\r\n\r\n### Contributor Checklist\r\n\r\n- [ ] Contributor has fully tested the PR manually\r\n- [ ] PR has the correct target branch and milestone\r\n- [ ] PR has 'needs review' or 'work-in-progress' label\r\n- [ ] If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')\r\n- [ ] If there are any front-end changes, before/after screenshots are included\r\n- [ ] If this is an important user-facing change, PR or related issue has a 'changelog' label\r\n\r\n### Reviewer Checklist\r\n\r\n- [ ] Automated test coverage is satisfactory\r\n- [ ] Reviewer has fully tested the PR manually\r\n- [ ] PR has been tested for [accessibility regressions](http://kolibri-dev.readthedocs.io/en/develop/manual_testing.html#accessibility-a11y-testing)\r\n- [ ] External dependencies files were updated (`yarn` and `pip`)\r\n- [ ] Documentation is updated\r\n- [ ] Link to diff of internal dependency change is included\r\n- [ ] CHANGELOG.rst is updated for high-level changes\r\n- [ ] Contributor is in AUTHORS.rst\r\n","created_at":"2018-06-20T23:49:29Z","updated_at":"2018-06-20T23:49:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3829/commits","review_comments_url":"https://api.github.com/repos/learningequality/kolibri/pulls/3829/comments","review_comment_url":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}","comments_url":"https://api.github.com/repos/learningequality/kolibri/issues/3829/comments","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/6c5df5dc6b290d21fcea69020ed4c7ba0f07b6e7","head":{"label":"indirectlylit:language-switcher","ref":"language-switcher","sha":"6c5df5dc6b290d21fcea69020ed4c7ba0f07b6e7","user":{"login":"indirectlylit","id":2367265,"node_id":"MDQ6VXNlcjIzNjcyNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"repo":{"id":54517539,"node_id":"MDEwOlJlcG9zaXRvcnk1NDUxNzUzOQ==","name":"kolibri","full_name":"indirectlylit/kolibri","owner":{"login":"indirectlylit","id":2367265,"node_id":"MDQ6VXNlcjIzNjcyNjU=","avatar_url":"https://avatars2.githubusercontent.com/u/2367265?v=4","gravatar_id":"","url":"https://api.github.com/users/indirectlylit","html_url":"https://github.com/indirectlylit","followers_url":"https://api.github.com/users/indirectlylit/followers","following_url":"https://api.github.com/users/indirectlylit/following{/other_user}","gists_url":"https://api.github.com/users/indirectlylit/gists{/gist_id}","starred_url":"https://api.github.com/users/indirectlylit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/indirectlylit/subscriptions","organizations_url":"https://api.github.com/users/indirectlylit/orgs","repos_url":"https://api.github.com/users/indirectlylit/repos","events_url":"https://api.github.com/users/indirectlylit/events{/privacy}","received_events_url":"https://api.github.com/users/indirectlylit/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/indirectlylit/kolibri","description":"Kolibri","fork":true,"url":"https://api.github.com/repos/indirectlylit/kolibri","forks_url":"https://api.github.com/repos/indirectlylit/kolibri/forks","keys_url":"https://api.github.com/repos/indirectlylit/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/indirectlylit/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/indirectlylit/kolibri/teams","hooks_url":"https://api.github.com/repos/indirectlylit/kolibri/hooks","issue_events_url":"https://api.github.com/repos/indirectlylit/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/indirectlylit/kolibri/events","assignees_url":"https://api.github.com/repos/indirectlylit/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/indirectlylit/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/indirectlylit/kolibri/tags","blobs_url":"https://api.github.com/repos/indirectlylit/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/indirectlylit/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/indirectlylit/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/indirectlylit/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/indirectlylit/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/indirectlylit/kolibri/languages","stargazers_url":"https://api.github.com/repos/indirectlylit/kolibri/stargazers","contributors_url":"https://api.github.com/repos/indirectlylit/kolibri/contributors","subscribers_url":"https://api.github.com/repos/indirectlylit/kolibri/subscribers","subscription_url":"https://api.github.com/repos/indirectlylit/kolibri/subscription","commits_url":"https://api.github.com/repos/indirectlylit/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/indirectlylit/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/indirectlylit/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/indirectlylit/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/indirectlylit/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/indirectlylit/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/indirectlylit/kolibri/merges","archive_url":"https://api.github.com/repos/indirectlylit/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/indirectlylit/kolibri/downloads","issues_url":"https://api.github.com/repos/indirectlylit/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/indirectlylit/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/indirectlylit/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/indirectlylit/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/indirectlylit/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/indirectlylit/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/indirectlylit/kolibri/deployments","created_at":"2016-03-23T00:08:12Z","updated_at":"2018-06-13T05:19:14Z","pushed_at":"2018-06-20T23:37:38Z","git_url":"git://github.com/indirectlylit/kolibri.git","ssh_url":"git@github.com:indirectlylit/kolibri.git","clone_url":"https://github.com/indirectlylit/kolibri.git","svn_url":"https://github.com/indirectlylit/kolibri","homepage":"http://learningequality.org/kolibri/","size":40737,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"develop"}},"base":{"label":"learningequality:develop","ref":"develop","sha":"6dd074db6109c0df43a60ad23cd20f2d733b3dad","user":{"login":"learningequality","id":3926525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"repo":{"id":49976939,"node_id":"MDEwOlJlcG9zaXRvcnk0OTk3NjkzOQ==","name":"kolibri","full_name":"learningequality/kolibri","owner":{"login":"learningequality","id":3926525,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM5MjY1MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/3926525?v=4","gravatar_id":"","url":"https://api.github.com/users/learningequality","html_url":"https://github.com/learningequality","followers_url":"https://api.github.com/users/learningequality/followers","following_url":"https://api.github.com/users/learningequality/following{/other_user}","gists_url":"https://api.github.com/users/learningequality/gists{/gist_id}","starred_url":"https://api.github.com/users/learningequality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/learningequality/subscriptions","organizations_url":"https://api.github.com/users/learningequality/orgs","repos_url":"https://api.github.com/users/learningequality/repos","events_url":"https://api.github.com/users/learningequality/events{/privacy}","received_events_url":"https://api.github.com/users/learningequality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/learningequality/kolibri","description":"Kolibri: the offline app for universal education","fork":false,"url":"https://api.github.com/repos/learningequality/kolibri","forks_url":"https://api.github.com/repos/learningequality/kolibri/forks","keys_url":"https://api.github.com/repos/learningequality/kolibri/keys{/key_id}","collaborators_url":"https://api.github.com/repos/learningequality/kolibri/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/learningequality/kolibri/teams","hooks_url":"https://api.github.com/repos/learningequality/kolibri/hooks","issue_events_url":"https://api.github.com/repos/learningequality/kolibri/issues/events{/number}","events_url":"https://api.github.com/repos/learningequality/kolibri/events","assignees_url":"https://api.github.com/repos/learningequality/kolibri/assignees{/user}","branches_url":"https://api.github.com/repos/learningequality/kolibri/branches{/branch}","tags_url":"https://api.github.com/repos/learningequality/kolibri/tags","blobs_url":"https://api.github.com/repos/learningequality/kolibri/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/learningequality/kolibri/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/learningequality/kolibri/git/refs{/sha}","trees_url":"https://api.github.com/repos/learningequality/kolibri/git/trees{/sha}","statuses_url":"https://api.github.com/repos/learningequality/kolibri/statuses/{sha}","languages_url":"https://api.github.com/repos/learningequality/kolibri/languages","stargazers_url":"https://api.github.com/repos/learningequality/kolibri/stargazers","contributors_url":"https://api.github.com/repos/learningequality/kolibri/contributors","subscribers_url":"https://api.github.com/repos/learningequality/kolibri/subscribers","subscription_url":"https://api.github.com/repos/learningequality/kolibri/subscription","commits_url":"https://api.github.com/repos/learningequality/kolibri/commits{/sha}","git_commits_url":"https://api.github.com/repos/learningequality/kolibri/git/commits{/sha}","comments_url":"https://api.github.com/repos/learningequality/kolibri/comments{/number}","issue_comment_url":"https://api.github.com/repos/learningequality/kolibri/issues/comments{/number}","contents_url":"https://api.github.com/repos/learningequality/kolibri/contents/{+path}","compare_url":"https://api.github.com/repos/learningequality/kolibri/compare/{base}...{head}","merges_url":"https://api.github.com/repos/learningequality/kolibri/merges","archive_url":"https://api.github.com/repos/learningequality/kolibri/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/learningequality/kolibri/downloads","issues_url":"https://api.github.com/repos/learningequality/kolibri/issues{/number}","pulls_url":"https://api.github.com/repos/learningequality/kolibri/pulls{/number}","milestones_url":"https://api.github.com/repos/learningequality/kolibri/milestones{/number}","notifications_url":"https://api.github.com/repos/learningequality/kolibri/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/learningequality/kolibri/labels{/name}","releases_url":"https://api.github.com/repos/learningequality/kolibri/releases{/id}","deployments_url":"https://api.github.com/repos/learningequality/kolibri/deployments","created_at":"2016-01-19T19:22:07Z","updated_at":"2018-06-20T18:41:57Z","pushed_at":"2018-06-20T15:47:48Z","git_url":"git://github.com/learningequality/kolibri.git","ssh_url":"git@github.com:learningequality/kolibri.git","clone_url":"https://github.com/learningequality/kolibri.git","svn_url":"https://github.com/learningequality/kolibri","homepage":"http://learningequality.org/kolibri/","size":40580,"stargazers_count":175,"watchers_count":175,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":132,"mirror_url":null,"archived":false,"open_issues_count":238,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":132,"open_issues":238,"watchers":175,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3829"},"html":{"href":"https://github.com/learningequality/kolibri/pull/3829"},"issue":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3829"},"comments":{"href":"https://api.github.com/repos/learningequality/kolibri/issues/3829/comments"},"review_comments":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3829/comments"},"review_comment":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/learningequality/kolibri/pulls/3829/commits"},"statuses":{"href":"https://api.github.com/repos/learningequality/kolibri/statuses/6c5df5dc6b290d21fcea69020ed4c7ba0f07b6e7"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":31,"deletions":112,"changed_files":3}}
{"actor":{"display_login":"indirectlylit"}}