{"action":"created","comment":{"url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/comments/186675364","pull_request_review_id":118298396,"id":186675364,"diff_hunk":"@@ -9,6 +9,15 @@ var newZ = require('..');\n var Identity = require('../test/Identity');\n var shuffle = require('../test/shuffle');\n \n+//  chainRec :: (Number -⁠> c, Number -⁠> c, Number) -⁠> Array c, Number) -⁠> Array b","path":"bench/old-vs-new.js","position":4,"original_position":4,"commit_id":"910cf92dfbd56593087d4a53350a5cb891b03d5d","original_commit_id":"910cf92dfbd56593087d4a53350a5cb891b03d5d","user":{"login":"Avaq","id":1217745,"avatar_url":"https://avatars0.githubusercontent.com/u/1217745?v=4","gravatar_id":"","url":"https://api.github.com/users/Avaq","html_url":"https://github.com/Avaq","followers_url":"https://api.github.com/users/Avaq/followers","following_url":"https://api.github.com/users/Avaq/following{/other_user}","gists_url":"https://api.github.com/users/Avaq/gists{/gist_id}","starred_url":"https://api.github.com/users/Avaq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Avaq/subscriptions","organizations_url":"https://api.github.com/users/Avaq/orgs","repos_url":"https://api.github.com/users/Avaq/repos","events_url":"https://api.github.com/users/Avaq/events{/privacy}","received_events_url":"https://api.github.com/users/Avaq/received_events","type":"User","site_admin":false},"body":"Oh darn. I copied from the Sanctuary website. :P","created_at":"2018-05-08T09:57:28Z","updated_at":"2018-05-08T09:57:28Z","html_url":"https://github.com/sanctuary-js/sanctuary-type-classes/pull/103#discussion_r186675364","pull_request_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/103","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/comments/186675364"},"html":{"href":"https://github.com/sanctuary-js/sanctuary-type-classes/pull/103#discussion_r186675364"},"pull_request":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/103"}},"in_reply_to_id":186666652},"pull_request":{"url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/103","id":186488026,"html_url":"https://github.com/sanctuary-js/sanctuary-type-classes/pull/103","diff_url":"https://github.com/sanctuary-js/sanctuary-type-classes/pull/103.diff","patch_url":"https://github.com/sanctuary-js/sanctuary-type-classes/pull/103.patch","issue_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues/103","number":103,"state":"open","locked":false,"title":"remove uses of Function#apply to accommodate large arrays","user":{"login":"davidchambers","id":210406,"avatar_url":"https://avatars2.githubusercontent.com/u/210406?v=4","gravatar_id":"","url":"https://api.github.com/users/davidchambers","html_url":"https://github.com/davidchambers","followers_url":"https://api.github.com/users/davidchambers/followers","following_url":"https://api.github.com/users/davidchambers/following{/other_user}","gists_url":"https://api.github.com/users/davidchambers/gists{/gist_id}","starred_url":"https://api.github.com/users/davidchambers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidchambers/subscriptions","organizations_url":"https://api.github.com/users/davidchambers/orgs","repos_url":"https://api.github.com/users/davidchambers/repos","events_url":"https://api.github.com/users/davidchambers/events{/privacy}","received_events_url":"https://api.github.com/users/davidchambers/received_events","type":"User","site_admin":false},"body":"Supersedes #102\r\n\r\nThe new implementation of `Array$chainRec` is longer but arguably simpler and more efficient.\r\n\r\n<table>\r\n  <tr>\r\n    <td colspan=\"2\"><b>Before</b></td>\r\n  </tr>\r\n  <tr>\r\n    <td>Data structure</td>\r\n    <td>array</td>\r\n  </tr>\r\n  <tr>\r\n    <td>Loop condition</td>\r\n    <td><code>$todo.length > 0</code></td>\r\n  </tr>\r\n  <tr>\r\n    <td>Advancement</td>\r\n    <td><code>$todo.shift()</code></td>\r\n  </tr>\r\n  <tr>\r\n    <td>Accumulation</td>\r\n    <td><code>$more.push(step.value)</code></td>\r\n  </tr>\r\n  <tr>\r\n    <td>Transference</td>\r\n    <td><code>Array.prototype.unshift.apply($todo, $more)</code> :warning:</td>\r\n  </tr>\r\n  <tr>\r\n    <td colspan=\"2\"><b>After</b></td>\r\n  </tr>\r\n  <tr>\r\n    <td>Data structure</td>\r\n    <td>linked list</td>\r\n  </tr>\r\n  <tr>\r\n    <td>Loop condition</td>\r\n    <td><code>xs !== nil</code></td>\r\n  </tr>\r\n  <tr>\r\n    <td>Advancement</td>\r\n    <td><code>xs = xs.tail</code></td>\r\n  </tr>\r\n  <tr>\r\n    <td>Accumulation</td>\r\n    <td><code>sx = {head: step.value, tail: sx}</code></td>\r\n  </tr>\r\n  <tr>\r\n    <td>Transference</td>\r\n    <td><code>while (sx !== nil) { xs = {head: sx.head, tail: xs}; sx = sx.tail; }</code></td>\r\n  </tr>\r\n</table>\r\n\r\nI'd appreciate your :eyes: on this pull request, Irakli. :)\r\n\r\n/cc @edahlseng\r\n","created_at":"2018-05-07T23:08:25Z","updated_at":"2018-05-08T09:57:28Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c54e31471f1d3967b58f619fd75a3fce00873c2b","assignee":null,"assignees":[],"requested_reviewers":[{"login":"safareli","id":1932383,"avatar_url":"https://avatars1.githubusercontent.com/u/1932383?v=4","gravatar_id":"","url":"https://api.github.com/users/safareli","html_url":"https://github.com/safareli","followers_url":"https://api.github.com/users/safareli/followers","following_url":"https://api.github.com/users/safareli/following{/other_user}","gists_url":"https://api.github.com/users/safareli/gists{/gist_id}","starred_url":"https://api.github.com/users/safareli/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/safareli/subscriptions","organizations_url":"https://api.github.com/users/safareli/orgs","repos_url":"https://api.github.com/users/safareli/repos","events_url":"https://api.github.com/users/safareli/events{/privacy}","received_events_url":"https://api.github.com/users/safareli/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/103/commits","review_comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/103/comments","review_comment_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues/103/comments","statuses_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/statuses/910cf92dfbd56593087d4a53350a5cb891b03d5d","head":{"label":"sanctuary-js:davidchambers/no-apply","ref":"davidchambers/no-apply","sha":"910cf92dfbd56593087d4a53350a5cb891b03d5d","user":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars1.githubusercontent.com/u/18357498?v=4","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"repo":{"id":58353356,"name":"sanctuary-type-classes","full_name":"sanctuary-js/sanctuary-type-classes","owner":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars1.githubusercontent.com/u/18357498?v=4","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sanctuary-js/sanctuary-type-classes","description":":rainbow: Standard library for Fantasy Land","fork":false,"url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes","forks_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/forks","keys_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/teams","hooks_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/hooks","issue_events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues/events{/number}","events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/events","assignees_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/assignees{/user}","branches_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/branches{/branch}","tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/tags","blobs_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/statuses/{sha}","languages_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/languages","stargazers_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/stargazers","contributors_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/contributors","subscribers_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/subscribers","subscription_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/subscription","commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/contents/{+path}","compare_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/merges","archive_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/downloads","issues_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues{/number}","pulls_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls{/number}","milestones_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/milestones{/number}","notifications_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/labels{/name}","releases_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/releases{/id}","deployments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/deployments","created_at":"2016-05-09T06:24:11Z","updated_at":"2018-04-29T19:55:46Z","pushed_at":"2018-05-08T09:21:57Z","git_url":"git://github.com/sanctuary-js/sanctuary-type-classes.git","ssh_url":"git@github.com:sanctuary-js/sanctuary-type-classes.git","clone_url":"https://github.com/sanctuary-js/sanctuary-type-classes.git","svn_url":"https://github.com/sanctuary-js/sanctuary-type-classes","homepage":"","size":449,"stargazers_count":91,"watchers_count":91,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":7,"watchers":91,"default_branch":"master"}},"base":{"label":"sanctuary-js:master","ref":"master","sha":"93141801e5710d71387e07c3296aa3a38900362d","user":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars1.githubusercontent.com/u/18357498?v=4","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"repo":{"id":58353356,"name":"sanctuary-type-classes","full_name":"sanctuary-js/sanctuary-type-classes","owner":{"login":"sanctuary-js","id":18357498,"avatar_url":"https://avatars1.githubusercontent.com/u/18357498?v=4","gravatar_id":"","url":"https://api.github.com/users/sanctuary-js","html_url":"https://github.com/sanctuary-js","followers_url":"https://api.github.com/users/sanctuary-js/followers","following_url":"https://api.github.com/users/sanctuary-js/following{/other_user}","gists_url":"https://api.github.com/users/sanctuary-js/gists{/gist_id}","starred_url":"https://api.github.com/users/sanctuary-js/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sanctuary-js/subscriptions","organizations_url":"https://api.github.com/users/sanctuary-js/orgs","repos_url":"https://api.github.com/users/sanctuary-js/repos","events_url":"https://api.github.com/users/sanctuary-js/events{/privacy}","received_events_url":"https://api.github.com/users/sanctuary-js/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/sanctuary-js/sanctuary-type-classes","description":":rainbow: Standard library for Fantasy Land","fork":false,"url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes","forks_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/forks","keys_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/teams","hooks_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/hooks","issue_events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues/events{/number}","events_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/events","assignees_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/assignees{/user}","branches_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/branches{/branch}","tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/tags","blobs_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/refs{/sha}","trees_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/statuses/{sha}","languages_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/languages","stargazers_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/stargazers","contributors_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/contributors","subscribers_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/subscribers","subscription_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/subscription","commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/commits{/sha}","git_commits_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/git/commits{/sha}","comments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/comments{/number}","issue_comment_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues/comments{/number}","contents_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/contents/{+path}","compare_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/merges","archive_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/downloads","issues_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues{/number}","pulls_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls{/number}","milestones_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/milestones{/number}","notifications_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/labels{/name}","releases_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/releases{/id}","deployments_url":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/deployments","created_at":"2016-05-09T06:24:11Z","updated_at":"2018-04-29T19:55:46Z","pushed_at":"2018-05-08T09:21:57Z","git_url":"git://github.com/sanctuary-js/sanctuary-type-classes.git","ssh_url":"git@github.com:sanctuary-js/sanctuary-type-classes.git","clone_url":"https://github.com/sanctuary-js/sanctuary-type-classes.git","svn_url":"https://github.com/sanctuary-js/sanctuary-type-classes","homepage":"","size":449,"stargazers_count":91,"watchers_count":91,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":13,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":13,"open_issues":7,"watchers":91,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/103"},"html":{"href":"https://github.com/sanctuary-js/sanctuary-type-classes/pull/103"},"issue":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues/103"},"comments":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/issues/103/comments"},"review_comments":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/103/comments"},"review_comment":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/pulls/103/commits"},"statuses":{"href":"https://api.github.com/repos/sanctuary-js/sanctuary-type-classes/statuses/910cf92dfbd56593087d4a53350a5cb891b03d5d"}},"author_association":"OWNER"}}
{"actor":{"display_login":"Avaq"}}