{"action":"created","comment":{"url":"https://api.github.com/repos/konigio/konig/pulls/comments/181058555","pull_request_review_id":111591345,"id":181058555,"diff_hunk":"@@ -529,5 +530,12 @@ public URI getTermStatus() {\n \n \tpublic void setTermStatus(URI termStatus) {\n \t\tthis.termStatus  = termStatus ;\n+\t}\n+\tpublic boolean isRequired() {\n+\t\treturn required;","path":"konig-core/src/main/java/io/konig/shacl/PropertyConstraint.java","position":14,"original_position":14,"commit_id":"d33d13bd92003478dc6169725e7513ccbb0be287","original_commit_id":"d33d13bd92003478dc6169725e7513ccbb0be287","user":{"login":"gmcfall","id":1863752,"avatar_url":"https://avatars3.githubusercontent.com/u/1863752?v=4","gravatar_id":"","url":"https://api.github.com/users/gmcfall","html_url":"https://github.com/gmcfall","followers_url":"https://api.github.com/users/gmcfall/followers","following_url":"https://api.github.com/users/gmcfall/following{/other_user}","gists_url":"https://api.github.com/users/gmcfall/gists{/gist_id}","starred_url":"https://api.github.com/users/gmcfall/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmcfall/subscriptions","organizations_url":"https://api.github.com/users/gmcfall/orgs","repos_url":"https://api.github.com/users/gmcfall/repos","events_url":"https://api.github.com/users/gmcfall/events{/privacy}","received_events_url":"https://api.github.com/users/gmcfall/received_events","type":"User","site_admin":false},"body":"return minCount!=null && minCount>1\r\n\r\nHowever, I think you might be interested in a different method which asserts that the property is single-valued and required.  If that's the case, then you should add the following method...\r\n\r\n```\r\nboolean isRequiredSingleValue() {\r\n  return minCount!=null && minCount==1 && maxCount!=null && maxCount==1;\r\n}\r\n```","created_at":"2018-04-12T12:13:22Z","updated_at":"2018-04-12T12:27:04Z","html_url":"https://github.com/konigio/konig/pull/831#discussion_r181058555","pull_request_url":"https://api.github.com/repos/konigio/konig/pulls/831","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/konigio/konig/pulls/comments/181058555"},"html":{"href":"https://github.com/konigio/konig/pull/831#discussion_r181058555"},"pull_request":{"href":"https://api.github.com/repos/konigio/konig/pulls/831"}}},"pull_request":{"url":"https://api.github.com/repos/konigio/konig/pulls/831","id":181170284,"html_url":"https://github.com/konigio/konig/pull/831","diff_url":"https://github.com/konigio/konig/pull/831.diff","patch_url":"https://github.com/konigio/konig/pull/831.patch","issue_url":"https://api.github.com/repos/konigio/konig/issues/831","number":831,"state":"open","locked":false,"title":"Elakiyaudhayanan/#825","user":{"login":"ElakiyaUdhayanan","id":14273840,"avatar_url":"https://avatars3.githubusercontent.com/u/14273840?v=4","gravatar_id":"","url":"https://api.github.com/users/ElakiyaUdhayanan","html_url":"https://github.com/ElakiyaUdhayanan","followers_url":"https://api.github.com/users/ElakiyaUdhayanan/followers","following_url":"https://api.github.com/users/ElakiyaUdhayanan/following{/other_user}","gists_url":"https://api.github.com/users/ElakiyaUdhayanan/gists{/gist_id}","starred_url":"https://api.github.com/users/ElakiyaUdhayanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ElakiyaUdhayanan/subscriptions","organizations_url":"https://api.github.com/users/ElakiyaUdhayanan/orgs","repos_url":"https://api.github.com/users/ElakiyaUdhayanan/repos","events_url":"https://api.github.com/users/ElakiyaUdhayanan/events{/privacy}","received_events_url":"https://api.github.com/users/ElakiyaUdhayanan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-04-12T11:21:51Z","updated_at":"2018-04-12T12:27:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"780f9f37e682e1940cade4cf4e141a043075ff5d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":757360619,"url":"https://api.github.com/repos/konigio/konig/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/konigio/konig/pulls/831/commits","review_comments_url":"https://api.github.com/repos/konigio/konig/pulls/831/comments","review_comment_url":"https://api.github.com/repos/konigio/konig/pulls/comments{/number}","comments_url":"https://api.github.com/repos/konigio/konig/issues/831/comments","statuses_url":"https://api.github.com/repos/konigio/konig/statuses/d33d13bd92003478dc6169725e7513ccbb0be287","head":{"label":"konigio:elakiyaudhayanan/#825","ref":"elakiyaudhayanan/#825","sha":"d33d13bd92003478dc6169725e7513ccbb0be287","user":{"login":"konigio","id":16478118,"avatar_url":"https://avatars2.githubusercontent.com/u/16478118?v=4","gravatar_id":"","url":"https://api.github.com/users/konigio","html_url":"https://github.com/konigio","followers_url":"https://api.github.com/users/konigio/followers","following_url":"https://api.github.com/users/konigio/following{/other_user}","gists_url":"https://api.github.com/users/konigio/gists{/gist_id}","starred_url":"https://api.github.com/users/konigio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konigio/subscriptions","organizations_url":"https://api.github.com/users/konigio/orgs","repos_url":"https://api.github.com/users/konigio/repos","events_url":"https://api.github.com/users/konigio/events{/privacy}","received_events_url":"https://api.github.com/users/konigio/received_events","type":"Organization","site_admin":false},"repo":{"id":48807429,"name":"konig","full_name":"konigio/konig","owner":{"login":"konigio","id":16478118,"avatar_url":"https://avatars2.githubusercontent.com/u/16478118?v=4","gravatar_id":"","url":"https://api.github.com/users/konigio","html_url":"https://github.com/konigio","followers_url":"https://api.github.com/users/konigio/followers","following_url":"https://api.github.com/users/konigio/following{/other_user}","gists_url":"https://api.github.com/users/konigio/gists{/gist_id}","starred_url":"https://api.github.com/users/konigio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konigio/subscriptions","organizations_url":"https://api.github.com/users/konigio/orgs","repos_url":"https://api.github.com/users/konigio/repos","events_url":"https://api.github.com/users/konigio/events{/privacy}","received_events_url":"https://api.github.com/users/konigio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/konigio/konig","description":"A collection of tools for semantic modeling","fork":false,"url":"https://api.github.com/repos/konigio/konig","forks_url":"https://api.github.com/repos/konigio/konig/forks","keys_url":"https://api.github.com/repos/konigio/konig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/konigio/konig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/konigio/konig/teams","hooks_url":"https://api.github.com/repos/konigio/konig/hooks","issue_events_url":"https://api.github.com/repos/konigio/konig/issues/events{/number}","events_url":"https://api.github.com/repos/konigio/konig/events","assignees_url":"https://api.github.com/repos/konigio/konig/assignees{/user}","branches_url":"https://api.github.com/repos/konigio/konig/branches{/branch}","tags_url":"https://api.github.com/repos/konigio/konig/tags","blobs_url":"https://api.github.com/repos/konigio/konig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/konigio/konig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/konigio/konig/git/refs{/sha}","trees_url":"https://api.github.com/repos/konigio/konig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/konigio/konig/statuses/{sha}","languages_url":"https://api.github.com/repos/konigio/konig/languages","stargazers_url":"https://api.github.com/repos/konigio/konig/stargazers","contributors_url":"https://api.github.com/repos/konigio/konig/contributors","subscribers_url":"https://api.github.com/repos/konigio/konig/subscribers","subscription_url":"https://api.github.com/repos/konigio/konig/subscription","commits_url":"https://api.github.com/repos/konigio/konig/commits{/sha}","git_commits_url":"https://api.github.com/repos/konigio/konig/git/commits{/sha}","comments_url":"https://api.github.com/repos/konigio/konig/comments{/number}","issue_comment_url":"https://api.github.com/repos/konigio/konig/issues/comments{/number}","contents_url":"https://api.github.com/repos/konigio/konig/contents/{+path}","compare_url":"https://api.github.com/repos/konigio/konig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/konigio/konig/merges","archive_url":"https://api.github.com/repos/konigio/konig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/konigio/konig/downloads","issues_url":"https://api.github.com/repos/konigio/konig/issues{/number}","pulls_url":"https://api.github.com/repos/konigio/konig/pulls{/number}","milestones_url":"https://api.github.com/repos/konigio/konig/milestones{/number}","notifications_url":"https://api.github.com/repos/konigio/konig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/konigio/konig/labels{/name}","releases_url":"https://api.github.com/repos/konigio/konig/releases{/id}","deployments_url":"https://api.github.com/repos/konigio/konig/deployments","created_at":"2015-12-30T15:42:21Z","updated_at":"2018-04-10T13:54:48Z","pushed_at":"2018-04-12T12:20:30Z","git_url":"git://github.com/konigio/konig.git","ssh_url":"git@github.com:konigio/konig.git","clone_url":"https://github.com/konigio/konig.git","svn_url":"https://github.com/konigio/konig","homepage":null,"size":11744,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":92,"license":null,"forks":2,"open_issues":92,"watchers":4,"default_branch":"master"}},"base":{"label":"konigio:master","ref":"master","sha":"1320f8cf83390012b1d453130009490488e94a8f","user":{"login":"konigio","id":16478118,"avatar_url":"https://avatars2.githubusercontent.com/u/16478118?v=4","gravatar_id":"","url":"https://api.github.com/users/konigio","html_url":"https://github.com/konigio","followers_url":"https://api.github.com/users/konigio/followers","following_url":"https://api.github.com/users/konigio/following{/other_user}","gists_url":"https://api.github.com/users/konigio/gists{/gist_id}","starred_url":"https://api.github.com/users/konigio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konigio/subscriptions","organizations_url":"https://api.github.com/users/konigio/orgs","repos_url":"https://api.github.com/users/konigio/repos","events_url":"https://api.github.com/users/konigio/events{/privacy}","received_events_url":"https://api.github.com/users/konigio/received_events","type":"Organization","site_admin":false},"repo":{"id":48807429,"name":"konig","full_name":"konigio/konig","owner":{"login":"konigio","id":16478118,"avatar_url":"https://avatars2.githubusercontent.com/u/16478118?v=4","gravatar_id":"","url":"https://api.github.com/users/konigio","html_url":"https://github.com/konigio","followers_url":"https://api.github.com/users/konigio/followers","following_url":"https://api.github.com/users/konigio/following{/other_user}","gists_url":"https://api.github.com/users/konigio/gists{/gist_id}","starred_url":"https://api.github.com/users/konigio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/konigio/subscriptions","organizations_url":"https://api.github.com/users/konigio/orgs","repos_url":"https://api.github.com/users/konigio/repos","events_url":"https://api.github.com/users/konigio/events{/privacy}","received_events_url":"https://api.github.com/users/konigio/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/konigio/konig","description":"A collection of tools for semantic modeling","fork":false,"url":"https://api.github.com/repos/konigio/konig","forks_url":"https://api.github.com/repos/konigio/konig/forks","keys_url":"https://api.github.com/repos/konigio/konig/keys{/key_id}","collaborators_url":"https://api.github.com/repos/konigio/konig/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/konigio/konig/teams","hooks_url":"https://api.github.com/repos/konigio/konig/hooks","issue_events_url":"https://api.github.com/repos/konigio/konig/issues/events{/number}","events_url":"https://api.github.com/repos/konigio/konig/events","assignees_url":"https://api.github.com/repos/konigio/konig/assignees{/user}","branches_url":"https://api.github.com/repos/konigio/konig/branches{/branch}","tags_url":"https://api.github.com/repos/konigio/konig/tags","blobs_url":"https://api.github.com/repos/konigio/konig/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/konigio/konig/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/konigio/konig/git/refs{/sha}","trees_url":"https://api.github.com/repos/konigio/konig/git/trees{/sha}","statuses_url":"https://api.github.com/repos/konigio/konig/statuses/{sha}","languages_url":"https://api.github.com/repos/konigio/konig/languages","stargazers_url":"https://api.github.com/repos/konigio/konig/stargazers","contributors_url":"https://api.github.com/repos/konigio/konig/contributors","subscribers_url":"https://api.github.com/repos/konigio/konig/subscribers","subscription_url":"https://api.github.com/repos/konigio/konig/subscription","commits_url":"https://api.github.com/repos/konigio/konig/commits{/sha}","git_commits_url":"https://api.github.com/repos/konigio/konig/git/commits{/sha}","comments_url":"https://api.github.com/repos/konigio/konig/comments{/number}","issue_comment_url":"https://api.github.com/repos/konigio/konig/issues/comments{/number}","contents_url":"https://api.github.com/repos/konigio/konig/contents/{+path}","compare_url":"https://api.github.com/repos/konigio/konig/compare/{base}...{head}","merges_url":"https://api.github.com/repos/konigio/konig/merges","archive_url":"https://api.github.com/repos/konigio/konig/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/konigio/konig/downloads","issues_url":"https://api.github.com/repos/konigio/konig/issues{/number}","pulls_url":"https://api.github.com/repos/konigio/konig/pulls{/number}","milestones_url":"https://api.github.com/repos/konigio/konig/milestones{/number}","notifications_url":"https://api.github.com/repos/konigio/konig/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/konigio/konig/labels{/name}","releases_url":"https://api.github.com/repos/konigio/konig/releases{/id}","deployments_url":"https://api.github.com/repos/konigio/konig/deployments","created_at":"2015-12-30T15:42:21Z","updated_at":"2018-04-10T13:54:48Z","pushed_at":"2018-04-12T12:20:30Z","git_url":"git://github.com/konigio/konig.git","ssh_url":"git@github.com:konigio/konig.git","clone_url":"https://github.com/konigio/konig.git","svn_url":"https://github.com/konigio/konig","homepage":null,"size":11744,"stargazers_count":4,"watchers_count":4,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":2,"mirror_url":null,"archived":false,"open_issues_count":92,"license":null,"forks":2,"open_issues":92,"watchers":4,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/konigio/konig/pulls/831"},"html":{"href":"https://github.com/konigio/konig/pull/831"},"issue":{"href":"https://api.github.com/repos/konigio/konig/issues/831"},"comments":{"href":"https://api.github.com/repos/konigio/konig/issues/831/comments"},"review_comments":{"href":"https://api.github.com/repos/konigio/konig/pulls/831/comments"},"review_comment":{"href":"https://api.github.com/repos/konigio/konig/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/konigio/konig/pulls/831/commits"},"statuses":{"href":"https://api.github.com/repos/konigio/konig/statuses/d33d13bd92003478dc6169725e7513ccbb0be287"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"gmcfall"}}