{"action":"created","comment":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/217850198","pull_request_review_id":155672163,"id":217850198,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNzg1MDE5OA==","diff_hunk":"@@ -0,0 +1,68 @@\n+/*\n+Base Copyright 2017 Luiz Ribeiro <luizribeiro@gmail.com>\n+Modified 2017 Andrew Novak <ndrw.nvk@gmail.com>\n+Modified 2018 Anthony Wharton <th3ant@gmail.com>\n+\n+This program is free software: you can redistribute it and/or modify\n+it under the terms of the GNU General Public License as published by\n+the Free Software Foundation, either version 2 of the License, or\n+(at your option) any later version.\n+\n+This program is distributed in the hope that it will be useful,\n+but WITHOUT ANY WARRANTY; without even the implied warranty of\n+MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n+GNU General Public License for more details.\n+\n+You should have received a copy of the GNU General Public LicensezZZ\n+along with this program.  If not, see <http://www.gnu.org/licenses/>.\n+*/\n+\n+#include QMK_KEYBOARD_H\n+\n+#define ______ KC_TRNS","path":"keyboards/ymd96/keymaps/AnthonyWharton/keymap.c","position":22,"original_position":22,"commit_id":"55a631d83c3f69f1704fbdf821c9843cb6075609","original_commit_id":"55e9619ba7dcd4dc1902a8d023d51a828c1b9ded","user":{"login":"AnthonyWharton","id":7091722,"node_id":"MDQ6VXNlcjcwOTE3MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7091722?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyWharton","html_url":"https://github.com/AnthonyWharton","followers_url":"https://api.github.com/users/AnthonyWharton/followers","following_url":"https://api.github.com/users/AnthonyWharton/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyWharton/subscriptions","organizations_url":"https://api.github.com/users/AnthonyWharton/orgs","repos_url":"https://api.github.com/users/AnthonyWharton/repos","events_url":"https://api.github.com/users/AnthonyWharton/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyWharton/received_events","type":"User","site_admin":false},"body":"Got it, will take a moment to reformat. I was just following [the documentation here](https://beta.docs.qmk.fm/detailed-guides/keymap#anatomy-of-a-keymap-c) which defines a similar macro, which may or may not be out of date? I did wonder why there was conflicting info, but I'll switch it over. If that documentation is out of date, where could I submit a change to this?","created_at":"2018-09-14T21:44:24Z","updated_at":"2018-09-14T21:44:24Z","html_url":"https://github.com/qmk/qmk_firmware/pull/3908#discussion_r217850198","pull_request_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/3908","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments/217850198"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/3908#discussion_r217850198"},"pull_request":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/3908"}},"in_reply_to_id":217840949},"pull_request":{"url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/3908","id":215621206,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE1NjIxMjA2","html_url":"https://github.com/qmk/qmk_firmware/pull/3908","diff_url":"https://github.com/qmk/qmk_firmware/pull/3908.diff","patch_url":"https://github.com/qmk/qmk_firmware/pull/3908.patch","issue_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/3908","number":3908,"state":"open","locked":false,"title":"Add YMD96 instructions for Linux + Backlight Fixes","user":{"login":"AnthonyWharton","id":7091722,"node_id":"MDQ6VXNlcjcwOTE3MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7091722?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyWharton","html_url":"https://github.com/AnthonyWharton","followers_url":"https://api.github.com/users/AnthonyWharton/followers","following_url":"https://api.github.com/users/AnthonyWharton/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyWharton/subscriptions","organizations_url":"https://api.github.com/users/AnthonyWharton/orgs","repos_url":"https://api.github.com/users/AnthonyWharton/repos","events_url":"https://api.github.com/users/AnthonyWharton/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyWharton/received_events","type":"User","site_admin":false},"body":"Added some help  for Linux users to flash compiled firmware onto the YMD96 board.\r\n\r\nAlso fixed the make instruction from `make ymd96-default` to `make ymd96:default`.","created_at":"2018-09-14T14:55:49Z","updated_at":"2018-09-14T21:44:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29e708dd39af2efc23051e025144f5204e7464a2","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/3908/commits","review_comments_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/3908/comments","review_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/3908/comments","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/55a631d83c3f69f1704fbdf821c9843cb6075609","head":{"label":"AnthonyWharton:ymd96_readmefix","ref":"ymd96_readmefix","sha":"55a631d83c3f69f1704fbdf821c9843cb6075609","user":{"login":"AnthonyWharton","id":7091722,"node_id":"MDQ6VXNlcjcwOTE3MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7091722?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyWharton","html_url":"https://github.com/AnthonyWharton","followers_url":"https://api.github.com/users/AnthonyWharton/followers","following_url":"https://api.github.com/users/AnthonyWharton/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyWharton/subscriptions","organizations_url":"https://api.github.com/users/AnthonyWharton/orgs","repos_url":"https://api.github.com/users/AnthonyWharton/repos","events_url":"https://api.github.com/users/AnthonyWharton/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyWharton/received_events","type":"User","site_admin":false},"repo":{"id":148780792,"node_id":"MDEwOlJlcG9zaXRvcnkxNDg3ODA3OTI=","name":"qmk_firmware","full_name":"AnthonyWharton/qmk_firmware","owner":{"login":"AnthonyWharton","id":7091722,"node_id":"MDQ6VXNlcjcwOTE3MjI=","avatar_url":"https://avatars0.githubusercontent.com/u/7091722?v=4","gravatar_id":"","url":"https://api.github.com/users/AnthonyWharton","html_url":"https://github.com/AnthonyWharton","followers_url":"https://api.github.com/users/AnthonyWharton/followers","following_url":"https://api.github.com/users/AnthonyWharton/following{/other_user}","gists_url":"https://api.github.com/users/AnthonyWharton/gists{/gist_id}","starred_url":"https://api.github.com/users/AnthonyWharton/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/AnthonyWharton/subscriptions","organizations_url":"https://api.github.com/users/AnthonyWharton/orgs","repos_url":"https://api.github.com/users/AnthonyWharton/repos","events_url":"https://api.github.com/users/AnthonyWharton/events{/privacy}","received_events_url":"https://api.github.com/users/AnthonyWharton/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/AnthonyWharton/qmk_firmware","description":"Fork maintained for my own personal configs. Currently only ymd96.","fork":true,"url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware","forks_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/forks","keys_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/events","assignees_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/merges","archive_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/AnthonyWharton/qmk_firmware/deployments","created_at":"2018-09-14T11:42:28Z","updated_at":"2018-09-14T11:45:36Z","pushed_at":"2018-09-14T21:38:27Z","git_url":"git://github.com/AnthonyWharton/qmk_firmware.git","ssh_url":"git@github.com:AnthonyWharton/qmk_firmware.git","clone_url":"https://github.com/AnthonyWharton/qmk_firmware.git","svn_url":"https://github.com/AnthonyWharton/qmk_firmware","homepage":"http://qmk.fm","size":100502,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"qmk:master","ref":"master","sha":"48a992f1c037658bbacccefd2709ffdcda8bb345","user":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"repo":{"id":27737393,"node_id":"MDEwOlJlcG9zaXRvcnkyNzczNzM5Mw==","name":"qmk_firmware","full_name":"qmk/qmk_firmware","owner":{"login":"qmk","id":25358678,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI1MzU4Njc4","avatar_url":"https://avatars3.githubusercontent.com/u/25358678?v=4","gravatar_id":"","url":"https://api.github.com/users/qmk","html_url":"https://github.com/qmk","followers_url":"https://api.github.com/users/qmk/followers","following_url":"https://api.github.com/users/qmk/following{/other_user}","gists_url":"https://api.github.com/users/qmk/gists{/gist_id}","starred_url":"https://api.github.com/users/qmk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qmk/subscriptions","organizations_url":"https://api.github.com/users/qmk/orgs","repos_url":"https://api.github.com/users/qmk/repos","events_url":"https://api.github.com/users/qmk/events{/privacy}","received_events_url":"https://api.github.com/users/qmk/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/qmk/qmk_firmware","description":"keyboard controller firmware for Atmel AVR and ARM USB families","fork":false,"url":"https://api.github.com/repos/qmk/qmk_firmware","forks_url":"https://api.github.com/repos/qmk/qmk_firmware/forks","keys_url":"https://api.github.com/repos/qmk/qmk_firmware/keys{/key_id}","collaborators_url":"https://api.github.com/repos/qmk/qmk_firmware/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/qmk/qmk_firmware/teams","hooks_url":"https://api.github.com/repos/qmk/qmk_firmware/hooks","issue_events_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/events{/number}","events_url":"https://api.github.com/repos/qmk/qmk_firmware/events","assignees_url":"https://api.github.com/repos/qmk/qmk_firmware/assignees{/user}","branches_url":"https://api.github.com/repos/qmk/qmk_firmware/branches{/branch}","tags_url":"https://api.github.com/repos/qmk/qmk_firmware/tags","blobs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/qmk/qmk_firmware/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/qmk/qmk_firmware/git/refs{/sha}","trees_url":"https://api.github.com/repos/qmk/qmk_firmware/git/trees{/sha}","statuses_url":"https://api.github.com/repos/qmk/qmk_firmware/statuses/{sha}","languages_url":"https://api.github.com/repos/qmk/qmk_firmware/languages","stargazers_url":"https://api.github.com/repos/qmk/qmk_firmware/stargazers","contributors_url":"https://api.github.com/repos/qmk/qmk_firmware/contributors","subscribers_url":"https://api.github.com/repos/qmk/qmk_firmware/subscribers","subscription_url":"https://api.github.com/repos/qmk/qmk_firmware/subscription","commits_url":"https://api.github.com/repos/qmk/qmk_firmware/commits{/sha}","git_commits_url":"https://api.github.com/repos/qmk/qmk_firmware/git/commits{/sha}","comments_url":"https://api.github.com/repos/qmk/qmk_firmware/comments{/number}","issue_comment_url":"https://api.github.com/repos/qmk/qmk_firmware/issues/comments{/number}","contents_url":"https://api.github.com/repos/qmk/qmk_firmware/contents/{+path}","compare_url":"https://api.github.com/repos/qmk/qmk_firmware/compare/{base}...{head}","merges_url":"https://api.github.com/repos/qmk/qmk_firmware/merges","archive_url":"https://api.github.com/repos/qmk/qmk_firmware/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/qmk/qmk_firmware/downloads","issues_url":"https://api.github.com/repos/qmk/qmk_firmware/issues{/number}","pulls_url":"https://api.github.com/repos/qmk/qmk_firmware/pulls{/number}","milestones_url":"https://api.github.com/repos/qmk/qmk_firmware/milestones{/number}","notifications_url":"https://api.github.com/repos/qmk/qmk_firmware/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/qmk/qmk_firmware/labels{/name}","releases_url":"https://api.github.com/repos/qmk/qmk_firmware/releases{/id}","deployments_url":"https://api.github.com/repos/qmk/qmk_firmware/deployments","created_at":"2014-12-08T22:02:05Z","updated_at":"2018-09-14T18:48:52Z","pushed_at":"2018-09-14T21:38:29Z","git_url":"git://github.com/qmk/qmk_firmware.git","ssh_url":"git@github.com:qmk/qmk_firmware.git","clone_url":"https://github.com/qmk/qmk_firmware.git","svn_url":"https://github.com/qmk/qmk_firmware","homepage":"http://qmk.fm","size":100318,"stargazers_count":2959,"watchers_count":2959,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5437,"mirror_url":null,"archived":false,"open_issues_count":364,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":5437,"open_issues":364,"watchers":2959,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/3908"},"html":{"href":"https://github.com/qmk/qmk_firmware/pull/3908"},"issue":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/3908"},"comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/issues/3908/comments"},"review_comments":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/3908/comments"},"review_comment":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/qmk/qmk_firmware/pulls/3908/commits"},"statuses":{"href":"https://api.github.com/repos/qmk/qmk_firmware/statuses/55a631d83c3f69f1704fbdf821c9843cb6075609"}},"author_association":"NONE"}}
{"actor":{"display_login":"AnthonyWharton"}}