{"action":"opened","number":2130,"pull_request":{"url":"https://api.github.com/repos/lhc70000/iina/pulls/2130","id":238909801,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4OTA5ODAx","html_url":"https://github.com/lhc70000/iina/pull/2130","diff_url":"https://github.com/lhc70000/iina/pull/2130.diff","patch_url":"https://github.com/lhc70000/iina/pull/2130.patch","issue_url":"https://api.github.com/repos/lhc70000/iina/issues/2130","number":2130,"state":"open","locked":false,"title":"Fix nil unwrap in SubPopoverViewController.playerCore.getter","user":{"login":"anohren","id":3519879,"node_id":"MDQ6VXNlcjM1MTk4Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3519879?v=4","gravatar_id":"","url":"https://api.github.com/users/anohren","html_url":"https://github.com/anohren","followers_url":"https://api.github.com/users/anohren/followers","following_url":"https://api.github.com/users/anohren/following{/other_user}","gists_url":"https://api.github.com/users/anohren/gists{/gist_id}","starred_url":"https://api.github.com/users/anohren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anohren/subscriptions","organizations_url":"https://api.github.com/users/anohren/orgs","repos_url":"https://api.github.com/users/anohren/repos","events_url":"https://api.github.com/users/anohren/events{/privacy}","received_events_url":"https://api.github.com/users/anohren/received_events","type":"User","site_admin":false},"body":"Threw a couple question marks at a crash report, since the code was already prepared for nil everywhere.\r\n\r\nException Type:        EXC_BAD_INSTRUCTION (SIGILL)\r\nException Codes:       0x0000000000000001, 0x0000000000000000\r\nException Note:        EXC_CORPSE_NOTIFY\r\n\r\nTermination Signal:    Illegal instruction: 4\r\nTermination Reason:    Namespace SIGNAL, Code 0x4\r\nTerminating Process:   exc handler [26767]\r\n\r\nThread 0 Crashed:: Dispatch queue: com.apple.main-thread\r\n0   com.colliderli.iina           \t0x000000010664ce50 closure #1 in SubPopoverViewController.playerCore.getter + 208\r\n1   com.colliderli.iina           \t0x0000000106655255 specialized SubPopoverViewController.numberOfRows(in:) + 53\r\n2   com.colliderli.iina           \t0x000000010664c376 @objc SubPopoverViewController.numberOfRows(in:) + 38","created_at":"2018-12-15T12:58:24Z","updated_at":"2018-12-15T12:58:24Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lhc70000/iina/pulls/2130/commits","review_comments_url":"https://api.github.com/repos/lhc70000/iina/pulls/2130/comments","review_comment_url":"https://api.github.com/repos/lhc70000/iina/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lhc70000/iina/issues/2130/comments","statuses_url":"https://api.github.com/repos/lhc70000/iina/statuses/0cf6b5dd9b11d366758a635a0da0a1c5cc8c118b","head":{"label":"anohren:release/1.0.0","ref":"release/1.0.0","sha":"0cf6b5dd9b11d366758a635a0da0a1c5cc8c118b","user":{"login":"anohren","id":3519879,"node_id":"MDQ6VXNlcjM1MTk4Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3519879?v=4","gravatar_id":"","url":"https://api.github.com/users/anohren","html_url":"https://github.com/anohren","followers_url":"https://api.github.com/users/anohren/followers","following_url":"https://api.github.com/users/anohren/following{/other_user}","gists_url":"https://api.github.com/users/anohren/gists{/gist_id}","starred_url":"https://api.github.com/users/anohren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anohren/subscriptions","organizations_url":"https://api.github.com/users/anohren/orgs","repos_url":"https://api.github.com/users/anohren/repos","events_url":"https://api.github.com/users/anohren/events{/privacy}","received_events_url":"https://api.github.com/users/anohren/received_events","type":"User","site_admin":false},"repo":{"id":158157756,"node_id":"MDEwOlJlcG9zaXRvcnkxNTgxNTc3NTY=","name":"iina","full_name":"anohren/iina","private":false,"owner":{"login":"anohren","id":3519879,"node_id":"MDQ6VXNlcjM1MTk4Nzk=","avatar_url":"https://avatars0.githubusercontent.com/u/3519879?v=4","gravatar_id":"","url":"https://api.github.com/users/anohren","html_url":"https://github.com/anohren","followers_url":"https://api.github.com/users/anohren/followers","following_url":"https://api.github.com/users/anohren/following{/other_user}","gists_url":"https://api.github.com/users/anohren/gists{/gist_id}","starred_url":"https://api.github.com/users/anohren/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/anohren/subscriptions","organizations_url":"https://api.github.com/users/anohren/orgs","repos_url":"https://api.github.com/users/anohren/repos","events_url":"https://api.github.com/users/anohren/events{/privacy}","received_events_url":"https://api.github.com/users/anohren/received_events","type":"User","site_admin":false},"html_url":"https://github.com/anohren/iina","description":"The modern video player for macOS.","fork":true,"url":"https://api.github.com/repos/anohren/iina","forks_url":"https://api.github.com/repos/anohren/iina/forks","keys_url":"https://api.github.com/repos/anohren/iina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/anohren/iina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/anohren/iina/teams","hooks_url":"https://api.github.com/repos/anohren/iina/hooks","issue_events_url":"https://api.github.com/repos/anohren/iina/issues/events{/number}","events_url":"https://api.github.com/repos/anohren/iina/events","assignees_url":"https://api.github.com/repos/anohren/iina/assignees{/user}","branches_url":"https://api.github.com/repos/anohren/iina/branches{/branch}","tags_url":"https://api.github.com/repos/anohren/iina/tags","blobs_url":"https://api.github.com/repos/anohren/iina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/anohren/iina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/anohren/iina/git/refs{/sha}","trees_url":"https://api.github.com/repos/anohren/iina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/anohren/iina/statuses/{sha}","languages_url":"https://api.github.com/repos/anohren/iina/languages","stargazers_url":"https://api.github.com/repos/anohren/iina/stargazers","contributors_url":"https://api.github.com/repos/anohren/iina/contributors","subscribers_url":"https://api.github.com/repos/anohren/iina/subscribers","subscription_url":"https://api.github.com/repos/anohren/iina/subscription","commits_url":"https://api.github.com/repos/anohren/iina/commits{/sha}","git_commits_url":"https://api.github.com/repos/anohren/iina/git/commits{/sha}","comments_url":"https://api.github.com/repos/anohren/iina/comments{/number}","issue_comment_url":"https://api.github.com/repos/anohren/iina/issues/comments{/number}","contents_url":"https://api.github.com/repos/anohren/iina/contents/{+path}","compare_url":"https://api.github.com/repos/anohren/iina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/anohren/iina/merges","archive_url":"https://api.github.com/repos/anohren/iina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/anohren/iina/downloads","issues_url":"https://api.github.com/repos/anohren/iina/issues{/number}","pulls_url":"https://api.github.com/repos/anohren/iina/pulls{/number}","milestones_url":"https://api.github.com/repos/anohren/iina/milestones{/number}","notifications_url":"https://api.github.com/repos/anohren/iina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/anohren/iina/labels{/name}","releases_url":"https://api.github.com/repos/anohren/iina/releases{/id}","deployments_url":"https://api.github.com/repos/anohren/iina/deployments","created_at":"2018-11-19T03:38:58Z","updated_at":"2018-11-19T03:39:03Z","pushed_at":"2018-12-15T12:56:19Z","git_url":"git://github.com/anohren/iina.git","ssh_url":"git@github.com:anohren/iina.git","clone_url":"https://github.com/anohren/iina.git","svn_url":"https://github.com/anohren/iina","homepage":"https://lhc70000.github.io/iina/","size":228247,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"lhc70000:release/1.0.0","ref":"release/1.0.0","sha":"45e45c43048e0d1148a1e4226e4b13946652f7e8","user":{"login":"lhc70000","id":8478049,"node_id":"MDQ6VXNlcjg0NzgwNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8478049?v=4","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"repo":{"id":76838017,"node_id":"MDEwOlJlcG9zaXRvcnk3NjgzODAxNw==","name":"iina","full_name":"lhc70000/iina","private":false,"owner":{"login":"lhc70000","id":8478049,"node_id":"MDQ6VXNlcjg0NzgwNDk=","avatar_url":"https://avatars3.githubusercontent.com/u/8478049?v=4","gravatar_id":"","url":"https://api.github.com/users/lhc70000","html_url":"https://github.com/lhc70000","followers_url":"https://api.github.com/users/lhc70000/followers","following_url":"https://api.github.com/users/lhc70000/following{/other_user}","gists_url":"https://api.github.com/users/lhc70000/gists{/gist_id}","starred_url":"https://api.github.com/users/lhc70000/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lhc70000/subscriptions","organizations_url":"https://api.github.com/users/lhc70000/orgs","repos_url":"https://api.github.com/users/lhc70000/repos","events_url":"https://api.github.com/users/lhc70000/events{/privacy}","received_events_url":"https://api.github.com/users/lhc70000/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lhc70000/iina","description":"The modern video player for macOS.","fork":false,"url":"https://api.github.com/repos/lhc70000/iina","forks_url":"https://api.github.com/repos/lhc70000/iina/forks","keys_url":"https://api.github.com/repos/lhc70000/iina/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lhc70000/iina/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lhc70000/iina/teams","hooks_url":"https://api.github.com/repos/lhc70000/iina/hooks","issue_events_url":"https://api.github.com/repos/lhc70000/iina/issues/events{/number}","events_url":"https://api.github.com/repos/lhc70000/iina/events","assignees_url":"https://api.github.com/repos/lhc70000/iina/assignees{/user}","branches_url":"https://api.github.com/repos/lhc70000/iina/branches{/branch}","tags_url":"https://api.github.com/repos/lhc70000/iina/tags","blobs_url":"https://api.github.com/repos/lhc70000/iina/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lhc70000/iina/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lhc70000/iina/git/refs{/sha}","trees_url":"https://api.github.com/repos/lhc70000/iina/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lhc70000/iina/statuses/{sha}","languages_url":"https://api.github.com/repos/lhc70000/iina/languages","stargazers_url":"https://api.github.com/repos/lhc70000/iina/stargazers","contributors_url":"https://api.github.com/repos/lhc70000/iina/contributors","subscribers_url":"https://api.github.com/repos/lhc70000/iina/subscribers","subscription_url":"https://api.github.com/repos/lhc70000/iina/subscription","commits_url":"https://api.github.com/repos/lhc70000/iina/commits{/sha}","git_commits_url":"https://api.github.com/repos/lhc70000/iina/git/commits{/sha}","comments_url":"https://api.github.com/repos/lhc70000/iina/comments{/number}","issue_comment_url":"https://api.github.com/repos/lhc70000/iina/issues/comments{/number}","contents_url":"https://api.github.com/repos/lhc70000/iina/contents/{+path}","compare_url":"https://api.github.com/repos/lhc70000/iina/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lhc70000/iina/merges","archive_url":"https://api.github.com/repos/lhc70000/iina/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lhc70000/iina/downloads","issues_url":"https://api.github.com/repos/lhc70000/iina/issues{/number}","pulls_url":"https://api.github.com/repos/lhc70000/iina/pulls{/number}","milestones_url":"https://api.github.com/repos/lhc70000/iina/milestones{/number}","notifications_url":"https://api.github.com/repos/lhc70000/iina/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lhc70000/iina/labels{/name}","releases_url":"https://api.github.com/repos/lhc70000/iina/releases{/id}","deployments_url":"https://api.github.com/repos/lhc70000/iina/deployments","created_at":"2016-12-19T07:18:45Z","updated_at":"2018-12-15T10:16:23Z","pushed_at":"2018-12-14T15:17:22Z","git_url":"git://github.com/lhc70000/iina.git","ssh_url":"git@github.com:lhc70000/iina.git","clone_url":"https://github.com/lhc70000/iina.git","svn_url":"https://github.com/lhc70000/iina","homepage":"https://lhc70000.github.io/iina/","size":228217,"stargazers_count":14928,"watchers_count":14928,"language":"Swift","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":1155,"mirror_url":null,"archived":false,"open_issues_count":475,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1155,"open_issues":475,"watchers":14928,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/2130"},"html":{"href":"https://github.com/lhc70000/iina/pull/2130"},"issue":{"href":"https://api.github.com/repos/lhc70000/iina/issues/2130"},"comments":{"href":"https://api.github.com/repos/lhc70000/iina/issues/2130/comments"},"review_comments":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/2130/comments"},"review_comment":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lhc70000/iina/pulls/2130/commits"},"statuses":{"href":"https://api.github.com/repos/lhc70000/iina/statuses/0cf6b5dd9b11d366758a635a0da0a1c5cc8c118b"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":7,"deletions":7,"changed_files":1}}
{"actor":{"display_login":"anohren"}}