{"action":"created","comment":{"url":"https://api.github.com/repos/pagarme/artis/pulls/comments/168477747","pull_request_review_id":96849479,"id":168477747,"diff_hunk":"@@ -1,54 +1,36 @@\n const path = require('path')\n const webpack = require('webpack')\n-const HtmlWebpackPlugin = require('html-webpack-plugin')","path":"webapp/config/webpack.config.prod.js","position":3,"original_position":3,"commit_id":"821c27da3a5bfbae8d65f7a0c1c6d08fdbd62c5d","original_commit_id":"821c27da3a5bfbae8d65f7a0c1c6d08fdbd62c5d","user":{"login":"vcapretz","id":14620121,"avatar_url":"https://avatars3.githubusercontent.com/u/14620121?v=4","gravatar_id":"","url":"https://api.github.com/users/vcapretz","html_url":"https://github.com/vcapretz","followers_url":"https://api.github.com/users/vcapretz/followers","following_url":"https://api.github.com/users/vcapretz/following{/other_user}","gists_url":"https://api.github.com/users/vcapretz/gists{/gist_id}","starred_url":"https://api.github.com/users/vcapretz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vcapretz/subscriptions","organizations_url":"https://api.github.com/users/vcapretz/orgs","repos_url":"https://api.github.com/users/vcapretz/repos","events_url":"https://api.github.com/users/vcapretz/events{/privacy}","received_events_url":"https://api.github.com/users/vcapretz/received_events","type":"User","site_admin":false},"body":"why don't we need these plugins? How did you do without them? \r\n\r\nI'm asking because HtmlWebpackPlugin inserts the build file to the `.html` file, but without it we would have to do it manually, right? \r\n\r\nAnd if we can actually remove these packages, don't forget to also remove them from the dependencies list in `package.json` (and to run yarn after that) ","created_at":"2018-02-15T13:42:40Z","updated_at":"2018-02-15T13:42:40Z","html_url":"https://github.com/pagarme/artis/pull/131#discussion_r168477747","pull_request_url":"https://api.github.com/repos/pagarme/artis/pulls/131","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pagarme/artis/pulls/comments/168477747"},"html":{"href":"https://github.com/pagarme/artis/pull/131#discussion_r168477747"},"pull_request":{"href":"https://api.github.com/repos/pagarme/artis/pulls/131"}}},"pull_request":{"url":"https://api.github.com/repos/pagarme/artis/pulls/131","id":169206698,"html_url":"https://github.com/pagarme/artis/pull/131","diff_url":"https://github.com/pagarme/artis/pull/131.diff","patch_url":"https://github.com/pagarme/artis/pull/131.patch","issue_url":"https://api.github.com/repos/pagarme/artis/issues/131","number":131,"state":"open","locked":false,"title":"Build production","user":{"login":"augusto-jm-amaral","id":10222646,"avatar_url":"https://avatars1.githubusercontent.com/u/10222646?v=4","gravatar_id":"","url":"https://api.github.com/users/augusto-jm-amaral","html_url":"https://github.com/augusto-jm-amaral","followers_url":"https://api.github.com/users/augusto-jm-amaral/followers","following_url":"https://api.github.com/users/augusto-jm-amaral/following{/other_user}","gists_url":"https://api.github.com/users/augusto-jm-amaral/gists{/gist_id}","starred_url":"https://api.github.com/users/augusto-jm-amaral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/augusto-jm-amaral/subscriptions","organizations_url":"https://api.github.com/users/augusto-jm-amaral/orgs","repos_url":"https://api.github.com/users/augusto-jm-amaral/repos","events_url":"https://api.github.com/users/augusto-jm-amaral/events{/privacy}","received_events_url":"https://api.github.com/users/augusto-jm-amaral/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\nRefactor production build script.\r\n\r\nFor test: https://github.com/augusto-jm-amaral/artis-build-test\r\n\r\n<!-- Write a brief and explicative description of your pull request. -->\r\n\r\nCloses https://github.com/pagarme/mercurio/issues/46\r\n<!--\r\nThings to cite on the PR description:\r\n\r\n- Why is the PR needed\r\n- What the PR does\r\n- What are possible side effects\r\n- Additional information (related github issues, links, etc)\r\n\r\n  Example: This PR implements feature \"x\" so we can solve our payments problem. This PR closes #98928312874 (github issue)\r\n-->\r\n\r\n## Your checklist for this pull request\r\n\r\n:rotating_light: Please review this items for a good pull request. :four_leaf_clover:\r\n\r\n1. I've read the project's [Contributing Guidelines](CONTRIBUTING.md)\r\n1. My commits are well written and follow [pagarme/git-style-guide](https://github.com/pagarme/git-style-guide)\r\n1. My changes are well covered by **tests** and **logs**\r\n1. I've updated the project docs (if needed)\r\n1. I fell safe about this implementation\r\n\r\nIn a good pull request, everything above is true :relaxed:\r\n","created_at":"2018-02-14T19:55:38Z","updated_at":"2018-02-15T13:42:40Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0d3a30831346c16768e5464672f3549bc883bddc","assignee":{"login":"augusto-jm-amaral","id":10222646,"avatar_url":"https://avatars1.githubusercontent.com/u/10222646?v=4","gravatar_id":"","url":"https://api.github.com/users/augusto-jm-amaral","html_url":"https://github.com/augusto-jm-amaral","followers_url":"https://api.github.com/users/augusto-jm-amaral/followers","following_url":"https://api.github.com/users/augusto-jm-amaral/following{/other_user}","gists_url":"https://api.github.com/users/augusto-jm-amaral/gists{/gist_id}","starred_url":"https://api.github.com/users/augusto-jm-amaral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/augusto-jm-amaral/subscriptions","organizations_url":"https://api.github.com/users/augusto-jm-amaral/orgs","repos_url":"https://api.github.com/users/augusto-jm-amaral/repos","events_url":"https://api.github.com/users/augusto-jm-amaral/events{/privacy}","received_events_url":"https://api.github.com/users/augusto-jm-amaral/received_events","type":"User","site_admin":false},"assignees":[{"login":"augusto-jm-amaral","id":10222646,"avatar_url":"https://avatars1.githubusercontent.com/u/10222646?v=4","gravatar_id":"","url":"https://api.github.com/users/augusto-jm-amaral","html_url":"https://github.com/augusto-jm-amaral","followers_url":"https://api.github.com/users/augusto-jm-amaral/followers","following_url":"https://api.github.com/users/augusto-jm-amaral/following{/other_user}","gists_url":"https://api.github.com/users/augusto-jm-amaral/gists{/gist_id}","starred_url":"https://api.github.com/users/augusto-jm-amaral/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/augusto-jm-amaral/subscriptions","organizations_url":"https://api.github.com/users/augusto-jm-amaral/orgs","repos_url":"https://api.github.com/users/augusto-jm-amaral/repos","events_url":"https://api.github.com/users/augusto-jm-amaral/events{/privacy}","received_events_url":"https://api.github.com/users/augusto-jm-amaral/received_events","type":"User","site_admin":false}],"requested_reviewers":[{"login":"allangrds","id":4103305,"avatar_url":"https://avatars1.githubusercontent.com/u/4103305?v=4","gravatar_id":"","url":"https://api.github.com/users/allangrds","html_url":"https://github.com/allangrds","followers_url":"https://api.github.com/users/allangrds/followers","following_url":"https://api.github.com/users/allangrds/following{/other_user}","gists_url":"https://api.github.com/users/allangrds/gists{/gist_id}","starred_url":"https://api.github.com/users/allangrds/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/allangrds/subscriptions","organizations_url":"https://api.github.com/users/allangrds/orgs","repos_url":"https://api.github.com/users/allangrds/repos","events_url":"https://api.github.com/users/allangrds/events{/privacy}","received_events_url":"https://api.github.com/users/allangrds/received_events","type":"User","site_admin":false},{"login":"thiagommedeiros","id":19213244,"avatar_url":"https://avatars0.githubusercontent.com/u/19213244?v=4","gravatar_id":"","url":"https://api.github.com/users/thiagommedeiros","html_url":"https://github.com/thiagommedeiros","followers_url":"https://api.github.com/users/thiagommedeiros/followers","following_url":"https://api.github.com/users/thiagommedeiros/following{/other_user}","gists_url":"https://api.github.com/users/thiagommedeiros/gists{/gist_id}","starred_url":"https://api.github.com/users/thiagommedeiros/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thiagommedeiros/subscriptions","organizations_url":"https://api.github.com/users/thiagommedeiros/orgs","repos_url":"https://api.github.com/users/thiagommedeiros/repos","events_url":"https://api.github.com/users/thiagommedeiros/events{/privacy}","received_events_url":"https://api.github.com/users/thiagommedeiros/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":762485681,"url":"https://api.github.com/repos/pagarme/artis/labels/waiting%20review","name":"waiting review","color":"fbca04","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pagarme/artis/pulls/131/commits","review_comments_url":"https://api.github.com/repos/pagarme/artis/pulls/131/comments","review_comment_url":"https://api.github.com/repos/pagarme/artis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pagarme/artis/issues/131/comments","statuses_url":"https://api.github.com/repos/pagarme/artis/statuses/821c27da3a5bfbae8d65f7a0c1c6d08fdbd62c5d","head":{"label":"pagarme:build-prod","ref":"build-prod","sha":"821c27da3a5bfbae8d65f7a0c1c6d08fdbd62c5d","user":{"login":"pagarme","id":3846050,"avatar_url":"https://avatars2.githubusercontent.com/u/3846050?v=4","gravatar_id":"","url":"https://api.github.com/users/pagarme","html_url":"https://github.com/pagarme","followers_url":"https://api.github.com/users/pagarme/followers","following_url":"https://api.github.com/users/pagarme/following{/other_user}","gists_url":"https://api.github.com/users/pagarme/gists{/gist_id}","starred_url":"https://api.github.com/users/pagarme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagarme/subscriptions","organizations_url":"https://api.github.com/users/pagarme/orgs","repos_url":"https://api.github.com/users/pagarme/repos","events_url":"https://api.github.com/users/pagarme/events{/privacy}","received_events_url":"https://api.github.com/users/pagarme/received_events","type":"Organization","site_admin":false},"repo":{"id":104494408,"name":"artis","full_name":"pagarme/artis","owner":{"login":"pagarme","id":3846050,"avatar_url":"https://avatars2.githubusercontent.com/u/3846050?v=4","gravatar_id":"","url":"https://api.github.com/users/pagarme","html_url":"https://github.com/pagarme","followers_url":"https://api.github.com/users/pagarme/followers","following_url":"https://api.github.com/users/pagarme/following{/other_user}","gists_url":"https://api.github.com/users/pagarme/gists{/gist_id}","starred_url":"https://api.github.com/users/pagarme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagarme/subscriptions","organizations_url":"https://api.github.com/users/pagarme/orgs","repos_url":"https://api.github.com/users/pagarme/repos","events_url":"https://api.github.com/users/pagarme/events{/privacy}","received_events_url":"https://api.github.com/users/pagarme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagarme/artis","description":":credit_card: Projeto de Checkout desenvolvido em parceria entre MundiPagg e Pagar.me.","fork":false,"url":"https://api.github.com/repos/pagarme/artis","forks_url":"https://api.github.com/repos/pagarme/artis/forks","keys_url":"https://api.github.com/repos/pagarme/artis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagarme/artis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagarme/artis/teams","hooks_url":"https://api.github.com/repos/pagarme/artis/hooks","issue_events_url":"https://api.github.com/repos/pagarme/artis/issues/events{/number}","events_url":"https://api.github.com/repos/pagarme/artis/events","assignees_url":"https://api.github.com/repos/pagarme/artis/assignees{/user}","branches_url":"https://api.github.com/repos/pagarme/artis/branches{/branch}","tags_url":"https://api.github.com/repos/pagarme/artis/tags","blobs_url":"https://api.github.com/repos/pagarme/artis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagarme/artis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagarme/artis/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagarme/artis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagarme/artis/statuses/{sha}","languages_url":"https://api.github.com/repos/pagarme/artis/languages","stargazers_url":"https://api.github.com/repos/pagarme/artis/stargazers","contributors_url":"https://api.github.com/repos/pagarme/artis/contributors","subscribers_url":"https://api.github.com/repos/pagarme/artis/subscribers","subscription_url":"https://api.github.com/repos/pagarme/artis/subscription","commits_url":"https://api.github.com/repos/pagarme/artis/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagarme/artis/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagarme/artis/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagarme/artis/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagarme/artis/contents/{+path}","compare_url":"https://api.github.com/repos/pagarme/artis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagarme/artis/merges","archive_url":"https://api.github.com/repos/pagarme/artis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagarme/artis/downloads","issues_url":"https://api.github.com/repos/pagarme/artis/issues{/number}","pulls_url":"https://api.github.com/repos/pagarme/artis/pulls{/number}","milestones_url":"https://api.github.com/repos/pagarme/artis/milestones{/number}","notifications_url":"https://api.github.com/repos/pagarme/artis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagarme/artis/labels{/name}","releases_url":"https://api.github.com/repos/pagarme/artis/releases{/id}","deployments_url":"https://api.github.com/repos/pagarme/artis/deployments","created_at":"2017-09-22T16:13:58Z","updated_at":"2018-02-06T17:43:45Z","pushed_at":"2018-02-14T19:58:46Z","git_url":"git://github.com/pagarme/artis.git","ssh_url":"git@github.com:pagarme/artis.git","clone_url":"https://github.com/pagarme/artis.git","svn_url":"https://github.com/pagarme/artis","homepage":"","size":1616,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":15,"watchers":20,"default_branch":"master"}},"base":{"label":"pagarme:master","ref":"master","sha":"aa8a4e557fbf5be43875680b0a30b28462b94364","user":{"login":"pagarme","id":3846050,"avatar_url":"https://avatars2.githubusercontent.com/u/3846050?v=4","gravatar_id":"","url":"https://api.github.com/users/pagarme","html_url":"https://github.com/pagarme","followers_url":"https://api.github.com/users/pagarme/followers","following_url":"https://api.github.com/users/pagarme/following{/other_user}","gists_url":"https://api.github.com/users/pagarme/gists{/gist_id}","starred_url":"https://api.github.com/users/pagarme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagarme/subscriptions","organizations_url":"https://api.github.com/users/pagarme/orgs","repos_url":"https://api.github.com/users/pagarme/repos","events_url":"https://api.github.com/users/pagarme/events{/privacy}","received_events_url":"https://api.github.com/users/pagarme/received_events","type":"Organization","site_admin":false},"repo":{"id":104494408,"name":"artis","full_name":"pagarme/artis","owner":{"login":"pagarme","id":3846050,"avatar_url":"https://avatars2.githubusercontent.com/u/3846050?v=4","gravatar_id":"","url":"https://api.github.com/users/pagarme","html_url":"https://github.com/pagarme","followers_url":"https://api.github.com/users/pagarme/followers","following_url":"https://api.github.com/users/pagarme/following{/other_user}","gists_url":"https://api.github.com/users/pagarme/gists{/gist_id}","starred_url":"https://api.github.com/users/pagarme/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pagarme/subscriptions","organizations_url":"https://api.github.com/users/pagarme/orgs","repos_url":"https://api.github.com/users/pagarme/repos","events_url":"https://api.github.com/users/pagarme/events{/privacy}","received_events_url":"https://api.github.com/users/pagarme/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pagarme/artis","description":":credit_card: Projeto de Checkout desenvolvido em parceria entre MundiPagg e Pagar.me.","fork":false,"url":"https://api.github.com/repos/pagarme/artis","forks_url":"https://api.github.com/repos/pagarme/artis/forks","keys_url":"https://api.github.com/repos/pagarme/artis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pagarme/artis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pagarme/artis/teams","hooks_url":"https://api.github.com/repos/pagarme/artis/hooks","issue_events_url":"https://api.github.com/repos/pagarme/artis/issues/events{/number}","events_url":"https://api.github.com/repos/pagarme/artis/events","assignees_url":"https://api.github.com/repos/pagarme/artis/assignees{/user}","branches_url":"https://api.github.com/repos/pagarme/artis/branches{/branch}","tags_url":"https://api.github.com/repos/pagarme/artis/tags","blobs_url":"https://api.github.com/repos/pagarme/artis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pagarme/artis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pagarme/artis/git/refs{/sha}","trees_url":"https://api.github.com/repos/pagarme/artis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pagarme/artis/statuses/{sha}","languages_url":"https://api.github.com/repos/pagarme/artis/languages","stargazers_url":"https://api.github.com/repos/pagarme/artis/stargazers","contributors_url":"https://api.github.com/repos/pagarme/artis/contributors","subscribers_url":"https://api.github.com/repos/pagarme/artis/subscribers","subscription_url":"https://api.github.com/repos/pagarme/artis/subscription","commits_url":"https://api.github.com/repos/pagarme/artis/commits{/sha}","git_commits_url":"https://api.github.com/repos/pagarme/artis/git/commits{/sha}","comments_url":"https://api.github.com/repos/pagarme/artis/comments{/number}","issue_comment_url":"https://api.github.com/repos/pagarme/artis/issues/comments{/number}","contents_url":"https://api.github.com/repos/pagarme/artis/contents/{+path}","compare_url":"https://api.github.com/repos/pagarme/artis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pagarme/artis/merges","archive_url":"https://api.github.com/repos/pagarme/artis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pagarme/artis/downloads","issues_url":"https://api.github.com/repos/pagarme/artis/issues{/number}","pulls_url":"https://api.github.com/repos/pagarme/artis/pulls{/number}","milestones_url":"https://api.github.com/repos/pagarme/artis/milestones{/number}","notifications_url":"https://api.github.com/repos/pagarme/artis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pagarme/artis/labels{/name}","releases_url":"https://api.github.com/repos/pagarme/artis/releases{/id}","deployments_url":"https://api.github.com/repos/pagarme/artis/deployments","created_at":"2017-09-22T16:13:58Z","updated_at":"2018-02-06T17:43:45Z","pushed_at":"2018-02-14T19:58:46Z","git_url":"git://github.com/pagarme/artis.git","ssh_url":"git@github.com:pagarme/artis.git","clone_url":"https://github.com/pagarme/artis.git","svn_url":"https://github.com/pagarme/artis","homepage":"","size":1616,"stargazers_count":20,"watchers_count":20,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":15,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":1,"open_issues":15,"watchers":20,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pagarme/artis/pulls/131"},"html":{"href":"https://github.com/pagarme/artis/pull/131"},"issue":{"href":"https://api.github.com/repos/pagarme/artis/issues/131"},"comments":{"href":"https://api.github.com/repos/pagarme/artis/issues/131/comments"},"review_comments":{"href":"https://api.github.com/repos/pagarme/artis/pulls/131/comments"},"review_comment":{"href":"https://api.github.com/repos/pagarme/artis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pagarme/artis/pulls/131/commits"},"statuses":{"href":"https://api.github.com/repos/pagarme/artis/statuses/821c27da3a5bfbae8d65f7a0c1c6d08fdbd62c5d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"vcapretz"}}