{"action":"created","comment":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/184510626","pull_request_review_id":115723831,"id":184510626,"diff_hunk":"@@ -1,5 +1,8 @@\n # Changelog\n \n+## 1.17.4-dev\n+* Bug - Fixed a bug where Docker Version() API never returns by adding a timeout [#1363](https://github.com/aws/amazon-ecs-agent/pull/1363)","path":"CHANGELOG.md","position":4,"original_position":4,"commit_id":"3387f2299512d63a4d65ab7b4ace5d58702259c7","original_commit_id":"3387f2299512d63a4d65ab7b4ace5d58702259c7","user":{"login":"aaithal","id":1183359,"avatar_url":"https://avatars1.githubusercontent.com/u/1183359?v=4","gravatar_id":"","url":"https://api.github.com/users/aaithal","html_url":"https://github.com/aaithal","followers_url":"https://api.github.com/users/aaithal/followers","following_url":"https://api.github.com/users/aaithal/following{/other_user}","gists_url":"https://api.github.com/users/aaithal/gists{/gist_id}","starred_url":"https://api.github.com/users/aaithal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaithal/subscriptions","organizations_url":"https://api.github.com/users/aaithal/orgs","repos_url":"https://api.github.com/users/aaithal/repos","events_url":"https://api.github.com/users/aaithal/events{/privacy}","received_events_url":"https://api.github.com/users/aaithal/received_events","type":"User","site_admin":false},"body":"I don't think it matters. I can modify it if you really insist (prefer not to 😃 ).","created_at":"2018-04-26T19:50:42Z","updated_at":"2018-04-26T19:50:42Z","html_url":"https://github.com/aws/amazon-ecs-agent/pull/1363#discussion_r184510626","pull_request_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1363","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments/184510626"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/1363#discussion_r184510626"},"pull_request":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1363"}},"in_reply_to_id":184509541},"pull_request":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1363","id":184118804,"html_url":"https://github.com/aws/amazon-ecs-agent/pull/1363","diff_url":"https://github.com/aws/amazon-ecs-agent/pull/1363.diff","patch_url":"https://github.com/aws/amazon-ecs-agent/pull/1363.patch","issue_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1363","number":1363,"state":"open","locked":false,"title":"Add timeout for Docker Version API","user":{"login":"aaithal","id":1183359,"avatar_url":"https://avatars1.githubusercontent.com/u/1183359?v=4","gravatar_id":"","url":"https://api.github.com/users/aaithal","html_url":"https://github.com/aaithal","followers_url":"https://api.github.com/users/aaithal/followers","following_url":"https://api.github.com/users/aaithal/following{/other_user}","gists_url":"https://api.github.com/users/aaithal/gists{/gist_id}","starred_url":"https://api.github.com/users/aaithal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaithal/subscriptions","organizations_url":"https://api.github.com/users/aaithal/orgs","repos_url":"https://api.github.com/users/aaithal/repos","events_url":"https://api.github.com/users/aaithal/events{/privacy}","received_events_url":"https://api.github.com/users/aaithal/received_events","type":"User","site_admin":false},"body":"<!--\r\nPlease make sure you've read and understood our contributing guidelines;\r\nhttps://github.com/aws/amazon-ecs-agent/blob/master/CONTRIBUTING.md\r\n\r\nPlease provide the following information:\r\n-->\r\n\r\n### Summary\r\n<!-- What does this pull request do? -->\r\nAdd timeout for Docker Version API\r\n\r\n### Implementation details\r\n<!-- How are the changes implemented? -->\r\n\r\n* b1dae3d37eba6eab9c835648afa7f096af1fb7c9 dockerclient: add timeout for Version API\r\n    This change adds a timeout for Docker client's Version API.\r\n    Additionally, the Docker version returned in saved in the task engine.\r\n    This helps with avoiding additional unnecessarily calls to the Docker\r\n    Version API everytime the agent connects to the backend. This should\r\n    help with issues seen in #1331\r\n\r\n    Finally, the dockerclient package has been refactored to extract all\r\n    timeout related constants to dockerclient package from the dockerapi\r\n    package to avoid circular dependencies.\r\n\r\n* 63f065004f5bae922d710e45086a2d817a86718b updated go-dickerclient for VersionWithContext\r\n    Updated go-dockerclient to get the VersionWithContext() method, which\r\n    helps with adding timeouts against the Docker Version() API, which can\r\n    occasionally timeout.\r\n\r\n### Testing\r\n<!-- How was this tested? -->\r\n<!--\r\nNote for external contributors:\r\n`make test` and `make run-integ-tests` can run in a Linux development\r\nenvironment like your laptop.  `go test -timeout=25s ./agent/...` and\r\n`.\\scripts\\run-integ.tests.ps1` can run in a Windows development environment\r\nlike your laptop.  Please ensure unit and integration tests pass (on at least\r\none platform) before opening the pull request.  `make run-functional-tests` and\r\n`.\\scripts\\run-functional-tests.ps1` must be run on an EC2 instance with an\r\ninstance profile allowing it access to AWS resources.  Running\r\n`make run-functional-tests` and `.\\scripts\\run-functional-tests.ps1` may incur\r\ncharges to your AWS account; if you're unable or unwilling to run these tests\r\nin your own account, we can run the tests and provide test results.\r\n-->\r\n- [x] Builds on Linux (`make release`)\r\n- [x] Builds on Windows (`go build -out amazon-ecs-agent.exe ./agent`)\r\n- [x] Unit tests on Linux (`make test`) pass\r\n- [x] Unit tests on Windows (`go test -timeout=25s ./agent/...`) pass\r\n- [x] Integration tests on Linux (`make run-integ-tests`) pass\r\n- [x] Integration tests on Windows (`.\\scripts\\run-integ-tests.ps1`) pass\r\n- [x] Functional tests on Linux (`make run-functional-tests`) pass\r\n- [x] Functional tests on Windows (`.\\scripts\\run-functional-tests.ps1`) pass\r\n\r\nNew tests cover the changes: <!-- yes|no -->\r\n\r\n### Description for the changelog\r\n<!--\r\nWrite a short (one line) summary that describes the changes in this\r\npull request for inclusion in the changelog.\r\nYou can see our changelog entry style here:\r\nhttps://github.com/aws/amazon-ecs-agent/commit/c9aefebc2b3007f09468f651f6308136bd7b384f\r\n-->\r\n\r\n### Licensing\r\n\r\nBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.\r\n","created_at":"2018-04-25T18:07:05Z","updated_at":"2018-04-26T19:50:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9db9d73bdc3c60bc1c1955655c8850aea968f0e7","assignee":null,"assignees":[],"requested_reviewers":[{"login":"adnxn","id":596369,"avatar_url":"https://avatars2.githubusercontent.com/u/596369?v=4","gravatar_id":"","url":"https://api.github.com/users/adnxn","html_url":"https://github.com/adnxn","followers_url":"https://api.github.com/users/adnxn/followers","following_url":"https://api.github.com/users/adnxn/following{/other_user}","gists_url":"https://api.github.com/users/adnxn/gists{/gist_id}","starred_url":"https://api.github.com/users/adnxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnxn/subscriptions","organizations_url":"https://api.github.com/users/adnxn/orgs","repos_url":"https://api.github.com/users/adnxn/repos","events_url":"https://api.github.com/users/adnxn/events{/privacy}","received_events_url":"https://api.github.com/users/adnxn/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":{"url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones/24","html_url":"https://github.com/aws/amazon-ecs-agent/milestone/24","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones/24/labels","id":3297098,"number":24,"title":"1.17.4","description":null,"creator":{"login":"adnxn","id":596369,"avatar_url":"https://avatars2.githubusercontent.com/u/596369?v=4","gravatar_id":"","url":"https://api.github.com/users/adnxn","html_url":"https://github.com/adnxn","followers_url":"https://api.github.com/users/adnxn/followers","following_url":"https://api.github.com/users/adnxn/following{/other_user}","gists_url":"https://api.github.com/users/adnxn/gists{/gist_id}","starred_url":"https://api.github.com/users/adnxn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnxn/subscriptions","organizations_url":"https://api.github.com/users/adnxn/orgs","repos_url":"https://api.github.com/users/adnxn/repos","events_url":"https://api.github.com/users/adnxn/events{/privacy}","received_events_url":"https://api.github.com/users/adnxn/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":1,"state":"open","created_at":"2018-04-25T17:51:01Z","updated_at":"2018-04-25T23:39:16Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1363/commits","review_comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1363/comments","review_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1363/comments","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/3387f2299512d63a4d65ab7b4ace5d58702259c7","head":{"label":"aaithal:versionTimeout","ref":"versionTimeout","sha":"3387f2299512d63a4d65ab7b4ace5d58702259c7","user":{"login":"aaithal","id":1183359,"avatar_url":"https://avatars1.githubusercontent.com/u/1183359?v=4","gravatar_id":"","url":"https://api.github.com/users/aaithal","html_url":"https://github.com/aaithal","followers_url":"https://api.github.com/users/aaithal/followers","following_url":"https://api.github.com/users/aaithal/following{/other_user}","gists_url":"https://api.github.com/users/aaithal/gists{/gist_id}","starred_url":"https://api.github.com/users/aaithal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaithal/subscriptions","organizations_url":"https://api.github.com/users/aaithal/orgs","repos_url":"https://api.github.com/users/aaithal/repos","events_url":"https://api.github.com/users/aaithal/events{/privacy}","received_events_url":"https://api.github.com/users/aaithal/received_events","type":"User","site_admin":false},"repo":{"id":30386191,"name":"amazon-ecs-agent","full_name":"aaithal/amazon-ecs-agent","owner":{"login":"aaithal","id":1183359,"avatar_url":"https://avatars1.githubusercontent.com/u/1183359?v=4","gravatar_id":"","url":"https://api.github.com/users/aaithal","html_url":"https://github.com/aaithal","followers_url":"https://api.github.com/users/aaithal/followers","following_url":"https://api.github.com/users/aaithal/following{/other_user}","gists_url":"https://api.github.com/users/aaithal/gists{/gist_id}","starred_url":"https://api.github.com/users/aaithal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aaithal/subscriptions","organizations_url":"https://api.github.com/users/aaithal/orgs","repos_url":"https://api.github.com/users/aaithal/repos","events_url":"https://api.github.com/users/aaithal/events{/privacy}","received_events_url":"https://api.github.com/users/aaithal/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/aaithal/amazon-ecs-agent","description":"Amazon EC2 Container Service Agent","fork":true,"url":"https://api.github.com/repos/aaithal/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aaithal/amazon-ecs-agent/deployments","created_at":"2015-02-06T00:24:31Z","updated_at":"2017-11-25T18:19:27Z","pushed_at":"2018-04-26T15:33:30Z","git_url":"git://github.com/aaithal/amazon-ecs-agent.git","ssh_url":"git@github.com:aaithal/amazon-ecs-agent.git","clone_url":"https://github.com/aaithal/amazon-ecs-agent.git","svn_url":"https://github.com/aaithal/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":30137,"stargazers_count":9,"watchers_count":9,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1,"open_issues":0,"watchers":9,"default_branch":"master"}},"base":{"label":"aws:dev","ref":"dev","sha":"fbfc6c1ab3ec338a4b0a85f724e2af0489cf93c5","user":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"repo":{"id":27551774,"name":"amazon-ecs-agent","full_name":"aws/amazon-ecs-agent","owner":{"login":"aws","id":2232217,"avatar_url":"https://avatars3.githubusercontent.com/u/2232217?v=4","gravatar_id":"","url":"https://api.github.com/users/aws","html_url":"https://github.com/aws","followers_url":"https://api.github.com/users/aws/followers","following_url":"https://api.github.com/users/aws/following{/other_user}","gists_url":"https://api.github.com/users/aws/gists{/gist_id}","starred_url":"https://api.github.com/users/aws/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aws/subscriptions","organizations_url":"https://api.github.com/users/aws/orgs","repos_url":"https://api.github.com/users/aws/repos","events_url":"https://api.github.com/users/aws/events{/privacy}","received_events_url":"https://api.github.com/users/aws/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aws/amazon-ecs-agent","description":"Amazon Elastic Container Service Agent","fork":false,"url":"https://api.github.com/repos/aws/amazon-ecs-agent","forks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/forks","keys_url":"https://api.github.com/repos/aws/amazon-ecs-agent/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aws/amazon-ecs-agent/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aws/amazon-ecs-agent/teams","hooks_url":"https://api.github.com/repos/aws/amazon-ecs-agent/hooks","issue_events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/events{/number}","events_url":"https://api.github.com/repos/aws/amazon-ecs-agent/events","assignees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/assignees{/user}","branches_url":"https://api.github.com/repos/aws/amazon-ecs-agent/branches{/branch}","tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/tags","blobs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/refs{/sha}","trees_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/{sha}","languages_url":"https://api.github.com/repos/aws/amazon-ecs-agent/languages","stargazers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/stargazers","contributors_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contributors","subscribers_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscribers","subscription_url":"https://api.github.com/repos/aws/amazon-ecs-agent/subscription","commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/commits{/sha}","git_commits_url":"https://api.github.com/repos/aws/amazon-ecs-agent/git/commits{/sha}","comments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/comments{/number}","issue_comment_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/comments{/number}","contents_url":"https://api.github.com/repos/aws/amazon-ecs-agent/contents/{+path}","compare_url":"https://api.github.com/repos/aws/amazon-ecs-agent/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aws/amazon-ecs-agent/merges","archive_url":"https://api.github.com/repos/aws/amazon-ecs-agent/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aws/amazon-ecs-agent/downloads","issues_url":"https://api.github.com/repos/aws/amazon-ecs-agent/issues{/number}","pulls_url":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls{/number}","milestones_url":"https://api.github.com/repos/aws/amazon-ecs-agent/milestones{/number}","notifications_url":"https://api.github.com/repos/aws/amazon-ecs-agent/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aws/amazon-ecs-agent/labels{/name}","releases_url":"https://api.github.com/repos/aws/amazon-ecs-agent/releases{/id}","deployments_url":"https://api.github.com/repos/aws/amazon-ecs-agent/deployments","created_at":"2014-12-04T17:31:49Z","updated_at":"2018-04-25T07:46:39Z","pushed_at":"2018-04-26T19:11:52Z","git_url":"git://github.com/aws/amazon-ecs-agent.git","ssh_url":"git@github.com:aws/amazon-ecs-agent.git","clone_url":"https://github.com/aws/amazon-ecs-agent.git","svn_url":"https://github.com/aws/amazon-ecs-agent","homepage":"http://aws.amazon.com/ecs/","size":30111,"stargazers_count":1215,"watchers_count":1215,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":323,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":323,"open_issues":106,"watchers":1215,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1363"},"html":{"href":"https://github.com/aws/amazon-ecs-agent/pull/1363"},"issue":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1363"},"comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/issues/1363/comments"},"review_comments":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1363/comments"},"review_comment":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/pulls/1363/commits"},"statuses":{"href":"https://api.github.com/repos/aws/amazon-ecs-agent/statuses/3387f2299512d63a4d65ab7b4ace5d58702259c7"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"aaithal"}}