{"action":"created","comment":{"url":"https://api.github.com/repos/dvsa/motr/pulls/comments/201927997","pull_request_review_id":136523831,"id":201927997,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMTkyNzk5Nw==","diff_hunk":"@@ -108,6 +121,21 @@ public Response phoneNumberPagePost(@FormParam(\"phoneNumber\") String phoneNumber\n         modelMap.putAll(dataLayerHelper.formatAttributes());\n         dataLayerHelper.clear();\n \n+        addDetailsForSurveyFromSession(modelMap);\n+\n         return Response.ok(renderer.render(PHONE_NUMBER_TEMPLATE, modelMap)).build();\n     }\n+\n+    private void addDetailsForSurveyFromSession(Map<String, Object> modelMap) {\n+\n+        VehicleDetails vehicle = motrSession.getVehicleDetailsFromSession();\n+        smartSurveyHelperFeedback.putAttribute(CONTACT_TYPE, \"mobile\");","path":"motr-webapp/webapp/src/main/java/uk/gov/dvsa/motr/web/resource/PhoneNumberResource.java","position":67,"original_position":67,"commit_id":"b27a11d323cc10c4a22b92cbe059d2adef9975bd","original_commit_id":"b27a11d323cc10c4a22b92cbe059d2adef9975bd","user":{"login":"przemos","id":7382082,"node_id":"MDQ6VXNlcjczODIwODI=","avatar_url":"https://avatars3.githubusercontent.com/u/7382082?v=4","gravatar_id":"","url":"https://api.github.com/users/przemos","html_url":"https://github.com/przemos","followers_url":"https://api.github.com/users/przemos/followers","following_url":"https://api.github.com/users/przemos/following{/other_user}","gists_url":"https://api.github.com/users/przemos/gists{/gist_id}","starred_url":"https://api.github.com/users/przemos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/przemos/subscriptions","organizations_url":"https://api.github.com/users/przemos/orgs","repos_url":"https://api.github.com/users/przemos/repos","events_url":"https://api.github.com/users/przemos/events{/privacy}","received_events_url":"https://api.github.com/users/przemos/received_events","type":"User","site_admin":false},"body":"Smart Survey accepts predefined attributes only, which means adding any new attribute on the fly will not result in that attribute being passed to Smart Survey. It would be nice if the code reflected that.","created_at":"2018-07-12T07:01:56Z","updated_at":"2018-07-12T07:01:56Z","html_url":"https://github.com/dvsa/motr/pull/48#discussion_r201927997","pull_request_url":"https://api.github.com/repos/dvsa/motr/pulls/48","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/dvsa/motr/pulls/comments/201927997"},"html":{"href":"https://github.com/dvsa/motr/pull/48#discussion_r201927997"},"pull_request":{"href":"https://api.github.com/repos/dvsa/motr/pulls/48"}}},"pull_request":{"url":"https://api.github.com/repos/dvsa/motr/pulls/48","id":199692744,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5NjkyNzQ0","html_url":"https://github.com/dvsa/motr/pull/48","diff_url":"https://github.com/dvsa/motr/pull/48.diff","patch_url":"https://github.com/dvsa/motr/pull/48.patch","issue_url":"https://api.github.com/repos/dvsa/motr/issues/48","number":48,"state":"open","locked":false,"title":"Feature BL-7657: Capture additional details in smart survey","user":{"login":"mrogowska","id":22588418,"node_id":"MDQ6VXNlcjIyNTg4NDE4","avatar_url":"https://avatars0.githubusercontent.com/u/22588418?v=4","gravatar_id":"","url":"https://api.github.com/users/mrogowska","html_url":"https://github.com/mrogowska","followers_url":"https://api.github.com/users/mrogowska/followers","following_url":"https://api.github.com/users/mrogowska/following{/other_user}","gists_url":"https://api.github.com/users/mrogowska/gists{/gist_id}","starred_url":"https://api.github.com/users/mrogowska/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mrogowska/subscriptions","organizations_url":"https://api.github.com/users/mrogowska/orgs","repos_url":"https://api.github.com/users/mrogowska/repos","events_url":"https://api.github.com/users/mrogowska/events{/privacy}","received_events_url":"https://api.github.com/users/mrogowska/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-06T09:27:53Z","updated_at":"2018-07-12T07:01:56Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7d82efacdaeeca4ec0ebcd364794764affd7fbb0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dvsa/motr/pulls/48/commits","review_comments_url":"https://api.github.com/repos/dvsa/motr/pulls/48/comments","review_comment_url":"https://api.github.com/repos/dvsa/motr/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dvsa/motr/issues/48/comments","statuses_url":"https://api.github.com/repos/dvsa/motr/statuses/b27a11d323cc10c4a22b92cbe059d2adef9975bd","head":{"label":"dvsa:feature-BL-7657-capture-additional-details-in-smart-survey","ref":"feature-BL-7657-capture-additional-details-in-smart-survey","sha":"b27a11d323cc10c4a22b92cbe059d2adef9975bd","user":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":113570712,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM1NzA3MTI=","name":"motr","full_name":"dvsa/motr","owner":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dvsa/motr","description":"MOT Reminders","fork":false,"url":"https://api.github.com/repos/dvsa/motr","forks_url":"https://api.github.com/repos/dvsa/motr/forks","keys_url":"https://api.github.com/repos/dvsa/motr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/motr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/motr/teams","hooks_url":"https://api.github.com/repos/dvsa/motr/hooks","issue_events_url":"https://api.github.com/repos/dvsa/motr/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/motr/events","assignees_url":"https://api.github.com/repos/dvsa/motr/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/motr/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/motr/tags","blobs_url":"https://api.github.com/repos/dvsa/motr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/motr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/motr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/motr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/motr/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/motr/languages","stargazers_url":"https://api.github.com/repos/dvsa/motr/stargazers","contributors_url":"https://api.github.com/repos/dvsa/motr/contributors","subscribers_url":"https://api.github.com/repos/dvsa/motr/subscribers","subscription_url":"https://api.github.com/repos/dvsa/motr/subscription","commits_url":"https://api.github.com/repos/dvsa/motr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/motr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/motr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/motr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/motr/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/motr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/motr/merges","archive_url":"https://api.github.com/repos/dvsa/motr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/motr/downloads","issues_url":"https://api.github.com/repos/dvsa/motr/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/motr/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/motr/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/motr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/motr/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/motr/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/motr/deployments","created_at":"2017-12-08T12:10:42Z","updated_at":"2018-07-11T15:14:58Z","pushed_at":"2018-07-11T16:51:50Z","git_url":"git://github.com/dvsa/motr.git","ssh_url":"git@github.com:dvsa/motr.git","clone_url":"https://github.com/dvsa/motr.git","svn_url":"https://github.com/dvsa/motr","homepage":null,"size":3059,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"base":{"label":"dvsa:master","ref":"master","sha":"995f0ce8d585a2ecd94db697da90cdaa27850bde","user":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"repo":{"id":113570712,"node_id":"MDEwOlJlcG9zaXRvcnkxMTM1NzA3MTI=","name":"motr","full_name":"dvsa/motr","owner":{"login":"dvsa","id":24296376,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0Mjk2Mzc2","avatar_url":"https://avatars1.githubusercontent.com/u/24296376?v=4","gravatar_id":"","url":"https://api.github.com/users/dvsa","html_url":"https://github.com/dvsa","followers_url":"https://api.github.com/users/dvsa/followers","following_url":"https://api.github.com/users/dvsa/following{/other_user}","gists_url":"https://api.github.com/users/dvsa/gists{/gist_id}","starred_url":"https://api.github.com/users/dvsa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dvsa/subscriptions","organizations_url":"https://api.github.com/users/dvsa/orgs","repos_url":"https://api.github.com/users/dvsa/repos","events_url":"https://api.github.com/users/dvsa/events{/privacy}","received_events_url":"https://api.github.com/users/dvsa/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dvsa/motr","description":"MOT Reminders","fork":false,"url":"https://api.github.com/repos/dvsa/motr","forks_url":"https://api.github.com/repos/dvsa/motr/forks","keys_url":"https://api.github.com/repos/dvsa/motr/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dvsa/motr/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dvsa/motr/teams","hooks_url":"https://api.github.com/repos/dvsa/motr/hooks","issue_events_url":"https://api.github.com/repos/dvsa/motr/issues/events{/number}","events_url":"https://api.github.com/repos/dvsa/motr/events","assignees_url":"https://api.github.com/repos/dvsa/motr/assignees{/user}","branches_url":"https://api.github.com/repos/dvsa/motr/branches{/branch}","tags_url":"https://api.github.com/repos/dvsa/motr/tags","blobs_url":"https://api.github.com/repos/dvsa/motr/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dvsa/motr/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dvsa/motr/git/refs{/sha}","trees_url":"https://api.github.com/repos/dvsa/motr/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dvsa/motr/statuses/{sha}","languages_url":"https://api.github.com/repos/dvsa/motr/languages","stargazers_url":"https://api.github.com/repos/dvsa/motr/stargazers","contributors_url":"https://api.github.com/repos/dvsa/motr/contributors","subscribers_url":"https://api.github.com/repos/dvsa/motr/subscribers","subscription_url":"https://api.github.com/repos/dvsa/motr/subscription","commits_url":"https://api.github.com/repos/dvsa/motr/commits{/sha}","git_commits_url":"https://api.github.com/repos/dvsa/motr/git/commits{/sha}","comments_url":"https://api.github.com/repos/dvsa/motr/comments{/number}","issue_comment_url":"https://api.github.com/repos/dvsa/motr/issues/comments{/number}","contents_url":"https://api.github.com/repos/dvsa/motr/contents/{+path}","compare_url":"https://api.github.com/repos/dvsa/motr/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dvsa/motr/merges","archive_url":"https://api.github.com/repos/dvsa/motr/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dvsa/motr/downloads","issues_url":"https://api.github.com/repos/dvsa/motr/issues{/number}","pulls_url":"https://api.github.com/repos/dvsa/motr/pulls{/number}","milestones_url":"https://api.github.com/repos/dvsa/motr/milestones{/number}","notifications_url":"https://api.github.com/repos/dvsa/motr/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dvsa/motr/labels{/name}","releases_url":"https://api.github.com/repos/dvsa/motr/releases{/id}","deployments_url":"https://api.github.com/repos/dvsa/motr/deployments","created_at":"2017-12-08T12:10:42Z","updated_at":"2018-07-11T15:14:58Z","pushed_at":"2018-07-11T16:51:50Z","git_url":"git://github.com/dvsa/motr.git","ssh_url":"git@github.com:dvsa/motr.git","clone_url":"https://github.com/dvsa/motr.git","svn_url":"https://github.com/dvsa/motr","homepage":null,"size":3059,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":2,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dvsa/motr/pulls/48"},"html":{"href":"https://github.com/dvsa/motr/pull/48"},"issue":{"href":"https://api.github.com/repos/dvsa/motr/issues/48"},"comments":{"href":"https://api.github.com/repos/dvsa/motr/issues/48/comments"},"review_comments":{"href":"https://api.github.com/repos/dvsa/motr/pulls/48/comments"},"review_comment":{"href":"https://api.github.com/repos/dvsa/motr/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dvsa/motr/pulls/48/commits"},"statuses":{"href":"https://api.github.com/repos/dvsa/motr/statuses/b27a11d323cc10c4a22b92cbe059d2adef9975bd"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"przemos"}}