{"action":"created","comment":{"url":"https://api.github.com/repos/apache/ignite/pulls/comments/223221642","pull_request_review_id":162298234,"id":223221642,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzIyMTY0Mg==","diff_hunk":"@@ -565,14 +566,16 @@ private void reinit(FileIO fileIO) throws IOException {\n                     if (calculateCrc && !skipCrc) {\n                         assert PageIO.getCrc(pageBuf) == 0 : U.hexLong(pageId);\n \n-                        PageIO.setCrc(pageBuf, calcCrc32(pageBuf, pageSize));\n+                        PageIO.setCrc(pageBuf, U.calcCrc(pageBuf, pageSize));\n+\n+                        pageBuf.position(0);\n                     }\n \n                     // Check whether crc was calculated somewhere above the stack if it is forcibly skipped.\n-                    assert skipCrc || PageIO.getCrc(pageBuf) != 0 || calcCrc32(pageBuf, pageSize) == 0 :\n+                    assert skipCrc || PageIO.getCrc(pageBuf) != 0 || U.calcCrc(pageBuf, pageSize) == 0 :\n                         \"CRC hasn't been calculated, crc=0\";\n \n-                    assert pageBuf.position() == 0 : pageBuf.position();\n+                    pageBuf.position(0);","path":"modules/core/src/main/java/org/apache/ignite/internal/processors/cache/persistence/file/FilePageStore.java","position":null,"original_position":42,"commit_id":"08a13201f2957b0342a9634ab0350a829768ee3d","original_commit_id":"3218a1ab74cf81398b8275fe2dcfcfb9e6fc1b28","user":{"login":"zstan","id":1107510,"node_id":"MDQ6VXNlcjExMDc1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1107510?v=4","gravatar_id":"","url":"https://api.github.com/users/zstan","html_url":"https://github.com/zstan","followers_url":"https://api.github.com/users/zstan/followers","following_url":"https://api.github.com/users/zstan/following{/other_user}","gists_url":"https://api.github.com/users/zstan/gists{/gist_id}","starred_url":"https://api.github.com/users/zstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zstan/subscriptions","organizations_url":"https://api.github.com/users/zstan/orgs","repos_url":"https://api.github.com/users/zstan/repos","events_url":"https://api.github.com/users/zstan/events{/privacy}","received_events_url":"https://api.github.com/users/zstan/received_events","type":"User","site_admin":false},"body":"all done, TC rerun.","created_at":"2018-10-07T17:37:27Z","updated_at":"2018-10-07T17:37:28Z","html_url":"https://github.com/apache/ignite/pull/4619#discussion_r223221642","pull_request_url":"https://api.github.com/repos/apache/ignite/pulls/4619","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/apache/ignite/pulls/comments/223221642"},"html":{"href":"https://github.com/apache/ignite/pull/4619#discussion_r223221642"},"pull_request":{"href":"https://api.github.com/repos/apache/ignite/pulls/4619"}},"in_reply_to_id":223033407},"pull_request":{"url":"https://api.github.com/repos/apache/ignite/pulls/4619","id":210902792,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTAyNzky","html_url":"https://github.com/apache/ignite/pull/4619","diff_url":"https://github.com/apache/ignite/pull/4619.diff","patch_url":"https://github.com/apache/ignite/pull/4619.patch","issue_url":"https://api.github.com/repos/apache/ignite/issues/4619","number":4619,"state":"open","locked":false,"title":"IGNITE-9272 j.u.zip.CRC32algo instead of PureJavaCrc32","user":{"login":"zstan","id":1107510,"node_id":"MDQ6VXNlcjExMDc1MTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1107510?v=4","gravatar_id":"","url":"https://api.github.com/users/zstan","html_url":"https://github.com/zstan","followers_url":"https://api.github.com/users/zstan/followers","following_url":"https://api.github.com/users/zstan/following{/other_user}","gists_url":"https://api.github.com/users/zstan/gists{/gist_id}","starred_url":"https://api.github.com/users/zstan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zstan/subscriptions","organizations_url":"https://api.github.com/users/zstan/orgs","repos_url":"https://api.github.com/users/zstan/repos","events_url":"https://api.github.com/users/zstan/events{/privacy}","received_events_url":"https://api.github.com/users/zstan/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-25T13:34:01Z","updated_at":"2018-10-07T17:37:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9c3298ca918692c77c554e1acedeb7c58075f895","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/ignite/pulls/4619/commits","review_comments_url":"https://api.github.com/repos/apache/ignite/pulls/4619/comments","review_comment_url":"https://api.github.com/repos/apache/ignite/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/ignite/issues/4619/comments","statuses_url":"https://api.github.com/repos/apache/ignite/statuses/08a13201f2957b0342a9634ab0350a829768ee3d","head":{"label":"gridgain:ignite-9272","ref":"ignite-9272","sha":"08a13201f2957b0342a9634ab0350a829768ee3d","user":{"login":"gridgain","id":803592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwMzU5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/803592?v=4","gravatar_id":"","url":"https://api.github.com/users/gridgain","html_url":"https://github.com/gridgain","followers_url":"https://api.github.com/users/gridgain/followers","following_url":"https://api.github.com/users/gridgain/following{/other_user}","gists_url":"https://api.github.com/users/gridgain/gists{/gist_id}","starred_url":"https://api.github.com/users/gridgain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridgain/subscriptions","organizations_url":"https://api.github.com/users/gridgain/orgs","repos_url":"https://api.github.com/users/gridgain/repos","events_url":"https://api.github.com/users/gridgain/events{/privacy}","received_events_url":"https://api.github.com/users/gridgain/received_events","type":"Organization","site_admin":false},"repo":{"id":32432793,"node_id":"MDEwOlJlcG9zaXRvcnkzMjQzMjc5Mw==","name":"apache-ignite","full_name":"gridgain/apache-ignite","private":false,"owner":{"login":"gridgain","id":803592,"node_id":"MDEyOk9yZ2FuaXphdGlvbjgwMzU5Mg==","avatar_url":"https://avatars3.githubusercontent.com/u/803592?v=4","gravatar_id":"","url":"https://api.github.com/users/gridgain","html_url":"https://github.com/gridgain","followers_url":"https://api.github.com/users/gridgain/followers","following_url":"https://api.github.com/users/gridgain/following{/other_user}","gists_url":"https://api.github.com/users/gridgain/gists{/gist_id}","starred_url":"https://api.github.com/users/gridgain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gridgain/subscriptions","organizations_url":"https://api.github.com/users/gridgain/orgs","repos_url":"https://api.github.com/users/gridgain/repos","events_url":"https://api.github.com/users/gridgain/events{/privacy}","received_events_url":"https://api.github.com/users/gridgain/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gridgain/apache-ignite","description":"Mirror of Apache Ignite","fork":true,"url":"https://api.github.com/repos/gridgain/apache-ignite","forks_url":"https://api.github.com/repos/gridgain/apache-ignite/forks","keys_url":"https://api.github.com/repos/gridgain/apache-ignite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gridgain/apache-ignite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gridgain/apache-ignite/teams","hooks_url":"https://api.github.com/repos/gridgain/apache-ignite/hooks","issue_events_url":"https://api.github.com/repos/gridgain/apache-ignite/issues/events{/number}","events_url":"https://api.github.com/repos/gridgain/apache-ignite/events","assignees_url":"https://api.github.com/repos/gridgain/apache-ignite/assignees{/user}","branches_url":"https://api.github.com/repos/gridgain/apache-ignite/branches{/branch}","tags_url":"https://api.github.com/repos/gridgain/apache-ignite/tags","blobs_url":"https://api.github.com/repos/gridgain/apache-ignite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gridgain/apache-ignite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gridgain/apache-ignite/git/refs{/sha}","trees_url":"https://api.github.com/repos/gridgain/apache-ignite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gridgain/apache-ignite/statuses/{sha}","languages_url":"https://api.github.com/repos/gridgain/apache-ignite/languages","stargazers_url":"https://api.github.com/repos/gridgain/apache-ignite/stargazers","contributors_url":"https://api.github.com/repos/gridgain/apache-ignite/contributors","subscribers_url":"https://api.github.com/repos/gridgain/apache-ignite/subscribers","subscription_url":"https://api.github.com/repos/gridgain/apache-ignite/subscription","commits_url":"https://api.github.com/repos/gridgain/apache-ignite/commits{/sha}","git_commits_url":"https://api.github.com/repos/gridgain/apache-ignite/git/commits{/sha}","comments_url":"https://api.github.com/repos/gridgain/apache-ignite/comments{/number}","issue_comment_url":"https://api.github.com/repos/gridgain/apache-ignite/issues/comments{/number}","contents_url":"https://api.github.com/repos/gridgain/apache-ignite/contents/{+path}","compare_url":"https://api.github.com/repos/gridgain/apache-ignite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gridgain/apache-ignite/merges","archive_url":"https://api.github.com/repos/gridgain/apache-ignite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gridgain/apache-ignite/downloads","issues_url":"https://api.github.com/repos/gridgain/apache-ignite/issues{/number}","pulls_url":"https://api.github.com/repos/gridgain/apache-ignite/pulls{/number}","milestones_url":"https://api.github.com/repos/gridgain/apache-ignite/milestones{/number}","notifications_url":"https://api.github.com/repos/gridgain/apache-ignite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gridgain/apache-ignite/labels{/name}","releases_url":"https://api.github.com/repos/gridgain/apache-ignite/releases{/id}","deployments_url":"https://api.github.com/repos/gridgain/apache-ignite/deployments","created_at":"2015-03-18T02:19:44Z","updated_at":"2018-09-25T15:44:27Z","pushed_at":"2018-10-07T17:13:25Z","git_url":"git://github.com/gridgain/apache-ignite.git","ssh_url":"git@github.com:gridgain/apache-ignite.git","clone_url":"https://github.com/gridgain/apache-ignite.git","svn_url":"https://github.com/gridgain/apache-ignite","homepage":"","size":367967,"stargazers_count":18,"watchers_count":18,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":7,"open_issues":16,"watchers":18,"default_branch":"sprint-2"}},"base":{"label":"apache:master","ref":"master","sha":"4e6727fe4c2952bb3d5be1c7767b3dd0dfe392da","user":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":31006158,"node_id":"MDEwOlJlcG9zaXRvcnkzMTAwNjE1OA==","name":"ignite","full_name":"apache/ignite","private":false,"owner":{"login":"apache","id":47359,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ3MzU5","avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/apache/ignite","description":"Mirror of Apache Ignite","fork":false,"url":"https://api.github.com/repos/apache/ignite","forks_url":"https://api.github.com/repos/apache/ignite/forks","keys_url":"https://api.github.com/repos/apache/ignite/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/ignite/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/ignite/teams","hooks_url":"https://api.github.com/repos/apache/ignite/hooks","issue_events_url":"https://api.github.com/repos/apache/ignite/issues/events{/number}","events_url":"https://api.github.com/repos/apache/ignite/events","assignees_url":"https://api.github.com/repos/apache/ignite/assignees{/user}","branches_url":"https://api.github.com/repos/apache/ignite/branches{/branch}","tags_url":"https://api.github.com/repos/apache/ignite/tags","blobs_url":"https://api.github.com/repos/apache/ignite/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/ignite/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/ignite/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/ignite/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/ignite/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/ignite/languages","stargazers_url":"https://api.github.com/repos/apache/ignite/stargazers","contributors_url":"https://api.github.com/repos/apache/ignite/contributors","subscribers_url":"https://api.github.com/repos/apache/ignite/subscribers","subscription_url":"https://api.github.com/repos/apache/ignite/subscription","commits_url":"https://api.github.com/repos/apache/ignite/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/ignite/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/ignite/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/ignite/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/ignite/contents/{+path}","compare_url":"https://api.github.com/repos/apache/ignite/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/ignite/merges","archive_url":"https://api.github.com/repos/apache/ignite/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/ignite/downloads","issues_url":"https://api.github.com/repos/apache/ignite/issues{/number}","pulls_url":"https://api.github.com/repos/apache/ignite/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/ignite/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/ignite/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/ignite/labels{/name}","releases_url":"https://api.github.com/repos/apache/ignite/releases{/id}","deployments_url":"https://api.github.com/repos/apache/ignite/deployments","created_at":"2015-02-19T08:00:05Z","updated_at":"2018-10-07T15:22:34Z","pushed_at":"2018-10-07T17:13:28Z","git_url":"git://github.com/apache/ignite.git","ssh_url":"git@github.com:apache/ignite.git","clone_url":"https://github.com/apache/ignite.git","svn_url":"https://github.com/apache/ignite","homepage":"","size":290268,"stargazers_count":1993,"watchers_count":1993,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1055,"mirror_url":null,"archived":false,"open_issues_count":1331,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1055,"open_issues":1331,"watchers":1993,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/ignite/pulls/4619"},"html":{"href":"https://github.com/apache/ignite/pull/4619"},"issue":{"href":"https://api.github.com/repos/apache/ignite/issues/4619"},"comments":{"href":"https://api.github.com/repos/apache/ignite/issues/4619/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/ignite/pulls/4619/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/ignite/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/ignite/pulls/4619/commits"},"statuses":{"href":"https://api.github.com/repos/apache/ignite/statuses/08a13201f2957b0342a9634ab0350a829768ee3d"}},"author_association":"NONE"}}
{"actor":{"display_login":"zstan"}}