{"action":"created","issue":{"url":"https://api.github.com/repos/blackbaud/skyux2/issues/1637","repository_url":"https://api.github.com/repos/blackbaud/skyux2","labels_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1637/labels{/name}","comments_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1637/comments","events_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1637/events","html_url":"https://github.com/blackbaud/skyux2/pull/1637","id":315180662,"number":1637,"title":"Fix popover flyout issue","user":{"login":"Blackbaud-StacyCarlos","id":13663118,"avatar_url":"https://avatars0.githubusercontent.com/u/13663118?v=4","gravatar_id":"","url":"https://api.github.com/users/Blackbaud-StacyCarlos","html_url":"https://github.com/Blackbaud-StacyCarlos","followers_url":"https://api.github.com/users/Blackbaud-StacyCarlos/followers","following_url":"https://api.github.com/users/Blackbaud-StacyCarlos/following{/other_user}","gists_url":"https://api.github.com/users/Blackbaud-StacyCarlos/gists{/gist_id}","starred_url":"https://api.github.com/users/Blackbaud-StacyCarlos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Blackbaud-StacyCarlos/subscriptions","organizations_url":"https://api.github.com/users/Blackbaud-StacyCarlos/orgs","repos_url":"https://api.github.com/users/Blackbaud-StacyCarlos/repos","events_url":"https://api.github.com/users/Blackbaud-StacyCarlos/events{/privacy}","received_events_url":"https://api.github.com/users/Blackbaud-StacyCarlos/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":10,"created_at":"2018-04-17T18:33:43Z","updated_at":"2018-05-07T15:49:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/blackbaud/skyux2/pulls/1637","html_url":"https://github.com/blackbaud/skyux2/pull/1637","diff_url":"https://github.com/blackbaud/skyux2/pull/1637.diff","patch_url":"https://github.com/blackbaud/skyux2/pull/1637.patch"},"body":"This incorporates a fix for #1636. \r\n\r\n~~The use of `getBoundingClientRect` is fine, but the resulting `top`, `bottom`, `right`, and `left` are not based on the `offsetParent` of the original element.~~\r\n\r\n~~When specifying `left` and `top` of a *positioned* element, we must ensure we compensate for the position of the first *positioned ancestor*, i.e. `offsetParent`, if you want to to line up with other siblings. Originally, the was solved by appending to body, but the change in design warrants this fix.~~\r\n\r\nRather than adding logic to determine offset parent, I have opted to remove styling that forces offset parents for fixed elements.\r\n\r\nHowever, I do believe many of these components are fundamentally flawed in how they were implemented. The reuse of the entire dropdown component, rather than a simple popover or dropdown menu component, was good as a base, but should be refactored out to increase maintainability and readability. \r\n* * *\r\nThe plunkr for Flyouts is currently broken, but this is where the issue can be seen."},"comment":{"url":"https://api.github.com/repos/blackbaud/skyux2/issues/comments/387109766","html_url":"https://github.com/blackbaud/skyux2/pull/1637#issuecomment-387109766","issue_url":"https://api.github.com/repos/blackbaud/skyux2/issues/1637","id":387109766,"user":{"login":"blackbaud-sky-savage","id":14355509,"avatar_url":"https://avatars3.githubusercontent.com/u/14355509?v=4","gravatar_id":"","url":"https://api.github.com/users/blackbaud-sky-savage","html_url":"https://github.com/blackbaud-sky-savage","followers_url":"https://api.github.com/users/blackbaud-sky-savage/followers","following_url":"https://api.github.com/users/blackbaud-sky-savage/following{/other_user}","gists_url":"https://api.github.com/users/blackbaud-sky-savage/gists{/gist_id}","starred_url":"https://api.github.com/users/blackbaud-sky-savage/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/blackbaud-sky-savage/subscriptions","organizations_url":"https://api.github.com/users/blackbaud-sky-savage/orgs","repos_url":"https://api.github.com/users/blackbaud-sky-savage/repos","events_url":"https://api.github.com/users/blackbaud-sky-savage/events{/privacy}","received_events_url":"https://api.github.com/users/blackbaud-sky-savage/received_events","type":"User","site_admin":false},"created_at":"2018-05-07T15:49:44Z","updated_at":"2018-05-07T15:49:44Z","author_association":"MEMBER","body":"\n**Tests passed.** Automated cross-browser testing via BrowserStack and Travis CI shows that the JavaScript changes in this pull request are: **CONFIRMED**\n\nCommit: b4118873bee80680fa8e0d71494fed74f21c53df\nBuild details: https://travis-ci.org/blackbaud-sky-savage/skyux2/builds/375943591\n\n(*Please note that this is a [fully automated](https://github.com/twbs/savage) comment.*)\n      "}}
{"actor":{"display_login":"blackbaud-sky-savage"}}