{"action":"created","comment":{"url":"https://api.github.com/repos/scality/Zenko/pulls/comments/213510907","pull_request_review_id":150362929,"id":213510907,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzUxMDkwNw==","diff_hunk":"@@ -29,8 +29,7 @@ redis:\n health:\n   port: 4042\n   path:\n-    liveness: /_/health/liveness\n-    readiness: /_/health/readiness\n+    liveness: /_/health/readiness","path":"kubernetes/zenko/charts/backbeat/values.yaml","position":6,"original_position":6,"commit_id":"b52dfcec91027a0b1fc6fd31ec36babfe5d28089","original_commit_id":"b52dfcec91027a0b1fc6fd31ec36babfe5d28089","user":{"login":"giacomoguiulfo","id":22091600,"node_id":"MDQ6VXNlcjIyMDkxNjAw","avatar_url":"https://avatars1.githubusercontent.com/u/22091600?v=4","gravatar_id":"","url":"https://api.github.com/users/giacomoguiulfo","html_url":"https://github.com/giacomoguiulfo","followers_url":"https://api.github.com/users/giacomoguiulfo/followers","following_url":"https://api.github.com/users/giacomoguiulfo/following{/other_user}","gists_url":"https://api.github.com/users/giacomoguiulfo/gists{/gist_id}","starred_url":"https://api.github.com/users/giacomoguiulfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giacomoguiulfo/subscriptions","organizations_url":"https://api.github.com/users/giacomoguiulfo/orgs","repos_url":"https://api.github.com/users/giacomoguiulfo/repos","events_url":"https://api.github.com/users/giacomoguiulfo/events{/privacy}","received_events_url":"https://api.github.com/users/giacomoguiulfo/received_events","type":"User","site_admin":false},"body":"It's clearly not the best way. But it's the only way of solving this issue without having to rebuild the `Backbeat` image (which we only do for releases). The reason for expediting this change without an image rebuild is because this is critical (IMHO).","created_at":"2018-08-29T00:12:04Z","updated_at":"2018-08-29T00:12:04Z","html_url":"https://github.com/scality/Zenko/pull/307#discussion_r213510907","pull_request_url":"https://api.github.com/repos/scality/Zenko/pulls/307","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/scality/Zenko/pulls/comments/213510907"},"html":{"href":"https://github.com/scality/Zenko/pull/307#discussion_r213510907"},"pull_request":{"href":"https://api.github.com/repos/scality/Zenko/pulls/307"}},"in_reply_to_id":213505335},"pull_request":{"url":"https://api.github.com/repos/scality/Zenko/pulls/307","id":211587730,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExNTg3NzMw","html_url":"https://github.com/scality/Zenko/pull/307","diff_url":"https://github.com/scality/Zenko/pull/307.diff","patch_url":"https://github.com/scality/Zenko/pull/307.patch","issue_url":"https://api.github.com/repos/scality/Zenko/issues/307","number":307,"state":"open","locked":false,"title":"ZENKO-1085 bugfix: backbeat liveness probes","user":{"login":"giacomoguiulfo","id":22091600,"node_id":"MDQ6VXNlcjIyMDkxNjAw","avatar_url":"https://avatars1.githubusercontent.com/u/22091600?v=4","gravatar_id":"","url":"https://api.github.com/users/giacomoguiulfo","html_url":"https://github.com/giacomoguiulfo","followers_url":"https://api.github.com/users/giacomoguiulfo/followers","following_url":"https://api.github.com/users/giacomoguiulfo/following{/other_user}","gists_url":"https://api.github.com/users/giacomoguiulfo/gists{/gist_id}","starred_url":"https://api.github.com/users/giacomoguiulfo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/giacomoguiulfo/subscriptions","organizations_url":"https://api.github.com/users/giacomoguiulfo/orgs","repos_url":"https://api.github.com/users/giacomoguiulfo/repos","events_url":"https://api.github.com/users/giacomoguiulfo/events{/privacy}","received_events_url":"https://api.github.com/users/giacomoguiulfo/received_events","type":"User","site_admin":false},"body":"There is no point on having readiness probes for\r\nthe Backbeat pods since they don't serve requests\r\n(except for BackbeatAPI).\r\n\r\nAlso, the **readiness** probe route is more appropriate for\r\nthe **liveness** probe since it detects when a connection\r\nto a dependency (i.e. Zookeeper) is lost and\r\nKubernetes can take advantage of that to restart\r\npods and allow them to reconnect properly. This is\r\nnecessary since the Backbeat pods don't seem to recover\r\non their own from these disconnections.","created_at":"2018-08-28T23:32:22Z","updated_at":"2018-08-29T00:12:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b750e59e391f3d63392daa91de1be2ef3719b455","assignee":null,"assignees":[],"requested_reviewers":[{"login":"rahulreddy","id":914178,"node_id":"MDQ6VXNlcjkxNDE3OA==","avatar_url":"https://avatars1.githubusercontent.com/u/914178?v=4","gravatar_id":"","url":"https://api.github.com/users/rahulreddy","html_url":"https://github.com/rahulreddy","followers_url":"https://api.github.com/users/rahulreddy/followers","following_url":"https://api.github.com/users/rahulreddy/following{/other_user}","gists_url":"https://api.github.com/users/rahulreddy/gists{/gist_id}","starred_url":"https://api.github.com/users/rahulreddy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rahulreddy/subscriptions","organizations_url":"https://api.github.com/users/rahulreddy/orgs","repos_url":"https://api.github.com/users/rahulreddy/repos","events_url":"https://api.github.com/users/rahulreddy/events{/privacy}","received_events_url":"https://api.github.com/users/rahulreddy/received_events","type":"User","site_admin":false},{"login":"jonathan-gramain","id":3418241,"node_id":"MDQ6VXNlcjM0MTgyNDE=","avatar_url":"https://avatars1.githubusercontent.com/u/3418241?v=4","gravatar_id":"","url":"https://api.github.com/users/jonathan-gramain","html_url":"https://github.com/jonathan-gramain","followers_url":"https://api.github.com/users/jonathan-gramain/followers","following_url":"https://api.github.com/users/jonathan-gramain/following{/other_user}","gists_url":"https://api.github.com/users/jonathan-gramain/gists{/gist_id}","starred_url":"https://api.github.com/users/jonathan-gramain/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jonathan-gramain/subscriptions","organizations_url":"https://api.github.com/users/jonathan-gramain/orgs","repos_url":"https://api.github.com/users/jonathan-gramain/repos","events_url":"https://api.github.com/users/jonathan-gramain/events{/privacy}","received_events_url":"https://api.github.com/users/jonathan-gramain/received_events","type":"User","site_admin":false},{"login":"tmacro","id":18455818,"node_id":"MDQ6VXNlcjE4NDU1ODE4","avatar_url":"https://avatars0.githubusercontent.com/u/18455818?v=4","gravatar_id":"","url":"https://api.github.com/users/tmacro","html_url":"https://github.com/tmacro","followers_url":"https://api.github.com/users/tmacro/followers","following_url":"https://api.github.com/users/tmacro/following{/other_user}","gists_url":"https://api.github.com/users/tmacro/gists{/gist_id}","starred_url":"https://api.github.com/users/tmacro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmacro/subscriptions","organizations_url":"https://api.github.com/users/tmacro/orgs","repos_url":"https://api.github.com/users/tmacro/repos","events_url":"https://api.github.com/users/tmacro/events{/privacy}","received_events_url":"https://api.github.com/users/tmacro/received_events","type":"User","site_admin":false},{"login":"ssalaues","id":24439848,"node_id":"MDQ6VXNlcjI0NDM5ODQ4","avatar_url":"https://avatars1.githubusercontent.com/u/24439848?v=4","gravatar_id":"","url":"https://api.github.com/users/ssalaues","html_url":"https://github.com/ssalaues","followers_url":"https://api.github.com/users/ssalaues/followers","following_url":"https://api.github.com/users/ssalaues/following{/other_user}","gists_url":"https://api.github.com/users/ssalaues/gists{/gist_id}","starred_url":"https://api.github.com/users/ssalaues/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ssalaues/subscriptions","organizations_url":"https://api.github.com/users/ssalaues/orgs","repos_url":"https://api.github.com/users/ssalaues/repos","events_url":"https://api.github.com/users/ssalaues/events{/privacy}","received_events_url":"https://api.github.com/users/ssalaues/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1025469355,"node_id":"MDU6TGFiZWwxMDI1NDY5MzU1","url":"https://api.github.com/repos/scality/Zenko/labels/backbeat","name":"backbeat","color":"274893","default":false},{"id":1026636568,"node_id":"MDU6TGFiZWwxMDI2NjM2NTY4","url":"https://api.github.com/repos/scality/Zenko/labels/charts","name":"charts","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/scality/Zenko/pulls/307/commits","review_comments_url":"https://api.github.com/repos/scality/Zenko/pulls/307/comments","review_comment_url":"https://api.github.com/repos/scality/Zenko/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scality/Zenko/issues/307/comments","statuses_url":"https://api.github.com/repos/scality/Zenko/statuses/b52dfcec91027a0b1fc6fd31ec36babfe5d28089","head":{"label":"scality:bugfix/ZENKO-1085-improve-backbeat-liveness-probes","ref":"bugfix/ZENKO-1085-improve-backbeat-liveness-probes","sha":"b52dfcec91027a0b1fc6fd31ec36babfe5d28089","user":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":93576430,"node_id":"MDEwOlJlcG9zaXRvcnk5MzU3NjQzMA==","name":"Zenko","full_name":"scality/Zenko","owner":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/Zenko","description":"Zenko is the open source multi-cloud data controller: own and keep control of your data on any cloud.","fork":false,"url":"https://api.github.com/repos/scality/Zenko","forks_url":"https://api.github.com/repos/scality/Zenko/forks","keys_url":"https://api.github.com/repos/scality/Zenko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/Zenko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/Zenko/teams","hooks_url":"https://api.github.com/repos/scality/Zenko/hooks","issue_events_url":"https://api.github.com/repos/scality/Zenko/issues/events{/number}","events_url":"https://api.github.com/repos/scality/Zenko/events","assignees_url":"https://api.github.com/repos/scality/Zenko/assignees{/user}","branches_url":"https://api.github.com/repos/scality/Zenko/branches{/branch}","tags_url":"https://api.github.com/repos/scality/Zenko/tags","blobs_url":"https://api.github.com/repos/scality/Zenko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/Zenko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/Zenko/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/Zenko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/Zenko/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/Zenko/languages","stargazers_url":"https://api.github.com/repos/scality/Zenko/stargazers","contributors_url":"https://api.github.com/repos/scality/Zenko/contributors","subscribers_url":"https://api.github.com/repos/scality/Zenko/subscribers","subscription_url":"https://api.github.com/repos/scality/Zenko/subscription","commits_url":"https://api.github.com/repos/scality/Zenko/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/Zenko/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/Zenko/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/Zenko/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/Zenko/contents/{+path}","compare_url":"https://api.github.com/repos/scality/Zenko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/Zenko/merges","archive_url":"https://api.github.com/repos/scality/Zenko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/Zenko/downloads","issues_url":"https://api.github.com/repos/scality/Zenko/issues{/number}","pulls_url":"https://api.github.com/repos/scality/Zenko/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/Zenko/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/Zenko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/Zenko/labels{/name}","releases_url":"https://api.github.com/repos/scality/Zenko/releases{/id}","deployments_url":"https://api.github.com/repos/scality/Zenko/deployments","created_at":"2017-06-07T00:53:14Z","updated_at":"2018-08-28T00:37:47Z","pushed_at":"2018-08-29T00:11:30Z","git_url":"git://github.com/scality/Zenko.git","ssh_url":"git@github.com:scality/Zenko.git","clone_url":"https://github.com/scality/Zenko.git","svn_url":"https://github.com/scality/Zenko","homepage":"https://www.zenko.io","size":1845,"stargazers_count":155,"watchers_count":155,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":23,"watchers":155,"default_branch":"development/0.9"}},"base":{"label":"scality:development/0.9","ref":"development/0.9","sha":"33316ec8f1f7084a0861dc99789d73023b67f9fb","user":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"repo":{"id":93576430,"node_id":"MDEwOlJlcG9zaXRvcnk5MzU3NjQzMA==","name":"Zenko","full_name":"scality/Zenko","owner":{"login":"scality","id":383812,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM4MzgxMg==","avatar_url":"https://avatars1.githubusercontent.com/u/383812?v=4","gravatar_id":"","url":"https://api.github.com/users/scality","html_url":"https://github.com/scality","followers_url":"https://api.github.com/users/scality/followers","following_url":"https://api.github.com/users/scality/following{/other_user}","gists_url":"https://api.github.com/users/scality/gists{/gist_id}","starred_url":"https://api.github.com/users/scality/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scality/subscriptions","organizations_url":"https://api.github.com/users/scality/orgs","repos_url":"https://api.github.com/users/scality/repos","events_url":"https://api.github.com/users/scality/events{/privacy}","received_events_url":"https://api.github.com/users/scality/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scality/Zenko","description":"Zenko is the open source multi-cloud data controller: own and keep control of your data on any cloud.","fork":false,"url":"https://api.github.com/repos/scality/Zenko","forks_url":"https://api.github.com/repos/scality/Zenko/forks","keys_url":"https://api.github.com/repos/scality/Zenko/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scality/Zenko/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scality/Zenko/teams","hooks_url":"https://api.github.com/repos/scality/Zenko/hooks","issue_events_url":"https://api.github.com/repos/scality/Zenko/issues/events{/number}","events_url":"https://api.github.com/repos/scality/Zenko/events","assignees_url":"https://api.github.com/repos/scality/Zenko/assignees{/user}","branches_url":"https://api.github.com/repos/scality/Zenko/branches{/branch}","tags_url":"https://api.github.com/repos/scality/Zenko/tags","blobs_url":"https://api.github.com/repos/scality/Zenko/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scality/Zenko/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scality/Zenko/git/refs{/sha}","trees_url":"https://api.github.com/repos/scality/Zenko/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scality/Zenko/statuses/{sha}","languages_url":"https://api.github.com/repos/scality/Zenko/languages","stargazers_url":"https://api.github.com/repos/scality/Zenko/stargazers","contributors_url":"https://api.github.com/repos/scality/Zenko/contributors","subscribers_url":"https://api.github.com/repos/scality/Zenko/subscribers","subscription_url":"https://api.github.com/repos/scality/Zenko/subscription","commits_url":"https://api.github.com/repos/scality/Zenko/commits{/sha}","git_commits_url":"https://api.github.com/repos/scality/Zenko/git/commits{/sha}","comments_url":"https://api.github.com/repos/scality/Zenko/comments{/number}","issue_comment_url":"https://api.github.com/repos/scality/Zenko/issues/comments{/number}","contents_url":"https://api.github.com/repos/scality/Zenko/contents/{+path}","compare_url":"https://api.github.com/repos/scality/Zenko/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scality/Zenko/merges","archive_url":"https://api.github.com/repos/scality/Zenko/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scality/Zenko/downloads","issues_url":"https://api.github.com/repos/scality/Zenko/issues{/number}","pulls_url":"https://api.github.com/repos/scality/Zenko/pulls{/number}","milestones_url":"https://api.github.com/repos/scality/Zenko/milestones{/number}","notifications_url":"https://api.github.com/repos/scality/Zenko/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scality/Zenko/labels{/name}","releases_url":"https://api.github.com/repos/scality/Zenko/releases{/id}","deployments_url":"https://api.github.com/repos/scality/Zenko/deployments","created_at":"2017-06-07T00:53:14Z","updated_at":"2018-08-28T00:37:47Z","pushed_at":"2018-08-29T00:11:30Z","git_url":"git://github.com/scality/Zenko.git","ssh_url":"git@github.com:scality/Zenko.git","clone_url":"https://github.com/scality/Zenko.git","svn_url":"https://github.com/scality/Zenko","homepage":"https://www.zenko.io","size":1845,"stargazers_count":155,"watchers_count":155,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":40,"mirror_url":null,"archived":false,"open_issues_count":23,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":40,"open_issues":23,"watchers":155,"default_branch":"development/0.9"}},"_links":{"self":{"href":"https://api.github.com/repos/scality/Zenko/pulls/307"},"html":{"href":"https://github.com/scality/Zenko/pull/307"},"issue":{"href":"https://api.github.com/repos/scality/Zenko/issues/307"},"comments":{"href":"https://api.github.com/repos/scality/Zenko/issues/307/comments"},"review_comments":{"href":"https://api.github.com/repos/scality/Zenko/pulls/307/comments"},"review_comment":{"href":"https://api.github.com/repos/scality/Zenko/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scality/Zenko/pulls/307/commits"},"statuses":{"href":"https://api.github.com/repos/scality/Zenko/statuses/b52dfcec91027a0b1fc6fd31ec36babfe5d28089"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"giacomoguiulfo"}}