{"action":"created","comment":{"url":"https://api.github.com/repos/linkernetworks/oauth/pulls/comments/198466871","pull_request_review_id":132400536,"id":198466871,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODQ2Njg3MQ==","diff_hunk":"@@ -83,31 +92,32 @@ func (s *OAuthServer) startHTTP() {\n \t\tif https {\n \t\t\tbind := \":\" + strconv.Itoa(s.config.HTTPSPort)\n \t\t\tlogger.Infof(\"Starting HTTPS server on [%v]\", bind)\n-\t\t\terr := http.ListenAndServeTLS(bind, s.config.CertPublicKey, s.config.CertPrivateKey, r)\n+\n+\t\t\ts.httpServer = &http.Server{\n+\t\t\t\tAddr:    bind,\n+\t\t\t\tHandler: r,\n+\t\t\t}\n+\n+\t\t\terr := s.httpServer.ListenAndServeTLS(s.config.CertPublicKey, s.config.CertPrivateKey)\n+","path":"src/server/server.go","position":115,"original_position":115,"commit_id":"db01be66657d44aa3a24091561bb8f54543249b5","original_commit_id":"db01be66657d44aa3a24091561bb8f54543249b5","user":{"login":"c9s","id":50894,"node_id":"MDQ6VXNlcjUwODk0","avatar_url":"https://avatars2.githubusercontent.com/u/50894?v=4","gravatar_id":"","url":"https://api.github.com/users/c9s","html_url":"https://github.com/c9s","followers_url":"https://api.github.com/users/c9s/followers","following_url":"https://api.github.com/users/c9s/following{/other_user}","gists_url":"https://api.github.com/users/c9s/gists{/gist_id}","starred_url":"https://api.github.com/users/c9s/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/c9s/subscriptions","organizations_url":"https://api.github.com/users/c9s/orgs","repos_url":"https://api.github.com/users/c9s/repos","events_url":"https://api.github.com/users/c9s/events{/privacy}","received_events_url":"https://api.github.com/users/c9s/received_events","type":"User","site_admin":false},"body":"You should keep the go routine concise, things that don’t need to be parallelized should be moved out of the go routine ","created_at":"2018-06-27T11:59:56Z","updated_at":"2018-06-27T12:03:19Z","html_url":"https://github.com/linkernetworks/oauth/pull/12#discussion_r198466871","pull_request_url":"https://api.github.com/repos/linkernetworks/oauth/pulls/12","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/linkernetworks/oauth/pulls/comments/198466871"},"html":{"href":"https://github.com/linkernetworks/oauth/pull/12#discussion_r198466871"},"pull_request":{"href":"https://api.github.com/repos/linkernetworks/oauth/pulls/12"}}},"pull_request":{"url":"https://api.github.com/repos/linkernetworks/oauth/pulls/12","id":197626267,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NjI2MjY3","html_url":"https://github.com/linkernetworks/oauth/pull/12","diff_url":"https://github.com/linkernetworks/oauth/pull/12.diff","patch_url":"https://github.com/linkernetworks/oauth/pull/12.patch","issue_url":"https://api.github.com/repos/linkernetworks/oauth/issues/12","number":12,"state":"open","locked":false,"title":"VX-137: Use gin route","user":{"login":"yarencheng","id":12826604,"node_id":"MDQ6VXNlcjEyODI2NjA0","avatar_url":"https://avatars1.githubusercontent.com/u/12826604?v=4","gravatar_id":"","url":"https://api.github.com/users/yarencheng","html_url":"https://github.com/yarencheng","followers_url":"https://api.github.com/users/yarencheng/followers","following_url":"https://api.github.com/users/yarencheng/following{/other_user}","gists_url":"https://api.github.com/users/yarencheng/gists{/gist_id}","starred_url":"https://api.github.com/users/yarencheng/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yarencheng/subscriptions","organizations_url":"https://api.github.com/users/yarencheng/orgs","repos_url":"https://api.github.com/users/yarencheng/repos","events_url":"https://api.github.com/users/yarencheng/events{/privacy}","received_events_url":"https://api.github.com/users/yarencheng/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-27T06:16:09Z","updated_at":"2018-06-27T12:03:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c11dba77cc44d23ba8547478f40e23a0d6cd98f0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/linkernetworks/oauth/pulls/12/commits","review_comments_url":"https://api.github.com/repos/linkernetworks/oauth/pulls/12/comments","review_comment_url":"https://api.github.com/repos/linkernetworks/oauth/pulls/comments{/number}","comments_url":"https://api.github.com/repos/linkernetworks/oauth/issues/12/comments","statuses_url":"https://api.github.com/repos/linkernetworks/oauth/statuses/db01be66657d44aa3a24091561bb8f54543249b5","head":{"label":"linkernetworks:aren/VX-137","ref":"aren/VX-137","sha":"db01be66657d44aa3a24091561bb8f54543249b5","user":{"login":"linkernetworks","id":16631987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjMxOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/16631987?v=4","gravatar_id":"","url":"https://api.github.com/users/linkernetworks","html_url":"https://github.com/linkernetworks","followers_url":"https://api.github.com/users/linkernetworks/followers","following_url":"https://api.github.com/users/linkernetworks/following{/other_user}","gists_url":"https://api.github.com/users/linkernetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/linkernetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkernetworks/subscriptions","organizations_url":"https://api.github.com/users/linkernetworks/orgs","repos_url":"https://api.github.com/users/linkernetworks/repos","events_url":"https://api.github.com/users/linkernetworks/events{/privacy}","received_events_url":"https://api.github.com/users/linkernetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":135102085,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxMDIwODU=","name":"oauth","full_name":"linkernetworks/oauth","owner":{"login":"linkernetworks","id":16631987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjMxOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/16631987?v=4","gravatar_id":"","url":"https://api.github.com/users/linkernetworks","html_url":"https://github.com/linkernetworks","followers_url":"https://api.github.com/users/linkernetworks/followers","following_url":"https://api.github.com/users/linkernetworks/following{/other_user}","gists_url":"https://api.github.com/users/linkernetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/linkernetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkernetworks/subscriptions","organizations_url":"https://api.github.com/users/linkernetworks/orgs","repos_url":"https://api.github.com/users/linkernetworks/repos","events_url":"https://api.github.com/users/linkernetworks/events{/privacy}","received_events_url":"https://api.github.com/users/linkernetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkernetworks/oauth","description":"LinkerNetwork OAuth Server","fork":false,"url":"https://api.github.com/repos/linkernetworks/oauth","forks_url":"https://api.github.com/repos/linkernetworks/oauth/forks","keys_url":"https://api.github.com/repos/linkernetworks/oauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkernetworks/oauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkernetworks/oauth/teams","hooks_url":"https://api.github.com/repos/linkernetworks/oauth/hooks","issue_events_url":"https://api.github.com/repos/linkernetworks/oauth/issues/events{/number}","events_url":"https://api.github.com/repos/linkernetworks/oauth/events","assignees_url":"https://api.github.com/repos/linkernetworks/oauth/assignees{/user}","branches_url":"https://api.github.com/repos/linkernetworks/oauth/branches{/branch}","tags_url":"https://api.github.com/repos/linkernetworks/oauth/tags","blobs_url":"https://api.github.com/repos/linkernetworks/oauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkernetworks/oauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkernetworks/oauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkernetworks/oauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkernetworks/oauth/statuses/{sha}","languages_url":"https://api.github.com/repos/linkernetworks/oauth/languages","stargazers_url":"https://api.github.com/repos/linkernetworks/oauth/stargazers","contributors_url":"https://api.github.com/repos/linkernetworks/oauth/contributors","subscribers_url":"https://api.github.com/repos/linkernetworks/oauth/subscribers","subscription_url":"https://api.github.com/repos/linkernetworks/oauth/subscription","commits_url":"https://api.github.com/repos/linkernetworks/oauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkernetworks/oauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkernetworks/oauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkernetworks/oauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkernetworks/oauth/contents/{+path}","compare_url":"https://api.github.com/repos/linkernetworks/oauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkernetworks/oauth/merges","archive_url":"https://api.github.com/repos/linkernetworks/oauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkernetworks/oauth/downloads","issues_url":"https://api.github.com/repos/linkernetworks/oauth/issues{/number}","pulls_url":"https://api.github.com/repos/linkernetworks/oauth/pulls{/number}","milestones_url":"https://api.github.com/repos/linkernetworks/oauth/milestones{/number}","notifications_url":"https://api.github.com/repos/linkernetworks/oauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkernetworks/oauth/labels{/name}","releases_url":"https://api.github.com/repos/linkernetworks/oauth/releases{/id}","deployments_url":"https://api.github.com/repos/linkernetworks/oauth/deployments","created_at":"2018-05-28T02:51:07Z","updated_at":"2018-06-27T06:23:22Z","pushed_at":"2018-06-27T10:28:49Z","git_url":"git://github.com/linkernetworks/oauth.git","ssh_url":"git@github.com:linkernetworks/oauth.git","clone_url":"https://github.com/linkernetworks/oauth.git","svn_url":"https://github.com/linkernetworks/oauth","homepage":"","size":120,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":4,"default_branch":"develop"}},"base":{"label":"linkernetworks:develop","ref":"develop","sha":"baf5bb43cc4b8148aad9572768d573cbc53d7e0d","user":{"login":"linkernetworks","id":16631987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjMxOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/16631987?v=4","gravatar_id":"","url":"https://api.github.com/users/linkernetworks","html_url":"https://github.com/linkernetworks","followers_url":"https://api.github.com/users/linkernetworks/followers","following_url":"https://api.github.com/users/linkernetworks/following{/other_user}","gists_url":"https://api.github.com/users/linkernetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/linkernetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkernetworks/subscriptions","organizations_url":"https://api.github.com/users/linkernetworks/orgs","repos_url":"https://api.github.com/users/linkernetworks/repos","events_url":"https://api.github.com/users/linkernetworks/events{/privacy}","received_events_url":"https://api.github.com/users/linkernetworks/received_events","type":"Organization","site_admin":false},"repo":{"id":135102085,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUxMDIwODU=","name":"oauth","full_name":"linkernetworks/oauth","owner":{"login":"linkernetworks","id":16631987,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NjMxOTg3","avatar_url":"https://avatars2.githubusercontent.com/u/16631987?v=4","gravatar_id":"","url":"https://api.github.com/users/linkernetworks","html_url":"https://github.com/linkernetworks","followers_url":"https://api.github.com/users/linkernetworks/followers","following_url":"https://api.github.com/users/linkernetworks/following{/other_user}","gists_url":"https://api.github.com/users/linkernetworks/gists{/gist_id}","starred_url":"https://api.github.com/users/linkernetworks/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linkernetworks/subscriptions","organizations_url":"https://api.github.com/users/linkernetworks/orgs","repos_url":"https://api.github.com/users/linkernetworks/repos","events_url":"https://api.github.com/users/linkernetworks/events{/privacy}","received_events_url":"https://api.github.com/users/linkernetworks/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/linkernetworks/oauth","description":"LinkerNetwork OAuth Server","fork":false,"url":"https://api.github.com/repos/linkernetworks/oauth","forks_url":"https://api.github.com/repos/linkernetworks/oauth/forks","keys_url":"https://api.github.com/repos/linkernetworks/oauth/keys{/key_id}","collaborators_url":"https://api.github.com/repos/linkernetworks/oauth/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/linkernetworks/oauth/teams","hooks_url":"https://api.github.com/repos/linkernetworks/oauth/hooks","issue_events_url":"https://api.github.com/repos/linkernetworks/oauth/issues/events{/number}","events_url":"https://api.github.com/repos/linkernetworks/oauth/events","assignees_url":"https://api.github.com/repos/linkernetworks/oauth/assignees{/user}","branches_url":"https://api.github.com/repos/linkernetworks/oauth/branches{/branch}","tags_url":"https://api.github.com/repos/linkernetworks/oauth/tags","blobs_url":"https://api.github.com/repos/linkernetworks/oauth/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/linkernetworks/oauth/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/linkernetworks/oauth/git/refs{/sha}","trees_url":"https://api.github.com/repos/linkernetworks/oauth/git/trees{/sha}","statuses_url":"https://api.github.com/repos/linkernetworks/oauth/statuses/{sha}","languages_url":"https://api.github.com/repos/linkernetworks/oauth/languages","stargazers_url":"https://api.github.com/repos/linkernetworks/oauth/stargazers","contributors_url":"https://api.github.com/repos/linkernetworks/oauth/contributors","subscribers_url":"https://api.github.com/repos/linkernetworks/oauth/subscribers","subscription_url":"https://api.github.com/repos/linkernetworks/oauth/subscription","commits_url":"https://api.github.com/repos/linkernetworks/oauth/commits{/sha}","git_commits_url":"https://api.github.com/repos/linkernetworks/oauth/git/commits{/sha}","comments_url":"https://api.github.com/repos/linkernetworks/oauth/comments{/number}","issue_comment_url":"https://api.github.com/repos/linkernetworks/oauth/issues/comments{/number}","contents_url":"https://api.github.com/repos/linkernetworks/oauth/contents/{+path}","compare_url":"https://api.github.com/repos/linkernetworks/oauth/compare/{base}...{head}","merges_url":"https://api.github.com/repos/linkernetworks/oauth/merges","archive_url":"https://api.github.com/repos/linkernetworks/oauth/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/linkernetworks/oauth/downloads","issues_url":"https://api.github.com/repos/linkernetworks/oauth/issues{/number}","pulls_url":"https://api.github.com/repos/linkernetworks/oauth/pulls{/number}","milestones_url":"https://api.github.com/repos/linkernetworks/oauth/milestones{/number}","notifications_url":"https://api.github.com/repos/linkernetworks/oauth/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/linkernetworks/oauth/labels{/name}","releases_url":"https://api.github.com/repos/linkernetworks/oauth/releases{/id}","deployments_url":"https://api.github.com/repos/linkernetworks/oauth/deployments","created_at":"2018-05-28T02:51:07Z","updated_at":"2018-06-27T06:23:22Z","pushed_at":"2018-06-27T10:28:49Z","git_url":"git://github.com/linkernetworks/oauth.git","ssh_url":"git@github.com:linkernetworks/oauth.git","clone_url":"https://github.com/linkernetworks/oauth.git","svn_url":"https://github.com/linkernetworks/oauth","homepage":"","size":120,"stargazers_count":4,"watchers_count":4,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":null,"forks":0,"open_issues":5,"watchers":4,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/linkernetworks/oauth/pulls/12"},"html":{"href":"https://github.com/linkernetworks/oauth/pull/12"},"issue":{"href":"https://api.github.com/repos/linkernetworks/oauth/issues/12"},"comments":{"href":"https://api.github.com/repos/linkernetworks/oauth/issues/12/comments"},"review_comments":{"href":"https://api.github.com/repos/linkernetworks/oauth/pulls/12/comments"},"review_comment":{"href":"https://api.github.com/repos/linkernetworks/oauth/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/linkernetworks/oauth/pulls/12/commits"},"statuses":{"href":"https://api.github.com/repos/linkernetworks/oauth/statuses/db01be66657d44aa3a24091561bb8f54543249b5"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"c9s"}}