{"action":"created","comment":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments/171542540","pull_request_review_id":100411394,"id":171542540,"diff_hunk":"@@ -73,7 +73,7 @@ open class BaseInstructionsBannerView: UIControl {\n     \n     func set(_ instruction: VisualInstruction?) {\n         let secondaryInstruction = instruction?.secondaryTextComponents\n-        primaryLabel.numberOfLines = secondaryInstruction == nil ? 2 : 1\n+        primaryLabel.numberOfLines = 1","path":"MapboxNavigation/InstructionsBannerView.swift","position":5,"original_position":5,"commit_id":"1de90007aa6761e68311155a533b28fc4b7fdc3a","original_commit_id":"04ed8d57e1550d221ff71b54697b215c58e99677","user":{"login":"frederoni","id":764476,"avatar_url":"https://avatars1.githubusercontent.com/u/764476?v=4","gravatar_id":"","url":"https://api.github.com/users/frederoni","html_url":"https://github.com/frederoni","followers_url":"https://api.github.com/users/frederoni/followers","following_url":"https://api.github.com/users/frederoni/following{/other_user}","gists_url":"https://api.github.com/users/frederoni/gists{/gist_id}","starred_url":"https://api.github.com/users/frederoni/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/frederoni/subscriptions","organizations_url":"https://api.github.com/users/frederoni/orgs","repos_url":"https://api.github.com/users/frederoni/repos","events_url":"https://api.github.com/users/frederoni/events{/privacy}","received_events_url":"https://api.github.com/users/frederoni/received_events","type":"User","site_admin":false},"body":"It would simplify the layout and snapshot tests. Note that this method https://github.com/mapbox/mapbox-navigation-ios/blob/2890d2f649b5d4f62285747d601c94cf565a6aad/MapboxNavigation/InstructionsBannerViewLayout.swift#L113-L117\r\nand accompanying arrays of constraints would be obsolete if we decide to make this change consistent.","created_at":"2018-03-01T12:24:23Z","updated_at":"2018-03-01T12:24:23Z","html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1169#discussion_r171542540","pull_request_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1169","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments/171542540"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-ios/pull/1169#discussion_r171542540"},"pull_request":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1169"}},"in_reply_to_id":171119232},"pull_request":{"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1169","id":171830964,"html_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1169","diff_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1169.diff","patch_url":"https://github.com/mapbox/mapbox-navigation-ios/pull/1169.patch","issue_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1169","number":1169,"state":"open","locked":false,"title":"Add abbreviations","user":{"login":"bsudekum","id":1058624,"avatar_url":"https://avatars0.githubusercontent.com/u/1058624?v=4","gravatar_id":"","url":"https://api.github.com/users/bsudekum","html_url":"https://github.com/bsudekum","followers_url":"https://api.github.com/users/bsudekum/followers","following_url":"https://api.github.com/users/bsudekum/following{/other_user}","gists_url":"https://api.github.com/users/bsudekum/gists{/gist_id}","starred_url":"https://api.github.com/users/bsudekum/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bsudekum/subscriptions","organizations_url":"https://api.github.com/users/bsudekum/orgs","repos_url":"https://api.github.com/users/bsudekum/repos","events_url":"https://api.github.com/users/bsudekum/events{/privacy}","received_events_url":"https://api.github.com/users/bsudekum/received_events","type":"User","site_admin":false},"body":"_Relies on: https://github.com/mapbox/MapboxDirections.swift/pull/244_\r\n\r\nThis adds abbreviations from the server.\r\n\r\ntodo: \r\n\r\n- [ ] Figure out how to use the `abbr_priority` key. Right now, we're just abbreviating in order they are given depending on if the text can fit. \r\n- [ ] Add tests\r\n\r\n/cc @mapbox/navigation-ios @danpaz ","created_at":"2018-02-28T01:16:00Z","updated_at":"2018-03-01T12:24:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0ab6ae84692a5187e3173379f1274b2fcf7b1f2d","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1169/commits","review_comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1169/comments","review_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1169/comments","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/1de90007aa6761e68311155a533b28fc4b7fdc3a","head":{"label":"mapbox:abbreviations","ref":"abbreviations","sha":"1de90007aa6761e68311155a533b28fc4b7fdc3a","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":73870932,"name":"mapbox-navigation-ios","full_name":"mapbox/mapbox-navigation-ios","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-ios","description":"Turn-by-turn navigation logic and UI in Swift or Objective-C on iOS","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/deployments","created_at":"2016-11-16T01:23:44Z","updated_at":"2018-02-28T18:45:16Z","pushed_at":"2018-02-28T20:21:11Z","git_url":"git://github.com/mapbox/mapbox-navigation-ios.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-ios.git","clone_url":"https://github.com/mapbox/mapbox-navigation-ios.git","svn_url":"https://github.com/mapbox/mapbox-navigation-ios","homepage":"https://www.mapbox.com/navigation-sdk/","size":41554,"stargazers_count":334,"watchers_count":334,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":66,"open_issues":99,"watchers":334,"default_branch":"master"}},"base":{"label":"mapbox:master","ref":"master","sha":"2890d2f649b5d4f62285747d601c94cf565a6aad","user":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"repo":{"id":73870932,"name":"mapbox-navigation-ios","full_name":"mapbox/mapbox-navigation-ios","owner":{"login":"mapbox","id":600935,"avatar_url":"https://avatars1.githubusercontent.com/u/600935?v=4","gravatar_id":"","url":"https://api.github.com/users/mapbox","html_url":"https://github.com/mapbox","followers_url":"https://api.github.com/users/mapbox/followers","following_url":"https://api.github.com/users/mapbox/following{/other_user}","gists_url":"https://api.github.com/users/mapbox/gists{/gist_id}","starred_url":"https://api.github.com/users/mapbox/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mapbox/subscriptions","organizations_url":"https://api.github.com/users/mapbox/orgs","repos_url":"https://api.github.com/users/mapbox/repos","events_url":"https://api.github.com/users/mapbox/events{/privacy}","received_events_url":"https://api.github.com/users/mapbox/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mapbox/mapbox-navigation-ios","description":"Turn-by-turn navigation logic and UI in Swift or Objective-C on iOS","fork":false,"url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios","forks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/forks","keys_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/teams","hooks_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/hooks","issue_events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/events{/number}","events_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/events","assignees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/assignees{/user}","branches_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/branches{/branch}","tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/tags","blobs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/refs{/sha}","trees_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/{sha}","languages_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/languages","stargazers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/stargazers","contributors_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contributors","subscribers_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscribers","subscription_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/subscription","commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/commits{/sha}","git_commits_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/git/commits{/sha}","comments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/comments{/number}","issue_comment_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/comments{/number}","contents_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/contents/{+path}","compare_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/merges","archive_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/downloads","issues_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues{/number}","pulls_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls{/number}","milestones_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/milestones{/number}","notifications_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/labels{/name}","releases_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/releases{/id}","deployments_url":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/deployments","created_at":"2016-11-16T01:23:44Z","updated_at":"2018-02-28T18:45:16Z","pushed_at":"2018-02-28T20:21:11Z","git_url":"git://github.com/mapbox/mapbox-navigation-ios.git","ssh_url":"git@github.com:mapbox/mapbox-navigation-ios.git","clone_url":"https://github.com/mapbox/mapbox-navigation-ios.git","svn_url":"https://github.com/mapbox/mapbox-navigation-ios","homepage":"https://www.mapbox.com/navigation-sdk/","size":41554,"stargazers_count":334,"watchers_count":334,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":99,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":66,"open_issues":99,"watchers":334,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1169"},"html":{"href":"https://github.com/mapbox/mapbox-navigation-ios/pull/1169"},"issue":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1169"},"comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/issues/1169/comments"},"review_comments":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1169/comments"},"review_comment":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/pulls/1169/commits"},"statuses":{"href":"https://api.github.com/repos/mapbox/mapbox-navigation-ios/statuses/1de90007aa6761e68311155a533b28fc4b7fdc3a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"frederoni"}}