{"action":"created","issue":{"url":"https://api.github.com/repos/vanilla/vanilla/issues/7715","repository_url":"https://api.github.com/repos/vanilla/vanilla","labels_url":"https://api.github.com/repos/vanilla/vanilla/issues/7715/labels{/name}","comments_url":"https://api.github.com/repos/vanilla/vanilla/issues/7715/comments","events_url":"https://api.github.com/repos/vanilla/vanilla/issues/7715/events","html_url":"https://github.com/vanilla/vanilla/pull/7715","id":356283407,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEyNTkzMzc5","number":7715,"title":"Fix Gdn_SQLDriver::whereNotIn for empty sets","user":{"login":"bleistivt","id":5205806,"node_id":"MDQ6VXNlcjUyMDU4MDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5205806?v=4","gravatar_id":"","url":"https://api.github.com/users/bleistivt","html_url":"https://github.com/bleistivt","followers_url":"https://api.github.com/users/bleistivt/followers","following_url":"https://api.github.com/users/bleistivt/following{/other_user}","gists_url":"https://api.github.com/users/bleistivt/gists{/gist_id}","starred_url":"https://api.github.com/users/bleistivt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bleistivt/subscriptions","organizations_url":"https://api.github.com/users/bleistivt/orgs","repos_url":"https://api.github.com/users/bleistivt/repos","events_url":"https://api.github.com/users/bleistivt/events{/privacy}","received_events_url":"https://api.github.com/users/bleistivt/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"charrondev","id":1770056,"node_id":"MDQ6VXNlcjE3NzAwNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1770056?v=4","gravatar_id":"","url":"https://api.github.com/users/charrondev","html_url":"https://github.com/charrondev","followers_url":"https://api.github.com/users/charrondev/followers","following_url":"https://api.github.com/users/charrondev/following{/other_user}","gists_url":"https://api.github.com/users/charrondev/gists{/gist_id}","starred_url":"https://api.github.com/users/charrondev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charrondev/subscriptions","organizations_url":"https://api.github.com/users/charrondev/orgs","repos_url":"https://api.github.com/users/charrondev/repos","events_url":"https://api.github.com/users/charrondev/events{/privacy}","received_events_url":"https://api.github.com/users/charrondev/received_events","type":"User","site_admin":false},"assignees":[{"login":"charrondev","id":1770056,"node_id":"MDQ6VXNlcjE3NzAwNTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1770056?v=4","gravatar_id":"","url":"https://api.github.com/users/charrondev","html_url":"https://github.com/charrondev","followers_url":"https://api.github.com/users/charrondev/followers","following_url":"https://api.github.com/users/charrondev/following{/other_user}","gists_url":"https://api.github.com/users/charrondev/gists{/gist_id}","starred_url":"https://api.github.com/users/charrondev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/charrondev/subscriptions","organizations_url":"https://api.github.com/users/charrondev/orgs","repos_url":"https://api.github.com/users/charrondev/repos","events_url":"https://api.github.com/users/charrondev/events{/privacy}","received_events_url":"https://api.github.com/users/charrondev/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/vanilla/vanilla/milestones/87","html_url":"https://github.com/vanilla/vanilla/milestone/87","labels_url":"https://api.github.com/repos/vanilla/vanilla/milestones/87/labels","id":3626177,"node_id":"MDk6TWlsZXN0b25lMzYyNjE3Nw==","number":87,"title":"2018-09-19","description":"","creator":{"login":"linc","id":117672,"node_id":"MDQ6VXNlcjExNzY3Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/117672?v=4","gravatar_id":"","url":"https://api.github.com/users/linc","html_url":"https://github.com/linc","followers_url":"https://api.github.com/users/linc/followers","following_url":"https://api.github.com/users/linc/following{/other_user}","gists_url":"https://api.github.com/users/linc/gists{/gist_id}","starred_url":"https://api.github.com/users/linc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/linc/subscriptions","organizations_url":"https://api.github.com/users/linc/orgs","repos_url":"https://api.github.com/users/linc/repos","events_url":"https://api.github.com/users/linc/events{/privacy}","received_events_url":"https://api.github.com/users/linc/received_events","type":"User","site_admin":false},"open_issues":7,"closed_issues":0,"state":"open","created_at":"2018-09-05T18:08:48Z","updated_at":"2018-09-06T23:33:13Z","due_on":"2018-09-19T07:00:00Z","closed_at":null},"comments":1,"created_at":"2018-09-02T13:41:24Z","updated_at":"2018-09-07T20:18:30Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vanilla/vanilla/pulls/7715","html_url":"https://github.com/vanilla/vanilla/pull/7715","diff_url":"https://github.com/vanilla/vanilla/pull/7715.diff","patch_url":"https://github.com/vanilla/vanilla/pull/7715.patch"},"body":"fixes #2969"},"comment":{"url":"https://api.github.com/repos/vanilla/vanilla/issues/comments/419554343","html_url":"https://github.com/vanilla/vanilla/pull/7715#issuecomment-419554343","issue_url":"https://api.github.com/repos/vanilla/vanilla/issues/7715","id":419554343,"node_id":"MDEyOklzc3VlQ29tbWVudDQxOTU1NDM0Mw==","user":{"login":"alex-mtl","id":15682507,"node_id":"MDQ6VXNlcjE1NjgyNTA3","avatar_url":"https://avatars0.githubusercontent.com/u/15682507?v=4","gravatar_id":"","url":"https://api.github.com/users/alex-mtl","html_url":"https://github.com/alex-mtl","followers_url":"https://api.github.com/users/alex-mtl/followers","following_url":"https://api.github.com/users/alex-mtl/following{/other_user}","gists_url":"https://api.github.com/users/alex-mtl/gists{/gist_id}","starred_url":"https://api.github.com/users/alex-mtl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alex-mtl/subscriptions","organizations_url":"https://api.github.com/users/alex-mtl/orgs","repos_url":"https://api.github.com/users/alex-mtl/repos","events_url":"https://api.github.com/users/alex-mtl/events{/privacy}","received_events_url":"https://api.github.com/users/alex-mtl/received_events","type":"User","site_admin":false},"created_at":"2018-09-07T20:18:30Z","updated_at":"2018-09-07T20:18:30Z","author_association":"CONTRIBUTOR","body":"I will not approve or refuse this \"improvement\".\r\n\r\nPersonally I disagree with initial issue statement:\r\n\r\n> This is contrary to what a developer might expect when writing e.g. SQL->whereNotIn('d.DiscussionID', array());\r\n\r\nI would be very surprised if ever meet such fragment of code. This particular one should kind never exist. What I would expect to meet:\r\n\r\n`SQL->whereNotIn('d.DiscussionID', $filterIds);`\r\n\r\nBut  that is another case. My opinion we need to check array before we call `whereNotIn` . \r\n\r\nThat method should bring Exception when gets an empty array as argument.\r\nBut that is my personal opinion. \r\n\r\nHowever, I think that such \"patch\" when result output of the method changes data to opposite (\"empty result\" before, and \"all records\" after) is pretty dangerous. I would prefer to keep that as is. It is very difficult or even impossible to test how often empty array is passed to `whereNotIn`.  "}}
{"actor":{"display_login":"alex-mtl"}}