{"action":"created","comment":{"url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/comments/237236266","pull_request_review_id":179481184,"id":237236266,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzIzNjI2Ng==","diff_hunk":"@@ -31,7 +32,9 @@ protected void createAttributes(T meta) {\n \t\tfor (String name : beanInformation.getAttributeNames()) {\n \t\t\tBeanAttributeInformation attrInformation = beanInformation.getAttribute(name);\n \t\t\tif (attrInformation.getGetter() != null && !isIgnored(attrInformation)) {\n-\t\t\t\tif (attrInformation.getGetter().getDeclaringClass() != implClass) {\n+\t\t\t\tboolean getterDeclaredInImplClass = attrInformation.getGetter().getDeclaringClass() == implClass;\n+\t\t\t\tboolean generic = attrInformation.getField().getGenericType() instanceof TypeVariable;\n+\t\t\t\tif (!getterDeclaredInImplClass && !generic) {","path":"crnk-meta/src/main/java/io/crnk/meta/internal/typed/MetaDataObjectProviderBase.java","position":15,"original_position":15,"commit_id":"9892e19ad55c3564b81b171a89f1aa6648070329","original_commit_id":"9892e19ad55c3564b81b171a89f1aa6648070329","user":{"login":"remmeier","id":8008853,"node_id":"MDQ6VXNlcjgwMDg4NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/8008853?v=4","gravatar_id":"","url":"https://api.github.com/users/remmeier","html_url":"https://github.com/remmeier","followers_url":"https://api.github.com/users/remmeier/followers","following_url":"https://api.github.com/users/remmeier/following{/other_user}","gists_url":"https://api.github.com/users/remmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/remmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remmeier/subscriptions","organizations_url":"https://api.github.com/users/remmeier/orgs","repos_url":"https://api.github.com/users/remmeier/repos","events_url":"https://api.github.com/users/remmeier/events{/privacy}","received_events_url":"https://api.github.com/users/remmeier/received_events","type":"User","site_admin":false},"body":"I'm a bit undecided about this one. The direction is good. But not sure, I think we can rather not make a new \"declarted\" MetaAttribute in the subtype. Somehow it should rather be reflected in the \"attributes\" rather than \"declaredAttributes\" list.","created_at":"2018-11-28T19:50:43Z","updated_at":"2018-11-28T19:51:53Z","html_url":"https://github.com/crnk-project/crnk-framework/pull/432#discussion_r237236266","pull_request_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/432","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/comments/237236266"},"html":{"href":"https://github.com/crnk-project/crnk-framework/pull/432#discussion_r237236266"},"pull_request":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/432"}}},"pull_request":{"url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/432","id":233994257,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMzOTk0MjU3","html_url":"https://github.com/crnk-project/crnk-framework/pull/432","diff_url":"https://github.com/crnk-project/crnk-framework/pull/432.diff","patch_url":"https://github.com/crnk-project/crnk-framework/pull/432.patch","issue_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues/432","number":432,"state":"open","locked":false,"title":"Resolve concrete types of type variables","user":{"login":"lorenzleutgeb","id":542154,"node_id":"MDQ6VXNlcjU0MjE1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/542154?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzleutgeb","html_url":"https://github.com/lorenzleutgeb","followers_url":"https://api.github.com/users/lorenzleutgeb/followers","following_url":"https://api.github.com/users/lorenzleutgeb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzleutgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzleutgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzleutgeb/subscriptions","organizations_url":"https://api.github.com/users/lorenzleutgeb/orgs","repos_url":"https://api.github.com/users/lorenzleutgeb/repos","events_url":"https://api.github.com/users/lorenzleutgeb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzleutgeb/received_events","type":"User","site_admin":false},"body":"This is an attempt to advance #430 by resolving the concrete types of type variables at runtime.\r\n\r\nI got my `JpaModule` to initialize, however requests to the meta module still fail with the same exception as described in #430.","created_at":"2018-11-27T17:15:37Z","updated_at":"2018-11-28T19:51:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9839b3a998ee7e1dbe0ddc368c7ceb5f6d0d9972","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/432/commits","review_comments_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/432/comments","review_comment_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues/432/comments","statuses_url":"https://api.github.com/repos/crnk-project/crnk-framework/statuses/9892e19ad55c3564b81b171a89f1aa6648070329","head":{"label":"lorenzleutgeb:generics","ref":"generics","sha":"9892e19ad55c3564b81b171a89f1aa6648070329","user":{"login":"lorenzleutgeb","id":542154,"node_id":"MDQ6VXNlcjU0MjE1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/542154?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzleutgeb","html_url":"https://github.com/lorenzleutgeb","followers_url":"https://api.github.com/users/lorenzleutgeb/followers","following_url":"https://api.github.com/users/lorenzleutgeb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzleutgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzleutgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzleutgeb/subscriptions","organizations_url":"https://api.github.com/users/lorenzleutgeb/orgs","repos_url":"https://api.github.com/users/lorenzleutgeb/repos","events_url":"https://api.github.com/users/lorenzleutgeb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzleutgeb/received_events","type":"User","site_admin":false},"repo":{"id":159321768,"node_id":"MDEwOlJlcG9zaXRvcnkxNTkzMjE3Njg=","name":"crnk-framework","full_name":"lorenzleutgeb/crnk-framework","private":false,"owner":{"login":"lorenzleutgeb","id":542154,"node_id":"MDQ6VXNlcjU0MjE1NA==","avatar_url":"https://avatars1.githubusercontent.com/u/542154?v=4","gravatar_id":"","url":"https://api.github.com/users/lorenzleutgeb","html_url":"https://github.com/lorenzleutgeb","followers_url":"https://api.github.com/users/lorenzleutgeb/followers","following_url":"https://api.github.com/users/lorenzleutgeb/following{/other_user}","gists_url":"https://api.github.com/users/lorenzleutgeb/gists{/gist_id}","starred_url":"https://api.github.com/users/lorenzleutgeb/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lorenzleutgeb/subscriptions","organizations_url":"https://api.github.com/users/lorenzleutgeb/orgs","repos_url":"https://api.github.com/users/lorenzleutgeb/repos","events_url":"https://api.github.com/users/lorenzleutgeb/events{/privacy}","received_events_url":"https://api.github.com/users/lorenzleutgeb/received_events","type":"User","site_admin":false},"html_url":"https://github.com/lorenzleutgeb/crnk-framework","description":"JSON API library for Java","fork":true,"url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework","forks_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/forks","keys_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/teams","hooks_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/hooks","issue_events_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/issues/events{/number}","events_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/events","assignees_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/assignees{/user}","branches_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/branches{/branch}","tags_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/tags","blobs_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/languages","stargazers_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/stargazers","contributors_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/contributors","subscribers_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/subscribers","subscription_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/subscription","commits_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/contents/{+path}","compare_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/merges","archive_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/downloads","issues_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/issues{/number}","pulls_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/labels{/name}","releases_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/releases{/id}","deployments_url":"https://api.github.com/repos/lorenzleutgeb/crnk-framework/deployments","created_at":"2018-11-27T11:01:33Z","updated_at":"2018-11-27T11:01:38Z","pushed_at":"2018-11-28T11:13:56Z","git_url":"git://github.com/lorenzleutgeb/crnk-framework.git","ssh_url":"git@github.com:lorenzleutgeb/crnk-framework.git","clone_url":"https://github.com/lorenzleutgeb/crnk-framework.git","svn_url":"https://github.com/lorenzleutgeb/crnk-framework","homepage":"","size":5311,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crnk-project:master","ref":"master","sha":"aa6497460633e1c0bcc07374b7d98b2d74aa0a97","user":{"login":"crnk-project","id":28780235,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzgwMjM1","avatar_url":"https://avatars0.githubusercontent.com/u/28780235?v=4","gravatar_id":"","url":"https://api.github.com/users/crnk-project","html_url":"https://github.com/crnk-project","followers_url":"https://api.github.com/users/crnk-project/followers","following_url":"https://api.github.com/users/crnk-project/following{/other_user}","gists_url":"https://api.github.com/users/crnk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crnk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crnk-project/subscriptions","organizations_url":"https://api.github.com/users/crnk-project/orgs","repos_url":"https://api.github.com/users/crnk-project/repos","events_url":"https://api.github.com/users/crnk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crnk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":91683656,"node_id":"MDEwOlJlcG9zaXRvcnk5MTY4MzY1Ng==","name":"crnk-framework","full_name":"crnk-project/crnk-framework","private":false,"owner":{"login":"crnk-project","id":28780235,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI4NzgwMjM1","avatar_url":"https://avatars0.githubusercontent.com/u/28780235?v=4","gravatar_id":"","url":"https://api.github.com/users/crnk-project","html_url":"https://github.com/crnk-project","followers_url":"https://api.github.com/users/crnk-project/followers","following_url":"https://api.github.com/users/crnk-project/following{/other_user}","gists_url":"https://api.github.com/users/crnk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crnk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crnk-project/subscriptions","organizations_url":"https://api.github.com/users/crnk-project/orgs","repos_url":"https://api.github.com/users/crnk-project/repos","events_url":"https://api.github.com/users/crnk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crnk-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/crnk-project/crnk-framework","description":"JSON API library for Java","fork":false,"url":"https://api.github.com/repos/crnk-project/crnk-framework","forks_url":"https://api.github.com/repos/crnk-project/crnk-framework/forks","keys_url":"https://api.github.com/repos/crnk-project/crnk-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crnk-project/crnk-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crnk-project/crnk-framework/teams","hooks_url":"https://api.github.com/repos/crnk-project/crnk-framework/hooks","issue_events_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues/events{/number}","events_url":"https://api.github.com/repos/crnk-project/crnk-framework/events","assignees_url":"https://api.github.com/repos/crnk-project/crnk-framework/assignees{/user}","branches_url":"https://api.github.com/repos/crnk-project/crnk-framework/branches{/branch}","tags_url":"https://api.github.com/repos/crnk-project/crnk-framework/tags","blobs_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crnk-project/crnk-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/crnk-project/crnk-framework/languages","stargazers_url":"https://api.github.com/repos/crnk-project/crnk-framework/stargazers","contributors_url":"https://api.github.com/repos/crnk-project/crnk-framework/contributors","subscribers_url":"https://api.github.com/repos/crnk-project/crnk-framework/subscribers","subscription_url":"https://api.github.com/repos/crnk-project/crnk-framework/subscription","commits_url":"https://api.github.com/repos/crnk-project/crnk-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/crnk-project/crnk-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/crnk-project/crnk-framework/contents/{+path}","compare_url":"https://api.github.com/repos/crnk-project/crnk-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crnk-project/crnk-framework/merges","archive_url":"https://api.github.com/repos/crnk-project/crnk-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crnk-project/crnk-framework/downloads","issues_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues{/number}","pulls_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/crnk-project/crnk-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/crnk-project/crnk-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crnk-project/crnk-framework/labels{/name}","releases_url":"https://api.github.com/repos/crnk-project/crnk-framework/releases{/id}","deployments_url":"https://api.github.com/repos/crnk-project/crnk-framework/deployments","created_at":"2017-05-18T11:06:31Z","updated_at":"2018-11-12T13:20:01Z","pushed_at":"2018-11-28T11:13:58Z","git_url":"git://github.com/crnk-project/crnk-framework.git","ssh_url":"git@github.com:crnk-project/crnk-framework.git","clone_url":"https://github.com/crnk-project/crnk-framework.git","svn_url":"https://github.com/crnk-project/crnk-framework","homepage":"","size":5331,"stargazers_count":106,"watchers_count":106,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":68,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":48,"open_issues":68,"watchers":106,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/432"},"html":{"href":"https://github.com/crnk-project/crnk-framework/pull/432"},"issue":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/issues/432"},"comments":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/issues/432/comments"},"review_comments":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/432/comments"},"review_comment":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/432/commits"},"statuses":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/statuses/9892e19ad55c3564b81b171a89f1aa6648070329"}},"author_association":"NONE"}}
{"actor":{"display_login":"remmeier"}}