{"action":"opened","number":2895,"pull_request":{"url":"https://api.github.com/repos/nunit/nunit/pulls/2895","id":195712024,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NzEyMDI0","html_url":"https://github.com/nunit/nunit/pull/2895","diff_url":"https://github.com/nunit/nunit/pull/2895.diff","patch_url":"https://github.com/nunit/nunit/pull/2895.patch","issue_url":"https://api.github.com/repos/nunit/nunit/issues/2895","number":2895,"state":"open","locked":false,"title":" Enable SetCulture and SetUICulture attributes for .NET-Standard 1.6 and fix tests that are failing in non-english locales","user":{"login":"Brar","id":335902,"node_id":"MDQ6VXNlcjMzNTkwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/335902?v=4","gravatar_id":"","url":"https://api.github.com/users/Brar","html_url":"https://github.com/Brar","followers_url":"https://api.github.com/users/Brar/followers","following_url":"https://api.github.com/users/Brar/following{/other_user}","gists_url":"https://api.github.com/users/Brar/gists{/gist_id}","starred_url":"https://api.github.com/users/Brar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brar/subscriptions","organizations_url":"https://api.github.com/users/Brar/orgs","repos_url":"https://api.github.com/users/Brar/repos","events_url":"https://api.github.com/users/Brar/events{/privacy}","received_events_url":"https://api.github.com/users/Brar/received_events","type":"User","site_admin":false},"body":"While drafting an initial pull request for #2889 I recognized some tests that are failing on my system due to locale issues (I'm on a de-DE locale).\r\n\r\nI looked into it and found that SetCulture/SetUICulture aren't used for NUnits own tests probably because those attributes are disabled for .Net-Standard 1.6.\r\n\r\nThis isn't really necessary and probably is a leftover from older compatibility requirements (perhaps PORTABLE or NETSTANDARD1_3).\r\n\r\nThis pull request  enables SetCultureAttribute and SetUICultureAttribute for .NET-Standard 1.6 which means that it now works on every platform that NUnit currently supports.\r\nIt also uses those attributes to fix some tests that are currently failing in non-english locales.\r\n\r\nAs this is pretty trivial I've opted for one pull request but left two separate commits to split the changes into logical units.","created_at":"2018-06-19T05:00:14Z","updated_at":"2018-06-19T05:00:14Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nunit/nunit/pulls/2895/commits","review_comments_url":"https://api.github.com/repos/nunit/nunit/pulls/2895/comments","review_comment_url":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nunit/nunit/issues/2895/comments","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/083fe3f5e283395bfa5a005db28aa72c8b5743f1","head":{"label":"Brar:SetCulture","ref":"SetCulture","sha":"083fe3f5e283395bfa5a005db28aa72c8b5743f1","user":{"login":"Brar","id":335902,"node_id":"MDQ6VXNlcjMzNTkwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/335902?v=4","gravatar_id":"","url":"https://api.github.com/users/Brar","html_url":"https://github.com/Brar","followers_url":"https://api.github.com/users/Brar/followers","following_url":"https://api.github.com/users/Brar/following{/other_user}","gists_url":"https://api.github.com/users/Brar/gists{/gist_id}","starred_url":"https://api.github.com/users/Brar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brar/subscriptions","organizations_url":"https://api.github.com/users/Brar/orgs","repos_url":"https://api.github.com/users/Brar/repos","events_url":"https://api.github.com/users/Brar/events{/privacy}","received_events_url":"https://api.github.com/users/Brar/received_events","type":"User","site_admin":false},"repo":{"id":137752962,"node_id":"MDEwOlJlcG9zaXRvcnkxMzc3NTI5NjI=","name":"nunit","full_name":"Brar/nunit","owner":{"login":"Brar","id":335902,"node_id":"MDQ6VXNlcjMzNTkwMg==","avatar_url":"https://avatars2.githubusercontent.com/u/335902?v=4","gravatar_id":"","url":"https://api.github.com/users/Brar","html_url":"https://github.com/Brar","followers_url":"https://api.github.com/users/Brar/followers","following_url":"https://api.github.com/users/Brar/following{/other_user}","gists_url":"https://api.github.com/users/Brar/gists{/gist_id}","starred_url":"https://api.github.com/users/Brar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Brar/subscriptions","organizations_url":"https://api.github.com/users/Brar/orgs","repos_url":"https://api.github.com/users/Brar/repos","events_url":"https://api.github.com/users/Brar/events{/privacy}","received_events_url":"https://api.github.com/users/Brar/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Brar/nunit","description":"NUnit 3.0 Framework","fork":true,"url":"https://api.github.com/repos/Brar/nunit","forks_url":"https://api.github.com/repos/Brar/nunit/forks","keys_url":"https://api.github.com/repos/Brar/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Brar/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Brar/nunit/teams","hooks_url":"https://api.github.com/repos/Brar/nunit/hooks","issue_events_url":"https://api.github.com/repos/Brar/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/Brar/nunit/events","assignees_url":"https://api.github.com/repos/Brar/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/Brar/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/Brar/nunit/tags","blobs_url":"https://api.github.com/repos/Brar/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Brar/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Brar/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/Brar/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Brar/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/Brar/nunit/languages","stargazers_url":"https://api.github.com/repos/Brar/nunit/stargazers","contributors_url":"https://api.github.com/repos/Brar/nunit/contributors","subscribers_url":"https://api.github.com/repos/Brar/nunit/subscribers","subscription_url":"https://api.github.com/repos/Brar/nunit/subscription","commits_url":"https://api.github.com/repos/Brar/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/Brar/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/Brar/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/Brar/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/Brar/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/Brar/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Brar/nunit/merges","archive_url":"https://api.github.com/repos/Brar/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Brar/nunit/downloads","issues_url":"https://api.github.com/repos/Brar/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/Brar/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/Brar/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/Brar/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Brar/nunit/labels{/name}","releases_url":"https://api.github.com/repos/Brar/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/Brar/nunit/deployments","created_at":"2018-06-18T13:07:18Z","updated_at":"2018-06-18T13:10:51Z","pushed_at":"2018-06-18T13:13:51Z","git_url":"git://github.com/Brar/nunit.git","ssh_url":"git@github.com:Brar/nunit.git","clone_url":"https://github.com/Brar/nunit.git","svn_url":"https://github.com/Brar/nunit","homepage":"http://www.nunit.org/","size":34440,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nunit:master","ref":"master","sha":"5cfc6da2abb22f444913da0e6359ca8ec5e8aa24","user":{"login":"nunit","id":2678858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Nzg4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"repo":{"id":13692183,"node_id":"MDEwOlJlcG9zaXRvcnkxMzY5MjE4Mw==","name":"nunit","full_name":"nunit/nunit","owner":{"login":"nunit","id":2678858,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI2Nzg4NTg=","avatar_url":"https://avatars0.githubusercontent.com/u/2678858?v=4","gravatar_id":"","url":"https://api.github.com/users/nunit","html_url":"https://github.com/nunit","followers_url":"https://api.github.com/users/nunit/followers","following_url":"https://api.github.com/users/nunit/following{/other_user}","gists_url":"https://api.github.com/users/nunit/gists{/gist_id}","starred_url":"https://api.github.com/users/nunit/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nunit/subscriptions","organizations_url":"https://api.github.com/users/nunit/orgs","repos_url":"https://api.github.com/users/nunit/repos","events_url":"https://api.github.com/users/nunit/events{/privacy}","received_events_url":"https://api.github.com/users/nunit/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nunit/nunit","description":"NUnit 3.0 Framework","fork":false,"url":"https://api.github.com/repos/nunit/nunit","forks_url":"https://api.github.com/repos/nunit/nunit/forks","keys_url":"https://api.github.com/repos/nunit/nunit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nunit/nunit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nunit/nunit/teams","hooks_url":"https://api.github.com/repos/nunit/nunit/hooks","issue_events_url":"https://api.github.com/repos/nunit/nunit/issues/events{/number}","events_url":"https://api.github.com/repos/nunit/nunit/events","assignees_url":"https://api.github.com/repos/nunit/nunit/assignees{/user}","branches_url":"https://api.github.com/repos/nunit/nunit/branches{/branch}","tags_url":"https://api.github.com/repos/nunit/nunit/tags","blobs_url":"https://api.github.com/repos/nunit/nunit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nunit/nunit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nunit/nunit/git/refs{/sha}","trees_url":"https://api.github.com/repos/nunit/nunit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nunit/nunit/statuses/{sha}","languages_url":"https://api.github.com/repos/nunit/nunit/languages","stargazers_url":"https://api.github.com/repos/nunit/nunit/stargazers","contributors_url":"https://api.github.com/repos/nunit/nunit/contributors","subscribers_url":"https://api.github.com/repos/nunit/nunit/subscribers","subscription_url":"https://api.github.com/repos/nunit/nunit/subscription","commits_url":"https://api.github.com/repos/nunit/nunit/commits{/sha}","git_commits_url":"https://api.github.com/repos/nunit/nunit/git/commits{/sha}","comments_url":"https://api.github.com/repos/nunit/nunit/comments{/number}","issue_comment_url":"https://api.github.com/repos/nunit/nunit/issues/comments{/number}","contents_url":"https://api.github.com/repos/nunit/nunit/contents/{+path}","compare_url":"https://api.github.com/repos/nunit/nunit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nunit/nunit/merges","archive_url":"https://api.github.com/repos/nunit/nunit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nunit/nunit/downloads","issues_url":"https://api.github.com/repos/nunit/nunit/issues{/number}","pulls_url":"https://api.github.com/repos/nunit/nunit/pulls{/number}","milestones_url":"https://api.github.com/repos/nunit/nunit/milestones{/number}","notifications_url":"https://api.github.com/repos/nunit/nunit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nunit/nunit/labels{/name}","releases_url":"https://api.github.com/repos/nunit/nunit/releases{/id}","deployments_url":"https://api.github.com/repos/nunit/nunit/deployments","created_at":"2013-10-18T23:43:29Z","updated_at":"2018-06-18T12:36:39Z","pushed_at":"2018-06-19T02:29:37Z","git_url":"git://github.com/nunit/nunit.git","ssh_url":"git@github.com:nunit/nunit.git","clone_url":"https://github.com/nunit/nunit.git","svn_url":"https://github.com/nunit/nunit","homepage":"http://www.nunit.org/","size":34443,"stargazers_count":1331,"watchers_count":1331,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":483,"mirror_url":null,"archived":false,"open_issues_count":295,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":483,"open_issues":295,"watchers":1331,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2895"},"html":{"href":"https://github.com/nunit/nunit/pull/2895"},"issue":{"href":"https://api.github.com/repos/nunit/nunit/issues/2895"},"comments":{"href":"https://api.github.com/repos/nunit/nunit/issues/2895/comments"},"review_comments":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2895/comments"},"review_comment":{"href":"https://api.github.com/repos/nunit/nunit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nunit/nunit/pulls/2895/commits"},"statuses":{"href":"https://api.github.com/repos/nunit/nunit/statuses/083fe3f5e283395bfa5a005db28aa72c8b5743f1"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":2,"additions":29,"deletions":7,"changed_files":8}}
{"actor":{"display_login":"Brar"}}