{"action":"opened","number":2565,"pull_request":{"url":"https://api.github.com/repos/pravega/pravega/pulls/2565","id":186897964,"html_url":"https://github.com/pravega/pravega/pull/2565","diff_url":"https://github.com/pravega/pravega/pull/2565.diff","patch_url":"https://github.com/pravega/pravega/pull/2565.patch","issue_url":"https://api.github.com/repos/pravega/pravega/issues/2565","number":2565,"state":"open","locked":false,"title":"Issue 2547: ClientFactory.close() should close the internal Controller client. (In Progress)","user":{"login":"shrids","id":11114165,"avatar_url":"https://avatars1.githubusercontent.com/u/11114165?v=4","gravatar_id":"","url":"https://api.github.com/users/shrids","html_url":"https://github.com/shrids","followers_url":"https://api.github.com/users/shrids/followers","following_url":"https://api.github.com/users/shrids/following{/other_user}","gists_url":"https://api.github.com/users/shrids/gists{/gist_id}","starred_url":"https://api.github.com/users/shrids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrids/subscriptions","organizations_url":"https://api.github.com/users/shrids/orgs","repos_url":"https://api.github.com/users/shrids/repos","events_url":"https://api.github.com/users/shrids/events{/privacy}","received_events_url":"https://api.github.com/users/shrids/received_events","type":"User","site_admin":false},"body":"=== Testing is in progress ===\r\n**Change log description**\r\nEnsure the controller client created by ClientFactory is closed.\r\n\r\n**Purpose of the change**\r\nFixes #2547 \r\n\r\n**What the code does**\r\nEnsures that the resources created and owned by ClientFactory are closed.\r\n\r\n**How to verify it**\r\nAll the exiting tests should pass.","created_at":"2018-05-09T11:49:58Z","updated_at":"2018-05-09T11:49:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pravega/pravega/pulls/2565/commits","review_comments_url":"https://api.github.com/repos/pravega/pravega/pulls/2565/comments","review_comment_url":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pravega/pravega/issues/2565/comments","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/fa5c116761ade859d8b432164f2daf2459796f82","head":{"label":"shrids:issue-2547-clientcloseresources","ref":"issue-2547-clientcloseresources","sha":"fa5c116761ade859d8b432164f2daf2459796f82","user":{"login":"shrids","id":11114165,"avatar_url":"https://avatars1.githubusercontent.com/u/11114165?v=4","gravatar_id":"","url":"https://api.github.com/users/shrids","html_url":"https://github.com/shrids","followers_url":"https://api.github.com/users/shrids/followers","following_url":"https://api.github.com/users/shrids/following{/other_user}","gists_url":"https://api.github.com/users/shrids/gists{/gist_id}","starred_url":"https://api.github.com/users/shrids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrids/subscriptions","organizations_url":"https://api.github.com/users/shrids/orgs","repos_url":"https://api.github.com/users/shrids/repos","events_url":"https://api.github.com/users/shrids/events{/privacy}","received_events_url":"https://api.github.com/users/shrids/received_events","type":"User","site_admin":false},"repo":{"id":90976985,"name":"pravega","full_name":"shrids/pravega","owner":{"login":"shrids","id":11114165,"avatar_url":"https://avatars1.githubusercontent.com/u/11114165?v=4","gravatar_id":"","url":"https://api.github.com/users/shrids","html_url":"https://github.com/shrids","followers_url":"https://api.github.com/users/shrids/followers","following_url":"https://api.github.com/users/shrids/following{/other_user}","gists_url":"https://api.github.com/users/shrids/gists{/gist_id}","starred_url":"https://api.github.com/users/shrids/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shrids/subscriptions","organizations_url":"https://api.github.com/users/shrids/orgs","repos_url":"https://api.github.com/users/shrids/repos","events_url":"https://api.github.com/users/shrids/events{/privacy}","received_events_url":"https://api.github.com/users/shrids/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/shrids/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":true,"url":"https://api.github.com/repos/shrids/pravega","forks_url":"https://api.github.com/repos/shrids/pravega/forks","keys_url":"https://api.github.com/repos/shrids/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/shrids/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/shrids/pravega/teams","hooks_url":"https://api.github.com/repos/shrids/pravega/hooks","issue_events_url":"https://api.github.com/repos/shrids/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/shrids/pravega/events","assignees_url":"https://api.github.com/repos/shrids/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/shrids/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/shrids/pravega/tags","blobs_url":"https://api.github.com/repos/shrids/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/shrids/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/shrids/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/shrids/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/shrids/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/shrids/pravega/languages","stargazers_url":"https://api.github.com/repos/shrids/pravega/stargazers","contributors_url":"https://api.github.com/repos/shrids/pravega/contributors","subscribers_url":"https://api.github.com/repos/shrids/pravega/subscribers","subscription_url":"https://api.github.com/repos/shrids/pravega/subscription","commits_url":"https://api.github.com/repos/shrids/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/shrids/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/shrids/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/shrids/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/shrids/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/shrids/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/shrids/pravega/merges","archive_url":"https://api.github.com/repos/shrids/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/shrids/pravega/downloads","issues_url":"https://api.github.com/repos/shrids/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/shrids/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/shrids/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/shrids/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/shrids/pravega/labels{/name}","releases_url":"https://api.github.com/repos/shrids/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/shrids/pravega/deployments","created_at":"2017-05-11T12:31:46Z","updated_at":"2018-05-09T08:00:15Z","pushed_at":"2018-05-09T11:45:36Z","git_url":"git://github.com/shrids/pravega.git","ssh_url":"git@github.com:shrids/pravega.git","clone_url":"https://github.com/shrids/pravega.git","svn_url":"https://github.com/shrids/pravega","homepage":"http://pravega.io","size":24314,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":5,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":5,"watchers":0,"default_branch":"master"}},"base":{"label":"pravega:master","ref":"master","sha":"771705433411181b302c78f616cbc6d6eb56a1a5","user":{"login":"pravega","id":25698199,"avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"repo":{"id":63096822,"name":"pravega","full_name":"pravega/pravega","owner":{"login":"pravega","id":25698199,"avatar_url":"https://avatars1.githubusercontent.com/u/25698199?v=4","gravatar_id":"","url":"https://api.github.com/users/pravega","html_url":"https://github.com/pravega","followers_url":"https://api.github.com/users/pravega/followers","following_url":"https://api.github.com/users/pravega/following{/other_user}","gists_url":"https://api.github.com/users/pravega/gists{/gist_id}","starred_url":"https://api.github.com/users/pravega/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pravega/subscriptions","organizations_url":"https://api.github.com/users/pravega/orgs","repos_url":"https://api.github.com/users/pravega/repos","events_url":"https://api.github.com/users/pravega/events{/privacy}","received_events_url":"https://api.github.com/users/pravega/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pravega/pravega","description":"Pravega - Streaming as a new software defined storage primitive","fork":false,"url":"https://api.github.com/repos/pravega/pravega","forks_url":"https://api.github.com/repos/pravega/pravega/forks","keys_url":"https://api.github.com/repos/pravega/pravega/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pravega/pravega/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pravega/pravega/teams","hooks_url":"https://api.github.com/repos/pravega/pravega/hooks","issue_events_url":"https://api.github.com/repos/pravega/pravega/issues/events{/number}","events_url":"https://api.github.com/repos/pravega/pravega/events","assignees_url":"https://api.github.com/repos/pravega/pravega/assignees{/user}","branches_url":"https://api.github.com/repos/pravega/pravega/branches{/branch}","tags_url":"https://api.github.com/repos/pravega/pravega/tags","blobs_url":"https://api.github.com/repos/pravega/pravega/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pravega/pravega/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pravega/pravega/git/refs{/sha}","trees_url":"https://api.github.com/repos/pravega/pravega/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pravega/pravega/statuses/{sha}","languages_url":"https://api.github.com/repos/pravega/pravega/languages","stargazers_url":"https://api.github.com/repos/pravega/pravega/stargazers","contributors_url":"https://api.github.com/repos/pravega/pravega/contributors","subscribers_url":"https://api.github.com/repos/pravega/pravega/subscribers","subscription_url":"https://api.github.com/repos/pravega/pravega/subscription","commits_url":"https://api.github.com/repos/pravega/pravega/commits{/sha}","git_commits_url":"https://api.github.com/repos/pravega/pravega/git/commits{/sha}","comments_url":"https://api.github.com/repos/pravega/pravega/comments{/number}","issue_comment_url":"https://api.github.com/repos/pravega/pravega/issues/comments{/number}","contents_url":"https://api.github.com/repos/pravega/pravega/contents/{+path}","compare_url":"https://api.github.com/repos/pravega/pravega/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pravega/pravega/merges","archive_url":"https://api.github.com/repos/pravega/pravega/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pravega/pravega/downloads","issues_url":"https://api.github.com/repos/pravega/pravega/issues{/number}","pulls_url":"https://api.github.com/repos/pravega/pravega/pulls{/number}","milestones_url":"https://api.github.com/repos/pravega/pravega/milestones{/number}","notifications_url":"https://api.github.com/repos/pravega/pravega/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pravega/pravega/labels{/name}","releases_url":"https://api.github.com/repos/pravega/pravega/releases{/id}","deployments_url":"https://api.github.com/repos/pravega/pravega/deployments","created_at":"2016-07-11T19:41:03Z","updated_at":"2018-05-09T11:05:44Z","pushed_at":"2018-05-09T09:42:52Z","git_url":"git://github.com/pravega/pravega.git","ssh_url":"git@github.com:pravega/pravega.git","clone_url":"https://github.com/pravega/pravega.git","svn_url":"https://github.com/pravega/pravega","homepage":"http://pravega.io","size":24840,"stargazers_count":208,"watchers_count":208,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":68,"mirror_url":null,"archived":false,"open_issues_count":383,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":68,"open_issues":383,"watchers":208,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2565"},"html":{"href":"https://github.com/pravega/pravega/pull/2565"},"issue":{"href":"https://api.github.com/repos/pravega/pravega/issues/2565"},"comments":{"href":"https://api.github.com/repos/pravega/pravega/issues/2565/comments"},"review_comments":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2565/comments"},"review_comment":{"href":"https://api.github.com/repos/pravega/pravega/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pravega/pravega/pulls/2565/commits"},"statuses":{"href":"https://api.github.com/repos/pravega/pravega/statuses/fa5c116761ade859d8b432164f2daf2459796f82"}},"author_association":"COLLABORATOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":19,"deletions":4,"changed_files":2}}
{"actor":{"display_login":"shrids"}}