{"action":"closed","number":495,"pull_request":{"url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/495","id":216357323,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE2MzU3MzIz","html_url":"https://github.com/SamZiemer/liferay-portal/pull/495","diff_url":"https://github.com/SamZiemer/liferay-portal/pull/495.diff","patch_url":"https://github.com/SamZiemer/liferay-portal/pull/495.patch","issue_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/495","number":495,"state":"closed","locked":false,"title":"LPS-85410 Update workflowContext to save the approver's id","user":{"login":"joshuacords","id":20051725,"node_id":"MDQ6VXNlcjIwMDUxNzI1","avatar_url":"https://avatars3.githubusercontent.com/u/20051725?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuacords","html_url":"https://github.com/joshuacords","followers_url":"https://api.github.com/users/joshuacords/followers","following_url":"https://api.github.com/users/joshuacords/following{/other_user}","gists_url":"https://api.github.com/users/joshuacords/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuacords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuacords/subscriptions","organizations_url":"https://api.github.com/users/joshuacords/orgs","repos_url":"https://api.github.com/users/joshuacords/repos","events_url":"https://api.github.com/users/joshuacords/events{/privacy}","received_events_url":"https://api.github.com/users/joshuacords/received_events","type":"User","site_admin":false},"body":"https://issues.liferay.com/browse/LPS-85410\r\n\r\nProblem: The workflowContext is never updated with the approver's userId when the completeWorkflowTask() is called.\r\n\r\nSolution: Pass in a workflowContext with the userId of the approver updated using same logic as [WorkflowHelper](https://github.com/joshuacords/liferay-portal/blob/83c8717c1c98b126a2717e88068cff732170e54d/modules/apps/portal-workflow/portal-workflow-rest/src/main/java/com/liferay/portal/workflow/rest/internal/helper/WorkflowHelper.java#L431-L439).\r\nConsidering there is no dependency from portal-workflow-task-web on portal-workflow-rest and the WorkflowHelper getWorkflowContext() method is protected, I believe it's better to mimic the logic rather than call the method.\r\nI could also see the change being made at a lower level, such as in [DefaultTaskManagerImpl.doCompleteWorkflowTask()](https://github.com/joshuacords/liferay-portal/blob/ecd1a18ec043d0c50329d410ee2f8a8e7ba31bf5/modules/apps/portal-workflow/portal-workflow-kaleo-runtime-impl/src/main/java/com/liferay/portal/workflow/kaleo/runtime/internal/DefaultTaskManagerImpl.java#L361-L362) but that logic is shared by other calls and the method signatures would need to add the userId, so I think this version of the fix is preferable.","created_at":"2018-09-18T15:47:44Z","updated_at":"2018-09-18T18:38:51Z","closed_at":"2018-09-18T18:38:51Z","merged_at":null,"merge_commit_sha":"fe8c95ef6be08ba130b8162fdc7e5706090d08d6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":930050421,"node_id":"MDU6TGFiZWw5MzAwNTA0MjE=","url":"https://api.github.com/repos/SamZiemer/liferay-portal/labels/ci:test:relevant%20-%20pending","name":"ci:test:relevant - pending","color":"fff4c9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/495/commits","review_comments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/495/comments","review_comment_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/495/comments","statuses_url":"https://api.github.com/repos/SamZiemer/liferay-portal/statuses/db831ab2906bfd7901b6eacb8021fa0b0636ec0f","head":{"label":"joshuacords:JCords-LPS-85410","ref":"JCords-LPS-85410","sha":"db831ab2906bfd7901b6eacb8021fa0b0636ec0f","user":{"login":"joshuacords","id":20051725,"node_id":"MDQ6VXNlcjIwMDUxNzI1","avatar_url":"https://avatars3.githubusercontent.com/u/20051725?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuacords","html_url":"https://github.com/joshuacords","followers_url":"https://api.github.com/users/joshuacords/followers","following_url":"https://api.github.com/users/joshuacords/following{/other_user}","gists_url":"https://api.github.com/users/joshuacords/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuacords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuacords/subscriptions","organizations_url":"https://api.github.com/users/joshuacords/orgs","repos_url":"https://api.github.com/users/joshuacords/repos","events_url":"https://api.github.com/users/joshuacords/events{/privacy}","received_events_url":"https://api.github.com/users/joshuacords/received_events","type":"User","site_admin":false},"repo":{"id":70831592,"node_id":"MDEwOlJlcG9zaXRvcnk3MDgzMTU5Mg==","name":"liferay-portal","full_name":"joshuacords/liferay-portal","private":false,"owner":{"login":"joshuacords","id":20051725,"node_id":"MDQ6VXNlcjIwMDUxNzI1","avatar_url":"https://avatars3.githubusercontent.com/u/20051725?v=4","gravatar_id":"","url":"https://api.github.com/users/joshuacords","html_url":"https://github.com/joshuacords","followers_url":"https://api.github.com/users/joshuacords/followers","following_url":"https://api.github.com/users/joshuacords/following{/other_user}","gists_url":"https://api.github.com/users/joshuacords/gists{/gist_id}","starred_url":"https://api.github.com/users/joshuacords/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/joshuacords/subscriptions","organizations_url":"https://api.github.com/users/joshuacords/orgs","repos_url":"https://api.github.com/users/joshuacords/repos","events_url":"https://api.github.com/users/joshuacords/events{/privacy}","received_events_url":"https://api.github.com/users/joshuacords/received_events","type":"User","site_admin":false},"html_url":"https://github.com/joshuacords/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/joshuacords/liferay-portal","forks_url":"https://api.github.com/repos/joshuacords/liferay-portal/forks","keys_url":"https://api.github.com/repos/joshuacords/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/joshuacords/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/joshuacords/liferay-portal/teams","hooks_url":"https://api.github.com/repos/joshuacords/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/joshuacords/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/joshuacords/liferay-portal/events","assignees_url":"https://api.github.com/repos/joshuacords/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/joshuacords/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/joshuacords/liferay-portal/tags","blobs_url":"https://api.github.com/repos/joshuacords/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/joshuacords/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/joshuacords/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/joshuacords/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/joshuacords/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/joshuacords/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/joshuacords/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/joshuacords/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/joshuacords/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/joshuacords/liferay-portal/subscription","commits_url":"https://api.github.com/repos/joshuacords/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/joshuacords/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/joshuacords/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/joshuacords/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/joshuacords/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/joshuacords/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/joshuacords/liferay-portal/merges","archive_url":"https://api.github.com/repos/joshuacords/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/joshuacords/liferay-portal/downloads","issues_url":"https://api.github.com/repos/joshuacords/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/joshuacords/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/joshuacords/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/joshuacords/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/joshuacords/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/joshuacords/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/joshuacords/liferay-portal/deployments","created_at":"2016-10-13T17:34:12Z","updated_at":"2018-09-18T18:26:54Z","pushed_at":"2018-09-18T18:26:58Z","git_url":"git://github.com/joshuacords/liferay-portal.git","ssh_url":"git@github.com:joshuacords/liferay-portal.git","clone_url":"https://github.com/joshuacords/liferay-portal.git","svn_url":"https://github.com/joshuacords/liferay-portal","homepage":"http://liferay.com","size":12782300,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"SamZiemer:master","ref":"master","sha":"4436d9d667ae4cfed9a70e09a625881322334eb7","user":{"login":"SamZiemer","id":8029905,"node_id":"MDQ6VXNlcjgwMjk5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8029905?v=4","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"repo":{"id":21368461,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM2ODQ2MQ==","name":"liferay-portal","full_name":"SamZiemer/liferay-portal","private":false,"owner":{"login":"SamZiemer","id":8029905,"node_id":"MDQ6VXNlcjgwMjk5MDU=","avatar_url":"https://avatars0.githubusercontent.com/u/8029905?v=4","gravatar_id":"","url":"https://api.github.com/users/SamZiemer","html_url":"https://github.com/SamZiemer","followers_url":"https://api.github.com/users/SamZiemer/followers","following_url":"https://api.github.com/users/SamZiemer/following{/other_user}","gists_url":"https://api.github.com/users/SamZiemer/gists{/gist_id}","starred_url":"https://api.github.com/users/SamZiemer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SamZiemer/subscriptions","organizations_url":"https://api.github.com/users/SamZiemer/orgs","repos_url":"https://api.github.com/users/SamZiemer/repos","events_url":"https://api.github.com/users/SamZiemer/events{/privacy}","received_events_url":"https://api.github.com/users/SamZiemer/received_events","type":"User","site_admin":false},"html_url":"https://github.com/SamZiemer/liferay-portal","description":null,"fork":true,"url":"https://api.github.com/repos/SamZiemer/liferay-portal","forks_url":"https://api.github.com/repos/SamZiemer/liferay-portal/forks","keys_url":"https://api.github.com/repos/SamZiemer/liferay-portal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SamZiemer/liferay-portal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SamZiemer/liferay-portal/teams","hooks_url":"https://api.github.com/repos/SamZiemer/liferay-portal/hooks","issue_events_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/events{/number}","events_url":"https://api.github.com/repos/SamZiemer/liferay-portal/events","assignees_url":"https://api.github.com/repos/SamZiemer/liferay-portal/assignees{/user}","branches_url":"https://api.github.com/repos/SamZiemer/liferay-portal/branches{/branch}","tags_url":"https://api.github.com/repos/SamZiemer/liferay-portal/tags","blobs_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/refs{/sha}","trees_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SamZiemer/liferay-portal/statuses/{sha}","languages_url":"https://api.github.com/repos/SamZiemer/liferay-portal/languages","stargazers_url":"https://api.github.com/repos/SamZiemer/liferay-portal/stargazers","contributors_url":"https://api.github.com/repos/SamZiemer/liferay-portal/contributors","subscribers_url":"https://api.github.com/repos/SamZiemer/liferay-portal/subscribers","subscription_url":"https://api.github.com/repos/SamZiemer/liferay-portal/subscription","commits_url":"https://api.github.com/repos/SamZiemer/liferay-portal/commits{/sha}","git_commits_url":"https://api.github.com/repos/SamZiemer/liferay-portal/git/commits{/sha}","comments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/comments{/number}","issue_comment_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/comments{/number}","contents_url":"https://api.github.com/repos/SamZiemer/liferay-portal/contents/{+path}","compare_url":"https://api.github.com/repos/SamZiemer/liferay-portal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SamZiemer/liferay-portal/merges","archive_url":"https://api.github.com/repos/SamZiemer/liferay-portal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SamZiemer/liferay-portal/downloads","issues_url":"https://api.github.com/repos/SamZiemer/liferay-portal/issues{/number}","pulls_url":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls{/number}","milestones_url":"https://api.github.com/repos/SamZiemer/liferay-portal/milestones{/number}","notifications_url":"https://api.github.com/repos/SamZiemer/liferay-portal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SamZiemer/liferay-portal/labels{/name}","releases_url":"https://api.github.com/repos/SamZiemer/liferay-portal/releases{/id}","deployments_url":"https://api.github.com/repos/SamZiemer/liferay-portal/deployments","created_at":"2014-06-30T22:51:45Z","updated_at":"2018-09-18T18:33:10Z","pushed_at":"2018-09-18T18:33:13Z","git_url":"git://github.com/SamZiemer/liferay-portal.git","ssh_url":"git@github.com:SamZiemer/liferay-portal.git","clone_url":"https://github.com/SamZiemer/liferay-portal.git","svn_url":"https://github.com/SamZiemer/liferay-portal","homepage":"http://liferay.com","size":12709410,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/495"},"html":{"href":"https://github.com/SamZiemer/liferay-portal/pull/495"},"issue":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/495"},"comments":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/issues/495/comments"},"review_comments":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/495/comments"},"review_comment":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/pulls/495/commits"},"statuses":{"href":"https://api.github.com/repos/SamZiemer/liferay-portal/statuses/db831ab2906bfd7901b6eacb8021fa0b0636ec0f"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":3,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":33,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"liferay-continuous-integration"}}