{"action":"created","comment":{"url":"https://api.github.com/repos/ceph/ceph/pulls/comments/211814213","pull_request_review_id":148315683,"id":211814213,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTgxNDIxMw==","diff_hunk":"@@ -595,6 +595,29 @@ TEST_F(OSDMapTest, CleanPGUpmaps) {\n     ASSERT_TRUE(parent_0 != parent_1);\n   }\n \n+  {\n+    // generate an oversized pg_upmap item and apply\n+    vector<int32_t> new_pg_upmap;","path":"src/test/osd/TestOSDMap.cc","position":6,"original_position":6,"commit_id":"0189f08b0a290c97564a5fe5e31465a0dad889b9","original_commit_id":"0189f08b0a290c97564a5fe5e31465a0dad889b9","user":{"login":"tchaikov","id":59071,"node_id":"MDQ6VXNlcjU5MDcx","avatar_url":"https://avatars2.githubusercontent.com/u/59071?v=4","gravatar_id":"","url":"https://api.github.com/users/tchaikov","html_url":"https://github.com/tchaikov","followers_url":"https://api.github.com/users/tchaikov/followers","following_url":"https://api.github.com/users/tchaikov/following{/other_user}","gists_url":"https://api.github.com/users/tchaikov/gists{/gist_id}","starred_url":"https://api.github.com/users/tchaikov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tchaikov/subscriptions","organizations_url":"https://api.github.com/users/tchaikov/orgs","repos_url":"https://api.github.com/users/tchaikov/repos","events_url":"https://api.github.com/users/tchaikov/events{/privacy}","received_events_url":"https://api.github.com/users/tchaikov/received_events","type":"User","site_admin":false},"body":"nit, \r\n```c++\r\nvector<int32_t> new_pg_upmap = {0, 2, 4};\r\n```\r\nwould do the trick.","created_at":"2018-08-22T02:33:53Z","updated_at":"2018-08-22T02:47:10Z","html_url":"https://github.com/ceph/ceph/pull/23661#discussion_r211814213","pull_request_url":"https://api.github.com/repos/ceph/ceph/pulls/23661","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments/211814213"},"html":{"href":"https://github.com/ceph/ceph/pull/23661#discussion_r211814213"},"pull_request":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23661"}}},"pull_request":{"url":"https://api.github.com/repos/ceph/ceph/pulls/23661","id":209689122,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5Njg5MTIy","html_url":"https://github.com/ceph/ceph/pull/23661","diff_url":"https://github.com/ceph/ceph/pull/23661.diff","patch_url":"https://github.com/ceph/ceph/pull/23661.patch","issue_url":"https://api.github.com/repos/ceph/ceph/issues/23661","number":23661,"state":"open","locked":false,"title":"osd/OSDMap: automatically cancel oversized pg_upmap items","user":{"login":"xiexingguo","id":14193361,"node_id":"MDQ6VXNlcjE0MTkzMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/14193361?v=4","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"body":"We have a test cluster with the upmap features enabled,\r\nand a PG was stuck at **active** state after we decreased the\r\ncorresponding pool size from 3 to 2.\r\n\r\n```\r\n data:\r\n    pools:   4 pools, 17800 pgs\r\n    objects: 1637k objects, 5328 GB\r\n    usage:   8404 GB used, 123 TB / 131 TB avail\r\n    pgs:     17799 active+clean\r\n             1     active\r\n```\r\n\r\nThe root cause is that we injected some pg_upmap items a couple\r\nof weeks ago which are now start to produce oversized up mappings\r\n, and hence comes this fix.\r\n\r\nSigned-off-by: xie xingguo <xie.xingguo@zte.com.cn>\r\n\r\n\r\n","created_at":"2018-08-21T02:06:06Z","updated_at":"2018-08-22T02:47:10Z","closed_at":null,"merged_at":null,"merge_commit_sha":"78c603bd6f82fbbfdb710c059f981653d822fd78","assignee":null,"assignees":[],"requested_reviewers":[{"login":"liewegas","id":433031,"node_id":"MDQ6VXNlcjQzMzAzMQ==","avatar_url":"https://avatars1.githubusercontent.com/u/433031?v=4","gravatar_id":"","url":"https://api.github.com/users/liewegas","html_url":"https://github.com/liewegas","followers_url":"https://api.github.com/users/liewegas/followers","following_url":"https://api.github.com/users/liewegas/following{/other_user}","gists_url":"https://api.github.com/users/liewegas/gists{/gist_id}","starred_url":"https://api.github.com/users/liewegas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liewegas/subscriptions","organizations_url":"https://api.github.com/users/liewegas/orgs","repos_url":"https://api.github.com/users/liewegas/repos","events_url":"https://api.github.com/users/liewegas/events{/privacy}","received_events_url":"https://api.github.com/users/liewegas/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":134774049,"node_id":"MDU6TGFiZWwxMzQ3NzQwNDk=","url":"https://api.github.com/repos/ceph/ceph/labels/bug%20fix","name":"bug fix","color":"ac0000","default":false},{"id":144329561,"node_id":"MDU6TGFiZWwxNDQzMjk1NjE=","url":"https://api.github.com/repos/ceph/ceph/labels/core","name":"core","color":"0041a2","default":false},{"id":148431321,"node_id":"MDU6TGFiZWwxNDg0MzEzMjE=","url":"https://api.github.com/repos/ceph/ceph/labels/needs-qa","name":"needs-qa","color":"fad8c7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ceph/ceph/pulls/23661/commits","review_comments_url":"https://api.github.com/repos/ceph/ceph/pulls/23661/comments","review_comment_url":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ceph/ceph/issues/23661/comments","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/0189f08b0a290c97564a5fe5e31465a0dad889b9","head":{"label":"xiexingguo:wip-cancel-oversize-upmap","ref":"wip-cancel-oversize-upmap","sha":"0189f08b0a290c97564a5fe5e31465a0dad889b9","user":{"login":"xiexingguo","id":14193361,"node_id":"MDQ6VXNlcjE0MTkzMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/14193361?v=4","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"repo":{"id":45168396,"node_id":"MDEwOlJlcG9zaXRvcnk0NTE2ODM5Ng==","name":"ceph","full_name":"xiexingguo/ceph","owner":{"login":"xiexingguo","id":14193361,"node_id":"MDQ6VXNlcjE0MTkzMzYx","avatar_url":"https://avatars3.githubusercontent.com/u/14193361?v=4","gravatar_id":"","url":"https://api.github.com/users/xiexingguo","html_url":"https://github.com/xiexingguo","followers_url":"https://api.github.com/users/xiexingguo/followers","following_url":"https://api.github.com/users/xiexingguo/following{/other_user}","gists_url":"https://api.github.com/users/xiexingguo/gists{/gist_id}","starred_url":"https://api.github.com/users/xiexingguo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiexingguo/subscriptions","organizations_url":"https://api.github.com/users/xiexingguo/orgs","repos_url":"https://api.github.com/users/xiexingguo/repos","events_url":"https://api.github.com/users/xiexingguo/events{/privacy}","received_events_url":"https://api.github.com/users/xiexingguo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/xiexingguo/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":true,"url":"https://api.github.com/repos/xiexingguo/ceph","forks_url":"https://api.github.com/repos/xiexingguo/ceph/forks","keys_url":"https://api.github.com/repos/xiexingguo/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xiexingguo/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xiexingguo/ceph/teams","hooks_url":"https://api.github.com/repos/xiexingguo/ceph/hooks","issue_events_url":"https://api.github.com/repos/xiexingguo/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/xiexingguo/ceph/events","assignees_url":"https://api.github.com/repos/xiexingguo/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/xiexingguo/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/xiexingguo/ceph/tags","blobs_url":"https://api.github.com/repos/xiexingguo/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xiexingguo/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xiexingguo/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/xiexingguo/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xiexingguo/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/xiexingguo/ceph/languages","stargazers_url":"https://api.github.com/repos/xiexingguo/ceph/stargazers","contributors_url":"https://api.github.com/repos/xiexingguo/ceph/contributors","subscribers_url":"https://api.github.com/repos/xiexingguo/ceph/subscribers","subscription_url":"https://api.github.com/repos/xiexingguo/ceph/subscription","commits_url":"https://api.github.com/repos/xiexingguo/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/xiexingguo/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/xiexingguo/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/xiexingguo/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/xiexingguo/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/xiexingguo/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xiexingguo/ceph/merges","archive_url":"https://api.github.com/repos/xiexingguo/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xiexingguo/ceph/downloads","issues_url":"https://api.github.com/repos/xiexingguo/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/xiexingguo/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/xiexingguo/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/xiexingguo/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xiexingguo/ceph/labels{/name}","releases_url":"https://api.github.com/repos/xiexingguo/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/xiexingguo/ceph/deployments","created_at":"2015-10-29T07:51:41Z","updated_at":"2018-08-21T02:22:52Z","pushed_at":"2018-08-22T00:23:49Z","git_url":"git://github.com/xiexingguo/ceph.git","ssh_url":"git@github.com:xiexingguo/ceph.git","clone_url":"https://github.com/xiexingguo/ceph.git","svn_url":"https://github.com/xiexingguo/ceph","homepage":"http://ceph.com","size":286776,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ceph:master","ref":"master","sha":"04b7d3db49d4bb6ce81ce373daebc4ebf05ba990","user":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"repo":{"id":2310495,"node_id":"MDEwOlJlcG9zaXRvcnkyMzEwNDk1","name":"ceph","full_name":"ceph/ceph","owner":{"login":"ceph","id":1015767,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMTU3Njc=","avatar_url":"https://avatars3.githubusercontent.com/u/1015767?v=4","gravatar_id":"","url":"https://api.github.com/users/ceph","html_url":"https://github.com/ceph","followers_url":"https://api.github.com/users/ceph/followers","following_url":"https://api.github.com/users/ceph/following{/other_user}","gists_url":"https://api.github.com/users/ceph/gists{/gist_id}","starred_url":"https://api.github.com/users/ceph/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ceph/subscriptions","organizations_url":"https://api.github.com/users/ceph/orgs","repos_url":"https://api.github.com/users/ceph/repos","events_url":"https://api.github.com/users/ceph/events{/privacy}","received_events_url":"https://api.github.com/users/ceph/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ceph/ceph","description":"Ceph is a distributed object, block, and file storage platform ","fork":false,"url":"https://api.github.com/repos/ceph/ceph","forks_url":"https://api.github.com/repos/ceph/ceph/forks","keys_url":"https://api.github.com/repos/ceph/ceph/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ceph/ceph/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ceph/ceph/teams","hooks_url":"https://api.github.com/repos/ceph/ceph/hooks","issue_events_url":"https://api.github.com/repos/ceph/ceph/issues/events{/number}","events_url":"https://api.github.com/repos/ceph/ceph/events","assignees_url":"https://api.github.com/repos/ceph/ceph/assignees{/user}","branches_url":"https://api.github.com/repos/ceph/ceph/branches{/branch}","tags_url":"https://api.github.com/repos/ceph/ceph/tags","blobs_url":"https://api.github.com/repos/ceph/ceph/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ceph/ceph/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ceph/ceph/git/refs{/sha}","trees_url":"https://api.github.com/repos/ceph/ceph/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ceph/ceph/statuses/{sha}","languages_url":"https://api.github.com/repos/ceph/ceph/languages","stargazers_url":"https://api.github.com/repos/ceph/ceph/stargazers","contributors_url":"https://api.github.com/repos/ceph/ceph/contributors","subscribers_url":"https://api.github.com/repos/ceph/ceph/subscribers","subscription_url":"https://api.github.com/repos/ceph/ceph/subscription","commits_url":"https://api.github.com/repos/ceph/ceph/commits{/sha}","git_commits_url":"https://api.github.com/repos/ceph/ceph/git/commits{/sha}","comments_url":"https://api.github.com/repos/ceph/ceph/comments{/number}","issue_comment_url":"https://api.github.com/repos/ceph/ceph/issues/comments{/number}","contents_url":"https://api.github.com/repos/ceph/ceph/contents/{+path}","compare_url":"https://api.github.com/repos/ceph/ceph/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ceph/ceph/merges","archive_url":"https://api.github.com/repos/ceph/ceph/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ceph/ceph/downloads","issues_url":"https://api.github.com/repos/ceph/ceph/issues{/number}","pulls_url":"https://api.github.com/repos/ceph/ceph/pulls{/number}","milestones_url":"https://api.github.com/repos/ceph/ceph/milestones{/number}","notifications_url":"https://api.github.com/repos/ceph/ceph/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ceph/ceph/labels{/name}","releases_url":"https://api.github.com/repos/ceph/ceph/releases{/id}","deployments_url":"https://api.github.com/repos/ceph/ceph/deployments","created_at":"2011-09-01T21:41:26Z","updated_at":"2018-08-21T21:42:05Z","pushed_at":"2018-08-22T02:32:05Z","git_url":"git://github.com/ceph/ceph.git","ssh_url":"git@github.com:ceph/ceph.git","clone_url":"https://github.com/ceph/ceph.git","svn_url":"https://github.com/ceph/ceph","homepage":"http://ceph.com","size":305634,"stargazers_count":4958,"watchers_count":4958,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2592,"mirror_url":null,"archived":false,"open_issues_count":732,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2592,"open_issues":732,"watchers":4958,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23661"},"html":{"href":"https://github.com/ceph/ceph/pull/23661"},"issue":{"href":"https://api.github.com/repos/ceph/ceph/issues/23661"},"comments":{"href":"https://api.github.com/repos/ceph/ceph/issues/23661/comments"},"review_comments":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23661/comments"},"review_comment":{"href":"https://api.github.com/repos/ceph/ceph/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ceph/ceph/pulls/23661/commits"},"statuses":{"href":"https://api.github.com/repos/ceph/ceph/statuses/0189f08b0a290c97564a5fe5e31465a0dad889b9"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"tchaikov"}}