{"action":"created","issue":{"url":"https://api.github.com/repos/CoreSecurity/pcapy/issues/47","repository_url":"https://api.github.com/repos/CoreSecurity/pcapy","labels_url":"https://api.github.com/repos/CoreSecurity/pcapy/issues/47/labels{/name}","comments_url":"https://api.github.com/repos/CoreSecurity/pcapy/issues/47/comments","events_url":"https://api.github.com/repos/CoreSecurity/pcapy/issues/47/events","html_url":"https://github.com/CoreSecurity/pcapy/pull/47","id":320426286,"number":47,"title":"Support monitor mode & other features","user":{"login":"gpotter2","id":10530980,"avatar_url":"https://avatars0.githubusercontent.com/u/10530980?v=4","gravatar_id":"","url":"https://api.github.com/users/gpotter2","html_url":"https://github.com/gpotter2","followers_url":"https://api.github.com/users/gpotter2/followers","following_url":"https://api.github.com/users/gpotter2/following{/other_user}","gists_url":"https://api.github.com/users/gpotter2/gists{/gist_id}","starred_url":"https://api.github.com/users/gpotter2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gpotter2/subscriptions","organizations_url":"https://api.github.com/users/gpotter2/orgs","repos_url":"https://api.github.com/users/gpotter2/repos","events_url":"https://api.github.com/users/gpotter2/events{/privacy}","received_events_url":"https://api.github.com/users/gpotter2/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-05-04T20:54:19Z","updated_at":"2018-05-28T00:30:26Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/CoreSecurity/pcapy/pulls/47","html_url":"https://github.com/CoreSecurity/pcapy/pull/47","diff_url":"https://github.com/CoreSecurity/pcapy/pull/47.diff","patch_url":"https://github.com/CoreSecurity/pcapy/pull/47.patch"},"body":"Hi ! This PR fixes https://github.com/CoreSecurity/pcapy/issues/45 and fixes https://github.com/CoreSecurity/pcapy/issues/17\r\n\r\nCalling @martinuy for review. I have a working scapy branch (https://github.com/secdev/scapy/commit/490298cd284b704f67518ed13f5c6767d631ab82) based on this, waiting for it to be merged :)\r\n\r\nAlso fixes a few additional warnings, about string conversion. Optional but fancy"},"comment":{"url":"https://api.github.com/repos/CoreSecurity/pcapy/issues/comments/392391531","html_url":"https://github.com/CoreSecurity/pcapy/pull/47#issuecomment-392391531","issue_url":"https://api.github.com/repos/CoreSecurity/pcapy/issues/47","id":392391531,"user":{"login":"martinuy","id":22035856,"avatar_url":"https://avatars3.githubusercontent.com/u/22035856?v=4","gravatar_id":"","url":"https://api.github.com/users/martinuy","html_url":"https://github.com/martinuy","followers_url":"https://api.github.com/users/martinuy/followers","following_url":"https://api.github.com/users/martinuy/following{/other_user}","gists_url":"https://api.github.com/users/martinuy/gists{/gist_id}","starred_url":"https://api.github.com/users/martinuy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinuy/subscriptions","organizations_url":"https://api.github.com/users/martinuy/orgs","repos_url":"https://api.github.com/users/martinuy/repos","events_url":"https://api.github.com/users/martinuy/events{/privacy}","received_events_url":"https://api.github.com/users/martinuy/received_events","type":"User","site_admin":false},"created_at":"2018-05-28T00:30:26Z","updated_at":"2018-05-28T00:30:26Z","author_association":"CONTRIBUTOR","body":"Hi @gpotter2, thank you very much for your contribution!\r\n\r\nJust a few comments:\r\n\r\nI've seen that this code is already present in other functions that return a capture handle:\r\n\r\n```\r\n#ifdef WIN32\r\n  pcap_setmintocopy(pt, 0);\r\n#endif\r\n```\r\n\r\nShouldn't we include it in pcap_create too? I'm not sure, and it's unfortunate that no-comment was added explaining this. Have you tested this on Windows?\r\n\r\nReturning ints on set-like functions looks fine to me. Previous idiom (returning None) was hiding information. Ideally, we should also export constants as part of pcapy's API. I.e.: PCAP_ERROR_ACTIVATED.\r\n\r\nNames you chose for set-like functions looks fine to me. Previous idiom (having setfunctionname all together) is more confusing.\r\n\r\nYour changes on commit 84807210bfd79f5c89ab2a1d4291cb408a15ba30 look fine to me. I suggest merging them after deciding if pcap_setmintocopy is necessary."}}
{"actor":{"display_login":"martinuy"}}