{"action":"created","comment":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/244058672","pull_request_review_id":187972253,"id":244058672,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDA1ODY3Mg==","diff_hunk":"@@ -212,6 +212,12 @@ export class AmpStoryPage extends AMP.BaseElement {\n         .addAdvanceListener(() => this.next(/* opt_isAutomaticAdvance */ true));\n     this.advancement_\n         .addProgressListener(progress => this.emitProgress_(progress));\n+    this.registerAction('goToPage', invocation => {\n+      const {args} = invocation;\n+      if (args) {\n+        this.switchTo_(args['targetPageId']);","path":"extensions/amp-story/1.0/amp-story-page.js","position":7,"original_position":7,"commit_id":"2cc9c889f97a25760a4c9376cf97ac9a3defb206","original_commit_id":"2cc9c889f97a25760a4c9376cf97ac9a3defb206","user":{"login":"newmuis","id":1651960,"node_id":"MDQ6VXNlcjE2NTE5NjA=","avatar_url":"https://avatars3.githubusercontent.com/u/1651960?v=4","gravatar_id":"","url":"https://api.github.com/users/newmuis","html_url":"https://github.com/newmuis","followers_url":"https://api.github.com/users/newmuis/followers","following_url":"https://api.github.com/users/newmuis/following{/other_user}","gists_url":"https://api.github.com/users/newmuis/gists{/gist_id}","starred_url":"https://api.github.com/users/newmuis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/newmuis/subscriptions","organizations_url":"https://api.github.com/users/newmuis/orgs","repos_url":"https://api.github.com/users/newmuis/repos","events_url":"https://api.github.com/users/newmuis/events{/privacy}","received_events_url":"https://api.github.com/users/newmuis/received_events","type":"User","site_admin":false},"body":"nit: maybe just `id`?","created_at":"2018-12-26T22:57:02Z","updated_at":"2018-12-26T22:57:16Z","html_url":"https://github.com/ampproject/amphtml/pull/20084#discussion_r244058672","pull_request_url":"https://api.github.com/repos/ampproject/amphtml/pulls/20084","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments/244058672"},"html":{"href":"https://github.com/ampproject/amphtml/pull/20084#discussion_r244058672"},"pull_request":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20084"}}},"pull_request":{"url":"https://api.github.com/repos/ampproject/amphtml/pulls/20084","id":241045354,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxMDQ1MzU0","html_url":"https://github.com/ampproject/amphtml/pull/20084","diff_url":"https://github.com/ampproject/amphtml/pull/20084.diff","patch_url":"https://github.com/ampproject/amphtml/pull/20084.patch","issue_url":"https://api.github.com/repos/ampproject/amphtml/issues/20084","number":20084,"state":"open","locked":false,"title":"✨Add a go to page action","user":{"login":"bramanudom","id":14865700,"node_id":"MDQ6VXNlcjE0ODY1NzAw","avatar_url":"https://avatars1.githubusercontent.com/u/14865700?v=4","gravatar_id":"","url":"https://api.github.com/users/bramanudom","html_url":"https://github.com/bramanudom","followers_url":"https://api.github.com/users/bramanudom/followers","following_url":"https://api.github.com/users/bramanudom/following{/other_user}","gists_url":"https://api.github.com/users/bramanudom/gists{/gist_id}","starred_url":"https://api.github.com/users/bramanudom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramanudom/subscriptions","organizations_url":"https://api.github.com/users/bramanudom/orgs","repos_url":"https://api.github.com/users/bramanudom/repos","events_url":"https://api.github.com/users/bramanudom/events{/privacy}","received_events_url":"https://api.github.com/users/bramanudom/received_events","type":"User","site_admin":false},"body":"#20083\r\nClicking on an element with this action should bring the user to another page within the same story. \r\n\r\nNote that there will be a follow-up PR to handle changes to navigation, per UX requirement . Currently, after jumping to a new non-adjacent page, navigating to the previous page does not bring you back to the page you jumped from.\r\n\r\n\r\n","created_at":"2018-12-26T22:40:41Z","updated_at":"2018-12-26T22:57:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":"29bd317e20adfe68eb630c8660f2fcf487047067","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gmajoulet","id":1492044,"node_id":"MDQ6VXNlcjE0OTIwNDQ=","avatar_url":"https://avatars1.githubusercontent.com/u/1492044?v=4","gravatar_id":"","url":"https://api.github.com/users/gmajoulet","html_url":"https://github.com/gmajoulet","followers_url":"https://api.github.com/users/gmajoulet/followers","following_url":"https://api.github.com/users/gmajoulet/following{/other_user}","gists_url":"https://api.github.com/users/gmajoulet/gists{/gist_id}","starred_url":"https://api.github.com/users/gmajoulet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gmajoulet/subscriptions","organizations_url":"https://api.github.com/users/gmajoulet/orgs","repos_url":"https://api.github.com/users/gmajoulet/repos","events_url":"https://api.github.com/users/gmajoulet/events{/privacy}","received_events_url":"https://api.github.com/users/gmajoulet/received_events","type":"User","site_admin":false},{"login":"cvializ","id":2363700,"node_id":"MDQ6VXNlcjIzNjM3MDA=","avatar_url":"https://avatars2.githubusercontent.com/u/2363700?v=4","gravatar_id":"","url":"https://api.github.com/users/cvializ","html_url":"https://github.com/cvializ","followers_url":"https://api.github.com/users/cvializ/followers","following_url":"https://api.github.com/users/cvializ/following{/other_user}","gists_url":"https://api.github.com/users/cvializ/gists{/gist_id}","starred_url":"https://api.github.com/users/cvializ/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cvializ/subscriptions","organizations_url":"https://api.github.com/users/cvializ/orgs","repos_url":"https://api.github.com/users/cvializ/repos","events_url":"https://api.github.com/users/cvializ/events{/privacy}","received_events_url":"https://api.github.com/users/cvializ/received_events","type":"User","site_admin":false},{"login":"Enriqe","id":5449100,"node_id":"MDQ6VXNlcjU0NDkxMDA=","avatar_url":"https://avatars0.githubusercontent.com/u/5449100?v=4","gravatar_id":"","url":"https://api.github.com/users/Enriqe","html_url":"https://github.com/Enriqe","followers_url":"https://api.github.com/users/Enriqe/followers","following_url":"https://api.github.com/users/Enriqe/following{/other_user}","gists_url":"https://api.github.com/users/Enriqe/gists{/gist_id}","starred_url":"https://api.github.com/users/Enriqe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Enriqe/subscriptions","organizations_url":"https://api.github.com/users/Enriqe/orgs","repos_url":"https://api.github.com/users/Enriqe/repos","events_url":"https://api.github.com/users/Enriqe/events{/privacy}","received_events_url":"https://api.github.com/users/Enriqe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":596633554,"node_id":"MDU6TGFiZWw1OTY2MzM1NTQ=","url":"https://api.github.com/repos/ampproject/amphtml/labels/cla:%20yes","name":"cla: yes","color":"ededed","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ampproject/amphtml/pulls/20084/commits","review_comments_url":"https://api.github.com/repos/ampproject/amphtml/pulls/20084/comments","review_comment_url":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ampproject/amphtml/issues/20084/comments","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/2cc9c889f97a25760a4c9376cf97ac9a3defb206","head":{"label":"bramanudom:go_to_page","ref":"go_to_page","sha":"2cc9c889f97a25760a4c9376cf97ac9a3defb206","user":{"login":"bramanudom","id":14865700,"node_id":"MDQ6VXNlcjE0ODY1NzAw","avatar_url":"https://avatars1.githubusercontent.com/u/14865700?v=4","gravatar_id":"","url":"https://api.github.com/users/bramanudom","html_url":"https://github.com/bramanudom","followers_url":"https://api.github.com/users/bramanudom/followers","following_url":"https://api.github.com/users/bramanudom/following{/other_user}","gists_url":"https://api.github.com/users/bramanudom/gists{/gist_id}","starred_url":"https://api.github.com/users/bramanudom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramanudom/subscriptions","organizations_url":"https://api.github.com/users/bramanudom/orgs","repos_url":"https://api.github.com/users/bramanudom/repos","events_url":"https://api.github.com/users/bramanudom/events{/privacy}","received_events_url":"https://api.github.com/users/bramanudom/received_events","type":"User","site_admin":false},"repo":{"id":157244540,"node_id":"MDEwOlJlcG9zaXRvcnkxNTcyNDQ1NDA=","name":"amphtml","full_name":"bramanudom/amphtml","private":false,"owner":{"login":"bramanudom","id":14865700,"node_id":"MDQ6VXNlcjE0ODY1NzAw","avatar_url":"https://avatars1.githubusercontent.com/u/14865700?v=4","gravatar_id":"","url":"https://api.github.com/users/bramanudom","html_url":"https://github.com/bramanudom","followers_url":"https://api.github.com/users/bramanudom/followers","following_url":"https://api.github.com/users/bramanudom/following{/other_user}","gists_url":"https://api.github.com/users/bramanudom/gists{/gist_id}","starred_url":"https://api.github.com/users/bramanudom/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bramanudom/subscriptions","organizations_url":"https://api.github.com/users/bramanudom/orgs","repos_url":"https://api.github.com/users/bramanudom/repos","events_url":"https://api.github.com/users/bramanudom/events{/privacy}","received_events_url":"https://api.github.com/users/bramanudom/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bramanudom/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":true,"url":"https://api.github.com/repos/bramanudom/amphtml","forks_url":"https://api.github.com/repos/bramanudom/amphtml/forks","keys_url":"https://api.github.com/repos/bramanudom/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bramanudom/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bramanudom/amphtml/teams","hooks_url":"https://api.github.com/repos/bramanudom/amphtml/hooks","issue_events_url":"https://api.github.com/repos/bramanudom/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/bramanudom/amphtml/events","assignees_url":"https://api.github.com/repos/bramanudom/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/bramanudom/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/bramanudom/amphtml/tags","blobs_url":"https://api.github.com/repos/bramanudom/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bramanudom/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bramanudom/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/bramanudom/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bramanudom/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/bramanudom/amphtml/languages","stargazers_url":"https://api.github.com/repos/bramanudom/amphtml/stargazers","contributors_url":"https://api.github.com/repos/bramanudom/amphtml/contributors","subscribers_url":"https://api.github.com/repos/bramanudom/amphtml/subscribers","subscription_url":"https://api.github.com/repos/bramanudom/amphtml/subscription","commits_url":"https://api.github.com/repos/bramanudom/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/bramanudom/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/bramanudom/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/bramanudom/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/bramanudom/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/bramanudom/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bramanudom/amphtml/merges","archive_url":"https://api.github.com/repos/bramanudom/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bramanudom/amphtml/downloads","issues_url":"https://api.github.com/repos/bramanudom/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/bramanudom/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/bramanudom/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/bramanudom/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bramanudom/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/bramanudom/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/bramanudom/amphtml/deployments","created_at":"2018-11-12T16:40:35Z","updated_at":"2018-12-26T21:42:22Z","pushed_at":"2018-12-26T22:24:11Z","git_url":"git://github.com/bramanudom/amphtml.git","ssh_url":"git@github.com:bramanudom/amphtml.git","clone_url":"https://github.com/bramanudom/amphtml.git","svn_url":"https://github.com/bramanudom/amphtml","homepage":"https://www.ampproject.org","size":567313,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ampproject:master","ref":"master","sha":"7b01b0e6439e38bb13d337549f821fcfa49c348d","user":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"repo":{"id":41766002,"node_id":"MDEwOlJlcG9zaXRvcnk0MTc2NjAwMg==","name":"amphtml","full_name":"ampproject/amphtml","private":false,"owner":{"login":"ampproject","id":14114390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MTE0Mzkw","avatar_url":"https://avatars3.githubusercontent.com/u/14114390?v=4","gravatar_id":"","url":"https://api.github.com/users/ampproject","html_url":"https://github.com/ampproject","followers_url":"https://api.github.com/users/ampproject/followers","following_url":"https://api.github.com/users/ampproject/following{/other_user}","gists_url":"https://api.github.com/users/ampproject/gists{/gist_id}","starred_url":"https://api.github.com/users/ampproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ampproject/subscriptions","organizations_url":"https://api.github.com/users/ampproject/orgs","repos_url":"https://api.github.com/users/ampproject/repos","events_url":"https://api.github.com/users/ampproject/events{/privacy}","received_events_url":"https://api.github.com/users/ampproject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ampproject/amphtml","description":"AMP HTML source code, samples, and documentation.  See below for more info.","fork":false,"url":"https://api.github.com/repos/ampproject/amphtml","forks_url":"https://api.github.com/repos/ampproject/amphtml/forks","keys_url":"https://api.github.com/repos/ampproject/amphtml/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ampproject/amphtml/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ampproject/amphtml/teams","hooks_url":"https://api.github.com/repos/ampproject/amphtml/hooks","issue_events_url":"https://api.github.com/repos/ampproject/amphtml/issues/events{/number}","events_url":"https://api.github.com/repos/ampproject/amphtml/events","assignees_url":"https://api.github.com/repos/ampproject/amphtml/assignees{/user}","branches_url":"https://api.github.com/repos/ampproject/amphtml/branches{/branch}","tags_url":"https://api.github.com/repos/ampproject/amphtml/tags","blobs_url":"https://api.github.com/repos/ampproject/amphtml/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ampproject/amphtml/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ampproject/amphtml/git/refs{/sha}","trees_url":"https://api.github.com/repos/ampproject/amphtml/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ampproject/amphtml/statuses/{sha}","languages_url":"https://api.github.com/repos/ampproject/amphtml/languages","stargazers_url":"https://api.github.com/repos/ampproject/amphtml/stargazers","contributors_url":"https://api.github.com/repos/ampproject/amphtml/contributors","subscribers_url":"https://api.github.com/repos/ampproject/amphtml/subscribers","subscription_url":"https://api.github.com/repos/ampproject/amphtml/subscription","commits_url":"https://api.github.com/repos/ampproject/amphtml/commits{/sha}","git_commits_url":"https://api.github.com/repos/ampproject/amphtml/git/commits{/sha}","comments_url":"https://api.github.com/repos/ampproject/amphtml/comments{/number}","issue_comment_url":"https://api.github.com/repos/ampproject/amphtml/issues/comments{/number}","contents_url":"https://api.github.com/repos/ampproject/amphtml/contents/{+path}","compare_url":"https://api.github.com/repos/ampproject/amphtml/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ampproject/amphtml/merges","archive_url":"https://api.github.com/repos/ampproject/amphtml/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ampproject/amphtml/downloads","issues_url":"https://api.github.com/repos/ampproject/amphtml/issues{/number}","pulls_url":"https://api.github.com/repos/ampproject/amphtml/pulls{/number}","milestones_url":"https://api.github.com/repos/ampproject/amphtml/milestones{/number}","notifications_url":"https://api.github.com/repos/ampproject/amphtml/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ampproject/amphtml/labels{/name}","releases_url":"https://api.github.com/repos/ampproject/amphtml/releases{/id}","deployments_url":"https://api.github.com/repos/ampproject/amphtml/deployments","created_at":"2015-09-01T22:10:53Z","updated_at":"2018-12-26T21:27:15Z","pushed_at":"2018-12-26T22:40:42Z","git_url":"git://github.com/ampproject/amphtml.git","ssh_url":"git@github.com:ampproject/amphtml.git","clone_url":"https://github.com/ampproject/amphtml.git","svn_url":"https://github.com/ampproject/amphtml","homepage":"https://www.ampproject.org","size":567413,"stargazers_count":12255,"watchers_count":12255,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":2749,"mirror_url":null,"archived":false,"open_issues_count":1576,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":2749,"open_issues":1576,"watchers":12255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20084"},"html":{"href":"https://github.com/ampproject/amphtml/pull/20084"},"issue":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/20084"},"comments":{"href":"https://api.github.com/repos/ampproject/amphtml/issues/20084/comments"},"review_comments":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20084/comments"},"review_comment":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ampproject/amphtml/pulls/20084/commits"},"statuses":{"href":"https://api.github.com/repos/ampproject/amphtml/statuses/2cc9c889f97a25760a4c9376cf97ac9a3defb206"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"newmuis"}}