{"action":"created","comment":{"url":"https://api.github.com/repos/ray-project/ray/pulls/comments/243980545","pull_request_review_id":187873150,"id":243980545,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0Mzk4MDU0NQ==","diff_hunk":"@@ -83,26 +113,56 @@ def run_experiments(experiments=None,\n         List of Trial objects, holding data for each executed trial.\n \n     \"\"\"\n-\n-    if scheduler is None:\n-        scheduler = FIFOScheduler()\n-\n-    if search_alg is None:\n-        search_alg = BasicVariantGenerator()\n-\n-    search_alg.add_configurations(experiments)\n-\n-    runner = TrialRunner(\n-        search_alg,\n-        scheduler=scheduler,\n-        launch_web_server=with_server,\n-        server_port=server_port,\n-        verbose=verbose,\n-        queue_trials=queue_trials,\n-        trial_executor=trial_executor)\n+    # This is important to do this here\n+    # because it schematize the experiments\n+    # and it conducts the implicit registration.\n+    experiments = convert_to_experiment_list(experiments)\n+    checkpoint_dir = _find_checkpoint_dir(experiments)\n+    if checkpoint_dir:\n+        logger.info(\"Using checkpoint dir: {}.\".format(checkpoint_dir))\n+    runner = None\n+\n+    if resume:\n+        if not checkpoint_dir:\n+            raise ValueError(\"checkpoint_dir not detected. \"\n+                             \"Set resume=False or set a local_dir.\")\n+        if not os.path.exists(\n+                os.path.join(checkpoint_dir, TrialRunner.CKPT_FILE)):\n+            logger.warn(\n+                \"Did not find checkpoint file in {}.\".format(checkpoint_dir))","path":"python/ray/tune/tune.py","position":102,"original_position":102,"commit_id":"86b37f66d43e50e9aea8e59f1bd23f91ab496c52","original_commit_id":"86b37f66d43e50e9aea8e59f1bd23f91ab496c52","user":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"body":"Don't need to warn, this is normal operation.","created_at":"2018-12-26T10:58:36Z","updated_at":"2018-12-26T10:59:53Z","html_url":"https://github.com/ray-project/ray/pull/3309#discussion_r243980545","pull_request_url":"https://api.github.com/repos/ray-project/ray/pulls/3309","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments/243980545"},"html":{"href":"https://github.com/ray-project/ray/pull/3309#discussion_r243980545"},"pull_request":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3309"}}},"pull_request":{"url":"https://api.github.com/repos/ray-project/ray/pulls/3309","id":230305524,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMzA1NTI0","html_url":"https://github.com/ray-project/ray/pull/3309","diff_url":"https://github.com/ray-project/ray/pull/3309.diff","patch_url":"https://github.com/ray-project/ray/pull/3309.patch","issue_url":"https://api.github.com/repos/ray-project/ray/issues/3309","number":3309,"state":"open","locked":false,"title":"[tune] Cluster Fault Tolerance","user":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"body":"## What do these changes do?\r\n\r\nA redo of #3165 with extraneous cleanup changes removed.\r\n\r\nThis currently does not use the same restoring code-path as #3238, but this can change later when component FT is implemented... (i.e., this doesn't notify components that some trials go RUNNING -> PENDING).\r\n\r\nThis adds the following functionality:\r\n - pickleable trials and TrialRunner.\r\n - checkpointing/restoring functionality for Trial runner\r\n - user endpoints for experiment checkpointing\r\n\r\n\r\nExample:\r\n\r\n```python\r\n\r\nIn [6]: import time\r\n   ...: import ray\r\n   ...: from ray import tune\r\n   ...:\r\n   ...: ray.init()\r\n   ...:\r\n   ...: kwargs = dict(\r\n   ...:     run=\"__fake\",\r\n   ...:     stop=dict(training_iteration=5),\r\n   ...:     checkpoint_freq=1,\r\n   ...:     max_failures=1)\r\n   ...:\r\n   ...: # This will save the experiment state to disk on each step\r\n   ...: tune.run_experiments(\r\n   ...:     dict(experiment1=kwargs),\r\n   ...:     raise_on_failed_trial=False)\r\n   ...:\r\n```\r\n\r\n\r\nTODO:\r\n\r\n - [x] User endpoints implemented.\r\n - [x] NODE FT: Add test for scheduler notification when nodes die and trials running -> pending\r\n\r\nNOTE: this should be a lot easier to review after #3414 is merged.\r\n\r\n\r\n","created_at":"2018-11-12T23:57:10Z","updated_at":"2018-12-26T10:59:52Z","closed_at":null,"merged_at":null,"merge_commit_sha":"298ac7f8ef59060396ad69acf5ce23ed95c55393","assignee":{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false},"assignees":[{"login":"ericl","id":14922,"node_id":"MDQ6VXNlcjE0OTIy","avatar_url":"https://avatars3.githubusercontent.com/u/14922?v=4","gravatar_id":"","url":"https://api.github.com/users/ericl","html_url":"https://github.com/ericl","followers_url":"https://api.github.com/users/ericl/followers","following_url":"https://api.github.com/users/ericl/following{/other_user}","gists_url":"https://api.github.com/users/ericl/gists{/gist_id}","starred_url":"https://api.github.com/users/ericl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericl/subscriptions","organizations_url":"https://api.github.com/users/ericl/orgs","repos_url":"https://api.github.com/users/ericl/repos","events_url":"https://api.github.com/users/ericl/events{/privacy}","received_events_url":"https://api.github.com/users/ericl/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ray-project/ray/pulls/3309/commits","review_comments_url":"https://api.github.com/repos/ray-project/ray/pulls/3309/comments","review_comment_url":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ray-project/ray/issues/3309/comments","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/86b37f66d43e50e9aea8e59f1bd23f91ab496c52","head":{"label":"richardliaw:tune_cluster-2","ref":"tune_cluster-2","sha":"86b37f66d43e50e9aea8e59f1bd23f91ab496c52","user":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"repo":{"id":79407420,"node_id":"MDEwOlJlcG9zaXRvcnk3OTQwNzQyMA==","name":"ray","full_name":"richardliaw/ray","private":false,"owner":{"login":"richardliaw","id":4529381,"node_id":"MDQ6VXNlcjQ1MjkzODE=","avatar_url":"https://avatars0.githubusercontent.com/u/4529381?v=4","gravatar_id":"","url":"https://api.github.com/users/richardliaw","html_url":"https://github.com/richardliaw","followers_url":"https://api.github.com/users/richardliaw/followers","following_url":"https://api.github.com/users/richardliaw/following{/other_user}","gists_url":"https://api.github.com/users/richardliaw/gists{/gist_id}","starred_url":"https://api.github.com/users/richardliaw/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/richardliaw/subscriptions","organizations_url":"https://api.github.com/users/richardliaw/orgs","repos_url":"https://api.github.com/users/richardliaw/repos","events_url":"https://api.github.com/users/richardliaw/events{/privacy}","received_events_url":"https://api.github.com/users/richardliaw/received_events","type":"User","site_admin":false},"html_url":"https://github.com/richardliaw/ray","description":"An experimental distributed execution engine","fork":true,"url":"https://api.github.com/repos/richardliaw/ray","forks_url":"https://api.github.com/repos/richardliaw/ray/forks","keys_url":"https://api.github.com/repos/richardliaw/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/richardliaw/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/richardliaw/ray/teams","hooks_url":"https://api.github.com/repos/richardliaw/ray/hooks","issue_events_url":"https://api.github.com/repos/richardliaw/ray/issues/events{/number}","events_url":"https://api.github.com/repos/richardliaw/ray/events","assignees_url":"https://api.github.com/repos/richardliaw/ray/assignees{/user}","branches_url":"https://api.github.com/repos/richardliaw/ray/branches{/branch}","tags_url":"https://api.github.com/repos/richardliaw/ray/tags","blobs_url":"https://api.github.com/repos/richardliaw/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/richardliaw/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/richardliaw/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/richardliaw/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/richardliaw/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/richardliaw/ray/languages","stargazers_url":"https://api.github.com/repos/richardliaw/ray/stargazers","contributors_url":"https://api.github.com/repos/richardliaw/ray/contributors","subscribers_url":"https://api.github.com/repos/richardliaw/ray/subscribers","subscription_url":"https://api.github.com/repos/richardliaw/ray/subscription","commits_url":"https://api.github.com/repos/richardliaw/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/richardliaw/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/richardliaw/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/richardliaw/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/richardliaw/ray/contents/{+path}","compare_url":"https://api.github.com/repos/richardliaw/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/richardliaw/ray/merges","archive_url":"https://api.github.com/repos/richardliaw/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/richardliaw/ray/downloads","issues_url":"https://api.github.com/repos/richardliaw/ray/issues{/number}","pulls_url":"https://api.github.com/repos/richardliaw/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/richardliaw/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/richardliaw/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/richardliaw/ray/labels{/name}","releases_url":"https://api.github.com/repos/richardliaw/ray/releases{/id}","deployments_url":"https://api.github.com/repos/richardliaw/ray/deployments","created_at":"2017-01-19T02:34:33Z","updated_at":"2018-12-18T08:43:17Z","pushed_at":"2018-12-26T10:00:49Z","git_url":"git://github.com/richardliaw/ray.git","ssh_url":"git@github.com:richardliaw/ray.git","clone_url":"https://github.com/richardliaw/ray.git","svn_url":"https://github.com/richardliaw/ray","homepage":"","size":26737,"stargazers_count":1,"watchers_count":1,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":2,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":2,"watchers":1,"default_branch":"master"}},"base":{"label":"ray-project:master","ref":"master","sha":"5426234cd84e3ac055c4f80be686601c22e81e00","user":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"repo":{"id":71932349,"node_id":"MDEwOlJlcG9zaXRvcnk3MTkzMjM0OQ==","name":"ray","full_name":"ray-project/ray","private":false,"owner":{"login":"ray-project","id":22125274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyMTI1Mjc0","avatar_url":"https://avatars3.githubusercontent.com/u/22125274?v=4","gravatar_id":"","url":"https://api.github.com/users/ray-project","html_url":"https://github.com/ray-project","followers_url":"https://api.github.com/users/ray-project/followers","following_url":"https://api.github.com/users/ray-project/following{/other_user}","gists_url":"https://api.github.com/users/ray-project/gists{/gist_id}","starred_url":"https://api.github.com/users/ray-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ray-project/subscriptions","organizations_url":"https://api.github.com/users/ray-project/orgs","repos_url":"https://api.github.com/users/ray-project/repos","events_url":"https://api.github.com/users/ray-project/events{/privacy}","received_events_url":"https://api.github.com/users/ray-project/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ray-project/ray","description":"A system for parallel and distributed Python that unifies the ML ecosystem.","fork":false,"url":"https://api.github.com/repos/ray-project/ray","forks_url":"https://api.github.com/repos/ray-project/ray/forks","keys_url":"https://api.github.com/repos/ray-project/ray/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ray-project/ray/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ray-project/ray/teams","hooks_url":"https://api.github.com/repos/ray-project/ray/hooks","issue_events_url":"https://api.github.com/repos/ray-project/ray/issues/events{/number}","events_url":"https://api.github.com/repos/ray-project/ray/events","assignees_url":"https://api.github.com/repos/ray-project/ray/assignees{/user}","branches_url":"https://api.github.com/repos/ray-project/ray/branches{/branch}","tags_url":"https://api.github.com/repos/ray-project/ray/tags","blobs_url":"https://api.github.com/repos/ray-project/ray/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ray-project/ray/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ray-project/ray/git/refs{/sha}","trees_url":"https://api.github.com/repos/ray-project/ray/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ray-project/ray/statuses/{sha}","languages_url":"https://api.github.com/repos/ray-project/ray/languages","stargazers_url":"https://api.github.com/repos/ray-project/ray/stargazers","contributors_url":"https://api.github.com/repos/ray-project/ray/contributors","subscribers_url":"https://api.github.com/repos/ray-project/ray/subscribers","subscription_url":"https://api.github.com/repos/ray-project/ray/subscription","commits_url":"https://api.github.com/repos/ray-project/ray/commits{/sha}","git_commits_url":"https://api.github.com/repos/ray-project/ray/git/commits{/sha}","comments_url":"https://api.github.com/repos/ray-project/ray/comments{/number}","issue_comment_url":"https://api.github.com/repos/ray-project/ray/issues/comments{/number}","contents_url":"https://api.github.com/repos/ray-project/ray/contents/{+path}","compare_url":"https://api.github.com/repos/ray-project/ray/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ray-project/ray/merges","archive_url":"https://api.github.com/repos/ray-project/ray/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ray-project/ray/downloads","issues_url":"https://api.github.com/repos/ray-project/ray/issues{/number}","pulls_url":"https://api.github.com/repos/ray-project/ray/pulls{/number}","milestones_url":"https://api.github.com/repos/ray-project/ray/milestones{/number}","notifications_url":"https://api.github.com/repos/ray-project/ray/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ray-project/ray/labels{/name}","releases_url":"https://api.github.com/repos/ray-project/ray/releases{/id}","deployments_url":"https://api.github.com/repos/ray-project/ray/deployments","created_at":"2016-10-25T19:38:30Z","updated_at":"2018-12-26T10:15:25Z","pushed_at":"2018-12-26T10:33:18Z","git_url":"git://github.com/ray-project/ray.git","ssh_url":"git@github.com:ray-project/ray.git","clone_url":"https://github.com/ray-project/ray.git","svn_url":"https://github.com/ray-project/ray","homepage":"https://ray.readthedocs.io/en/latest/","size":17661,"stargazers_count":5114,"watchers_count":5114,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":700,"mirror_url":null,"archived":false,"open_issues_count":512,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":700,"open_issues":512,"watchers":5114,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3309"},"html":{"href":"https://github.com/ray-project/ray/pull/3309"},"issue":{"href":"https://api.github.com/repos/ray-project/ray/issues/3309"},"comments":{"href":"https://api.github.com/repos/ray-project/ray/issues/3309/comments"},"review_comments":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3309/comments"},"review_comment":{"href":"https://api.github.com/repos/ray-project/ray/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ray-project/ray/pulls/3309/commits"},"statuses":{"href":"https://api.github.com/repos/ray-project/ray/statuses/86b37f66d43e50e9aea8e59f1bd23f91ab496c52"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"ericl"}}