{"action":"created","comment":{"url":"https://api.github.com/repos/w3c/manifest/pulls/comments/215130254","pull_request_review_id":152323614,"id":215130254,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTEzMDI1NA==","diff_hunk":"@@ -2570,6 +2604,143 @@ <h3>\n           </pre>\n         </div>\n       </section>\n+      <section>\n+        <h2><a id=\"icon-masks\"></a>\n+          Icon masks and safe zone\n+        </h2>\n+        <p>\n+          Some platforms have their own preferred icon shape, but as web\n+          applications should work across multiple platforms, it is possible to\n+          indicate that an icon can have a user-agent-specified mask applied by\n+          adding the <a>maskable</a> purpose. This allows the platform to ensure\n+          that the icon looks well integrated with the platform, and even apply\n+          different masks and background colors in different places throughout\n+          the platform.\n+        </p>\n+        <p>\n+          Any icon indicating that it can be supercomposed with a mask, must\n+          make sure that all important parts are within the <dfn>safe\n+          zone</dfn>, which is defined as a circle with center point in the\n+          center of the icon and with a radius of 2/5 (40%) of the icon size,\n+          which means the smaller of the icon width and height, in case the\n+          icon is not rectangular.\n+        </p>\n+        <figure>\n+          <img src=\"images/safe-zone.svg\" width=\"340\" height=\"340\" alt=\n+          \"safe zone illustrated\">\n+          <figcaption>\n+            The safe zone is a centrally positioned circle, with radius 2/5\n+            (40%) of the minimum of the icon's width and height.\n+          </figcaption>\n+        </figure>\n+        <p>\n+          All pixels in this zone are guaranteed to be seen in all masks.\n+          Pixels outside the safe zone are not guaranteed (but can) be visible\n+          depending on the applies mask.\n+        </p>\n+        <p>\n+          The user agent MAY apply a mask of any size, making any pixels that\n+          are more than 2/5ths of the image size (minimum of width and height\n+          if non-square) away from the center (the <a>safe zone</a>)\n+          transparent.\n+        </p>\n+        <p>\n+          The user agent MUST NOT make any pixel within the safe zone\n+          transparent.\n+        </p>\n+        <p>\n+          The user agent MAY enlarge the icon by adding additional padding.\n+        </p>\n+        <p>\n+          The user agent MUST paste any image containing transparent pixels","path":"index.html","position":100,"original_position":100,"commit_id":"11142cb494538b01ad7b3b3f0789f9d9d691d769","original_commit_id":"11142cb494538b01ad7b3b3f0789f9d9d691d769","user":{"login":"mgiuca","id":228433,"node_id":"MDQ6VXNlcjIyODQzMw==","avatar_url":"https://avatars0.githubusercontent.com/u/228433?v=4","gravatar_id":"","url":"https://api.github.com/users/mgiuca","html_url":"https://github.com/mgiuca","followers_url":"https://api.github.com/users/mgiuca/followers","following_url":"https://api.github.com/users/mgiuca/following{/other_user}","gists_url":"https://api.github.com/users/mgiuca/gists{/gist_id}","starred_url":"https://api.github.com/users/mgiuca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mgiuca/subscriptions","organizations_url":"https://api.github.com/users/mgiuca/orgs","repos_url":"https://api.github.com/users/mgiuca/repos","events_url":"https://api.github.com/users/mgiuca/events{/privacy}","received_events_url":"https://api.github.com/users/mgiuca/received_events","type":"User","site_admin":false},"body":"s/paste/composite.\r\n\r\nAlso it's a bit unclear what \"any image\" means (it refers to the icon, not just any random image).\r\n\r\nSo: \"If the icon contains transparent pixels, the user agent MUST composite the icon onto a solid ...\"\r\n\r\nAlso, suggest adding a non-normative note: \"It is suggested that designers avoid using transparent pixels in maskable icons.\" (Again, avoiding RFC 2119 word \"recommended\".)","created_at":"2018-09-05T04:01:13Z","updated_at":"2018-09-05T04:03:53Z","html_url":"https://github.com/w3c/manifest/pull/657#discussion_r215130254","pull_request_url":"https://api.github.com/repos/w3c/manifest/pulls/657","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/w3c/manifest/pulls/comments/215130254"},"html":{"href":"https://github.com/w3c/manifest/pull/657#discussion_r215130254"},"pull_request":{"href":"https://api.github.com/repos/w3c/manifest/pulls/657"}}},"pull_request":{"url":"https://api.github.com/repos/w3c/manifest/pulls/657","id":171028537,"node_id":"MDExOlB1bGxSZXF1ZXN0MTcxMDI4NTM3","html_url":"https://github.com/w3c/manifest/pull/657","diff_url":"https://github.com/w3c/manifest/pull/657.diff","patch_url":"https://github.com/w3c/manifest/pull/657.patch","issue_url":"https://api.github.com/repos/w3c/manifest/issues/657","number":657,"state":"open","locked":false,"title":"Add a 'masking' purpose, for allowing the UA to supercompose such icons","user":{"login":"kenchris","id":1101339,"node_id":"MDQ6VXNlcjExMDEzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1101339?v=4","gravatar_id":"","url":"https://api.github.com/users/kenchris","html_url":"https://github.com/kenchris","followers_url":"https://api.github.com/users/kenchris/followers","following_url":"https://api.github.com/users/kenchris/following{/other_user}","gists_url":"https://api.github.com/users/kenchris/gists{/gist_id}","starred_url":"https://api.github.com/users/kenchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenchris/subscriptions","organizations_url":"https://api.github.com/users/kenchris/orgs","repos_url":"https://api.github.com/users/kenchris/repos","events_url":"https://api.github.com/users/kenchris/events{/privacy}","received_events_url":"https://api.github.com/users/kenchris/received_events","type":"User","site_admin":false},"body":"Follow Matt's idea and just allow icons to be masked for now.\n\n\n<!--\n    This comment and the below content is programatically generated.\n    You may add a comma-separated list of anchors you'd like a\n    direct link to below (e.g. #idl-serializers, #idl-sequence):\n\n    Don't remove this comment or modify anything below this line.\n    If you don't want a preview generated for this pull request,\n    just replace the whole of this comment's content by \"no preview\"\n    and remove what's below.\n-->\n***\n<a href=\"https://pr-preview.s3.amazonaws.com/kenchris/manifest/pull/657.html\" title=\"Last updated on Sep 4, 2018, 11:23 AM GMT (11142cb)\">Preview</a> | <a href=\"https://pr-preview.s3.amazonaws.com/w3c/manifest/657/5fbd52b...kenchris:11142cb.html\" title=\"Last updated on Sep 4, 2018, 11:23 AM GMT (11142cb)\">Diff</a>","created_at":"2018-02-23T14:31:05Z","updated_at":"2018-09-05T04:03:53Z","closed_at":null,"merged_at":null,"merge_commit_sha":"98a1e2b2ca5fe4933f600876e56833ba6153d4fc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/w3c/manifest/pulls/657/commits","review_comments_url":"https://api.github.com/repos/w3c/manifest/pulls/657/comments","review_comment_url":"https://api.github.com/repos/w3c/manifest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/w3c/manifest/issues/657/comments","statuses_url":"https://api.github.com/repos/w3c/manifest/statuses/11142cb494538b01ad7b3b3f0789f9d9d691d769","head":{"label":"kenchris:masking","ref":"masking","sha":"11142cb494538b01ad7b3b3f0789f9d9d691d769","user":{"login":"kenchris","id":1101339,"node_id":"MDQ6VXNlcjExMDEzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1101339?v=4","gravatar_id":"","url":"https://api.github.com/users/kenchris","html_url":"https://github.com/kenchris","followers_url":"https://api.github.com/users/kenchris/followers","following_url":"https://api.github.com/users/kenchris/following{/other_user}","gists_url":"https://api.github.com/users/kenchris/gists{/gist_id}","starred_url":"https://api.github.com/users/kenchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenchris/subscriptions","organizations_url":"https://api.github.com/users/kenchris/orgs","repos_url":"https://api.github.com/users/kenchris/repos","events_url":"https://api.github.com/users/kenchris/events{/privacy}","received_events_url":"https://api.github.com/users/kenchris/received_events","type":"User","site_admin":false},"repo":{"id":16946808,"node_id":"MDEwOlJlcG9zaXRvcnkxNjk0NjgwOA==","name":"manifest","full_name":"kenchris/manifest","owner":{"login":"kenchris","id":1101339,"node_id":"MDQ6VXNlcjExMDEzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/1101339?v=4","gravatar_id":"","url":"https://api.github.com/users/kenchris","html_url":"https://github.com/kenchris","followers_url":"https://api.github.com/users/kenchris/followers","following_url":"https://api.github.com/users/kenchris/following{/other_user}","gists_url":"https://api.github.com/users/kenchris/gists{/gist_id}","starred_url":"https://api.github.com/users/kenchris/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenchris/subscriptions","organizations_url":"https://api.github.com/users/kenchris/orgs","repos_url":"https://api.github.com/users/kenchris/repos","events_url":"https://api.github.com/users/kenchris/events{/privacy}","received_events_url":"https://api.github.com/users/kenchris/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/kenchris/manifest","description":"Manifest for hosted web apps and packaged apps","fork":true,"url":"https://api.github.com/repos/kenchris/manifest","forks_url":"https://api.github.com/repos/kenchris/manifest/forks","keys_url":"https://api.github.com/repos/kenchris/manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kenchris/manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kenchris/manifest/teams","hooks_url":"https://api.github.com/repos/kenchris/manifest/hooks","issue_events_url":"https://api.github.com/repos/kenchris/manifest/issues/events{/number}","events_url":"https://api.github.com/repos/kenchris/manifest/events","assignees_url":"https://api.github.com/repos/kenchris/manifest/assignees{/user}","branches_url":"https://api.github.com/repos/kenchris/manifest/branches{/branch}","tags_url":"https://api.github.com/repos/kenchris/manifest/tags","blobs_url":"https://api.github.com/repos/kenchris/manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kenchris/manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kenchris/manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/kenchris/manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kenchris/manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/kenchris/manifest/languages","stargazers_url":"https://api.github.com/repos/kenchris/manifest/stargazers","contributors_url":"https://api.github.com/repos/kenchris/manifest/contributors","subscribers_url":"https://api.github.com/repos/kenchris/manifest/subscribers","subscription_url":"https://api.github.com/repos/kenchris/manifest/subscription","commits_url":"https://api.github.com/repos/kenchris/manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/kenchris/manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/kenchris/manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/kenchris/manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/kenchris/manifest/contents/{+path}","compare_url":"https://api.github.com/repos/kenchris/manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kenchris/manifest/merges","archive_url":"https://api.github.com/repos/kenchris/manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kenchris/manifest/downloads","issues_url":"https://api.github.com/repos/kenchris/manifest/issues{/number}","pulls_url":"https://api.github.com/repos/kenchris/manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/kenchris/manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/kenchris/manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kenchris/manifest/labels{/name}","releases_url":"https://api.github.com/repos/kenchris/manifest/releases{/id}","deployments_url":"https://api.github.com/repos/kenchris/manifest/deployments","created_at":"2014-02-18T11:31:14Z","updated_at":"2018-09-03T12:42:04Z","pushed_at":"2018-09-04T11:23:32Z","git_url":"git://github.com/kenchris/manifest.git","ssh_url":"git@github.com:kenchris/manifest.git","clone_url":"https://github.com/kenchris/manifest.git","svn_url":"https://github.com/kenchris/manifest","homepage":null,"size":1593,"stargazers_count":0,"watchers_count":0,"language":"HTML","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"gh-pages"}},"base":{"label":"w3c:gh-pages","ref":"gh-pages","sha":"5e22b12250d59352f040f05c8679d76eff2a56c8","user":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"repo":{"id":9549221,"node_id":"MDEwOlJlcG9zaXRvcnk5NTQ5MjIx","name":"manifest","full_name":"w3c/manifest","owner":{"login":"w3c","id":379216,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM3OTIxNg==","avatar_url":"https://avatars2.githubusercontent.com/u/379216?v=4","gravatar_id":"","url":"https://api.github.com/users/w3c","html_url":"https://github.com/w3c","followers_url":"https://api.github.com/users/w3c/followers","following_url":"https://api.github.com/users/w3c/following{/other_user}","gists_url":"https://api.github.com/users/w3c/gists{/gist_id}","starred_url":"https://api.github.com/users/w3c/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/w3c/subscriptions","organizations_url":"https://api.github.com/users/w3c/orgs","repos_url":"https://api.github.com/users/w3c/repos","events_url":"https://api.github.com/users/w3c/events{/privacy}","received_events_url":"https://api.github.com/users/w3c/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/w3c/manifest","description":"Manifest for web apps","fork":false,"url":"https://api.github.com/repos/w3c/manifest","forks_url":"https://api.github.com/repos/w3c/manifest/forks","keys_url":"https://api.github.com/repos/w3c/manifest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/w3c/manifest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/w3c/manifest/teams","hooks_url":"https://api.github.com/repos/w3c/manifest/hooks","issue_events_url":"https://api.github.com/repos/w3c/manifest/issues/events{/number}","events_url":"https://api.github.com/repos/w3c/manifest/events","assignees_url":"https://api.github.com/repos/w3c/manifest/assignees{/user}","branches_url":"https://api.github.com/repos/w3c/manifest/branches{/branch}","tags_url":"https://api.github.com/repos/w3c/manifest/tags","blobs_url":"https://api.github.com/repos/w3c/manifest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/w3c/manifest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/w3c/manifest/git/refs{/sha}","trees_url":"https://api.github.com/repos/w3c/manifest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/w3c/manifest/statuses/{sha}","languages_url":"https://api.github.com/repos/w3c/manifest/languages","stargazers_url":"https://api.github.com/repos/w3c/manifest/stargazers","contributors_url":"https://api.github.com/repos/w3c/manifest/contributors","subscribers_url":"https://api.github.com/repos/w3c/manifest/subscribers","subscription_url":"https://api.github.com/repos/w3c/manifest/subscription","commits_url":"https://api.github.com/repos/w3c/manifest/commits{/sha}","git_commits_url":"https://api.github.com/repos/w3c/manifest/git/commits{/sha}","comments_url":"https://api.github.com/repos/w3c/manifest/comments{/number}","issue_comment_url":"https://api.github.com/repos/w3c/manifest/issues/comments{/number}","contents_url":"https://api.github.com/repos/w3c/manifest/contents/{+path}","compare_url":"https://api.github.com/repos/w3c/manifest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/w3c/manifest/merges","archive_url":"https://api.github.com/repos/w3c/manifest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/w3c/manifest/downloads","issues_url":"https://api.github.com/repos/w3c/manifest/issues{/number}","pulls_url":"https://api.github.com/repos/w3c/manifest/pulls{/number}","milestones_url":"https://api.github.com/repos/w3c/manifest/milestones{/number}","notifications_url":"https://api.github.com/repos/w3c/manifest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/w3c/manifest/labels{/name}","releases_url":"https://api.github.com/repos/w3c/manifest/releases{/id}","deployments_url":"https://api.github.com/repos/w3c/manifest/deployments","created_at":"2013-04-19T16:07:37Z","updated_at":"2018-09-04T22:23:59Z","pushed_at":"2018-09-04T22:23:55Z","git_url":"git://github.com/w3c/manifest.git","ssh_url":"git@github.com:w3c/manifest.git","clone_url":"https://github.com/w3c/manifest.git","svn_url":"https://github.com/w3c/manifest","homepage":"https://www.w3.org/TR/appmanifest/","size":1555,"stargazers_count":338,"watchers_count":338,"language":"HTML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":80,"mirror_url":null,"archived":false,"open_issues_count":71,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":80,"open_issues":71,"watchers":338,"default_branch":"gh-pages"}},"_links":{"self":{"href":"https://api.github.com/repos/w3c/manifest/pulls/657"},"html":{"href":"https://github.com/w3c/manifest/pull/657"},"issue":{"href":"https://api.github.com/repos/w3c/manifest/issues/657"},"comments":{"href":"https://api.github.com/repos/w3c/manifest/issues/657/comments"},"review_comments":{"href":"https://api.github.com/repos/w3c/manifest/pulls/657/comments"},"review_comment":{"href":"https://api.github.com/repos/w3c/manifest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/w3c/manifest/pulls/657/commits"},"statuses":{"href":"https://api.github.com/repos/w3c/manifest/statuses/11142cb494538b01ad7b3b3f0789f9d9d691d769"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mgiuca"}}