{"action":"created","comment":{"url":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/comments/222442951","pull_request_review_id":161330733,"id":222442951,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMjQ0Mjk1MQ==","diff_hunk":"@@ -189,13 +189,16 @@ func escapeUnicode(input string) string {\n \t\t\t// surrogate pair\n \t\t\tvar r1, r2 = utf16.EncodeRune(r)\n \t\t\tvar s = fmt.Sprintf(\"\\\\u%x\\\\u%x\", r1, r2)\n-\t\t\tbuffer.WriteString(s)\n+\t\t\t_, err := buffer.WriteString(s)\n+\t\t\t_ = err // error always nil https://golang.org/pkg/bytes/#Buffer.WriteString\n \t\t} else if r > 127 {\n \t\t\tvar s = fmt.Sprintf(\"\\\\u%04x\", r)\n-\t\t\tbuffer.WriteString(s)\n+\t\t\t_, err := buffer.WriteString(s)\n+\t\t\t_ = err // error always nil https://golang.org/pkg/bytes/#Buffer.WriteString\n \t\t} else {\n \t\t\tvar s = fmt.Sprintf(\"%c\", r)\n-\t\t\tbuffer.WriteString(s)\n+\t\t\t_, err := buffer.WriteString(s)\n+\t\t\t_ = err // error always nil https://golang.org/pkg/bytes/#Buffer.WriteString","path":"smtpapi.go","position":16,"original_position":16,"commit_id":"eef1b804983fa119ac364379daa89d3b19dcd20d","original_commit_id":"eef1b804983fa119ac364379daa89d3b19dcd20d","user":{"login":"extemporalgenome","id":536740,"node_id":"MDQ6VXNlcjUzNjc0MA==","avatar_url":"https://avatars1.githubusercontent.com/u/536740?v=4","gravatar_id":"","url":"https://api.github.com/users/extemporalgenome","html_url":"https://github.com/extemporalgenome","followers_url":"https://api.github.com/users/extemporalgenome/followers","following_url":"https://api.github.com/users/extemporalgenome/following{/other_user}","gists_url":"https://api.github.com/users/extemporalgenome/gists{/gist_id}","starred_url":"https://api.github.com/users/extemporalgenome/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/extemporalgenome/subscriptions","organizations_url":"https://api.github.com/users/extemporalgenome/orgs","repos_url":"https://api.github.com/users/extemporalgenome/repos","events_url":"https://api.github.com/users/extemporalgenome/events{/privacy}","received_events_url":"https://api.github.com/users/extemporalgenome/received_events","type":"User","site_admin":false},"body":"would this be better as a `//nolint: ...` directive? It's not clean, but neither two-step discard.","created_at":"2018-10-03T19:45:09Z","updated_at":"2018-10-03T19:45:09Z","html_url":"https://github.com/sendgrid/smtpapi-go/pull/65#discussion_r222442951","pull_request_url":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/65","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/comments/222442951"},"html":{"href":"https://github.com/sendgrid/smtpapi-go/pull/65#discussion_r222442951"},"pull_request":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/65"}}},"pull_request":{"url":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/65","id":219915015,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5OTE1MDE1","html_url":"https://github.com/sendgrid/smtpapi-go/pull/65","diff_url":"https://github.com/sendgrid/smtpapi-go/pull/65.diff","patch_url":"https://github.com/sendgrid/smtpapi-go/pull/65.patch","issue_url":"https://api.github.com/repos/sendgrid/smtpapi-go/issues/65","number":65,"state":"open","locked":false,"title":"Failing build","user":{"login":"vaskoz","id":21339,"node_id":"MDQ6VXNlcjIxMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/21339?v=4","gravatar_id":"","url":"https://api.github.com/users/vaskoz","html_url":"https://github.com/vaskoz","followers_url":"https://api.github.com/users/vaskoz/followers","following_url":"https://api.github.com/users/vaskoz/following{/other_user}","gists_url":"https://api.github.com/users/vaskoz/gists{/gist_id}","starred_url":"https://api.github.com/users/vaskoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaskoz/subscriptions","organizations_url":"https://api.github.com/users/vaskoz/orgs","repos_url":"https://api.github.com/users/vaskoz/repos","events_url":"https://api.github.com/users/vaskoz/events{/privacy}","received_events_url":"https://api.github.com/users/vaskoz/received_events","type":"User","site_admin":false},"body":"<!--\r\nWe appreciate the effort for this pull request but before that please make sure you read the contribution guidelines given above, then fill out the blanks below.\r\n\r\n\r\nPlease enter each Issue number you are resolving in your PR after one of the following words [Fixes, Closes, Resolves]. This will auto-link these issues and close them when this PR is merged!\r\ne.g. \r\nFixes #1\r\nCloses #2\r\n-->\r\n# Fixes # \r\nThe build has been broken for a while due to `gometalinter` issues. Specifically, these [failures](https://travis-ci.org/sendgrid/smtpapi-go/jobs/388022288#L512-L516).\r\n\r\n### Checklist\r\n- [x] I have made a material change to the repo (functionality, testing, spelling, grammar)\r\n- [x] I have read the [Contribution Guide] and my PR follows them.\r\n- [x] I updated my branch with the master branch.\r\n- [x] I have added tests that prove my fix is effective or that my feature works\r\n- [x] I have added necessary documentation about the functionality in the appropriate .md file\r\n- [x] I have added in line documentation to the code I modified\r\n\r\n### Short description of what this PR does:\r\n- gometalinter found errors not being explicitly handled which is bad practice.\r\n- gometalinter found an optimization where a raw string is better.\r\n\r\nIf you have questions, please send an email to [Sendgrid](mailto:dx@sendgrid.com), or file a Github Issue in this repository.\r\n","created_at":"2018-10-03T04:56:17Z","updated_at":"2018-10-03T19:45:09Z","closed_at":null,"merged_at":null,"merge_commit_sha":"61878d96384a16b1a138fc1010bcd12cad9a3fcb","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":380766354,"node_id":"MDU6TGFiZWwzODA3NjYzNTQ=","url":"https://api.github.com/repos/sendgrid/smtpapi-go/labels/status:%20code%20review%20request","name":"status: code review request","color":"cccccc","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/65/commits","review_comments_url":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/65/comments","review_comment_url":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/comments{/number}","comments_url":"https://api.github.com/repos/sendgrid/smtpapi-go/issues/65/comments","statuses_url":"https://api.github.com/repos/sendgrid/smtpapi-go/statuses/eef1b804983fa119ac364379daa89d3b19dcd20d","head":{"label":"vaskoz:failingBuild","ref":"failingBuild","sha":"eef1b804983fa119ac364379daa89d3b19dcd20d","user":{"login":"vaskoz","id":21339,"node_id":"MDQ6VXNlcjIxMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/21339?v=4","gravatar_id":"","url":"https://api.github.com/users/vaskoz","html_url":"https://github.com/vaskoz","followers_url":"https://api.github.com/users/vaskoz/followers","following_url":"https://api.github.com/users/vaskoz/following{/other_user}","gists_url":"https://api.github.com/users/vaskoz/gists{/gist_id}","starred_url":"https://api.github.com/users/vaskoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaskoz/subscriptions","organizations_url":"https://api.github.com/users/vaskoz/orgs","repos_url":"https://api.github.com/users/vaskoz/repos","events_url":"https://api.github.com/users/vaskoz/events{/privacy}","received_events_url":"https://api.github.com/users/vaskoz/received_events","type":"User","site_admin":false},"repo":{"id":90768533,"node_id":"MDEwOlJlcG9zaXRvcnk5MDc2ODUzMw==","name":"smtpapi-go","full_name":"vaskoz/smtpapi-go","private":false,"owner":{"login":"vaskoz","id":21339,"node_id":"MDQ6VXNlcjIxMzM5","avatar_url":"https://avatars0.githubusercontent.com/u/21339?v=4","gravatar_id":"","url":"https://api.github.com/users/vaskoz","html_url":"https://github.com/vaskoz","followers_url":"https://api.github.com/users/vaskoz/followers","following_url":"https://api.github.com/users/vaskoz/following{/other_user}","gists_url":"https://api.github.com/users/vaskoz/gists{/gist_id}","starred_url":"https://api.github.com/users/vaskoz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vaskoz/subscriptions","organizations_url":"https://api.github.com/users/vaskoz/orgs","repos_url":"https://api.github.com/users/vaskoz/repos","events_url":"https://api.github.com/users/vaskoz/events{/privacy}","received_events_url":"https://api.github.com/users/vaskoz/received_events","type":"User","site_admin":false},"html_url":"https://github.com/vaskoz/smtpapi-go","description":"Wrapper for SendGrid's X-SMTPAPI in Go","fork":true,"url":"https://api.github.com/repos/vaskoz/smtpapi-go","forks_url":"https://api.github.com/repos/vaskoz/smtpapi-go/forks","keys_url":"https://api.github.com/repos/vaskoz/smtpapi-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vaskoz/smtpapi-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vaskoz/smtpapi-go/teams","hooks_url":"https://api.github.com/repos/vaskoz/smtpapi-go/hooks","issue_events_url":"https://api.github.com/repos/vaskoz/smtpapi-go/issues/events{/number}","events_url":"https://api.github.com/repos/vaskoz/smtpapi-go/events","assignees_url":"https://api.github.com/repos/vaskoz/smtpapi-go/assignees{/user}","branches_url":"https://api.github.com/repos/vaskoz/smtpapi-go/branches{/branch}","tags_url":"https://api.github.com/repos/vaskoz/smtpapi-go/tags","blobs_url":"https://api.github.com/repos/vaskoz/smtpapi-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vaskoz/smtpapi-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vaskoz/smtpapi-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/vaskoz/smtpapi-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vaskoz/smtpapi-go/statuses/{sha}","languages_url":"https://api.github.com/repos/vaskoz/smtpapi-go/languages","stargazers_url":"https://api.github.com/repos/vaskoz/smtpapi-go/stargazers","contributors_url":"https://api.github.com/repos/vaskoz/smtpapi-go/contributors","subscribers_url":"https://api.github.com/repos/vaskoz/smtpapi-go/subscribers","subscription_url":"https://api.github.com/repos/vaskoz/smtpapi-go/subscription","commits_url":"https://api.github.com/repos/vaskoz/smtpapi-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/vaskoz/smtpapi-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/vaskoz/smtpapi-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/vaskoz/smtpapi-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/vaskoz/smtpapi-go/contents/{+path}","compare_url":"https://api.github.com/repos/vaskoz/smtpapi-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vaskoz/smtpapi-go/merges","archive_url":"https://api.github.com/repos/vaskoz/smtpapi-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vaskoz/smtpapi-go/downloads","issues_url":"https://api.github.com/repos/vaskoz/smtpapi-go/issues{/number}","pulls_url":"https://api.github.com/repos/vaskoz/smtpapi-go/pulls{/number}","milestones_url":"https://api.github.com/repos/vaskoz/smtpapi-go/milestones{/number}","notifications_url":"https://api.github.com/repos/vaskoz/smtpapi-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vaskoz/smtpapi-go/labels{/name}","releases_url":"https://api.github.com/repos/vaskoz/smtpapi-go/releases{/id}","deployments_url":"https://api.github.com/repos/vaskoz/smtpapi-go/deployments","created_at":"2017-05-09T16:35:47Z","updated_at":"2017-05-09T16:35:48Z","pushed_at":"2018-10-03T05:17:36Z","git_url":"git://github.com/vaskoz/smtpapi-go.git","ssh_url":"git@github.com:vaskoz/smtpapi-go.git","clone_url":"https://github.com/vaskoz/smtpapi-go.git","svn_url":"https://github.com/vaskoz/smtpapi-go","homepage":null,"size":91,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"sendgrid:master","ref":"master","sha":"809db2e7ed3a873b327eaa0a0380baa0ea5a455b","user":{"login":"sendgrid","id":181234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTIzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/181234?v=4","gravatar_id":"","url":"https://api.github.com/users/sendgrid","html_url":"https://github.com/sendgrid","followers_url":"https://api.github.com/users/sendgrid/followers","following_url":"https://api.github.com/users/sendgrid/following{/other_user}","gists_url":"https://api.github.com/users/sendgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgrid/subscriptions","organizations_url":"https://api.github.com/users/sendgrid/orgs","repos_url":"https://api.github.com/users/sendgrid/repos","events_url":"https://api.github.com/users/sendgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sendgrid/received_events","type":"Organization","site_admin":false},"repo":{"id":15367378,"node_id":"MDEwOlJlcG9zaXRvcnkxNTM2NzM3OA==","name":"smtpapi-go","full_name":"sendgrid/smtpapi-go","private":false,"owner":{"login":"sendgrid","id":181234,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4MTIzNA==","avatar_url":"https://avatars0.githubusercontent.com/u/181234?v=4","gravatar_id":"","url":"https://api.github.com/users/sendgrid","html_url":"https://github.com/sendgrid","followers_url":"https://api.github.com/users/sendgrid/followers","following_url":"https://api.github.com/users/sendgrid/following{/other_user}","gists_url":"https://api.github.com/users/sendgrid/gists{/gist_id}","starred_url":"https://api.github.com/users/sendgrid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sendgrid/subscriptions","organizations_url":"https://api.github.com/users/sendgrid/orgs","repos_url":"https://api.github.com/users/sendgrid/repos","events_url":"https://api.github.com/users/sendgrid/events{/privacy}","received_events_url":"https://api.github.com/users/sendgrid/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/sendgrid/smtpapi-go","description":"SendGrids smtpapi library in Golang","fork":false,"url":"https://api.github.com/repos/sendgrid/smtpapi-go","forks_url":"https://api.github.com/repos/sendgrid/smtpapi-go/forks","keys_url":"https://api.github.com/repos/sendgrid/smtpapi-go/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sendgrid/smtpapi-go/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sendgrid/smtpapi-go/teams","hooks_url":"https://api.github.com/repos/sendgrid/smtpapi-go/hooks","issue_events_url":"https://api.github.com/repos/sendgrid/smtpapi-go/issues/events{/number}","events_url":"https://api.github.com/repos/sendgrid/smtpapi-go/events","assignees_url":"https://api.github.com/repos/sendgrid/smtpapi-go/assignees{/user}","branches_url":"https://api.github.com/repos/sendgrid/smtpapi-go/branches{/branch}","tags_url":"https://api.github.com/repos/sendgrid/smtpapi-go/tags","blobs_url":"https://api.github.com/repos/sendgrid/smtpapi-go/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sendgrid/smtpapi-go/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sendgrid/smtpapi-go/git/refs{/sha}","trees_url":"https://api.github.com/repos/sendgrid/smtpapi-go/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sendgrid/smtpapi-go/statuses/{sha}","languages_url":"https://api.github.com/repos/sendgrid/smtpapi-go/languages","stargazers_url":"https://api.github.com/repos/sendgrid/smtpapi-go/stargazers","contributors_url":"https://api.github.com/repos/sendgrid/smtpapi-go/contributors","subscribers_url":"https://api.github.com/repos/sendgrid/smtpapi-go/subscribers","subscription_url":"https://api.github.com/repos/sendgrid/smtpapi-go/subscription","commits_url":"https://api.github.com/repos/sendgrid/smtpapi-go/commits{/sha}","git_commits_url":"https://api.github.com/repos/sendgrid/smtpapi-go/git/commits{/sha}","comments_url":"https://api.github.com/repos/sendgrid/smtpapi-go/comments{/number}","issue_comment_url":"https://api.github.com/repos/sendgrid/smtpapi-go/issues/comments{/number}","contents_url":"https://api.github.com/repos/sendgrid/smtpapi-go/contents/{+path}","compare_url":"https://api.github.com/repos/sendgrid/smtpapi-go/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sendgrid/smtpapi-go/merges","archive_url":"https://api.github.com/repos/sendgrid/smtpapi-go/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sendgrid/smtpapi-go/downloads","issues_url":"https://api.github.com/repos/sendgrid/smtpapi-go/issues{/number}","pulls_url":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls{/number}","milestones_url":"https://api.github.com/repos/sendgrid/smtpapi-go/milestones{/number}","notifications_url":"https://api.github.com/repos/sendgrid/smtpapi-go/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sendgrid/smtpapi-go/labels{/name}","releases_url":"https://api.github.com/repos/sendgrid/smtpapi-go/releases{/id}","deployments_url":"https://api.github.com/repos/sendgrid/smtpapi-go/deployments","created_at":"2013-12-21T23:27:47Z","updated_at":"2018-10-03T19:09:04Z","pushed_at":"2018-10-03T05:17:39Z","git_url":"git://github.com/sendgrid/smtpapi-go.git","ssh_url":"git@github.com:sendgrid/smtpapi-go.git","clone_url":"https://github.com/sendgrid/smtpapi-go.git","svn_url":"https://github.com/sendgrid/smtpapi-go","homepage":"https://sendgrid.com","size":85,"stargazers_count":19,"watchers_count":19,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":30,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":30,"open_issues":10,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/65"},"html":{"href":"https://github.com/sendgrid/smtpapi-go/pull/65"},"issue":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/issues/65"},"comments":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/issues/65/comments"},"review_comments":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/65/comments"},"review_comment":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/pulls/65/commits"},"statuses":{"href":"https://api.github.com/repos/sendgrid/smtpapi-go/statuses/eef1b804983fa119ac364379daa89d3b19dcd20d"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"extemporalgenome"}}