{"action":"created","comment":{"url":"https://api.github.com/repos/guzzle/psr7/pulls/comments/237120068","pull_request_review_id":179341354,"id":237120068,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzNzEyMDA2OA==","diff_hunk":"@@ -0,0 +1,121 @@\n+<?php\n+namespace GuzzleHttp\\Psr7;\n+\n+use Psr\\Http\\Message\\ResponseInterface;\n+\n+/**\n+ * Response emitter\n+ */\n+class ResponseEmitter\n+{\n+    /**\n+     * Emits a response.\n+     *\n+     * @param ResponseInterface $response A response to emit.\n+     * @param int $maxBufferSize Maximum output buffering size (pass 0 to emit all content at once).\n+     * @param bool $normalizeHeaders Normalize header names while emitting. For example: Content-type -> Content-Type.","path":"src/ResponseEmitter.php","position":16,"original_position":16,"commit_id":"3fc858fde37964ad2697cfa7d7eae0dd58765ada","original_commit_id":"3fc858fde37964ad2697cfa7d7eae0dd58765ada","user":{"login":"plashenkov","id":2331932,"node_id":"MDQ6VXNlcjIzMzE5MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2331932?v=4","gravatar_id":"","url":"https://api.github.com/users/plashenkov","html_url":"https://github.com/plashenkov","followers_url":"https://api.github.com/users/plashenkov/followers","following_url":"https://api.github.com/users/plashenkov/following{/other_user}","gists_url":"https://api.github.com/users/plashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/plashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plashenkov/subscriptions","organizations_url":"https://api.github.com/users/plashenkov/orgs","repos_url":"https://api.github.com/users/plashenkov/repos","events_url":"https://api.github.com/users/plashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/plashenkov/received_events","type":"User","site_admin":false},"body":"Yes, it looks like this is a standard here. This is a matter of dispute, strictly speaking. For example, here: https://github.com/guzzle/psr7/blob/master/src/Uri.php#L206-L209 and here: https://github.com/guzzle/psr7/blob/master/src/Uri.php#L247-L250 This is a code, not a PHPDoc, but the logic is the same. Somebody love to align all `===`, etc. When renaming any of variables or function names we need to realign everything every time. If we need to align, I'll do this for sure.\r\n\r\nP.S. https://github.com/guzzle/psr7/blob/master/src/PumpStream.php#L34-L41 This block needs fix :)","created_at":"2018-11-28T15:03:34Z","updated_at":"2018-11-28T15:03:34Z","html_url":"https://github.com/guzzle/psr7/pull/208#discussion_r237120068","pull_request_url":"https://api.github.com/repos/guzzle/psr7/pulls/208","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/guzzle/psr7/pulls/comments/237120068"},"html":{"href":"https://github.com/guzzle/psr7/pull/208#discussion_r237120068"},"pull_request":{"href":"https://api.github.com/repos/guzzle/psr7/pulls/208"}},"in_reply_to_id":236423905},"pull_request":{"url":"https://api.github.com/repos/guzzle/psr7/pulls/208","id":197471021,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDcxMDIx","html_url":"https://github.com/guzzle/psr7/pull/208","diff_url":"https://github.com/guzzle/psr7/pull/208.diff","patch_url":"https://github.com/guzzle/psr7/pull/208.patch","issue_url":"https://api.github.com/repos/guzzle/psr7/issues/208","number":208,"state":"open","locked":false,"title":"ResponseEmitter added","user":{"login":"plashenkov","id":2331932,"node_id":"MDQ6VXNlcjIzMzE5MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2331932?v=4","gravatar_id":"","url":"https://api.github.com/users/plashenkov","html_url":"https://github.com/plashenkov","followers_url":"https://api.github.com/users/plashenkov/followers","following_url":"https://api.github.com/users/plashenkov/following{/other_user}","gists_url":"https://api.github.com/users/plashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/plashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plashenkov/subscriptions","organizations_url":"https://api.github.com/users/plashenkov/orgs","repos_url":"https://api.github.com/users/plashenkov/repos","events_url":"https://api.github.com/users/plashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/plashenkov/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-06-26T15:51:18Z","updated_at":"2018-11-28T15:03:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3d18930e0096ef6a5fdff55cada4d10c1d1d5c67","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/guzzle/psr7/pulls/208/commits","review_comments_url":"https://api.github.com/repos/guzzle/psr7/pulls/208/comments","review_comment_url":"https://api.github.com/repos/guzzle/psr7/pulls/comments{/number}","comments_url":"https://api.github.com/repos/guzzle/psr7/issues/208/comments","statuses_url":"https://api.github.com/repos/guzzle/psr7/statuses/3fc858fde37964ad2697cfa7d7eae0dd58765ada","head":{"label":"plashenkov:master","ref":"master","sha":"3fc858fde37964ad2697cfa7d7eae0dd58765ada","user":{"login":"plashenkov","id":2331932,"node_id":"MDQ6VXNlcjIzMzE5MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2331932?v=4","gravatar_id":"","url":"https://api.github.com/users/plashenkov","html_url":"https://github.com/plashenkov","followers_url":"https://api.github.com/users/plashenkov/followers","following_url":"https://api.github.com/users/plashenkov/following{/other_user}","gists_url":"https://api.github.com/users/plashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/plashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plashenkov/subscriptions","organizations_url":"https://api.github.com/users/plashenkov/orgs","repos_url":"https://api.github.com/users/plashenkov/repos","events_url":"https://api.github.com/users/plashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/plashenkov/received_events","type":"User","site_admin":false},"repo":{"id":138662174,"node_id":"MDEwOlJlcG9zaXRvcnkxMzg2NjIxNzQ=","name":"psr7","full_name":"plashenkov/psr7","private":false,"owner":{"login":"plashenkov","id":2331932,"node_id":"MDQ6VXNlcjIzMzE5MzI=","avatar_url":"https://avatars3.githubusercontent.com/u/2331932?v=4","gravatar_id":"","url":"https://api.github.com/users/plashenkov","html_url":"https://github.com/plashenkov","followers_url":"https://api.github.com/users/plashenkov/followers","following_url":"https://api.github.com/users/plashenkov/following{/other_user}","gists_url":"https://api.github.com/users/plashenkov/gists{/gist_id}","starred_url":"https://api.github.com/users/plashenkov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/plashenkov/subscriptions","organizations_url":"https://api.github.com/users/plashenkov/orgs","repos_url":"https://api.github.com/users/plashenkov/repos","events_url":"https://api.github.com/users/plashenkov/events{/privacy}","received_events_url":"https://api.github.com/users/plashenkov/received_events","type":"User","site_admin":false},"html_url":"https://github.com/plashenkov/psr7","description":"PSR-7 HTTP message library","fork":true,"url":"https://api.github.com/repos/plashenkov/psr7","forks_url":"https://api.github.com/repos/plashenkov/psr7/forks","keys_url":"https://api.github.com/repos/plashenkov/psr7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/plashenkov/psr7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/plashenkov/psr7/teams","hooks_url":"https://api.github.com/repos/plashenkov/psr7/hooks","issue_events_url":"https://api.github.com/repos/plashenkov/psr7/issues/events{/number}","events_url":"https://api.github.com/repos/plashenkov/psr7/events","assignees_url":"https://api.github.com/repos/plashenkov/psr7/assignees{/user}","branches_url":"https://api.github.com/repos/plashenkov/psr7/branches{/branch}","tags_url":"https://api.github.com/repos/plashenkov/psr7/tags","blobs_url":"https://api.github.com/repos/plashenkov/psr7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/plashenkov/psr7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/plashenkov/psr7/git/refs{/sha}","trees_url":"https://api.github.com/repos/plashenkov/psr7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/plashenkov/psr7/statuses/{sha}","languages_url":"https://api.github.com/repos/plashenkov/psr7/languages","stargazers_url":"https://api.github.com/repos/plashenkov/psr7/stargazers","contributors_url":"https://api.github.com/repos/plashenkov/psr7/contributors","subscribers_url":"https://api.github.com/repos/plashenkov/psr7/subscribers","subscription_url":"https://api.github.com/repos/plashenkov/psr7/subscription","commits_url":"https://api.github.com/repos/plashenkov/psr7/commits{/sha}","git_commits_url":"https://api.github.com/repos/plashenkov/psr7/git/commits{/sha}","comments_url":"https://api.github.com/repos/plashenkov/psr7/comments{/number}","issue_comment_url":"https://api.github.com/repos/plashenkov/psr7/issues/comments{/number}","contents_url":"https://api.github.com/repos/plashenkov/psr7/contents/{+path}","compare_url":"https://api.github.com/repos/plashenkov/psr7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/plashenkov/psr7/merges","archive_url":"https://api.github.com/repos/plashenkov/psr7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/plashenkov/psr7/downloads","issues_url":"https://api.github.com/repos/plashenkov/psr7/issues{/number}","pulls_url":"https://api.github.com/repos/plashenkov/psr7/pulls{/number}","milestones_url":"https://api.github.com/repos/plashenkov/psr7/milestones{/number}","notifications_url":"https://api.github.com/repos/plashenkov/psr7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/plashenkov/psr7/labels{/name}","releases_url":"https://api.github.com/repos/plashenkov/psr7/releases{/id}","deployments_url":"https://api.github.com/repos/plashenkov/psr7/deployments","created_at":"2018-06-25T23:57:39Z","updated_at":"2018-06-26T15:47:53Z","pushed_at":"2018-06-26T15:47:51Z","git_url":"git://github.com/plashenkov/psr7.git","ssh_url":"git@github.com:plashenkov/psr7.git","clone_url":"https://github.com/plashenkov/psr7.git","svn_url":"https://github.com/plashenkov/psr7","homepage":"","size":374,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"guzzle:master","ref":"master","sha":"58f6e264ef0e4107c8b3d15a9c2e653b2bce0b4d","user":{"login":"guzzle","id":638632,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzODYzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/638632?v=4","gravatar_id":"","url":"https://api.github.com/users/guzzle","html_url":"https://github.com/guzzle","followers_url":"https://api.github.com/users/guzzle/followers","following_url":"https://api.github.com/users/guzzle/following{/other_user}","gists_url":"https://api.github.com/users/guzzle/gists{/gist_id}","starred_url":"https://api.github.com/users/guzzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guzzle/subscriptions","organizations_url":"https://api.github.com/users/guzzle/orgs","repos_url":"https://api.github.com/users/guzzle/repos","events_url":"https://api.github.com/users/guzzle/events{/privacy}","received_events_url":"https://api.github.com/users/guzzle/received_events","type":"Organization","site_admin":false},"repo":{"id":31295421,"node_id":"MDEwOlJlcG9zaXRvcnkzMTI5NTQyMQ==","name":"psr7","full_name":"guzzle/psr7","private":false,"owner":{"login":"guzzle","id":638632,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYzODYzMg==","avatar_url":"https://avatars0.githubusercontent.com/u/638632?v=4","gravatar_id":"","url":"https://api.github.com/users/guzzle","html_url":"https://github.com/guzzle","followers_url":"https://api.github.com/users/guzzle/followers","following_url":"https://api.github.com/users/guzzle/following{/other_user}","gists_url":"https://api.github.com/users/guzzle/gists{/gist_id}","starred_url":"https://api.github.com/users/guzzle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/guzzle/subscriptions","organizations_url":"https://api.github.com/users/guzzle/orgs","repos_url":"https://api.github.com/users/guzzle/repos","events_url":"https://api.github.com/users/guzzle/events{/privacy}","received_events_url":"https://api.github.com/users/guzzle/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/guzzle/psr7","description":"PSR-7 HTTP message library","fork":false,"url":"https://api.github.com/repos/guzzle/psr7","forks_url":"https://api.github.com/repos/guzzle/psr7/forks","keys_url":"https://api.github.com/repos/guzzle/psr7/keys{/key_id}","collaborators_url":"https://api.github.com/repos/guzzle/psr7/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/guzzle/psr7/teams","hooks_url":"https://api.github.com/repos/guzzle/psr7/hooks","issue_events_url":"https://api.github.com/repos/guzzle/psr7/issues/events{/number}","events_url":"https://api.github.com/repos/guzzle/psr7/events","assignees_url":"https://api.github.com/repos/guzzle/psr7/assignees{/user}","branches_url":"https://api.github.com/repos/guzzle/psr7/branches{/branch}","tags_url":"https://api.github.com/repos/guzzle/psr7/tags","blobs_url":"https://api.github.com/repos/guzzle/psr7/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/guzzle/psr7/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/guzzle/psr7/git/refs{/sha}","trees_url":"https://api.github.com/repos/guzzle/psr7/git/trees{/sha}","statuses_url":"https://api.github.com/repos/guzzle/psr7/statuses/{sha}","languages_url":"https://api.github.com/repos/guzzle/psr7/languages","stargazers_url":"https://api.github.com/repos/guzzle/psr7/stargazers","contributors_url":"https://api.github.com/repos/guzzle/psr7/contributors","subscribers_url":"https://api.github.com/repos/guzzle/psr7/subscribers","subscription_url":"https://api.github.com/repos/guzzle/psr7/subscription","commits_url":"https://api.github.com/repos/guzzle/psr7/commits{/sha}","git_commits_url":"https://api.github.com/repos/guzzle/psr7/git/commits{/sha}","comments_url":"https://api.github.com/repos/guzzle/psr7/comments{/number}","issue_comment_url":"https://api.github.com/repos/guzzle/psr7/issues/comments{/number}","contents_url":"https://api.github.com/repos/guzzle/psr7/contents/{+path}","compare_url":"https://api.github.com/repos/guzzle/psr7/compare/{base}...{head}","merges_url":"https://api.github.com/repos/guzzle/psr7/merges","archive_url":"https://api.github.com/repos/guzzle/psr7/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/guzzle/psr7/downloads","issues_url":"https://api.github.com/repos/guzzle/psr7/issues{/number}","pulls_url":"https://api.github.com/repos/guzzle/psr7/pulls{/number}","milestones_url":"https://api.github.com/repos/guzzle/psr7/milestones{/number}","notifications_url":"https://api.github.com/repos/guzzle/psr7/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/guzzle/psr7/labels{/name}","releases_url":"https://api.github.com/repos/guzzle/psr7/releases{/id}","deployments_url":"https://api.github.com/repos/guzzle/psr7/deployments","created_at":"2015-02-25T03:31:26Z","updated_at":"2018-11-28T13:36:58Z","pushed_at":"2018-11-27T15:43:05Z","git_url":"git://github.com/guzzle/psr7.git","ssh_url":"git@github.com:guzzle/psr7.git","clone_url":"https://github.com/guzzle/psr7.git","svn_url":"https://github.com/guzzle/psr7","homepage":"","size":405,"stargazers_count":3449,"watchers_count":3449,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":150,"mirror_url":null,"archived":false,"open_issues_count":22,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":150,"open_issues":22,"watchers":3449,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/guzzle/psr7/pulls/208"},"html":{"href":"https://github.com/guzzle/psr7/pull/208"},"issue":{"href":"https://api.github.com/repos/guzzle/psr7/issues/208"},"comments":{"href":"https://api.github.com/repos/guzzle/psr7/issues/208/comments"},"review_comments":{"href":"https://api.github.com/repos/guzzle/psr7/pulls/208/comments"},"review_comment":{"href":"https://api.github.com/repos/guzzle/psr7/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/guzzle/psr7/pulls/208/commits"},"statuses":{"href":"https://api.github.com/repos/guzzle/psr7/statuses/3fc858fde37964ad2697cfa7d7eae0dd58765ada"}},"author_association":"NONE"}}
{"actor":{"display_login":"plashenkov"}}