{"action":"created","comment":{"url":"https://api.github.com/repos/apache/spark/pulls/comments/175662764","pull_request_review_id":105226840,"id":175662764,"diff_hunk":"@@ -245,6 +245,17 @@ object SparkSubmit extends CommandLineUtils with Logging {\n       args: SparkSubmitArguments,\n       conf: Option[HadoopConfiguration] = None)\n       : (Seq[String], Seq[String], SparkConf, String) = {\n+    try {\n+      doPrepareSubmitEnvironment(args, conf)\n+    } catch {\n+      case e: SparkException => printErrorAndExit(e.getMessage); throw e","path":"core/src/main/scala/org/apache/spark/deploy/SparkSubmit.scala","position":7,"original_position":7,"commit_id":"8a124522519ed4f8fb750555f1a596c9f97b6947","original_commit_id":"8a124522519ed4f8fb750555f1a596c9f97b6947","user":{"login":"jiangxb1987","id":4784782,"avatar_url":"https://avatars1.githubusercontent.com/u/4784782?v=4","gravatar_id":"","url":"https://api.github.com/users/jiangxb1987","html_url":"https://github.com/jiangxb1987","followers_url":"https://api.github.com/users/jiangxb1987/followers","following_url":"https://api.github.com/users/jiangxb1987/following{/other_user}","gists_url":"https://api.github.com/users/jiangxb1987/gists{/gist_id}","starred_url":"https://api.github.com/users/jiangxb1987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jiangxb1987/subscriptions","organizations_url":"https://api.github.com/users/jiangxb1987/orgs","repos_url":"https://api.github.com/users/jiangxb1987/repos","events_url":"https://api.github.com/users/jiangxb1987/events{/privacy}","received_events_url":"https://api.github.com/users/jiangxb1987/received_events","type":"User","site_admin":false},"body":"nit:\r\n```\r\ncase e: SparkException =>\r\n    printErrorAndExit(e.getMessage)\r\n    throw e\r\n```","created_at":"2018-03-20T06:09:02Z","updated_at":"2018-03-20T06:09:02Z","html_url":"https://github.com/apache/spark/pull/20853#discussion_r175662764","pull_request_url":"https://api.github.com/repos/apache/spark/pulls/20853","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/comments/175662764"},"html":{"href":"https://github.com/apache/spark/pull/20853#discussion_r175662764"},"pull_request":{"href":"https://api.github.com/repos/apache/spark/pulls/20853"}}},"pull_request":{"url":"https://api.github.com/repos/apache/spark/pulls/20853","id":175737111,"html_url":"https://github.com/apache/spark/pull/20853","diff_url":"https://github.com/apache/spark/pull/20853.diff","patch_url":"https://github.com/apache/spark/pull/20853.patch","issue_url":"https://api.github.com/repos/apache/spark/issues/20853","number":20853,"state":"open","locked":false,"title":"[SPARK-23729][CORE] Respect URI fragment when resolving globs","user":{"login":"misutoth","id":7244068,"avatar_url":"https://avatars3.githubusercontent.com/u/7244068?v=4","gravatar_id":"","url":"https://api.github.com/users/misutoth","html_url":"https://github.com/misutoth","followers_url":"https://api.github.com/users/misutoth/followers","following_url":"https://api.github.com/users/misutoth/following{/other_user}","gists_url":"https://api.github.com/users/misutoth/gists{/gist_id}","starred_url":"https://api.github.com/users/misutoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misutoth/subscriptions","organizations_url":"https://api.github.com/users/misutoth/orgs","repos_url":"https://api.github.com/users/misutoth/repos","events_url":"https://api.github.com/users/misutoth/events{/privacy}","received_events_url":"https://api.github.com/users/misutoth/received_events","type":"User","site_admin":false},"body":"## What changes were proposed in this pull request?\r\n\r\nFirstly, glob resolution will not result in swallowing the remote name part (that is preceded by the `#` sign) in case of `--files` or `--archives` options\r\n\r\nMoreover in the special case of multiple resolutions when the remote naming does not make sense and error is returned.\r\n## How was this patch tested?\r\n\r\nEnhanced current test and wrote additional test for the error case","created_at":"2018-03-18T06:14:37Z","updated_at":"2018-03-20T06:09:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4b8b8611c5f0682906784255a03fd525b3153d39","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/apache/spark/pulls/20853/commits","review_comments_url":"https://api.github.com/repos/apache/spark/pulls/20853/comments","review_comment_url":"https://api.github.com/repos/apache/spark/pulls/comments{/number}","comments_url":"https://api.github.com/repos/apache/spark/issues/20853/comments","statuses_url":"https://api.github.com/repos/apache/spark/statuses/8a124522519ed4f8fb750555f1a596c9f97b6947","head":{"label":"misutoth:glob-with-remote-name","ref":"glob-with-remote-name","sha":"8a124522519ed4f8fb750555f1a596c9f97b6947","user":{"login":"misutoth","id":7244068,"avatar_url":"https://avatars3.githubusercontent.com/u/7244068?v=4","gravatar_id":"","url":"https://api.github.com/users/misutoth","html_url":"https://github.com/misutoth","followers_url":"https://api.github.com/users/misutoth/followers","following_url":"https://api.github.com/users/misutoth/following{/other_user}","gists_url":"https://api.github.com/users/misutoth/gists{/gist_id}","starred_url":"https://api.github.com/users/misutoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misutoth/subscriptions","organizations_url":"https://api.github.com/users/misutoth/orgs","repos_url":"https://api.github.com/users/misutoth/repos","events_url":"https://api.github.com/users/misutoth/events{/privacy}","received_events_url":"https://api.github.com/users/misutoth/received_events","type":"User","site_admin":false},"repo":{"id":119835914,"name":"spark","full_name":"misutoth/spark","owner":{"login":"misutoth","id":7244068,"avatar_url":"https://avatars3.githubusercontent.com/u/7244068?v=4","gravatar_id":"","url":"https://api.github.com/users/misutoth","html_url":"https://github.com/misutoth","followers_url":"https://api.github.com/users/misutoth/followers","following_url":"https://api.github.com/users/misutoth/following{/other_user}","gists_url":"https://api.github.com/users/misutoth/gists{/gist_id}","starred_url":"https://api.github.com/users/misutoth/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/misutoth/subscriptions","organizations_url":"https://api.github.com/users/misutoth/orgs","repos_url":"https://api.github.com/users/misutoth/repos","events_url":"https://api.github.com/users/misutoth/events{/privacy}","received_events_url":"https://api.github.com/users/misutoth/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/misutoth/spark","description":"Mirror of Apache Spark","fork":true,"url":"https://api.github.com/repos/misutoth/spark","forks_url":"https://api.github.com/repos/misutoth/spark/forks","keys_url":"https://api.github.com/repos/misutoth/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/misutoth/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/misutoth/spark/teams","hooks_url":"https://api.github.com/repos/misutoth/spark/hooks","issue_events_url":"https://api.github.com/repos/misutoth/spark/issues/events{/number}","events_url":"https://api.github.com/repos/misutoth/spark/events","assignees_url":"https://api.github.com/repos/misutoth/spark/assignees{/user}","branches_url":"https://api.github.com/repos/misutoth/spark/branches{/branch}","tags_url":"https://api.github.com/repos/misutoth/spark/tags","blobs_url":"https://api.github.com/repos/misutoth/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/misutoth/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/misutoth/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/misutoth/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/misutoth/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/misutoth/spark/languages","stargazers_url":"https://api.github.com/repos/misutoth/spark/stargazers","contributors_url":"https://api.github.com/repos/misutoth/spark/contributors","subscribers_url":"https://api.github.com/repos/misutoth/spark/subscribers","subscription_url":"https://api.github.com/repos/misutoth/spark/subscription","commits_url":"https://api.github.com/repos/misutoth/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/misutoth/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/misutoth/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/misutoth/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/misutoth/spark/contents/{+path}","compare_url":"https://api.github.com/repos/misutoth/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/misutoth/spark/merges","archive_url":"https://api.github.com/repos/misutoth/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/misutoth/spark/downloads","issues_url":"https://api.github.com/repos/misutoth/spark/issues{/number}","pulls_url":"https://api.github.com/repos/misutoth/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/misutoth/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/misutoth/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/misutoth/spark/labels{/name}","releases_url":"https://api.github.com/repos/misutoth/spark/releases{/id}","deployments_url":"https://api.github.com/repos/misutoth/spark/deployments","created_at":"2018-02-01T12:57:08Z","updated_at":"2018-02-01T12:57:36Z","pushed_at":"2018-03-19T23:05:21Z","git_url":"git://github.com/misutoth/spark.git","ssh_url":"git@github.com:misutoth/spark.git","clone_url":"https://github.com/misutoth/spark.git","svn_url":"https://github.com/misutoth/spark","homepage":null,"size":269150,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"apache:master","ref":"master","sha":"8a1efe3076f29259151f1fba2ff894487efb6c4e","user":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"repo":{"id":17165658,"name":"spark","full_name":"apache/spark","owner":{"login":"apache","id":47359,"avatar_url":"https://avatars0.githubusercontent.com/u/47359?v=4","gravatar_id":"","url":"https://api.github.com/users/apache","html_url":"https://github.com/apache","followers_url":"https://api.github.com/users/apache/followers","following_url":"https://api.github.com/users/apache/following{/other_user}","gists_url":"https://api.github.com/users/apache/gists{/gist_id}","starred_url":"https://api.github.com/users/apache/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apache/subscriptions","organizations_url":"https://api.github.com/users/apache/orgs","repos_url":"https://api.github.com/users/apache/repos","events_url":"https://api.github.com/users/apache/events{/privacy}","received_events_url":"https://api.github.com/users/apache/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/apache/spark","description":"Mirror of Apache Spark","fork":false,"url":"https://api.github.com/repos/apache/spark","forks_url":"https://api.github.com/repos/apache/spark/forks","keys_url":"https://api.github.com/repos/apache/spark/keys{/key_id}","collaborators_url":"https://api.github.com/repos/apache/spark/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/apache/spark/teams","hooks_url":"https://api.github.com/repos/apache/spark/hooks","issue_events_url":"https://api.github.com/repos/apache/spark/issues/events{/number}","events_url":"https://api.github.com/repos/apache/spark/events","assignees_url":"https://api.github.com/repos/apache/spark/assignees{/user}","branches_url":"https://api.github.com/repos/apache/spark/branches{/branch}","tags_url":"https://api.github.com/repos/apache/spark/tags","blobs_url":"https://api.github.com/repos/apache/spark/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/apache/spark/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/apache/spark/git/refs{/sha}","trees_url":"https://api.github.com/repos/apache/spark/git/trees{/sha}","statuses_url":"https://api.github.com/repos/apache/spark/statuses/{sha}","languages_url":"https://api.github.com/repos/apache/spark/languages","stargazers_url":"https://api.github.com/repos/apache/spark/stargazers","contributors_url":"https://api.github.com/repos/apache/spark/contributors","subscribers_url":"https://api.github.com/repos/apache/spark/subscribers","subscription_url":"https://api.github.com/repos/apache/spark/subscription","commits_url":"https://api.github.com/repos/apache/spark/commits{/sha}","git_commits_url":"https://api.github.com/repos/apache/spark/git/commits{/sha}","comments_url":"https://api.github.com/repos/apache/spark/comments{/number}","issue_comment_url":"https://api.github.com/repos/apache/spark/issues/comments{/number}","contents_url":"https://api.github.com/repos/apache/spark/contents/{+path}","compare_url":"https://api.github.com/repos/apache/spark/compare/{base}...{head}","merges_url":"https://api.github.com/repos/apache/spark/merges","archive_url":"https://api.github.com/repos/apache/spark/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/apache/spark/downloads","issues_url":"https://api.github.com/repos/apache/spark/issues{/number}","pulls_url":"https://api.github.com/repos/apache/spark/pulls{/number}","milestones_url":"https://api.github.com/repos/apache/spark/milestones{/number}","notifications_url":"https://api.github.com/repos/apache/spark/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/apache/spark/labels{/name}","releases_url":"https://api.github.com/repos/apache/spark/releases{/id}","deployments_url":"https://api.github.com/repos/apache/spark/deployments","created_at":"2014-02-25T08:00:08Z","updated_at":"2018-03-20T04:29:24Z","pushed_at":"2018-03-20T05:50:19Z","git_url":"git://github.com/apache/spark.git","ssh_url":"git@github.com:apache/spark.git","clone_url":"https://github.com/apache/spark.git","svn_url":"https://github.com/apache/spark","homepage":null,"size":269630,"stargazers_count":16564,"watchers_count":16564,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":15239,"mirror_url":null,"archived":false,"open_issues_count":480,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15239,"open_issues":480,"watchers":16564,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/apache/spark/pulls/20853"},"html":{"href":"https://github.com/apache/spark/pull/20853"},"issue":{"href":"https://api.github.com/repos/apache/spark/issues/20853"},"comments":{"href":"https://api.github.com/repos/apache/spark/issues/20853/comments"},"review_comments":{"href":"https://api.github.com/repos/apache/spark/pulls/20853/comments"},"review_comment":{"href":"https://api.github.com/repos/apache/spark/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/apache/spark/pulls/20853/commits"},"statuses":{"href":"https://api.github.com/repos/apache/spark/statuses/8a124522519ed4f8fb750555f1a596c9f97b6947"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jiangxb1987"}}