{"action":"created","issue":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/2699","repository_url":"https://api.github.com/repos/PCSX2/pcsx2","labels_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/2699/labels{/name}","comments_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/2699/comments","events_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/2699/events","html_url":"https://github.com/PCSX2/pcsx2/issues/2699","id":382768665,"node_id":"MDU6SXNzdWUzODI3Njg2NjU=","number":2699,"title":"cmake: Installation issues.","user":{"login":"orbea","id":4204285,"node_id":"MDQ6VXNlcjQyMDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4204285?v=4","gravatar_id":"","url":"https://api.github.com/users/orbea","html_url":"https://github.com/orbea","followers_url":"https://api.github.com/users/orbea/followers","following_url":"https://api.github.com/users/orbea/following{/other_user}","gists_url":"https://api.github.com/users/orbea/gists{/gist_id}","starred_url":"https://api.github.com/users/orbea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbea/subscriptions","organizations_url":"https://api.github.com/users/orbea/orgs","repos_url":"https://api.github.com/users/orbea/repos","events_url":"https://api.github.com/users/orbea/events{/privacy}","received_events_url":"https://api.github.com/users/orbea/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":16,"created_at":"2018-11-20T17:19:37Z","updated_at":"2018-12-13T18:30:05Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"***PCSX2 version:***\r\nhttps://github.com/PCSX2/pcsx2/commit/651d287f1da5047cda12ae81de832755c70aaef5\r\n\r\n***Description of the issue:***\r\n\r\nThe following code in `pcsx2/CMakeLists.txt` has the following three problems, the first one is critical and makes it entirely non-working.\r\n\r\nhttps://github.com/PCSX2/pcsx2/blob/651d287f1da5047cda12ae81de832755c70aaef5/pcsx2/CMakeLists.txt#L713\r\n\r\n1. It is modifying `${BIN_DIR}/PCSX2` (`/usr/bin/PCSX2`) and not `$DESTDIR/${BIN_DIR}/PCSX2`, if `${BIN_DIR}/PCSX2` is not already installed on the system then it will fail. This results in modifying the old file to be replaced and not the new file to be installed. This can never work because `cmake` does not know the value of `${DESTDIR}` and only `make/ninja/samu/etc.` do. The alternative would be to modify it before its installed, but there doesn't seem to be a good place to do this without modifying `add_pcsx2_executable` in `cmake/Pcsx2Utils.cmake` to not actually install the files which would be messy.\r\n2. Not all users have `/bin/bash`, but it should be entirely safe to use `/bin/sh` here as even with true bourne shells such as `hsh` this should work.\r\n3. Not all users have `sudo` and using `sudo` inside of a cmake installation is a really terrible thing from a package management perspective.\r\n\r\n***Last known version to work:***\r\nThis was introduced in PR https://github.com/PCSX2/pcsx2/pull/2586.\r\n\r\n***PC specifications:***\r\nOS: `Slackware64-current`\r\n`cmake-3.12.4`\r\n"},"comment":{"url":"https://api.github.com/repos/PCSX2/pcsx2/issues/comments/447071845","html_url":"https://github.com/PCSX2/pcsx2/issues/2699#issuecomment-447071845","issue_url":"https://api.github.com/repos/PCSX2/pcsx2/issues/2699","id":447071845,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzA3MTg0NQ==","user":{"login":"orbea","id":4204285,"node_id":"MDQ6VXNlcjQyMDQyODU=","avatar_url":"https://avatars2.githubusercontent.com/u/4204285?v=4","gravatar_id":"","url":"https://api.github.com/users/orbea","html_url":"https://github.com/orbea","followers_url":"https://api.github.com/users/orbea/followers","following_url":"https://api.github.com/users/orbea/following{/other_user}","gists_url":"https://api.github.com/users/orbea/gists{/gist_id}","starred_url":"https://api.github.com/users/orbea/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/orbea/subscriptions","organizations_url":"https://api.github.com/users/orbea/orgs","repos_url":"https://api.github.com/users/orbea/repos","events_url":"https://api.github.com/users/orbea/events{/privacy}","received_events_url":"https://api.github.com/users/orbea/received_events","type":"User","site_admin":false},"created_at":"2018-12-13T18:30:05Z","updated_at":"2018-12-13T18:30:05Z","author_association":"CONTRIBUTOR","body":"Which plugin in specifically?"}}
{"actor":{"display_login":"orbea"}}