{"action":"created","comment":{"url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/comments/171862635","pull_request_review_id":100793040,"id":171862635,"diff_hunk":"@@ -154,7 +155,8 @@ public void showProgress(boolean show) {\n \n     @Override\n     public void onSuccess(String message) {\n-        ViewUtils.showSnackbar(binding.getRoot(), message);\n+        Toast.makeText(getActivity(), message, Toast.LENGTH_SHORT).show();\n+        getActivity().finish();","path":"app/src/main/java/org/fossasia/openevent/app/module/event/create/CreateEventFragment.java","position":14,"original_position":14,"commit_id":"a17a9046d85bde9612bd2e58a517f7685e31d067","original_commit_id":"a17a9046d85bde9612bd2e58a517f7685e31d067","user":{"login":"iamareebjamal","id":3874064,"avatar_url":"https://avatars0.githubusercontent.com/u/3874064?v=4","gravatar_id":"","url":"https://api.github.com/users/iamareebjamal","html_url":"https://github.com/iamareebjamal","followers_url":"https://api.github.com/users/iamareebjamal/followers","following_url":"https://api.github.com/users/iamareebjamal/following{/other_user}","gists_url":"https://api.github.com/users/iamareebjamal/gists{/gist_id}","starred_url":"https://api.github.com/users/iamareebjamal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iamareebjamal/subscriptions","organizations_url":"https://api.github.com/users/iamareebjamal/orgs","repos_url":"https://api.github.com/users/iamareebjamal/repos","events_url":"https://api.github.com/users/iamareebjamal/events{/privacy}","received_events_url":"https://api.github.com/users/iamareebjamal/received_events","type":"User","site_admin":false},"body":"Rather than closing in `onSuccess` create a new method in view contract called `close` and call it in the presenter, so that we can test the behaviour","created_at":"2018-03-02T14:36:59Z","updated_at":"2018-03-02T14:37:04Z","html_url":"https://github.com/fossasia/open-event-orga-app/pull/688#discussion_r171862635","pull_request_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/688","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/comments/171862635"},"html":{"href":"https://github.com/fossasia/open-event-orga-app/pull/688#discussion_r171862635"},"pull_request":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/688"}}},"pull_request":{"url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/688","id":172478683,"html_url":"https://github.com/fossasia/open-event-orga-app/pull/688","diff_url":"https://github.com/fossasia/open-event-orga-app/pull/688.diff","patch_url":"https://github.com/fossasia/open-event-orga-app/pull/688.patch","issue_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/688","number":688,"state":"open","locked":false,"title":"fix: Create Event Activity will finish after event is created","user":{"login":"leeyh20","id":7023320,"avatar_url":"https://avatars3.githubusercontent.com/u/7023320?v=4","gravatar_id":"","url":"https://api.github.com/users/leeyh20","html_url":"https://github.com/leeyh20","followers_url":"https://api.github.com/users/leeyh20/followers","following_url":"https://api.github.com/users/leeyh20/following{/other_user}","gists_url":"https://api.github.com/users/leeyh20/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyh20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyh20/subscriptions","organizations_url":"https://api.github.com/users/leeyh20/orgs","repos_url":"https://api.github.com/users/leeyh20/repos","events_url":"https://api.github.com/users/leeyh20/events{/privacy}","received_events_url":"https://api.github.com/users/leeyh20/received_events","type":"User","site_admin":false},"body":"Fixes #613 \r\n\r\nChanges: Create Event Activity will finish and send an intent to the fragment that started that activity, which is EventListFragment. (However, EventListFragment's parent activity is MainActivity, thus the intent will first be passed to the MainActivity) EventListFragment will then know that creating the event was successful as its onActivityResult function will be called.\r\n\r\nEdit: Now just shows a toast instead.\r\n\r\nScreenshots for the change: \r\nIn this GIF, we create an event named \"lol\"\r\n![createevent](https://user-images.githubusercontent.com/7023320/36901104-cfe668e6-1e60-11e8-9d38-0697ae2e9dfc.gif)\r\n\r\n@srv-twry @iamareebjamal Could you help me to review this?\r\nHowever, EventListFragment does not automatically refresh after the event is created. I have tried calling the function `getPresenter().loadUserEvents(true)` inside onActivityResult to try to refresh the events list, but to no avail. Is there a way to refresh without the user having to swipe?\r\n","created_at":"2018-03-02T11:16:09Z","updated_at":"2018-03-02T14:37:04Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d5c8d98f5282696b14556265b70b3c3373d27580","assignee":{"login":"leeyh20","id":7023320,"avatar_url":"https://avatars3.githubusercontent.com/u/7023320?v=4","gravatar_id":"","url":"https://api.github.com/users/leeyh20","html_url":"https://github.com/leeyh20","followers_url":"https://api.github.com/users/leeyh20/followers","following_url":"https://api.github.com/users/leeyh20/following{/other_user}","gists_url":"https://api.github.com/users/leeyh20/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyh20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyh20/subscriptions","organizations_url":"https://api.github.com/users/leeyh20/orgs","repos_url":"https://api.github.com/users/leeyh20/repos","events_url":"https://api.github.com/users/leeyh20/events{/privacy}","received_events_url":"https://api.github.com/users/leeyh20/received_events","type":"User","site_admin":false},"assignees":[{"login":"leeyh20","id":7023320,"avatar_url":"https://avatars3.githubusercontent.com/u/7023320?v=4","gravatar_id":"","url":"https://api.github.com/users/leeyh20","html_url":"https://github.com/leeyh20","followers_url":"https://api.github.com/users/leeyh20/followers","following_url":"https://api.github.com/users/leeyh20/following{/other_user}","gists_url":"https://api.github.com/users/leeyh20/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyh20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyh20/subscriptions","organizations_url":"https://api.github.com/users/leeyh20/orgs","repos_url":"https://api.github.com/users/leeyh20/repos","events_url":"https://api.github.com/users/leeyh20/events{/privacy}","received_events_url":"https://api.github.com/users/leeyh20/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":634391022,"url":"https://api.github.com/repos/fossasia/open-event-orga-app/labels/needs-review","name":"needs-review","color":"fef2c0","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/688/commits","review_comments_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/688/comments","review_comment_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/688/comments","statuses_url":"https://api.github.com/repos/fossasia/open-event-orga-app/statuses/a17a9046d85bde9612bd2e58a517f7685e31d067","head":{"label":"leeyh20:finish-create-event-activity","ref":"finish-create-event-activity","sha":"a17a9046d85bde9612bd2e58a517f7685e31d067","user":{"login":"leeyh20","id":7023320,"avatar_url":"https://avatars3.githubusercontent.com/u/7023320?v=4","gravatar_id":"","url":"https://api.github.com/users/leeyh20","html_url":"https://github.com/leeyh20","followers_url":"https://api.github.com/users/leeyh20/followers","following_url":"https://api.github.com/users/leeyh20/following{/other_user}","gists_url":"https://api.github.com/users/leeyh20/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyh20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyh20/subscriptions","organizations_url":"https://api.github.com/users/leeyh20/orgs","repos_url":"https://api.github.com/users/leeyh20/repos","events_url":"https://api.github.com/users/leeyh20/events{/privacy}","received_events_url":"https://api.github.com/users/leeyh20/received_events","type":"User","site_admin":false},"repo":{"id":122367112,"name":"open-event-orga-app","full_name":"leeyh20/open-event-orga-app","owner":{"login":"leeyh20","id":7023320,"avatar_url":"https://avatars3.githubusercontent.com/u/7023320?v=4","gravatar_id":"","url":"https://api.github.com/users/leeyh20","html_url":"https://github.com/leeyh20","followers_url":"https://api.github.com/users/leeyh20/followers","following_url":"https://api.github.com/users/leeyh20/following{/other_user}","gists_url":"https://api.github.com/users/leeyh20/gists{/gist_id}","starred_url":"https://api.github.com/users/leeyh20/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/leeyh20/subscriptions","organizations_url":"https://api.github.com/users/leeyh20/orgs","repos_url":"https://api.github.com/users/leeyh20/repos","events_url":"https://api.github.com/users/leeyh20/events{/privacy}","received_events_url":"https://api.github.com/users/leeyh20/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/leeyh20/open-event-orga-app","description":"Open Event Mobile App for Organizers and Entry Managers https://github.com/fossasia/open-event-orga-app/raw/apk/test-app-debug.apk","fork":true,"url":"https://api.github.com/repos/leeyh20/open-event-orga-app","forks_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/forks","keys_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/teams","hooks_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/hooks","issue_events_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/issues/events{/number}","events_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/events","assignees_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/assignees{/user}","branches_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/branches{/branch}","tags_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/tags","blobs_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/statuses/{sha}","languages_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/languages","stargazers_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/stargazers","contributors_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/contributors","subscribers_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/subscribers","subscription_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/subscription","commits_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/contents/{+path}","compare_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/merges","archive_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/downloads","issues_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/issues{/number}","pulls_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/pulls{/number}","milestones_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/milestones{/number}","notifications_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/labels{/name}","releases_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/releases{/id}","deployments_url":"https://api.github.com/repos/leeyh20/open-event-orga-app/deployments","created_at":"2018-02-21T17:11:59Z","updated_at":"2018-02-21T17:12:01Z","pushed_at":"2018-03-02T13:48:05Z","git_url":"git://github.com/leeyh20/open-event-orga-app.git","ssh_url":"git@github.com:leeyh20/open-event-orga-app.git","clone_url":"https://github.com/leeyh20/open-event-orga-app.git","svn_url":"https://github.com/leeyh20/open-event-orga-app","homepage":"","size":18676,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"development"}},"base":{"label":"fossasia:development","ref":"development","sha":"9744fc8073a8db4725ee05ecedacc15e3a7f3631","user":{"login":"fossasia","id":6295529,"avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"repo":{"id":65606855,"name":"open-event-orga-app","full_name":"fossasia/open-event-orga-app","owner":{"login":"fossasia","id":6295529,"avatar_url":"https://avatars3.githubusercontent.com/u/6295529?v=4","gravatar_id":"","url":"https://api.github.com/users/fossasia","html_url":"https://github.com/fossasia","followers_url":"https://api.github.com/users/fossasia/followers","following_url":"https://api.github.com/users/fossasia/following{/other_user}","gists_url":"https://api.github.com/users/fossasia/gists{/gist_id}","starred_url":"https://api.github.com/users/fossasia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fossasia/subscriptions","organizations_url":"https://api.github.com/users/fossasia/orgs","repos_url":"https://api.github.com/users/fossasia/repos","events_url":"https://api.github.com/users/fossasia/events{/privacy}","received_events_url":"https://api.github.com/users/fossasia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fossasia/open-event-orga-app","description":"Open Event Mobile App for Organizers and Entry Managers https://github.com/fossasia/open-event-orga-app/raw/apk/test-app-debug.apk","fork":false,"url":"https://api.github.com/repos/fossasia/open-event-orga-app","forks_url":"https://api.github.com/repos/fossasia/open-event-orga-app/forks","keys_url":"https://api.github.com/repos/fossasia/open-event-orga-app/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fossasia/open-event-orga-app/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fossasia/open-event-orga-app/teams","hooks_url":"https://api.github.com/repos/fossasia/open-event-orga-app/hooks","issue_events_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/events{/number}","events_url":"https://api.github.com/repos/fossasia/open-event-orga-app/events","assignees_url":"https://api.github.com/repos/fossasia/open-event-orga-app/assignees{/user}","branches_url":"https://api.github.com/repos/fossasia/open-event-orga-app/branches{/branch}","tags_url":"https://api.github.com/repos/fossasia/open-event-orga-app/tags","blobs_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/refs{/sha}","trees_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fossasia/open-event-orga-app/statuses/{sha}","languages_url":"https://api.github.com/repos/fossasia/open-event-orga-app/languages","stargazers_url":"https://api.github.com/repos/fossasia/open-event-orga-app/stargazers","contributors_url":"https://api.github.com/repos/fossasia/open-event-orga-app/contributors","subscribers_url":"https://api.github.com/repos/fossasia/open-event-orga-app/subscribers","subscription_url":"https://api.github.com/repos/fossasia/open-event-orga-app/subscription","commits_url":"https://api.github.com/repos/fossasia/open-event-orga-app/commits{/sha}","git_commits_url":"https://api.github.com/repos/fossasia/open-event-orga-app/git/commits{/sha}","comments_url":"https://api.github.com/repos/fossasia/open-event-orga-app/comments{/number}","issue_comment_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/comments{/number}","contents_url":"https://api.github.com/repos/fossasia/open-event-orga-app/contents/{+path}","compare_url":"https://api.github.com/repos/fossasia/open-event-orga-app/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fossasia/open-event-orga-app/merges","archive_url":"https://api.github.com/repos/fossasia/open-event-orga-app/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fossasia/open-event-orga-app/downloads","issues_url":"https://api.github.com/repos/fossasia/open-event-orga-app/issues{/number}","pulls_url":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls{/number}","milestones_url":"https://api.github.com/repos/fossasia/open-event-orga-app/milestones{/number}","notifications_url":"https://api.github.com/repos/fossasia/open-event-orga-app/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fossasia/open-event-orga-app/labels{/name}","releases_url":"https://api.github.com/repos/fossasia/open-event-orga-app/releases{/id}","deployments_url":"https://api.github.com/repos/fossasia/open-event-orga-app/deployments","created_at":"2016-08-13T08:08:39Z","updated_at":"2018-03-02T04:32:12Z","pushed_at":"2018-03-02T14:30:46Z","git_url":"git://github.com/fossasia/open-event-orga-app.git","ssh_url":"git@github.com:fossasia/open-event-orga-app.git","clone_url":"https://github.com/fossasia/open-event-orga-app.git","svn_url":"https://github.com/fossasia/open-event-orga-app","homepage":"","size":18675,"stargazers_count":331,"watchers_count":331,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":103,"mirror_url":null,"archived":false,"open_issues_count":64,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":103,"open_issues":64,"watchers":331,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/688"},"html":{"href":"https://github.com/fossasia/open-event-orga-app/pull/688"},"issue":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/688"},"comments":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/issues/688/comments"},"review_comments":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/688/comments"},"review_comment":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/pulls/688/commits"},"statuses":{"href":"https://api.github.com/repos/fossasia/open-event-orga-app/statuses/a17a9046d85bde9612bd2e58a517f7685e31d067"}},"author_association":"NONE"}}
{"actor":{"display_login":"iamareebjamal"}}