{"action":"created","comment":{"url":"https://api.github.com/repos/ngageoint/opensphere/pulls/comments/233883063","pull_request_review_id":175399442,"id":233883063,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzg4MzA2Mw==","diff_hunk":"@@ -29,50 +39,51 @@ os.ui.menu.map.setup = function() {\n     children: [{\n       label: 'Map',\n       type: os.ui.menu.MenuItemType.GROUP,\n+      sort: os.ui.menu.map.GroupSort.GROUPS++,","path":"src/os/ui/menu/mapmenu.js","position":21,"original_position":21,"commit_id":"088c26719e74a613367b82dc8922bce2463761ed","original_commit_id":"088c26719e74a613367b82dc8922bce2463761ed","user":{"login":"schmidtk","id":5685437,"node_id":"MDQ6VXNlcjU2ODU0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5685437?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidtk","html_url":"https://github.com/schmidtk","followers_url":"https://api.github.com/users/schmidtk/followers","following_url":"https://api.github.com/users/schmidtk/following{/other_user}","gists_url":"https://api.github.com/users/schmidtk/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidtk/subscriptions","organizations_url":"https://api.github.com/users/schmidtk/orgs","repos_url":"https://api.github.com/users/schmidtk/repos","events_url":"https://api.github.com/users/schmidtk/events{/privacy}","received_events_url":"https://api.github.com/users/schmidtk/received_events","type":"User","site_admin":false},"body":"Fair point. I suppose it also makes the order for plugin menu items dependent on plugin load order... also bad. I'll switch back to the hard coded values and use fixed values for the group sort as well.","created_at":"2018-11-15T15:16:11Z","updated_at":"2018-11-15T15:16:12Z","html_url":"https://github.com/ngageoint/opensphere/pull/331#discussion_r233883063","pull_request_url":"https://api.github.com/repos/ngageoint/opensphere/pulls/331","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ngageoint/opensphere/pulls/comments/233883063"},"html":{"href":"https://github.com/ngageoint/opensphere/pull/331#discussion_r233883063"},"pull_request":{"href":"https://api.github.com/repos/ngageoint/opensphere/pulls/331"}},"in_reply_to_id":233879274},"pull_request":{"url":"https://api.github.com/repos/ngageoint/opensphere/pulls/331","id":227466109,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDY2MTA5","html_url":"https://github.com/ngageoint/opensphere/pull/331","diff_url":"https://github.com/ngageoint/opensphere/pull/331.diff","patch_url":"https://github.com/ngageoint/opensphere/pull/331.patch","issue_url":"https://api.github.com/repos/ngageoint/opensphere/issues/331","number":331,"state":"open","locked":false,"title":"Add annotations to Saved Places","user":{"login":"schmidtk","id":5685437,"node_id":"MDQ6VXNlcjU2ODU0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5685437?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidtk","html_url":"https://github.com/schmidtk","followers_url":"https://api.github.com/users/schmidtk/followers","following_url":"https://api.github.com/users/schmidtk/following{/other_user}","gists_url":"https://api.github.com/users/schmidtk/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidtk/subscriptions","organizations_url":"https://api.github.com/users/schmidtk/orgs","repos_url":"https://api.github.com/users/schmidtk/repos","events_url":"https://api.github.com/users/schmidtk/events{/privacy}","received_events_url":"https://api.github.com/users/schmidtk/received_events","type":"User","site_admin":false},"body":"Latest build can be tested here:\r\nhttps://schmidtk.github.io/annotations/\r\n\r\nThis adds map annotations to Saved Places. Currently supported:\r\n- Create annotations and persist across sessions.\r\n- Sync between 2D/3D.\r\n- Annotations are included in screen capture (screenshots and recordings).\r\n- KML BalloonStyle rendered as an annotation.\r\n- Annotations exported to KML BalloonStyle for display in Google Earth.\r\n\r\nGeneral OpenSphere changes:\r\n- `plugin.cesium.CesiumRenderer#getCoordinateFromPixel` now picks the globe instead of the ellipsoid. This provides a more accurate coordinate (with altitude) when terrain is enabled.\r\n- `os.webgl.IWebGLRenderer#getPixelFromCoordinate` now takes an optional param to test if the coordinate is in view. If not, `null` is returned. This has been implemented in the Cesium renderer.\r\n- `plugin.capture.MapOverlayRenderer` now renders `ol.Overlay` instances. The original class has been renamed to `plugin.capture.MapOverviewRenderer`, to align with OpenLayers terms.\r\n\r\nTODO:\r\n- [x] Merge #315 and display annotations for KML balloons.\r\n- [x] Fix 3D sync when annotations are created outside the current view.\r\n- [x] Export annotations to KML for display in Google Earth.","created_at":"2018-10-31T22:54:30Z","updated_at":"2018-11-15T15:16:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"6aea85c09e74aad1129ad07992e571c4ed56984d","assignee":{"login":"schmidtk","id":5685437,"node_id":"MDQ6VXNlcjU2ODU0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5685437?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidtk","html_url":"https://github.com/schmidtk","followers_url":"https://api.github.com/users/schmidtk/followers","following_url":"https://api.github.com/users/schmidtk/following{/other_user}","gists_url":"https://api.github.com/users/schmidtk/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidtk/subscriptions","organizations_url":"https://api.github.com/users/schmidtk/orgs","repos_url":"https://api.github.com/users/schmidtk/repos","events_url":"https://api.github.com/users/schmidtk/events{/privacy}","received_events_url":"https://api.github.com/users/schmidtk/received_events","type":"User","site_admin":false},"assignees":[{"login":"schmidtk","id":5685437,"node_id":"MDQ6VXNlcjU2ODU0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5685437?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidtk","html_url":"https://github.com/schmidtk","followers_url":"https://api.github.com/users/schmidtk/followers","following_url":"https://api.github.com/users/schmidtk/following{/other_user}","gists_url":"https://api.github.com/users/schmidtk/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidtk/subscriptions","organizations_url":"https://api.github.com/users/schmidtk/orgs","repos_url":"https://api.github.com/users/schmidtk/repos","events_url":"https://api.github.com/users/schmidtk/events{/privacy}","received_events_url":"https://api.github.com/users/schmidtk/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/ngageoint/opensphere/pulls/331/commits","review_comments_url":"https://api.github.com/repos/ngageoint/opensphere/pulls/331/comments","review_comment_url":"https://api.github.com/repos/ngageoint/opensphere/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ngageoint/opensphere/issues/331/comments","statuses_url":"https://api.github.com/repos/ngageoint/opensphere/statuses/088c26719e74a613367b82dc8922bce2463761ed","head":{"label":"schmidtk:places-annotations","ref":"places-annotations","sha":"088c26719e74a613367b82dc8922bce2463761ed","user":{"login":"schmidtk","id":5685437,"node_id":"MDQ6VXNlcjU2ODU0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5685437?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidtk","html_url":"https://github.com/schmidtk","followers_url":"https://api.github.com/users/schmidtk/followers","following_url":"https://api.github.com/users/schmidtk/following{/other_user}","gists_url":"https://api.github.com/users/schmidtk/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidtk/subscriptions","organizations_url":"https://api.github.com/users/schmidtk/orgs","repos_url":"https://api.github.com/users/schmidtk/repos","events_url":"https://api.github.com/users/schmidtk/events{/privacy}","received_events_url":"https://api.github.com/users/schmidtk/received_events","type":"User","site_admin":false},"repo":{"id":114584109,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ1ODQxMDk=","name":"opensphere","full_name":"schmidtk/opensphere","private":false,"owner":{"login":"schmidtk","id":5685437,"node_id":"MDQ6VXNlcjU2ODU0Mzc=","avatar_url":"https://avatars3.githubusercontent.com/u/5685437?v=4","gravatar_id":"","url":"https://api.github.com/users/schmidtk","html_url":"https://github.com/schmidtk","followers_url":"https://api.github.com/users/schmidtk/followers","following_url":"https://api.github.com/users/schmidtk/following{/other_user}","gists_url":"https://api.github.com/users/schmidtk/gists{/gist_id}","starred_url":"https://api.github.com/users/schmidtk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/schmidtk/subscriptions","organizations_url":"https://api.github.com/users/schmidtk/orgs","repos_url":"https://api.github.com/users/schmidtk/repos","events_url":"https://api.github.com/users/schmidtk/events{/privacy}","received_events_url":"https://api.github.com/users/schmidtk/received_events","type":"User","site_admin":false},"html_url":"https://github.com/schmidtk/opensphere","description":"OpenSphere","fork":true,"url":"https://api.github.com/repos/schmidtk/opensphere","forks_url":"https://api.github.com/repos/schmidtk/opensphere/forks","keys_url":"https://api.github.com/repos/schmidtk/opensphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/schmidtk/opensphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/schmidtk/opensphere/teams","hooks_url":"https://api.github.com/repos/schmidtk/opensphere/hooks","issue_events_url":"https://api.github.com/repos/schmidtk/opensphere/issues/events{/number}","events_url":"https://api.github.com/repos/schmidtk/opensphere/events","assignees_url":"https://api.github.com/repos/schmidtk/opensphere/assignees{/user}","branches_url":"https://api.github.com/repos/schmidtk/opensphere/branches{/branch}","tags_url":"https://api.github.com/repos/schmidtk/opensphere/tags","blobs_url":"https://api.github.com/repos/schmidtk/opensphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/schmidtk/opensphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/schmidtk/opensphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/schmidtk/opensphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/schmidtk/opensphere/statuses/{sha}","languages_url":"https://api.github.com/repos/schmidtk/opensphere/languages","stargazers_url":"https://api.github.com/repos/schmidtk/opensphere/stargazers","contributors_url":"https://api.github.com/repos/schmidtk/opensphere/contributors","subscribers_url":"https://api.github.com/repos/schmidtk/opensphere/subscribers","subscription_url":"https://api.github.com/repos/schmidtk/opensphere/subscription","commits_url":"https://api.github.com/repos/schmidtk/opensphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/schmidtk/opensphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/schmidtk/opensphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/schmidtk/opensphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/schmidtk/opensphere/contents/{+path}","compare_url":"https://api.github.com/repos/schmidtk/opensphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/schmidtk/opensphere/merges","archive_url":"https://api.github.com/repos/schmidtk/opensphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/schmidtk/opensphere/downloads","issues_url":"https://api.github.com/repos/schmidtk/opensphere/issues{/number}","pulls_url":"https://api.github.com/repos/schmidtk/opensphere/pulls{/number}","milestones_url":"https://api.github.com/repos/schmidtk/opensphere/milestones{/number}","notifications_url":"https://api.github.com/repos/schmidtk/opensphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/schmidtk/opensphere/labels{/name}","releases_url":"https://api.github.com/repos/schmidtk/opensphere/releases{/id}","deployments_url":"https://api.github.com/repos/schmidtk/opensphere/deployments","created_at":"2017-12-18T01:51:06Z","updated_at":"2018-11-15T12:26:39Z","pushed_at":"2018-11-15T12:28:11Z","git_url":"git://github.com/schmidtk/opensphere.git","ssh_url":"git@github.com:schmidtk/opensphere.git","clone_url":"https://github.com/schmidtk/opensphere.git","svn_url":"https://github.com/schmidtk/opensphere","homepage":null,"size":14091,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"ngageoint:master","ref":"master","sha":"04b96d4e7661eecaa166270e8603064a8b3ebaf0","user":{"login":"ngageoint","id":7175944,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNzU5NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7175944?v=4","gravatar_id":"","url":"https://api.github.com/users/ngageoint","html_url":"https://github.com/ngageoint","followers_url":"https://api.github.com/users/ngageoint/followers","following_url":"https://api.github.com/users/ngageoint/following{/other_user}","gists_url":"https://api.github.com/users/ngageoint/gists{/gist_id}","starred_url":"https://api.github.com/users/ngageoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngageoint/subscriptions","organizations_url":"https://api.github.com/users/ngageoint/orgs","repos_url":"https://api.github.com/users/ngageoint/repos","events_url":"https://api.github.com/users/ngageoint/events{/privacy}","received_events_url":"https://api.github.com/users/ngageoint/received_events","type":"Organization","site_admin":false},"repo":{"id":113375075,"node_id":"MDEwOlJlcG9zaXRvcnkxMTMzNzUwNzU=","name":"opensphere","full_name":"ngageoint/opensphere","private":false,"owner":{"login":"ngageoint","id":7175944,"node_id":"MDEyOk9yZ2FuaXphdGlvbjcxNzU5NDQ=","avatar_url":"https://avatars2.githubusercontent.com/u/7175944?v=4","gravatar_id":"","url":"https://api.github.com/users/ngageoint","html_url":"https://github.com/ngageoint","followers_url":"https://api.github.com/users/ngageoint/followers","following_url":"https://api.github.com/users/ngageoint/following{/other_user}","gists_url":"https://api.github.com/users/ngageoint/gists{/gist_id}","starred_url":"https://api.github.com/users/ngageoint/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ngageoint/subscriptions","organizations_url":"https://api.github.com/users/ngageoint/orgs","repos_url":"https://api.github.com/users/ngageoint/repos","events_url":"https://api.github.com/users/ngageoint/events{/privacy}","received_events_url":"https://api.github.com/users/ngageoint/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ngageoint/opensphere","description":"OpenSphere","fork":false,"url":"https://api.github.com/repos/ngageoint/opensphere","forks_url":"https://api.github.com/repos/ngageoint/opensphere/forks","keys_url":"https://api.github.com/repos/ngageoint/opensphere/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ngageoint/opensphere/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ngageoint/opensphere/teams","hooks_url":"https://api.github.com/repos/ngageoint/opensphere/hooks","issue_events_url":"https://api.github.com/repos/ngageoint/opensphere/issues/events{/number}","events_url":"https://api.github.com/repos/ngageoint/opensphere/events","assignees_url":"https://api.github.com/repos/ngageoint/opensphere/assignees{/user}","branches_url":"https://api.github.com/repos/ngageoint/opensphere/branches{/branch}","tags_url":"https://api.github.com/repos/ngageoint/opensphere/tags","blobs_url":"https://api.github.com/repos/ngageoint/opensphere/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ngageoint/opensphere/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ngageoint/opensphere/git/refs{/sha}","trees_url":"https://api.github.com/repos/ngageoint/opensphere/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ngageoint/opensphere/statuses/{sha}","languages_url":"https://api.github.com/repos/ngageoint/opensphere/languages","stargazers_url":"https://api.github.com/repos/ngageoint/opensphere/stargazers","contributors_url":"https://api.github.com/repos/ngageoint/opensphere/contributors","subscribers_url":"https://api.github.com/repos/ngageoint/opensphere/subscribers","subscription_url":"https://api.github.com/repos/ngageoint/opensphere/subscription","commits_url":"https://api.github.com/repos/ngageoint/opensphere/commits{/sha}","git_commits_url":"https://api.github.com/repos/ngageoint/opensphere/git/commits{/sha}","comments_url":"https://api.github.com/repos/ngageoint/opensphere/comments{/number}","issue_comment_url":"https://api.github.com/repos/ngageoint/opensphere/issues/comments{/number}","contents_url":"https://api.github.com/repos/ngageoint/opensphere/contents/{+path}","compare_url":"https://api.github.com/repos/ngageoint/opensphere/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ngageoint/opensphere/merges","archive_url":"https://api.github.com/repos/ngageoint/opensphere/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ngageoint/opensphere/downloads","issues_url":"https://api.github.com/repos/ngageoint/opensphere/issues{/number}","pulls_url":"https://api.github.com/repos/ngageoint/opensphere/pulls{/number}","milestones_url":"https://api.github.com/repos/ngageoint/opensphere/milestones{/number}","notifications_url":"https://api.github.com/repos/ngageoint/opensphere/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ngageoint/opensphere/labels{/name}","releases_url":"https://api.github.com/repos/ngageoint/opensphere/releases{/id}","deployments_url":"https://api.github.com/repos/ngageoint/opensphere/deployments","created_at":"2017-12-06T22:43:51Z","updated_at":"2018-11-14T22:55:48Z","pushed_at":"2018-11-15T14:51:51Z","git_url":"git://github.com/ngageoint/opensphere.git","ssh_url":"git@github.com:ngageoint/opensphere.git","clone_url":"https://github.com/ngageoint/opensphere.git","svn_url":"https://github.com/ngageoint/opensphere","homepage":null,"size":14006,"stargazers_count":44,"watchers_count":44,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":20,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":20,"open_issues":38,"watchers":44,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ngageoint/opensphere/pulls/331"},"html":{"href":"https://github.com/ngageoint/opensphere/pull/331"},"issue":{"href":"https://api.github.com/repos/ngageoint/opensphere/issues/331"},"comments":{"href":"https://api.github.com/repos/ngageoint/opensphere/issues/331/comments"},"review_comments":{"href":"https://api.github.com/repos/ngageoint/opensphere/pulls/331/comments"},"review_comment":{"href":"https://api.github.com/repos/ngageoint/opensphere/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ngageoint/opensphere/pulls/331/commits"},"statuses":{"href":"https://api.github.com/repos/ngageoint/opensphere/statuses/088c26719e74a613367b82dc8922bce2463761ed"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"schmidtk"}}