{"action":"closed","issue":{"url":"https://api.github.com/repos/rhaamo/reel2bits/issues/7","repository_url":"https://api.github.com/repos/rhaamo/reel2bits","labels_url":"https://api.github.com/repos/rhaamo/reel2bits/issues/7/labels{/name}","comments_url":"https://api.github.com/repos/rhaamo/reel2bits/issues/7/comments","events_url":"https://api.github.com/repos/rhaamo/reel2bits/issues/7/events","html_url":"https://github.com/rhaamo/reel2bits/issues/7","id":379842040,"node_id":"MDU6SXNzdWUzNzk4NDIwNDA=","number":7,"title":"User search is wrong and broken","user":{"login":"rhaamo","id":8625,"node_id":"MDQ6VXNlcjg2MjU=","avatar_url":"https://avatars1.githubusercontent.com/u/8625?v=4","gravatar_id":"","url":"https://api.github.com/users/rhaamo","html_url":"https://github.com/rhaamo","followers_url":"https://api.github.com/users/rhaamo/followers","following_url":"https://api.github.com/users/rhaamo/following{/other_user}","gists_url":"https://api.github.com/users/rhaamo/gists{/gist_id}","starred_url":"https://api.github.com/users/rhaamo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhaamo/subscriptions","organizations_url":"https://api.github.com/users/rhaamo/orgs","repos_url":"https://api.github.com/users/rhaamo/repos","events_url":"https://api.github.com/users/rhaamo/events{/privacy}","received_events_url":"https://api.github.com/users/rhaamo/received_events","type":"User","site_admin":false},"labels":[{"id":1012283533,"node_id":"MDU6TGFiZWwxMDEyMjgzNTMz","url":"https://api.github.com/repos/rhaamo/reel2bits/labels/bug","name":"bug","color":"d73a4a","default":true},{"id":1124903460,"node_id":"MDU6TGFiZWwxMTI0OTAzNDYw","url":"https://api.github.com/repos/rhaamo/reel2bits/labels/priority:%20important","name":"priority: important","color":"d93f0b","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-12T16:00:19Z","updated_at":"2018-11-13T09:50:59Z","closed_at":"2018-11-13T09:50:59Z","author_association":"OWNER","body":"We should rework the whole search to include users (remote or local) and songs, maybe albums.\r\n\r\nCurrently it's only user search, and SQL JOIN following part is broken.\r\n\r\nNew search needs to account user being not logged (no following status !)\r\nAnd search should returns `search[accounts]` plus `search[songs]`\r\n\r\nSomething like\r\n```\r\nsearch[songs] == songs matching search, FTS\r\nsearch[accounts] ==\r\n  if s https://\r\n     match actor url in db ?\r\n  else if s user@instance\r\n     match actor username and instance in db ?\r\n  else\r\n     match actor username in db using LIKE ?\r\n  or, no results for the three cases\r\n     do a webfinger, it will return only one user\r\n```"}}
{"actor":{"display_login":"rhaamo"}}