{"action":"created","comment":{"url":"https://api.github.com/repos/Wilfred/remacs/pulls/comments/229437027","pull_request_review_id":169938279,"id":229437027,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTQzNzAyNw==","diff_hunk":"@@ -105,4 +105,20 @@ pub extern \"C\" fn set_window_update_flags(w: LispWindowRef, on_p: bool) {\n     }\n }\n \n+/***********************************************************************\n+\t\t\t   Blinking cursor\n+ ***********************************************************************/\n+\n+#[lisp_fn]\n+pub fn internal_show_cursor(window: LispObject, show: LispObject) {\n+    if !unsafe { redisplaying_p } {\n+        window_or_selected(window).set_cursor_off_p(show.is_nil())\n+    }","path":"rust_src/src/dispnew.rs","position":28,"original_position":28,"commit_id":"3c244d1815fd01182bd9e0fac2a83f6e52bb6ee8","original_commit_id":"3c244d1815fd01182bd9e0fac2a83f6e52bb6ee8","user":{"login":"shaleh","id":1377996,"node_id":"MDQ6VXNlcjEzNzc5OTY=","avatar_url":"https://avatars3.githubusercontent.com/u/1377996?v=4","gravatar_id":"","url":"https://api.github.com/users/shaleh","html_url":"https://github.com/shaleh","followers_url":"https://api.github.com/users/shaleh/followers","following_url":"https://api.github.com/users/shaleh/following{/other_user}","gists_url":"https://api.github.com/users/shaleh/gists{/gist_id}","starred_url":"https://api.github.com/users/shaleh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shaleh/subscriptions","organizations_url":"https://api.github.com/users/shaleh/orgs","repos_url":"https://api.github.com/users/shaleh/repos","events_url":"https://api.github.com/users/shaleh/events{/privacy}","received_events_url":"https://api.github.com/users/shaleh/received_events","type":"User","site_admin":false},"body":"Making no return is the equivalent. I prefer the explicit return too.","created_at":"2018-10-30T18:40:44Z","updated_at":"2018-10-30T18:40:44Z","html_url":"https://github.com/Wilfred/remacs/pull/979#discussion_r229437027","pull_request_url":"https://api.github.com/repos/Wilfred/remacs/pulls/979","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/comments/229437027"},"html":{"href":"https://github.com/Wilfred/remacs/pull/979#discussion_r229437027"},"pull_request":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/979"}},"in_reply_to_id":229261218},"pull_request":{"url":"https://api.github.com/repos/Wilfred/remacs/pulls/979","id":226779979,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2Nzc5OTc5","html_url":"https://github.com/Wilfred/remacs/pull/979","diff_url":"https://github.com/Wilfred/remacs/pull/979.diff","patch_url":"https://github.com/Wilfred/remacs/pull/979.patch","issue_url":"https://api.github.com/repos/Wilfred/remacs/issues/979","number":979,"state":"open","locked":false,"title":"Port internal-show-cursor{,-p}","user":{"login":"bb010g","id":340132,"node_id":"MDQ6VXNlcjM0MDEzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/340132?v=4","gravatar_id":"","url":"https://api.github.com/users/bb010g","html_url":"https://github.com/bb010g","followers_url":"https://api.github.com/users/bb010g/followers","following_url":"https://api.github.com/users/bb010g/following{/other_user}","gists_url":"https://api.github.com/users/bb010g/gists{/gist_id}","starred_url":"https://api.github.com/users/bb010g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bb010g/subscriptions","organizations_url":"https://api.github.com/users/bb010g/orgs","repos_url":"https://api.github.com/users/bb010g/repos","events_url":"https://api.github.com/users/bb010g/events{/privacy}","received_events_url":"https://api.github.com/users/bb010g/received_events","type":"User","site_admin":false},"body":"Closes #974.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/wilfred/remacs/979)\n<!-- Reviewable:end -->\n","created_at":"2018-10-30T03:26:05Z","updated_at":"2018-10-30T18:40:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"06a3337e531dcf7ccfa69583bdd01e5594502dc4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Wilfred/remacs/pulls/979/commits","review_comments_url":"https://api.github.com/repos/Wilfred/remacs/pulls/979/comments","review_comment_url":"https://api.github.com/repos/Wilfred/remacs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Wilfred/remacs/issues/979/comments","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/3c244d1815fd01182bd9e0fac2a83f6e52bb6ee8","head":{"label":"bb010g:iscp","ref":"iscp","sha":"3c244d1815fd01182bd9e0fac2a83f6e52bb6ee8","user":{"login":"bb010g","id":340132,"node_id":"MDQ6VXNlcjM0MDEzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/340132?v=4","gravatar_id":"","url":"https://api.github.com/users/bb010g","html_url":"https://github.com/bb010g","followers_url":"https://api.github.com/users/bb010g/followers","following_url":"https://api.github.com/users/bb010g/following{/other_user}","gists_url":"https://api.github.com/users/bb010g/gists{/gist_id}","starred_url":"https://api.github.com/users/bb010g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bb010g/subscriptions","organizations_url":"https://api.github.com/users/bb010g/orgs","repos_url":"https://api.github.com/users/bb010g/repos","events_url":"https://api.github.com/users/bb010g/events{/privacy}","received_events_url":"https://api.github.com/users/bb010g/received_events","type":"User","site_admin":false},"repo":{"id":154768509,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ3Njg1MDk=","name":"remacs","full_name":"bb010g/remacs","private":false,"owner":{"login":"bb010g","id":340132,"node_id":"MDQ6VXNlcjM0MDEzMg==","avatar_url":"https://avatars2.githubusercontent.com/u/340132?v=4","gravatar_id":"","url":"https://api.github.com/users/bb010g","html_url":"https://github.com/bb010g","followers_url":"https://api.github.com/users/bb010g/followers","following_url":"https://api.github.com/users/bb010g/following{/other_user}","gists_url":"https://api.github.com/users/bb010g/gists{/gist_id}","starred_url":"https://api.github.com/users/bb010g/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bb010g/subscriptions","organizations_url":"https://api.github.com/users/bb010g/orgs","repos_url":"https://api.github.com/users/bb010g/repos","events_url":"https://api.github.com/users/bb010g/events{/privacy}","received_events_url":"https://api.github.com/users/bb010g/received_events","type":"User","site_admin":false},"html_url":"https://github.com/bb010g/remacs","description":"Rust :heart: Emacs","fork":true,"url":"https://api.github.com/repos/bb010g/remacs","forks_url":"https://api.github.com/repos/bb010g/remacs/forks","keys_url":"https://api.github.com/repos/bb010g/remacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bb010g/remacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bb010g/remacs/teams","hooks_url":"https://api.github.com/repos/bb010g/remacs/hooks","issue_events_url":"https://api.github.com/repos/bb010g/remacs/issues/events{/number}","events_url":"https://api.github.com/repos/bb010g/remacs/events","assignees_url":"https://api.github.com/repos/bb010g/remacs/assignees{/user}","branches_url":"https://api.github.com/repos/bb010g/remacs/branches{/branch}","tags_url":"https://api.github.com/repos/bb010g/remacs/tags","blobs_url":"https://api.github.com/repos/bb010g/remacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bb010g/remacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bb010g/remacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/bb010g/remacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bb010g/remacs/statuses/{sha}","languages_url":"https://api.github.com/repos/bb010g/remacs/languages","stargazers_url":"https://api.github.com/repos/bb010g/remacs/stargazers","contributors_url":"https://api.github.com/repos/bb010g/remacs/contributors","subscribers_url":"https://api.github.com/repos/bb010g/remacs/subscribers","subscription_url":"https://api.github.com/repos/bb010g/remacs/subscription","commits_url":"https://api.github.com/repos/bb010g/remacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/bb010g/remacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/bb010g/remacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/bb010g/remacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/bb010g/remacs/contents/{+path}","compare_url":"https://api.github.com/repos/bb010g/remacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bb010g/remacs/merges","archive_url":"https://api.github.com/repos/bb010g/remacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bb010g/remacs/downloads","issues_url":"https://api.github.com/repos/bb010g/remacs/issues{/number}","pulls_url":"https://api.github.com/repos/bb010g/remacs/pulls{/number}","milestones_url":"https://api.github.com/repos/bb010g/remacs/milestones{/number}","notifications_url":"https://api.github.com/repos/bb010g/remacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bb010g/remacs/labels{/name}","releases_url":"https://api.github.com/repos/bb010g/remacs/releases{/id}","deployments_url":"https://api.github.com/repos/bb010g/remacs/deployments","created_at":"2018-10-26T02:53:55Z","updated_at":"2018-10-26T07:30:59Z","pushed_at":"2018-10-30T03:24:54Z","git_url":"git://github.com/bb010g/remacs.git","ssh_url":"git@github.com:bb010g/remacs.git","clone_url":"https://github.com/bb010g/remacs.git","svn_url":"https://github.com/bb010g/remacs","homepage":"","size":269354,"stargazers_count":0,"watchers_count":0,"language":"Emacs Lisp","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Wilfred:master","ref":"master","sha":"d889054c2619004cda757acb8201c672becdeee5","user":{"login":"Wilfred","id":70800,"node_id":"MDQ6VXNlcjcwODAw","avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"repo":{"id":74522337,"node_id":"MDEwOlJlcG9zaXRvcnk3NDUyMjMzNw==","name":"remacs","full_name":"Wilfred/remacs","private":false,"owner":{"login":"Wilfred","id":70800,"node_id":"MDQ6VXNlcjcwODAw","avatar_url":"https://avatars0.githubusercontent.com/u/70800?v=4","gravatar_id":"","url":"https://api.github.com/users/Wilfred","html_url":"https://github.com/Wilfred","followers_url":"https://api.github.com/users/Wilfred/followers","following_url":"https://api.github.com/users/Wilfred/following{/other_user}","gists_url":"https://api.github.com/users/Wilfred/gists{/gist_id}","starred_url":"https://api.github.com/users/Wilfred/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Wilfred/subscriptions","organizations_url":"https://api.github.com/users/Wilfred/orgs","repos_url":"https://api.github.com/users/Wilfred/repos","events_url":"https://api.github.com/users/Wilfred/events{/privacy}","received_events_url":"https://api.github.com/users/Wilfred/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Wilfred/remacs","description":"Rust :heart: Emacs","fork":false,"url":"https://api.github.com/repos/Wilfred/remacs","forks_url":"https://api.github.com/repos/Wilfred/remacs/forks","keys_url":"https://api.github.com/repos/Wilfred/remacs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Wilfred/remacs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Wilfred/remacs/teams","hooks_url":"https://api.github.com/repos/Wilfred/remacs/hooks","issue_events_url":"https://api.github.com/repos/Wilfred/remacs/issues/events{/number}","events_url":"https://api.github.com/repos/Wilfred/remacs/events","assignees_url":"https://api.github.com/repos/Wilfred/remacs/assignees{/user}","branches_url":"https://api.github.com/repos/Wilfred/remacs/branches{/branch}","tags_url":"https://api.github.com/repos/Wilfred/remacs/tags","blobs_url":"https://api.github.com/repos/Wilfred/remacs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Wilfred/remacs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Wilfred/remacs/git/refs{/sha}","trees_url":"https://api.github.com/repos/Wilfred/remacs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Wilfred/remacs/statuses/{sha}","languages_url":"https://api.github.com/repos/Wilfred/remacs/languages","stargazers_url":"https://api.github.com/repos/Wilfred/remacs/stargazers","contributors_url":"https://api.github.com/repos/Wilfred/remacs/contributors","subscribers_url":"https://api.github.com/repos/Wilfred/remacs/subscribers","subscription_url":"https://api.github.com/repos/Wilfred/remacs/subscription","commits_url":"https://api.github.com/repos/Wilfred/remacs/commits{/sha}","git_commits_url":"https://api.github.com/repos/Wilfred/remacs/git/commits{/sha}","comments_url":"https://api.github.com/repos/Wilfred/remacs/comments{/number}","issue_comment_url":"https://api.github.com/repos/Wilfred/remacs/issues/comments{/number}","contents_url":"https://api.github.com/repos/Wilfred/remacs/contents/{+path}","compare_url":"https://api.github.com/repos/Wilfred/remacs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Wilfred/remacs/merges","archive_url":"https://api.github.com/repos/Wilfred/remacs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Wilfred/remacs/downloads","issues_url":"https://api.github.com/repos/Wilfred/remacs/issues{/number}","pulls_url":"https://api.github.com/repos/Wilfred/remacs/pulls{/number}","milestones_url":"https://api.github.com/repos/Wilfred/remacs/milestones{/number}","notifications_url":"https://api.github.com/repos/Wilfred/remacs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Wilfred/remacs/labels{/name}","releases_url":"https://api.github.com/repos/Wilfred/remacs/releases{/id}","deployments_url":"https://api.github.com/repos/Wilfred/remacs/deployments","created_at":"2016-11-22T23:29:21Z","updated_at":"2018-10-30T14:01:32Z","pushed_at":"2018-10-30T18:02:23Z","git_url":"git://github.com/Wilfred/remacs.git","ssh_url":"git@github.com:Wilfred/remacs.git","clone_url":"https://github.com/Wilfred/remacs.git","svn_url":"https://github.com/Wilfred/remacs","homepage":"","size":269435,"stargazers_count":2699,"watchers_count":2699,"language":"Emacs Lisp","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":215,"mirror_url":null,"archived":false,"open_issues_count":101,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":215,"open_issues":101,"watchers":2699,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/979"},"html":{"href":"https://github.com/Wilfred/remacs/pull/979"},"issue":{"href":"https://api.github.com/repos/Wilfred/remacs/issues/979"},"comments":{"href":"https://api.github.com/repos/Wilfred/remacs/issues/979/comments"},"review_comments":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/979/comments"},"review_comment":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Wilfred/remacs/pulls/979/commits"},"statuses":{"href":"https://api.github.com/repos/Wilfred/remacs/statuses/3c244d1815fd01182bd9e0fac2a83f6e52bb6ee8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"shaleh"}}