{"action":"created","comment":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/226793393","pull_request_review_id":166710425,"id":226793393,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNjc5MzM5Mw==","diff_hunk":"@@ -0,0 +1,141 @@\n+// @flow\n+import * as React from 'react'\n+import {Formik} from 'formik'\n+import * as Yup from 'yup'\n+// TODO: Ian 2018-10-19 move the processors out of steplist (chore)\n+import * as fieldProcessors from '../../steplist/fieldLevel/processing'\n+import {\n+  DropdownField,\n+  InputField,\n+  FormGroup,\n+  OutlineButton,\n+  PrimaryButton,\n+} from '@opentrons/components'\n+import i18n from '../../localization'\n+import styles from './LiquidPlacementForm.css'\n+import formStyles from '../forms.css'\n+import type {Options} from '../../types'\n+\n+export type ValidFormValues = {\n+  selectedLiquidId: string,\n+  volume: string,","path":"protocol-designer/src/components/LiquidPlacementForm/LiquidPlacementForm.js","position":21,"original_position":21,"commit_id":"285626c88a700e1a6abc876a3cdb4a06d3158f02","original_commit_id":"285626c88a700e1a6abc876a3cdb4a06d3158f02","user":{"login":"IanLondon","id":11590381,"node_id":"MDQ6VXNlcjExNTkwMzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"FORMIK WARNING: I almost let a subtle but bad bug thru, declaring type of this as `volume: number`. Unless the onChange of a field explicitly casts to number before calling Formik's `setFieldValue`, and if you don't have `type='number'` on the `<input />`, then it will validate correctly but still just be a string and pass that string into the submit callback which is expecting a number.\r\n\r\nAside: it might be nice to use `type=\"number\"` if we use `novalidate` to override the browser's annoying weird field validation, thoughts?","created_at":"2018-10-19T22:05:25Z","updated_at":"2018-10-19T22:05:26Z","html_url":"https://github.com/Opentrons/opentrons/pull/2518#discussion_r226793393","pull_request_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments/226793393"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/2518#discussion_r226793393"},"pull_request":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2518"}}},"pull_request":{"url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2518","id":224420942,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NDIwOTQy","html_url":"https://github.com/Opentrons/opentrons/pull/2518","diff_url":"https://github.com/Opentrons/opentrons/pull/2518.diff","patch_url":"https://github.com/Opentrons/opentrons/pull/2518.patch","issue_url":"https://api.github.com/repos/Opentrons/opentrons/issues/2518","number":2518,"state":"open","locked":false,"title":"feat(protocol-designer): replace liquid placement form","user":{"login":"IanLondon","id":11590381,"node_id":"MDQ6VXNlcjExNTkwMzgx","avatar_url":"https://avatars0.githubusercontent.com/u/11590381?v=4","gravatar_id":"","url":"https://api.github.com/users/IanLondon","html_url":"https://github.com/IanLondon","followers_url":"https://api.github.com/users/IanLondon/followers","following_url":"https://api.github.com/users/IanLondon/following{/other_user}","gists_url":"https://api.github.com/users/IanLondon/gists{/gist_id}","starred_url":"https://api.github.com/users/IanLondon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanLondon/subscriptions","organizations_url":"https://api.github.com/users/IanLondon/orgs","repos_url":"https://api.github.com/users/IanLondon/repos","events_url":"https://api.github.com/users/IanLondon/events{/privacy}","received_events_url":"https://api.github.com/users/IanLondon/received_events","type":"User","site_admin":false},"body":"## overview\r\n\r\nNew, more minimalist Liquid Placement form!\r\n\r\n![image](https://user-images.githubusercontent.com/11590381/47245671-43d8c600-d3c8-11e8-9953-01d996c02561.png)\r\n\r\nAnd getting rid of a lot of old code from the original PD prototype\r\n\r\n![image](https://user-images.githubusercontent.com/11590381/47245723-71be0a80-d3c8-11e8-9f16-79ba2dad6204.png)\r\n\r\n\r\nCloses #2429\r\n\r\n## changelog\r\n\r\n* implement new simpler liquid placement form\r\n* remove old IngredientPropertiesForm\r\n\r\n## review requests\r\n\r\n- [ ] You cannot enter invalid inputs in the volume field (n > 0, limited to 1 decimal max)\r\n- [ ] Liquid and volume must be non-null to save form\r\n- [ ] Errors show up in form with invalid values","created_at":"2018-10-19T21:59:44Z","updated_at":"2018-10-19T22:05:26Z","closed_at":null,"merged_at":null,"merge_commit_sha":"77d8f6598682812be35c8fef368cd64b3cb97df3","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mcous","id":2963448,"node_id":"MDQ6VXNlcjI5NjM0NDg=","avatar_url":"https://avatars1.githubusercontent.com/u/2963448?v=4","gravatar_id":"","url":"https://api.github.com/users/mcous","html_url":"https://github.com/mcous","followers_url":"https://api.github.com/users/mcous/followers","following_url":"https://api.github.com/users/mcous/following{/other_user}","gists_url":"https://api.github.com/users/mcous/gists{/gist_id}","starred_url":"https://api.github.com/users/mcous/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mcous/subscriptions","organizations_url":"https://api.github.com/users/mcous/orgs","repos_url":"https://api.github.com/users/mcous/repos","events_url":"https://api.github.com/users/mcous/events{/privacy}","received_events_url":"https://api.github.com/users/mcous/received_events","type":"User","site_admin":false},{"login":"Kadee80","id":3430313,"node_id":"MDQ6VXNlcjM0MzAzMTM=","avatar_url":"https://avatars1.githubusercontent.com/u/3430313?v=4","gravatar_id":"","url":"https://api.github.com/users/Kadee80","html_url":"https://github.com/Kadee80","followers_url":"https://api.github.com/users/Kadee80/followers","following_url":"https://api.github.com/users/Kadee80/following{/other_user}","gists_url":"https://api.github.com/users/Kadee80/gists{/gist_id}","starred_url":"https://api.github.com/users/Kadee80/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Kadee80/subscriptions","organizations_url":"https://api.github.com/users/Kadee80/orgs","repos_url":"https://api.github.com/users/Kadee80/repos","events_url":"https://api.github.com/users/Kadee80/events{/privacy}","received_events_url":"https://api.github.com/users/Kadee80/received_events","type":"User","site_admin":false},{"login":"b-cooper","id":4731953,"node_id":"MDQ6VXNlcjQ3MzE5NTM=","avatar_url":"https://avatars3.githubusercontent.com/u/4731953?v=4","gravatar_id":"","url":"https://api.github.com/users/b-cooper","html_url":"https://github.com/b-cooper","followers_url":"https://api.github.com/users/b-cooper/followers","following_url":"https://api.github.com/users/b-cooper/following{/other_user}","gists_url":"https://api.github.com/users/b-cooper/gists{/gist_id}","starred_url":"https://api.github.com/users/b-cooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/b-cooper/subscriptions","organizations_url":"https://api.github.com/users/b-cooper/orgs","repos_url":"https://api.github.com/users/b-cooper/repos","events_url":"https://api.github.com/users/b-cooper/events{/privacy}","received_events_url":"https://api.github.com/users/b-cooper/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":770645862,"node_id":"MDU6TGFiZWw3NzA2NDU4NjI=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/protocol%20designer","name":"protocol designer","color":"440f89","default":false},{"id":762619415,"node_id":"MDU6TGFiZWw3NjI2MTk0MTU=","url":"https://api.github.com/repos/Opentrons/opentrons/labels/ready%20for%20review","name":"ready for review","color":"6ed32a","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2518/commits","review_comments_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/2518/comments","review_comment_url":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/issues/2518/comments","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/285626c88a700e1a6abc876a3cdb4a06d3158f02","head":{"label":"Opentrons:pd_liquid-placement-form-2429","ref":"pd_liquid-placement-form-2429","sha":"285626c88a700e1a6abc876a3cdb4a06d3158f02","user":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"node_id":"MDEwOlJlcG9zaXRvcnkzODY0NDg0MQ==","name":"opentrons","full_name":"Opentrons/opentrons","private":false,"owner":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-10-19T19:58:46Z","pushed_at":"2018-10-19T21:59:44Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":31310,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":225,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":50,"open_issues":225,"watchers":79,"default_branch":"edge"}},"base":{"label":"Opentrons:edge","ref":"edge","sha":"2c48c09031a5d0793d3bd05b03e7313e27b53809","user":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"repo":{"id":38644841,"node_id":"MDEwOlJlcG9zaXRvcnkzODY0NDg0MQ==","name":"opentrons","full_name":"Opentrons/opentrons","private":false,"owner":{"login":"Opentrons","id":6139147,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxMzkxNDc=","avatar_url":"https://avatars2.githubusercontent.com/u/6139147?v=4","gravatar_id":"","url":"https://api.github.com/users/Opentrons","html_url":"https://github.com/Opentrons","followers_url":"https://api.github.com/users/Opentrons/followers","following_url":"https://api.github.com/users/Opentrons/following{/other_user}","gists_url":"https://api.github.com/users/Opentrons/gists{/gist_id}","starred_url":"https://api.github.com/users/Opentrons/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Opentrons/subscriptions","organizations_url":"https://api.github.com/users/Opentrons/orgs","repos_url":"https://api.github.com/users/Opentrons/repos","events_url":"https://api.github.com/users/Opentrons/events{/privacy}","received_events_url":"https://api.github.com/users/Opentrons/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/Opentrons/opentrons","description":"Software for writing protocols and running them on Opentrons robots","fork":false,"url":"https://api.github.com/repos/Opentrons/opentrons","forks_url":"https://api.github.com/repos/Opentrons/opentrons/forks","keys_url":"https://api.github.com/repos/Opentrons/opentrons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Opentrons/opentrons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Opentrons/opentrons/teams","hooks_url":"https://api.github.com/repos/Opentrons/opentrons/hooks","issue_events_url":"https://api.github.com/repos/Opentrons/opentrons/issues/events{/number}","events_url":"https://api.github.com/repos/Opentrons/opentrons/events","assignees_url":"https://api.github.com/repos/Opentrons/opentrons/assignees{/user}","branches_url":"https://api.github.com/repos/Opentrons/opentrons/branches{/branch}","tags_url":"https://api.github.com/repos/Opentrons/opentrons/tags","blobs_url":"https://api.github.com/repos/Opentrons/opentrons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Opentrons/opentrons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Opentrons/opentrons/git/refs{/sha}","trees_url":"https://api.github.com/repos/Opentrons/opentrons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Opentrons/opentrons/statuses/{sha}","languages_url":"https://api.github.com/repos/Opentrons/opentrons/languages","stargazers_url":"https://api.github.com/repos/Opentrons/opentrons/stargazers","contributors_url":"https://api.github.com/repos/Opentrons/opentrons/contributors","subscribers_url":"https://api.github.com/repos/Opentrons/opentrons/subscribers","subscription_url":"https://api.github.com/repos/Opentrons/opentrons/subscription","commits_url":"https://api.github.com/repos/Opentrons/opentrons/commits{/sha}","git_commits_url":"https://api.github.com/repos/Opentrons/opentrons/git/commits{/sha}","comments_url":"https://api.github.com/repos/Opentrons/opentrons/comments{/number}","issue_comment_url":"https://api.github.com/repos/Opentrons/opentrons/issues/comments{/number}","contents_url":"https://api.github.com/repos/Opentrons/opentrons/contents/{+path}","compare_url":"https://api.github.com/repos/Opentrons/opentrons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Opentrons/opentrons/merges","archive_url":"https://api.github.com/repos/Opentrons/opentrons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Opentrons/opentrons/downloads","issues_url":"https://api.github.com/repos/Opentrons/opentrons/issues{/number}","pulls_url":"https://api.github.com/repos/Opentrons/opentrons/pulls{/number}","milestones_url":"https://api.github.com/repos/Opentrons/opentrons/milestones{/number}","notifications_url":"https://api.github.com/repos/Opentrons/opentrons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Opentrons/opentrons/labels{/name}","releases_url":"https://api.github.com/repos/Opentrons/opentrons/releases{/id}","deployments_url":"https://api.github.com/repos/Opentrons/opentrons/deployments","created_at":"2015-07-06T20:41:01Z","updated_at":"2018-10-19T19:58:46Z","pushed_at":"2018-10-19T21:59:44Z","git_url":"git://github.com/Opentrons/opentrons.git","ssh_url":"git@github.com:Opentrons/opentrons.git","clone_url":"https://github.com/Opentrons/opentrons.git","svn_url":"https://github.com/Opentrons/opentrons","homepage":"","size":31310,"stargazers_count":79,"watchers_count":79,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":50,"mirror_url":null,"archived":false,"open_issues_count":225,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":50,"open_issues":225,"watchers":79,"default_branch":"edge"}},"_links":{"self":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2518"},"html":{"href":"https://github.com/Opentrons/opentrons/pull/2518"},"issue":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/2518"},"comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/issues/2518/comments"},"review_comments":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2518/comments"},"review_comment":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Opentrons/opentrons/pulls/2518/commits"},"statuses":{"href":"https://api.github.com/repos/Opentrons/opentrons/statuses/285626c88a700e1a6abc876a3cdb4a06d3158f02"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"IanLondon"}}