{"action":"created","comment":{"url":"https://api.github.com/repos/franklinsch/flint/pulls/comments/200201696","pull_request_review_id":134470709,"id":200201696,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwMDIwMTY5Ng==","diff_hunk":"@@ -20,6 +22,12 @@ InvalidTypes :: (any) {\n     var a: Bool = true\n     a = b // expected-error {{Use of undeclared identifier 'b'}}\n \n+    // expected-error@27 {{Incompatible assignment between values of type 'Address' and 'Bool'}}\n+    // expected-error@27 {{Cannot convert expression of type 'Bool' to expected subscript type 'Int'}}\n+    arr[a] = a\n+\n+    dict[a] // expected-error {{Cannot convert expression of type 'Bool' to expected subscript type 'Address'}}","path":"Tests/SemanticTests/invalid_types.flint","position":17,"original_position":17,"commit_id":"6e692625b9d205bf8d5efb4a35c63c77cc38a232","original_commit_id":"6e692625b9d205bf8d5efb4a35c63c77cc38a232","user":{"login":"franklinsch","id":7278429,"node_id":"MDQ6VXNlcjcyNzg0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7278429?v=4","gravatar_id":"","url":"https://api.github.com/users/franklinsch","html_url":"https://github.com/franklinsch","followers_url":"https://api.github.com/users/franklinsch/followers","following_url":"https://api.github.com/users/franklinsch/following{/other_user}","gists_url":"https://api.github.com/users/franklinsch/gists{/gist_id}","starred_url":"https://api.github.com/users/franklinsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franklinsch/subscriptions","organizations_url":"https://api.github.com/users/franklinsch/orgs","repos_url":"https://api.github.com/users/franklinsch/repos","events_url":"https://api.github.com/users/franklinsch/events{/privacy}","received_events_url":"https://api.github.com/users/franklinsch/received_events","type":"User","site_admin":false},"body":"Nice. Could you add a line to check there aren't implicit conversions between `Address` and `Int`? Like `arr[3] = ...`","created_at":"2018-07-04T21:12:12Z","updated_at":"2018-07-04T21:12:38Z","html_url":"https://github.com/franklinsch/flint/pull/228#discussion_r200201696","pull_request_url":"https://api.github.com/repos/franklinsch/flint/pulls/228","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/franklinsch/flint/pulls/comments/200201696"},"html":{"href":"https://github.com/franklinsch/flint/pull/228#discussion_r200201696"},"pull_request":{"href":"https://api.github.com/repos/franklinsch/flint/pulls/228"}}},"pull_request":{"url":"https://api.github.com/repos/franklinsch/flint/pulls/228","id":199178073,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk5MTc4MDcz","html_url":"https://github.com/franklinsch/flint/pull/228","diff_url":"https://github.com/franklinsch/flint/pull/228.diff","patch_url":"https://github.com/franklinsch/flint/pull/228.patch","issue_url":"https://api.github.com/repos/franklinsch/flint/issues/228","number":228,"state":"open","locked":false,"title":"Add subscript type checking","user":{"login":"DJRHails","id":10828202,"node_id":"MDQ6VXNlcjEwODI4MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/10828202?v=4","gravatar_id":"","url":"https://api.github.com/users/DJRHails","html_url":"https://github.com/DJRHails","followers_url":"https://api.github.com/users/DJRHails/followers","following_url":"https://api.github.com/users/DJRHails/following{/other_user}","gists_url":"https://api.github.com/users/DJRHails/gists{/gist_id}","starred_url":"https://api.github.com/users/DJRHails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DJRHails/subscriptions","organizations_url":"https://api.github.com/users/DJRHails/orgs","repos_url":"https://api.github.com/users/DJRHails/repos","events_url":"https://api.github.com/users/DJRHails/events{/privacy}","received_events_url":"https://api.github.com/users/DJRHails/received_events","type":"User","site_admin":false},"body":"Fixes #101 to add subscript type checking for arrays and dictionaries. ","created_at":"2018-07-04T08:43:03Z","updated_at":"2018-07-04T21:12:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9cb0a02adae071e863761aca917134732e50b6ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/franklinsch/flint/pulls/228/commits","review_comments_url":"https://api.github.com/repos/franklinsch/flint/pulls/228/comments","review_comment_url":"https://api.github.com/repos/franklinsch/flint/pulls/comments{/number}","comments_url":"https://api.github.com/repos/franklinsch/flint/issues/228/comments","statuses_url":"https://api.github.com/repos/franklinsch/flint/statuses/6e692625b9d205bf8d5efb4a35c63c77cc38a232","head":{"label":"DJRHails:type_check_subscripts","ref":"type_check_subscripts","sha":"6e692625b9d205bf8d5efb4a35c63c77cc38a232","user":{"login":"DJRHails","id":10828202,"node_id":"MDQ6VXNlcjEwODI4MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/10828202?v=4","gravatar_id":"","url":"https://api.github.com/users/DJRHails","html_url":"https://github.com/DJRHails","followers_url":"https://api.github.com/users/DJRHails/followers","following_url":"https://api.github.com/users/DJRHails/following{/other_user}","gists_url":"https://api.github.com/users/DJRHails/gists{/gist_id}","starred_url":"https://api.github.com/users/DJRHails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DJRHails/subscriptions","organizations_url":"https://api.github.com/users/DJRHails/orgs","repos_url":"https://api.github.com/users/DJRHails/repos","events_url":"https://api.github.com/users/DJRHails/events{/privacy}","received_events_url":"https://api.github.com/users/DJRHails/received_events","type":"User","site_admin":false},"repo":{"id":139429072,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0MjkwNzI=","name":"flint","full_name":"DJRHails/flint","owner":{"login":"DJRHails","id":10828202,"node_id":"MDQ6VXNlcjEwODI4MjAy","avatar_url":"https://avatars1.githubusercontent.com/u/10828202?v=4","gravatar_id":"","url":"https://api.github.com/users/DJRHails","html_url":"https://github.com/DJRHails","followers_url":"https://api.github.com/users/DJRHails/followers","following_url":"https://api.github.com/users/DJRHails/following{/other_user}","gists_url":"https://api.github.com/users/DJRHails/gists{/gist_id}","starred_url":"https://api.github.com/users/DJRHails/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DJRHails/subscriptions","organizations_url":"https://api.github.com/users/DJRHails/orgs","repos_url":"https://api.github.com/users/DJRHails/repos","events_url":"https://api.github.com/users/DJRHails/events{/privacy}","received_events_url":"https://api.github.com/users/DJRHails/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/DJRHails/flint","description":"The Flint Programming Language for Smart Contracts","fork":true,"url":"https://api.github.com/repos/DJRHails/flint","forks_url":"https://api.github.com/repos/DJRHails/flint/forks","keys_url":"https://api.github.com/repos/DJRHails/flint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DJRHails/flint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DJRHails/flint/teams","hooks_url":"https://api.github.com/repos/DJRHails/flint/hooks","issue_events_url":"https://api.github.com/repos/DJRHails/flint/issues/events{/number}","events_url":"https://api.github.com/repos/DJRHails/flint/events","assignees_url":"https://api.github.com/repos/DJRHails/flint/assignees{/user}","branches_url":"https://api.github.com/repos/DJRHails/flint/branches{/branch}","tags_url":"https://api.github.com/repos/DJRHails/flint/tags","blobs_url":"https://api.github.com/repos/DJRHails/flint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DJRHails/flint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DJRHails/flint/git/refs{/sha}","trees_url":"https://api.github.com/repos/DJRHails/flint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DJRHails/flint/statuses/{sha}","languages_url":"https://api.github.com/repos/DJRHails/flint/languages","stargazers_url":"https://api.github.com/repos/DJRHails/flint/stargazers","contributors_url":"https://api.github.com/repos/DJRHails/flint/contributors","subscribers_url":"https://api.github.com/repos/DJRHails/flint/subscribers","subscription_url":"https://api.github.com/repos/DJRHails/flint/subscription","commits_url":"https://api.github.com/repos/DJRHails/flint/commits{/sha}","git_commits_url":"https://api.github.com/repos/DJRHails/flint/git/commits{/sha}","comments_url":"https://api.github.com/repos/DJRHails/flint/comments{/number}","issue_comment_url":"https://api.github.com/repos/DJRHails/flint/issues/comments{/number}","contents_url":"https://api.github.com/repos/DJRHails/flint/contents/{+path}","compare_url":"https://api.github.com/repos/DJRHails/flint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DJRHails/flint/merges","archive_url":"https://api.github.com/repos/DJRHails/flint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DJRHails/flint/downloads","issues_url":"https://api.github.com/repos/DJRHails/flint/issues{/number}","pulls_url":"https://api.github.com/repos/DJRHails/flint/pulls{/number}","milestones_url":"https://api.github.com/repos/DJRHails/flint/milestones{/number}","notifications_url":"https://api.github.com/repos/DJRHails/flint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DJRHails/flint/labels{/name}","releases_url":"https://api.github.com/repos/DJRHails/flint/releases{/id}","deployments_url":"https://api.github.com/repos/DJRHails/flint/deployments","created_at":"2018-07-02T10:37:24Z","updated_at":"2018-07-04T10:08:45Z","pushed_at":"2018-07-04T16:59:24Z","git_url":"git://github.com/DJRHails/flint.git","ssh_url":"git@github.com:DJRHails/flint.git","clone_url":"https://github.com/DJRHails/flint.git","svn_url":"https://github.com/DJRHails/flint","homepage":"","size":1271,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"franklinsch:master","ref":"master","sha":"718ea3cabc176aaabb58fba6b30b4af9a3b3bb22","user":{"login":"franklinsch","id":7278429,"node_id":"MDQ6VXNlcjcyNzg0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7278429?v=4","gravatar_id":"","url":"https://api.github.com/users/franklinsch","html_url":"https://github.com/franklinsch","followers_url":"https://api.github.com/users/franklinsch/followers","following_url":"https://api.github.com/users/franklinsch/following{/other_user}","gists_url":"https://api.github.com/users/franklinsch/gists{/gist_id}","starred_url":"https://api.github.com/users/franklinsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franklinsch/subscriptions","organizations_url":"https://api.github.com/users/franklinsch/orgs","repos_url":"https://api.github.com/users/franklinsch/repos","events_url":"https://api.github.com/users/franklinsch/events{/privacy}","received_events_url":"https://api.github.com/users/franklinsch/received_events","type":"User","site_admin":false},"repo":{"id":114819539,"node_id":"MDEwOlJlcG9zaXRvcnkxMTQ4MTk1Mzk=","name":"flint","full_name":"franklinsch/flint","owner":{"login":"franklinsch","id":7278429,"node_id":"MDQ6VXNlcjcyNzg0Mjk=","avatar_url":"https://avatars0.githubusercontent.com/u/7278429?v=4","gravatar_id":"","url":"https://api.github.com/users/franklinsch","html_url":"https://github.com/franklinsch","followers_url":"https://api.github.com/users/franklinsch/followers","following_url":"https://api.github.com/users/franklinsch/following{/other_user}","gists_url":"https://api.github.com/users/franklinsch/gists{/gist_id}","starred_url":"https://api.github.com/users/franklinsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/franklinsch/subscriptions","organizations_url":"https://api.github.com/users/franklinsch/orgs","repos_url":"https://api.github.com/users/franklinsch/repos","events_url":"https://api.github.com/users/franklinsch/events{/privacy}","received_events_url":"https://api.github.com/users/franklinsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/franklinsch/flint","description":"The Flint Programming Language for Smart Contracts","fork":false,"url":"https://api.github.com/repos/franklinsch/flint","forks_url":"https://api.github.com/repos/franklinsch/flint/forks","keys_url":"https://api.github.com/repos/franklinsch/flint/keys{/key_id}","collaborators_url":"https://api.github.com/repos/franklinsch/flint/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/franklinsch/flint/teams","hooks_url":"https://api.github.com/repos/franklinsch/flint/hooks","issue_events_url":"https://api.github.com/repos/franklinsch/flint/issues/events{/number}","events_url":"https://api.github.com/repos/franklinsch/flint/events","assignees_url":"https://api.github.com/repos/franklinsch/flint/assignees{/user}","branches_url":"https://api.github.com/repos/franklinsch/flint/branches{/branch}","tags_url":"https://api.github.com/repos/franklinsch/flint/tags","blobs_url":"https://api.github.com/repos/franklinsch/flint/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/franklinsch/flint/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/franklinsch/flint/git/refs{/sha}","trees_url":"https://api.github.com/repos/franklinsch/flint/git/trees{/sha}","statuses_url":"https://api.github.com/repos/franklinsch/flint/statuses/{sha}","languages_url":"https://api.github.com/repos/franklinsch/flint/languages","stargazers_url":"https://api.github.com/repos/franklinsch/flint/stargazers","contributors_url":"https://api.github.com/repos/franklinsch/flint/contributors","subscribers_url":"https://api.github.com/repos/franklinsch/flint/subscribers","subscription_url":"https://api.github.com/repos/franklinsch/flint/subscription","commits_url":"https://api.github.com/repos/franklinsch/flint/commits{/sha}","git_commits_url":"https://api.github.com/repos/franklinsch/flint/git/commits{/sha}","comments_url":"https://api.github.com/repos/franklinsch/flint/comments{/number}","issue_comment_url":"https://api.github.com/repos/franklinsch/flint/issues/comments{/number}","contents_url":"https://api.github.com/repos/franklinsch/flint/contents/{+path}","compare_url":"https://api.github.com/repos/franklinsch/flint/compare/{base}...{head}","merges_url":"https://api.github.com/repos/franklinsch/flint/merges","archive_url":"https://api.github.com/repos/franklinsch/flint/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/franklinsch/flint/downloads","issues_url":"https://api.github.com/repos/franklinsch/flint/issues{/number}","pulls_url":"https://api.github.com/repos/franklinsch/flint/pulls{/number}","milestones_url":"https://api.github.com/repos/franklinsch/flint/milestones{/number}","notifications_url":"https://api.github.com/repos/franklinsch/flint/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/franklinsch/flint/labels{/name}","releases_url":"https://api.github.com/repos/franklinsch/flint/releases{/id}","deployments_url":"https://api.github.com/repos/franklinsch/flint/deployments","created_at":"2017-12-19T23:00:04Z","updated_at":"2018-07-04T09:53:10Z","pushed_at":"2018-07-04T15:39:22Z","git_url":"git://github.com/franklinsch/flint.git","ssh_url":"git@github.com:franklinsch/flint.git","clone_url":"https://github.com/franklinsch/flint.git","svn_url":"https://github.com/franklinsch/flint","homepage":"","size":1262,"stargazers_count":149,"watchers_count":149,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":true,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":50,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":5,"open_issues":50,"watchers":149,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/franklinsch/flint/pulls/228"},"html":{"href":"https://github.com/franklinsch/flint/pull/228"},"issue":{"href":"https://api.github.com/repos/franklinsch/flint/issues/228"},"comments":{"href":"https://api.github.com/repos/franklinsch/flint/issues/228/comments"},"review_comments":{"href":"https://api.github.com/repos/franklinsch/flint/pulls/228/comments"},"review_comment":{"href":"https://api.github.com/repos/franklinsch/flint/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/franklinsch/flint/pulls/228/commits"},"statuses":{"href":"https://api.github.com/repos/franklinsch/flint/statuses/6e692625b9d205bf8d5efb4a35c63c77cc38a232"}},"author_association":"NONE"}}
{"actor":{"display_login":"franklinsch"}}