{"action":"created","comment":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments/176623518","pull_request_review_id":106361088,"id":176623518,"diff_hunk":"@@ -135,12 +133,22 @@ private void SubscribeToEvents()\n \n         private void OnCommandsLogChanged(object sender, EventArgs e)\n         {\n-            _syncContext.Post(_ => RefreshLogItems(), null);\n+            ThreadHelper.JoinableTaskFactory.RunAsync(","path":"GitUI/CommandsDialogs/BrowseDialog/FormGitLog.cs","position":29,"original_position":29,"commit_id":"ea4c75d54af2f90ff4db2c651fec132c7078c362","original_commit_id":"ea4c75d54af2f90ff4db2c651fec132c7078c362","user":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"body":"> When should we apply FileAndForget. I think it should be applied here, otherwise exceptions will be swallowed.\r\n\r\nIt should be applied to all tasks which are not joined somewhere. I've proposed analyzers to aid in this effort but they are not yet implemented.","created_at":"2018-03-23T02:17:58Z","updated_at":"2018-03-23T02:17:58Z","html_url":"https://github.com/gitextensions/gitextensions/pull/4601#discussion_r176623518","pull_request_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4601","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments/176623518"},"html":{"href":"https://github.com/gitextensions/gitextensions/pull/4601#discussion_r176623518"},"pull_request":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4601"}},"in_reply_to_id":176540676},"pull_request":{"url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4601","id":173936901,"html_url":"https://github.com/gitextensions/gitextensions/pull/4601","diff_url":"https://github.com/gitextensions/gitextensions/pull/4601.diff","patch_url":"https://github.com/gitextensions/gitextensions/pull/4601.patch","issue_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/4601","number":4601,"state":"open","locked":false,"title":"[WIP] Adopt Microsoft.VisualStudio.Threading","user":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"body":"Adopts Microsoft.VisualStudio.Threading, an open source library for UI applications that use asynchronous operations.\r\n\r\n* Repository: [Microsoft/vs-threading](https://github.com/Microsoft/vs-threading)\r\n* Developers should be aware of the [Three Threading Rules](https://github.com/Microsoft/vs-threading/blob/master/doc/threading_rules.md)\r\n* Several analyzers are included to help identify problems early in the development process: https://github.com/Microsoft/vs-threading/blob/master/doc/analyzers/index.md\r\n\r\nThe code is updated to address all warnings reported by analyzers in the project. The most challenging part was updating the use of Reactive Extensions to work with `JoinableTaskFactory`. I have not yet verified that the test code sets the `JoinableTaskFactory` for use in tests. There may also be some packaging updates required to include the dependencies for distribution.\r\n\r\n📝 If accepted, please do not rebase or squash this pull request during the merge.\r\n\r\n/cc @AArnott ","created_at":"2018-03-09T07:28:04Z","updated_at":"2018-03-23T02:17:58Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ae416084c2c944495e26e4b3b5372a5b6c093061","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4601/commits","review_comments_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4601/comments","review_comment_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/4601/comments","statuses_url":"https://api.github.com/repos/gitextensions/gitextensions/statuses/ea4c75d54af2f90ff4db2c651fec132c7078c362","head":{"label":"sharwell:vs-threading","ref":"vs-threading","sha":"ea4c75d54af2f90ff4db2c651fec132c7078c362","user":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"repo":{"id":12352888,"name":"gitextensions","full_name":"sharwell/gitextensions","owner":{"login":"sharwell","id":1408396,"avatar_url":"https://avatars1.githubusercontent.com/u/1408396?v=4","gravatar_id":"","url":"https://api.github.com/users/sharwell","html_url":"https://github.com/sharwell","followers_url":"https://api.github.com/users/sharwell/followers","following_url":"https://api.github.com/users/sharwell/following{/other_user}","gists_url":"https://api.github.com/users/sharwell/gists{/gist_id}","starred_url":"https://api.github.com/users/sharwell/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sharwell/subscriptions","organizations_url":"https://api.github.com/users/sharwell/orgs","repos_url":"https://api.github.com/users/sharwell/repos","events_url":"https://api.github.com/users/sharwell/events{/privacy}","received_events_url":"https://api.github.com/users/sharwell/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sharwell/gitextensions","description":"GitExtensions is a shell extension, a Visual Studio 2008/2010/2012 plugin and a standalone Git repository tool.","fork":true,"url":"https://api.github.com/repos/sharwell/gitextensions","forks_url":"https://api.github.com/repos/sharwell/gitextensions/forks","keys_url":"https://api.github.com/repos/sharwell/gitextensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sharwell/gitextensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sharwell/gitextensions/teams","hooks_url":"https://api.github.com/repos/sharwell/gitextensions/hooks","issue_events_url":"https://api.github.com/repos/sharwell/gitextensions/issues/events{/number}","events_url":"https://api.github.com/repos/sharwell/gitextensions/events","assignees_url":"https://api.github.com/repos/sharwell/gitextensions/assignees{/user}","branches_url":"https://api.github.com/repos/sharwell/gitextensions/branches{/branch}","tags_url":"https://api.github.com/repos/sharwell/gitextensions/tags","blobs_url":"https://api.github.com/repos/sharwell/gitextensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sharwell/gitextensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sharwell/gitextensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/sharwell/gitextensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sharwell/gitextensions/statuses/{sha}","languages_url":"https://api.github.com/repos/sharwell/gitextensions/languages","stargazers_url":"https://api.github.com/repos/sharwell/gitextensions/stargazers","contributors_url":"https://api.github.com/repos/sharwell/gitextensions/contributors","subscribers_url":"https://api.github.com/repos/sharwell/gitextensions/subscribers","subscription_url":"https://api.github.com/repos/sharwell/gitextensions/subscription","commits_url":"https://api.github.com/repos/sharwell/gitextensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/sharwell/gitextensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/sharwell/gitextensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/sharwell/gitextensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/sharwell/gitextensions/contents/{+path}","compare_url":"https://api.github.com/repos/sharwell/gitextensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sharwell/gitextensions/merges","archive_url":"https://api.github.com/repos/sharwell/gitextensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sharwell/gitextensions/downloads","issues_url":"https://api.github.com/repos/sharwell/gitextensions/issues{/number}","pulls_url":"https://api.github.com/repos/sharwell/gitextensions/pulls{/number}","milestones_url":"https://api.github.com/repos/sharwell/gitextensions/milestones{/number}","notifications_url":"https://api.github.com/repos/sharwell/gitextensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sharwell/gitextensions/labels{/name}","releases_url":"https://api.github.com/repos/sharwell/gitextensions/releases{/id}","deployments_url":"https://api.github.com/repos/sharwell/gitextensions/deployments","created_at":"2013-08-25T02:15:15Z","updated_at":"2015-07-25T05:18:38Z","pushed_at":"2018-03-22T14:58:24Z","git_url":"git://github.com/sharwell/gitextensions.git","ssh_url":"git@github.com:sharwell/gitextensions.git","clone_url":"https://github.com/sharwell/gitextensions.git","svn_url":"https://github.com/sharwell/gitextensions","homepage":"http://code.google.com/p/gitextensions","size":457165,"stargazers_count":0,"watchers_count":0,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"gitextensions:master","ref":"master","sha":"2cdaf3fb31b9a89d866ad68579f4449fd0e0f437","user":{"login":"gitextensions","id":1700077,"avatar_url":"https://avatars2.githubusercontent.com/u/1700077?v=4","gravatar_id":"","url":"https://api.github.com/users/gitextensions","html_url":"https://github.com/gitextensions","followers_url":"https://api.github.com/users/gitextensions/followers","following_url":"https://api.github.com/users/gitextensions/following{/other_user}","gists_url":"https://api.github.com/users/gitextensions/gists{/gist_id}","starred_url":"https://api.github.com/users/gitextensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitextensions/subscriptions","organizations_url":"https://api.github.com/users/gitextensions/orgs","repos_url":"https://api.github.com/users/gitextensions/repos","events_url":"https://api.github.com/users/gitextensions/events{/privacy}","received_events_url":"https://api.github.com/users/gitextensions/received_events","type":"Organization","site_admin":false},"repo":{"id":85953,"name":"gitextensions","full_name":"gitextensions/gitextensions","owner":{"login":"gitextensions","id":1700077,"avatar_url":"https://avatars2.githubusercontent.com/u/1700077?v=4","gravatar_id":"","url":"https://api.github.com/users/gitextensions","html_url":"https://github.com/gitextensions","followers_url":"https://api.github.com/users/gitextensions/followers","following_url":"https://api.github.com/users/gitextensions/following{/other_user}","gists_url":"https://api.github.com/users/gitextensions/gists{/gist_id}","starred_url":"https://api.github.com/users/gitextensions/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gitextensions/subscriptions","organizations_url":"https://api.github.com/users/gitextensions/orgs","repos_url":"https://api.github.com/users/gitextensions/repos","events_url":"https://api.github.com/users/gitextensions/events{/privacy}","received_events_url":"https://api.github.com/users/gitextensions/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/gitextensions/gitextensions","description":"Git Extensions is a standalone UI tool for managing git repositories. It also integrates with Windows Explorer and Microsoft Visual Studio (2010/2012/2013/2015/2017).","fork":false,"url":"https://api.github.com/repos/gitextensions/gitextensions","forks_url":"https://api.github.com/repos/gitextensions/gitextensions/forks","keys_url":"https://api.github.com/repos/gitextensions/gitextensions/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gitextensions/gitextensions/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gitextensions/gitextensions/teams","hooks_url":"https://api.github.com/repos/gitextensions/gitextensions/hooks","issue_events_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/events{/number}","events_url":"https://api.github.com/repos/gitextensions/gitextensions/events","assignees_url":"https://api.github.com/repos/gitextensions/gitextensions/assignees{/user}","branches_url":"https://api.github.com/repos/gitextensions/gitextensions/branches{/branch}","tags_url":"https://api.github.com/repos/gitextensions/gitextensions/tags","blobs_url":"https://api.github.com/repos/gitextensions/gitextensions/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gitextensions/gitextensions/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gitextensions/gitextensions/git/refs{/sha}","trees_url":"https://api.github.com/repos/gitextensions/gitextensions/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gitextensions/gitextensions/statuses/{sha}","languages_url":"https://api.github.com/repos/gitextensions/gitextensions/languages","stargazers_url":"https://api.github.com/repos/gitextensions/gitextensions/stargazers","contributors_url":"https://api.github.com/repos/gitextensions/gitextensions/contributors","subscribers_url":"https://api.github.com/repos/gitextensions/gitextensions/subscribers","subscription_url":"https://api.github.com/repos/gitextensions/gitextensions/subscription","commits_url":"https://api.github.com/repos/gitextensions/gitextensions/commits{/sha}","git_commits_url":"https://api.github.com/repos/gitextensions/gitextensions/git/commits{/sha}","comments_url":"https://api.github.com/repos/gitextensions/gitextensions/comments{/number}","issue_comment_url":"https://api.github.com/repos/gitextensions/gitextensions/issues/comments{/number}","contents_url":"https://api.github.com/repos/gitextensions/gitextensions/contents/{+path}","compare_url":"https://api.github.com/repos/gitextensions/gitextensions/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gitextensions/gitextensions/merges","archive_url":"https://api.github.com/repos/gitextensions/gitextensions/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gitextensions/gitextensions/downloads","issues_url":"https://api.github.com/repos/gitextensions/gitextensions/issues{/number}","pulls_url":"https://api.github.com/repos/gitextensions/gitextensions/pulls{/number}","milestones_url":"https://api.github.com/repos/gitextensions/gitextensions/milestones{/number}","notifications_url":"https://api.github.com/repos/gitextensions/gitextensions/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gitextensions/gitextensions/labels{/name}","releases_url":"https://api.github.com/repos/gitextensions/gitextensions/releases{/id}","deployments_url":"https://api.github.com/repos/gitextensions/gitextensions/deployments","created_at":"2008-12-06T09:18:59Z","updated_at":"2018-03-22T18:33:00Z","pushed_at":"2018-03-22T20:33:20Z","git_url":"git://github.com/gitextensions/gitextensions.git","ssh_url":"git@github.com:gitextensions/gitextensions.git","clone_url":"https://github.com/gitextensions/gitextensions.git","svn_url":"https://github.com/gitextensions/gitextensions","homepage":"http://gitextensions.github.io/","size":71985,"stargazers_count":2675,"watchers_count":2675,"language":"C#","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":973,"mirror_url":null,"archived":false,"open_issues_count":671,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":973,"open_issues":671,"watchers":2675,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4601"},"html":{"href":"https://github.com/gitextensions/gitextensions/pull/4601"},"issue":{"href":"https://api.github.com/repos/gitextensions/gitextensions/issues/4601"},"comments":{"href":"https://api.github.com/repos/gitextensions/gitextensions/issues/4601/comments"},"review_comments":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4601/comments"},"review_comment":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gitextensions/gitextensions/pulls/4601/commits"},"statuses":{"href":"https://api.github.com/repos/gitextensions/gitextensions/statuses/ea4c75d54af2f90ff4db2c651fec132c7078c362"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"sharwell"}}