{"action":"created","comment":{"url":"https://api.github.com/repos/kiegroup/drools/pulls/comments/230745945","pull_request_review_id":171550165,"id":230745945,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDc0NTk0NQ==","diff_hunk":"@@ -1122,6 +1122,8 @@ public void reset() {\n         this.processRuntime = null;\n \n         this.initialFactHandle = initInitialFact(kBase, null);\n+\n+        this.alive = true;","path":"drools-core/src/main/java/org/drools/core/impl/StatefulKnowledgeSessionImpl.java","position":5,"original_position":5,"commit_id":"2b4e5eba8cc5986f02b308f7df06f8ada62ae871","original_commit_id":"2b4e5eba8cc5986f02b308f7df06f8ada62ae871","user":{"login":"mariofusco","id":372781,"node_id":"MDQ6VXNlcjM3Mjc4MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/372781?v=4","gravatar_id":"","url":"https://api.github.com/users/mariofusco","html_url":"https://github.com/mariofusco","followers_url":"https://api.github.com/users/mariofusco/followers","following_url":"https://api.github.com/users/mariofusco/following{/other_user}","gists_url":"https://api.github.com/users/mariofusco/gists{/gist_id}","starred_url":"https://api.github.com/users/mariofusco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mariofusco/subscriptions","organizations_url":"https://api.github.com/users/mariofusco/orgs","repos_url":"https://api.github.com/users/mariofusco/repos","events_url":"https://api.github.com/users/mariofusco/events{/privacy}","received_events_url":"https://api.github.com/users/mariofusco/received_events","type":"User","site_admin":false},"body":"I cannot do this. If I'd do this it would be possible to keep using a KieSession created from a pool even after it has been disposed.","created_at":"2018-11-05T13:20:51Z","updated_at":"2018-11-05T13:20:51Z","html_url":"https://github.com/kiegroup/drools/pull/2135#discussion_r230745945","pull_request_url":"https://api.github.com/repos/kiegroup/drools/pulls/2135","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/comments/230745945"},"html":{"href":"https://github.com/kiegroup/drools/pull/2135#discussion_r230745945"},"pull_request":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/2135"}}},"pull_request":{"url":"https://api.github.com/repos/kiegroup/drools/pulls/2135","id":228112175,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI4MTEyMTc1","html_url":"https://github.com/kiegroup/drools/pull/2135","diff_url":"https://github.com/kiegroup/drools/pull/2135.diff","patch_url":"https://github.com/kiegroup/drools/pull/2135.patch","issue_url":"https://api.github.com/repos/kiegroup/drools/issues/2135","number":2135,"state":"open","locked":false,"title":"DROOLS-3228: Rules don't produce the correct result anymore after a session reset","user":{"login":"liebharc","id":544520,"node_id":"MDQ6VXNlcjU0NDUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/544520?v=4","gravatar_id":"","url":"https://api.github.com/users/liebharc","html_url":"https://github.com/liebharc","followers_url":"https://api.github.com/users/liebharc/followers","following_url":"https://api.github.com/users/liebharc/following{/other_user}","gists_url":"https://api.github.com/users/liebharc/gists{/gist_id}","starred_url":"https://api.github.com/users/liebharc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liebharc/subscriptions","organizations_url":"https://api.github.com/users/liebharc/orgs","repos_url":"https://api.github.com/users/liebharc/repos","events_url":"https://api.github.com/users/liebharc/events{/privacy}","received_events_url":"https://api.github.com/users/liebharc/received_events","type":"User","site_admin":false},"body":"Hello,\r\n\r\nI did some further investigations on the issue reported with https://issues.jboss.org/browse/DROOLS-3228 . For the main issue it seems that just the order _memory.getSegmentMemory()_ and  _memory.reset()_ must be maintained (as it was with Drools 7.12.0.Final). \r\n\r\nI've also found another issue with session reset in that a sequential session can't be used anymore after a reset as it refuses to add new elements to the agend group queue. \r\n\r\nExecuting https://github.com/liebharc/JavaRules/blob/master/src/test/java/com/github/liebharc/JavaRules/UnitTestBase.java should show all the described issues as test failures.\r\n\r\nThere doesn't seem to be specific test cases for AgendaGroupQueueImpl and ConcurrentNodeMemories - or at least I couldn't find them. \r\n\r\nI'm looking forward to hear your thoughts.","created_at":"2018-11-03T10:51:27Z","updated_at":"2018-11-05T13:20:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71c92acb0c007188c504e0488ffb63de256bd644","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiegroup/drools/pulls/2135/commits","review_comments_url":"https://api.github.com/repos/kiegroup/drools/pulls/2135/comments","review_comment_url":"https://api.github.com/repos/kiegroup/drools/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiegroup/drools/issues/2135/comments","statuses_url":"https://api.github.com/repos/kiegroup/drools/statuses/2b4e5eba8cc5986f02b308f7df06f8ada62ae871","head":{"label":"liebharc:master","ref":"master","sha":"2b4e5eba8cc5986f02b308f7df06f8ada62ae871","user":{"login":"liebharc","id":544520,"node_id":"MDQ6VXNlcjU0NDUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/544520?v=4","gravatar_id":"","url":"https://api.github.com/users/liebharc","html_url":"https://github.com/liebharc","followers_url":"https://api.github.com/users/liebharc/followers","following_url":"https://api.github.com/users/liebharc/following{/other_user}","gists_url":"https://api.github.com/users/liebharc/gists{/gist_id}","starred_url":"https://api.github.com/users/liebharc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liebharc/subscriptions","organizations_url":"https://api.github.com/users/liebharc/orgs","repos_url":"https://api.github.com/users/liebharc/repos","events_url":"https://api.github.com/users/liebharc/events{/privacy}","received_events_url":"https://api.github.com/users/liebharc/received_events","type":"User","site_admin":false},"repo":{"id":155972244,"node_id":"MDEwOlJlcG9zaXRvcnkxNTU5NzIyNDQ=","name":"drools","full_name":"liebharc/drools","private":false,"owner":{"login":"liebharc","id":544520,"node_id":"MDQ6VXNlcjU0NDUyMA==","avatar_url":"https://avatars1.githubusercontent.com/u/544520?v=4","gravatar_id":"","url":"https://api.github.com/users/liebharc","html_url":"https://github.com/liebharc","followers_url":"https://api.github.com/users/liebharc/followers","following_url":"https://api.github.com/users/liebharc/following{/other_user}","gists_url":"https://api.github.com/users/liebharc/gists{/gist_id}","starred_url":"https://api.github.com/users/liebharc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/liebharc/subscriptions","organizations_url":"https://api.github.com/users/liebharc/orgs","repos_url":"https://api.github.com/users/liebharc/repos","events_url":"https://api.github.com/users/liebharc/events{/privacy}","received_events_url":"https://api.github.com/users/liebharc/received_events","type":"User","site_admin":false},"html_url":"https://github.com/liebharc/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":true,"url":"https://api.github.com/repos/liebharc/drools","forks_url":"https://api.github.com/repos/liebharc/drools/forks","keys_url":"https://api.github.com/repos/liebharc/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/liebharc/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/liebharc/drools/teams","hooks_url":"https://api.github.com/repos/liebharc/drools/hooks","issue_events_url":"https://api.github.com/repos/liebharc/drools/issues/events{/number}","events_url":"https://api.github.com/repos/liebharc/drools/events","assignees_url":"https://api.github.com/repos/liebharc/drools/assignees{/user}","branches_url":"https://api.github.com/repos/liebharc/drools/branches{/branch}","tags_url":"https://api.github.com/repos/liebharc/drools/tags","blobs_url":"https://api.github.com/repos/liebharc/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/liebharc/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/liebharc/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/liebharc/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/liebharc/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/liebharc/drools/languages","stargazers_url":"https://api.github.com/repos/liebharc/drools/stargazers","contributors_url":"https://api.github.com/repos/liebharc/drools/contributors","subscribers_url":"https://api.github.com/repos/liebharc/drools/subscribers","subscription_url":"https://api.github.com/repos/liebharc/drools/subscription","commits_url":"https://api.github.com/repos/liebharc/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/liebharc/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/liebharc/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/liebharc/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/liebharc/drools/contents/{+path}","compare_url":"https://api.github.com/repos/liebharc/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/liebharc/drools/merges","archive_url":"https://api.github.com/repos/liebharc/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/liebharc/drools/downloads","issues_url":"https://api.github.com/repos/liebharc/drools/issues{/number}","pulls_url":"https://api.github.com/repos/liebharc/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/liebharc/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/liebharc/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/liebharc/drools/labels{/name}","releases_url":"https://api.github.com/repos/liebharc/drools/releases{/id}","deployments_url":"https://api.github.com/repos/liebharc/drools/deployments","created_at":"2018-11-03T10:23:56Z","updated_at":"2018-11-03T10:33:37Z","pushed_at":"2018-11-04T10:18:40Z","git_url":"git://github.com/liebharc/drools.git","ssh_url":"git@github.com:liebharc/drools.git","clone_url":"https://github.com/liebharc/drools.git","svn_url":"https://github.com/liebharc/drools","homepage":"http://www.drools.org","size":159902,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiegroup:master","ref":"master","sha":"9bc76ec94c4acde977104aa5255b9ad86ec8d285","user":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"repo":{"id":1381673,"node_id":"MDEwOlJlcG9zaXRvcnkxMzgxNjcz","name":"drools","full_name":"kiegroup/drools","private":false,"owner":{"login":"kiegroup","id":517980,"node_id":"MDEyOk9yZ2FuaXphdGlvbjUxNzk4MA==","avatar_url":"https://avatars3.githubusercontent.com/u/517980?v=4","gravatar_id":"","url":"https://api.github.com/users/kiegroup","html_url":"https://github.com/kiegroup","followers_url":"https://api.github.com/users/kiegroup/followers","following_url":"https://api.github.com/users/kiegroup/following{/other_user}","gists_url":"https://api.github.com/users/kiegroup/gists{/gist_id}","starred_url":"https://api.github.com/users/kiegroup/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiegroup/subscriptions","organizations_url":"https://api.github.com/users/kiegroup/orgs","repos_url":"https://api.github.com/users/kiegroup/repos","events_url":"https://api.github.com/users/kiegroup/events{/privacy}","received_events_url":"https://api.github.com/users/kiegroup/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kiegroup/drools","description":"Drools Expert is the rule engine and Drools Fusion does complex event processing (CEP).","fork":false,"url":"https://api.github.com/repos/kiegroup/drools","forks_url":"https://api.github.com/repos/kiegroup/drools/forks","keys_url":"https://api.github.com/repos/kiegroup/drools/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiegroup/drools/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiegroup/drools/teams","hooks_url":"https://api.github.com/repos/kiegroup/drools/hooks","issue_events_url":"https://api.github.com/repos/kiegroup/drools/issues/events{/number}","events_url":"https://api.github.com/repos/kiegroup/drools/events","assignees_url":"https://api.github.com/repos/kiegroup/drools/assignees{/user}","branches_url":"https://api.github.com/repos/kiegroup/drools/branches{/branch}","tags_url":"https://api.github.com/repos/kiegroup/drools/tags","blobs_url":"https://api.github.com/repos/kiegroup/drools/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiegroup/drools/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiegroup/drools/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiegroup/drools/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiegroup/drools/statuses/{sha}","languages_url":"https://api.github.com/repos/kiegroup/drools/languages","stargazers_url":"https://api.github.com/repos/kiegroup/drools/stargazers","contributors_url":"https://api.github.com/repos/kiegroup/drools/contributors","subscribers_url":"https://api.github.com/repos/kiegroup/drools/subscribers","subscription_url":"https://api.github.com/repos/kiegroup/drools/subscription","commits_url":"https://api.github.com/repos/kiegroup/drools/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiegroup/drools/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiegroup/drools/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiegroup/drools/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiegroup/drools/contents/{+path}","compare_url":"https://api.github.com/repos/kiegroup/drools/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiegroup/drools/merges","archive_url":"https://api.github.com/repos/kiegroup/drools/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiegroup/drools/downloads","issues_url":"https://api.github.com/repos/kiegroup/drools/issues{/number}","pulls_url":"https://api.github.com/repos/kiegroup/drools/pulls{/number}","milestones_url":"https://api.github.com/repos/kiegroup/drools/milestones{/number}","notifications_url":"https://api.github.com/repos/kiegroup/drools/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiegroup/drools/labels{/name}","releases_url":"https://api.github.com/repos/kiegroup/drools/releases{/id}","deployments_url":"https://api.github.com/repos/kiegroup/drools/deployments","created_at":"2011-02-18T08:37:05Z","updated_at":"2018-11-05T11:39:12Z","pushed_at":"2018-11-05T07:46:28Z","git_url":"git://github.com/kiegroup/drools.git","ssh_url":"git@github.com:kiegroup/drools.git","clone_url":"https://github.com/kiegroup/drools.git","svn_url":"https://github.com/kiegroup/drools","homepage":"http://www.drools.org","size":159908,"stargazers_count":1789,"watchers_count":1789,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1493,"mirror_url":null,"archived":false,"open_issues_count":7,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1493,"open_issues":7,"watchers":1789,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/2135"},"html":{"href":"https://github.com/kiegroup/drools/pull/2135"},"issue":{"href":"https://api.github.com/repos/kiegroup/drools/issues/2135"},"comments":{"href":"https://api.github.com/repos/kiegroup/drools/issues/2135/comments"},"review_comments":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/2135/comments"},"review_comment":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiegroup/drools/pulls/2135/commits"},"statuses":{"href":"https://api.github.com/repos/kiegroup/drools/statuses/2b4e5eba8cc5986f02b308f7df06f8ada62ae871"}},"author_association":"NONE"}}
{"actor":{"display_login":"mariofusco"}}