{"action":"created","comment":{"url":"https://api.github.com/repos/kiwix/kiwix-android/pulls/comments/168673519","pull_request_review_id":97080920,"id":168673519,"diff_hunk":"@@ -5,13 +5,108 @@\n   <dimen name=\"activity_vertical_margin\">16dp</dimen>\n   <dimen name=\"dimen_small_padding\">4dp</dimen>\n   <dimen name=\"dimen_medium_padding\">8dp</dimen>\n+  <dimen name=\"dimen_big_padding\">16dp</dimen>\n   <dimen name=\"navigation_width\">260dp</dimen>\n   <dimen name=\"widget_margin\">0dp</dimen>\n   <dimen name=\"fab_margin\">16dp</dimen>\n   <dimen name=\"appbar_padding_top\">8dp</dimen>\n   <dimen name=\"abc_search_view_text_min_width\">160dip</dimen>\n   <dimen name=\"abc_dropdownitem_text_padding_left\">8dip</dimen>\n   <dimen name=\"abc_dropdownitem_text_padding_right\">8dip</dimen>\n+  <dimen name=\"ic_star_yellow_width\">100dp</dimen>\n+  <dimen name=\"ic_star_yellow_height\">100dp</dimen>\n+  <dimen name=\"activity_bookmarks_bottom_padding\">15dp</dimen>\n+  <dimen name=\"activity_bookmarks_padding_left\">10dp</dimen>\n+  <dimen name=\"activity_bookmarks_padding_right\">10dp</dimen>\n+  <dimen name=\"activity_bookmarks_padding_top\">15dp</dimen>\n+  <dimen name=\"network_permission_text_margin_top\">200dp</dimen>\n+  <dimen name=\"network_permission_button_margin_top\">230dp</dimen>\n+  <dimen name=\"library_list_padding_bottom\">60dp</dimen>\n+  <dimen name=\"bookmark_tab_icon_width\">24dp</dimen>\n+  <dimen name=\"bookmark_tab_icon_height\">24dp</dimen>\n+  <dimen name=\"bookmark_title_margin\">15dp</dimen>\n+  <dimen name=\"bookmark_title_text_size\">15sp</dimen>\n+  <dimen name=\"content_header_margin_left\">16dp</dimen>\n+  <dimen name=\"content_header_margin_right\">16dp</dimen>\n+  <dimen name=\"favicon_width\">48dp</dimen>\n+  <dimen name=\"download_item_linear_layout_width\">0dp</dimen>\n+  <dimen name=\"download_progress_padding\">1dp</dimen>\n+  <dimen name=\"pause_min_height\">35dp</dimen>\n+  <dimen name=\"pause_min_width\">35dp</dimen>\n+  <dimen name=\"stop_min_width\">35dp</dimen>\n+  <dimen name=\"stop_min_height\">35dp</dimen>\n+  <dimen name=\"stop_margin_left\">8dp</dimen>\n+  <dimen name=\"stop_margin_right\">8dp</dimen>\n+  <dimen name=\"download_management_no_downloads_padding_bottom\">75dp</dimen>\n+  <dimen name=\"download_management_no_downloads_text_size\">20sp</dimen>\n+  <dimen name=\"drawer_left_view_height\">1dp</dimen>\n+  <dimen name=\"left_drawer_list_divider_height\">0dp</dimen>\n+  <dimen name=\"left_drawer_list_height\">0dp</dimen>\n+  <dimen name=\"drawer_left_line_view_height\">1dp</dimen>\n+  <dimen name=\"action_back_button_padding_button\">4dp</dimen>\n+  <dimen name=\"action_back_button_padding_left\">4dp</dimen>\n+  <dimen name=\"action_back_button_padding_right\">4dp</dimen>\n+  <dimen name=\"action_back_button_padding_top\">4dp</dimen>\n+  <dimen name=\"plus_drawable_padding_bottom\">4dp</dimen>\n+  <dimen name=\"plus_drawable_padding_left\">4dp</dimen>\n+  <dimen name=\"plus_drawable_padding_right\">4dp</dimen>\n+  <dimen name=\"plus_drawable_padding_top\">4dp</dimen>\n+  <dimen name=\"action_forward_button_padding_bottom\">4dp</dimen>\n+  <dimen name=\"action_forward_button_padding_left\">4dp</dimen>\n+  <dimen name=\"action_forward_button_padding_right\">4dp</dimen>","path":"app/src/main/res/values/dimens.xml","position":52,"original_position":52,"commit_id":"09bcc0df3918c3ccd09fa308d7bea65224369c8a","original_commit_id":"09bcc0df3918c3ccd09fa308d7bea65224369c8a","user":{"login":"brijeshshah13","id":18366144,"avatar_url":"https://avatars2.githubusercontent.com/u/18366144?v=4","gravatar_id":"","url":"https://api.github.com/users/brijeshshah13","html_url":"https://github.com/brijeshshah13","followers_url":"https://api.github.com/users/brijeshshah13/followers","following_url":"https://api.github.com/users/brijeshshah13/following{/other_user}","gists_url":"https://api.github.com/users/brijeshshah13/gists{/gist_id}","starred_url":"https://api.github.com/users/brijeshshah13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijeshshah13/subscriptions","organizations_url":"https://api.github.com/users/brijeshshah13/orgs","repos_url":"https://api.github.com/users/brijeshshah13/repos","events_url":"https://api.github.com/users/brijeshshah13/events{/privacy}","received_events_url":"https://api.github.com/users/brijeshshah13/received_events","type":"User","site_admin":false},"body":"The whole purpose of declaring different dimensions with same value for each View was to obtain the flexibility to change that respective value any time without any hassle.\r\n@srv-twry @mhutti1 Still, shall I change those?","created_at":"2018-02-16T04:28:34Z","updated_at":"2018-02-16T04:28:34Z","html_url":"https://github.com/kiwix/kiwix-android/pull/415#discussion_r168673519","pull_request_url":"https://api.github.com/repos/kiwix/kiwix-android/pulls/415","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kiwix/kiwix-android/pulls/comments/168673519"},"html":{"href":"https://github.com/kiwix/kiwix-android/pull/415#discussion_r168673519"},"pull_request":{"href":"https://api.github.com/repos/kiwix/kiwix-android/pulls/415"}},"in_reply_to_id":168652564},"pull_request":{"url":"https://api.github.com/repos/kiwix/kiwix-android/pulls/415","id":169478743,"html_url":"https://github.com/kiwix/kiwix-android/pull/415","diff_url":"https://github.com/kiwix/kiwix-android/pull/415.diff","patch_url":"https://github.com/kiwix/kiwix-android/pull/415.patch","issue_url":"https://api.github.com/repos/kiwix/kiwix-android/issues/415","number":415,"state":"open","locked":false,"title":"refactor: Extract dimensions of resources","user":{"login":"brijeshshah13","id":18366144,"avatar_url":"https://avatars2.githubusercontent.com/u/18366144?v=4","gravatar_id":"","url":"https://api.github.com/users/brijeshshah13","html_url":"https://github.com/brijeshshah13","followers_url":"https://api.github.com/users/brijeshshah13/followers","following_url":"https://api.github.com/users/brijeshshah13/following{/other_user}","gists_url":"https://api.github.com/users/brijeshshah13/gists{/gist_id}","starred_url":"https://api.github.com/users/brijeshshah13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijeshshah13/subscriptions","organizations_url":"https://api.github.com/users/brijeshshah13/orgs","repos_url":"https://api.github.com/users/brijeshshah13/repos","events_url":"https://api.github.com/users/brijeshshah13/events{/privacy}","received_events_url":"https://api.github.com/users/brijeshshah13/received_events","type":"User","site_admin":false},"body":"Fixes #413.","created_at":"2018-02-15T20:37:12Z","updated_at":"2018-02-16T04:28:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a7336e894cb9b20f4c48dcc23c0a7f658b549a12","assignee":{"login":"mhutti1","id":2286937,"avatar_url":"https://avatars1.githubusercontent.com/u/2286937?v=4","gravatar_id":"","url":"https://api.github.com/users/mhutti1","html_url":"https://github.com/mhutti1","followers_url":"https://api.github.com/users/mhutti1/followers","following_url":"https://api.github.com/users/mhutti1/following{/other_user}","gists_url":"https://api.github.com/users/mhutti1/gists{/gist_id}","starred_url":"https://api.github.com/users/mhutti1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhutti1/subscriptions","organizations_url":"https://api.github.com/users/mhutti1/orgs","repos_url":"https://api.github.com/users/mhutti1/repos","events_url":"https://api.github.com/users/mhutti1/events{/privacy}","received_events_url":"https://api.github.com/users/mhutti1/received_events","type":"User","site_admin":false},"assignees":[{"login":"mhutti1","id":2286937,"avatar_url":"https://avatars1.githubusercontent.com/u/2286937?v=4","gravatar_id":"","url":"https://api.github.com/users/mhutti1","html_url":"https://github.com/mhutti1","followers_url":"https://api.github.com/users/mhutti1/followers","following_url":"https://api.github.com/users/mhutti1/following{/other_user}","gists_url":"https://api.github.com/users/mhutti1/gists{/gist_id}","starred_url":"https://api.github.com/users/mhutti1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mhutti1/subscriptions","organizations_url":"https://api.github.com/users/mhutti1/orgs","repos_url":"https://api.github.com/users/mhutti1/repos","events_url":"https://api.github.com/users/mhutti1/events{/privacy}","received_events_url":"https://api.github.com/users/mhutti1/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kiwix/kiwix-android/pulls/415/commits","review_comments_url":"https://api.github.com/repos/kiwix/kiwix-android/pulls/415/comments","review_comment_url":"https://api.github.com/repos/kiwix/kiwix-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kiwix/kiwix-android/issues/415/comments","statuses_url":"https://api.github.com/repos/kiwix/kiwix-android/statuses/09bcc0df3918c3ccd09fa308d7bea65224369c8a","head":{"label":"brijeshshah13:master","ref":"master","sha":"09bcc0df3918c3ccd09fa308d7bea65224369c8a","user":{"login":"brijeshshah13","id":18366144,"avatar_url":"https://avatars2.githubusercontent.com/u/18366144?v=4","gravatar_id":"","url":"https://api.github.com/users/brijeshshah13","html_url":"https://github.com/brijeshshah13","followers_url":"https://api.github.com/users/brijeshshah13/followers","following_url":"https://api.github.com/users/brijeshshah13/following{/other_user}","gists_url":"https://api.github.com/users/brijeshshah13/gists{/gist_id}","starred_url":"https://api.github.com/users/brijeshshah13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijeshshah13/subscriptions","organizations_url":"https://api.github.com/users/brijeshshah13/orgs","repos_url":"https://api.github.com/users/brijeshshah13/repos","events_url":"https://api.github.com/users/brijeshshah13/events{/privacy}","received_events_url":"https://api.github.com/users/brijeshshah13/received_events","type":"User","site_admin":false},"repo":{"id":121613964,"name":"kiwix-android","full_name":"brijeshshah13/kiwix-android","owner":{"login":"brijeshshah13","id":18366144,"avatar_url":"https://avatars2.githubusercontent.com/u/18366144?v=4","gravatar_id":"","url":"https://api.github.com/users/brijeshshah13","html_url":"https://github.com/brijeshshah13","followers_url":"https://api.github.com/users/brijeshshah13/followers","following_url":"https://api.github.com/users/brijeshshah13/following{/other_user}","gists_url":"https://api.github.com/users/brijeshshah13/gists{/gist_id}","starred_url":"https://api.github.com/users/brijeshshah13/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brijeshshah13/subscriptions","organizations_url":"https://api.github.com/users/brijeshshah13/orgs","repos_url":"https://api.github.com/users/brijeshshah13/repos","events_url":"https://api.github.com/users/brijeshshah13/events{/privacy}","received_events_url":"https://api.github.com/users/brijeshshah13/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/brijeshshah13/kiwix-android","description":"Kiwix port for offline on Android","fork":true,"url":"https://api.github.com/repos/brijeshshah13/kiwix-android","forks_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/forks","keys_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/teams","hooks_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/hooks","issue_events_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/issues/events{/number}","events_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/events","assignees_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/assignees{/user}","branches_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/branches{/branch}","tags_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/tags","blobs_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/statuses/{sha}","languages_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/languages","stargazers_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/stargazers","contributors_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/contributors","subscribers_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/subscribers","subscription_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/subscription","commits_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/contents/{+path}","compare_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/merges","archive_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/downloads","issues_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/issues{/number}","pulls_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/pulls{/number}","milestones_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/milestones{/number}","notifications_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/labels{/name}","releases_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/releases{/id}","deployments_url":"https://api.github.com/repos/brijeshshah13/kiwix-android/deployments","created_at":"2018-02-15T10:02:32Z","updated_at":"2018-02-15T10:02:35Z","pushed_at":"2018-02-16T00:48:35Z","git_url":"git://github.com/brijeshshah13/kiwix-android.git","ssh_url":"git@github.com:brijeshshah13/kiwix-android.git","clone_url":"https://github.com/brijeshshah13/kiwix-android.git","svn_url":"https://github.com/brijeshshah13/kiwix-android","homepage":"http://android.kiwix.org","size":148572,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kiwix:master","ref":"master","sha":"8827e6082dcf305646335b739f110bc9fccc585b","user":{"login":"kiwix","id":826219,"avatar_url":"https://avatars3.githubusercontent.com/u/826219?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwix","html_url":"https://github.com/kiwix","followers_url":"https://api.github.com/users/kiwix/followers","following_url":"https://api.github.com/users/kiwix/following{/other_user}","gists_url":"https://api.github.com/users/kiwix/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwix/subscriptions","organizations_url":"https://api.github.com/users/kiwix/orgs","repos_url":"https://api.github.com/users/kiwix/repos","events_url":"https://api.github.com/users/kiwix/events{/privacy}","received_events_url":"https://api.github.com/users/kiwix/received_events","type":"Organization","site_admin":false},"repo":{"id":79377628,"name":"kiwix-android","full_name":"kiwix/kiwix-android","owner":{"login":"kiwix","id":826219,"avatar_url":"https://avatars3.githubusercontent.com/u/826219?v=4","gravatar_id":"","url":"https://api.github.com/users/kiwix","html_url":"https://github.com/kiwix","followers_url":"https://api.github.com/users/kiwix/followers","following_url":"https://api.github.com/users/kiwix/following{/other_user}","gists_url":"https://api.github.com/users/kiwix/gists{/gist_id}","starred_url":"https://api.github.com/users/kiwix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kiwix/subscriptions","organizations_url":"https://api.github.com/users/kiwix/orgs","repos_url":"https://api.github.com/users/kiwix/repos","events_url":"https://api.github.com/users/kiwix/events{/privacy}","received_events_url":"https://api.github.com/users/kiwix/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kiwix/kiwix-android","description":"Kiwix port for offline on Android","fork":false,"url":"https://api.github.com/repos/kiwix/kiwix-android","forks_url":"https://api.github.com/repos/kiwix/kiwix-android/forks","keys_url":"https://api.github.com/repos/kiwix/kiwix-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kiwix/kiwix-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kiwix/kiwix-android/teams","hooks_url":"https://api.github.com/repos/kiwix/kiwix-android/hooks","issue_events_url":"https://api.github.com/repos/kiwix/kiwix-android/issues/events{/number}","events_url":"https://api.github.com/repos/kiwix/kiwix-android/events","assignees_url":"https://api.github.com/repos/kiwix/kiwix-android/assignees{/user}","branches_url":"https://api.github.com/repos/kiwix/kiwix-android/branches{/branch}","tags_url":"https://api.github.com/repos/kiwix/kiwix-android/tags","blobs_url":"https://api.github.com/repos/kiwix/kiwix-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kiwix/kiwix-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kiwix/kiwix-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/kiwix/kiwix-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kiwix/kiwix-android/statuses/{sha}","languages_url":"https://api.github.com/repos/kiwix/kiwix-android/languages","stargazers_url":"https://api.github.com/repos/kiwix/kiwix-android/stargazers","contributors_url":"https://api.github.com/repos/kiwix/kiwix-android/contributors","subscribers_url":"https://api.github.com/repos/kiwix/kiwix-android/subscribers","subscription_url":"https://api.github.com/repos/kiwix/kiwix-android/subscription","commits_url":"https://api.github.com/repos/kiwix/kiwix-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/kiwix/kiwix-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/kiwix/kiwix-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/kiwix/kiwix-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/kiwix/kiwix-android/contents/{+path}","compare_url":"https://api.github.com/repos/kiwix/kiwix-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kiwix/kiwix-android/merges","archive_url":"https://api.github.com/repos/kiwix/kiwix-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kiwix/kiwix-android/downloads","issues_url":"https://api.github.com/repos/kiwix/kiwix-android/issues{/number}","pulls_url":"https://api.github.com/repos/kiwix/kiwix-android/pulls{/number}","milestones_url":"https://api.github.com/repos/kiwix/kiwix-android/milestones{/number}","notifications_url":"https://api.github.com/repos/kiwix/kiwix-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kiwix/kiwix-android/labels{/name}","releases_url":"https://api.github.com/repos/kiwix/kiwix-android/releases{/id}","deployments_url":"https://api.github.com/repos/kiwix/kiwix-android/deployments","created_at":"2017-01-18T19:48:46Z","updated_at":"2018-02-16T01:57:48Z","pushed_at":"2018-02-16T02:35:01Z","git_url":"git://github.com/kiwix/kiwix-android.git","ssh_url":"git@github.com:kiwix/kiwix-android.git","clone_url":"https://github.com/kiwix/kiwix-android.git","svn_url":"https://github.com/kiwix/kiwix-android","homepage":"http://android.kiwix.org","size":148559,"stargazers_count":40,"watchers_count":40,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":48,"mirror_url":null,"archived":false,"open_issues_count":147,"license":null,"forks":48,"open_issues":147,"watchers":40,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kiwix/kiwix-android/pulls/415"},"html":{"href":"https://github.com/kiwix/kiwix-android/pull/415"},"issue":{"href":"https://api.github.com/repos/kiwix/kiwix-android/issues/415"},"comments":{"href":"https://api.github.com/repos/kiwix/kiwix-android/issues/415/comments"},"review_comments":{"href":"https://api.github.com/repos/kiwix/kiwix-android/pulls/415/comments"},"review_comment":{"href":"https://api.github.com/repos/kiwix/kiwix-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kiwix/kiwix-android/pulls/415/commits"},"statuses":{"href":"https://api.github.com/repos/kiwix/kiwix-android/statuses/09bcc0df3918c3ccd09fa308d7bea65224369c8a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"brijeshshah13"}}