{"action":"created","comment":{"url":"https://api.github.com/repos/snipe/snipe-it/pulls/comments/215451203","pull_request_review_id":152718615,"id":215451203,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTQ1MTIwMw==","diff_hunk":"@@ -252,21 +262,11 @@ public function checkOut($target, $admin = null, $checkout_at = null, $expected_\n                 $this->location_id = $target->id;\n             }\n         }\n-        \n-        /**\n-         * Does the user have to confirm that they accept the asset?\n-         *\n-         * If so, set the acceptance-status to \"pending\".\n-         * This value is used in the unaccepted assets reports, for example\n-         * \n-         * @see https://github.com/snipe/snipe-it/issues/5772\n-         */\n-        if ($this->requireAcceptance() && $target instanceof User) {\n-          $this->accepted = self::ACCEPTANCE_PENDING;\n-        }","path":"app/Models/Asset.php","position":63,"original_position":63,"commit_id":"62195a805af48be810957f40d6cb0bc27e27b962","original_commit_id":"62195a805af48be810957f40d6cb0bc27e27b962","user":{"login":"dmeltzer","id":3803132,"node_id":"MDQ6VXNlcjM4MDMxMzI=","avatar_url":"https://avatars3.githubusercontent.com/u/3803132?v=4","gravatar_id":"","url":"https://api.github.com/users/dmeltzer","html_url":"https://github.com/dmeltzer","followers_url":"https://api.github.com/users/dmeltzer/followers","following_url":"https://api.github.com/users/dmeltzer/following{/other_user}","gists_url":"https://api.github.com/users/dmeltzer/gists{/gist_id}","starred_url":"https://api.github.com/users/dmeltzer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dmeltzer/subscriptions","organizations_url":"https://api.github.com/users/dmeltzer/orgs","repos_url":"https://api.github.com/users/dmeltzer/repos","events_url":"https://api.github.com/users/dmeltzer/events{/privacy}","received_events_url":"https://api.github.com/users/dmeltzer/received_events","type":"User","site_admin":false},"body":"Just confirming that this disappearing was intentional and not a result of merge weirdness.","created_at":"2018-09-05T23:00:21Z","updated_at":"2018-09-05T23:05:13Z","html_url":"https://github.com/snipe/snipe-it/pull/5913#discussion_r215451203","pull_request_url":"https://api.github.com/repos/snipe/snipe-it/pulls/5913","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/comments/215451203"},"html":{"href":"https://github.com/snipe/snipe-it/pull/5913#discussion_r215451203"},"pull_request":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/5913"}}},"pull_request":{"url":"https://api.github.com/repos/snipe/snipe-it/pulls/5913","id":203008564,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAzMDA4NTY0","html_url":"https://github.com/snipe/snipe-it/pull/5913","diff_url":"https://github.com/snipe/snipe-it/pull/5913.diff","patch_url":"https://github.com/snipe/snipe-it/pull/5913.patch","issue_url":"https://api.github.com/repos/snipe/snipe-it/issues/5913","number":5913,"state":"open","locked":false,"title":"[WIP] Refactor: Decouple checkin/checkout notifications from logging ","user":{"login":"tilldeeke","id":1795149,"node_id":"MDQ6VXNlcjE3OTUxNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1795149?v=4","gravatar_id":"","url":"https://api.github.com/users/tilldeeke","html_url":"https://github.com/tilldeeke","followers_url":"https://api.github.com/users/tilldeeke/followers","following_url":"https://api.github.com/users/tilldeeke/following{/other_user}","gists_url":"https://api.github.com/users/tilldeeke/gists{/gist_id}","starred_url":"https://api.github.com/users/tilldeeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilldeeke/subscriptions","organizations_url":"https://api.github.com/users/tilldeeke/orgs","repos_url":"https://api.github.com/users/tilldeeke/repos","events_url":"https://api.github.com/users/tilldeeke/events{/privacy}","received_events_url":"https://api.github.com/users/tilldeeke/received_events","type":"User","site_admin":false},"body":"**Work in progress, please don't merge!**\r\n\r\nThis PR begins to refactor the sending of checkin/checkout notifications.\r\n\r\nAt the moment, the notifications get sent in the code responsible for logging the checkin/checkout action. Since sending notifications and logging should be two totally seperate concerns, this PR introduces events for checkins/checkouts that can be listened and reacted to.\r\n\r\nThe _checkin_ notifications get sent when the appropriate event was fired and are completely decoupled from loggin so far.\r\n\r\nThe _checkout_ notifications also get sent when an appropriate event fires, but aren't totally decoupled, because the asset acceptance depends on the id of the log entry.\r\n(to accept/decline you have to open a url of this format:` /account/accept-asset/{log_id}`).\r\n\r\nThis is something I'd like to refactor in the next few days too, so that accepting or declining assets doesn't depend on the logging of checkouts.\r\n\r\n\r\n\r\n","created_at":"2018-07-21T12:50:26Z","updated_at":"2018-09-05T23:05:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c11c6538cda50dc00e357119c42640c4458ac610","assignee":null,"assignees":[],"requested_reviewers":[{"login":"snipe","id":197404,"node_id":"MDQ6VXNlcjE5NzQwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/197404?v=4","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/snipe/snipe-it/pulls/5913/commits","review_comments_url":"https://api.github.com/repos/snipe/snipe-it/pulls/5913/comments","review_comment_url":"https://api.github.com/repos/snipe/snipe-it/pulls/comments{/number}","comments_url":"https://api.github.com/repos/snipe/snipe-it/issues/5913/comments","statuses_url":"https://api.github.com/repos/snipe/snipe-it/statuses/62195a805af48be810957f40d6cb0bc27e27b962","head":{"label":"tilldeeke:refactore-checkout-checkin-notification-sending","ref":"refactore-checkout-checkin-notification-sending","sha":"62195a805af48be810957f40d6cb0bc27e27b962","user":{"login":"tilldeeke","id":1795149,"node_id":"MDQ6VXNlcjE3OTUxNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1795149?v=4","gravatar_id":"","url":"https://api.github.com/users/tilldeeke","html_url":"https://github.com/tilldeeke","followers_url":"https://api.github.com/users/tilldeeke/followers","following_url":"https://api.github.com/users/tilldeeke/following{/other_user}","gists_url":"https://api.github.com/users/tilldeeke/gists{/gist_id}","starred_url":"https://api.github.com/users/tilldeeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilldeeke/subscriptions","organizations_url":"https://api.github.com/users/tilldeeke/orgs","repos_url":"https://api.github.com/users/tilldeeke/repos","events_url":"https://api.github.com/users/tilldeeke/events{/privacy}","received_events_url":"https://api.github.com/users/tilldeeke/received_events","type":"User","site_admin":false},"repo":{"id":140201098,"node_id":"MDEwOlJlcG9zaXRvcnkxNDAyMDEwOTg=","name":"snipe-it","full_name":"tilldeeke/snipe-it","owner":{"login":"tilldeeke","id":1795149,"node_id":"MDQ6VXNlcjE3OTUxNDk=","avatar_url":"https://avatars2.githubusercontent.com/u/1795149?v=4","gravatar_id":"","url":"https://api.github.com/users/tilldeeke","html_url":"https://github.com/tilldeeke","followers_url":"https://api.github.com/users/tilldeeke/followers","following_url":"https://api.github.com/users/tilldeeke/following{/other_user}","gists_url":"https://api.github.com/users/tilldeeke/gists{/gist_id}","starred_url":"https://api.github.com/users/tilldeeke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tilldeeke/subscriptions","organizations_url":"https://api.github.com/users/tilldeeke/orgs","repos_url":"https://api.github.com/users/tilldeeke/repos","events_url":"https://api.github.com/users/tilldeeke/events{/privacy}","received_events_url":"https://api.github.com/users/tilldeeke/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tilldeeke/snipe-it","description":"A free open source IT asset/license management system","fork":true,"url":"https://api.github.com/repos/tilldeeke/snipe-it","forks_url":"https://api.github.com/repos/tilldeeke/snipe-it/forks","keys_url":"https://api.github.com/repos/tilldeeke/snipe-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tilldeeke/snipe-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tilldeeke/snipe-it/teams","hooks_url":"https://api.github.com/repos/tilldeeke/snipe-it/hooks","issue_events_url":"https://api.github.com/repos/tilldeeke/snipe-it/issues/events{/number}","events_url":"https://api.github.com/repos/tilldeeke/snipe-it/events","assignees_url":"https://api.github.com/repos/tilldeeke/snipe-it/assignees{/user}","branches_url":"https://api.github.com/repos/tilldeeke/snipe-it/branches{/branch}","tags_url":"https://api.github.com/repos/tilldeeke/snipe-it/tags","blobs_url":"https://api.github.com/repos/tilldeeke/snipe-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tilldeeke/snipe-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tilldeeke/snipe-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/tilldeeke/snipe-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tilldeeke/snipe-it/statuses/{sha}","languages_url":"https://api.github.com/repos/tilldeeke/snipe-it/languages","stargazers_url":"https://api.github.com/repos/tilldeeke/snipe-it/stargazers","contributors_url":"https://api.github.com/repos/tilldeeke/snipe-it/contributors","subscribers_url":"https://api.github.com/repos/tilldeeke/snipe-it/subscribers","subscription_url":"https://api.github.com/repos/tilldeeke/snipe-it/subscription","commits_url":"https://api.github.com/repos/tilldeeke/snipe-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/tilldeeke/snipe-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/tilldeeke/snipe-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/tilldeeke/snipe-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/tilldeeke/snipe-it/contents/{+path}","compare_url":"https://api.github.com/repos/tilldeeke/snipe-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tilldeeke/snipe-it/merges","archive_url":"https://api.github.com/repos/tilldeeke/snipe-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tilldeeke/snipe-it/downloads","issues_url":"https://api.github.com/repos/tilldeeke/snipe-it/issues{/number}","pulls_url":"https://api.github.com/repos/tilldeeke/snipe-it/pulls{/number}","milestones_url":"https://api.github.com/repos/tilldeeke/snipe-it/milestones{/number}","notifications_url":"https://api.github.com/repos/tilldeeke/snipe-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tilldeeke/snipe-it/labels{/name}","releases_url":"https://api.github.com/repos/tilldeeke/snipe-it/releases{/id}","deployments_url":"https://api.github.com/repos/tilldeeke/snipe-it/deployments","created_at":"2018-07-08T20:40:53Z","updated_at":"2018-07-23T20:42:26Z","pushed_at":"2018-08-06T12:47:45Z","git_url":"git://github.com/tilldeeke/snipe-it.git","ssh_url":"git@github.com:tilldeeke/snipe-it.git","clone_url":"https://github.com/tilldeeke/snipe-it.git","svn_url":"https://github.com/tilldeeke/snipe-it","homepage":"https://snipeitapp.com","size":84045,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"snipe:develop","ref":"develop","sha":"2d0df24ef37fc912d7523d85a72da0c5ffe27fe3","user":{"login":"snipe","id":197404,"node_id":"MDQ6VXNlcjE5NzQwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/197404?v=4","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"repo":{"id":14346979,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM0Njk3OQ==","name":"snipe-it","full_name":"snipe/snipe-it","owner":{"login":"snipe","id":197404,"node_id":"MDQ6VXNlcjE5NzQwNA==","avatar_url":"https://avatars0.githubusercontent.com/u/197404?v=4","gravatar_id":"","url":"https://api.github.com/users/snipe","html_url":"https://github.com/snipe","followers_url":"https://api.github.com/users/snipe/followers","following_url":"https://api.github.com/users/snipe/following{/other_user}","gists_url":"https://api.github.com/users/snipe/gists{/gist_id}","starred_url":"https://api.github.com/users/snipe/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/snipe/subscriptions","organizations_url":"https://api.github.com/users/snipe/orgs","repos_url":"https://api.github.com/users/snipe/repos","events_url":"https://api.github.com/users/snipe/events{/privacy}","received_events_url":"https://api.github.com/users/snipe/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/snipe/snipe-it","description":"A free open source IT asset/license management system","fork":false,"url":"https://api.github.com/repos/snipe/snipe-it","forks_url":"https://api.github.com/repos/snipe/snipe-it/forks","keys_url":"https://api.github.com/repos/snipe/snipe-it/keys{/key_id}","collaborators_url":"https://api.github.com/repos/snipe/snipe-it/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/snipe/snipe-it/teams","hooks_url":"https://api.github.com/repos/snipe/snipe-it/hooks","issue_events_url":"https://api.github.com/repos/snipe/snipe-it/issues/events{/number}","events_url":"https://api.github.com/repos/snipe/snipe-it/events","assignees_url":"https://api.github.com/repos/snipe/snipe-it/assignees{/user}","branches_url":"https://api.github.com/repos/snipe/snipe-it/branches{/branch}","tags_url":"https://api.github.com/repos/snipe/snipe-it/tags","blobs_url":"https://api.github.com/repos/snipe/snipe-it/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/snipe/snipe-it/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/snipe/snipe-it/git/refs{/sha}","trees_url":"https://api.github.com/repos/snipe/snipe-it/git/trees{/sha}","statuses_url":"https://api.github.com/repos/snipe/snipe-it/statuses/{sha}","languages_url":"https://api.github.com/repos/snipe/snipe-it/languages","stargazers_url":"https://api.github.com/repos/snipe/snipe-it/stargazers","contributors_url":"https://api.github.com/repos/snipe/snipe-it/contributors","subscribers_url":"https://api.github.com/repos/snipe/snipe-it/subscribers","subscription_url":"https://api.github.com/repos/snipe/snipe-it/subscription","commits_url":"https://api.github.com/repos/snipe/snipe-it/commits{/sha}","git_commits_url":"https://api.github.com/repos/snipe/snipe-it/git/commits{/sha}","comments_url":"https://api.github.com/repos/snipe/snipe-it/comments{/number}","issue_comment_url":"https://api.github.com/repos/snipe/snipe-it/issues/comments{/number}","contents_url":"https://api.github.com/repos/snipe/snipe-it/contents/{+path}","compare_url":"https://api.github.com/repos/snipe/snipe-it/compare/{base}...{head}","merges_url":"https://api.github.com/repos/snipe/snipe-it/merges","archive_url":"https://api.github.com/repos/snipe/snipe-it/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/snipe/snipe-it/downloads","issues_url":"https://api.github.com/repos/snipe/snipe-it/issues{/number}","pulls_url":"https://api.github.com/repos/snipe/snipe-it/pulls{/number}","milestones_url":"https://api.github.com/repos/snipe/snipe-it/milestones{/number}","notifications_url":"https://api.github.com/repos/snipe/snipe-it/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/snipe/snipe-it/labels{/name}","releases_url":"https://api.github.com/repos/snipe/snipe-it/releases{/id}","deployments_url":"https://api.github.com/repos/snipe/snipe-it/deployments","created_at":"2013-11-12T22:25:47Z","updated_at":"2018-09-05T19:06:22Z","pushed_at":"2018-09-05T21:58:21Z","git_url":"git://github.com/snipe/snipe-it.git","ssh_url":"git@github.com:snipe/snipe-it.git","clone_url":"https://github.com/snipe/snipe-it.git","svn_url":"https://github.com/snipe/snipe-it","homepage":"https://snipeitapp.com","size":84992,"stargazers_count":2247,"watchers_count":2247,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":984,"mirror_url":null,"archived":false,"open_issues_count":256,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":984,"open_issues":256,"watchers":2247,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/5913"},"html":{"href":"https://github.com/snipe/snipe-it/pull/5913"},"issue":{"href":"https://api.github.com/repos/snipe/snipe-it/issues/5913"},"comments":{"href":"https://api.github.com/repos/snipe/snipe-it/issues/5913/comments"},"review_comments":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/5913/comments"},"review_comment":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/snipe/snipe-it/pulls/5913/commits"},"statuses":{"href":"https://api.github.com/repos/snipe/snipe-it/statuses/62195a805af48be810957f40d6cb0bc27e27b962"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"dmeltzer"}}