{"action":"created","comment":{"url":"https://api.github.com/repos/TrustWallet/trust-core/pulls/comments/184243462","pull_request_review_id":115399121,"id":184243462,"diff_hunk":"@@ -0,0 +1,49 @@\n+// Copyright © 2017-2018 Trust.\n+//\n+// This file is part of Trust. The full Trust copyright notice, including\n+// terms governing use, modification, and redistribution, is contained in the\n+// file LICENSE at the root of the source code distribution tree.\n+\n+import Foundation\n+\n+/// https://github.com/ethereum/EIPs/blob/master/EIPS/eip-137.md\n+extension String {\n+    /// sha3 keccak 256\n+    public func sha3() -> Data {\n+        guard let data = self.data(using: .utf8) else {\n+            return Data()\n+        }\n+        return data.sha3()\n+    }\n+\n+    public var labelhash: Data {","path":"Sources/Solidity/Namehash.swift","position":19,"original_position":19,"commit_id":"6d79e656b36c0757b247c8b19354b7a7f6817ed2","original_commit_id":"6d79e656b36c0757b247c8b19354b7a7f6817ed2","user":{"login":"alejandro-isaza","id":167236,"avatar_url":"https://avatars1.githubusercontent.com/u/167236?v=4","gravatar_id":"","url":"https://api.github.com/users/alejandro-isaza","html_url":"https://github.com/alejandro-isaza","followers_url":"https://api.github.com/users/alejandro-isaza/followers","following_url":"https://api.github.com/users/alejandro-isaza/following{/other_user}","gists_url":"https://api.github.com/users/alejandro-isaza/gists{/gist_id}","starred_url":"https://api.github.com/users/alejandro-isaza/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alejandro-isaza/subscriptions","organizations_url":"https://api.github.com/users/alejandro-isaza/orgs","repos_url":"https://api.github.com/users/alejandro-isaza/repos","events_url":"https://api.github.com/users/alejandro-isaza/events{/privacy}","received_events_url":"https://api.github.com/users/alejandro-isaza/received_events","type":"User","site_admin":false},"body":"But then it should be `labelHash` (capital H) and is should be a static method in the ENSEncoder class.","created_at":"2018-04-26T00:33:31Z","updated_at":"2018-04-26T00:33:31Z","html_url":"https://github.com/TrustWallet/trust-core/pull/8#discussion_r184243462","pull_request_url":"https://api.github.com/repos/TrustWallet/trust-core/pulls/8","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/TrustWallet/trust-core/pulls/comments/184243462"},"html":{"href":"https://github.com/TrustWallet/trust-core/pull/8#discussion_r184243462"},"pull_request":{"href":"https://api.github.com/repos/TrustWallet/trust-core/pulls/8"}},"in_reply_to_id":184192855},"pull_request":{"url":"https://api.github.com/repos/TrustWallet/trust-core/pulls/8","id":183939367,"html_url":"https://github.com/TrustWallet/trust-core/pull/8","diff_url":"https://github.com/TrustWallet/trust-core/pull/8.diff","patch_url":"https://github.com/TrustWallet/trust-core/pull/8.patch","issue_url":"https://api.github.com/repos/TrustWallet/trust-core/issues/8","number":8,"state":"open","locked":false,"title":"Add ENSEncoder","user":{"login":"hewigovens","id":360470,"avatar_url":"https://avatars1.githubusercontent.com/u/360470?v=4","gravatar_id":"","url":"https://api.github.com/users/hewigovens","html_url":"https://github.com/hewigovens","followers_url":"https://api.github.com/users/hewigovens/followers","following_url":"https://api.github.com/users/hewigovens/following{/other_user}","gists_url":"https://api.github.com/users/hewigovens/gists{/gist_id}","starred_url":"https://api.github.com/users/hewigovens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewigovens/subscriptions","organizations_url":"https://api.github.com/users/hewigovens/orgs","repos_url":"https://api.github.com/users/hewigovens/repos","events_url":"https://api.github.com/users/hewigovens/events{/privacy}","received_events_url":"https://api.github.com/users/hewigovens/received_events","type":"User","site_admin":false},"body":"1. Add ENSEncoder and tests\r\n2. Add Namehash and tests\r\n3. Mark TrustCoreTests scheme as shared","created_at":"2018-04-25T06:53:40Z","updated_at":"2018-04-26T00:33:31Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bcb8dee046de8c7491abad1afb576b706ab38a78","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/TrustWallet/trust-core/pulls/8/commits","review_comments_url":"https://api.github.com/repos/TrustWallet/trust-core/pulls/8/comments","review_comment_url":"https://api.github.com/repos/TrustWallet/trust-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/TrustWallet/trust-core/issues/8/comments","statuses_url":"https://api.github.com/repos/TrustWallet/trust-core/statuses/6d79e656b36c0757b247c8b19354b7a7f6817ed2","head":{"label":"hewigovens:ens-encoder","ref":"ens-encoder","sha":"6d79e656b36c0757b247c8b19354b7a7f6817ed2","user":{"login":"hewigovens","id":360470,"avatar_url":"https://avatars1.githubusercontent.com/u/360470?v=4","gravatar_id":"","url":"https://api.github.com/users/hewigovens","html_url":"https://github.com/hewigovens","followers_url":"https://api.github.com/users/hewigovens/followers","following_url":"https://api.github.com/users/hewigovens/following{/other_user}","gists_url":"https://api.github.com/users/hewigovens/gists{/gist_id}","starred_url":"https://api.github.com/users/hewigovens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewigovens/subscriptions","organizations_url":"https://api.github.com/users/hewigovens/orgs","repos_url":"https://api.github.com/users/hewigovens/repos","events_url":"https://api.github.com/users/hewigovens/events{/privacy}","received_events_url":"https://api.github.com/users/hewigovens/received_events","type":"User","site_admin":false},"repo":{"id":130929468,"name":"trust-core","full_name":"hewigovens/trust-core","owner":{"login":"hewigovens","id":360470,"avatar_url":"https://avatars1.githubusercontent.com/u/360470?v=4","gravatar_id":"","url":"https://api.github.com/users/hewigovens","html_url":"https://github.com/hewigovens","followers_url":"https://api.github.com/users/hewigovens/followers","following_url":"https://api.github.com/users/hewigovens/following{/other_user}","gists_url":"https://api.github.com/users/hewigovens/gists{/gist_id}","starred_url":"https://api.github.com/users/hewigovens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hewigovens/subscriptions","organizations_url":"https://api.github.com/users/hewigovens/orgs","repos_url":"https://api.github.com/users/hewigovens/repos","events_url":"https://api.github.com/users/hewigovens/events{/privacy}","received_events_url":"https://api.github.com/users/hewigovens/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/hewigovens/trust-core","description":"Core Ethereum data structures and algorithms","fork":true,"url":"https://api.github.com/repos/hewigovens/trust-core","forks_url":"https://api.github.com/repos/hewigovens/trust-core/forks","keys_url":"https://api.github.com/repos/hewigovens/trust-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hewigovens/trust-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hewigovens/trust-core/teams","hooks_url":"https://api.github.com/repos/hewigovens/trust-core/hooks","issue_events_url":"https://api.github.com/repos/hewigovens/trust-core/issues/events{/number}","events_url":"https://api.github.com/repos/hewigovens/trust-core/events","assignees_url":"https://api.github.com/repos/hewigovens/trust-core/assignees{/user}","branches_url":"https://api.github.com/repos/hewigovens/trust-core/branches{/branch}","tags_url":"https://api.github.com/repos/hewigovens/trust-core/tags","blobs_url":"https://api.github.com/repos/hewigovens/trust-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hewigovens/trust-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hewigovens/trust-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/hewigovens/trust-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hewigovens/trust-core/statuses/{sha}","languages_url":"https://api.github.com/repos/hewigovens/trust-core/languages","stargazers_url":"https://api.github.com/repos/hewigovens/trust-core/stargazers","contributors_url":"https://api.github.com/repos/hewigovens/trust-core/contributors","subscribers_url":"https://api.github.com/repos/hewigovens/trust-core/subscribers","subscription_url":"https://api.github.com/repos/hewigovens/trust-core/subscription","commits_url":"https://api.github.com/repos/hewigovens/trust-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/hewigovens/trust-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/hewigovens/trust-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/hewigovens/trust-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/hewigovens/trust-core/contents/{+path}","compare_url":"https://api.github.com/repos/hewigovens/trust-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hewigovens/trust-core/merges","archive_url":"https://api.github.com/repos/hewigovens/trust-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hewigovens/trust-core/downloads","issues_url":"https://api.github.com/repos/hewigovens/trust-core/issues{/number}","pulls_url":"https://api.github.com/repos/hewigovens/trust-core/pulls{/number}","milestones_url":"https://api.github.com/repos/hewigovens/trust-core/milestones{/number}","notifications_url":"https://api.github.com/repos/hewigovens/trust-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hewigovens/trust-core/labels{/name}","releases_url":"https://api.github.com/repos/hewigovens/trust-core/releases{/id}","deployments_url":"https://api.github.com/repos/hewigovens/trust-core/deployments","created_at":"2018-04-25T00:38:44Z","updated_at":"2018-04-25T00:38:45Z","pushed_at":"2018-04-25T06:51:28Z","git_url":"git://github.com/hewigovens/trust-core.git","ssh_url":"git@github.com:hewigovens/trust-core.git","clone_url":"https://github.com/hewigovens/trust-core.git","svn_url":"https://github.com/hewigovens/trust-core","homepage":null,"size":74,"stargazers_count":0,"watchers_count":0,"language":"Swift","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"TrustWallet:master","ref":"master","sha":"acca5f6dd27d62d1a12f0ec785df0777e10795ad","user":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"repo":{"id":125131118,"name":"trust-core","full_name":"TrustWallet/trust-core","owner":{"login":"TrustWallet","id":32179889,"avatar_url":"https://avatars2.githubusercontent.com/u/32179889?v=4","gravatar_id":"","url":"https://api.github.com/users/TrustWallet","html_url":"https://github.com/TrustWallet","followers_url":"https://api.github.com/users/TrustWallet/followers","following_url":"https://api.github.com/users/TrustWallet/following{/other_user}","gists_url":"https://api.github.com/users/TrustWallet/gists{/gist_id}","starred_url":"https://api.github.com/users/TrustWallet/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TrustWallet/subscriptions","organizations_url":"https://api.github.com/users/TrustWallet/orgs","repos_url":"https://api.github.com/users/TrustWallet/repos","events_url":"https://api.github.com/users/TrustWallet/events{/privacy}","received_events_url":"https://api.github.com/users/TrustWallet/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/TrustWallet/trust-core","description":"Core Ethereum data structures and algorithms","fork":false,"url":"https://api.github.com/repos/TrustWallet/trust-core","forks_url":"https://api.github.com/repos/TrustWallet/trust-core/forks","keys_url":"https://api.github.com/repos/TrustWallet/trust-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/TrustWallet/trust-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/TrustWallet/trust-core/teams","hooks_url":"https://api.github.com/repos/TrustWallet/trust-core/hooks","issue_events_url":"https://api.github.com/repos/TrustWallet/trust-core/issues/events{/number}","events_url":"https://api.github.com/repos/TrustWallet/trust-core/events","assignees_url":"https://api.github.com/repos/TrustWallet/trust-core/assignees{/user}","branches_url":"https://api.github.com/repos/TrustWallet/trust-core/branches{/branch}","tags_url":"https://api.github.com/repos/TrustWallet/trust-core/tags","blobs_url":"https://api.github.com/repos/TrustWallet/trust-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/TrustWallet/trust-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/TrustWallet/trust-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/TrustWallet/trust-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/TrustWallet/trust-core/statuses/{sha}","languages_url":"https://api.github.com/repos/TrustWallet/trust-core/languages","stargazers_url":"https://api.github.com/repos/TrustWallet/trust-core/stargazers","contributors_url":"https://api.github.com/repos/TrustWallet/trust-core/contributors","subscribers_url":"https://api.github.com/repos/TrustWallet/trust-core/subscribers","subscription_url":"https://api.github.com/repos/TrustWallet/trust-core/subscription","commits_url":"https://api.github.com/repos/TrustWallet/trust-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/TrustWallet/trust-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/TrustWallet/trust-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/TrustWallet/trust-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/TrustWallet/trust-core/contents/{+path}","compare_url":"https://api.github.com/repos/TrustWallet/trust-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/TrustWallet/trust-core/merges","archive_url":"https://api.github.com/repos/TrustWallet/trust-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/TrustWallet/trust-core/downloads","issues_url":"https://api.github.com/repos/TrustWallet/trust-core/issues{/number}","pulls_url":"https://api.github.com/repos/TrustWallet/trust-core/pulls{/number}","milestones_url":"https://api.github.com/repos/TrustWallet/trust-core/milestones{/number}","notifications_url":"https://api.github.com/repos/TrustWallet/trust-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/TrustWallet/trust-core/labels{/name}","releases_url":"https://api.github.com/repos/TrustWallet/trust-core/releases{/id}","deployments_url":"https://api.github.com/repos/TrustWallet/trust-core/deployments","created_at":"2018-03-14T00:16:19Z","updated_at":"2018-04-24T16:38:55Z","pushed_at":"2018-04-25T06:53:40Z","git_url":"git://github.com/TrustWallet/trust-core.git","ssh_url":"git@github.com:TrustWallet/trust-core.git","clone_url":"https://github.com/TrustWallet/trust-core.git","svn_url":"https://github.com/TrustWallet/trust-core","homepage":null,"size":68,"stargazers_count":9,"watchers_count":9,"language":"Swift","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":3,"watchers":9,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/TrustWallet/trust-core/pulls/8"},"html":{"href":"https://github.com/TrustWallet/trust-core/pull/8"},"issue":{"href":"https://api.github.com/repos/TrustWallet/trust-core/issues/8"},"comments":{"href":"https://api.github.com/repos/TrustWallet/trust-core/issues/8/comments"},"review_comments":{"href":"https://api.github.com/repos/TrustWallet/trust-core/pulls/8/comments"},"review_comment":{"href":"https://api.github.com/repos/TrustWallet/trust-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/TrustWallet/trust-core/pulls/8/commits"},"statuses":{"href":"https://api.github.com/repos/TrustWallet/trust-core/statuses/6d79e656b36c0757b247c8b19354b7a7f6817ed2"}},"author_association":"NONE"}}
{"actor":{"display_login":"alejandro-isaza"}}