{"action":"created","issue":{"url":"https://api.github.com/repos/google/periph/issues/325","repository_url":"https://api.github.com/repos/google/periph","labels_url":"https://api.github.com/repos/google/periph/issues/325/labels{/name}","comments_url":"https://api.github.com/repos/google/periph/issues/325/comments","events_url":"https://api.github.com/repos/google/periph/issues/325/events","html_url":"https://github.com/google/periph/pull/325","id":379448983,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTA2MDEw","number":325,"title":"[ADS1x15] Fixed synchronization","user":{"login":"bezineb5","id":1782448,"node_id":"MDQ6VXNlcjE3ODI0NDg=","avatar_url":"https://avatars3.githubusercontent.com/u/1782448?v=4","gravatar_id":"","url":"https://api.github.com/users/bezineb5","html_url":"https://github.com/bezineb5","followers_url":"https://api.github.com/users/bezineb5/followers","following_url":"https://api.github.com/users/bezineb5/following{/other_user}","gists_url":"https://api.github.com/users/bezineb5/gists{/gist_id}","starred_url":"https://api.github.com/users/bezineb5/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bezineb5/subscriptions","organizations_url":"https://api.github.com/users/bezineb5/orgs","repos_url":"https://api.github.com/users/bezineb5/repos","events_url":"https://api.github.com/users/bezineb5/events{/privacy}","received_events_url":"https://api.github.com/users/bezineb5/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-10T18:40:43Z","updated_at":"2018-11-10T18:43:38Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/google/periph/pulls/325","html_url":"https://github.com/google/periph/pull/325","diff_url":"https://github.com/google/periph/pull/325.diff","patch_url":"https://github.com/google/periph/pull/325.patch"},"body":"I fixed the typo and the lack of mutex when calling Halt() on a pin.\r\nAdded unit tests based upon a real device.\r\n\r\nAlso, I added a convenience String() function on i2ctest.IO, in order to make it easier to write unit tests. Do you think it has value or do you prefer me to remove it?\r\n\r\nLast but not least, should I had those devices in the documentation on periph.io? Where is it?\r\n\r\nThanks!"},"comment":{"url":"https://api.github.com/repos/google/periph/issues/comments/437608437","html_url":"https://github.com/google/periph/pull/325#issuecomment-437608437","issue_url":"https://api.github.com/repos/google/periph/issues/325","id":437608437,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzYwODQzNw==","user":{"login":"codecov-io","id":8655789,"node_id":"MDQ6VXNlcjg2NTU3ODk=","avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-11-10T18:43:38Z","updated_at":"2018-11-10T18:43:38Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/google/periph/pull/325?src=pr&el=h1) Report\n> Merging [#325](https://codecov.io/gh/google/periph/pull/325?src=pr&el=desc) into [master](https://codecov.io/gh/google/periph/commit/1a11d2e379d3e80cbbde1cefa34bfa3030514758?src=pr&el=desc) will **increase** coverage by `1.21%`.\n> The diff coverage is `77.77%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/google/periph/pull/325/graphs/tree.svg?width=650&token=AxJC9WZ6ql&height=150&src=pr)](https://codecov.io/gh/google/periph/pull/325?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #325      +/-   ##\n==========================================\n+ Coverage   69.96%   71.17%   +1.21%     \n==========================================\n  Files         100      100              \n  Lines        8812     8826      +14     \n==========================================\n+ Hits         6165     6282     +117     \n+ Misses       2491     2376     -115     \n- Partials      156      168      +12\n```\n\n\n| [Impacted Files](https://codecov.io/gh/google/periph/pull/325?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [conn/i2c/i2ctest/i2ctest.go](https://codecov.io/gh/google/periph/pull/325/diff?src=pr&el=tree#diff-Y29ubi9pMmMvaTJjdGVzdC9pMmN0ZXN0Lmdv) | `100% <100%> (ø)` | :arrow_up: |\n| [experimental/devices/ads1x15/ads1x15.go](https://codecov.io/gh/google/periph/pull/325/diff?src=pr&el=tree#diff-ZXhwZXJpbWVudGFsL2RldmljZXMvYWRzMXgxNS9hZHMxeDE1Lmdv) | `79.52% <60%> (+50.45%)` | :arrow_up: |\n| [devices/lepton/lepton.go](https://codecov.io/gh/google/periph/pull/325/diff?src=pr&el=tree#diff-ZGV2aWNlcy9sZXB0b24vbGVwdG9uLmdv) | `88.41% <0%> (+1.21%)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/google/periph/pull/325?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/google/periph/pull/325?src=pr&el=footer). Last update [1a11d2e...77db0e5](https://codecov.io/gh/google/periph/pull/325?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov-io"}}