{"action":"created","issue":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3104","repository_url":"https://api.github.com/repos/freedomofpress/securedrop","labels_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3104/labels{/name}","comments_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3104/comments","events_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3104/events","html_url":"https://github.com/freedomofpress/securedrop/pull/3104","id":302294210,"number":3104,"title":"Bugfix: Update installer.patch against latest tails-installer 5.0.4","user":{"login":"ageis","id":1161532,"avatar_url":"https://avatars0.githubusercontent.com/u/1161532?v=4","gravatar_id":"","url":"https://api.github.com/users/ageis","html_url":"https://github.com/ageis","followers_url":"https://api.github.com/users/ageis/followers","following_url":"https://api.github.com/users/ageis/following{/other_user}","gists_url":"https://api.github.com/users/ageis/gists{/gist_id}","starred_url":"https://api.github.com/users/ageis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ageis/subscriptions","organizations_url":"https://api.github.com/users/ageis/orgs","repos_url":"https://api.github.com/users/ageis/repos","events_url":"https://api.github.com/users/ageis/events{/privacy}","received_events_url":"https://api.github.com/users/ageis/received_events","type":"User","site_admin":false},"labels":[{"id":59848063,"url":"https://api.github.com/repos/freedomofpress/securedrop/labels/bug","name":"bug","color":"e11d21","default":true},{"id":616447641,"url":"https://api.github.com/repos/freedomofpress/securedrop/labels/development%20env","name":"development env","color":"bfd4f2","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-03-05T13:11:00Z","updated_at":"2018-03-05T13:43:26Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/freedomofpress/securedrop/pulls/3104","html_url":"https://github.com/freedomofpress/securedrop/pull/3104","diff_url":"https://github.com/freedomofpress/securedrop/pull/3104.diff","patch_url":"https://github.com/freedomofpress/securedrop/pull/3104.patch"},"body":"[tails-installer](https://anonscm.debian.org/git/pkg-privacy/packages/tails-installer.git) is a Python application, currently at version 5.0.4+dfsg. That version was tagged on January 22nd and uploaded to Launchpad PPA on Feb 4th, causing the included patch to fail because some lines in `gui.py` and `creator.py` had changed.\r\nSee: https://klistrain.se/p/0491dbc\r\n```\r\nroot@amnesia:/home/amnesia/temp# sudo patch -p0 -d/ < installer.patch\r\npatching file /usr/lib/python2.7/dist-packages/tails_installer/creator.py\r\nReversed (or previously applied) patch detected!  Assume -R? [n] n\r\nApply anyway? [n] y\r\nHunk #1 FAILED at 615.\r\n1 out of 1 hunk FAILED -- saving rejects to file /usr/lib/python2.7/dist-packages/tails_installer/creator.py.rej\r\npatching file /usr/lib/python2.7/dist-packages/tails_installer/gui.py\r\nHunk #1 FAILED at 483.\r\n1 out of 1 hunk FAILED -- saving rejects to file /usr/lib/python2.7/dist-packages/tails_installer/gui.py.rej\r\n```\r\n\r\nThis updates the patch in the \"virtualizing Tails\" documentation based on the latest version of tails-installer.\r\n\r\nHere is the new patch ([link](https://paste.cointel.pro/?7b5492e3840adfaa#jdd32xc0lILACFZRozLiDRPwYTdR8SvrIZB9N3IZF2c=)):\r\n```\r\n--- /usr/lib/python2.7/dist-packages/tails_installer/creator.py      2018-01-22 14:59:40.000000000 +0100\r\n+++ /usr/lib/python2.7/dist-packages/tails_installer/creator.py.mod  2018-03-05 05:15:00.000000000 -0800\r\n@@ -595,16 +595,6 @@ class LinuxTailsInstallerCreator(TailsInstallerCreator):\r\n                 self.log.debug('Skipping non-removable device: %s'\r\n                                % data['device'])\r\n\r\n-            # Only pay attention to USB and SDIO devices, unless --force'd\r\n-            iface = drive.props.connection_bus\r\n-            if iface != 'usb' and iface != 'sdio' \\\r\n-               and self.opts.force != data['device']:\r\n-                self.log.warning(\r\n-                    \"Skipping device '%(device)s' connected to '%(interface)s' interface\"\r\n-                    % {'device': data['udi'], 'interface': iface}\r\n-                )\r\n-                continue\r\n-\r\n             # Skip optical drives\r\n             if data['is_optical'] and self.opts.force != data['device']:\r\n                 self.log.debug('Skipping optical device: %s' % data['device'])\r\n--- /usr/lib/python2.7/dist-packages/tails_installer/gui.py      2018-01-22 14:59:40.000000000 +0100\r\n+++ /usr/lib/python2.7/dist-packages/tails_installer/gui.py.mod  2018-03-05 05:15:00.000000000 -0800\r\n@@ -568,16 +568,6 @@ class TailsInstallerWindow(Gtk.ApplicationWindow):\r\n                     self.devices_with_persistence.append(info['parent'])\r\n                     continue\r\n                 pretty_name = self.get_device_pretty_name(info)\r\n-                # Skip devices with non-removable bit enabled\r\n-                if not info['removable']:\r\n-                    message =_('The USB stick \"%(pretty_name)s\"'\r\n-                               ' is configured as non-removable by its'\r\n-                               ' manufacturer and Tails will fail to start on it.'\r\n-                               ' Please try installing on a different model.') % {\r\n-                               'pretty_name':  pretty_name\r\n-                               }\r\n-                    self.status(message)\r\n-                    continue\r\n                 # Skip too small devices, but inform the user\r\n                 if not info['is_device_big_enough_for_installation']:\r\n                     message =_('The device \"%(pretty_name)s\"'\r\n```\r\n\r\n## Status\r\n\r\nReady for review. Waiting on @Anonymous26 to file an issue.\r\n\r\n## Description of Changes\r\n\r\nUpdates installer.patch in the virtualizing Tails documentation to work with tails-installer 5.0.4, which was released 02/04/2018.\r\n\r\n## Testing\r\n\r\nNeeds to be tested against actual Tails 3.5."},"comment":{"url":"https://api.github.com/repos/freedomofpress/securedrop/issues/comments/370422630","html_url":"https://github.com/freedomofpress/securedrop/pull/3104#issuecomment-370422630","issue_url":"https://api.github.com/repos/freedomofpress/securedrop/issues/3104","id":370422630,"user":{"login":"ageis","id":1161532,"avatar_url":"https://avatars0.githubusercontent.com/u/1161532?v=4","gravatar_id":"","url":"https://api.github.com/users/ageis","html_url":"https://github.com/ageis","followers_url":"https://api.github.com/users/ageis/followers","following_url":"https://api.github.com/users/ageis/following{/other_user}","gists_url":"https://api.github.com/users/ageis/gists{/gist_id}","starred_url":"https://api.github.com/users/ageis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ageis/subscriptions","organizations_url":"https://api.github.com/users/ageis/orgs","repos_url":"https://api.github.com/users/ageis/repos","events_url":"https://api.github.com/users/ageis/events{/privacy}","received_events_url":"https://api.github.com/users/ageis/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T13:43:26Z","updated_at":"2018-03-05T13:43:26Z","author_association":"CONTRIBUTOR","body":"![tails_vm_patch](https://user-images.githubusercontent.com/1161532/36977986-e0d97ef8-2037-11e8-8347-cede0d1b5dbb.png)\r\nMy patch succeeded in a Tails 3.5 VirtualBox VM, and tails-installer executes without any errors. Believe @kushaldas is also providing review and @Anonymous26 is actually going to use it to install Tails to the virtual hard disk image (VDI). "}}
{"actor":{"display_login":"ageis"}}