{"action":"created","comment":{"url":"https://api.github.com/repos/gcp/leela-zero/pulls/comments/198295838","pull_request_review_id":132202736,"id":198295838,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODI5NTgzOA==","diff_hunk":"@@ -76,6 +76,12 @@ std::string cfg_options_str;\n bool cfg_benchmark;\n int cfg_analyze_interval_centis;\n \n+std::unique_ptr<UCTSearch> GTP::search;","path":"src/GTP.cpp","position":4,"original_position":4,"commit_id":"271165397b96de2ebf880ef1d32d0fe293b3cba3","original_commit_id":"271165397b96de2ebf880ef1d32d0fe293b3cba3","user":{"login":"ihavnoid","id":33939814,"node_id":"MDQ6VXNlcjMzOTM5ODE0","avatar_url":"https://avatars3.githubusercontent.com/u/33939814?v=4","gravatar_id":"","url":"https://api.github.com/users/ihavnoid","html_url":"https://github.com/ihavnoid","followers_url":"https://api.github.com/users/ihavnoid/followers","following_url":"https://api.github.com/users/ihavnoid/following{/other_user}","gists_url":"https://api.github.com/users/ihavnoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ihavnoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihavnoid/subscriptions","organizations_url":"https://api.github.com/users/ihavnoid/orgs","repos_url":"https://api.github.com/users/ihavnoid/repos","events_url":"https://api.github.com/users/ihavnoid/events{/privacy}","received_events_url":"https://api.github.com/users/ihavnoid/received_events","type":"User","site_admin":false},"body":"You probably figured out, but this was due to an attempt trying to remove the global Network and keep it as a member of UCTSearch.  Without this, OpenCL gets initialized on first GTP command hence introducing some wierdness.  (Comment will continue below)","created_at":"2018-06-26T20:59:32Z","updated_at":"2018-06-26T20:59:32Z","html_url":"https://github.com/gcp/leela-zero/pull/1558#discussion_r198295838","pull_request_url":"https://api.github.com/repos/gcp/leela-zero/pulls/1558","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/gcp/leela-zero/pulls/comments/198295838"},"html":{"href":"https://github.com/gcp/leela-zero/pull/1558#discussion_r198295838"},"pull_request":{"href":"https://api.github.com/repos/gcp/leela-zero/pulls/1558"}},"in_reply_to_id":198258203},"pull_request":{"url":"https://api.github.com/repos/gcp/leela-zero/pulls/1558","id":195147274,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1MTQ3Mjc0","html_url":"https://github.com/gcp/leela-zero/pull/1558","diff_url":"https://github.com/gcp/leela-zero/pull/1558.diff","patch_url":"https://github.com/gcp/leela-zero/pull/1558.patch","issue_url":"https://api.github.com/repos/gcp/leela-zero/issues/1558","number":1558,"state":"open","locked":false,"title":"Code restructuring part 1 : no globals","user":{"login":"ihavnoid","id":33939814,"node_id":"MDQ6VXNlcjMzOTM5ODE0","avatar_url":"https://avatars3.githubusercontent.com/u/33939814?v=4","gravatar_id":"","url":"https://api.github.com/users/ihavnoid","html_url":"https://github.com/ihavnoid","followers_url":"https://api.github.com/users/ihavnoid/followers","following_url":"https://api.github.com/users/ihavnoid/following{/other_user}","gists_url":"https://api.github.com/users/ihavnoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ihavnoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihavnoid/subscriptions","organizations_url":"https://api.github.com/users/ihavnoid/orgs","repos_url":"https://api.github.com/users/ihavnoid/repos","events_url":"https://api.github.com/users/ihavnoid/events{/privacy}","received_events_url":"https://api.github.com/users/ihavnoid/received_events","type":"User","site_admin":false},"body":"Restructured code to remove:\r\n- No global / thread_local OpenCL structures\r\n- Network is now all non-static methods with instance variables\r\n- NNCache is a member of Network, OpenCLScheduler is also a member of Network\r\n- ThreadData is renamed to OpenCLContext (it's no longer thread-specific!)\r\n- Other accompanying fixes\r\n","created_at":"2018-06-15T11:25:28Z","updated_at":"2018-06-26T20:59:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"eb092cd0cf382389d6e3b86b42887af8f957fe22","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/gcp/leela-zero/pulls/1558/commits","review_comments_url":"https://api.github.com/repos/gcp/leela-zero/pulls/1558/comments","review_comment_url":"https://api.github.com/repos/gcp/leela-zero/pulls/comments{/number}","comments_url":"https://api.github.com/repos/gcp/leela-zero/issues/1558/comments","statuses_url":"https://api.github.com/repos/gcp/leela-zero/statuses/271165397b96de2ebf880ef1d32d0fe293b3cba3","head":{"label":"ihavnoid:code_restructuring","ref":"code_restructuring","sha":"271165397b96de2ebf880ef1d32d0fe293b3cba3","user":{"login":"ihavnoid","id":33939814,"node_id":"MDQ6VXNlcjMzOTM5ODE0","avatar_url":"https://avatars3.githubusercontent.com/u/33939814?v=4","gravatar_id":"","url":"https://api.github.com/users/ihavnoid","html_url":"https://github.com/ihavnoid","followers_url":"https://api.github.com/users/ihavnoid/followers","following_url":"https://api.github.com/users/ihavnoid/following{/other_user}","gists_url":"https://api.github.com/users/ihavnoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ihavnoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihavnoid/subscriptions","organizations_url":"https://api.github.com/users/ihavnoid/orgs","repos_url":"https://api.github.com/users/ihavnoid/repos","events_url":"https://api.github.com/users/ihavnoid/events{/privacy}","received_events_url":"https://api.github.com/users/ihavnoid/received_events","type":"User","site_admin":false},"repo":{"id":112053508,"node_id":"MDEwOlJlcG9zaXRvcnkxMTIwNTM1MDg=","name":"leela-zero","full_name":"ihavnoid/leela-zero","owner":{"login":"ihavnoid","id":33939814,"node_id":"MDQ6VXNlcjMzOTM5ODE0","avatar_url":"https://avatars3.githubusercontent.com/u/33939814?v=4","gravatar_id":"","url":"https://api.github.com/users/ihavnoid","html_url":"https://github.com/ihavnoid","followers_url":"https://api.github.com/users/ihavnoid/followers","following_url":"https://api.github.com/users/ihavnoid/following{/other_user}","gists_url":"https://api.github.com/users/ihavnoid/gists{/gist_id}","starred_url":"https://api.github.com/users/ihavnoid/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ihavnoid/subscriptions","organizations_url":"https://api.github.com/users/ihavnoid/orgs","repos_url":"https://api.github.com/users/ihavnoid/repos","events_url":"https://api.github.com/users/ihavnoid/events{/privacy}","received_events_url":"https://api.github.com/users/ihavnoid/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ihavnoid/leela-zero","description":"Go engine with no human-provided knowledge, modeled after the AlphaGo Zero paper.","fork":true,"url":"https://api.github.com/repos/ihavnoid/leela-zero","forks_url":"https://api.github.com/repos/ihavnoid/leela-zero/forks","keys_url":"https://api.github.com/repos/ihavnoid/leela-zero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ihavnoid/leela-zero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ihavnoid/leela-zero/teams","hooks_url":"https://api.github.com/repos/ihavnoid/leela-zero/hooks","issue_events_url":"https://api.github.com/repos/ihavnoid/leela-zero/issues/events{/number}","events_url":"https://api.github.com/repos/ihavnoid/leela-zero/events","assignees_url":"https://api.github.com/repos/ihavnoid/leela-zero/assignees{/user}","branches_url":"https://api.github.com/repos/ihavnoid/leela-zero/branches{/branch}","tags_url":"https://api.github.com/repos/ihavnoid/leela-zero/tags","blobs_url":"https://api.github.com/repos/ihavnoid/leela-zero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ihavnoid/leela-zero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ihavnoid/leela-zero/git/refs{/sha}","trees_url":"https://api.github.com/repos/ihavnoid/leela-zero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ihavnoid/leela-zero/statuses/{sha}","languages_url":"https://api.github.com/repos/ihavnoid/leela-zero/languages","stargazers_url":"https://api.github.com/repos/ihavnoid/leela-zero/stargazers","contributors_url":"https://api.github.com/repos/ihavnoid/leela-zero/contributors","subscribers_url":"https://api.github.com/repos/ihavnoid/leela-zero/subscribers","subscription_url":"https://api.github.com/repos/ihavnoid/leela-zero/subscription","commits_url":"https://api.github.com/repos/ihavnoid/leela-zero/commits{/sha}","git_commits_url":"https://api.github.com/repos/ihavnoid/leela-zero/git/commits{/sha}","comments_url":"https://api.github.com/repos/ihavnoid/leela-zero/comments{/number}","issue_comment_url":"https://api.github.com/repos/ihavnoid/leela-zero/issues/comments{/number}","contents_url":"https://api.github.com/repos/ihavnoid/leela-zero/contents/{+path}","compare_url":"https://api.github.com/repos/ihavnoid/leela-zero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ihavnoid/leela-zero/merges","archive_url":"https://api.github.com/repos/ihavnoid/leela-zero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ihavnoid/leela-zero/downloads","issues_url":"https://api.github.com/repos/ihavnoid/leela-zero/issues{/number}","pulls_url":"https://api.github.com/repos/ihavnoid/leela-zero/pulls{/number}","milestones_url":"https://api.github.com/repos/ihavnoid/leela-zero/milestones{/number}","notifications_url":"https://api.github.com/repos/ihavnoid/leela-zero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ihavnoid/leela-zero/labels{/name}","releases_url":"https://api.github.com/repos/ihavnoid/leela-zero/releases{/id}","deployments_url":"https://api.github.com/repos/ihavnoid/leela-zero/deployments","created_at":"2017-11-26T03:41:55Z","updated_at":"2018-06-26T02:06:56Z","pushed_at":"2018-06-24T05:42:40Z","git_url":"git://github.com/ihavnoid/leela-zero.git","ssh_url":"git@github.com:ihavnoid/leela-zero.git","clone_url":"https://github.com/ihavnoid/leela-zero.git","svn_url":"https://github.com/ihavnoid/leela-zero","homepage":null,"size":17214,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"gcp:next","ref":"next","sha":"91031bfbcb09b6dc379a62e4c5e84006f0560179","user":{"login":"gcp","id":1104290,"node_id":"MDQ6VXNlcjExMDQyOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1104290?v=4","gravatar_id":"","url":"https://api.github.com/users/gcp","html_url":"https://github.com/gcp","followers_url":"https://api.github.com/users/gcp/followers","following_url":"https://api.github.com/users/gcp/following{/other_user}","gists_url":"https://api.github.com/users/gcp/gists{/gist_id}","starred_url":"https://api.github.com/users/gcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcp/subscriptions","organizations_url":"https://api.github.com/users/gcp/orgs","repos_url":"https://api.github.com/users/gcp/repos","events_url":"https://api.github.com/users/gcp/events{/privacy}","received_events_url":"https://api.github.com/users/gcp/received_events","type":"User","site_admin":false},"repo":{"id":108166281,"node_id":"MDEwOlJlcG9zaXRvcnkxMDgxNjYyODE=","name":"leela-zero","full_name":"gcp/leela-zero","owner":{"login":"gcp","id":1104290,"node_id":"MDQ6VXNlcjExMDQyOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/1104290?v=4","gravatar_id":"","url":"https://api.github.com/users/gcp","html_url":"https://github.com/gcp","followers_url":"https://api.github.com/users/gcp/followers","following_url":"https://api.github.com/users/gcp/following{/other_user}","gists_url":"https://api.github.com/users/gcp/gists{/gist_id}","starred_url":"https://api.github.com/users/gcp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gcp/subscriptions","organizations_url":"https://api.github.com/users/gcp/orgs","repos_url":"https://api.github.com/users/gcp/repos","events_url":"https://api.github.com/users/gcp/events{/privacy}","received_events_url":"https://api.github.com/users/gcp/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/gcp/leela-zero","description":"Go engine with no human-provided knowledge, modeled after the AlphaGo Zero paper.","fork":false,"url":"https://api.github.com/repos/gcp/leela-zero","forks_url":"https://api.github.com/repos/gcp/leela-zero/forks","keys_url":"https://api.github.com/repos/gcp/leela-zero/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gcp/leela-zero/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gcp/leela-zero/teams","hooks_url":"https://api.github.com/repos/gcp/leela-zero/hooks","issue_events_url":"https://api.github.com/repos/gcp/leela-zero/issues/events{/number}","events_url":"https://api.github.com/repos/gcp/leela-zero/events","assignees_url":"https://api.github.com/repos/gcp/leela-zero/assignees{/user}","branches_url":"https://api.github.com/repos/gcp/leela-zero/branches{/branch}","tags_url":"https://api.github.com/repos/gcp/leela-zero/tags","blobs_url":"https://api.github.com/repos/gcp/leela-zero/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gcp/leela-zero/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gcp/leela-zero/git/refs{/sha}","trees_url":"https://api.github.com/repos/gcp/leela-zero/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gcp/leela-zero/statuses/{sha}","languages_url":"https://api.github.com/repos/gcp/leela-zero/languages","stargazers_url":"https://api.github.com/repos/gcp/leela-zero/stargazers","contributors_url":"https://api.github.com/repos/gcp/leela-zero/contributors","subscribers_url":"https://api.github.com/repos/gcp/leela-zero/subscribers","subscription_url":"https://api.github.com/repos/gcp/leela-zero/subscription","commits_url":"https://api.github.com/repos/gcp/leela-zero/commits{/sha}","git_commits_url":"https://api.github.com/repos/gcp/leela-zero/git/commits{/sha}","comments_url":"https://api.github.com/repos/gcp/leela-zero/comments{/number}","issue_comment_url":"https://api.github.com/repos/gcp/leela-zero/issues/comments{/number}","contents_url":"https://api.github.com/repos/gcp/leela-zero/contents/{+path}","compare_url":"https://api.github.com/repos/gcp/leela-zero/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gcp/leela-zero/merges","archive_url":"https://api.github.com/repos/gcp/leela-zero/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gcp/leela-zero/downloads","issues_url":"https://api.github.com/repos/gcp/leela-zero/issues{/number}","pulls_url":"https://api.github.com/repos/gcp/leela-zero/pulls{/number}","milestones_url":"https://api.github.com/repos/gcp/leela-zero/milestones{/number}","notifications_url":"https://api.github.com/repos/gcp/leela-zero/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gcp/leela-zero/labels{/name}","releases_url":"https://api.github.com/repos/gcp/leela-zero/releases{/id}","deployments_url":"https://api.github.com/repos/gcp/leela-zero/deployments","created_at":"2017-10-24T18:19:43Z","updated_at":"2018-06-26T15:46:34Z","pushed_at":"2018-06-26T18:38:18Z","git_url":"git://github.com/gcp/leela-zero.git","ssh_url":"git@github.com:gcp/leela-zero.git","clone_url":"https://github.com/gcp/leela-zero.git","svn_url":"https://github.com/gcp/leela-zero","homepage":null,"size":2959,"stargazers_count":2524,"watchers_count":2524,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":515,"mirror_url":null,"archived":false,"open_issues_count":297,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":515,"open_issues":297,"watchers":2524,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/gcp/leela-zero/pulls/1558"},"html":{"href":"https://github.com/gcp/leela-zero/pull/1558"},"issue":{"href":"https://api.github.com/repos/gcp/leela-zero/issues/1558"},"comments":{"href":"https://api.github.com/repos/gcp/leela-zero/issues/1558/comments"},"review_comments":{"href":"https://api.github.com/repos/gcp/leela-zero/pulls/1558/comments"},"review_comment":{"href":"https://api.github.com/repos/gcp/leela-zero/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/gcp/leela-zero/pulls/1558/commits"},"statuses":{"href":"https://api.github.com/repos/gcp/leela-zero/statuses/271165397b96de2ebf880ef1d32d0fe293b3cba3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ihavnoid"}}