{"action":"created","comment":{"url":"https://api.github.com/repos/wellcometrust/platform/pulls/comments/184444090","pull_request_review_id":115642996,"id":184444090,"diff_hunk":"@@ -0,0 +1,20 @@\n+package uk.ac.wellcome.s3\n+\n+import java.net.URI\n+\n+import scala.util.Try\n+\n+case class S3ObjectLocation(bucket: String, key: String) {\n+  def toURI: URI = {","path":"common/src/main/scala/uk/ac/wellcome/s3/S3ObjectLocation.scala","position":8,"original_position":8,"commit_id":"35b969453c0e6cfbc8f929bd63a4c6c1508eeac5","original_commit_id":"35b969453c0e6cfbc8f929bd63a4c6c1508eeac5","user":{"login":"alicefuzier","id":26736746,"avatar_url":"https://avatars3.githubusercontent.com/u/26736746?v=4","gravatar_id":"","url":"https://api.github.com/users/alicefuzier","html_url":"https://github.com/alicefuzier","followers_url":"https://api.github.com/users/alicefuzier/followers","following_url":"https://api.github.com/users/alicefuzier/following{/other_user}","gists_url":"https://api.github.com/users/alicefuzier/gists{/gist_id}","starred_url":"https://api.github.com/users/alicefuzier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alicefuzier/subscriptions","organizations_url":"https://api.github.com/users/alicefuzier/orgs","repos_url":"https://api.github.com/users/alicefuzier/repos","events_url":"https://api.github.com/users/alicefuzier/events{/privacy}","received_events_url":"https://api.github.com/users/alicefuzier/received_events","type":"User","site_admin":false},"body":"I don't see this ever being used..","created_at":"2018-04-26T16:01:50Z","updated_at":"2018-04-26T16:01:50Z","html_url":"https://github.com/wellcometrust/platform/pull/1923#discussion_r184444090","pull_request_url":"https://api.github.com/repos/wellcometrust/platform/pulls/1923","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/platform/pulls/comments/184444090"},"html":{"href":"https://github.com/wellcometrust/platform/pull/1923#discussion_r184444090"},"pull_request":{"href":"https://api.github.com/repos/wellcometrust/platform/pulls/1923"}}},"pull_request":{"url":"https://api.github.com/repos/wellcometrust/platform/pulls/1923","id":182870358,"html_url":"https://github.com/wellcometrust/platform/pull/1923","diff_url":"https://github.com/wellcometrust/platform/pull/1923.diff","patch_url":"https://github.com/wellcometrust/platform/pull/1923.patch","issue_url":"https://api.github.com/repos/wellcometrust/platform/issues/1923","number":1923,"state":"open","locked":false,"title":"Allow passing messages larger than SNS size cap","user":{"login":"kenoir","id":953792,"avatar_url":"https://avatars3.githubusercontent.com/u/953792?v=4","gravatar_id":"","url":"https://api.github.com/users/kenoir","html_url":"https://github.com/kenoir","followers_url":"https://api.github.com/users/kenoir/followers","following_url":"https://api.github.com/users/kenoir/following{/other_user}","gists_url":"https://api.github.com/users/kenoir/gists{/gist_id}","starred_url":"https://api.github.com/users/kenoir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kenoir/subscriptions","organizations_url":"https://api.github.com/users/kenoir/orgs","repos_url":"https://api.github.com/users/kenoir/repos","events_url":"https://api.github.com/users/kenoir/events{/privacy}","received_events_url":"https://api.github.com/users/kenoir/received_events","type":"User","site_admin":false},"body":"### What is this PR trying to achieve?\r\n\r\nSupersedes: https://github.com/wellcometrust/platform/pull/1891\r\n\r\nFix #1776 and prevent AWS SNS/SQS messages exceeding maximum size limit.\r\n\r\nThis change stores references to objects in S3 and hands around message pointers to them rather than handling the entire object, bypassing the size limit.\r\n\r\nThe `MessageWorker` class introduced here allows direct passing of objects serialisable with circe, and is intended to supersede SQSWorker where appropriate.\r\n\r\n**TODO:**\r\n- [x] Consider options for removing inheritance requirement from `MessageWorker`\r\n- [x] Test including Worker & Writer to cover send and receive path in single test\r\n\r\n### Have the following been considered/are they needed?\r\n\r\n- [ ] Deployed new versions\r\n- [ ] Run `terraform apply`.","created_at":"2018-04-19T19:08:37Z","updated_at":"2018-04-26T16:01:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"3cae46ea084add15377760764a097cbde013afb6","assignee":null,"assignees":[],"requested_reviewers":[{"login":"alexwlchan","id":301220,"avatar_url":"https://avatars0.githubusercontent.com/u/301220?v=4","gravatar_id":"","url":"https://api.github.com/users/alexwlchan","html_url":"https://github.com/alexwlchan","followers_url":"https://api.github.com/users/alexwlchan/followers","following_url":"https://api.github.com/users/alexwlchan/following{/other_user}","gists_url":"https://api.github.com/users/alexwlchan/gists{/gist_id}","starred_url":"https://api.github.com/users/alexwlchan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexwlchan/subscriptions","organizations_url":"https://api.github.com/users/alexwlchan/orgs","repos_url":"https://api.github.com/users/alexwlchan/repos","events_url":"https://api.github.com/users/alexwlchan/events{/privacy}","received_events_url":"https://api.github.com/users/alexwlchan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wellcometrust/platform/pulls/1923/commits","review_comments_url":"https://api.github.com/repos/wellcometrust/platform/pulls/1923/comments","review_comment_url":"https://api.github.com/repos/wellcometrust/platform/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wellcometrust/platform/issues/1923/comments","statuses_url":"https://api.github.com/repos/wellcometrust/platform/statuses/35b969453c0e6cfbc8f929bd63a4c6c1508eeac5","head":{"label":"wellcometrust:fix-sns-max-message-size-redux","ref":"fix-sns-max-message-size-redux","sha":"35b969453c0e6cfbc8f929bd63a4c6c1508eeac5","user":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars3.githubusercontent.com/u/2814213?v=4","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":80218943,"name":"platform","full_name":"wellcometrust/platform","owner":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars3.githubusercontent.com/u/2814213?v=4","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellcometrust/platform","description":"Wellcome Collection digital platform","fork":false,"url":"https://api.github.com/repos/wellcometrust/platform","forks_url":"https://api.github.com/repos/wellcometrust/platform/forks","keys_url":"https://api.github.com/repos/wellcometrust/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/platform/teams","hooks_url":"https://api.github.com/repos/wellcometrust/platform/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/platform/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/platform/events","assignees_url":"https://api.github.com/repos/wellcometrust/platform/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/platform/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/platform/tags","blobs_url":"https://api.github.com/repos/wellcometrust/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/platform/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/platform/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/platform/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/platform/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/platform/subscription","commits_url":"https://api.github.com/repos/wellcometrust/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/platform/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/platform/merges","archive_url":"https://api.github.com/repos/wellcometrust/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/platform/downloads","issues_url":"https://api.github.com/repos/wellcometrust/platform/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/platform/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/platform/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/platform/deployments","created_at":"2017-01-27T15:27:42Z","updated_at":"2018-04-26T15:09:38Z","pushed_at":"2018-04-26T15:35:54Z","git_url":"git://github.com/wellcometrust/platform.git","ssh_url":"git@github.com:wellcometrust/platform.git","clone_url":"https://github.com/wellcometrust/platform.git","svn_url":"https://github.com/wellcometrust/platform","homepage":"https://developers.wellcomecollection.org/","size":13150,"stargazers_count":13,"watchers_count":13,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":142,"watchers":13,"default_branch":"master"}},"base":{"label":"wellcometrust:master","ref":"master","sha":"a5e4515d00742123fce8e57469f7d259ed5a227e","user":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars3.githubusercontent.com/u/2814213?v=4","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"repo":{"id":80218943,"name":"platform","full_name":"wellcometrust/platform","owner":{"login":"wellcometrust","id":2814213,"avatar_url":"https://avatars3.githubusercontent.com/u/2814213?v=4","gravatar_id":"","url":"https://api.github.com/users/wellcometrust","html_url":"https://github.com/wellcometrust","followers_url":"https://api.github.com/users/wellcometrust/followers","following_url":"https://api.github.com/users/wellcometrust/following{/other_user}","gists_url":"https://api.github.com/users/wellcometrust/gists{/gist_id}","starred_url":"https://api.github.com/users/wellcometrust/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wellcometrust/subscriptions","organizations_url":"https://api.github.com/users/wellcometrust/orgs","repos_url":"https://api.github.com/users/wellcometrust/repos","events_url":"https://api.github.com/users/wellcometrust/events{/privacy}","received_events_url":"https://api.github.com/users/wellcometrust/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wellcometrust/platform","description":"Wellcome Collection digital platform","fork":false,"url":"https://api.github.com/repos/wellcometrust/platform","forks_url":"https://api.github.com/repos/wellcometrust/platform/forks","keys_url":"https://api.github.com/repos/wellcometrust/platform/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wellcometrust/platform/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wellcometrust/platform/teams","hooks_url":"https://api.github.com/repos/wellcometrust/platform/hooks","issue_events_url":"https://api.github.com/repos/wellcometrust/platform/issues/events{/number}","events_url":"https://api.github.com/repos/wellcometrust/platform/events","assignees_url":"https://api.github.com/repos/wellcometrust/platform/assignees{/user}","branches_url":"https://api.github.com/repos/wellcometrust/platform/branches{/branch}","tags_url":"https://api.github.com/repos/wellcometrust/platform/tags","blobs_url":"https://api.github.com/repos/wellcometrust/platform/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wellcometrust/platform/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wellcometrust/platform/git/refs{/sha}","trees_url":"https://api.github.com/repos/wellcometrust/platform/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wellcometrust/platform/statuses/{sha}","languages_url":"https://api.github.com/repos/wellcometrust/platform/languages","stargazers_url":"https://api.github.com/repos/wellcometrust/platform/stargazers","contributors_url":"https://api.github.com/repos/wellcometrust/platform/contributors","subscribers_url":"https://api.github.com/repos/wellcometrust/platform/subscribers","subscription_url":"https://api.github.com/repos/wellcometrust/platform/subscription","commits_url":"https://api.github.com/repos/wellcometrust/platform/commits{/sha}","git_commits_url":"https://api.github.com/repos/wellcometrust/platform/git/commits{/sha}","comments_url":"https://api.github.com/repos/wellcometrust/platform/comments{/number}","issue_comment_url":"https://api.github.com/repos/wellcometrust/platform/issues/comments{/number}","contents_url":"https://api.github.com/repos/wellcometrust/platform/contents/{+path}","compare_url":"https://api.github.com/repos/wellcometrust/platform/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wellcometrust/platform/merges","archive_url":"https://api.github.com/repos/wellcometrust/platform/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wellcometrust/platform/downloads","issues_url":"https://api.github.com/repos/wellcometrust/platform/issues{/number}","pulls_url":"https://api.github.com/repos/wellcometrust/platform/pulls{/number}","milestones_url":"https://api.github.com/repos/wellcometrust/platform/milestones{/number}","notifications_url":"https://api.github.com/repos/wellcometrust/platform/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wellcometrust/platform/labels{/name}","releases_url":"https://api.github.com/repos/wellcometrust/platform/releases{/id}","deployments_url":"https://api.github.com/repos/wellcometrust/platform/deployments","created_at":"2017-01-27T15:27:42Z","updated_at":"2018-04-26T15:09:38Z","pushed_at":"2018-04-26T15:35:54Z","git_url":"git://github.com/wellcometrust/platform.git","ssh_url":"git@github.com:wellcometrust/platform.git","clone_url":"https://github.com/wellcometrust/platform.git","svn_url":"https://github.com/wellcometrust/platform","homepage":"https://developers.wellcomecollection.org/","size":13150,"stargazers_count":13,"watchers_count":13,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":5,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":5,"open_issues":142,"watchers":13,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wellcometrust/platform/pulls/1923"},"html":{"href":"https://github.com/wellcometrust/platform/pull/1923"},"issue":{"href":"https://api.github.com/repos/wellcometrust/platform/issues/1923"},"comments":{"href":"https://api.github.com/repos/wellcometrust/platform/issues/1923/comments"},"review_comments":{"href":"https://api.github.com/repos/wellcometrust/platform/pulls/1923/comments"},"review_comment":{"href":"https://api.github.com/repos/wellcometrust/platform/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wellcometrust/platform/pulls/1923/commits"},"statuses":{"href":"https://api.github.com/repos/wellcometrust/platform/statuses/35b969453c0e6cfbc8f929bd63a4c6c1508eeac5"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"alicefuzier"}}