{"action":"closed","number":2618,"pull_request":{"url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2618","id":179002349,"html_url":"https://github.com/rust-lang-nursery/rust-clippy/pull/2618","diff_url":"https://github.com/rust-lang-nursery/rust-clippy/pull/2618.diff","patch_url":"https://github.com/rust-lang-nursery/rust-clippy/pull/2618.patch","issue_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2618","number":2618,"state":"closed","locked":false,"title":"Move `set -e` to before the deploy","user":{"login":"rcoh","id":492903,"avatar_url":"https://avatars0.githubusercontent.com/u/492903?v=4","gravatar_id":"","url":"https://api.github.com/users/rcoh","html_url":"https://github.com/rcoh","followers_url":"https://api.github.com/users/rcoh/followers","following_url":"https://api.github.com/users/rcoh/following{/other_user}","gists_url":"https://api.github.com/users/rcoh/gists{/gist_id}","starred_url":"https://api.github.com/users/rcoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcoh/subscriptions","organizations_url":"https://api.github.com/users/rcoh/orgs","repos_url":"https://api.github.com/users/rcoh/repos","events_url":"https://api.github.com/users/rcoh/events{/privacy}","received_events_url":"https://api.github.com/users/rcoh/received_events","type":"User","site_admin":false},"body":"I _think_ this might be why the deploy script crashing isn't causing the release to fail (see #2600). Not sure if there's an easy way to make a test-release to test that. In any case, the most recent build of 191 https://travis-ci.org/rust-lang-nursery/rust-clippy/builds/360193356 had this problem.","created_at":"2018-04-03T06:13:19Z","updated_at":"2018-04-03T06:49:19Z","closed_at":"2018-04-03T06:49:19Z","merged_at":"2018-04-03T06:49:19Z","merge_commit_sha":"c012fecce6856a59fc9fe0845dab14117153adc7","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2618/commits","review_comments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2618/comments","review_comment_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/comments{/number}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2618/comments","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/statuses/35125d370f788d4c8c44751434592d7e8e841462","head":{"label":"rcoh:patch-1","ref":"patch-1","sha":"35125d370f788d4c8c44751434592d7e8e841462","user":{"login":"rcoh","id":492903,"avatar_url":"https://avatars0.githubusercontent.com/u/492903?v=4","gravatar_id":"","url":"https://api.github.com/users/rcoh","html_url":"https://github.com/rcoh","followers_url":"https://api.github.com/users/rcoh/followers","following_url":"https://api.github.com/users/rcoh/following{/other_user}","gists_url":"https://api.github.com/users/rcoh/gists{/gist_id}","starred_url":"https://api.github.com/users/rcoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcoh/subscriptions","organizations_url":"https://api.github.com/users/rcoh/orgs","repos_url":"https://api.github.com/users/rcoh/repos","events_url":"https://api.github.com/users/rcoh/events{/privacy}","received_events_url":"https://api.github.com/users/rcoh/received_events","type":"User","site_admin":false},"repo":{"id":127859635,"name":"rust-clippy","full_name":"rcoh/rust-clippy","owner":{"login":"rcoh","id":492903,"avatar_url":"https://avatars0.githubusercontent.com/u/492903?v=4","gravatar_id":"","url":"https://api.github.com/users/rcoh","html_url":"https://github.com/rcoh","followers_url":"https://api.github.com/users/rcoh/followers","following_url":"https://api.github.com/users/rcoh/following{/other_user}","gists_url":"https://api.github.com/users/rcoh/gists{/gist_id}","starred_url":"https://api.github.com/users/rcoh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rcoh/subscriptions","organizations_url":"https://api.github.com/users/rcoh/orgs","repos_url":"https://api.github.com/users/rcoh/repos","events_url":"https://api.github.com/users/rcoh/events{/privacy}","received_events_url":"https://api.github.com/users/rcoh/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rcoh/rust-clippy","description":"A bunch of lints to catch common mistakes and improve your Rust code","fork":true,"url":"https://api.github.com/repos/rcoh/rust-clippy","forks_url":"https://api.github.com/repos/rcoh/rust-clippy/forks","keys_url":"https://api.github.com/repos/rcoh/rust-clippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rcoh/rust-clippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rcoh/rust-clippy/teams","hooks_url":"https://api.github.com/repos/rcoh/rust-clippy/hooks","issue_events_url":"https://api.github.com/repos/rcoh/rust-clippy/issues/events{/number}","events_url":"https://api.github.com/repos/rcoh/rust-clippy/events","assignees_url":"https://api.github.com/repos/rcoh/rust-clippy/assignees{/user}","branches_url":"https://api.github.com/repos/rcoh/rust-clippy/branches{/branch}","tags_url":"https://api.github.com/repos/rcoh/rust-clippy/tags","blobs_url":"https://api.github.com/repos/rcoh/rust-clippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rcoh/rust-clippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rcoh/rust-clippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rcoh/rust-clippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rcoh/rust-clippy/statuses/{sha}","languages_url":"https://api.github.com/repos/rcoh/rust-clippy/languages","stargazers_url":"https://api.github.com/repos/rcoh/rust-clippy/stargazers","contributors_url":"https://api.github.com/repos/rcoh/rust-clippy/contributors","subscribers_url":"https://api.github.com/repos/rcoh/rust-clippy/subscribers","subscription_url":"https://api.github.com/repos/rcoh/rust-clippy/subscription","commits_url":"https://api.github.com/repos/rcoh/rust-clippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rcoh/rust-clippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rcoh/rust-clippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rcoh/rust-clippy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rcoh/rust-clippy/contents/{+path}","compare_url":"https://api.github.com/repos/rcoh/rust-clippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rcoh/rust-clippy/merges","archive_url":"https://api.github.com/repos/rcoh/rust-clippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rcoh/rust-clippy/downloads","issues_url":"https://api.github.com/repos/rcoh/rust-clippy/issues{/number}","pulls_url":"https://api.github.com/repos/rcoh/rust-clippy/pulls{/number}","milestones_url":"https://api.github.com/repos/rcoh/rust-clippy/milestones{/number}","notifications_url":"https://api.github.com/repos/rcoh/rust-clippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rcoh/rust-clippy/labels{/name}","releases_url":"https://api.github.com/repos/rcoh/rust-clippy/releases{/id}","deployments_url":"https://api.github.com/repos/rcoh/rust-clippy/deployments","created_at":"2018-04-03T06:10:30Z","updated_at":"2018-04-03T06:10:33Z","pushed_at":"2018-04-03T06:11:47Z","git_url":"git://github.com/rcoh/rust-clippy.git","ssh_url":"git@github.com:rcoh/rust-clippy.git","clone_url":"https://github.com/rcoh/rust-clippy.git","svn_url":"https://github.com/rcoh/rust-clippy","homepage":"https://rust-lang-nursery.github.io/rust-clippy","size":8231,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"rust-lang-nursery:master","ref":"master","sha":"90fcdafb79995f8ca6d444fac05e2291707aea1c","user":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"repo":{"id":26850443,"name":"rust-clippy","full_name":"rust-lang-nursery/rust-clippy","owner":{"login":"rust-lang-nursery","id":14631425,"avatar_url":"https://avatars1.githubusercontent.com/u/14631425?v=4","gravatar_id":"","url":"https://api.github.com/users/rust-lang-nursery","html_url":"https://github.com/rust-lang-nursery","followers_url":"https://api.github.com/users/rust-lang-nursery/followers","following_url":"https://api.github.com/users/rust-lang-nursery/following{/other_user}","gists_url":"https://api.github.com/users/rust-lang-nursery/gists{/gist_id}","starred_url":"https://api.github.com/users/rust-lang-nursery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rust-lang-nursery/subscriptions","organizations_url":"https://api.github.com/users/rust-lang-nursery/orgs","repos_url":"https://api.github.com/users/rust-lang-nursery/repos","events_url":"https://api.github.com/users/rust-lang-nursery/events{/privacy}","received_events_url":"https://api.github.com/users/rust-lang-nursery/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/rust-lang-nursery/rust-clippy","description":"A bunch of lints to catch common mistakes and improve your Rust code","fork":false,"url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy","forks_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/forks","keys_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/teams","hooks_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/hooks","issue_events_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/events{/number}","events_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/events","assignees_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/assignees{/user}","branches_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/branches{/branch}","tags_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/tags","blobs_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/refs{/sha}","trees_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/statuses/{sha}","languages_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/languages","stargazers_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/stargazers","contributors_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/contributors","subscribers_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/subscribers","subscription_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/subscription","commits_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/commits{/sha}","git_commits_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/git/commits{/sha}","comments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/comments{/number}","issue_comment_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/comments{/number}","contents_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/contents/{+path}","compare_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/merges","archive_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/downloads","issues_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues{/number}","pulls_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls{/number}","milestones_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/milestones{/number}","notifications_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/labels{/name}","releases_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/releases{/id}","deployments_url":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/deployments","created_at":"2014-11-19T07:49:21Z","updated_at":"2018-04-03T01:31:54Z","pushed_at":"2018-04-03T06:49:19Z","git_url":"git://github.com/rust-lang-nursery/rust-clippy.git","ssh_url":"git@github.com:rust-lang-nursery/rust-clippy.git","clone_url":"https://github.com/rust-lang-nursery/rust-clippy.git","svn_url":"https://github.com/rust-lang-nursery/rust-clippy","homepage":"https://rust-lang-nursery.github.io/rust-clippy","size":8231,"stargazers_count":1990,"watchers_count":1990,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":267,"mirror_url":null,"archived":false,"open_issues_count":688,"license":{"key":"mpl-2.0","name":"Mozilla Public License 2.0","spdx_id":"MPL-2.0","url":"https://api.github.com/licenses/mpl-2.0"},"forks":267,"open_issues":688,"watchers":1990,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2618"},"html":{"href":"https://github.com/rust-lang-nursery/rust-clippy/pull/2618"},"issue":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2618"},"comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/issues/2618/comments"},"review_comments":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2618/comments"},"review_comment":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/pulls/2618/commits"},"statuses":{"href":"https://api.github.com/repos/rust-lang-nursery/rust-clippy/statuses/35125d370f788d4c8c44751434592d7e8e841462"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"oli-obk","id":332036,"avatar_url":"https://avatars2.githubusercontent.com/u/332036?v=4","gravatar_id":"","url":"https://api.github.com/users/oli-obk","html_url":"https://github.com/oli-obk","followers_url":"https://api.github.com/users/oli-obk/followers","following_url":"https://api.github.com/users/oli-obk/following{/other_user}","gists_url":"https://api.github.com/users/oli-obk/gists{/gist_id}","starred_url":"https://api.github.com/users/oli-obk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/oli-obk/subscriptions","organizations_url":"https://api.github.com/users/oli-obk/orgs","repos_url":"https://api.github.com/users/oli-obk/repos","events_url":"https://api.github.com/users/oli-obk/events{/privacy}","received_events_url":"https://api.github.com/users/oli-obk/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":2,"deletions":2,"changed_files":1}}
{"actor":{"display_login":"oli-obk"}}