{"action":"created","issue":{"url":"https://api.github.com/repos/18F/identity-idp/issues/2063","repository_url":"https://api.github.com/repos/18F/identity-idp","labels_url":"https://api.github.com/repos/18F/identity-idp/issues/2063/labels{/name}","comments_url":"https://api.github.com/repos/18F/identity-idp/issues/2063/comments","events_url":"https://api.github.com/repos/18F/identity-idp/issues/2063/events","html_url":"https://github.com/18F/identity-idp/pull/2063","id":308227546,"number":2063,"title":"LG-140 Add ability to remember a phone for 2FA","user":{"login":"jmhooper","id":963654,"avatar_url":"https://avatars1.githubusercontent.com/u/963654?v=4","gravatar_id":"","url":"https://api.github.com/users/jmhooper","html_url":"https://github.com/jmhooper","followers_url":"https://api.github.com/users/jmhooper/followers","following_url":"https://api.github.com/users/jmhooper/following{/other_user}","gists_url":"https://api.github.com/users/jmhooper/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhooper/subscriptions","organizations_url":"https://api.github.com/users/jmhooper/orgs","repos_url":"https://api.github.com/users/jmhooper/repos","events_url":"https://api.github.com/users/jmhooper/events{/privacy}","received_events_url":"https://api.github.com/users/jmhooper/received_events","type":"User","site_admin":false},"labels":[{"id":355011342,"url":"https://api.github.com/repos/18F/identity-idp/labels/status%20-%20ready%20for%20review","name":"status - ready for review","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-03-24T04:12:08Z","updated_at":"2018-04-09T16:56:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/18F/identity-idp/pulls/2063","html_url":"https://github.com/18F/identity-idp/pull/2063","diff_url":"https://github.com/18F/identity-idp/pull/2063.diff","patch_url":"https://github.com/18F/identity-idp/pull/2063.patch"},"body":"**Why**: So that users who log in repeatedly do not need to continually\r\n2FA\r\n\r\n**How**: Store an encrypted cookie that contains the user's ID and the\r\ntime the cookie was created. When the user goes to 2FA, check for that\r\ncookie, and skip 2FA if it exists.\r\n\r\nHi! Before submitting your PR for review, and/or before merging it, please\r\ngo through the following checklist:\r\n\r\n- [x] For DB changes, check for missing indexes, check to see if the changes\r\naffect other apps (such as the dashboard), make sure the DB columns in the\r\nvarious environments are properly populated, coordinate with devops, plan\r\nmigrations in separate steps.\r\n\r\n- [x] For route changes, make sure GET requests don't change state or result in\r\ndestructive behavior. GET requests should only result in information being\r\nread, not written.\r\n\r\n- [x] For encryption changes, make sure it is compatible with data that was\r\nencrypted with the old code.\r\n\r\n- [x] For secrets changes, [make sure to update the S3 secrets bucket](https://github.com/18F/identity-private/wiki/Secrets-S3-buckets) with the \r\nnew configs in **all** environments. \r\n\r\n- [x] Do not disable Rubocop or Reek offenses unless you are absolutely sure\r\nthey are false positives. If you're not sure how to fix the offense, please\r\nask a teammate.\r\n\r\n- [x] When reading data, write tests for nil values, empty strings,\r\nand invalid formats.\r\n\r\n- [x] When calling `redirect_to` in a controller, use `_url`, not `_path`.\r\n\r\n- [x] When adding user data to the session, use the `user_session` helper\r\ninstead of the `session` helper so the data does not persist beyond the user's\r\nsession.\r\n\r\n- [x] When adding a new controller that requires the user to be fully\r\nauthenticated, make sure to add `before_action :confirm_two_factor_authenticated`.\r\n"},"comment":{"url":"https://api.github.com/repos/18F/identity-idp/issues/comments/379820916","html_url":"https://github.com/18F/identity-idp/pull/2063#issuecomment-379820916","issue_url":"https://api.github.com/repos/18F/identity-idp/issues/2063","id":379820916,"user":{"login":"jmhooper","id":963654,"avatar_url":"https://avatars1.githubusercontent.com/u/963654?v=4","gravatar_id":"","url":"https://api.github.com/users/jmhooper","html_url":"https://github.com/jmhooper","followers_url":"https://api.github.com/users/jmhooper/followers","following_url":"https://api.github.com/users/jmhooper/following{/other_user}","gists_url":"https://api.github.com/users/jmhooper/gists{/gist_id}","starred_url":"https://api.github.com/users/jmhooper/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmhooper/subscriptions","organizations_url":"https://api.github.com/users/jmhooper/orgs","repos_url":"https://api.github.com/users/jmhooper/repos","events_url":"https://api.github.com/users/jmhooper/events{/privacy}","received_events_url":"https://api.github.com/users/jmhooper/received_events","type":"User","site_admin":false},"created_at":"2018-04-09T16:56:14Z","updated_at":"2018-04-09T16:56:14Z","author_association":"MEMBER","body":"@monfresh:\r\n\r\nRE remembering the selection: I think it is possible but is most likely worth doing in a follow on if we want it\r\n\r\nRE the CSP issues: That's a really good catch. We'll need to the secure headers concern to the sign in screen."}}
{"actor":{"display_login":"jmhooper"}}