{"action":"created","issue":{"url":"https://api.github.com/repos/NAVCoin/navpi-go/issues/46","repository_url":"https://api.github.com/repos/NAVCoin/navpi-go","labels_url":"https://api.github.com/repos/NAVCoin/navpi-go/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/NAVCoin/navpi-go/issues/46/comments","events_url":"https://api.github.com/repos/NAVCoin/navpi-go/issues/46/events","html_url":"https://github.com/NAVCoin/navpi-go/pull/46","id":302211592,"number":46,"title":"V2.0.0 kowhai rpc daemon start","user":{"login":"red010b37","id":4919660,"avatar_url":"https://avatars0.githubusercontent.com/u/4919660?v=4","gravatar_id":"","url":"https://api.github.com/users/red010b37","html_url":"https://github.com/red010b37","followers_url":"https://api.github.com/users/red010b37/followers","following_url":"https://api.github.com/users/red010b37/following{/other_user}","gists_url":"https://api.github.com/users/red010b37/gists{/gist_id}","starred_url":"https://api.github.com/users/red010b37/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/red010b37/subscriptions","organizations_url":"https://api.github.com/users/red010b37/orgs","repos_url":"https://api.github.com/users/red010b37/repos","events_url":"https://api.github.com/users/red010b37/events{/privacy}","received_events_url":"https://api.github.com/users/red010b37/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-05T08:37:34Z","updated_at":"2018-03-05T10:33:43Z","closed_at":"2018-03-05T09:39:53Z","author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/NAVCoin/navpi-go/pulls/46","html_url":"https://github.com/NAVCoin/navpi-go/pull/46","diff_url":"https://github.com/NAVCoin/navpi-go/pull/46.diff","patch_url":"https://github.com/NAVCoin/navpi-go/pull/46.patch"},"body":""},"comment":{"url":"https://api.github.com/repos/NAVCoin/navpi-go/issues/comments/370377333","html_url":"https://github.com/NAVCoin/navpi-go/pull/46#issuecomment-370377333","issue_url":"https://api.github.com/repos/NAVCoin/navpi-go/issues/46","id":370377333,"user":{"login":"matt-auckland","id":12672050,"avatar_url":"https://avatars2.githubusercontent.com/u/12672050?v=4","gravatar_id":"","url":"https://api.github.com/users/matt-auckland","html_url":"https://github.com/matt-auckland","followers_url":"https://api.github.com/users/matt-auckland/followers","following_url":"https://api.github.com/users/matt-auckland/following{/other_user}","gists_url":"https://api.github.com/users/matt-auckland/gists{/gist_id}","starred_url":"https://api.github.com/users/matt-auckland/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matt-auckland/subscriptions","organizations_url":"https://api.github.com/users/matt-auckland/orgs","repos_url":"https://api.github.com/users/matt-auckland/repos","events_url":"https://api.github.com/users/matt-auckland/events{/privacy}","received_events_url":"https://api.github.com/users/matt-auckland/received_events","type":"User","site_admin":false},"created_at":"2018-03-05T10:33:42Z","updated_at":"2018-03-05T10:33:42Z","author_association":"MEMBER","body":"Riiiight. That makes sense, thanks for explaining\n\nOn 5/03/2018 23:20, \"zanuka\" <notifications@github.com> wrote:\n\n> *@zanuka* commented on this pull request.\n> ------------------------------\n>\n> In app/main.go\n> <https://github.com/NAVCoin/navpi-go/pull/46#discussion_r172141209>:\n>\n> >  \tapi.InitMetaHandlers(router, \"api\")\n>\n>  \t// check to see if we have a defined running config\n>  \t// If not we are only going to boot the setup apis, otherwise we will start the app\n>  \tif conf.AppConf.RunningNavVersion == \"\" {\n>\n> -\t\t//log.Println(\"App config undetected :: creating mock config, initializing setup handlers\")\n> -\n> -\t\t//appConfig, err := conf.MockAppConfig()\n> -\t\t//if err != nil {\n> -\t\t//\tlog.Fatal(\"Failed to create the mock config: \" + err.Error())\n> -\t\t//} else {\n> -\t\t//\tlog.Println(\"appConfig\", appConfig)\n> -\t\t//}\n> -\n> +\t\tlog.Println(\"No App Config starting the setup api\")\n>  \t\tsetupapi.InitSetupHandlers(router, \"api\")\n>\n>\n> @matt-auckland <https://github.com/matt-auckland> yeah we've been using\n> that lowercase style throughout for vars that are local to functions, but\n> the general recommendation is that var names in Go should be short rather\n> than long. This is especially true for local variables with limited scope.\n> so you'll see lots of aa or x type convention in projects... which can be\n> a bit unreadable at times so we've been lengthening ours a bit for clarity.\n> We've also been adhering to the lowerCasePrivateFunction() and\n> UpperCasePublicFunction convention as well 👍\n>\n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub\n> <https://github.com/NAVCoin/navpi-go/pull/46#discussion_r172141209>, or mute\n> the thread\n> <https://github.com/notifications/unsubscribe-auth/AMFcMuJjw9pQjXZyFrWPhcyrEKW1uNDKks5tbRF2gaJpZM4Sb5oN>\n> .\n>\n"}}
{"actor":{"display_login":"matt-auckland"}}