{"action":"created","comment":{"url":"https://api.github.com/repos/symfony/symfony/pulls/comments/225889102","pull_request_review_id":165584737,"id":225889102,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNTg4OTEwMg==","diff_hunk":"@@ -304,6 +304,27 @@ class_exists('Test\\\\'.__NAMESPACE__.'\\\\UseTraitWithInternalMethod', true);\n \n         $this->assertSame(array(), $deprecations);\n     }\n+\n+    public function testVirtualUse()\n+    {\n+        $deprecations = array();\n+        set_error_handler(function ($type, $msg) use (&$deprecations) { $deprecations[] = $msg; });\n+        $e = error_reporting(E_USER_DEPRECATED);\n+\n+        class_exists('Test\\\\'.__NAMESPACE__.'\\\\ExtendsVirtual', true);\n+\n+        error_reporting($e);\n+        restore_error_handler();\n+\n+        var_dump($deprecations);","path":"src/Symfony/Component/Debug/Tests/DebugClassLoaderTest.php","position":16,"original_position":16,"commit_id":"b3e4af4865fa229c89df390a8872b386d078d7a3","original_commit_id":"354e6967efc41fc098563a8ec5e81ef772cf30fc","user":{"login":"ro0NL","id":1047696,"node_id":"MDQ6VXNlcjEwNDc2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1047696?v=4","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"body":"of course, meanwhile do you still have fixture suggestions? ","created_at":"2018-10-17T11:42:18Z","updated_at":"2018-10-17T11:42:18Z","html_url":"https://github.com/symfony/symfony/pull/28902#discussion_r225889102","pull_request_url":"https://api.github.com/repos/symfony/symfony/pulls/28902","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments/225889102"},"html":{"href":"https://github.com/symfony/symfony/pull/28902#discussion_r225889102"},"pull_request":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28902"}},"in_reply_to_id":225877269},"pull_request":{"url":"https://api.github.com/repos/symfony/symfony/pulls/28902","id":223530726,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNTMwNzI2","html_url":"https://github.com/symfony/symfony/pull/28902","diff_url":"https://github.com/symfony/symfony/pull/28902.diff","patch_url":"https://github.com/symfony/symfony/pull/28902.patch","issue_url":"https://api.github.com/repos/symfony/symfony/issues/28902","number":28902,"state":"open","locked":false,"title":"[Debug] Detect virtual methods using @method","user":{"login":"ro0NL","id":1047696,"node_id":"MDQ6VXNlcjEwNDc2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1047696?v=4","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"body":"| Q             | A\r\n| ------------- | ---\r\n| Branch?       | master\r\n| Bug fix?      | no\r\n| New feature?  | yes\r\n| BC breaks?    | no     <!-- see https://symfony.com/bc -->\r\n| Deprecations? | no\r\n| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->\r\n| Fixed tickets | https://github.com/symfony/symfony/pull/28897#issuecomment-430542792\r\n| License       | MIT\r\n| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->\r\n\r\nMy first Debug PR, so im still on it. But early feedback welcome.\r\n\r\nIn #28901 we'll introduce a new virtual interface method using `@method` annotation. IIUC the idea is to trigger whenever such a method is overridden.","created_at":"2018-10-17T09:31:21Z","updated_at":"2018-10-17T11:42:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"460ed50c5ac5d823df10c8a4c9f0743bd5817502","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":49125875,"node_id":"MDU6TGFiZWw0OTEyNTg3NQ==","url":"https://api.github.com/repos/symfony/symfony/labels/Debug","name":"Debug","color":"DDDDDD","default":false},{"id":100378,"node_id":"MDU6TGFiZWwxMDAzNzg=","url":"https://api.github.com/repos/symfony/symfony/labels/Feature","name":"Feature","color":"02e10c","default":false},{"id":237003792,"node_id":"MDU6TGFiZWwyMzcwMDM3OTI=","url":"https://api.github.com/repos/symfony/symfony/labels/Status:%20Needs%20Review","name":"Status: Needs Review","color":"ededed","default":false}],"milestone":{"url":"https://api.github.com/repos/symfony/symfony/milestones/18","html_url":"https://github.com/symfony/symfony/milestone/18","labels_url":"https://api.github.com/repos/symfony/symfony/milestones/18/labels","id":3234645,"node_id":"MDk6TWlsZXN0b25lMzIzNDY0NQ==","number":18,"title":"next","description":"https://symfony.com/roadmap?version=4.2#checker","creator":{"login":"nicolas-grekas","id":243674,"node_id":"MDQ6VXNlcjI0MzY3NA==","avatar_url":"https://avatars3.githubusercontent.com/u/243674?v=4","gravatar_id":"","url":"https://api.github.com/users/nicolas-grekas","html_url":"https://github.com/nicolas-grekas","followers_url":"https://api.github.com/users/nicolas-grekas/followers","following_url":"https://api.github.com/users/nicolas-grekas/following{/other_user}","gists_url":"https://api.github.com/users/nicolas-grekas/gists{/gist_id}","starred_url":"https://api.github.com/users/nicolas-grekas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nicolas-grekas/subscriptions","organizations_url":"https://api.github.com/users/nicolas-grekas/orgs","repos_url":"https://api.github.com/users/nicolas-grekas/repos","events_url":"https://api.github.com/users/nicolas-grekas/events{/privacy}","received_events_url":"https://api.github.com/users/nicolas-grekas/received_events","type":"User","site_admin":false},"open_issues":144,"closed_issues":330,"state":"open","created_at":"2018-04-02T12:03:21Z","updated_at":"2018-10-17T09:35:44Z","due_on":null,"closed_at":null},"commits_url":"https://api.github.com/repos/symfony/symfony/pulls/28902/commits","review_comments_url":"https://api.github.com/repos/symfony/symfony/pulls/28902/comments","review_comment_url":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}","comments_url":"https://api.github.com/repos/symfony/symfony/issues/28902/comments","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/b3e4af4865fa229c89df390a8872b386d078d7a3","head":{"label":"ro0NL:debug","ref":"debug","sha":"b3e4af4865fa229c89df390a8872b386d078d7a3","user":{"login":"ro0NL","id":1047696,"node_id":"MDQ6VXNlcjEwNDc2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1047696?v=4","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"repo":{"id":57444546,"node_id":"MDEwOlJlcG9zaXRvcnk1NzQ0NDU0Ng==","name":"symfony","full_name":"ro0NL/symfony","private":false,"owner":{"login":"ro0NL","id":1047696,"node_id":"MDQ6VXNlcjEwNDc2OTY=","avatar_url":"https://avatars0.githubusercontent.com/u/1047696?v=4","gravatar_id":"","url":"https://api.github.com/users/ro0NL","html_url":"https://github.com/ro0NL","followers_url":"https://api.github.com/users/ro0NL/followers","following_url":"https://api.github.com/users/ro0NL/following{/other_user}","gists_url":"https://api.github.com/users/ro0NL/gists{/gist_id}","starred_url":"https://api.github.com/users/ro0NL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ro0NL/subscriptions","organizations_url":"https://api.github.com/users/ro0NL/orgs","repos_url":"https://api.github.com/users/ro0NL/repos","events_url":"https://api.github.com/users/ro0NL/events{/privacy}","received_events_url":"https://api.github.com/users/ro0NL/received_events","type":"User","site_admin":false},"html_url":"https://github.com/ro0NL/symfony","description":"The Symfony PHP framework","fork":true,"url":"https://api.github.com/repos/ro0NL/symfony","forks_url":"https://api.github.com/repos/ro0NL/symfony/forks","keys_url":"https://api.github.com/repos/ro0NL/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ro0NL/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ro0NL/symfony/teams","hooks_url":"https://api.github.com/repos/ro0NL/symfony/hooks","issue_events_url":"https://api.github.com/repos/ro0NL/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/ro0NL/symfony/events","assignees_url":"https://api.github.com/repos/ro0NL/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/ro0NL/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/ro0NL/symfony/tags","blobs_url":"https://api.github.com/repos/ro0NL/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ro0NL/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ro0NL/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/ro0NL/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ro0NL/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/ro0NL/symfony/languages","stargazers_url":"https://api.github.com/repos/ro0NL/symfony/stargazers","contributors_url":"https://api.github.com/repos/ro0NL/symfony/contributors","subscribers_url":"https://api.github.com/repos/ro0NL/symfony/subscribers","subscription_url":"https://api.github.com/repos/ro0NL/symfony/subscription","commits_url":"https://api.github.com/repos/ro0NL/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/ro0NL/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/ro0NL/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/ro0NL/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/ro0NL/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/ro0NL/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ro0NL/symfony/merges","archive_url":"https://api.github.com/repos/ro0NL/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ro0NL/symfony/downloads","issues_url":"https://api.github.com/repos/ro0NL/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/ro0NL/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/ro0NL/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/ro0NL/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ro0NL/symfony/labels{/name}","releases_url":"https://api.github.com/repos/ro0NL/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/ro0NL/symfony/deployments","created_at":"2016-04-30T14:01:29Z","updated_at":"2018-09-23T11:00:31Z","pushed_at":"2018-10-17T11:41:21Z","git_url":"git://github.com/ro0NL/symfony.git","ssh_url":"git@github.com:ro0NL/symfony.git","clone_url":"https://github.com/ro0NL/symfony.git","svn_url":"https://github.com/ro0NL/symfony","homepage":"https://symfony.dev","size":121649,"stargazers_count":1,"watchers_count":1,"language":"PHP","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"symfony:master","ref":"master","sha":"dd432c4f1e5d003a7d39f3d827b7d2bb95403e88","user":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"repo":{"id":458058,"node_id":"MDEwOlJlcG9zaXRvcnk0NTgwNTg=","name":"symfony","full_name":"symfony/symfony","private":false,"owner":{"login":"symfony","id":143937,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MzkzNw==","avatar_url":"https://avatars3.githubusercontent.com/u/143937?v=4","gravatar_id":"","url":"https://api.github.com/users/symfony","html_url":"https://github.com/symfony","followers_url":"https://api.github.com/users/symfony/followers","following_url":"https://api.github.com/users/symfony/following{/other_user}","gists_url":"https://api.github.com/users/symfony/gists{/gist_id}","starred_url":"https://api.github.com/users/symfony/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/symfony/subscriptions","organizations_url":"https://api.github.com/users/symfony/orgs","repos_url":"https://api.github.com/users/symfony/repos","events_url":"https://api.github.com/users/symfony/events{/privacy}","received_events_url":"https://api.github.com/users/symfony/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/symfony/symfony","description":"The Symfony PHP framework","fork":false,"url":"https://api.github.com/repos/symfony/symfony","forks_url":"https://api.github.com/repos/symfony/symfony/forks","keys_url":"https://api.github.com/repos/symfony/symfony/keys{/key_id}","collaborators_url":"https://api.github.com/repos/symfony/symfony/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/symfony/symfony/teams","hooks_url":"https://api.github.com/repos/symfony/symfony/hooks","issue_events_url":"https://api.github.com/repos/symfony/symfony/issues/events{/number}","events_url":"https://api.github.com/repos/symfony/symfony/events","assignees_url":"https://api.github.com/repos/symfony/symfony/assignees{/user}","branches_url":"https://api.github.com/repos/symfony/symfony/branches{/branch}","tags_url":"https://api.github.com/repos/symfony/symfony/tags","blobs_url":"https://api.github.com/repos/symfony/symfony/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/symfony/symfony/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/symfony/symfony/git/refs{/sha}","trees_url":"https://api.github.com/repos/symfony/symfony/git/trees{/sha}","statuses_url":"https://api.github.com/repos/symfony/symfony/statuses/{sha}","languages_url":"https://api.github.com/repos/symfony/symfony/languages","stargazers_url":"https://api.github.com/repos/symfony/symfony/stargazers","contributors_url":"https://api.github.com/repos/symfony/symfony/contributors","subscribers_url":"https://api.github.com/repos/symfony/symfony/subscribers","subscription_url":"https://api.github.com/repos/symfony/symfony/subscription","commits_url":"https://api.github.com/repos/symfony/symfony/commits{/sha}","git_commits_url":"https://api.github.com/repos/symfony/symfony/git/commits{/sha}","comments_url":"https://api.github.com/repos/symfony/symfony/comments{/number}","issue_comment_url":"https://api.github.com/repos/symfony/symfony/issues/comments{/number}","contents_url":"https://api.github.com/repos/symfony/symfony/contents/{+path}","compare_url":"https://api.github.com/repos/symfony/symfony/compare/{base}...{head}","merges_url":"https://api.github.com/repos/symfony/symfony/merges","archive_url":"https://api.github.com/repos/symfony/symfony/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/symfony/symfony/downloads","issues_url":"https://api.github.com/repos/symfony/symfony/issues{/number}","pulls_url":"https://api.github.com/repos/symfony/symfony/pulls{/number}","milestones_url":"https://api.github.com/repos/symfony/symfony/milestones{/number}","notifications_url":"https://api.github.com/repos/symfony/symfony/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/symfony/symfony/labels{/name}","releases_url":"https://api.github.com/repos/symfony/symfony/releases{/id}","deployments_url":"https://api.github.com/repos/symfony/symfony/deployments","created_at":"2010-01-04T14:21:21Z","updated_at":"2018-10-17T11:26:51Z","pushed_at":"2018-10-17T11:41:24Z","git_url":"git://github.com/symfony/symfony.git","ssh_url":"git@github.com:symfony/symfony.git","clone_url":"https://github.com/symfony/symfony.git","svn_url":"https://github.com/symfony/symfony","homepage":"https://symfony.com","size":126731,"stargazers_count":18814,"watchers_count":18814,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":6462,"mirror_url":null,"archived":false,"open_issues_count":818,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":6462,"open_issues":818,"watchers":18814,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28902"},"html":{"href":"https://github.com/symfony/symfony/pull/28902"},"issue":{"href":"https://api.github.com/repos/symfony/symfony/issues/28902"},"comments":{"href":"https://api.github.com/repos/symfony/symfony/issues/28902/comments"},"review_comments":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28902/comments"},"review_comment":{"href":"https://api.github.com/repos/symfony/symfony/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/symfony/symfony/pulls/28902/commits"},"statuses":{"href":"https://api.github.com/repos/symfony/symfony/statuses/b3e4af4865fa229c89df390a8872b386d078d7a3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"ro0NL"}}