{"action":"created","issue":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2676","repository_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer","labels_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2676/labels{/name}","comments_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2676/comments","events_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2676/events","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2676","id":381193305,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMjE5NzYy","number":2676,"title":"[Core] Add array support for buffSpellId","user":{"login":"niseko","id":2842471,"node_id":"MDQ6VXNlcjI4NDI0NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2842471?v=4","gravatar_id":"","url":"https://api.github.com/users/niseko","html_url":"https://github.com/niseko","followers_url":"https://api.github.com/users/niseko/followers","following_url":"https://api.github.com/users/niseko/following{/other_user}","gists_url":"https://api.github.com/users/niseko/gists{/gist_id}","starred_url":"https://api.github.com/users/niseko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niseko/subscriptions","organizations_url":"https://api.github.com/users/niseko/orgs","repos_url":"https://api.github.com/users/niseko/repos","events_url":"https://api.github.com/users/niseko/events{/privacy}","received_events_url":"https://api.github.com/users/niseko/received_events","type":"User","site_admin":false},"labels":[{"id":732044734,"node_id":"MDU6TGFiZWw3MzIwNDQ3MzQ=","url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/labels/core","name":"core","color":"000000","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-15T14:46:52Z","updated_at":"2018-11-15T15:36:00Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/pulls/2676","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2676","diff_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2676.diff","patch_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2676.patch"},"body":"As i've seen a lot of requests for that\r\n\r\n![image](https://user-images.githubusercontent.com/2842471/48559833-b1efaa80-e8ec-11e8-8768-fe4ccdbf196f.png)\r\nprepot:\r\n![image](https://user-images.githubusercontent.com/2842471/48559853-c16ef380-e8ec-11e8-8a68-26d32b9923ac.png)\r\nactual pot:\r\n![image](https://user-images.githubusercontent.com/2842471/48559927-fed38100-e8ec-11e8-97e4-95d2a8c6b8a7.png)\r\ndifferent pot:\r\n![image](https://user-images.githubusercontent.com/2842471/48560097-5bcf3700-e8ed-11e8-9fe8-c98d68481a48.png)\r\n\r\n\r\nfixes #2305, fixes #2306  \r\n\r\nEdit: this'll probably fuck with the #2571 implementation"},"comment":{"url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/comments/439082377","html_url":"https://github.com/WoWAnalyzer/WoWAnalyzer/pull/2676#issuecomment-439082377","issue_url":"https://api.github.com/repos/WoWAnalyzer/WoWAnalyzer/issues/2676","id":439082377,"node_id":"MDEyOklzc3VlQ29tbWVudDQzOTA4MjM3Nw==","user":{"login":"niseko","id":2842471,"node_id":"MDQ6VXNlcjI4NDI0NzE=","avatar_url":"https://avatars0.githubusercontent.com/u/2842471?v=4","gravatar_id":"","url":"https://api.github.com/users/niseko","html_url":"https://github.com/niseko","followers_url":"https://api.github.com/users/niseko/followers","following_url":"https://api.github.com/users/niseko/following{/other_user}","gists_url":"https://api.github.com/users/niseko/gists{/gist_id}","starred_url":"https://api.github.com/users/niseko/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/niseko/subscriptions","organizations_url":"https://api.github.com/users/niseko/orgs","repos_url":"https://api.github.com/users/niseko/repos","events_url":"https://api.github.com/users/niseko/events{/privacy}","received_events_url":"https://api.github.com/users/niseko/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T15:36:00Z","updated_at":"2018-11-15T15:36:00Z","author_association":"MEMBER","body":"Pretty sure that the label being wrong is a separate issue, caused by it just taking the first spell in the array of spells. This PR enables buffSpellId to take arrays, for spells like where you either have 1 spell with multiple buffs it can trigger, or have multiple spells combined as one, which have separate buffs (Hex, the combat potion class)."}}
{"actor":{"display_login":"niseko"}}