{"action":"created","issue":{"url":"https://api.github.com/repos/publiclab/plots2/issues/4133","repository_url":"https://api.github.com/repos/publiclab/plots2","labels_url":"https://api.github.com/repos/publiclab/plots2/issues/4133/labels{/name}","comments_url":"https://api.github.com/repos/publiclab/plots2/issues/4133/comments","events_url":"https://api.github.com/repos/publiclab/plots2/issues/4133/events","html_url":"https://github.com/publiclab/plots2/pull/4133","id":387993684,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM2MzYwNTUx","number":4133,"title":"Login modal","user":{"login":"JonathanXu1","id":22998430,"node_id":"MDQ6VXNlcjIyOTk4NDMw","avatar_url":"https://avatars3.githubusercontent.com/u/22998430?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanXu1","html_url":"https://github.com/JonathanXu1","followers_url":"https://api.github.com/users/JonathanXu1/followers","following_url":"https://api.github.com/users/JonathanXu1/following{/other_user}","gists_url":"https://api.github.com/users/JonathanXu1/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanXu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanXu1/subscriptions","organizations_url":"https://api.github.com/users/JonathanXu1/orgs","repos_url":"https://api.github.com/users/JonathanXu1/repos","events_url":"https://api.github.com/users/JonathanXu1/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanXu1/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/publiclab/plots2/milestones/18","html_url":"https://github.com/publiclab/plots2/milestone/18","labels_url":"https://api.github.com/repos/publiclab/plots2/milestones/18/labels","id":3438830,"node_id":"MDk6TWlsZXN0b25lMzQzODgzMA==","number":18,"title":"OAuth","description":"This milestone carries all the issues related to the OAuth Signup/login","creator":{"login":"SidharthBansal","id":20972099,"node_id":"MDQ6VXNlcjIwOTcyMDk5","avatar_url":"https://avatars0.githubusercontent.com/u/20972099?v=4","gravatar_id":"","url":"https://api.github.com/users/SidharthBansal","html_url":"https://github.com/SidharthBansal","followers_url":"https://api.github.com/users/SidharthBansal/followers","following_url":"https://api.github.com/users/SidharthBansal/following{/other_user}","gists_url":"https://api.github.com/users/SidharthBansal/gists{/gist_id}","starred_url":"https://api.github.com/users/SidharthBansal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SidharthBansal/subscriptions","organizations_url":"https://api.github.com/users/SidharthBansal/orgs","repos_url":"https://api.github.com/users/SidharthBansal/repos","events_url":"https://api.github.com/users/SidharthBansal/events{/privacy}","received_events_url":"https://api.github.com/users/SidharthBansal/received_events","type":"User","site_admin":false},"open_issues":23,"closed_issues":73,"state":"open","created_at":"2018-06-20T14:18:49Z","updated_at":"2018-12-07T16:12:37Z","due_on":null,"closed_at":null},"comments":15,"created_at":"2018-12-05T23:39:06Z","updated_at":"2018-12-07T17:29:49Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/publiclab/plots2/pulls/4133","html_url":"https://github.com/publiclab/plots2/pull/4133","diff_url":"https://github.com/publiclab/plots2/pull/4133.diff","patch_url":"https://github.com/publiclab/plots2/pull/4133.patch"},"body":"Fixes #2866\r\n\r\nMake sure these boxes are checked before your pull request (PR) is ready to be reviewed and merged. Thanks!\r\n\r\n* [ ] tests pass -- look for a green checkbox ✔️ a few minutes after opening your PR -- or run tests locally with `rake test`\r\n* [x] code is in uniquely-named feature branch and has no merge conflicts\r\n* [x] PR is descriptively titled\r\n* [x] ask `@publiclab/reviewers` for help, in a comment below\r\n\r\nThis creates a modal that toggles when the login button is created. Email login can be toggled by email icon.\r\n"},"comment":{"url":"https://api.github.com/repos/publiclab/plots2/issues/comments/445305694","html_url":"https://github.com/publiclab/plots2/pull/4133#issuecomment-445305694","issue_url":"https://api.github.com/repos/publiclab/plots2/issues/4133","id":445305694,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTMwNTY5NA==","user":{"login":"JonathanXu1","id":22998430,"node_id":"MDQ6VXNlcjIyOTk4NDMw","avatar_url":"https://avatars3.githubusercontent.com/u/22998430?v=4","gravatar_id":"","url":"https://api.github.com/users/JonathanXu1","html_url":"https://github.com/JonathanXu1","followers_url":"https://api.github.com/users/JonathanXu1/followers","following_url":"https://api.github.com/users/JonathanXu1/following{/other_user}","gists_url":"https://api.github.com/users/JonathanXu1/gists{/gist_id}","starred_url":"https://api.github.com/users/JonathanXu1/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/JonathanXu1/subscriptions","organizations_url":"https://api.github.com/users/JonathanXu1/orgs","repos_url":"https://api.github.com/users/JonathanXu1/repos","events_url":"https://api.github.com/users/JonathanXu1/events{/privacy}","received_events_url":"https://api.github.com/users/JonathanXu1/received_events","type":"User","site_admin":false},"created_at":"2018-12-07T17:29:49Z","updated_at":"2018-12-07T17:29:49Z","author_association":"CONTRIBUTOR","body":"@jywarren yeah I think just merging login is a much safer and user-friendly option. Signup is very iffy as it only works on the signup page and is very large as a modal. I'll submit my task once I apply the changes to the login modal."}}
{"actor":{"display_login":"JonathanXu1"}}