{"action":"created","issue":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6030","repository_url":"https://api.github.com/repos/devtools-html/debugger.html","labels_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6030/labels{/name}","comments_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6030/comments","events_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6030/events","html_url":"https://github.com/devtools-html/debugger.html/pull/6030","id":316052646,"number":6030,"title":"Revert \"Added VisibilityHandler to handle the mounting and unmounting…","user":{"login":"jasonLaster","id":254562,"avatar_url":"https://avatars1.githubusercontent.com/u/254562?v=4","gravatar_id":"","url":"https://api.github.com/users/jasonLaster","html_url":"https://github.com/jasonLaster","followers_url":"https://api.github.com/users/jasonLaster/followers","following_url":"https://api.github.com/users/jasonLaster/following{/other_user}","gists_url":"https://api.github.com/users/jasonLaster/gists{/gist_id}","starred_url":"https://api.github.com/users/jasonLaster/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jasonLaster/subscriptions","organizations_url":"https://api.github.com/users/jasonLaster/orgs","repos_url":"https://api.github.com/users/jasonLaster/repos","events_url":"https://api.github.com/users/jasonLaster/events{/privacy}","received_events_url":"https://api.github.com/users/jasonLaster/received_events","type":"User","site_admin":false},"labels":[{"id":731965385,"url":"https://api.github.com/repos/devtools-html/debugger.html/labels/pr-needs-review","name":"pr-needs-review","color":"bfd4f2","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-19T21:46:52Z","updated_at":"2018-04-20T16:09:59Z","closed_at":"2018-04-20T00:26:26Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/devtools-html/debugger.html/pulls/6030","html_url":"https://github.com/devtools-html/debugger.html/pull/6030","diff_url":"https://github.com/devtools-html/debugger.html/pull/6030.diff","patch_url":"https://github.com/devtools-html/debugger.html/pull/6030.patch"},"body":"Fixes Issue: #5748\r\n\r\n### Summary of Changes\r\n\r\n* We no longer unmount the app when we navigate to another tool\r\n* This means we will naturally preserve the scroll position\r\n\r\nTrade-offs\r\n- I do not believe we saw a significant performance win by unmounting the application.\r\n- Unmounting the app means removing codemirror's underlying dom\r\n- saving the scroll position on scroll is possible, but requires scrolling at the right time. There's also quite a bit of overhead in re-mounting..."},"comment":{"url":"https://api.github.com/repos/devtools-html/debugger.html/issues/comments/383145275","html_url":"https://github.com/devtools-html/debugger.html/pull/6030#issuecomment-383145275","issue_url":"https://api.github.com/repos/devtools-html/debugger.html/issues/6030","id":383145275,"user":{"login":"juliandescottes","id":1141550,"avatar_url":"https://avatars3.githubusercontent.com/u/1141550?v=4","gravatar_id":"","url":"https://api.github.com/users/juliandescottes","html_url":"https://github.com/juliandescottes","followers_url":"https://api.github.com/users/juliandescottes/followers","following_url":"https://api.github.com/users/juliandescottes/following{/other_user}","gists_url":"https://api.github.com/users/juliandescottes/gists{/gist_id}","starred_url":"https://api.github.com/users/juliandescottes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/juliandescottes/subscriptions","organizations_url":"https://api.github.com/users/juliandescottes/orgs","repos_url":"https://api.github.com/users/juliandescottes/repos","events_url":"https://api.github.com/users/juliandescottes/events{/privacy}","received_events_url":"https://api.github.com/users/juliandescottes/received_events","type":"User","site_admin":false},"created_at":"2018-04-20T16:09:59Z","updated_at":"2018-04-20T16:09:59Z","author_association":"MEMBER","body":"Great that this managed to be fixed before the end of 61 Nightly!"}}
{"actor":{"display_login":"juliandescottes"}}