{"action":"created","issue":{"url":"https://api.github.com/repos/jdbi/jdbi/issues/1081","repository_url":"https://api.github.com/repos/jdbi/jdbi","labels_url":"https://api.github.com/repos/jdbi/jdbi/issues/1081/labels{/name}","comments_url":"https://api.github.com/repos/jdbi/jdbi/issues/1081/comments","events_url":"https://api.github.com/repos/jdbi/jdbi/issues/1081/events","html_url":"https://github.com/jdbi/jdbi/pull/1081","id":314329478,"number":1081,"title":"fix #981 logging interface","user":{"login":"TheRealMarnes","id":3950300,"avatar_url":"https://avatars2.githubusercontent.com/u/3950300?v=4","gravatar_id":"","url":"https://api.github.com/users/TheRealMarnes","html_url":"https://github.com/TheRealMarnes","followers_url":"https://api.github.com/users/TheRealMarnes/followers","following_url":"https://api.github.com/users/TheRealMarnes/following{/other_user}","gists_url":"https://api.github.com/users/TheRealMarnes/gists{/gist_id}","starred_url":"https://api.github.com/users/TheRealMarnes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TheRealMarnes/subscriptions","organizations_url":"https://api.github.com/users/TheRealMarnes/orgs","repos_url":"https://api.github.com/users/TheRealMarnes/repos","events_url":"https://api.github.com/users/TheRealMarnes/events{/privacy}","received_events_url":"https://api.github.com/users/TheRealMarnes/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":8,"created_at":"2018-04-14T13:34:18Z","updated_at":"2018-04-27T01:05:28Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/jdbi/jdbi/pulls/1081","html_url":"https://github.com/jdbi/jdbi/pull/1081","diff_url":"https://github.com/jdbi/jdbi/pull/1081.diff","patch_url":"https://github.com/jdbi/jdbi/pull/1081.patch"},"body":"#981 \r\n\r\nI'd like some input from the team about the overall design and whether I should take testing any further.\r\n\r\nI personally think the design is ok as this is basically exactly what I do in my personal project for which I opened the issue.\r\n\r\nLoggableArgument is a copy-paste from my project, where I use it in all of my custom ArgumentFactories. IIRC the BuiltInArgumentFactory already provides a usable `toString()`, so if users make sure to use LoggableArgument in their custom ArgumentFactories, every Argument should be loggable. Works fine in my project.\r\n\r\nAs for testing, I think the current tests cover everything and are sufficient even if some more combinations could be made. Writing more tests feels a bit redundant to me since most of the tested code will just be the same.\r\n\r\nI felt like deprecating TimingCollector maybe?"},"comment":{"url":"https://api.github.com/repos/jdbi/jdbi/issues/comments/384833051","html_url":"https://github.com/jdbi/jdbi/pull/1081#issuecomment-384833051","issue_url":"https://api.github.com/repos/jdbi/jdbi/issues/1081","id":384833051,"user":{"login":"qualidafial","id":38629,"avatar_url":"https://avatars2.githubusercontent.com/u/38629?v=4","gravatar_id":"","url":"https://api.github.com/users/qualidafial","html_url":"https://github.com/qualidafial","followers_url":"https://api.github.com/users/qualidafial/followers","following_url":"https://api.github.com/users/qualidafial/following{/other_user}","gists_url":"https://api.github.com/users/qualidafial/gists{/gist_id}","starred_url":"https://api.github.com/users/qualidafial/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/qualidafial/subscriptions","organizations_url":"https://api.github.com/users/qualidafial/orgs","repos_url":"https://api.github.com/users/qualidafial/repos","events_url":"https://api.github.com/users/qualidafial/events{/privacy}","received_events_url":"https://api.github.com/users/qualidafial/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T01:05:28Z","updated_at":"2018-04-27T01:05:28Z","author_association":"MEMBER","body":"@TheRealMarnes I think we're pretty close. Thanks for being patient and putting in the time to make all these changes we've been asking for.\r\n\r\nI'm +1 to merge this once we get the timer boilerplate method Steven asked for, and remove the redundant `LOG.trace()` statements."}}
{"actor":{"display_login":"qualidafial"}}