{"action":"created","comment":{"url":"https://api.github.com/repos/dlang/dmd/pulls/comments/170163393","pull_request_review_id":98806572,"id":170163393,"diff_hunk":"@@ -132,10 +133,75 @@ void test4()\n     bar!((a, b) => a < b + 7);\n }\n \n+int bar()\n+{\n+    return 2;\n+}\n+\n+void foobar2(alias pred)()\n+{\n+    // imports.testalambda1.bar != imports.testlambda2.bar\n+    import imports.testlambda2 : bar;\n+    static assert(!__traits(isSame, pred, (int a) => a + bar()));\n+}\n+\n+void foobar(alias pred)()\n+{\n+    // testlambdacomp.bar != testlambdacomp.test5.bar\n+    static assert(!__traits(isSame, pred, (int a) => a + bar()));\n+\n+    // imports.testlambda1.bar != testlambdacomp.test5.bar\n+    import imports.testlambda1 : bar;\n+    static assert(!__traits(isSame, pred, (int a) => a + bar()));\n+\n+    // functions imported from different modules are not equal\n+    foobar2!((int a) => a + bar())();\n+}","path":"test/compilable/testlambdacomp.d","position":41,"original_position":41,"commit_id":"f79db1f659c22816a57844e4db0fabb44ee84040","original_commit_id":"f79db1f659c22816a57844e4db0fabb44ee84040","user":{"login":"wilzbach","id":4370550,"avatar_url":"https://avatars3.githubusercontent.com/u/4370550?v=4","gravatar_id":"","url":"https://api.github.com/users/wilzbach","html_url":"https://github.com/wilzbach","followers_url":"https://api.github.com/users/wilzbach/followers","following_url":"https://api.github.com/users/wilzbach/following{/other_user}","gists_url":"https://api.github.com/users/wilzbach/gists{/gist_id}","starred_url":"https://api.github.com/users/wilzbach/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wilzbach/subscriptions","organizations_url":"https://api.github.com/users/wilzbach/orgs","repos_url":"https://api.github.com/users/wilzbach/repos","events_url":"https://api.github.com/users/wilzbach/events{/privacy}","received_events_url":"https://api.github.com/users/wilzbach/received_events","type":"User","site_admin":false},"body":"Alternatively, simply don't declare a function which you just call once, but call it e.g. `test6` and do `alias pred = (int a) => a + bar()` in the beginning.","created_at":"2018-02-23T04:16:49Z","updated_at":"2018-02-23T04:18:11Z","html_url":"https://github.com/dlang/dmd/pull/7935#discussion_r170163393","pull_request_url":"https://api.github.com/repos/dlang/dmd/pulls/7935","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments/170163393"},"html":{"href":"https://github.com/dlang/dmd/pull/7935#discussion_r170163393"},"pull_request":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7935"}},"in_reply_to_id":170163259},"pull_request":{"url":"https://api.github.com/repos/dlang/dmd/pulls/7935","id":170412803,"html_url":"https://github.com/dlang/dmd/pull/7935","diff_url":"https://github.com/dlang/dmd/pull/7935.diff","patch_url":"https://github.com/dlang/dmd/pull/7935.patch","issue_url":"https://api.github.com/repos/dlang/dmd/issues/7935","number":7935,"state":"open","locked":false,"title":"__traits(isSame) for lambda functions which contain function calls","user":{"login":"RazvanN7","id":22907766,"avatar_url":"https://avatars2.githubusercontent.com/u/22907766?v=4","gravatar_id":"","url":"https://api.github.com/users/RazvanN7","html_url":"https://github.com/RazvanN7","followers_url":"https://api.github.com/users/RazvanN7/followers","following_url":"https://api.github.com/users/RazvanN7/following{/other_user}","gists_url":"https://api.github.com/users/RazvanN7/gists{/gist_id}","starred_url":"https://api.github.com/users/RazvanN7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RazvanN7/subscriptions","organizations_url":"https://api.github.com/users/RazvanN7/orgs","repos_url":"https://api.github.com/users/RazvanN7/repos","events_url":"https://api.github.com/users/RazvanN7/events{/privacy}","received_events_url":"https://api.github.com/users/RazvanN7/received_events","type":"User","site_admin":false},"body":"This PR adds the capability of comparing lambda functions which contain calls to other functions.\r\n\r\nTwo functions are considered equal if their serializations is equal. 2 function serializations are equal if : \r\n\r\n-> the mangled names of the functions are equal\r\n-> the serializations of the parameters with which the function is called are equal","created_at":"2018-02-21T09:18:13Z","updated_at":"2018-02-23T04:18:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"35ed7dc98c44f200dc632fce9451eabae82e2cd4","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/dlang/dmd/pulls/7935/commits","review_comments_url":"https://api.github.com/repos/dlang/dmd/pulls/7935/comments","review_comment_url":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/dlang/dmd/issues/7935/comments","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/f79db1f659c22816a57844e4db0fabb44ee84040","head":{"label":"RazvanN7:Lambda_v3","ref":"Lambda_v3","sha":"f79db1f659c22816a57844e4db0fabb44ee84040","user":{"login":"RazvanN7","id":22907766,"avatar_url":"https://avatars2.githubusercontent.com/u/22907766?v=4","gravatar_id":"","url":"https://api.github.com/users/RazvanN7","html_url":"https://github.com/RazvanN7","followers_url":"https://api.github.com/users/RazvanN7/followers","following_url":"https://api.github.com/users/RazvanN7/following{/other_user}","gists_url":"https://api.github.com/users/RazvanN7/gists{/gist_id}","starred_url":"https://api.github.com/users/RazvanN7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RazvanN7/subscriptions","organizations_url":"https://api.github.com/users/RazvanN7/orgs","repos_url":"https://api.github.com/users/RazvanN7/repos","events_url":"https://api.github.com/users/RazvanN7/events{/privacy}","received_events_url":"https://api.github.com/users/RazvanN7/received_events","type":"User","site_admin":false},"repo":{"id":78457954,"name":"dmd","full_name":"RazvanN7/dmd","owner":{"login":"RazvanN7","id":22907766,"avatar_url":"https://avatars2.githubusercontent.com/u/22907766?v=4","gravatar_id":"","url":"https://api.github.com/users/RazvanN7","html_url":"https://github.com/RazvanN7","followers_url":"https://api.github.com/users/RazvanN7/followers","following_url":"https://api.github.com/users/RazvanN7/following{/other_user}","gists_url":"https://api.github.com/users/RazvanN7/gists{/gist_id}","starred_url":"https://api.github.com/users/RazvanN7/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/RazvanN7/subscriptions","organizations_url":"https://api.github.com/users/RazvanN7/orgs","repos_url":"https://api.github.com/users/RazvanN7/repos","events_url":"https://api.github.com/users/RazvanN7/events{/privacy}","received_events_url":"https://api.github.com/users/RazvanN7/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/RazvanN7/dmd","description":"dmd D Programming Language compiler","fork":true,"url":"https://api.github.com/repos/RazvanN7/dmd","forks_url":"https://api.github.com/repos/RazvanN7/dmd/forks","keys_url":"https://api.github.com/repos/RazvanN7/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/RazvanN7/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/RazvanN7/dmd/teams","hooks_url":"https://api.github.com/repos/RazvanN7/dmd/hooks","issue_events_url":"https://api.github.com/repos/RazvanN7/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/RazvanN7/dmd/events","assignees_url":"https://api.github.com/repos/RazvanN7/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/RazvanN7/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/RazvanN7/dmd/tags","blobs_url":"https://api.github.com/repos/RazvanN7/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/RazvanN7/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/RazvanN7/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/RazvanN7/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/RazvanN7/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/RazvanN7/dmd/languages","stargazers_url":"https://api.github.com/repos/RazvanN7/dmd/stargazers","contributors_url":"https://api.github.com/repos/RazvanN7/dmd/contributors","subscribers_url":"https://api.github.com/repos/RazvanN7/dmd/subscribers","subscription_url":"https://api.github.com/repos/RazvanN7/dmd/subscription","commits_url":"https://api.github.com/repos/RazvanN7/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/RazvanN7/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/RazvanN7/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/RazvanN7/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/RazvanN7/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/RazvanN7/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/RazvanN7/dmd/merges","archive_url":"https://api.github.com/repos/RazvanN7/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/RazvanN7/dmd/downloads","issues_url":"https://api.github.com/repos/RazvanN7/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/RazvanN7/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/RazvanN7/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/RazvanN7/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/RazvanN7/dmd/labels{/name}","releases_url":"https://api.github.com/repos/RazvanN7/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/RazvanN7/dmd/deployments","created_at":"2017-01-09T18:46:42Z","updated_at":"2017-01-09T18:46:52Z","pushed_at":"2018-02-22T11:04:28Z","git_url":"git://github.com/RazvanN7/dmd.git","ssh_url":"git@github.com:RazvanN7/dmd.git","clone_url":"https://github.com/RazvanN7/dmd.git","svn_url":"https://github.com/RazvanN7/dmd","homepage":"dlang.org","size":83445,"stargazers_count":0,"watchers_count":0,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"dlang:master","ref":"master","sha":"e82e0710924d25f438c4ced4a8fd7c56edb6232a","user":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"repo":{"id":1257070,"name":"dmd","full_name":"dlang/dmd","owner":{"login":"dlang","id":565913,"avatar_url":"https://avatars3.githubusercontent.com/u/565913?v=4","gravatar_id":"","url":"https://api.github.com/users/dlang","html_url":"https://github.com/dlang","followers_url":"https://api.github.com/users/dlang/followers","following_url":"https://api.github.com/users/dlang/following{/other_user}","gists_url":"https://api.github.com/users/dlang/gists{/gist_id}","starred_url":"https://api.github.com/users/dlang/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dlang/subscriptions","organizations_url":"https://api.github.com/users/dlang/orgs","repos_url":"https://api.github.com/users/dlang/repos","events_url":"https://api.github.com/users/dlang/events{/privacy}","received_events_url":"https://api.github.com/users/dlang/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/dlang/dmd","description":"dmd D Programming Language compiler","fork":false,"url":"https://api.github.com/repos/dlang/dmd","forks_url":"https://api.github.com/repos/dlang/dmd/forks","keys_url":"https://api.github.com/repos/dlang/dmd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dlang/dmd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dlang/dmd/teams","hooks_url":"https://api.github.com/repos/dlang/dmd/hooks","issue_events_url":"https://api.github.com/repos/dlang/dmd/issues/events{/number}","events_url":"https://api.github.com/repos/dlang/dmd/events","assignees_url":"https://api.github.com/repos/dlang/dmd/assignees{/user}","branches_url":"https://api.github.com/repos/dlang/dmd/branches{/branch}","tags_url":"https://api.github.com/repos/dlang/dmd/tags","blobs_url":"https://api.github.com/repos/dlang/dmd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dlang/dmd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dlang/dmd/git/refs{/sha}","trees_url":"https://api.github.com/repos/dlang/dmd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dlang/dmd/statuses/{sha}","languages_url":"https://api.github.com/repos/dlang/dmd/languages","stargazers_url":"https://api.github.com/repos/dlang/dmd/stargazers","contributors_url":"https://api.github.com/repos/dlang/dmd/contributors","subscribers_url":"https://api.github.com/repos/dlang/dmd/subscribers","subscription_url":"https://api.github.com/repos/dlang/dmd/subscription","commits_url":"https://api.github.com/repos/dlang/dmd/commits{/sha}","git_commits_url":"https://api.github.com/repos/dlang/dmd/git/commits{/sha}","comments_url":"https://api.github.com/repos/dlang/dmd/comments{/number}","issue_comment_url":"https://api.github.com/repos/dlang/dmd/issues/comments{/number}","contents_url":"https://api.github.com/repos/dlang/dmd/contents/{+path}","compare_url":"https://api.github.com/repos/dlang/dmd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dlang/dmd/merges","archive_url":"https://api.github.com/repos/dlang/dmd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dlang/dmd/downloads","issues_url":"https://api.github.com/repos/dlang/dmd/issues{/number}","pulls_url":"https://api.github.com/repos/dlang/dmd/pulls{/number}","milestones_url":"https://api.github.com/repos/dlang/dmd/milestones{/number}","notifications_url":"https://api.github.com/repos/dlang/dmd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dlang/dmd/labels{/name}","releases_url":"https://api.github.com/repos/dlang/dmd/releases{/id}","deployments_url":"https://api.github.com/repos/dlang/dmd/deployments","created_at":"2011-01-15T06:53:53Z","updated_at":"2018-02-22T01:17:54Z","pushed_at":"2018-02-23T04:02:33Z","git_url":"git://github.com/dlang/dmd.git","ssh_url":"git@github.com:dlang/dmd.git","clone_url":"https://github.com/dlang/dmd.git","svn_url":"https://github.com/dlang/dmd","homepage":"dlang.org","size":85910,"stargazers_count":1749,"watchers_count":1749,"language":"D","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":439,"mirror_url":null,"archived":false,"open_issues_count":137,"license":{"key":"bsl-1.0","name":"Boost Software License 1.0","spdx_id":"BSL-1.0","url":"https://api.github.com/licenses/bsl-1.0"},"forks":439,"open_issues":137,"watchers":1749,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7935"},"html":{"href":"https://github.com/dlang/dmd/pull/7935"},"issue":{"href":"https://api.github.com/repos/dlang/dmd/issues/7935"},"comments":{"href":"https://api.github.com/repos/dlang/dmd/issues/7935/comments"},"review_comments":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7935/comments"},"review_comment":{"href":"https://api.github.com/repos/dlang/dmd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/dlang/dmd/pulls/7935/commits"},"statuses":{"href":"https://api.github.com/repos/dlang/dmd/statuses/f79db1f659c22816a57844e4db0fabb44ee84040"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"wilzbach"}}