{"push_id":3025705313,"size":20,"distinct_size":20,"ref":"refs/heads/master","head":"60046c0bea52f261ca21f6097208b3607671d18b","before":"c8ebf4d054dced3fc5033d80e04052b5816a250e","commits":[{"sha":"c0756bc41cccc2826dc699b6fff8b8913b849aac","author":{"name":"David Lantos","email":"dfcf65ad46dfdcc7b3dc7e68a3dbfc3f9010cc62@gmail.com"},"message":"Add link to the \"fc4-tool\"\n\nWe have a link to the\nhttps://fundingcircle.github.io/fc4-framework/methodology/toolset.html\npage directly.\n\nNew users learn about the \"fc4-tool\" but cannot see what it is unless\nthey navigate away from the page.\n\nThis change adds a link to the directory containing the tool in GitHub\nto make resolving \"fc4-tool\" less of a quest.","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/c0756bc41cccc2826dc699b6fff8b8913b849aac"},{"sha":"d5e727fa7ed9ae91113ab132402ab5c311cb7a84","author":{"name":"Sasha Gerrand","email":"e4218b61aab21c01dbe21cb957d04c82be33c969@users.noreply.github.com"},"message":"Merge pull request #77 from sldblog/link-to-tool\n\nAdd link to the \"fc4-tool\" on the \"Toolset\" page","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/d5e727fa7ed9ae91113ab132402ab5c311cb7a84"},{"sha":"f800b5921c6a6840791128b647ddfaa042619959","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Start PoC of rendering Structurizr Express diagrams in Node using Puppeteer and headless Chrome","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/f800b5921c6a6840791128b647ddfaa042619959"},{"sha":"519ccc9ec409a80a34b4cbc9b3e4a12da4d0c7ab","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] WIP++ PoC with Structurizr Express, Node, Puppeteer, headless Chrome","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/519ccc9ec409a80a34b4cbc9b3e4a12da4d0c7ab"},{"sha":"fdac587e65808ecf45b698f14a1513208cc8433b","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Read/write to/from stdin/stdout","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/fdac587e65808ecf45b698f14a1513208cc8433b"},{"sha":"52df969394d34d22ddd0e47629348cc6969f6f82","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] It works!","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/52df969394d34d22ddd0e47629348cc6969f6f82"},{"sha":"7550160b36ef04f44a44a5550acc541d65ab53e4","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Still trying to fix CI\n\nI’ve been having a lot of trouble getting Puppeteer and Chromium to work\nin the Alpine CI image… finally I found this:\n\nhttps://github.com/GoogleChrome/puppeteer/blob/master/docs/troubleshooting.md#running-on-alpine\n\nwhich informed me that right now we have to use Puppeteer 1.4.0 (as\nopposed to the current version, 1.9.0). And it also recommended using\nthe apk-installed Chromium rather than having Puppeteer download its own\nversion, which makes sense to me since we need to have apk install\nchromium either way, so as to get all the dependencies installed that we\nneed to run any chromium.","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/7550160b36ef04f44a44a5550acc541d65ab53e4"},{"sha":"19c77418d8dc80a384854226b871f5ab458b5735","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Speed up rendering","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/19c77418d8dc80a384854226b871f5ab458b5735"},{"sha":"d4ab06509847246d415fb22b1bb22296da4cfb2b","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Minor code maintainability improvements","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/d4ab06509847246d415fb22b1bb22296da4cfb2b"},{"sha":"3680a6f950d5cb0893e0f5b4949606c47e310b9d","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Minor logging code maintainability improvements","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/3680a6f950d5cb0893e0f5b4949606c47e310b9d"},{"sha":"dcb94dca4922ac6baf4f2bad52bf74eecd6385a6","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Restore Structurizr logo to rendered images\n\nBy adjusting the duration of a pause in rendering process.\n\nThe first change, the increase, is the one that restored the logo; I\nrealized that a prior change that shortened this pause had caused the\nlogo to be missing.\n\nThe second change, the decrease, I tried in the hopes of offsetting the\nfirst. It seems to work on my system, but might need to be bumped back\nup. We’ll see.","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/dcb94dca4922ac6baf4f2bad52bf74eecd6385a6"},{"sha":"a445662333f2922e017a0481d89bbfbb76b3f7d4","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Fix intermittent issue with missing logo\n\nI recently observed that the Structurizr Express logo was always missing\nfrom the rendered images, and that lengthening the duration of a certain\npause in the rendering process fixed this. It turns out I didn’t\nlengthen it quite enough, because I’m now seeing the logo be\noccasionally, intermittently, missing.\n\nSo hopefully bumping this from 300ms to 350ms will make this issue less\nlikely to occur.\n\nThere may be smarter ways to ensure the image is on the\ndiagram, though; I think maybe listening for the `load` event on the\nimage object in the DOM might be faster _and_ more accurate a way to\nboth ensure that the logo appears _and_ that we’re pausing only for the\nabsolute minimum necessary duration.","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/a445662333f2922e017a0481d89bbfbb76b3f7d4"},{"sha":"113f4a71944c7b7b9c397f0dc7b2bbcb6ff8f357","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Make renderer work with remote Structurizr Express\n\nI realized that we can’t embed Structurizr Express (SE) into this\nproject unless and until we get permission from Simon Brown and work out\nlicensing issues. So I’ve broken that work (embedding SE) out into a\nseparate branch, so this renderer for now at least needs to work with\nthe canonical instance of Structurizr Express.\n\nWhile working on this, I found I needed some debugging help, so I added\na debugMode to help out with that. And while trying to get the timing of\nthe pauses right, I discovered that Puppeteer has a page.waitForSelector\nfunction, which was perfect for replacing one of the sleeps with\nsomething more precise and probably more reliable.","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/113f4a71944c7b7b9c397f0dc7b2bbcb6ff8f357"},{"sha":"4b42bdac7f9d33f5ea28606e91302b4c22df5ddb","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Refactor massive render fn\n\nIt was just way too huge and needed to be broken up.","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/4b42bdac7f9d33f5ea28606e91302b4c22df5ddb"},{"sha":"bfc6066f3b10b1996bbf1f40f4578951b1ba3821","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] More minor logging code maintainability improvements","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/bfc6066f3b10b1996bbf1f40f4578951b1ba3821"},{"sha":"e88347a5f4205236f45f92cf7a2fc8fe32dec9f7","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: automated rendering] Add a comment","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/e88347a5f4205236f45f92cf7a2fc8fe32dec9f7"},{"sha":"2efddf36bf72de330f30d41762e72dbfb00b816e","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"[tool: renderer] Make JavaScript more standards-compliant\n\nAs per feedback from @fussybeaver in #80 — thanks Niel!","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/2efddf36bf72de330f30d41762e72dbfb00b816e"},{"sha":"19b844d693d6b9b6c406755f42649915d890de56","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"Merge pull request #80 from FundingCircle/node-renderer\n\nNode Renderer","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/19b844d693d6b9b6c406755f42649915d890de56"},{"sha":"1c015936a3bbf40a1be387972979e6e70e85c807","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"Fix an intermittently failing test\n\nI don’t know why this test failed intermittently, but in looking the\ntest and its subject over to try to figure it out, I noticed that the\nfunction both returned a value *and* wrote it to stdout as a side effect\nwhich seemed very fuzzy to me, and it looked like this had led to the\ntest being muddled over what it should be testing — the return value or\nthe side effect. So I fixed the function by removing the main side\neffect and moving it to the function that _calls_ this function.","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/1c015936a3bbf40a1be387972979e6e70e85c807"},{"sha":"60046c0bea52f261ca21f6097208b3607671d18b","author":{"name":"Avi Flax","email":"d19f9ffa11d37316baeee1afc92260319dbf2019@fundingcircle.com"},"message":"Merge pull request #79 from FundingCircle/fix-test\n\nFix an intermittently failing test","distinct":true,"url":"https://api.github.com/repos/aviflax/fc4-framework/commits/60046c0bea52f261ca21f6097208b3607671d18b"}]}
{"actor":{"display_login":"aviflax"}}