{"action":"created","issue":{"url":"https://api.github.com/repos/artsy/exchange/issues/361","repository_url":"https://api.github.com/repos/artsy/exchange","labels_url":"https://api.github.com/repos/artsy/exchange/issues/361/labels{/name}","comments_url":"https://api.github.com/repos/artsy/exchange/issues/361/comments","events_url":"https://api.github.com/repos/artsy/exchange/issues/361/events","html_url":"https://github.com/artsy/exchange/pull/361","id":395690327,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQyMDgzOTE5","number":361,"title":"Update reminder emails to 5hrs before expiration","user":{"login":"ashkan18","id":1230819,"node_id":"MDQ6VXNlcjEyMzA4MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1230819?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkan18","html_url":"https://github.com/ashkan18","followers_url":"https://api.github.com/users/ashkan18/followers","following_url":"https://api.github.com/users/ashkan18/following{/other_user}","gists_url":"https://api.github.com/users/ashkan18/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkan18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkan18/subscriptions","organizations_url":"https://api.github.com/users/ashkan18/orgs","repos_url":"https://api.github.com/users/ashkan18/repos","events_url":"https://api.github.com/users/ashkan18/events{/privacy}","received_events_url":"https://api.github.com/users/ashkan18/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"starsirius","id":796573,"node_id":"MDQ6VXNlcjc5NjU3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/796573?v=4","gravatar_id":"","url":"https://api.github.com/users/starsirius","html_url":"https://github.com/starsirius","followers_url":"https://api.github.com/users/starsirius/followers","following_url":"https://api.github.com/users/starsirius/following{/other_user}","gists_url":"https://api.github.com/users/starsirius/gists{/gist_id}","starred_url":"https://api.github.com/users/starsirius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starsirius/subscriptions","organizations_url":"https://api.github.com/users/starsirius/orgs","repos_url":"https://api.github.com/users/starsirius/repos","events_url":"https://api.github.com/users/starsirius/events{/privacy}","received_events_url":"https://api.github.com/users/starsirius/received_events","type":"User","site_admin":false},"assignees":[{"login":"starsirius","id":796573,"node_id":"MDQ6VXNlcjc5NjU3Mw==","avatar_url":"https://avatars1.githubusercontent.com/u/796573?v=4","gravatar_id":"","url":"https://api.github.com/users/starsirius","html_url":"https://github.com/starsirius","followers_url":"https://api.github.com/users/starsirius/followers","following_url":"https://api.github.com/users/starsirius/following{/other_user}","gists_url":"https://api.github.com/users/starsirius/gists{/gist_id}","starred_url":"https://api.github.com/users/starsirius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/starsirius/subscriptions","organizations_url":"https://api.github.com/users/starsirius/orgs","repos_url":"https://api.github.com/users/starsirius/repos","events_url":"https://api.github.com/users/starsirius/events{/privacy}","received_events_url":"https://api.github.com/users/starsirius/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2019-01-03T19:09:18Z","updated_at":"2019-01-04T15:20:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/artsy/exchange/pulls/361","html_url":"https://github.com/artsy/exchange/pull/361","diff_url":"https://github.com/artsy/exchange/pull/361.diff","patch_url":"https://github.com/artsy/exchange/pull/361.patch"},"body":"# Problem\r\nWe want to switch Pulse emails to use Exchange notification instead of queuing their own job in the future for reminder emails. https://github.com/artsy/pulse/pull/325\r\n\r\n# Solution\r\nCurrently reminder notifications are posted only 2hrs before expiration and only consumer is APRb for these for slack notification. Emails need to be sent 5hrs before expiration. After talking to CRT we are good with getting internal notifications at 5hr too.\r\nWe updated reminder notification to 5hrs and this way pulse could switch to these events.\r\n\r\n# What happens to existing queued jobs?\r\nFor existing ones we still use 2hrs since they were already queued, if we want to not send emails 2hrs before for existing jobs we can follow this:\r\n- Deploy Exchange with this change\r\n- Wait 2 days (so all jobs queued in 2 days from the deploy time are finished)\r\n- Merge https://github.com/artsy/pulse/pull/325 \r\n- Delete current jobs queued in Pulse for reminder emails\r\n- Deploy Pulse"},"comment":{"url":"https://api.github.com/repos/artsy/exchange/issues/comments/451473155","html_url":"https://github.com/artsy/exchange/pull/361#issuecomment-451473155","issue_url":"https://api.github.com/repos/artsy/exchange/issues/361","id":451473155,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTQ3MzE1NQ==","user":{"login":"ashkan18","id":1230819,"node_id":"MDQ6VXNlcjEyMzA4MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/1230819?v=4","gravatar_id":"","url":"https://api.github.com/users/ashkan18","html_url":"https://github.com/ashkan18","followers_url":"https://api.github.com/users/ashkan18/followers","following_url":"https://api.github.com/users/ashkan18/following{/other_user}","gists_url":"https://api.github.com/users/ashkan18/gists{/gist_id}","starred_url":"https://api.github.com/users/ashkan18/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ashkan18/subscriptions","organizations_url":"https://api.github.com/users/ashkan18/orgs","repos_url":"https://api.github.com/users/ashkan18/repos","events_url":"https://api.github.com/users/ashkan18/events{/privacy}","received_events_url":"https://api.github.com/users/ashkan18/received_events","type":"User","site_admin":false},"created_at":"2019-01-04T15:20:32Z","updated_at":"2019-01-04T15:20:32Z","author_association":"COLLABORATOR","body":"@starsirius this should be ready "}}
{"actor":{"display_login":"ashkan18"}}