{"action":"created","comment":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/184887510","pull_request_review_id":116170934,"id":184887510,"diff_hunk":"@@ -33,7 +33,7 @@\n #                                                                    #\n # Note: DO NOT include the .c extension!!!                           #\n \n-MYPLUGINS = \n+#MYPLUGINS = ","path":"src/plugins/Makefile.in","position":5,"original_position":5,"commit_id":"3495aa003b62315717e62f6de8830c2bd69d5cb3","original_commit_id":"3495aa003b62315717e62f6de8830c2bd69d5cb3","user":{"login":"4144","id":959758,"avatar_url":"https://avatars1.githubusercontent.com/u/959758?v=4","gravatar_id":"","url":"https://api.github.com/users/4144","html_url":"https://github.com/4144","followers_url":"https://api.github.com/users/4144/followers","following_url":"https://api.github.com/users/4144/following{/other_user}","gists_url":"https://api.github.com/users/4144/gists{/gist_id}","starred_url":"https://api.github.com/users/4144/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/4144/subscriptions","organizations_url":"https://api.github.com/users/4144/orgs","repos_url":"https://api.github.com/users/4144/repos","events_url":"https://api.github.com/users/4144/events{/privacy}","received_events_url":"https://api.github.com/users/4144/received_events","type":"User","site_admin":false},"body":"better replace to ``MYPLUGINS := $(MYPLUGINS)``\r\nin this way will works old way and you can set env var too","created_at":"2018-04-29T15:57:29Z","updated_at":"2018-04-29T15:57:38Z","html_url":"https://github.com/HerculesWS/Hercules/pull/2025#discussion_r184887510","pull_request_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2025","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments/184887510"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2025#discussion_r184887510"},"pull_request":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2025"}}},"pull_request":{"url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2025","id":184832796,"html_url":"https://github.com/HerculesWS/Hercules/pull/2025","diff_url":"https://github.com/HerculesWS/Hercules/pull/2025.diff","patch_url":"https://github.com/HerculesWS/Hercules/pull/2025.patch","issue_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2025","number":2025,"state":"open","locked":false,"title":"Comment out \"MYPLUGINS =\"","user":{"login":"Noooil","id":20649209,"avatar_url":"https://avatars3.githubusercontent.com/u/20649209?v=4","gravatar_id":"","url":"https://api.github.com/users/Noooil","html_url":"https://github.com/Noooil","followers_url":"https://api.github.com/users/Noooil/followers","following_url":"https://api.github.com/users/Noooil/following{/other_user}","gists_url":"https://api.github.com/users/Noooil/gists{/gist_id}","starred_url":"https://api.github.com/users/Noooil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noooil/subscriptions","organizations_url":"https://api.github.com/users/Noooil/orgs","repos_url":"https://api.github.com/users/Noooil/repos","events_url":"https://api.github.com/users/Noooil/events{/privacy}","received_events_url":"https://api.github.com/users/Noooil/received_events","type":"User","site_admin":false},"body":"[//]: # (**********************************)\r\n[//]: # (** Fill in the following fields **)\r\n[//]: # (**********************************)\r\n\r\n[//]: # (Note: Lines beginning with syntax such as this one, are comments and will not be visible in your report!)\r\n\r\n### Pull Request Prelude\r\n\r\n[//]: # (Thank you for working on improving Hercules!)\r\n\r\n[//]: # (Please complete these steps and check the following boxes by putting an `x` inside the brackets _before_ filing your Pull Request.)\r\n\r\n- [X] I have followed [proper Hercules code styling][code].\r\n- [X] I have read and understood the [contribution guidelines][cont] before making this PR.\r\n- [X] I am aware that this PR will be closed if the above-mentioned criteria are not fulfilled.\r\n\r\n### Changes Proposed\r\nThere are 3 different ways to populate a variable in a Makefile (https://stackoverflow.com/a/28891382)\r\n\r\n1.  You manipulate the file directly and set the variable before it gets used\r\n2.  You pass it to make like so: make MYPLUGINS=\"test\" all\r\n3.  You set an env variable via export like so: export MYPLUGINS=\"test\"\r\n\r\nThe problem is precedence. If you just set the MYPLUGINS in your environment via export it won't get used because the empty string declaration in the Makefile.in gets prefered.\r\n\r\nThis change will add upon the configurability of hercules.\r\n\r\n**Affected Branches:**\r\nstable\r\n\r\n[master]: # (Master? Slave?)\r\nmaster\r\n\r\n**Issues addressed:**\r\nlack of configurability options for used plugins\r\n\r\n[cont]: https://github.com/HerculesWS/Hercules/blob/master/CONTRIBUTING.md\r\n[code]: https://github.com/HerculesWS/Hercules/wiki/Coding-Style\r\n","created_at":"2018-04-29T12:41:51Z","updated_at":"2018-04-29T15:57:38Z","closed_at":null,"merged_at":null,"merge_commit_sha":"558c3d0f3089427df4af8f058b60fd7a4d344767","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2025/commits","review_comments_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2025/comments","review_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/2025/comments","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/3495aa003b62315717e62f6de8830c2bd69d5cb3","head":{"label":"Noooil:stable","ref":"stable","sha":"3495aa003b62315717e62f6de8830c2bd69d5cb3","user":{"login":"Noooil","id":20649209,"avatar_url":"https://avatars3.githubusercontent.com/u/20649209?v=4","gravatar_id":"","url":"https://api.github.com/users/Noooil","html_url":"https://github.com/Noooil","followers_url":"https://api.github.com/users/Noooil/followers","following_url":"https://api.github.com/users/Noooil/following{/other_user}","gists_url":"https://api.github.com/users/Noooil/gists{/gist_id}","starred_url":"https://api.github.com/users/Noooil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noooil/subscriptions","organizations_url":"https://api.github.com/users/Noooil/orgs","repos_url":"https://api.github.com/users/Noooil/repos","events_url":"https://api.github.com/users/Noooil/events{/privacy}","received_events_url":"https://api.github.com/users/Noooil/received_events","type":"User","site_admin":false},"repo":{"id":131492457,"name":"Hercules","full_name":"Noooil/Hercules","owner":{"login":"Noooil","id":20649209,"avatar_url":"https://avatars3.githubusercontent.com/u/20649209?v=4","gravatar_id":"","url":"https://api.github.com/users/Noooil","html_url":"https://github.com/Noooil","followers_url":"https://api.github.com/users/Noooil/followers","following_url":"https://api.github.com/users/Noooil/following{/other_user}","gists_url":"https://api.github.com/users/Noooil/gists{/gist_id}","starred_url":"https://api.github.com/users/Noooil/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Noooil/subscriptions","organizations_url":"https://api.github.com/users/Noooil/orgs","repos_url":"https://api.github.com/users/Noooil/repos","events_url":"https://api.github.com/users/Noooil/events{/privacy}","received_events_url":"https://api.github.com/users/Noooil/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Noooil/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":true,"url":"https://api.github.com/repos/Noooil/Hercules","forks_url":"https://api.github.com/repos/Noooil/Hercules/forks","keys_url":"https://api.github.com/repos/Noooil/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Noooil/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Noooil/Hercules/teams","hooks_url":"https://api.github.com/repos/Noooil/Hercules/hooks","issue_events_url":"https://api.github.com/repos/Noooil/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/Noooil/Hercules/events","assignees_url":"https://api.github.com/repos/Noooil/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/Noooil/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/Noooil/Hercules/tags","blobs_url":"https://api.github.com/repos/Noooil/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Noooil/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Noooil/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/Noooil/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Noooil/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/Noooil/Hercules/languages","stargazers_url":"https://api.github.com/repos/Noooil/Hercules/stargazers","contributors_url":"https://api.github.com/repos/Noooil/Hercules/contributors","subscribers_url":"https://api.github.com/repos/Noooil/Hercules/subscribers","subscription_url":"https://api.github.com/repos/Noooil/Hercules/subscription","commits_url":"https://api.github.com/repos/Noooil/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/Noooil/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/Noooil/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/Noooil/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/Noooil/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/Noooil/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Noooil/Hercules/merges","archive_url":"https://api.github.com/repos/Noooil/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Noooil/Hercules/downloads","issues_url":"https://api.github.com/repos/Noooil/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/Noooil/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/Noooil/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/Noooil/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Noooil/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/Noooil/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/Noooil/Hercules/deployments","created_at":"2018-04-29T12:24:57Z","updated_at":"2018-04-29T12:28:07Z","pushed_at":"2018-04-29T12:28:04Z","git_url":"git://github.com/Noooil/Hercules.git","ssh_url":"git@github.com:Noooil/Hercules.git","clone_url":"https://github.com/Noooil/Hercules.git","svn_url":"https://github.com/Noooil/Hercules","homepage":"http://herc.ws","size":161771,"stargazers_count":0,"watchers_count":0,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"stable"}},"base":{"label":"HerculesWS:stable","ref":"stable","sha":"7b097da8b433ea3b768b6c306c12801f7ddef0a5","user":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"repo":{"id":7551429,"name":"Hercules","full_name":"HerculesWS/Hercules","owner":{"login":"HerculesWS","id":3220669,"avatar_url":"https://avatars3.githubusercontent.com/u/3220669?v=4","gravatar_id":"","url":"https://api.github.com/users/HerculesWS","html_url":"https://github.com/HerculesWS","followers_url":"https://api.github.com/users/HerculesWS/followers","following_url":"https://api.github.com/users/HerculesWS/following{/other_user}","gists_url":"https://api.github.com/users/HerculesWS/gists{/gist_id}","starred_url":"https://api.github.com/users/HerculesWS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/HerculesWS/subscriptions","organizations_url":"https://api.github.com/users/HerculesWS/orgs","repos_url":"https://api.github.com/users/HerculesWS/repos","events_url":"https://api.github.com/users/HerculesWS/events{/privacy}","received_events_url":"https://api.github.com/users/HerculesWS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/HerculesWS/Hercules","description":"Hercules is a collaborative software development project revolving around the creation of a robust massively multiplayer online role playing game (MMORPG) server package. Written in C, the program is very versatile and provides NPCs, warps and modifications. The project is jointly managed by a group of volunteers located around the world as well as a tremendous community providing QA and support. Hercules is a continuation of the original Athena project.","fork":false,"url":"https://api.github.com/repos/HerculesWS/Hercules","forks_url":"https://api.github.com/repos/HerculesWS/Hercules/forks","keys_url":"https://api.github.com/repos/HerculesWS/Hercules/keys{/key_id}","collaborators_url":"https://api.github.com/repos/HerculesWS/Hercules/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/HerculesWS/Hercules/teams","hooks_url":"https://api.github.com/repos/HerculesWS/Hercules/hooks","issue_events_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/events{/number}","events_url":"https://api.github.com/repos/HerculesWS/Hercules/events","assignees_url":"https://api.github.com/repos/HerculesWS/Hercules/assignees{/user}","branches_url":"https://api.github.com/repos/HerculesWS/Hercules/branches{/branch}","tags_url":"https://api.github.com/repos/HerculesWS/Hercules/tags","blobs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/HerculesWS/Hercules/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/HerculesWS/Hercules/git/refs{/sha}","trees_url":"https://api.github.com/repos/HerculesWS/Hercules/git/trees{/sha}","statuses_url":"https://api.github.com/repos/HerculesWS/Hercules/statuses/{sha}","languages_url":"https://api.github.com/repos/HerculesWS/Hercules/languages","stargazers_url":"https://api.github.com/repos/HerculesWS/Hercules/stargazers","contributors_url":"https://api.github.com/repos/HerculesWS/Hercules/contributors","subscribers_url":"https://api.github.com/repos/HerculesWS/Hercules/subscribers","subscription_url":"https://api.github.com/repos/HerculesWS/Hercules/subscription","commits_url":"https://api.github.com/repos/HerculesWS/Hercules/commits{/sha}","git_commits_url":"https://api.github.com/repos/HerculesWS/Hercules/git/commits{/sha}","comments_url":"https://api.github.com/repos/HerculesWS/Hercules/comments{/number}","issue_comment_url":"https://api.github.com/repos/HerculesWS/Hercules/issues/comments{/number}","contents_url":"https://api.github.com/repos/HerculesWS/Hercules/contents/{+path}","compare_url":"https://api.github.com/repos/HerculesWS/Hercules/compare/{base}...{head}","merges_url":"https://api.github.com/repos/HerculesWS/Hercules/merges","archive_url":"https://api.github.com/repos/HerculesWS/Hercules/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/HerculesWS/Hercules/downloads","issues_url":"https://api.github.com/repos/HerculesWS/Hercules/issues{/number}","pulls_url":"https://api.github.com/repos/HerculesWS/Hercules/pulls{/number}","milestones_url":"https://api.github.com/repos/HerculesWS/Hercules/milestones{/number}","notifications_url":"https://api.github.com/repos/HerculesWS/Hercules/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/HerculesWS/Hercules/labels{/name}","releases_url":"https://api.github.com/repos/HerculesWS/Hercules/releases{/id}","deployments_url":"https://api.github.com/repos/HerculesWS/Hercules/deployments","created_at":"2013-01-11T00:29:38Z","updated_at":"2018-04-27T04:46:30Z","pushed_at":"2018-04-29T14:07:07Z","git_url":"git://github.com/HerculesWS/Hercules.git","ssh_url":"git@github.com:HerculesWS/Hercules.git","clone_url":"https://github.com/HerculesWS/Hercules.git","svn_url":"https://github.com/HerculesWS/Hercules","homepage":"http://herc.ws","size":178107,"stargazers_count":412,"watchers_count":412,"language":"C","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":528,"mirror_url":null,"archived":false,"open_issues_count":407,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":528,"open_issues":407,"watchers":412,"default_branch":"stable"}},"_links":{"self":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2025"},"html":{"href":"https://github.com/HerculesWS/Hercules/pull/2025"},"issue":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2025"},"comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/issues/2025/comments"},"review_comments":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2025/comments"},"review_comment":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/HerculesWS/Hercules/pulls/2025/commits"},"statuses":{"href":"https://api.github.com/repos/HerculesWS/Hercules/statuses/3495aa003b62315717e62f6de8830c2bd69d5cb3"}},"author_association":"NONE"}}
{"actor":{"display_login":"4144"}}