{"action":"created","issue":{"url":"https://api.github.com/repos/stretchr/testify/issues/614","repository_url":"https://api.github.com/repos/stretchr/testify","labels_url":"https://api.github.com/repos/stretchr/testify/issues/614/labels{/name}","comments_url":"https://api.github.com/repos/stretchr/testify/issues/614/comments","events_url":"https://api.github.com/repos/stretchr/testify/issues/614/events","html_url":"https://github.com/stretchr/testify/pull/614","id":331992270,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NTg0Mzk1","number":614,"title":"EqualError: Accept error as expected value as well as string","user":{"login":"jinnovation","id":1932579,"node_id":"MDQ6VXNlcjE5MzI1Nzk=","avatar_url":"https://avatars3.githubusercontent.com/u/1932579?v=4","gravatar_id":"","url":"https://api.github.com/users/jinnovation","html_url":"https://github.com/jinnovation","followers_url":"https://api.github.com/users/jinnovation/followers","following_url":"https://api.github.com/users/jinnovation/following{/other_user}","gists_url":"https://api.github.com/users/jinnovation/gists{/gist_id}","starred_url":"https://api.github.com/users/jinnovation/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jinnovation/subscriptions","organizations_url":"https://api.github.com/users/jinnovation/orgs","repos_url":"https://api.github.com/users/jinnovation/repos","events_url":"https://api.github.com/users/jinnovation/events{/privacy}","received_events_url":"https://api.github.com/users/jinnovation/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-06-13T13:21:49Z","updated_at":"2019-01-02T22:54:42Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/stretchr/testify/pulls/614","html_url":"https://github.com/stretchr/testify/pull/614","diff_url":"https://github.com/stretchr/testify/pull/614.diff","patch_url":"https://github.com/stretchr/testify/pull/614.patch"},"body":"This modification is useful in cases where we want to assert equality against\r\nsome exported error value, e.g. `assert.EqualError(t, err, pkg.ErrSomeError)`,\r\nletting us avoid the unnecessary error \"dereference\" to string."},"comment":{"url":"https://api.github.com/repos/stretchr/testify/issues/comments/451010894","html_url":"https://github.com/stretchr/testify/pull/614#issuecomment-451010894","issue_url":"https://api.github.com/repos/stretchr/testify/issues/614","id":451010894,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MTAxMDg5NA==","user":{"login":"slizco","id":30560290,"node_id":"MDQ6VXNlcjMwNTYwMjkw","avatar_url":"https://avatars3.githubusercontent.com/u/30560290?v=4","gravatar_id":"","url":"https://api.github.com/users/slizco","html_url":"https://github.com/slizco","followers_url":"https://api.github.com/users/slizco/followers","following_url":"https://api.github.com/users/slizco/following{/other_user}","gists_url":"https://api.github.com/users/slizco/gists{/gist_id}","starred_url":"https://api.github.com/users/slizco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/slizco/subscriptions","organizations_url":"https://api.github.com/users/slizco/orgs","repos_url":"https://api.github.com/users/slizco/repos","events_url":"https://api.github.com/users/slizco/events{/privacy}","received_events_url":"https://api.github.com/users/slizco/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T22:54:42Z","updated_at":"2019-01-02T22:54:42Z","author_association":"NONE","body":"I'd also like to see this PR included. As an addition, it'd be nice for the assertion to return `true` if both the expected and actual errors passed equate to `nil` (in the case where an `error` is passed for expected value instead of `string`). This should still be a non-breaking change."}}
{"actor":{"display_login":"slizco"}}