{"action":"created","issue":{"url":"https://api.github.com/repos/istio/istio/issues/4036","repository_url":"https://api.github.com/repos/istio/istio","labels_url":"https://api.github.com/repos/istio/istio/issues/4036/labels{/name}","comments_url":"https://api.github.com/repos/istio/istio/issues/4036/comments","events_url":"https://api.github.com/repos/istio/istio/issues/4036/events","html_url":"https://github.com/istio/istio/pull/4036","id":302931240,"number":4036,"title":"Followup on EDS","user":{"login":"costinm","id":84202,"avatar_url":"https://avatars1.githubusercontent.com/u/84202?v=4","gravatar_id":"","url":"https://api.github.com/users/costinm","html_url":"https://github.com/costinm","followers_url":"https://api.github.com/users/costinm/followers","following_url":"https://api.github.com/users/costinm/following{/other_user}","gists_url":"https://api.github.com/users/costinm/gists{/gist_id}","starred_url":"https://api.github.com/users/costinm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/costinm/subscriptions","organizations_url":"https://api.github.com/users/costinm/orgs","repos_url":"https://api.github.com/users/costinm/repos","events_url":"https://api.github.com/users/costinm/events{/privacy}","received_events_url":"https://api.github.com/users/costinm/received_events","type":"User","site_admin":false},"labels":[{"id":491318011,"url":"https://api.github.com/repos/istio/istio/labels/cla:%20yes","name":"cla: yes","color":"bfdadc","default":false},{"id":663804851,"url":"https://api.github.com/repos/istio/istio/labels/needs-rebase","name":"needs-rebase","color":"bfdadc","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-03-07T01:29:54Z","updated_at":"2018-03-07T19:45:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/istio/istio/pulls/4036","html_url":"https://github.com/istio/istio/pull/4036","diff_url":"https://github.com/istio/istio/pull/4036.diff","patch_url":"https://github.com/istio/istio/pull/4036.patch"},"body":"- reduce logging (use env variable until someone finds out how to configure modules in the new logger)\r\n- add a fail-safe env variable, in case we need to turn it off. Needs to be set in the injector template if needed.\r\n- add the TLS option for grpc port (first attempt - will replace with proper grpc listener in followup). \r\nShriram: yes, I still agree we should load the certs in pilot, but can be done later.\r\n- starting to add some structs for debug and push - in progress, will keep adding while the rest is reviewed. Main question is how to name the clients for the debug - based on POD ID (IP) and watched resource, pod name and resource, or  group by remote pod. A http handler listing all connected endpoints and the watched resources in followup.\r\n- finish the move of all eds-related functions to eds.go (from mesh_discovery)\r\n\r\nAlso this changes the 2 'istio-on-istio' pilot configs to v2. "},"comment":{"url":"https://api.github.com/repos/istio/istio/issues/comments/371260930","html_url":"https://github.com/istio/istio/pull/4036#issuecomment-371260930","issue_url":"https://api.github.com/repos/istio/istio/issues/4036","id":371260930,"user":{"login":"codecov[bot]","id":22429695,"avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-03-07T19:45:43Z","updated_at":"2018-03-07T19:45:43Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/istio/istio/pull/4036?src=pr&el=h1) Report\n> Merging [#4036](https://codecov.io/gh/istio/istio/pull/4036?src=pr&el=desc) into [master](https://codecov.io/gh/istio/istio/commit/c863c92ff0384fa5f343c6575b4fe9095a249703?src=pr&el=desc) will **increase** coverage by `1%`.\n> The diff coverage is `64%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/istio/istio/pull/4036/graphs/tree.svg?width=650&height=150&src=pr&token=nYtepj7fDQ)](https://codecov.io/gh/istio/istio/pull/4036?src=pr&el=tree)\n\n```diff\n@@          Coverage Diff           @@\n##           master   #4036   +/-   ##\n======================================\n+ Coverage      75%     75%   +1%     \n======================================\n  Files         304     304           \n  Lines       27607   27540   -67     \n======================================\n- Hits        20676   20631   -45     \n+ Misses       5604    5581   -23     \n- Partials     1327    1328    +1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/istio/istio/pull/4036?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [pkg/bootstrap/bootstrap\\_config.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-cGtnL2Jvb3RzdHJhcC9ib290c3RyYXBfY29uZmlnLmdv) | `37% <0%> (ø)` | :arrow_down: |\n| [pilot/pkg/proxy/envoy/v1/discovery.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL3Byb3h5L2Vudm95L3YxL2Rpc2NvdmVyeS5nbw==) | `75% <0%> (ø)` | :arrow_down: |\n| [pilot/pkg/proxy/envoy/v2/mesh\\_discovery.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL3Byb3h5L2Vudm95L3YyL21lc2hfZGlzY292ZXJ5Lmdv) | `37% <0%> (-17%)` | :arrow_down: |\n| [pilot/pkg/bootstrap/monitoring.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL2Jvb3RzdHJhcC9tb25pdG9yaW5nLmdv) | `66% <100%> (+2%)` | :arrow_up: |\n| [pilot/pkg/bootstrap/server.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL2Jvb3RzdHJhcC9zZXJ2ZXIuZ28=) | `43% <100%> (+1%)` | :arrow_up: |\n| [pilot/pkg/proxy/envoy/v2/eds.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL3Byb3h5L2Vudm95L3YyL2Vkcy5nbw==) | `72% <65%> (-14%)` | :arrow_down: |\n| [mixer/adapter/solarwinds/log\\_handler.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zb2xhcndpbmRzL2xvZ19oYW5kbGVyLmdv) | `58% <0%> (-7%)` | :arrow_down: |\n| [mixer/adapter/servicecontrol/handler.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-bWl4ZXIvYWRhcHRlci9zZXJ2aWNlY29udHJvbC9oYW5kbGVyLmdv) | `34% <0%> (-5%)` | :arrow_down: |\n| [pilot/pkg/serviceregistry/kube/controller.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL3NlcnZpY2VyZWdpc3RyeS9rdWJlL2NvbnRyb2xsZXIuZ28=) | `63% <0%> (-1%)` | :arrow_down: |\n| [pilot/pkg/proxy/envoy/v2/mesh.go](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree#diff-cGlsb3QvcGtnL3Byb3h5L2Vudm95L3YyL21lc2guZ28=) | `75% <0%> (ø)` | :arrow_down: |\n| ... and [16 more](https://codecov.io/gh/istio/istio/pull/4036/diff?src=pr&el=tree-more) | |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/istio/istio/pull/4036?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/istio/istio/pull/4036?src=pr&el=footer). Last update [c863c92...4031ee1](https://codecov.io/gh/istio/istio/pull/4036?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}