{"action":"closed","issue":{"url":"https://api.github.com/repos/heptio/ark/issues/705","repository_url":"https://api.github.com/repos/heptio/ark","labels_url":"https://api.github.com/repos/heptio/ark/issues/705/labels{/name}","comments_url":"https://api.github.com/repos/heptio/ark/issues/705/comments","events_url":"https://api.github.com/repos/heptio/ark/issues/705/events","html_url":"https://github.com/heptio/ark/issues/705","id":344958576,"node_id":"MDU6SXNzdWUzNDQ5NTg1NzY=","number":705,"title":"sync controller: don't delete API objects that are new/in-progress/etc.","user":{"login":"skriss","id":5241206,"node_id":"MDQ6VXNlcjUyNDEyMDY=","avatar_url":"https://avatars3.githubusercontent.com/u/5241206?v=4","gravatar_id":"","url":"https://api.github.com/users/skriss","html_url":"https://github.com/skriss","followers_url":"https://api.github.com/users/skriss/followers","following_url":"https://api.github.com/users/skriss/following{/other_user}","gists_url":"https://api.github.com/users/skriss/gists{/gist_id}","starred_url":"https://api.github.com/users/skriss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/skriss/subscriptions","organizations_url":"https://api.github.com/users/skriss/orgs","repos_url":"https://api.github.com/users/skriss/repos","events_url":"https://api.github.com/users/skriss/events{/privacy}","received_events_url":"https://api.github.com/users/skriss/received_events","type":"User","site_admin":false},"labels":[{"id":660493774,"node_id":"MDU6TGFiZWw2NjA0OTM3NzQ=","url":"https://api.github.com/repos/heptio/ark/labels/Bug","name":"Bug","color":"ee0701","default":false},{"id":665348751,"node_id":"MDU6TGFiZWw2NjUzNDg3NTE=","url":"https://api.github.com/repos/heptio/ark/labels/P1%20-%20Important","name":"P1 - Important","color":"d93f0b","default":false}],"state":"closed","locked":false,"assignee":{"login":"carlisia","id":16508,"node_id":"MDQ6VXNlcjE2NTA4","avatar_url":"https://avatars0.githubusercontent.com/u/16508?v=4","gravatar_id":"","url":"https://api.github.com/users/carlisia","html_url":"https://github.com/carlisia","followers_url":"https://api.github.com/users/carlisia/followers","following_url":"https://api.github.com/users/carlisia/following{/other_user}","gists_url":"https://api.github.com/users/carlisia/gists{/gist_id}","starred_url":"https://api.github.com/users/carlisia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlisia/subscriptions","organizations_url":"https://api.github.com/users/carlisia/orgs","repos_url":"https://api.github.com/users/carlisia/repos","events_url":"https://api.github.com/users/carlisia/events{/privacy}","received_events_url":"https://api.github.com/users/carlisia/received_events","type":"User","site_admin":false},"assignees":[{"login":"carlisia","id":16508,"node_id":"MDQ6VXNlcjE2NTA4","avatar_url":"https://avatars0.githubusercontent.com/u/16508?v=4","gravatar_id":"","url":"https://api.github.com/users/carlisia","html_url":"https://github.com/carlisia","followers_url":"https://api.github.com/users/carlisia/followers","following_url":"https://api.github.com/users/carlisia/following{/other_user}","gists_url":"https://api.github.com/users/carlisia/gists{/gist_id}","starred_url":"https://api.github.com/users/carlisia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/carlisia/subscriptions","organizations_url":"https://api.github.com/users/carlisia/orgs","repos_url":"https://api.github.com/users/carlisia/repos","events_url":"https://api.github.com/users/carlisia/events{/privacy}","received_events_url":"https://api.github.com/users/carlisia/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/heptio/ark/milestones/8","html_url":"https://github.com/heptio/ark/milestone/8","labels_url":"https://api.github.com/repos/heptio/ark/milestones/8/labels","id":3460464,"node_id":"MDk6TWlsZXN0b25lMzQ2MDQ2NA==","number":8,"title":"v0.10.0","description":"","creator":{"login":"ncdc","id":354,"node_id":"MDQ6VXNlcjM1NA==","avatar_url":"https://avatars2.githubusercontent.com/u/354?v=4","gravatar_id":"","url":"https://api.github.com/users/ncdc","html_url":"https://github.com/ncdc","followers_url":"https://api.github.com/users/ncdc/followers","following_url":"https://api.github.com/users/ncdc/following{/other_user}","gists_url":"https://api.github.com/users/ncdc/gists{/gist_id}","starred_url":"https://api.github.com/users/ncdc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ncdc/subscriptions","organizations_url":"https://api.github.com/users/ncdc/orgs","repos_url":"https://api.github.com/users/ncdc/repos","events_url":"https://api.github.com/users/ncdc/events{/privacy}","received_events_url":"https://api.github.com/users/ncdc/received_events","type":"User","site_admin":false},"open_issues":5,"closed_issues":6,"state":"open","created_at":"2018-06-28T17:55:08Z","updated_at":"2018-07-31T16:18:48Z","due_on":null,"closed_at":null},"comments":5,"created_at":"2018-07-26T18:36:02Z","updated_at":"2018-07-31T16:18:48Z","closed_at":"2018-07-31T16:18:48Z","author_association":"CONTRIBUTOR","body":"backups with `.spec.phase` of \"\", New, InProgress should be excluded from the `deleteUnused` func.\r\n\r\nbackups with `.spec.phase` of FailedValidation -- I think it makes sense to exclude them as well.  This ensure we don't delete the API obj before a user can see why it failed validation. It will still be GC'ed according to its TTL.  We could possibly look at GC'ing backups that failed validation more quickly, but I don't think it's important for now.\r\n\r\nbackups with `.spec.phase` of Failed - these **should** be in object storage (just metadata + logs) -- so the existing code won't delete them, unless the upload of metadata to object storage fails. I'm tempted to exclude these from `deleteUnused` as well, as it could cause confusion for the user if a backup fails, uploading metadata/logs fail, and then the backup API obj just disappears.\r\n\r\nSo I think the net result of this is `deleteUnused` should *only* process `Completed` backups.\r\n\r\n@carlisia WDYT?  \r\n"}}
{"actor":{"display_login":"skriss"}}