{"action":"created","comment":{"url":"https://api.github.com/repos/pmix/pmix-standard/pulls/comments/228696719","pull_request_review_id":169037975,"id":228696719,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyODY5NjcxOQ==","diff_hunk":"@@ -223,6 +215,37 @@ \\subsection{\\code{PMIx_server_register_nspace}}\n \n Pass job-related information to the \\ac{PMIx} server library for distribution to local client processes.\n \n+The \\refarg{info} argument is expected to be a set of\n+\\begin{itemize}\n+    \\item namespace-level key-values: \n+    \\begin{itemize}\n+        \\item required: \\refattr{PMIX_NSPACE}, \\refattr{PMIX_JOBID}, \\refattr{PMIX_NODE_LIST}, \\refattr{PMIX_UNIV_SIZE}, \\refattr{PMIX_JOB_SIZE}, \\refattr{PMIX_MAX_PROCS}, \\refattr{PMIX_NUM_NODES}, \\refattr{PMIX_NODE_MAP}, \\refattr{PMIX_PROC_MAP}\n+        \\item optional: \\refattr{PMIX_SERVER_NSPACE}, \\refattr{PMIX_SERVER_RANK}, \\refattr{PMIX_NPROC_OFFSET}, \\refattr{PMIX_APPLDR}, \\refattr{PMIX_SESSION_ID}, \\refattr{PMIX_ALLOCATED_NODELIST}, \\refattr{PMIX_JOB_NUM_APPS}, \\refattr{PMIX_MAPBY}, \\refattr{PMIX_RANKBY}, \\refattr{PMIX_BINDTO}\n+    \\end{itemize}\n+    \\item node-level key-values: \n+    \\begin{itemize}\n+        \\item required: \\refattr{PMIX_LOCAL_SIZE}, \\refattr{PMIX_LOCAL_PEERS}. \\refattr{PMIX_LOCAL_CPUSETS}\n+        \\item optional: \\refattr{PMIX_AVAIL_PHYS_MEMORY}, \\refattr{PMIX_HWLOC_XML_V1}, \\refattr{PMIX_HWLOC_XML_V2}, \\refattr{PMIX_LOCALLDR}, \\refattr{PMIX_NODE_SIZE}, \\refattr{PMIX_LOCAL_PROCS}\n+    \\end{itemize}\n+    \\item Multiple complex key-values, each named \\refattr{PMIX_PROC_DATA}, encapsulating per-process information.\n+\n+          \\pastePRRTEAttributeItem{PMIX_PROC_DATA}\n+\n+          \\refattr{PMIX_PROC_DATA} must have type \\emph{PMIX_DATA_ARRAY} (\\refstruct{pmix_data_array_t}) with elements of type \\emph{PMIX_INFO} (\\refstruct{pmix_info_t}).\n+          The set of information enclosed in each of such keys is provided below (NOTE that the first key-value must be rank of the process as per \\refattr{PMIX_PROC_DATA} description).\n+    \\begin{itemize}\n+        \\item application-level key-values (in case of multiple applications):\n+        \\begin{itemize}\n+            \\item required: \\refattr{PMIX_APPNUM}, \\refattr{PMIX_APPLDR}, \\refattr{PMIX_APP_SIZE}, \\refattr{PMIX_APP_RANK}\n+        \\end{itemize}\n+        \\item process-level key-values:\n+        \\begin{itemize}\n+            \\item required: \\refattr{PMIX_RANK}, \\refattr{PMIX_LOCAL_RANK}, \\refattr{PMIX_NODE_RANK}, \\refattr{PMIX_NODEID}\n+            \\item optional: \\refattr{PMIX_PROCID}, \\refattr{PMIX_GLOBAL_RANK}, \\refattr{PMIX_HOSTNAME}\n+        \\end{itemize}\n+    \\end{itemize}\n+\\end{itemize}","path":"Chap_API_Server.tex","position":70,"original_position":70,"commit_id":"3ee8e8ca85ed3b93102f4b9ef34938705a45142b","original_commit_id":"3ee8e8ca85ed3b93102f4b9ef34938705a45142b","user":{"login":"rhc54","id":2440928,"node_id":"MDQ6VXNlcjI0NDA5Mjg=","avatar_url":"https://avatars1.githubusercontent.com/u/2440928?v=4","gravatar_id":"","url":"https://api.github.com/users/rhc54","html_url":"https://github.com/rhc54","followers_url":"https://api.github.com/users/rhc54/followers","following_url":"https://api.github.com/users/rhc54/following{/other_user}","gists_url":"https://api.github.com/users/rhc54/gists{/gist_id}","starred_url":"https://api.github.com/users/rhc54/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhc54/subscriptions","organizations_url":"https://api.github.com/users/rhc54/orgs","repos_url":"https://api.github.com/users/rhc54/repos","events_url":"https://api.github.com/users/rhc54/events{/privacy}","received_events_url":"https://api.github.com/users/rhc54/received_events","type":"User","site_admin":false},"body":"I'm not sure I understand how this differs from the prior itemized list of required and optional values. We certainly don't want to list them all twice, so perhaps we just need to look at organization?","created_at":"2018-10-27T01:16:00Z","updated_at":"2018-10-27T01:16:08Z","html_url":"https://github.com/pmix/pmix-standard/pull/123#discussion_r228696719","pull_request_url":"https://api.github.com/repos/pmix/pmix-standard/pulls/123","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pmix/pmix-standard/pulls/comments/228696719"},"html":{"href":"https://github.com/pmix/pmix-standard/pull/123#discussion_r228696719"},"pull_request":{"href":"https://api.github.com/repos/pmix/pmix-standard/pulls/123"}}},"pull_request":{"url":"https://api.github.com/repos/pmix/pmix-standard/pulls/123","id":226258620,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2MjU4NjIw","html_url":"https://github.com/pmix/pmix-standard/pull/123","diff_url":"https://github.com/pmix/pmix-standard/pull/123.diff","patch_url":"https://github.com/pmix/pmix-standard/pull/123.patch","issue_url":"https://api.github.com/repos/pmix/pmix-standard/issues/123","number":123,"state":"open","locked":false,"title":"Fix job-level information description","user":{"login":"artpol84","id":7534910,"node_id":"MDQ6VXNlcjc1MzQ5MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7534910?v=4","gravatar_id":"","url":"https://api.github.com/users/artpol84","html_url":"https://github.com/artpol84","followers_url":"https://api.github.com/users/artpol84/followers","following_url":"https://api.github.com/users/artpol84/following{/other_user}","gists_url":"https://api.github.com/users/artpol84/gists{/gist_id}","starred_url":"https://api.github.com/users/artpol84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpol84/subscriptions","organizations_url":"https://api.github.com/users/artpol84/orgs","repos_url":"https://api.github.com/users/artpol84/repos","events_url":"https://api.github.com/users/artpol84/events{/privacy}","received_events_url":"https://api.github.com/users/artpol84/received_events","type":"User","site_admin":false},"body":"This PR clarifies namespace registration with respect to a job-level information format.\r\n\r\nI was matching the way we interpret PMIx standard in Slurm and I found it difficult to implement based on description only. I had to go consult PRRTE implementation for that. \r\nThe main thing is that it seems to be incomplete with respect to how info argument should look like.\r\n\r\nIn particular:\r\n* From the description it seems like job-level information has a flat organization. While in practice Process data for the particular process is grouped in the `PMIX_PROC_DATA` key.\r\n* Application notion is also confusing there. As we don't have an application number argument in PMIx_Get there is no way to request keys about applications. Because of that, there is no way for the client to request information about \"given application\". As the result, PRRTE is storing application number, application size and other stuff for each process. However from the description it seems that RM is expected to group info about application (number, size, appldr) at higher level.\r\n\r\nI tried to modify the standard to make it more straightforward.","created_at":"2018-10-27T00:58:29Z","updated_at":"2018-10-27T01:16:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5363736eae4f5a18aa42f6b3c76a80eb01ecbf2f","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pmix/pmix-standard/pulls/123/commits","review_comments_url":"https://api.github.com/repos/pmix/pmix-standard/pulls/123/comments","review_comment_url":"https://api.github.com/repos/pmix/pmix-standard/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmix/pmix-standard/issues/123/comments","statuses_url":"https://api.github.com/repos/pmix/pmix-standard/statuses/3ee8e8ca85ed3b93102f4b9ef34938705a45142b","head":{"label":"artpol84:fix/jobinfo","ref":"fix/jobinfo","sha":"3ee8e8ca85ed3b93102f4b9ef34938705a45142b","user":{"login":"artpol84","id":7534910,"node_id":"MDQ6VXNlcjc1MzQ5MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7534910?v=4","gravatar_id":"","url":"https://api.github.com/users/artpol84","html_url":"https://github.com/artpol84","followers_url":"https://api.github.com/users/artpol84/followers","following_url":"https://api.github.com/users/artpol84/following{/other_user}","gists_url":"https://api.github.com/users/artpol84/gists{/gist_id}","starred_url":"https://api.github.com/users/artpol84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpol84/subscriptions","organizations_url":"https://api.github.com/users/artpol84/orgs","repos_url":"https://api.github.com/users/artpol84/repos","events_url":"https://api.github.com/users/artpol84/events{/privacy}","received_events_url":"https://api.github.com/users/artpol84/received_events","type":"User","site_admin":false},"repo":{"id":154880490,"node_id":"MDEwOlJlcG9zaXRvcnkxNTQ4ODA0OTA=","name":"pmix-standard","full_name":"artpol84/pmix-standard","private":false,"owner":{"login":"artpol84","id":7534910,"node_id":"MDQ6VXNlcjc1MzQ5MTA=","avatar_url":"https://avatars1.githubusercontent.com/u/7534910?v=4","gravatar_id":"","url":"https://api.github.com/users/artpol84","html_url":"https://github.com/artpol84","followers_url":"https://api.github.com/users/artpol84/followers","following_url":"https://api.github.com/users/artpol84/following{/other_user}","gists_url":"https://api.github.com/users/artpol84/gists{/gist_id}","starred_url":"https://api.github.com/users/artpol84/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/artpol84/subscriptions","organizations_url":"https://api.github.com/users/artpol84/orgs","repos_url":"https://api.github.com/users/artpol84/repos","events_url":"https://api.github.com/users/artpol84/events{/privacy}","received_events_url":"https://api.github.com/users/artpol84/received_events","type":"User","site_admin":false},"html_url":"https://github.com/artpol84/pmix-standard","description":"PMIx Standard Document","fork":true,"url":"https://api.github.com/repos/artpol84/pmix-standard","forks_url":"https://api.github.com/repos/artpol84/pmix-standard/forks","keys_url":"https://api.github.com/repos/artpol84/pmix-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/artpol84/pmix-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/artpol84/pmix-standard/teams","hooks_url":"https://api.github.com/repos/artpol84/pmix-standard/hooks","issue_events_url":"https://api.github.com/repos/artpol84/pmix-standard/issues/events{/number}","events_url":"https://api.github.com/repos/artpol84/pmix-standard/events","assignees_url":"https://api.github.com/repos/artpol84/pmix-standard/assignees{/user}","branches_url":"https://api.github.com/repos/artpol84/pmix-standard/branches{/branch}","tags_url":"https://api.github.com/repos/artpol84/pmix-standard/tags","blobs_url":"https://api.github.com/repos/artpol84/pmix-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/artpol84/pmix-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/artpol84/pmix-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/artpol84/pmix-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/artpol84/pmix-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/artpol84/pmix-standard/languages","stargazers_url":"https://api.github.com/repos/artpol84/pmix-standard/stargazers","contributors_url":"https://api.github.com/repos/artpol84/pmix-standard/contributors","subscribers_url":"https://api.github.com/repos/artpol84/pmix-standard/subscribers","subscription_url":"https://api.github.com/repos/artpol84/pmix-standard/subscription","commits_url":"https://api.github.com/repos/artpol84/pmix-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/artpol84/pmix-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/artpol84/pmix-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/artpol84/pmix-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/artpol84/pmix-standard/contents/{+path}","compare_url":"https://api.github.com/repos/artpol84/pmix-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/artpol84/pmix-standard/merges","archive_url":"https://api.github.com/repos/artpol84/pmix-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/artpol84/pmix-standard/downloads","issues_url":"https://api.github.com/repos/artpol84/pmix-standard/issues{/number}","pulls_url":"https://api.github.com/repos/artpol84/pmix-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/artpol84/pmix-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/artpol84/pmix-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/artpol84/pmix-standard/labels{/name}","releases_url":"https://api.github.com/repos/artpol84/pmix-standard/releases{/id}","deployments_url":"https://api.github.com/repos/artpol84/pmix-standard/deployments","created_at":"2018-10-26T18:49:38Z","updated_at":"2018-10-26T18:49:40Z","pushed_at":"2018-10-27T01:04:27Z","git_url":"git://github.com/artpol84/pmix-standard.git","ssh_url":"git@github.com:artpol84/pmix-standard.git","clone_url":"https://github.com/artpol84/pmix-standard.git","svn_url":"https://github.com/artpol84/pmix-standard","homepage":null,"size":1328,"stargazers_count":0,"watchers_count":0,"language":"TeX","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pmix:master","ref":"master","sha":"c5bbb2a0ffe41f40d8c5b6cc7121ffe58caf3d70","user":{"login":"pmix","id":15238617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjM4NjE3","avatar_url":"https://avatars3.githubusercontent.com/u/15238617?v=4","gravatar_id":"","url":"https://api.github.com/users/pmix","html_url":"https://github.com/pmix","followers_url":"https://api.github.com/users/pmix/followers","following_url":"https://api.github.com/users/pmix/following{/other_user}","gists_url":"https://api.github.com/users/pmix/gists{/gist_id}","starred_url":"https://api.github.com/users/pmix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmix/subscriptions","organizations_url":"https://api.github.com/users/pmix/orgs","repos_url":"https://api.github.com/users/pmix/repos","events_url":"https://api.github.com/users/pmix/events{/privacy}","received_events_url":"https://api.github.com/users/pmix/received_events","type":"Organization","site_admin":false},"repo":{"id":109306746,"node_id":"MDEwOlJlcG9zaXRvcnkxMDkzMDY3NDY=","name":"pmix-standard","full_name":"pmix/pmix-standard","private":false,"owner":{"login":"pmix","id":15238617,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjM4NjE3","avatar_url":"https://avatars3.githubusercontent.com/u/15238617?v=4","gravatar_id":"","url":"https://api.github.com/users/pmix","html_url":"https://github.com/pmix","followers_url":"https://api.github.com/users/pmix/followers","following_url":"https://api.github.com/users/pmix/following{/other_user}","gists_url":"https://api.github.com/users/pmix/gists{/gist_id}","starred_url":"https://api.github.com/users/pmix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmix/subscriptions","organizations_url":"https://api.github.com/users/pmix/orgs","repos_url":"https://api.github.com/users/pmix/repos","events_url":"https://api.github.com/users/pmix/events{/privacy}","received_events_url":"https://api.github.com/users/pmix/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/pmix/pmix-standard","description":"PMIx Standard Document","fork":false,"url":"https://api.github.com/repos/pmix/pmix-standard","forks_url":"https://api.github.com/repos/pmix/pmix-standard/forks","keys_url":"https://api.github.com/repos/pmix/pmix-standard/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmix/pmix-standard/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmix/pmix-standard/teams","hooks_url":"https://api.github.com/repos/pmix/pmix-standard/hooks","issue_events_url":"https://api.github.com/repos/pmix/pmix-standard/issues/events{/number}","events_url":"https://api.github.com/repos/pmix/pmix-standard/events","assignees_url":"https://api.github.com/repos/pmix/pmix-standard/assignees{/user}","branches_url":"https://api.github.com/repos/pmix/pmix-standard/branches{/branch}","tags_url":"https://api.github.com/repos/pmix/pmix-standard/tags","blobs_url":"https://api.github.com/repos/pmix/pmix-standard/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmix/pmix-standard/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmix/pmix-standard/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmix/pmix-standard/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmix/pmix-standard/statuses/{sha}","languages_url":"https://api.github.com/repos/pmix/pmix-standard/languages","stargazers_url":"https://api.github.com/repos/pmix/pmix-standard/stargazers","contributors_url":"https://api.github.com/repos/pmix/pmix-standard/contributors","subscribers_url":"https://api.github.com/repos/pmix/pmix-standard/subscribers","subscription_url":"https://api.github.com/repos/pmix/pmix-standard/subscription","commits_url":"https://api.github.com/repos/pmix/pmix-standard/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmix/pmix-standard/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmix/pmix-standard/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmix/pmix-standard/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmix/pmix-standard/contents/{+path}","compare_url":"https://api.github.com/repos/pmix/pmix-standard/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmix/pmix-standard/merges","archive_url":"https://api.github.com/repos/pmix/pmix-standard/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmix/pmix-standard/downloads","issues_url":"https://api.github.com/repos/pmix/pmix-standard/issues{/number}","pulls_url":"https://api.github.com/repos/pmix/pmix-standard/pulls{/number}","milestones_url":"https://api.github.com/repos/pmix/pmix-standard/milestones{/number}","notifications_url":"https://api.github.com/repos/pmix/pmix-standard/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmix/pmix-standard/labels{/name}","releases_url":"https://api.github.com/repos/pmix/pmix-standard/releases{/id}","deployments_url":"https://api.github.com/repos/pmix/pmix-standard/deployments","created_at":"2017-11-02T19:01:29Z","updated_at":"2018-10-26T20:00:26Z","pushed_at":"2018-10-27T01:04:28Z","git_url":"git://github.com/pmix/pmix-standard.git","ssh_url":"git@github.com:pmix/pmix-standard.git","clone_url":"https://github.com/pmix/pmix-standard.git","svn_url":"https://github.com/pmix/pmix-standard","homepage":null,"size":1335,"stargazers_count":1,"watchers_count":1,"language":"TeX","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":8,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":8,"open_issues":8,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmix/pmix-standard/pulls/123"},"html":{"href":"https://github.com/pmix/pmix-standard/pull/123"},"issue":{"href":"https://api.github.com/repos/pmix/pmix-standard/issues/123"},"comments":{"href":"https://api.github.com/repos/pmix/pmix-standard/issues/123/comments"},"review_comments":{"href":"https://api.github.com/repos/pmix/pmix-standard/pulls/123/comments"},"review_comment":{"href":"https://api.github.com/repos/pmix/pmix-standard/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmix/pmix-standard/pulls/123/commits"},"statuses":{"href":"https://api.github.com/repos/pmix/pmix-standard/statuses/3ee8e8ca85ed3b93102f4b9ef34938705a45142b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"rhc54"}}