{"action":"created","issue":{"url":"https://api.github.com/repos/alibaba/pouch/issues/1312","repository_url":"https://api.github.com/repos/alibaba/pouch","labels_url":"https://api.github.com/repos/alibaba/pouch/issues/1312/labels{/name}","comments_url":"https://api.github.com/repos/alibaba/pouch/issues/1312/comments","events_url":"https://api.github.com/repos/alibaba/pouch/issues/1312/events","html_url":"https://github.com/alibaba/pouch/pull/1312","id":322694112,"number":1312,"title":"bugfix: fix endpoints disappear when pouchd restart","user":{"login":"rudyfly","id":2264659,"avatar_url":"https://avatars3.githubusercontent.com/u/2264659?v=4","gravatar_id":"","url":"https://api.github.com/users/rudyfly","html_url":"https://github.com/rudyfly","followers_url":"https://api.github.com/users/rudyfly/followers","following_url":"https://api.github.com/users/rudyfly/following{/other_user}","gists_url":"https://api.github.com/users/rudyfly/gists{/gist_id}","starred_url":"https://api.github.com/users/rudyfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rudyfly/subscriptions","organizations_url":"https://api.github.com/users/rudyfly/orgs","repos_url":"https://api.github.com/users/rudyfly/repos","events_url":"https://api.github.com/users/rudyfly/events{/privacy}","received_events_url":"https://api.github.com/users/rudyfly/received_events","type":"User","site_admin":false},"labels":[{"id":684575943,"url":"https://api.github.com/repos/alibaba/pouch/labels/kind/bug","name":"kind/bug","color":"f77e56","default":false},{"id":722355122,"url":"https://api.github.com/repos/alibaba/pouch/labels/size/L","name":"size/L","color":"fbca04","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-14T07:00:50Z","updated_at":"2018-05-15T00:14:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/alibaba/pouch/pulls/1312","html_url":"https://github.com/alibaba/pouch/pull/1312","diff_url":"https://github.com/alibaba/pouch/pull/1312.diff","patch_url":"https://github.com/alibaba/pouch/pull/1312.patch"},"body":"<!-- \r\nPlease make sure you have read and understood the contributing guidelines;\r\nhttps://github.com/alibaba/pouch/blob/master/CONTRIBUTING.md -->\r\n\r\n### Ⅰ. Describe what this PR did\r\nFix endpoints disappear when pouchd restart, restore network controller\r\nneed keep endpoints that is using by the running containers, add the\r\nactive sandboxes option to initialize network controller.\r\n\r\n### Ⅱ. Does this pull request fix one issue?\r\n<!--If that, add \"fixes #xxxx\" below in the next line, for example, fixes #15. Otherwise, add \"NONE\" -->\r\n\r\n\r\n### Ⅲ. Describe how you did it\r\n\r\n\r\n### Ⅳ. Describe how to verify it\r\nThe container's endpoint is exist when pouchd has restarted.\r\n1. create container\r\n```\r\n# pouch run -d --name foo registry.hub.docker.com/library/busybox:latest top\r\n```\r\n2. restart pouchd\r\n3. check the endpoint is exist or not\r\n```\r\n# pouch exec -ti foo ifconfig\r\neth0      Link encap:Ethernet  HWaddr 02:42:AC:11:00:02\r\n          inet addr:172.17.0.2  Bcast:0.0.0.0  Mask:255.255.255.0\r\n          inet6 addr: fe80::42:acff:fe11:2/64 Scope:Link\r\n          UP BROADCAST RUNNING MULTICAST  MTU:1500  Metric:1\r\n          RX packets:22 errors:0 dropped:0 overruns:0 frame:0\r\n          TX packets:7 errors:0 dropped:0 overruns:0 carrier:0\r\n          collisions:0 txqueuelen:0\r\n          RX bytes:1828 (1.7 KiB)  TX bytes:586 (586.0 B)\r\n\r\nlo        Link encap:Local Loopback\r\n          inet addr:127.0.0.1  Mask:255.0.0.0\r\n          inet6 addr: ::1/128 Scope:Host\r\n          UP LOOPBACK RUNNING  MTU:65536  Metric:1\r\n          RX packets:0 errors:0 dropped:0 overruns:0 frame:0\r\n          TX packets:0 errors:0 dropped:0 overruns:0 carrier:0\r\n          collisions:0 txqueuelen:1000\r\n          RX bytes:0 (0.0 B)  TX bytes:0 (0.0 B)\r\n```\r\n\r\n### Ⅴ. Special notes for reviews\r\n\r\nSigned-off-by: Rudy Zhang <rudyflyzhang@gmail.com>\r\n"},"comment":{"url":"https://api.github.com/repos/alibaba/pouch/issues/comments/389002155","html_url":"https://github.com/alibaba/pouch/pull/1312#issuecomment-389002155","issue_url":"https://api.github.com/repos/alibaba/pouch/issues/1312","id":389002155,"user":{"login":"codecov-io","id":8655789,"avatar_url":"https://avatars0.githubusercontent.com/u/8655789?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov-io","html_url":"https://github.com/codecov-io","followers_url":"https://api.github.com/users/codecov-io/followers","following_url":"https://api.github.com/users/codecov-io/following{/other_user}","gists_url":"https://api.github.com/users/codecov-io/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov-io/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov-io/subscriptions","organizations_url":"https://api.github.com/users/codecov-io/orgs","repos_url":"https://api.github.com/users/codecov-io/repos","events_url":"https://api.github.com/users/codecov-io/events{/privacy}","received_events_url":"https://api.github.com/users/codecov-io/received_events","type":"User","site_admin":false},"created_at":"2018-05-15T00:14:43Z","updated_at":"2018-05-15T00:14:43Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/alibaba/pouch/pull/1312?src=pr&el=h1) Report\n> Merging [#1312](https://codecov.io/gh/alibaba/pouch/pull/1312?src=pr&el=desc) into [master](https://codecov.io/gh/alibaba/pouch/commit/de46ffaf755dee313d90060a53ba420aa6a4339a?src=pr&el=desc) will **decrease** coverage by `<.01%`.\n> The diff coverage is `0%`.\n\n\n[![Impacted file tree graph](https://codecov.io/gh/alibaba/pouch/pull/1312/graphs/tree.svg?width=650&height=150&token=AABQWPigYE&src=pr)](https://codecov.io/gh/alibaba/pouch/pull/1312?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master    #1312      +/-   ##\n==========================================\n- Coverage   17.38%   17.37%   -0.01%     \n==========================================\n  Files         189      189              \n  Lines       11772    11789      +17     \n==========================================\n+ Hits         2046     2048       +2     \n- Misses       9578     9594      +16     \n+ Partials      148      147       -1\n```\n\n\n| [Impacted Files](https://codecov.io/gh/alibaba/pouch/pull/1312?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [daemon/mgr/container\\_utils.go](https://codecov.io/gh/alibaba/pouch/pull/1312/diff?src=pr&el=tree#diff-ZGFlbW9uL21nci9jb250YWluZXJfdXRpbHMuZ28=) | `49.61% <0%> (-8.42%)` | :arrow_down: |\n| [daemon/mgr/network.go](https://codecov.io/gh/alibaba/pouch/pull/1312/diff?src=pr&el=tree#diff-ZGFlbW9uL21nci9uZXR3b3JrLmdv) | `3.19% <0%> (-0.14%)` | :arrow_down: |\n| [daemon/mgr/container.go](https://codecov.io/gh/alibaba/pouch/pull/1312/diff?src=pr&el=tree#diff-ZGFlbW9uL21nci9jb250YWluZXIuZ28=) | `0% <0%> (ø)` | :arrow_up: |\n| [daemon/logger/jsonfile/utils.go](https://codecov.io/gh/alibaba/pouch/pull/1312/diff?src=pr&el=tree#diff-ZGFlbW9uL2xvZ2dlci9qc29uZmlsZS91dGlscy5nbw==) | `70% <0%> (+1.66%)` | :arrow_up: |\n"}}
{"actor":{"display_login":"codecov-io"}}