{"action":"created","comment":{"url":"https://api.github.com/repos/google/proto-lens/pulls/comments/175333098","pull_request_review_id":104842529,"id":175333098,"diff_hunk":"@@ -0,0 +1,56 @@\n+name: proto-lens-discrimination\n+version: '0.1.1.0'\n+synopsis: Support for using proto-lens types with http://hackage.haskell.org/package/discrimination.\n+description: >\n+  Reflection-based implementations of Sort for proto-lens'\n+  generated types.\n+category: Data\n+author: Andrew Pritchard\n+maintainer: awpr+protolens@google.com\n+copyright: Google Inc.\n+license: BSD3\n+github: google/proto-lens/proto-lens-discrimination\n+extra-source-files:\n+  - tests/*.proto\n+\n+custom-setup:\n+  dependencies:\n+    - base >= 4.8 && < 4.11\n+    - Cabal\n+    - proto-lens-protoc == 0.3.*\n+\n+dependencies:\n+  - base >= 4.8 && < 4.11\n+  - data-default >= 0.5 && < 0.8\n+  - bytestring == 0.10.*\n+  - contravariant >= 1.3 && < 1.5\n+  - containers >= 0.5 && < 0.6\n+  - discrimination >= 0.3 && < 0.4\n+  - discrimination-ieee754 == 0.1.*\n+  - lens-family == 1.2.*\n+  - proto-lens >= 0.3 && < 0.4\n+  - proto-lens-protoc >= 0.3 && < 0.4\n+  - text == 1.2.*\n+\n+library:\n+  source-dirs: src\n+  exposed-modules:\n+    - Data.ProtoLens.Sort\n+    - Data.ProtoLens.Group\n+    - Data.ProtoLens.Discrimination\n+\n+tests:\n+\n+  discrimination_test:\n+    main: disc_test.hs\n+    source-dirs: tests\n+    dependencies:\n+      - HUnit >= 1.3 && < 1.7\n+      - proto-lens-arbitrary","path":"proto-lens-discrimination/package.yaml","position":49,"original_position":49,"commit_id":"356928cadd2d77850d07987bbb616f24fee19363","original_commit_id":"356928cadd2d77850d07987bbb616f24fee19363","user":{"login":"judah","id":49143,"avatar_url":"https://avatars3.githubusercontent.com/u/49143?v=4","gravatar_id":"","url":"https://api.github.com/users/judah","html_url":"https://github.com/judah","followers_url":"https://api.github.com/users/judah/followers","following_url":"https://api.github.com/users/judah/following{/other_user}","gists_url":"https://api.github.com/users/judah/gists{/gist_id}","starred_url":"https://api.github.com/users/judah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/judah/subscriptions","organizations_url":"https://api.github.com/users/judah/orgs","repos_url":"https://api.github.com/users/judah/repos","events_url":"https://api.github.com/users/judah/events{/privacy}","received_events_url":"https://api.github.com/users/judah/received_events","type":"User","site_admin":false},"body":"Add bounds for proto-lens-arbitrary? ","created_at":"2018-03-19T05:13:37Z","updated_at":"2018-03-19T05:26:55Z","html_url":"https://github.com/google/proto-lens/pull/182#discussion_r175333098","pull_request_url":"https://api.github.com/repos/google/proto-lens/pulls/182","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/google/proto-lens/pulls/comments/175333098"},"html":{"href":"https://github.com/google/proto-lens/pull/182#discussion_r175333098"},"pull_request":{"href":"https://api.github.com/repos/google/proto-lens/pulls/182"}}},"pull_request":{"url":"https://api.github.com/repos/google/proto-lens/pulls/182","id":175333030,"html_url":"https://github.com/google/proto-lens/pull/182","diff_url":"https://github.com/google/proto-lens/pull/182.diff","patch_url":"https://github.com/google/proto-lens/pull/182.patch","issue_url":"https://api.github.com/repos/google/proto-lens/issues/182","number":182,"state":"open","locked":false,"title":"Add discrimination-ieee754 and proto-lens-discrimination for linear-time sorting.","user":{"login":"awpr","id":458666,"avatar_url":"https://avatars0.githubusercontent.com/u/458666?v=4","gravatar_id":"","url":"https://api.github.com/users/awpr","html_url":"https://github.com/awpr","followers_url":"https://api.github.com/users/awpr/followers","following_url":"https://api.github.com/users/awpr/following{/other_user}","gists_url":"https://api.github.com/users/awpr/gists{/gist_id}","starred_url":"https://api.github.com/users/awpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awpr/subscriptions","organizations_url":"https://api.github.com/users/awpr/orgs","repos_url":"https://api.github.com/users/awpr/repos","events_url":"https://api.github.com/users/awpr/events{/privacy}","received_events_url":"https://api.github.com/users/awpr/received_events","type":"User","site_admin":false},"body":"My fix to discrimination finally got merged a few months ago, so we can proceed with this again.\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/google/proto-lens/182)\n<!-- Reviewable:end -->\n","created_at":"2018-03-15T17:59:14Z","updated_at":"2018-03-19T05:26:55Z","closed_at":null,"merged_at":null,"merge_commit_sha":"10728a5d2c1cda9e9b8665da2958c072723db169","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/google/proto-lens/pulls/182/commits","review_comments_url":"https://api.github.com/repos/google/proto-lens/pulls/182/comments","review_comment_url":"https://api.github.com/repos/google/proto-lens/pulls/comments{/number}","comments_url":"https://api.github.com/repos/google/proto-lens/issues/182/comments","statuses_url":"https://api.github.com/repos/google/proto-lens/statuses/356928cadd2d77850d07987bbb616f24fee19363","head":{"label":"awpr:discrimination_redux","ref":"discrimination_redux","sha":"356928cadd2d77850d07987bbb616f24fee19363","user":{"login":"awpr","id":458666,"avatar_url":"https://avatars0.githubusercontent.com/u/458666?v=4","gravatar_id":"","url":"https://api.github.com/users/awpr","html_url":"https://github.com/awpr","followers_url":"https://api.github.com/users/awpr/followers","following_url":"https://api.github.com/users/awpr/following{/other_user}","gists_url":"https://api.github.com/users/awpr/gists{/gist_id}","starred_url":"https://api.github.com/users/awpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awpr/subscriptions","organizations_url":"https://api.github.com/users/awpr/orgs","repos_url":"https://api.github.com/users/awpr/repos","events_url":"https://api.github.com/users/awpr/events{/privacy}","received_events_url":"https://api.github.com/users/awpr/received_events","type":"User","site_admin":false},"repo":{"id":64429754,"name":"proto-lens","full_name":"awpr/proto-lens","owner":{"login":"awpr","id":458666,"avatar_url":"https://avatars0.githubusercontent.com/u/458666?v=4","gravatar_id":"","url":"https://api.github.com/users/awpr","html_url":"https://github.com/awpr","followers_url":"https://api.github.com/users/awpr/followers","following_url":"https://api.github.com/users/awpr/following{/other_user}","gists_url":"https://api.github.com/users/awpr/gists{/gist_id}","starred_url":"https://api.github.com/users/awpr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/awpr/subscriptions","organizations_url":"https://api.github.com/users/awpr/orgs","repos_url":"https://api.github.com/users/awpr/repos","events_url":"https://api.github.com/users/awpr/events{/privacy}","received_events_url":"https://api.github.com/users/awpr/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/awpr/proto-lens","description":"API for protocol buffers using modern Haskell language and library patterns. This is not an official Google product.","fork":true,"url":"https://api.github.com/repos/awpr/proto-lens","forks_url":"https://api.github.com/repos/awpr/proto-lens/forks","keys_url":"https://api.github.com/repos/awpr/proto-lens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/awpr/proto-lens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/awpr/proto-lens/teams","hooks_url":"https://api.github.com/repos/awpr/proto-lens/hooks","issue_events_url":"https://api.github.com/repos/awpr/proto-lens/issues/events{/number}","events_url":"https://api.github.com/repos/awpr/proto-lens/events","assignees_url":"https://api.github.com/repos/awpr/proto-lens/assignees{/user}","branches_url":"https://api.github.com/repos/awpr/proto-lens/branches{/branch}","tags_url":"https://api.github.com/repos/awpr/proto-lens/tags","blobs_url":"https://api.github.com/repos/awpr/proto-lens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/awpr/proto-lens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/awpr/proto-lens/git/refs{/sha}","trees_url":"https://api.github.com/repos/awpr/proto-lens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/awpr/proto-lens/statuses/{sha}","languages_url":"https://api.github.com/repos/awpr/proto-lens/languages","stargazers_url":"https://api.github.com/repos/awpr/proto-lens/stargazers","contributors_url":"https://api.github.com/repos/awpr/proto-lens/contributors","subscribers_url":"https://api.github.com/repos/awpr/proto-lens/subscribers","subscription_url":"https://api.github.com/repos/awpr/proto-lens/subscription","commits_url":"https://api.github.com/repos/awpr/proto-lens/commits{/sha}","git_commits_url":"https://api.github.com/repos/awpr/proto-lens/git/commits{/sha}","comments_url":"https://api.github.com/repos/awpr/proto-lens/comments{/number}","issue_comment_url":"https://api.github.com/repos/awpr/proto-lens/issues/comments{/number}","contents_url":"https://api.github.com/repos/awpr/proto-lens/contents/{+path}","compare_url":"https://api.github.com/repos/awpr/proto-lens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/awpr/proto-lens/merges","archive_url":"https://api.github.com/repos/awpr/proto-lens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/awpr/proto-lens/downloads","issues_url":"https://api.github.com/repos/awpr/proto-lens/issues{/number}","pulls_url":"https://api.github.com/repos/awpr/proto-lens/pulls{/number}","milestones_url":"https://api.github.com/repos/awpr/proto-lens/milestones{/number}","notifications_url":"https://api.github.com/repos/awpr/proto-lens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/awpr/proto-lens/labels{/name}","releases_url":"https://api.github.com/repos/awpr/proto-lens/releases{/id}","deployments_url":"https://api.github.com/repos/awpr/proto-lens/deployments","created_at":"2016-07-28T21:35:48Z","updated_at":"2018-03-15T17:21:11Z","pushed_at":"2018-03-15T19:19:20Z","git_url":"git://github.com/awpr/proto-lens.git","ssh_url":"git@github.com:awpr/proto-lens.git","clone_url":"https://github.com/awpr/proto-lens.git","svn_url":"https://github.com/awpr/proto-lens","homepage":"","size":622,"stargazers_count":0,"watchers_count":0,"language":"Haskell","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"google:master","ref":"master","sha":"f73627ec70d801f4ffb548be201a920056534d4b","user":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"repo":{"id":57992085,"name":"proto-lens","full_name":"google/proto-lens","owner":{"login":"google","id":1342004,"avatar_url":"https://avatars1.githubusercontent.com/u/1342004?v=4","gravatar_id":"","url":"https://api.github.com/users/google","html_url":"https://github.com/google","followers_url":"https://api.github.com/users/google/followers","following_url":"https://api.github.com/users/google/following{/other_user}","gists_url":"https://api.github.com/users/google/gists{/gist_id}","starred_url":"https://api.github.com/users/google/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/google/subscriptions","organizations_url":"https://api.github.com/users/google/orgs","repos_url":"https://api.github.com/users/google/repos","events_url":"https://api.github.com/users/google/events{/privacy}","received_events_url":"https://api.github.com/users/google/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/google/proto-lens","description":"API for protocol buffers using modern Haskell language and library patterns. This is not an official Google product.","fork":false,"url":"https://api.github.com/repos/google/proto-lens","forks_url":"https://api.github.com/repos/google/proto-lens/forks","keys_url":"https://api.github.com/repos/google/proto-lens/keys{/key_id}","collaborators_url":"https://api.github.com/repos/google/proto-lens/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/google/proto-lens/teams","hooks_url":"https://api.github.com/repos/google/proto-lens/hooks","issue_events_url":"https://api.github.com/repos/google/proto-lens/issues/events{/number}","events_url":"https://api.github.com/repos/google/proto-lens/events","assignees_url":"https://api.github.com/repos/google/proto-lens/assignees{/user}","branches_url":"https://api.github.com/repos/google/proto-lens/branches{/branch}","tags_url":"https://api.github.com/repos/google/proto-lens/tags","blobs_url":"https://api.github.com/repos/google/proto-lens/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/google/proto-lens/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/google/proto-lens/git/refs{/sha}","trees_url":"https://api.github.com/repos/google/proto-lens/git/trees{/sha}","statuses_url":"https://api.github.com/repos/google/proto-lens/statuses/{sha}","languages_url":"https://api.github.com/repos/google/proto-lens/languages","stargazers_url":"https://api.github.com/repos/google/proto-lens/stargazers","contributors_url":"https://api.github.com/repos/google/proto-lens/contributors","subscribers_url":"https://api.github.com/repos/google/proto-lens/subscribers","subscription_url":"https://api.github.com/repos/google/proto-lens/subscription","commits_url":"https://api.github.com/repos/google/proto-lens/commits{/sha}","git_commits_url":"https://api.github.com/repos/google/proto-lens/git/commits{/sha}","comments_url":"https://api.github.com/repos/google/proto-lens/comments{/number}","issue_comment_url":"https://api.github.com/repos/google/proto-lens/issues/comments{/number}","contents_url":"https://api.github.com/repos/google/proto-lens/contents/{+path}","compare_url":"https://api.github.com/repos/google/proto-lens/compare/{base}...{head}","merges_url":"https://api.github.com/repos/google/proto-lens/merges","archive_url":"https://api.github.com/repos/google/proto-lens/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/google/proto-lens/downloads","issues_url":"https://api.github.com/repos/google/proto-lens/issues{/number}","pulls_url":"https://api.github.com/repos/google/proto-lens/pulls{/number}","milestones_url":"https://api.github.com/repos/google/proto-lens/milestones{/number}","notifications_url":"https://api.github.com/repos/google/proto-lens/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/google/proto-lens/labels{/name}","releases_url":"https://api.github.com/repos/google/proto-lens/releases{/id}","deployments_url":"https://api.github.com/repos/google/proto-lens/deployments","created_at":"2016-05-03T18:35:31Z","updated_at":"2018-03-17T22:28:52Z","pushed_at":"2018-03-19T05:07:39Z","git_url":"git://github.com/google/proto-lens.git","ssh_url":"git@github.com:google/proto-lens.git","clone_url":"https://github.com/google/proto-lens.git","svn_url":"https://github.com/google/proto-lens","homepage":"","size":808,"stargazers_count":192,"watchers_count":192,"language":"Haskell","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":true,"forks_count":32,"mirror_url":null,"archived":false,"open_issues_count":35,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":32,"open_issues":35,"watchers":192,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/google/proto-lens/pulls/182"},"html":{"href":"https://github.com/google/proto-lens/pull/182"},"issue":{"href":"https://api.github.com/repos/google/proto-lens/issues/182"},"comments":{"href":"https://api.github.com/repos/google/proto-lens/issues/182/comments"},"review_comments":{"href":"https://api.github.com/repos/google/proto-lens/pulls/182/comments"},"review_comment":{"href":"https://api.github.com/repos/google/proto-lens/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/google/proto-lens/pulls/182/commits"},"statuses":{"href":"https://api.github.com/repos/google/proto-lens/statuses/356928cadd2d77850d07987bbb616f24fee19363"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"judah"}}