{"action":"created","issue":{"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/105","repository_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk","labels_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/105/labels{/name}","comments_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/105/comments","events_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/105/events","html_url":"https://github.com/aerogear/aerogear-js-sdk/issues/105","id":325078687,"node_id":"MDU6SXNzdWUzMjUwNzg2ODc=","number":105,"title":"Root Detection for Android","user":{"login":"evanshortiss","id":1303687,"node_id":"MDQ6VXNlcjEzMDM2ODc=","avatar_url":"https://avatars0.githubusercontent.com/u/1303687?v=4","gravatar_id":"","url":"https://api.github.com/users/evanshortiss","html_url":"https://github.com/evanshortiss","followers_url":"https://api.github.com/users/evanshortiss/followers","following_url":"https://api.github.com/users/evanshortiss/following{/other_user}","gists_url":"https://api.github.com/users/evanshortiss/gists{/gist_id}","starred_url":"https://api.github.com/users/evanshortiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanshortiss/subscriptions","organizations_url":"https://api.github.com/users/evanshortiss/orgs","repos_url":"https://api.github.com/users/evanshortiss/repos","events_url":"https://api.github.com/users/evanshortiss/events{/privacy}","received_events_url":"https://api.github.com/users/evanshortiss/received_events","type":"User","site_admin":false},"labels":[{"id":839378523,"node_id":"MDU6TGFiZWw4MzkzNzg1MjM=","url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true}],"state":"open","locked":false,"assignee":{"login":"ciaranRoche","id":14313111,"node_id":"MDQ6VXNlcjE0MzEzMTEx","avatar_url":"https://avatars3.githubusercontent.com/u/14313111?v=4","gravatar_id":"","url":"https://api.github.com/users/ciaranRoche","html_url":"https://github.com/ciaranRoche","followers_url":"https://api.github.com/users/ciaranRoche/followers","following_url":"https://api.github.com/users/ciaranRoche/following{/other_user}","gists_url":"https://api.github.com/users/ciaranRoche/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranRoche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranRoche/subscriptions","organizations_url":"https://api.github.com/users/ciaranRoche/orgs","repos_url":"https://api.github.com/users/ciaranRoche/repos","events_url":"https://api.github.com/users/ciaranRoche/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranRoche/received_events","type":"User","site_admin":false},"assignees":[{"login":"ciaranRoche","id":14313111,"node_id":"MDQ6VXNlcjE0MzEzMTEx","avatar_url":"https://avatars3.githubusercontent.com/u/14313111?v=4","gravatar_id":"","url":"https://api.github.com/users/ciaranRoche","html_url":"https://github.com/ciaranRoche","followers_url":"https://api.github.com/users/ciaranRoche/followers","following_url":"https://api.github.com/users/ciaranRoche/following{/other_user}","gists_url":"https://api.github.com/users/ciaranRoche/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranRoche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranRoche/subscriptions","organizations_url":"https://api.github.com/users/ciaranRoche/orgs","repos_url":"https://api.github.com/users/ciaranRoche/repos","events_url":"https://api.github.com/users/ciaranRoche/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranRoche/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-05-21T22:22:55Z","updated_at":"2018-06-01T07:34:40Z","closed_at":null,"author_association":"MEMBER","body":"## Description\r\nI've tested the root checks on my Nexus 5 device and found that our default check is not sufficient for certain devices.\r\n\r\nWe are invoking `IRoot.isRooted()`, but on my device this doesn't catch the root. I need to invoke `IRoot. isRootedRedBeerWithoutBusyBoxCheck()` which correctly detected the root as did `IRoot.isRootedRedBeer()`.\r\n\r\nI'm not 100% sure what solution is best here from an Android perspective. Maybe check both `isRootedRedBeer` and `isRootedRedBeerWithoutBusyBoxCheck`? If the `isRootedRedBeerWithoutBusyBoxCheck` returns false then assume it's a false positive per [this doc](https://github.com/scottyab/rootbeer/blob/master/README.md#false-positives)?\r\n\r\n## Steps to reproduce\r\n1. Root or obtain rooted Android Device\r\n2. Invoke `return this.securityService.check(SecurityCheckType.notRooted)`\r\n3. Verify that `check.passed` is false"},"comment":{"url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/comments/393792379","html_url":"https://github.com/aerogear/aerogear-js-sdk/issues/105#issuecomment-393792379","issue_url":"https://api.github.com/repos/aerogear/aerogear-js-sdk/issues/105","id":393792379,"node_id":"MDEyOklzc3VlQ29tbWVudDM5Mzc5MjM3OQ==","user":{"login":"ciaranRoche","id":14313111,"node_id":"MDQ6VXNlcjE0MzEzMTEx","avatar_url":"https://avatars3.githubusercontent.com/u/14313111?v=4","gravatar_id":"","url":"https://api.github.com/users/ciaranRoche","html_url":"https://github.com/ciaranRoche","followers_url":"https://api.github.com/users/ciaranRoche/followers","following_url":"https://api.github.com/users/ciaranRoche/following{/other_user}","gists_url":"https://api.github.com/users/ciaranRoche/gists{/gist_id}","starred_url":"https://api.github.com/users/ciaranRoche/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ciaranRoche/subscriptions","organizations_url":"https://api.github.com/users/ciaranRoche/orgs","repos_url":"https://api.github.com/users/ciaranRoche/repos","events_url":"https://api.github.com/users/ciaranRoche/events{/privacy}","received_events_url":"https://api.github.com/users/ciaranRoche/received_events","type":"User","site_admin":false},"created_at":"2018-06-01T07:34:40Z","updated_at":"2018-06-01T07:34:40Z","author_association":"MEMBER","body":"@evanshortiss I am going to merge the fix now, but I think we should keep this issue open. Next sprint we are bringing in a task on e2e verification of these security checks, ill make note of this issue and see if we can run those e2e steps on a real device for both this SDK and our Android SDK to ensure this issue is resolved."}}
{"actor":{"display_login":"ciaranRoche"}}