{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/198249095","pull_request_review_id":132145774,"id":198249095,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5ODI0OTA5NQ==","diff_hunk":"@@ -19,22 +19,22 @@\n \n package org.elasticsearch.ingest.common;\n \n-import org.elasticsearch.ingest.CompoundProcessor;\n-import org.elasticsearch.ingest.IngestDocument;\n-import org.elasticsearch.ingest.Processor;\n-import org.elasticsearch.ingest.TestProcessor;\n-import org.elasticsearch.ingest.TestTemplateService;\n-import org.elasticsearch.script.TemplateScript;\n-import org.elasticsearch.test.ESTestCase;\n-\n import java.util.ArrayList;\n import java.util.Arrays;\n import java.util.Collections;\n import java.util.HashMap;\n import java.util.List;\n import java.util.Locale;\n import java.util.Map;\n+import org.elasticsearch.ingest.CompoundProcessor;\n+import org.elasticsearch.ingest.IngestDocument;\n+import org.elasticsearch.ingest.Processor;\n+import org.elasticsearch.ingest.TestProcessor;\n+import org.elasticsearch.ingest.TestTemplateService;\n+import org.elasticsearch.script.TemplateScript;\n+import org.elasticsearch.test.ESTestCase;","path":"modules/ingest-common/src/test/java/org/elasticsearch/ingest/common/ForEachProcessorTests.java","position":25,"original_position":25,"commit_id":"93d6923198c796880baecf10798976c66eff8e2b","original_commit_id":"93d6923198c796880baecf10798976c66eff8e2b","user":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"body":"Done :), sorry about that","created_at":"2018-06-26T18:17:51Z","updated_at":"2018-06-26T18:17:51Z","html_url":"https://github.com/elastic/elasticsearch/pull/31578#discussion_r198249095","pull_request_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/31578","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments/198249095"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/31578#discussion_r198249095"},"pull_request":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/31578"}},"in_reply_to_id":198247261},"pull_request":{"url":"https://api.github.com/repos/elastic/elasticsearch/pulls/31578","id":197407991,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk3NDA3OTkx","html_url":"https://github.com/elastic/elasticsearch/pull/31578","diff_url":"https://github.com/elastic/elasticsearch/pull/31578.diff","patch_url":"https://github.com/elastic/elasticsearch/pull/31578.patch","issue_url":"https://api.github.com/repos/elastic/elasticsearch/issues/31578","number":31578,"state":"closed","locked":false,"title":"ingest: Add ignore_missing property to foreach filter (#22147)","user":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"body":"Adds the `ignore_missing` functionality to the foreach filter to fix #22147.\r\n\r\nTried to keep it as close to the way this is implemented in the GeoIP filter as possible.","created_at":"2018-06-26T12:39:56Z","updated_at":"2018-06-26T18:17:51Z","closed_at":"2018-06-26T18:04:41Z","merged_at":"2018-06-26T18:04:41Z","merge_commit_sha":"13e1cf61917285ee0f16d4c28818daeae6607525","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":268963484,"node_id":"MDU6TGFiZWwyNjg5NjM0ODQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/:Core/Ingest","name":":Core/Ingest","color":"0e8a16","default":false},{"id":23174,"node_id":"MDU6TGFiZWwyMzE3NA==","url":"https://api.github.com/repos/elastic/elasticsearch/labels/%3Eenhancement","name":">enhancement","color":"4a4ea8","default":false},{"id":484855464,"node_id":"MDU6TGFiZWw0ODQ4NTU0NjQ=","url":"https://api.github.com/repos/elastic/elasticsearch/labels/v7.0.0","name":"v7.0.0","color":"dddddd","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/31578/commits","review_comments_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/31578/comments","review_comment_url":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/issues/31578/comments","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/93d6923198c796880baecf10798976c66eff8e2b","head":{"label":"original-brownbear:22147","ref":"22147","sha":"93d6923198c796880baecf10798976c66eff8e2b","user":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"repo":{"id":92321292,"node_id":"MDEwOlJlcG9zaXRvcnk5MjMyMTI5Mg==","name":"elasticsearch","full_name":"original-brownbear/elasticsearch","owner":{"login":"original-brownbear","id":6490959,"node_id":"MDQ6VXNlcjY0OTA5NTk=","avatar_url":"https://avatars0.githubusercontent.com/u/6490959?v=4","gravatar_id":"","url":"https://api.github.com/users/original-brownbear","html_url":"https://github.com/original-brownbear","followers_url":"https://api.github.com/users/original-brownbear/followers","following_url":"https://api.github.com/users/original-brownbear/following{/other_user}","gists_url":"https://api.github.com/users/original-brownbear/gists{/gist_id}","starred_url":"https://api.github.com/users/original-brownbear/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/original-brownbear/subscriptions","organizations_url":"https://api.github.com/users/original-brownbear/orgs","repos_url":"https://api.github.com/users/original-brownbear/repos","events_url":"https://api.github.com/users/original-brownbear/events{/privacy}","received_events_url":"https://api.github.com/users/original-brownbear/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/original-brownbear/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":true,"url":"https://api.github.com/repos/original-brownbear/elasticsearch","forks_url":"https://api.github.com/repos/original-brownbear/elasticsearch/forks","keys_url":"https://api.github.com/repos/original-brownbear/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/original-brownbear/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/original-brownbear/elasticsearch/teams","hooks_url":"https://api.github.com/repos/original-brownbear/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/original-brownbear/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/original-brownbear/elasticsearch/events","assignees_url":"https://api.github.com/repos/original-brownbear/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/original-brownbear/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/original-brownbear/elasticsearch/tags","blobs_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/original-brownbear/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/original-brownbear/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/original-brownbear/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/original-brownbear/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/original-brownbear/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/original-brownbear/elasticsearch/subscription","commits_url":"https://api.github.com/repos/original-brownbear/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/original-brownbear/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/original-brownbear/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/original-brownbear/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/original-brownbear/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/original-brownbear/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/original-brownbear/elasticsearch/merges","archive_url":"https://api.github.com/repos/original-brownbear/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/original-brownbear/elasticsearch/downloads","issues_url":"https://api.github.com/repos/original-brownbear/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/original-brownbear/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/original-brownbear/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/original-brownbear/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/original-brownbear/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/original-brownbear/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/original-brownbear/elasticsearch/deployments","created_at":"2017-05-24T18:00:17Z","updated_at":"2017-05-24T18:01:04Z","pushed_at":"2018-06-26T18:04:45Z","git_url":"git://github.com/original-brownbear/elasticsearch.git","ssh_url":"git@github.com:original-brownbear/elasticsearch.git","clone_url":"https://github.com/original-brownbear/elasticsearch.git","svn_url":"https://github.com/original-brownbear/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":436620,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"db90905405297a392707c3137e19f7227462bdd8","user":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":507775,"node_id":"MDEwOlJlcG9zaXRvcnk1MDc3NzU=","name":"elasticsearch","full_name":"elastic/elasticsearch","owner":{"login":"elastic","id":6764390,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY3NjQzOTA=","avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/elasticsearch","description":"Open Source, Distributed, RESTful Search Engine","fork":false,"url":"https://api.github.com/repos/elastic/elasticsearch","forks_url":"https://api.github.com/repos/elastic/elasticsearch/forks","keys_url":"https://api.github.com/repos/elastic/elasticsearch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/elasticsearch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/elasticsearch/teams","hooks_url":"https://api.github.com/repos/elastic/elasticsearch/hooks","issue_events_url":"https://api.github.com/repos/elastic/elasticsearch/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/elasticsearch/events","assignees_url":"https://api.github.com/repos/elastic/elasticsearch/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/elasticsearch/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/elasticsearch/tags","blobs_url":"https://api.github.com/repos/elastic/elasticsearch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/elasticsearch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/elasticsearch/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/elasticsearch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/elasticsearch/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/elasticsearch/languages","stargazers_url":"https://api.github.com/repos/elastic/elasticsearch/stargazers","contributors_url":"https://api.github.com/repos/elastic/elasticsearch/contributors","subscribers_url":"https://api.github.com/repos/elastic/elasticsearch/subscribers","subscription_url":"https://api.github.com/repos/elastic/elasticsearch/subscription","commits_url":"https://api.github.com/repos/elastic/elasticsearch/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/elasticsearch/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/elasticsearch/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/elasticsearch/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/elasticsearch/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/elasticsearch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/elasticsearch/merges","archive_url":"https://api.github.com/repos/elastic/elasticsearch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/elasticsearch/downloads","issues_url":"https://api.github.com/repos/elastic/elasticsearch/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/elasticsearch/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/elasticsearch/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/elasticsearch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/elasticsearch/labels{/name}","releases_url":"https://api.github.com/repos/elastic/elasticsearch/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/elasticsearch/deployments","created_at":"2010-02-08T13:20:56Z","updated_at":"2018-06-26T18:05:15Z","pushed_at":"2018-06-26T18:09:54Z","git_url":"git://github.com/elastic/elasticsearch.git","ssh_url":"git@github.com:elastic/elasticsearch.git","clone_url":"https://github.com/elastic/elasticsearch.git","svn_url":"https://github.com/elastic/elasticsearch","homepage":"https://www.elastic.co/products/elasticsearch","size":493554,"stargazers_count":32010,"watchers_count":32010,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":10997,"mirror_url":null,"archived":false,"open_issues_count":1455,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10997,"open_issues":1455,"watchers":32010,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/31578"},"html":{"href":"https://github.com/elastic/elasticsearch/pull/31578"},"issue":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/31578"},"comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/issues/31578/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/31578/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/elasticsearch/pulls/31578/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/elasticsearch/statuses/93d6923198c796880baecf10798976c66eff8e2b"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"original-brownbear"}}