{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/22589","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/22589/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/22589/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/22589/events","html_url":"https://github.com/nodejs/node/pull/22589","id":355257019,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExODI3OTY0","number":22589,"title":"test: skip fs.watch on Travis","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"labels":[{"id":442446525,"node_id":"MDU6TGFiZWw0NDI0NDY1MjU=","url":"https://api.github.com/repos/nodejs/node/labels/async_hooks","name":"async_hooks","color":"ededed","default":false},{"id":155435785,"node_id":"MDU6TGFiZWwxNTU0MzU3ODU=","url":"https://api.github.com/repos/nodejs/node/labels/fs","name":"fs","color":"0052cc","default":false},{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":7,"created_at":"2018-08-29T17:19:38Z","updated_at":"2018-11-08T07:36:52Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/22589","html_url":"https://github.com/nodejs/node/pull/22589","diff_url":"https://github.com/nodejs/node/pull/22589.diff","patch_url":"https://github.com/nodejs/node/pull/22589.patch"},"body":"Fixes: https://github.com/nodejs/node/issues/21310\r\nRefs: https://docs.travis-ci.com/user/environment-variables/#default-environment-variables\r\n\r\n- Refs: https://travis-ci.com/nodejs/node/jobs/142234998\r\n  - test/async-hooks/test-fseventwrap.js\r\n  - test/parallel/test-fs-watch-close-when-destroyed.js\r\n\r\n- Ref: https://travis-ci.com/nodejs/node/jobs/142716959\r\n  - test/sequential/test-fs-watch.js\r\n\r\nRefs: https://github.com/nodejs/node/pull/24198#issuecomment-436460289\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [X] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/436900378","html_url":"https://github.com/nodejs/node/pull/22589#issuecomment-436900378","issue_url":"https://api.github.com/repos/nodejs/node/issues/22589","id":436900378,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjkwMDM3OA==","user":{"login":"thefourtheye","id":696611,"node_id":"MDQ6VXNlcjY5NjYxMQ==","avatar_url":"https://avatars3.githubusercontent.com/u/696611?v=4","gravatar_id":"","url":"https://api.github.com/users/thefourtheye","html_url":"https://github.com/thefourtheye","followers_url":"https://api.github.com/users/thefourtheye/followers","following_url":"https://api.github.com/users/thefourtheye/following{/other_user}","gists_url":"https://api.github.com/users/thefourtheye/gists{/gist_id}","starred_url":"https://api.github.com/users/thefourtheye/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/thefourtheye/subscriptions","organizations_url":"https://api.github.com/users/thefourtheye/orgs","repos_url":"https://api.github.com/users/thefourtheye/repos","events_url":"https://api.github.com/users/thefourtheye/events{/privacy}","received_events_url":"https://api.github.com/users/thefourtheye/received_events","type":"User","site_admin":false},"created_at":"2018-11-08T07:36:52Z","updated_at":"2018-11-08T07:36:52Z","author_association":"CONTRIBUTOR","body":"The tests being skipped here need to be tested on all our supported platforms. We even have captured the caveats in our docs, [here](https://nodejs.org/docs/latest/api/fs.html#fs_caveats).\r\n\r\nI understand these tests make our CI flaky, but I would prefer not to skip them if that is an option."}}
{"actor":{"display_login":"thefourtheye"}}