{"action":"created","comment":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/184498684","pull_request_review_id":115707238,"id":184498684,"diff_hunk":"@@ -495,11 +513,31 @@ void DlgPrefDeck::slotRateRampingModeLinearButton(bool checked) {\n     }\n }\n \n+void DlgPrefDeck::slotTimeFormatChanged(double v) {\n+    int i = static_cast<int>(v);\n+    m_timeDisplayFormat = static_cast<TrackTime::DisplayFormat>(i);\n+\n+    m_pConfig->set(ConfigKey(\"[Controls]\",\"TimeFormat\"), ConfigValue(v));\n+    comboBoxTimeFormat->setCurrentIndex(\n+                comboBoxTimeFormat->findData(i));\n+\n+}\n+\n+void DlgPrefDeck::slotTimeFormatChanged(int index) {\n+    int mode = comboBoxTimeFormat->itemData(index).toInt();\n+    m_timeDisplayFormat = static_cast<TrackTime::DisplayFormat>(mode);\n+}\n+\n void DlgPrefDeck::slotApply() {\n     double timeDisplay = static_cast<double>(m_timeDisplayMode);","path":"src/preferences/dialog/dlgprefdeck.cpp","position":45,"original_position":45,"commit_id":"9c658a054b0741c9e69f1cd9d665c2e816896dce","original_commit_id":"9c658a054b0741c9e69f1cd9d665c2e816896dce","user":{"login":"daschuer","id":1777442,"avatar_url":"https://avatars3.githubusercontent.com/u/1777442?v=4","gravatar_id":"","url":"https://api.github.com/users/daschuer","html_url":"https://github.com/daschuer","followers_url":"https://api.github.com/users/daschuer/followers","following_url":"https://api.github.com/users/daschuer/following{/other_user}","gists_url":"https://api.github.com/users/daschuer/gists{/gist_id}","starred_url":"https://api.github.com/users/daschuer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/daschuer/subscriptions","organizations_url":"https://api.github.com/users/daschuer/orgs","repos_url":"https://api.github.com/users/daschuer/repos","events_url":"https://api.github.com/users/daschuer/events{/privacy}","received_events_url":"https://api.github.com/users/daschuer/received_events","type":"User","site_admin":false},"body":"I think we can get also rid of m_timeDisplayMode","created_at":"2018-04-26T19:03:42Z","updated_at":"2018-04-26T19:53:27Z","html_url":"https://github.com/mixxxdj/mixxx/pull/1652#discussion_r184498684","pull_request_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1652","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments/184498684"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1652#discussion_r184498684"},"pull_request":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1652"}}},"pull_request":{"url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1652","id":184416301,"html_url":"https://github.com/mixxxdj/mixxx/pull/1652","diff_url":"https://github.com/mixxxdj/mixxx/pull/1652.diff","patch_url":"https://github.com/mixxxdj/mixxx/pull/1652.patch","issue_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1652","number":1652,"state":"open","locked":false,"title":"Implement switchable time format for decks","user":{"login":"poelzi","id":66107,"avatar_url":"https://avatars3.githubusercontent.com/u/66107?v=4","gravatar_id":"","url":"https://api.github.com/users/poelzi","html_url":"https://github.com/poelzi","followers_url":"https://api.github.com/users/poelzi/followers","following_url":"https://api.github.com/users/poelzi/following{/other_user}","gists_url":"https://api.github.com/users/poelzi/gists{/gist_id}","starred_url":"https://api.github.com/users/poelzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poelzi/subscriptions","organizations_url":"https://api.github.com/users/poelzi/orgs","repos_url":"https://api.github.com/users/poelzi/repos","events_url":"https://api.github.com/users/poelzi/events{/privacy}","received_events_url":"https://api.github.com/users/poelzi/received_events","type":"User","site_admin":false},"body":"The display format on the decks can now be configured.\r\nImplement first alternative display based on kiloseconds.\r\n\r\nIf you mixx tracks based on first and last downbeat, it is unnecessary complicated to use minutes. The first alternative display shows \"k.sss:zzz\" following roughly the idea of the kilosecond so it can be much easier calculated when the next track should be started.","created_at":"2018-04-26T17:48:20Z","updated_at":"2018-04-26T19:53:27Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b2abc58d865dade08d85d1b6552325cb357e5936","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1652/commits","review_comments_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1652/comments","review_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/1652/comments","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/9c658a054b0741c9e69f1cd9d665c2e816896dce","head":{"label":"poelzi:feature/seconds","ref":"feature/seconds","sha":"9c658a054b0741c9e69f1cd9d665c2e816896dce","user":{"login":"poelzi","id":66107,"avatar_url":"https://avatars3.githubusercontent.com/u/66107?v=4","gravatar_id":"","url":"https://api.github.com/users/poelzi","html_url":"https://github.com/poelzi","followers_url":"https://api.github.com/users/poelzi/followers","following_url":"https://api.github.com/users/poelzi/following{/other_user}","gists_url":"https://api.github.com/users/poelzi/gists{/gist_id}","starred_url":"https://api.github.com/users/poelzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poelzi/subscriptions","organizations_url":"https://api.github.com/users/poelzi/orgs","repos_url":"https://api.github.com/users/poelzi/repos","events_url":"https://api.github.com/users/poelzi/events{/privacy}","received_events_url":"https://api.github.com/users/poelzi/received_events","type":"User","site_admin":false},"repo":{"id":98884779,"name":"mixxx","full_name":"poelzi/mixxx","owner":{"login":"poelzi","id":66107,"avatar_url":"https://avatars3.githubusercontent.com/u/66107?v=4","gravatar_id":"","url":"https://api.github.com/users/poelzi","html_url":"https://github.com/poelzi","followers_url":"https://api.github.com/users/poelzi/followers","following_url":"https://api.github.com/users/poelzi/following{/other_user}","gists_url":"https://api.github.com/users/poelzi/gists{/gist_id}","starred_url":"https://api.github.com/users/poelzi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poelzi/subscriptions","organizations_url":"https://api.github.com/users/poelzi/orgs","repos_url":"https://api.github.com/users/poelzi/repos","events_url":"https://api.github.com/users/poelzi/events{/privacy}","received_events_url":"https://api.github.com/users/poelzi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/poelzi/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":true,"url":"https://api.github.com/repos/poelzi/mixxx","forks_url":"https://api.github.com/repos/poelzi/mixxx/forks","keys_url":"https://api.github.com/repos/poelzi/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poelzi/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poelzi/mixxx/teams","hooks_url":"https://api.github.com/repos/poelzi/mixxx/hooks","issue_events_url":"https://api.github.com/repos/poelzi/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/poelzi/mixxx/events","assignees_url":"https://api.github.com/repos/poelzi/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/poelzi/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/poelzi/mixxx/tags","blobs_url":"https://api.github.com/repos/poelzi/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poelzi/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poelzi/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/poelzi/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poelzi/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/poelzi/mixxx/languages","stargazers_url":"https://api.github.com/repos/poelzi/mixxx/stargazers","contributors_url":"https://api.github.com/repos/poelzi/mixxx/contributors","subscribers_url":"https://api.github.com/repos/poelzi/mixxx/subscribers","subscription_url":"https://api.github.com/repos/poelzi/mixxx/subscription","commits_url":"https://api.github.com/repos/poelzi/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/poelzi/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/poelzi/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/poelzi/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/poelzi/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/poelzi/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poelzi/mixxx/merges","archive_url":"https://api.github.com/repos/poelzi/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poelzi/mixxx/downloads","issues_url":"https://api.github.com/repos/poelzi/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/poelzi/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/poelzi/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/poelzi/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poelzi/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/poelzi/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/poelzi/mixxx/deployments","created_at":"2017-07-31T12:06:59Z","updated_at":"2017-07-31T12:07:12Z","pushed_at":"2018-04-26T17:43:04Z","git_url":"git://github.com/poelzi/mixxx.git","ssh_url":"git@github.com:poelzi/mixxx.git","clone_url":"https://github.com/poelzi/mixxx.git","svn_url":"https://github.com/poelzi/mixxx","homepage":"http://mixxx.org","size":289085,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"mixxxdj:master","ref":"master","sha":"54d15e3b6d6878131e36f2dac8d1b6180a8bf06b","user":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"repo":{"id":10126031,"name":"mixxx","full_name":"mixxxdj/mixxx","owner":{"login":"mixxxdj","id":1743769,"avatar_url":"https://avatars3.githubusercontent.com/u/1743769?v=4","gravatar_id":"","url":"https://api.github.com/users/mixxxdj","html_url":"https://github.com/mixxxdj","followers_url":"https://api.github.com/users/mixxxdj/followers","following_url":"https://api.github.com/users/mixxxdj/following{/other_user}","gists_url":"https://api.github.com/users/mixxxdj/gists{/gist_id}","starred_url":"https://api.github.com/users/mixxxdj/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mixxxdj/subscriptions","organizations_url":"https://api.github.com/users/mixxxdj/orgs","repos_url":"https://api.github.com/users/mixxxdj/repos","events_url":"https://api.github.com/users/mixxxdj/events{/privacy}","received_events_url":"https://api.github.com/users/mixxxdj/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mixxxdj/mixxx","description":"Mixxx is Free DJ software that gives you everything you need to perform live mixes.","fork":false,"url":"https://api.github.com/repos/mixxxdj/mixxx","forks_url":"https://api.github.com/repos/mixxxdj/mixxx/forks","keys_url":"https://api.github.com/repos/mixxxdj/mixxx/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mixxxdj/mixxx/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mixxxdj/mixxx/teams","hooks_url":"https://api.github.com/repos/mixxxdj/mixxx/hooks","issue_events_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/events{/number}","events_url":"https://api.github.com/repos/mixxxdj/mixxx/events","assignees_url":"https://api.github.com/repos/mixxxdj/mixxx/assignees{/user}","branches_url":"https://api.github.com/repos/mixxxdj/mixxx/branches{/branch}","tags_url":"https://api.github.com/repos/mixxxdj/mixxx/tags","blobs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mixxxdj/mixxx/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mixxxdj/mixxx/git/refs{/sha}","trees_url":"https://api.github.com/repos/mixxxdj/mixxx/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mixxxdj/mixxx/statuses/{sha}","languages_url":"https://api.github.com/repos/mixxxdj/mixxx/languages","stargazers_url":"https://api.github.com/repos/mixxxdj/mixxx/stargazers","contributors_url":"https://api.github.com/repos/mixxxdj/mixxx/contributors","subscribers_url":"https://api.github.com/repos/mixxxdj/mixxx/subscribers","subscription_url":"https://api.github.com/repos/mixxxdj/mixxx/subscription","commits_url":"https://api.github.com/repos/mixxxdj/mixxx/commits{/sha}","git_commits_url":"https://api.github.com/repos/mixxxdj/mixxx/git/commits{/sha}","comments_url":"https://api.github.com/repos/mixxxdj/mixxx/comments{/number}","issue_comment_url":"https://api.github.com/repos/mixxxdj/mixxx/issues/comments{/number}","contents_url":"https://api.github.com/repos/mixxxdj/mixxx/contents/{+path}","compare_url":"https://api.github.com/repos/mixxxdj/mixxx/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mixxxdj/mixxx/merges","archive_url":"https://api.github.com/repos/mixxxdj/mixxx/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mixxxdj/mixxx/downloads","issues_url":"https://api.github.com/repos/mixxxdj/mixxx/issues{/number}","pulls_url":"https://api.github.com/repos/mixxxdj/mixxx/pulls{/number}","milestones_url":"https://api.github.com/repos/mixxxdj/mixxx/milestones{/number}","notifications_url":"https://api.github.com/repos/mixxxdj/mixxx/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mixxxdj/mixxx/labels{/name}","releases_url":"https://api.github.com/repos/mixxxdj/mixxx/releases{/id}","deployments_url":"https://api.github.com/repos/mixxxdj/mixxx/deployments","created_at":"2013-05-17T15:14:38Z","updated_at":"2018-04-26T13:55:19Z","pushed_at":"2018-04-26T17:48:20Z","git_url":"git://github.com/mixxxdj/mixxx.git","ssh_url":"git@github.com:mixxxdj/mixxx.git","clone_url":"https://github.com/mixxxdj/mixxx.git","svn_url":"https://github.com/mixxxdj/mixxx","homepage":"http://mixxx.org","size":289340,"stargazers_count":1001,"watchers_count":1001,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":502,"mirror_url":null,"archived":false,"open_issues_count":65,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":502,"open_issues":65,"watchers":1001,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1652"},"html":{"href":"https://github.com/mixxxdj/mixxx/pull/1652"},"issue":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1652"},"comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/issues/1652/comments"},"review_comments":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1652/comments"},"review_comment":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mixxxdj/mixxx/pulls/1652/commits"},"statuses":{"href":"https://api.github.com/repos/mixxxdj/mixxx/statuses/9c658a054b0741c9e69f1cd9d665c2e816896dce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"daschuer"}}