{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/24376","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/24376/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/24376/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/24376/events","html_url":"https://github.com/nodejs/node/pull/24376","id":380999891,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMxMDY4MzM2","number":24376,"title":"test: skip test that use --tls-v1.x flags","user":{"login":"danbev","id":432351,"node_id":"MDQ6VXNlcjQzMjM1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/432351?v=4","gravatar_id":"","url":"https://api.github.com/users/danbev","html_url":"https://github.com/danbev","followers_url":"https://api.github.com/users/danbev/followers","following_url":"https://api.github.com/users/danbev/following{/other_user}","gists_url":"https://api.github.com/users/danbev/gists{/gist_id}","starred_url":"https://api.github.com/users/danbev/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danbev/subscriptions","organizations_url":"https://api.github.com/users/danbev/orgs","repos_url":"https://api.github.com/users/danbev/repos","events_url":"https://api.github.com/users/danbev/events{/privacy}","received_events_url":"https://api.github.com/users/danbev/received_events","type":"User","site_admin":false},"labels":[{"id":176240519,"node_id":"MDU6TGFiZWwxNzYyNDA1MTk=","url":"https://api.github.com/repos/nodejs/node/labels/test","name":"test","color":"990099","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-11-15T04:54:10Z","updated_at":"2018-11-15T05:00:01Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/24376","html_url":"https://github.com/nodejs/node/pull/24376","diff_url":"https://github.com/nodejs/node/pull/24376.diff","patch_url":"https://github.com/nodejs/node/pull/24376.patch"},"body":"Currently, configuring `--without-ssl` will cause the following test to\r\nfail:\r\n```console\r\n=== release test-https-agent-additional-options ===\r\nPath: parallel/test-https-agent-additional-options\r\nout/Release/node: bad option: --tls-v1.1\r\nCommand: out/Release/node --tls-v1.1\r\n  /node/test/parallel/test-https-agent-additional-options.js\r\n```\r\n```console\r\n=== release test-https-agent-session-eviction ===\r\nPath: parallel/test-https-agent-session-eviction\r\nout/Release/node: bad option: --tls-v1.0\r\n\r\nCommand: out/Release/node --tls-v1.0\r\n  /node/test/parallel/test-https-agent-session-eviction.js\r\n```\r\nThis commit adds a check for the `--tls-v.x` flags and skips them if node\r\nwas built without crypto support.\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/438918083","html_url":"https://github.com/nodejs/node/pull/24376#issuecomment-438918083","issue_url":"https://api.github.com/repos/nodejs/node/issues/24376","id":438918083,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODkxODA4Mw==","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"created_at":"2018-11-15T05:00:01Z","updated_at":"2018-11-15T05:00:01Z","author_association":"MEMBER","body":"@danbev could you open an issues is nodejs/build for us to add a jub that builds `--withou-ssl`, please?"}}
{"actor":{"display_login":"refack"}}