{"action":"created","comment":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/170196059","pull_request_review_id":98845498,"id":170196059,"diff_hunk":"@@ -25,50 +25,40 @@\n import re\n \n import codecs\n+from tempfile import TemporaryFile\n from fs.opener import fsopen\n+from inspirehep.utils.url import copy_file\n \n \n RE_ALPHANUMERIC = re.compile('\\W+', re.UNICODE)\n \n \n class KbWriter(object):\n-    def __init__(self, kb_path, batch_size=1000):\n+    def __init__(self, kb_path):\n         self.kb_path = kb_path\n-        self.data_buffer = []\n-        self.batch_size = batch_size\n+        self.local_file = TemporaryFile(prefix='inspire')","path":"inspirehep/modules/refextract/utils.py","position":18,"original_position":18,"commit_id":"c952408555dd347becc37d308778e89f1d975da8","original_commit_id":"c952408555dd347becc37d308778e89f1d975da8","user":{"login":"david-caro","id":587148,"avatar_url":"https://avatars1.githubusercontent.com/u/587148?v=4","gravatar_id":"","url":"https://api.github.com/users/david-caro","html_url":"https://github.com/david-caro","followers_url":"https://api.github.com/users/david-caro/followers","following_url":"https://api.github.com/users/david-caro/following{/other_user}","gists_url":"https://api.github.com/users/david-caro/gists{/gist_id}","starred_url":"https://api.github.com/users/david-caro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/david-caro/subscriptions","organizations_url":"https://api.github.com/users/david-caro/orgs","repos_url":"https://api.github.com/users/david-caro/repos","events_url":"https://api.github.com/users/david-caro/events{/privacy}","received_events_url":"https://api.github.com/users/david-caro/received_events","type":"User","site_admin":false},"body":"Shouldn't this be in the __enter__ one?","created_at":"2018-02-23T08:56:02Z","updated_at":"2018-02-23T08:56:02Z","html_url":"https://github.com/inspirehep/inspire-next/pull/3205#discussion_r170196059","pull_request_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3205","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments/170196059"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/3205#discussion_r170196059"},"pull_request":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3205"}}},"pull_request":{"url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3205","id":170770029,"html_url":"https://github.com/inspirehep/inspire-next/pull/3205","diff_url":"https://github.com/inspirehep/inspire-next/pull/3205.diff","patch_url":"https://github.com/inspirehep/inspire-next/pull/3205.patch","issue_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/3205","number":3205,"state":"open","locked":false,"title":"refextract: correctly generate journal KB","user":{"login":"michamos","id":2895793,"avatar_url":"https://avatars3.githubusercontent.com/u/2895793?v=4","gravatar_id":"","url":"https://api.github.com/users/michamos","html_url":"https://github.com/michamos","followers_url":"https://api.github.com/users/michamos/followers","following_url":"https://api.github.com/users/michamos/following{/other_user}","gists_url":"https://api.github.com/users/michamos/gists{/gist_id}","starred_url":"https://api.github.com/users/michamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michamos/subscriptions","organizations_url":"https://api.github.com/users/michamos/orgs","repos_url":"https://api.github.com/users/michamos/repos","events_url":"https://api.github.com/users/michamos/events{/privacy}","received_events_url":"https://api.github.com/users/michamos/received_events","type":"User","site_admin":false},"body":"## Description\r\n<!--- Describe your changes in detail -->\r\n* Previously, the journal knowledge base file was opened in write mode\r\ninstead of append, which resulted in new writes overwriting previous\r\nones instead of being appended to them.\r\n\r\n## Related Issue\r\n<!--- If suggesting a new feature or change, please discuss it in an issue first -->\r\n<!--- If fixing a bug, there should be an issue describing it with steps to reproduce -->\r\n<!--- Please link to the issue here: -->\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have all the information that I need (if not, move to `RFC` and look for it).\r\n- [x] I linked the related issue(s) in the corresponding commit logs.\r\n- [x] I wrote [good commit log messages](https://github.com/torvalds/subsurface-for-dirk/blob/5f15ad5a86ada3c5e574041a5f9d85235322dabb/README#L92-L119).\r\n- [x] My code follows the code style of this project.\r\n- [x] I've added any new docs if API/utils methods were added.\r\n- [x] I have updated the existing documentation accordingly.\r\n- [x] I have added tests to cover my changes.\r\n- [x] All new and existing tests passed.\r\n<!--- After this you can move the PR to `Needs Review` -->\r\n","created_at":"2018-02-22T14:46:45Z","updated_at":"2018-02-23T08:56:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"466faa3819370ce8bdf18925b1f025f5f6297e9c","assignee":{"login":"michamos","id":2895793,"avatar_url":"https://avatars3.githubusercontent.com/u/2895793?v=4","gravatar_id":"","url":"https://api.github.com/users/michamos","html_url":"https://github.com/michamos","followers_url":"https://api.github.com/users/michamos/followers","following_url":"https://api.github.com/users/michamos/following{/other_user}","gists_url":"https://api.github.com/users/michamos/gists{/gist_id}","starred_url":"https://api.github.com/users/michamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michamos/subscriptions","organizations_url":"https://api.github.com/users/michamos/orgs","repos_url":"https://api.github.com/users/michamos/repos","events_url":"https://api.github.com/users/michamos/events{/privacy}","received_events_url":"https://api.github.com/users/michamos/received_events","type":"User","site_admin":false},"assignees":[{"login":"michamos","id":2895793,"avatar_url":"https://avatars3.githubusercontent.com/u/2895793?v=4","gravatar_id":"","url":"https://api.github.com/users/michamos","html_url":"https://github.com/michamos","followers_url":"https://api.github.com/users/michamos/followers","following_url":"https://api.github.com/users/michamos/following{/other_user}","gists_url":"https://api.github.com/users/michamos/gists{/gist_id}","starred_url":"https://api.github.com/users/michamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michamos/subscriptions","organizations_url":"https://api.github.com/users/michamos/orgs","repos_url":"https://api.github.com/users/michamos/repos","events_url":"https://api.github.com/users/michamos/events{/privacy}","received_events_url":"https://api.github.com/users/michamos/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":828440238,"url":"https://api.github.com/repos/inspirehep/inspire-next/labels/Review:%20Ready%20for%20Review","name":"Review: Ready for Review","color":"75b1b8","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3205/commits","review_comments_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3205/comments","review_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/3205/comments","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/c952408555dd347becc37d308778e89f1d975da8","head":{"label":"michamos:fix-refextract-kb-generation","ref":"fix-refextract-kb-generation","sha":"c952408555dd347becc37d308778e89f1d975da8","user":{"login":"michamos","id":2895793,"avatar_url":"https://avatars3.githubusercontent.com/u/2895793?v=4","gravatar_id":"","url":"https://api.github.com/users/michamos","html_url":"https://github.com/michamos","followers_url":"https://api.github.com/users/michamos/followers","following_url":"https://api.github.com/users/michamos/following{/other_user}","gists_url":"https://api.github.com/users/michamos/gists{/gist_id}","starred_url":"https://api.github.com/users/michamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michamos/subscriptions","organizations_url":"https://api.github.com/users/michamos/orgs","repos_url":"https://api.github.com/users/michamos/repos","events_url":"https://api.github.com/users/michamos/events{/privacy}","received_events_url":"https://api.github.com/users/michamos/received_events","type":"User","site_admin":false},"repo":{"id":80839279,"name":"inspire-next","full_name":"michamos/inspire-next","owner":{"login":"michamos","id":2895793,"avatar_url":"https://avatars3.githubusercontent.com/u/2895793?v=4","gravatar_id":"","url":"https://api.github.com/users/michamos","html_url":"https://github.com/michamos","followers_url":"https://api.github.com/users/michamos/followers","following_url":"https://api.github.com/users/michamos/following{/other_user}","gists_url":"https://api.github.com/users/michamos/gists{/gist_id}","starred_url":"https://api.github.com/users/michamos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michamos/subscriptions","organizations_url":"https://api.github.com/users/michamos/orgs","repos_url":"https://api.github.com/users/michamos/repos","events_url":"https://api.github.com/users/michamos/events{/privacy}","received_events_url":"https://api.github.com/users/michamos/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/michamos/inspire-next","description":"The next version of INSPIRE","fork":true,"url":"https://api.github.com/repos/michamos/inspire-next","forks_url":"https://api.github.com/repos/michamos/inspire-next/forks","keys_url":"https://api.github.com/repos/michamos/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/michamos/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/michamos/inspire-next/teams","hooks_url":"https://api.github.com/repos/michamos/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/michamos/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/michamos/inspire-next/events","assignees_url":"https://api.github.com/repos/michamos/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/michamos/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/michamos/inspire-next/tags","blobs_url":"https://api.github.com/repos/michamos/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/michamos/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/michamos/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/michamos/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/michamos/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/michamos/inspire-next/languages","stargazers_url":"https://api.github.com/repos/michamos/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/michamos/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/michamos/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/michamos/inspire-next/subscription","commits_url":"https://api.github.com/repos/michamos/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/michamos/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/michamos/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/michamos/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/michamos/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/michamos/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/michamos/inspire-next/merges","archive_url":"https://api.github.com/repos/michamos/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/michamos/inspire-next/downloads","issues_url":"https://api.github.com/repos/michamos/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/michamos/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/michamos/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/michamos/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/michamos/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/michamos/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/michamos/inspire-next/deployments","created_at":"2017-02-03T15:03:12Z","updated_at":"2017-02-03T15:03:15Z","pushed_at":"2018-02-22T16:07:07Z","git_url":"git://github.com/michamos/inspire-next.git","ssh_url":"git@github.com:michamos/inspire-next.git","clone_url":"https://github.com/michamos/inspire-next.git","svn_url":"https://github.com/michamos/inspire-next","homepage":"https://labs.inspirehep.net","size":71481,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"inspirehep:master","ref":"master","sha":"0697c7fbc72b8acff7421b71d9fa505c4d64bb10","user":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"repo":{"id":15221515,"name":"inspire-next","full_name":"inspirehep/inspire-next","owner":{"login":"inspirehep","id":356664,"avatar_url":"https://avatars3.githubusercontent.com/u/356664?v=4","gravatar_id":"","url":"https://api.github.com/users/inspirehep","html_url":"https://github.com/inspirehep","followers_url":"https://api.github.com/users/inspirehep/followers","following_url":"https://api.github.com/users/inspirehep/following{/other_user}","gists_url":"https://api.github.com/users/inspirehep/gists{/gist_id}","starred_url":"https://api.github.com/users/inspirehep/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/inspirehep/subscriptions","organizations_url":"https://api.github.com/users/inspirehep/orgs","repos_url":"https://api.github.com/users/inspirehep/repos","events_url":"https://api.github.com/users/inspirehep/events{/privacy}","received_events_url":"https://api.github.com/users/inspirehep/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/inspirehep/inspire-next","description":"The next version of INSPIRE","fork":false,"url":"https://api.github.com/repos/inspirehep/inspire-next","forks_url":"https://api.github.com/repos/inspirehep/inspire-next/forks","keys_url":"https://api.github.com/repos/inspirehep/inspire-next/keys{/key_id}","collaborators_url":"https://api.github.com/repos/inspirehep/inspire-next/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/inspirehep/inspire-next/teams","hooks_url":"https://api.github.com/repos/inspirehep/inspire-next/hooks","issue_events_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/events{/number}","events_url":"https://api.github.com/repos/inspirehep/inspire-next/events","assignees_url":"https://api.github.com/repos/inspirehep/inspire-next/assignees{/user}","branches_url":"https://api.github.com/repos/inspirehep/inspire-next/branches{/branch}","tags_url":"https://api.github.com/repos/inspirehep/inspire-next/tags","blobs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/inspirehep/inspire-next/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/inspirehep/inspire-next/git/refs{/sha}","trees_url":"https://api.github.com/repos/inspirehep/inspire-next/git/trees{/sha}","statuses_url":"https://api.github.com/repos/inspirehep/inspire-next/statuses/{sha}","languages_url":"https://api.github.com/repos/inspirehep/inspire-next/languages","stargazers_url":"https://api.github.com/repos/inspirehep/inspire-next/stargazers","contributors_url":"https://api.github.com/repos/inspirehep/inspire-next/contributors","subscribers_url":"https://api.github.com/repos/inspirehep/inspire-next/subscribers","subscription_url":"https://api.github.com/repos/inspirehep/inspire-next/subscription","commits_url":"https://api.github.com/repos/inspirehep/inspire-next/commits{/sha}","git_commits_url":"https://api.github.com/repos/inspirehep/inspire-next/git/commits{/sha}","comments_url":"https://api.github.com/repos/inspirehep/inspire-next/comments{/number}","issue_comment_url":"https://api.github.com/repos/inspirehep/inspire-next/issues/comments{/number}","contents_url":"https://api.github.com/repos/inspirehep/inspire-next/contents/{+path}","compare_url":"https://api.github.com/repos/inspirehep/inspire-next/compare/{base}...{head}","merges_url":"https://api.github.com/repos/inspirehep/inspire-next/merges","archive_url":"https://api.github.com/repos/inspirehep/inspire-next/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/inspirehep/inspire-next/downloads","issues_url":"https://api.github.com/repos/inspirehep/inspire-next/issues{/number}","pulls_url":"https://api.github.com/repos/inspirehep/inspire-next/pulls{/number}","milestones_url":"https://api.github.com/repos/inspirehep/inspire-next/milestones{/number}","notifications_url":"https://api.github.com/repos/inspirehep/inspire-next/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/inspirehep/inspire-next/labels{/name}","releases_url":"https://api.github.com/repos/inspirehep/inspire-next/releases{/id}","deployments_url":"https://api.github.com/repos/inspirehep/inspire-next/deployments","created_at":"2013-12-16T09:11:58Z","updated_at":"2018-02-19T12:20:36Z","pushed_at":"2018-02-22T17:48:14Z","git_url":"git://github.com/inspirehep/inspire-next.git","ssh_url":"git@github.com:inspirehep/inspire-next.git","clone_url":"https://github.com/inspirehep/inspire-next.git","svn_url":"https://github.com/inspirehep/inspire-next","homepage":"https://labs.inspirehep.net","size":73919,"stargazers_count":32,"watchers_count":32,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":51,"mirror_url":null,"archived":false,"open_issues_count":245,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":51,"open_issues":245,"watchers":32,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3205"},"html":{"href":"https://github.com/inspirehep/inspire-next/pull/3205"},"issue":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/3205"},"comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/issues/3205/comments"},"review_comments":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3205/comments"},"review_comment":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/inspirehep/inspire-next/pulls/3205/commits"},"statuses":{"href":"https://api.github.com/repos/inspirehep/inspire-next/statuses/c952408555dd347becc37d308778e89f1d975da8"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"david-caro"}}