{"action":"opened","number":162,"pull_request":{"url":"https://api.github.com/repos/aurelia/dependency-injection/pulls/162","id":188989626,"html_url":"https://github.com/aurelia/dependency-injection/pull/162","diff_url":"https://github.com/aurelia/dependency-injection/pull/162.diff","patch_url":"https://github.com/aurelia/dependency-injection/pull/162.patch","issue_url":"https://api.github.com/repos/aurelia/dependency-injection/issues/162","number":162,"state":"open","locked":false,"title":"Fixing parameter decorators","user":{"login":"doktordirk","id":13430091,"avatar_url":"https://avatars1.githubusercontent.com/u/13430091?v=4","gravatar_id":"","url":"https://api.github.com/users/doktordirk","html_url":"https://github.com/doktordirk","followers_url":"https://api.github.com/users/doktordirk/followers","following_url":"https://api.github.com/users/doktordirk/following{/other_user}","gists_url":"https://api.github.com/users/doktordirk/gists{/gist_id}","starred_url":"https://api.github.com/users/doktordirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doktordirk/subscriptions","organizations_url":"https://api.github.com/users/doktordirk/orgs","repos_url":"https://api.github.com/users/doktordirk/repos","events_url":"https://api.github.com/users/doktordirk/events{/privacy}","received_events_url":"https://api.github.com/users/doktordirk/received_events","type":"User","site_admin":false},"body":"The previous fix for autoinject and inheritance compared constructors parameter types with those of the inject property. That broke the  parameter decorators.\r\n\r\nThis PR reverts autoinject back to the previous index matching and just ensures that only the own property 'inject' is used for autoinject and parameter decorators to avoid the inheritance issues.\r\n\r\nIncluded are the fixed test for parameter decorators for the use with autoinject, tests for inheritance together with parameter decorators, and a test for the checkparent option of @optional","created_at":"2018-05-18T10:50:16Z","updated_at":"2018-05-18T10:50:16Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/aurelia/dependency-injection/pulls/162/commits","review_comments_url":"https://api.github.com/repos/aurelia/dependency-injection/pulls/162/comments","review_comment_url":"https://api.github.com/repos/aurelia/dependency-injection/pulls/comments{/number}","comments_url":"https://api.github.com/repos/aurelia/dependency-injection/issues/162/comments","statuses_url":"https://api.github.com/repos/aurelia/dependency-injection/statuses/724ff081217f296f1f6a8e766dbf246f33f7e2e2","head":{"label":"doktordirk:resolver-meta","ref":"resolver-meta","sha":"724ff081217f296f1f6a8e766dbf246f33f7e2e2","user":{"login":"doktordirk","id":13430091,"avatar_url":"https://avatars1.githubusercontent.com/u/13430091?v=4","gravatar_id":"","url":"https://api.github.com/users/doktordirk","html_url":"https://github.com/doktordirk","followers_url":"https://api.github.com/users/doktordirk/followers","following_url":"https://api.github.com/users/doktordirk/following{/other_user}","gists_url":"https://api.github.com/users/doktordirk/gists{/gist_id}","starred_url":"https://api.github.com/users/doktordirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doktordirk/subscriptions","organizations_url":"https://api.github.com/users/doktordirk/orgs","repos_url":"https://api.github.com/users/doktordirk/repos","events_url":"https://api.github.com/users/doktordirk/events{/privacy}","received_events_url":"https://api.github.com/users/doktordirk/received_events","type":"User","site_admin":false},"repo":{"id":57435756,"name":"dependency-injection","full_name":"doktordirk/dependency-injection","owner":{"login":"doktordirk","id":13430091,"avatar_url":"https://avatars1.githubusercontent.com/u/13430091?v=4","gravatar_id":"","url":"https://api.github.com/users/doktordirk","html_url":"https://github.com/doktordirk","followers_url":"https://api.github.com/users/doktordirk/followers","following_url":"https://api.github.com/users/doktordirk/following{/other_user}","gists_url":"https://api.github.com/users/doktordirk/gists{/gist_id}","starred_url":"https://api.github.com/users/doktordirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/doktordirk/subscriptions","organizations_url":"https://api.github.com/users/doktordirk/orgs","repos_url":"https://api.github.com/users/doktordirk/repos","events_url":"https://api.github.com/users/doktordirk/events{/privacy}","received_events_url":"https://api.github.com/users/doktordirk/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/doktordirk/dependency-injection","description":"A lightweight,  extensible dependency injection container for JavaScript.","fork":true,"url":"https://api.github.com/repos/doktordirk/dependency-injection","forks_url":"https://api.github.com/repos/doktordirk/dependency-injection/forks","keys_url":"https://api.github.com/repos/doktordirk/dependency-injection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/doktordirk/dependency-injection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/doktordirk/dependency-injection/teams","hooks_url":"https://api.github.com/repos/doktordirk/dependency-injection/hooks","issue_events_url":"https://api.github.com/repos/doktordirk/dependency-injection/issues/events{/number}","events_url":"https://api.github.com/repos/doktordirk/dependency-injection/events","assignees_url":"https://api.github.com/repos/doktordirk/dependency-injection/assignees{/user}","branches_url":"https://api.github.com/repos/doktordirk/dependency-injection/branches{/branch}","tags_url":"https://api.github.com/repos/doktordirk/dependency-injection/tags","blobs_url":"https://api.github.com/repos/doktordirk/dependency-injection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/doktordirk/dependency-injection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/doktordirk/dependency-injection/git/refs{/sha}","trees_url":"https://api.github.com/repos/doktordirk/dependency-injection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/doktordirk/dependency-injection/statuses/{sha}","languages_url":"https://api.github.com/repos/doktordirk/dependency-injection/languages","stargazers_url":"https://api.github.com/repos/doktordirk/dependency-injection/stargazers","contributors_url":"https://api.github.com/repos/doktordirk/dependency-injection/contributors","subscribers_url":"https://api.github.com/repos/doktordirk/dependency-injection/subscribers","subscription_url":"https://api.github.com/repos/doktordirk/dependency-injection/subscription","commits_url":"https://api.github.com/repos/doktordirk/dependency-injection/commits{/sha}","git_commits_url":"https://api.github.com/repos/doktordirk/dependency-injection/git/commits{/sha}","comments_url":"https://api.github.com/repos/doktordirk/dependency-injection/comments{/number}","issue_comment_url":"https://api.github.com/repos/doktordirk/dependency-injection/issues/comments{/number}","contents_url":"https://api.github.com/repos/doktordirk/dependency-injection/contents/{+path}","compare_url":"https://api.github.com/repos/doktordirk/dependency-injection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/doktordirk/dependency-injection/merges","archive_url":"https://api.github.com/repos/doktordirk/dependency-injection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/doktordirk/dependency-injection/downloads","issues_url":"https://api.github.com/repos/doktordirk/dependency-injection/issues{/number}","pulls_url":"https://api.github.com/repos/doktordirk/dependency-injection/pulls{/number}","milestones_url":"https://api.github.com/repos/doktordirk/dependency-injection/milestones{/number}","notifications_url":"https://api.github.com/repos/doktordirk/dependency-injection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/doktordirk/dependency-injection/labels{/name}","releases_url":"https://api.github.com/repos/doktordirk/dependency-injection/releases{/id}","deployments_url":"https://api.github.com/repos/doktordirk/dependency-injection/deployments","created_at":"2016-04-30T09:35:31Z","updated_at":"2018-04-29T09:03:27Z","pushed_at":"2018-05-18T10:38:13Z","git_url":"git://github.com/doktordirk/dependency-injection.git","ssh_url":"git@github.com:doktordirk/dependency-injection.git","clone_url":"https://github.com/doktordirk/dependency-injection.git","svn_url":"https://github.com/doktordirk/dependency-injection","homepage":null,"size":774,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"aurelia:master","ref":"master","sha":"6b8ab445423c379726084b0584f704fa05e51780","user":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"repo":{"id":27728611,"name":"dependency-injection","full_name":"aurelia/dependency-injection","owner":{"login":"aurelia","id":9808864,"avatar_url":"https://avatars1.githubusercontent.com/u/9808864?v=4","gravatar_id":"","url":"https://api.github.com/users/aurelia","html_url":"https://github.com/aurelia","followers_url":"https://api.github.com/users/aurelia/followers","following_url":"https://api.github.com/users/aurelia/following{/other_user}","gists_url":"https://api.github.com/users/aurelia/gists{/gist_id}","starred_url":"https://api.github.com/users/aurelia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aurelia/subscriptions","organizations_url":"https://api.github.com/users/aurelia/orgs","repos_url":"https://api.github.com/users/aurelia/repos","events_url":"https://api.github.com/users/aurelia/events{/privacy}","received_events_url":"https://api.github.com/users/aurelia/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/aurelia/dependency-injection","description":"A lightweight,  extensible dependency injection container for JavaScript.","fork":false,"url":"https://api.github.com/repos/aurelia/dependency-injection","forks_url":"https://api.github.com/repos/aurelia/dependency-injection/forks","keys_url":"https://api.github.com/repos/aurelia/dependency-injection/keys{/key_id}","collaborators_url":"https://api.github.com/repos/aurelia/dependency-injection/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/aurelia/dependency-injection/teams","hooks_url":"https://api.github.com/repos/aurelia/dependency-injection/hooks","issue_events_url":"https://api.github.com/repos/aurelia/dependency-injection/issues/events{/number}","events_url":"https://api.github.com/repos/aurelia/dependency-injection/events","assignees_url":"https://api.github.com/repos/aurelia/dependency-injection/assignees{/user}","branches_url":"https://api.github.com/repos/aurelia/dependency-injection/branches{/branch}","tags_url":"https://api.github.com/repos/aurelia/dependency-injection/tags","blobs_url":"https://api.github.com/repos/aurelia/dependency-injection/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/aurelia/dependency-injection/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/aurelia/dependency-injection/git/refs{/sha}","trees_url":"https://api.github.com/repos/aurelia/dependency-injection/git/trees{/sha}","statuses_url":"https://api.github.com/repos/aurelia/dependency-injection/statuses/{sha}","languages_url":"https://api.github.com/repos/aurelia/dependency-injection/languages","stargazers_url":"https://api.github.com/repos/aurelia/dependency-injection/stargazers","contributors_url":"https://api.github.com/repos/aurelia/dependency-injection/contributors","subscribers_url":"https://api.github.com/repos/aurelia/dependency-injection/subscribers","subscription_url":"https://api.github.com/repos/aurelia/dependency-injection/subscription","commits_url":"https://api.github.com/repos/aurelia/dependency-injection/commits{/sha}","git_commits_url":"https://api.github.com/repos/aurelia/dependency-injection/git/commits{/sha}","comments_url":"https://api.github.com/repos/aurelia/dependency-injection/comments{/number}","issue_comment_url":"https://api.github.com/repos/aurelia/dependency-injection/issues/comments{/number}","contents_url":"https://api.github.com/repos/aurelia/dependency-injection/contents/{+path}","compare_url":"https://api.github.com/repos/aurelia/dependency-injection/compare/{base}...{head}","merges_url":"https://api.github.com/repos/aurelia/dependency-injection/merges","archive_url":"https://api.github.com/repos/aurelia/dependency-injection/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/aurelia/dependency-injection/downloads","issues_url":"https://api.github.com/repos/aurelia/dependency-injection/issues{/number}","pulls_url":"https://api.github.com/repos/aurelia/dependency-injection/pulls{/number}","milestones_url":"https://api.github.com/repos/aurelia/dependency-injection/milestones{/number}","notifications_url":"https://api.github.com/repos/aurelia/dependency-injection/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/aurelia/dependency-injection/labels{/name}","releases_url":"https://api.github.com/repos/aurelia/dependency-injection/releases{/id}","deployments_url":"https://api.github.com/repos/aurelia/dependency-injection/deployments","created_at":"2014-12-08T18:28:11Z","updated_at":"2018-05-14T03:59:34Z","pushed_at":"2018-05-16T14:48:24Z","git_url":"git://github.com/aurelia/dependency-injection.git","ssh_url":"git@github.com:aurelia/dependency-injection.git","clone_url":"https://github.com/aurelia/dependency-injection.git","svn_url":"https://github.com/aurelia/dependency-injection","homepage":null,"size":769,"stargazers_count":143,"watchers_count":143,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":60,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":60,"open_issues":9,"watchers":143,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/aurelia/dependency-injection/pulls/162"},"html":{"href":"https://github.com/aurelia/dependency-injection/pull/162"},"issue":{"href":"https://api.github.com/repos/aurelia/dependency-injection/issues/162"},"comments":{"href":"https://api.github.com/repos/aurelia/dependency-injection/issues/162/comments"},"review_comments":{"href":"https://api.github.com/repos/aurelia/dependency-injection/pulls/162/comments"},"review_comment":{"href":"https://api.github.com/repos/aurelia/dependency-injection/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/aurelia/dependency-injection/pulls/162/commits"},"statuses":{"href":"https://api.github.com/repos/aurelia/dependency-injection/statuses/724ff081217f296f1f6a8e766dbf246f33f7e2e2"}},"author_association":"CONTRIBUTOR","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":true,"commits":1,"additions":251,"deletions":40,"changed_files":3}}
{"actor":{"display_login":"doktordirk"}}