{"action":"created","issue":{"url":"https://api.github.com/repos/TestRunnerSRL/OoT-Randomizer/issues/16","repository_url":"https://api.github.com/repos/TestRunnerSRL/OoT-Randomizer","labels_url":"https://api.github.com/repos/TestRunnerSRL/OoT-Randomizer/issues/16/labels{/name}","comments_url":"https://api.github.com/repos/TestRunnerSRL/OoT-Randomizer/issues/16/comments","events_url":"https://api.github.com/repos/TestRunnerSRL/OoT-Randomizer/issues/16/events","html_url":"https://github.com/TestRunnerSRL/OoT-Randomizer/pull/16","id":347745805,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2MjY2OTMy","number":16,"title":"Fix for reverting Zelda's Letter","user":{"login":"scattertv","id":24556079,"node_id":"MDQ6VXNlcjI0NTU2MDc5","avatar_url":"https://avatars0.githubusercontent.com/u/24556079?v=4","gravatar_id":"","url":"https://api.github.com/users/scattertv","html_url":"https://github.com/scattertv","followers_url":"https://api.github.com/users/scattertv/followers","following_url":"https://api.github.com/users/scattertv/following{/other_user}","gists_url":"https://api.github.com/users/scattertv/gists{/gist_id}","starred_url":"https://api.github.com/users/scattertv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scattertv/subscriptions","organizations_url":"https://api.github.com/users/scattertv/orgs","repos_url":"https://api.github.com/users/scattertv/repos","events_url":"https://api.github.com/users/scattertv/events{/privacy}","received_events_url":"https://api.github.com/users/scattertv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-08-06T00:38:42Z","updated_at":"2018-08-06T18:15:18Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/TestRunnerSRL/OoT-Randomizer/pulls/16","html_url":"https://github.com/TestRunnerSRL/OoT-Randomizer/pull/16","diff_url":"https://github.com/TestRunnerSRL/OoT-Randomizer/pull/16.diff","patch_url":"https://github.com/TestRunnerSRL/OoT-Randomizer/pull/16.patch"},"body":"This PR fixes the issue of Zelda's Letter reverting to a Chicken, even after talking to Impa.\r\n\r\nThe vanilla game checks that Zelda's Lullaby is in your inventory when saving and resetting after receiving Zelda's Letter. If it isn't, the letter reverts to a Chicken and the \"talked to Zelda in courtyard\" flag resets (preventing learning Saria's Song as well). The randomizer changes this to check for the song you learned from Impa instead, by simply changing the song that it checks for.\r\n\r\nSongsanity changes the check \"song learned from Impa is in the inventory\" to \"talked to Impa in the courtyard\". Obviously this is because Impa will not necessarily teach a song. However, the change is reverted to check for \"song learned from Impa\" if Songsanity is not enabled. The value telling the code which song to check for is not changed in this branch, so it will always check for Zelda's Lullaby. This change simply removes the reversion so that the Impa flag is always checked, even if Songsanity is not selected.\r\n\r\nAlso removes the vanilla check for Saria's Song to learn Song From Saria, keeping the check for the flag even outside Songsanity."},"comment":{"url":"https://api.github.com/repos/TestRunnerSRL/OoT-Randomizer/issues/comments/410801853","html_url":"https://github.com/TestRunnerSRL/OoT-Randomizer/pull/16#issuecomment-410801853","issue_url":"https://api.github.com/repos/TestRunnerSRL/OoT-Randomizer/issues/16","id":410801853,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDgwMTg1Mw==","user":{"login":"TestRunnerSRL","id":9971110,"node_id":"MDQ6VXNlcjk5NzExMTA=","avatar_url":"https://avatars2.githubusercontent.com/u/9971110?v=4","gravatar_id":"","url":"https://api.github.com/users/TestRunnerSRL","html_url":"https://github.com/TestRunnerSRL","followers_url":"https://api.github.com/users/TestRunnerSRL/followers","following_url":"https://api.github.com/users/TestRunnerSRL/following{/other_user}","gists_url":"https://api.github.com/users/TestRunnerSRL/gists{/gist_id}","starred_url":"https://api.github.com/users/TestRunnerSRL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TestRunnerSRL/subscriptions","organizations_url":"https://api.github.com/users/TestRunnerSRL/orgs","repos_url":"https://api.github.com/users/TestRunnerSRL/repos","events_url":"https://api.github.com/users/TestRunnerSRL/events{/privacy}","received_events_url":"https://api.github.com/users/TestRunnerSRL/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T18:15:18Z","updated_at":"2018-08-06T18:15:18Z","author_association":"OWNER","body":"The code in 2.0 changed the songs you were given and the song that is checked for in every song location. Making it use other flags is better, but was a more complicated solution to implement. I'd've made it do it that way everywhere, but the way I've implemented some of these checks also give you an item at the same time, so they had to be reverted. The changes shouldn't actually make it vanilla, since the changes for which song to check should still exist (later in the file). Not sure if there is some code conflict somewhere, but if this works then I'll merge it in anyways"}}
{"actor":{"display_login":"TestRunnerSRL"}}