{"action":"created","comment":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/232437457","pull_request_review_id":173645530,"id":232437457,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjQzNzQ1Nw==","diff_hunk":"@@ -208,6 +233,30 @@ void AP_LandingGear::update()\n         \n         gear_state_current = gear_state_new;\n     }\n+\n+    /*\n+      check for height based triggering\n+     */\n+    int16_t alt_m = constrain_int16(height_above_ground_m, 0, INT16_MAX);","path":"libraries/AP_LandingGear/AP_LandingGear.cpp","position":102,"original_position":70,"commit_id":"fef6e7332e02292ee2558661a618313ee1477938","original_commit_id":"d18afc96805d774fdc37167487acd4127b510c09","user":{"login":"tridge","id":831867,"node_id":"MDQ6VXNlcjgzMTg2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"body":"because I deliberately want the integer rounding, so even if the user sets the two alt values the same they get a 1m hysterisis, which prevents it oscillating","created_at":"2018-11-10T02:06:45Z","updated_at":"2018-11-10T02:06:45Z","html_url":"https://github.com/ArduPilot/ardupilot/pull/9735#discussion_r232437457","pull_request_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9735","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments/232437457"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/9735#discussion_r232437457"},"pull_request":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9735"}},"in_reply_to_id":232231742},"pull_request":{"url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9735","id":229587559,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NTg3NTU5","html_url":"https://github.com/ArduPilot/ardupilot/pull/9735","diff_url":"https://github.com/ArduPilot/ardupilot/pull/9735.diff","patch_url":"https://github.com/ArduPilot/ardupilot/pull/9735.patch","issue_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9735","number":9735,"state":"open","locked":false,"title":"Added height based landing gear triggering","user":{"login":"tridge","id":831867,"node_id":"MDQ6VXNlcjgzMTg2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"body":"This allows landing gear to be retracted and deployed using height above ground\r\n\r\nThis also removes the PWM values in the landing gear library and uses MIN/MAX/REVERSED from the servo. That makes it usable with more than one set of landing gear.","created_at":"2018-11-09T04:49:06Z","updated_at":"2018-11-10T02:06:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1869b9e8173352e6a07fb25a24644bd7b3030ec","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":24269224,"node_id":"MDU6TGFiZWwyNDI2OTIyNA==","url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/Copter","name":"Copter","color":"02e10c","default":false},{"id":24269267,"node_id":"MDU6TGFiZWwyNDI2OTI2Nw==","url":"https://api.github.com/repos/ArduPilot/ardupilot/labels/Plane","name":"Plane","color":"d7e102","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9735/commits","review_comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9735/comments","review_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9735/comments","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/fef6e7332e02292ee2558661a618313ee1477938","head":{"label":"tridge:pr-lgear-alt","ref":"pr-lgear-alt","sha":"fef6e7332e02292ee2558661a618313ee1477938","user":{"login":"tridge","id":831867,"node_id":"MDQ6VXNlcjgzMTg2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"repo":{"id":7513848,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEzODQ4","name":"ardupilot","full_name":"tridge/ardupilot","private":false,"owner":{"login":"tridge","id":831867,"node_id":"MDQ6VXNlcjgzMTg2Nw==","avatar_url":"https://avatars2.githubusercontent.com/u/831867?v=4","gravatar_id":"","url":"https://api.github.com/users/tridge","html_url":"https://github.com/tridge","followers_url":"https://api.github.com/users/tridge/followers","following_url":"https://api.github.com/users/tridge/following{/other_user}","gists_url":"https://api.github.com/users/tridge/gists{/gist_id}","starred_url":"https://api.github.com/users/tridge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tridge/subscriptions","organizations_url":"https://api.github.com/users/tridge/orgs","repos_url":"https://api.github.com/users/tridge/repos","events_url":"https://api.github.com/users/tridge/events{/privacy}","received_events_url":"https://api.github.com/users/tridge/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tridge/ardupilot","description":null,"fork":true,"url":"https://api.github.com/repos/tridge/ardupilot","forks_url":"https://api.github.com/repos/tridge/ardupilot/forks","keys_url":"https://api.github.com/repos/tridge/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tridge/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tridge/ardupilot/teams","hooks_url":"https://api.github.com/repos/tridge/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/tridge/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/tridge/ardupilot/events","assignees_url":"https://api.github.com/repos/tridge/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/tridge/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/tridge/ardupilot/tags","blobs_url":"https://api.github.com/repos/tridge/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tridge/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tridge/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/tridge/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tridge/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/tridge/ardupilot/languages","stargazers_url":"https://api.github.com/repos/tridge/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/tridge/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/tridge/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/tridge/ardupilot/subscription","commits_url":"https://api.github.com/repos/tridge/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/tridge/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/tridge/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/tridge/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/tridge/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/tridge/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tridge/ardupilot/merges","archive_url":"https://api.github.com/repos/tridge/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tridge/ardupilot/downloads","issues_url":"https://api.github.com/repos/tridge/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/tridge/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/tridge/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/tridge/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tridge/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/tridge/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/tridge/ardupilot/deployments","created_at":"2013-01-09T02:57:15Z","updated_at":"2018-10-31T20:49:17Z","pushed_at":"2018-11-10T02:05:08Z","git_url":"git://github.com/tridge/ardupilot.git","ssh_url":"git@github.com:tridge/ardupilot.git","clone_url":"https://github.com/tridge/ardupilot.git","svn_url":"https://github.com/tridge/ardupilot","homepage":null,"size":126753,"stargazers_count":22,"watchers_count":22,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":9,"open_issues":1,"watchers":22,"default_branch":"master"}},"base":{"label":"ArduPilot:master","ref":"master","sha":"c0af0cfe70a8a102b1d7dfa436a46d7c32039ce3","user":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"repo":{"id":7512484,"node_id":"MDEwOlJlcG9zaXRvcnk3NTEyNDg0","name":"ardupilot","full_name":"ArduPilot/ardupilot","private":false,"owner":{"login":"ArduPilot","id":17919847,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3OTE5ODQ3","avatar_url":"https://avatars3.githubusercontent.com/u/17919847?v=4","gravatar_id":"","url":"https://api.github.com/users/ArduPilot","html_url":"https://github.com/ArduPilot","followers_url":"https://api.github.com/users/ArduPilot/followers","following_url":"https://api.github.com/users/ArduPilot/following{/other_user}","gists_url":"https://api.github.com/users/ArduPilot/gists{/gist_id}","starred_url":"https://api.github.com/users/ArduPilot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ArduPilot/subscriptions","organizations_url":"https://api.github.com/users/ArduPilot/orgs","repos_url":"https://api.github.com/users/ArduPilot/repos","events_url":"https://api.github.com/users/ArduPilot/events{/privacy}","received_events_url":"https://api.github.com/users/ArduPilot/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/ArduPilot/ardupilot","description":"ArduPlane, ArduCopter, ArduRover source","fork":false,"url":"https://api.github.com/repos/ArduPilot/ardupilot","forks_url":"https://api.github.com/repos/ArduPilot/ardupilot/forks","keys_url":"https://api.github.com/repos/ArduPilot/ardupilot/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ArduPilot/ardupilot/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ArduPilot/ardupilot/teams","hooks_url":"https://api.github.com/repos/ArduPilot/ardupilot/hooks","issue_events_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/events{/number}","events_url":"https://api.github.com/repos/ArduPilot/ardupilot/events","assignees_url":"https://api.github.com/repos/ArduPilot/ardupilot/assignees{/user}","branches_url":"https://api.github.com/repos/ArduPilot/ardupilot/branches{/branch}","tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/tags","blobs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/refs{/sha}","trees_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/{sha}","languages_url":"https://api.github.com/repos/ArduPilot/ardupilot/languages","stargazers_url":"https://api.github.com/repos/ArduPilot/ardupilot/stargazers","contributors_url":"https://api.github.com/repos/ArduPilot/ardupilot/contributors","subscribers_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscribers","subscription_url":"https://api.github.com/repos/ArduPilot/ardupilot/subscription","commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/commits{/sha}","git_commits_url":"https://api.github.com/repos/ArduPilot/ardupilot/git/commits{/sha}","comments_url":"https://api.github.com/repos/ArduPilot/ardupilot/comments{/number}","issue_comment_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues/comments{/number}","contents_url":"https://api.github.com/repos/ArduPilot/ardupilot/contents/{+path}","compare_url":"https://api.github.com/repos/ArduPilot/ardupilot/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ArduPilot/ardupilot/merges","archive_url":"https://api.github.com/repos/ArduPilot/ardupilot/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ArduPilot/ardupilot/downloads","issues_url":"https://api.github.com/repos/ArduPilot/ardupilot/issues{/number}","pulls_url":"https://api.github.com/repos/ArduPilot/ardupilot/pulls{/number}","milestones_url":"https://api.github.com/repos/ArduPilot/ardupilot/milestones{/number}","notifications_url":"https://api.github.com/repos/ArduPilot/ardupilot/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ArduPilot/ardupilot/labels{/name}","releases_url":"https://api.github.com/repos/ArduPilot/ardupilot/releases{/id}","deployments_url":"https://api.github.com/repos/ArduPilot/ardupilot/deployments","created_at":"2013-01-09T00:58:52Z","updated_at":"2018-11-10T01:22:24Z","pushed_at":"2018-11-10T02:05:25Z","git_url":"git://github.com/ArduPilot/ardupilot.git","ssh_url":"git@github.com:ArduPilot/ardupilot.git","clone_url":"https://github.com/ArduPilot/ardupilot.git","svn_url":"https://github.com/ArduPilot/ardupilot","homepage":"http://ardupilot.org/","size":115865,"stargazers_count":3573,"watchers_count":3573,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7102,"mirror_url":null,"archived":false,"open_issues_count":1314,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":7102,"open_issues":1314,"watchers":3573,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9735"},"html":{"href":"https://github.com/ArduPilot/ardupilot/pull/9735"},"issue":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9735"},"comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/issues/9735/comments"},"review_comments":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9735/comments"},"review_comment":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/pulls/9735/commits"},"statuses":{"href":"https://api.github.com/repos/ArduPilot/ardupilot/statuses/fef6e7332e02292ee2558661a618313ee1477938"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tridge"}}