{"action":"created","issue":{"url":"https://api.github.com/repos/openfaas/faas-netes/issues/318","repository_url":"https://api.github.com/repos/openfaas/faas-netes","labels_url":"https://api.github.com/repos/openfaas/faas-netes/issues/318/labels{/name}","comments_url":"https://api.github.com/repos/openfaas/faas-netes/issues/318/comments","events_url":"https://api.github.com/repos/openfaas/faas-netes/issues/318/events","html_url":"https://github.com/openfaas/faas-netes/pull/318","id":379456004,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5OTEwMDI3","number":318,"title":"Add nats.enableMonitoring chart configuration","user":{"login":"LucasRoesler","id":891889,"node_id":"MDQ6VXNlcjg5MTg4OQ==","avatar_url":"https://avatars1.githubusercontent.com/u/891889?v=4","gravatar_id":"","url":"https://api.github.com/users/LucasRoesler","html_url":"https://github.com/LucasRoesler","followers_url":"https://api.github.com/users/LucasRoesler/followers","following_url":"https://api.github.com/users/LucasRoesler/following{/other_user}","gists_url":"https://api.github.com/users/LucasRoesler/gists{/gist_id}","starred_url":"https://api.github.com/users/LucasRoesler/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucasRoesler/subscriptions","organizations_url":"https://api.github.com/users/LucasRoesler/orgs","repos_url":"https://api.github.com/users/LucasRoesler/repos","events_url":"https://api.github.com/users/LucasRoesler/events{/privacy}","received_events_url":"https://api.github.com/users/LucasRoesler/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-11-10T19:58:46Z","updated_at":"2018-11-11T12:32:55Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/openfaas/faas-netes/pulls/318","html_url":"https://github.com/openfaas/faas-netes/pull/318","diff_url":"https://github.com/openfaas/faas-netes/pull/318.diff","patch_url":"https://github.com/openfaas/faas-netes/pull/318.patch"},"body":"## Description\r\n- Add `nats.enableMonitoring` to the helm chart\r\n- Expose the nats monitoring port at `8222` when the\r\n`nats.enableMonitoring=true`\r\n- The port is disabled by default\r\n\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\n- [X] I have raised an issue to propose this change ([required](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md))\r\n\r\nClosed #315 \r\n\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nDeployed to my local k8s cluster using helm in three ways\r\n\r\n1) deplay without any values override\r\n2) upgrade the deployment in (1) with an override to set `nats.enableMonitoring=true`\r\n3) upgrade the deployment in (2) to set  `nats.enableMonitoring=false`\r\n\r\nIn each case I then used `kubectl` to request the Deployment and the Service for the nats component and verified that the 8222 port was enabled or disabled as appropriate to the setting. When the port was enabled, tested the endpoint via curl, as described in https://nats.io/documentation/tutorials/nats-monitoring/\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [ ] Bug fix (non-breaking change which fixes an issue)\r\n- [X] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [X] My code follows the code style of this project.\r\n- [X] My change requires a change to the documentation.\r\n- [X] I have updated the documentation accordingly.\r\n- [X] I've read the [CONTRIBUTION](https://github.com/openfaas/faas/blob/master/CONTRIBUTING.md) guide\r\n- [X] I have signed-off my commits with `git commit -s`\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n"},"comment":{"url":"https://api.github.com/repos/openfaas/faas-netes/issues/comments/437666445","html_url":"https://github.com/openfaas/faas-netes/pull/318#issuecomment-437666445","issue_url":"https://api.github.com/repos/openfaas/faas-netes/issues/318","id":437666445,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzY2NjQ0NQ==","user":{"login":"alexellis","id":6358735,"node_id":"MDQ6VXNlcjYzNTg3MzU=","avatar_url":"https://avatars1.githubusercontent.com/u/6358735?v=4","gravatar_id":"","url":"https://api.github.com/users/alexellis","html_url":"https://github.com/alexellis","followers_url":"https://api.github.com/users/alexellis/followers","following_url":"https://api.github.com/users/alexellis/following{/other_user}","gists_url":"https://api.github.com/users/alexellis/gists{/gist_id}","starred_url":"https://api.github.com/users/alexellis/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alexellis/subscriptions","organizations_url":"https://api.github.com/users/alexellis/orgs","repos_url":"https://api.github.com/users/alexellis/repos","events_url":"https://api.github.com/users/alexellis/events{/privacy}","received_events_url":"https://api.github.com/users/alexellis/received_events","type":"User","site_admin":false},"created_at":"2018-11-11T12:32:55Z","updated_at":"2018-11-11T12:32:55Z","author_association":"MEMBER","body":"Review requested, please feel free to ping reviewer if you don't get an answer in a few days."}}
{"actor":{"display_login":"alexellis"}}