{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/comments/229892714","pull_request_review_id":170502224,"id":229892714,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyOTg5MjcxNA==","diff_hunk":"@@ -49,12 +49,15 @@ Along with the above, the controller also...\n   recover if the controller were to be restarted.\n \n ### Ingress Traffic\n-\n-This section details how traffic reaches the cluster.\n-\n-As seen above, the ingress traffic for controller-managed resources starts at the ALB and reaches the Kubernetes nodes through each service's NodePort. This means that\n-services referenced from ingress resource must be exposed on a node port in order to be\n-reached by the ALB.\n+ALB Ingress controller supports two traffic mode:","path":"docs/README.md","position":10,"original_position":10,"commit_id":"f5fc786c41be659efa84ae19bd42be3c83f64c80","original_commit_id":"f5fc786c41be659efa84ae19bd42be3c83f64c80","user":{"login":"bigkraig","id":508403,"node_id":"MDQ6VXNlcjUwODQwMw==","avatar_url":"https://avatars1.githubusercontent.com/u/508403?v=4","gravatar_id":"","url":"https://api.github.com/users/bigkraig","html_url":"https://github.com/bigkraig","followers_url":"https://api.github.com/users/bigkraig/followers","following_url":"https://api.github.com/users/bigkraig/following{/other_user}","gists_url":"https://api.github.com/users/bigkraig/gists{/gist_id}","starred_url":"https://api.github.com/users/bigkraig/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bigkraig/subscriptions","organizations_url":"https://api.github.com/users/bigkraig/orgs","repos_url":"https://api.github.com/users/bigkraig/repos","events_url":"https://api.github.com/users/bigkraig/events{/privacy}","received_events_url":"https://api.github.com/users/bigkraig/received_events","type":"User","site_admin":false},"body":"s/mode/modes/","created_at":"2018-10-31T22:45:12Z","updated_at":"2018-10-31T22:45:12Z","html_url":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller/pull/709#discussion_r229892714","pull_request_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/709","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/comments/229892714"},"html":{"href":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller/pull/709#discussion_r229892714"},"pull_request":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/709"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/709","id":227449150,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3NDQ5MTUw","html_url":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller/pull/709","diff_url":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller/pull/709.diff","patch_url":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller/pull/709.patch","issue_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/issues/709","number":709,"state":"open","locked":false,"title":"Modifications to docs","user":{"login":"M00nF1sh","id":40677631,"node_id":"MDQ6VXNlcjQwNjc3NjMx","avatar_url":"https://avatars0.githubusercontent.com/u/40677631?v=4","gravatar_id":"","url":"https://api.github.com/users/M00nF1sh","html_url":"https://github.com/M00nF1sh","followers_url":"https://api.github.com/users/M00nF1sh/followers","following_url":"https://api.github.com/users/M00nF1sh/following{/other_user}","gists_url":"https://api.github.com/users/M00nF1sh/gists{/gist_id}","starred_url":"https://api.github.com/users/M00nF1sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M00nF1sh/subscriptions","organizations_url":"https://api.github.com/users/M00nF1sh/orgs","repos_url":"https://api.github.com/users/M00nF1sh/repos","events_url":"https://api.github.com/users/M00nF1sh/events{/privacy}","received_events_url":"https://api.github.com/users/M00nF1sh/received_events","type":"User","site_admin":false},"body":"1. Adding new architecture digram(including IP mode)\r\n2. Adding rough introduction for IP mode\r\n3. Fix broken links in doc","created_at":"2018-10-31T21:33:55Z","updated_at":"2018-10-31T22:45:12Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0f59793f3b5bf4667ef66777f008f5ef19655e63","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":959249505,"node_id":"MDU6TGFiZWw5NTkyNDk1MDU=","url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/labels/approved","name":"approved","color":"0ffa16","default":false},{"id":959251099,"node_id":"MDU6TGFiZWw5NTkyNTEwOTk=","url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":959251764,"node_id":"MDU6TGFiZWw5NTkyNTE3NjQ=","url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/709/commits","review_comments_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/709/comments","review_comment_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/issues/709/comments","statuses_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/statuses/f5fc786c41be659efa84ae19bd42be3c83f64c80","head":{"label":"M00nF1sh:fix-doc","ref":"fix-doc","sha":"f5fc786c41be659efa84ae19bd42be3c83f64c80","user":{"login":"M00nF1sh","id":40677631,"node_id":"MDQ6VXNlcjQwNjc3NjMx","avatar_url":"https://avatars0.githubusercontent.com/u/40677631?v=4","gravatar_id":"","url":"https://api.github.com/users/M00nF1sh","html_url":"https://github.com/M00nF1sh","followers_url":"https://api.github.com/users/M00nF1sh/followers","following_url":"https://api.github.com/users/M00nF1sh/following{/other_user}","gists_url":"https://api.github.com/users/M00nF1sh/gists{/gist_id}","starred_url":"https://api.github.com/users/M00nF1sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M00nF1sh/subscriptions","organizations_url":"https://api.github.com/users/M00nF1sh/orgs","repos_url":"https://api.github.com/users/M00nF1sh/repos","events_url":"https://api.github.com/users/M00nF1sh/events{/privacy}","received_events_url":"https://api.github.com/users/M00nF1sh/received_events","type":"User","site_admin":false},"repo":{"id":151170128,"node_id":"MDEwOlJlcG9zaXRvcnkxNTExNzAxMjg=","name":"aws-alb-ingress-controller","full_name":"M00nF1sh/aws-alb-ingress-controller","private":false,"owner":{"login":"M00nF1sh","id":40677631,"node_id":"MDQ6VXNlcjQwNjc3NjMx","avatar_url":"https://avatars0.githubusercontent.com/u/40677631?v=4","gravatar_id":"","url":"https://api.github.com/users/M00nF1sh","html_url":"https://github.com/M00nF1sh","followers_url":"https://api.github.com/users/M00nF1sh/followers","following_url":"https://api.github.com/users/M00nF1sh/following{/other_user}","gists_url":"https://api.github.com/users/M00nF1sh/gists{/gist_id}","starred_url":"https://api.github.com/users/M00nF1sh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/M00nF1sh/subscriptions","organizations_url":"https://api.github.com/users/M00nF1sh/orgs","repos_url":"https://api.github.com/users/M00nF1sh/repos","events_url":"https://api.github.com/users/M00nF1sh/events{/privacy}","received_events_url":"https://api.github.com/users/M00nF1sh/received_events","type":"User","site_admin":false},"html_url":"https://github.com/M00nF1sh/aws-alb-ingress-controller","description":"AWS ALB Ingress Controller for Kubernetes","fork":true,"url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller","forks_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/forks","keys_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/teams","hooks_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/hooks","issue_events_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/issues/events{/number}","events_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/events","assignees_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/assignees{/user}","branches_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/branches{/branch}","tags_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/tags","blobs_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/languages","stargazers_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/stargazers","contributors_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/contributors","subscribers_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/subscribers","subscription_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/subscription","commits_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/contents/{+path}","compare_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/merges","archive_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/downloads","issues_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/issues{/number}","pulls_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/labels{/name}","releases_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/releases{/id}","deployments_url":"https://api.github.com/repos/M00nF1sh/aws-alb-ingress-controller/deployments","created_at":"2018-10-01T22:39:18Z","updated_at":"2018-10-31T21:22:17Z","pushed_at":"2018-10-31T21:32:55Z","git_url":"git://github.com/M00nF1sh/aws-alb-ingress-controller.git","ssh_url":"git@github.com:M00nF1sh/aws-alb-ingress-controller.git","clone_url":"https://github.com/M00nF1sh/aws-alb-ingress-controller.git","svn_url":"https://github.com/M00nF1sh/aws-alb-ingress-controller","homepage":"https://aws.amazon.com/blogs/apn/coreos-and-ticketmaster-collaborate-to-bring-aws-application-load-balancer-support-to-kubernetes/","size":124167,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes-sigs:master","ref":"master","sha":"ef9f48dc64122e8ec6aa9f79ed01bf4b01352344","user":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"repo":{"id":84610043,"node_id":"MDEwOlJlcG9zaXRvcnk4NDYxMDA0Mw==","name":"aws-alb-ingress-controller","full_name":"kubernetes-sigs/aws-alb-ingress-controller","private":false,"owner":{"login":"kubernetes-sigs","id":36015203,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2MDE1MjAz","avatar_url":"https://avatars1.githubusercontent.com/u/36015203?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes-sigs","html_url":"https://github.com/kubernetes-sigs","followers_url":"https://api.github.com/users/kubernetes-sigs/followers","following_url":"https://api.github.com/users/kubernetes-sigs/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes-sigs/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes-sigs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes-sigs/subscriptions","organizations_url":"https://api.github.com/users/kubernetes-sigs/orgs","repos_url":"https://api.github.com/users/kubernetes-sigs/repos","events_url":"https://api.github.com/users/kubernetes-sigs/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes-sigs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller","description":"AWS ALB Ingress Controller for Kubernetes","fork":false,"url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller","forks_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/forks","keys_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/teams","hooks_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/hooks","issue_events_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/events","assignees_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/tags","blobs_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/languages","stargazers_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/stargazers","contributors_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/contributors","subscribers_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/subscribers","subscription_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/subscription","commits_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/merges","archive_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/downloads","issues_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/deployments","created_at":"2017-03-10T23:45:09Z","updated_at":"2018-10-31T19:30:32Z","pushed_at":"2018-10-31T21:33:55Z","git_url":"git://github.com/kubernetes-sigs/aws-alb-ingress-controller.git","ssh_url":"git@github.com:kubernetes-sigs/aws-alb-ingress-controller.git","clone_url":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller.git","svn_url":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller","homepage":"https://aws.amazon.com/blogs/apn/coreos-and-ticketmaster-collaborate-to-bring-aws-application-load-balancer-support-to-kubernetes/","size":124105,"stargazers_count":691,"watchers_count":691,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":233,"mirror_url":null,"archived":false,"open_issues_count":52,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":233,"open_issues":52,"watchers":691,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/709"},"html":{"href":"https://github.com/kubernetes-sigs/aws-alb-ingress-controller/pull/709"},"issue":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/issues/709"},"comments":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/issues/709/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/709/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/pulls/709/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes-sigs/aws-alb-ingress-controller/statuses/f5fc786c41be659efa84ae19bd42be3c83f64c80"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"bigkraig"}}