{"action":"created","issue":{"url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-dotnet/issues/48","repository_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-dotnet","labels_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-dotnet/issues/48/labels{/name}","comments_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-dotnet/issues/48/comments","events_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-dotnet/issues/48/events","html_url":"https://github.com/IOT-DSA/sdk-dslink-dotnet/issues/48","id":353014193,"node_id":"MDU6SXNzdWUzNTMwMTQxOTM=","number":48,"title":"Connector should not use System.Net.WebSocket methods","user":{"login":"mbreissi","id":15672247,"node_id":"MDQ6VXNlcjE1NjcyMjQ3","avatar_url":"https://avatars1.githubusercontent.com/u/15672247?v=4","gravatar_id":"","url":"https://api.github.com/users/mbreissi","html_url":"https://github.com/mbreissi","followers_url":"https://api.github.com/users/mbreissi/followers","following_url":"https://api.github.com/users/mbreissi/following{/other_user}","gists_url":"https://api.github.com/users/mbreissi/gists{/gist_id}","starred_url":"https://api.github.com/users/mbreissi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mbreissi/subscriptions","organizations_url":"https://api.github.com/users/mbreissi/orgs","repos_url":"https://api.github.com/users/mbreissi/repos","events_url":"https://api.github.com/users/mbreissi/events{/privacy}","received_events_url":"https://api.github.com/users/mbreissi/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-22T15:45:47Z","updated_at":"2018-08-24T05:34:59Z","closed_at":"2018-08-24T05:34:59Z","author_association":"NONE","body":"Currently, the Write methods catches WebSocketException, breaking the protocol independence of the Connector class.  It appears that the catch block is unnecessary as web socket exceptions are caught in the descendant class (WebSocketBaseConnector), making this dependence unnecessary.  Consider either: (1) removing the try/catch block; or (2) catching a more generic Exception that is not protocol specific."},"comment":{"url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-dotnet/issues/comments/415656055","html_url":"https://github.com/IOT-DSA/sdk-dslink-dotnet/issues/48#issuecomment-415656055","issue_url":"https://api.github.com/repos/IOT-DSA/sdk-dslink-dotnet/issues/48","id":415656055,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNTY1NjA1NQ==","user":{"login":"logangorence","id":1173922,"node_id":"MDQ6VXNlcjExNzM5MjI=","avatar_url":"https://avatars3.githubusercontent.com/u/1173922?v=4","gravatar_id":"","url":"https://api.github.com/users/logangorence","html_url":"https://github.com/logangorence","followers_url":"https://api.github.com/users/logangorence/followers","following_url":"https://api.github.com/users/logangorence/following{/other_user}","gists_url":"https://api.github.com/users/logangorence/gists{/gist_id}","starred_url":"https://api.github.com/users/logangorence/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/logangorence/subscriptions","organizations_url":"https://api.github.com/users/logangorence/orgs","repos_url":"https://api.github.com/users/logangorence/repos","events_url":"https://api.github.com/users/logangorence/events{/privacy}","received_events_url":"https://api.github.com/users/logangorence/received_events","type":"User","site_admin":false},"created_at":"2018-08-24T05:34:59Z","updated_at":"2018-08-24T05:34:59Z","author_association":"COLLABORATOR","body":"This is fixed via #49."}}
{"actor":{"display_login":"logangorence"}}