{"action":"created","comment":{"url":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/comments/166739458","pull_request_review_id":94851678,"id":166739458,"diff_hunk":"@@ -215,7 +202,23 @@ contract AuctionBase is Pausable {\n   /// @dev Returns true if the NFT is on auction.\n   /// @param _auction - Auction to check.\n   function _isActive(Auction storage _auction) internal view returns (bool) {\n-    return (_auction.startedAt > 0);\n+    return (_auction.startedAt > 0 && !_auction.cancelled && _getAuctionEndAt(_auction) <= now);\n+  }\n+\n+  function _isEnded(Auction storage _auction) internal view returns (bool) {","path":"contracts/AuctionBase.sol","position":161,"original_position":161,"commit_id":"5b905c1d8d8ab525326e0c80a7ff201afb7f4bc3","original_commit_id":"5b905c1d8d8ab525326e0c80a7ff201afb7f4bc3","user":{"login":"mertcelebi","id":2692053,"avatar_url":"https://avatars0.githubusercontent.com/u/2692053?v=4","gravatar_id":"","url":"https://api.github.com/users/mertcelebi","html_url":"https://github.com/mertcelebi","followers_url":"https://api.github.com/users/mertcelebi/followers","following_url":"https://api.github.com/users/mertcelebi/following{/other_user}","gists_url":"https://api.github.com/users/mertcelebi/gists{/gist_id}","starred_url":"https://api.github.com/users/mertcelebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mertcelebi/subscriptions","organizations_url":"https://api.github.com/users/mertcelebi/orgs","repos_url":"https://api.github.com/users/mertcelebi/repos","events_url":"https://api.github.com/users/mertcelebi/events{/privacy}","received_events_url":"https://api.github.com/users/mertcelebi/received_events","type":"User","site_admin":false},"body":"So, it's apparently okay to use it. Using `storage` is not good. Also, using structs may sometimes cause bugs depending on the fields in the struct (a la nested structs). Regardless, I will create an issue and change this along with #17 ","created_at":"2018-02-07T20:05:50Z","updated_at":"2018-02-07T20:05:50Z","html_url":"https://github.com/hillstreetlabs/marketplace/pull/14#discussion_r166739458","pull_request_url":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/comments/166739458"},"html":{"href":"https://github.com/hillstreetlabs/marketplace/pull/14#discussion_r166739458"},"pull_request":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/14"}},"in_reply_to_id":166717850},"pull_request":{"url":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/14","id":167768481,"html_url":"https://github.com/hillstreetlabs/marketplace/pull/14","diff_url":"https://github.com/hillstreetlabs/marketplace/pull/14.diff","patch_url":"https://github.com/hillstreetlabs/marketplace/pull/14.patch","issue_url":"https://api.github.com/repos/hillstreetlabs/marketplace/issues/14","number":14,"state":"open","locked":false,"title":"Cleanup code + add duration logic","user":{"login":"mertcelebi","id":2692053,"avatar_url":"https://avatars0.githubusercontent.com/u/2692053?v=4","gravatar_id":"","url":"https://api.github.com/users/mertcelebi","html_url":"https://github.com/mertcelebi","followers_url":"https://api.github.com/users/mertcelebi/followers","following_url":"https://api.github.com/users/mertcelebi/following{/other_user}","gists_url":"https://api.github.com/users/mertcelebi/gists{/gist_id}","starred_url":"https://api.github.com/users/mertcelebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mertcelebi/subscriptions","organizations_url":"https://api.github.com/users/mertcelebi/orgs","repos_url":"https://api.github.com/users/mertcelebi/repos","events_url":"https://api.github.com/users/mertcelebi/events{/privacy}","received_events_url":"https://api.github.com/users/mertcelebi/received_events","type":"User","site_admin":false},"body":"First steps for #12 ","created_at":"2018-02-07T18:10:16Z","updated_at":"2018-02-07T20:05:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8881dcba0015c710baf38b5183863d70dec6d524","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/14/commits","review_comments_url":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/14/comments","review_comment_url":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hillstreetlabs/marketplace/issues/14/comments","statuses_url":"https://api.github.com/repos/hillstreetlabs/marketplace/statuses/5b905c1d8d8ab525326e0c80a7ff201afb7f4bc3","head":{"label":"mertcelebi:master","ref":"master","sha":"5b905c1d8d8ab525326e0c80a7ff201afb7f4bc3","user":{"login":"mertcelebi","id":2692053,"avatar_url":"https://avatars0.githubusercontent.com/u/2692053?v=4","gravatar_id":"","url":"https://api.github.com/users/mertcelebi","html_url":"https://github.com/mertcelebi","followers_url":"https://api.github.com/users/mertcelebi/followers","following_url":"https://api.github.com/users/mertcelebi/following{/other_user}","gists_url":"https://api.github.com/users/mertcelebi/gists{/gist_id}","starred_url":"https://api.github.com/users/mertcelebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mertcelebi/subscriptions","organizations_url":"https://api.github.com/users/mertcelebi/orgs","repos_url":"https://api.github.com/users/mertcelebi/repos","events_url":"https://api.github.com/users/mertcelebi/events{/privacy}","received_events_url":"https://api.github.com/users/mertcelebi/received_events","type":"User","site_admin":false},"repo":{"id":120652032,"name":"marketplace","full_name":"mertcelebi/marketplace","owner":{"login":"mertcelebi","id":2692053,"avatar_url":"https://avatars0.githubusercontent.com/u/2692053?v=4","gravatar_id":"","url":"https://api.github.com/users/mertcelebi","html_url":"https://github.com/mertcelebi","followers_url":"https://api.github.com/users/mertcelebi/followers","following_url":"https://api.github.com/users/mertcelebi/following{/other_user}","gists_url":"https://api.github.com/users/mertcelebi/gists{/gist_id}","starred_url":"https://api.github.com/users/mertcelebi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mertcelebi/subscriptions","organizations_url":"https://api.github.com/users/mertcelebi/orgs","repos_url":"https://api.github.com/users/mertcelebi/repos","events_url":"https://api.github.com/users/mertcelebi/events{/privacy}","received_events_url":"https://api.github.com/users/mertcelebi/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/mertcelebi/marketplace","description":"Bare bones auction website for crypto-collectibles 🤝","fork":true,"url":"https://api.github.com/repos/mertcelebi/marketplace","forks_url":"https://api.github.com/repos/mertcelebi/marketplace/forks","keys_url":"https://api.github.com/repos/mertcelebi/marketplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mertcelebi/marketplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mertcelebi/marketplace/teams","hooks_url":"https://api.github.com/repos/mertcelebi/marketplace/hooks","issue_events_url":"https://api.github.com/repos/mertcelebi/marketplace/issues/events{/number}","events_url":"https://api.github.com/repos/mertcelebi/marketplace/events","assignees_url":"https://api.github.com/repos/mertcelebi/marketplace/assignees{/user}","branches_url":"https://api.github.com/repos/mertcelebi/marketplace/branches{/branch}","tags_url":"https://api.github.com/repos/mertcelebi/marketplace/tags","blobs_url":"https://api.github.com/repos/mertcelebi/marketplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mertcelebi/marketplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mertcelebi/marketplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/mertcelebi/marketplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mertcelebi/marketplace/statuses/{sha}","languages_url":"https://api.github.com/repos/mertcelebi/marketplace/languages","stargazers_url":"https://api.github.com/repos/mertcelebi/marketplace/stargazers","contributors_url":"https://api.github.com/repos/mertcelebi/marketplace/contributors","subscribers_url":"https://api.github.com/repos/mertcelebi/marketplace/subscribers","subscription_url":"https://api.github.com/repos/mertcelebi/marketplace/subscription","commits_url":"https://api.github.com/repos/mertcelebi/marketplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/mertcelebi/marketplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/mertcelebi/marketplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/mertcelebi/marketplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/mertcelebi/marketplace/contents/{+path}","compare_url":"https://api.github.com/repos/mertcelebi/marketplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mertcelebi/marketplace/merges","archive_url":"https://api.github.com/repos/mertcelebi/marketplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mertcelebi/marketplace/downloads","issues_url":"https://api.github.com/repos/mertcelebi/marketplace/issues{/number}","pulls_url":"https://api.github.com/repos/mertcelebi/marketplace/pulls{/number}","milestones_url":"https://api.github.com/repos/mertcelebi/marketplace/milestones{/number}","notifications_url":"https://api.github.com/repos/mertcelebi/marketplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mertcelebi/marketplace/labels{/name}","releases_url":"https://api.github.com/repos/mertcelebi/marketplace/releases{/id}","deployments_url":"https://api.github.com/repos/mertcelebi/marketplace/deployments","created_at":"2018-02-07T18:08:27Z","updated_at":"2018-02-07T18:08:29Z","pushed_at":"2018-02-07T18:20:31Z","git_url":"git://github.com/mertcelebi/marketplace.git","ssh_url":"git@github.com:mertcelebi/marketplace.git","clone_url":"https://github.com/mertcelebi/marketplace.git","svn_url":"https://github.com/mertcelebi/marketplace","homepage":"","size":109,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"hillstreetlabs:master","ref":"master","sha":"eb4a7873b6e921d6e4558b9154027d45eef39acf","user":{"login":"hillstreetlabs","id":36055571,"avatar_url":"https://avatars3.githubusercontent.com/u/36055571?v=4","gravatar_id":"","url":"https://api.github.com/users/hillstreetlabs","html_url":"https://github.com/hillstreetlabs","followers_url":"https://api.github.com/users/hillstreetlabs/followers","following_url":"https://api.github.com/users/hillstreetlabs/following{/other_user}","gists_url":"https://api.github.com/users/hillstreetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/hillstreetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hillstreetlabs/subscriptions","organizations_url":"https://api.github.com/users/hillstreetlabs/orgs","repos_url":"https://api.github.com/users/hillstreetlabs/repos","events_url":"https://api.github.com/users/hillstreetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/hillstreetlabs/received_events","type":"Organization","site_admin":false},"repo":{"id":119900911,"name":"marketplace","full_name":"hillstreetlabs/marketplace","owner":{"login":"hillstreetlabs","id":36055571,"avatar_url":"https://avatars3.githubusercontent.com/u/36055571?v=4","gravatar_id":"","url":"https://api.github.com/users/hillstreetlabs","html_url":"https://github.com/hillstreetlabs","followers_url":"https://api.github.com/users/hillstreetlabs/followers","following_url":"https://api.github.com/users/hillstreetlabs/following{/other_user}","gists_url":"https://api.github.com/users/hillstreetlabs/gists{/gist_id}","starred_url":"https://api.github.com/users/hillstreetlabs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hillstreetlabs/subscriptions","organizations_url":"https://api.github.com/users/hillstreetlabs/orgs","repos_url":"https://api.github.com/users/hillstreetlabs/repos","events_url":"https://api.github.com/users/hillstreetlabs/events{/privacy}","received_events_url":"https://api.github.com/users/hillstreetlabs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hillstreetlabs/marketplace","description":"Bare bones auction website for crypto-collectibles 🤝","fork":false,"url":"https://api.github.com/repos/hillstreetlabs/marketplace","forks_url":"https://api.github.com/repos/hillstreetlabs/marketplace/forks","keys_url":"https://api.github.com/repos/hillstreetlabs/marketplace/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hillstreetlabs/marketplace/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hillstreetlabs/marketplace/teams","hooks_url":"https://api.github.com/repos/hillstreetlabs/marketplace/hooks","issue_events_url":"https://api.github.com/repos/hillstreetlabs/marketplace/issues/events{/number}","events_url":"https://api.github.com/repos/hillstreetlabs/marketplace/events","assignees_url":"https://api.github.com/repos/hillstreetlabs/marketplace/assignees{/user}","branches_url":"https://api.github.com/repos/hillstreetlabs/marketplace/branches{/branch}","tags_url":"https://api.github.com/repos/hillstreetlabs/marketplace/tags","blobs_url":"https://api.github.com/repos/hillstreetlabs/marketplace/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hillstreetlabs/marketplace/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hillstreetlabs/marketplace/git/refs{/sha}","trees_url":"https://api.github.com/repos/hillstreetlabs/marketplace/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hillstreetlabs/marketplace/statuses/{sha}","languages_url":"https://api.github.com/repos/hillstreetlabs/marketplace/languages","stargazers_url":"https://api.github.com/repos/hillstreetlabs/marketplace/stargazers","contributors_url":"https://api.github.com/repos/hillstreetlabs/marketplace/contributors","subscribers_url":"https://api.github.com/repos/hillstreetlabs/marketplace/subscribers","subscription_url":"https://api.github.com/repos/hillstreetlabs/marketplace/subscription","commits_url":"https://api.github.com/repos/hillstreetlabs/marketplace/commits{/sha}","git_commits_url":"https://api.github.com/repos/hillstreetlabs/marketplace/git/commits{/sha}","comments_url":"https://api.github.com/repos/hillstreetlabs/marketplace/comments{/number}","issue_comment_url":"https://api.github.com/repos/hillstreetlabs/marketplace/issues/comments{/number}","contents_url":"https://api.github.com/repos/hillstreetlabs/marketplace/contents/{+path}","compare_url":"https://api.github.com/repos/hillstreetlabs/marketplace/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hillstreetlabs/marketplace/merges","archive_url":"https://api.github.com/repos/hillstreetlabs/marketplace/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hillstreetlabs/marketplace/downloads","issues_url":"https://api.github.com/repos/hillstreetlabs/marketplace/issues{/number}","pulls_url":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls{/number}","milestones_url":"https://api.github.com/repos/hillstreetlabs/marketplace/milestones{/number}","notifications_url":"https://api.github.com/repos/hillstreetlabs/marketplace/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hillstreetlabs/marketplace/labels{/name}","releases_url":"https://api.github.com/repos/hillstreetlabs/marketplace/releases{/id}","deployments_url":"https://api.github.com/repos/hillstreetlabs/marketplace/deployments","created_at":"2018-02-01T22:22:54Z","updated_at":"2018-02-06T19:56:02Z","pushed_at":"2018-02-07T18:45:13Z","git_url":"git://github.com/hillstreetlabs/marketplace.git","ssh_url":"git@github.com:hillstreetlabs/marketplace.git","clone_url":"https://github.com/hillstreetlabs/marketplace.git","svn_url":"https://github.com/hillstreetlabs/marketplace","homepage":"","size":146,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":4,"mirror_url":null,"archived":false,"open_issues_count":8,"license":null,"forks":4,"open_issues":8,"watchers":3,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/14"},"html":{"href":"https://github.com/hillstreetlabs/marketplace/pull/14"},"issue":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/issues/14"},"comments":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/hillstreetlabs/marketplace/statuses/5b905c1d8d8ab525326e0c80a7ff201afb7f4bc3"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mertcelebi"}}