{"action":"created","issue":{"url":"https://api.github.com/repos/awakesecurity/proto3-wire/issues/46","repository_url":"https://api.github.com/repos/awakesecurity/proto3-wire","labels_url":"https://api.github.com/repos/awakesecurity/proto3-wire/issues/46/labels{/name}","comments_url":"https://api.github.com/repos/awakesecurity/proto3-wire/issues/46/comments","events_url":"https://api.github.com/repos/awakesecurity/proto3-wire/issues/46/events","html_url":"https://github.com/awakesecurity/proto3-wire/pull/46","id":371722392,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0MTA1OTIy","number":46,"title":"Optimizations for encoding and decoding","user":{"login":"gbaz","id":1125849,"node_id":"MDQ6VXNlcjExMjU4NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1125849?v=4","gravatar_id":"","url":"https://api.github.com/users/gbaz","html_url":"https://github.com/gbaz","followers_url":"https://api.github.com/users/gbaz/followers","following_url":"https://api.github.com/users/gbaz/following{/other_user}","gists_url":"https://api.github.com/users/gbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/gbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbaz/subscriptions","organizations_url":"https://api.github.com/users/gbaz/orgs","repos_url":"https://api.github.com/users/gbaz/repos","events_url":"https://api.github.com/users/gbaz/events{/privacy}","received_events_url":"https://api.github.com/users/gbaz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-18T21:32:07Z","updated_at":"2018-10-18T21:33:56Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/awakesecurity/proto3-wire/pulls/46","html_url":"https://github.com/awakesecurity/proto3-wire/pull/46","diff_url":"https://github.com/awakesecurity/proto3-wire/pull/46.diff","patch_url":"https://github.com/awakesecurity/proto3-wire/pull/46.patch"},"body":"Supersedes #45 now. Includes changes to improve decoding _and_ encoding.\r\n\r\nThis replaces decodeWire with a function that does direct parsing instead of via the cereal library. The most important element is that it also replaces the varint128 decoding with a fully unrolled version, which should greatly improve performance.\r\n\r\nOn top of that we also swap to use IntMap throughout and get rid of the Seqs for lists, which should also cut some modest overhead.\r\n\r\nOn encodings, we use unpacked constructors for the Builder which is a pair of a length and bytestring builder, and also unroll the _encoding_ of varint128s for some modest gain."},"comment":{"url":"https://api.github.com/repos/awakesecurity/proto3-wire/issues/comments/431171771","html_url":"https://github.com/awakesecurity/proto3-wire/pull/46#issuecomment-431171771","issue_url":"https://api.github.com/repos/awakesecurity/proto3-wire/issues/46","id":431171771,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTE3MTc3MQ==","user":{"login":"gbaz","id":1125849,"node_id":"MDQ6VXNlcjExMjU4NDk=","avatar_url":"https://avatars3.githubusercontent.com/u/1125849?v=4","gravatar_id":"","url":"https://api.github.com/users/gbaz","html_url":"https://github.com/gbaz","followers_url":"https://api.github.com/users/gbaz/followers","following_url":"https://api.github.com/users/gbaz/following{/other_user}","gists_url":"https://api.github.com/users/gbaz/gists{/gist_id}","starred_url":"https://api.github.com/users/gbaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gbaz/subscriptions","organizations_url":"https://api.github.com/users/gbaz/orgs","repos_url":"https://api.github.com/users/gbaz/repos","events_url":"https://api.github.com/users/gbaz/events{/privacy}","received_events_url":"https://api.github.com/users/gbaz/received_events","type":"User","site_admin":false},"created_at":"2018-10-18T21:33:56Z","updated_at":"2018-10-18T21:33:56Z","author_association":"COLLABORATOR","body":"All the decode stuff has been through review. Relevant tests are passing. After we're confident in the encoding stuff I'd like to merge."}}
{"actor":{"display_login":"gbaz"}}