{"action":"created","comment":{"url":"https://api.github.com/repos/andela/wg-aces/pulls/comments/211928543","pull_request_review_id":148450082,"id":211928543,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTkyODU0Mw==","diff_hunk":"@@ -59,7 +59,8 @@\n \n # Configure a real backend in production\n if DEBUG:\n-    EMAIL_BACKEND = 'django.core.mail.backends.console.EmailBackend'\n+    EMAIL_BACKEND = os.environ.get('EMAIL_BACKEND',","path":"settings.py","position":5,"original_position":5,"commit_id":"8d5759d2f33e8aaf1db6760153b8dec575331153","original_commit_id":"8d5759d2f33e8aaf1db6760153b8dec575331153","user":{"login":"isheebo","id":29917291,"node_id":"MDQ6VXNlcjI5OTE3Mjkx","avatar_url":"https://avatars3.githubusercontent.com/u/29917291?v=4","gravatar_id":"","url":"https://api.github.com/users/isheebo","html_url":"https://github.com/isheebo","followers_url":"https://api.github.com/users/isheebo/followers","following_url":"https://api.github.com/users/isheebo/following{/other_user}","gists_url":"https://api.github.com/users/isheebo/gists{/gist_id}","starred_url":"https://api.github.com/users/isheebo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/isheebo/subscriptions","organizations_url":"https://api.github.com/users/isheebo/orgs","repos_url":"https://api.github.com/users/isheebo/repos","events_url":"https://api.github.com/users/isheebo/events{/privacy}","received_events_url":"https://api.github.com/users/isheebo/received_events","type":"User","site_admin":false},"body":"remove the #noqa\r\n```\r\nif DEBUG:\r\n    EMAIL_BACKEND = os.environ.get(\r\n        'EMAIL_BACKEND',\r\n        'django.core.mail.backends.console.EmailBackend'\r\n    )\r\n```","created_at":"2018-08-22T12:04:51Z","updated_at":"2018-08-22T12:04:51Z","html_url":"https://github.com/andela/wg-aces/pull/32#discussion_r211928543","pull_request_url":"https://api.github.com/repos/andela/wg-aces/pulls/32","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/andela/wg-aces/pulls/comments/211928543"},"html":{"href":"https://github.com/andela/wg-aces/pull/32#discussion_r211928543"},"pull_request":{"href":"https://api.github.com/repos/andela/wg-aces/pulls/32"}}},"pull_request":{"url":"https://api.github.com/repos/andela/wg-aces/pulls/32","id":209361682,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA5MzYxNjgy","html_url":"https://github.com/andela/wg-aces/pull/32","diff_url":"https://github.com/andela/wg-aces/pull/32.diff","patch_url":"https://github.com/andela/wg-aces/pull/32.patch","issue_url":"https://api.github.com/repos/andela/wg-aces/issues/32","number":32,"state":"open","locked":false,"title":"#159728034 Plain text passwords should not be visible","user":{"login":"Jpkat92","id":4680759,"node_id":"MDQ6VXNlcjQ2ODA3NTk=","avatar_url":"https://avatars2.githubusercontent.com/u/4680759?v=4","gravatar_id":"","url":"https://api.github.com/users/Jpkat92","html_url":"https://github.com/Jpkat92","followers_url":"https://api.github.com/users/Jpkat92/followers","following_url":"https://api.github.com/users/Jpkat92/following{/other_user}","gists_url":"https://api.github.com/users/Jpkat92/gists{/gist_id}","starred_url":"https://api.github.com/users/Jpkat92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Jpkat92/subscriptions","organizations_url":"https://api.github.com/users/Jpkat92/orgs","repos_url":"https://api.github.com/users/Jpkat92/repos","events_url":"https://api.github.com/users/Jpkat92/events{/privacy}","received_events_url":"https://api.github.com/users/Jpkat92/received_events","type":"User","site_admin":false},"body":"#### What does this PR do?\r\nIt makes passwords of new users invisible to administrators. Instead, new users should receive their passwords via email\r\n\r\n#### Description of Task to be completed?\r\nAs part of the task, passwords for new users in the dashboard should be hidden from administrators\r\nThe system should send an email to the newly created user's email with a password\r\n\r\n#### How should this be manually tested?;\r\n- Clone repository by running `git clone -b ch-make-user-passwords-invisible-159728034 https://github.com/andela/wg-aces.git` in your terminal\r\n- Run `pip install -r requirements.txt` to install necessary project dependencies\r\n- Enter the command `./manage.py runserver` to launch the application \r\n- Login with the `Administrator` account or any account that has permissions to add a user to a gym\r\n- Access `Gyms` under the `Administrator` dropdown menu on the right\r\n- Add a new user to any existing gym, you may create a new gym if none exists\r\n- On creation of new user, password is sent to the email provided and should not be displayed to an administrator\r\n\r\n#### What are the relevant pivotal tracker stories?\r\n[#159728034](https://www.pivotaltracker.com/story/show/159728034)\r\n\r\n#### Screenshots\r\n- Confirmation page for adding new user\r\n<img width=\"1291\" alt=\"screen shot 2018-08-22 at 13 16 22\" src=\"https://user-images.githubusercontent.com/4680759/44458058-ac483880-a60d-11e8-87b0-243ea88e0c51.png\">\r\n\r\n\r\n- Register Page indicating entry of an email as compulsory\r\n<img width=\"1080\" alt=\"screen shot 2018-08-22 at 11 32 07\" src=\"https://user-images.githubusercontent.com/4680759/44452461-42289700-a5ff-11e8-98a1-ffb7cab3a9a3.png\">\r\n\r\n\r\n","created_at":"2018-08-19T14:02:31Z","updated_at":"2018-08-22T12:04:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"5d8fc13a82553ae2a529f1d02363fd7b6d0a69a4","assignee":null,"assignees":[],"requested_reviewers":[{"login":"mutebironald","id":39955301,"node_id":"MDQ6VXNlcjM5OTU1MzAx","avatar_url":"https://avatars1.githubusercontent.com/u/39955301?v=4","gravatar_id":"","url":"https://api.github.com/users/mutebironald","html_url":"https://github.com/mutebironald","followers_url":"https://api.github.com/users/mutebironald/followers","following_url":"https://api.github.com/users/mutebironald/following{/other_user}","gists_url":"https://api.github.com/users/mutebironald/gists{/gist_id}","starred_url":"https://api.github.com/users/mutebironald/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mutebironald/subscriptions","organizations_url":"https://api.github.com/users/mutebironald/orgs","repos_url":"https://api.github.com/users/mutebironald/repos","events_url":"https://api.github.com/users/mutebironald/events{/privacy}","received_events_url":"https://api.github.com/users/mutebironald/received_events","type":"User","site_admin":false},{"login":"archbishop12","id":39958516,"node_id":"MDQ6VXNlcjM5OTU4NTE2","avatar_url":"https://avatars3.githubusercontent.com/u/39958516?v=4","gravatar_id":"","url":"https://api.github.com/users/archbishop12","html_url":"https://github.com/archbishop12","followers_url":"https://api.github.com/users/archbishop12/followers","following_url":"https://api.github.com/users/archbishop12/following{/other_user}","gists_url":"https://api.github.com/users/archbishop12/gists{/gist_id}","starred_url":"https://api.github.com/users/archbishop12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/archbishop12/subscriptions","organizations_url":"https://api.github.com/users/archbishop12/orgs","repos_url":"https://api.github.com/users/archbishop12/repos","events_url":"https://api.github.com/users/archbishop12/events{/privacy}","received_events_url":"https://api.github.com/users/archbishop12/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/andela/wg-aces/pulls/32/commits","review_comments_url":"https://api.github.com/repos/andela/wg-aces/pulls/32/comments","review_comment_url":"https://api.github.com/repos/andela/wg-aces/pulls/comments{/number}","comments_url":"https://api.github.com/repos/andela/wg-aces/issues/32/comments","statuses_url":"https://api.github.com/repos/andela/wg-aces/statuses/8d5759d2f33e8aaf1db6760153b8dec575331153","head":{"label":"andela:ch-make-user-passwords-invisible-159728034","ref":"ch-make-user-passwords-invisible-159728034","sha":"8d5759d2f33e8aaf1db6760153b8dec575331153","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":142039112,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwMzkxMTI=","name":"wg-aces","full_name":"andela/wg-aces","owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/wg-aces","description":null,"fork":false,"url":"https://api.github.com/repos/andela/wg-aces","forks_url":"https://api.github.com/repos/andela/wg-aces/forks","keys_url":"https://api.github.com/repos/andela/wg-aces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/wg-aces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/wg-aces/teams","hooks_url":"https://api.github.com/repos/andela/wg-aces/hooks","issue_events_url":"https://api.github.com/repos/andela/wg-aces/issues/events{/number}","events_url":"https://api.github.com/repos/andela/wg-aces/events","assignees_url":"https://api.github.com/repos/andela/wg-aces/assignees{/user}","branches_url":"https://api.github.com/repos/andela/wg-aces/branches{/branch}","tags_url":"https://api.github.com/repos/andela/wg-aces/tags","blobs_url":"https://api.github.com/repos/andela/wg-aces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/wg-aces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/wg-aces/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/wg-aces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/wg-aces/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/wg-aces/languages","stargazers_url":"https://api.github.com/repos/andela/wg-aces/stargazers","contributors_url":"https://api.github.com/repos/andela/wg-aces/contributors","subscribers_url":"https://api.github.com/repos/andela/wg-aces/subscribers","subscription_url":"https://api.github.com/repos/andela/wg-aces/subscription","commits_url":"https://api.github.com/repos/andela/wg-aces/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/wg-aces/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/wg-aces/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/wg-aces/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/wg-aces/contents/{+path}","compare_url":"https://api.github.com/repos/andela/wg-aces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/wg-aces/merges","archive_url":"https://api.github.com/repos/andela/wg-aces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/wg-aces/downloads","issues_url":"https://api.github.com/repos/andela/wg-aces/issues{/number}","pulls_url":"https://api.github.com/repos/andela/wg-aces/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/wg-aces/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/wg-aces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/wg-aces/labels{/name}","releases_url":"https://api.github.com/repos/andela/wg-aces/releases{/id}","deployments_url":"https://api.github.com/repos/andela/wg-aces/deployments","created_at":"2018-07-23T16:16:38Z","updated_at":"2018-08-17T18:58:44Z","pushed_at":"2018-08-22T12:00:48Z","git_url":"git://github.com/andela/wg-aces.git","ssh_url":"git@github.com:andela/wg-aces.git","clone_url":"https://github.com/andela/wg-aces.git","svn_url":"https://github.com/andela/wg-aces","homepage":null,"size":28304,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"base":{"label":"andela:develop","ref":"develop","sha":"d48b827583ce4008a971df7a023025d4f588d454","user":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"repo":{"id":142039112,"node_id":"MDEwOlJlcG9zaXRvcnkxNDIwMzkxMTI=","name":"wg-aces","full_name":"andela/wg-aces","owner":{"login":"andela","id":4100206,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQxMDAyMDY=","avatar_url":"https://avatars2.githubusercontent.com/u/4100206?v=4","gravatar_id":"","url":"https://api.github.com/users/andela","html_url":"https://github.com/andela","followers_url":"https://api.github.com/users/andela/followers","following_url":"https://api.github.com/users/andela/following{/other_user}","gists_url":"https://api.github.com/users/andela/gists{/gist_id}","starred_url":"https://api.github.com/users/andela/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andela/subscriptions","organizations_url":"https://api.github.com/users/andela/orgs","repos_url":"https://api.github.com/users/andela/repos","events_url":"https://api.github.com/users/andela/events{/privacy}","received_events_url":"https://api.github.com/users/andela/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/andela/wg-aces","description":null,"fork":false,"url":"https://api.github.com/repos/andela/wg-aces","forks_url":"https://api.github.com/repos/andela/wg-aces/forks","keys_url":"https://api.github.com/repos/andela/wg-aces/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andela/wg-aces/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andela/wg-aces/teams","hooks_url":"https://api.github.com/repos/andela/wg-aces/hooks","issue_events_url":"https://api.github.com/repos/andela/wg-aces/issues/events{/number}","events_url":"https://api.github.com/repos/andela/wg-aces/events","assignees_url":"https://api.github.com/repos/andela/wg-aces/assignees{/user}","branches_url":"https://api.github.com/repos/andela/wg-aces/branches{/branch}","tags_url":"https://api.github.com/repos/andela/wg-aces/tags","blobs_url":"https://api.github.com/repos/andela/wg-aces/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andela/wg-aces/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andela/wg-aces/git/refs{/sha}","trees_url":"https://api.github.com/repos/andela/wg-aces/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andela/wg-aces/statuses/{sha}","languages_url":"https://api.github.com/repos/andela/wg-aces/languages","stargazers_url":"https://api.github.com/repos/andela/wg-aces/stargazers","contributors_url":"https://api.github.com/repos/andela/wg-aces/contributors","subscribers_url":"https://api.github.com/repos/andela/wg-aces/subscribers","subscription_url":"https://api.github.com/repos/andela/wg-aces/subscription","commits_url":"https://api.github.com/repos/andela/wg-aces/commits{/sha}","git_commits_url":"https://api.github.com/repos/andela/wg-aces/git/commits{/sha}","comments_url":"https://api.github.com/repos/andela/wg-aces/comments{/number}","issue_comment_url":"https://api.github.com/repos/andela/wg-aces/issues/comments{/number}","contents_url":"https://api.github.com/repos/andela/wg-aces/contents/{+path}","compare_url":"https://api.github.com/repos/andela/wg-aces/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andela/wg-aces/merges","archive_url":"https://api.github.com/repos/andela/wg-aces/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andela/wg-aces/downloads","issues_url":"https://api.github.com/repos/andela/wg-aces/issues{/number}","pulls_url":"https://api.github.com/repos/andela/wg-aces/pulls{/number}","milestones_url":"https://api.github.com/repos/andela/wg-aces/milestones{/number}","notifications_url":"https://api.github.com/repos/andela/wg-aces/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andela/wg-aces/labels{/name}","releases_url":"https://api.github.com/repos/andela/wg-aces/releases{/id}","deployments_url":"https://api.github.com/repos/andela/wg-aces/deployments","created_at":"2018-07-23T16:16:38Z","updated_at":"2018-08-17T18:58:44Z","pushed_at":"2018-08-22T12:00:48Z","git_url":"git://github.com/andela/wg-aces.git","ssh_url":"git@github.com:andela/wg-aces.git","clone_url":"https://github.com/andela/wg-aces.git","svn_url":"https://github.com/andela/wg-aces","homepage":null,"size":28304,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":3,"license":{"key":"agpl-3.0","name":"GNU Affero General Public License v3.0","spdx_id":"AGPL-3.0","url":"https://api.github.com/licenses/agpl-3.0","node_id":"MDc6TGljZW5zZTE="},"forks":0,"open_issues":3,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/andela/wg-aces/pulls/32"},"html":{"href":"https://github.com/andela/wg-aces/pull/32"},"issue":{"href":"https://api.github.com/repos/andela/wg-aces/issues/32"},"comments":{"href":"https://api.github.com/repos/andela/wg-aces/issues/32/comments"},"review_comments":{"href":"https://api.github.com/repos/andela/wg-aces/pulls/32/comments"},"review_comment":{"href":"https://api.github.com/repos/andela/wg-aces/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/andela/wg-aces/pulls/32/commits"},"statuses":{"href":"https://api.github.com/repos/andela/wg-aces/statuses/8d5759d2f33e8aaf1db6760153b8dec575331153"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"isheebo"}}