{"action":"created","issue":{"url":"https://api.github.com/repos/sci-visus/OpenVisus/issues/11","repository_url":"https://api.github.com/repos/sci-visus/OpenVisus","labels_url":"https://api.github.com/repos/sci-visus/OpenVisus/issues/11/labels{/name}","comments_url":"https://api.github.com/repos/sci-visus/OpenVisus/issues/11/comments","events_url":"https://api.github.com/repos/sci-visus/OpenVisus/issues/11/events","html_url":"https://github.com/sci-visus/OpenVisus/pull/11","id":354109697,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwOTYwMzQ1","number":11,"title":"Fixed error in BUILD_TYPE not being defined","user":{"login":"ptbremer","id":1264379,"node_id":"MDQ6VXNlcjEyNjQzNzk=","avatar_url":"https://avatars2.githubusercontent.com/u/1264379?v=4","gravatar_id":"","url":"https://api.github.com/users/ptbremer","html_url":"https://github.com/ptbremer","followers_url":"https://api.github.com/users/ptbremer/followers","following_url":"https://api.github.com/users/ptbremer/following{/other_user}","gists_url":"https://api.github.com/users/ptbremer/gists{/gist_id}","starred_url":"https://api.github.com/users/ptbremer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ptbremer/subscriptions","organizations_url":"https://api.github.com/users/ptbremer/orgs","repos_url":"https://api.github.com/users/ptbremer/repos","events_url":"https://api.github.com/users/ptbremer/events{/privacy}","received_events_url":"https://api.github.com/users/ptbremer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-08-26T16:52:38Z","updated_at":"2018-08-27T06:31:29Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/sci-visus/OpenVisus/pulls/11","html_url":"https://github.com/sci-visus/OpenVisus/pull/11","diff_url":"https://github.com/sci-visus/OpenVisus/pull/11.diff","patch_url":"https://github.com/sci-visus/OpenVisus/pull/11.patch"},"body":"This is a small change I had to make to support installing on my system. The BUILD_TYPE wasn't defined and instead it seems CMake now uses CMAKE_INSTALL_CONFIG_NAME. However, even that variable is not defined unless you explicitly configure with \"cmake -DCMAKE_BUILD_TYPE=Release\" or something similar. So I am guarding against that by testing whether the variable exists. "},"comment":{"url":"https://api.github.com/repos/sci-visus/OpenVisus/issues/comments/416128010","html_url":"https://github.com/sci-visus/OpenVisus/pull/11#issuecomment-416128010","issue_url":"https://api.github.com/repos/sci-visus/OpenVisus/issues/11","id":416128010,"node_id":"MDEyOklzc3VlQ29tbWVudDQxNjEyODAxMA==","user":{"login":"scrgiorgio","id":1260735,"node_id":"MDQ6VXNlcjEyNjA3MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1260735?v=4","gravatar_id":"","url":"https://api.github.com/users/scrgiorgio","html_url":"https://github.com/scrgiorgio","followers_url":"https://api.github.com/users/scrgiorgio/followers","following_url":"https://api.github.com/users/scrgiorgio/following{/other_user}","gists_url":"https://api.github.com/users/scrgiorgio/gists{/gist_id}","starred_url":"https://api.github.com/users/scrgiorgio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scrgiorgio/subscriptions","organizations_url":"https://api.github.com/users/scrgiorgio/orgs","repos_url":"https://api.github.com/users/scrgiorgio/repos","events_url":"https://api.github.com/users/scrgiorgio/events{/privacy}","received_events_url":"https://api.github.com/users/scrgiorgio/received_events","type":"User","site_admin":false},"created_at":"2018-08-27T06:31:29Z","updated_at":"2018-08-27T06:31:29Z","author_association":"CONTRIBUTOR","body":"Timo I do this for Linux (see CMake/VisusMacro.cmake):\r\n\r\nif(NOT CMAKE_BUILD_TYPE)\r\n    set(CMAKE_BUILD_TYPE \"Release\" CACHE STRING \"Choose the type of build, options are: Debug Release\" FORCE)\r\nendif()\r\n\r\nare you compiling on osx using g++? In that case  I can change the file to check what is the compiler under osx.\r\n\r\nLet me know\r\n\r\n\r\n"}}
{"actor":{"display_login":"scrgiorgio"}}