{"action":"created","issue":{"url":"https://api.github.com/repos/dropwizard-jobs/dropwizard-jobs/issues/65","repository_url":"https://api.github.com/repos/dropwizard-jobs/dropwizard-jobs","labels_url":"https://api.github.com/repos/dropwizard-jobs/dropwizard-jobs/issues/65/labels{/name}","comments_url":"https://api.github.com/repos/dropwizard-jobs/dropwizard-jobs/issues/65/comments","events_url":"https://api.github.com/repos/dropwizard-jobs/dropwizard-jobs/issues/65/events","html_url":"https://github.com/dropwizard-jobs/dropwizard-jobs/pull/65","id":253850191,"node_id":"MDExOlB1bGxSZXF1ZXN0MTM4MzE3Nzcx","number":65,"title":"Feature: Configurable timezone for @On cronjobs","user":{"login":"eonwhite","id":109324,"node_id":"MDQ6VXNlcjEwOTMyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/109324?v=4","gravatar_id":"","url":"https://api.github.com/users/eonwhite","html_url":"https://github.com/eonwhite","followers_url":"https://api.github.com/users/eonwhite/followers","following_url":"https://api.github.com/users/eonwhite/following{/other_user}","gists_url":"https://api.github.com/users/eonwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/eonwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eonwhite/subscriptions","organizations_url":"https://api.github.com/users/eonwhite/orgs","repos_url":"https://api.github.com/users/eonwhite/repos","events_url":"https://api.github.com/users/eonwhite/events{/privacy}","received_events_url":"https://api.github.com/users/eonwhite/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2017-08-30T01:19:43Z","updated_at":"2018-11-06T17:06:07Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/dropwizard-jobs/dropwizard-jobs/pulls/65","html_url":"https://github.com/dropwizard-jobs/dropwizard-jobs/pull/65","diff_url":"https://github.com/dropwizard-jobs/dropwizard-jobs/pull/65.diff","patch_url":"https://github.com/dropwizard-jobs/dropwizard-jobs/pull/65.patch"},"body":"This is a really handy bundle, but since the `JobManager` is doing all the job setup for you, there's currently no way to override the default timezone used for cron scheduling.\r\n\r\nI like to run all my servers in UTC, but sometimes it's important to have crons scheduled for a particular timezone, so this is inconvenient.\r\n\r\nThis PR creates two ways to configure the timezone used by the `JobManager`-created `@On` jobs:\r\n\r\n- If you add a `de.spinscale.dropwizard.jobs.timezone` property to the quartz configuration, you can set the timezone that will be used for all jobs created by the dropwizard-jobs bundle.\r\n\r\n- If you add a `[timezone]` to a particular cron expression, it will use that timezone for that particular cron. For example in your config,\r\n\r\n```\r\njobs:\r\n  MyJob: 0 15 10 ? * * [America/Los_Angeles]\r\n```\r\n\r\nWill configure the MyJob to run at 10:15am, Los Angeles time.\r\n\r\nLet me know if you have any feedback, and thank you for your work on this project."},"comment":{"url":"https://api.github.com/repos/dropwizard-jobs/dropwizard-jobs/issues/comments/436330301","html_url":"https://github.com/dropwizard-jobs/dropwizard-jobs/pull/65#issuecomment-436330301","issue_url":"https://api.github.com/repos/dropwizard-jobs/dropwizard-jobs/issues/65","id":436330301,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNjMzMDMwMQ==","user":{"login":"eonwhite","id":109324,"node_id":"MDQ6VXNlcjEwOTMyNA==","avatar_url":"https://avatars0.githubusercontent.com/u/109324?v=4","gravatar_id":"","url":"https://api.github.com/users/eonwhite","html_url":"https://github.com/eonwhite","followers_url":"https://api.github.com/users/eonwhite/followers","following_url":"https://api.github.com/users/eonwhite/following{/other_user}","gists_url":"https://api.github.com/users/eonwhite/gists{/gist_id}","starred_url":"https://api.github.com/users/eonwhite/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eonwhite/subscriptions","organizations_url":"https://api.github.com/users/eonwhite/orgs","repos_url":"https://api.github.com/users/eonwhite/repos","events_url":"https://api.github.com/users/eonwhite/events{/privacy}","received_events_url":"https://api.github.com/users/eonwhite/received_events","type":"User","site_admin":false},"created_at":"2018-11-06T17:06:07Z","updated_at":"2018-11-06T17:06:07Z","author_association":"CONTRIBUTOR","body":"Since there's interest in this, re-opening. I don't really see any major problems with merging -- the only concern some people had was that the `[timezone]` syntax might be too idiosyncratic. I think it's worth it to preserve the current configuration format. Anyway, up to project organizers."}}
{"actor":{"display_login":"eonwhite"}}