{"action":"created","issue":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70898","repository_url":"https://api.github.com/repos/kubernetes/kubernetes","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70898/labels{/name}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70898/comments","events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70898/events","html_url":"https://github.com/kubernetes/kubernetes/pull/70898","id":379367557,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5ODU1MTMz","number":70898,"title":"[WIP] ensure scheduler preemptor behaves in an efficient/correct path","user":{"login":"Huang-Wei","id":1425903,"node_id":"MDQ6VXNlcjE0MjU5MDM=","avatar_url":"https://avatars0.githubusercontent.com/u/1425903?v=4","gravatar_id":"","url":"https://api.github.com/users/Huang-Wei","html_url":"https://github.com/Huang-Wei","followers_url":"https://api.github.com/users/Huang-Wei/followers","following_url":"https://api.github.com/users/Huang-Wei/following{/other_user}","gists_url":"https://api.github.com/users/Huang-Wei/gists{/gist_id}","starred_url":"https://api.github.com/users/Huang-Wei/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Huang-Wei/subscriptions","organizations_url":"https://api.github.com/users/Huang-Wei/orgs","repos_url":"https://api.github.com/users/Huang-Wei/repos","events_url":"https://api.github.com/users/Huang-Wei/events{/privacy}","received_events_url":"https://api.github.com/users/Huang-Wei/received_events","type":"User","site_admin":false},"labels":[{"id":477397086,"node_id":"MDU6TGFiZWw0NzczOTcwODY=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":687500047,"node_id":"MDU6TGFiZWw2ODc1MDAwNDc=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/do-not-merge/work-in-progress","name":"do-not-merge/work-in-progress","color":"e11d21","default":false},{"id":105146071,"node_id":"MDU6TGFiZWwxMDUxNDYwNzE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/kind/bug","name":"kind/bug","color":"e11d21","default":false},{"id":1111992057,"node_id":"MDU6TGFiZWwxMTExOTkyMDU3","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/needs-priority","name":"needs-priority","color":"ededed","default":false},{"id":200149833,"node_id":"MDU6TGFiZWwyMDAxNDk4MzM=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":125550211,"node_id":"MDU6TGFiZWwxMjU1NTAyMTE=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/scheduling","name":"sig/scheduling","color":"d2b48c","default":false},{"id":483069764,"node_id":"MDU6TGFiZWw0ODMwNjk3NjQ=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/testing","name":"sig/testing","color":"d2b48c","default":false},{"id":253450978,"node_id":"MDU6TGFiZWwyNTM0NTA5Nzg=","url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/L","name":"size/L","color":"ee9900","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-11-10T00:29:46Z","updated_at":"2018-11-12T20:35:04Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/70898","html_url":"https://github.com/kubernetes/kubernetes/pull/70898","diff_url":"https://github.com/kubernetes/kubernetes/pull/70898.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/70898.patch"},"body":"**What type of PR is this?**\r\n\r\n/kind bug\r\n\r\n**What this PR does / why we need it**:\r\n\r\n- don't update nominatedMap cache when Pop() an element from activeQ\r\n- instead, delete the nominated info from cache when it's bound (scheduled)\r\n\r\n**Which issue(s) this PR fixes**:\r\n\r\nFixes #70622\r\n\r\n**Special notes for your reviewer**:\r\n\r\n- The code fix can be reviewed right now\r\n- I will append an e2e test later\r\n\r\n**Does this PR introduce a user-facing change?**:\r\n\r\n```release-note\r\nFix a potential bug that scheduler isn't preempting pods in an exact correct path.\r\n```\r\n\r\n/sig scheduling\r\n"},"comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments/438019797","html_url":"https://github.com/kubernetes/kubernetes/pull/70898#issuecomment-438019797","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/70898","id":438019797,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODAxOTc5Nw==","user":{"login":"k8s-ci-robot","id":20407524,"node_id":"MDQ6VXNlcjIwNDA3NTI0","avatar_url":"https://avatars0.githubusercontent.com/u/20407524?v=4","gravatar_id":"","url":"https://api.github.com/users/k8s-ci-robot","html_url":"https://github.com/k8s-ci-robot","followers_url":"https://api.github.com/users/k8s-ci-robot/followers","following_url":"https://api.github.com/users/k8s-ci-robot/following{/other_user}","gists_url":"https://api.github.com/users/k8s-ci-robot/gists{/gist_id}","starred_url":"https://api.github.com/users/k8s-ci-robot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/k8s-ci-robot/subscriptions","organizations_url":"https://api.github.com/users/k8s-ci-robot/orgs","repos_url":"https://api.github.com/users/k8s-ci-robot/repos","events_url":"https://api.github.com/users/k8s-ci-robot/events{/privacy}","received_events_url":"https://api.github.com/users/k8s-ci-robot/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T20:35:04Z","updated_at":"2018-11-12T20:35:04Z","author_association":"CONTRIBUTOR","body":"@Huang-Wei: The following tests **failed**, say `/retest` to rerun them all:\n\nTest name | Commit | Details | Rerun command\n--- | --- | --- | ---\npull-kubernetes-e2e-gce-100-performance | 729bcd4b97f44daa5a951fef5cf3135cf644158f | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70898/pull-kubernetes-e2e-gce-100-performance/26683/) | `/test pull-kubernetes-e2e-gce-100-performance`\npull-kubernetes-kubemark-e2e-gce-big | 729bcd4b97f44daa5a951fef5cf3135cf644158f | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70898/pull-kubernetes-kubemark-e2e-gce-big/29075/) | `/test pull-kubernetes-kubemark-e2e-gce-big`\npull-kubernetes-e2e-kops-aws | 9254427aa93b7a57dac526dd9a2ca49c78977dbf | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70898/pull-kubernetes-e2e-kops-aws/113560/) | `/test pull-kubernetes-e2e-kops-aws`\npull-kubernetes-e2e-gce | 9254427aa93b7a57dac526dd9a2ca49c78977dbf | [link](https://gubernator.k8s.io/build/kubernetes-jenkins/pr-logs/pull/70898/pull-kubernetes-e2e-gce/59654/) | `/test pull-kubernetes-e2e-gce`\n\n[Full PR test history](https://gubernator.k8s.io/pr/70898). [Your PR dashboard](https://gubernator.k8s.io/pr/Huang-Wei). Please help us cut down on flakes by [linking to](https://git.k8s.io/community/contributors/devel/flaky-tests.md#filing-issues-for-flaky-tests) an [open issue](https://github.com/kubernetes/kubernetes/issues?q=is:issue+is:open) when you hit one in your PR.\n\n<details>\n\nInstructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md).  If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).\n</details>\n<!-- test report -->"}}
{"actor":{"display_login":"k8s-ci-robot"}}