{"action":"created","issue":{"url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1462","repository_url":"https://api.github.com/repos/official-stockfish/Stockfish","labels_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1462/labels{/name}","comments_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1462/comments","events_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1462/events","html_url":"https://github.com/official-stockfish/Stockfish/pull/1462","id":302663375,"number":1462,"title":"Return alpha+1 in qsearch when reaching MAX_PLY with check.","user":{"login":"xoto10","id":23479932,"avatar_url":"https://avatars3.githubusercontent.com/u/23479932?v=4","gravatar_id":"","url":"https://api.github.com/users/xoto10","html_url":"https://github.com/xoto10","followers_url":"https://api.github.com/users/xoto10/followers","following_url":"https://api.github.com/users/xoto10/following{/other_user}","gists_url":"https://api.github.com/users/xoto10/gists{/gist_id}","starred_url":"https://api.github.com/users/xoto10/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xoto10/subscriptions","organizations_url":"https://api.github.com/users/xoto10/orgs","repos_url":"https://api.github.com/users/xoto10/repos","events_url":"https://api.github.com/users/xoto10/events{/privacy}","received_events_url":"https://api.github.com/users/xoto10/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":34,"created_at":"2018-03-06T11:26:28Z","updated_at":"2018-03-21T01:24:35Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/official-stockfish/Stockfish/pulls/1462","html_url":"https://github.com/official-stockfish/Stockfish/pull/1462","diff_url":"https://github.com/official-stockfish/Stockfish/pull/1462.diff","patch_url":"https://github.com/official-stockfish/Stockfish/pull/1462.patch"},"body":"Bugfix: qsearch() was returning VALUE_DRAW if the search reached MAX_PLY with a check. This patch changes the return value to alpha+1.\r\n\r\nTo make this condition happen more often, this test fixed MAX_PLY at 20 and demonstrated that returning alpha+1 gave better results by passing [0,5] SPRT very easily:\r\n\r\nSTC: http://tests.stockfishchess.org/tests/view/5a9ce1330ebc590297cb605f\r\nLLR: 3.02 (-2.94,2.94) [0.00,5.00]\r\nTotal: 6224 W: 1468 L: 1302 D: 3454\r\n\r\n[ Edit: LTC was also run: http://tests.stockfishchess.org/tests/view/5a9cf7e70ebc590297cb606a\r\n. . . . LLR: 2.96 (-2.94,2.94) [0.00,5.00]\r\n. . . . Total: 4771 W: 755 L: 618 D: 3398\r\n. . . . Because of the MAX_PLY restriction I felt it was virtually the same test as STC.\r\n\r\n. . . . See also the discussion at: [this_commit](https://github.com/xoto10/stockfish-xoto10/commit/6d4f88f18caabfc5c848fbc41fa078123cd96498)\r\n]\r\n\r\nTests of just the proposed code change for non-regression (i.e. with MAX_PLY at the normal value of 128) passed [-3,1] SPRT with more wins than losses:\r\n\r\nSTC: http://tests.stockfishchess.org/tests/view/5a9d7b270ebc590297cb60ee\r\nLLR: 2.96 (-2.94,2.94) [-3.00,1.00]\r\nTotal: 23236 W: 5166 L: 5047 D: 13023\r\n\r\nLTC: http://tests.stockfishchess.org/tests/view/5a9d96ff0ebc590297cb6109\r\nLLR: 2.96 (-2.94,2.94) [-3.00,1.00]\r\nTotal: 43017 W: 7032 L: 6946 D: 29039\r\n\r\nAttempts to make a similar change in search() did badly in tests."},"comment":{"url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/comments/374810574","html_url":"https://github.com/official-stockfish/Stockfish/pull/1462#issuecomment-374810574","issue_url":"https://api.github.com/repos/official-stockfish/Stockfish/issues/1462","id":374810574,"user":{"login":"lucasart","id":2278294,"avatar_url":"https://avatars2.githubusercontent.com/u/2278294?v=4","gravatar_id":"","url":"https://api.github.com/users/lucasart","html_url":"https://github.com/lucasart","followers_url":"https://api.github.com/users/lucasart/followers","following_url":"https://api.github.com/users/lucasart/following{/other_user}","gists_url":"https://api.github.com/users/lucasart/gists{/gist_id}","starred_url":"https://api.github.com/users/lucasart/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lucasart/subscriptions","organizations_url":"https://api.github.com/users/lucasart/orgs","repos_url":"https://api.github.com/users/lucasart/repos","events_url":"https://api.github.com/users/lucasart/events{/privacy}","received_events_url":"https://api.github.com/users/lucasart/received_events","type":"User","site_admin":false},"created_at":"2018-03-21T01:24:35Z","updated_at":"2018-03-21T01:24:35Z","author_association":"NONE","body":"@mcostalba @snicolet: shouldn't this PR be closed ? Seems clear that it won't be merged."}}
{"actor":{"display_login":"lucasart"}}