{"action":"created","issue":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/3841","repository_url":"https://api.github.com/repos/trilinos/Trilinos","labels_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3841/labels{/name}","comments_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3841/comments","events_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3841/events","html_url":"https://github.com/trilinos/Trilinos/pull/3841","id":379203409,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzI2NDMy","number":3841,"title":"Fix compiling using Sacado with a CUDA device compiler and KOKKOS_ENABLE_CUDA=OFF","user":{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"assignees":[{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false}],"milestone":null,"comments":15,"created_at":"2018-11-09T15:21:05Z","updated_at":"2018-11-12T18:00:00Z","closed_at":"2018-11-12T18:00:00Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/trilinos/Trilinos/pulls/3841","html_url":"https://github.com/trilinos/Trilinos/pull/3841","diff_url":"https://github.com/trilinos/Trilinos/pull/3841.diff","patch_url":"https://github.com/trilinos/Trilinos/pull/3841.patch"},"body":"<!---\r\nBe sure to select `develop` as the `base` branch against which to create this\r\npull request.  Only pull requests against `develop` will undergo Trilinos'\r\nautomated testing.  Pull requests against `master` will be ignored.\r\n\r\nProvide a general summary of your changes in the Title above.  If this pull\r\nrequest pertains to a particular package in Trilinos, it's worthwhile to start\r\nthe title with \"PackageName:  \".\r\n\r\nNote that anything between these delimiters is a comment that will not appear\r\nin the pull request description once created. Most areas in this message are\r\ncommented out and can be easily added by removing the comment delimiters.\r\n\r\nPlease make sure to mark:\r\n* Reviewers\r\n* Assignees\r\n* Labels\r\n\r\nReplace <teamName> below with the appropriate Trilinos package/team name.\r\n-->\r\n@trilinos/kokkos\r\n@trilinos/sacado\r\n\r\n## Description\r\nIf a `CUDA` device compiler and `KOKKOS_ENABLE_CUDA=OFF`, still define\r\n- `Kokkos::atomic_compare_exchange`\r\n- `Kokkos::atomic_exchange`\r\n- `Kokkos::atomic_fetch_add`\r\n- `Kokkos::atomic_fetch_and`\r\n- `Kokkos::atomic_fetch_or`\r\n- `Kokkos::atomic_fetch_sub`\r\n\r\nand don't define `Sacado::createGlobalMemoryPool` and `Sacado::destroyGlobalMemoryPool` with a `Kokkos::Cuda` parameter in that case.\r\n\r\n## Motivation and Context\r\nFixes https://github.com/kokkos/kokkos/issues/1607 and https://github.com/dealii/dealii/issues/6423.\r\n\r\n## How Has This Been Tested?\r\nCompiling `Trilinos` configured without `CUDA` support, but with `Kokkos` and `Sacado` works.\r\nCompiling (`deal.II`)[https://github.com/dealii/dealii/] with `CUDA` support and such a `Trilinos` configuration works and passes `deal.II`s test suite.\r\n\r\n## Checklist\r\n\r\n- [x] My commit messages mention the appropriate GitHub issue numbers.\r\n- [x] My code follows the code style of the affected package(s).\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [x] I have read the [code contribution guidelines](../blob/master/CONTRIBUTING.md) for this project.\r\n- [ ] I have added tests to cover my changes.\r\n- [ ] All new and existing tests passed.\r\n- [ ] No new compiler warnings were introduced.\r\n- [ ] These changes break backwards compatibility."},"comment":{"url":"https://api.github.com/repos/trilinos/Trilinos/issues/comments/437974371","html_url":"https://github.com/trilinos/Trilinos/pull/3841#issuecomment-437974371","issue_url":"https://api.github.com/repos/trilinos/Trilinos/issues/3841","id":437974371,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzk3NDM3MQ==","user":{"login":"masterleinad","id":2423533,"node_id":"MDQ6VXNlcjI0MjM1MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/2423533?v=4","gravatar_id":"","url":"https://api.github.com/users/masterleinad","html_url":"https://github.com/masterleinad","followers_url":"https://api.github.com/users/masterleinad/followers","following_url":"https://api.github.com/users/masterleinad/following{/other_user}","gists_url":"https://api.github.com/users/masterleinad/gists{/gist_id}","starred_url":"https://api.github.com/users/masterleinad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/masterleinad/subscriptions","organizations_url":"https://api.github.com/users/masterleinad/orgs","repos_url":"https://api.github.com/users/masterleinad/repos","events_url":"https://api.github.com/users/masterleinad/events{/privacy}","received_events_url":"https://api.github.com/users/masterleinad/received_events","type":"User","site_admin":false},"created_at":"2018-11-12T18:00:00Z","updated_at":"2018-11-12T18:00:00Z","author_association":"CONTRIBUTOR","body":"Superseded by #3843."}}
{"actor":{"display_login":"masterleinad"}}