{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/165239655","pull_request_review_id":93144864,"id":165239655,"diff_hunk":"@@ -729,6 +729,7 @@ func insertDataWithCommit(goCtx goctx.Context, prevData, curData []byte, loadDat\n \t\tif !reachLimit {\n \t\t\tbreak\n \t\t}\n+\t\tterror.Log(loadDataInfo.Ctx.StmtCommit())","path":"server/conn.go","position":4,"original_position":4,"commit_id":"f5969efbea858df03b7e75c3a540171c940ad180","original_commit_id":"f5969efbea858df03b7e75c3a540171c940ad180","user":{"login":"coocood","id":891222,"avatar_url":"https://avatars0.githubusercontent.com/u/891222?v=4","gravatar_id":"","url":"https://api.github.com/users/coocood","html_url":"https://github.com/coocood","followers_url":"https://api.github.com/users/coocood/followers","following_url":"https://api.github.com/users/coocood/following{/other_user}","gists_url":"https://api.github.com/users/coocood/gists{/gist_id}","starred_url":"https://api.github.com/users/coocood/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coocood/subscriptions","organizations_url":"https://api.github.com/users/coocood/orgs","repos_url":"https://api.github.com/users/coocood/repos","events_url":"https://api.github.com/users/coocood/events{/privacy}","received_events_url":"https://api.github.com/users/coocood/received_events","type":"User","site_admin":false},"body":"Other places only log the StmtCommit error too.\r\nWe can discuss how to treat this error later.","created_at":"2018-02-01T01:39:46Z","updated_at":"2018-02-01T01:39:47Z","html_url":"https://github.com/pingcap/tidb/pull/5758#discussion_r165239655","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/5758","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/165239655"},"html":{"href":"https://github.com/pingcap/tidb/pull/5758#discussion_r165239655"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/5758"}},"in_reply_to_id":165066159},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/5758","id":166233576,"html_url":"https://github.com/pingcap/tidb/pull/5758","diff_url":"https://github.com/pingcap/tidb/pull/5758.diff","patch_url":"https://github.com/pingcap/tidb/pull/5758.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/5758","number":5758,"state":"open","locked":false,"title":"server: forget to add `StmtCommit` when loading data","user":{"login":"zimulala","id":4242506,"avatar_url":"https://avatars2.githubusercontent.com/u/4242506?v=4","gravatar_id":"","url":"https://api.github.com/users/zimulala","html_url":"https://github.com/zimulala","followers_url":"https://api.github.com/users/zimulala/followers","following_url":"https://api.github.com/users/zimulala/following{/other_user}","gists_url":"https://api.github.com/users/zimulala/gists{/gist_id}","starred_url":"https://api.github.com/users/zimulala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimulala/subscriptions","organizations_url":"https://api.github.com/users/zimulala/orgs","repos_url":"https://api.github.com/users/zimulala/repos","events_url":"https://api.github.com/users/zimulala/events{/privacy}","received_events_url":"https://api.github.com/users/zimulala/received_events","type":"User","site_admin":false},"body":"The operation of `load data` divides into several batches. Every batch needs to commit once. So it also needs to call `StmtCommit`.\r\n\r\n\r\nRelate to #5678 ","created_at":"2018-01-31T11:28:00Z","updated_at":"2018-02-01T01:39:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"615581912e847ae444261f7aca9ff13eac9409bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/5758/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/5758/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/5758/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/f5969efbea858df03b7e75c3a540171c940ad180","head":{"label":"zimulala:load-data","ref":"load-data","sha":"f5969efbea858df03b7e75c3a540171c940ad180","user":{"login":"zimulala","id":4242506,"avatar_url":"https://avatars2.githubusercontent.com/u/4242506?v=4","gravatar_id":"","url":"https://api.github.com/users/zimulala","html_url":"https://github.com/zimulala","followers_url":"https://api.github.com/users/zimulala/followers","following_url":"https://api.github.com/users/zimulala/following{/other_user}","gists_url":"https://api.github.com/users/zimulala/gists{/gist_id}","starred_url":"https://api.github.com/users/zimulala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimulala/subscriptions","organizations_url":"https://api.github.com/users/zimulala/orgs","repos_url":"https://api.github.com/users/zimulala/repos","events_url":"https://api.github.com/users/zimulala/events{/privacy}","received_events_url":"https://api.github.com/users/zimulala/received_events","type":"User","site_admin":false},"repo":{"id":41986662,"name":"tidb","full_name":"zimulala/tidb","owner":{"login":"zimulala","id":4242506,"avatar_url":"https://avatars2.githubusercontent.com/u/4242506?v=4","gravatar_id":"","url":"https://api.github.com/users/zimulala","html_url":"https://github.com/zimulala","followers_url":"https://api.github.com/users/zimulala/followers","following_url":"https://api.github.com/users/zimulala/following{/other_user}","gists_url":"https://api.github.com/users/zimulala/gists{/gist_id}","starred_url":"https://api.github.com/users/zimulala/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zimulala/subscriptions","organizations_url":"https://api.github.com/users/zimulala/orgs","repos_url":"https://api.github.com/users/zimulala/repos","events_url":"https://api.github.com/users/zimulala/events{/privacy}","received_events_url":"https://api.github.com/users/zimulala/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/zimulala/tidb","description":"TiDB is a distributed SQL database.","fork":true,"url":"https://api.github.com/repos/zimulala/tidb","forks_url":"https://api.github.com/repos/zimulala/tidb/forks","keys_url":"https://api.github.com/repos/zimulala/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zimulala/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zimulala/tidb/teams","hooks_url":"https://api.github.com/repos/zimulala/tidb/hooks","issue_events_url":"https://api.github.com/repos/zimulala/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/zimulala/tidb/events","assignees_url":"https://api.github.com/repos/zimulala/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/zimulala/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/zimulala/tidb/tags","blobs_url":"https://api.github.com/repos/zimulala/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zimulala/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zimulala/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/zimulala/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zimulala/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/zimulala/tidb/languages","stargazers_url":"https://api.github.com/repos/zimulala/tidb/stargazers","contributors_url":"https://api.github.com/repos/zimulala/tidb/contributors","subscribers_url":"https://api.github.com/repos/zimulala/tidb/subscribers","subscription_url":"https://api.github.com/repos/zimulala/tidb/subscription","commits_url":"https://api.github.com/repos/zimulala/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/zimulala/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/zimulala/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/zimulala/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/zimulala/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/zimulala/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zimulala/tidb/merges","archive_url":"https://api.github.com/repos/zimulala/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zimulala/tidb/downloads","issues_url":"https://api.github.com/repos/zimulala/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/zimulala/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/zimulala/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/zimulala/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zimulala/tidb/labels{/name}","releases_url":"https://api.github.com/repos/zimulala/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/zimulala/tidb/deployments","created_at":"2015-09-06T04:16:07Z","updated_at":"2017-10-19T09:16:15Z","pushed_at":"2018-01-31T11:20:04Z","git_url":"git://github.com/zimulala/tidb.git","ssh_url":"git@github.com:zimulala/tidb.git","clone_url":"https://github.com/zimulala/tidb.git","svn_url":"https://github.com/zimulala/tidb","homepage":"","size":40862,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"059f618717b9ff1bc81aa7c24739be36575412b9","user":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-02-01T00:22:00Z","pushed_at":"2018-01-31T12:01:00Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":66664,"stargazers_count":11590,"watchers_count":11590,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1563,"mirror_url":null,"archived":false,"open_issues_count":373,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1563,"open_issues":373,"watchers":11590,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/5758"},"html":{"href":"https://github.com/pingcap/tidb/pull/5758"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/5758"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/5758/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/5758/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/5758/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/f5969efbea858df03b7e75c3a540171c940ad180"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"coocood"}}