{"action":"created","comment":{"url":"https://api.github.com/repos/jgsogo/conan/pulls/comments/215341593","pull_request_review_id":152584082,"id":215341593,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNTM0MTU5Mw==","diff_hunk":"@@ -202,7 +202,9 @@ def excluded_files(self):\n         return excluded_list\n \n     def get_remote_url(self):\n-        return self.run(\"info --show-item url\").strip()\n+        url = self.run(\"info --show-item url\").strip()\n+        revision = self.run(\"info --show-item revision\").strip()\n+        return \"{url}@{revision}\".format(url=url, revision=revision)","path":"conans/client/tools/scm.py","position":7,"original_position":7,"commit_id":"cea22a41840056fe0ba06b8bf853d2f7b689a5cc","original_commit_id":"cea22a41840056fe0ba06b8bf853d2f7b689a5cc","user":{"login":"jgsogo","id":1406456,"node_id":"MDQ6VXNlcjE0MDY0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1406456?v=4","gravatar_id":"","url":"https://api.github.com/users/jgsogo","html_url":"https://github.com/jgsogo","followers_url":"https://api.github.com/users/jgsogo/followers","following_url":"https://api.github.com/users/jgsogo/following{/other_user}","gists_url":"https://api.github.com/users/jgsogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jgsogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgsogo/subscriptions","organizations_url":"https://api.github.com/users/jgsogo/orgs","repos_url":"https://api.github.com/users/jgsogo/repos","events_url":"https://api.github.com/users/jgsogo/events{/privacy}","received_events_url":"https://api.github.com/users/jgsogo/received_events","type":"User","site_admin":false},"body":"`SVN::get_remote_url` should return just the URL, like the Git implementation, otherwise it would fail [here](https://github.com/jgsogo/conan/blob/cea22a41840056fe0ba06b8bf853d2f7b689a5cc/conans/client/cmd/export.py#L77) when url is a local folder... so I think we have to leave `get_remote_url` as it was and add the peg_revision in this line: https://github.com/jgsogo/conan/blob/cea22a41840056fe0ba06b8bf853d2f7b689a5cc/conans/client/cmd/export.py#L84","created_at":"2018-09-05T16:32:30Z","updated_at":"2018-09-05T16:35:50Z","html_url":"https://github.com/jgsogo/conan/pull/2#discussion_r215341593","pull_request_url":"https://api.github.com/repos/jgsogo/conan/pulls/2","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/jgsogo/conan/pulls/comments/215341593"},"html":{"href":"https://github.com/jgsogo/conan/pull/2#discussion_r215341593"},"pull_request":{"href":"https://api.github.com/repos/jgsogo/conan/pulls/2"}}},"pull_request":{"url":"https://api.github.com/repos/jgsogo/conan/pulls/2","id":213272688,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEzMjcyNjg4","html_url":"https://github.com/jgsogo/conan/pull/2","diff_url":"https://github.com/jgsogo/conan/pull/2.diff","patch_url":"https://github.com/jgsogo/conan/pull/2.patch","issue_url":"https://api.github.com/repos/jgsogo/conan/issues/2","number":2,"state":"open","locked":false,"title":"Add SVN feature to get last-changed-revision and the current branch/tag/trunk name","user":{"login":"climblinne","id":9393574,"node_id":"MDQ6VXNlcjkzOTM1NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9393574?v=4","gravatar_id":"","url":"https://api.github.com/users/climblinne","html_url":"https://github.com/climblinne","followers_url":"https://api.github.com/users/climblinne/followers","following_url":"https://api.github.com/users/climblinne/following{/other_user}","gists_url":"https://api.github.com/users/climblinne/gists{/gist_id}","starred_url":"https://api.github.com/users/climblinne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/climblinne/subscriptions","organizations_url":"https://api.github.com/users/climblinne/orgs","repos_url":"https://api.github.com/users/climblinne/repos","events_url":"https://api.github.com/users/climblinne/events{/privacy}","received_events_url":"https://api.github.com/users/climblinne/received_events","type":"User","site_admin":false},"body":"complement to SVN issue-3130 of conan","created_at":"2018-09-05T12:18:03Z","updated_at":"2018-09-05T16:35:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"bdd87aff1efa020431cb46fc220947d16edb6f3e","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/jgsogo/conan/pulls/2/commits","review_comments_url":"https://api.github.com/repos/jgsogo/conan/pulls/2/comments","review_comment_url":"https://api.github.com/repos/jgsogo/conan/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jgsogo/conan/issues/2/comments","statuses_url":"https://api.github.com/repos/jgsogo/conan/statuses/cea22a41840056fe0ba06b8bf853d2f7b689a5cc","head":{"label":"climblinne:issue-3130","ref":"issue-3130","sha":"cea22a41840056fe0ba06b8bf853d2f7b689a5cc","user":{"login":"climblinne","id":9393574,"node_id":"MDQ6VXNlcjkzOTM1NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9393574?v=4","gravatar_id":"","url":"https://api.github.com/users/climblinne","html_url":"https://github.com/climblinne","followers_url":"https://api.github.com/users/climblinne/followers","following_url":"https://api.github.com/users/climblinne/following{/other_user}","gists_url":"https://api.github.com/users/climblinne/gists{/gist_id}","starred_url":"https://api.github.com/users/climblinne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/climblinne/subscriptions","organizations_url":"https://api.github.com/users/climblinne/orgs","repos_url":"https://api.github.com/users/climblinne/repos","events_url":"https://api.github.com/users/climblinne/events{/privacy}","received_events_url":"https://api.github.com/users/climblinne/received_events","type":"User","site_admin":false},"repo":{"id":147512511,"node_id":"MDEwOlJlcG9zaXRvcnkxNDc1MTI1MTE=","name":"conan","full_name":"climblinne/conan","owner":{"login":"climblinne","id":9393574,"node_id":"MDQ6VXNlcjkzOTM1NzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/9393574?v=4","gravatar_id":"","url":"https://api.github.com/users/climblinne","html_url":"https://github.com/climblinne","followers_url":"https://api.github.com/users/climblinne/followers","following_url":"https://api.github.com/users/climblinne/following{/other_user}","gists_url":"https://api.github.com/users/climblinne/gists{/gist_id}","starred_url":"https://api.github.com/users/climblinne/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/climblinne/subscriptions","organizations_url":"https://api.github.com/users/climblinne/orgs","repos_url":"https://api.github.com/users/climblinne/repos","events_url":"https://api.github.com/users/climblinne/events{/privacy}","received_events_url":"https://api.github.com/users/climblinne/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/climblinne/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/climblinne/conan","forks_url":"https://api.github.com/repos/climblinne/conan/forks","keys_url":"https://api.github.com/repos/climblinne/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/climblinne/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/climblinne/conan/teams","hooks_url":"https://api.github.com/repos/climblinne/conan/hooks","issue_events_url":"https://api.github.com/repos/climblinne/conan/issues/events{/number}","events_url":"https://api.github.com/repos/climblinne/conan/events","assignees_url":"https://api.github.com/repos/climblinne/conan/assignees{/user}","branches_url":"https://api.github.com/repos/climblinne/conan/branches{/branch}","tags_url":"https://api.github.com/repos/climblinne/conan/tags","blobs_url":"https://api.github.com/repos/climblinne/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/climblinne/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/climblinne/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/climblinne/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/climblinne/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/climblinne/conan/languages","stargazers_url":"https://api.github.com/repos/climblinne/conan/stargazers","contributors_url":"https://api.github.com/repos/climblinne/conan/contributors","subscribers_url":"https://api.github.com/repos/climblinne/conan/subscribers","subscription_url":"https://api.github.com/repos/climblinne/conan/subscription","commits_url":"https://api.github.com/repos/climblinne/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/climblinne/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/climblinne/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/climblinne/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/climblinne/conan/contents/{+path}","compare_url":"https://api.github.com/repos/climblinne/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/climblinne/conan/merges","archive_url":"https://api.github.com/repos/climblinne/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/climblinne/conan/downloads","issues_url":"https://api.github.com/repos/climblinne/conan/issues{/number}","pulls_url":"https://api.github.com/repos/climblinne/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/climblinne/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/climblinne/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/climblinne/conan/labels{/name}","releases_url":"https://api.github.com/repos/climblinne/conan/releases{/id}","deployments_url":"https://api.github.com/repos/climblinne/conan/deployments","created_at":"2018-09-05T12:14:10Z","updated_at":"2018-09-05T12:14:14Z","pushed_at":"2018-09-05T13:06:16Z","git_url":"git://github.com/climblinne/conan.git","ssh_url":"git@github.com:climblinne/conan.git","clone_url":"https://github.com/climblinne/conan.git","svn_url":"https://github.com/climblinne/conan","homepage":"https://conan.io","size":5641,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"develop"}},"base":{"label":"jgsogo:issue-3130","ref":"issue-3130","sha":"363f6cf949f6412ca498ff7104e962d0cfc30caf","user":{"login":"jgsogo","id":1406456,"node_id":"MDQ6VXNlcjE0MDY0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1406456?v=4","gravatar_id":"","url":"https://api.github.com/users/jgsogo","html_url":"https://github.com/jgsogo","followers_url":"https://api.github.com/users/jgsogo/followers","following_url":"https://api.github.com/users/jgsogo/following{/other_user}","gists_url":"https://api.github.com/users/jgsogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jgsogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgsogo/subscriptions","organizations_url":"https://api.github.com/users/jgsogo/orgs","repos_url":"https://api.github.com/users/jgsogo/repos","events_url":"https://api.github.com/users/jgsogo/events{/privacy}","received_events_url":"https://api.github.com/users/jgsogo/received_events","type":"User","site_admin":false},"repo":{"id":140403647,"node_id":"MDEwOlJlcG9zaXRvcnkxNDA0MDM2NDc=","name":"conan","full_name":"jgsogo/conan","owner":{"login":"jgsogo","id":1406456,"node_id":"MDQ6VXNlcjE0MDY0NTY=","avatar_url":"https://avatars2.githubusercontent.com/u/1406456?v=4","gravatar_id":"","url":"https://api.github.com/users/jgsogo","html_url":"https://github.com/jgsogo","followers_url":"https://api.github.com/users/jgsogo/followers","following_url":"https://api.github.com/users/jgsogo/following{/other_user}","gists_url":"https://api.github.com/users/jgsogo/gists{/gist_id}","starred_url":"https://api.github.com/users/jgsogo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgsogo/subscriptions","organizations_url":"https://api.github.com/users/jgsogo/orgs","repos_url":"https://api.github.com/users/jgsogo/repos","events_url":"https://api.github.com/users/jgsogo/events{/privacy}","received_events_url":"https://api.github.com/users/jgsogo/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/jgsogo/conan","description":"Conan.io - The open-source C/C++ package manager","fork":true,"url":"https://api.github.com/repos/jgsogo/conan","forks_url":"https://api.github.com/repos/jgsogo/conan/forks","keys_url":"https://api.github.com/repos/jgsogo/conan/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jgsogo/conan/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jgsogo/conan/teams","hooks_url":"https://api.github.com/repos/jgsogo/conan/hooks","issue_events_url":"https://api.github.com/repos/jgsogo/conan/issues/events{/number}","events_url":"https://api.github.com/repos/jgsogo/conan/events","assignees_url":"https://api.github.com/repos/jgsogo/conan/assignees{/user}","branches_url":"https://api.github.com/repos/jgsogo/conan/branches{/branch}","tags_url":"https://api.github.com/repos/jgsogo/conan/tags","blobs_url":"https://api.github.com/repos/jgsogo/conan/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jgsogo/conan/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jgsogo/conan/git/refs{/sha}","trees_url":"https://api.github.com/repos/jgsogo/conan/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jgsogo/conan/statuses/{sha}","languages_url":"https://api.github.com/repos/jgsogo/conan/languages","stargazers_url":"https://api.github.com/repos/jgsogo/conan/stargazers","contributors_url":"https://api.github.com/repos/jgsogo/conan/contributors","subscribers_url":"https://api.github.com/repos/jgsogo/conan/subscribers","subscription_url":"https://api.github.com/repos/jgsogo/conan/subscription","commits_url":"https://api.github.com/repos/jgsogo/conan/commits{/sha}","git_commits_url":"https://api.github.com/repos/jgsogo/conan/git/commits{/sha}","comments_url":"https://api.github.com/repos/jgsogo/conan/comments{/number}","issue_comment_url":"https://api.github.com/repos/jgsogo/conan/issues/comments{/number}","contents_url":"https://api.github.com/repos/jgsogo/conan/contents/{+path}","compare_url":"https://api.github.com/repos/jgsogo/conan/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jgsogo/conan/merges","archive_url":"https://api.github.com/repos/jgsogo/conan/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jgsogo/conan/downloads","issues_url":"https://api.github.com/repos/jgsogo/conan/issues{/number}","pulls_url":"https://api.github.com/repos/jgsogo/conan/pulls{/number}","milestones_url":"https://api.github.com/repos/jgsogo/conan/milestones{/number}","notifications_url":"https://api.github.com/repos/jgsogo/conan/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jgsogo/conan/labels{/name}","releases_url":"https://api.github.com/repos/jgsogo/conan/releases{/id}","deployments_url":"https://api.github.com/repos/jgsogo/conan/deployments","created_at":"2018-07-10T08:45:31Z","updated_at":"2018-09-04T15:52:53Z","pushed_at":"2018-09-05T15:56:40Z","git_url":"git://github.com/jgsogo/conan.git","ssh_url":"git@github.com:jgsogo/conan.git","clone_url":"https://github.com/jgsogo/conan.git","svn_url":"https://github.com/jgsogo/conan","homepage":"https://conan.io","size":5635,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":1,"watchers":0,"default_branch":"develop"}},"_links":{"self":{"href":"https://api.github.com/repos/jgsogo/conan/pulls/2"},"html":{"href":"https://github.com/jgsogo/conan/pull/2"},"issue":{"href":"https://api.github.com/repos/jgsogo/conan/issues/2"},"comments":{"href":"https://api.github.com/repos/jgsogo/conan/issues/2/comments"},"review_comments":{"href":"https://api.github.com/repos/jgsogo/conan/pulls/2/comments"},"review_comment":{"href":"https://api.github.com/repos/jgsogo/conan/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jgsogo/conan/pulls/2/commits"},"statuses":{"href":"https://api.github.com/repos/jgsogo/conan/statuses/cea22a41840056fe0ba06b8bf853d2f7b689a5cc"}},"author_association":"NONE"}}
{"actor":{"display_login":"jgsogo"}}