{"action":"created","issue":{"url":"https://api.github.com/repos/awslabs/amazon-redshift-utils/issues/261","repository_url":"https://api.github.com/repos/awslabs/amazon-redshift-utils","labels_url":"https://api.github.com/repos/awslabs/amazon-redshift-utils/issues/261/labels{/name}","comments_url":"https://api.github.com/repos/awslabs/amazon-redshift-utils/issues/261/comments","events_url":"https://api.github.com/repos/awslabs/amazon-redshift-utils/issues/261/events","html_url":"https://github.com/awslabs/amazon-redshift-utils/issues/261","id":294927173,"number":261,"title":"Fail Fast if query fails","user":{"login":"etspaceman","id":630953,"avatar_url":"https://avatars1.githubusercontent.com/u/630953?v=4","gravatar_id":"","url":"https://api.github.com/users/etspaceman","html_url":"https://github.com/etspaceman","followers_url":"https://api.github.com/users/etspaceman/followers","following_url":"https://api.github.com/users/etspaceman/following{/other_user}","gists_url":"https://api.github.com/users/etspaceman/gists{/gist_id}","starred_url":"https://api.github.com/users/etspaceman/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/etspaceman/subscriptions","organizations_url":"https://api.github.com/users/etspaceman/orgs","repos_url":"https://api.github.com/users/etspaceman/repos","events_url":"https://api.github.com/users/etspaceman/events{/privacy}","received_events_url":"https://api.github.com/users/etspaceman/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-06T21:56:50Z","updated_at":"2018-02-07T00:19:21Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"If a query fails in the analyze-vacuum Redshift utility, it currently continues on to the next query. Setting up alerting based on exit codes on this job is difficult as only the logs themselves will indicate the error. It also seems less-than ideal to continue processing if queries are failing.\r\n\r\nThe script should _at least_ introduce an option to fail-fast, if not fail-fast by default, if a query fails. If enabled, it should also throw an exception so that the application properly displays an exit code. "},"comment":{"url":"https://api.github.com/repos/awslabs/amazon-redshift-utils/issues/comments/363611944","html_url":"https://github.com/awslabs/amazon-redshift-utils/issues/261#issuecomment-363611944","issue_url":"https://api.github.com/repos/awslabs/amazon-redshift-utils/issues/261","id":363611944,"user":{"login":"IanMeyers","id":6339696,"avatar_url":"https://avatars3.githubusercontent.com/u/6339696?v=4","gravatar_id":"","url":"https://api.github.com/users/IanMeyers","html_url":"https://github.com/IanMeyers","followers_url":"https://api.github.com/users/IanMeyers/followers","following_url":"https://api.github.com/users/IanMeyers/following{/other_user}","gists_url":"https://api.github.com/users/IanMeyers/gists{/gist_id}","starred_url":"https://api.github.com/users/IanMeyers/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/IanMeyers/subscriptions","organizations_url":"https://api.github.com/users/IanMeyers/orgs","repos_url":"https://api.github.com/users/IanMeyers/repos","events_url":"https://api.github.com/users/IanMeyers/events{/privacy}","received_events_url":"https://api.github.com/users/IanMeyers/received_events","type":"User","site_admin":false},"created_at":"2018-02-07T00:19:21Z","updated_at":"2018-02-07T00:19:21Z","author_association":"CONTRIBUTOR","body":"Agreed - and as far as I can see all query level script execution exposes all native Exceptions (see https://github.com/awslabs/amazon-redshift-utils/blob/master/src/AnalyzeVacuumUtility/lib/analyze_vacuum.py#L51). Command execution however does swallow errors, which is probably wrong (https://github.com/awslabs/amazon-redshift-utils/blob/master/src/AnalyzeVacuumUtility/lib/analyze_vacuum.py#L169).\r\n\r\nWhere are you seeing the exception occur?"}}
{"actor":{"display_login":"IanMeyers"}}