{"action":"created","comment":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/comments/167192567","pull_request_review_id":95376704,"id":167192567,"diff_hunk":"@@ -29,23 +29,39 @@\n \n #include \"testutil.hpp\"\n \n-int main (void)\n+typedef void (*extra_func_t) (void *socket);\n+\n+void set_sockopt_fastpath (void *socket)\n+{\n+    int value = 1;\n+    int rc =\n+      zmq_setsockopt (socket, ZMQ_LOOPBACK_FASTPATH, &value, sizeof value);","path":"tests/test_pair_tcp.cpp","position":11,"original_position":11,"commit_id":"3a82419b2174b8247531259afe3808f7b0389f0f","original_commit_id":"3a82419b2174b8247531259afe3808f7b0389f0f","user":{"login":"bluca","id":782193,"avatar_url":"https://avatars3.githubusercontent.com/u/782193?v=4","gravatar_id":"","url":"https://api.github.com/users/bluca","html_url":"https://github.com/bluca","followers_url":"https://api.github.com/users/bluca/followers","following_url":"https://api.github.com/users/bluca/following{/other_user}","gists_url":"https://api.github.com/users/bluca/gists{/gist_id}","starred_url":"https://api.github.com/users/bluca/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bluca/subscriptions","organizations_url":"https://api.github.com/users/bluca/orgs","repos_url":"https://api.github.com/users/bluca/repos","events_url":"https://api.github.com/users/bluca/events{/privacy}","received_events_url":"https://api.github.com/users/bluca/received_events","type":"User","site_admin":false},"body":"```\r\n../tests/test_pair_tcp.cpp: In function ‘void set_sockopt_fastpath(void*)’:\r\n../tests/test_pair_tcp.cpp:38:31: error: ‘ZMQ_LOOPBACK_FASTPATH’ was not declared in this scope\r\n       zmq_setsockopt (socket, ZMQ_LOOPBACK_FASTPATH, &value, sizeof value);\r\n```\r\n\r\nIt also needs to be ifdefd for drafts","created_at":"2018-02-09T10:33:33Z","updated_at":"2018-02-09T10:33:33Z","html_url":"https://github.com/zeromq/libzmq/pull/2923#discussion_r167192567","pull_request_url":"https://api.github.com/repos/zeromq/libzmq/pulls/2923","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/comments/167192567"},"html":{"href":"https://github.com/zeromq/libzmq/pull/2923#discussion_r167192567"},"pull_request":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/2923"}},"in_reply_to_id":167079655},"pull_request":{"url":"https://api.github.com/repos/zeromq/libzmq/pulls/2923","id":167195596,"html_url":"https://github.com/zeromq/libzmq/pull/2923","diff_url":"https://github.com/zeromq/libzmq/pull/2923.diff","patch_url":"https://github.com/zeromq/libzmq/pull/2923.patch","issue_url":"https://api.github.com/repos/zeromq/libzmq/issues/2923","number":2923,"state":"open","locked":false,"title":"Add support for SIO_LOOPBACK_FAST_PATH on Windows","user":{"login":"sigiesec","id":16757805,"avatar_url":"https://avatars0.githubusercontent.com/u/16757805?v=4","gravatar_id":"","url":"https://api.github.com/users/sigiesec","html_url":"https://github.com/sigiesec","followers_url":"https://api.github.com/users/sigiesec/followers","following_url":"https://api.github.com/users/sigiesec/following{/other_user}","gists_url":"https://api.github.com/users/sigiesec/gists{/gist_id}","starred_url":"https://api.github.com/users/sigiesec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigiesec/subscriptions","organizations_url":"https://api.github.com/users/sigiesec/orgs","repos_url":"https://api.github.com/users/sigiesec/repos","events_url":"https://api.github.com/users/sigiesec/events{/privacy}","received_events_url":"https://api.github.com/users/sigiesec/received_events","type":"User","site_admin":false},"body":"Fixes #2899 \r\n\r\nThis PR requires #2908 to be merged first.","created_at":"2018-02-05T16:45:10Z","updated_at":"2018-02-09T10:33:33Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b1687147e3551b8acbade2befb6cfa5d61fafe21","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"milestone":null,"commits_url":"https://api.github.com/repos/zeromq/libzmq/pulls/2923/commits","review_comments_url":"https://api.github.com/repos/zeromq/libzmq/pulls/2923/comments","review_comment_url":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zeromq/libzmq/issues/2923/comments","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/3a82419b2174b8247531259afe3808f7b0389f0f","head":{"label":"sigiesec:fastpath","ref":"fastpath","sha":"3a82419b2174b8247531259afe3808f7b0389f0f","user":{"login":"sigiesec","id":16757805,"avatar_url":"https://avatars0.githubusercontent.com/u/16757805?v=4","gravatar_id":"","url":"https://api.github.com/users/sigiesec","html_url":"https://github.com/sigiesec","followers_url":"https://api.github.com/users/sigiesec/followers","following_url":"https://api.github.com/users/sigiesec/following{/other_user}","gists_url":"https://api.github.com/users/sigiesec/gists{/gist_id}","starred_url":"https://api.github.com/users/sigiesec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigiesec/subscriptions","organizations_url":"https://api.github.com/users/sigiesec/orgs","repos_url":"https://api.github.com/users/sigiesec/repos","events_url":"https://api.github.com/users/sigiesec/events{/privacy}","received_events_url":"https://api.github.com/users/sigiesec/received_events","type":"User","site_admin":false},"repo":{"id":50349567,"name":"libzmq","full_name":"sigiesec/libzmq","owner":{"login":"sigiesec","id":16757805,"avatar_url":"https://avatars0.githubusercontent.com/u/16757805?v=4","gravatar_id":"","url":"https://api.github.com/users/sigiesec","html_url":"https://github.com/sigiesec","followers_url":"https://api.github.com/users/sigiesec/followers","following_url":"https://api.github.com/users/sigiesec/following{/other_user}","gists_url":"https://api.github.com/users/sigiesec/gists{/gist_id}","starred_url":"https://api.github.com/users/sigiesec/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sigiesec/subscriptions","organizations_url":"https://api.github.com/users/sigiesec/orgs","repos_url":"https://api.github.com/users/sigiesec/repos","events_url":"https://api.github.com/users/sigiesec/events{/privacy}","received_events_url":"https://api.github.com/users/sigiesec/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/sigiesec/libzmq","description":"ZeroMQ core engine in C++, implements ZMTP/3.0","fork":true,"url":"https://api.github.com/repos/sigiesec/libzmq","forks_url":"https://api.github.com/repos/sigiesec/libzmq/forks","keys_url":"https://api.github.com/repos/sigiesec/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/sigiesec/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/sigiesec/libzmq/teams","hooks_url":"https://api.github.com/repos/sigiesec/libzmq/hooks","issue_events_url":"https://api.github.com/repos/sigiesec/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/sigiesec/libzmq/events","assignees_url":"https://api.github.com/repos/sigiesec/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/sigiesec/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/sigiesec/libzmq/tags","blobs_url":"https://api.github.com/repos/sigiesec/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/sigiesec/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/sigiesec/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/sigiesec/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/sigiesec/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/sigiesec/libzmq/languages","stargazers_url":"https://api.github.com/repos/sigiesec/libzmq/stargazers","contributors_url":"https://api.github.com/repos/sigiesec/libzmq/contributors","subscribers_url":"https://api.github.com/repos/sigiesec/libzmq/subscribers","subscription_url":"https://api.github.com/repos/sigiesec/libzmq/subscription","commits_url":"https://api.github.com/repos/sigiesec/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/sigiesec/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/sigiesec/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/sigiesec/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/sigiesec/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/sigiesec/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/sigiesec/libzmq/merges","archive_url":"https://api.github.com/repos/sigiesec/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/sigiesec/libzmq/downloads","issues_url":"https://api.github.com/repos/sigiesec/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/sigiesec/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/sigiesec/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/sigiesec/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/sigiesec/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/sigiesec/libzmq/releases{/id}","deployments_url":"https://api.github.com/repos/sigiesec/libzmq/deployments","created_at":"2016-01-25T12:35:42Z","updated_at":"2016-01-25T12:35:44Z","pushed_at":"2018-02-09T10:18:27Z","git_url":"git://github.com/sigiesec/libzmq.git","ssh_url":"git@github.com:sigiesec/libzmq.git","clone_url":"https://github.com/sigiesec/libzmq.git","svn_url":"https://github.com/sigiesec/libzmq","homepage":"http://www.zeromq.org","size":17269,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"zeromq:master","ref":"master","sha":"b77d7610cd91dbe25096b804c77b27065b7dd1fd","user":{"login":"zeromq","id":109777,"avatar_url":"https://avatars0.githubusercontent.com/u/109777?v=4","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"repo":{"id":263379,"name":"libzmq","full_name":"zeromq/libzmq","owner":{"login":"zeromq","id":109777,"avatar_url":"https://avatars0.githubusercontent.com/u/109777?v=4","gravatar_id":"","url":"https://api.github.com/users/zeromq","html_url":"https://github.com/zeromq","followers_url":"https://api.github.com/users/zeromq/followers","following_url":"https://api.github.com/users/zeromq/following{/other_user}","gists_url":"https://api.github.com/users/zeromq/gists{/gist_id}","starred_url":"https://api.github.com/users/zeromq/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zeromq/subscriptions","organizations_url":"https://api.github.com/users/zeromq/orgs","repos_url":"https://api.github.com/users/zeromq/repos","events_url":"https://api.github.com/users/zeromq/events{/privacy}","received_events_url":"https://api.github.com/users/zeromq/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zeromq/libzmq","description":"ZeroMQ core engine in C++, implements ZMTP/3.0","fork":false,"url":"https://api.github.com/repos/zeromq/libzmq","forks_url":"https://api.github.com/repos/zeromq/libzmq/forks","keys_url":"https://api.github.com/repos/zeromq/libzmq/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zeromq/libzmq/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zeromq/libzmq/teams","hooks_url":"https://api.github.com/repos/zeromq/libzmq/hooks","issue_events_url":"https://api.github.com/repos/zeromq/libzmq/issues/events{/number}","events_url":"https://api.github.com/repos/zeromq/libzmq/events","assignees_url":"https://api.github.com/repos/zeromq/libzmq/assignees{/user}","branches_url":"https://api.github.com/repos/zeromq/libzmq/branches{/branch}","tags_url":"https://api.github.com/repos/zeromq/libzmq/tags","blobs_url":"https://api.github.com/repos/zeromq/libzmq/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zeromq/libzmq/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zeromq/libzmq/git/refs{/sha}","trees_url":"https://api.github.com/repos/zeromq/libzmq/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zeromq/libzmq/statuses/{sha}","languages_url":"https://api.github.com/repos/zeromq/libzmq/languages","stargazers_url":"https://api.github.com/repos/zeromq/libzmq/stargazers","contributors_url":"https://api.github.com/repos/zeromq/libzmq/contributors","subscribers_url":"https://api.github.com/repos/zeromq/libzmq/subscribers","subscription_url":"https://api.github.com/repos/zeromq/libzmq/subscription","commits_url":"https://api.github.com/repos/zeromq/libzmq/commits{/sha}","git_commits_url":"https://api.github.com/repos/zeromq/libzmq/git/commits{/sha}","comments_url":"https://api.github.com/repos/zeromq/libzmq/comments{/number}","issue_comment_url":"https://api.github.com/repos/zeromq/libzmq/issues/comments{/number}","contents_url":"https://api.github.com/repos/zeromq/libzmq/contents/{+path}","compare_url":"https://api.github.com/repos/zeromq/libzmq/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zeromq/libzmq/merges","archive_url":"https://api.github.com/repos/zeromq/libzmq/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zeromq/libzmq/downloads","issues_url":"https://api.github.com/repos/zeromq/libzmq/issues{/number}","pulls_url":"https://api.github.com/repos/zeromq/libzmq/pulls{/number}","milestones_url":"https://api.github.com/repos/zeromq/libzmq/milestones{/number}","notifications_url":"https://api.github.com/repos/zeromq/libzmq/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zeromq/libzmq/labels{/name}","releases_url":"https://api.github.com/repos/zeromq/libzmq/releases{/id}","deployments_url":"https://api.github.com/repos/zeromq/libzmq/deployments","created_at":"2009-07-29T09:56:41Z","updated_at":"2018-02-09T05:44:47Z","pushed_at":"2018-02-09T09:49:19Z","git_url":"git://github.com/zeromq/libzmq.git","ssh_url":"git@github.com:zeromq/libzmq.git","clone_url":"https://github.com/zeromq/libzmq.git","svn_url":"https://github.com/zeromq/libzmq","homepage":"http://www.zeromq.org","size":17201,"stargazers_count":3977,"watchers_count":3977,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":false,"has_wiki":false,"has_pages":false,"forks_count":1228,"mirror_url":null,"archived":false,"open_issues_count":202,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":1228,"open_issues":202,"watchers":3977,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/2923"},"html":{"href":"https://github.com/zeromq/libzmq/pull/2923"},"issue":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/2923"},"comments":{"href":"https://api.github.com/repos/zeromq/libzmq/issues/2923/comments"},"review_comments":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/2923/comments"},"review_comment":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zeromq/libzmq/pulls/2923/commits"},"statuses":{"href":"https://api.github.com/repos/zeromq/libzmq/statuses/3a82419b2174b8247531259afe3808f7b0389f0f"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"bluca"}}