{"action":"created","issue":{"url":"https://api.github.com/repos/zaklaus/rurik/issues/1","repository_url":"https://api.github.com/repos/zaklaus/rurik","labels_url":"https://api.github.com/repos/zaklaus/rurik/issues/1/labels{/name}","comments_url":"https://api.github.com/repos/zaklaus/rurik/issues/1/comments","events_url":"https://api.github.com/repos/zaklaus/rurik/issues/1/events","html_url":"https://github.com/zaklaus/rurik/issues/1","id":394060318,"node_id":"MDU6SXNzdWUzOTQwNjAzMTg=","number":1,"title":"Implement lighting","user":{"login":"zaklaus","id":9026786,"node_id":"MDQ6VXNlcjkwMjY3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9026786?v=4","gravatar_id":"","url":"https://api.github.com/users/zaklaus","html_url":"https://github.com/zaklaus","followers_url":"https://api.github.com/users/zaklaus/followers","following_url":"https://api.github.com/users/zaklaus/following{/other_user}","gists_url":"https://api.github.com/users/zaklaus/gists{/gist_id}","starred_url":"https://api.github.com/users/zaklaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaklaus/subscriptions","organizations_url":"https://api.github.com/users/zaklaus/orgs","repos_url":"https://api.github.com/users/zaklaus/repos","events_url":"https://api.github.com/users/zaklaus/events{/privacy}","received_events_url":"https://api.github.com/users/zaklaus/received_events","type":"User","site_admin":false},"labels":[{"id":1170138326,"node_id":"MDU6TGFiZWwxMTcwMTM4MzI2","url":"https://api.github.com/repos/zaklaus/rurik/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"state":"open","locked":false,"assignee":{"login":"zaklaus","id":9026786,"node_id":"MDQ6VXNlcjkwMjY3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9026786?v=4","gravatar_id":"","url":"https://api.github.com/users/zaklaus","html_url":"https://github.com/zaklaus","followers_url":"https://api.github.com/users/zaklaus/followers","following_url":"https://api.github.com/users/zaklaus/following{/other_user}","gists_url":"https://api.github.com/users/zaklaus/gists{/gist_id}","starred_url":"https://api.github.com/users/zaklaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaklaus/subscriptions","organizations_url":"https://api.github.com/users/zaklaus/orgs","repos_url":"https://api.github.com/users/zaklaus/repos","events_url":"https://api.github.com/users/zaklaus/events{/privacy}","received_events_url":"https://api.github.com/users/zaklaus/received_events","type":"User","site_admin":false},"assignees":[{"login":"zaklaus","id":9026786,"node_id":"MDQ6VXNlcjkwMjY3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9026786?v=4","gravatar_id":"","url":"https://api.github.com/users/zaklaus","html_url":"https://github.com/zaklaus","followers_url":"https://api.github.com/users/zaklaus/followers","following_url":"https://api.github.com/users/zaklaus/following{/other_user}","gists_url":"https://api.github.com/users/zaklaus/gists{/gist_id}","starred_url":"https://api.github.com/users/zaklaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaklaus/subscriptions","organizations_url":"https://api.github.com/users/zaklaus/orgs","repos_url":"https://api.github.com/users/zaklaus/repos","events_url":"https://api.github.com/users/zaklaus/events{/privacy}","received_events_url":"https://api.github.com/users/zaklaus/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-12-26T01:10:54Z","updated_at":"2018-12-26T08:01:04Z","closed_at":null,"author_association":"OWNER","body":"Ideally, the lighting solution should be a composition of several rendered layers.\r\n\r\nThose are:\r\n- Ambient lighting, which is already implemented as a part of the weather system.\r\n- Additive lighting, which adds color information on top of our ambient color.\r\n- Multiplicative lighting, which will mix with the existing colors and provide more immersive and smooth application of light information onto the surface.\r\n- AO, we can generate ambient occlusion off of an object and mix it with the surface, adding a depth to the solution.\r\n- Real-time shadows, a tough one to consider, shadows are really a question of game design itself and their incorporation depends per case. Raytraced shadows could work, we could also use pre-drawn shadows and blur them out according to their distance from the caster, leading to neat blurred shadows applied on top of our solution.\r\n- Bloom, already implemented in as a proof of concept, needs HDR support to analyze bright data properly."},"comment":{"url":"https://api.github.com/repos/zaklaus/rurik/issues/comments/449924742","html_url":"https://github.com/zaklaus/rurik/issues/1#issuecomment-449924742","issue_url":"https://api.github.com/repos/zaklaus/rurik/issues/1","id":449924742,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0OTkyNDc0Mg==","user":{"login":"zaklaus","id":9026786,"node_id":"MDQ6VXNlcjkwMjY3ODY=","avatar_url":"https://avatars0.githubusercontent.com/u/9026786?v=4","gravatar_id":"","url":"https://api.github.com/users/zaklaus","html_url":"https://github.com/zaklaus","followers_url":"https://api.github.com/users/zaklaus/followers","following_url":"https://api.github.com/users/zaklaus/following{/other_user}","gists_url":"https://api.github.com/users/zaklaus/gists{/gist_id}","starred_url":"https://api.github.com/users/zaklaus/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zaklaus/subscriptions","organizations_url":"https://api.github.com/users/zaklaus/orgs","repos_url":"https://api.github.com/users/zaklaus/repos","events_url":"https://api.github.com/users/zaklaus/events{/privacy}","received_events_url":"https://api.github.com/users/zaklaus/received_events","type":"User","site_admin":false},"created_at":"2018-12-26T08:01:04Z","updated_at":"2018-12-26T08:01:04Z","author_association":"OWNER","body":"AO support was added: \r\n![image](https://user-images.githubusercontent.com/9026786/50438076-bd22f680-08ec-11e9-8128-ba2a51f83ee7.png)\r\n"}}
{"actor":{"display_login":"zaklaus"}}