{"push_id":2520135881,"size":1,"distinct_size":1,"ref":"refs/heads/master","head":"b75abf5bb636869fd893ecf98414b8b2fe0d4a12","before":"a914a7c95895161c99533d5919b8504b37ea54a0","commits":[{"sha":"b75abf5bb636869fd893ecf98414b8b2fe0d4a12","author":{"name":"Andrzej Kaczmarek","email":"e629a10adbe722145f074acb1ca27e72d94cfcb5@codecoup.pl"},"message":"Fix remote 'g' command error handling (PR remote/9665)\n\n'g' command returns hex-string as response so simply checking for 'E'\nto determine if it failed is not enough and can trigger spurious error\nmessages.  For example, invalid behaviour can be easily triggered on\nCortex-M as follows:\n\n  (gdb) set $r0 = 0xe0\n  Sending packet: $P0=e0000000#72...Packet received: OK\n  Packet P (set-register) is supported\n  Sending packet: $g#67...Packet received: E0000000849A0020...\n  Remote failure reply: E0000000849A0020...\n\nThis patch fixes the problem by calling putpkt()/getpkt() directly and\nchecking result with packet_check_result().  This works fine since Enn\nresponse has odd number of bytes while proper response has even number\nof bytes.\n\nAlso, remote_send() is now not used anywhere so it can be removed.\n\ngdb/Changelog:\n2018-04-26  Andrzej Kaczmarek  <andrzej.kaczmarek@codecoup.pl>\n\n\tPR remote/9665\n\t* remote.c (send_g_packet): Use putpkt/getpkt/packet_check_result\n\tinstead of remote_send.\n\t(remote_send): Remove.","distinct":true,"url":"https://api.github.com/repos/fskjdflaskjh/binutils-gdb/commits/b75abf5bb636869fd893ecf98414b8b2fe0d4a12"}]}
{"actor":{"display_login":"fskjdflaskjh"}}