{"action":"created","issue":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/615","repository_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool","labels_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/615/labels{/name}","comments_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/615/comments","events_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/615/events","html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/615","id":296429015,"number":615,"title":"QPPCT-655: Filter out duplicate templateId elements","user":{"login":"halprin","id":16943066,"avatar_url":"https://avatars0.githubusercontent.com/u/16943066?v=4","gravatar_id":"","url":"https://api.github.com/users/halprin","html_url":"https://github.com/halprin","followers_url":"https://api.github.com/users/halprin/followers","following_url":"https://api.github.com/users/halprin/following{/other_user}","gists_url":"https://api.github.com/users/halprin/gists{/gist_id}","starred_url":"https://api.github.com/users/halprin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/halprin/subscriptions","organizations_url":"https://api.github.com/users/halprin/orgs","repos_url":"https://api.github.com/users/halprin/repos","events_url":"https://api.github.com/users/halprin/events{/privacy}","received_events_url":"https://api.github.com/users/halprin/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-02-12T16:04:32Z","updated_at":"2018-02-12T17:37:56Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/pulls/615","html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/615","diff_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/615.diff","patch_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/615.patch"},"body":"### Information\r\n- JIRA story QPPCT-655.\r\n\r\n### Changes proposed in this PR:\r\n- Filter out duplicate template IDs when decoding.\r\n  - This reduces the number of extraneous decoded `Node`s when a user accidentally includes extra `templateId` elements.\r\n- A test.\r\n- In the QRDA3 file attached to the original issue, it drops the number of issues from \"holy cow, just start over on that file\" to 2!\r\n\r\n### Checklist \r\n- [X] All JUnit tests pass (`mvn clean verify`).\r\n- [X] New unit tests written to cover new functionality.\r\n- [X] Added and updated JavaDocs for non-test classes and methods.\r\n- [X] No local design debt. Do you feel that something is \"ugly\" after your changes?\r\n- [X] Updated documentation (`README.md`, etc.) depending if the changes require it.\r\n"},"comment":{"url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/comments/365000680","html_url":"https://github.com/CMSgov/qpp-conversion-tool/pull/615#issuecomment-365000680","issue_url":"https://api.github.com/repos/CMSgov/qpp-conversion-tool/issues/615","id":365000680,"user":{"login":"FlexionSonarQube","id":28455477,"avatar_url":"https://avatars0.githubusercontent.com/u/28455477?v=4","gravatar_id":"","url":"https://api.github.com/users/FlexionSonarQube","html_url":"https://github.com/FlexionSonarQube","followers_url":"https://api.github.com/users/FlexionSonarQube/followers","following_url":"https://api.github.com/users/FlexionSonarQube/following{/other_user}","gists_url":"https://api.github.com/users/FlexionSonarQube/gists{/gist_id}","starred_url":"https://api.github.com/users/FlexionSonarQube/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FlexionSonarQube/subscriptions","organizations_url":"https://api.github.com/users/FlexionSonarQube/orgs","repos_url":"https://api.github.com/users/FlexionSonarQube/repos","events_url":"https://api.github.com/users/FlexionSonarQube/events{/privacy}","received_events_url":"https://api.github.com/users/FlexionSonarQube/received_events","type":"User","site_admin":false},"created_at":"2018-02-12T17:37:56Z","updated_at":"2018-02-12T17:37:56Z","author_association":"COLLABORATOR","body":"SonarQube analysis reported 2 issues\n* ![MAJOR][MAJOR] 1 major\n* ![MINOR][MINOR] 1 minor\n\nWatch the comments in this conversation to review them.\n\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"FlexionSonarQube"}}