{"action":"created","issue":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43859","repository_url":"https://api.github.com/repos/NixOS/nixpkgs","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43859/labels{/name}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43859/comments","events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43859/events","html_url":"https://github.com/NixOS/nixpkgs/pull/43859","id":343198490,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAyOTE4NjQz","number":43859,"title":"appleseed: Fix non-executable items and Python bindings","user":{"login":"Hodapp87","id":896431,"node_id":"MDQ6VXNlcjg5NjQzMQ==","avatar_url":"https://avatars2.githubusercontent.com/u/896431?v=4","gravatar_id":"","url":"https://api.github.com/users/Hodapp87","html_url":"https://github.com/Hodapp87","followers_url":"https://api.github.com/users/Hodapp87/followers","following_url":"https://api.github.com/users/Hodapp87/following{/other_user}","gists_url":"https://api.github.com/users/Hodapp87/gists{/gist_id}","starred_url":"https://api.github.com/users/Hodapp87/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Hodapp87/subscriptions","organizations_url":"https://api.github.com/users/Hodapp87/orgs","repos_url":"https://api.github.com/users/Hodapp87/repos","events_url":"https://api.github.com/users/Hodapp87/events{/privacy}","received_events_url":"https://api.github.com/users/Hodapp87/received_events","type":"User","site_admin":false},"labels":[{"id":737642262,"node_id":"MDU6TGFiZWw3Mzc2NDIyNjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%200","name":"10.rebuild-darwin: 0","color":"eeffee","default":false},{"id":731733923,"node_id":"MDU6TGFiZWw3MzE3MzM5MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%201-10","name":"10.rebuild-linux: 1-10","color":"eeffee","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-07-20T18:04:29Z","updated_at":"2018-07-20T19:33:50Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/43859","html_url":"https://github.com/NixOS/nixpkgs/pull/43859","diff_url":"https://github.com/NixOS/nixpkgs/pull/43859.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/43859.patch"},"body":"###### Motivation for this change\r\n\r\nI realized a few things:\r\n\r\n- I wasn't actually building the Python bindings to Appleseed because Boost was missing Python bindings and because I was using the wrong CMake flags (and this made some comments also wrong)\r\n- The build was failing to mark some things executable in the `bin` directory (which I didn't realize were even supposed to be executable), and this was breaking some less-obvious features when using Appleseed with Blender via Blenderseed.\r\n\r\n###### Things done\r\n\r\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\r\n\r\n- [X] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\r\n- Built on platform(s)\r\n   - [X] NixOS\r\n   - [ ] macOS\r\n   - [ ] other Linux distributions\r\n- [X] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\r\n- [X] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\r\n- [X] Tested execution of all binary files (usually in `./result/bin/`)\r\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\r\n- [X] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\r\n\r\n---\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments/406705269","html_url":"https://github.com/NixOS/nixpkgs/pull/43859#issuecomment-406705269","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/43859","id":406705269,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjcwNTI2OQ==","user":{"login":"FRidh","id":2129135,"node_id":"MDQ6VXNlcjIxMjkxMzU=","avatar_url":"https://avatars3.githubusercontent.com/u/2129135?v=4","gravatar_id":"","url":"https://api.github.com/users/FRidh","html_url":"https://github.com/FRidh","followers_url":"https://api.github.com/users/FRidh/followers","following_url":"https://api.github.com/users/FRidh/following{/other_user}","gists_url":"https://api.github.com/users/FRidh/gists{/gist_id}","starred_url":"https://api.github.com/users/FRidh/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/FRidh/subscriptions","organizations_url":"https://api.github.com/users/FRidh/orgs","repos_url":"https://api.github.com/users/FRidh/repos","events_url":"https://api.github.com/users/FRidh/events{/privacy}","received_events_url":"https://api.github.com/users/FRidh/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T19:33:50Z","updated_at":"2018-07-20T19:33:50Z","author_association":"MEMBER","body":"`disabledIf isPy3k` can be used in case the Python 3 bindings don't function."}}
{"actor":{"display_login":"FRidh"}}