{"action":"created","issue":{"url":"https://api.github.com/repos/ansible/ansible/issues/18558","repository_url":"https://api.github.com/repos/ansible/ansible","labels_url":"https://api.github.com/repos/ansible/ansible/issues/18558/labels{/name}","comments_url":"https://api.github.com/repos/ansible/ansible/issues/18558/comments","events_url":"https://api.github.com/repos/ansible/ansible/issues/18558/events","html_url":"https://github.com/ansible/ansible/pull/18558","id":190521023,"number":18558,"title":"Fix broken authentication for GCE modules (#17075)","user":{"login":"laurentgo","id":677448,"avatar_url":"https://avatars0.githubusercontent.com/u/677448?v=4","gravatar_id":"","url":"https://api.github.com/users/laurentgo","html_url":"https://github.com/laurentgo","followers_url":"https://api.github.com/users/laurentgo/followers","following_url":"https://api.github.com/users/laurentgo/following{/other_user}","gists_url":"https://api.github.com/users/laurentgo/gists{/gist_id}","starred_url":"https://api.github.com/users/laurentgo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/laurentgo/subscriptions","organizations_url":"https://api.github.com/users/laurentgo/orgs","repos_url":"https://api.github.com/users/laurentgo/repos","events_url":"https://api.github.com/users/laurentgo/events{/privacy}","received_events_url":"https://api.github.com/users/laurentgo/received_events","type":"User","site_admin":false},"labels":[{"id":454885231,"url":"https://api.github.com/repos/ansible/ansible/labels/affects_2.3","name":"affects_2.3","color":"5319e7","default":false},{"id":785271699,"url":"https://api.github.com/repos/ansible/ansible/labels/bug","name":"bug","color":"fbca04","default":true},{"id":499635167,"url":"https://api.github.com/repos/ansible/ansible/labels/c:module_utils/","name":"c:module_utils/","color":"b60205","default":false},{"id":512427836,"url":"https://api.github.com/repos/ansible/ansible/labels/module_util","name":"module_util","color":"ededed","default":false},{"id":231201931,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_rebase","name":"needs_rebase","color":"eb6420","default":false},{"id":61436281,"url":"https://api.github.com/repos/ansible/ansible/labels/needs_revision","name":"needs_revision","color":"eb6450","default":false},{"id":581543918,"url":"https://api.github.com/repos/ansible/ansible/labels/stale_ci","name":"stale_ci","color":"fef2c0","default":false},{"id":636352796,"url":"https://api.github.com/repos/ansible/ansible/labels/support:core","name":"support:core","color":"ededed","default":false}],"state":"closed","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2016-11-19T21:18:07Z","updated_at":"2018-05-30T16:11:42Z","closed_at":"2018-05-30T16:11:42Z","author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/ansible/ansible/pulls/18558","html_url":"https://github.com/ansible/ansible/pull/18558","diff_url":"https://github.com/ansible/ansible/pull/18558.diff","patch_url":"https://github.com/ansible/ansible/pull/18558.patch"},"body":"##### ISSUE TYPE\r\n - Bugfix Pull Request\r\n\r\n##### COMPONENT NAME\r\ngce module\r\n\r\n##### ANSIBLE VERSION\r\n```\r\nansible --version\r\nansible 2.2.0.0\r\n  config file = /etc/ansible/ansible.cfg\r\n  configured module search path = Default w/o overrides\r\n```\r\n\r\n##### SUMMARY\r\nFixes #17075\r\n\r\nGCE internal authorization or installed application authentications stopped working when checking if the credentials_file is actually a JSON file.\r\n\r\nThe reason for this check is to make sure that the current version of libcloud supports JSON file, but the content itself is not checked, nor is the module failing if the file is not a JSON file.\r\n\r\nThis change reverts to the previous behaviour before the check was introduced which is to ignore if the file doesn't exist and to let libcloud module detect which kind of authentication is used. It also fixes module arguments being ignored if configured for internal authorization (use of empty strings as stated in Ansible documentation)."},"comment":{"url":"https://api.github.com/repos/ansible/ansible/issues/comments/393221350","html_url":"https://github.com/ansible/ansible/pull/18558#issuecomment-393221350","issue_url":"https://api.github.com/repos/ansible/ansible/issues/18558","id":393221350,"user":{"login":"s-hertel","id":19572925,"avatar_url":"https://avatars2.githubusercontent.com/u/19572925?v=4","gravatar_id":"","url":"https://api.github.com/users/s-hertel","html_url":"https://github.com/s-hertel","followers_url":"https://api.github.com/users/s-hertel/followers","following_url":"https://api.github.com/users/s-hertel/following{/other_user}","gists_url":"https://api.github.com/users/s-hertel/gists{/gist_id}","starred_url":"https://api.github.com/users/s-hertel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/s-hertel/subscriptions","organizations_url":"https://api.github.com/users/s-hertel/orgs","repos_url":"https://api.github.com/users/s-hertel/repos","events_url":"https://api.github.com/users/s-hertel/events{/privacy}","received_events_url":"https://api.github.com/users/s-hertel/received_events","type":"User","site_admin":false},"created_at":"2018-05-30T16:11:42Z","updated_at":"2018-05-30T16:11:42Z","author_association":"CONTRIBUTOR","body":"This should be fixed in 2.4 by f5f6cf467e2411c92a13f6ddd827a6cb405a69ea."}}
{"actor":{"display_login":"s-hertel"}}