{"action":"created","comment":{"url":"https://api.github.com/repos/hail-is/hail/pulls/comments/230784831","pull_request_review_id":171599479,"id":230784831,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMDc4NDgzMQ==","diff_hunk":"@@ -614,12 +615,12 @@ class HailContext private(val sc: SparkContext,\n \n   def readRows(\n     path: String,\n-    t: TStruct,\n+    t: PStruct,\n     codecSpec: CodecSpec,\n     partFiles: Array[String],\n     requestedType: TStruct\n   ): ContextRDD[RVDContext, RegionValue] = {\n-    val makeDec = codecSpec.buildDecoder(t.physicalType, requestedType.physicalType)\n+    val makeDec = codecSpec.buildDecoder(t, requestedType)","path":"hail/src/main/scala/is/hail/HailContext.scala","position":19,"original_position":19,"commit_id":"5c65c43183674af961434634c2aba66da3c008f8","original_commit_id":"5c65c43183674af961434634c2aba66da3c008f8","user":{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"body":"Great.  And eventually `t` will become an encoded type and the decoder will specify its physical type.","created_at":"2018-11-05T15:10:30Z","updated_at":"2018-11-05T15:15:02Z","html_url":"https://github.com/hail-is/hail/pull/4721#discussion_r230784831","pull_request_url":"https://api.github.com/repos/hail-is/hail/pulls/4721","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments/230784831"},"html":{"href":"https://github.com/hail-is/hail/pull/4721#discussion_r230784831"},"pull_request":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4721"}}},"pull_request":{"url":"https://api.github.com/repos/hail-is/hail/pulls/4721","id":227993596,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI3OTkzNTk2","html_url":"https://github.com/hail-is/hail/pull/4721","diff_url":"https://github.com/hail-is/hail/pull/4721.diff","patch_url":"https://github.com/hail-is/hail/pull/4721.patch","issue_url":"https://api.github.com/repos/hail-is/hail/issues/4721","number":4721,"state":"open","locked":false,"title":"PTypes 31: ReadRows uses PType","user":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-11-02T16:34:56Z","updated_at":"2018-11-05T15:15:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ead755625e05dd429d07a0800f76fde35480ed0d","assignee":{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false},"assignees":[{"login":"cseed","id":1244990,"node_id":"MDQ6VXNlcjEyNDQ5OTA=","avatar_url":"https://avatars3.githubusercontent.com/u/1244990?v=4","gravatar_id":"","url":"https://api.github.com/users/cseed","html_url":"https://github.com/cseed","followers_url":"https://api.github.com/users/cseed/followers","following_url":"https://api.github.com/users/cseed/following{/other_user}","gists_url":"https://api.github.com/users/cseed/gists{/gist_id}","starred_url":"https://api.github.com/users/cseed/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cseed/subscriptions","organizations_url":"https://api.github.com/users/cseed/orgs","repos_url":"https://api.github.com/users/cseed/repos","events_url":"https://api.github.com/users/cseed/events{/privacy}","received_events_url":"https://api.github.com/users/cseed/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hail-is/hail/pulls/4721/commits","review_comments_url":"https://api.github.com/repos/hail-is/hail/pulls/4721/comments","review_comment_url":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hail-is/hail/issues/4721/comments","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/5c65c43183674af961434634c2aba66da3c008f8","head":{"label":"tpoterba:ptypes-31","ref":"ptypes-31","sha":"5c65c43183674af961434634c2aba66da3c008f8","user":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"repo":{"id":64860564,"node_id":"MDEwOlJlcG9zaXRvcnk2NDg2MDU2NA==","name":"hail","full_name":"tpoterba/hail","private":false,"owner":{"login":"tpoterba","id":10562794,"node_id":"MDQ6VXNlcjEwNTYyNzk0","avatar_url":"https://avatars2.githubusercontent.com/u/10562794?v=4","gravatar_id":"","url":"https://api.github.com/users/tpoterba","html_url":"https://github.com/tpoterba","followers_url":"https://api.github.com/users/tpoterba/followers","following_url":"https://api.github.com/users/tpoterba/following{/other_user}","gists_url":"https://api.github.com/users/tpoterba/gists{/gist_id}","starred_url":"https://api.github.com/users/tpoterba/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tpoterba/subscriptions","organizations_url":"https://api.github.com/users/tpoterba/orgs","repos_url":"https://api.github.com/users/tpoterba/repos","events_url":"https://api.github.com/users/tpoterba/events{/privacy}","received_events_url":"https://api.github.com/users/tpoterba/received_events","type":"User","site_admin":false},"html_url":"https://github.com/tpoterba/hail","description":"Hail, a framework for scalable genetic data analysis","fork":true,"url":"https://api.github.com/repos/tpoterba/hail","forks_url":"https://api.github.com/repos/tpoterba/hail/forks","keys_url":"https://api.github.com/repos/tpoterba/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tpoterba/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tpoterba/hail/teams","hooks_url":"https://api.github.com/repos/tpoterba/hail/hooks","issue_events_url":"https://api.github.com/repos/tpoterba/hail/issues/events{/number}","events_url":"https://api.github.com/repos/tpoterba/hail/events","assignees_url":"https://api.github.com/repos/tpoterba/hail/assignees{/user}","branches_url":"https://api.github.com/repos/tpoterba/hail/branches{/branch}","tags_url":"https://api.github.com/repos/tpoterba/hail/tags","blobs_url":"https://api.github.com/repos/tpoterba/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tpoterba/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tpoterba/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/tpoterba/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tpoterba/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/tpoterba/hail/languages","stargazers_url":"https://api.github.com/repos/tpoterba/hail/stargazers","contributors_url":"https://api.github.com/repos/tpoterba/hail/contributors","subscribers_url":"https://api.github.com/repos/tpoterba/hail/subscribers","subscription_url":"https://api.github.com/repos/tpoterba/hail/subscription","commits_url":"https://api.github.com/repos/tpoterba/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/tpoterba/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/tpoterba/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/tpoterba/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/tpoterba/hail/contents/{+path}","compare_url":"https://api.github.com/repos/tpoterba/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tpoterba/hail/merges","archive_url":"https://api.github.com/repos/tpoterba/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tpoterba/hail/downloads","issues_url":"https://api.github.com/repos/tpoterba/hail/issues{/number}","pulls_url":"https://api.github.com/repos/tpoterba/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/tpoterba/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/tpoterba/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tpoterba/hail/labels{/name}","releases_url":"https://api.github.com/repos/tpoterba/hail/releases{/id}","deployments_url":"https://api.github.com/repos/tpoterba/hail/deployments","created_at":"2016-08-03T16:15:03Z","updated_at":"2018-09-05T15:26:06Z","pushed_at":"2018-11-03T19:18:58Z","git_url":"git://github.com/tpoterba/hail.git","ssh_url":"git@github.com:tpoterba/hail.git","clone_url":"https://github.com/tpoterba/hail.git","svn_url":"https://github.com/tpoterba/hail","homepage":"","size":47312,"stargazers_count":0,"watchers_count":0,"language":"Scala","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hail-is:master","ref":"master","sha":"ff7d562f7693488d8dca85606018be839e15b623","user":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"repo":{"id":45069467,"node_id":"MDEwOlJlcG9zaXRvcnk0NTA2OTQ2Nw==","name":"hail","full_name":"hail-is/hail","private":false,"owner":{"login":"hail-is","id":20861792,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIwODYxNzky","avatar_url":"https://avatars1.githubusercontent.com/u/20861792?v=4","gravatar_id":"","url":"https://api.github.com/users/hail-is","html_url":"https://github.com/hail-is","followers_url":"https://api.github.com/users/hail-is/followers","following_url":"https://api.github.com/users/hail-is/following{/other_user}","gists_url":"https://api.github.com/users/hail-is/gists{/gist_id}","starred_url":"https://api.github.com/users/hail-is/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hail-is/subscriptions","organizations_url":"https://api.github.com/users/hail-is/orgs","repos_url":"https://api.github.com/users/hail-is/repos","events_url":"https://api.github.com/users/hail-is/events{/privacy}","received_events_url":"https://api.github.com/users/hail-is/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/hail-is/hail","description":"Scalable genomic data analysis.","fork":false,"url":"https://api.github.com/repos/hail-is/hail","forks_url":"https://api.github.com/repos/hail-is/hail/forks","keys_url":"https://api.github.com/repos/hail-is/hail/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hail-is/hail/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hail-is/hail/teams","hooks_url":"https://api.github.com/repos/hail-is/hail/hooks","issue_events_url":"https://api.github.com/repos/hail-is/hail/issues/events{/number}","events_url":"https://api.github.com/repos/hail-is/hail/events","assignees_url":"https://api.github.com/repos/hail-is/hail/assignees{/user}","branches_url":"https://api.github.com/repos/hail-is/hail/branches{/branch}","tags_url":"https://api.github.com/repos/hail-is/hail/tags","blobs_url":"https://api.github.com/repos/hail-is/hail/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hail-is/hail/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hail-is/hail/git/refs{/sha}","trees_url":"https://api.github.com/repos/hail-is/hail/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hail-is/hail/statuses/{sha}","languages_url":"https://api.github.com/repos/hail-is/hail/languages","stargazers_url":"https://api.github.com/repos/hail-is/hail/stargazers","contributors_url":"https://api.github.com/repos/hail-is/hail/contributors","subscribers_url":"https://api.github.com/repos/hail-is/hail/subscribers","subscription_url":"https://api.github.com/repos/hail-is/hail/subscription","commits_url":"https://api.github.com/repos/hail-is/hail/commits{/sha}","git_commits_url":"https://api.github.com/repos/hail-is/hail/git/commits{/sha}","comments_url":"https://api.github.com/repos/hail-is/hail/comments{/number}","issue_comment_url":"https://api.github.com/repos/hail-is/hail/issues/comments{/number}","contents_url":"https://api.github.com/repos/hail-is/hail/contents/{+path}","compare_url":"https://api.github.com/repos/hail-is/hail/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hail-is/hail/merges","archive_url":"https://api.github.com/repos/hail-is/hail/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hail-is/hail/downloads","issues_url":"https://api.github.com/repos/hail-is/hail/issues{/number}","pulls_url":"https://api.github.com/repos/hail-is/hail/pulls{/number}","milestones_url":"https://api.github.com/repos/hail-is/hail/milestones{/number}","notifications_url":"https://api.github.com/repos/hail-is/hail/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hail-is/hail/labels{/name}","releases_url":"https://api.github.com/repos/hail-is/hail/releases{/id}","deployments_url":"https://api.github.com/repos/hail-is/hail/deployments","created_at":"2015-10-27T20:55:42Z","updated_at":"2018-11-04T01:23:01Z","pushed_at":"2018-11-05T14:05:59Z","git_url":"git://github.com/hail-is/hail.git","ssh_url":"git@github.com:hail-is/hail.git","clone_url":"https://github.com/hail-is/hail.git","svn_url":"https://github.com/hail-is/hail","homepage":"https://hail.is","size":45137,"stargazers_count":397,"watchers_count":397,"language":"Scala","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":115,"mirror_url":null,"archived":false,"open_issues_count":122,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":115,"open_issues":122,"watchers":397,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4721"},"html":{"href":"https://github.com/hail-is/hail/pull/4721"},"issue":{"href":"https://api.github.com/repos/hail-is/hail/issues/4721"},"comments":{"href":"https://api.github.com/repos/hail-is/hail/issues/4721/comments"},"review_comments":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4721/comments"},"review_comment":{"href":"https://api.github.com/repos/hail-is/hail/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hail-is/hail/pulls/4721/commits"},"statuses":{"href":"https://api.github.com/repos/hail-is/hail/statuses/5c65c43183674af961434634c2aba66da3c008f8"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"cseed"}}