{"action":"created","issue":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/376","repository_url":"https://api.github.com/repos/mit-crpg/OpenMOC","labels_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/376/labels{/name}","comments_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/376/comments","events_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/376/events","html_url":"https://github.com/mit-crpg/OpenMOC/pull/376","id":394832736,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDY4NDQz","number":376,"title":"Add modular domains and printString() geometry tests","user":{"login":"GiudGiud","id":25037151,"node_id":"MDQ6VXNlcjI1MDM3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/25037151?v=4","gravatar_id":"","url":"https://api.github.com/users/GiudGiud","html_url":"https://github.com/GiudGiud","followers_url":"https://api.github.com/users/GiudGiud/followers","following_url":"https://api.github.com/users/GiudGiud/following{/other_user}","gists_url":"https://api.github.com/users/GiudGiud/gists{/gist_id}","starred_url":"https://api.github.com/users/GiudGiud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiudGiud/subscriptions","organizations_url":"https://api.github.com/users/GiudGiud/orgs","repos_url":"https://api.github.com/users/GiudGiud/repos","events_url":"https://api.github.com/users/GiudGiud/events{/privacy}","received_events_url":"https://api.github.com/users/GiudGiud/received_events","type":"User","site_admin":false},"labels":[{"id":315334512,"node_id":"MDU6TGFiZWwzMTUzMzQ1MTI=","url":"https://api.github.com/repos/mit-crpg/OpenMOC/labels/Test%20Suite","name":"Test Suite","color":"006b75","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-29T23:26:42Z","updated_at":"2019-01-02T18:03:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/pulls/376","html_url":"https://github.com/mit-crpg/OpenMOC/pull/376","diff_url":"https://github.com/mit-crpg/OpenMOC/pull/376.diff","patch_url":"https://github.com/mit-crpg/OpenMOC/pull/376.patch"},"body":"Just two simple tests + some white space deletion"},"comment":{"url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/comments/450936246","html_url":"https://github.com/mit-crpg/OpenMOC/pull/376#issuecomment-450936246","issue_url":"https://api.github.com/repos/mit-crpg/OpenMOC/issues/376","id":450936246,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDkzNjI0Ng==","user":{"login":"GiudGiud","id":25037151,"node_id":"MDQ6VXNlcjI1MDM3MTUx","avatar_url":"https://avatars2.githubusercontent.com/u/25037151?v=4","gravatar_id":"","url":"https://api.github.com/users/GiudGiud","html_url":"https://github.com/GiudGiud","followers_url":"https://api.github.com/users/GiudGiud/followers","following_url":"https://api.github.com/users/GiudGiud/following{/other_user}","gists_url":"https://api.github.com/users/GiudGiud/gists{/gist_id}","starred_url":"https://api.github.com/users/GiudGiud/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/GiudGiud/subscriptions","organizations_url":"https://api.github.com/users/GiudGiud/orgs","repos_url":"https://api.github.com/users/GiudGiud/repos","events_url":"https://api.github.com/users/GiudGiud/events{/privacy}","received_events_url":"https://api.github.com/users/GiudGiud/received_events","type":"User","site_admin":false},"created_at":"2019-01-02T18:03:11Z","updated_at":"2019-01-02T18:03:11Z","author_association":"CONTRIBUTOR","body":"@tjlaboss could you please review this PR ?\r\n\r\nNo real innovation there, test_geometry_print is very close to test_geometry_dump in design, and test_modular_domains is a repeat of test_forward_3D_lattice_cmfd but with modular domains.\r\nModular domains are used to make the ray tracer pretend it s a domain decomposed geometry and have the tracks line up between sub-domains. \r\n\r\nThe change in vector alignment is important because in the code a bunch of arrays are declared as aligned for SIMD vectorization. That means 32 byte aligned on AVX2 (on falcon and newer machines), but if we align the start of the array to a 16 byte array then the array can be misaligned, when we told the compiler it was aligned. I got some seg faults, fixed after doing that. A 32 byte aligned array is automatically 16 byte aligned so no worries that way"}}
{"actor":{"display_login":"GiudGiud"}}