{"action":"created","comment":{"url":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/comments/244486747","pull_request_review_id":188409618,"id":244486747,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NDQ4Njc0Nw==","diff_hunk":"@@ -55,6 +61,92 @@ impl_spim_ext!(\n /// - The over-read character is hardcoded to `0`.\n pub struct Spim<T>(T);\n \n+impl<T> Transfer<u8> for Spim<T> where T: SpimExt\n+{\n+   type Error = Error;\n+\n+    fn transfer<'w>(&mut self, words: &'w mut [u8]) -> Result<&'w [u8], Error> {\n+        // TODO: some targets have a maxcnt whose size is larger","path":"nrf52-hal-common/src/spim.rs","position":31,"original_position":31,"commit_id":"673fee52b9e4c7d6b02f8eb39d3d84bf481c4ede","original_commit_id":"a21843dea9a49b0e248d9867de76e7441c64e0f7","user":{"login":"simonsso","id":3679593,"node_id":"MDQ6VXNlcjM2Nzk1OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3679593?v=4","gravatar_id":"","url":"https://api.github.com/users/simonsso","html_url":"https://github.com/simonsso","followers_url":"https://api.github.com/users/simonsso/followers","following_url":"https://api.github.com/users/simonsso/following{/other_user}","gists_url":"https://api.github.com/users/simonsso/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsso/subscriptions","organizations_url":"https://api.github.com/users/simonsso/orgs","repos_url":"https://api.github.com/users/simonsso/repos","events_url":"https://api.github.com/users/simonsso/events{/privacy}","received_events_url":"https://api.github.com/users/simonsso/received_events","type":"User","site_admin":false},"body":"Thanks, not only the comment but also the code it commented should be removed!","created_at":"2018-12-29T12:54:29Z","updated_at":"2018-12-29T12:54:29Z","html_url":"https://github.com/nrf-rs/nrf52-hal/pull/39#discussion_r244486747","pull_request_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/comments/244486747"},"html":{"href":"https://github.com/nrf-rs/nrf52-hal/pull/39#discussion_r244486747"},"pull_request":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/39"}},"in_reply_to_id":244483573},"pull_request":{"url":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/39","id":241437592,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNDM3NTky","html_url":"https://github.com/nrf-rs/nrf52-hal/pull/39","diff_url":"https://github.com/nrf-rs/nrf52-hal/pull/39.diff","patch_url":"https://github.com/nrf-rs/nrf52-hal/pull/39.patch","issue_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/issues/39","number":39,"state":"open","locked":false,"title":"Implemented embedded_hal Transfer trait","user":{"login":"simonsso","id":3679593,"node_id":"MDQ6VXNlcjM2Nzk1OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3679593?v=4","gravatar_id":"","url":"https://api.github.com/users/simonsso","html_url":"https://github.com/simonsso","followers_url":"https://api.github.com/users/simonsso/followers","following_url":"https://api.github.com/users/simonsso/following{/other_user}","gists_url":"https://api.github.com/users/simonsso/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsso/subscriptions","organizations_url":"https://api.github.com/users/simonsso/orgs","repos_url":"https://api.github.com/users/simonsso/repos","events_url":"https://api.github.com/users/simonsso/events{/privacy}","received_events_url":"https://api.github.com/users/simonsso/received_events","type":"User","site_admin":false},"body":"Hi\r\nHere is an implementation for the embedded_hal transfer trait. #10  It is based on the existing DMA setup code but CS is handled outside in embedded_hal and I set up multiple transfers if size is over the limit.\r\n\r\nI also wrote some code for #17 not as suggested in the ticket but that could be refactored later.\r\n\r\n","created_at":"2018-12-29T10:15:38Z","updated_at":"2018-12-29T12:54:29Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ea01e5991d8f3ded3e3639c09154b7c5cc1975e3","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/39/commits","review_comments_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/39/comments","review_comment_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/issues/39/comments","statuses_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/statuses/673fee52b9e4c7d6b02f8eb39d3d84bf481c4ede","head":{"label":"simonsso:pullrequest2","ref":"pullrequest2","sha":"673fee52b9e4c7d6b02f8eb39d3d84bf481c4ede","user":{"login":"simonsso","id":3679593,"node_id":"MDQ6VXNlcjM2Nzk1OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3679593?v=4","gravatar_id":"","url":"https://api.github.com/users/simonsso","html_url":"https://github.com/simonsso","followers_url":"https://api.github.com/users/simonsso/followers","following_url":"https://api.github.com/users/simonsso/following{/other_user}","gists_url":"https://api.github.com/users/simonsso/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsso/subscriptions","organizations_url":"https://api.github.com/users/simonsso/orgs","repos_url":"https://api.github.com/users/simonsso/repos","events_url":"https://api.github.com/users/simonsso/events{/privacy}","received_events_url":"https://api.github.com/users/simonsso/received_events","type":"User","site_admin":false},"repo":{"id":160934715,"node_id":"MDEwOlJlcG9zaXRvcnkxNjA5MzQ3MTU=","name":"nrf52-hal","full_name":"simonsso/nrf52-hal","private":false,"owner":{"login":"simonsso","id":3679593,"node_id":"MDQ6VXNlcjM2Nzk1OTM=","avatar_url":"https://avatars0.githubusercontent.com/u/3679593?v=4","gravatar_id":"","url":"https://api.github.com/users/simonsso","html_url":"https://github.com/simonsso","followers_url":"https://api.github.com/users/simonsso/followers","following_url":"https://api.github.com/users/simonsso/following{/other_user}","gists_url":"https://api.github.com/users/simonsso/gists{/gist_id}","starred_url":"https://api.github.com/users/simonsso/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonsso/subscriptions","organizations_url":"https://api.github.com/users/simonsso/orgs","repos_url":"https://api.github.com/users/simonsso/repos","events_url":"https://api.github.com/users/simonsso/events{/privacy}","received_events_url":"https://api.github.com/users/simonsso/received_events","type":"User","site_admin":false},"html_url":"https://github.com/simonsso/nrf52-hal","description":"A Rust HAL for the nrf52 family of devices","fork":true,"url":"https://api.github.com/repos/simonsso/nrf52-hal","forks_url":"https://api.github.com/repos/simonsso/nrf52-hal/forks","keys_url":"https://api.github.com/repos/simonsso/nrf52-hal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/simonsso/nrf52-hal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/simonsso/nrf52-hal/teams","hooks_url":"https://api.github.com/repos/simonsso/nrf52-hal/hooks","issue_events_url":"https://api.github.com/repos/simonsso/nrf52-hal/issues/events{/number}","events_url":"https://api.github.com/repos/simonsso/nrf52-hal/events","assignees_url":"https://api.github.com/repos/simonsso/nrf52-hal/assignees{/user}","branches_url":"https://api.github.com/repos/simonsso/nrf52-hal/branches{/branch}","tags_url":"https://api.github.com/repos/simonsso/nrf52-hal/tags","blobs_url":"https://api.github.com/repos/simonsso/nrf52-hal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/simonsso/nrf52-hal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/simonsso/nrf52-hal/git/refs{/sha}","trees_url":"https://api.github.com/repos/simonsso/nrf52-hal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/simonsso/nrf52-hal/statuses/{sha}","languages_url":"https://api.github.com/repos/simonsso/nrf52-hal/languages","stargazers_url":"https://api.github.com/repos/simonsso/nrf52-hal/stargazers","contributors_url":"https://api.github.com/repos/simonsso/nrf52-hal/contributors","subscribers_url":"https://api.github.com/repos/simonsso/nrf52-hal/subscribers","subscription_url":"https://api.github.com/repos/simonsso/nrf52-hal/subscription","commits_url":"https://api.github.com/repos/simonsso/nrf52-hal/commits{/sha}","git_commits_url":"https://api.github.com/repos/simonsso/nrf52-hal/git/commits{/sha}","comments_url":"https://api.github.com/repos/simonsso/nrf52-hal/comments{/number}","issue_comment_url":"https://api.github.com/repos/simonsso/nrf52-hal/issues/comments{/number}","contents_url":"https://api.github.com/repos/simonsso/nrf52-hal/contents/{+path}","compare_url":"https://api.github.com/repos/simonsso/nrf52-hal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/simonsso/nrf52-hal/merges","archive_url":"https://api.github.com/repos/simonsso/nrf52-hal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/simonsso/nrf52-hal/downloads","issues_url":"https://api.github.com/repos/simonsso/nrf52-hal/issues{/number}","pulls_url":"https://api.github.com/repos/simonsso/nrf52-hal/pulls{/number}","milestones_url":"https://api.github.com/repos/simonsso/nrf52-hal/milestones{/number}","notifications_url":"https://api.github.com/repos/simonsso/nrf52-hal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/simonsso/nrf52-hal/labels{/name}","releases_url":"https://api.github.com/repos/simonsso/nrf52-hal/releases{/id}","deployments_url":"https://api.github.com/repos/simonsso/nrf52-hal/deployments","created_at":"2018-12-08T11:59:49Z","updated_at":"2018-12-08T11:59:51Z","pushed_at":"2018-12-29T12:47:06Z","git_url":"git://github.com/simonsso/nrf52-hal.git","ssh_url":"git@github.com:simonsso/nrf52-hal.git","clone_url":"https://github.com/simonsso/nrf52-hal.git","svn_url":"https://github.com/simonsso/nrf52-hal","homepage":null,"size":115,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nrf-rs:master","ref":"master","sha":"25550fc9081fc96ad779898f12da7fd0d4b52d14","user":{"login":"nrf-rs","id":42665441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjY1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/42665441?v=4","gravatar_id":"","url":"https://api.github.com/users/nrf-rs","html_url":"https://github.com/nrf-rs","followers_url":"https://api.github.com/users/nrf-rs/followers","following_url":"https://api.github.com/users/nrf-rs/following{/other_user}","gists_url":"https://api.github.com/users/nrf-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/nrf-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrf-rs/subscriptions","organizations_url":"https://api.github.com/users/nrf-rs/orgs","repos_url":"https://api.github.com/users/nrf-rs/repos","events_url":"https://api.github.com/users/nrf-rs/events{/privacy}","received_events_url":"https://api.github.com/users/nrf-rs/received_events","type":"Organization","site_admin":false},"repo":{"id":145948665,"node_id":"MDEwOlJlcG9zaXRvcnkxNDU5NDg2NjU=","name":"nrf52-hal","full_name":"nrf-rs/nrf52-hal","private":false,"owner":{"login":"nrf-rs","id":42665441,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQyNjY1NDQx","avatar_url":"https://avatars2.githubusercontent.com/u/42665441?v=4","gravatar_id":"","url":"https://api.github.com/users/nrf-rs","html_url":"https://github.com/nrf-rs","followers_url":"https://api.github.com/users/nrf-rs/followers","following_url":"https://api.github.com/users/nrf-rs/following{/other_user}","gists_url":"https://api.github.com/users/nrf-rs/gists{/gist_id}","starred_url":"https://api.github.com/users/nrf-rs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nrf-rs/subscriptions","organizations_url":"https://api.github.com/users/nrf-rs/orgs","repos_url":"https://api.github.com/users/nrf-rs/repos","events_url":"https://api.github.com/users/nrf-rs/events{/privacy}","received_events_url":"https://api.github.com/users/nrf-rs/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/nrf-rs/nrf52-hal","description":"A Rust HAL for the nrf52 family of devices","fork":false,"url":"https://api.github.com/repos/nrf-rs/nrf52-hal","forks_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/forks","keys_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/teams","hooks_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/hooks","issue_events_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/issues/events{/number}","events_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/events","assignees_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/assignees{/user}","branches_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/branches{/branch}","tags_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/tags","blobs_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/git/refs{/sha}","trees_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/statuses/{sha}","languages_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/languages","stargazers_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/stargazers","contributors_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/contributors","subscribers_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/subscribers","subscription_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/subscription","commits_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/commits{/sha}","git_commits_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/git/commits{/sha}","comments_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/comments{/number}","issue_comment_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/issues/comments{/number}","contents_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/contents/{+path}","compare_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/merges","archive_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/downloads","issues_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/issues{/number}","pulls_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls{/number}","milestones_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/milestones{/number}","notifications_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/labels{/name}","releases_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/releases{/id}","deployments_url":"https://api.github.com/repos/nrf-rs/nrf52-hal/deployments","created_at":"2018-08-24T05:58:32Z","updated_at":"2018-12-29T10:41:40Z","pushed_at":"2018-12-29T12:47:07Z","git_url":"git://github.com/nrf-rs/nrf52-hal.git","ssh_url":"git@github.com:nrf-rs/nrf52-hal.git","clone_url":"https://github.com/nrf-rs/nrf52-hal.git","svn_url":"https://github.com/nrf-rs/nrf52-hal","homepage":null,"size":114,"stargazers_count":16,"watchers_count":16,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":10,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":10,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/39"},"html":{"href":"https://github.com/nrf-rs/nrf52-hal/pull/39"},"issue":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/issues/39"},"comments":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/nrf-rs/nrf52-hal/statuses/673fee52b9e4c7d6b02f8eb39d3d84bf481c4ede"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"simonsso"}}