{"action":"created","issue":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8363","repository_url":"https://api.github.com/repos/openshift/openshift-ansible","labels_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8363/labels{/name}","comments_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8363/comments","events_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8363/events","html_url":"https://github.com/openshift/openshift-ansible/issues/8363","id":322775215,"number":8363,"title":"Cant upgrade Origin 3.7 - 3.9 using playbook","user":{"login":"a-zcomp","id":39264607,"avatar_url":"https://avatars2.githubusercontent.com/u/39264607?v=4","gravatar_id":"","url":"https://api.github.com/users/a-zcomp","html_url":"https://github.com/a-zcomp","followers_url":"https://api.github.com/users/a-zcomp/followers","following_url":"https://api.github.com/users/a-zcomp/following{/other_user}","gists_url":"https://api.github.com/users/a-zcomp/gists{/gist_id}","starred_url":"https://api.github.com/users/a-zcomp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/a-zcomp/subscriptions","organizations_url":"https://api.github.com/users/a-zcomp/orgs","repos_url":"https://api.github.com/users/a-zcomp/repos","events_url":"https://api.github.com/users/a-zcomp/events{/privacy}","received_events_url":"https://api.github.com/users/a-zcomp/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-05-14T11:23:25Z","updated_at":"2018-05-25T13:57:32Z","closed_at":null,"author_association":"NONE","body":"#### Description\r\n\r\nWhen trying to perform an upgrade from Origin 3.7 to 3.9 using playbooks/byo/openshift-cluster/upgrades/v3_9/upgrade.yml an error saying I need to upgrade from 3.8 is shown\r\n\r\n##### Version\r\n\r\nPlease put the following version information in the code block\r\nindicated below.\r\n```\r\nansible 2.5.2\r\nopenshift-ansible-3.9.29-1-16-g8071e9d55\r\n```\r\n##### Steps To Reproduce\r\n\r\n1. Run 3.9 upgrade playbook against 3.7 install\r\n\r\n##### Expected Results\r\n\r\nOpenshift Origin is upgraded to 3.9\r\n\r\n##### Observed Results\r\n\r\nPlaybook error\r\n```\r\n     Hosts:    master-2, master-3 (full host names removed)\r\n     Play:     Verify upgrade targets\r\n     Task:     Fail when openshift version does not meet minimum requirement for Origin upgrade\r\n     Message:  This upgrade playbook must be run against OpenShift 3.8 or later\r\n```"},"comment":{"url":"https://api.github.com/repos/openshift/openshift-ansible/issues/comments/392066155","html_url":"https://github.com/openshift/openshift-ansible/issues/8363#issuecomment-392066155","issue_url":"https://api.github.com/repos/openshift/openshift-ansible/issues/8363","id":392066155,"user":{"login":"mshutt","id":35930614,"avatar_url":"https://avatars2.githubusercontent.com/u/35930614?v=4","gravatar_id":"","url":"https://api.github.com/users/mshutt","html_url":"https://github.com/mshutt","followers_url":"https://api.github.com/users/mshutt/followers","following_url":"https://api.github.com/users/mshutt/following{/other_user}","gists_url":"https://api.github.com/users/mshutt/gists{/gist_id}","starred_url":"https://api.github.com/users/mshutt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mshutt/subscriptions","organizations_url":"https://api.github.com/users/mshutt/orgs","repos_url":"https://api.github.com/users/mshutt/repos","events_url":"https://api.github.com/users/mshutt/events{/privacy}","received_events_url":"https://api.github.com/users/mshutt/received_events","type":"User","site_admin":false},"created_at":"2018-05-25T13:57:32Z","updated_at":"2018-05-25T13:57:32Z","author_association":"NONE","body":"@vrutkovs I believe the problem with \"clearing facts\" (at least with the containerized install) is that the facts are programmatically generated using `roles/openshift_facts/library/openshift_facts.py`\r\n\r\nhttps://github.com/openshift/openshift-ansible/blob/f8f497e2bcb088553447c36974779a7c43483384/roles/openshift_facts/library/openshift_facts.py#L895\r\n\r\nBasically, it will detect the version of the containerized install by reading /etc/sysconfig/origin-master-controllers and parsing out current version from the IMAGE_VERSION variable.  In my case, I had to edit that file by hand on the master that failed the upgrade from 3.7.2 to 3.8 and manually define the tag to v3.8.0 and then I was able to re-run the 3.9 upgrade playbook.  Of course, the relabeling of the master to include the new labels required by 3.9 (node-role.kubernetes.io/master) weren't applied to that one failed master either and I had to manually `oc label` that node .  See `https://github.com/openshift/openshift-ansible/issues/8467` for details.\r\n\r\nThis is, of course, in the release-3.9 tag...  It seems that this has been changed in master?  I've not had a chance to take a deeper look at what has been changed.  But this \"failsafe\" parsing of the /etc/sysconfig/origin-master-controllers file to get the version had also bit me in a partially failed 3.7.0 -> 3.7.2 upgrade."}}
{"actor":{"display_login":"mshutt"}}