{"action":"created","issue":{"url":"https://api.github.com/repos/FortAwesome/react-fontawesome/issues/114","repository_url":"https://api.github.com/repos/FortAwesome/react-fontawesome","labels_url":"https://api.github.com/repos/FortAwesome/react-fontawesome/issues/114/labels{/name}","comments_url":"https://api.github.com/repos/FortAwesome/react-fontawesome/issues/114/comments","events_url":"https://api.github.com/repos/FortAwesome/react-fontawesome/issues/114/events","html_url":"https://github.com/FortAwesome/react-fontawesome/issues/114","id":313301890,"node_id":"MDU6SXNzdWUzMTMzMDE4OTA=","number":114,"title":"Remove humps from the package.json dependencies","user":{"login":"robmadole","id":132895,"node_id":"MDQ6VXNlcjEzMjg5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/132895?v=4","gravatar_id":"","url":"https://api.github.com/users/robmadole","html_url":"https://github.com/robmadole","followers_url":"https://api.github.com/users/robmadole/followers","following_url":"https://api.github.com/users/robmadole/following{/other_user}","gists_url":"https://api.github.com/users/robmadole/gists{/gist_id}","starred_url":"https://api.github.com/users/robmadole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmadole/subscriptions","organizations_url":"https://api.github.com/users/robmadole/orgs","repos_url":"https://api.github.com/users/robmadole/repos","events_url":"https://api.github.com/users/robmadole/events{/privacy}","received_events_url":"https://api.github.com/users/robmadole/received_events","type":"User","site_admin":false},"labels":[{"id":685118342,"node_id":"MDU6TGFiZWw2ODUxMTgzNDI=","url":"https://api.github.com/repos/FortAwesome/react-fontawesome/labels/enhancement","name":"enhancement","color":"84b6eb","default":true},{"id":685118344,"node_id":"MDU6TGFiZWw2ODUxMTgzNDQ=","url":"https://api.github.com/repos/FortAwesome/react-fontawesome/labels/good%20first%20issue","name":"good first issue","color":"7057ff","default":true}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-04-11T12:28:04Z","updated_at":"2018-08-13T18:25:23Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"This is a simple change but will take some testing to verify that it's correct.\r\n\r\nWe list `humps` as a [dependency here](https://github.com/FortAwesome/react-fontawesome/blob/master/package.json#L62).\r\n\r\nHowever Rollup should already including `humps` in the dist files. (index.js and index.es.js).\r\n\r\nSo let's remove that and then test with a new [React app](https://github.com/facebook/create-react-app). My recommendation would be to:\r\n\r\n1. Remove `humps` from deps in package.json\r\n1. Run `yarn pack` (this will create a tarball in the root)\r\n1. Create a brand new React app using create-react-app\r\n1. Install the tarball\r\n1. Follow the usage instructions to use react-fontawesome in the new app and verify that it's working"},"comment":{"url":"https://api.github.com/repos/FortAwesome/react-fontawesome/issues/comments/412616866","html_url":"https://github.com/FortAwesome/react-fontawesome/issues/114#issuecomment-412616866","issue_url":"https://api.github.com/repos/FortAwesome/react-fontawesome/issues/114","id":412616866,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjYxNjg2Ng==","user":{"login":"robmadole","id":132895,"node_id":"MDQ6VXNlcjEzMjg5NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/132895?v=4","gravatar_id":"","url":"https://api.github.com/users/robmadole","html_url":"https://github.com/robmadole","followers_url":"https://api.github.com/users/robmadole/followers","following_url":"https://api.github.com/users/robmadole/following{/other_user}","gists_url":"https://api.github.com/users/robmadole/gists{/gist_id}","starred_url":"https://api.github.com/users/robmadole/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robmadole/subscriptions","organizations_url":"https://api.github.com/users/robmadole/orgs","repos_url":"https://api.github.com/users/robmadole/repos","events_url":"https://api.github.com/users/robmadole/events{/privacy}","received_events_url":"https://api.github.com/users/robmadole/received_events","type":"User","site_admin":false},"created_at":"2018-08-13T18:25:23Z","updated_at":"2018-08-13T18:25:23Z","author_association":"CONTRIBUTOR","body":"@sdabhi23 I think [it's already included](https://github.com/FortAwesome/react-fontawesome/blob/master/index.js#L16). This issue was so that we could remove it from `dependencies` in `package.json` and then probably place it in `devDependencies`. That way it's still installed and Rollup can get to it but it will not be installed when someone installs `react-fontawesome`. Does that make sense?"}}
{"actor":{"display_login":"robmadole"}}