{"action":"created","issue":{"url":"https://api.github.com/repos/eclipse/kapua/issues/1868","repository_url":"https://api.github.com/repos/eclipse/kapua","labels_url":"https://api.github.com/repos/eclipse/kapua/issues/1868/labels{/name}","comments_url":"https://api.github.com/repos/eclipse/kapua/issues/1868/comments","events_url":"https://api.github.com/repos/eclipse/kapua/issues/1868/events","html_url":"https://github.com/eclipse/kapua/pull/1868","id":340305229,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzQ5MDg4","number":1868,"title":"Fixed domain name / hostname validation for EndpointInfo","user":{"login":"Coduz","id":3942036,"node_id":"MDQ6VXNlcjM5NDIwMzY=","avatar_url":"https://avatars3.githubusercontent.com/u/3942036?v=4","gravatar_id":"","url":"https://api.github.com/users/Coduz","html_url":"https://github.com/Coduz","followers_url":"https://api.github.com/users/Coduz/followers","following_url":"https://api.github.com/users/Coduz/following{/other_user}","gists_url":"https://api.github.com/users/Coduz/gists{/gist_id}","starred_url":"https://api.github.com/users/Coduz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Coduz/subscriptions","organizations_url":"https://api.github.com/users/Coduz/orgs","repos_url":"https://api.github.com/users/Coduz/repos","events_url":"https://api.github.com/users/Coduz/events{/privacy}","received_events_url":"https://api.github.com/users/Coduz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-07-11T15:56:24Z","updated_at":"2018-07-12T13:50:25Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/eclipse/kapua/pulls/1868","html_url":"https://github.com/eclipse/kapua/pull/1868","diff_url":"https://github.com/eclipse/kapua/pull/1868.diff","patch_url":"https://github.com/eclipse/kapua/pull/1868.patch"},"body":"Fixed DNS validation regex.\r\n\r\n**Related Issue**\r\nThis PR fixes #1861 \r\n\r\n**Description of the solution adopted**\r\nWe created a regex inspired by the one contained in the [RFC 1123](https://tools.ietf.org/html/rfc1123).\r\n\r\n**Screenshots**\r\n![screen shot 2018-07-11 at 5 31 23 pm](https://user-images.githubusercontent.com/3942036/42584372-56e246d8-8533-11e8-85bd-2a1122bd41fd.png)\r\n\r\n**Any side note on the changes made**\r\n_None_"},"comment":{"url":"https://api.github.com/repos/eclipse/kapua/issues/comments/404518775","html_url":"https://github.com/eclipse/kapua/pull/1868#issuecomment-404518775","issue_url":"https://api.github.com/repos/eclipse/kapua/issues/1868","id":404518775,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNDUxODc3NQ==","user":{"login":"LeoNerdoG","id":15121999,"node_id":"MDQ6VXNlcjE1MTIxOTk5","avatar_url":"https://avatars1.githubusercontent.com/u/15121999?v=4","gravatar_id":"","url":"https://api.github.com/users/LeoNerdoG","html_url":"https://github.com/LeoNerdoG","followers_url":"https://api.github.com/users/LeoNerdoG/followers","following_url":"https://api.github.com/users/LeoNerdoG/following{/other_user}","gists_url":"https://api.github.com/users/LeoNerdoG/gists{/gist_id}","starred_url":"https://api.github.com/users/LeoNerdoG/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LeoNerdoG/subscriptions","organizations_url":"https://api.github.com/users/LeoNerdoG/orgs","repos_url":"https://api.github.com/users/LeoNerdoG/repos","events_url":"https://api.github.com/users/LeoNerdoG/events{/privacy}","received_events_url":"https://api.github.com/users/LeoNerdoG/received_events","type":"User","site_admin":false},"created_at":"2018-07-12T13:50:25Z","updated_at":"2018-07-12T13:50:25Z","author_association":"CONTRIBUTOR","body":"Hey @Coduz,\r\nI wrote 4) and 5) because of this in RFC 3986:\r\n\r\n>  Such a [Domain] name **_consists of a sequence of domain labels separated by \".\",_**\r\n   each domain label starting and ending with an alphanumeric character\r\n   and possibly also containing \"-\" characters.  The rightmost domain\r\n   label of a fully qualified domain name in DNS may be followed by a\r\n   single \".\" and should be if it is necessary to distinguish between\r\n   the complete domain name and some local domain.\r\n\r\n      reg-name    = *( unreserved / pct-encoded / sub-delims )\r\n\r\n>   If the URI scheme defines a default for host, then that default\r\n   applies when the host subcomponent is undefined or when the\r\n   registered name is empty (zero length).  For example, the \"file\" URI\r\n   scheme is defined so that no authority, an empty host, and\r\n   \"localhost\" all mean the end-user's machine, whereas the \"http\"\r\n   scheme considers a missing authority or empty host invalid.\r\n\r\nI have never used localhost with a TLD, and could not find that **localhost.com** is invalid domain, (except from the part in RFC 3986 that is shown above) so I guess it can stay then?\r\nThe sam applies to WINS. \r\nSo if you think this is OK, you can merge. but maybe we can debate about this in a couple of minutes  when meeting starts =) \r\n\r\n"}}
{"actor":{"display_login":"LeoNerdoG"}}