{"action":"created","issue":{"url":"https://api.github.com/repos/atom/tree-view/issues/1252","repository_url":"https://api.github.com/repos/atom/tree-view","labels_url":"https://api.github.com/repos/atom/tree-view/issues/1252/labels{/name}","comments_url":"https://api.github.com/repos/atom/tree-view/issues/1252/comments","events_url":"https://api.github.com/repos/atom/tree-view/issues/1252/events","html_url":"https://github.com/atom/tree-view/pull/1252","id":326486578,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkwNTYwNjY2","number":1252,"title":"Enable hideIgnoredNames with hideVcsIgnoredFiles","user":{"login":"denis-sokolov","id":113721,"node_id":"MDQ6VXNlcjExMzcyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/113721?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-sokolov","html_url":"https://github.com/denis-sokolov","followers_url":"https://api.github.com/users/denis-sokolov/followers","following_url":"https://api.github.com/users/denis-sokolov/following{/other_user}","gists_url":"https://api.github.com/users/denis-sokolov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-sokolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-sokolov/subscriptions","organizations_url":"https://api.github.com/users/denis-sokolov/orgs","repos_url":"https://api.github.com/users/denis-sokolov/repos","events_url":"https://api.github.com/users/denis-sokolov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-sokolov/received_events","type":"User","site_admin":false},"labels":[{"id":193726960,"node_id":"MDU6TGFiZWwxOTM3MjY5NjA=","url":"https://api.github.com/repos/atom/tree-view/labels/needs-review","name":"needs-review","color":"bfe5bf","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-05-25T11:33:05Z","updated_at":"2018-08-03T15:56:20Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/atom/tree-view/pulls/1252","html_url":"https://github.com/atom/tree-view/pull/1252","diff_url":"https://github.com/atom/tree-view/pull/1252.diff","patch_url":"https://github.com/atom/tree-view/pull/1252.patch"},"body":"### Description of the Change\r\n\r\nInterpreting English, when both “hide ignored names” and “hide vcs ignored files” are enabled, I would expect both to apply, and the union of the two options of files to be hidden.\r\n\r\nBefore this commit, however, the “hide vcs ignored files” would override the “hide ignored names” for no apparent benefit.\r\n\r\n### Alternate Designs\r\n\r\nNo alternate designs were considered.\r\n\r\n### Benefits\r\n\r\nThe behavior will more closely match the user’s expectation based on the shared interface in English.\r\n\r\n### Possible Drawbacks\r\n\r\nSome users may have been relying on the gitignored files overriding the custom “ignored names” setting.\r\n\r\n### Applicable Issues\r\n\r\nNo open issues about this.\r\n"},"comment":{"url":"https://api.github.com/repos/atom/tree-view/issues/comments/410297557","html_url":"https://github.com/atom/tree-view/pull/1252#issuecomment-410297557","issue_url":"https://api.github.com/repos/atom/tree-view/issues/1252","id":410297557,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDI5NzU1Nw==","user":{"login":"denis-sokolov","id":113721,"node_id":"MDQ6VXNlcjExMzcyMQ==","avatar_url":"https://avatars0.githubusercontent.com/u/113721?v=4","gravatar_id":"","url":"https://api.github.com/users/denis-sokolov","html_url":"https://github.com/denis-sokolov","followers_url":"https://api.github.com/users/denis-sokolov/followers","following_url":"https://api.github.com/users/denis-sokolov/following{/other_user}","gists_url":"https://api.github.com/users/denis-sokolov/gists{/gist_id}","starred_url":"https://api.github.com/users/denis-sokolov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/denis-sokolov/subscriptions","organizations_url":"https://api.github.com/users/denis-sokolov/orgs","repos_url":"https://api.github.com/users/denis-sokolov/repos","events_url":"https://api.github.com/users/denis-sokolov/events{/privacy}","received_events_url":"https://api.github.com/users/denis-sokolov/received_events","type":"User","site_admin":false},"created_at":"2018-08-03T15:56:20Z","updated_at":"2018-08-03T15:56:20Z","author_association":"NONE","body":"@lee-dohm, not returning false and falling through to other options is the purpose of this PR."}}
{"actor":{"display_login":"denis-sokolov"}}