{"action":"opened","number":2308,"pull_request":{"url":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/2308","id":201496249,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAxNDk2MjQ5","html_url":"https://github.com/pmmp/PocketMine-MP/pull/2308","diff_url":"https://github.com/pmmp/PocketMine-MP/pull/2308.diff","patch_url":"https://github.com/pmmp/PocketMine-MP/pull/2308.patch","issue_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2308","number":2308,"state":"open","locked":false,"title":"Forms API, take 2","user":{"login":"dktapps","id":14214667,"node_id":"MDQ6VXNlcjE0MjE0NjY3","avatar_url":"https://avatars2.githubusercontent.com/u/14214667?v=4","gravatar_id":"","url":"https://api.github.com/users/dktapps","html_url":"https://github.com/dktapps","followers_url":"https://api.github.com/users/dktapps/followers","following_url":"https://api.github.com/users/dktapps/following{/other_user}","gists_url":"https://api.github.com/users/dktapps/gists{/gist_id}","starred_url":"https://api.github.com/users/dktapps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dktapps/subscriptions","organizations_url":"https://api.github.com/users/dktapps/orgs","repos_url":"https://api.github.com/users/dktapps/repos","events_url":"https://api.github.com/users/dktapps/events{/privacy}","received_events_url":"https://api.github.com/users/dktapps/received_events","type":"User","site_admin":false},"body":"## Introduction\r\nThis is a revision of #1476 , which was abandoned due to me getting sick of messing about with it and it being full of bugs.\r\n\r\nThis primarily differs from #1476 due to a large simplification in how form data is handled. Previously form response data would be stored in the form itself, which added a lot of extra complexity to form handling, made them impossible to duplicate, reuse, etc etc. In this revision, forms and their subcomponents do not have any responsibility for storing response data - instead it's passed to `onSubmit()`.\r\n\r\nThis is not yet complete and will probably see further changes before it is done.\r\n\r\n## Changes\r\n### API changes\r\n- Added new classes under the `pocketmine\\form` namespace\r\n- Added API method `Player->sendForm()`.\r\n\r\n### Behavioural changes\r\nThis is a pure API addition and should not affect any existing behaviour, apart from possibly breaking external form API plugins.\r\n\r\n## Backwards compatibility\r\nsee Behavioural changes\r\n\r\n## Tests\r\nhas been briefly tested, test scripts will come.","created_at":"2018-07-15T12:42:07Z","updated_at":"2018-07-15T12:42:07Z","closed_at":null,"merged_at":null,"merge_commit_sha":null,"assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":454782351,"node_id":"MDU6TGFiZWw0NTQ3ODIzNTE=","url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/Category:%20API","name":"Category: API","color":"00aa55","default":false},{"id":454787972,"node_id":"MDU6TGFiZWw0NTQ3ODc5NzI=","url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/PR:%20Contribution","name":"PR: Contribution","color":"bfdadc","default":false},{"id":475724985,"node_id":"MDU6TGFiZWw0NzU3MjQ5ODU=","url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels/Status:%20Work%20in%20Progress","name":"Status: Work in Progress","color":"a6b7f4","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/2308/commits","review_comments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/2308/comments","review_comment_url":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2308/comments","statuses_url":"https://api.github.com/repos/pmmp/PocketMine-MP/statuses/3fe707c59e06ce1cae8307b08f1bb6cfc4eb5a3d","head":{"label":"pmmp:forms-api","ref":"forms-api","sha":"3fe707c59e06ce1cae8307b08f1bb6cfc4eb5a3d","user":{"login":"pmmp","id":22548559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQ4NTU5","avatar_url":"https://avatars2.githubusercontent.com/u/22548559?v=4","gravatar_id":"","url":"https://api.github.com/users/pmmp","html_url":"https://github.com/pmmp","followers_url":"https://api.github.com/users/pmmp/followers","following_url":"https://api.github.com/users/pmmp/following{/other_user}","gists_url":"https://api.github.com/users/pmmp/gists{/gist_id}","starred_url":"https://api.github.com/users/pmmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmmp/subscriptions","organizations_url":"https://api.github.com/users/pmmp/orgs","repos_url":"https://api.github.com/users/pmmp/repos","events_url":"https://api.github.com/users/pmmp/events{/privacy}","received_events_url":"https://api.github.com/users/pmmp/received_events","type":"Organization","site_admin":false},"repo":{"id":69691727,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY5MTcyNw==","name":"PocketMine-MP","full_name":"pmmp/PocketMine-MP","owner":{"login":"pmmp","id":22548559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQ4NTU5","avatar_url":"https://avatars2.githubusercontent.com/u/22548559?v=4","gravatar_id":"","url":"https://api.github.com/users/pmmp","html_url":"https://github.com/pmmp","followers_url":"https://api.github.com/users/pmmp/followers","following_url":"https://api.github.com/users/pmmp/following{/other_user}","gists_url":"https://api.github.com/users/pmmp/gists{/gist_id}","starred_url":"https://api.github.com/users/pmmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmmp/subscriptions","organizations_url":"https://api.github.com/users/pmmp/orgs","repos_url":"https://api.github.com/users/pmmp/repos","events_url":"https://api.github.com/users/pmmp/events{/privacy}","received_events_url":"https://api.github.com/users/pmmp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmmp/PocketMine-MP","description":"A server software for Minecraft: Bedrock Edition in PHP","fork":false,"url":"https://api.github.com/repos/pmmp/PocketMine-MP","forks_url":"https://api.github.com/repos/pmmp/PocketMine-MP/forks","keys_url":"https://api.github.com/repos/pmmp/PocketMine-MP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmmp/PocketMine-MP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmmp/PocketMine-MP/teams","hooks_url":"https://api.github.com/repos/pmmp/PocketMine-MP/hooks","issue_events_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/events{/number}","events_url":"https://api.github.com/repos/pmmp/PocketMine-MP/events","assignees_url":"https://api.github.com/repos/pmmp/PocketMine-MP/assignees{/user}","branches_url":"https://api.github.com/repos/pmmp/PocketMine-MP/branches{/branch}","tags_url":"https://api.github.com/repos/pmmp/PocketMine-MP/tags","blobs_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmmp/PocketMine-MP/statuses/{sha}","languages_url":"https://api.github.com/repos/pmmp/PocketMine-MP/languages","stargazers_url":"https://api.github.com/repos/pmmp/PocketMine-MP/stargazers","contributors_url":"https://api.github.com/repos/pmmp/PocketMine-MP/contributors","subscribers_url":"https://api.github.com/repos/pmmp/PocketMine-MP/subscribers","subscription_url":"https://api.github.com/repos/pmmp/PocketMine-MP/subscription","commits_url":"https://api.github.com/repos/pmmp/PocketMine-MP/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmmp/PocketMine-MP/contents/{+path}","compare_url":"https://api.github.com/repos/pmmp/PocketMine-MP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmmp/PocketMine-MP/merges","archive_url":"https://api.github.com/repos/pmmp/PocketMine-MP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmmp/PocketMine-MP/downloads","issues_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues{/number}","pulls_url":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls{/number}","milestones_url":"https://api.github.com/repos/pmmp/PocketMine-MP/milestones{/number}","notifications_url":"https://api.github.com/repos/pmmp/PocketMine-MP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels{/name}","releases_url":"https://api.github.com/repos/pmmp/PocketMine-MP/releases{/id}","deployments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/deployments","created_at":"2016-09-30T18:29:35Z","updated_at":"2018-07-15T12:00:38Z","pushed_at":"2018-07-15T10:50:06Z","git_url":"git://github.com/pmmp/PocketMine-MP.git","ssh_url":"git@github.com:pmmp/PocketMine-MP.git","clone_url":"https://github.com/pmmp/PocketMine-MP.git","svn_url":"https://github.com/pmmp/PocketMine-MP","homepage":"https://pmmp.io","size":20964,"stargazers_count":980,"watchers_count":980,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":703,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":703,"open_issues":84,"watchers":980,"default_branch":"master"}},"base":{"label":"pmmp:release/3.1","ref":"release/3.1","sha":"2e18fe710ceb8e4f8f067041d18de0560359eecd","user":{"login":"pmmp","id":22548559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQ4NTU5","avatar_url":"https://avatars2.githubusercontent.com/u/22548559?v=4","gravatar_id":"","url":"https://api.github.com/users/pmmp","html_url":"https://github.com/pmmp","followers_url":"https://api.github.com/users/pmmp/followers","following_url":"https://api.github.com/users/pmmp/following{/other_user}","gists_url":"https://api.github.com/users/pmmp/gists{/gist_id}","starred_url":"https://api.github.com/users/pmmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmmp/subscriptions","organizations_url":"https://api.github.com/users/pmmp/orgs","repos_url":"https://api.github.com/users/pmmp/repos","events_url":"https://api.github.com/users/pmmp/events{/privacy}","received_events_url":"https://api.github.com/users/pmmp/received_events","type":"Organization","site_admin":false},"repo":{"id":69691727,"node_id":"MDEwOlJlcG9zaXRvcnk2OTY5MTcyNw==","name":"PocketMine-MP","full_name":"pmmp/PocketMine-MP","owner":{"login":"pmmp","id":22548559,"node_id":"MDEyOk9yZ2FuaXphdGlvbjIyNTQ4NTU5","avatar_url":"https://avatars2.githubusercontent.com/u/22548559?v=4","gravatar_id":"","url":"https://api.github.com/users/pmmp","html_url":"https://github.com/pmmp","followers_url":"https://api.github.com/users/pmmp/followers","following_url":"https://api.github.com/users/pmmp/following{/other_user}","gists_url":"https://api.github.com/users/pmmp/gists{/gist_id}","starred_url":"https://api.github.com/users/pmmp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pmmp/subscriptions","organizations_url":"https://api.github.com/users/pmmp/orgs","repos_url":"https://api.github.com/users/pmmp/repos","events_url":"https://api.github.com/users/pmmp/events{/privacy}","received_events_url":"https://api.github.com/users/pmmp/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pmmp/PocketMine-MP","description":"A server software for Minecraft: Bedrock Edition in PHP","fork":false,"url":"https://api.github.com/repos/pmmp/PocketMine-MP","forks_url":"https://api.github.com/repos/pmmp/PocketMine-MP/forks","keys_url":"https://api.github.com/repos/pmmp/PocketMine-MP/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pmmp/PocketMine-MP/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pmmp/PocketMine-MP/teams","hooks_url":"https://api.github.com/repos/pmmp/PocketMine-MP/hooks","issue_events_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/events{/number}","events_url":"https://api.github.com/repos/pmmp/PocketMine-MP/events","assignees_url":"https://api.github.com/repos/pmmp/PocketMine-MP/assignees{/user}","branches_url":"https://api.github.com/repos/pmmp/PocketMine-MP/branches{/branch}","tags_url":"https://api.github.com/repos/pmmp/PocketMine-MP/tags","blobs_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/refs{/sha}","trees_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pmmp/PocketMine-MP/statuses/{sha}","languages_url":"https://api.github.com/repos/pmmp/PocketMine-MP/languages","stargazers_url":"https://api.github.com/repos/pmmp/PocketMine-MP/stargazers","contributors_url":"https://api.github.com/repos/pmmp/PocketMine-MP/contributors","subscribers_url":"https://api.github.com/repos/pmmp/PocketMine-MP/subscribers","subscription_url":"https://api.github.com/repos/pmmp/PocketMine-MP/subscription","commits_url":"https://api.github.com/repos/pmmp/PocketMine-MP/commits{/sha}","git_commits_url":"https://api.github.com/repos/pmmp/PocketMine-MP/git/commits{/sha}","comments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/comments{/number}","issue_comment_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/comments{/number}","contents_url":"https://api.github.com/repos/pmmp/PocketMine-MP/contents/{+path}","compare_url":"https://api.github.com/repos/pmmp/PocketMine-MP/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pmmp/PocketMine-MP/merges","archive_url":"https://api.github.com/repos/pmmp/PocketMine-MP/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pmmp/PocketMine-MP/downloads","issues_url":"https://api.github.com/repos/pmmp/PocketMine-MP/issues{/number}","pulls_url":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls{/number}","milestones_url":"https://api.github.com/repos/pmmp/PocketMine-MP/milestones{/number}","notifications_url":"https://api.github.com/repos/pmmp/PocketMine-MP/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pmmp/PocketMine-MP/labels{/name}","releases_url":"https://api.github.com/repos/pmmp/PocketMine-MP/releases{/id}","deployments_url":"https://api.github.com/repos/pmmp/PocketMine-MP/deployments","created_at":"2016-09-30T18:29:35Z","updated_at":"2018-07-15T12:00:38Z","pushed_at":"2018-07-15T10:50:06Z","git_url":"git://github.com/pmmp/PocketMine-MP.git","ssh_url":"git@github.com:pmmp/PocketMine-MP.git","clone_url":"https://github.com/pmmp/PocketMine-MP.git","svn_url":"https://github.com/pmmp/PocketMine-MP","homepage":"https://pmmp.io","size":20964,"stargazers_count":980,"watchers_count":980,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":703,"mirror_url":null,"archived":false,"open_issues_count":84,"license":{"key":"lgpl-3.0","name":"GNU Lesser General Public License v3.0","spdx_id":"LGPL-3.0","url":"https://api.github.com/licenses/lgpl-3.0","node_id":"MDc6TGljZW5zZTEy"},"forks":703,"open_issues":84,"watchers":980,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/2308"},"html":{"href":"https://github.com/pmmp/PocketMine-MP/pull/2308"},"issue":{"href":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2308"},"comments":{"href":"https://api.github.com/repos/pmmp/PocketMine-MP/issues/2308/comments"},"review_comments":{"href":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/2308/comments"},"review_comment":{"href":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pmmp/PocketMine-MP/pulls/2308/commits"},"statuses":{"href":"https://api.github.com/repos/pmmp/PocketMine-MP/statuses/3fe707c59e06ce1cae8307b08f1bb6cfc4eb5a3d"}},"author_association":"MEMBER","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":42,"additions":1319,"deletions":1,"changed_files":19}}
{"actor":{"display_login":"dktapps"}}