{"action":"created","issue":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/708","repository_url":"https://api.github.com/repos/DataDog/dd-trace-py","labels_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/708/labels{/name}","comments_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/708/comments","events_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/708/events","html_url":"https://github.com/DataDog/dd-trace-py/pull/708","id":379841045,"node_id":"MDExOlB1bGxSZXF1ZXN0MjMwMTgzNjkz","number":708,"title":"[core] Allow DD_AGENT_HOST and DD_TRACE_AGENT_PORT env variables","user":{"login":"brettlangdon","id":1320353,"node_id":"MDQ6VXNlcjEzMjAzNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1320353?v=4","gravatar_id":"","url":"https://api.github.com/users/brettlangdon","html_url":"https://github.com/brettlangdon","followers_url":"https://api.github.com/users/brettlangdon/followers","following_url":"https://api.github.com/users/brettlangdon/following{/other_user}","gists_url":"https://api.github.com/users/brettlangdon/gists{/gist_id}","starred_url":"https://api.github.com/users/brettlangdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettlangdon/subscriptions","organizations_url":"https://api.github.com/users/brettlangdon/orgs","repos_url":"https://api.github.com/users/brettlangdon/repos","events_url":"https://api.github.com/users/brettlangdon/events{/privacy}","received_events_url":"https://api.github.com/users/brettlangdon/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones/29","html_url":"https://github.com/DataDog/dd-trace-py/milestone/29","labels_url":"https://api.github.com/repos/DataDog/dd-trace-py/milestones/29/labels","id":3800265,"node_id":"MDk6TWlsZXN0b25lMzgwMDI2NQ==","number":29,"title":"0.17.0","description":"","creator":{"login":"brettlangdon","id":1320353,"node_id":"MDQ6VXNlcjEzMjAzNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1320353?v=4","gravatar_id":"","url":"https://api.github.com/users/brettlangdon","html_url":"https://github.com/brettlangdon","followers_url":"https://api.github.com/users/brettlangdon/followers","following_url":"https://api.github.com/users/brettlangdon/following{/other_user}","gists_url":"https://api.github.com/users/brettlangdon/gists{/gist_id}","starred_url":"https://api.github.com/users/brettlangdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettlangdon/subscriptions","organizations_url":"https://api.github.com/users/brettlangdon/orgs","repos_url":"https://api.github.com/users/brettlangdon/repos","events_url":"https://api.github.com/users/brettlangdon/events{/privacy}","received_events_url":"https://api.github.com/users/brettlangdon/received_events","type":"User","site_admin":false},"open_issues":11,"closed_issues":12,"state":"open","created_at":"2018-11-06T13:27:53Z","updated_at":"2018-11-13T19:40:28Z","due_on":null,"closed_at":null},"comments":0,"created_at":"2018-11-12T15:58:15Z","updated_at":"2018-11-13T22:19:46Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/pulls/708","html_url":"https://github.com/DataDog/dd-trace-py/pull/708","diff_url":"https://github.com/DataDog/dd-trace-py/pull/708.diff","patch_url":"https://github.com/DataDog/dd-trace-py/pull/708.patch"},"body":"To help support desired containerization onboarding improvements we need to support `DD_AGENT_HOST` and `DD_TRACE_AGENT_PORT` environment variables for configuration.\r\n\r\nThese changes are the minimal viable changes needed to support these variables. It isn't the most clean, using something like `get_env()` would be better, but we decided to get this out the door since @Kyle-Verhoog has a task to work on standardizing our `DD_*` variables."},"comment":{"url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/comments/438460270","html_url":"https://github.com/DataDog/dd-trace-py/pull/708#issuecomment-438460270","issue_url":"https://api.github.com/repos/DataDog/dd-trace-py/issues/708","id":438460270,"node_id":"MDEyOklzc3VlQ29tbWVudDQzODQ2MDI3MA==","user":{"login":"brettlangdon","id":1320353,"node_id":"MDQ6VXNlcjEzMjAzNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1320353?v=4","gravatar_id":"","url":"https://api.github.com/users/brettlangdon","html_url":"https://github.com/brettlangdon","followers_url":"https://api.github.com/users/brettlangdon/followers","following_url":"https://api.github.com/users/brettlangdon/following{/other_user}","gists_url":"https://api.github.com/users/brettlangdon/gists{/gist_id}","starred_url":"https://api.github.com/users/brettlangdon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/brettlangdon/subscriptions","organizations_url":"https://api.github.com/users/brettlangdon/orgs","repos_url":"https://api.github.com/users/brettlangdon/repos","events_url":"https://api.github.com/users/brettlangdon/events{/privacy}","received_events_url":"https://api.github.com/users/brettlangdon/received_events","type":"User","site_admin":false},"created_at":"2018-11-13T22:19:46Z","updated_at":"2018-11-13T22:19:46Z","author_association":"MEMBER","body":"@palazzem I think if I understood what you were looking for correctly, I updated the tests to also run the same hostname check runner, but without using `ddtrace-run`. I also updated those tests to use a non-default port... just to be sure."}}
{"actor":{"display_login":"brettlangdon"}}