{"action":"created","comment":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/213293486","pull_request_review_id":150097515,"id":213293486,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMzI5MzQ4Ng==","diff_hunk":"@@ -14,6 +14,10 @@ stdenv.mkDerivation rec {\n   nativeBuildInputs = [ pkgconfig texinfo ];\n   buildInputs = [ libuuid gettext ];\n \n+  preConfigure = stdenv.lib.optionalString stdenv.hostPlatform.isMusl ''\n+    NIX_CFLAGS_COMPILE+=\" -D__GNUC_PREREQ(maj,min)=0\"","path":"pkgs/tools/filesystems/e2fsprogs/default.nix","position":5,"original_position":5,"commit_id":"6c77871cf1a007cba0f614e5fb59b028595c9634","original_commit_id":"6c77871cf1a007cba0f614e5fb59b028595c9634","user":{"login":"Mic92","id":96200,"node_id":"MDQ6VXNlcjk2MjAw","avatar_url":"https://avatars3.githubusercontent.com/u/96200?v=4","gravatar_id":"","url":"https://api.github.com/users/Mic92","html_url":"https://github.com/Mic92","followers_url":"https://api.github.com/users/Mic92/followers","following_url":"https://api.github.com/users/Mic92/following{/other_user}","gists_url":"https://api.github.com/users/Mic92/gists{/gist_id}","starred_url":"https://api.github.com/users/Mic92/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Mic92/subscriptions","organizations_url":"https://api.github.com/users/Mic92/orgs","repos_url":"https://api.github.com/users/Mic92/repos","events_url":"https://api.github.com/users/Mic92/events{/privacy}","received_events_url":"https://api.github.com/users/Mic92/received_events","type":"User","site_admin":false},"body":"This can be also done in nix no?\r\n```nix\r\nNIX_CFLAGS_COMPILE = stdenv.lib.optional stdenv.hostPlatform.isMusl \" -D__GNUC_PREREQ(maj,min)=0\";\r\n```","created_at":"2018-08-28T12:31:51Z","updated_at":"2018-08-28T12:31:51Z","html_url":"https://github.com/NixOS/nixpkgs/pull/45703#discussion_r213293486","pull_request_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45703","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments/213293486"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45703#discussion_r213293486"},"pull_request":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45703"}},"in_reply_to_id":213292859},"pull_request":{"url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45703","id":211394511,"node_id":"MDExOlB1bGxSZXF1ZXN0MjExMzk0NTEx","html_url":"https://github.com/NixOS/nixpkgs/pull/45703","diff_url":"https://github.com/NixOS/nixpkgs/pull/45703.diff","patch_url":"https://github.com/NixOS/nixpkgs/pull/45703.patch","issue_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45703","number":45703,"state":"open","locked":false,"title":"e2fsprogs: fix w/musl, __GNUC_PREREQ is glibc-ism","user":{"login":"dtzWill","id":817330,"node_id":"MDQ6VXNlcjgxNzMzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"body":"These are used to guard diagnostic push/pop pragmas\n(to selectively quiet warnings).\n\n\n<!-- Please check what applies. Note that these are not hard requirements but merely serve as information for reviewers. -->\n\n- [x] Tested using sandboxing ([nix.useSandbox](http://nixos.org/nixos/manual/options.html#opt-nix.useSandbox) on NixOS, or option `sandbox` in [`nix.conf`](http://nixos.org/nix/manual/#sec-conf-file) on non-NixOS)\n- Built on platform(s)\n   - [x] NixOS\n   - [ ] macOS\n   - [ ] other Linux distributions\n- [ ] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside [nixos/tests](https://github.com/NixOS/nixpkgs/blob/master/nixos/tests))\n- [ ] Tested compilation of all pkgs that depend on this change using `nix-shell -p nox --run \"nox-review wip\"`\n- [x] Tested execution of all binary files (usually in `./result/bin/`)\n- [ ] Determined the impact on package closure size (by running `nix path-info -S` before and after)\n- [ ] Fits [CONTRIBUTING.md](https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md).\n\n---","created_at":"2018-08-28T11:49:17Z","updated_at":"2018-08-28T12:31:51Z","closed_at":null,"merged_at":null,"merge_commit_sha":"197c1a91c27b08fcb0d7dabe8a2618b646efbedc","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":731735222,"node_id":"MDU6TGFiZWw3MzE3MzUyMjI=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-darwin:%201-10","name":"10.rebuild-darwin: 1-10","color":"eeffee","default":false},{"id":731734523,"node_id":"MDU6TGFiZWw3MzE3MzQ1MjM=","url":"https://api.github.com/repos/NixOS/nixpkgs/labels/10.rebuild-linux:%20501+","name":"10.rebuild-linux: 501+","color":"b60205","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45703/commits","review_comments_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45703/comments","review_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/45703/comments","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/6c77871cf1a007cba0f614e5fb59b028595c9634","head":{"label":"dtzWill:fix/e2fsprogs-musl","ref":"fix/e2fsprogs-musl","sha":"6c77871cf1a007cba0f614e5fb59b028595c9634","user":{"login":"dtzWill","id":817330,"node_id":"MDQ6VXNlcjgxNzMzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"repo":{"id":60178915,"node_id":"MDEwOlJlcG9zaXRvcnk2MDE3ODkxNQ==","name":"nixpkgs","full_name":"dtzWill/nixpkgs","owner":{"login":"dtzWill","id":817330,"node_id":"MDQ6VXNlcjgxNzMzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/817330?v=4","gravatar_id":"","url":"https://api.github.com/users/dtzWill","html_url":"https://github.com/dtzWill","followers_url":"https://api.github.com/users/dtzWill/followers","following_url":"https://api.github.com/users/dtzWill/following{/other_user}","gists_url":"https://api.github.com/users/dtzWill/gists{/gist_id}","starred_url":"https://api.github.com/users/dtzWill/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dtzWill/subscriptions","organizations_url":"https://api.github.com/users/dtzWill/orgs","repos_url":"https://api.github.com/users/dtzWill/repos","events_url":"https://api.github.com/users/dtzWill/events{/privacy}","received_events_url":"https://api.github.com/users/dtzWill/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/dtzWill/nixpkgs","description":"Nix Packages collection","fork":true,"url":"https://api.github.com/repos/dtzWill/nixpkgs","forks_url":"https://api.github.com/repos/dtzWill/nixpkgs/forks","keys_url":"https://api.github.com/repos/dtzWill/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/dtzWill/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/dtzWill/nixpkgs/teams","hooks_url":"https://api.github.com/repos/dtzWill/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/dtzWill/nixpkgs/events","assignees_url":"https://api.github.com/repos/dtzWill/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/dtzWill/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/dtzWill/nixpkgs/tags","blobs_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/dtzWill/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/dtzWill/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/dtzWill/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/dtzWill/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/dtzWill/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/dtzWill/nixpkgs/subscription","commits_url":"https://api.github.com/repos/dtzWill/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/dtzWill/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/dtzWill/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/dtzWill/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/dtzWill/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/dtzWill/nixpkgs/merges","archive_url":"https://api.github.com/repos/dtzWill/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/dtzWill/nixpkgs/downloads","issues_url":"https://api.github.com/repos/dtzWill/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/dtzWill/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/dtzWill/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/dtzWill/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/dtzWill/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/dtzWill/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/dtzWill/nixpkgs/deployments","created_at":"2016-06-01T13:23:48Z","updated_at":"2018-08-23T14:39:30Z","pushed_at":"2018-08-28T11:47:39Z","git_url":"git://github.com/dtzWill/nixpkgs.git","ssh_url":"git@github.com:dtzWill/nixpkgs.git","clone_url":"https://github.com/dtzWill/nixpkgs.git","svn_url":"https://github.com/dtzWill/nixpkgs","homepage":null,"size":780314,"stargazers_count":0,"watchers_count":0,"language":"Nix","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"NixOS:staging","ref":"staging","sha":"775d1ecf578bed07b22f5780feae60f6272b4f1e","user":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"repo":{"id":4542716,"node_id":"MDEwOlJlcG9zaXRvcnk0NTQyNzE2","name":"nixpkgs","full_name":"NixOS/nixpkgs","owner":{"login":"NixOS","id":487568,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQ4NzU2OA==","avatar_url":"https://avatars3.githubusercontent.com/u/487568?v=4","gravatar_id":"","url":"https://api.github.com/users/NixOS","html_url":"https://github.com/NixOS","followers_url":"https://api.github.com/users/NixOS/followers","following_url":"https://api.github.com/users/NixOS/following{/other_user}","gists_url":"https://api.github.com/users/NixOS/gists{/gist_id}","starred_url":"https://api.github.com/users/NixOS/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/NixOS/subscriptions","organizations_url":"https://api.github.com/users/NixOS/orgs","repos_url":"https://api.github.com/users/NixOS/repos","events_url":"https://api.github.com/users/NixOS/events{/privacy}","received_events_url":"https://api.github.com/users/NixOS/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/NixOS/nixpkgs","description":"Nix Packages collection","fork":false,"url":"https://api.github.com/repos/NixOS/nixpkgs","forks_url":"https://api.github.com/repos/NixOS/nixpkgs/forks","keys_url":"https://api.github.com/repos/NixOS/nixpkgs/keys{/key_id}","collaborators_url":"https://api.github.com/repos/NixOS/nixpkgs/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/NixOS/nixpkgs/teams","hooks_url":"https://api.github.com/repos/NixOS/nixpkgs/hooks","issue_events_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/events{/number}","events_url":"https://api.github.com/repos/NixOS/nixpkgs/events","assignees_url":"https://api.github.com/repos/NixOS/nixpkgs/assignees{/user}","branches_url":"https://api.github.com/repos/NixOS/nixpkgs/branches{/branch}","tags_url":"https://api.github.com/repos/NixOS/nixpkgs/tags","blobs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/NixOS/nixpkgs/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/NixOS/nixpkgs/git/refs{/sha}","trees_url":"https://api.github.com/repos/NixOS/nixpkgs/git/trees{/sha}","statuses_url":"https://api.github.com/repos/NixOS/nixpkgs/statuses/{sha}","languages_url":"https://api.github.com/repos/NixOS/nixpkgs/languages","stargazers_url":"https://api.github.com/repos/NixOS/nixpkgs/stargazers","contributors_url":"https://api.github.com/repos/NixOS/nixpkgs/contributors","subscribers_url":"https://api.github.com/repos/NixOS/nixpkgs/subscribers","subscription_url":"https://api.github.com/repos/NixOS/nixpkgs/subscription","commits_url":"https://api.github.com/repos/NixOS/nixpkgs/commits{/sha}","git_commits_url":"https://api.github.com/repos/NixOS/nixpkgs/git/commits{/sha}","comments_url":"https://api.github.com/repos/NixOS/nixpkgs/comments{/number}","issue_comment_url":"https://api.github.com/repos/NixOS/nixpkgs/issues/comments{/number}","contents_url":"https://api.github.com/repos/NixOS/nixpkgs/contents/{+path}","compare_url":"https://api.github.com/repos/NixOS/nixpkgs/compare/{base}...{head}","merges_url":"https://api.github.com/repos/NixOS/nixpkgs/merges","archive_url":"https://api.github.com/repos/NixOS/nixpkgs/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/NixOS/nixpkgs/downloads","issues_url":"https://api.github.com/repos/NixOS/nixpkgs/issues{/number}","pulls_url":"https://api.github.com/repos/NixOS/nixpkgs/pulls{/number}","milestones_url":"https://api.github.com/repos/NixOS/nixpkgs/milestones{/number}","notifications_url":"https://api.github.com/repos/NixOS/nixpkgs/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/NixOS/nixpkgs/labels{/name}","releases_url":"https://api.github.com/repos/NixOS/nixpkgs/releases{/id}","deployments_url":"https://api.github.com/repos/NixOS/nixpkgs/deployments","created_at":"2012-06-04T02:49:46Z","updated_at":"2018-08-28T12:28:41Z","pushed_at":"2018-08-28T12:25:04Z","git_url":"git://github.com/NixOS/nixpkgs.git","ssh_url":"git@github.com:NixOS/nixpkgs.git","clone_url":"https://github.com/NixOS/nixpkgs.git","svn_url":"https://github.com/NixOS/nixpkgs","homepage":null,"size":843801,"stargazers_count":2725,"watchers_count":2725,"language":"Nix","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":2971,"mirror_url":null,"archived":false,"open_issues_count":3106,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":2971,"open_issues":3106,"watchers":2725,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45703"},"html":{"href":"https://github.com/NixOS/nixpkgs/pull/45703"},"issue":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45703"},"comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/issues/45703/comments"},"review_comments":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45703/comments"},"review_comment":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/NixOS/nixpkgs/pulls/45703/commits"},"statuses":{"href":"https://api.github.com/repos/NixOS/nixpkgs/statuses/6c77871cf1a007cba0f614e5fb59b028595c9634"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Mic92"}}