{"action":"created","comment":{"url":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/comments/211907034","pull_request_review_id":148424250,"id":211907034,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxMTkwNzAzNA==","diff_hunk":"@@ -67,4 +67,46 @@ class TaxCalcResourceISpec extends IntegrationSpec {\n       }\n     }\n   }\n+\n+  \"GET Tax Calculation Messages\" should {\n+    \"return a 200 with a json response body\" when {\n+      \"the downstream response from the self assessment api version 1.0 returns a 200 with a json response body\" in {\n+        val url = \"/ni/AA111111A/calculations/041f7e4d-87d9-4d4a-a296-3cfbdf92f7e2/validation-messages\"\n+\n+        Given()\n+          .theClientIsAuthorised\n+          .And()\n+          .get(url)\n+          .returns(aResponse\n+            .withStatus(NOT_FOUND))","path":"it/router/resources/TaxCalcResourceISpec.scala","position":15,"original_position":15,"commit_id":"a05991b16595d780075938314eb9a87ec35f9395","original_commit_id":"a05991b16595d780075938314eb9a87ec35f9395","user":{"login":"MarkAKelly","id":21219364,"node_id":"MDQ6VXNlcjIxMjE5MzY0","avatar_url":"https://avatars2.githubusercontent.com/u/21219364?v=4","gravatar_id":"","url":"https://api.github.com/users/MarkAKelly","html_url":"https://github.com/MarkAKelly","followers_url":"https://api.github.com/users/MarkAKelly/followers","following_url":"https://api.github.com/users/MarkAKelly/following{/other_user}","gists_url":"https://api.github.com/users/MarkAKelly/gists{/gist_id}","starred_url":"https://api.github.com/users/MarkAKelly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/MarkAKelly/subscriptions","organizations_url":"https://api.github.com/users/MarkAKelly/orgs","repos_url":"https://api.github.com/users/MarkAKelly/repos","events_url":"https://api.github.com/users/MarkAKelly/events{/privacy}","received_events_url":"https://api.github.com/users/MarkAKelly/received_events","type":"User","site_admin":false},"body":"Shouldn't be in the 200 response block ","created_at":"2018-08-22T10:36:42Z","updated_at":"2018-08-22T10:36:42Z","html_url":"https://github.com/hmrc/self-assessment-api-router/pull/49#discussion_r211907034","pull_request_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/49","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/comments/211907034"},"html":{"href":"https://github.com/hmrc/self-assessment-api-router/pull/49#discussion_r211907034"},"pull_request":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/49"}}},"pull_request":{"url":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/49","id":210079573,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwMDc5NTcz","html_url":"https://github.com/hmrc/self-assessment-api-router/pull/49","diff_url":"https://github.com/hmrc/self-assessment-api-router/pull/49.diff","patch_url":"https://github.com/hmrc/self-assessment-api-router/pull/49.patch","issue_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues/49","number":49,"state":"open","locked":false,"title":"MTDSA-2079 : Implemented new routing logic in router","user":{"login":"narendravijayarao","id":26090262,"node_id":"MDQ6VXNlcjI2MDkwMjYy","avatar_url":"https://avatars3.githubusercontent.com/u/26090262?v=4","gravatar_id":"","url":"https://api.github.com/users/narendravijayarao","html_url":"https://github.com/narendravijayarao","followers_url":"https://api.github.com/users/narendravijayarao/followers","following_url":"https://api.github.com/users/narendravijayarao/following{/other_user}","gists_url":"https://api.github.com/users/narendravijayarao/gists{/gist_id}","starred_url":"https://api.github.com/users/narendravijayarao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/narendravijayarao/subscriptions","organizations_url":"https://api.github.com/users/narendravijayarao/orgs","repos_url":"https://api.github.com/users/narendravijayarao/repos","events_url":"https://api.github.com/users/narendravijayarao/events{/privacy}","received_events_url":"https://api.github.com/users/narendravijayarao/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-22T09:57:15Z","updated_at":"2018-08-22T10:36:42Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1766ddd02c702f0614dae0d8370040ce9956e13","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/49/commits","review_comments_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/49/comments","review_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/comments{/number}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues/49/comments","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/statuses/a05991b16595d780075938314eb9a87ec35f9395","head":{"label":"hmrc:MTDSA-2079","ref":"MTDSA-2079","sha":"a05991b16595d780075938314eb9a87ec35f9395","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":134717964,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3MTc5NjQ=","name":"self-assessment-api-router","full_name":"hmrc/self-assessment-api-router","owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/self-assessment-api-router","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/self-assessment-api-router","forks_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/forks","keys_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/teams","hooks_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/hooks","issue_events_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/events","assignees_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/tags","blobs_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/languages","stargazers_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/stargazers","contributors_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/contributors","subscribers_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/subscribers","subscription_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/subscription","commits_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/merges","archive_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/downloads","issues_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/deployments","created_at":"2018-05-24T13:17:25Z","updated_at":"2018-08-14T10:48:42Z","pushed_at":"2018-08-22T10:28:43Z","git_url":"git://github.com/hmrc/self-assessment-api-router.git","ssh_url":"git@github.com:hmrc/self-assessment-api-router.git","clone_url":"https://github.com/hmrc/self-assessment-api-router.git","svn_url":"https://github.com/hmrc/self-assessment-api-router","homepage":"","size":229,"stargazers_count":0,"watchers_count":0,"language":"RAML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"base":{"label":"hmrc:master","ref":"master","sha":"a8004bb0ba7feac1a0b220989e049391a9945ea1","user":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"repo":{"id":134717964,"node_id":"MDEwOlJlcG9zaXRvcnkxMzQ3MTc5NjQ=","name":"self-assessment-api-router","full_name":"hmrc/self-assessment-api-router","owner":{"login":"hmrc","id":5755339,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU3NTUzMzk=","avatar_url":"https://avatars1.githubusercontent.com/u/5755339?v=4","gravatar_id":"","url":"https://api.github.com/users/hmrc","html_url":"https://github.com/hmrc","followers_url":"https://api.github.com/users/hmrc/followers","following_url":"https://api.github.com/users/hmrc/following{/other_user}","gists_url":"https://api.github.com/users/hmrc/gists{/gist_id}","starred_url":"https://api.github.com/users/hmrc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hmrc/subscriptions","organizations_url":"https://api.github.com/users/hmrc/orgs","repos_url":"https://api.github.com/users/hmrc/repos","events_url":"https://api.github.com/users/hmrc/events{/privacy}","received_events_url":"https://api.github.com/users/hmrc/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/hmrc/self-assessment-api-router","description":null,"fork":false,"url":"https://api.github.com/repos/hmrc/self-assessment-api-router","forks_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/forks","keys_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/keys{/key_id}","collaborators_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/teams","hooks_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/hooks","issue_events_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues/events{/number}","events_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/events","assignees_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/assignees{/user}","branches_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/branches{/branch}","tags_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/tags","blobs_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/refs{/sha}","trees_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/trees{/sha}","statuses_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/statuses/{sha}","languages_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/languages","stargazers_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/stargazers","contributors_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/contributors","subscribers_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/subscribers","subscription_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/subscription","commits_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/commits{/sha}","git_commits_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/git/commits{/sha}","comments_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/comments{/number}","issue_comment_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues/comments{/number}","contents_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/contents/{+path}","compare_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/compare/{base}...{head}","merges_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/merges","archive_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/downloads","issues_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues{/number}","pulls_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls{/number}","milestones_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/milestones{/number}","notifications_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/labels{/name}","releases_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/releases{/id}","deployments_url":"https://api.github.com/repos/hmrc/self-assessment-api-router/deployments","created_at":"2018-05-24T13:17:25Z","updated_at":"2018-08-14T10:48:42Z","pushed_at":"2018-08-22T10:28:43Z","git_url":"git://github.com/hmrc/self-assessment-api-router.git","ssh_url":"git@github.com:hmrc/self-assessment-api-router.git","clone_url":"https://github.com/hmrc/self-assessment-api-router.git","svn_url":"https://github.com/hmrc/self-assessment-api-router","homepage":"","size":229,"stargazers_count":0,"watchers_count":0,"language":"RAML","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":1,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/49"},"html":{"href":"https://github.com/hmrc/self-assessment-api-router/pull/49"},"issue":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues/49"},"comments":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/issues/49/comments"},"review_comments":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/49/comments"},"review_comment":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/pulls/49/commits"},"statuses":{"href":"https://api.github.com/repos/hmrc/self-assessment-api-router/statuses/a05991b16595d780075938314eb9a87ec35f9395"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"MarkAKelly"}}