{"action":"created","issue":{"url":"https://api.github.com/repos/openmrs/openmrs-ocl-client/issues/14","repository_url":"https://api.github.com/repos/openmrs/openmrs-ocl-client","labels_url":"https://api.github.com/repos/openmrs/openmrs-ocl-client/issues/14/labels{/name}","comments_url":"https://api.github.com/repos/openmrs/openmrs-ocl-client/issues/14/comments","events_url":"https://api.github.com/repos/openmrs/openmrs-ocl-client/issues/14/events","html_url":"https://github.com/openmrs/openmrs-ocl-client/pull/14","id":325617222,"number":14,"title":"OCLOMRS-27: Adding Nginx Configuration to allow serving of different URL's in the single page application","user":{"login":"mwaz","id":10160787,"avatar_url":"https://avatars0.githubusercontent.com/u/10160787?v=4","gravatar_id":"","url":"https://api.github.com/users/mwaz","html_url":"https://github.com/mwaz","followers_url":"https://api.github.com/users/mwaz/followers","following_url":"https://api.github.com/users/mwaz/following{/other_user}","gists_url":"https://api.github.com/users/mwaz/gists{/gist_id}","starred_url":"https://api.github.com/users/mwaz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mwaz/subscriptions","organizations_url":"https://api.github.com/users/mwaz/orgs","repos_url":"https://api.github.com/users/mwaz/repos","events_url":"https://api.github.com/users/mwaz/events{/privacy}","received_events_url":"https://api.github.com/users/mwaz/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"cintiadr","id":2509707,"avatar_url":"https://avatars3.githubusercontent.com/u/2509707?v=4","gravatar_id":"","url":"https://api.github.com/users/cintiadr","html_url":"https://github.com/cintiadr","followers_url":"https://api.github.com/users/cintiadr/followers","following_url":"https://api.github.com/users/cintiadr/following{/other_user}","gists_url":"https://api.github.com/users/cintiadr/gists{/gist_id}","starred_url":"https://api.github.com/users/cintiadr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cintiadr/subscriptions","organizations_url":"https://api.github.com/users/cintiadr/orgs","repos_url":"https://api.github.com/users/cintiadr/repos","events_url":"https://api.github.com/users/cintiadr/events{/privacy}","received_events_url":"https://api.github.com/users/cintiadr/received_events","type":"User","site_admin":false},"assignees":[{"login":"cintiadr","id":2509707,"avatar_url":"https://avatars3.githubusercontent.com/u/2509707?v=4","gravatar_id":"","url":"https://api.github.com/users/cintiadr","html_url":"https://github.com/cintiadr","followers_url":"https://api.github.com/users/cintiadr/followers","following_url":"https://api.github.com/users/cintiadr/following{/other_user}","gists_url":"https://api.github.com/users/cintiadr/gists{/gist_id}","starred_url":"https://api.github.com/users/cintiadr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cintiadr/subscriptions","organizations_url":"https://api.github.com/users/cintiadr/orgs","repos_url":"https://api.github.com/users/cintiadr/repos","events_url":"https://api.github.com/users/cintiadr/events{/privacy}","received_events_url":"https://api.github.com/users/cintiadr/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-05-23T09:14:22Z","updated_at":"2018-05-23T10:26:03Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/openmrs/openmrs-ocl-client/pulls/14","html_url":"https://github.com/openmrs/openmrs-ocl-client/pull/14","diff_url":"https://github.com/openmrs/openmrs-ocl-client/pull/14.diff","patch_url":"https://github.com/openmrs/openmrs-ocl-client/pull/14.patch"},"body":"# JIRA TICKET NAME:\r\n[OCLOMRS-27](https://issues.openmrs.org/browse/OCLOMRS-27)\r\n\r\n# Summary:\r\nCurrently the default Nginx configuration does not allow serving different routes such as **_/dashboard_** or **_/login_**. The nginx.conf will overrride the default nginx settings and allow nginx to serve files from all the supplied URL's. The Pull Request is in relation to the Ticket [ITSM-4148](https://issues.openmrs.org/browse/ITSM-4148)."},"comment":{"url":"https://api.github.com/repos/openmrs/openmrs-ocl-client/issues/comments/391298899","html_url":"https://github.com/openmrs/openmrs-ocl-client/pull/14#issuecomment-391298899","issue_url":"https://api.github.com/repos/openmrs/openmrs-ocl-client/issues/14","id":391298899,"user":{"login":"cintiadr","id":2509707,"avatar_url":"https://avatars3.githubusercontent.com/u/2509707?v=4","gravatar_id":"","url":"https://api.github.com/users/cintiadr","html_url":"https://github.com/cintiadr","followers_url":"https://api.github.com/users/cintiadr/followers","following_url":"https://api.github.com/users/cintiadr/following{/other_user}","gists_url":"https://api.github.com/users/cintiadr/gists{/gist_id}","starred_url":"https://api.github.com/users/cintiadr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cintiadr/subscriptions","organizations_url":"https://api.github.com/users/cintiadr/orgs","repos_url":"https://api.github.com/users/cintiadr/repos","events_url":"https://api.github.com/users/cintiadr/events{/privacy}","received_events_url":"https://api.github.com/users/cintiadr/received_events","type":"User","site_admin":false},"created_at":"2018-05-23T10:26:03Z","updated_at":"2018-05-23T10:26:03Z","author_association":"NONE","body":"I'm slightly confused by what exactly you want to achieve. \r\nSo, you are _not_ able to change the the infrastructure nginx proxy. You cannot override or modify anything outside your docker container from inside your docker container, due to technical and logical restrictions. \r\nAny application-specific logic should be done inside your docker container. I have more than 20 docker containers running now, your docker container should be responsible for any logic required by your application. \r\n\r\nThat said, _nginx.conf_ is _not_ a yaml file. It only works for the infrastructure nginx, which happens to be deployed using ansible (which parsers a yaml file). I copied the lines so you could have an idea what our proxy is using. \r\n\r\nWhat you need to do, instead, is changing the file /etc/nginx/conf.d/default.conf inside your docker container. I don't really understand how you are modifying your docker image without changing your docker file. I did build your docker image locally, and as expected it didn't work. \r\n\r\nFirst, I'd strongly recommend you update the docker compose file, as I recommended before: https://github.com/openmrs/openmrs-ocl-client/pull/16\r\n\r\nAnd then, I'd ask you to do:\r\n\r\n# build docker image\r\n$ docker build -t openmrs/ocl-client:local .\r\n\r\n# start docker image\r\n$ docker-compose up -d\r\n\r\n# enter docker image\r\n$ docker exec -it openmrs-ocl-client_oclclient_1 sh \r\n\r\nCopy the file  /etc/nginx/conf.d/default.conf to this repo. Edit the way you want. \r\nChange your dockerfile to copy this file to your container. \r\n\r\nTo redo it:\r\n$ docker-compose down -v\r\n\r\n# build docker image\r\n$ docker build -t openmrs/ocl-client:local .\r\n\r\n# start docker image\r\n$ docker-compose up -d\r\n\r\nAfter you get it working inside your browser, locally, I think it would be good to go. \r\n\r\n\r\n"}}
{"actor":{"display_login":"cintiadr"}}