{"action":"created","issue":{"url":"https://api.github.com/repos/rear/rear/issues/1897","repository_url":"https://api.github.com/repos/rear/rear","labels_url":"https://api.github.com/repos/rear/rear/issues/1897/labels{/name}","comments_url":"https://api.github.com/repos/rear/rear/issues/1897/comments","events_url":"https://api.github.com/repos/rear/rear/issues/1897/events","html_url":"https://github.com/rear/rear/pull/1897","id":349192183,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzY2NzI0","number":1897,"title":"LVM: specifying uuid for 'lvmdev' is optional when recovering.","user":{"login":"rmetrich","id":1163635,"node_id":"MDQ6VXNlcjExNjM2MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163635?v=4","gravatar_id":"","url":"https://api.github.com/users/rmetrich","html_url":"https://github.com/rmetrich","followers_url":"https://api.github.com/users/rmetrich/followers","following_url":"https://api.github.com/users/rmetrich/following{/other_user}","gists_url":"https://api.github.com/users/rmetrich/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetrich/subscriptions","organizations_url":"https://api.github.com/users/rmetrich/orgs","repos_url":"https://api.github.com/users/rmetrich/repos","events_url":"https://api.github.com/users/rmetrich/events{/privacy}","received_events_url":"https://api.github.com/users/rmetrich/received_events","type":"User","site_admin":false},"labels":[{"id":430056618,"node_id":"MDU6TGFiZWw0MzAwNTY2MTg=","url":"https://api.github.com/repos/rear/rear/labels/minor%20bug","name":"minor bug","color":"ffaaaa","default":false}],"state":"open","locked":false,"assignee":{"login":"jsmeix","id":1788608,"node_id":"MDQ6VXNlcjE3ODg2MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false},"assignees":[{"login":"jsmeix","id":1788608,"node_id":"MDQ6VXNlcjE3ODg2MDg=","avatar_url":"https://avatars0.githubusercontent.com/u/1788608?v=4","gravatar_id":"","url":"https://api.github.com/users/jsmeix","html_url":"https://github.com/jsmeix","followers_url":"https://api.github.com/users/jsmeix/followers","following_url":"https://api.github.com/users/jsmeix/following{/other_user}","gists_url":"https://api.github.com/users/jsmeix/gists{/gist_id}","starred_url":"https://api.github.com/users/jsmeix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jsmeix/subscriptions","organizations_url":"https://api.github.com/users/jsmeix/orgs","repos_url":"https://api.github.com/users/jsmeix/repos","events_url":"https://api.github.com/users/jsmeix/events{/privacy}","received_events_url":"https://api.github.com/users/jsmeix/received_events","type":"User","site_admin":false}],"milestone":{"url":"https://api.github.com/repos/rear/rear/milestones/16","html_url":"https://github.com/rear/rear/milestone/16","labels_url":"https://api.github.com/repos/rear/rear/milestones/16/labels","id":3315699,"node_id":"MDk6TWlsZXN0b25lMzMxNTY5OQ==","number":16,"title":"ReaR v2.5","description":"For ReaR release 2.5 we do not have a release date in mind (maybe end of 2018 or beginning 2019). It depends on bug fixes or bleeding edge new features...\r\nOr, it can get faster when a company (or person) sponsor us to do the release sooner.","creator":{"login":"gdha","id":888633,"node_id":"MDQ6VXNlcjg4ODYzMw==","avatar_url":"https://avatars2.githubusercontent.com/u/888633?v=4","gravatar_id":"","url":"https://api.github.com/users/gdha","html_url":"https://github.com/gdha","followers_url":"https://api.github.com/users/gdha/followers","following_url":"https://api.github.com/users/gdha/following{/other_user}","gists_url":"https://api.github.com/users/gdha/gists{/gist_id}","starred_url":"https://api.github.com/users/gdha/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdha/subscriptions","organizations_url":"https://api.github.com/users/gdha/orgs","repos_url":"https://api.github.com/users/gdha/repos","events_url":"https://api.github.com/users/gdha/events{/privacy}","received_events_url":"https://api.github.com/users/gdha/received_events","type":"User","site_admin":false},"open_issues":18,"closed_issues":38,"state":"open","created_at":"2018-05-02T18:19:50Z","updated_at":"2018-08-10T09:06:31Z","due_on":null,"closed_at":null},"comments":1,"created_at":"2018-08-09T16:03:07Z","updated_at":"2018-08-10T09:32:23Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rear/rear/pulls/1897","html_url":"https://github.com/rear/rear/pull/1897","diff_url":"https://github.com/rear/rear/pull/1897.diff","patch_url":"https://github.com/rear/rear/pull/1897.patch"},"body":"#### Relax-and-Recover (ReaR) Pull Request Template\r\n\r\nPlease fill in the following items before submitting a new pull request:\r\n\r\n##### Pull Request Details:\r\n\r\n* Type: **Bug Fix** / **New Feature** / **Enhancement** / **Other?** Bug Fix\r\n\r\n* Impact: **Low** / **Normal** / **High** / **Critical** / **Urgent** Low\r\n\r\n* Reference to related issue (URL):\r\n\r\n* How was this pull request tested? Tested on RHEL 7 during LVM migration\r\n\r\n* Brief description of the changes in this pull request:\r\n\r\nDue to this, the `grep` must be adjusted to not expect a trailing blank at the end of the line.\r\nThis is typically used when migrating a PV to another disk while it already exists on the first disk. In such case, the uuid cannot be reused.\r\n\r\nExample of disklayout.conf line before removing the uuid:\r\n\r\n`lvmdev /dev/rhel /dev/sda2 w6XFUx-DeeL-uAEY-0nEn-1A3o-pLp1-qcwYdO 12345678`\r\n\r\nWhen removing the uuid (and unused size), the current code was breaking if there was no trailing space:\r\n\r\n`lvmdev /dev/rhel /dev/sda2<space>` : OK\r\n`lvmdev /dev/rhel /dev/sda2` : BAD\r\n\r\nThe new code also supports the second line, which is better for robustness.\r\n"},"comment":{"url":"https://api.github.com/repos/rear/rear/issues/comments/412030818","html_url":"https://github.com/rear/rear/pull/1897#issuecomment-412030818","issue_url":"https://api.github.com/repos/rear/rear/issues/1897","id":412030818,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMjAzMDgxOA==","user":{"login":"rmetrich","id":1163635,"node_id":"MDQ6VXNlcjExNjM2MzU=","avatar_url":"https://avatars0.githubusercontent.com/u/1163635?v=4","gravatar_id":"","url":"https://api.github.com/users/rmetrich","html_url":"https://github.com/rmetrich","followers_url":"https://api.github.com/users/rmetrich/followers","following_url":"https://api.github.com/users/rmetrich/following{/other_user}","gists_url":"https://api.github.com/users/rmetrich/gists{/gist_id}","starred_url":"https://api.github.com/users/rmetrich/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rmetrich/subscriptions","organizations_url":"https://api.github.com/users/rmetrich/orgs","repos_url":"https://api.github.com/users/rmetrich/repos","events_url":"https://api.github.com/users/rmetrich/events{/privacy}","received_events_url":"https://api.github.com/users/rmetrich/received_events","type":"User","site_admin":false},"created_at":"2018-08-10T09:32:23Z","updated_at":"2018-08-10T09:32:23Z","author_association":"CONTRIBUTOR","body":"@jsmeix the `grep -w` works for us here, because the 3rd field is the lvmdev device, which doesn't contain a dash which is considered as a word boundary.\r\nHere we will have `/dev/sda` for example.\r\nInitiallly the `grep` was done with a trailing space (e.g. `/dev/sda `) to avoid catching other devices starting similarly, such as `/dev/sdaw`. `grep -w` works for these cases also:\r\n\r\n~~~\r\n$ LAYOUT=\"$(echo -e \"lvmdev /dev/myfirstvg /dev/sdaw\\nlvmdev /dev/mysecondvg /dev/sda\\nlvmdev /dev/mythirdvg /dev/sda1\\nlvmdev /dev/myfirstvg /dev/sdax some-uuid somesize\\nlvmdev /dev/mysecondvg /dev/sda2\\n\")\"\r\n\r\n$ echo \"$LAYOUT\"\r\nlvmdev /dev/myfirstvg /dev/sdaw\r\nlvmdev /dev/mysecondvg /dev/sda\r\nlvmdev /dev/mythirdvg /dev/sda1\r\nlvmdev /dev/myfirstvg /dev/sdax some-uuid somesize\r\nlvmdev /dev/mysecondvg /dev/sda2\r\n\r\n$ PVNAME=\"pv:/dev/sda\"\r\n$ echo \"$LAYOUT\" | grep -w \"^lvmdev.*${PVNAME#pv:}\"\r\nlvmdev /dev/mysecondvg /dev/sda\r\n~~~"}}
{"actor":{"display_login":"rmetrich"}}