{"action":"created","comment":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/comments/192029819","pull_request_review_id":124719959,"id":192029819,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5MjAyOTgxOQ==","diff_hunk":"@@ -113,9 +121,39 @@ func TableFromMeta(alloc autoid.Allocator, tblInfo *model.TableInfo) (table.Tabl\n \t}\n \n \tt.meta = tblInfo\n+\tpartitionExpr, err := generatePartitionExpr(tblInfo)\n+\tif err != nil {\n+\t\treturn nil, errors.Trace(err)\n+\t}\n+\tt.partitionExpr = partitionExpr\n \treturn t, nil\n }\n \n+func generatePartitionExpr(tblInfo *model.TableInfo) ([]expression.Expression, error) {\n+\tpi := tblInfo.GetPartitionInfo()\n+\tif pi == nil {\n+\t\treturn nil, nil\n+\t}\n+\t// TODO: Only partition by range is supported currently.\n+\tif pi.Type != model.PartitionTypeRange {\n+\t\treturn nil, nil","path":"table/tables/tables.go","position":53,"original_position":53,"commit_id":"c9ebd05bcc1409c96d35251f989a026e3efba401","original_commit_id":"c9ebd05bcc1409c96d35251f989a026e3efba401","user":{"login":"tiancaiamao","id":1420062,"node_id":"MDQ6VXNlcjE0MjAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"body":"From the user's point of view, we don't support it does not not means it's an error, is that right?","created_at":"2018-05-31T08:51:36Z","updated_at":"2018-05-31T08:51:37Z","html_url":"https://github.com/pingcap/tidb/pull/6684#discussion_r192029819","pull_request_url":"https://api.github.com/repos/pingcap/tidb/pulls/6684","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments/192029819"},"html":{"href":"https://github.com/pingcap/tidb/pull/6684#discussion_r192029819"},"pull_request":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6684"}},"in_reply_to_id":192027983},"pull_request":{"url":"https://api.github.com/repos/pingcap/tidb/pulls/6684","id":191136833,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxMTM2ODMz","html_url":"https://github.com/pingcap/tidb/pull/6684","diff_url":"https://github.com/pingcap/tidb/pull/6684.diff","patch_url":"https://github.com/pingcap/tidb/pull/6684.patch","issue_url":"https://api.github.com/repos/pingcap/tidb/issues/6684","number":6684,"state":"open","locked":false,"title":"table/tables: modify `AddRecord` to handle table partition","user":{"login":"tiancaiamao","id":1420062,"node_id":"MDQ6VXNlcjE0MjAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"body":"If table partition is used, AddRecord will add records to the\r\npartition, according to the partition definitions.\r\n\r\n@coocood @winkyao ","created_at":"2018-05-29T12:56:05Z","updated_at":"2018-05-31T08:51:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b569300c24eabdf9dc00d53f58273ecede4f1e36","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":564574080,"node_id":"MDU6TGFiZWw1NjQ1NzQwODA=","url":"https://api.github.com/repos/pingcap/tidb/labels/LGT1","name":"LGT1","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/pingcap/tidb/pulls/6684/commits","review_comments_url":"https://api.github.com/repos/pingcap/tidb/pulls/6684/comments","review_comment_url":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pingcap/tidb/issues/6684/comments","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/c9ebd05bcc1409c96d35251f989a026e3efba401","head":{"label":"tiancaiamao:partition-insert","ref":"partition-insert","sha":"c9ebd05bcc1409c96d35251f989a026e3efba401","user":{"login":"tiancaiamao","id":1420062,"node_id":"MDQ6VXNlcjE0MjAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"repo":{"id":63065396,"node_id":"MDEwOlJlcG9zaXRvcnk2MzA2NTM5Ng==","name":"tidb","full_name":"tiancaiamao/tidb","owner":{"login":"tiancaiamao","id":1420062,"node_id":"MDQ6VXNlcjE0MjAwNjI=","avatar_url":"https://avatars2.githubusercontent.com/u/1420062?v=4","gravatar_id":"","url":"https://api.github.com/users/tiancaiamao","html_url":"https://github.com/tiancaiamao","followers_url":"https://api.github.com/users/tiancaiamao/followers","following_url":"https://api.github.com/users/tiancaiamao/following{/other_user}","gists_url":"https://api.github.com/users/tiancaiamao/gists{/gist_id}","starred_url":"https://api.github.com/users/tiancaiamao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tiancaiamao/subscriptions","organizations_url":"https://api.github.com/users/tiancaiamao/orgs","repos_url":"https://api.github.com/users/tiancaiamao/repos","events_url":"https://api.github.com/users/tiancaiamao/events{/privacy}","received_events_url":"https://api.github.com/users/tiancaiamao/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tiancaiamao/tidb","description":"TiDB is a distributed NewSQL database compatible with MySQL protocol ","fork":true,"url":"https://api.github.com/repos/tiancaiamao/tidb","forks_url":"https://api.github.com/repos/tiancaiamao/tidb/forks","keys_url":"https://api.github.com/repos/tiancaiamao/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tiancaiamao/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tiancaiamao/tidb/teams","hooks_url":"https://api.github.com/repos/tiancaiamao/tidb/hooks","issue_events_url":"https://api.github.com/repos/tiancaiamao/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/tiancaiamao/tidb/events","assignees_url":"https://api.github.com/repos/tiancaiamao/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/tiancaiamao/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/tiancaiamao/tidb/tags","blobs_url":"https://api.github.com/repos/tiancaiamao/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tiancaiamao/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tiancaiamao/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/tiancaiamao/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tiancaiamao/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/tiancaiamao/tidb/languages","stargazers_url":"https://api.github.com/repos/tiancaiamao/tidb/stargazers","contributors_url":"https://api.github.com/repos/tiancaiamao/tidb/contributors","subscribers_url":"https://api.github.com/repos/tiancaiamao/tidb/subscribers","subscription_url":"https://api.github.com/repos/tiancaiamao/tidb/subscription","commits_url":"https://api.github.com/repos/tiancaiamao/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/tiancaiamao/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/tiancaiamao/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/tiancaiamao/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/tiancaiamao/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/tiancaiamao/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tiancaiamao/tidb/merges","archive_url":"https://api.github.com/repos/tiancaiamao/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tiancaiamao/tidb/downloads","issues_url":"https://api.github.com/repos/tiancaiamao/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/tiancaiamao/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/tiancaiamao/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/tiancaiamao/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tiancaiamao/tidb/labels{/name}","releases_url":"https://api.github.com/repos/tiancaiamao/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/tiancaiamao/tidb/deployments","created_at":"2016-07-11T12:20:13Z","updated_at":"2016-07-11T12:20:15Z","pushed_at":"2018-05-31T08:05:51Z","git_url":"git://github.com/tiancaiamao/tidb.git","ssh_url":"git@github.com:tiancaiamao/tidb.git","clone_url":"https://github.com/tiancaiamao/tidb.git","svn_url":"https://github.com/tiancaiamao/tidb","homepage":"","size":50167,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pingcap:master","ref":"master","sha":"55dd23fde1de8cb9877de5d2b2bfddd668a989d7","user":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"repo":{"id":41986369,"node_id":"MDEwOlJlcG9zaXRvcnk0MTk4NjM2OQ==","name":"tidb","full_name":"pingcap/tidb","owner":{"login":"pingcap","id":11855343,"node_id":"MDEyOk9yZ2FuaXphdGlvbjExODU1MzQz","avatar_url":"https://avatars3.githubusercontent.com/u/11855343?v=4","gravatar_id":"","url":"https://api.github.com/users/pingcap","html_url":"https://github.com/pingcap","followers_url":"https://api.github.com/users/pingcap/followers","following_url":"https://api.github.com/users/pingcap/following{/other_user}","gists_url":"https://api.github.com/users/pingcap/gists{/gist_id}","starred_url":"https://api.github.com/users/pingcap/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pingcap/subscriptions","organizations_url":"https://api.github.com/users/pingcap/orgs","repos_url":"https://api.github.com/users/pingcap/repos","events_url":"https://api.github.com/users/pingcap/events{/privacy}","received_events_url":"https://api.github.com/users/pingcap/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pingcap/tidb","description":"TiDB is a distributed HTAP database compatible with the MySQL protocol ","fork":false,"url":"https://api.github.com/repos/pingcap/tidb","forks_url":"https://api.github.com/repos/pingcap/tidb/forks","keys_url":"https://api.github.com/repos/pingcap/tidb/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pingcap/tidb/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pingcap/tidb/teams","hooks_url":"https://api.github.com/repos/pingcap/tidb/hooks","issue_events_url":"https://api.github.com/repos/pingcap/tidb/issues/events{/number}","events_url":"https://api.github.com/repos/pingcap/tidb/events","assignees_url":"https://api.github.com/repos/pingcap/tidb/assignees{/user}","branches_url":"https://api.github.com/repos/pingcap/tidb/branches{/branch}","tags_url":"https://api.github.com/repos/pingcap/tidb/tags","blobs_url":"https://api.github.com/repos/pingcap/tidb/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pingcap/tidb/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pingcap/tidb/git/refs{/sha}","trees_url":"https://api.github.com/repos/pingcap/tidb/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pingcap/tidb/statuses/{sha}","languages_url":"https://api.github.com/repos/pingcap/tidb/languages","stargazers_url":"https://api.github.com/repos/pingcap/tidb/stargazers","contributors_url":"https://api.github.com/repos/pingcap/tidb/contributors","subscribers_url":"https://api.github.com/repos/pingcap/tidb/subscribers","subscription_url":"https://api.github.com/repos/pingcap/tidb/subscription","commits_url":"https://api.github.com/repos/pingcap/tidb/commits{/sha}","git_commits_url":"https://api.github.com/repos/pingcap/tidb/git/commits{/sha}","comments_url":"https://api.github.com/repos/pingcap/tidb/comments{/number}","issue_comment_url":"https://api.github.com/repos/pingcap/tidb/issues/comments{/number}","contents_url":"https://api.github.com/repos/pingcap/tidb/contents/{+path}","compare_url":"https://api.github.com/repos/pingcap/tidb/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pingcap/tidb/merges","archive_url":"https://api.github.com/repos/pingcap/tidb/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pingcap/tidb/downloads","issues_url":"https://api.github.com/repos/pingcap/tidb/issues{/number}","pulls_url":"https://api.github.com/repos/pingcap/tidb/pulls{/number}","milestones_url":"https://api.github.com/repos/pingcap/tidb/milestones{/number}","notifications_url":"https://api.github.com/repos/pingcap/tidb/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pingcap/tidb/labels{/name}","releases_url":"https://api.github.com/repos/pingcap/tidb/releases{/id}","deployments_url":"https://api.github.com/repos/pingcap/tidb/deployments","created_at":"2015-09-06T04:01:52Z","updated_at":"2018-05-31T07:21:49Z","pushed_at":"2018-05-31T08:37:14Z","git_url":"git://github.com/pingcap/tidb.git","ssh_url":"git@github.com:pingcap/tidb.git","clone_url":"https://github.com/pingcap/tidb.git","svn_url":"https://github.com/pingcap/tidb","homepage":"https://pingcap.com","size":74136,"stargazers_count":13493,"watchers_count":13493,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1830,"mirror_url":null,"archived":false,"open_issues_count":416,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1830,"open_issues":416,"watchers":13493,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6684"},"html":{"href":"https://github.com/pingcap/tidb/pull/6684"},"issue":{"href":"https://api.github.com/repos/pingcap/tidb/issues/6684"},"comments":{"href":"https://api.github.com/repos/pingcap/tidb/issues/6684/comments"},"review_comments":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6684/comments"},"review_comment":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pingcap/tidb/pulls/6684/commits"},"statuses":{"href":"https://api.github.com/repos/pingcap/tidb/statuses/c9ebd05bcc1409c96d35251f989a026e3efba401"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"tiancaiamao"}}