{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab-android/pulls/comments/241496038","pull_request_review_id":184784029,"id":241496038,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MTQ5NjAzOA==","diff_hunk":"@@ -322,6 +344,25 @@ protected void updateAndInitPreferences() {\n                 getParent(vibrationPref).removePreference(vibrationPref);\n             }\n \n+            if (Build.VERSION.SDK_INT < Build.VERSION_CODES.LOLLIPOP) {\n+                Log.d(TAG, \"Removing alarm clock prefs\");\n+                getPreferenceScreen().removePreference(alarmClockPrefCat);\n+            } else {\n+                updateAlarmClockEnabledPreferenceIcon(alarmClockEnabledPref,\n+                        getPreferenceBool(alarmClockEnabledPref, false));\n+                alarmClockEnabledPref.setOnPreferenceChangeListener((preference, newValue) -> {\n+                    updateAlarmClockEnabledPreferenceIcon(preference, newValue);","path":"mobile/src/main/java/org/openhab/habdroid/ui/PreferencesActivity.java","position":47,"original_position":47,"commit_id":"1cf65be5db806fda2b6b2becfaf45ceaca994465","original_commit_id":"1cf65be5db806fda2b6b2becfaf45ceaca994465","user":{"login":"mueller-ma","id":22525368,"node_id":"MDQ6VXNlcjIyNTI1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/22525368?v=4","gravatar_id":"","url":"https://api.github.com/users/mueller-ma","html_url":"https://github.com/mueller-ma","followers_url":"https://api.github.com/users/mueller-ma/followers","following_url":"https://api.github.com/users/mueller-ma/following{/other_user}","gists_url":"https://api.github.com/users/mueller-ma/gists{/gist_id}","starred_url":"https://api.github.com/users/mueller-ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mueller-ma/subscriptions","organizations_url":"https://api.github.com/users/mueller-ma/orgs","repos_url":"https://api.github.com/users/mueller-ma/repos","events_url":"https://api.github.com/users/mueller-ma/events{/privacy}","received_events_url":"https://api.github.com/users/mueller-ma/received_events","type":"User","site_admin":false},"body":"Will do","created_at":"2018-12-13T17:38:24Z","updated_at":"2018-12-13T17:38:25Z","html_url":"https://github.com/openhab/openhab-android/pull/1137#discussion_r241496038","pull_request_url":"https://api.github.com/repos/openhab/openhab-android/pulls/1137","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/comments/241496038"},"html":{"href":"https://github.com/openhab/openhab-android/pull/1137#discussion_r241496038"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/1137"}},"in_reply_to_id":241295513},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab-android/pulls/1137","id":238175697,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4MTc1Njk3","html_url":"https://github.com/openhab/openhab-android/pull/1137","diff_url":"https://github.com/openhab/openhab-android/pull/1137.diff","patch_url":"https://github.com/openhab/openhab-android/pull/1137.patch","issue_url":"https://api.github.com/repos/openhab/openhab-android/issues/1137","number":1137,"state":"open","locked":false,"title":"Send alarm clock to openHAB","user":{"login":"mueller-ma","id":22525368,"node_id":"MDQ6VXNlcjIyNTI1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/22525368?v=4","gravatar_id":"","url":"https://api.github.com/users/mueller-ma","html_url":"https://github.com/mueller-ma","followers_url":"https://api.github.com/users/mueller-ma/followers","following_url":"https://api.github.com/users/mueller-ma/following{/other_user}","gists_url":"https://api.github.com/users/mueller-ma/gists{/gist_id}","starred_url":"https://api.github.com/users/mueller-ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mueller-ma/subscriptions","organizations_url":"https://api.github.com/users/mueller-ma/orgs","repos_url":"https://api.github.com/users/mueller-ma/repos","events_url":"https://api.github.com/users/mueller-ma/events{/privacy}","received_events_url":"https://api.github.com/users/mueller-ma/received_events","type":"User","site_admin":false},"body":"and also add a framework for adding more background tasks like this in\r\nthe future.\r\n\r\nThanks to @ekahlenberger for this idea.\r\n\r\nSigned-off-by: mueller-ma <mueller-ma@users.noreply.github.com>\r\n\r\nTODO:\r\n\r\n- [ ] Add feature with example to Readme/Docs","created_at":"2018-12-12T20:42:26Z","updated_at":"2018-12-13T17:38:25Z","closed_at":null,"merged_at":null,"merge_commit_sha":"7c526d66c96b6ecf16e69bd90a1ffdb816e89a18","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":91955062,"node_id":"MDU6TGFiZWw5MTk1NTA2Mg==","url":"https://api.github.com/repos/openhab/openhab-android/labels/enhancement","name":"enhancement","color":"84b6eb","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab-android/pulls/1137/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab-android/pulls/1137/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab-android/issues/1137/comments","statuses_url":"https://api.github.com/repos/openhab/openhab-android/statuses/1cf65be5db806fda2b6b2becfaf45ceaca994465","head":{"label":"mueller-ma:alarm-clock","ref":"alarm-clock","sha":"1cf65be5db806fda2b6b2becfaf45ceaca994465","user":{"login":"mueller-ma","id":22525368,"node_id":"MDQ6VXNlcjIyNTI1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/22525368?v=4","gravatar_id":"","url":"https://api.github.com/users/mueller-ma","html_url":"https://github.com/mueller-ma","followers_url":"https://api.github.com/users/mueller-ma/followers","following_url":"https://api.github.com/users/mueller-ma/following{/other_user}","gists_url":"https://api.github.com/users/mueller-ma/gists{/gist_id}","starred_url":"https://api.github.com/users/mueller-ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mueller-ma/subscriptions","organizations_url":"https://api.github.com/users/mueller-ma/orgs","repos_url":"https://api.github.com/users/mueller-ma/repos","events_url":"https://api.github.com/users/mueller-ma/events{/privacy}","received_events_url":"https://api.github.com/users/mueller-ma/received_events","type":"User","site_admin":false},"repo":{"id":86972940,"node_id":"MDEwOlJlcG9zaXRvcnk4Njk3Mjk0MA==","name":"openhab.android","full_name":"mueller-ma/openhab.android","private":false,"owner":{"login":"mueller-ma","id":22525368,"node_id":"MDQ6VXNlcjIyNTI1MzY4","avatar_url":"https://avatars1.githubusercontent.com/u/22525368?v=4","gravatar_id":"","url":"https://api.github.com/users/mueller-ma","html_url":"https://github.com/mueller-ma","followers_url":"https://api.github.com/users/mueller-ma/followers","following_url":"https://api.github.com/users/mueller-ma/following{/other_user}","gists_url":"https://api.github.com/users/mueller-ma/gists{/gist_id}","starred_url":"https://api.github.com/users/mueller-ma/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mueller-ma/subscriptions","organizations_url":"https://api.github.com/users/mueller-ma/orgs","repos_url":"https://api.github.com/users/mueller-ma/repos","events_url":"https://api.github.com/users/mueller-ma/events{/privacy}","received_events_url":"https://api.github.com/users/mueller-ma/received_events","type":"User","site_admin":false},"html_url":"https://github.com/mueller-ma/openhab.android","description":"openHAB Android app","fork":true,"url":"https://api.github.com/repos/mueller-ma/openhab.android","forks_url":"https://api.github.com/repos/mueller-ma/openhab.android/forks","keys_url":"https://api.github.com/repos/mueller-ma/openhab.android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mueller-ma/openhab.android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mueller-ma/openhab.android/teams","hooks_url":"https://api.github.com/repos/mueller-ma/openhab.android/hooks","issue_events_url":"https://api.github.com/repos/mueller-ma/openhab.android/issues/events{/number}","events_url":"https://api.github.com/repos/mueller-ma/openhab.android/events","assignees_url":"https://api.github.com/repos/mueller-ma/openhab.android/assignees{/user}","branches_url":"https://api.github.com/repos/mueller-ma/openhab.android/branches{/branch}","tags_url":"https://api.github.com/repos/mueller-ma/openhab.android/tags","blobs_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mueller-ma/openhab.android/statuses/{sha}","languages_url":"https://api.github.com/repos/mueller-ma/openhab.android/languages","stargazers_url":"https://api.github.com/repos/mueller-ma/openhab.android/stargazers","contributors_url":"https://api.github.com/repos/mueller-ma/openhab.android/contributors","subscribers_url":"https://api.github.com/repos/mueller-ma/openhab.android/subscribers","subscription_url":"https://api.github.com/repos/mueller-ma/openhab.android/subscription","commits_url":"https://api.github.com/repos/mueller-ma/openhab.android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mueller-ma/openhab.android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mueller-ma/openhab.android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mueller-ma/openhab.android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mueller-ma/openhab.android/contents/{+path}","compare_url":"https://api.github.com/repos/mueller-ma/openhab.android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mueller-ma/openhab.android/merges","archive_url":"https://api.github.com/repos/mueller-ma/openhab.android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mueller-ma/openhab.android/downloads","issues_url":"https://api.github.com/repos/mueller-ma/openhab.android/issues{/number}","pulls_url":"https://api.github.com/repos/mueller-ma/openhab.android/pulls{/number}","milestones_url":"https://api.github.com/repos/mueller-ma/openhab.android/milestones{/number}","notifications_url":"https://api.github.com/repos/mueller-ma/openhab.android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mueller-ma/openhab.android/labels{/name}","releases_url":"https://api.github.com/repos/mueller-ma/openhab.android/releases{/id}","deployments_url":"https://api.github.com/repos/mueller-ma/openhab.android/deployments","created_at":"2017-04-02T08:23:49Z","updated_at":"2017-09-30T23:51:32Z","pushed_at":"2018-12-13T17:31:04Z","git_url":"git://github.com/mueller-ma/openhab.android.git","ssh_url":"git@github.com:mueller-ma/openhab.android.git","clone_url":"https://github.com/mueller-ma/openhab.android.git","svn_url":"https://github.com/mueller-ma/openhab.android","homepage":null,"size":27188,"stargazers_count":1,"watchers_count":1,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":1,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"0a0dd0ffd4ea0b8d241cea80eed6b84f3dcc2fdd","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":18703240,"node_id":"MDEwOlJlcG9zaXRvcnkxODcwMzI0MA==","name":"openhab-android","full_name":"openhab/openhab-android","private":false,"owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openhab/openhab-android","description":"openHAB client for Android","fork":false,"url":"https://api.github.com/repos/openhab/openhab-android","forks_url":"https://api.github.com/repos/openhab/openhab-android/forks","keys_url":"https://api.github.com/repos/openhab/openhab-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab-android/teams","hooks_url":"https://api.github.com/repos/openhab/openhab-android/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab-android/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab-android/events","assignees_url":"https://api.github.com/repos/openhab/openhab-android/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab-android/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab-android/tags","blobs_url":"https://api.github.com/repos/openhab/openhab-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab-android/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab-android/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab-android/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab-android/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab-android/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab-android/subscription","commits_url":"https://api.github.com/repos/openhab/openhab-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab-android/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab-android/merges","archive_url":"https://api.github.com/repos/openhab/openhab-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab-android/downloads","issues_url":"https://api.github.com/repos/openhab/openhab-android/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab-android/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab-android/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab-android/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab-android/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab-android/deployments","created_at":"2014-04-12T12:09:03Z","updated_at":"2018-12-13T17:31:05Z","pushed_at":"2018-12-13T17:31:55Z","git_url":"git://github.com/openhab/openhab-android.git","ssh_url":"git@github.com:openhab/openhab-android.git","clone_url":"https://github.com/openhab/openhab-android.git","svn_url":"https://github.com/openhab/openhab-android","homepage":"https://play.google.com/store/apps/details?id=org.openhab.habdroid","size":26849,"stargazers_count":261,"watchers_count":261,"language":"Java","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":216,"mirror_url":null,"archived":false,"open_issues_count":116,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":216,"open_issues":116,"watchers":261,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/1137"},"html":{"href":"https://github.com/openhab/openhab-android/pull/1137"},"issue":{"href":"https://api.github.com/repos/openhab/openhab-android/issues/1137"},"comments":{"href":"https://api.github.com/repos/openhab/openhab-android/issues/1137/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/1137/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab-android/pulls/1137/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab-android/statuses/1cf65be5db806fda2b6b2becfaf45ceaca994465"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"mueller-ma"}}