{"action":"created","comment":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/209897471","pull_request_review_id":145997306,"id":209897471,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwOTg5NzQ3MQ==","diff_hunk":"@@ -35,6 +35,12 @@ public class WalletSyncManager : IWalletSyncManager, IDisposable\n         /// <summary>Queue which contains blocks that should be processed by <see cref=\"WalletManager\"/>.</summary>\n         private readonly AsyncQueue<Block> blocksQueue;\n \n+        /// <summary>Limit blocksQueue size.</summary>\n+        private const int MaxQueueSize = 1000;","path":"src/Stratis.Bitcoin.Features.Wallet/WalletSyncManager.cs","position":null,"original_position":5,"commit_id":"da5c2291474e78577721087693bdcea1347caa64","original_commit_id":"da5c2291474e78577721087693bdcea1347caa64","user":{"login":"Aprogiena","id":30052221,"node_id":"MDQ6VXNlcjMwMDUyMjIx","avatar_url":"https://avatars0.githubusercontent.com/u/30052221?v=4","gravatar_id":"","url":"https://api.github.com/users/Aprogiena","html_url":"https://github.com/Aprogiena","followers_url":"https://api.github.com/users/Aprogiena/followers","following_url":"https://api.github.com/users/Aprogiena/following{/other_user}","gists_url":"https://api.github.com/users/Aprogiena/gists{/gist_id}","starred_url":"https://api.github.com/users/Aprogiena/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Aprogiena/subscriptions","organizations_url":"https://api.github.com/users/Aprogiena/orgs","repos_url":"https://api.github.com/users/Aprogiena/repos","events_url":"https://api.github.com/users/Aprogiena/events{/privacy}","received_events_url":"https://api.github.com/users/Aprogiena/received_events","type":"User","site_admin":false},"body":"This is too much, this should be on the order of 100 or 200","created_at":"2018-08-14T10:07:37Z","updated_at":"2018-08-14T10:07:37Z","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1890#discussion_r209897471","pull_request_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1890","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments/209897471"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1890#discussion_r209897471"},"pull_request":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1890"}}},"pull_request":{"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1890","id":207308274,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzA4Mjc0","html_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1890","diff_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1890.diff","patch_url":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1890.patch","issue_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1890","number":1890,"state":"open","locked":false,"title":"WalletSyncManager speedup with AsyncQueue<Block>","user":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"body":"Related to #1103.\r\n\r\nThis PR implements `AsyncQueue<Block>` and calls back to process a `Block`, in `OnProcessBlockAsync()`.\r\n\r\nThe aim of this change is to allow Consensus to advance, rather then wait for `WalletSyncManager` to process blocks - point 1 in #1103.\r\n\r\nUnit tests passing:\r\n\r\n![image](https://user-images.githubusercontent.com/16000683/43900378-95045680-9bdc-11e8-9270-3de1b639db8e.png)\r\n\r\nTest evidence : \r\n\r\n![image](https://user-images.githubusercontent.com/16000683/43902094-16632590-9be1-11e8-93a4-4df9ee1861da.png)\r\n\r\nConsensus is advancing, when a wallet that is processing a huge amount of transactions - at this wallet address [TNkjjYwkkeX9sfssCP5Qq4ta67d3meKS2k](https://chainz.cryptoid.info/strat-test/address.dws?TNkjjYwkkeX9sfssCP5Qq4ta67d3meKS2k.htm).","created_at":"2018-08-09T13:01:20Z","updated_at":"2018-08-14T10:07:37Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f00c8be4a3d50678f0d27feae969a0ad3a4b8998","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":926800905,"node_id":"MDU6TGFiZWw5MjY4MDA5MDU=","url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels/pr-review-medium","name":"pr-review-medium","color":"295182","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1890/commits","review_comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1890/comments","review_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1890/comments","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/da5c2291474e78577721087693bdcea1347caa64","head":{"label":"ferdeen:1103_wallet_sync_manager_speedup_AsyncQueue_Block","ref":"1103_wallet_sync_manager_speedup_AsyncQueue_Block","sha":"da5c2291474e78577721087693bdcea1347caa64","user":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"repo":{"id":123270487,"node_id":"MDEwOlJlcG9zaXRvcnkxMjMyNzA0ODc=","name":"StratisBitcoinFullNode","full_name":"ferdeen/StratisBitcoinFullNode","owner":{"login":"ferdeen","id":16000683,"node_id":"MDQ6VXNlcjE2MDAwNjgz","avatar_url":"https://avatars3.githubusercontent.com/u/16000683?v=4","gravatar_id":"","url":"https://api.github.com/users/ferdeen","html_url":"https://github.com/ferdeen","followers_url":"https://api.github.com/users/ferdeen/followers","following_url":"https://api.github.com/users/ferdeen/following{/other_user}","gists_url":"https://api.github.com/users/ferdeen/gists{/gist_id}","starred_url":"https://api.github.com/users/ferdeen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ferdeen/subscriptions","organizations_url":"https://api.github.com/users/ferdeen/orgs","repos_url":"https://api.github.com/users/ferdeen/repos","events_url":"https://api.github.com/users/ferdeen/events{/privacy}","received_events_url":"https://api.github.com/users/ferdeen/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/ferdeen/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":true,"url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/ferdeen/StratisBitcoinFullNode/deployments","created_at":"2018-02-28T10:40:08Z","updated_at":"2018-08-13T10:56:51Z","pushed_at":"2018-08-14T09:40:48Z","git_url":"git://github.com/ferdeen/StratisBitcoinFullNode.git","ssh_url":"git@github.com:ferdeen/StratisBitcoinFullNode.git","clone_url":"https://github.com/ferdeen/StratisBitcoinFullNode.git","svn_url":"https://github.com/ferdeen/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":31441,"stargazers_count":1,"watchers_count":1,"language":"C#","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"stratisproject:master","ref":"master","sha":"ebbd13296a66030b664f931ee50dad81037101fb","user":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"repo":{"id":67271290,"node_id":"MDEwOlJlcG9zaXRvcnk2NzI3MTI5MA==","name":"StratisBitcoinFullNode","full_name":"stratisproject/StratisBitcoinFullNode","owner":{"login":"stratisproject","id":15229748,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1MjI5NzQ4","avatar_url":"https://avatars0.githubusercontent.com/u/15229748?v=4","gravatar_id":"","url":"https://api.github.com/users/stratisproject","html_url":"https://github.com/stratisproject","followers_url":"https://api.github.com/users/stratisproject/followers","following_url":"https://api.github.com/users/stratisproject/following{/other_user}","gists_url":"https://api.github.com/users/stratisproject/gists{/gist_id}","starred_url":"https://api.github.com/users/stratisproject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stratisproject/subscriptions","organizations_url":"https://api.github.com/users/stratisproject/orgs","repos_url":"https://api.github.com/users/stratisproject/repos","events_url":"https://api.github.com/users/stratisproject/events{/privacy}","received_events_url":"https://api.github.com/users/stratisproject/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/stratisproject/StratisBitcoinFullNode","description":"Bitcoin full node in C#","fork":false,"url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode","forks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/forks","keys_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/keys{/key_id}","collaborators_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/teams","hooks_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/hooks","issue_events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/events{/number}","events_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/events","assignees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/assignees{/user}","branches_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/branches{/branch}","tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/tags","blobs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/refs{/sha}","trees_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/trees{/sha}","statuses_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/{sha}","languages_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/languages","stargazers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/stargazers","contributors_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contributors","subscribers_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscribers","subscription_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/subscription","commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/commits{/sha}","git_commits_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/git/commits{/sha}","comments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/comments{/number}","issue_comment_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/comments{/number}","contents_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/contents/{+path}","compare_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/compare/{base}...{head}","merges_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/merges","archive_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/downloads","issues_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues{/number}","pulls_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls{/number}","milestones_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/milestones{/number}","notifications_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/labels{/name}","releases_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/releases{/id}","deployments_url":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/deployments","created_at":"2016-09-03T04:32:51Z","updated_at":"2018-08-13T17:21:26Z","pushed_at":"2018-08-14T09:40:49Z","git_url":"git://github.com/stratisproject/StratisBitcoinFullNode.git","ssh_url":"git@github.com:stratisproject/StratisBitcoinFullNode.git","clone_url":"https://github.com/stratisproject/StratisBitcoinFullNode.git","svn_url":"https://github.com/stratisproject/StratisBitcoinFullNode","homepage":"https://stratisplatform.com","size":32553,"stargazers_count":531,"watchers_count":531,"language":"C#","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":243,"mirror_url":null,"archived":false,"open_issues_count":156,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":243,"open_issues":156,"watchers":531,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1890"},"html":{"href":"https://github.com/stratisproject/StratisBitcoinFullNode/pull/1890"},"issue":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1890"},"comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/issues/1890/comments"},"review_comments":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1890/comments"},"review_comment":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/pulls/1890/commits"},"statuses":{"href":"https://api.github.com/repos/stratisproject/StratisBitcoinFullNode/statuses/da5c2291474e78577721087693bdcea1347caa64"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Aprogiena"}}