{"action":"closed","number":278,"pull_request":{"url":"https://api.github.com/repos/SUSE/rmt/pulls/278","id":234356692,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM0MzU2Njky","html_url":"https://github.com/SUSE/rmt/pull/278","diff_url":"https://github.com/SUSE/rmt/pull/278.diff","patch_url":"https://github.com/SUSE/rmt/pull/278.patch","issue_url":"https://api.github.com/repos/SUSE/rmt/issues/278","number":278,"state":"closed","locked":false,"title":"Fix products wrongly showing as enabled for mirroring","user":{"login":"simson-suse","id":36953810,"node_id":"MDQ6VXNlcjM2OTUzODEw","avatar_url":"https://avatars3.githubusercontent.com/u/36953810?v=4","gravatar_id":"","url":"https://api.github.com/users/simson-suse","html_url":"https://github.com/simson-suse","followers_url":"https://api.github.com/users/simson-suse/followers","following_url":"https://api.github.com/users/simson-suse/following{/other_user}","gists_url":"https://api.github.com/users/simson-suse/gists{/gist_id}","starred_url":"https://api.github.com/users/simson-suse/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simson-suse/subscriptions","organizations_url":"https://api.github.com/users/simson-suse/orgs","repos_url":"https://api.github.com/users/simson-suse/repos","events_url":"https://api.github.com/users/simson-suse/events{/privacy}","received_events_url":"https://api.github.com/users/simson-suse/received_events","type":"User","site_admin":false},"body":"See Bugzilla bug #1102193 for reference.\r\n\r\nTo avoid confusion: When a repository is enabled or not, we talk about\r\nzypper (RPM) repositories, which ship with a default, either `enabled`\r\nor `disabled`. As an example, typically \"debug symbols\" are `disabled`\r\nby default.\r\n\r\nBefore, if there were no `enabled` repositories for a product (which\r\nhappens for very old products), `mirror?` would return true even though\r\nthere was nothing mirrored. This kinda made sense since we accept a\r\n__product__ as `enabled` when all the __repos__ that are `enabled` by\r\ndefault are \"enabled for mirroring\", because that's usually everything\r\none needs (by definition, since they other repos on the clients are\r\n`disabled` by default anyway).\r\n\r\nNow it will first check if there are repositories that are `enabled` by\r\ndefault. And if that is true, it then checks if these are all \"enabled\r\nfor mirroring\". If there are no repositories that are `enabled` by\r\ndefault, it will check if there are repositories that are `disabled` by\r\ndefault, and consider the product `enabled` if all those repositories\r\nare \"enabled for mirroring\". If there are no repositories at all, it\r\nwill just return `false`, since a product without repositories is not\r\nunderstood by RMT anyway.","created_at":"2018-11-28T17:08:43Z","updated_at":"2019-01-03T14:46:12Z","closed_at":"2019-01-03T14:46:12Z","merged_at":"2019-01-03T14:46:12Z","merge_commit_sha":"78d40f679457af61a033a2051b6112acee3fae90","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SUSE/rmt/pulls/278/commits","review_comments_url":"https://api.github.com/repos/SUSE/rmt/pulls/278/comments","review_comment_url":"https://api.github.com/repos/SUSE/rmt/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SUSE/rmt/issues/278/comments","statuses_url":"https://api.github.com/repos/SUSE/rmt/statuses/19895a3929e7f9a22e1bb2aaa5bacf8691be54c7","head":{"label":"SUSE:fix-products-wrongly-showing-as-enabled-for-mirroring","ref":"fix-products-wrongly-showing-as-enabled-for-mirroring","sha":"19895a3929e7f9a22e1bb2aaa5bacf8691be54c7","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":96195015,"node_id":"MDEwOlJlcG9zaXRvcnk5NjE5NTAxNQ==","name":"rmt","full_name":"SUSE/rmt","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/rmt","description":"RPM repository mirroring tool and registration proxy for SUSE Customer Center.","fork":false,"url":"https://api.github.com/repos/SUSE/rmt","forks_url":"https://api.github.com/repos/SUSE/rmt/forks","keys_url":"https://api.github.com/repos/SUSE/rmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/rmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/rmt/teams","hooks_url":"https://api.github.com/repos/SUSE/rmt/hooks","issue_events_url":"https://api.github.com/repos/SUSE/rmt/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/rmt/events","assignees_url":"https://api.github.com/repos/SUSE/rmt/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/rmt/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/rmt/tags","blobs_url":"https://api.github.com/repos/SUSE/rmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/rmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/rmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/rmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/rmt/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/rmt/languages","stargazers_url":"https://api.github.com/repos/SUSE/rmt/stargazers","contributors_url":"https://api.github.com/repos/SUSE/rmt/contributors","subscribers_url":"https://api.github.com/repos/SUSE/rmt/subscribers","subscription_url":"https://api.github.com/repos/SUSE/rmt/subscription","commits_url":"https://api.github.com/repos/SUSE/rmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/rmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/rmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/rmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/rmt/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/rmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/rmt/merges","archive_url":"https://api.github.com/repos/SUSE/rmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/rmt/downloads","issues_url":"https://api.github.com/repos/SUSE/rmt/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/rmt/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/rmt/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/rmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/rmt/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/rmt/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/rmt/deployments","created_at":"2017-07-04T08:33:17Z","updated_at":"2019-01-03T13:45:35Z","pushed_at":"2019-01-03T14:46:12Z","git_url":"git://github.com/SUSE/rmt.git","ssh_url":"git@github.com:SUSE/rmt.git","clone_url":"https://github.com/SUSE/rmt.git","svn_url":"https://github.com/SUSE/rmt","homepage":"","size":1715,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":18,"watchers":21,"default_branch":"master"}},"base":{"label":"SUSE:master","ref":"master","sha":"6e954653cea3ddddb106aeddd106e2f31bbf7b92","user":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"repo":{"id":96195015,"node_id":"MDEwOlJlcG9zaXRvcnk5NjE5NTAxNQ==","name":"rmt","full_name":"SUSE/rmt","private":false,"owner":{"login":"SUSE","id":1067733,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwNjc3MzM=","avatar_url":"https://avatars0.githubusercontent.com/u/1067733?v=4","gravatar_id":"","url":"https://api.github.com/users/SUSE","html_url":"https://github.com/SUSE","followers_url":"https://api.github.com/users/SUSE/followers","following_url":"https://api.github.com/users/SUSE/following{/other_user}","gists_url":"https://api.github.com/users/SUSE/gists{/gist_id}","starred_url":"https://api.github.com/users/SUSE/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SUSE/subscriptions","organizations_url":"https://api.github.com/users/SUSE/orgs","repos_url":"https://api.github.com/users/SUSE/repos","events_url":"https://api.github.com/users/SUSE/events{/privacy}","received_events_url":"https://api.github.com/users/SUSE/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SUSE/rmt","description":"RPM repository mirroring tool and registration proxy for SUSE Customer Center.","fork":false,"url":"https://api.github.com/repos/SUSE/rmt","forks_url":"https://api.github.com/repos/SUSE/rmt/forks","keys_url":"https://api.github.com/repos/SUSE/rmt/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SUSE/rmt/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SUSE/rmt/teams","hooks_url":"https://api.github.com/repos/SUSE/rmt/hooks","issue_events_url":"https://api.github.com/repos/SUSE/rmt/issues/events{/number}","events_url":"https://api.github.com/repos/SUSE/rmt/events","assignees_url":"https://api.github.com/repos/SUSE/rmt/assignees{/user}","branches_url":"https://api.github.com/repos/SUSE/rmt/branches{/branch}","tags_url":"https://api.github.com/repos/SUSE/rmt/tags","blobs_url":"https://api.github.com/repos/SUSE/rmt/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SUSE/rmt/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SUSE/rmt/git/refs{/sha}","trees_url":"https://api.github.com/repos/SUSE/rmt/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SUSE/rmt/statuses/{sha}","languages_url":"https://api.github.com/repos/SUSE/rmt/languages","stargazers_url":"https://api.github.com/repos/SUSE/rmt/stargazers","contributors_url":"https://api.github.com/repos/SUSE/rmt/contributors","subscribers_url":"https://api.github.com/repos/SUSE/rmt/subscribers","subscription_url":"https://api.github.com/repos/SUSE/rmt/subscription","commits_url":"https://api.github.com/repos/SUSE/rmt/commits{/sha}","git_commits_url":"https://api.github.com/repos/SUSE/rmt/git/commits{/sha}","comments_url":"https://api.github.com/repos/SUSE/rmt/comments{/number}","issue_comment_url":"https://api.github.com/repos/SUSE/rmt/issues/comments{/number}","contents_url":"https://api.github.com/repos/SUSE/rmt/contents/{+path}","compare_url":"https://api.github.com/repos/SUSE/rmt/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SUSE/rmt/merges","archive_url":"https://api.github.com/repos/SUSE/rmt/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SUSE/rmt/downloads","issues_url":"https://api.github.com/repos/SUSE/rmt/issues{/number}","pulls_url":"https://api.github.com/repos/SUSE/rmt/pulls{/number}","milestones_url":"https://api.github.com/repos/SUSE/rmt/milestones{/number}","notifications_url":"https://api.github.com/repos/SUSE/rmt/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SUSE/rmt/labels{/name}","releases_url":"https://api.github.com/repos/SUSE/rmt/releases{/id}","deployments_url":"https://api.github.com/repos/SUSE/rmt/deployments","created_at":"2017-07-04T08:33:17Z","updated_at":"2019-01-03T13:45:35Z","pushed_at":"2019-01-03T14:46:12Z","git_url":"git://github.com/SUSE/rmt.git","ssh_url":"git@github.com:SUSE/rmt.git","clone_url":"https://github.com/SUSE/rmt.git","svn_url":"https://github.com/SUSE/rmt","homepage":"","size":1715,"stargazers_count":21,"watchers_count":21,"language":"Ruby","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":18,"license":{"key":"other","name":"Other","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":7,"open_issues":18,"watchers":21,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SUSE/rmt/pulls/278"},"html":{"href":"https://github.com/SUSE/rmt/pull/278"},"issue":{"href":"https://api.github.com/repos/SUSE/rmt/issues/278"},"comments":{"href":"https://api.github.com/repos/SUSE/rmt/issues/278/comments"},"review_comments":{"href":"https://api.github.com/repos/SUSE/rmt/pulls/278/comments"},"review_comment":{"href":"https://api.github.com/repos/SUSE/rmt/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SUSE/rmt/pulls/278/commits"},"statuses":{"href":"https://api.github.com/repos/SUSE/rmt/statuses/19895a3929e7f9a22e1bb2aaa5bacf8691be54c7"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tmuntaner","id":318856,"node_id":"MDQ6VXNlcjMxODg1Ng==","avatar_url":"https://avatars2.githubusercontent.com/u/318856?v=4","gravatar_id":"","url":"https://api.github.com/users/tmuntaner","html_url":"https://github.com/tmuntaner","followers_url":"https://api.github.com/users/tmuntaner/followers","following_url":"https://api.github.com/users/tmuntaner/following{/other_user}","gists_url":"https://api.github.com/users/tmuntaner/gists{/gist_id}","starred_url":"https://api.github.com/users/tmuntaner/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tmuntaner/subscriptions","organizations_url":"https://api.github.com/users/tmuntaner/orgs","repos_url":"https://api.github.com/users/tmuntaner/repos","events_url":"https://api.github.com/users/tmuntaner/events{/privacy}","received_events_url":"https://api.github.com/users/tmuntaner/received_events","type":"User","site_admin":false},"comments":1,"review_comments":2,"maintainer_can_modify":false,"commits":2,"additions":72,"deletions":3,"changed_files":5}}
{"actor":{"display_login":"tmuntaner"}}