{"action":"created","comment":{"url":"https://api.github.com/repos/elastic/kibana/pulls/comments/190984169","pull_request_review_id":123482450,"id":190984169,"diff_hunk":"@@ -23,11 +23,20 @@ export class ExplainCollectionEnabled extends React.Component {\n   constructor(props) {\n     super(props);\n     this.handleClick = this.handleClick.bind(this);\n+\n+    this.state = {\n+      waitedTooLong: false\n+    };\n   }\n \n   handleClick() {\n     const { enabler } = this.props;\n     enabler.enableCollectionEnabled();\n+\n+    // wait 19 seconds, show link to reload\n+    setTimeout(() => {\n+      this.setState({ waitedTooLong: true });","path":"x-pack/plugins/monitoring/public/components/no_data/explanations/collection_enabled/collection_enabled.js","position":16,"original_position":16,"commit_id":"89c8be55ac5d68b548dbbcab17ad941ccf5a7455","original_commit_id":"89c8be55ac5d68b548dbbcab17ad941ccf5a7455","user":{"login":"pickypg","id":1501235,"avatar_url":"https://avatars2.githubusercontent.com/u/1501235?v=4","gravatar_id":"","url":"https://api.github.com/users/pickypg","html_url":"https://github.com/pickypg","followers_url":"https://api.github.com/users/pickypg/followers","following_url":"https://api.github.com/users/pickypg/following{/other_user}","gists_url":"https://api.github.com/users/pickypg/gists{/gist_id}","starred_url":"https://api.github.com/users/pickypg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pickypg/subscriptions","organizations_url":"https://api.github.com/users/pickypg/orgs","repos_url":"https://api.github.com/users/pickypg/repos","events_url":"https://api.github.com/users/pickypg/events{/privacy}","received_events_url":"https://api.github.com/users/pickypg/received_events","type":"User","site_admin":false},"body":"What happens relative to this timeout triggering if the page has navigated away automatically? Does this timer get thrown away or does it still live on with a dead reference?","created_at":"2018-05-25T19:02:49Z","updated_at":"2018-05-25T19:03:46Z","html_url":"https://github.com/elastic/kibana/pull/19451#discussion_r190984169","pull_request_url":"https://api.github.com/repos/elastic/kibana/pulls/19451","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments/190984169"},"html":{"href":"https://github.com/elastic/kibana/pull/19451#discussion_r190984169"},"pull_request":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19451"}}},"pull_request":{"url":"https://api.github.com/repos/elastic/kibana/pulls/19451","id":190654270,"html_url":"https://github.com/elastic/kibana/pull/19451","diff_url":"https://github.com/elastic/kibana/pull/19451.diff","patch_url":"https://github.com/elastic/kibana/pull/19451.patch","issue_url":"https://api.github.com/repos/elastic/kibana/issues/19451","number":19451,"state":"open","locked":false,"title":"[Monitoring] Improve User Experience of Enabling Monitoring Collection","user":{"login":"tsullivan","id":908371,"avatar_url":"https://avatars1.githubusercontent.com/u/908371?v=4","gravatar_id":"","url":"https://api.github.com/users/tsullivan","html_url":"https://github.com/tsullivan","followers_url":"https://api.github.com/users/tsullivan/followers","following_url":"https://api.github.com/users/tsullivan/following{/other_user}","gists_url":"https://api.github.com/users/tsullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsullivan/subscriptions","organizations_url":"https://api.github.com/users/tsullivan/orgs","repos_url":"https://api.github.com/users/tsullivan/repos","events_url":"https://api.github.com/users/tsullivan/events{/privacy}","received_events_url":"https://api.github.com/users/tsullivan/received_events","type":"User","site_admin":false},"body":"I had a negative experience when upgrading from 6.2.4 to 6.3.0 and going through enabling Monitoring Collection. The issue was that I already had some monitoring data from the older stack version, and I didn't get to the \"No Data Found\" page by default. When I eventually got there, it was because I 404'd trying to look at data at an absolute time range.\r\n\r\nThis is a small PR to improve the experience of enabling monitoring collection when the page is set to an absolute time range. The `timefilter` object isn't in scope for this view, so it would be a larger effort to try to programmatically set the timefilter options.\r\n\r\nRelease note: Improve the experience of enabling monitoring collection when the page is set to an absolute time range.\r\n\r\nVideo: https://drive.google.com/file/d/1aZ5q82UkK3MP7BgEhfjaHXDeStm1yona/view?usp=sharing\r\n\r\ncc @ycombinator @justinkambic ","created_at":"2018-05-25T17:43:51Z","updated_at":"2018-05-25T19:03:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71de969dc107d86bb26b60189c4c1ba365dfa8bb","assignee":null,"assignees":[],"requested_reviewers":[{"login":"gchaps","id":33642766,"avatar_url":"https://avatars0.githubusercontent.com/u/33642766?v=4","gravatar_id":"","url":"https://api.github.com/users/gchaps","html_url":"https://github.com/gchaps","followers_url":"https://api.github.com/users/gchaps/followers","following_url":"https://api.github.com/users/gchaps/following{/other_user}","gists_url":"https://api.github.com/users/gchaps/gists{/gist_id}","starred_url":"https://api.github.com/users/gchaps/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchaps/subscriptions","organizations_url":"https://api.github.com/users/gchaps/orgs","repos_url":"https://api.github.com/users/gchaps/repos","events_url":"https://api.github.com/users/gchaps/events{/privacy}","received_events_url":"https://api.github.com/users/gchaps/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":912940115,"url":"https://api.github.com/repos/elastic/kibana/labels/:Monitoring","name":":Monitoring","color":"fef2c0","default":false},{"id":26198236,"url":"https://api.github.com/repos/elastic/kibana/labels/release_note:enhancement","name":"release_note:enhancement","color":"4a4ea8","default":false},{"id":135307740,"url":"https://api.github.com/repos/elastic/kibana/labels/review","name":"review","color":"0052cc","default":false},{"id":934760184,"url":"https://api.github.com/repos/elastic/kibana/labels/v6.3.1","name":"v6.3.1","color":"ffffff","default":false},{"id":883958396,"url":"https://api.github.com/repos/elastic/kibana/labels/v6.4.0","name":"v6.4.0","color":"ffffff","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/elastic/kibana/pulls/19451/commits","review_comments_url":"https://api.github.com/repos/elastic/kibana/pulls/19451/comments","review_comment_url":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}","comments_url":"https://api.github.com/repos/elastic/kibana/issues/19451/comments","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/89c8be55ac5d68b548dbbcab17ad941ccf5a7455","head":{"label":"tsullivan:monitoring/success-enabling-monitoring-text-improvmnt","ref":"monitoring/success-enabling-monitoring-text-improvmnt","sha":"89c8be55ac5d68b548dbbcab17ad941ccf5a7455","user":{"login":"tsullivan","id":908371,"avatar_url":"https://avatars1.githubusercontent.com/u/908371?v=4","gravatar_id":"","url":"https://api.github.com/users/tsullivan","html_url":"https://github.com/tsullivan","followers_url":"https://api.github.com/users/tsullivan/followers","following_url":"https://api.github.com/users/tsullivan/following{/other_user}","gists_url":"https://api.github.com/users/tsullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsullivan/subscriptions","organizations_url":"https://api.github.com/users/tsullivan/orgs","repos_url":"https://api.github.com/users/tsullivan/repos","events_url":"https://api.github.com/users/tsullivan/events{/privacy}","received_events_url":"https://api.github.com/users/tsullivan/received_events","type":"User","site_admin":false},"repo":{"id":42211003,"name":"kibana","full_name":"tsullivan/kibana","owner":{"login":"tsullivan","id":908371,"avatar_url":"https://avatars1.githubusercontent.com/u/908371?v=4","gravatar_id":"","url":"https://api.github.com/users/tsullivan","html_url":"https://github.com/tsullivan","followers_url":"https://api.github.com/users/tsullivan/followers","following_url":"https://api.github.com/users/tsullivan/following{/other_user}","gists_url":"https://api.github.com/users/tsullivan/gists{/gist_id}","starred_url":"https://api.github.com/users/tsullivan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tsullivan/subscriptions","organizations_url":"https://api.github.com/users/tsullivan/orgs","repos_url":"https://api.github.com/users/tsullivan/repos","events_url":"https://api.github.com/users/tsullivan/events{/privacy}","received_events_url":"https://api.github.com/users/tsullivan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/tsullivan/kibana","description":"Kibana","fork":true,"url":"https://api.github.com/repos/tsullivan/kibana","forks_url":"https://api.github.com/repos/tsullivan/kibana/forks","keys_url":"https://api.github.com/repos/tsullivan/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tsullivan/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tsullivan/kibana/teams","hooks_url":"https://api.github.com/repos/tsullivan/kibana/hooks","issue_events_url":"https://api.github.com/repos/tsullivan/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/tsullivan/kibana/events","assignees_url":"https://api.github.com/repos/tsullivan/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/tsullivan/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/tsullivan/kibana/tags","blobs_url":"https://api.github.com/repos/tsullivan/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tsullivan/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tsullivan/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/tsullivan/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tsullivan/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/tsullivan/kibana/languages","stargazers_url":"https://api.github.com/repos/tsullivan/kibana/stargazers","contributors_url":"https://api.github.com/repos/tsullivan/kibana/contributors","subscribers_url":"https://api.github.com/repos/tsullivan/kibana/subscribers","subscription_url":"https://api.github.com/repos/tsullivan/kibana/subscription","commits_url":"https://api.github.com/repos/tsullivan/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/tsullivan/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/tsullivan/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/tsullivan/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/tsullivan/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/tsullivan/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tsullivan/kibana/merges","archive_url":"https://api.github.com/repos/tsullivan/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tsullivan/kibana/downloads","issues_url":"https://api.github.com/repos/tsullivan/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/tsullivan/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/tsullivan/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/tsullivan/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tsullivan/kibana/labels{/name}","releases_url":"https://api.github.com/repos/tsullivan/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/tsullivan/kibana/deployments","created_at":"2015-09-09T23:53:33Z","updated_at":"2018-05-25T01:07:36Z","pushed_at":"2018-05-25T17:49:18Z","git_url":"git://github.com/tsullivan/kibana.git","ssh_url":"git@github.com:tsullivan/kibana.git","clone_url":"https://github.com/tsullivan/kibana.git","svn_url":"https://github.com/tsullivan/kibana","homepage":"https://www.elastic.co/products/kibana","size":401137,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"elastic:master","ref":"master","sha":"194aba149fc0bb140496435dbd82161e2d6bc278","user":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"repo":{"id":7833168,"name":"kibana","full_name":"elastic/kibana","owner":{"login":"elastic","id":6764390,"avatar_url":"https://avatars0.githubusercontent.com/u/6764390?v=4","gravatar_id":"","url":"https://api.github.com/users/elastic","html_url":"https://github.com/elastic","followers_url":"https://api.github.com/users/elastic/followers","following_url":"https://api.github.com/users/elastic/following{/other_user}","gists_url":"https://api.github.com/users/elastic/gists{/gist_id}","starred_url":"https://api.github.com/users/elastic/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/elastic/subscriptions","organizations_url":"https://api.github.com/users/elastic/orgs","repos_url":"https://api.github.com/users/elastic/repos","events_url":"https://api.github.com/users/elastic/events{/privacy}","received_events_url":"https://api.github.com/users/elastic/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/elastic/kibana","description":":bar_chart: Kibana analytics and search dashboard for Elasticsearch","fork":false,"url":"https://api.github.com/repos/elastic/kibana","forks_url":"https://api.github.com/repos/elastic/kibana/forks","keys_url":"https://api.github.com/repos/elastic/kibana/keys{/key_id}","collaborators_url":"https://api.github.com/repos/elastic/kibana/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/elastic/kibana/teams","hooks_url":"https://api.github.com/repos/elastic/kibana/hooks","issue_events_url":"https://api.github.com/repos/elastic/kibana/issues/events{/number}","events_url":"https://api.github.com/repos/elastic/kibana/events","assignees_url":"https://api.github.com/repos/elastic/kibana/assignees{/user}","branches_url":"https://api.github.com/repos/elastic/kibana/branches{/branch}","tags_url":"https://api.github.com/repos/elastic/kibana/tags","blobs_url":"https://api.github.com/repos/elastic/kibana/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/elastic/kibana/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/elastic/kibana/git/refs{/sha}","trees_url":"https://api.github.com/repos/elastic/kibana/git/trees{/sha}","statuses_url":"https://api.github.com/repos/elastic/kibana/statuses/{sha}","languages_url":"https://api.github.com/repos/elastic/kibana/languages","stargazers_url":"https://api.github.com/repos/elastic/kibana/stargazers","contributors_url":"https://api.github.com/repos/elastic/kibana/contributors","subscribers_url":"https://api.github.com/repos/elastic/kibana/subscribers","subscription_url":"https://api.github.com/repos/elastic/kibana/subscription","commits_url":"https://api.github.com/repos/elastic/kibana/commits{/sha}","git_commits_url":"https://api.github.com/repos/elastic/kibana/git/commits{/sha}","comments_url":"https://api.github.com/repos/elastic/kibana/comments{/number}","issue_comment_url":"https://api.github.com/repos/elastic/kibana/issues/comments{/number}","contents_url":"https://api.github.com/repos/elastic/kibana/contents/{+path}","compare_url":"https://api.github.com/repos/elastic/kibana/compare/{base}...{head}","merges_url":"https://api.github.com/repos/elastic/kibana/merges","archive_url":"https://api.github.com/repos/elastic/kibana/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/elastic/kibana/downloads","issues_url":"https://api.github.com/repos/elastic/kibana/issues{/number}","pulls_url":"https://api.github.com/repos/elastic/kibana/pulls{/number}","milestones_url":"https://api.github.com/repos/elastic/kibana/milestones{/number}","notifications_url":"https://api.github.com/repos/elastic/kibana/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/elastic/kibana/labels{/name}","releases_url":"https://api.github.com/repos/elastic/kibana/releases{/id}","deployments_url":"https://api.github.com/repos/elastic/kibana/deployments","created_at":"2013-01-26T04:00:59Z","updated_at":"2018-05-25T19:01:28Z","pushed_at":"2018-05-25T19:01:10Z","git_url":"git://github.com/elastic/kibana.git","ssh_url":"git@github.com:elastic/kibana.git","clone_url":"https://github.com/elastic/kibana.git","svn_url":"https://github.com/elastic/kibana","homepage":"https://www.elastic.co/products/kibana","size":408987,"stargazers_count":9404,"watchers_count":9404,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3659,"mirror_url":null,"archived":false,"open_issues_count":3125,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3659,"open_issues":3125,"watchers":9404,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19451"},"html":{"href":"https://github.com/elastic/kibana/pull/19451"},"issue":{"href":"https://api.github.com/repos/elastic/kibana/issues/19451"},"comments":{"href":"https://api.github.com/repos/elastic/kibana/issues/19451/comments"},"review_comments":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19451/comments"},"review_comment":{"href":"https://api.github.com/repos/elastic/kibana/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/elastic/kibana/pulls/19451/commits"},"statuses":{"href":"https://api.github.com/repos/elastic/kibana/statuses/89c8be55ac5d68b548dbbcab17ad941ccf5a7455"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pickypg"}}