{"action":"created","issue":{"url":"https://api.github.com/repos/fable-compiler/Fable/issues/1473","repository_url":"https://api.github.com/repos/fable-compiler/Fable","labels_url":"https://api.github.com/repos/fable-compiler/Fable/issues/1473/labels{/name}","comments_url":"https://api.github.com/repos/fable-compiler/Fable/issues/1473/comments","events_url":"https://api.github.com/repos/fable-compiler/Fable/issues/1473/events","html_url":"https://github.com/fable-compiler/Fable/pull/1473","id":339734984,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwMzEyNzg1","number":1473,"title":"[WIP] Compile chars as numbers","user":{"login":"alfonsogarciacaro","id":8275461,"node_id":"MDQ6VXNlcjgyNzU0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/8275461?v=4","gravatar_id":"","url":"https://api.github.com/users/alfonsogarciacaro","html_url":"https://github.com/alfonsogarciacaro","followers_url":"https://api.github.com/users/alfonsogarciacaro/followers","following_url":"https://api.github.com/users/alfonsogarciacaro/following{/other_user}","gists_url":"https://api.github.com/users/alfonsogarciacaro/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsogarciacaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsogarciacaro/subscriptions","organizations_url":"https://api.github.com/users/alfonsogarciacaro/orgs","repos_url":"https://api.github.com/users/alfonsogarciacaro/repos","events_url":"https://api.github.com/users/alfonsogarciacaro/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsogarciacaro/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":6,"created_at":"2018-07-10T08:08:11Z","updated_at":"2018-07-16T08:54:14Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/fable-compiler/Fable/pulls/1473","html_url":"https://github.com/fable-compiler/Fable/pull/1473","diff_url":"https://github.com/fable-compiler/Fable/pull/1473.diff","patch_url":"https://github.com/fable-compiler/Fable/pull/1473.patch"},"body":"This PR tried to compile chars as numbers in the hope this would give a performance boost when parsing but apparently there's not much gain. [Some discussion here](https://github.com/fable-compiler/Fable/issues/1457#issuecomment-402765942)."},"comment":{"url":"https://api.github.com/repos/fable-compiler/Fable/issues/comments/405184248","html_url":"https://github.com/fable-compiler/Fable/pull/1473#issuecomment-405184248","issue_url":"https://api.github.com/repos/fable-compiler/Fable/issues/1473","id":405184248,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNTE4NDI0OA==","user":{"login":"alfonsogarciacaro","id":8275461,"node_id":"MDQ6VXNlcjgyNzU0NjE=","avatar_url":"https://avatars0.githubusercontent.com/u/8275461?v=4","gravatar_id":"","url":"https://api.github.com/users/alfonsogarciacaro","html_url":"https://github.com/alfonsogarciacaro","followers_url":"https://api.github.com/users/alfonsogarciacaro/followers","following_url":"https://api.github.com/users/alfonsogarciacaro/following{/other_user}","gists_url":"https://api.github.com/users/alfonsogarciacaro/gists{/gist_id}","starred_url":"https://api.github.com/users/alfonsogarciacaro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alfonsogarciacaro/subscriptions","organizations_url":"https://api.github.com/users/alfonsogarciacaro/orgs","repos_url":"https://api.github.com/users/alfonsogarciacaro/repos","events_url":"https://api.github.com/users/alfonsogarciacaro/events{/privacy}","received_events_url":"https://api.github.com/users/alfonsogarciacaro/received_events","type":"User","site_admin":false},"created_at":"2018-07-16T08:54:14Z","updated_at":"2018-07-16T08:54:14Z","author_association":"MEMBER","body":"Thanks a lot for benchmarking @chadunit! So in principle the performance boost is coming mainly from using typed arrays which can be done just by using `uint16[]` (if the user knows about this).\r\n\r\nThis PR still uses regular expressions for `IsDigit` and `IsWhitespace`. I wonder if this has a big influence in the benchmark. I'll try to convert them to use codes instead and run the Scott Wlaschin parser again. Thanks again for providing the gist @chadunit!"}}
{"actor":{"display_login":"alfonsogarciacaro"}}