{"action":"created","issue":{"url":"https://api.github.com/repos/epics-base/epicsCoreJava/issues/19","repository_url":"https://api.github.com/repos/epics-base/epicsCoreJava","labels_url":"https://api.github.com/repos/epics-base/epicsCoreJava/issues/19/labels{/name}","comments_url":"https://api.github.com/repos/epics-base/epicsCoreJava/issues/19/comments","events_url":"https://api.github.com/repos/epics-base/epicsCoreJava/issues/19/events","html_url":"https://github.com/epics-base/epicsCoreJava/pull/19","id":345812299,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0ODQ0OTgw","number":19,"title":"Updated pvdata","user":{"login":"shroffk","id":2111304,"node_id":"MDQ6VXNlcjIxMTEzMDQ=","avatar_url":"https://avatars0.githubusercontent.com/u/2111304?v=4","gravatar_id":"","url":"https://api.github.com/users/shroffk","html_url":"https://github.com/shroffk","followers_url":"https://api.github.com/users/shroffk/followers","following_url":"https://api.github.com/users/shroffk/following{/other_user}","gists_url":"https://api.github.com/users/shroffk/gists{/gist_id}","starred_url":"https://api.github.com/users/shroffk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/shroffk/subscriptions","organizations_url":"https://api.github.com/users/shroffk/orgs","repos_url":"https://api.github.com/users/shroffk/repos","events_url":"https://api.github.com/users/shroffk/events{/privacy}","received_events_url":"https://api.github.com/users/shroffk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-07-30T15:35:44Z","updated_at":"2018-08-06T12:08:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/epics-base/epicsCoreJava/pulls/19","html_url":"https://github.com/epics-base/epicsCoreJava/pull/19","diff_url":"https://github.com/epics-base/epicsCoreJava/pull/19.diff","patch_url":"https://github.com/epics-base/epicsCoreJava/pull/19.patch"},"body":"Have to wait till PR#18 is merged before this can be merged."},"comment":{"url":"https://api.github.com/repos/epics-base/epicsCoreJava/issues/comments/410686353","html_url":"https://github.com/epics-base/epicsCoreJava/pull/19#issuecomment-410686353","issue_url":"https://api.github.com/repos/epics-base/epicsCoreJava/issues/19","id":410686353,"node_id":"MDEyOklzc3VlQ29tbWVudDQxMDY4NjM1Mw==","user":{"login":"georgweiss","id":35602960,"node_id":"MDQ6VXNlcjM1NjAyOTYw","avatar_url":"https://avatars2.githubusercontent.com/u/35602960?v=4","gravatar_id":"","url":"https://api.github.com/users/georgweiss","html_url":"https://github.com/georgweiss","followers_url":"https://api.github.com/users/georgweiss/followers","following_url":"https://api.github.com/users/georgweiss/following{/other_user}","gists_url":"https://api.github.com/users/georgweiss/gists{/gist_id}","starred_url":"https://api.github.com/users/georgweiss/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/georgweiss/subscriptions","organizations_url":"https://api.github.com/users/georgweiss/orgs","repos_url":"https://api.github.com/users/georgweiss/repos","events_url":"https://api.github.com/users/georgweiss/events{/privacy}","received_events_url":"https://api.github.com/users/georgweiss/received_events","type":"User","site_admin":false},"created_at":"2018-08-06T12:08:44Z","updated_at":"2018-08-06T12:08:44Z","author_association":"CONTRIBUTOR","body":"Does not seem to build on Java 10 (several issues).\r\n\r\nAs for technical matters, I have insufficient experience with the code to say anything clever. However, I do have some comments in regards to VImage related classes: \r\n1) Is the VImageType enum supposed to cover all relevant permutations of properties like colour space,   number of bytes per pixel and others? If so, why not use a class that encapsulates these properties?\r\n2) In VImgeDataType, why is there a need for a string type? Plus, the methods in the class are tightly dependent on the order in which the values appear in the source code. As an alternative, one could maybe consider an integer (or short) property in the enum in order to not depend on the ordinal, e.g. pvBoolean(0), pvByte(1), pvShort(2) etc."}}
{"actor":{"display_login":"georgweiss"}}