{"action":"created","comment":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/216847080","pull_request_review_id":154426030,"id":216847080,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIxNjg0NzA4MA==","diff_hunk":"@@ -42,6 +42,34 @@\n \n class TopologyConstructionTest(test.TestCase):\n \n+  def test_add_variable_supports_TensorShape(self):","path":"tensorflow/python/keras/engine/topology_test.py","position":4,"original_position":4,"commit_id":"bd81c8b19e04e0d5f3f28ca73b7f7e2f1b11fdca","original_commit_id":"bd81c8b19e04e0d5f3f28ca73b7f7e2f1b11fdca","user":{"login":"facaiy","id":1112263,"node_id":"MDQ6VXNlcjExMTIyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1112263?v=4","gravatar_id":"","url":"https://api.github.com/users/facaiy","html_url":"https://github.com/facaiy","followers_url":"https://api.github.com/users/facaiy/followers","following_url":"https://api.github.com/users/facaiy/following{/other_user}","gists_url":"https://api.github.com/users/facaiy/gists{/gist_id}","starred_url":"https://api.github.com/users/facaiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facaiy/subscriptions","organizations_url":"https://api.github.com/users/facaiy/orgs","repos_url":"https://api.github.com/users/facaiy/repos","events_url":"https://api.github.com/users/facaiy/events{/privacy}","received_events_url":"https://api.github.com/users/facaiy/received_events","type":"User","site_admin":false},"body":"Could you explain what's CL? changed line? And could you clarity what the new unit test is for? I think init_op_test has added tests for TensorShape. \r\n","created_at":"2018-09-11T22:41:38Z","updated_at":"2018-09-11T22:41:39Z","html_url":"https://github.com/tensorflow/tensorflow/pull/21865#discussion_r216847080","pull_request_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21865","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments/216847080"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/21865#discussion_r216847080"},"pull_request":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21865"}},"in_reply_to_id":216781358},"pull_request":{"url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21865","id":210882087,"node_id":"MDExOlB1bGxSZXF1ZXN0MjEwODgyMDg3","html_url":"https://github.com/tensorflow/tensorflow/pull/21865","diff_url":"https://github.com/tensorflow/tensorflow/pull/21865.diff","patch_url":"https://github.com/tensorflow/tensorflow/pull/21865.patch","issue_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21865","number":21865,"state":"open","locked":false,"title":"initializer should support TensorShape","user":{"login":"facaiy","id":1112263,"node_id":"MDQ6VXNlcjExMTIyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1112263?v=4","gravatar_id":"","url":"https://api.github.com/users/facaiy","html_url":"https://github.com/facaiy","followers_url":"https://api.github.com/users/facaiy/followers","following_url":"https://api.github.com/users/facaiy/following{/other_user}","gists_url":"https://api.github.com/users/facaiy/gists{/gist_id}","starred_url":"https://api.github.com/users/facaiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facaiy/subscriptions","organizations_url":"https://api.github.com/users/facaiy/orgs","repos_url":"https://api.github.com/users/facaiy/repos","events_url":"https://api.github.com/users/facaiy/events{/privacy}","received_events_url":"https://api.github.com/users/facaiy/received_events","type":"User","site_admin":false},"body":"Fix #21838.","created_at":"2018-08-25T03:01:07Z","updated_at":"2018-09-11T22:41:39Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05670810c08b1f625957caee5d2ec962ab71f49b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":300136587,"node_id":"MDU6TGFiZWwzMDAxMzY1ODc=","url":"https://api.github.com/repos/tensorflow/tensorflow/labels/cla:%20yes","name":"cla: yes","color":"009800","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21865/commits","review_comments_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21865/comments","review_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/21865/comments","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/bd81c8b19e04e0d5f3f28ca73b7f7e2f1b11fdca","head":{"label":"facaiy:BUG/initalizer_supports_TensorShape","ref":"BUG/initalizer_supports_TensorShape","sha":"bd81c8b19e04e0d5f3f28ca73b7f7e2f1b11fdca","user":{"login":"facaiy","id":1112263,"node_id":"MDQ6VXNlcjExMTIyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1112263?v=4","gravatar_id":"","url":"https://api.github.com/users/facaiy","html_url":"https://github.com/facaiy","followers_url":"https://api.github.com/users/facaiy/followers","following_url":"https://api.github.com/users/facaiy/following{/other_user}","gists_url":"https://api.github.com/users/facaiy/gists{/gist_id}","starred_url":"https://api.github.com/users/facaiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facaiy/subscriptions","organizations_url":"https://api.github.com/users/facaiy/orgs","repos_url":"https://api.github.com/users/facaiy/repos","events_url":"https://api.github.com/users/facaiy/events{/privacy}","received_events_url":"https://api.github.com/users/facaiy/received_events","type":"User","site_admin":false},"repo":{"id":86031405,"node_id":"MDEwOlJlcG9zaXRvcnk4NjAzMTQwNQ==","name":"tensorflow","full_name":"facaiy/tensorflow","owner":{"login":"facaiy","id":1112263,"node_id":"MDQ6VXNlcjExMTIyNjM=","avatar_url":"https://avatars3.githubusercontent.com/u/1112263?v=4","gravatar_id":"","url":"https://api.github.com/users/facaiy","html_url":"https://github.com/facaiy","followers_url":"https://api.github.com/users/facaiy/followers","following_url":"https://api.github.com/users/facaiy/following{/other_user}","gists_url":"https://api.github.com/users/facaiy/gists{/gist_id}","starred_url":"https://api.github.com/users/facaiy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/facaiy/subscriptions","organizations_url":"https://api.github.com/users/facaiy/orgs","repos_url":"https://api.github.com/users/facaiy/repos","events_url":"https://api.github.com/users/facaiy/events{/privacy}","received_events_url":"https://api.github.com/users/facaiy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/facaiy/tensorflow","description":"Computation using data flow graphs for scalable machine learning","fork":true,"url":"https://api.github.com/repos/facaiy/tensorflow","forks_url":"https://api.github.com/repos/facaiy/tensorflow/forks","keys_url":"https://api.github.com/repos/facaiy/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/facaiy/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/facaiy/tensorflow/teams","hooks_url":"https://api.github.com/repos/facaiy/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/facaiy/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/facaiy/tensorflow/events","assignees_url":"https://api.github.com/repos/facaiy/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/facaiy/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/facaiy/tensorflow/tags","blobs_url":"https://api.github.com/repos/facaiy/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/facaiy/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/facaiy/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/facaiy/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/facaiy/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/facaiy/tensorflow/languages","stargazers_url":"https://api.github.com/repos/facaiy/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/facaiy/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/facaiy/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/facaiy/tensorflow/subscription","commits_url":"https://api.github.com/repos/facaiy/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/facaiy/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/facaiy/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/facaiy/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/facaiy/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/facaiy/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/facaiy/tensorflow/merges","archive_url":"https://api.github.com/repos/facaiy/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/facaiy/tensorflow/downloads","issues_url":"https://api.github.com/repos/facaiy/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/facaiy/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/facaiy/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/facaiy/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/facaiy/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/facaiy/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/facaiy/tensorflow/deployments","created_at":"2017-03-24T05:42:08Z","updated_at":"2018-09-05T02:21:22Z","pushed_at":"2018-09-11T13:47:40Z","git_url":"git://github.com/facaiy/tensorflow.git","ssh_url":"git@github.com:facaiy/tensorflow.git","clone_url":"https://github.com/facaiy/tensorflow.git","svn_url":"https://github.com/facaiy/tensorflow","homepage":"http://tensorflow.org","size":254024,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"tensorflow:master","ref":"master","sha":"ca94990804cf5326c0f6f46d75c96e0f0e240366","user":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"repo":{"id":45717250,"node_id":"MDEwOlJlcG9zaXRvcnk0NTcxNzI1MA==","name":"tensorflow","full_name":"tensorflow/tensorflow","owner":{"login":"tensorflow","id":15658638,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1NjU4NjM4","avatar_url":"https://avatars1.githubusercontent.com/u/15658638?v=4","gravatar_id":"","url":"https://api.github.com/users/tensorflow","html_url":"https://github.com/tensorflow","followers_url":"https://api.github.com/users/tensorflow/followers","following_url":"https://api.github.com/users/tensorflow/following{/other_user}","gists_url":"https://api.github.com/users/tensorflow/gists{/gist_id}","starred_url":"https://api.github.com/users/tensorflow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tensorflow/subscriptions","organizations_url":"https://api.github.com/users/tensorflow/orgs","repos_url":"https://api.github.com/users/tensorflow/repos","events_url":"https://api.github.com/users/tensorflow/events{/privacy}","received_events_url":"https://api.github.com/users/tensorflow/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/tensorflow/tensorflow","description":"An Open Source Machine Learning Framework for Everyone","fork":false,"url":"https://api.github.com/repos/tensorflow/tensorflow","forks_url":"https://api.github.com/repos/tensorflow/tensorflow/forks","keys_url":"https://api.github.com/repos/tensorflow/tensorflow/keys{/key_id}","collaborators_url":"https://api.github.com/repos/tensorflow/tensorflow/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/tensorflow/tensorflow/teams","hooks_url":"https://api.github.com/repos/tensorflow/tensorflow/hooks","issue_events_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/events{/number}","events_url":"https://api.github.com/repos/tensorflow/tensorflow/events","assignees_url":"https://api.github.com/repos/tensorflow/tensorflow/assignees{/user}","branches_url":"https://api.github.com/repos/tensorflow/tensorflow/branches{/branch}","tags_url":"https://api.github.com/repos/tensorflow/tensorflow/tags","blobs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/tensorflow/tensorflow/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/tensorflow/tensorflow/git/refs{/sha}","trees_url":"https://api.github.com/repos/tensorflow/tensorflow/git/trees{/sha}","statuses_url":"https://api.github.com/repos/tensorflow/tensorflow/statuses/{sha}","languages_url":"https://api.github.com/repos/tensorflow/tensorflow/languages","stargazers_url":"https://api.github.com/repos/tensorflow/tensorflow/stargazers","contributors_url":"https://api.github.com/repos/tensorflow/tensorflow/contributors","subscribers_url":"https://api.github.com/repos/tensorflow/tensorflow/subscribers","subscription_url":"https://api.github.com/repos/tensorflow/tensorflow/subscription","commits_url":"https://api.github.com/repos/tensorflow/tensorflow/commits{/sha}","git_commits_url":"https://api.github.com/repos/tensorflow/tensorflow/git/commits{/sha}","comments_url":"https://api.github.com/repos/tensorflow/tensorflow/comments{/number}","issue_comment_url":"https://api.github.com/repos/tensorflow/tensorflow/issues/comments{/number}","contents_url":"https://api.github.com/repos/tensorflow/tensorflow/contents/{+path}","compare_url":"https://api.github.com/repos/tensorflow/tensorflow/compare/{base}...{head}","merges_url":"https://api.github.com/repos/tensorflow/tensorflow/merges","archive_url":"https://api.github.com/repos/tensorflow/tensorflow/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/tensorflow/tensorflow/downloads","issues_url":"https://api.github.com/repos/tensorflow/tensorflow/issues{/number}","pulls_url":"https://api.github.com/repos/tensorflow/tensorflow/pulls{/number}","milestones_url":"https://api.github.com/repos/tensorflow/tensorflow/milestones{/number}","notifications_url":"https://api.github.com/repos/tensorflow/tensorflow/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/tensorflow/tensorflow/labels{/name}","releases_url":"https://api.github.com/repos/tensorflow/tensorflow/releases{/id}","deployments_url":"https://api.github.com/repos/tensorflow/tensorflow/deployments","created_at":"2015-11-07T01:19:20Z","updated_at":"2018-09-11T22:39:41Z","pushed_at":"2018-09-11T22:40:55Z","git_url":"git://github.com/tensorflow/tensorflow.git","ssh_url":"git@github.com:tensorflow/tensorflow.git","clone_url":"https://github.com/tensorflow/tensorflow.git","svn_url":"https://github.com/tensorflow/tensorflow","homepage":"https://tensorflow.org","size":254846,"stargazers_count":109255,"watchers_count":109255,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":67417,"mirror_url":null,"archived":false,"open_issues_count":1847,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":67417,"open_issues":1847,"watchers":109255,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21865"},"html":{"href":"https://github.com/tensorflow/tensorflow/pull/21865"},"issue":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/21865"},"comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/issues/21865/comments"},"review_comments":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21865/comments"},"review_comment":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/tensorflow/tensorflow/pulls/21865/commits"},"statuses":{"href":"https://api.github.com/repos/tensorflow/tensorflow/statuses/bd81c8b19e04e0d5f3f28ca73b7f7e2f1b11fdca"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"facaiy"}}