{"action":"created","comment":{"url":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/comments/232380179","pull_request_review_id":173573732,"id":232380179,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjM4MDE3OQ==","diff_hunk":"@@ -147,46 +324,130 @@ def __init__(self, name, app_id, display_name, project_id):\n \n     @property\n     def name(self):\n-        \"\"\"The fully qualified resource name of this Android App.\"\"\"\n+        \"\"\"The fully qualified resource name of this Android or iOS app.\"\"\"\n         return self._name\n \n     @property\n     def app_id(self):\n-        \"\"\"The globally unique, Firebase-assigned identifier of this Android App.\n+        \"\"\"The globally unique, Firebase-assigned identifier of this Android or iOS app.\n \n-        This ID is unique even across Apps of different platforms, such as iOS Apps.\n+        This ID is unique even across apps of different platforms.\n         \"\"\"\n         return self._app_id\n \n     @property\n     def display_name(self):\n-        \"\"\"The user-assigned display name of this Android App.\"\"\"\n+        \"\"\"The user-assigned display name of this Android or iOS app.\"\"\"\n         return self._display_name\n \n     @property\n     def project_id(self):\n-        \"\"\"The permanent, globally unique, user-assigned ID of the parent Firebase Project.\"\"\"\n+        \"\"\"The permanent, globally unique, user-assigned ID of the parent Firebase project.\"\"\"\n         return self._project_id\n \n \n class AndroidAppMetadata(_AppMetadata):\n-    \"\"\"Android-specific information about an Android Firebase App.\"\"\"\n+    \"\"\"Android-specific information about an Android Firebase app.\"\"\"\n \n-    def __init__(self, name, app_id, display_name, project_id, package_name):\n+    def __init__(self, package_name, name, app_id, display_name, project_id):","path":"firebase_admin/project_management.py","position":329,"original_position":329,"commit_id":"dc5ed7549832c2ea29b89e6f866d50d75cf1d1e7","original_commit_id":"dc5ed7549832c2ea29b89e6f866d50d75cf1d1e7","user":{"login":"hiranya911","id":2375201,"node_id":"MDQ6VXNlcjIzNzUyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/2375201?v=4","gravatar_id":"","url":"https://api.github.com/users/hiranya911","html_url":"https://github.com/hiranya911","followers_url":"https://api.github.com/users/hiranya911/followers","following_url":"https://api.github.com/users/hiranya911/following{/other_user}","gists_url":"https://api.github.com/users/hiranya911/gists{/gist_id}","starred_url":"https://api.github.com/users/hiranya911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiranya911/subscriptions","organizations_url":"https://api.github.com/users/hiranya911/orgs","repos_url":"https://api.github.com/users/hiranya911/repos","events_url":"https://api.github.com/users/hiranya911/events{/privacy}","received_events_url":"https://api.github.com/users/hiranya911/received_events","type":"User","site_admin":false},"body":"It seems to me the argument order you had earlier is the more appropriate one. Commons args followed by more type specific args.","created_at":"2018-11-09T20:13:27Z","updated_at":"2018-11-09T20:37:17Z","html_url":"https://github.com/firebase/firebase-admin-python/pull/217#discussion_r232380179","pull_request_url":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/217","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/comments/232380179"},"html":{"href":"https://github.com/firebase/firebase-admin-python/pull/217#discussion_r232380179"},"pull_request":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/217"}}},"pull_request":{"url":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/217","id":229484256,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NDg0MjU2","html_url":"https://github.com/firebase/firebase-admin-python/pull/217","diff_url":"https://github.com/firebase/firebase-admin-python/pull/217.diff","patch_url":"https://github.com/firebase/firebase-admin-python/pull/217.patch","issue_url":"https://api.github.com/repos/firebase/firebase-admin-python/issues/217","number":217,"state":"open","locked":false,"title":"Implement get_config and all SHA certificate-related methods","user":{"login":"weixifan","id":44070836,"node_id":"MDQ6VXNlcjQ0MDcwODM2","avatar_url":"https://avatars1.githubusercontent.com/u/44070836?v=4","gravatar_id":"","url":"https://api.github.com/users/weixifan","html_url":"https://github.com/weixifan","followers_url":"https://api.github.com/users/weixifan/followers","following_url":"https://api.github.com/users/weixifan/following{/other_user}","gists_url":"https://api.github.com/users/weixifan/gists{/gist_id}","starred_url":"https://api.github.com/users/weixifan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/weixifan/subscriptions","organizations_url":"https://api.github.com/users/weixifan/orgs","repos_url":"https://api.github.com/users/weixifan/repos","events_url":"https://api.github.com/users/weixifan/events{/privacy}","received_events_url":"https://api.github.com/users/weixifan/received_events","type":"User","site_admin":false},"body":"This PR concludes the main implementation work of the `project_management` module. New integration tests have been added to cover these new functionalities.\r\n\r\nThe final few upcoming PRs will add a unit test suite for the `project_management` module.","created_at":"2018-11-08T19:37:03Z","updated_at":"2018-11-09T20:37:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f5497c27050c85157578465b8785f32eb33883db","assignee":{"login":"hiranya911","id":2375201,"node_id":"MDQ6VXNlcjIzNzUyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/2375201?v=4","gravatar_id":"","url":"https://api.github.com/users/hiranya911","html_url":"https://github.com/hiranya911","followers_url":"https://api.github.com/users/hiranya911/followers","following_url":"https://api.github.com/users/hiranya911/following{/other_user}","gists_url":"https://api.github.com/users/hiranya911/gists{/gist_id}","starred_url":"https://api.github.com/users/hiranya911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiranya911/subscriptions","organizations_url":"https://api.github.com/users/hiranya911/orgs","repos_url":"https://api.github.com/users/hiranya911/repos","events_url":"https://api.github.com/users/hiranya911/events{/privacy}","received_events_url":"https://api.github.com/users/hiranya911/received_events","type":"User","site_admin":false},"assignees":[{"login":"hiranya911","id":2375201,"node_id":"MDQ6VXNlcjIzNzUyMDE=","avatar_url":"https://avatars1.githubusercontent.com/u/2375201?v=4","gravatar_id":"","url":"https://api.github.com/users/hiranya911","html_url":"https://github.com/hiranya911","followers_url":"https://api.github.com/users/hiranya911/followers","following_url":"https://api.github.com/users/hiranya911/following{/other_user}","gists_url":"https://api.github.com/users/hiranya911/gists{/gist_id}","starred_url":"https://api.github.com/users/hiranya911/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hiranya911/subscriptions","organizations_url":"https://api.github.com/users/hiranya911/orgs","repos_url":"https://api.github.com/users/hiranya911/repos","events_url":"https://api.github.com/users/hiranya911/events{/privacy}","received_events_url":"https://api.github.com/users/hiranya911/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/217/commits","review_comments_url":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/217/comments","review_comment_url":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/comments{/number}","comments_url":"https://api.github.com/repos/firebase/firebase-admin-python/issues/217/comments","statuses_url":"https://api.github.com/repos/firebase/firebase-admin-python/statuses/dc5ed7549832c2ea29b89e6f866d50d75cf1d1e7","head":{"label":"firebase:weixifan-project-management-5","ref":"weixifan-project-management-5","sha":"dc5ed7549832c2ea29b89e6f866d50d75cf1d1e7","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":84979152,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk3OTE1Mg==","name":"firebase-admin-python","full_name":"firebase/firebase-admin-python","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-admin-python","description":"Firebase Admin Python SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-admin-python","forks_url":"https://api.github.com/repos/firebase/firebase-admin-python/forks","keys_url":"https://api.github.com/repos/firebase/firebase-admin-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-admin-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-admin-python/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-admin-python/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-admin-python/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-admin-python/events","assignees_url":"https://api.github.com/repos/firebase/firebase-admin-python/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-admin-python/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-admin-python/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-admin-python/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-admin-python/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-admin-python/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-admin-python/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-admin-python/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-admin-python/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-admin-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-admin-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-admin-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-admin-python/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-admin-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-admin-python/merges","archive_url":"https://api.github.com/repos/firebase/firebase-admin-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-admin-python/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-admin-python/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-admin-python/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-admin-python/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-admin-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-admin-python/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-admin-python/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-admin-python/deployments","created_at":"2017-03-14T17:40:16Z","updated_at":"2018-11-07T07:13:24Z","pushed_at":"2018-11-09T06:54:45Z","git_url":"git://github.com/firebase/firebase-admin-python.git","ssh_url":"git@github.com:firebase/firebase-admin-python.git","clone_url":"https://github.com/firebase/firebase-admin-python.git","svn_url":"https://github.com/firebase/firebase-admin-python","homepage":"https://firebase.google.com/docs/admin/setup","size":532,"stargazers_count":220,"watchers_count":220,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":66,"open_issues":28,"watchers":220,"default_branch":"master"}},"base":{"label":"firebase:project-mgt-service","ref":"project-mgt-service","sha":"87f05c0a62b788cf6191c9619155784bc80194de","user":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"repo":{"id":84979152,"node_id":"MDEwOlJlcG9zaXRvcnk4NDk3OTE1Mg==","name":"firebase-admin-python","full_name":"firebase/firebase-admin-python","private":false,"owner":{"login":"firebase","id":1335026,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzMzUwMjY=","avatar_url":"https://avatars2.githubusercontent.com/u/1335026?v=4","gravatar_id":"","url":"https://api.github.com/users/firebase","html_url":"https://github.com/firebase","followers_url":"https://api.github.com/users/firebase/followers","following_url":"https://api.github.com/users/firebase/following{/other_user}","gists_url":"https://api.github.com/users/firebase/gists{/gist_id}","starred_url":"https://api.github.com/users/firebase/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/firebase/subscriptions","organizations_url":"https://api.github.com/users/firebase/orgs","repos_url":"https://api.github.com/users/firebase/repos","events_url":"https://api.github.com/users/firebase/events{/privacy}","received_events_url":"https://api.github.com/users/firebase/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/firebase/firebase-admin-python","description":"Firebase Admin Python SDK","fork":false,"url":"https://api.github.com/repos/firebase/firebase-admin-python","forks_url":"https://api.github.com/repos/firebase/firebase-admin-python/forks","keys_url":"https://api.github.com/repos/firebase/firebase-admin-python/keys{/key_id}","collaborators_url":"https://api.github.com/repos/firebase/firebase-admin-python/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/firebase/firebase-admin-python/teams","hooks_url":"https://api.github.com/repos/firebase/firebase-admin-python/hooks","issue_events_url":"https://api.github.com/repos/firebase/firebase-admin-python/issues/events{/number}","events_url":"https://api.github.com/repos/firebase/firebase-admin-python/events","assignees_url":"https://api.github.com/repos/firebase/firebase-admin-python/assignees{/user}","branches_url":"https://api.github.com/repos/firebase/firebase-admin-python/branches{/branch}","tags_url":"https://api.github.com/repos/firebase/firebase-admin-python/tags","blobs_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/refs{/sha}","trees_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/trees{/sha}","statuses_url":"https://api.github.com/repos/firebase/firebase-admin-python/statuses/{sha}","languages_url":"https://api.github.com/repos/firebase/firebase-admin-python/languages","stargazers_url":"https://api.github.com/repos/firebase/firebase-admin-python/stargazers","contributors_url":"https://api.github.com/repos/firebase/firebase-admin-python/contributors","subscribers_url":"https://api.github.com/repos/firebase/firebase-admin-python/subscribers","subscription_url":"https://api.github.com/repos/firebase/firebase-admin-python/subscription","commits_url":"https://api.github.com/repos/firebase/firebase-admin-python/commits{/sha}","git_commits_url":"https://api.github.com/repos/firebase/firebase-admin-python/git/commits{/sha}","comments_url":"https://api.github.com/repos/firebase/firebase-admin-python/comments{/number}","issue_comment_url":"https://api.github.com/repos/firebase/firebase-admin-python/issues/comments{/number}","contents_url":"https://api.github.com/repos/firebase/firebase-admin-python/contents/{+path}","compare_url":"https://api.github.com/repos/firebase/firebase-admin-python/compare/{base}...{head}","merges_url":"https://api.github.com/repos/firebase/firebase-admin-python/merges","archive_url":"https://api.github.com/repos/firebase/firebase-admin-python/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/firebase/firebase-admin-python/downloads","issues_url":"https://api.github.com/repos/firebase/firebase-admin-python/issues{/number}","pulls_url":"https://api.github.com/repos/firebase/firebase-admin-python/pulls{/number}","milestones_url":"https://api.github.com/repos/firebase/firebase-admin-python/milestones{/number}","notifications_url":"https://api.github.com/repos/firebase/firebase-admin-python/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/firebase/firebase-admin-python/labels{/name}","releases_url":"https://api.github.com/repos/firebase/firebase-admin-python/releases{/id}","deployments_url":"https://api.github.com/repos/firebase/firebase-admin-python/deployments","created_at":"2017-03-14T17:40:16Z","updated_at":"2018-11-07T07:13:24Z","pushed_at":"2018-11-09T06:54:45Z","git_url":"git://github.com/firebase/firebase-admin-python.git","ssh_url":"git@github.com:firebase/firebase-admin-python.git","clone_url":"https://github.com/firebase/firebase-admin-python.git","svn_url":"https://github.com/firebase/firebase-admin-python","homepage":"https://firebase.google.com/docs/admin/setup","size":532,"stargazers_count":220,"watchers_count":220,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":66,"mirror_url":null,"archived":false,"open_issues_count":28,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":66,"open_issues":28,"watchers":220,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/217"},"html":{"href":"https://github.com/firebase/firebase-admin-python/pull/217"},"issue":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/issues/217"},"comments":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/issues/217/comments"},"review_comments":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/217/comments"},"review_comment":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/pulls/217/commits"},"statuses":{"href":"https://api.github.com/repos/firebase/firebase-admin-python/statuses/dc5ed7549832c2ea29b89e6f866d50d75cf1d1e7"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"hiranya911"}}