{"action":"created","issue":{"url":"https://api.github.com/repos/andykirk/CKEditorFootnotes/issues/30","repository_url":"https://api.github.com/repos/andykirk/CKEditorFootnotes","labels_url":"https://api.github.com/repos/andykirk/CKEditorFootnotes/issues/30/labels{/name}","comments_url":"https://api.github.com/repos/andykirk/CKEditorFootnotes/issues/30/comments","events_url":"https://api.github.com/repos/andykirk/CKEditorFootnotes/issues/30/events","html_url":"https://github.com/andykirk/CKEditorFootnotes/issues/30","id":320274643,"number":30,"title":"Update text of footonote","user":{"login":"alessandrots","id":3252654,"avatar_url":"https://avatars0.githubusercontent.com/u/3252654?v=4","gravatar_id":"","url":"https://api.github.com/users/alessandrots","html_url":"https://github.com/alessandrots","followers_url":"https://api.github.com/users/alessandrots/followers","following_url":"https://api.github.com/users/alessandrots/following{/other_user}","gists_url":"https://api.github.com/users/alessandrots/gists{/gist_id}","starred_url":"https://api.github.com/users/alessandrots/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/alessandrots/subscriptions","organizations_url":"https://api.github.com/users/alessandrots/orgs","repos_url":"https://api.github.com/users/alessandrots/repos","events_url":"https://api.github.com/users/alessandrots/events{/privacy}","received_events_url":"https://api.github.com/users/alessandrots/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-04T13:26:39Z","updated_at":"2018-05-04T14:10:59Z","closed_at":null,"author_association":"NONE","body":"Actually, what I have here is a question.\r\n\r\nI'm sorry, maybe this is not even the right place.\r\n\r\nI've seen all the code in this plugin. My question is about update a marker.\r\n\r\nWhen the user clicks the footnote href number and opens the dialog, the text that the user places there will change exactly a specific endnote.\r\nI have seen that a new ID is generated and the addFootnote function adds a new html li.\r\n\r\nMy initial scenario:\r\nI added 3 footnote.\r\n\r\n```\r\n<section class=\"footnotes\">\r\n ...\r\n    <ol>\r\n        <li data-footnote-id=\"yo7kq\" id=\"footnote-1\"><sup><a href=\"#footnote-marker-1-1\">^</a> </sup><cite>1</cite></li>\r\n        <li data-footnote-id=\"7p8e2\" id=\"footnote-2\"><sup><a href=\"#footnote-marker-2-1\">^</a> </sup><cite>2</cite></li>\r\n        <li data-footnote-id=\"tjbp6\" id=\"footnote-3\"><sup><a href=\"#footnote-marker-3-1\">^</a> </sup><cite>3</cite></li>\r\n    </ol>\r\n</section>\r\n```\r\n\r\nThen I clicked on the second marker, opened the dialog and changed the text.\r\n\r\nIn the reorderMarkers function a new ID is added this.footnote_ids = \r\n[\"yo7kq\", \"7p8e2\", \"tjbp6\", \"sqs80\"]\r\nwhat I understand is that the li tag is updated, it overwritten. Is that correct?\r\n\r\n```\r\n<section class=\"footnotes\">\r\n...\r\n<ol>\r\n    <li data-footnote-id=\"yo7kq\" id=\"footnote-1\"><sup><a href=\"#footnote-marker-1-1\">^</a> </sup><cite>1</cite></li>\r\n    <li data-footnote-id=\"sqs80\" id=\"footnote-2\"><sup><a href=\"#footnote-marker-2-1\">^</a> </sup><cite>NEW_2</cite></li>\r\n    <li data-footnote-id=\"tjbp6\" id=\"footnote-3\"><sup><a href=\"#footnote-marker-3-1\">^</a> </sup><cite>3</cite></li>\r\n</ol>\r\n</section>\r\n```\r\n\r\nMy doubts:     \r\n1) When changing the footnote-2 information how is this replacement made in html? Does the append of a new li exclude the former?\r\n\r\n2) Is there any way I can get the text for a footnote, when the user clicks the button on the toolbar the text has already been appeared on textearea of dialog"},"comment":{"url":"https://api.github.com/repos/andykirk/CKEditorFootnotes/issues/comments/386613688","html_url":"https://github.com/andykirk/CKEditorFootnotes/issues/30#issuecomment-386613688","issue_url":"https://api.github.com/repos/andykirk/CKEditorFootnotes/issues/30","id":386613688,"user":{"login":"andykirk","id":1502457,"avatar_url":"https://avatars2.githubusercontent.com/u/1502457?v=4","gravatar_id":"","url":"https://api.github.com/users/andykirk","html_url":"https://github.com/andykirk","followers_url":"https://api.github.com/users/andykirk/followers","following_url":"https://api.github.com/users/andykirk/following{/other_user}","gists_url":"https://api.github.com/users/andykirk/gists{/gist_id}","starred_url":"https://api.github.com/users/andykirk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andykirk/subscriptions","organizations_url":"https://api.github.com/users/andykirk/orgs","repos_url":"https://api.github.com/users/andykirk/repos","events_url":"https://api.github.com/users/andykirk/events{/privacy}","received_events_url":"https://api.github.com/users/andykirk/received_events","type":"User","site_admin":false},"created_at":"2018-05-04T14:10:59Z","updated_at":"2018-05-04T14:10:59Z","author_association":"OWNER","body":"Hi,\r\nI'm afraid I really don't understand what you're asking.\r\n\r\nThe [AB2] toolbar button is used for inserting new or existing footnotes, not editing them.\r\nThe content of a footnote can be edited directly in the edit area (footnotes section).\r\n\r\nWhilst editing, the markers in the content e.g. [1] shouldn't activate a dialog or anything - they're widgets so you can move them around.\r\nSimilarly, the markers (^, a, b, etc) in the footnotes sections shouldn't activate anything whilst in the editor.\r\n\r\nIf that doesn't answer your question, please can you have another go at asking it, perhaps with screenshots or something?\r\n\r\nThanks."}}
{"actor":{"display_login":"andykirk"}}