{"action":"created","issue":{"url":"https://api.github.com/repos/commercetools/nodejs/issues/789","repository_url":"https://api.github.com/repos/commercetools/nodejs","labels_url":"https://api.github.com/repos/commercetools/nodejs/issues/789/labels{/name}","comments_url":"https://api.github.com/repos/commercetools/nodejs/issues/789/comments","events_url":"https://api.github.com/repos/commercetools/nodejs/issues/789/events","html_url":"https://github.com/commercetools/nodejs/pull/789","id":358699559,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0MzcyNzI0","number":789,"title":"refactor(sync-actions/product-types): apply hints for nested value changes. ","user":{"login":"adnasa","id":462507,"node_id":"MDQ6VXNlcjQ2MjUwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/462507?v=4","gravatar_id":"","url":"https://api.github.com/users/adnasa","html_url":"https://github.com/adnasa","followers_url":"https://api.github.com/users/adnasa/followers","following_url":"https://api.github.com/users/adnasa/following{/other_user}","gists_url":"https://api.github.com/users/adnasa/gists{/gist_id}","starred_url":"https://api.github.com/users/adnasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnasa/subscriptions","organizations_url":"https://api.github.com/users/adnasa/orgs","repos_url":"https://api.github.com/users/adnasa/repos","events_url":"https://api.github.com/users/adnasa/events{/privacy}","received_events_url":"https://api.github.com/users/adnasa/received_events","type":"User","site_admin":false},"labels":[{"id":458563455,"node_id":"MDU6TGFiZWw0NTg1NjM0NTU=","url":"https://api.github.com/repos/commercetools/nodejs/labels/Status:%20Review","name":"Status: Review","color":"fbca04","default":false},{"id":505963108,"node_id":"MDU6TGFiZWw1MDU5NjMxMDg=","url":"https://api.github.com/repos/commercetools/nodejs/labels/Type:%20Breaking%20Change","name":"Type: Breaking Change","color":"000000","default":false}],"state":"open","locked":false,"assignee":{"login":"adnasa","id":462507,"node_id":"MDQ6VXNlcjQ2MjUwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/462507?v=4","gravatar_id":"","url":"https://api.github.com/users/adnasa","html_url":"https://github.com/adnasa","followers_url":"https://api.github.com/users/adnasa/followers","following_url":"https://api.github.com/users/adnasa/following{/other_user}","gists_url":"https://api.github.com/users/adnasa/gists{/gist_id}","starred_url":"https://api.github.com/users/adnasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnasa/subscriptions","organizations_url":"https://api.github.com/users/adnasa/orgs","repos_url":"https://api.github.com/users/adnasa/repos","events_url":"https://api.github.com/users/adnasa/events{/privacy}","received_events_url":"https://api.github.com/users/adnasa/received_events","type":"User","site_admin":false},"assignees":[{"login":"adnasa","id":462507,"node_id":"MDQ6VXNlcjQ2MjUwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/462507?v=4","gravatar_id":"","url":"https://api.github.com/users/adnasa","html_url":"https://github.com/adnasa","followers_url":"https://api.github.com/users/adnasa/followers","following_url":"https://api.github.com/users/adnasa/following{/other_user}","gists_url":"https://api.github.com/users/adnasa/gists{/gist_id}","starred_url":"https://api.github.com/users/adnasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnasa/subscriptions","organizations_url":"https://api.github.com/users/adnasa/orgs","repos_url":"https://api.github.com/users/adnasa/repos","events_url":"https://api.github.com/users/adnasa/events{/privacy}","received_events_url":"https://api.github.com/users/adnasa/received_events","type":"User","site_admin":false}],"milestone":null,"comments":5,"created_at":"2018-09-10T16:28:54Z","updated_at":"2018-09-12T11:10:37Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/commercetools/nodejs/pulls/789","html_url":"https://github.com/commercetools/nodejs/pull/789","diff_url":"https://github.com/commercetools/nodejs/pull/789.diff","patch_url":"https://github.com/commercetools/nodejs/pull/789.patch"},"body":"#### Summary\r\n\r\n- supercedes https://github.com/commercetools/nodejs/pull/760\r\n- removes old implementation for update-action generation for `attributes` and `enums`\r\n- introduces __hints__ approach to appropriately calculate update-actions for `attributes` and `enums`\r\n- _slightly_ related to https://github.com/commercetools/nodejs/issues/759\r\n\r\n#### Description\r\n\r\nEverything discussed in `syncActions.md`\r\n\r\n#### Todo\r\n\r\n- Tests\r\n  - [x] Unit\r\n  - ~~Integration~~\r\n  - ~~Acceptance~~\r\n- [x] Documentation\r\n"},"comment":{"url":"https://api.github.com/repos/commercetools/nodejs/issues/comments/420610252","html_url":"https://github.com/commercetools/nodejs/pull/789#issuecomment-420610252","issue_url":"https://api.github.com/repos/commercetools/nodejs/issues/789","id":420610252,"node_id":"MDEyOklzc3VlQ29tbWVudDQyMDYxMDI1Mg==","user":{"login":"adnasa","id":462507,"node_id":"MDQ6VXNlcjQ2MjUwNw==","avatar_url":"https://avatars1.githubusercontent.com/u/462507?v=4","gravatar_id":"","url":"https://api.github.com/users/adnasa","html_url":"https://github.com/adnasa","followers_url":"https://api.github.com/users/adnasa/followers","following_url":"https://api.github.com/users/adnasa/following{/other_user}","gists_url":"https://api.github.com/users/adnasa/gists{/gist_id}","starred_url":"https://api.github.com/users/adnasa/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/adnasa/subscriptions","organizations_url":"https://api.github.com/users/adnasa/orgs","repos_url":"https://api.github.com/users/adnasa/repos","events_url":"https://api.github.com/users/adnasa/events{/privacy}","received_events_url":"https://api.github.com/users/adnasa/received_events","type":"User","site_admin":false},"created_at":"2018-09-12T11:10:37Z","updated_at":"2018-09-12T11:10:37Z","author_association":"MEMBER","body":"> I think my main question is how this will work practically for users. In the other packages we simply just diff the now and before so a user can just dump their data into the function.\r\n\r\nI think I've covered this extensively with documentation that unlike other implementations, we accept only hints for nested values on product-types.\r\n\r\nThis is why I asked that this is reviewed as an approach and topic and if this is something we can proceed with, then we can apply the same approach to other sync-actions __providing that they have the same problem and needs__, and not having to re-think the underlying API with no time to figure out use cases ref #758 \r\n\r\nshort answers: no, it's not \"practical\", and I wasn't trying to comply to how other sync-actions work for the moment, because that doesn't solve the problem. This is the more intuitive approach that I propose.\r\n\r\n> Is there any way we do this to hints too?\r\n\r\nI don't understand? the point of hints, is that they are provided by the consumer, not specifically calculated internally in `product-types` before passing it down to the underlying `createBuildActions`..\r\n\r\n"}}
{"actor":{"display_login":"adnasa"}}