{"action":"created","comment":{"url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/comments/170054013","pull_request_review_id":98681549,"id":170054013,"diff_hunk":"@@ -172,24 +185,19 @@ public QuerySpec deserialize(ResourceInformation resourceInformation, Map<String\n \t\t\t\t\tdeserializeFields(querySpec, parameter);\n \t\t\t\t\tbreak;\n \t\t\t\tcase page:\n-\t\t\t\t\tdeserializePage(querySpec, parameter);\n+\t\t\t\t\tpageParameters.put(parameter.pageParameter, parameter.getValues());\n \t\t\t\t\tbreak;\n \t\t\t\tdefault:\n \t\t\t\t\tdeserializeUnknown(querySpec, parameter);\n \t\t\t}\n-\n+\t\t}\n+\t\tif (resourceInformation.getPagingBehavior() != null) {","path":"crnk-core/src/main/java/io/crnk/core/queryspec/DefaultQuerySpecDeserializer.java","position":162,"original_position":162,"commit_id":"7b58356c2b55f1adb9ab0db83e5ffd3ffb2e6540","original_commit_id":"0be54bcdd6bb54a503abe05ec187e476d5a6f7c2","user":{"login":"remmeier","id":8008853,"avatar_url":"https://avatars3.githubusercontent.com/u/8008853?v=4","gravatar_id":"","url":"https://api.github.com/users/remmeier","html_url":"https://github.com/remmeier","followers_url":"https://api.github.com/users/remmeier/followers","following_url":"https://api.github.com/users/remmeier/following{/other_user}","gists_url":"https://api.github.com/users/remmeier/gists{/gist_id}","starred_url":"https://api.github.com/users/remmeier/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/remmeier/subscriptions","organizations_url":"https://api.github.com/users/remmeier/orgs","repos_url":"https://api.github.com/users/remmeier/repos","events_url":"https://api.github.com/users/remmeier/events{/privacy}","received_events_url":"https://api.github.com/users/remmeier/received_events","type":"User","site_admin":false},"body":"I'm ok with the pagingBehavior being null if no paging is supported. But if there is no paging ANDa paging parameter was provided, then it should throw an exception?","created_at":"2018-02-22T18:41:23Z","updated_at":"2018-02-22T18:41:23Z","html_url":"https://github.com/crnk-project/crnk-framework/pull/232#discussion_r170054013","pull_request_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/232","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/comments/170054013"},"html":{"href":"https://github.com/crnk-project/crnk-framework/pull/232#discussion_r170054013"},"pull_request":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/232"}},"in_reply_to_id":169932334},"pull_request":{"url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/232","id":170186995,"html_url":"https://github.com/crnk-project/crnk-framework/pull/232","diff_url":"https://github.com/crnk-project/crnk-framework/pull/232.diff","patch_url":"https://github.com/crnk-project/crnk-framework/pull/232.patch","issue_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues/232","number":232,"state":"open","locked":false,"title":"Issues/47 2","user":{"login":"vicmosin","id":612207,"avatar_url":"https://avatars3.githubusercontent.com/u/612207?v=4","gravatar_id":"","url":"https://api.github.com/users/vicmosin","html_url":"https://github.com/vicmosin","followers_url":"https://api.github.com/users/vicmosin/followers","following_url":"https://api.github.com/users/vicmosin/following{/other_user}","gists_url":"https://api.github.com/users/vicmosin/gists{/gist_id}","starred_url":"https://api.github.com/users/vicmosin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicmosin/subscriptions","organizations_url":"https://api.github.com/users/vicmosin/orgs","repos_url":"https://api.github.com/users/vicmosin/repos","events_url":"https://api.github.com/users/vicmosin/events{/privacy}","received_events_url":"https://api.github.com/users/vicmosin/received_events","type":"User","site_admin":false},"body":"* Resolves #219 and #203","created_at":"2018-02-20T13:07:11Z","updated_at":"2018-02-22T18:41:23Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f2946ec1d29ca485968952e1bbdeb7cd5d08e98c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/232/commits","review_comments_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/232/comments","review_comment_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/comments{/number}","comments_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues/232/comments","statuses_url":"https://api.github.com/repos/crnk-project/crnk-framework/statuses/7b58356c2b55f1adb9ab0db83e5ffd3ffb2e6540","head":{"label":"vicmosin:issues/47-2","ref":"issues/47-2","sha":"7b58356c2b55f1adb9ab0db83e5ffd3ffb2e6540","user":{"login":"vicmosin","id":612207,"avatar_url":"https://avatars3.githubusercontent.com/u/612207?v=4","gravatar_id":"","url":"https://api.github.com/users/vicmosin","html_url":"https://github.com/vicmosin","followers_url":"https://api.github.com/users/vicmosin/followers","following_url":"https://api.github.com/users/vicmosin/following{/other_user}","gists_url":"https://api.github.com/users/vicmosin/gists{/gist_id}","starred_url":"https://api.github.com/users/vicmosin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicmosin/subscriptions","organizations_url":"https://api.github.com/users/vicmosin/orgs","repos_url":"https://api.github.com/users/vicmosin/repos","events_url":"https://api.github.com/users/vicmosin/events{/privacy}","received_events_url":"https://api.github.com/users/vicmosin/received_events","type":"User","site_admin":false},"repo":{"id":111408128,"name":"crnk-framework","full_name":"vicmosin/crnk-framework","owner":{"login":"vicmosin","id":612207,"avatar_url":"https://avatars3.githubusercontent.com/u/612207?v=4","gravatar_id":"","url":"https://api.github.com/users/vicmosin","html_url":"https://github.com/vicmosin","followers_url":"https://api.github.com/users/vicmosin/followers","following_url":"https://api.github.com/users/vicmosin/following{/other_user}","gists_url":"https://api.github.com/users/vicmosin/gists{/gist_id}","starred_url":"https://api.github.com/users/vicmosin/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/vicmosin/subscriptions","organizations_url":"https://api.github.com/users/vicmosin/orgs","repos_url":"https://api.github.com/users/vicmosin/repos","events_url":"https://api.github.com/users/vicmosin/events{/privacy}","received_events_url":"https://api.github.com/users/vicmosin/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/vicmosin/crnk-framework","description":"JSON API library for Java","fork":true,"url":"https://api.github.com/repos/vicmosin/crnk-framework","forks_url":"https://api.github.com/repos/vicmosin/crnk-framework/forks","keys_url":"https://api.github.com/repos/vicmosin/crnk-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/vicmosin/crnk-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/vicmosin/crnk-framework/teams","hooks_url":"https://api.github.com/repos/vicmosin/crnk-framework/hooks","issue_events_url":"https://api.github.com/repos/vicmosin/crnk-framework/issues/events{/number}","events_url":"https://api.github.com/repos/vicmosin/crnk-framework/events","assignees_url":"https://api.github.com/repos/vicmosin/crnk-framework/assignees{/user}","branches_url":"https://api.github.com/repos/vicmosin/crnk-framework/branches{/branch}","tags_url":"https://api.github.com/repos/vicmosin/crnk-framework/tags","blobs_url":"https://api.github.com/repos/vicmosin/crnk-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/vicmosin/crnk-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/vicmosin/crnk-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/vicmosin/crnk-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/vicmosin/crnk-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/vicmosin/crnk-framework/languages","stargazers_url":"https://api.github.com/repos/vicmosin/crnk-framework/stargazers","contributors_url":"https://api.github.com/repos/vicmosin/crnk-framework/contributors","subscribers_url":"https://api.github.com/repos/vicmosin/crnk-framework/subscribers","subscription_url":"https://api.github.com/repos/vicmosin/crnk-framework/subscription","commits_url":"https://api.github.com/repos/vicmosin/crnk-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/vicmosin/crnk-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/vicmosin/crnk-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/vicmosin/crnk-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/vicmosin/crnk-framework/contents/{+path}","compare_url":"https://api.github.com/repos/vicmosin/crnk-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/vicmosin/crnk-framework/merges","archive_url":"https://api.github.com/repos/vicmosin/crnk-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/vicmosin/crnk-framework/downloads","issues_url":"https://api.github.com/repos/vicmosin/crnk-framework/issues{/number}","pulls_url":"https://api.github.com/repos/vicmosin/crnk-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/vicmosin/crnk-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/vicmosin/crnk-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/vicmosin/crnk-framework/labels{/name}","releases_url":"https://api.github.com/repos/vicmosin/crnk-framework/releases{/id}","deployments_url":"https://api.github.com/repos/vicmosin/crnk-framework/deployments","created_at":"2017-11-20T12:32:58Z","updated_at":"2017-11-20T12:33:02Z","pushed_at":"2018-02-22T17:26:13Z","git_url":"git://github.com/vicmosin/crnk-framework.git","ssh_url":"git@github.com:vicmosin/crnk-framework.git","clone_url":"https://github.com/vicmosin/crnk-framework.git","svn_url":"https://github.com/vicmosin/crnk-framework","homepage":"","size":3726,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"crnk-project:master","ref":"master","sha":"ce22ddc88223c2a647a5e20681264a879569878a","user":{"login":"crnk-project","id":28780235,"avatar_url":"https://avatars0.githubusercontent.com/u/28780235?v=4","gravatar_id":"","url":"https://api.github.com/users/crnk-project","html_url":"https://github.com/crnk-project","followers_url":"https://api.github.com/users/crnk-project/followers","following_url":"https://api.github.com/users/crnk-project/following{/other_user}","gists_url":"https://api.github.com/users/crnk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crnk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crnk-project/subscriptions","organizations_url":"https://api.github.com/users/crnk-project/orgs","repos_url":"https://api.github.com/users/crnk-project/repos","events_url":"https://api.github.com/users/crnk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crnk-project/received_events","type":"Organization","site_admin":false},"repo":{"id":91683656,"name":"crnk-framework","full_name":"crnk-project/crnk-framework","owner":{"login":"crnk-project","id":28780235,"avatar_url":"https://avatars0.githubusercontent.com/u/28780235?v=4","gravatar_id":"","url":"https://api.github.com/users/crnk-project","html_url":"https://github.com/crnk-project","followers_url":"https://api.github.com/users/crnk-project/followers","following_url":"https://api.github.com/users/crnk-project/following{/other_user}","gists_url":"https://api.github.com/users/crnk-project/gists{/gist_id}","starred_url":"https://api.github.com/users/crnk-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crnk-project/subscriptions","organizations_url":"https://api.github.com/users/crnk-project/orgs","repos_url":"https://api.github.com/users/crnk-project/repos","events_url":"https://api.github.com/users/crnk-project/events{/privacy}","received_events_url":"https://api.github.com/users/crnk-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/crnk-project/crnk-framework","description":"JSON API library for Java","fork":false,"url":"https://api.github.com/repos/crnk-project/crnk-framework","forks_url":"https://api.github.com/repos/crnk-project/crnk-framework/forks","keys_url":"https://api.github.com/repos/crnk-project/crnk-framework/keys{/key_id}","collaborators_url":"https://api.github.com/repos/crnk-project/crnk-framework/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/crnk-project/crnk-framework/teams","hooks_url":"https://api.github.com/repos/crnk-project/crnk-framework/hooks","issue_events_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues/events{/number}","events_url":"https://api.github.com/repos/crnk-project/crnk-framework/events","assignees_url":"https://api.github.com/repos/crnk-project/crnk-framework/assignees{/user}","branches_url":"https://api.github.com/repos/crnk-project/crnk-framework/branches{/branch}","tags_url":"https://api.github.com/repos/crnk-project/crnk-framework/tags","blobs_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/refs{/sha}","trees_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/trees{/sha}","statuses_url":"https://api.github.com/repos/crnk-project/crnk-framework/statuses/{sha}","languages_url":"https://api.github.com/repos/crnk-project/crnk-framework/languages","stargazers_url":"https://api.github.com/repos/crnk-project/crnk-framework/stargazers","contributors_url":"https://api.github.com/repos/crnk-project/crnk-framework/contributors","subscribers_url":"https://api.github.com/repos/crnk-project/crnk-framework/subscribers","subscription_url":"https://api.github.com/repos/crnk-project/crnk-framework/subscription","commits_url":"https://api.github.com/repos/crnk-project/crnk-framework/commits{/sha}","git_commits_url":"https://api.github.com/repos/crnk-project/crnk-framework/git/commits{/sha}","comments_url":"https://api.github.com/repos/crnk-project/crnk-framework/comments{/number}","issue_comment_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues/comments{/number}","contents_url":"https://api.github.com/repos/crnk-project/crnk-framework/contents/{+path}","compare_url":"https://api.github.com/repos/crnk-project/crnk-framework/compare/{base}...{head}","merges_url":"https://api.github.com/repos/crnk-project/crnk-framework/merges","archive_url":"https://api.github.com/repos/crnk-project/crnk-framework/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/crnk-project/crnk-framework/downloads","issues_url":"https://api.github.com/repos/crnk-project/crnk-framework/issues{/number}","pulls_url":"https://api.github.com/repos/crnk-project/crnk-framework/pulls{/number}","milestones_url":"https://api.github.com/repos/crnk-project/crnk-framework/milestones{/number}","notifications_url":"https://api.github.com/repos/crnk-project/crnk-framework/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/crnk-project/crnk-framework/labels{/name}","releases_url":"https://api.github.com/repos/crnk-project/crnk-framework/releases{/id}","deployments_url":"https://api.github.com/repos/crnk-project/crnk-framework/deployments","created_at":"2017-05-18T11:06:31Z","updated_at":"2018-02-22T18:40:43Z","pushed_at":"2018-02-22T18:24:18Z","git_url":"git://github.com/crnk-project/crnk-framework.git","ssh_url":"git@github.com:crnk-project/crnk-framework.git","clone_url":"https://github.com/crnk-project/crnk-framework.git","svn_url":"https://github.com/crnk-project/crnk-framework","homepage":"","size":3204,"stargazers_count":53,"watchers_count":53,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":15,"mirror_url":null,"archived":false,"open_issues_count":38,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":15,"open_issues":38,"watchers":53,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/232"},"html":{"href":"https://github.com/crnk-project/crnk-framework/pull/232"},"issue":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/issues/232"},"comments":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/issues/232/comments"},"review_comments":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/232/comments"},"review_comment":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/pulls/232/commits"},"statuses":{"href":"https://api.github.com/repos/crnk-project/crnk-framework/statuses/7b58356c2b55f1adb9ab0db83e5ffd3ffb2e6540"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"remmeier"}}