{"action":"created","issue":{"url":"https://api.github.com/repos/atularen/ngx-monaco-editor/issues/79","repository_url":"https://api.github.com/repos/atularen/ngx-monaco-editor","labels_url":"https://api.github.com/repos/atularen/ngx-monaco-editor/issues/79/labels{/name}","comments_url":"https://api.github.com/repos/atularen/ngx-monaco-editor/issues/79/comments","events_url":"https://api.github.com/repos/atularen/ngx-monaco-editor/issues/79/events","html_url":"https://github.com/atularen/ngx-monaco-editor/issues/79","id":370728433,"node_id":"MDU6SXNzdWUzNzA3Mjg0MzM=","number":79,"title":"ngx-monaco-editor not working with angular 6.1","user":{"login":"lesv","id":1136014,"node_id":"MDQ6VXNlcjExMzYwMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1136014?v=4","gravatar_id":"","url":"https://api.github.com/users/lesv","html_url":"https://github.com/lesv","followers_url":"https://api.github.com/users/lesv/followers","following_url":"https://api.github.com/users/lesv/following{/other_user}","gists_url":"https://api.github.com/users/lesv/gists{/gist_id}","starred_url":"https://api.github.com/users/lesv/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lesv/subscriptions","organizations_url":"https://api.github.com/users/lesv/orgs","repos_url":"https://api.github.com/users/lesv/repos","events_url":"https://api.github.com/users/lesv/events{/privacy}","received_events_url":"https://api.github.com/users/lesv/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":3,"created_at":"2018-10-16T17:53:19Z","updated_at":"2018-10-16T22:45:13Z","closed_at":null,"author_association":"NONE","body":"I've downloaded the sample you posted in #56 and it works.  I've been using that to update my try and am finding the major difference is 6.1. (I'll update the issue once I gather more info.)\r\n\r\nLooking at [this](https://update.angular.io/) suggests:\r\n\r\n- [ ] Switch from HttpModule and the Http service to HttpClientModule and the HttpClient service. HttpClient simplifies the default ergonomics (You don't need to map to json anymore) and now supports typed return values and interceptors. Read more on angular.io\r\n\r\n\r\n- [ ] Remove deprecated RxJS 6 features using rxjs-tslint auto update rules\r\n\r\nFor most applications this will mean running the following two commands:\r\n```\r\nnpm install -g rxjs-tslint\r\nrxjs-5-to-6-migrate -p src/tsconfig.app.json\r\n```\r\n\r\n- [ ] Once you and all of your dependencies have updated to RxJS 6, remove rxjs-compat.\r\n\r\n### During the Update\r\nThere aren't currently any recommendations for moving between these versions.\r\n\r\n### After the Update\r\n\r\n- [ ] If you use the Angular Service worker, migrate any versionedFiles to the files array. The behavior is the same."},"comment":{"url":"https://api.github.com/repos/atularen/ngx-monaco-editor/issues/comments/430427294","html_url":"https://github.com/atularen/ngx-monaco-editor/issues/79#issuecomment-430427294","issue_url":"https://api.github.com/repos/atularen/ngx-monaco-editor/issues/79","id":430427294,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMDQyNzI5NA==","user":{"login":"dannymcgee","id":13191586,"node_id":"MDQ6VXNlcjEzMTkxNTg2","avatar_url":"https://avatars3.githubusercontent.com/u/13191586?v=4","gravatar_id":"","url":"https://api.github.com/users/dannymcgee","html_url":"https://github.com/dannymcgee","followers_url":"https://api.github.com/users/dannymcgee/followers","following_url":"https://api.github.com/users/dannymcgee/following{/other_user}","gists_url":"https://api.github.com/users/dannymcgee/gists{/gist_id}","starred_url":"https://api.github.com/users/dannymcgee/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dannymcgee/subscriptions","organizations_url":"https://api.github.com/users/dannymcgee/orgs","repos_url":"https://api.github.com/users/dannymcgee/repos","events_url":"https://api.github.com/users/dannymcgee/events{/privacy}","received_events_url":"https://api.github.com/users/dannymcgee/received_events","type":"User","site_admin":false},"created_at":"2018-10-16T22:45:13Z","updated_at":"2018-10-16T22:45:13Z","author_association":"NONE","body":"Whoops, issues are open now. \r\n\r\nYeah, I didn't publish to NPM or anything so you'll need to clone the repo and build it. I should probably edit the Readme to reflect that. Honestly, I've already switched over to CodeMirror for my particular project because I found it suits my needs better, otherwise I might consider publishing it as a package under a new name."}}
{"actor":{"display_login":"dannymcgee"}}