{"action":"created","comment":{"url":"https://api.github.com/repos/salesforce/refocus/pulls/comments/175873180","pull_request_review_id":105476795,"id":175873180,"diff_hunk":"@@ -137,8 +137,11 @@ function cleanAddAspectToSample(sampleObj, aspectObj) {\n     constants.fieldsToStringify.sample);\n   const aspect = sampleStore.arrayObjsStringsToJson(aspectObj,\n     constants.fieldsToStringify.aspect);\n-  modelUtils.cleanQueryBodyObj(aspect, embeddedAspectFields);\n-  sampleStore.convertAspectStrings(aspect);\n+  if (aspect) {\n+    modelUtils.cleanQueryBodyObj(aspect, embeddedAspectFields);\n+    sampleStore.convertAspectStrings(aspect);\n+  }\n+\n   sampleRes.aspect = aspect;","path":"cache/models/samples.js","position":11,"original_position":11,"commit_id":"c44cde3b3e8e89988fc6a41bb48af599e5dbbc9c","original_commit_id":"c44cde3b3e8e89988fc6a41bb48af599e5dbbc9c","user":{"login":"jgraff2","id":22939895,"avatar_url":"https://avatars1.githubusercontent.com/u/22939895?v=4","gravatar_id":"","url":"https://api.github.com/users/jgraff2","html_url":"https://github.com/jgraff2","followers_url":"https://api.github.com/users/jgraff2/followers","following_url":"https://api.github.com/users/jgraff2/following{/other_user}","gists_url":"https://api.github.com/users/jgraff2/gists{/gist_id}","starred_url":"https://api.github.com/users/jgraff2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgraff2/subscriptions","organizations_url":"https://api.github.com/users/jgraff2/orgs","repos_url":"https://api.github.com/users/jgraff2/repos","events_url":"https://api.github.com/users/jgraff2/events{/privacy}","received_events_url":"https://api.github.com/users/jgraff2/received_events","type":"User","site_admin":false},"body":"Oh ok, I didn't read that closely enough. Makes sense, I will change it.","created_at":"2018-03-20T18:17:10Z","updated_at":"2018-03-20T18:17:10Z","html_url":"https://github.com/salesforce/refocus/pull/757#discussion_r175873180","pull_request_url":"https://api.github.com/repos/salesforce/refocus/pulls/757","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/salesforce/refocus/pulls/comments/175873180"},"html":{"href":"https://github.com/salesforce/refocus/pull/757#discussion_r175873180"},"pull_request":{"href":"https://api.github.com/repos/salesforce/refocus/pulls/757"}},"in_reply_to_id":175624306},"pull_request":{"url":"https://api.github.com/repos/salesforce/refocus/pulls/757","id":176053559,"html_url":"https://github.com/salesforce/refocus/pull/757","diff_url":"https://github.com/salesforce/refocus/pull/757.diff","patch_url":"https://github.com/salesforce/refocus/pull/757.patch","issue_url":"https://api.github.com/repos/salesforce/refocus/issues/757","number":757,"state":"closed","locked":false,"title":"Don't cause error when sample has no aspect.","user":{"login":"jgraff2","id":22939895,"avatar_url":"https://avatars1.githubusercontent.com/u/22939895?v=4","gravatar_id":"","url":"https://api.github.com/users/jgraff2","html_url":"https://github.com/jgraff2","followers_url":"https://api.github.com/users/jgraff2/followers","following_url":"https://api.github.com/users/jgraff2/following{/other_user}","gists_url":"https://api.github.com/users/jgraff2/gists{/gist_id}","starred_url":"https://api.github.com/users/jgraff2/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jgraff2/subscriptions","organizations_url":"https://api.github.com/users/jgraff2/orgs","repos_url":"https://api.github.com/users/jgraff2/repos","events_url":"https://api.github.com/users/jgraff2/events{/privacy}","received_events_url":"https://api.github.com/users/jgraff2/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-19T23:36:34Z","updated_at":"2018-03-20T18:17:10Z","closed_at":"2018-03-20T18:13:34Z","merged_at":"2018-03-20T18:13:34Z","merge_commit_sha":"b9f0645d1bf415cd76ee24ee8812d7393d3f5ec0","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/salesforce/refocus/pulls/757/commits","review_comments_url":"https://api.github.com/repos/salesforce/refocus/pulls/757/comments","review_comment_url":"https://api.github.com/repos/salesforce/refocus/pulls/comments{/number}","comments_url":"https://api.github.com/repos/salesforce/refocus/issues/757/comments","statuses_url":"https://api.github.com/repos/salesforce/refocus/statuses/c44cde3b3e8e89988fc6a41bb48af599e5dbbc9c","head":{"label":"salesforce:missing-aspect-error","ref":"missing-aspect-error","sha":"c44cde3b3e8e89988fc6a41bb48af599e5dbbc9c","user":{"login":"salesforce","id":453694,"avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"repo":{"id":64511432,"name":"refocus","full_name":"salesforce/refocus","owner":{"login":"salesforce","id":453694,"avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesforce/refocus","description":"The Go-To Platform for Visualizing Service Health","fork":false,"url":"https://api.github.com/repos/salesforce/refocus","forks_url":"https://api.github.com/repos/salesforce/refocus/forks","keys_url":"https://api.github.com/repos/salesforce/refocus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesforce/refocus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesforce/refocus/teams","hooks_url":"https://api.github.com/repos/salesforce/refocus/hooks","issue_events_url":"https://api.github.com/repos/salesforce/refocus/issues/events{/number}","events_url":"https://api.github.com/repos/salesforce/refocus/events","assignees_url":"https://api.github.com/repos/salesforce/refocus/assignees{/user}","branches_url":"https://api.github.com/repos/salesforce/refocus/branches{/branch}","tags_url":"https://api.github.com/repos/salesforce/refocus/tags","blobs_url":"https://api.github.com/repos/salesforce/refocus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesforce/refocus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesforce/refocus/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesforce/refocus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesforce/refocus/statuses/{sha}","languages_url":"https://api.github.com/repos/salesforce/refocus/languages","stargazers_url":"https://api.github.com/repos/salesforce/refocus/stargazers","contributors_url":"https://api.github.com/repos/salesforce/refocus/contributors","subscribers_url":"https://api.github.com/repos/salesforce/refocus/subscribers","subscription_url":"https://api.github.com/repos/salesforce/refocus/subscription","commits_url":"https://api.github.com/repos/salesforce/refocus/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesforce/refocus/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesforce/refocus/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesforce/refocus/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesforce/refocus/contents/{+path}","compare_url":"https://api.github.com/repos/salesforce/refocus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesforce/refocus/merges","archive_url":"https://api.github.com/repos/salesforce/refocus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesforce/refocus/downloads","issues_url":"https://api.github.com/repos/salesforce/refocus/issues{/number}","pulls_url":"https://api.github.com/repos/salesforce/refocus/pulls{/number}","milestones_url":"https://api.github.com/repos/salesforce/refocus/milestones{/number}","notifications_url":"https://api.github.com/repos/salesforce/refocus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesforce/refocus/labels{/name}","releases_url":"https://api.github.com/repos/salesforce/refocus/releases{/id}","deployments_url":"https://api.github.com/repos/salesforce/refocus/deployments","created_at":"2016-07-29T21:27:40Z","updated_at":"2018-03-20T18:13:37Z","pushed_at":"2018-03-20T18:13:40Z","git_url":"git://github.com/salesforce/refocus.git","ssh_url":"git@github.com:salesforce/refocus.git","clone_url":"https://github.com/salesforce/refocus.git","svn_url":"https://github.com/salesforce/refocus","homepage":"https://salesforce.github.io/refocus/docs/01-quickstart.html","size":9703,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":19,"open_issues":16,"watchers":61,"default_branch":"master"}},"base":{"label":"salesforce:master","ref":"master","sha":"f5940ed0bd637af478f587632de35826423a262b","user":{"login":"salesforce","id":453694,"avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"repo":{"id":64511432,"name":"refocus","full_name":"salesforce/refocus","owner":{"login":"salesforce","id":453694,"avatar_url":"https://avatars3.githubusercontent.com/u/453694?v=4","gravatar_id":"","url":"https://api.github.com/users/salesforce","html_url":"https://github.com/salesforce","followers_url":"https://api.github.com/users/salesforce/followers","following_url":"https://api.github.com/users/salesforce/following{/other_user}","gists_url":"https://api.github.com/users/salesforce/gists{/gist_id}","starred_url":"https://api.github.com/users/salesforce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/salesforce/subscriptions","organizations_url":"https://api.github.com/users/salesforce/orgs","repos_url":"https://api.github.com/users/salesforce/repos","events_url":"https://api.github.com/users/salesforce/events{/privacy}","received_events_url":"https://api.github.com/users/salesforce/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/salesforce/refocus","description":"The Go-To Platform for Visualizing Service Health","fork":false,"url":"https://api.github.com/repos/salesforce/refocus","forks_url":"https://api.github.com/repos/salesforce/refocus/forks","keys_url":"https://api.github.com/repos/salesforce/refocus/keys{/key_id}","collaborators_url":"https://api.github.com/repos/salesforce/refocus/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/salesforce/refocus/teams","hooks_url":"https://api.github.com/repos/salesforce/refocus/hooks","issue_events_url":"https://api.github.com/repos/salesforce/refocus/issues/events{/number}","events_url":"https://api.github.com/repos/salesforce/refocus/events","assignees_url":"https://api.github.com/repos/salesforce/refocus/assignees{/user}","branches_url":"https://api.github.com/repos/salesforce/refocus/branches{/branch}","tags_url":"https://api.github.com/repos/salesforce/refocus/tags","blobs_url":"https://api.github.com/repos/salesforce/refocus/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/salesforce/refocus/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/salesforce/refocus/git/refs{/sha}","trees_url":"https://api.github.com/repos/salesforce/refocus/git/trees{/sha}","statuses_url":"https://api.github.com/repos/salesforce/refocus/statuses/{sha}","languages_url":"https://api.github.com/repos/salesforce/refocus/languages","stargazers_url":"https://api.github.com/repos/salesforce/refocus/stargazers","contributors_url":"https://api.github.com/repos/salesforce/refocus/contributors","subscribers_url":"https://api.github.com/repos/salesforce/refocus/subscribers","subscription_url":"https://api.github.com/repos/salesforce/refocus/subscription","commits_url":"https://api.github.com/repos/salesforce/refocus/commits{/sha}","git_commits_url":"https://api.github.com/repos/salesforce/refocus/git/commits{/sha}","comments_url":"https://api.github.com/repos/salesforce/refocus/comments{/number}","issue_comment_url":"https://api.github.com/repos/salesforce/refocus/issues/comments{/number}","contents_url":"https://api.github.com/repos/salesforce/refocus/contents/{+path}","compare_url":"https://api.github.com/repos/salesforce/refocus/compare/{base}...{head}","merges_url":"https://api.github.com/repos/salesforce/refocus/merges","archive_url":"https://api.github.com/repos/salesforce/refocus/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/salesforce/refocus/downloads","issues_url":"https://api.github.com/repos/salesforce/refocus/issues{/number}","pulls_url":"https://api.github.com/repos/salesforce/refocus/pulls{/number}","milestones_url":"https://api.github.com/repos/salesforce/refocus/milestones{/number}","notifications_url":"https://api.github.com/repos/salesforce/refocus/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/salesforce/refocus/labels{/name}","releases_url":"https://api.github.com/repos/salesforce/refocus/releases{/id}","deployments_url":"https://api.github.com/repos/salesforce/refocus/deployments","created_at":"2016-07-29T21:27:40Z","updated_at":"2018-03-20T18:13:37Z","pushed_at":"2018-03-20T18:13:40Z","git_url":"git://github.com/salesforce/refocus.git","ssh_url":"git@github.com:salesforce/refocus.git","clone_url":"https://github.com/salesforce/refocus.git","svn_url":"https://github.com/salesforce/refocus","homepage":"https://salesforce.github.io/refocus/docs/01-quickstart.html","size":9703,"stargazers_count":61,"watchers_count":61,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":16,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":19,"open_issues":16,"watchers":61,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/salesforce/refocus/pulls/757"},"html":{"href":"https://github.com/salesforce/refocus/pull/757"},"issue":{"href":"https://api.github.com/repos/salesforce/refocus/issues/757"},"comments":{"href":"https://api.github.com/repos/salesforce/refocus/issues/757/comments"},"review_comments":{"href":"https://api.github.com/repos/salesforce/refocus/pulls/757/comments"},"review_comment":{"href":"https://api.github.com/repos/salesforce/refocus/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/salesforce/refocus/pulls/757/commits"},"statuses":{"href":"https://api.github.com/repos/salesforce/refocus/statuses/c44cde3b3e8e89988fc6a41bb48af599e5dbbc9c"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"jgraff2"}}