{"action":"created","comment":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/185454383","pull_request_review_id":116843310,"id":185454383,"diff_hunk":"@@ -16,9 +16,22 @@\n \n #include <map>\n \n+// NOTE:\n+// YOU ARE NOT OBLIGED TO USE THESE MACROS\n+// If you're writing something more specialized, please don't try to make them\n+// work for your case, but just write something new instead.\n+\n namespace at {\n namespace native {\n \n+Tensor& fill_(Tensor& self, Scalar value) {\n+  return self._fill_(value);\n+}\n+\n+Tensor& fill_(Tensor& self, const Tensor& value) {\n+  return self._fill_(value);\n+}","path":"aten/src/ATen/native/UnaryOps.cpp","position":18,"original_position":18,"commit_id":"dba6e9392829d3dc222af16c302a06f39b7a9e77","original_commit_id":"dba6e9392829d3dc222af16c302a06f39b7a9e77","user":{"login":"apaszke","id":4583066,"avatar_url":"https://avatars3.githubusercontent.com/u/4583066?v=4","gravatar_id":"","url":"https://api.github.com/users/apaszke","html_url":"https://github.com/apaszke","followers_url":"https://api.github.com/users/apaszke/followers","following_url":"https://api.github.com/users/apaszke/following{/other_user}","gists_url":"https://api.github.com/users/apaszke/gists{/gist_id}","starred_url":"https://api.github.com/users/apaszke/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apaszke/subscriptions","organizations_url":"https://api.github.com/users/apaszke/orgs","repos_url":"https://api.github.com/users/apaszke/repos","events_url":"https://api.github.com/users/apaszke/events{/privacy}","received_events_url":"https://api.github.com/users/apaszke/received_events","type":"User","site_admin":false},"body":"Lol why can't we leave `fill_` as it was then?","created_at":"2018-05-02T10:31:59Z","updated_at":"2018-05-02T10:35:32Z","html_url":"https://github.com/pytorch/pytorch/pull/6725#discussion_r185454383","pull_request_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6725","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments/185454383"},"html":{"href":"https://github.com/pytorch/pytorch/pull/6725#discussion_r185454383"},"pull_request":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6725"}}},"pull_request":{"url":"https://api.github.com/repos/pytorch/pytorch/pulls/6725","id":182592649,"html_url":"https://github.com/pytorch/pytorch/pull/6725","diff_url":"https://github.com/pytorch/pytorch/pull/6725.diff","patch_url":"https://github.com/pytorch/pytorch/pull/6725.patch","issue_url":"https://api.github.com/repos/pytorch/pytorch/issues/6725","number":6725,"state":"open","locked":false,"title":"Add SLEEF for libm float and double","user":{"login":"cpuhrsch","id":1716488,"avatar_url":"https://avatars1.githubusercontent.com/u/1716488?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuhrsch","html_url":"https://github.com/cpuhrsch","followers_url":"https://api.github.com/users/cpuhrsch/followers","following_url":"https://api.github.com/users/cpuhrsch/following{/other_user}","gists_url":"https://api.github.com/users/cpuhrsch/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuhrsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuhrsch/subscriptions","organizations_url":"https://api.github.com/users/cpuhrsch/orgs","repos_url":"https://api.github.com/users/cpuhrsch/repos","events_url":"https://api.github.com/users/cpuhrsch/events{/privacy}","received_events_url":"https://api.github.com/users/cpuhrsch/received_events","type":"User","site_admin":false},"body":"Speeds up vectorized operations on contiguous tensors while preserving the ULP [required by libc's math library](https://www.gnu.org/software/libc/manual/html_node/Errors-in-Math-Functions.html).\r\n\r\nIn particular, the \"_u10\" part of the function means that it has a ULP of 1.0. \r\n\r\nThis library comes with different [valid ranges](http://sleef.org/purec.xhtml). For example sinf has a valid range of [-5e+9, 5e+9]. This needs to be accounted for manually (work in progress).\r\n\r\nEDIT: It was decided that we'll add a flag to functions where the corresponding vectorized implementation does not cover the entire range of floating pointer values and will disable them by default.","created_at":"2018-04-18T20:23:54Z","updated_at":"2018-05-02T10:35:32Z","closed_at":null,"merged_at":null,"merge_commit_sha":"037dbb6b095f5565b474e0fb9b6e7518d5217610","assignee":null,"assignees":[],"requested_reviewers":[{"login":"zdevito","id":370202,"avatar_url":"https://avatars0.githubusercontent.com/u/370202?v=4","gravatar_id":"","url":"https://api.github.com/users/zdevito","html_url":"https://github.com/zdevito","followers_url":"https://api.github.com/users/zdevito/followers","following_url":"https://api.github.com/users/zdevito/following{/other_user}","gists_url":"https://api.github.com/users/zdevito/gists{/gist_id}","starred_url":"https://api.github.com/users/zdevito/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zdevito/subscriptions","organizations_url":"https://api.github.com/users/zdevito/orgs","repos_url":"https://api.github.com/users/zdevito/repos","events_url":"https://api.github.com/users/zdevito/events{/privacy}","received_events_url":"https://api.github.com/users/zdevito/received_events","type":"User","site_admin":false},{"login":"colesbury","id":655866,"avatar_url":"https://avatars1.githubusercontent.com/u/655866?v=4","gravatar_id":"","url":"https://api.github.com/users/colesbury","html_url":"https://github.com/colesbury","followers_url":"https://api.github.com/users/colesbury/followers","following_url":"https://api.github.com/users/colesbury/following{/other_user}","gists_url":"https://api.github.com/users/colesbury/gists{/gist_id}","starred_url":"https://api.github.com/users/colesbury/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/colesbury/subscriptions","organizations_url":"https://api.github.com/users/colesbury/orgs","repos_url":"https://api.github.com/users/colesbury/repos","events_url":"https://api.github.com/users/colesbury/events{/privacy}","received_events_url":"https://api.github.com/users/colesbury/received_events","type":"User","site_admin":false},{"login":"soumith","id":1310570,"avatar_url":"https://avatars0.githubusercontent.com/u/1310570?v=4","gravatar_id":"","url":"https://api.github.com/users/soumith","html_url":"https://github.com/soumith","followers_url":"https://api.github.com/users/soumith/followers","following_url":"https://api.github.com/users/soumith/following{/other_user}","gists_url":"https://api.github.com/users/soumith/gists{/gist_id}","starred_url":"https://api.github.com/users/soumith/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/soumith/subscriptions","organizations_url":"https://api.github.com/users/soumith/orgs","repos_url":"https://api.github.com/users/soumith/repos","events_url":"https://api.github.com/users/soumith/events{/privacy}","received_events_url":"https://api.github.com/users/soumith/received_events","type":"User","site_admin":false},{"login":"gchanan","id":3768583,"avatar_url":"https://avatars2.githubusercontent.com/u/3768583?v=4","gravatar_id":"","url":"https://api.github.com/users/gchanan","html_url":"https://github.com/gchanan","followers_url":"https://api.github.com/users/gchanan/followers","following_url":"https://api.github.com/users/gchanan/following{/other_user}","gists_url":"https://api.github.com/users/gchanan/gists{/gist_id}","starred_url":"https://api.github.com/users/gchanan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gchanan/subscriptions","organizations_url":"https://api.github.com/users/gchanan/orgs","repos_url":"https://api.github.com/users/gchanan/repos","events_url":"https://api.github.com/users/gchanan/events{/privacy}","received_events_url":"https://api.github.com/users/gchanan/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6725/commits","review_comments_url":"https://api.github.com/repos/pytorch/pytorch/pulls/6725/comments","review_comment_url":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}","comments_url":"https://api.github.com/repos/pytorch/pytorch/issues/6725/comments","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/dba6e9392829d3dc222af16c302a06f39b7a9e77","head":{"label":"cpuhrsch:sleef","ref":"sleef","sha":"dba6e9392829d3dc222af16c302a06f39b7a9e77","user":{"login":"cpuhrsch","id":1716488,"avatar_url":"https://avatars1.githubusercontent.com/u/1716488?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuhrsch","html_url":"https://github.com/cpuhrsch","followers_url":"https://api.github.com/users/cpuhrsch/followers","following_url":"https://api.github.com/users/cpuhrsch/following{/other_user}","gists_url":"https://api.github.com/users/cpuhrsch/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuhrsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuhrsch/subscriptions","organizations_url":"https://api.github.com/users/cpuhrsch/orgs","repos_url":"https://api.github.com/users/cpuhrsch/repos","events_url":"https://api.github.com/users/cpuhrsch/events{/privacy}","received_events_url":"https://api.github.com/users/cpuhrsch/received_events","type":"User","site_admin":false},"repo":{"id":118517346,"name":"pytorch","full_name":"cpuhrsch/pytorch","owner":{"login":"cpuhrsch","id":1716488,"avatar_url":"https://avatars1.githubusercontent.com/u/1716488?v=4","gravatar_id":"","url":"https://api.github.com/users/cpuhrsch","html_url":"https://github.com/cpuhrsch","followers_url":"https://api.github.com/users/cpuhrsch/followers","following_url":"https://api.github.com/users/cpuhrsch/following{/other_user}","gists_url":"https://api.github.com/users/cpuhrsch/gists{/gist_id}","starred_url":"https://api.github.com/users/cpuhrsch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cpuhrsch/subscriptions","organizations_url":"https://api.github.com/users/cpuhrsch/orgs","repos_url":"https://api.github.com/users/cpuhrsch/repos","events_url":"https://api.github.com/users/cpuhrsch/events{/privacy}","received_events_url":"https://api.github.com/users/cpuhrsch/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/cpuhrsch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":true,"url":"https://api.github.com/repos/cpuhrsch/pytorch","forks_url":"https://api.github.com/repos/cpuhrsch/pytorch/forks","keys_url":"https://api.github.com/repos/cpuhrsch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cpuhrsch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cpuhrsch/pytorch/teams","hooks_url":"https://api.github.com/repos/cpuhrsch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/cpuhrsch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/cpuhrsch/pytorch/events","assignees_url":"https://api.github.com/repos/cpuhrsch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/cpuhrsch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/cpuhrsch/pytorch/tags","blobs_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cpuhrsch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/cpuhrsch/pytorch/languages","stargazers_url":"https://api.github.com/repos/cpuhrsch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/cpuhrsch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/cpuhrsch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/cpuhrsch/pytorch/subscription","commits_url":"https://api.github.com/repos/cpuhrsch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/cpuhrsch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/cpuhrsch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/cpuhrsch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/cpuhrsch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/cpuhrsch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cpuhrsch/pytorch/merges","archive_url":"https://api.github.com/repos/cpuhrsch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cpuhrsch/pytorch/downloads","issues_url":"https://api.github.com/repos/cpuhrsch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/cpuhrsch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/cpuhrsch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/cpuhrsch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cpuhrsch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/cpuhrsch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/cpuhrsch/pytorch/deployments","created_at":"2018-01-22T21:26:11Z","updated_at":"2018-05-01T18:41:01Z","pushed_at":"2018-05-02T04:07:15Z","git_url":"git://github.com/cpuhrsch/pytorch.git","ssh_url":"git@github.com:cpuhrsch/pytorch.git","clone_url":"https://github.com/cpuhrsch/pytorch.git","svn_url":"https://github.com/cpuhrsch/pytorch","homepage":"http://pytorch.org","size":51809,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"pytorch:master","ref":"master","sha":"967c4a0c18dc6a18efc1afbe3f0afbca2cf496a3","user":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"repo":{"id":65600975,"name":"pytorch","full_name":"pytorch/pytorch","owner":{"login":"pytorch","id":21003710,"avatar_url":"https://avatars3.githubusercontent.com/u/21003710?v=4","gravatar_id":"","url":"https://api.github.com/users/pytorch","html_url":"https://github.com/pytorch","followers_url":"https://api.github.com/users/pytorch/followers","following_url":"https://api.github.com/users/pytorch/following{/other_user}","gists_url":"https://api.github.com/users/pytorch/gists{/gist_id}","starred_url":"https://api.github.com/users/pytorch/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pytorch/subscriptions","organizations_url":"https://api.github.com/users/pytorch/orgs","repos_url":"https://api.github.com/users/pytorch/repos","events_url":"https://api.github.com/users/pytorch/events{/privacy}","received_events_url":"https://api.github.com/users/pytorch/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/pytorch/pytorch","description":"Tensors and Dynamic neural networks in Python  with strong GPU acceleration","fork":false,"url":"https://api.github.com/repos/pytorch/pytorch","forks_url":"https://api.github.com/repos/pytorch/pytorch/forks","keys_url":"https://api.github.com/repos/pytorch/pytorch/keys{/key_id}","collaborators_url":"https://api.github.com/repos/pytorch/pytorch/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/pytorch/pytorch/teams","hooks_url":"https://api.github.com/repos/pytorch/pytorch/hooks","issue_events_url":"https://api.github.com/repos/pytorch/pytorch/issues/events{/number}","events_url":"https://api.github.com/repos/pytorch/pytorch/events","assignees_url":"https://api.github.com/repos/pytorch/pytorch/assignees{/user}","branches_url":"https://api.github.com/repos/pytorch/pytorch/branches{/branch}","tags_url":"https://api.github.com/repos/pytorch/pytorch/tags","blobs_url":"https://api.github.com/repos/pytorch/pytorch/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/pytorch/pytorch/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/pytorch/pytorch/git/refs{/sha}","trees_url":"https://api.github.com/repos/pytorch/pytorch/git/trees{/sha}","statuses_url":"https://api.github.com/repos/pytorch/pytorch/statuses/{sha}","languages_url":"https://api.github.com/repos/pytorch/pytorch/languages","stargazers_url":"https://api.github.com/repos/pytorch/pytorch/stargazers","contributors_url":"https://api.github.com/repos/pytorch/pytorch/contributors","subscribers_url":"https://api.github.com/repos/pytorch/pytorch/subscribers","subscription_url":"https://api.github.com/repos/pytorch/pytorch/subscription","commits_url":"https://api.github.com/repos/pytorch/pytorch/commits{/sha}","git_commits_url":"https://api.github.com/repos/pytorch/pytorch/git/commits{/sha}","comments_url":"https://api.github.com/repos/pytorch/pytorch/comments{/number}","issue_comment_url":"https://api.github.com/repos/pytorch/pytorch/issues/comments{/number}","contents_url":"https://api.github.com/repos/pytorch/pytorch/contents/{+path}","compare_url":"https://api.github.com/repos/pytorch/pytorch/compare/{base}...{head}","merges_url":"https://api.github.com/repos/pytorch/pytorch/merges","archive_url":"https://api.github.com/repos/pytorch/pytorch/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/pytorch/pytorch/downloads","issues_url":"https://api.github.com/repos/pytorch/pytorch/issues{/number}","pulls_url":"https://api.github.com/repos/pytorch/pytorch/pulls{/number}","milestones_url":"https://api.github.com/repos/pytorch/pytorch/milestones{/number}","notifications_url":"https://api.github.com/repos/pytorch/pytorch/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/pytorch/pytorch/labels{/name}","releases_url":"https://api.github.com/repos/pytorch/pytorch/releases{/id}","deployments_url":"https://api.github.com/repos/pytorch/pytorch/deployments","created_at":"2016-08-13T05:26:41Z","updated_at":"2018-05-02T10:20:01Z","pushed_at":"2018-05-02T09:36:54Z","git_url":"git://github.com/pytorch/pytorch.git","ssh_url":"git@github.com:pytorch/pytorch.git","clone_url":"https://github.com/pytorch/pytorch.git","svn_url":"https://github.com/pytorch/pytorch","homepage":"http://pytorch.org","size":51900,"stargazers_count":14708,"watchers_count":14708,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3294,"mirror_url":null,"archived":false,"open_issues_count":983,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":3294,"open_issues":983,"watchers":14708,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6725"},"html":{"href":"https://github.com/pytorch/pytorch/pull/6725"},"issue":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/6725"},"comments":{"href":"https://api.github.com/repos/pytorch/pytorch/issues/6725/comments"},"review_comments":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6725/comments"},"review_comment":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/pytorch/pytorch/pulls/6725/commits"},"statuses":{"href":"https://api.github.com/repos/pytorch/pytorch/statuses/dba6e9392829d3dc222af16c302a06f39b7a9e77"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apaszke"}}