{"action":"created","comment":{"url":"https://api.github.com/repos/mercadopago/px-android/pulls/comments/195521776","pull_request_review_id":128908522,"id":195521776,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NTUyMTc3Ng==","diff_hunk":"@@ -201,7 +211,10 @@ public void trackModal(final OneTapModel model) {\n     }\n \n     @Override\n-    public void showCardFlow(@NonNull OneTapModel model, @NonNull final Card card) {\n+    public void showCardFlow(@NonNull final OneTapModel model, @NonNull final Card card) {\n+        if (callback != null) {\n+            callback.onOneTapConfirmCardFlow();\n+        }\n         new MercadoPagoComponents.Activities.CardVaultActivityBuilder()","path":"sdk/src/main/java/com/mercadopago/onetap/OneTapFragment.java","position":55,"original_position":55,"commit_id":"aae23f6e601863fe0e4d6ae3ab0f9735336861ce","original_commit_id":"aae23f6e601863fe0e4d6ae3ab0f9735336861ce","user":{"login":"zehemz","id":7827612,"node_id":"MDQ6VXNlcjc4Mjc2MTI=","avatar_url":"https://avatars0.githubusercontent.com/u/7827612?v=4","gravatar_id":"","url":"https://api.github.com/users/zehemz","html_url":"https://github.com/zehemz","followers_url":"https://api.github.com/users/zehemz/followers","following_url":"https://api.github.com/users/zehemz/following{/other_user}","gists_url":"https://api.github.com/users/zehemz/gists{/gist_id}","starred_url":"https://api.github.com/users/zehemz/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zehemz/subscriptions","organizations_url":"https://api.github.com/users/zehemz/orgs","repos_url":"https://api.github.com/users/zehemz/repos","events_url":"https://api.github.com/users/zehemz/events{/privacy}","received_events_url":"https://api.github.com/users/zehemz/received_events","type":"User","site_admin":false},"body":"La logica de render de onetap esta bien q este adentro, pero esto es más bien lógica de flow, está bien me parece que lo delegue al callback de onOneTapConfirmCardFlow(model, card)","created_at":"2018-06-14T18:13:07Z","updated_at":"2018-06-14T18:13:08Z","html_url":"https://github.com/mercadopago/px-android/pull/1084#discussion_r195521776","pull_request_url":"https://api.github.com/repos/mercadopago/px-android/pulls/1084","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/comments/195521776"},"html":{"href":"https://github.com/mercadopago/px-android/pull/1084#discussion_r195521776"},"pull_request":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/1084"}},"in_reply_to_id":195434028},"pull_request":{"url":"https://api.github.com/repos/mercadopago/px-android/pulls/1084","id":194720652,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk0NzIwNjUy","html_url":"https://github.com/mercadopago/px-android/pull/1084","diff_url":"https://github.com/mercadopago/px-android/pull/1084.diff","patch_url":"https://github.com/mercadopago/px-android/pull/1084.patch","issue_url":"https://api.github.com/repos/mercadopago/px-android/issues/1084","number":1084,"state":"open","locked":false,"title":"[Fix] One tap: Transitions in flow","user":{"login":"valeserber","id":5674142,"node_id":"MDQ6VXNlcjU2NzQxNDI=","avatar_url":"https://avatars3.githubusercontent.com/u/5674142?v=4","gravatar_id":"","url":"https://api.github.com/users/valeserber","html_url":"https://github.com/valeserber","followers_url":"https://api.github.com/users/valeserber/followers","following_url":"https://api.github.com/users/valeserber/following{/other_user}","gists_url":"https://api.github.com/users/valeserber/gists{/gist_id}","starred_url":"https://api.github.com/users/valeserber/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/valeserber/subscriptions","organizations_url":"https://api.github.com/users/valeserber/orgs","repos_url":"https://api.github.com/users/valeserber/repos","events_url":"https://api.github.com/users/valeserber/events{/privacy}","received_events_url":"https://api.github.com/users/valeserber/received_events","type":"User","site_admin":false},"body":"<!--- Escribir un resumen de los cambios en el Título de arriba -->\r\n\r\n## Motivación y Contexto\r\n<!--- ¿Por qué este cambio es requerido? ¿Qué problema resuelve? -->\r\nSe arreglan las transiciones en los flujos de one tap.\r\n\r\n[Video](https://drive.google.com/open?id=1g4APwPVd29tvghbe9zOtA9gYYYgF7_ez)","created_at":"2018-06-13T21:29:09Z","updated_at":"2018-06-14T18:13:08Z","closed_at":null,"merged_at":null,"merge_commit_sha":"d440caca7ca30eaa981ed48a0b453e79cf5aea3c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matiasromar","id":4195740,"node_id":"MDQ6VXNlcjQxOTU3NDA=","avatar_url":"https://avatars0.githubusercontent.com/u/4195740?v=4","gravatar_id":"","url":"https://api.github.com/users/matiasromar","html_url":"https://github.com/matiasromar","followers_url":"https://api.github.com/users/matiasromar/followers","following_url":"https://api.github.com/users/matiasromar/following{/other_user}","gists_url":"https://api.github.com/users/matiasromar/gists{/gist_id}","starred_url":"https://api.github.com/users/matiasromar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matiasromar/subscriptions","organizations_url":"https://api.github.com/users/matiasromar/orgs","repos_url":"https://api.github.com/users/matiasromar/repos","events_url":"https://api.github.com/users/matiasromar/events{/privacy}","received_events_url":"https://api.github.com/users/matiasromar/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/mercadopago/px-android/pulls/1084/commits","review_comments_url":"https://api.github.com/repos/mercadopago/px-android/pulls/1084/comments","review_comment_url":"https://api.github.com/repos/mercadopago/px-android/pulls/comments{/number}","comments_url":"https://api.github.com/repos/mercadopago/px-android/issues/1084/comments","statuses_url":"https://api.github.com/repos/mercadopago/px-android/statuses/aae23f6e601863fe0e4d6ae3ab0f9735336861ce","head":{"label":"mercadopago:fix/onetap_transition","ref":"fix/onetap_transition","sha":"aae23f6e601863fe0e4d6ae3ab0f9735336861ce","user":{"login":"mercadopago","id":900583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMDU4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"repo":{"id":49529486,"node_id":"MDEwOlJlcG9zaXRvcnk0OTUyOTQ4Ng==","name":"px-android","full_name":"mercadopago/px-android","owner":{"login":"mercadopago","id":900583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMDU4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mercadopago/px-android","description":"MercadoPago SDK Android","fork":false,"url":"https://api.github.com/repos/mercadopago/px-android","forks_url":"https://api.github.com/repos/mercadopago/px-android/forks","keys_url":"https://api.github.com/repos/mercadopago/px-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mercadopago/px-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mercadopago/px-android/teams","hooks_url":"https://api.github.com/repos/mercadopago/px-android/hooks","issue_events_url":"https://api.github.com/repos/mercadopago/px-android/issues/events{/number}","events_url":"https://api.github.com/repos/mercadopago/px-android/events","assignees_url":"https://api.github.com/repos/mercadopago/px-android/assignees{/user}","branches_url":"https://api.github.com/repos/mercadopago/px-android/branches{/branch}","tags_url":"https://api.github.com/repos/mercadopago/px-android/tags","blobs_url":"https://api.github.com/repos/mercadopago/px-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mercadopago/px-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mercadopago/px-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mercadopago/px-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mercadopago/px-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mercadopago/px-android/languages","stargazers_url":"https://api.github.com/repos/mercadopago/px-android/stargazers","contributors_url":"https://api.github.com/repos/mercadopago/px-android/contributors","subscribers_url":"https://api.github.com/repos/mercadopago/px-android/subscribers","subscription_url":"https://api.github.com/repos/mercadopago/px-android/subscription","commits_url":"https://api.github.com/repos/mercadopago/px-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mercadopago/px-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mercadopago/px-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mercadopago/px-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mercadopago/px-android/contents/{+path}","compare_url":"https://api.github.com/repos/mercadopago/px-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mercadopago/px-android/merges","archive_url":"https://api.github.com/repos/mercadopago/px-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mercadopago/px-android/downloads","issues_url":"https://api.github.com/repos/mercadopago/px-android/issues{/number}","pulls_url":"https://api.github.com/repos/mercadopago/px-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mercadopago/px-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mercadopago/px-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mercadopago/px-android/labels{/name}","releases_url":"https://api.github.com/repos/mercadopago/px-android/releases{/id}","deployments_url":"https://api.github.com/repos/mercadopago/px-android/deployments","created_at":"2016-01-12T21:18:39Z","updated_at":"2018-06-04T03:16:55Z","pushed_at":"2018-06-14T13:20:50Z","git_url":"git://github.com/mercadopago/px-android.git","ssh_url":"git@github.com:mercadopago/px-android.git","clone_url":"https://github.com/mercadopago/px-android.git","svn_url":"https://github.com/mercadopago/px-android","homepage":"http://mercadopago.github.io/px-android","size":79262,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":25,"watchers":25,"default_branch":"master"}},"base":{"label":"mercadopago:develop","ref":"develop","sha":"5a88399307004aee59143eadf00014e988778b45","user":{"login":"mercadopago","id":900583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMDU4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"repo":{"id":49529486,"node_id":"MDEwOlJlcG9zaXRvcnk0OTUyOTQ4Ng==","name":"px-android","full_name":"mercadopago/px-android","owner":{"login":"mercadopago","id":900583,"node_id":"MDEyOk9yZ2FuaXphdGlvbjkwMDU4Mw==","avatar_url":"https://avatars3.githubusercontent.com/u/900583?v=4","gravatar_id":"","url":"https://api.github.com/users/mercadopago","html_url":"https://github.com/mercadopago","followers_url":"https://api.github.com/users/mercadopago/followers","following_url":"https://api.github.com/users/mercadopago/following{/other_user}","gists_url":"https://api.github.com/users/mercadopago/gists{/gist_id}","starred_url":"https://api.github.com/users/mercadopago/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mercadopago/subscriptions","organizations_url":"https://api.github.com/users/mercadopago/orgs","repos_url":"https://api.github.com/users/mercadopago/repos","events_url":"https://api.github.com/users/mercadopago/events{/privacy}","received_events_url":"https://api.github.com/users/mercadopago/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/mercadopago/px-android","description":"MercadoPago SDK Android","fork":false,"url":"https://api.github.com/repos/mercadopago/px-android","forks_url":"https://api.github.com/repos/mercadopago/px-android/forks","keys_url":"https://api.github.com/repos/mercadopago/px-android/keys{/key_id}","collaborators_url":"https://api.github.com/repos/mercadopago/px-android/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/mercadopago/px-android/teams","hooks_url":"https://api.github.com/repos/mercadopago/px-android/hooks","issue_events_url":"https://api.github.com/repos/mercadopago/px-android/issues/events{/number}","events_url":"https://api.github.com/repos/mercadopago/px-android/events","assignees_url":"https://api.github.com/repos/mercadopago/px-android/assignees{/user}","branches_url":"https://api.github.com/repos/mercadopago/px-android/branches{/branch}","tags_url":"https://api.github.com/repos/mercadopago/px-android/tags","blobs_url":"https://api.github.com/repos/mercadopago/px-android/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/mercadopago/px-android/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/mercadopago/px-android/git/refs{/sha}","trees_url":"https://api.github.com/repos/mercadopago/px-android/git/trees{/sha}","statuses_url":"https://api.github.com/repos/mercadopago/px-android/statuses/{sha}","languages_url":"https://api.github.com/repos/mercadopago/px-android/languages","stargazers_url":"https://api.github.com/repos/mercadopago/px-android/stargazers","contributors_url":"https://api.github.com/repos/mercadopago/px-android/contributors","subscribers_url":"https://api.github.com/repos/mercadopago/px-android/subscribers","subscription_url":"https://api.github.com/repos/mercadopago/px-android/subscription","commits_url":"https://api.github.com/repos/mercadopago/px-android/commits{/sha}","git_commits_url":"https://api.github.com/repos/mercadopago/px-android/git/commits{/sha}","comments_url":"https://api.github.com/repos/mercadopago/px-android/comments{/number}","issue_comment_url":"https://api.github.com/repos/mercadopago/px-android/issues/comments{/number}","contents_url":"https://api.github.com/repos/mercadopago/px-android/contents/{+path}","compare_url":"https://api.github.com/repos/mercadopago/px-android/compare/{base}...{head}","merges_url":"https://api.github.com/repos/mercadopago/px-android/merges","archive_url":"https://api.github.com/repos/mercadopago/px-android/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/mercadopago/px-android/downloads","issues_url":"https://api.github.com/repos/mercadopago/px-android/issues{/number}","pulls_url":"https://api.github.com/repos/mercadopago/px-android/pulls{/number}","milestones_url":"https://api.github.com/repos/mercadopago/px-android/milestones{/number}","notifications_url":"https://api.github.com/repos/mercadopago/px-android/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/mercadopago/px-android/labels{/name}","releases_url":"https://api.github.com/repos/mercadopago/px-android/releases{/id}","deployments_url":"https://api.github.com/repos/mercadopago/px-android/deployments","created_at":"2016-01-12T21:18:39Z","updated_at":"2018-06-04T03:16:55Z","pushed_at":"2018-06-14T13:20:50Z","git_url":"git://github.com/mercadopago/px-android.git","ssh_url":"git@github.com:mercadopago/px-android.git","clone_url":"https://github.com/mercadopago/px-android.git","svn_url":"https://github.com/mercadopago/px-android","homepage":"http://mercadopago.github.io/px-android","size":79262,"stargazers_count":25,"watchers_count":25,"language":"Java","has_issues":false,"has_projects":false,"has_downloads":true,"has_wiki":true,"has_pages":true,"forks_count":19,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":19,"open_issues":25,"watchers":25,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/1084"},"html":{"href":"https://github.com/mercadopago/px-android/pull/1084"},"issue":{"href":"https://api.github.com/repos/mercadopago/px-android/issues/1084"},"comments":{"href":"https://api.github.com/repos/mercadopago/px-android/issues/1084/comments"},"review_comments":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/1084/comments"},"review_comment":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/mercadopago/px-android/pulls/1084/commits"},"statuses":{"href":"https://api.github.com/repos/mercadopago/px-android/statuses/aae23f6e601863fe0e4d6ae3ab0f9735336861ce"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"zehemz"}}