{"action":"created","comment":{"url":"https://api.github.com/repos/lsst/obs_decam/pulls/comments/176451785","pull_request_review_id":106156096,"id":176451785,"diff_hunk":"@@ -33,16 +33,15 @@\n \n import lsst.pex.exceptions as pexExcept\n import lsst.daf.persistence as dafPersist\n-from lsst.obs.base import MakeRawVisitInfo\n from lsst.afw.image import RotType\n-from lsst.afw.coord import IcrsCoord, Coord\n-from lsst.afw.geom import degrees\n+from lsst.afw.geom import degrees, SpherePoint\n \n \n # Desired VisitInfo values for visit 229388, shared between test_getRaw.py and\n # test_getInstcal.py\n \n-boresightRaDec = IcrsCoord('02:51:16.790', '-00:00:05.699')\n+boresightRaDec = SpherePoint(42.81995833, -0.00158305, degrees)\n+# boresightRaDec = IcrsCoord('02:51:16.790', '-00:00:05.699')","path":"tests/test_getRaw.py","position":16,"original_position":16,"commit_id":"a287491f27d9ad23a51c2992dd224ca25cc8069e","original_commit_id":"a287491f27d9ad23a51c2992dd224ca25cc8069e","user":{"login":"rearmstr","id":1485496,"avatar_url":"https://avatars2.githubusercontent.com/u/1485496?v=4","gravatar_id":"","url":"https://api.github.com/users/rearmstr","html_url":"https://github.com/rearmstr","followers_url":"https://api.github.com/users/rearmstr/followers","following_url":"https://api.github.com/users/rearmstr/following{/other_user}","gists_url":"https://api.github.com/users/rearmstr/gists{/gist_id}","starred_url":"https://api.github.com/users/rearmstr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rearmstr/subscriptions","organizations_url":"https://api.github.com/users/rearmstr/orgs","repos_url":"https://api.github.com/users/rearmstr/repos","events_url":"https://api.github.com/users/rearmstr/events{/privacy}","received_events_url":"https://api.github.com/users/rearmstr/received_events","type":"User","site_admin":false},"body":"Why did you include this line?  If you want to preserve the coordinates I don't think it makes sense to put them in a IcrsCoord.","created_at":"2018-03-22T14:58:19Z","updated_at":"2018-03-22T14:58:19Z","html_url":"https://github.com/lsst/obs_decam/pull/78#discussion_r176451785","pull_request_url":"https://api.github.com/repos/lsst/obs_decam/pulls/78","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/lsst/obs_decam/pulls/comments/176451785"},"html":{"href":"https://github.com/lsst/obs_decam/pull/78#discussion_r176451785"},"pull_request":{"href":"https://api.github.com/repos/lsst/obs_decam/pulls/78"}}},"pull_request":{"url":"https://api.github.com/repos/lsst/obs_decam/pulls/78","id":175629442,"html_url":"https://github.com/lsst/obs_decam/pull/78","diff_url":"https://github.com/lsst/obs_decam/pull/78.diff","patch_url":"https://github.com/lsst/obs_decam/pull/78.patch","issue_url":"https://api.github.com/repos/lsst/obs_decam/issues/78","number":78,"state":"open","locked":false,"title":"DM-11162: Replace all use of Coord and subclasses with SpherePoint","user":{"login":"r-owen","id":874176,"avatar_url":"https://avatars0.githubusercontent.com/u/874176?v=4","gravatar_id":"","url":"https://api.github.com/users/r-owen","html_url":"https://github.com/r-owen","followers_url":"https://api.github.com/users/r-owen/followers","following_url":"https://api.github.com/users/r-owen/following{/other_user}","gists_url":"https://api.github.com/users/r-owen/gists{/gist_id}","starred_url":"https://api.github.com/users/r-owen/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/r-owen/subscriptions","organizations_url":"https://api.github.com/users/r-owen/orgs","repos_url":"https://api.github.com/users/r-owen/repos","events_url":"https://api.github.com/users/r-owen/events{/privacy}","received_events_url":"https://api.github.com/users/r-owen/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-03-16T19:46:02Z","updated_at":"2018-03-22T14:58:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f14911a7bbced723852b012294a839700ea4c6bf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/lsst/obs_decam/pulls/78/commits","review_comments_url":"https://api.github.com/repos/lsst/obs_decam/pulls/78/comments","review_comment_url":"https://api.github.com/repos/lsst/obs_decam/pulls/comments{/number}","comments_url":"https://api.github.com/repos/lsst/obs_decam/issues/78/comments","statuses_url":"https://api.github.com/repos/lsst/obs_decam/statuses/a287491f27d9ad23a51c2992dd224ca25cc8069e","head":{"label":"lsst:tickets/DM-11162","ref":"tickets/DM-11162","sha":"a287491f27d9ad23a51c2992dd224ca25cc8069e","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":32425715,"name":"obs_decam","full_name":"lsst/obs_decam","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/obs_decam","description":"Interface for DECam to the LSST stack.","fork":false,"url":"https://api.github.com/repos/lsst/obs_decam","forks_url":"https://api.github.com/repos/lsst/obs_decam/forks","keys_url":"https://api.github.com/repos/lsst/obs_decam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/obs_decam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/obs_decam/teams","hooks_url":"https://api.github.com/repos/lsst/obs_decam/hooks","issue_events_url":"https://api.github.com/repos/lsst/obs_decam/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/obs_decam/events","assignees_url":"https://api.github.com/repos/lsst/obs_decam/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/obs_decam/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/obs_decam/tags","blobs_url":"https://api.github.com/repos/lsst/obs_decam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/obs_decam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/obs_decam/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/obs_decam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/obs_decam/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/obs_decam/languages","stargazers_url":"https://api.github.com/repos/lsst/obs_decam/stargazers","contributors_url":"https://api.github.com/repos/lsst/obs_decam/contributors","subscribers_url":"https://api.github.com/repos/lsst/obs_decam/subscribers","subscription_url":"https://api.github.com/repos/lsst/obs_decam/subscription","commits_url":"https://api.github.com/repos/lsst/obs_decam/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/obs_decam/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/obs_decam/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/obs_decam/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/obs_decam/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/obs_decam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/obs_decam/merges","archive_url":"https://api.github.com/repos/lsst/obs_decam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/obs_decam/downloads","issues_url":"https://api.github.com/repos/lsst/obs_decam/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/obs_decam/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/obs_decam/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/obs_decam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/obs_decam/labels{/name}","releases_url":"https://api.github.com/repos/lsst/obs_decam/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/obs_decam/deployments","created_at":"2015-03-17T23:10:06Z","updated_at":"2017-08-10T16:44:09Z","pushed_at":"2018-03-20T22:37:32Z","git_url":"git://github.com/lsst/obs_decam.git","ssh_url":"git@github.com:lsst/obs_decam.git","clone_url":"https://github.com/lsst/obs_decam.git","svn_url":"https://github.com/lsst/obs_decam","homepage":null,"size":52784,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":7,"open_issues":6,"watchers":2,"default_branch":"master"}},"base":{"label":"lsst:master","ref":"master","sha":"8a7a6f39e33c69437744eb2339e1bdafe492c87d","user":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"repo":{"id":32425715,"name":"obs_decam","full_name":"lsst/obs_decam","owner":{"login":"lsst","id":1134504,"avatar_url":"https://avatars1.githubusercontent.com/u/1134504?v=4","gravatar_id":"","url":"https://api.github.com/users/lsst","html_url":"https://github.com/lsst","followers_url":"https://api.github.com/users/lsst/followers","following_url":"https://api.github.com/users/lsst/following{/other_user}","gists_url":"https://api.github.com/users/lsst/gists{/gist_id}","starred_url":"https://api.github.com/users/lsst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/lsst/subscriptions","organizations_url":"https://api.github.com/users/lsst/orgs","repos_url":"https://api.github.com/users/lsst/repos","events_url":"https://api.github.com/users/lsst/events{/privacy}","received_events_url":"https://api.github.com/users/lsst/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/lsst/obs_decam","description":"Interface for DECam to the LSST stack.","fork":false,"url":"https://api.github.com/repos/lsst/obs_decam","forks_url":"https://api.github.com/repos/lsst/obs_decam/forks","keys_url":"https://api.github.com/repos/lsst/obs_decam/keys{/key_id}","collaborators_url":"https://api.github.com/repos/lsst/obs_decam/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/lsst/obs_decam/teams","hooks_url":"https://api.github.com/repos/lsst/obs_decam/hooks","issue_events_url":"https://api.github.com/repos/lsst/obs_decam/issues/events{/number}","events_url":"https://api.github.com/repos/lsst/obs_decam/events","assignees_url":"https://api.github.com/repos/lsst/obs_decam/assignees{/user}","branches_url":"https://api.github.com/repos/lsst/obs_decam/branches{/branch}","tags_url":"https://api.github.com/repos/lsst/obs_decam/tags","blobs_url":"https://api.github.com/repos/lsst/obs_decam/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/lsst/obs_decam/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/lsst/obs_decam/git/refs{/sha}","trees_url":"https://api.github.com/repos/lsst/obs_decam/git/trees{/sha}","statuses_url":"https://api.github.com/repos/lsst/obs_decam/statuses/{sha}","languages_url":"https://api.github.com/repos/lsst/obs_decam/languages","stargazers_url":"https://api.github.com/repos/lsst/obs_decam/stargazers","contributors_url":"https://api.github.com/repos/lsst/obs_decam/contributors","subscribers_url":"https://api.github.com/repos/lsst/obs_decam/subscribers","subscription_url":"https://api.github.com/repos/lsst/obs_decam/subscription","commits_url":"https://api.github.com/repos/lsst/obs_decam/commits{/sha}","git_commits_url":"https://api.github.com/repos/lsst/obs_decam/git/commits{/sha}","comments_url":"https://api.github.com/repos/lsst/obs_decam/comments{/number}","issue_comment_url":"https://api.github.com/repos/lsst/obs_decam/issues/comments{/number}","contents_url":"https://api.github.com/repos/lsst/obs_decam/contents/{+path}","compare_url":"https://api.github.com/repos/lsst/obs_decam/compare/{base}...{head}","merges_url":"https://api.github.com/repos/lsst/obs_decam/merges","archive_url":"https://api.github.com/repos/lsst/obs_decam/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/lsst/obs_decam/downloads","issues_url":"https://api.github.com/repos/lsst/obs_decam/issues{/number}","pulls_url":"https://api.github.com/repos/lsst/obs_decam/pulls{/number}","milestones_url":"https://api.github.com/repos/lsst/obs_decam/milestones{/number}","notifications_url":"https://api.github.com/repos/lsst/obs_decam/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/lsst/obs_decam/labels{/name}","releases_url":"https://api.github.com/repos/lsst/obs_decam/releases{/id}","deployments_url":"https://api.github.com/repos/lsst/obs_decam/deployments","created_at":"2015-03-17T23:10:06Z","updated_at":"2017-08-10T16:44:09Z","pushed_at":"2018-03-20T22:37:32Z","git_url":"git://github.com/lsst/obs_decam.git","ssh_url":"git@github.com:lsst/obs_decam.git","clone_url":"https://github.com/lsst/obs_decam.git","svn_url":"https://github.com/lsst/obs_decam","homepage":null,"size":52784,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":7,"open_issues":6,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/lsst/obs_decam/pulls/78"},"html":{"href":"https://github.com/lsst/obs_decam/pull/78"},"issue":{"href":"https://api.github.com/repos/lsst/obs_decam/issues/78"},"comments":{"href":"https://api.github.com/repos/lsst/obs_decam/issues/78/comments"},"review_comments":{"href":"https://api.github.com/repos/lsst/obs_decam/pulls/78/comments"},"review_comment":{"href":"https://api.github.com/repos/lsst/obs_decam/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/lsst/obs_decam/pulls/78/commits"},"statuses":{"href":"https://api.github.com/repos/lsst/obs_decam/statuses/a287491f27d9ad23a51c2992dd224ca25cc8069e"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"rearmstr"}}