{"action":"created","comment":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/182814802","pull_request_review_id":113690854,"id":182814802,"diff_hunk":"@@ -381,3 +392,32 @@ func getClientset(file string, dryRun bool) (clientset.Interface, error) {\n \t}\n \treturn kubeconfigutil.ClientSetFromFile(file)\n }\n+\n+func findExistingKubeConfig(file string) string {","path":"cmd/kubeadm/app/cmd/token.go","position":67,"original_position":67,"commit_id":"0a8d3132a8d46dd9836dfca05ffb042f896ebfbf","original_commit_id":"0a8d3132a8d46dd9836dfca05ffb042f896ebfbf","user":{"login":"timothysc","id":169553,"avatar_url":"https://avatars0.githubusercontent.com/u/169553?v=4","gravatar_id":"","url":"https://api.github.com/users/timothysc","html_url":"https://github.com/timothysc","followers_url":"https://api.github.com/users/timothysc/followers","following_url":"https://api.github.com/users/timothysc/following{/other_user}","gists_url":"https://api.github.com/users/timothysc/gists{/gist_id}","starred_url":"https://api.github.com/users/timothysc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/timothysc/subscriptions","organizations_url":"https://api.github.com/users/timothysc/orgs","repos_url":"https://api.github.com/users/timothysc/repos","events_url":"https://api.github.com/users/timothysc/events{/privacy}","received_events_url":"https://api.github.com/users/timothysc/received_events","type":"User","site_admin":false},"body":"Most of this code exists in clientcmd.NewNonInteractiveDeferredLoadingClientConfig and should not be leveraged using the client tooling.  ","created_at":"2018-04-19T16:52:39Z","updated_at":"2018-04-19T16:52:45Z","html_url":"https://github.com/kubernetes/kubernetes/pull/62850#discussion_r182814802","pull_request_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62850","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments/182814802"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62850#discussion_r182814802"},"pull_request":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62850"}}},"pull_request":{"url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62850","id":182786512,"html_url":"https://github.com/kubernetes/kubernetes/pull/62850","diff_url":"https://github.com/kubernetes/kubernetes/pull/62850.diff","patch_url":"https://github.com/kubernetes/kubernetes/pull/62850.patch","issue_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62850","number":62850,"state":"open","locked":false,"title":"kubeadm-token: search for existing kubeconfig files","user":{"login":"neolit123","id":331852,"avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"body":"<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If this is your first time, read our contributor guidelines https://git.k8s.io/community/contributors/devel/pull-requests.md#the-pr-submit-process and developer guide https://git.k8s.io/community/contributors/devel/development.md#development-guide\r\n2. If you want *faster* PR reviews, read how: https://git.k8s.io/community/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n3. Follow the instructions for writing a release note: https://git.k8s.io/community/contributors/devel/pull-requests.md#write-release-notes-if-needed\r\n4. If the PR is unfinished, see how to mark it: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#marking-unfinished-pull-requests\r\n-->\r\n\r\n**What this PR does / why we need it**:\r\n\r\nAdd means to search the current user home path and\r\nthe environment variable KUBECONFIG for existing files if the\r\nuser does not provide a --kubeconfig flag.\r\n\r\nIf the user provides a --kubeconfig flag respect it.\r\n\r\n**Which issue(s) this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close the issue(s) when PR gets merged)*:\r\nFixes https://github.com/kubernetes/kubeadm/issues/198\r\n\r\n**Special notes for your reviewer**:\r\n\r\ni'm not 100% sure if that's the correct approach and if that's what's requested. so let's discuss it.\r\n\r\n**Release note**:\r\n<!--  Write your release note:\r\n1. Enter your extended release note in the below block. If the PR requires additional action from users switching to the new release, include the string \"action required\".\r\n2. If no release note is required, just write \"NONE\".\r\n-->\r\n```release-note\r\nSearch standard KubeConfig file locations when using `kubeadm token` without `--kubeconfig`.\r\n```\r\n","created_at":"2018-04-19T14:01:39Z","updated_at":"2018-04-19T16:52:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"541a3405af978233bfa307045d2a31efb4133f18","assignee":null,"assignees":[],"requested_reviewers":[{"login":"krousey","id":157083,"avatar_url":"https://avatars2.githubusercontent.com/u/157083?v=4","gravatar_id":"","url":"https://api.github.com/users/krousey","html_url":"https://github.com/krousey","followers_url":"https://api.github.com/users/krousey/followers","following_url":"https://api.github.com/users/krousey/following{/other_user}","gists_url":"https://api.github.com/users/krousey/gists{/gist_id}","starred_url":"https://api.github.com/users/krousey/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/krousey/subscriptions","organizations_url":"https://api.github.com/users/krousey/orgs","repos_url":"https://api.github.com/users/krousey/repos","events_url":"https://api.github.com/users/krousey/events{/privacy}","received_events_url":"https://api.github.com/users/krousey/received_events","type":"User","site_admin":false},{"login":"xiangpengzhao","id":15881573,"avatar_url":"https://avatars0.githubusercontent.com/u/15881573?v=4","gravatar_id":"","url":"https://api.github.com/users/xiangpengzhao","html_url":"https://github.com/xiangpengzhao","followers_url":"https://api.github.com/users/xiangpengzhao/followers","following_url":"https://api.github.com/users/xiangpengzhao/following{/other_user}","gists_url":"https://api.github.com/users/xiangpengzhao/gists{/gist_id}","starred_url":"https://api.github.com/users/xiangpengzhao/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xiangpengzhao/subscriptions","organizations_url":"https://api.github.com/users/xiangpengzhao/orgs","repos_url":"https://api.github.com/users/xiangpengzhao/repos","events_url":"https://api.github.com/users/xiangpengzhao/events{/privacy}","received_events_url":"https://api.github.com/users/xiangpengzhao/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":451459590,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/area/kubeadm","name":"area/kubeadm","color":"0052cc","default":false},{"id":477397086,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":200149833,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/release-note","name":"release-note","color":"c2e0c6","default":false},{"id":173494222,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/sig/cluster-lifecycle","name":"sig/cluster-lifecycle","color":"d2b48c","default":false},{"id":253450934,"url":"https://api.github.com/repos/kubernetes/kubernetes/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62850/commits","review_comments_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62850/comments","review_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/62850/comments","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0a8d3132a8d46dd9836dfca05ffb042f896ebfbf","head":{"label":"neolit123:token-config","ref":"token-config","sha":"0a8d3132a8d46dd9836dfca05ffb042f896ebfbf","user":{"login":"neolit123","id":331852,"avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"repo":{"id":104209335,"name":"kubernetes","full_name":"neolit123/kubernetes","owner":{"login":"neolit123","id":331852,"avatar_url":"https://avatars3.githubusercontent.com/u/331852?v=4","gravatar_id":"","url":"https://api.github.com/users/neolit123","html_url":"https://github.com/neolit123","followers_url":"https://api.github.com/users/neolit123/followers","following_url":"https://api.github.com/users/neolit123/following{/other_user}","gists_url":"https://api.github.com/users/neolit123/gists{/gist_id}","starred_url":"https://api.github.com/users/neolit123/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/neolit123/subscriptions","organizations_url":"https://api.github.com/users/neolit123/orgs","repos_url":"https://api.github.com/users/neolit123/repos","events_url":"https://api.github.com/users/neolit123/events{/privacy}","received_events_url":"https://api.github.com/users/neolit123/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/neolit123/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":true,"url":"https://api.github.com/repos/neolit123/kubernetes","forks_url":"https://api.github.com/repos/neolit123/kubernetes/forks","keys_url":"https://api.github.com/repos/neolit123/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/neolit123/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/neolit123/kubernetes/teams","hooks_url":"https://api.github.com/repos/neolit123/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/neolit123/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/neolit123/kubernetes/events","assignees_url":"https://api.github.com/repos/neolit123/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/neolit123/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/neolit123/kubernetes/tags","blobs_url":"https://api.github.com/repos/neolit123/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/neolit123/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/neolit123/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/neolit123/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/neolit123/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/neolit123/kubernetes/languages","stargazers_url":"https://api.github.com/repos/neolit123/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/neolit123/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/neolit123/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/neolit123/kubernetes/subscription","commits_url":"https://api.github.com/repos/neolit123/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/neolit123/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/neolit123/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/neolit123/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/neolit123/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/neolit123/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/neolit123/kubernetes/merges","archive_url":"https://api.github.com/repos/neolit123/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/neolit123/kubernetes/downloads","issues_url":"https://api.github.com/repos/neolit123/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/neolit123/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/neolit123/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/neolit123/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/neolit123/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/neolit123/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/neolit123/kubernetes/deployments","created_at":"2017-09-20T11:53:57Z","updated_at":"2017-09-20T11:54:40Z","pushed_at":"2018-04-19T14:23:21Z","git_url":"git://github.com/neolit123/kubernetes.git","ssh_url":"git@github.com:neolit123/kubernetes.git","clone_url":"https://github.com/neolit123/kubernetes.git","svn_url":"https://github.com/neolit123/kubernetes","homepage":"http://kubernetes.io","size":546023,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"kubernetes:master","ref":"master","sha":"8306b692b67c5a6149b3d912af1fe051ff2e97f9","user":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"repo":{"id":20580498,"name":"kubernetes","full_name":"kubernetes/kubernetes","owner":{"login":"kubernetes","id":13629408,"avatar_url":"https://avatars2.githubusercontent.com/u/13629408?v=4","gravatar_id":"","url":"https://api.github.com/users/kubernetes","html_url":"https://github.com/kubernetes","followers_url":"https://api.github.com/users/kubernetes/followers","following_url":"https://api.github.com/users/kubernetes/following{/other_user}","gists_url":"https://api.github.com/users/kubernetes/gists{/gist_id}","starred_url":"https://api.github.com/users/kubernetes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kubernetes/subscriptions","organizations_url":"https://api.github.com/users/kubernetes/orgs","repos_url":"https://api.github.com/users/kubernetes/repos","events_url":"https://api.github.com/users/kubernetes/events{/privacy}","received_events_url":"https://api.github.com/users/kubernetes/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/kubernetes/kubernetes","description":"Production-Grade Container Scheduling and Management","fork":false,"url":"https://api.github.com/repos/kubernetes/kubernetes","forks_url":"https://api.github.com/repos/kubernetes/kubernetes/forks","keys_url":"https://api.github.com/repos/kubernetes/kubernetes/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kubernetes/kubernetes/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kubernetes/kubernetes/teams","hooks_url":"https://api.github.com/repos/kubernetes/kubernetes/hooks","issue_events_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/events{/number}","events_url":"https://api.github.com/repos/kubernetes/kubernetes/events","assignees_url":"https://api.github.com/repos/kubernetes/kubernetes/assignees{/user}","branches_url":"https://api.github.com/repos/kubernetes/kubernetes/branches{/branch}","tags_url":"https://api.github.com/repos/kubernetes/kubernetes/tags","blobs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kubernetes/kubernetes/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kubernetes/kubernetes/git/refs{/sha}","trees_url":"https://api.github.com/repos/kubernetes/kubernetes/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kubernetes/kubernetes/statuses/{sha}","languages_url":"https://api.github.com/repos/kubernetes/kubernetes/languages","stargazers_url":"https://api.github.com/repos/kubernetes/kubernetes/stargazers","contributors_url":"https://api.github.com/repos/kubernetes/kubernetes/contributors","subscribers_url":"https://api.github.com/repos/kubernetes/kubernetes/subscribers","subscription_url":"https://api.github.com/repos/kubernetes/kubernetes/subscription","commits_url":"https://api.github.com/repos/kubernetes/kubernetes/commits{/sha}","git_commits_url":"https://api.github.com/repos/kubernetes/kubernetes/git/commits{/sha}","comments_url":"https://api.github.com/repos/kubernetes/kubernetes/comments{/number}","issue_comment_url":"https://api.github.com/repos/kubernetes/kubernetes/issues/comments{/number}","contents_url":"https://api.github.com/repos/kubernetes/kubernetes/contents/{+path}","compare_url":"https://api.github.com/repos/kubernetes/kubernetes/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kubernetes/kubernetes/merges","archive_url":"https://api.github.com/repos/kubernetes/kubernetes/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kubernetes/kubernetes/downloads","issues_url":"https://api.github.com/repos/kubernetes/kubernetes/issues{/number}","pulls_url":"https://api.github.com/repos/kubernetes/kubernetes/pulls{/number}","milestones_url":"https://api.github.com/repos/kubernetes/kubernetes/milestones{/number}","notifications_url":"https://api.github.com/repos/kubernetes/kubernetes/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kubernetes/kubernetes/labels{/name}","releases_url":"https://api.github.com/repos/kubernetes/kubernetes/releases{/id}","deployments_url":"https://api.github.com/repos/kubernetes/kubernetes/deployments","created_at":"2014-06-06T22:56:04Z","updated_at":"2018-04-19T16:30:52Z","pushed_at":"2018-04-19T16:50:28Z","git_url":"git://github.com/kubernetes/kubernetes.git","ssh_url":"git@github.com:kubernetes/kubernetes.git","clone_url":"https://github.com/kubernetes/kubernetes.git","svn_url":"https://github.com/kubernetes/kubernetes","homepage":"http://kubernetes.io","size":771459,"stargazers_count":35271,"watchers_count":35271,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":12481,"mirror_url":null,"archived":false,"open_issues_count":3458,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":12481,"open_issues":3458,"watchers":35271,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62850"},"html":{"href":"https://github.com/kubernetes/kubernetes/pull/62850"},"issue":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62850"},"comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/issues/62850/comments"},"review_comments":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62850/comments"},"review_comment":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kubernetes/kubernetes/pulls/62850/commits"},"statuses":{"href":"https://api.github.com/repos/kubernetes/kubernetes/statuses/0a8d3132a8d46dd9836dfca05ffb042f896ebfbf"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"timothysc"}}