{"action":"created","comment":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/193895136","pull_request_review_id":126964480,"id":193895136,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5Mzg5NTEzNg==","diff_hunk":"@@ -242,6 +243,10 @@ def fit(self, X, y, sample_weight=None):\n         -------\n         self : object\n         \"\"\"\n+        # Validate hyperparameters\n+        if self.n_estimators == 10:","path":"sklearn/ensemble/forest.py","position":13,"original_position":13,"commit_id":"8b5cb95c87b22131ed0f55205717accd4893f5bf","original_commit_id":"8b5cb95c87b22131ed0f55205717accd4893f5bf","user":{"login":"Olamyy","id":14059714,"node_id":"MDQ6VXNlcjE0MDU5NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/14059714?v=4","gravatar_id":"","url":"https://api.github.com/users/Olamyy","html_url":"https://github.com/Olamyy","followers_url":"https://api.github.com/users/Olamyy/followers","following_url":"https://api.github.com/users/Olamyy/following{/other_user}","gists_url":"https://api.github.com/users/Olamyy/gists{/gist_id}","starred_url":"https://api.github.com/users/Olamyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olamyy/subscriptions","organizations_url":"https://api.github.com/users/Olamyy/orgs","repos_url":"https://api.github.com/users/Olamyy/repos","events_url":"https://api.github.com/users/Olamyy/events{/privacy}","received_events_url":"https://api.github.com/users/Olamyy/received_events","type":"User","site_admin":false},"body":"@amueller I've created two issues to take care of both of these.","created_at":"2018-06-07T21:31:41Z","updated_at":"2018-06-07T21:31:41Z","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11172#discussion_r193895136","pull_request_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11172","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments/193895136"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11172#discussion_r193895136"},"pull_request":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11172"}},"in_reply_to_id":193729163},"pull_request":{"url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11172","id":191602223,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjAyMjIz","html_url":"https://github.com/scikit-learn/scikit-learn/pull/11172","diff_url":"https://github.com/scikit-learn/scikit-learn/pull/11172.diff","patch_url":"https://github.com/scikit-learn/scikit-learn/pull/11172.patch","issue_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11172","number":11172,"state":"open","locked":false,"title":"Fixes #11128 : Default n_estimator value should be 100","user":{"login":"Olamyy","id":14059714,"node_id":"MDQ6VXNlcjE0MDU5NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/14059714?v=4","gravatar_id":"","url":"https://api.github.com/users/Olamyy","html_url":"https://github.com/Olamyy","followers_url":"https://api.github.com/users/Olamyy/followers","following_url":"https://api.github.com/users/Olamyy/following{/other_user}","gists_url":"https://api.github.com/users/Olamyy/gists{/gist_id}","starred_url":"https://api.github.com/users/Olamyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olamyy/subscriptions","organizations_url":"https://api.github.com/users/Olamyy/orgs","repos_url":"https://api.github.com/users/Olamyy/repos","events_url":"https://api.github.com/users/Olamyy/events{/privacy}","received_events_url":"https://api.github.com/users/Olamyy/received_events","type":"User","site_admin":false},"body":"Fixes #11128 ","created_at":"2018-05-30T22:53:15Z","updated_at":"2018-06-07T21:31:41Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a03dccf00703b4b88539db79ee15d816a2ba9cbf","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11172/commits","review_comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11172/comments","review_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11172/comments","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/8b5cb95c87b22131ed0f55205717accd4893f5bf","head":{"label":"Olamyy:n_estimator_should_be_100","ref":"n_estimator_should_be_100","sha":"8b5cb95c87b22131ed0f55205717accd4893f5bf","user":{"login":"Olamyy","id":14059714,"node_id":"MDQ6VXNlcjE0MDU5NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/14059714?v=4","gravatar_id":"","url":"https://api.github.com/users/Olamyy","html_url":"https://github.com/Olamyy","followers_url":"https://api.github.com/users/Olamyy/followers","following_url":"https://api.github.com/users/Olamyy/following{/other_user}","gists_url":"https://api.github.com/users/Olamyy/gists{/gist_id}","starred_url":"https://api.github.com/users/Olamyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olamyy/subscriptions","organizations_url":"https://api.github.com/users/Olamyy/orgs","repos_url":"https://api.github.com/users/Olamyy/repos","events_url":"https://api.github.com/users/Olamyy/events{/privacy}","received_events_url":"https://api.github.com/users/Olamyy/received_events","type":"User","site_admin":false},"repo":{"id":135353074,"node_id":"MDEwOlJlcG9zaXRvcnkxMzUzNTMwNzQ=","name":"scikit-learn","full_name":"Olamyy/scikit-learn","owner":{"login":"Olamyy","id":14059714,"node_id":"MDQ6VXNlcjE0MDU5NzE0","avatar_url":"https://avatars2.githubusercontent.com/u/14059714?v=4","gravatar_id":"","url":"https://api.github.com/users/Olamyy","html_url":"https://github.com/Olamyy","followers_url":"https://api.github.com/users/Olamyy/followers","following_url":"https://api.github.com/users/Olamyy/following{/other_user}","gists_url":"https://api.github.com/users/Olamyy/gists{/gist_id}","starred_url":"https://api.github.com/users/Olamyy/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Olamyy/subscriptions","organizations_url":"https://api.github.com/users/Olamyy/orgs","repos_url":"https://api.github.com/users/Olamyy/repos","events_url":"https://api.github.com/users/Olamyy/events{/privacy}","received_events_url":"https://api.github.com/users/Olamyy/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Olamyy/scikit-learn","description":"scikit-learn: machine learning in Python","fork":true,"url":"https://api.github.com/repos/Olamyy/scikit-learn","forks_url":"https://api.github.com/repos/Olamyy/scikit-learn/forks","keys_url":"https://api.github.com/repos/Olamyy/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Olamyy/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Olamyy/scikit-learn/teams","hooks_url":"https://api.github.com/repos/Olamyy/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/Olamyy/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/Olamyy/scikit-learn/events","assignees_url":"https://api.github.com/repos/Olamyy/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/Olamyy/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/Olamyy/scikit-learn/tags","blobs_url":"https://api.github.com/repos/Olamyy/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Olamyy/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Olamyy/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/Olamyy/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Olamyy/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/Olamyy/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/Olamyy/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/Olamyy/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/Olamyy/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/Olamyy/scikit-learn/subscription","commits_url":"https://api.github.com/repos/Olamyy/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/Olamyy/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/Olamyy/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/Olamyy/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/Olamyy/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/Olamyy/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Olamyy/scikit-learn/merges","archive_url":"https://api.github.com/repos/Olamyy/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Olamyy/scikit-learn/downloads","issues_url":"https://api.github.com/repos/Olamyy/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/Olamyy/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/Olamyy/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/Olamyy/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Olamyy/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/Olamyy/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/Olamyy/scikit-learn/deployments","created_at":"2018-05-29T21:07:18Z","updated_at":"2018-05-29T21:07:26Z","pushed_at":"2018-06-07T11:32:39Z","git_url":"git://github.com/Olamyy/scikit-learn.git","ssh_url":"git@github.com:Olamyy/scikit-learn.git","clone_url":"https://github.com/Olamyy/scikit-learn.git","svn_url":"https://github.com/Olamyy/scikit-learn","homepage":"http://scikit-learn.org","size":93480,"stargazers_count":0,"watchers_count":0,"language":"Python","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"scikit-learn:master","ref":"master","sha":"b225ceb4befa0b21e7e220f64659192d10843b59","user":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"repo":{"id":843222,"node_id":"MDEwOlJlcG9zaXRvcnk4NDMyMjI=","name":"scikit-learn","full_name":"scikit-learn/scikit-learn","owner":{"login":"scikit-learn","id":365630,"node_id":"MDEyOk9yZ2FuaXphdGlvbjM2NTYzMA==","avatar_url":"https://avatars2.githubusercontent.com/u/365630?v=4","gravatar_id":"","url":"https://api.github.com/users/scikit-learn","html_url":"https://github.com/scikit-learn","followers_url":"https://api.github.com/users/scikit-learn/followers","following_url":"https://api.github.com/users/scikit-learn/following{/other_user}","gists_url":"https://api.github.com/users/scikit-learn/gists{/gist_id}","starred_url":"https://api.github.com/users/scikit-learn/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scikit-learn/subscriptions","organizations_url":"https://api.github.com/users/scikit-learn/orgs","repos_url":"https://api.github.com/users/scikit-learn/repos","events_url":"https://api.github.com/users/scikit-learn/events{/privacy}","received_events_url":"https://api.github.com/users/scikit-learn/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/scikit-learn/scikit-learn","description":"scikit-learn: machine learning in Python","fork":false,"url":"https://api.github.com/repos/scikit-learn/scikit-learn","forks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/forks","keys_url":"https://api.github.com/repos/scikit-learn/scikit-learn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/scikit-learn/scikit-learn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/scikit-learn/scikit-learn/teams","hooks_url":"https://api.github.com/repos/scikit-learn/scikit-learn/hooks","issue_events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/events{/number}","events_url":"https://api.github.com/repos/scikit-learn/scikit-learn/events","assignees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/assignees{/user}","branches_url":"https://api.github.com/repos/scikit-learn/scikit-learn/branches{/branch}","tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/tags","blobs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/refs{/sha}","trees_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/{sha}","languages_url":"https://api.github.com/repos/scikit-learn/scikit-learn/languages","stargazers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/stargazers","contributors_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contributors","subscribers_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscribers","subscription_url":"https://api.github.com/repos/scikit-learn/scikit-learn/subscription","commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/commits{/sha}","git_commits_url":"https://api.github.com/repos/scikit-learn/scikit-learn/git/commits{/sha}","comments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/comments{/number}","issue_comment_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/comments{/number}","contents_url":"https://api.github.com/repos/scikit-learn/scikit-learn/contents/{+path}","compare_url":"https://api.github.com/repos/scikit-learn/scikit-learn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/scikit-learn/scikit-learn/merges","archive_url":"https://api.github.com/repos/scikit-learn/scikit-learn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/scikit-learn/scikit-learn/downloads","issues_url":"https://api.github.com/repos/scikit-learn/scikit-learn/issues{/number}","pulls_url":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls{/number}","milestones_url":"https://api.github.com/repos/scikit-learn/scikit-learn/milestones{/number}","notifications_url":"https://api.github.com/repos/scikit-learn/scikit-learn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/scikit-learn/scikit-learn/labels{/name}","releases_url":"https://api.github.com/repos/scikit-learn/scikit-learn/releases{/id}","deployments_url":"https://api.github.com/repos/scikit-learn/scikit-learn/deployments","created_at":"2010-08-17T09:43:38Z","updated_at":"2018-06-07T20:24:02Z","pushed_at":"2018-06-07T18:23:53Z","git_url":"git://github.com/scikit-learn/scikit-learn.git","ssh_url":"git@github.com:scikit-learn/scikit-learn.git","clone_url":"https://github.com/scikit-learn/scikit-learn.git","svn_url":"https://github.com/scikit-learn/scikit-learn","homepage":"http://scikit-learn.org","size":90673,"stargazers_count":28627,"watchers_count":28627,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":14206,"mirror_url":null,"archived":false,"open_issues_count":1607,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":14206,"open_issues":1607,"watchers":28627,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11172"},"html":{"href":"https://github.com/scikit-learn/scikit-learn/pull/11172"},"issue":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11172"},"comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/issues/11172/comments"},"review_comments":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11172/comments"},"review_comment":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/pulls/11172/commits"},"statuses":{"href":"https://api.github.com/repos/scikit-learn/scikit-learn/statuses/8b5cb95c87b22131ed0f55205717accd4893f5bf"}},"author_association":"NONE"}}
{"actor":{"display_login":"Olamyy"}}