{"action":"created","comment":{"url":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/comments/170458459","pull_request_review_id":99148172,"id":170458459,"diff_hunk":"@@ -10,13 +10,17 @@ fn main() {\n     if cfg!(feature = \"development\") {\n         return;\n     }\n-    if let Ok(target) = env::var(\"TARGET\") {\n-        if !target.starts_with(\"arm-\") {","path":"build.rs","position":18,"original_position":5,"commit_id":"ecf4d591ce83dd42b3bb58af0be5d48009891001","original_commit_id":"2053c494563f8232917632f4c0ad4a30082387f6","user":{"login":"yuhe00","id":305671,"avatar_url":"https://avatars2.githubusercontent.com/u/305671?v=4","gravatar_id":"","url":"https://api.github.com/users/yuhe00","html_url":"https://github.com/yuhe00","followers_url":"https://api.github.com/users/yuhe00/followers","following_url":"https://api.github.com/users/yuhe00/following{/other_user}","gists_url":"https://api.github.com/users/yuhe00/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhe00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhe00/subscriptions","organizations_url":"https://api.github.com/users/yuhe00/orgs","repos_url":"https://api.github.com/users/yuhe00/repos","events_url":"https://api.github.com/users/yuhe00/events{/privacy}","received_events_url":"https://api.github.com/users/yuhe00/received_events","type":"User","site_admin":false},"body":"> It should be easy to upgrade wiringpi and wiringop without having to know if their internal structure changes.\r\n\r\nI'm not sure I agree, because there infinite many ways they could change their internal structure, and you can't cover all of the cases anyway, e.g. they could change to a completely different build system. We're pinning it to a particular version and we only use certain parts of the library, so I think this is fine.\r\n\r\n> It should be possible to override the compiler by setting CC (see #16).\r\n\r\nThis is supported by `cc`. See the [docs](https://github.com/alexcrichton/cc-rs#external-configuration-via-environment-variables).\r\n\r\n> It should be possible to successfully run cargo doc on any platform.\r\n> It should be safe to accidentally run cargo run or even sudo cargo run on a development machine, without trashing the RAM or anything.\r\n\r\nNot sure how these are relevant.","created_at":"2018-02-25T16:35:49Z","updated_at":"2018-02-25T16:35:49Z","html_url":"https://github.com/Ogeon/rust-wiringpi/pull/23#discussion_r170458459","pull_request_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/23","author_association":"NONE","_links":{"self":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/comments/170458459"},"html":{"href":"https://github.com/Ogeon/rust-wiringpi/pull/23#discussion_r170458459"},"pull_request":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/23"}},"in_reply_to_id":170434043},"pull_request":{"url":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/23","id":171199441,"html_url":"https://github.com/Ogeon/rust-wiringpi/pull/23","diff_url":"https://github.com/Ogeon/rust-wiringpi/pull/23.diff","patch_url":"https://github.com/Ogeon/rust-wiringpi/pull/23.patch","issue_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/issues/23","number":23,"state":"open","locked":false,"title":"Fix build for cross-compilation","user":{"login":"yuhe00","id":305671,"avatar_url":"https://avatars2.githubusercontent.com/u/305671?v=4","gravatar_id":"","url":"https://api.github.com/users/yuhe00","html_url":"https://github.com/yuhe00","followers_url":"https://api.github.com/users/yuhe00/followers","following_url":"https://api.github.com/users/yuhe00/following{/other_user}","gists_url":"https://api.github.com/users/yuhe00/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhe00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhe00/subscriptions","organizations_url":"https://api.github.com/users/yuhe00/orgs","repos_url":"https://api.github.com/users/yuhe00/repos","events_url":"https://api.github.com/users/yuhe00/events{/privacy}","received_events_url":"https://api.github.com/users/yuhe00/received_events","type":"User","site_admin":false},"body":"I got this working with my setup, cross-compiling from x86 to RPi using `arm-linux-gnueabihf-gcc`.","created_at":"2018-02-24T21:51:25Z","updated_at":"2018-02-25T16:35:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"c6bd4976fade5787b2fbfab85afdaf666903c814","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/23/commits","review_comments_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/23/comments","review_comment_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/issues/23/comments","statuses_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/statuses/ecf4d591ce83dd42b3bb58af0be5d48009891001","head":{"label":"yuhe00:fix-build","ref":"fix-build","sha":"ecf4d591ce83dd42b3bb58af0be5d48009891001","user":{"login":"yuhe00","id":305671,"avatar_url":"https://avatars2.githubusercontent.com/u/305671?v=4","gravatar_id":"","url":"https://api.github.com/users/yuhe00","html_url":"https://github.com/yuhe00","followers_url":"https://api.github.com/users/yuhe00/followers","following_url":"https://api.github.com/users/yuhe00/following{/other_user}","gists_url":"https://api.github.com/users/yuhe00/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhe00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhe00/subscriptions","organizations_url":"https://api.github.com/users/yuhe00/orgs","repos_url":"https://api.github.com/users/yuhe00/repos","events_url":"https://api.github.com/users/yuhe00/events{/privacy}","received_events_url":"https://api.github.com/users/yuhe00/received_events","type":"User","site_admin":false},"repo":{"id":122782724,"name":"rust-wiringpi","full_name":"yuhe00/rust-wiringpi","owner":{"login":"yuhe00","id":305671,"avatar_url":"https://avatars2.githubusercontent.com/u/305671?v=4","gravatar_id":"","url":"https://api.github.com/users/yuhe00","html_url":"https://github.com/yuhe00","followers_url":"https://api.github.com/users/yuhe00/followers","following_url":"https://api.github.com/users/yuhe00/following{/other_user}","gists_url":"https://api.github.com/users/yuhe00/gists{/gist_id}","starred_url":"https://api.github.com/users/yuhe00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/yuhe00/subscriptions","organizations_url":"https://api.github.com/users/yuhe00/orgs","repos_url":"https://api.github.com/users/yuhe00/repos","events_url":"https://api.github.com/users/yuhe00/events{/privacy}","received_events_url":"https://api.github.com/users/yuhe00/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/yuhe00/rust-wiringpi","description":"WiringPi API wrapper for Rust","fork":true,"url":"https://api.github.com/repos/yuhe00/rust-wiringpi","forks_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/forks","keys_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/teams","hooks_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/hooks","issue_events_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/issues/events{/number}","events_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/events","assignees_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/assignees{/user}","branches_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/branches{/branch}","tags_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/tags","blobs_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/git/refs{/sha}","trees_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/statuses/{sha}","languages_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/languages","stargazers_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/stargazers","contributors_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/contributors","subscribers_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/subscribers","subscription_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/subscription","commits_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/commits{/sha}","git_commits_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/git/commits{/sha}","comments_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/comments{/number}","issue_comment_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/issues/comments{/number}","contents_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/contents/{+path}","compare_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/merges","archive_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/downloads","issues_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/issues{/number}","pulls_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/pulls{/number}","milestones_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/milestones{/number}","notifications_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/labels{/name}","releases_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/releases{/id}","deployments_url":"https://api.github.com/repos/yuhe00/rust-wiringpi/deployments","created_at":"2018-02-24T21:47:26Z","updated_at":"2018-02-24T21:47:27Z","pushed_at":"2018-02-25T11:20:12Z","git_url":"git://github.com/yuhe00/rust-wiringpi.git","ssh_url":"git@github.com:yuhe00/rust-wiringpi.git","clone_url":"https://github.com/yuhe00/rust-wiringpi.git","svn_url":"https://github.com/yuhe00/rust-wiringpi","homepage":null,"size":62,"stargazers_count":0,"watchers_count":0,"language":"Rust","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"Ogeon:master","ref":"master","sha":"125d921a1f7414ef95710f3d27f8058700bcbfb2","user":{"login":"Ogeon","id":225229,"avatar_url":"https://avatars3.githubusercontent.com/u/225229?v=4","gravatar_id":"","url":"https://api.github.com/users/Ogeon","html_url":"https://github.com/Ogeon","followers_url":"https://api.github.com/users/Ogeon/followers","following_url":"https://api.github.com/users/Ogeon/following{/other_user}","gists_url":"https://api.github.com/users/Ogeon/gists{/gist_id}","starred_url":"https://api.github.com/users/Ogeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ogeon/subscriptions","organizations_url":"https://api.github.com/users/Ogeon/orgs","repos_url":"https://api.github.com/users/Ogeon/repos","events_url":"https://api.github.com/users/Ogeon/events{/privacy}","received_events_url":"https://api.github.com/users/Ogeon/received_events","type":"User","site_admin":false},"repo":{"id":25434999,"name":"rust-wiringpi","full_name":"Ogeon/rust-wiringpi","owner":{"login":"Ogeon","id":225229,"avatar_url":"https://avatars3.githubusercontent.com/u/225229?v=4","gravatar_id":"","url":"https://api.github.com/users/Ogeon","html_url":"https://github.com/Ogeon","followers_url":"https://api.github.com/users/Ogeon/followers","following_url":"https://api.github.com/users/Ogeon/following{/other_user}","gists_url":"https://api.github.com/users/Ogeon/gists{/gist_id}","starred_url":"https://api.github.com/users/Ogeon/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Ogeon/subscriptions","organizations_url":"https://api.github.com/users/Ogeon/orgs","repos_url":"https://api.github.com/users/Ogeon/repos","events_url":"https://api.github.com/users/Ogeon/events{/privacy}","received_events_url":"https://api.github.com/users/Ogeon/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Ogeon/rust-wiringpi","description":"WiringPi API wrapper for Rust","fork":false,"url":"https://api.github.com/repos/Ogeon/rust-wiringpi","forks_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/forks","keys_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/teams","hooks_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/hooks","issue_events_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/issues/events{/number}","events_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/events","assignees_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/assignees{/user}","branches_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/branches{/branch}","tags_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/tags","blobs_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/git/refs{/sha}","trees_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/statuses/{sha}","languages_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/languages","stargazers_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/stargazers","contributors_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/contributors","subscribers_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/subscribers","subscription_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/subscription","commits_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/commits{/sha}","git_commits_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/git/commits{/sha}","comments_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/comments{/number}","issue_comment_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/issues/comments{/number}","contents_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/contents/{+path}","compare_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/merges","archive_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/downloads","issues_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/issues{/number}","pulls_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls{/number}","milestones_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/milestones{/number}","notifications_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/labels{/name}","releases_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/releases{/id}","deployments_url":"https://api.github.com/repos/Ogeon/rust-wiringpi/deployments","created_at":"2014-10-19T17:56:25Z","updated_at":"2018-02-04T18:52:55Z","pushed_at":"2018-02-25T11:20:13Z","git_url":"git://github.com/Ogeon/rust-wiringpi.git","ssh_url":"git@github.com:Ogeon/rust-wiringpi.git","clone_url":"https://github.com/Ogeon/rust-wiringpi.git","svn_url":"https://github.com/Ogeon/rust-wiringpi","homepage":null,"size":61,"stargazers_count":19,"watchers_count":19,"language":"Rust","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":12,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit"},"forks":12,"open_issues":4,"watchers":19,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/23"},"html":{"href":"https://github.com/Ogeon/rust-wiringpi/pull/23"},"issue":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/issues/23"},"comments":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/issues/23/comments"},"review_comments":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/23/comments"},"review_comment":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/pulls/23/commits"},"statuses":{"href":"https://api.github.com/repos/Ogeon/rust-wiringpi/statuses/ecf4d591ce83dd42b3bb58af0be5d48009891001"}},"author_association":"NONE"}}
{"actor":{"display_login":"yuhe00"}}