{"action":"created","issue":{"url":"https://api.github.com/repos/nodejs/node/issues/23840","repository_url":"https://api.github.com/repos/nodejs/node","labels_url":"https://api.github.com/repos/nodejs/node/issues/23840/labels{/name}","comments_url":"https://api.github.com/repos/nodejs/node/issues/23840/comments","events_url":"https://api.github.com/repos/nodejs/node/issues/23840/events","html_url":"https://github.com/nodejs/node/pull/23840","id":373274985,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI1MjQyNjIx","number":23840,"title":"buffer: validate arg types","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"labels":[{"id":155267414,"node_id":"MDU6TGFiZWwxNTUyNjc0MTQ=","url":"https://api.github.com/repos/nodejs/node/labels/buffer","name":"buffer","color":"f7c6c7","default":false},{"id":829539823,"node_id":"MDU6TGFiZWw4Mjk1Mzk4MjM=","url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v10.x","name":"dont-land-on-v10.x","color":"4213c4","default":false},{"id":364533783,"node_id":"MDU6TGFiZWwzNjQ1MzM3ODM=","url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v6.x","name":"dont-land-on-v6.x","color":"c2e0c6","default":false},{"id":575600232,"node_id":"MDU6TGFiZWw1NzU2MDAyMzI=","url":"https://api.github.com/repos/nodejs/node/labels/dont-land-on-v8.x","name":"dont-land-on-v8.x","color":"1d76db","default":false},{"id":585819831,"node_id":"MDU6TGFiZWw1ODU4MTk4MzE=","url":"https://api.github.com/repos/nodejs/node/labels/regression","name":"regression","color":"b60205","default":false}],"state":"open","locked":false,"assignee":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"assignees":[{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false}],"milestone":null,"comments":10,"created_at":"2018-10-24T02:11:36Z","updated_at":"2018-10-25T16:06:25Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/23840","html_url":"https://github.com/nodejs/node/pull/23840","diff_url":"https://github.com/nodejs/node/pull/23840.diff","patch_url":"https://github.com/nodejs/node/pull/23840.patch"},"body":"Validate `buffer.copy` arguments type and range.\r\nSince this fixes a crash in node11, it might be considered semver-patch.\r\n\r\nAlternative to: https://github.com/nodejs/node/pull/23795\r\nFixes: https://github.com/nodejs/node/issues/23668\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [X] tests and/or benchmarks are included\r\n- [X] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n"},"comment":{"url":"https://api.github.com/repos/nodejs/node/issues/comments/433110745","html_url":"https://github.com/nodejs/node/pull/23840#issuecomment-433110745","issue_url":"https://api.github.com/repos/nodejs/node/issues/23840","id":433110745,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMzExMDc0NQ==","user":{"login":"refack","id":96947,"node_id":"MDQ6VXNlcjk2OTQ3","avatar_url":"https://avatars3.githubusercontent.com/u/96947?v=4","gravatar_id":"","url":"https://api.github.com/users/refack","html_url":"https://github.com/refack","followers_url":"https://api.github.com/users/refack/followers","following_url":"https://api.github.com/users/refack/following{/other_user}","gists_url":"https://api.github.com/users/refack/gists{/gist_id}","starred_url":"https://api.github.com/users/refack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/refack/subscriptions","organizations_url":"https://api.github.com/users/refack/orgs","repos_url":"https://api.github.com/users/refack/repos","events_url":"https://api.github.com/users/refack/events{/privacy}","received_events_url":"https://api.github.com/users/refack/received_events","type":"User","site_admin":false},"created_at":"2018-10-25T16:06:25Z","updated_at":"2018-10-25T16:06:25Z","author_association":"MEMBER","body":"> I think the main options would be wrapping them (which might create some overhead we don’t want?), doing the typechecks in C++ in those methods, or incorporating something like #23795 into this PR. I’m fine with any of them, but I’d like us to do something, even if they are not technically public…\r\n\r\nOk.\r\nI'm thinking about this...\r\nIf anyone has a preference, advice would be much appreciated.\r\n(I think the trend was to move typechecks to JS... but in this case it will require js wrappers...)\r\n@bmeurer a priori what's your intuition?"}}
{"actor":{"display_login":"refack"}}