{"action":"closed","number":1758,"pull_request":{"url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1758","id":205846217,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA1ODQ2MjE3","html_url":"https://github.com/Microsoft/AdaptiveCards/pull/1758","diff_url":"https://github.com/Microsoft/AdaptiveCards/pull/1758.diff","patch_url":"https://github.com/Microsoft/AdaptiveCards/pull/1758.patch","issue_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/1758","number":1758,"state":"closed","locked":false,"title":"stopped requiring type property for Columns","user":{"login":"tuanh118","id":3454845,"node_id":"MDQ6VXNlcjM0NTQ4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3454845?v=4","gravatar_id":"","url":"https://api.github.com/users/tuanh118","html_url":"https://github.com/tuanh118","followers_url":"https://api.github.com/users/tuanh118/followers","following_url":"https://api.github.com/users/tuanh118/following{/other_user}","gists_url":"https://api.github.com/users/tuanh118/gists{/gist_id}","starred_url":"https://api.github.com/users/tuanh118/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuanh118/subscriptions","organizations_url":"https://api.github.com/users/tuanh118/orgs","repos_url":"https://api.github.com/users/tuanh118/repos","events_url":"https://api.github.com/users/tuanh118/events{/privacy}","received_events_url":"https://api.github.com/users/tuanh118/received_events","type":"User","site_admin":false},"body":"- **Comment:** Not totally happy with the modifications, but it's the best solution I have to make it work. Definitely open for a better solution.\r\n- **Modifications:**\r\n  - Removed `[JsonRequired]` from `AdaptiveTypedElement.cs` since it already has `Required = Required.Always` in the line above and `[JsonRequired]` seems to block children to overriding it\r\n  - Overriding `Required` in `AdaptiveColumn`\r\n  - Added a special case in `AdaptiveTypedElementConverter.cs`. If we want to do something similar for other elements in the future, we'll also need to add corresponding special cases. ","created_at":"2018-08-02T20:05:34Z","updated_at":"2018-08-24T20:20:19Z","closed_at":"2018-08-24T20:20:19Z","merged_at":"2018-08-24T20:20:18Z","merge_commit_sha":"6a1e2df5b386abde1b716b1083760d228ba25956","assignee":null,"assignees":[],"requested_reviewers":[{"login":"matthidinger","id":1432195,"node_id":"MDQ6VXNlcjE0MzIxOTU=","avatar_url":"https://avatars1.githubusercontent.com/u/1432195?v=4","gravatar_id":"","url":"https://api.github.com/users/matthidinger","html_url":"https://github.com/matthidinger","followers_url":"https://api.github.com/users/matthidinger/followers","following_url":"https://api.github.com/users/matthidinger/following{/other_user}","gists_url":"https://api.github.com/users/matthidinger/gists{/gist_id}","starred_url":"https://api.github.com/users/matthidinger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/matthidinger/subscriptions","organizations_url":"https://api.github.com/users/matthidinger/orgs","repos_url":"https://api.github.com/users/matthidinger/repos","events_url":"https://api.github.com/users/matthidinger/events{/privacy}","received_events_url":"https://api.github.com/users/matthidinger/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":497291984,"node_id":"MDU6TGFiZWw0OTcyOTE5ODQ=","url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels/Area-Schema","name":"Area-Schema","color":"fbca04","default":false},{"id":497280004,"node_id":"MDU6TGFiZWw0OTcyODAwMDQ=","url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels/Bug","name":"Bug","color":"ee0701","default":false},{"id":639300865,"node_id":"MDU6TGFiZWw2MzkzMDA4NjU=","url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels/Platform-.NET","name":"Platform-.NET","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1758/commits","review_comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1758/comments","review_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments{/number}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/1758/comments","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/f8a602d9b37343d4f4b447a593547ce38bf7269b","head":{"label":"Microsoft:tupha/type-column-not-required","ref":"tupha/type-column-not-required","sha":"f8a602d9b37343d4f4b447a593547ce38bf7269b","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75978731,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk3ODczMQ==","name":"AdaptiveCards","full_name":"Microsoft/AdaptiveCards","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/AdaptiveCards","description":"A new way for developers to exchange card content in a common and consistent way.","fork":false,"url":"https://api.github.com/repos/Microsoft/AdaptiveCards","forks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/forks","keys_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/teams","hooks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/events","assignees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/tags","blobs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscription","commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/merges","archive_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/downloads","issues_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/deployments","created_at":"2016-12-08T22:00:33Z","updated_at":"2018-08-24T17:02:58Z","pushed_at":"2018-08-24T20:20:19Z","git_url":"git://github.com/Microsoft/AdaptiveCards.git","ssh_url":"git@github.com:Microsoft/AdaptiveCards.git","clone_url":"https://github.com/Microsoft/AdaptiveCards.git","svn_url":"https://github.com/Microsoft/AdaptiveCards","homepage":"http://adaptivecards.io","size":86014,"stargazers_count":365,"watchers_count":365,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":348,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":93,"open_issues":348,"watchers":365,"default_branch":"master"}},"base":{"label":"Microsoft:master","ref":"master","sha":"fd04327d8acd95428b706c8e099a21b1847b7296","user":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"repo":{"id":75978731,"node_id":"MDEwOlJlcG9zaXRvcnk3NTk3ODczMQ==","name":"AdaptiveCards","full_name":"Microsoft/AdaptiveCards","owner":{"login":"Microsoft","id":6154722,"node_id":"MDEyOk9yZ2FuaXphdGlvbjYxNTQ3MjI=","avatar_url":"https://avatars2.githubusercontent.com/u/6154722?v=4","gravatar_id":"","url":"https://api.github.com/users/Microsoft","html_url":"https://github.com/Microsoft","followers_url":"https://api.github.com/users/Microsoft/followers","following_url":"https://api.github.com/users/Microsoft/following{/other_user}","gists_url":"https://api.github.com/users/Microsoft/gists{/gist_id}","starred_url":"https://api.github.com/users/Microsoft/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Microsoft/subscriptions","organizations_url":"https://api.github.com/users/Microsoft/orgs","repos_url":"https://api.github.com/users/Microsoft/repos","events_url":"https://api.github.com/users/Microsoft/events{/privacy}","received_events_url":"https://api.github.com/users/Microsoft/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/Microsoft/AdaptiveCards","description":"A new way for developers to exchange card content in a common and consistent way.","fork":false,"url":"https://api.github.com/repos/Microsoft/AdaptiveCards","forks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/forks","keys_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/teams","hooks_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/hooks","issue_events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/events{/number}","events_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/events","assignees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/assignees{/user}","branches_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/branches{/branch}","tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/tags","blobs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/refs{/sha}","trees_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/{sha}","languages_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/languages","stargazers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/stargazers","contributors_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contributors","subscribers_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscribers","subscription_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/subscription","commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/commits{/sha}","git_commits_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/git/commits{/sha}","comments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/comments{/number}","issue_comment_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/comments{/number}","contents_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/contents/{+path}","compare_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/merges","archive_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/downloads","issues_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues{/number}","pulls_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls{/number}","milestones_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/milestones{/number}","notifications_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/labels{/name}","releases_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/releases{/id}","deployments_url":"https://api.github.com/repos/Microsoft/AdaptiveCards/deployments","created_at":"2016-12-08T22:00:33Z","updated_at":"2018-08-24T17:02:58Z","pushed_at":"2018-08-24T20:20:19Z","git_url":"git://github.com/Microsoft/AdaptiveCards.git","ssh_url":"git@github.com:Microsoft/AdaptiveCards.git","clone_url":"https://github.com/Microsoft/AdaptiveCards.git","svn_url":"https://github.com/Microsoft/AdaptiveCards","homepage":"http://adaptivecards.io","size":86014,"stargazers_count":365,"watchers_count":365,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":93,"mirror_url":null,"archived":false,"open_issues_count":348,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":93,"open_issues":348,"watchers":365,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1758"},"html":{"href":"https://github.com/Microsoft/AdaptiveCards/pull/1758"},"issue":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/1758"},"comments":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/issues/1758/comments"},"review_comments":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1758/comments"},"review_comment":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/pulls/1758/commits"},"statuses":{"href":"https://api.github.com/repos/Microsoft/AdaptiveCards/statuses/f8a602d9b37343d4f4b447a593547ce38bf7269b"}},"author_association":"MEMBER","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"tuanh118","id":3454845,"node_id":"MDQ6VXNlcjM0NTQ4NDU=","avatar_url":"https://avatars0.githubusercontent.com/u/3454845?v=4","gravatar_id":"","url":"https://api.github.com/users/tuanh118","html_url":"https://github.com/tuanh118","followers_url":"https://api.github.com/users/tuanh118/followers","following_url":"https://api.github.com/users/tuanh118/following{/other_user}","gists_url":"https://api.github.com/users/tuanh118/gists{/gist_id}","starred_url":"https://api.github.com/users/tuanh118/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tuanh118/subscriptions","organizations_url":"https://api.github.com/users/tuanh118/orgs","repos_url":"https://api.github.com/users/tuanh118/repos","events_url":"https://api.github.com/users/tuanh118/events{/privacy}","received_events_url":"https://api.github.com/users/tuanh118/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":5,"additions":57,"deletions":2,"changed_files":4}}
{"actor":{"display_login":"tuanh118"}}