{"action":"created","comment":{"url":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/comments/232296433","pull_request_review_id":173466311,"id":232296433,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMjI5NjQzMw==","diff_hunk":"@@ -722,9 +724,9 @@ private function getIncrementalQueryAddon(): ?string\n                     );\n                 } else if ($this->incrementalFetching['type'] === self::TYPE_TIMESTAMP) {\n                     $incrementalAddon = sprintf(\n-                        \" WHERE CONVERT(DATETIME2, %s, 121) > CONVERT(DATETIME2, '%s', 121)\",\n+                        \" WHERE %s > %s\",","path":"src/Keboola/DbExtractor/Extractor/MSSQL.php","position":14,"original_position":14,"commit_id":"9162b2485d842a3a1c82389e8ee72574c68895e6","original_commit_id":"9162b2485d842a3a1c82389e8ee72574c68895e6","user":{"login":"pivnicek","id":569139,"node_id":"MDQ6VXNlcjU2OTEzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/569139?v=4","gravatar_id":"","url":"https://api.github.com/users/pivnicek","html_url":"https://github.com/pivnicek","followers_url":"https://api.github.com/users/pivnicek/followers","following_url":"https://api.github.com/users/pivnicek/following{/other_user}","gists_url":"https://api.github.com/users/pivnicek/gists{/gist_id}","starred_url":"https://api.github.com/users/pivnicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivnicek/subscriptions","organizations_url":"https://api.github.com/users/pivnicek/orgs","repos_url":"https://api.github.com/users/pivnicek/repos","events_url":"https://api.github.com/users/pivnicek/events{/privacy}","received_events_url":"https://api.github.com/users/pivnicek/received_events","type":"User","site_admin":false},"body":"No, because we're getting the correct value for state now https://github.com/keboola/db-extractor-mssql/pull/85/files#diff-b62d461d3edce69713b325b36fea667dR81\r\nThat was the real fix.","created_at":"2018-11-09T15:42:10Z","updated_at":"2018-11-09T15:42:11Z","html_url":"https://github.com/keboola/db-extractor-mssql/pull/85#discussion_r232296433","pull_request_url":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/85","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/comments/232296433"},"html":{"href":"https://github.com/keboola/db-extractor-mssql/pull/85#discussion_r232296433"},"pull_request":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/85"}},"in_reply_to_id":232282176},"pull_request":{"url":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/85","id":229348189,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5MzQ4MTg5","html_url":"https://github.com/keboola/db-extractor-mssql/pull/85","diff_url":"https://github.com/keboola/db-extractor-mssql/pull/85.diff","patch_url":"https://github.com/keboola/db-extractor-mssql/pull/85.patch","issue_url":"https://api.github.com/repos/keboola/db-extractor-mssql/issues/85","number":85,"state":"open","locked":false,"title":"Fix datetime incremental fetching","user":{"login":"pivnicek","id":569139,"node_id":"MDQ6VXNlcjU2OTEzOQ==","avatar_url":"https://avatars1.githubusercontent.com/u/569139?v=4","gravatar_id":"","url":"https://api.github.com/users/pivnicek","html_url":"https://github.com/pivnicek","followers_url":"https://api.github.com/users/pivnicek/followers","following_url":"https://api.github.com/users/pivnicek/following{/other_user}","gists_url":"https://api.github.com/users/pivnicek/gists{/gist_id}","starred_url":"https://api.github.com/users/pivnicek/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/pivnicek/subscriptions","organizations_url":"https://api.github.com/users/pivnicek/orgs","repos_url":"https://api.github.com/users/pivnicek/repos","events_url":"https://api.github.com/users/pivnicek/events{/privacy}","received_events_url":"https://api.github.com/users/pivnicek/received_events","type":"User","site_admin":false},"body":"Fixes #79 and #84 ","created_at":"2018-11-08T12:28:21Z","updated_at":"2018-11-09T15:42:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"0e24726f0b42f695d2aa274d1613e0e5afba9e4a","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/85/commits","review_comments_url":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/85/comments","review_comment_url":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/comments{/number}","comments_url":"https://api.github.com/repos/keboola/db-extractor-mssql/issues/85/comments","statuses_url":"https://api.github.com/repos/keboola/db-extractor-mssql/statuses/9162b2485d842a3a1c82389e8ee72574c68895e6","head":{"label":"keboola:piv-datetime-fetch","ref":"piv-datetime-fetch","sha":"9162b2485d842a3a1c82389e8ee72574c68895e6","user":{"login":"keboola","id":1424387,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"repo":{"id":55369388,"node_id":"MDEwOlJlcG9zaXRvcnk1NTM2OTM4OA==","name":"db-extractor-mssql","full_name":"keboola/db-extractor-mssql","private":false,"owner":{"login":"keboola","id":1424387,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keboola/db-extractor-mssql","description":null,"fork":false,"url":"https://api.github.com/repos/keboola/db-extractor-mssql","forks_url":"https://api.github.com/repos/keboola/db-extractor-mssql/forks","keys_url":"https://api.github.com/repos/keboola/db-extractor-mssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keboola/db-extractor-mssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keboola/db-extractor-mssql/teams","hooks_url":"https://api.github.com/repos/keboola/db-extractor-mssql/hooks","issue_events_url":"https://api.github.com/repos/keboola/db-extractor-mssql/issues/events{/number}","events_url":"https://api.github.com/repos/keboola/db-extractor-mssql/events","assignees_url":"https://api.github.com/repos/keboola/db-extractor-mssql/assignees{/user}","branches_url":"https://api.github.com/repos/keboola/db-extractor-mssql/branches{/branch}","tags_url":"https://api.github.com/repos/keboola/db-extractor-mssql/tags","blobs_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keboola/db-extractor-mssql/statuses/{sha}","languages_url":"https://api.github.com/repos/keboola/db-extractor-mssql/languages","stargazers_url":"https://api.github.com/repos/keboola/db-extractor-mssql/stargazers","contributors_url":"https://api.github.com/repos/keboola/db-extractor-mssql/contributors","subscribers_url":"https://api.github.com/repos/keboola/db-extractor-mssql/subscribers","subscription_url":"https://api.github.com/repos/keboola/db-extractor-mssql/subscription","commits_url":"https://api.github.com/repos/keboola/db-extractor-mssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/keboola/db-extractor-mssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/keboola/db-extractor-mssql/issues/comments{/number}","contents_url":"https://api.github.com/repos/keboola/db-extractor-mssql/contents/{+path}","compare_url":"https://api.github.com/repos/keboola/db-extractor-mssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keboola/db-extractor-mssql/merges","archive_url":"https://api.github.com/repos/keboola/db-extractor-mssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keboola/db-extractor-mssql/downloads","issues_url":"https://api.github.com/repos/keboola/db-extractor-mssql/issues{/number}","pulls_url":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls{/number}","milestones_url":"https://api.github.com/repos/keboola/db-extractor-mssql/milestones{/number}","notifications_url":"https://api.github.com/repos/keboola/db-extractor-mssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keboola/db-extractor-mssql/labels{/name}","releases_url":"https://api.github.com/repos/keboola/db-extractor-mssql/releases{/id}","deployments_url":"https://api.github.com/repos/keboola/db-extractor-mssql/deployments","created_at":"2016-04-03T21:14:53Z","updated_at":"2018-11-02T14:43:43Z","pushed_at":"2018-11-08T13:19:10Z","git_url":"git://github.com/keboola/db-extractor-mssql.git","ssh_url":"git@github.com:keboola/db-extractor-mssql.git","clone_url":"https://github.com/keboola/db-extractor-mssql.git","svn_url":"https://github.com/keboola/db-extractor-mssql","homepage":null,"size":3145,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"base":{"label":"keboola:master","ref":"master","sha":"5083b70974d1bb193a10062ea973ead145e205f1","user":{"login":"keboola","id":1424387,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"repo":{"id":55369388,"node_id":"MDEwOlJlcG9zaXRvcnk1NTM2OTM4OA==","name":"db-extractor-mssql","full_name":"keboola/db-extractor-mssql","private":false,"owner":{"login":"keboola","id":1424387,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE0MjQzODc=","avatar_url":"https://avatars1.githubusercontent.com/u/1424387?v=4","gravatar_id":"","url":"https://api.github.com/users/keboola","html_url":"https://github.com/keboola","followers_url":"https://api.github.com/users/keboola/followers","following_url":"https://api.github.com/users/keboola/following{/other_user}","gists_url":"https://api.github.com/users/keboola/gists{/gist_id}","starred_url":"https://api.github.com/users/keboola/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/keboola/subscriptions","organizations_url":"https://api.github.com/users/keboola/orgs","repos_url":"https://api.github.com/users/keboola/repos","events_url":"https://api.github.com/users/keboola/events{/privacy}","received_events_url":"https://api.github.com/users/keboola/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/keboola/db-extractor-mssql","description":null,"fork":false,"url":"https://api.github.com/repos/keboola/db-extractor-mssql","forks_url":"https://api.github.com/repos/keboola/db-extractor-mssql/forks","keys_url":"https://api.github.com/repos/keboola/db-extractor-mssql/keys{/key_id}","collaborators_url":"https://api.github.com/repos/keboola/db-extractor-mssql/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/keboola/db-extractor-mssql/teams","hooks_url":"https://api.github.com/repos/keboola/db-extractor-mssql/hooks","issue_events_url":"https://api.github.com/repos/keboola/db-extractor-mssql/issues/events{/number}","events_url":"https://api.github.com/repos/keboola/db-extractor-mssql/events","assignees_url":"https://api.github.com/repos/keboola/db-extractor-mssql/assignees{/user}","branches_url":"https://api.github.com/repos/keboola/db-extractor-mssql/branches{/branch}","tags_url":"https://api.github.com/repos/keboola/db-extractor-mssql/tags","blobs_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/refs{/sha}","trees_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/trees{/sha}","statuses_url":"https://api.github.com/repos/keboola/db-extractor-mssql/statuses/{sha}","languages_url":"https://api.github.com/repos/keboola/db-extractor-mssql/languages","stargazers_url":"https://api.github.com/repos/keboola/db-extractor-mssql/stargazers","contributors_url":"https://api.github.com/repos/keboola/db-extractor-mssql/contributors","subscribers_url":"https://api.github.com/repos/keboola/db-extractor-mssql/subscribers","subscription_url":"https://api.github.com/repos/keboola/db-extractor-mssql/subscription","commits_url":"https://api.github.com/repos/keboola/db-extractor-mssql/commits{/sha}","git_commits_url":"https://api.github.com/repos/keboola/db-extractor-mssql/git/commits{/sha}","comments_url":"https://api.github.com/repos/keboola/db-extractor-mssql/comments{/number}","issue_comment_url":"https://api.github.com/repos/keboola/db-extractor-mssql/issues/comments{/number}","contents_url":"https://api.github.com/repos/keboola/db-extractor-mssql/contents/{+path}","compare_url":"https://api.github.com/repos/keboola/db-extractor-mssql/compare/{base}...{head}","merges_url":"https://api.github.com/repos/keboola/db-extractor-mssql/merges","archive_url":"https://api.github.com/repos/keboola/db-extractor-mssql/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/keboola/db-extractor-mssql/downloads","issues_url":"https://api.github.com/repos/keboola/db-extractor-mssql/issues{/number}","pulls_url":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls{/number}","milestones_url":"https://api.github.com/repos/keboola/db-extractor-mssql/milestones{/number}","notifications_url":"https://api.github.com/repos/keboola/db-extractor-mssql/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/keboola/db-extractor-mssql/labels{/name}","releases_url":"https://api.github.com/repos/keboola/db-extractor-mssql/releases{/id}","deployments_url":"https://api.github.com/repos/keboola/db-extractor-mssql/deployments","created_at":"2016-04-03T21:14:53Z","updated_at":"2018-11-02T14:43:43Z","pushed_at":"2018-11-08T13:19:10Z","git_url":"git://github.com/keboola/db-extractor-mssql.git","ssh_url":"git@github.com:keboola/db-extractor-mssql.git","clone_url":"https://github.com/keboola/db-extractor-mssql.git","svn_url":"https://github.com/keboola/db-extractor-mssql","homepage":null,"size":3145,"stargazers_count":0,"watchers_count":0,"language":"PHP","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":13,"license":null,"forks":0,"open_issues":13,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/85"},"html":{"href":"https://github.com/keboola/db-extractor-mssql/pull/85"},"issue":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/issues/85"},"comments":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/issues/85/comments"},"review_comments":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/85/comments"},"review_comment":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/pulls/85/commits"},"statuses":{"href":"https://api.github.com/repos/keboola/db-extractor-mssql/statuses/9162b2485d842a3a1c82389e8ee72574c68895e6"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"pivnicek"}}