{"action":"created","issue":{"url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/331","repository_url":"https://api.github.com/repos/cgogn/CGoGN_2","labels_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/331/labels{/name}","comments_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/331/comments","events_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/331/events","html_url":"https://github.com/cgogn/CGoGN_2/pull/331","id":269553058,"number":331,"title":"Eigen","user":{"login":"sylvainthery","id":14980816,"avatar_url":"https://avatars1.githubusercontent.com/u/14980816?v=4","gravatar_id":"","url":"https://api.github.com/users/sylvainthery","html_url":"https://github.com/sylvainthery","followers_url":"https://api.github.com/users/sylvainthery/followers","following_url":"https://api.github.com/users/sylvainthery/following{/other_user}","gists_url":"https://api.github.com/users/sylvainthery/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvainthery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvainthery/subscriptions","organizations_url":"https://api.github.com/users/sylvainthery/orgs","repos_url":"https://api.github.com/users/sylvainthery/repos","events_url":"https://api.github.com/users/sylvainthery/events{/privacy}","received_events_url":"https://api.github.com/users/sylvainthery/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2017-10-30T10:42:43Z","updated_at":"2018-02-21T17:43:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/cgogn/CGoGN_2/pulls/331","html_url":"https://github.com/cgogn/CGoGN_2/pull/331","diff_url":"https://github.com/cgogn/CGoGN_2/pull/331.diff","patch_url":"https://github.com/cgogn/CGoGN_2/pull/331.patch"},"body":"- warnings \r\n-  vector_traits ok avec les CwiseBinaryOp (et autre)\r\n\r\nMais il y a 2 gros points négatifs, pour l'écriture des fonctions:\r\n  - il faut maintenant un paramètre template (de type) par paramètre vecteur de la fonction,\r\n    ce qui n'est pas très intuitif.\r\n  - on ne peut plus déclarer de variable du type de l'un des paramètres, car ça peut être un \r\n    CwiseBinaryOp qui n'est le bon type et en plus n'est pas constructible. Il faut maintenant\r\n    déclarer un vector_traits<VEC>::Type (ou plutôt ::Self ?). Idem pour les param  VEC* p= NULL\r\n"},"comment":{"url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/comments/367409450","html_url":"https://github.com/cgogn/CGoGN_2/pull/331#issuecomment-367409450","issue_url":"https://api.github.com/repos/cgogn/CGoGN_2/issues/331","id":367409450,"user":{"login":"sylvainthery","id":14980816,"avatar_url":"https://avatars1.githubusercontent.com/u/14980816?v=4","gravatar_id":"","url":"https://api.github.com/users/sylvainthery","html_url":"https://github.com/sylvainthery","followers_url":"https://api.github.com/users/sylvainthery/followers","following_url":"https://api.github.com/users/sylvainthery/following{/other_user}","gists_url":"https://api.github.com/users/sylvainthery/gists{/gist_id}","starred_url":"https://api.github.com/users/sylvainthery/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sylvainthery/subscriptions","organizations_url":"https://api.github.com/users/sylvainthery/orgs","repos_url":"https://api.github.com/users/sylvainthery/repos","events_url":"https://api.github.com/users/sylvainthery/events{/privacy}","received_events_url":"https://api.github.com/users/sylvainthery/received_events","type":"User","site_admin":false},"created_at":"2018-02-21T17:43:36Z","updated_at":"2018-02-21T17:43:36Z","author_association":"CONTRIBUTOR","body":"Non seulement ça évite d'expliciter le param template, mais surtout sinon il ya des conflits avec \r\nlese fonctions geom avec les param non Eigen.\r\nEt pour avoir expérimenté les messages d'erreurs sont beaucoup plus clairs !\r\n"}}
{"actor":{"display_login":"sylvainthery"}}