{"action":"created","issue":{"url":"https://api.github.com/repos/danilobuerger/autocert-s3-cache/issues/4","repository_url":"https://api.github.com/repos/danilobuerger/autocert-s3-cache","labels_url":"https://api.github.com/repos/danilobuerger/autocert-s3-cache/issues/4/labels{/name}","comments_url":"https://api.github.com/repos/danilobuerger/autocert-s3-cache/issues/4/comments","events_url":"https://api.github.com/repos/danilobuerger/autocert-s3-cache/issues/4/events","html_url":"https://github.com/danilobuerger/autocert-s3-cache/pull/4","id":308377795,"number":4,"title":"S3 with DSN option","user":{"login":"njones","id":94100,"avatar_url":"https://avatars3.githubusercontent.com/u/94100?v=4","gravatar_id":"","url":"https://api.github.com/users/njones","html_url":"https://github.com/njones","followers_url":"https://api.github.com/users/njones/followers","following_url":"https://api.github.com/users/njones/following{/other_user}","gists_url":"https://api.github.com/users/njones/gists{/gist_id}","starred_url":"https://api.github.com/users/njones/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/njones/subscriptions","organizations_url":"https://api.github.com/users/njones/orgs","repos_url":"https://api.github.com/users/njones/repos","events_url":"https://api.github.com/users/njones/events{/privacy}","received_events_url":"https://api.github.com/users/njones/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":4,"created_at":"2018-03-25T19:29:53Z","updated_at":"2018-03-27T09:38:02Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/danilobuerger/autocert-s3-cache/pulls/4","html_url":"https://github.com/danilobuerger/autocert-s3-cache/pull/4","diff_url":"https://github.com/danilobuerger/autocert-s3-cache/pull/4.diff","patch_url":"https://github.com/danilobuerger/autocert-s3-cache/pull/4.patch"},"body":"Adds a `NewS3DSN` function to so that a cache can be created from a S3 DSN. With tests. "},"comment":{"url":"https://api.github.com/repos/danilobuerger/autocert-s3-cache/issues/comments/376461112","html_url":"https://github.com/danilobuerger/autocert-s3-cache/pull/4#issuecomment-376461112","issue_url":"https://api.github.com/repos/danilobuerger/autocert-s3-cache/issues/4","id":376461112,"user":{"login":"danilobuerger","id":996231,"avatar_url":"https://avatars2.githubusercontent.com/u/996231?v=4","gravatar_id":"","url":"https://api.github.com/users/danilobuerger","html_url":"https://github.com/danilobuerger","followers_url":"https://api.github.com/users/danilobuerger/followers","following_url":"https://api.github.com/users/danilobuerger/following{/other_user}","gists_url":"https://api.github.com/users/danilobuerger/gists{/gist_id}","starred_url":"https://api.github.com/users/danilobuerger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danilobuerger/subscriptions","organizations_url":"https://api.github.com/users/danilobuerger/orgs","repos_url":"https://api.github.com/users/danilobuerger/repos","events_url":"https://api.github.com/users/danilobuerger/events{/privacy}","received_events_url":"https://api.github.com/users/danilobuerger/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T09:38:02Z","updated_at":"2018-03-27T09:38:02Z","author_association":"OWNER","body":"Alright, so I thought about this, but I don't really think its appropriate for this library. I want to keep it clear in scope and I fear that including something like dsn will open the doors to other session related options. You want to add `NewStaticCredentials`, later someone wants xyz and I don't want to maintain all that. So here is what I would propose:\r\n\r\nAdd something like \r\n```\r\nfunc NewWithS3(s3 s3iface.S3API, bucket string) (*Cache, error)\r\n```\r\n\r\nThen you can still create your own library that converts dsn to s3 and do something like:\r\n\r\n```\r\ns3, bucket, err := yourLib.ParseDSN(\"s3://...\")\r\ncache, err := cache.NewWithS3(s3, bucket)\r\n```"}}
{"actor":{"display_login":"danilobuerger"}}