{"action":"created","comment":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments/224217241","pull_request_review_id":163530673,"id":224217241,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyNDIxNzI0MQ==","diff_hunk":"@@ -0,0 +1,14 @@\n+export * from '../wrappers/asset_proxy_owner';","path":"packages/abi-gen-wrappers/src/index.ts","position":1,"original_position":1,"commit_id":"ed32b37d6307a62b523a48d8376470300b58d1fb","original_commit_id":"ed32b37d6307a62b523a48d8376470300b58d1fb","user":{"login":"albrow","id":800857,"node_id":"MDQ6VXNlcjgwMDg1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/800857?v=4","gravatar_id":"","url":"https://api.github.com/users/albrow","html_url":"https://github.com/albrow","followers_url":"https://api.github.com/users/albrow/followers","following_url":"https://api.github.com/users/albrow/following{/other_user}","gists_url":"https://api.github.com/users/albrow/gists{/gist_id}","starred_url":"https://api.github.com/users/albrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albrow/subscriptions","organizations_url":"https://api.github.com/users/albrow/orgs","repos_url":"https://api.github.com/users/albrow/repos","events_url":"https://api.github.com/users/albrow/events{/privacy}","received_events_url":"https://api.github.com/users/albrow/received_events","type":"User","site_admin":false},"body":"IMO `src` should be for user-editable source code. These wrappers are generated code. What do you think?","created_at":"2018-10-10T19:47:47Z","updated_at":"2018-10-10T19:47:47Z","html_url":"https://github.com/0xProject/0x-monorepo/pull/1105#discussion_r224217241","pull_request_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1105","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments/224217241"},"html":{"href":"https://github.com/0xProject/0x-monorepo/pull/1105#discussion_r224217241"},"pull_request":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1105"}},"in_reply_to_id":224004480},"pull_request":{"url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1105","id":219550272,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE5NTUwMjcy","html_url":"https://github.com/0xProject/0x-monorepo/pull/1105","diff_url":"https://github.com/0xProject/0x-monorepo/pull/1105.diff","patch_url":"https://github.com/0xProject/0x-monorepo/pull/1105.patch","issue_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1105","number":1105,"state":"open","locked":false,"title":"[WIP] Reorganize and modularize generated contract wrappers and artifacts","user":{"login":"albrow","id":800857,"node_id":"MDQ6VXNlcjgwMDg1Nw==","avatar_url":"https://avatars3.githubusercontent.com/u/800857?v=4","gravatar_id":"","url":"https://api.github.com/users/albrow","html_url":"https://github.com/albrow","followers_url":"https://api.github.com/users/albrow/followers","following_url":"https://api.github.com/users/albrow/following{/other_user}","gists_url":"https://api.github.com/users/albrow/gists{/gist_id}","starred_url":"https://api.github.com/users/albrow/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/albrow/subscriptions","organizations_url":"https://api.github.com/users/albrow/orgs","repos_url":"https://api.github.com/users/albrow/repos","events_url":"https://api.github.com/users/albrow/events{/privacy}","received_events_url":"https://api.github.com/users/albrow/received_events","type":"User","site_admin":false},"body":"## Description\r\n\r\n<!--- Describe your changes in detail -->\r\n\r\nThis PR is a huge reorganization of how we generate, store, and copy generated files related to contracts (specifically artifacts and contract wrappers generated by abi-gen).\r\n\r\nHere's a summary of the biggest changes (some of which are not fully complete yet):\r\n\r\n~~1. The contracts package is now a public package that will be published with the name `@0xproject/contracts`\r\n2. All artifacts have been moved out of `@0xproject/migrations`  and into `@0xproject/contracts`. Artifacts are encapsulated in an npm package and have a version number indicated by a __package.json__ file. You can import artifacts with `import { artifacts } from '@0xproject/contracts'`.\r\n3. All contract wrappers have been moved into `@0xproject/contracts`. Like artifacts, they are encapsulated in an npm package. You can import them with `import { wrappers } from '@0xproject/contracts'`.\r\n4. Addresses of deployed contracts are no longer stored in artifact files. For tests, you can get the addresses of contracts that were deployed during migrations with the new `getContractAddresses` function in `@0xproject/migrations`. (I'm still not sure if I'm happy with this exact interface, but in any case there will be some mechanism to get the contract addresses after you run `runMigrationsAsync`). For contracts that have been deployed to the mainnet or various testnets, the addresses will be exposed as an object in one of our public packages (exact details TBD). This approach leads to a better separation between things that are temporary (addresses of contracts that were deployed for testing purposes) and permanent (addresses, abis, and source code of contracts that have already been deployed to mainnet or a testnet).~~\r\n\r\n(A lot has changed. See below for an [updated high-level description](#issuecomment-428388266)).\r\n\r\n## Testing instructions\r\n\r\n<!--- Please describe how reviewers can test your changes -->\r\n\r\n## Types of changes\r\n\r\n<!--- What types of changes does your code introduce? Uncomment all the bullets that apply: -->\r\n\r\n<!-- * Bug fix (non-breaking change which fixes an issue) -->\r\n\r\n<!-- * New feature (non-breaking change which adds functionality) -->\r\n\r\n* Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n\r\n<!--- The following points should be used to indicate the progress of your PR.  Put an `x` in all the boxes that apply right now, and come back over time and check them off as you make progress.  If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n\r\n*   [ ] Prefix PR title with `[WIP]` if necessary.\r\n*   [ ] Prefix PR title with bracketed package name(s) corresponding to the changed package(s). For example: `[sol-cov] Fixed bug`.\r\n*   [ ] Add tests to cover changes as needed.\r\n*   [ ] Update documentation as needed.\r\n*   [ ] Add new entries to the relevant CHANGELOG.jsons.\r\n","created_at":"2018-10-02T00:02:07Z","updated_at":"2018-10-10T19:47:47Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a19318a76630aea0da0f8056249aeb2e00e4152c","assignee":null,"assignees":[],"requested_reviewers":[{"login":"BMillman19","id":1141340,"node_id":"MDQ6VXNlcjExNDEzNDA=","avatar_url":"https://avatars0.githubusercontent.com/u/1141340?v=4","gravatar_id":"","url":"https://api.github.com/users/BMillman19","html_url":"https://github.com/BMillman19","followers_url":"https://api.github.com/users/BMillman19/followers","following_url":"https://api.github.com/users/BMillman19/following{/other_user}","gists_url":"https://api.github.com/users/BMillman19/gists{/gist_id}","starred_url":"https://api.github.com/users/BMillman19/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BMillman19/subscriptions","organizations_url":"https://api.github.com/users/BMillman19/orgs","repos_url":"https://api.github.com/users/BMillman19/repos","events_url":"https://api.github.com/users/BMillman19/events{/privacy}","received_events_url":"https://api.github.com/users/BMillman19/received_events","type":"User","site_admin":false},{"login":"fragosti","id":3066135,"node_id":"MDQ6VXNlcjMwNjYxMzU=","avatar_url":"https://avatars1.githubusercontent.com/u/3066135?v=4","gravatar_id":"","url":"https://api.github.com/users/fragosti","html_url":"https://github.com/fragosti","followers_url":"https://api.github.com/users/fragosti/followers","following_url":"https://api.github.com/users/fragosti/following{/other_user}","gists_url":"https://api.github.com/users/fragosti/gists{/gist_id}","starred_url":"https://api.github.com/users/fragosti/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fragosti/subscriptions","organizations_url":"https://api.github.com/users/fragosti/orgs","repos_url":"https://api.github.com/users/fragosti/repos","events_url":"https://api.github.com/users/fragosti/events{/privacy}","received_events_url":"https://api.github.com/users/fragosti/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":639459897,"node_id":"MDU6TGFiZWw2Mzk0NTk4OTc=","url":"https://api.github.com/repos/0xProject/0x-monorepo/labels/WIP","name":"WIP","color":"d4c5f9","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1105/commits","review_comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1105/comments","review_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments{/number}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1105/comments","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/ed32b37d6307a62b523a48d8376470300b58d1fb","head":{"label":"0xProject:feature/contracts-artifacts-re-org","ref":"feature/contracts-artifacts-re-org","sha":"ed32b37d6307a62b523a48d8376470300b58d1fb","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE4MTM3MQ==","name":"0x-monorepo","full_name":"0xProject/0x-monorepo","private":false,"owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xProject/0x-monorepo","description":"0x protocol monorepo - includes our smart contracts and many developer tools","fork":false,"url":"https://api.github.com/repos/0xProject/0x-monorepo","forks_url":"https://api.github.com/repos/0xProject/0x-monorepo/forks","keys_url":"https://api.github.com/repos/0xProject/0x-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-monorepo/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-monorepo/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/events","assignees_url":"https://api.github.com/repos/0xProject/0x-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-monorepo/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-monorepo/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-monorepo/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-monorepo/merges","archive_url":"https://api.github.com/repos/0xProject/0x-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-monorepo/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-monorepo/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-10-10T15:19:19Z","pushed_at":"2018-10-10T19:35:23Z","git_url":"git://github.com/0xProject/0x-monorepo.git","ssh_url":"git@github.com:0xProject/0x-monorepo.git","clone_url":"https://github.com/0xProject/0x-monorepo.git","svn_url":"https://github.com/0xProject/0x-monorepo","homepage":"","size":60019,"stargazers_count":835,"watchers_count":835,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":228,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":228,"open_issues":51,"watchers":835,"default_branch":"development"}},"base":{"label":"0xProject:development","ref":"development","sha":"afb34da72978b5272cfb5a235498e483c72556bc","user":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"repo":{"id":92181371,"node_id":"MDEwOlJlcG9zaXRvcnk5MjE4MTM3MQ==","name":"0x-monorepo","full_name":"0xProject/0x-monorepo","private":false,"owner":{"login":"0xProject","id":24832717,"node_id":"MDEyOk9yZ2FuaXphdGlvbjI0ODMyNzE3","avatar_url":"https://avatars2.githubusercontent.com/u/24832717?v=4","gravatar_id":"","url":"https://api.github.com/users/0xProject","html_url":"https://github.com/0xProject","followers_url":"https://api.github.com/users/0xProject/followers","following_url":"https://api.github.com/users/0xProject/following{/other_user}","gists_url":"https://api.github.com/users/0xProject/gists{/gist_id}","starred_url":"https://api.github.com/users/0xProject/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/0xProject/subscriptions","organizations_url":"https://api.github.com/users/0xProject/orgs","repos_url":"https://api.github.com/users/0xProject/repos","events_url":"https://api.github.com/users/0xProject/events{/privacy}","received_events_url":"https://api.github.com/users/0xProject/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/0xProject/0x-monorepo","description":"0x protocol monorepo - includes our smart contracts and many developer tools","fork":false,"url":"https://api.github.com/repos/0xProject/0x-monorepo","forks_url":"https://api.github.com/repos/0xProject/0x-monorepo/forks","keys_url":"https://api.github.com/repos/0xProject/0x-monorepo/keys{/key_id}","collaborators_url":"https://api.github.com/repos/0xProject/0x-monorepo/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/0xProject/0x-monorepo/teams","hooks_url":"https://api.github.com/repos/0xProject/0x-monorepo/hooks","issue_events_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/events{/number}","events_url":"https://api.github.com/repos/0xProject/0x-monorepo/events","assignees_url":"https://api.github.com/repos/0xProject/0x-monorepo/assignees{/user}","branches_url":"https://api.github.com/repos/0xProject/0x-monorepo/branches{/branch}","tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/tags","blobs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/refs{/sha}","trees_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/trees{/sha}","statuses_url":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/{sha}","languages_url":"https://api.github.com/repos/0xProject/0x-monorepo/languages","stargazers_url":"https://api.github.com/repos/0xProject/0x-monorepo/stargazers","contributors_url":"https://api.github.com/repos/0xProject/0x-monorepo/contributors","subscribers_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscribers","subscription_url":"https://api.github.com/repos/0xProject/0x-monorepo/subscription","commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/commits{/sha}","git_commits_url":"https://api.github.com/repos/0xProject/0x-monorepo/git/commits{/sha}","comments_url":"https://api.github.com/repos/0xProject/0x-monorepo/comments{/number}","issue_comment_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues/comments{/number}","contents_url":"https://api.github.com/repos/0xProject/0x-monorepo/contents/{+path}","compare_url":"https://api.github.com/repos/0xProject/0x-monorepo/compare/{base}...{head}","merges_url":"https://api.github.com/repos/0xProject/0x-monorepo/merges","archive_url":"https://api.github.com/repos/0xProject/0x-monorepo/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/0xProject/0x-monorepo/downloads","issues_url":"https://api.github.com/repos/0xProject/0x-monorepo/issues{/number}","pulls_url":"https://api.github.com/repos/0xProject/0x-monorepo/pulls{/number}","milestones_url":"https://api.github.com/repos/0xProject/0x-monorepo/milestones{/number}","notifications_url":"https://api.github.com/repos/0xProject/0x-monorepo/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/0xProject/0x-monorepo/labels{/name}","releases_url":"https://api.github.com/repos/0xProject/0x-monorepo/releases{/id}","deployments_url":"https://api.github.com/repos/0xProject/0x-monorepo/deployments","created_at":"2017-05-23T14:17:33Z","updated_at":"2018-10-10T15:19:19Z","pushed_at":"2018-10-10T19:35:23Z","git_url":"git://github.com/0xProject/0x-monorepo.git","ssh_url":"git@github.com:0xProject/0x-monorepo.git","clone_url":"https://github.com/0xProject/0x-monorepo.git","svn_url":"https://github.com/0xProject/0x-monorepo","homepage":"","size":60019,"stargazers_count":835,"watchers_count":835,"language":"TypeScript","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":228,"mirror_url":null,"archived":false,"open_issues_count":51,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":228,"open_issues":51,"watchers":835,"default_branch":"development"}},"_links":{"self":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1105"},"html":{"href":"https://github.com/0xProject/0x-monorepo/pull/1105"},"issue":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1105"},"comments":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/issues/1105/comments"},"review_comments":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1105/comments"},"review_comment":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/pulls/1105/commits"},"statuses":{"href":"https://api.github.com/repos/0xProject/0x-monorepo/statuses/ed32b37d6307a62b523a48d8376470300b58d1fb"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"albrow"}}