{"action":"created","issue":{"url":"https://api.github.com/repos/faneshion/MatchZoo/issues/228","repository_url":"https://api.github.com/repos/faneshion/MatchZoo","labels_url":"https://api.github.com/repos/faneshion/MatchZoo/issues/228/labels{/name}","comments_url":"https://api.github.com/repos/faneshion/MatchZoo/issues/228/comments","events_url":"https://api.github.com/repos/faneshion/MatchZoo/issues/228/events","html_url":"https://github.com/faneshion/MatchZoo/issues/228","id":338195058,"node_id":"MDU6SXNzdWUzMzgxOTUwNTg=","number":228,"title":"Error in rank hinge loss","user":{"login":"aneesh-joshi","id":14147383,"node_id":"MDQ6VXNlcjE0MTQ3Mzgz","avatar_url":"https://avatars2.githubusercontent.com/u/14147383?v=4","gravatar_id":"","url":"https://api.github.com/users/aneesh-joshi","html_url":"https://github.com/aneesh-joshi","followers_url":"https://api.github.com/users/aneesh-joshi/followers","following_url":"https://api.github.com/users/aneesh-joshi/following{/other_user}","gists_url":"https://api.github.com/users/aneesh-joshi/gists{/gist_id}","starred_url":"https://api.github.com/users/aneesh-joshi/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/aneesh-joshi/subscriptions","organizations_url":"https://api.github.com/users/aneesh-joshi/orgs","repos_url":"https://api.github.com/users/aneesh-joshi/repos","events_url":"https://api.github.com/users/aneesh-joshi/events{/privacy}","received_events_url":"https://api.github.com/users/aneesh-joshi/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":1,"created_at":"2018-07-04T09:17:11Z","updated_at":"2018-07-04T09:30:49Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"https://github.com/faneshion/MatchZoo/blob/50422a5bc973d27b8c507122aa3f41e633366893/matchzoo/losses/rank_losses.py#L16\r\n\r\nI am not an expert but this seems to be wrong.\r\nAll loss functions use `y_true` and `y_pred`\r\nThis function only uses `y_pred`\r\n\r\nReferences:\r\nhttps://github.com/keras-team/keras/blob/468f080c98f06780c950e5a78c9eeeaf9fff002e/keras/losses.py#L38\r\n\r\n@uduse @bwanglzu @yangliuy "},"comment":{"url":"https://api.github.com/repos/faneshion/MatchZoo/issues/comments/402422370","html_url":"https://github.com/faneshion/MatchZoo/issues/228#issuecomment-402422370","issue_url":"https://api.github.com/repos/faneshion/MatchZoo/issues/228","id":402422370,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjQyMjM3MA==","user":{"login":"bwanglzu","id":9794489,"node_id":"MDQ6VXNlcjk3OTQ0ODk=","avatar_url":"https://avatars1.githubusercontent.com/u/9794489?v=4","gravatar_id":"","url":"https://api.github.com/users/bwanglzu","html_url":"https://github.com/bwanglzu","followers_url":"https://api.github.com/users/bwanglzu/followers","following_url":"https://api.github.com/users/bwanglzu/following{/other_user}","gists_url":"https://api.github.com/users/bwanglzu/gists{/gist_id}","starred_url":"https://api.github.com/users/bwanglzu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bwanglzu/subscriptions","organizations_url":"https://api.github.com/users/bwanglzu/orgs","repos_url":"https://api.github.com/users/bwanglzu/repos","events_url":"https://api.github.com/users/bwanglzu/events{/privacy}","received_events_url":"https://api.github.com/users/bwanglzu/received_events","type":"User","site_admin":false},"created_at":"2018-07-04T09:30:49Z","updated_at":"2018-07-04T09:30:49Z","author_association":"COLLABORATOR","body":"I think the code is correct, but the implementation is kind of not easy to read, we'll clean it in 2.0, thanks! @aneesh-joshi "}}
{"actor":{"display_login":"bwanglzu"}}