{"action":"created","issue":{"url":"https://api.github.com/repos/alphagov/verify-hub/issues/70","repository_url":"https://api.github.com/repos/alphagov/verify-hub","labels_url":"https://api.github.com/repos/alphagov/verify-hub/issues/70/labels{/name}","comments_url":"https://api.github.com/repos/alphagov/verify-hub/issues/70/comments","events_url":"https://api.github.com/repos/alphagov/verify-hub/issues/70/events","html_url":"https://github.com/alphagov/verify-hub/pull/70","id":327254706,"number":70,"title":"Handle cases where validSignature is null","user":{"login":"davbo","id":330135,"avatar_url":"https://avatars3.githubusercontent.com/u/330135?v=4","gravatar_id":"","url":"https://api.github.com/users/davbo","html_url":"https://github.com/davbo","followers_url":"https://api.github.com/users/davbo/followers","following_url":"https://api.github.com/users/davbo/following{/other_user}","gists_url":"https://api.github.com/users/davbo/gists{/gist_id}","starred_url":"https://api.github.com/users/davbo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davbo/subscriptions","organizations_url":"https://api.github.com/users/davbo/orgs","repos_url":"https://api.github.com/users/davbo/repos","events_url":"https://api.github.com/users/davbo/events{/privacy}","received_events_url":"https://api.github.com/users/davbo/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":5,"created_at":"2018-05-29T10:11:39Z","updated_at":"2018-05-29T12:18:28Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/alphagov/verify-hub/pulls/70","html_url":"https://github.com/alphagov/verify-hub/pull/70","diff_url":"https://github.com/alphagov/verify-hub/pull/70.diff","patch_url":"https://github.com/alphagov/verify-hub/pull/70.patch"},"body":"In some cases the Hub will not sign Responses (relying on signed\r\nassertions) and this logging would error with a NullPointerException.\r\n\r\nThis change separates the states of not having a signature and that\r\nsignature not being valid to better represent what is happening."},"comment":{"url":"https://api.github.com/repos/alphagov/verify-hub/issues/comments/392755498","html_url":"https://github.com/alphagov/verify-hub/pull/70#issuecomment-392755498","issue_url":"https://api.github.com/repos/alphagov/verify-hub/issues/70","id":392755498,"user":{"login":"willp-bl","id":2528459,"avatar_url":"https://avatars0.githubusercontent.com/u/2528459?v=4","gravatar_id":"","url":"https://api.github.com/users/willp-bl","html_url":"https://github.com/willp-bl","followers_url":"https://api.github.com/users/willp-bl/followers","following_url":"https://api.github.com/users/willp-bl/following{/other_user}","gists_url":"https://api.github.com/users/willp-bl/gists{/gist_id}","starred_url":"https://api.github.com/users/willp-bl/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/willp-bl/subscriptions","organizations_url":"https://api.github.com/users/willp-bl/orgs","repos_url":"https://api.github.com/users/willp-bl/repos","events_url":"https://api.github.com/users/willp-bl/events{/privacy}","received_events_url":"https://api.github.com/users/willp-bl/received_events","type":"User","site_admin":false},"created_at":"2018-05-29T12:18:28Z","updated_at":"2018-05-29T12:18:28Z","author_association":"CONTRIBUTOR","body":"I don't think this will be a performance bottleneck :) Plus the compiler/JVM should work out the most efficient code path."}}
{"actor":{"display_login":"willp-bl"}}