{"action":"closed","number":6587,"pull_request":{"url":"https://api.github.com/repos/helm/charts/pulls/6587","id":200553529,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNTUzNTI5","html_url":"https://github.com/helm/charts/pull/6587","diff_url":"https://github.com/helm/charts/pull/6587.diff","patch_url":"https://github.com/helm/charts/pull/6587.patch","issue_url":"https://api.github.com/repos/helm/charts/issues/6587","number":6587,"state":"closed","locked":false,"title":"[stable/minio] Securing access to Minio on Kubernetes with TLS","user":{"login":"raru12","id":33184606,"node_id":"MDQ6VXNlcjMzMTg0NjA2","avatar_url":"https://avatars3.githubusercontent.com/u/33184606?v=4","gravatar_id":"","url":"https://api.github.com/users/raru12","html_url":"https://github.com/raru12","followers_url":"https://api.github.com/users/raru12/followers","following_url":"https://api.github.com/users/raru12/following{/other_user}","gists_url":"https://api.github.com/users/raru12/gists{/gist_id}","starred_url":"https://api.github.com/users/raru12/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/raru12/subscriptions","organizations_url":"https://api.github.com/users/raru12/orgs","repos_url":"https://api.github.com/users/raru12/repos","events_url":"https://api.github.com/users/raru12/events{/privacy}","received_events_url":"https://api.github.com/users/raru12/received_events","type":"User","site_admin":false},"body":"<!--\r\nThank you for contributing to kubernetes/charts. Before you submit this PR we'd like to\r\nmake sure you are aware of our technical requirements and best practices:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/CONTRIBUTING.md#technical-requirements\r\n* https://github.com/kubernetes/helm/tree/master/docs/chart_best_practices\r\n\r\nFor a quick overview across what we will look at reviewing your PR, please read\r\nour review guidelines:\r\n\r\n* https://github.com/kubernetes/charts/blob/master/REVIEW_GUIDELINES.md\r\n\r\nFollowing our best practices right from the start will accelerate the review process and\r\nhelp get your PR merged quicker.\r\n\r\nWhen updates to your PR are requested, please add new commits and do not squash the\r\nhistory. This will make it easier to identify new changes. The PR will be squashed\r\nanyways when it is merged. Thanks.\r\n\r\nFor fast feedback, please @-mention maintainers that are listed in the Chart.yaml file.\r\n\r\nPlease make sure you test your changes before you push them. Once pushed, a CircleCI\r\nwill run across your changes and do some initial checks and linting. These checks run\r\nvery quickly. Please check the results. We would like these checks to pass before we\r\neven continue reviewing your changes.\r\n-->\r\n\r\n**What this PR does / why we need it**: This PR contains updates to chart that will give users an option to enable SSL for secure access to Minio. \r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #\r\n\r\n**Special notes for your reviewer**: References have been taken from similar kind of implementation in this chart - https://github.com/kubernetes/charts/tree/master/stable/mysql\r\nUpdates as per the minio documentation from here - https://github.com/minio/minio/tree/master/docs/tls/kubernetes\r\n","created_at":"2018-07-10T23:53:13Z","updated_at":"2018-10-02T18:35:14Z","closed_at":"2018-10-02T18:35:14Z","merged_at":null,"merge_commit_sha":"e61359d708d0191bd49e8b4e04004a5aeab02904","assignee":null,"assignees":[],"requested_reviewers":[{"login":"scottrigby","id":407675,"node_id":"MDQ6VXNlcjQwNzY3NQ==","avatar_url":"https://avatars2.githubusercontent.com/u/407675?v=4","gravatar_id":"","url":"https://api.github.com/users/scottrigby","html_url":"https://github.com/scottrigby","followers_url":"https://api.github.com/users/scottrigby/followers","following_url":"https://api.github.com/users/scottrigby/following{/other_user}","gists_url":"https://api.github.com/users/scottrigby/gists{/gist_id}","starred_url":"https://api.github.com/users/scottrigby/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/scottrigby/subscriptions","organizations_url":"https://api.github.com/users/scottrigby/orgs","repos_url":"https://api.github.com/users/scottrigby/repos","events_url":"https://api.github.com/users/scottrigby/events{/privacy}","received_events_url":"https://api.github.com/users/scottrigby/received_events","type":"User","site_admin":false},{"login":"viglesiasce","id":410279,"node_id":"MDQ6VXNlcjQxMDI3OQ==","avatar_url":"https://avatars2.githubusercontent.com/u/410279?v=4","gravatar_id":"","url":"https://api.github.com/users/viglesiasce","html_url":"https://github.com/viglesiasce","followers_url":"https://api.github.com/users/viglesiasce/followers","following_url":"https://api.github.com/users/viglesiasce/following{/other_user}","gists_url":"https://api.github.com/users/viglesiasce/gists{/gist_id}","starred_url":"https://api.github.com/users/viglesiasce/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/viglesiasce/subscriptions","organizations_url":"https://api.github.com/users/viglesiasce/orgs","repos_url":"https://api.github.com/users/viglesiasce/repos","events_url":"https://api.github.com/users/viglesiasce/events{/privacy}","received_events_url":"https://api.github.com/users/viglesiasce/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[{"id":1037076588,"node_id":"MDU6TGFiZWwxMDM3MDc2NTg4","url":"https://api.github.com/repos/helm/charts/labels/Contribution%20Allowed","name":"Contribution Allowed","color":"3df47d","default":false},{"id":484586588,"node_id":"MDU6TGFiZWw0ODQ1ODY1ODg=","url":"https://api.github.com/repos/helm/charts/labels/cncf-cla:%20yes","name":"cncf-cla: yes","color":"bfe5bf","default":false},{"id":778124484,"node_id":"MDU6TGFiZWw3NzgxMjQ0ODQ=","url":"https://api.github.com/repos/helm/charts/labels/lifecycle/stale","name":"lifecycle/stale","color":"795548","default":false},{"id":582594847,"node_id":"MDU6TGFiZWw1ODI1OTQ4NDc=","url":"https://api.github.com/repos/helm/charts/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":676477477,"node_id":"MDU6TGFiZWw2NzY0Nzc0Nzc=","url":"https://api.github.com/repos/helm/charts/labels/size/M","name":"size/M","color":"eebb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/helm/charts/pulls/6587/commits","review_comments_url":"https://api.github.com/repos/helm/charts/pulls/6587/comments","review_comment_url":"https://api.github.com/repos/helm/charts/pulls/comments{/number}","comments_url":"https://api.github.com/repos/helm/charts/issues/6587/comments","statuses_url":"https://api.github.com/repos/helm/charts/statuses/ef4e605c0ce60f92559c5c8dcaf758923a28ce02","head":{"label":"gdpredge:master","ref":"master","sha":"ef4e605c0ce60f92559c5c8dcaf758923a28ce02","user":{"login":"gdpredge","id":40775650,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzc1NjUw","avatar_url":"https://avatars2.githubusercontent.com/u/40775650?v=4","gravatar_id":"","url":"https://api.github.com/users/gdpredge","html_url":"https://github.com/gdpredge","followers_url":"https://api.github.com/users/gdpredge/followers","following_url":"https://api.github.com/users/gdpredge/following{/other_user}","gists_url":"https://api.github.com/users/gdpredge/gists{/gist_id}","starred_url":"https://api.github.com/users/gdpredge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdpredge/subscriptions","organizations_url":"https://api.github.com/users/gdpredge/orgs","repos_url":"https://api.github.com/users/gdpredge/repos","events_url":"https://api.github.com/users/gdpredge/events{/privacy}","received_events_url":"https://api.github.com/users/gdpredge/received_events","type":"Organization","site_admin":false},"repo":{"id":139496055,"node_id":"MDEwOlJlcG9zaXRvcnkxMzk0OTYwNTU=","name":"charts","full_name":"gdpredge/charts","private":false,"owner":{"login":"gdpredge","id":40775650,"node_id":"MDEyOk9yZ2FuaXphdGlvbjQwNzc1NjUw","avatar_url":"https://avatars2.githubusercontent.com/u/40775650?v=4","gravatar_id":"","url":"https://api.github.com/users/gdpredge","html_url":"https://github.com/gdpredge","followers_url":"https://api.github.com/users/gdpredge/followers","following_url":"https://api.github.com/users/gdpredge/following{/other_user}","gists_url":"https://api.github.com/users/gdpredge/gists{/gist_id}","starred_url":"https://api.github.com/users/gdpredge/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/gdpredge/subscriptions","organizations_url":"https://api.github.com/users/gdpredge/orgs","repos_url":"https://api.github.com/users/gdpredge/repos","events_url":"https://api.github.com/users/gdpredge/events{/privacy}","received_events_url":"https://api.github.com/users/gdpredge/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/gdpredge/charts","description":"Curated applications for Kubernetes","fork":true,"url":"https://api.github.com/repos/gdpredge/charts","forks_url":"https://api.github.com/repos/gdpredge/charts/forks","keys_url":"https://api.github.com/repos/gdpredge/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/gdpredge/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/gdpredge/charts/teams","hooks_url":"https://api.github.com/repos/gdpredge/charts/hooks","issue_events_url":"https://api.github.com/repos/gdpredge/charts/issues/events{/number}","events_url":"https://api.github.com/repos/gdpredge/charts/events","assignees_url":"https://api.github.com/repos/gdpredge/charts/assignees{/user}","branches_url":"https://api.github.com/repos/gdpredge/charts/branches{/branch}","tags_url":"https://api.github.com/repos/gdpredge/charts/tags","blobs_url":"https://api.github.com/repos/gdpredge/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/gdpredge/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/gdpredge/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/gdpredge/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/gdpredge/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/gdpredge/charts/languages","stargazers_url":"https://api.github.com/repos/gdpredge/charts/stargazers","contributors_url":"https://api.github.com/repos/gdpredge/charts/contributors","subscribers_url":"https://api.github.com/repos/gdpredge/charts/subscribers","subscription_url":"https://api.github.com/repos/gdpredge/charts/subscription","commits_url":"https://api.github.com/repos/gdpredge/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/gdpredge/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/gdpredge/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/gdpredge/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/gdpredge/charts/contents/{+path}","compare_url":"https://api.github.com/repos/gdpredge/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/gdpredge/charts/merges","archive_url":"https://api.github.com/repos/gdpredge/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/gdpredge/charts/downloads","issues_url":"https://api.github.com/repos/gdpredge/charts/issues{/number}","pulls_url":"https://api.github.com/repos/gdpredge/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/gdpredge/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/gdpredge/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/gdpredge/charts/labels{/name}","releases_url":"https://api.github.com/repos/gdpredge/charts/releases{/id}","deployments_url":"https://api.github.com/repos/gdpredge/charts/deployments","created_at":"2018-07-02T21:17:21Z","updated_at":"2018-07-19T19:52:42Z","pushed_at":"2018-09-07T05:00:02Z","git_url":"git://github.com/gdpredge/charts.git","ssh_url":"git@github.com:gdpredge/charts.git","clone_url":"https://github.com/gdpredge/charts.git","svn_url":"https://github.com/gdpredge/charts","homepage":"","size":11737,"stargazers_count":1,"watchers_count":1,"language":"Smarty","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"helm:master","ref":"master","sha":"4c2e8e376fd111d1ac4e90671e7bfb37c4930830","user":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"repo":{"id":46806184,"node_id":"MDEwOlJlcG9zaXRvcnk0NjgwNjE4NA==","name":"charts","full_name":"helm/charts","private":false,"owner":{"login":"helm","id":15859888,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE1ODU5ODg4","avatar_url":"https://avatars2.githubusercontent.com/u/15859888?v=4","gravatar_id":"","url":"https://api.github.com/users/helm","html_url":"https://github.com/helm","followers_url":"https://api.github.com/users/helm/followers","following_url":"https://api.github.com/users/helm/following{/other_user}","gists_url":"https://api.github.com/users/helm/gists{/gist_id}","starred_url":"https://api.github.com/users/helm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/helm/subscriptions","organizations_url":"https://api.github.com/users/helm/orgs","repos_url":"https://api.github.com/users/helm/repos","events_url":"https://api.github.com/users/helm/events{/privacy}","received_events_url":"https://api.github.com/users/helm/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/helm/charts","description":"Curated applications for Kubernetes","fork":false,"url":"https://api.github.com/repos/helm/charts","forks_url":"https://api.github.com/repos/helm/charts/forks","keys_url":"https://api.github.com/repos/helm/charts/keys{/key_id}","collaborators_url":"https://api.github.com/repos/helm/charts/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/helm/charts/teams","hooks_url":"https://api.github.com/repos/helm/charts/hooks","issue_events_url":"https://api.github.com/repos/helm/charts/issues/events{/number}","events_url":"https://api.github.com/repos/helm/charts/events","assignees_url":"https://api.github.com/repos/helm/charts/assignees{/user}","branches_url":"https://api.github.com/repos/helm/charts/branches{/branch}","tags_url":"https://api.github.com/repos/helm/charts/tags","blobs_url":"https://api.github.com/repos/helm/charts/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/helm/charts/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/helm/charts/git/refs{/sha}","trees_url":"https://api.github.com/repos/helm/charts/git/trees{/sha}","statuses_url":"https://api.github.com/repos/helm/charts/statuses/{sha}","languages_url":"https://api.github.com/repos/helm/charts/languages","stargazers_url":"https://api.github.com/repos/helm/charts/stargazers","contributors_url":"https://api.github.com/repos/helm/charts/contributors","subscribers_url":"https://api.github.com/repos/helm/charts/subscribers","subscription_url":"https://api.github.com/repos/helm/charts/subscription","commits_url":"https://api.github.com/repos/helm/charts/commits{/sha}","git_commits_url":"https://api.github.com/repos/helm/charts/git/commits{/sha}","comments_url":"https://api.github.com/repos/helm/charts/comments{/number}","issue_comment_url":"https://api.github.com/repos/helm/charts/issues/comments{/number}","contents_url":"https://api.github.com/repos/helm/charts/contents/{+path}","compare_url":"https://api.github.com/repos/helm/charts/compare/{base}...{head}","merges_url":"https://api.github.com/repos/helm/charts/merges","archive_url":"https://api.github.com/repos/helm/charts/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/helm/charts/downloads","issues_url":"https://api.github.com/repos/helm/charts/issues{/number}","pulls_url":"https://api.github.com/repos/helm/charts/pulls{/number}","milestones_url":"https://api.github.com/repos/helm/charts/milestones{/number}","notifications_url":"https://api.github.com/repos/helm/charts/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/helm/charts/labels{/name}","releases_url":"https://api.github.com/repos/helm/charts/releases{/id}","deployments_url":"https://api.github.com/repos/helm/charts/deployments","created_at":"2015-11-24T17:05:28Z","updated_at":"2018-10-02T18:21:37Z","pushed_at":"2018-10-02T18:31:15Z","git_url":"git://github.com/helm/charts.git","ssh_url":"git@github.com:helm/charts.git","clone_url":"https://github.com/helm/charts.git","svn_url":"https://github.com/helm/charts","homepage":"","size":12433,"stargazers_count":4857,"watchers_count":4857,"language":"Smarty","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":4315,"mirror_url":null,"archived":false,"open_issues_count":581,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":4315,"open_issues":581,"watchers":4857,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/helm/charts/pulls/6587"},"html":{"href":"https://github.com/helm/charts/pull/6587"},"issue":{"href":"https://api.github.com/repos/helm/charts/issues/6587"},"comments":{"href":"https://api.github.com/repos/helm/charts/issues/6587/comments"},"review_comments":{"href":"https://api.github.com/repos/helm/charts/pulls/6587/comments"},"review_comment":{"href":"https://api.github.com/repos/helm/charts/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/helm/charts/pulls/6587/commits"},"statuses":{"href":"https://api.github.com/repos/helm/charts/statuses/ef4e605c0ce60f92559c5c8dcaf758923a28ce02"}},"author_association":"NONE","merged":false,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":null,"comments":5,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":75,"deletions":0,"changed_files":4}}
{"actor":{"display_login":"stale"}}