{"action":"created","comment":{"url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/comments/208911792","pull_request_review_id":144818356,"id":208911792,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwODkxMTc5Mg==","diff_hunk":"@@ -260,7 +262,7 @@ void QgsQuickAttributeFormModelBase::flatten( QgsAttributeEditorContainer *conta\n         item->setData( QStringLiteral( \"field\" ), QgsQuickAttributeFormModel::ElementType );\n         item->setData( fieldIndex, QgsQuickAttributeFormModel::FieldIndex );\n         item->setData( container->isGroupBox() ? container->name() : QString(), QgsQuickAttributeFormModel::Group );\n-        item->setData( true, QgsQuickAttributeFormModel::CurrentlyVisible );\n+        item->setData( fieldName != QStringLiteral( \"uuid\" ) && fieldName != QStringLiteral( \"fid\" ), QgsQuickAttributeFormModel::CurrentlyVisible );","path":"src/quickgui/attributes/qgsquickattributeformmodelbase.cpp","position":23,"original_position":23,"commit_id":"babcd8ee25d56b82e9b0d191827641e9d1fe0e18","original_commit_id":"babcd8ee25d56b82e9b0d191827641e9d1fe0e18","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"body":"we are here in QGIS library, not sure why there should be hardcoded \"uuid\" or \"fid\" or anything like that.","created_at":"2018-08-09T12:35:41Z","updated_at":"2018-08-09T12:48:46Z","html_url":"https://github.com/PeterPetrik/QGIS/pull/14#discussion_r208911792","pull_request_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/14","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/comments/208911792"},"html":{"href":"https://github.com/PeterPetrik/QGIS/pull/14#discussion_r208911792"},"pull_request":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/14","id":207300754,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA3MzAwNzU0","html_url":"https://github.com/PeterPetrik/QGIS/pull/14","diff_url":"https://github.com/PeterPetrik/QGIS/pull/14.diff","patch_url":"https://github.com/PeterPetrik/QGIS/pull/14.patch","issue_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/14","number":14,"state":"open","locked":false,"title":"Added alias role and using it for field label","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-08-09T12:33:25Z","updated_at":"2018-08-09T12:48:46Z","closed_at":null,"merged_at":null,"merge_commit_sha":"71e134b337f64489a5009662561db1475dea6d23","assignee":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"assignees":[{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/14/commits","review_comments_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/14/comments","review_comment_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/14/comments","statuses_url":"https://api.github.com/repos/PeterPetrik/QGIS/statuses/babcd8ee25d56b82e9b0d191827641e9d1fe0e18","head":{"label":"PeterPetrik:qgsquick_feature_form_improvements","ref":"qgsquick_feature_form_improvements","sha":"babcd8ee25d56b82e9b0d191827641e9d1fe0e18","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"repo":{"id":38666026,"node_id":"MDEwOlJlcG9zaXRvcnkzODY2NjAyNg==","name":"QGIS","full_name":"PeterPetrik/QGIS","owner":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PeterPetrik/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/PeterPetrik/QGIS","forks_url":"https://api.github.com/repos/PeterPetrik/QGIS/forks","keys_url":"https://api.github.com/repos/PeterPetrik/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeterPetrik/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeterPetrik/QGIS/teams","hooks_url":"https://api.github.com/repos/PeterPetrik/QGIS/hooks","issue_events_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/PeterPetrik/QGIS/events","assignees_url":"https://api.github.com/repos/PeterPetrik/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/PeterPetrik/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/tags","blobs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeterPetrik/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/PeterPetrik/QGIS/languages","stargazers_url":"https://api.github.com/repos/PeterPetrik/QGIS/stargazers","contributors_url":"https://api.github.com/repos/PeterPetrik/QGIS/contributors","subscribers_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscribers","subscription_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscription","commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeterPetrik/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeterPetrik/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/PeterPetrik/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeterPetrik/QGIS/merges","archive_url":"https://api.github.com/repos/PeterPetrik/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeterPetrik/QGIS/downloads","issues_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/PeterPetrik/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/PeterPetrik/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeterPetrik/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/PeterPetrik/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/PeterPetrik/QGIS/deployments","created_at":"2015-07-07T05:24:42Z","updated_at":"2018-08-06T05:31:28Z","pushed_at":"2018-08-09T12:33:26Z","git_url":"git://github.com/PeterPetrik/QGIS.git","ssh_url":"git@github.com:PeterPetrik/QGIS.git","clone_url":"https://github.com/PeterPetrik/QGIS.git","svn_url":"https://github.com/PeterPetrik/QGIS","homepage":"http://qgis.org","size":1384128,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"base":{"label":"PeterPetrik:master","ref":"master","sha":"51b63e6b466d330cdf0e885b73658a38bd7a4a97","user":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"repo":{"id":38666026,"node_id":"MDEwOlJlcG9zaXRvcnkzODY2NjAyNg==","name":"QGIS","full_name":"PeterPetrik/QGIS","owner":{"login":"PeterPetrik","id":804608,"node_id":"MDQ6VXNlcjgwNDYwOA==","avatar_url":"https://avatars2.githubusercontent.com/u/804608?v=4","gravatar_id":"","url":"https://api.github.com/users/PeterPetrik","html_url":"https://github.com/PeterPetrik","followers_url":"https://api.github.com/users/PeterPetrik/followers","following_url":"https://api.github.com/users/PeterPetrik/following{/other_user}","gists_url":"https://api.github.com/users/PeterPetrik/gists{/gist_id}","starred_url":"https://api.github.com/users/PeterPetrik/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PeterPetrik/subscriptions","organizations_url":"https://api.github.com/users/PeterPetrik/orgs","repos_url":"https://api.github.com/users/PeterPetrik/repos","events_url":"https://api.github.com/users/PeterPetrik/events{/privacy}","received_events_url":"https://api.github.com/users/PeterPetrik/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/PeterPetrik/QGIS","description":"QGIS is a free, open source, cross platform (lin/win/mac) geographical information system (GIS)","fork":true,"url":"https://api.github.com/repos/PeterPetrik/QGIS","forks_url":"https://api.github.com/repos/PeterPetrik/QGIS/forks","keys_url":"https://api.github.com/repos/PeterPetrik/QGIS/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PeterPetrik/QGIS/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PeterPetrik/QGIS/teams","hooks_url":"https://api.github.com/repos/PeterPetrik/QGIS/hooks","issue_events_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/events{/number}","events_url":"https://api.github.com/repos/PeterPetrik/QGIS/events","assignees_url":"https://api.github.com/repos/PeterPetrik/QGIS/assignees{/user}","branches_url":"https://api.github.com/repos/PeterPetrik/QGIS/branches{/branch}","tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/tags","blobs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/refs{/sha}","trees_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PeterPetrik/QGIS/statuses/{sha}","languages_url":"https://api.github.com/repos/PeterPetrik/QGIS/languages","stargazers_url":"https://api.github.com/repos/PeterPetrik/QGIS/stargazers","contributors_url":"https://api.github.com/repos/PeterPetrik/QGIS/contributors","subscribers_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscribers","subscription_url":"https://api.github.com/repos/PeterPetrik/QGIS/subscription","commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/commits{/sha}","git_commits_url":"https://api.github.com/repos/PeterPetrik/QGIS/git/commits{/sha}","comments_url":"https://api.github.com/repos/PeterPetrik/QGIS/comments{/number}","issue_comment_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues/comments{/number}","contents_url":"https://api.github.com/repos/PeterPetrik/QGIS/contents/{+path}","compare_url":"https://api.github.com/repos/PeterPetrik/QGIS/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PeterPetrik/QGIS/merges","archive_url":"https://api.github.com/repos/PeterPetrik/QGIS/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PeterPetrik/QGIS/downloads","issues_url":"https://api.github.com/repos/PeterPetrik/QGIS/issues{/number}","pulls_url":"https://api.github.com/repos/PeterPetrik/QGIS/pulls{/number}","milestones_url":"https://api.github.com/repos/PeterPetrik/QGIS/milestones{/number}","notifications_url":"https://api.github.com/repos/PeterPetrik/QGIS/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PeterPetrik/QGIS/labels{/name}","releases_url":"https://api.github.com/repos/PeterPetrik/QGIS/releases{/id}","deployments_url":"https://api.github.com/repos/PeterPetrik/QGIS/deployments","created_at":"2015-07-07T05:24:42Z","updated_at":"2018-08-06T05:31:28Z","pushed_at":"2018-08-09T12:33:26Z","git_url":"git://github.com/PeterPetrik/QGIS.git","ssh_url":"git@github.com:PeterPetrik/QGIS.git","clone_url":"https://github.com/PeterPetrik/QGIS.git","svn_url":"https://github.com/PeterPetrik/QGIS","homepage":"http://qgis.org","size":1384128,"stargazers_count":1,"watchers_count":1,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"gpl-2.0","name":"GNU General Public License v2.0","spdx_id":"GPL-2.0","url":"https://api.github.com/licenses/gpl-2.0","node_id":"MDc6TGljZW5zZTg="},"forks":0,"open_issues":1,"watchers":1,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/14"},"html":{"href":"https://github.com/PeterPetrik/QGIS/pull/14"},"issue":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/issues/14"},"comments":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/PeterPetrik/QGIS/statuses/babcd8ee25d56b82e9b0d191827641e9d1fe0e18"}},"author_association":"OWNER"}}
{"actor":{"display_login":"PeterPetrik"}}