{"action":"created","comment":{"url":"https://api.github.com/repos/minio/minio/pulls/comments/233165166","pull_request_review_id":174515536,"id":233165166,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzE2NTE2Ng==","diff_hunk":"@@ -597,3 +599,61 @@ func (g *GetObjectReader) Read(p []byte) (n int, err error) {\n \t}\n \treturn\n }\n+\n+//SealMD5CurrFn seals md5sum with object encryption key and returns sealed\n+// md5sum\n+type SealMD5CurrFn func([]byte) []byte\n+\n+// PutObjReaders is a type that wraps sio.EncryptReader and\n+// underlying hash.Reader in a struct\n+type PutObjReaders struct {","path":"cmd/object-api-utils.go","position":null,"original_position":27,"commit_id":"56c01b9a78d5036d0efd672caab5b74ba9587003","original_commit_id":"945202c1c2c05075d2a8386068f974baabdca951","user":{"login":"poornas","id":791968,"node_id":"MDQ6VXNlcjc5MTk2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/791968?v=4","gravatar_id":"","url":"https://api.github.com/users/poornas","html_url":"https://github.com/poornas","followers_url":"https://api.github.com/users/poornas/followers","following_url":"https://api.github.com/users/poornas/following{/other_user}","gists_url":"https://api.github.com/users/poornas/gists{/gist_id}","starred_url":"https://api.github.com/users/poornas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poornas/subscriptions","organizations_url":"https://api.github.com/users/poornas/orgs","repos_url":"https://api.github.com/users/poornas/repos","events_url":"https://api.github.com/users/poornas/events{/privacy}","received_events_url":"https://api.github.com/users/poornas/received_events","type":"User","site_admin":false},"body":"done.","created_at":"2018-11-13T18:19:45Z","updated_at":"2018-11-13T18:19:45Z","html_url":"https://github.com/minio/minio/pull/6680#discussion_r233165166","pull_request_url":"https://api.github.com/repos/minio/minio/pulls/6680","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/comments/233165166"},"html":{"href":"https://github.com/minio/minio/pull/6680#discussion_r233165166"},"pull_request":{"href":"https://api.github.com/repos/minio/minio/pulls/6680"}},"in_reply_to_id":232869442},"pull_request":{"url":"https://api.github.com/repos/minio/minio/pulls/6680","id":224752103,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI0NzUyMTAz","html_url":"https://github.com/minio/minio/pull/6680","diff_url":"https://github.com/minio/minio/pull/6680.diff","patch_url":"https://github.com/minio/minio/pull/6680.patch","issue_url":"https://api.github.com/repos/minio/minio/issues/6680","number":6680,"state":"open","locked":false,"title":"Fix: Preserve MD5Sum for SSE encrypted objects","user":{"login":"poornas","id":791968,"node_id":"MDQ6VXNlcjc5MTk2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/791968?v=4","gravatar_id":"","url":"https://api.github.com/users/poornas","html_url":"https://github.com/poornas","followers_url":"https://api.github.com/users/poornas/followers","following_url":"https://api.github.com/users/poornas/following{/other_user}","gists_url":"https://api.github.com/users/poornas/gists{/gist_id}","starred_url":"https://api.github.com/users/poornas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poornas/subscriptions","organizations_url":"https://api.github.com/users/poornas/orgs","repos_url":"https://api.github.com/users/poornas/repos","events_url":"https://api.github.com/users/poornas/events{/privacy}","received_events_url":"https://api.github.com/users/poornas/received_events","type":"User","site_admin":false},"body":"To conform with AWS S3 Spec on ETag for SSE-S3 encrypted objects,\r\nencrypt client sent MD5Sum and store it n backend as ETag.Extend\r\nthis behavior to SSE-C encrypted objects.\r\n\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n## Description\r\n<!--- Describe your changes in detail -->\r\nFixes #6580 for minio server. Unable to reopen https://github.com/minio/minio/pull/6680 which was closed due to github issues yesterday and could not update PR for travis test failures.\r\n## Motivation and Context\r\n<!--- Why is this change required? What problem does it solve? -->\r\n<!--- If it fixes an open issue, please link to the issue here. -->\r\nS3 spec specifies that content MD5Sum to be returned as Etag for single PUT,Upload Part operations where client requests SSE-S3 encryption. This PR makes minio server conformant to S3 spec.\r\n## Regression\r\n<!-- Is this PR fixing a regression? (Yes / No) --> No ( Incorrectly implemented because we were returning encrypted MD5Sum as ETag)\r\n<!-- If Yes, optionally please include minio version or commit id or PR# that caused this regression, if you have these details. -->\r\n\r\n## How Has This Been Tested?\r\n<!--- Please describe in detail how you tested your changes. -->\r\n<!--- Include details of your testing environment, and the tests you ran to -->\r\n<!--- see how your change affects other areas of the code, etc. -->\r\nmanually with awscli & minio KMS settings(MINIO_SSE_VAULT_ENDPOINT etc)[See KMS documentation)\r\n\r\n## Types of changes\r\n<!--- What types of changes does your code introduce? Put an `x` in all the boxes that apply: -->\r\n- [x] Bug fix (non-breaking change which fixes an issue)\r\n- [ ] New feature (non-breaking change which adds functionality)\r\n- [ ] Breaking change (fix or feature that would cause existing functionality to change)\r\n\r\n## Checklist:\r\n<!--- Go over all the following points, and put an `x` in all the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] My code follows the code style of this project.\r\n- [ ] My change requires a change to the documentation.\r\n- [ ] I have updated the documentation accordingly.\r\n- [ ] I have added unit tests to cover my changes.\r\n- [ ] I have added/updated functional tests in [mint](https://github.com/minio/mint). (If yes, add `mint` PR # here: )\r\n- [x] All new and existing tests passed.","created_at":"2018-10-22T17:25:33Z","updated_at":"2018-11-13T18:19:45Z","closed_at":null,"merged_at":null,"merge_commit_sha":"8b35f401f29079506838dfddae8680f2f49c3b55","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/minio/minio/pulls/6680/commits","review_comments_url":"https://api.github.com/repos/minio/minio/pulls/6680/comments","review_comment_url":"https://api.github.com/repos/minio/minio/pulls/comments{/number}","comments_url":"https://api.github.com/repos/minio/minio/issues/6680/comments","statuses_url":"https://api.github.com/repos/minio/minio/statuses/56c01b9a78d5036d0efd672caab5b74ba9587003","head":{"label":"poornas:encryptetag","ref":"encryptetag","sha":"56c01b9a78d5036d0efd672caab5b74ba9587003","user":{"login":"poornas","id":791968,"node_id":"MDQ6VXNlcjc5MTk2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/791968?v=4","gravatar_id":"","url":"https://api.github.com/users/poornas","html_url":"https://github.com/poornas","followers_url":"https://api.github.com/users/poornas/followers","following_url":"https://api.github.com/users/poornas/following{/other_user}","gists_url":"https://api.github.com/users/poornas/gists{/gist_id}","starred_url":"https://api.github.com/users/poornas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poornas/subscriptions","organizations_url":"https://api.github.com/users/poornas/orgs","repos_url":"https://api.github.com/users/poornas/repos","events_url":"https://api.github.com/users/poornas/events{/privacy}","received_events_url":"https://api.github.com/users/poornas/received_events","type":"User","site_admin":false},"repo":{"id":88773605,"node_id":"MDEwOlJlcG9zaXRvcnk4ODc3MzYwNQ==","name":"minio","full_name":"poornas/minio","private":false,"owner":{"login":"poornas","id":791968,"node_id":"MDQ6VXNlcjc5MTk2OA==","avatar_url":"https://avatars0.githubusercontent.com/u/791968?v=4","gravatar_id":"","url":"https://api.github.com/users/poornas","html_url":"https://github.com/poornas","followers_url":"https://api.github.com/users/poornas/followers","following_url":"https://api.github.com/users/poornas/following{/other_user}","gists_url":"https://api.github.com/users/poornas/gists{/gist_id}","starred_url":"https://api.github.com/users/poornas/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/poornas/subscriptions","organizations_url":"https://api.github.com/users/poornas/orgs","repos_url":"https://api.github.com/users/poornas/repos","events_url":"https://api.github.com/users/poornas/events{/privacy}","received_events_url":"https://api.github.com/users/poornas/received_events","type":"User","site_admin":false},"html_url":"https://github.com/poornas/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":true,"url":"https://api.github.com/repos/poornas/minio","forks_url":"https://api.github.com/repos/poornas/minio/forks","keys_url":"https://api.github.com/repos/poornas/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/poornas/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/poornas/minio/teams","hooks_url":"https://api.github.com/repos/poornas/minio/hooks","issue_events_url":"https://api.github.com/repos/poornas/minio/issues/events{/number}","events_url":"https://api.github.com/repos/poornas/minio/events","assignees_url":"https://api.github.com/repos/poornas/minio/assignees{/user}","branches_url":"https://api.github.com/repos/poornas/minio/branches{/branch}","tags_url":"https://api.github.com/repos/poornas/minio/tags","blobs_url":"https://api.github.com/repos/poornas/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/poornas/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/poornas/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/poornas/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/poornas/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/poornas/minio/languages","stargazers_url":"https://api.github.com/repos/poornas/minio/stargazers","contributors_url":"https://api.github.com/repos/poornas/minio/contributors","subscribers_url":"https://api.github.com/repos/poornas/minio/subscribers","subscription_url":"https://api.github.com/repos/poornas/minio/subscription","commits_url":"https://api.github.com/repos/poornas/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/poornas/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/poornas/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/poornas/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/poornas/minio/contents/{+path}","compare_url":"https://api.github.com/repos/poornas/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/poornas/minio/merges","archive_url":"https://api.github.com/repos/poornas/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/poornas/minio/downloads","issues_url":"https://api.github.com/repos/poornas/minio/issues{/number}","pulls_url":"https://api.github.com/repos/poornas/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/poornas/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/poornas/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/poornas/minio/labels{/name}","releases_url":"https://api.github.com/repos/poornas/minio/releases{/id}","deployments_url":"https://api.github.com/repos/poornas/minio/deployments","created_at":"2017-04-19T17:45:44Z","updated_at":"2017-04-19T17:45:47Z","pushed_at":"2018-11-13T18:15:20Z","git_url":"git://github.com/poornas/minio.git","ssh_url":"git@github.com:poornas/minio.git","clone_url":"https://github.com/poornas/minio.git","svn_url":"https://github.com/poornas/minio","homepage":"https://minio.io","size":45524,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"minio:master","ref":"master","sha":"2447bb58ddcd2cdf4128358f94c6562febed93b9","user":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"repo":{"id":29261473,"node_id":"MDEwOlJlcG9zaXRvcnkyOTI2MTQ3Mw==","name":"minio","full_name":"minio/minio","private":false,"owner":{"login":"minio","id":695951,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY5NTk1MQ==","avatar_url":"https://avatars3.githubusercontent.com/u/695951?v=4","gravatar_id":"","url":"https://api.github.com/users/minio","html_url":"https://github.com/minio","followers_url":"https://api.github.com/users/minio/followers","following_url":"https://api.github.com/users/minio/following{/other_user}","gists_url":"https://api.github.com/users/minio/gists{/gist_id}","starred_url":"https://api.github.com/users/minio/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/minio/subscriptions","organizations_url":"https://api.github.com/users/minio/orgs","repos_url":"https://api.github.com/users/minio/repos","events_url":"https://api.github.com/users/minio/events{/privacy}","received_events_url":"https://api.github.com/users/minio/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/minio/minio","description":"Minio is an open source object storage server compatible with Amazon S3 APIs","fork":false,"url":"https://api.github.com/repos/minio/minio","forks_url":"https://api.github.com/repos/minio/minio/forks","keys_url":"https://api.github.com/repos/minio/minio/keys{/key_id}","collaborators_url":"https://api.github.com/repos/minio/minio/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/minio/minio/teams","hooks_url":"https://api.github.com/repos/minio/minio/hooks","issue_events_url":"https://api.github.com/repos/minio/minio/issues/events{/number}","events_url":"https://api.github.com/repos/minio/minio/events","assignees_url":"https://api.github.com/repos/minio/minio/assignees{/user}","branches_url":"https://api.github.com/repos/minio/minio/branches{/branch}","tags_url":"https://api.github.com/repos/minio/minio/tags","blobs_url":"https://api.github.com/repos/minio/minio/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/minio/minio/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/minio/minio/git/refs{/sha}","trees_url":"https://api.github.com/repos/minio/minio/git/trees{/sha}","statuses_url":"https://api.github.com/repos/minio/minio/statuses/{sha}","languages_url":"https://api.github.com/repos/minio/minio/languages","stargazers_url":"https://api.github.com/repos/minio/minio/stargazers","contributors_url":"https://api.github.com/repos/minio/minio/contributors","subscribers_url":"https://api.github.com/repos/minio/minio/subscribers","subscription_url":"https://api.github.com/repos/minio/minio/subscription","commits_url":"https://api.github.com/repos/minio/minio/commits{/sha}","git_commits_url":"https://api.github.com/repos/minio/minio/git/commits{/sha}","comments_url":"https://api.github.com/repos/minio/minio/comments{/number}","issue_comment_url":"https://api.github.com/repos/minio/minio/issues/comments{/number}","contents_url":"https://api.github.com/repos/minio/minio/contents/{+path}","compare_url":"https://api.github.com/repos/minio/minio/compare/{base}...{head}","merges_url":"https://api.github.com/repos/minio/minio/merges","archive_url":"https://api.github.com/repos/minio/minio/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/minio/minio/downloads","issues_url":"https://api.github.com/repos/minio/minio/issues{/number}","pulls_url":"https://api.github.com/repos/minio/minio/pulls{/number}","milestones_url":"https://api.github.com/repos/minio/minio/milestones{/number}","notifications_url":"https://api.github.com/repos/minio/minio/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/minio/minio/labels{/name}","releases_url":"https://api.github.com/repos/minio/minio/releases{/id}","deployments_url":"https://api.github.com/repos/minio/minio/deployments","created_at":"2015-01-14T19:23:58Z","updated_at":"2018-11-13T17:42:32Z","pushed_at":"2018-11-13T18:15:25Z","git_url":"git://github.com/minio/minio.git","ssh_url":"git@github.com:minio/minio.git","clone_url":"https://github.com/minio/minio.git","svn_url":"https://github.com/minio/minio","homepage":"https://minio.io/downloads.html#download-server","size":43584,"stargazers_count":13534,"watchers_count":13534,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1229,"mirror_url":null,"archived":false,"open_issues_count":144,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":1229,"open_issues":144,"watchers":13534,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/minio/minio/pulls/6680"},"html":{"href":"https://github.com/minio/minio/pull/6680"},"issue":{"href":"https://api.github.com/repos/minio/minio/issues/6680"},"comments":{"href":"https://api.github.com/repos/minio/minio/issues/6680/comments"},"review_comments":{"href":"https://api.github.com/repos/minio/minio/pulls/6680/comments"},"review_comment":{"href":"https://api.github.com/repos/minio/minio/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/minio/minio/pulls/6680/commits"},"statuses":{"href":"https://api.github.com/repos/minio/minio/statuses/56c01b9a78d5036d0efd672caab5b74ba9587003"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"poornas"}}