{"action":"closed","number":17,"pull_request":{"url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls/17","id":206588008,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA2NTg4MDA4","html_url":"https://github.com/loveorigami/yii2-modal-ajax/pull/17","diff_url":"https://github.com/loveorigami/yii2-modal-ajax/pull/17.diff","patch_url":"https://github.com/loveorigami/yii2-modal-ajax/pull/17.patch","issue_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/issues/17","number":17,"state":"closed","locked":false,"title":"Fix ajaxSubmit (see #16)","user":{"login":"Commifreak","id":87267,"node_id":"MDQ6VXNlcjg3MjY3","avatar_url":"https://avatars3.githubusercontent.com/u/87267?v=4","gravatar_id":"","url":"https://api.github.com/users/Commifreak","html_url":"https://github.com/Commifreak","followers_url":"https://api.github.com/users/Commifreak/followers","following_url":"https://api.github.com/users/Commifreak/following{/other_user}","gists_url":"https://api.github.com/users/Commifreak/gists{/gist_id}","starred_url":"https://api.github.com/users/Commifreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Commifreak/subscriptions","organizations_url":"https://api.github.com/users/Commifreak/orgs","repos_url":"https://api.github.com/users/Commifreak/repos","events_url":"https://api.github.com/users/Commifreak/events{/privacy}","received_events_url":"https://api.github.com/users/Commifreak/received_events","type":"User","site_admin":false},"body":"From #16 \r\n\r\nThis fixes the ajaxSubmit.\r\n\r\nYour idea in #16 (ajaxSubmit: '$this->ajaxSubmit' does not work either, because in case on false, we also get an JS syntax error, because the resulting JS is:\r\n```js\r\najaxSubmit: \r\n});\r\n```\r\nwhich is invalid.\r\n)\r\n\r\nMy PR generate either bool true or bool false inside the JS option, which does not need further testing (kbModal => options.ajaxSubmit || true).\r\n\r\nShould fix the abilitity to diable ajaxSubmit now.\r\n\r\nLet me know, if I forgot something.","created_at":"2018-08-07T06:02:31Z","updated_at":"2018-08-07T06:07:14Z","closed_at":"2018-08-07T06:07:14Z","merged_at":"2018-08-07T06:07:14Z","merge_commit_sha":"37282c2d5a28d7cafa68b3cd11ca77602fa24804","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls/17/commits","review_comments_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls/17/comments","review_comment_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls/comments{/number}","comments_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/issues/17/comments","statuses_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/statuses/2b3c57b7a28eac1c028eb16bfb009e0a9d97762a","head":{"label":"Commifreak:master","ref":"master","sha":"2b3c57b7a28eac1c028eb16bfb009e0a9d97762a","user":{"login":"Commifreak","id":87267,"node_id":"MDQ6VXNlcjg3MjY3","avatar_url":"https://avatars3.githubusercontent.com/u/87267?v=4","gravatar_id":"","url":"https://api.github.com/users/Commifreak","html_url":"https://github.com/Commifreak","followers_url":"https://api.github.com/users/Commifreak/followers","following_url":"https://api.github.com/users/Commifreak/following{/other_user}","gists_url":"https://api.github.com/users/Commifreak/gists{/gist_id}","starred_url":"https://api.github.com/users/Commifreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Commifreak/subscriptions","organizations_url":"https://api.github.com/users/Commifreak/orgs","repos_url":"https://api.github.com/users/Commifreak/repos","events_url":"https://api.github.com/users/Commifreak/events{/privacy}","received_events_url":"https://api.github.com/users/Commifreak/received_events","type":"User","site_admin":false},"repo":{"id":143826084,"node_id":"MDEwOlJlcG9zaXRvcnkxNDM4MjYwODQ=","name":"yii2-modal-ajax","full_name":"Commifreak/yii2-modal-ajax","owner":{"login":"Commifreak","id":87267,"node_id":"MDQ6VXNlcjg3MjY3","avatar_url":"https://avatars3.githubusercontent.com/u/87267?v=4","gravatar_id":"","url":"https://api.github.com/users/Commifreak","html_url":"https://github.com/Commifreak","followers_url":"https://api.github.com/users/Commifreak/followers","following_url":"https://api.github.com/users/Commifreak/following{/other_user}","gists_url":"https://api.github.com/users/Commifreak/gists{/gist_id}","starred_url":"https://api.github.com/users/Commifreak/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Commifreak/subscriptions","organizations_url":"https://api.github.com/users/Commifreak/orgs","repos_url":"https://api.github.com/users/Commifreak/repos","events_url":"https://api.github.com/users/Commifreak/events{/privacy}","received_events_url":"https://api.github.com/users/Commifreak/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/Commifreak/yii2-modal-ajax","description":"A wrapper around Yii2 Bootstrap Modal for using an ActiveForm via AJAX inside.  ","fork":true,"url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax","forks_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/forks","keys_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/teams","hooks_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/hooks","issue_events_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/issues/events{/number}","events_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/events","assignees_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/assignees{/user}","branches_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/branches{/branch}","tags_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/tags","blobs_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/git/refs{/sha}","trees_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/statuses/{sha}","languages_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/languages","stargazers_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/stargazers","contributors_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/contributors","subscribers_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/subscribers","subscription_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/subscription","commits_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/commits{/sha}","git_commits_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/git/commits{/sha}","comments_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/comments{/number}","issue_comment_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/issues/comments{/number}","contents_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/contents/{+path}","compare_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/merges","archive_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/downloads","issues_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/issues{/number}","pulls_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/pulls{/number}","milestones_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/milestones{/number}","notifications_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/labels{/name}","releases_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/releases{/id}","deployments_url":"https://api.github.com/repos/Commifreak/yii2-modal-ajax/deployments","created_at":"2018-08-07T05:53:01Z","updated_at":"2018-08-07T05:58:23Z","pushed_at":"2018-08-07T05:58:22Z","git_url":"git://github.com/Commifreak/yii2-modal-ajax.git","ssh_url":"git@github.com:Commifreak/yii2-modal-ajax.git","clone_url":"https://github.com/Commifreak/yii2-modal-ajax.git","svn_url":"https://github.com/Commifreak/yii2-modal-ajax","homepage":null,"size":24,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"loveorigami:master","ref":"master","sha":"94ae344580f7b5fd92b09450c2b0021196df4323","user":{"login":"loveorigami","id":98164,"node_id":"MDQ6VXNlcjk4MTY0","avatar_url":"https://avatars1.githubusercontent.com/u/98164?v=4","gravatar_id":"","url":"https://api.github.com/users/loveorigami","html_url":"https://github.com/loveorigami","followers_url":"https://api.github.com/users/loveorigami/followers","following_url":"https://api.github.com/users/loveorigami/following{/other_user}","gists_url":"https://api.github.com/users/loveorigami/gists{/gist_id}","starred_url":"https://api.github.com/users/loveorigami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loveorigami/subscriptions","organizations_url":"https://api.github.com/users/loveorigami/orgs","repos_url":"https://api.github.com/users/loveorigami/repos","events_url":"https://api.github.com/users/loveorigami/events{/privacy}","received_events_url":"https://api.github.com/users/loveorigami/received_events","type":"User","site_admin":false},"repo":{"id":66061681,"node_id":"MDEwOlJlcG9zaXRvcnk2NjA2MTY4MQ==","name":"yii2-modal-ajax","full_name":"loveorigami/yii2-modal-ajax","owner":{"login":"loveorigami","id":98164,"node_id":"MDQ6VXNlcjk4MTY0","avatar_url":"https://avatars1.githubusercontent.com/u/98164?v=4","gravatar_id":"","url":"https://api.github.com/users/loveorigami","html_url":"https://github.com/loveorigami","followers_url":"https://api.github.com/users/loveorigami/followers","following_url":"https://api.github.com/users/loveorigami/following{/other_user}","gists_url":"https://api.github.com/users/loveorigami/gists{/gist_id}","starred_url":"https://api.github.com/users/loveorigami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loveorigami/subscriptions","organizations_url":"https://api.github.com/users/loveorigami/orgs","repos_url":"https://api.github.com/users/loveorigami/repos","events_url":"https://api.github.com/users/loveorigami/events{/privacy}","received_events_url":"https://api.github.com/users/loveorigami/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/loveorigami/yii2-modal-ajax","description":"A wrapper around Yii2 Bootstrap Modal for using an ActiveForm via AJAX inside.  ","fork":false,"url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax","forks_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/forks","keys_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/keys{/key_id}","collaborators_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/teams","hooks_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/hooks","issue_events_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/issues/events{/number}","events_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/events","assignees_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/assignees{/user}","branches_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/branches{/branch}","tags_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/tags","blobs_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/git/refs{/sha}","trees_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/git/trees{/sha}","statuses_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/statuses/{sha}","languages_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/languages","stargazers_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/stargazers","contributors_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/contributors","subscribers_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/subscribers","subscription_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/subscription","commits_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/commits{/sha}","git_commits_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/git/commits{/sha}","comments_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/comments{/number}","issue_comment_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/issues/comments{/number}","contents_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/contents/{+path}","compare_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/compare/{base}...{head}","merges_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/merges","archive_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/downloads","issues_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/issues{/number}","pulls_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls{/number}","milestones_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/milestones{/number}","notifications_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/labels{/name}","releases_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/releases{/id}","deployments_url":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/deployments","created_at":"2016-08-19T07:19:40Z","updated_at":"2018-08-03T09:45:47Z","pushed_at":"2018-08-07T06:07:14Z","git_url":"git://github.com/loveorigami/yii2-modal-ajax.git","ssh_url":"git@github.com:loveorigami/yii2-modal-ajax.git","clone_url":"https://github.com/loveorigami/yii2-modal-ajax.git","svn_url":"https://github.com/loveorigami/yii2-modal-ajax","homepage":null,"size":24,"stargazers_count":27,"watchers_count":27,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":11,"mirror_url":null,"archived":false,"open_issues_count":1,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":11,"open_issues":1,"watchers":27,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls/17"},"html":{"href":"https://github.com/loveorigami/yii2-modal-ajax/pull/17"},"issue":{"href":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/issues/17"},"comments":{"href":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/issues/17/comments"},"review_comments":{"href":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls/17/comments"},"review_comment":{"href":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/pulls/17/commits"},"statuses":{"href":"https://api.github.com/repos/loveorigami/yii2-modal-ajax/statuses/2b3c57b7a28eac1c028eb16bfb009e0a9d97762a"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"loveorigami","id":98164,"node_id":"MDQ6VXNlcjk4MTY0","avatar_url":"https://avatars1.githubusercontent.com/u/98164?v=4","gravatar_id":"","url":"https://api.github.com/users/loveorigami","html_url":"https://github.com/loveorigami","followers_url":"https://api.github.com/users/loveorigami/followers","following_url":"https://api.github.com/users/loveorigami/following{/other_user}","gists_url":"https://api.github.com/users/loveorigami/gists{/gist_id}","starred_url":"https://api.github.com/users/loveorigami/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/loveorigami/subscriptions","organizations_url":"https://api.github.com/users/loveorigami/orgs","repos_url":"https://api.github.com/users/loveorigami/repos","events_url":"https://api.github.com/users/loveorigami/events{/privacy}","received_events_url":"https://api.github.com/users/loveorigami/received_events","type":"User","site_admin":false},"comments":1,"review_comments":0,"maintainer_can_modify":false,"commits":2,"additions":3,"deletions":3,"changed_files":2}}
{"actor":{"display_login":"loveorigami"}}