{"action":"created","issue":{"url":"https://api.github.com/repos/IQSS/dataverse/issues/4606","repository_url":"https://api.github.com/repos/IQSS/dataverse","labels_url":"https://api.github.com/repos/IQSS/dataverse/issues/4606/labels{/name}","comments_url":"https://api.github.com/repos/IQSS/dataverse/issues/4606/comments","events_url":"https://api.github.com/repos/IQSS/dataverse/issues/4606/events","html_url":"https://github.com/IQSS/dataverse/pull/4606","id":316586592,"node_id":"MDExOlB1bGxSZXF1ZXN0MTgzMjc3NzEz","number":4606,"title":"3083 support migration with dois","user":{"login":"michbarsinai","id":1938468,"node_id":"MDQ6VXNlcjE5Mzg0Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1938468?v=4","gravatar_id":"","url":"https://api.github.com/users/michbarsinai","html_url":"https://github.com/michbarsinai","followers_url":"https://api.github.com/users/michbarsinai/followers","following_url":"https://api.github.com/users/michbarsinai/following{/other_user}","gists_url":"https://api.github.com/users/michbarsinai/gists{/gist_id}","starred_url":"https://api.github.com/users/michbarsinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michbarsinai/subscriptions","organizations_url":"https://api.github.com/users/michbarsinai/orgs","repos_url":"https://api.github.com/users/michbarsinai/repos","events_url":"https://api.github.com/users/michbarsinai/events{/privacy}","received_events_url":"https://api.github.com/users/michbarsinai/received_events","type":"User","site_admin":false},"labels":[{"id":435707518,"node_id":"MDU6TGFiZWw0MzU3MDc1MTg=","url":"https://api.github.com/repos/IQSS/dataverse/labels/Status:%20Code%20Review","name":"Status: Code Review","color":"e6e6e6","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":25,"created_at":"2018-04-22T15:06:38Z","updated_at":"2018-07-03T16:29:58Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/IQSS/dataverse/pulls/4606","html_url":"https://github.com/IQSS/dataverse/pull/4606","diff_url":"https://github.com/IQSS/dataverse/pull/4606.diff","patch_url":"https://github.com/IQSS/dataverse/pull/4606.patch"},"body":"## New Contributors\r\n\r\nWelcome! New contributors should at least glance at [CONTRIBUTING.md](/CONTRIBUTING.md), especially the section on pull requests where we encourage you to reach out to other developers before you start coding. Also, please note that we measure code coverage and prefer you write unit tests. Pull requests can still be reviewed without tests or completion of the checklist outlined below. Thanks!\r\n\r\n## Related Issues\r\n\r\n- connects to #3083: Create Dataset: add support for migrating (with existing DOIs) via native API\r\n\r\n## Pull Request Checklist\r\n\r\n- [x] Unit [tests][] completed\r\n- [x] Integration [tests][]: None\r\n- [x] Deployment requirements, [SQL updates][], [Solr updates][], etc.: None\r\n- [x] [Documentation][docs] completed\r\n- [x] Merged latest from \"develop\" [branch][] and resolved conflicts\r\n\r\n[tests]: http://guides.dataverse.org/en/latest/developers/testing.html\r\n[SQL updates]: https://github.com/IQSS/dataverse/tree/develop/scripts/database/upgrades\r\n[Solr updates]: https://github.com/IQSS/dataverse/blob/develop/conf/solr/7.2.1/schema.xml\r\n[docs]: http://guides.dataverse.org/en/latest/developers/documentation.html\r\n[branch]: http://guides.dataverse.org/en/latest/developers/branching-strategy.html"},"comment":{"url":"https://api.github.com/repos/IQSS/dataverse/issues/comments/402216939","html_url":"https://github.com/IQSS/dataverse/pull/4606#issuecomment-402216939","issue_url":"https://api.github.com/repos/IQSS/dataverse/issues/4606","id":402216939,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMjIxNjkzOQ==","user":{"login":"michbarsinai","id":1938468,"node_id":"MDQ6VXNlcjE5Mzg0Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1938468?v=4","gravatar_id":"","url":"https://api.github.com/users/michbarsinai","html_url":"https://github.com/michbarsinai","followers_url":"https://api.github.com/users/michbarsinai/followers","following_url":"https://api.github.com/users/michbarsinai/following{/other_user}","gists_url":"https://api.github.com/users/michbarsinai/gists{/gist_id}","starred_url":"https://api.github.com/users/michbarsinai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/michbarsinai/subscriptions","organizations_url":"https://api.github.com/users/michbarsinai/orgs","repos_url":"https://api.github.com/users/michbarsinai/repos","events_url":"https://api.github.com/users/michbarsinai/events{/privacy}","received_events_url":"https://api.github.com/users/michbarsinai/received_events","type":"User","site_admin":false},"created_at":"2018-07-03T16:29:58Z","updated_at":"2018-07-03T16:29:58Z","author_association":"MEMBER","body":"Ok. I’ve fixed it in the 3083 branch: it was waiting for a wrong message (different case and missing colon).  I’ve added an equalsToCI method, for case insensitive comparison. \n\nSent from my iPhone\n\n> On 3 Jul 2018, at 18:58, Philip Durbin <notifications@github.com> wrote:\n> \n> testAddUpdateDatasetViaNativeAPI\n> \n> @michbarsinai that test is failing on the \"develop\" branch too. I just opened #4803 about it.\n> \n> —\n> You are receiving this because you were mentioned.\n> Reply to this email directly, view it on GitHub, or mute the thread.\n"}}
{"actor":{"display_login":"michbarsinai"}}