{"action":"closed","issue":{"url":"https://api.github.com/repos/mozilla-services/screenshots/issues/4896","repository_url":"https://api.github.com/repos/mozilla-services/screenshots","labels_url":"https://api.github.com/repos/mozilla-services/screenshots/issues/4896/labels{/name}","comments_url":"https://api.github.com/repos/mozilla-services/screenshots/issues/4896/comments","events_url":"https://api.github.com/repos/mozilla-services/screenshots/issues/4896/events","html_url":"https://github.com/mozilla-services/screenshots/issues/4896","id":360368789,"node_id":"MDU6SXNzdWUzNjAzNjg3ODk=","number":4896,"title":"[FxA] SignIn button on settings page triggers page not found","user":{"login":"punamdahiya","id":597734,"node_id":"MDQ6VXNlcjU5NzczNA==","avatar_url":"https://avatars1.githubusercontent.com/u/597734?v=4","gravatar_id":"","url":"https://api.github.com/users/punamdahiya","html_url":"https://github.com/punamdahiya","followers_url":"https://api.github.com/users/punamdahiya/followers","following_url":"https://api.github.com/users/punamdahiya/following{/other_user}","gists_url":"https://api.github.com/users/punamdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/punamdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punamdahiya/subscriptions","organizations_url":"https://api.github.com/users/punamdahiya/orgs","repos_url":"https://api.github.com/users/punamdahiya/repos","events_url":"https://api.github.com/users/punamdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/punamdahiya/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"punamdahiya","id":597734,"node_id":"MDQ6VXNlcjU5NzczNA==","avatar_url":"https://avatars1.githubusercontent.com/u/597734?v=4","gravatar_id":"","url":"https://api.github.com/users/punamdahiya","html_url":"https://github.com/punamdahiya","followers_url":"https://api.github.com/users/punamdahiya/followers","following_url":"https://api.github.com/users/punamdahiya/following{/other_user}","gists_url":"https://api.github.com/users/punamdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/punamdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punamdahiya/subscriptions","organizations_url":"https://api.github.com/users/punamdahiya/orgs","repos_url":"https://api.github.com/users/punamdahiya/repos","events_url":"https://api.github.com/users/punamdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/punamdahiya/received_events","type":"User","site_admin":false},"assignees":[{"login":"punamdahiya","id":597734,"node_id":"MDQ6VXNlcjU5NzczNA==","avatar_url":"https://avatars1.githubusercontent.com/u/597734?v=4","gravatar_id":"","url":"https://api.github.com/users/punamdahiya","html_url":"https://github.com/punamdahiya","followers_url":"https://api.github.com/users/punamdahiya/followers","following_url":"https://api.github.com/users/punamdahiya/following{/other_user}","gists_url":"https://api.github.com/users/punamdahiya/gists{/gist_id}","starred_url":"https://api.github.com/users/punamdahiya/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/punamdahiya/subscriptions","organizations_url":"https://api.github.com/users/punamdahiya/orgs","repos_url":"https://api.github.com/users/punamdahiya/repos","events_url":"https://api.github.com/users/punamdahiya/events{/privacy}","received_events_url":"https://api.github.com/users/punamdahiya/received_events","type":"User","site_admin":false}],"milestone":null,"comments":0,"created_at":"2018-09-14T16:15:32Z","updated_at":"2018-09-14T19:06:46Z","closed_at":"2018-09-14T19:06:46Z","author_association":"COLLABORATOR","body":"STR\r\n1. Click on settings in header and disconnect from FxA account\r\n2. Access /settings page directly from URL\r\n3. Click on SignIn \r\n\r\n[Actual Result]\r\nShows page not found\r\n[Expected]\r\nRedirects to auth login page\r\n\r\nWith routes changed inside server.js, href for signin button needs to be updated to /api/fxa-oauth/login/ instead of existing /api/fxa-oauth/login\r\n\r\nThis was missed as we rarely access sign in from settings page"}}
{"actor":{"display_login":"chenba"}}