{"action":"created","comment":{"url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/comments/196096198","pull_request_review_id":129584108,"id":196096198,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDE5NjA5NjE5OA==","diff_hunk":"@@ -316,26 +319,40 @@ func (n *ASGNodePoolsBackend) Terminate(node *Node, decrementDesired bool) error\n \t}\n \n \t_, err := n.asgClient.TerminateInstanceInAutoScalingGroup(params)","path":"pkg/updatestrategy/aws_asg.go","position":null,"original_position":32,"commit_id":"93f35ef5d0abc5caa276d8dde279c11464037dac","original_commit_id":"eda6a85f25dce49f682f2c8cb38f3e858fb06587","user":{"login":"mikkeloscar","id":128566,"node_id":"MDQ6VXNlcjEyODU2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"body":"Refactored it to be more clear. Now, on error, it will try to get the state (but not care about it) and only return an error if there's also an error on getting the current instance state.\r\n\r\nOtherwise it will just go into the backoff waiting for the instance to be terminated.","created_at":"2018-06-18T14:21:49Z","updated_at":"2018-06-18T14:21:50Z","html_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/61#discussion_r196096198","pull_request_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/61","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/comments/196096198"},"html":{"href":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/61#discussion_r196096198"},"pull_request":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/61"}},"in_reply_to_id":196087917},"pull_request":{"url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/61","id":195531778,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk1NTMxNzc4","html_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/61","diff_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/61.diff","patch_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/61.patch","issue_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/61","number":61,"state":"open","locked":false,"title":"Wait for instance to be terminated in AWS","user":{"login":"mikkeloscar","id":128566,"node_id":"MDQ6VXNlcjEyODU2Ng==","avatar_url":"https://avatars0.githubusercontent.com/u/128566?v=4","gravatar_id":"","url":"https://api.github.com/users/mikkeloscar","html_url":"https://github.com/mikkeloscar","followers_url":"https://api.github.com/users/mikkeloscar/followers","following_url":"https://api.github.com/users/mikkeloscar/following{/other_user}","gists_url":"https://api.github.com/users/mikkeloscar/gists{/gist_id}","starred_url":"https://api.github.com/users/mikkeloscar/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mikkeloscar/subscriptions","organizations_url":"https://api.github.com/users/mikkeloscar/orgs","repos_url":"https://api.github.com/users/mikkeloscar/repos","events_url":"https://api.github.com/users/mikkeloscar/events{/privacy}","received_events_url":"https://api.github.com/users/mikkeloscar/received_events","type":"User","site_admin":false},"body":"Deleting the Kubernetes node object when terminating a node had the bad side effect that flannel on other nodes would remove the routes before the node was actually gone. Instead of deleting the node object we wait for the instance to be terminated according to AWS this way we don't drain the same node multiple times (which was the reason for deleting the node object manually in the first place).","created_at":"2018-06-18T13:49:36Z","updated_at":"2018-06-18T14:21:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"57816ba90b3708bf3bdbffb08b4affa5dc13ab9c","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/61/commits","review_comments_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/61/comments","review_comment_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/61/comments","statuses_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/statuses/93f35ef5d0abc5caa276d8dde279c11464037dac","head":{"label":"zalando-incubator:wait-for-instance-shutdown","ref":"wait-for-instance-shutdown","sha":"93f35ef5d0abc5caa276d8dde279c11464037dac","user":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":131291943,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyOTE5NDM=","name":"cluster-lifecycle-manager","full_name":"zalando-incubator/cluster-lifecycle-manager","owner":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager","description":"Cluster Lifecycle Manager (CLM) to provision and update multiple Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager","forks_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/forks","keys_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/events","assignees_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/merges","archive_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/deployments","created_at":"2018-04-27T12:11:30Z","updated_at":"2018-06-15T09:42:13Z","pushed_at":"2018-06-18T14:19:55Z","git_url":"git://github.com/zalando-incubator/cluster-lifecycle-manager.git","ssh_url":"git@github.com:zalando-incubator/cluster-lifecycle-manager.git","clone_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager.git","svn_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager","homepage":"","size":610,"stargazers_count":58,"watchers_count":58,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":9,"watchers":58,"default_branch":"master"}},"base":{"label":"zalando-incubator:master","ref":"master","sha":"4b4520593878aa8a8111ed2610fd9851f89066c8","user":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"repo":{"id":131291943,"node_id":"MDEwOlJlcG9zaXRvcnkxMzEyOTE5NDM=","name":"cluster-lifecycle-manager","full_name":"zalando-incubator/cluster-lifecycle-manager","owner":{"login":"zalando-incubator","id":18533786,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE4NTMzNzg2","avatar_url":"https://avatars3.githubusercontent.com/u/18533786?v=4","gravatar_id":"","url":"https://api.github.com/users/zalando-incubator","html_url":"https://github.com/zalando-incubator","followers_url":"https://api.github.com/users/zalando-incubator/followers","following_url":"https://api.github.com/users/zalando-incubator/following{/other_user}","gists_url":"https://api.github.com/users/zalando-incubator/gists{/gist_id}","starred_url":"https://api.github.com/users/zalando-incubator/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/zalando-incubator/subscriptions","organizations_url":"https://api.github.com/users/zalando-incubator/orgs","repos_url":"https://api.github.com/users/zalando-incubator/repos","events_url":"https://api.github.com/users/zalando-incubator/events{/privacy}","received_events_url":"https://api.github.com/users/zalando-incubator/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager","description":"Cluster Lifecycle Manager (CLM) to provision and update multiple Kubernetes clusters","fork":false,"url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager","forks_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/forks","keys_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/teams","hooks_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/hooks","issue_events_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/events{/number}","events_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/events","assignees_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/assignees{/user}","branches_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/branches{/branch}","tags_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/tags","blobs_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/languages","stargazers_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/stargazers","contributors_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/contributors","subscribers_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/subscribers","subscription_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/subscription","commits_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/contents/{+path}","compare_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/merges","archive_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/downloads","issues_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues{/number}","pulls_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/labels{/name}","releases_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/releases{/id}","deployments_url":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/deployments","created_at":"2018-04-27T12:11:30Z","updated_at":"2018-06-15T09:42:13Z","pushed_at":"2018-06-18T14:19:55Z","git_url":"git://github.com/zalando-incubator/cluster-lifecycle-manager.git","ssh_url":"git@github.com:zalando-incubator/cluster-lifecycle-manager.git","clone_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager.git","svn_url":"https://github.com/zalando-incubator/cluster-lifecycle-manager","homepage":"","size":610,"stargazers_count":58,"watchers_count":58,"language":"Go","has_issues":true,"has_projects":false,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":9,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":3,"open_issues":9,"watchers":58,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/61"},"html":{"href":"https://github.com/zalando-incubator/cluster-lifecycle-manager/pull/61"},"issue":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/61"},"comments":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/issues/61/comments"},"review_comments":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/61/comments"},"review_comment":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/pulls/61/commits"},"statuses":{"href":"https://api.github.com/repos/zalando-incubator/cluster-lifecycle-manager/statuses/93f35ef5d0abc5caa276d8dde279c11464037dac"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"mikkeloscar"}}