{"action":"created","issue":{"url":"https://api.github.com/repos/pytroll/satpy/issues/496","repository_url":"https://api.github.com/repos/pytroll/satpy","labels_url":"https://api.github.com/repos/pytroll/satpy/issues/496/labels{/name}","comments_url":"https://api.github.com/repos/pytroll/satpy/issues/496/comments","events_url":"https://api.github.com/repos/pytroll/satpy/issues/496/events","html_url":"https://github.com/pytroll/satpy/pull/496","id":379197858,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI5NzIyMDM2","number":496,"title":"Add more descriptive names to AHI readers AreaDefinition names","user":{"login":"djhoese","id":1828519,"node_id":"MDQ6VXNlcjE4Mjg1MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/djhoese","html_url":"https://github.com/djhoese","followers_url":"https://api.github.com/users/djhoese/followers","following_url":"https://api.github.com/users/djhoese/following{/other_user}","gists_url":"https://api.github.com/users/djhoese/gists{/gist_id}","starred_url":"https://api.github.com/users/djhoese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djhoese/subscriptions","organizations_url":"https://api.github.com/users/djhoese/orgs","repos_url":"https://api.github.com/users/djhoese/repos","events_url":"https://api.github.com/users/djhoese/events{/privacy}","received_events_url":"https://api.github.com/users/djhoese/received_events","type":"User","site_admin":false},"labels":[{"id":323805262,"node_id":"MDU6TGFiZWwzMjM4MDUyNjI=","url":"https://api.github.com/repos/pytroll/satpy/labels/bug","name":"bug","color":"fc2929","default":true},{"id":841946101,"node_id":"MDU6TGFiZWw4NDE5NDYxMDE=","url":"https://api.github.com/repos/pytroll/satpy/labels/component:readers","name":"component:readers","color":"1d76db","default":false}],"state":"open","locked":false,"assignee":{"login":"djhoese","id":1828519,"node_id":"MDQ6VXNlcjE4Mjg1MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/djhoese","html_url":"https://github.com/djhoese","followers_url":"https://api.github.com/users/djhoese/followers","following_url":"https://api.github.com/users/djhoese/following{/other_user}","gists_url":"https://api.github.com/users/djhoese/gists{/gist_id}","starred_url":"https://api.github.com/users/djhoese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djhoese/subscriptions","organizations_url":"https://api.github.com/users/djhoese/orgs","repos_url":"https://api.github.com/users/djhoese/repos","events_url":"https://api.github.com/users/djhoese/events{/privacy}","received_events_url":"https://api.github.com/users/djhoese/received_events","type":"User","site_admin":false},"assignees":[{"login":"djhoese","id":1828519,"node_id":"MDQ6VXNlcjE4Mjg1MTk=","avatar_url":"https://avatars3.githubusercontent.com/u/1828519?v=4","gravatar_id":"","url":"https://api.github.com/users/djhoese","html_url":"https://github.com/djhoese","followers_url":"https://api.github.com/users/djhoese/followers","following_url":"https://api.github.com/users/djhoese/following{/other_user}","gists_url":"https://api.github.com/users/djhoese/gists{/gist_id}","starred_url":"https://api.github.com/users/djhoese/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/djhoese/subscriptions","organizations_url":"https://api.github.com/users/djhoese/orgs","repos_url":"https://api.github.com/users/djhoese/repos","events_url":"https://api.github.com/users/djhoese/events{/privacy}","received_events_url":"https://api.github.com/users/djhoese/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-11-09T15:06:29Z","updated_at":"2018-11-09T21:29:36Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/pytroll/satpy/pulls/496","html_url":"https://github.com/pytroll/satpy/pull/496","diff_url":"https://github.com/pytroll/satpy/pull/496.diff","patch_url":"https://github.com/pytroll/satpy/pull/496.patch"},"body":"The previous names were things like \"some_area_name\". For users who want to put area names in their filenames (`{area.area_id}`) this makes the filename extremely ugly and not very useful. I took the information that I could find from the file and put it in the area definition. As far as everyone seems to know AHI HRIT files (himawaricast) these files only come in full disk (FLDK) variants so I hardcoded that name.\r\n\r\n - [ ] Tests added <!-- for all bug fixes or enhancements -->\r\n - [ ] Tests passed <!-- for all non-documentation changes -->\r\n - [x] Passes ``git diff origin/master -- \"*py\" | flake8 --diff`` <!-- remove if you did not edit any Python files -->"},"comment":{"url":"https://api.github.com/repos/pytroll/satpy/issues/comments/437501012","html_url":"https://github.com/pytroll/satpy/pull/496#issuecomment-437501012","issue_url":"https://api.github.com/repos/pytroll/satpy/issues/496","id":437501012,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNzUwMTAxMg==","user":{"login":"codecov[bot]","id":22429695,"node_id":"MDM6Qm90MjI0Mjk2OTU=","avatar_url":"https://avatars2.githubusercontent.com/in/254?v=4","gravatar_id":"","url":"https://api.github.com/users/codecov%5Bbot%5D","html_url":"https://github.com/apps/codecov","followers_url":"https://api.github.com/users/codecov%5Bbot%5D/followers","following_url":"https://api.github.com/users/codecov%5Bbot%5D/following{/other_user}","gists_url":"https://api.github.com/users/codecov%5Bbot%5D/gists{/gist_id}","starred_url":"https://api.github.com/users/codecov%5Bbot%5D/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/codecov%5Bbot%5D/subscriptions","organizations_url":"https://api.github.com/users/codecov%5Bbot%5D/orgs","repos_url":"https://api.github.com/users/codecov%5Bbot%5D/repos","events_url":"https://api.github.com/users/codecov%5Bbot%5D/events{/privacy}","received_events_url":"https://api.github.com/users/codecov%5Bbot%5D/received_events","type":"Bot","site_admin":false},"created_at":"2018-11-09T21:29:36Z","updated_at":"2018-11-09T21:29:36Z","author_association":"NONE","body":"# [Codecov](https://codecov.io/gh/pytroll/satpy/pull/496?src=pr&el=h1) Report\n> Merging [#496](https://codecov.io/gh/pytroll/satpy/pull/496?src=pr&el=desc) into [master](https://codecov.io/gh/pytroll/satpy/commit/ee6bc3a3b58a5b6ad4ea8900234cccb681c757b2?src=pr&el=desc) will **increase** coverage by `<.01%`.\n> The diff coverage is `100%`.\n\n[![Impacted file tree graph](https://codecov.io/gh/pytroll/satpy/pull/496/graphs/tree.svg?width=650&token=plt2new8tY&height=150&src=pr)](https://codecov.io/gh/pytroll/satpy/pull/496?src=pr&el=tree)\n\n```diff\n@@            Coverage Diff             @@\n##           master     #496      +/-   ##\n==========================================\n+ Coverage   74.08%   74.08%   +<.01%     \n==========================================\n  Files         137      137              \n  Lines       18219    18220       +1     \n==========================================\n+ Hits        13498    13499       +1     \n  Misses       4721     4721\n```\n\n\n| [Impacted Files](https://codecov.io/gh/pytroll/satpy/pull/496?src=pr&el=tree) | Coverage Δ | |\n|---|---|---|\n| [satpy/readers/ahi\\_hsd.py](https://codecov.io/gh/pytroll/satpy/pull/496/diff?src=pr&el=tree#diff-c2F0cHkvcmVhZGVycy9haGlfaHNkLnB5) | `45.6% <100%> (+0.3%)` | :arrow_up: |\n| [satpy/readers/hrit\\_jma.py](https://codecov.io/gh/pytroll/satpy/pull/496/diff?src=pr&el=tree#diff-c2F0cHkvcmVhZGVycy9ocml0X2ptYS5weQ==) | `97.67% <100%> (ø)` | :arrow_up: |\n\n------\n\n[Continue to review full report at Codecov](https://codecov.io/gh/pytroll/satpy/pull/496?src=pr&el=continue).\n> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)\n> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`\n> Powered by [Codecov](https://codecov.io/gh/pytroll/satpy/pull/496?src=pr&el=footer). Last update [ee6bc3a...d4d90b8](https://codecov.io/gh/pytroll/satpy/pull/496?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).\n"}}
{"actor":{"display_login":"codecov"}}