{"action":"created","comment":{"url":"https://api.github.com/repos/angular/tsickle/pulls/comments/204716076","pull_request_review_id":139829834,"id":204716076,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNDcxNjA3Ng==","diff_hunk":"@@ -137,21 +135,24 @@ class RedundantJSDocShouldBeStripped {\n  * @return {void}\n  */\n function JSDocWithBadTag() { }\n-/** *\n+/**\n  * For example,\n  * \\@madeUpTag\n-  @type {string} */\n+ * @type {string}\n+ */\n const c = 'c';\n-/***\n+/**\n  * Don't emit type comments for Polymer behaviors,\n  * as this breaks their closure plugin :-(\n  *\n  * @polymerBehavior\n+ * @type {!Object}\n  */\n const somePolymerBehavior = {};\n-/** *\n+/**\n  * Don't emit type comments for Polymer behaviors\n  * if they are declared via the Polymer function.\n-  @type {?} */\n+ * @type {?}\n+ */\n let Polymer;\n-Polymer({ behaviors: ['test'] });\n+Polymer({ behaviors: [(/** @type {?} */ ('test'))] });","path":"test_files/jsdoc/jsdoc.js","position":40,"original_position":40,"commit_id":"cee6fddbb42e3732d1ccfbe980aeef48b2c01978","original_commit_id":"08c92e3cae5e2a1a22e27eb5286bcba0588497be","user":{"login":"mprobst","id":7208,"node_id":"MDQ6VXNlcjcyMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7208?v=4","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"Yes. It turns out that Tobias added a crazy hack to tsickle to work around five failing files in google3. I went ahead and fixed the five files, and now aomarks also fixed PolymerPass, so this is no longer an issue.\r\n\r\nOnce JSCompiler releases with the fix, we should probably just delete this code.","created_at":"2018-07-24T11:17:20Z","updated_at":"2018-07-24T11:18:34Z","html_url":"https://github.com/angular/tsickle/pull/862#discussion_r204716076","pull_request_url":"https://api.github.com/repos/angular/tsickle/pulls/862","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/angular/tsickle/pulls/comments/204716076"},"html":{"href":"https://github.com/angular/tsickle/pull/862#discussion_r204716076"},"pull_request":{"href":"https://api.github.com/repos/angular/tsickle/pulls/862"}},"in_reply_to_id":204518269},"pull_request":{"url":"https://api.github.com/repos/angular/tsickle/pulls/862","id":200748665,"node_id":"MDExOlB1bGxSZXF1ZXN0MjAwNzQ4NjY1","html_url":"https://github.com/angular/tsickle/pull/862","diff_url":"https://github.com/angular/tsickle/pull/862.diff","patch_url":"https://github.com/angular/tsickle/pull/862.patch","issue_url":"https://api.github.com/repos/angular/tsickle/issues/862","number":862,"state":"open","locked":false,"title":"Fully convert tsickle to TypeScript's transformer API.","user":{"login":"mprobst","id":7208,"node_id":"MDQ6VXNlcjcyMDg=","avatar_url":"https://avatars0.githubusercontent.com/u/7208?v=4","gravatar_id":"","url":"https://api.github.com/users/mprobst","html_url":"https://github.com/mprobst","followers_url":"https://api.github.com/users/mprobst/followers","following_url":"https://api.github.com/users/mprobst/following{/other_user}","gists_url":"https://api.github.com/users/mprobst/gists{/gist_id}","starred_url":"https://api.github.com/users/mprobst/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mprobst/subscriptions","organizations_url":"https://api.github.com/users/mprobst/orgs","repos_url":"https://api.github.com/users/mprobst/repos","events_url":"https://api.github.com/users/mprobst/events{/privacy}","received_events_url":"https://api.github.com/users/mprobst/received_events","type":"User","site_admin":false},"body":"","created_at":"2018-07-11T15:55:07Z","updated_at":"2018-07-24T11:18:34Z","closed_at":null,"merged_at":null,"merge_commit_sha":"f1b680d68bc3433797de05654a9c385f94277bf9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":308083292,"node_id":"MDU6TGFiZWwzMDgwODMyOTI=","url":"https://api.github.com/repos/angular/tsickle/labels/cla:%20yes","name":"cla: yes","color":"207de5","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/angular/tsickle/pulls/862/commits","review_comments_url":"https://api.github.com/repos/angular/tsickle/pulls/862/comments","review_comment_url":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}","comments_url":"https://api.github.com/repos/angular/tsickle/issues/862/comments","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/cee6fddbb42e3732d1ccfbe980aeef48b2c01978","head":{"label":"angular:transform-main","ref":"transform-main","sha":"cee6fddbb42e3732d1ccfbe980aeef48b2c01978","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcyMjczNQ==","name":"tsickle","full_name":"angular/tsickle","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Translator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2018-07-23T18:58:02Z","pushed_at":"2018-07-24T10:26:18Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":3185,"stargazers_count":461,"watchers_count":461,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":70,"open_issues":142,"watchers":461,"default_branch":"master"}},"base":{"label":"angular:master","ref":"master","sha":"17bb1fdf124913360550848766f214ba39a2e0c0","user":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"repo":{"id":43722735,"node_id":"MDEwOlJlcG9zaXRvcnk0MzcyMjczNQ==","name":"tsickle","full_name":"angular/tsickle","owner":{"login":"angular","id":139426,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEzOTQyNg==","avatar_url":"https://avatars3.githubusercontent.com/u/139426?v=4","gravatar_id":"","url":"https://api.github.com/users/angular","html_url":"https://github.com/angular","followers_url":"https://api.github.com/users/angular/followers","following_url":"https://api.github.com/users/angular/following{/other_user}","gists_url":"https://api.github.com/users/angular/gists{/gist_id}","starred_url":"https://api.github.com/users/angular/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/angular/subscriptions","organizations_url":"https://api.github.com/users/angular/orgs","repos_url":"https://api.github.com/users/angular/repos","events_url":"https://api.github.com/users/angular/events{/privacy}","received_events_url":"https://api.github.com/users/angular/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/angular/tsickle","description":"Tsickle — TypeScript to Closure Translator","fork":false,"url":"https://api.github.com/repos/angular/tsickle","forks_url":"https://api.github.com/repos/angular/tsickle/forks","keys_url":"https://api.github.com/repos/angular/tsickle/keys{/key_id}","collaborators_url":"https://api.github.com/repos/angular/tsickle/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/angular/tsickle/teams","hooks_url":"https://api.github.com/repos/angular/tsickle/hooks","issue_events_url":"https://api.github.com/repos/angular/tsickle/issues/events{/number}","events_url":"https://api.github.com/repos/angular/tsickle/events","assignees_url":"https://api.github.com/repos/angular/tsickle/assignees{/user}","branches_url":"https://api.github.com/repos/angular/tsickle/branches{/branch}","tags_url":"https://api.github.com/repos/angular/tsickle/tags","blobs_url":"https://api.github.com/repos/angular/tsickle/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/angular/tsickle/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/angular/tsickle/git/refs{/sha}","trees_url":"https://api.github.com/repos/angular/tsickle/git/trees{/sha}","statuses_url":"https://api.github.com/repos/angular/tsickle/statuses/{sha}","languages_url":"https://api.github.com/repos/angular/tsickle/languages","stargazers_url":"https://api.github.com/repos/angular/tsickle/stargazers","contributors_url":"https://api.github.com/repos/angular/tsickle/contributors","subscribers_url":"https://api.github.com/repos/angular/tsickle/subscribers","subscription_url":"https://api.github.com/repos/angular/tsickle/subscription","commits_url":"https://api.github.com/repos/angular/tsickle/commits{/sha}","git_commits_url":"https://api.github.com/repos/angular/tsickle/git/commits{/sha}","comments_url":"https://api.github.com/repos/angular/tsickle/comments{/number}","issue_comment_url":"https://api.github.com/repos/angular/tsickle/issues/comments{/number}","contents_url":"https://api.github.com/repos/angular/tsickle/contents/{+path}","compare_url":"https://api.github.com/repos/angular/tsickle/compare/{base}...{head}","merges_url":"https://api.github.com/repos/angular/tsickle/merges","archive_url":"https://api.github.com/repos/angular/tsickle/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/angular/tsickle/downloads","issues_url":"https://api.github.com/repos/angular/tsickle/issues{/number}","pulls_url":"https://api.github.com/repos/angular/tsickle/pulls{/number}","milestones_url":"https://api.github.com/repos/angular/tsickle/milestones{/number}","notifications_url":"https://api.github.com/repos/angular/tsickle/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/angular/tsickle/labels{/name}","releases_url":"https://api.github.com/repos/angular/tsickle/releases{/id}","deployments_url":"https://api.github.com/repos/angular/tsickle/deployments","created_at":"2015-10-06T00:55:40Z","updated_at":"2018-07-23T18:58:02Z","pushed_at":"2018-07-24T10:26:18Z","git_url":"git://github.com/angular/tsickle.git","ssh_url":"git@github.com:angular/tsickle.git","clone_url":"https://github.com/angular/tsickle.git","svn_url":"https://github.com/angular/tsickle","homepage":"","size":3185,"stargazers_count":461,"watchers_count":461,"language":"TypeScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":70,"mirror_url":null,"archived":false,"open_issues_count":142,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":70,"open_issues":142,"watchers":461,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/angular/tsickle/pulls/862"},"html":{"href":"https://github.com/angular/tsickle/pull/862"},"issue":{"href":"https://api.github.com/repos/angular/tsickle/issues/862"},"comments":{"href":"https://api.github.com/repos/angular/tsickle/issues/862/comments"},"review_comments":{"href":"https://api.github.com/repos/angular/tsickle/pulls/862/comments"},"review_comment":{"href":"https://api.github.com/repos/angular/tsickle/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/angular/tsickle/pulls/862/commits"},"statuses":{"href":"https://api.github.com/repos/angular/tsickle/statuses/cee6fddbb42e3732d1ccfbe980aeef48b2c01978"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"mprobst"}}