{"action":"created","comment":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/221293838","pull_request_review_id":159912209,"id":221293838,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMTI5MzgzOA==","diff_hunk":"@@ -325,6 +325,21 @@ issue_delete(job *pjob)\n \t(void)issue_to_svr(rmt_server, preq, release_req);\n }\n \n+/**\n+ * @Brief\n+ *\t\tdecrement entity usage for a single un-instantiated subjob\n+ *\n+ * @param[in]\tparent - pointer to parent Job structure.\n+ */\n+static void\n+decr_single_subjob_usage(job *parent)\n+{\n+\tparent->ji_qs.ji_svrflags &= ~JOB_SVFLG_ArrayJob; /* small hack to decrementing usage for singel un-initialized subjob */","path":"src/server/req_delete.c","position":null,"original_position":22,"commit_id":"b2f22afcadb50bc872cb198d65b51190511aaf45","original_commit_id":"adf9beeaa055f4366ceadbbce93cf1daae9a0d18","user":{"login":"Shrini-h","id":30307577,"node_id":"MDQ6VXNlcjMwMzA3NTc3","avatar_url":"https://avatars1.githubusercontent.com/u/30307577?v=4","gravatar_id":"","url":"https://api.github.com/users/Shrini-h","html_url":"https://github.com/Shrini-h","followers_url":"https://api.github.com/users/Shrini-h/followers","following_url":"https://api.github.com/users/Shrini-h/following{/other_user}","gists_url":"https://api.github.com/users/Shrini-h/gists{/gist_id}","starred_url":"https://api.github.com/users/Shrini-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shrini-h/subscriptions","organizations_url":"https://api.github.com/users/Shrini-h/orgs","repos_url":"https://api.github.com/users/Shrini-h/repos","events_url":"https://api.github.com/users/Shrini-h/events{/privacy}","received_events_url":"https://api.github.com/users/Shrini-h/received_events","type":"User","site_admin":false},"body":"fixed the typo in commit named rc1 https://github.com/PBSPro/pbspro/commit/b2f22afcadb50bc872cb198d65b51190511aaf45    If fixed the gramo which was not noticed.","created_at":"2018-09-28T15:31:18Z","updated_at":"2018-09-28T15:31:18Z","html_url":"https://github.com/PBSPro/pbspro/pull/807#discussion_r221293838","pull_request_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/807","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments/221293838"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/807#discussion_r221293838"},"pull_request":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/807"}},"in_reply_to_id":221214520},"pull_request":{"url":"https://api.github.com/repos/PBSPro/pbspro/pulls/807","id":214850156,"node_id":"MDExOlB1bGxSZXF1ZXN0MjE0ODUwMTU2","html_url":"https://github.com/PBSPro/pbspro/pull/807","diff_url":"https://github.com/PBSPro/pbspro/pull/807.diff","patch_url":"https://github.com/PBSPro/pbspro/pull/807.patch","issue_url":"https://api.github.com/repos/PBSPro/pbspro/issues/807","number":807,"state":"open","locked":false,"title":"Entity limits not working for job arrays","user":{"login":"Shrini-h","id":30307577,"node_id":"MDQ6VXNlcjMwMzA3NTc3","avatar_url":"https://avatars1.githubusercontent.com/u/30307577?v=4","gravatar_id":"","url":"https://api.github.com/users/Shrini-h","html_url":"https://github.com/Shrini-h","followers_url":"https://api.github.com/users/Shrini-h/followers","following_url":"https://api.github.com/users/Shrini-h/following{/other_user}","gists_url":"https://api.github.com/users/Shrini-h/gists{/gist_id}","starred_url":"https://api.github.com/users/Shrini-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shrini-h/subscriptions","organizations_url":"https://api.github.com/users/Shrini-h/orgs","repos_url":"https://api.github.com/users/Shrini-h/repos","events_url":"https://api.github.com/users/Shrini-h/events{/privacy}","received_events_url":"https://api.github.com/users/Shrini-h/received_events","type":"User","site_admin":false},"body":"<!--- Please review your changes in preview mode -->\r\n<!--- Provide a general summary of your changes in the Title above -->\r\n\r\n#### Bug/feature Description\r\n* *Counters for max_queued and other limits are not being accounted properly, leading PBS to reject jobs that should be accepted, even across server restarts.*\r\n\r\n#### Affected Platform(s)\r\n* *All*\r\n\r\n#### Cause / Analysis / Design\r\n* *When a job is submitted, PBS checks if queueing will violate any entity limits (user, group, project, overall).*\r\n* *While this was working fine for normal jobs, array jobs were violating the limits as the whole array job was considered to be using the resources only once.*\r\n\r\n#### Solution Description\r\n* *With the proposed changes, PBS will account for subjobs so that the limits work properly.*\r\n\r\n#### Testing logs/output\r\n[Entity_limits_logs_09_24.zip](https://github.com/PBSPro/pbspro/files/2409742/Entity_limits_logs_09_24.zip)\r\n\r\n\r\n#### Checklist:\r\n<!--- Use the preview button to see the checkboxes/links properly. -->\r\n<!--- Go over the following points, and put an `x` (without spaces around it) in the boxes that apply. -->\r\n<!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! -->\r\n- [x] I have joined the **[pbspro community forum](http://community.pbspro.org/)**.\r\n- [x] My pull request contains a **single, signed** commit. See **[setting up gpg signature](https://pbspro.atlassian.net/wiki/display/DG/Signing+Your+Git+Commits)**.\r\n- [x] My code follows the **[coding style](https://pbspro.atlassian.net/wiki/display/DG/Coding+Standards)** of this project.\r\n- [ ] My change requires project documentation. See **[required documentation checklist](https://pbspro.atlassian.net/wiki/display/DG/Checklist+for+Developing+Features+and+Bug+Fixes)** for details.\r\n   - [ ] I have added documentation in the **[project documentation area](https://pbspro.atlassian.net/wiki/display/PD)**.\r\n- [x] I have added new **PTL test(s) to my commit**. (See **[using PTL for testing](https://pbspro.atlassian.net/wiki/display/DG/Using+PTL+for+Testing)**) *(or)*\r\n   - [ ] I have added  **manual test(s) to this pull request and explained why PTL is not appropriate** for this case.\r\n- [x] All new and existing automated tests have passed. (See **[running automated PTL tests](https://pbspro.atlassian.net/wiki/display/DG/PTL+Quick+Start+Guide)**).\r\n- [x] I have attached **test logs to this pull request** as evidence of testing/verification.\r\n\r\n\r\n__***For further information please visit the [Developer Guide Home](https://pbspro.atlassian.net/wiki/display/DG/Developer+Guide+Home).***__\r\n","created_at":"2018-09-12T06:37:04Z","updated_at":"2018-09-28T15:31:18Z","closed_at":null,"merged_at":null,"merge_commit_sha":"125e8b5aaa63302325c026f43e7bc1f40ea68491","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/807/commits","review_comments_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/807/comments","review_comment_url":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/issues/807/comments","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/b2f22afcadb50bc872cb198d65b51190511aaf45","head":{"label":"Shrini-h:dev_max_queued_4subjobs","ref":"dev_max_queued_4subjobs","sha":"b2f22afcadb50bc872cb198d65b51190511aaf45","user":{"login":"Shrini-h","id":30307577,"node_id":"MDQ6VXNlcjMwMzA3NTc3","avatar_url":"https://avatars1.githubusercontent.com/u/30307577?v=4","gravatar_id":"","url":"https://api.github.com/users/Shrini-h","html_url":"https://github.com/Shrini-h","followers_url":"https://api.github.com/users/Shrini-h/followers","following_url":"https://api.github.com/users/Shrini-h/following{/other_user}","gists_url":"https://api.github.com/users/Shrini-h/gists{/gist_id}","starred_url":"https://api.github.com/users/Shrini-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shrini-h/subscriptions","organizations_url":"https://api.github.com/users/Shrini-h/orgs","repos_url":"https://api.github.com/users/Shrini-h/repos","events_url":"https://api.github.com/users/Shrini-h/events{/privacy}","received_events_url":"https://api.github.com/users/Shrini-h/received_events","type":"User","site_admin":false},"repo":{"id":97791084,"node_id":"MDEwOlJlcG9zaXRvcnk5Nzc5MTA4NA==","name":"pbspro","full_name":"Shrini-h/pbspro","private":false,"owner":{"login":"Shrini-h","id":30307577,"node_id":"MDQ6VXNlcjMwMzA3NTc3","avatar_url":"https://avatars1.githubusercontent.com/u/30307577?v=4","gravatar_id":"","url":"https://api.github.com/users/Shrini-h","html_url":"https://github.com/Shrini-h","followers_url":"https://api.github.com/users/Shrini-h/followers","following_url":"https://api.github.com/users/Shrini-h/following{/other_user}","gists_url":"https://api.github.com/users/Shrini-h/gists{/gist_id}","starred_url":"https://api.github.com/users/Shrini-h/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/Shrini-h/subscriptions","organizations_url":"https://api.github.com/users/Shrini-h/orgs","repos_url":"https://api.github.com/users/Shrini-h/repos","events_url":"https://api.github.com/users/Shrini-h/events{/privacy}","received_events_url":"https://api.github.com/users/Shrini-h/received_events","type":"User","site_admin":false},"html_url":"https://github.com/Shrini-h/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":true,"url":"https://api.github.com/repos/Shrini-h/pbspro","forks_url":"https://api.github.com/repos/Shrini-h/pbspro/forks","keys_url":"https://api.github.com/repos/Shrini-h/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/Shrini-h/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/Shrini-h/pbspro/teams","hooks_url":"https://api.github.com/repos/Shrini-h/pbspro/hooks","issue_events_url":"https://api.github.com/repos/Shrini-h/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/Shrini-h/pbspro/events","assignees_url":"https://api.github.com/repos/Shrini-h/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/Shrini-h/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/Shrini-h/pbspro/tags","blobs_url":"https://api.github.com/repos/Shrini-h/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/Shrini-h/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/Shrini-h/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/Shrini-h/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/Shrini-h/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/Shrini-h/pbspro/languages","stargazers_url":"https://api.github.com/repos/Shrini-h/pbspro/stargazers","contributors_url":"https://api.github.com/repos/Shrini-h/pbspro/contributors","subscribers_url":"https://api.github.com/repos/Shrini-h/pbspro/subscribers","subscription_url":"https://api.github.com/repos/Shrini-h/pbspro/subscription","commits_url":"https://api.github.com/repos/Shrini-h/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/Shrini-h/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/Shrini-h/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/Shrini-h/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/Shrini-h/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/Shrini-h/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/Shrini-h/pbspro/merges","archive_url":"https://api.github.com/repos/Shrini-h/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/Shrini-h/pbspro/downloads","issues_url":"https://api.github.com/repos/Shrini-h/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/Shrini-h/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/Shrini-h/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/Shrini-h/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/Shrini-h/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/Shrini-h/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/Shrini-h/pbspro/deployments","created_at":"2017-07-20T04:39:41Z","updated_at":"2018-09-28T07:38:58Z","pushed_at":"2018-09-28T15:20:15Z","git_url":"git://github.com/Shrini-h/pbspro.git","ssh_url":"git@github.com:Shrini-h/pbspro.git","clone_url":"https://github.com/Shrini-h/pbspro.git","svn_url":"https://github.com/Shrini-h/pbspro","homepage":"www.pbspro.org","size":16337,"stargazers_count":1,"watchers_count":1,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":0,"open_issues":0,"watchers":1,"default_branch":"master"}},"base":{"label":"PBSPro:master","ref":"master","sha":"2c5fefcdef5b6dffec05393707fa10cc2ccfc0c3","user":{"login":"PBSPro","id":19280436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjgwNDM2","avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"repo":{"id":59082072,"node_id":"MDEwOlJlcG9zaXRvcnk1OTA4MjA3Mg==","name":"pbspro","full_name":"PBSPro/pbspro","private":false,"owner":{"login":"PBSPro","id":19280436,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MjgwNDM2","avatar_url":"https://avatars2.githubusercontent.com/u/19280436?v=4","gravatar_id":"","url":"https://api.github.com/users/PBSPro","html_url":"https://github.com/PBSPro","followers_url":"https://api.github.com/users/PBSPro/followers","following_url":"https://api.github.com/users/PBSPro/following{/other_user}","gists_url":"https://api.github.com/users/PBSPro/gists{/gist_id}","starred_url":"https://api.github.com/users/PBSPro/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/PBSPro/subscriptions","organizations_url":"https://api.github.com/users/PBSPro/orgs","repos_url":"https://api.github.com/users/PBSPro/repos","events_url":"https://api.github.com/users/PBSPro/events{/privacy}","received_events_url":"https://api.github.com/users/PBSPro/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/PBSPro/pbspro","description":"An HPC workload manager and job scheduler for desktops, clusters, and clouds.","fork":false,"url":"https://api.github.com/repos/PBSPro/pbspro","forks_url":"https://api.github.com/repos/PBSPro/pbspro/forks","keys_url":"https://api.github.com/repos/PBSPro/pbspro/keys{/key_id}","collaborators_url":"https://api.github.com/repos/PBSPro/pbspro/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/PBSPro/pbspro/teams","hooks_url":"https://api.github.com/repos/PBSPro/pbspro/hooks","issue_events_url":"https://api.github.com/repos/PBSPro/pbspro/issues/events{/number}","events_url":"https://api.github.com/repos/PBSPro/pbspro/events","assignees_url":"https://api.github.com/repos/PBSPro/pbspro/assignees{/user}","branches_url":"https://api.github.com/repos/PBSPro/pbspro/branches{/branch}","tags_url":"https://api.github.com/repos/PBSPro/pbspro/tags","blobs_url":"https://api.github.com/repos/PBSPro/pbspro/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/PBSPro/pbspro/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/PBSPro/pbspro/git/refs{/sha}","trees_url":"https://api.github.com/repos/PBSPro/pbspro/git/trees{/sha}","statuses_url":"https://api.github.com/repos/PBSPro/pbspro/statuses/{sha}","languages_url":"https://api.github.com/repos/PBSPro/pbspro/languages","stargazers_url":"https://api.github.com/repos/PBSPro/pbspro/stargazers","contributors_url":"https://api.github.com/repos/PBSPro/pbspro/contributors","subscribers_url":"https://api.github.com/repos/PBSPro/pbspro/subscribers","subscription_url":"https://api.github.com/repos/PBSPro/pbspro/subscription","commits_url":"https://api.github.com/repos/PBSPro/pbspro/commits{/sha}","git_commits_url":"https://api.github.com/repos/PBSPro/pbspro/git/commits{/sha}","comments_url":"https://api.github.com/repos/PBSPro/pbspro/comments{/number}","issue_comment_url":"https://api.github.com/repos/PBSPro/pbspro/issues/comments{/number}","contents_url":"https://api.github.com/repos/PBSPro/pbspro/contents/{+path}","compare_url":"https://api.github.com/repos/PBSPro/pbspro/compare/{base}...{head}","merges_url":"https://api.github.com/repos/PBSPro/pbspro/merges","archive_url":"https://api.github.com/repos/PBSPro/pbspro/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/PBSPro/pbspro/downloads","issues_url":"https://api.github.com/repos/PBSPro/pbspro/issues{/number}","pulls_url":"https://api.github.com/repos/PBSPro/pbspro/pulls{/number}","milestones_url":"https://api.github.com/repos/PBSPro/pbspro/milestones{/number}","notifications_url":"https://api.github.com/repos/PBSPro/pbspro/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/PBSPro/pbspro/labels{/name}","releases_url":"https://api.github.com/repos/PBSPro/pbspro/releases{/id}","deployments_url":"https://api.github.com/repos/PBSPro/pbspro/deployments","created_at":"2016-05-18T04:31:29Z","updated_at":"2018-09-27T20:14:40Z","pushed_at":"2018-09-28T15:20:17Z","git_url":"git://github.com/PBSPro/pbspro.git","ssh_url":"git@github.com:PBSPro/pbspro.git","clone_url":"https://github.com/PBSPro/pbspro.git","svn_url":"https://github.com/PBSPro/pbspro","homepage":"www.pbspro.org","size":16090,"stargazers_count":200,"watchers_count":200,"language":"C","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":155,"mirror_url":null,"archived":false,"open_issues_count":21,"license":{"key":"other","name":"NOASSERTION","spdx_id":"NOASSERTION","url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":155,"open_issues":21,"watchers":200,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/807"},"html":{"href":"https://github.com/PBSPro/pbspro/pull/807"},"issue":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/807"},"comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/issues/807/comments"},"review_comments":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/807/comments"},"review_comment":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/PBSPro/pbspro/pulls/807/commits"},"statuses":{"href":"https://api.github.com/repos/PBSPro/pbspro/statuses/b2f22afcadb50bc872cb198d65b51190511aaf45"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"Shrini-h"}}