{"action":"created","issue":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/3118","repository_url":"https://api.github.com/repos/Azure/acs-engine","labels_url":"https://api.github.com/repos/Azure/acs-engine/issues/3118/labels{/name}","comments_url":"https://api.github.com/repos/Azure/acs-engine/issues/3118/comments","events_url":"https://api.github.com/repos/Azure/acs-engine/issues/3118/events","html_url":"https://github.com/Azure/acs-engine/pull/3118","id":327996449,"node_id":"MDExOlB1bGxSZXF1ZXN0MTkxNjQ1Njg0","number":3118,"title":"acs-engine orchestrators should thrown an error when an invalid/unsup…","user":{"login":"tariq1890","id":2658224,"node_id":"MDQ6VXNlcjI2NTgyMjQ=","avatar_url":"https://avatars1.githubusercontent.com/u/2658224?v=4","gravatar_id":"","url":"https://api.github.com/users/tariq1890","html_url":"https://github.com/tariq1890","followers_url":"https://api.github.com/users/tariq1890/followers","following_url":"https://api.github.com/users/tariq1890/following{/other_user}","gists_url":"https://api.github.com/users/tariq1890/gists{/gist_id}","starred_url":"https://api.github.com/users/tariq1890/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/tariq1890/subscriptions","organizations_url":"https://api.github.com/users/tariq1890/orgs","repos_url":"https://api.github.com/users/tariq1890/repos","events_url":"https://api.github.com/users/tariq1890/events{/privacy}","received_events_url":"https://api.github.com/users/tariq1890/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-05-31T05:12:43Z","updated_at":"2018-05-31T05:12:44Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/Azure/acs-engine/pulls/3118","html_url":"https://github.com/Azure/acs-engine/pull/3118","diff_url":"https://github.com/Azure/acs-engine/pull/3118.diff","patch_url":"https://github.com/Azure/acs-engine/pull/3118.patch"},"body":"…ported version is provided\r\n\r\n<!--  Thanks for sending a pull request!  Here are some tips for you:\r\n1. If you want *faster* PR reviews, read how: https://github.com/kubernetes/community/blob/master/contributors/devel/pull-requests.md#best-practices-for-faster-reviews\r\n-->\r\n\r\n**What this PR does / why we need it**: The orchestrators command should error out when an invalid orchestrator version is provided as input.\r\n\r\n**Which issue this PR fixes** *(optional, in `fixes #<issue number>(, fixes #<issue_number>, ...)` format, will close that issue when PR gets merged)*: fixes #2852\r\n\r\n**Special notes for your reviewer**:\r\n\r\n**If applicable**:\r\n- [ ] documentation\r\n- [ ] unit tests\r\n- [ ] tested backward compatibility (ie. deploy with previous version, upgrade with this branch)\r\n\r\n**Release note**:\r\n<!--  Steps to write your release note:\r\n1. Use the release-note-* labels to set the release note state (if you have access)\r\n2. Enter your extended release note in the below block; leaving it blank means using the PR title as the release note. If no release note is required, just write `NONE`.\r\n-->\r\n```release-note\r\n```\r\n"},"comment":{"url":"https://api.github.com/repos/Azure/acs-engine/issues/comments/393405715","html_url":"https://github.com/Azure/acs-engine/pull/3118#issuecomment-393405715","issue_url":"https://api.github.com/repos/Azure/acs-engine/issues/3118","id":393405715,"node_id":"MDEyOklzc3VlQ29tbWVudDM5MzQwNTcxNQ==","user":{"login":"acs-bot","id":24280864,"node_id":"MDQ6VXNlcjI0MjgwODY0","avatar_url":"https://avatars2.githubusercontent.com/u/24280864?v=4","gravatar_id":"","url":"https://api.github.com/users/acs-bot","html_url":"https://github.com/acs-bot","followers_url":"https://api.github.com/users/acs-bot/followers","following_url":"https://api.github.com/users/acs-bot/following{/other_user}","gists_url":"https://api.github.com/users/acs-bot/gists{/gist_id}","starred_url":"https://api.github.com/users/acs-bot/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/acs-bot/subscriptions","organizations_url":"https://api.github.com/users/acs-bot/orgs","repos_url":"https://api.github.com/users/acs-bot/repos","events_url":"https://api.github.com/users/acs-bot/events{/privacy}","received_events_url":"https://api.github.com/users/acs-bot/received_events","type":"User","site_admin":false},"created_at":"2018-05-31T05:12:44Z","updated_at":"2018-05-31T05:12:44Z","author_association":"COLLABORATOR","body":"[APPROVALNOTIFIER] This PR is **NOT APPROVED**\n\nThis pull-request has been approved by: \nTo fully approve this pull request, please assign additional approvers.\nWe suggest the following additional approver: **brendandburns**\n\nAssign the PR to them by writing `/assign @brendandburns` in a comment when ready.\n\nThe full list of commands accepted by this bot can be found [here](https://go.k8s.io/bot-commands).\n\nThe pull request process is described [here](https://git.k8s.io/community/contributors/guide/owners.md#the-code-review-process)\n\n<details open>\nNeeds approval from an approver in each of these files:\n\n- **[OWNERS](https://github.com/Azure/acs-engine/blob/master/OWNERS)**\n\nApprovers can indicate their approval by writing `/approve` in a comment\nApprovers can cancel approval by writing `/approve cancel` in a comment\n</details>\n<!-- META={\"approvers\":[\"brendandburns\"]} -->"}}
{"actor":{"display_login":"acs-bot"}}