{"action":"created","comment":{"url":"https://api.github.com/repos/kotlintest/kotlintest/pulls/comments/245407310","pull_request_review_id":189511455,"id":245407310,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0NTQwNzMxMA==","diff_hunk":"@@ -160,16 +162,27 @@ class TestCaseExecutor(private val listener: TestEngineListener,\n    */\n   private fun before(testCase: TestCase) {\n     listener.enterTestCase(testCase)\n-    val userListeners = listOf(testCase.spec) + testCase.spec.listeners() + Project.listeners()\n+\n+    val userListeners = testCase.spec.listeners() + Project.listeners()\n     userListeners.forEach { it.beforeTest(testCase.description) }\n+\n+    if (testCase.config.enabled) {\n+      // Only execute before test from the spec if the test is enabled","path":"kotlintest-runner/kotlintest-runner-jvm/src/main/kotlin/io/kotlintest/runner/jvm/TestCaseExecutor.kt","position":203,"original_position":43,"commit_id":"b1092f4060447426068bc2265f4cfcea73b95c52","original_commit_id":"d2fbfc367da5167c36cdf131f0ff6a0921b3fccf","user":{"login":"sksamuel","id":743706,"node_id":"MDQ6VXNlcjc0MzcwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/743706?v=4","gravatar_id":"","url":"https://api.github.com/users/sksamuel","html_url":"https://github.com/sksamuel","followers_url":"https://api.github.com/users/sksamuel/followers","following_url":"https://api.github.com/users/sksamuel/following{/other_user}","gists_url":"https://api.github.com/users/sksamuel/gists{/gist_id}","starred_url":"https://api.github.com/users/sksamuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sksamuel/subscriptions","organizations_url":"https://api.github.com/users/sksamuel/orgs","repos_url":"https://api.github.com/users/sksamuel/repos","events_url":"https://api.github.com/users/sksamuel/events{/privacy}","received_events_url":"https://api.github.com/users/sksamuel/received_events","type":"User","site_admin":false},"body":"Let's remove this functionality from here. It has nothing to do with coroutines.\r\nWe'll address it in the \"rework listeners\" branch.","created_at":"2019-01-04T20:10:11Z","updated_at":"2019-01-04T20:10:11Z","html_url":"https://github.com/kotlintest/kotlintest/pull/518#discussion_r245407310","pull_request_url":"https://api.github.com/repos/kotlintest/kotlintest/pulls/518","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/kotlintest/kotlintest/pulls/comments/245407310"},"html":{"href":"https://github.com/kotlintest/kotlintest/pull/518#discussion_r245407310"},"pull_request":{"href":"https://api.github.com/repos/kotlintest/kotlintest/pulls/518"}}},"pull_request":{"url":"https://api.github.com/repos/kotlintest/kotlintest/pulls/518","id":241692094,"node_id":"MDExOlB1bGxSZXF1ZXN0MjQxNjkyMDk0","html_url":"https://github.com/kotlintest/kotlintest/pull/518","diff_url":"https://github.com/kotlintest/kotlintest/pull/518.diff","patch_url":"https://github.com/kotlintest/kotlintest/pull/518.patch","issue_url":"https://api.github.com/repos/kotlintest/kotlintest/issues/518","number":518,"state":"open","locked":false,"title":"all spec DSLs now provide coroutine scopes for suspendable functions;…","user":{"login":"sksamuel","id":743706,"node_id":"MDQ6VXNlcjc0MzcwNg==","avatar_url":"https://avatars3.githubusercontent.com/u/743706?v=4","gravatar_id":"","url":"https://api.github.com/users/sksamuel","html_url":"https://github.com/sksamuel","followers_url":"https://api.github.com/users/sksamuel/followers","following_url":"https://api.github.com/users/sksamuel/following{/other_user}","gists_url":"https://api.github.com/users/sksamuel/gists{/gist_id}","starred_url":"https://api.github.com/users/sksamuel/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/sksamuel/subscriptions","organizations_url":"https://api.github.com/users/sksamuel/orgs","repos_url":"https://api.github.com/users/sksamuel/repos","events_url":"https://api.github.com/users/sksamuel/events{/privacy}","received_events_url":"https://api.github.com/users/sksamuel/received_events","type":"User","site_admin":false},"body":"… Reimplemented spec runners using coroutines; breaking changes to extension function signatures to add suspend keyword #386","created_at":"2019-01-02T08:27:11Z","updated_at":"2019-01-04T20:10:11Z","closed_at":null,"merged_at":null,"merge_commit_sha":"96c60fa84118d5b08ea1510bd7b3c1cdfd15f602","assignee":null,"assignees":[],"requested_reviewers":[{"login":"ajalt","id":1109214,"node_id":"MDQ6VXNlcjExMDkyMTQ=","avatar_url":"https://avatars2.githubusercontent.com/u/1109214?v=4","gravatar_id":"","url":"https://api.github.com/users/ajalt","html_url":"https://github.com/ajalt","followers_url":"https://api.github.com/users/ajalt/followers","following_url":"https://api.github.com/users/ajalt/following{/other_user}","gists_url":"https://api.github.com/users/ajalt/gists{/gist_id}","starred_url":"https://api.github.com/users/ajalt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ajalt/subscriptions","organizations_url":"https://api.github.com/users/ajalt/orgs","repos_url":"https://api.github.com/users/ajalt/repos","events_url":"https://api.github.com/users/ajalt/events{/privacy}","received_events_url":"https://api.github.com/users/ajalt/received_events","type":"User","site_admin":false}],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/kotlintest/kotlintest/pulls/518/commits","review_comments_url":"https://api.github.com/repos/kotlintest/kotlintest/pulls/518/comments","review_comment_url":"https://api.github.com/repos/kotlintest/kotlintest/pulls/comments{/number}","comments_url":"https://api.github.com/repos/kotlintest/kotlintest/issues/518/comments","statuses_url":"https://api.github.com/repos/kotlintest/kotlintest/statuses/b1092f4060447426068bc2265f4cfcea73b95c52","head":{"label":"kotlintest:feature/coroutine2","ref":"feature/coroutine2","sha":"b1092f4060447426068bc2265f4cfcea73b95c52","user":{"login":"kotlintest","id":17798238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzk4MjM4","avatar_url":"https://avatars1.githubusercontent.com/u/17798238?v=4","gravatar_id":"","url":"https://api.github.com/users/kotlintest","html_url":"https://github.com/kotlintest","followers_url":"https://api.github.com/users/kotlintest/followers","following_url":"https://api.github.com/users/kotlintest/following{/other_user}","gists_url":"https://api.github.com/users/kotlintest/gists{/gist_id}","starred_url":"https://api.github.com/users/kotlintest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotlintest/subscriptions","organizations_url":"https://api.github.com/users/kotlintest/orgs","repos_url":"https://api.github.com/users/kotlintest/repos","events_url":"https://api.github.com/users/kotlintest/events{/privacy}","received_events_url":"https://api.github.com/users/kotlintest/received_events","type":"Organization","site_admin":false},"repo":{"id":47071082,"node_id":"MDEwOlJlcG9zaXRvcnk0NzA3MTA4Mg==","name":"kotlintest","full_name":"kotlintest/kotlintest","private":false,"owner":{"login":"kotlintest","id":17798238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzk4MjM4","avatar_url":"https://avatars1.githubusercontent.com/u/17798238?v=4","gravatar_id":"","url":"https://api.github.com/users/kotlintest","html_url":"https://github.com/kotlintest","followers_url":"https://api.github.com/users/kotlintest/followers","following_url":"https://api.github.com/users/kotlintest/following{/other_user}","gists_url":"https://api.github.com/users/kotlintest/gists{/gist_id}","starred_url":"https://api.github.com/users/kotlintest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotlintest/subscriptions","organizations_url":"https://api.github.com/users/kotlintest/orgs","repos_url":"https://api.github.com/users/kotlintest/repos","events_url":"https://api.github.com/users/kotlintest/events{/privacy}","received_events_url":"https://api.github.com/users/kotlintest/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kotlintest/kotlintest","description":"Powerful, elegant and flexible Kotlin test framework","fork":false,"url":"https://api.github.com/repos/kotlintest/kotlintest","forks_url":"https://api.github.com/repos/kotlintest/kotlintest/forks","keys_url":"https://api.github.com/repos/kotlintest/kotlintest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kotlintest/kotlintest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kotlintest/kotlintest/teams","hooks_url":"https://api.github.com/repos/kotlintest/kotlintest/hooks","issue_events_url":"https://api.github.com/repos/kotlintest/kotlintest/issues/events{/number}","events_url":"https://api.github.com/repos/kotlintest/kotlintest/events","assignees_url":"https://api.github.com/repos/kotlintest/kotlintest/assignees{/user}","branches_url":"https://api.github.com/repos/kotlintest/kotlintest/branches{/branch}","tags_url":"https://api.github.com/repos/kotlintest/kotlintest/tags","blobs_url":"https://api.github.com/repos/kotlintest/kotlintest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kotlintest/kotlintest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kotlintest/kotlintest/git/refs{/sha}","trees_url":"https://api.github.com/repos/kotlintest/kotlintest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kotlintest/kotlintest/statuses/{sha}","languages_url":"https://api.github.com/repos/kotlintest/kotlintest/languages","stargazers_url":"https://api.github.com/repos/kotlintest/kotlintest/stargazers","contributors_url":"https://api.github.com/repos/kotlintest/kotlintest/contributors","subscribers_url":"https://api.github.com/repos/kotlintest/kotlintest/subscribers","subscription_url":"https://api.github.com/repos/kotlintest/kotlintest/subscription","commits_url":"https://api.github.com/repos/kotlintest/kotlintest/commits{/sha}","git_commits_url":"https://api.github.com/repos/kotlintest/kotlintest/git/commits{/sha}","comments_url":"https://api.github.com/repos/kotlintest/kotlintest/comments{/number}","issue_comment_url":"https://api.github.com/repos/kotlintest/kotlintest/issues/comments{/number}","contents_url":"https://api.github.com/repos/kotlintest/kotlintest/contents/{+path}","compare_url":"https://api.github.com/repos/kotlintest/kotlintest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kotlintest/kotlintest/merges","archive_url":"https://api.github.com/repos/kotlintest/kotlintest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kotlintest/kotlintest/downloads","issues_url":"https://api.github.com/repos/kotlintest/kotlintest/issues{/number}","pulls_url":"https://api.github.com/repos/kotlintest/kotlintest/pulls{/number}","milestones_url":"https://api.github.com/repos/kotlintest/kotlintest/milestones{/number}","notifications_url":"https://api.github.com/repos/kotlintest/kotlintest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kotlintest/kotlintest/labels{/name}","releases_url":"https://api.github.com/repos/kotlintest/kotlintest/releases{/id}","deployments_url":"https://api.github.com/repos/kotlintest/kotlintest/deployments","created_at":"2015-11-29T16:32:15Z","updated_at":"2019-01-03T15:10:26Z","pushed_at":"2019-01-04T19:48:38Z","git_url":"git://github.com/kotlintest/kotlintest.git","ssh_url":"git@github.com:kotlintest/kotlintest.git","clone_url":"https://github.com/kotlintest/kotlintest.git","svn_url":"https://github.com/kotlintest/kotlintest","homepage":"","size":2601,"stargazers_count":1293,"watchers_count":1293,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":156,"open_issues":43,"watchers":1293,"default_branch":"master"}},"base":{"label":"kotlintest:master","ref":"master","sha":"46426bd3445f4d330c44e79ce1ee48c54c5bb49c","user":{"login":"kotlintest","id":17798238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzk4MjM4","avatar_url":"https://avatars1.githubusercontent.com/u/17798238?v=4","gravatar_id":"","url":"https://api.github.com/users/kotlintest","html_url":"https://github.com/kotlintest","followers_url":"https://api.github.com/users/kotlintest/followers","following_url":"https://api.github.com/users/kotlintest/following{/other_user}","gists_url":"https://api.github.com/users/kotlintest/gists{/gist_id}","starred_url":"https://api.github.com/users/kotlintest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotlintest/subscriptions","organizations_url":"https://api.github.com/users/kotlintest/orgs","repos_url":"https://api.github.com/users/kotlintest/repos","events_url":"https://api.github.com/users/kotlintest/events{/privacy}","received_events_url":"https://api.github.com/users/kotlintest/received_events","type":"Organization","site_admin":false},"repo":{"id":47071082,"node_id":"MDEwOlJlcG9zaXRvcnk0NzA3MTA4Mg==","name":"kotlintest","full_name":"kotlintest/kotlintest","private":false,"owner":{"login":"kotlintest","id":17798238,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE3Nzk4MjM4","avatar_url":"https://avatars1.githubusercontent.com/u/17798238?v=4","gravatar_id":"","url":"https://api.github.com/users/kotlintest","html_url":"https://github.com/kotlintest","followers_url":"https://api.github.com/users/kotlintest/followers","following_url":"https://api.github.com/users/kotlintest/following{/other_user}","gists_url":"https://api.github.com/users/kotlintest/gists{/gist_id}","starred_url":"https://api.github.com/users/kotlintest/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kotlintest/subscriptions","organizations_url":"https://api.github.com/users/kotlintest/orgs","repos_url":"https://api.github.com/users/kotlintest/repos","events_url":"https://api.github.com/users/kotlintest/events{/privacy}","received_events_url":"https://api.github.com/users/kotlintest/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/kotlintest/kotlintest","description":"Powerful, elegant and flexible Kotlin test framework","fork":false,"url":"https://api.github.com/repos/kotlintest/kotlintest","forks_url":"https://api.github.com/repos/kotlintest/kotlintest/forks","keys_url":"https://api.github.com/repos/kotlintest/kotlintest/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kotlintest/kotlintest/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kotlintest/kotlintest/teams","hooks_url":"https://api.github.com/repos/kotlintest/kotlintest/hooks","issue_events_url":"https://api.github.com/repos/kotlintest/kotlintest/issues/events{/number}","events_url":"https://api.github.com/repos/kotlintest/kotlintest/events","assignees_url":"https://api.github.com/repos/kotlintest/kotlintest/assignees{/user}","branches_url":"https://api.github.com/repos/kotlintest/kotlintest/branches{/branch}","tags_url":"https://api.github.com/repos/kotlintest/kotlintest/tags","blobs_url":"https://api.github.com/repos/kotlintest/kotlintest/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kotlintest/kotlintest/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kotlintest/kotlintest/git/refs{/sha}","trees_url":"https://api.github.com/repos/kotlintest/kotlintest/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kotlintest/kotlintest/statuses/{sha}","languages_url":"https://api.github.com/repos/kotlintest/kotlintest/languages","stargazers_url":"https://api.github.com/repos/kotlintest/kotlintest/stargazers","contributors_url":"https://api.github.com/repos/kotlintest/kotlintest/contributors","subscribers_url":"https://api.github.com/repos/kotlintest/kotlintest/subscribers","subscription_url":"https://api.github.com/repos/kotlintest/kotlintest/subscription","commits_url":"https://api.github.com/repos/kotlintest/kotlintest/commits{/sha}","git_commits_url":"https://api.github.com/repos/kotlintest/kotlintest/git/commits{/sha}","comments_url":"https://api.github.com/repos/kotlintest/kotlintest/comments{/number}","issue_comment_url":"https://api.github.com/repos/kotlintest/kotlintest/issues/comments{/number}","contents_url":"https://api.github.com/repos/kotlintest/kotlintest/contents/{+path}","compare_url":"https://api.github.com/repos/kotlintest/kotlintest/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kotlintest/kotlintest/merges","archive_url":"https://api.github.com/repos/kotlintest/kotlintest/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kotlintest/kotlintest/downloads","issues_url":"https://api.github.com/repos/kotlintest/kotlintest/issues{/number}","pulls_url":"https://api.github.com/repos/kotlintest/kotlintest/pulls{/number}","milestones_url":"https://api.github.com/repos/kotlintest/kotlintest/milestones{/number}","notifications_url":"https://api.github.com/repos/kotlintest/kotlintest/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kotlintest/kotlintest/labels{/name}","releases_url":"https://api.github.com/repos/kotlintest/kotlintest/releases{/id}","deployments_url":"https://api.github.com/repos/kotlintest/kotlintest/deployments","created_at":"2015-11-29T16:32:15Z","updated_at":"2019-01-03T15:10:26Z","pushed_at":"2019-01-04T19:48:38Z","git_url":"git://github.com/kotlintest/kotlintest.git","ssh_url":"git@github.com:kotlintest/kotlintest.git","clone_url":"https://github.com/kotlintest/kotlintest.git","svn_url":"https://github.com/kotlintest/kotlintest","homepage":"","size":2601,"stargazers_count":1293,"watchers_count":1293,"language":"Kotlin","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":156,"mirror_url":null,"archived":false,"open_issues_count":43,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0","node_id":"MDc6TGljZW5zZTI="},"forks":156,"open_issues":43,"watchers":1293,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/kotlintest/kotlintest/pulls/518"},"html":{"href":"https://github.com/kotlintest/kotlintest/pull/518"},"issue":{"href":"https://api.github.com/repos/kotlintest/kotlintest/issues/518"},"comments":{"href":"https://api.github.com/repos/kotlintest/kotlintest/issues/518/comments"},"review_comments":{"href":"https://api.github.com/repos/kotlintest/kotlintest/pulls/518/comments"},"review_comment":{"href":"https://api.github.com/repos/kotlintest/kotlintest/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/kotlintest/kotlintest/pulls/518/commits"},"statuses":{"href":"https://api.github.com/repos/kotlintest/kotlintest/statuses/b1092f4060447426068bc2265f4cfcea73b95c52"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"sksamuel"}}