{"action":"closed","number":5,"pull_request":{"url":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls/5","id":223762472,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIzNzYyNDcy","html_url":"https://github.com/BitMEX/react-native-navigation/pull/5","diff_url":"https://github.com/BitMEX/react-native-navigation/pull/5.diff","patch_url":"https://github.com/BitMEX/react-native-navigation/pull/5.patch","issue_url":"https://api.github.com/repos/BitMEX/react-native-navigation/issues/5","number":5,"state":"closed","locked":false,"title":"Android auto-blur option","user":{"login":"ericketts","id":35305520,"node_id":"MDQ6VXNlcjM1MzA1NTIw","avatar_url":"https://avatars1.githubusercontent.com/u/35305520?v=4","gravatar_id":"","url":"https://api.github.com/users/ericketts","html_url":"https://github.com/ericketts","followers_url":"https://api.github.com/users/ericketts/followers","following_url":"https://api.github.com/users/ericketts/following{/other_user}","gists_url":"https://api.github.com/users/ericketts/gists{/gist_id}","starred_url":"https://api.github.com/users/ericketts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericketts/subscriptions","organizations_url":"https://api.github.com/users/ericketts/orgs","repos_url":"https://api.github.com/users/ericketts/repos","events_url":"https://api.github.com/users/ericketts/events{/privacy}","received_events_url":"https://api.github.com/users/ericketts/received_events","type":"User","site_admin":false},"body":"This PR adds an Android specific boolean flag `blurOnUnmount` that can be passed as part of the options when pushing or popping a component; when this flag is `true` for a component, any input views that have focus on said component will be blurred when the component is getting destroyed, which has the effect of dismissing the keyboard when the component is unmounted.\r\n\r\nThe reason this functionality is behind a flag and not automatically enabled by default is because the appearing component will not be able to focus an input if the disappearing component performs the auto-blur functionality. Its important to be aware of this limitation to avoid weird and seemingly inexplicable behavior. If this limitation becomes a blocker, it might be possible to work around it by futzing with the ordering of calls to the appearing and disappearing components, however I didn't know for sure this would be the case, so it seemed safer to put the functionality behind a option flag and cross the \"always-on\" bridge if and when we get to it.\r\n\r\nThis PR will also have an accompanying PR for the frontend repo, I'll update this description with a link to that PR when it goes up.\r\n\r\n**Edit:** frontend PR is up at BitMEX/frontend#1626","created_at":"2018-10-17T21:41:00Z","updated_at":"2018-10-18T00:14:54Z","closed_at":"2018-10-18T00:14:54Z","merged_at":"2018-10-18T00:14:54Z","merge_commit_sha":"592f46c6dfb6826f9f3c30388c7801b27eeb7c23","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":899785907,"node_id":"MDU6TGFiZWw4OTk3ODU5MDc=","url":"https://api.github.com/repos/BitMEX/react-native-navigation/labels/enhancement","name":"enhancement","color":"a2eeef","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls/5/commits","review_comments_url":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls/5/comments","review_comment_url":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls/comments{/number}","comments_url":"https://api.github.com/repos/BitMEX/react-native-navigation/issues/5/comments","statuses_url":"https://api.github.com/repos/BitMEX/react-native-navigation/statuses/3bfb373cacbb05ff7e819e29d670348468017316","head":{"label":"BitMEX:feature/android-auto-blur","ref":"feature/android-auto-blur","sha":"3bfb373cacbb05ff7e819e29d670348468017316","user":{"login":"BitMEX","id":6471318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzEzMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6471318?v=4","gravatar_id":"","url":"https://api.github.com/users/BitMEX","html_url":"https://github.com/BitMEX","followers_url":"https://api.github.com/users/BitMEX/followers","following_url":"https://api.github.com/users/BitMEX/following{/other_user}","gists_url":"https://api.github.com/users/BitMEX/gists{/gist_id}","starred_url":"https://api.github.com/users/BitMEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitMEX/subscriptions","organizations_url":"https://api.github.com/users/BitMEX/orgs","repos_url":"https://api.github.com/users/BitMEX/repos","events_url":"https://api.github.com/users/BitMEX/events{/privacy}","received_events_url":"https://api.github.com/users/BitMEX/received_events","type":"Organization","site_admin":false},"repo":{"id":129288734,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyODg3MzQ=","name":"react-native-navigation","full_name":"BitMEX/react-native-navigation","private":false,"owner":{"login":"BitMEX","id":6471318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzEzMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6471318?v=4","gravatar_id":"","url":"https://api.github.com/users/BitMEX","html_url":"https://github.com/BitMEX","followers_url":"https://api.github.com/users/BitMEX/followers","following_url":"https://api.github.com/users/BitMEX/following{/other_user}","gists_url":"https://api.github.com/users/BitMEX/gists{/gist_id}","starred_url":"https://api.github.com/users/BitMEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitMEX/subscriptions","organizations_url":"https://api.github.com/users/BitMEX/orgs","repos_url":"https://api.github.com/users/BitMEX/repos","events_url":"https://api.github.com/users/BitMEX/events{/privacy}","received_events_url":"https://api.github.com/users/BitMEX/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BitMEX/react-native-navigation","description":"A complete native navigation solution for React Native","fork":true,"url":"https://api.github.com/repos/BitMEX/react-native-navigation","forks_url":"https://api.github.com/repos/BitMEX/react-native-navigation/forks","keys_url":"https://api.github.com/repos/BitMEX/react-native-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BitMEX/react-native-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BitMEX/react-native-navigation/teams","hooks_url":"https://api.github.com/repos/BitMEX/react-native-navigation/hooks","issue_events_url":"https://api.github.com/repos/BitMEX/react-native-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/BitMEX/react-native-navigation/events","assignees_url":"https://api.github.com/repos/BitMEX/react-native-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/BitMEX/react-native-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/BitMEX/react-native-navigation/tags","blobs_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BitMEX/react-native-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/BitMEX/react-native-navigation/languages","stargazers_url":"https://api.github.com/repos/BitMEX/react-native-navigation/stargazers","contributors_url":"https://api.github.com/repos/BitMEX/react-native-navigation/contributors","subscribers_url":"https://api.github.com/repos/BitMEX/react-native-navigation/subscribers","subscription_url":"https://api.github.com/repos/BitMEX/react-native-navigation/subscription","commits_url":"https://api.github.com/repos/BitMEX/react-native-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/BitMEX/react-native-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/BitMEX/react-native-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/BitMEX/react-native-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/BitMEX/react-native-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BitMEX/react-native-navigation/merges","archive_url":"https://api.github.com/repos/BitMEX/react-native-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BitMEX/react-native-navigation/downloads","issues_url":"https://api.github.com/repos/BitMEX/react-native-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/BitMEX/react-native-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/BitMEX/react-native-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BitMEX/react-native-navigation/labels{/name}","releases_url":"https://api.github.com/repos/BitMEX/react-native-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/BitMEX/react-native-navigation/deployments","created_at":"2018-04-12T17:33:46Z","updated_at":"2018-06-11T21:48:07Z","pushed_at":"2018-10-18T00:14:54Z","git_url":"git://github.com/BitMEX/react-native-navigation.git","ssh_url":"git@github.com:BitMEX/react-native-navigation.git","clone_url":"https://github.com/BitMEX/react-native-navigation.git","svn_url":"https://github.com/BitMEX/react-native-navigation","homepage":"https://wix.github.io/react-native-navigation/","size":12518,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"BitMEX:v2","ref":"v2","sha":"b360fb9b25653cb346303b14ba0bb3342db5b49a","user":{"login":"BitMEX","id":6471318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzEzMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6471318?v=4","gravatar_id":"","url":"https://api.github.com/users/BitMEX","html_url":"https://github.com/BitMEX","followers_url":"https://api.github.com/users/BitMEX/followers","following_url":"https://api.github.com/users/BitMEX/following{/other_user}","gists_url":"https://api.github.com/users/BitMEX/gists{/gist_id}","starred_url":"https://api.github.com/users/BitMEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitMEX/subscriptions","organizations_url":"https://api.github.com/users/BitMEX/orgs","repos_url":"https://api.github.com/users/BitMEX/repos","events_url":"https://api.github.com/users/BitMEX/events{/privacy}","received_events_url":"https://api.github.com/users/BitMEX/received_events","type":"Organization","site_admin":false},"repo":{"id":129288734,"node_id":"MDEwOlJlcG9zaXRvcnkxMjkyODg3MzQ=","name":"react-native-navigation","full_name":"BitMEX/react-native-navigation","private":false,"owner":{"login":"BitMEX","id":6471318,"node_id":"MDEyOk9yZ2FuaXphdGlvbjY0NzEzMTg=","avatar_url":"https://avatars0.githubusercontent.com/u/6471318?v=4","gravatar_id":"","url":"https://api.github.com/users/BitMEX","html_url":"https://github.com/BitMEX","followers_url":"https://api.github.com/users/BitMEX/followers","following_url":"https://api.github.com/users/BitMEX/following{/other_user}","gists_url":"https://api.github.com/users/BitMEX/gists{/gist_id}","starred_url":"https://api.github.com/users/BitMEX/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BitMEX/subscriptions","organizations_url":"https://api.github.com/users/BitMEX/orgs","repos_url":"https://api.github.com/users/BitMEX/repos","events_url":"https://api.github.com/users/BitMEX/events{/privacy}","received_events_url":"https://api.github.com/users/BitMEX/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/BitMEX/react-native-navigation","description":"A complete native navigation solution for React Native","fork":true,"url":"https://api.github.com/repos/BitMEX/react-native-navigation","forks_url":"https://api.github.com/repos/BitMEX/react-native-navigation/forks","keys_url":"https://api.github.com/repos/BitMEX/react-native-navigation/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BitMEX/react-native-navigation/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BitMEX/react-native-navigation/teams","hooks_url":"https://api.github.com/repos/BitMEX/react-native-navigation/hooks","issue_events_url":"https://api.github.com/repos/BitMEX/react-native-navigation/issues/events{/number}","events_url":"https://api.github.com/repos/BitMEX/react-native-navigation/events","assignees_url":"https://api.github.com/repos/BitMEX/react-native-navigation/assignees{/user}","branches_url":"https://api.github.com/repos/BitMEX/react-native-navigation/branches{/branch}","tags_url":"https://api.github.com/repos/BitMEX/react-native-navigation/tags","blobs_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/refs{/sha}","trees_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BitMEX/react-native-navigation/statuses/{sha}","languages_url":"https://api.github.com/repos/BitMEX/react-native-navigation/languages","stargazers_url":"https://api.github.com/repos/BitMEX/react-native-navigation/stargazers","contributors_url":"https://api.github.com/repos/BitMEX/react-native-navigation/contributors","subscribers_url":"https://api.github.com/repos/BitMEX/react-native-navigation/subscribers","subscription_url":"https://api.github.com/repos/BitMEX/react-native-navigation/subscription","commits_url":"https://api.github.com/repos/BitMEX/react-native-navigation/commits{/sha}","git_commits_url":"https://api.github.com/repos/BitMEX/react-native-navigation/git/commits{/sha}","comments_url":"https://api.github.com/repos/BitMEX/react-native-navigation/comments{/number}","issue_comment_url":"https://api.github.com/repos/BitMEX/react-native-navigation/issues/comments{/number}","contents_url":"https://api.github.com/repos/BitMEX/react-native-navigation/contents/{+path}","compare_url":"https://api.github.com/repos/BitMEX/react-native-navigation/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BitMEX/react-native-navigation/merges","archive_url":"https://api.github.com/repos/BitMEX/react-native-navigation/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BitMEX/react-native-navigation/downloads","issues_url":"https://api.github.com/repos/BitMEX/react-native-navigation/issues{/number}","pulls_url":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls{/number}","milestones_url":"https://api.github.com/repos/BitMEX/react-native-navigation/milestones{/number}","notifications_url":"https://api.github.com/repos/BitMEX/react-native-navigation/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BitMEX/react-native-navigation/labels{/name}","releases_url":"https://api.github.com/repos/BitMEX/react-native-navigation/releases{/id}","deployments_url":"https://api.github.com/repos/BitMEX/react-native-navigation/deployments","created_at":"2018-04-12T17:33:46Z","updated_at":"2018-06-11T21:48:07Z","pushed_at":"2018-10-18T00:14:54Z","git_url":"git://github.com/BitMEX/react-native-navigation.git","ssh_url":"git@github.com:BitMEX/react-native-navigation.git","clone_url":"https://github.com/BitMEX/react-native-navigation.git","svn_url":"https://github.com/BitMEX/react-native-navigation","homepage":"https://wix.github.io/react-native-navigation/","size":12518,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":1,"open_issues":0,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls/5"},"html":{"href":"https://github.com/BitMEX/react-native-navigation/pull/5"},"issue":{"href":"https://api.github.com/repos/BitMEX/react-native-navigation/issues/5"},"comments":{"href":"https://api.github.com/repos/BitMEX/react-native-navigation/issues/5/comments"},"review_comments":{"href":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls/5/comments"},"review_comment":{"href":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/BitMEX/react-native-navigation/pulls/5/commits"},"statuses":{"href":"https://api.github.com/repos/BitMEX/react-native-navigation/statuses/3bfb373cacbb05ff7e819e29d670348468017316"}},"author_association":"COLLABORATOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"ericketts","id":35305520,"node_id":"MDQ6VXNlcjM1MzA1NTIw","avatar_url":"https://avatars1.githubusercontent.com/u/35305520?v=4","gravatar_id":"","url":"https://api.github.com/users/ericketts","html_url":"https://github.com/ericketts","followers_url":"https://api.github.com/users/ericketts/followers","following_url":"https://api.github.com/users/ericketts/following{/other_user}","gists_url":"https://api.github.com/users/ericketts/gists{/gist_id}","starred_url":"https://api.github.com/users/ericketts/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ericketts/subscriptions","organizations_url":"https://api.github.com/users/ericketts/orgs","repos_url":"https://api.github.com/users/ericketts/repos","events_url":"https://api.github.com/users/ericketts/events{/privacy}","received_events_url":"https://api.github.com/users/ericketts/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":3,"additions":38,"deletions":7,"changed_files":3}}
{"actor":{"display_login":"ericketts"}}