{"action":"created","issue":{"url":"https://api.github.com/repos/amethyst/laminar/issues/21","repository_url":"https://api.github.com/repos/amethyst/laminar","labels_url":"https://api.github.com/repos/amethyst/laminar/issues/21/labels{/name}","comments_url":"https://api.github.com/repos/amethyst/laminar/issues/21/comments","events_url":"https://api.github.com/repos/amethyst/laminar/issues/21/events","html_url":"https://github.com/amethyst/laminar/pull/21","id":367957180,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIxMjQ2NDc0","number":21,"title":"Implemented Connection Pool.","user":{"login":"TimonPost","id":19969910,"node_id":"MDQ6VXNlcjE5OTY5OTEw","avatar_url":"https://avatars3.githubusercontent.com/u/19969910?v=4","gravatar_id":"","url":"https://api.github.com/users/TimonPost","html_url":"https://github.com/TimonPost","followers_url":"https://api.github.com/users/TimonPost/followers","following_url":"https://api.github.com/users/TimonPost/following{/other_user}","gists_url":"https://api.github.com/users/TimonPost/gists{/gist_id}","starred_url":"https://api.github.com/users/TimonPost/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/TimonPost/subscriptions","organizations_url":"https://api.github.com/users/TimonPost/orgs","repos_url":"https://api.github.com/users/TimonPost/repos","events_url":"https://api.github.com/users/TimonPost/events{/privacy}","received_events_url":"https://api.github.com/users/TimonPost/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-10-08T21:20:34Z","updated_at":"2018-10-09T15:00:41Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/amethyst/laminar/pulls/21","html_url":"https://github.com/amethyst/laminar/pull/21","diff_url":"https://github.com/amethyst/laminar/pull/21.diff","patch_url":"https://github.com/amethyst/laminar/pull/21.patch"},"body":"So in discord we spoke about refactoring `SocketState`.\r\n\r\nI have moved all the connection logic from `SocketState` type to its own type. Now we have an `ConnectionPool` which will manage the virtual connections. \r\n\r\nSo why this you may ask. Because we want to separate concerns here. And having connection logic appart from receving logic seems nice to me. And a nice beginning for refactoring `SocketState.`\r\n\r\nI can make the connection pool generic to also support TCP connections but did not know if that was necessarily since TCP connections work differently. "},"comment":{"url":"https://api.github.com/repos/amethyst/laminar/issues/comments/428227321","html_url":"https://github.com/amethyst/laminar/pull/21#issuecomment-428227321","issue_url":"https://api.github.com/repos/amethyst/laminar/issues/21","id":428227321,"node_id":"MDEyOklzc3VlQ29tbWVudDQyODIyNzMyMQ==","user":{"login":"LucioFranco","id":5758045,"node_id":"MDQ6VXNlcjU3NTgwNDU=","avatar_url":"https://avatars0.githubusercontent.com/u/5758045?v=4","gravatar_id":"","url":"https://api.github.com/users/LucioFranco","html_url":"https://github.com/LucioFranco","followers_url":"https://api.github.com/users/LucioFranco/followers","following_url":"https://api.github.com/users/LucioFranco/following{/other_user}","gists_url":"https://api.github.com/users/LucioFranco/gists{/gist_id}","starred_url":"https://api.github.com/users/LucioFranco/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LucioFranco/subscriptions","organizations_url":"https://api.github.com/users/LucioFranco/orgs","repos_url":"https://api.github.com/users/LucioFranco/repos","events_url":"https://api.github.com/users/LucioFranco/events{/privacy}","received_events_url":"https://api.github.com/users/LucioFranco/received_events","type":"User","site_admin":false},"created_at":"2018-10-09T15:00:41Z","updated_at":"2018-10-09T15:00:41Z","author_association":"MEMBER","body":"Good work!\r\nbors r+"}}
{"actor":{"display_login":"LucioFranco"}}