{"action":"created","issue":{"url":"https://api.github.com/repos/rm-hull/luma.oled/issues/232","repository_url":"https://api.github.com/repos/rm-hull/luma.oled","labels_url":"https://api.github.com/repos/rm-hull/luma.oled/issues/232/labels{/name}","comments_url":"https://api.github.com/repos/rm-hull/luma.oled/issues/232/comments","events_url":"https://api.github.com/repos/rm-hull/luma.oled/issues/232/events","html_url":"https://github.com/rm-hull/luma.oled/pull/232","id":390900342,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM4NTYyODIz","number":232,"title":"Fix regression bug caused by device consolidation PR","user":{"login":"rm-hull","id":1915543,"node_id":"MDQ6VXNlcjE5MTU1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1915543?v=4","gravatar_id":"","url":"https://api.github.com/users/rm-hull","html_url":"https://github.com/rm-hull","followers_url":"https://api.github.com/users/rm-hull/followers","following_url":"https://api.github.com/users/rm-hull/following{/other_user}","gists_url":"https://api.github.com/users/rm-hull/gists{/gist_id}","starred_url":"https://api.github.com/users/rm-hull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rm-hull/subscriptions","organizations_url":"https://api.github.com/users/rm-hull/orgs","repos_url":"https://api.github.com/users/rm-hull/repos","events_url":"https://api.github.com/users/rm-hull/events{/privacy}","received_events_url":"https://api.github.com/users/rm-hull/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-13T23:11:38Z","updated_at":"2018-12-14T08:36:43Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/rm-hull/luma.oled/pulls/232","html_url":"https://github.com/rm-hull/luma.oled/pull/232","diff_url":"https://github.com/rm-hull/luma.oled/pull/232.diff","patch_url":"https://github.com/rm-hull/luma.oled/pull/232.patch"},"body":"Fixes: https://github.com/rm-hull/luma.examples/issues/95\r\n\r\nNote: affects SSD1325 and SSD1327 drivers.\r\nWithout the fix, the tests fail exactly the same way as reported in the above issue:\r\n\r\n```\r\n============================================= FAILURES =============================================\r\n____________________________________ test_framebuffer_override _____________________________________\r\n\r\n    def test_framebuffer_override():\r\n        \"\"\"\r\n        Reproduce https://github.com/rm-hull/luma.examples/issues/95\r\n        \"\"\"\r\n>       ssd1325(serial, mode=\"1\", framebuffer=\"diff_to_previous\")\r\n\r\ntests/test_ssd1325.py:100: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\n\r\nself = <luma.oled.device.ssd1325 object at 0x10ec8b890>, serial_interface = <Mock id='4539280912'>\r\nwidth = 128, height = 64, rotate = 0, mode = '1', kwargs = {'framebuffer': 'diff_to_previous'}\r\n\r\n    def __init__(self, serial_interface=None, width=128, height=64, rotate=0, mode=\"RGB\", **kwargs):\r\n        super(ssd1325, self).__init__(luma.core.const.common, serial_interface,\r\n                                      width, height, rotate, mode,\r\n                                      framebuffer=\"full_frame\", nibble_order=1,\r\n>                                     **kwargs)\r\nE       TypeError: __init__() got multiple values for keyword argument 'framebuffer'\r\n\r\nluma/oled/device/__init__.py:469: TypeError\r\n____________________________________ test_framebuffer_override _____________________________________\r\n\r\n    def test_framebuffer_override():\r\n        \"\"\"\r\n        Reproduce https://github.com/rm-hull/luma.examples/issues/95\r\n        \"\"\"\r\n>       ssd1327(serial, mode=\"1\", framebuffer=\"diff_to_previous\")\r\n\r\ntests/test_ssd1327.py:99: \r\n_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ \r\n\r\nself = <luma.oled.device.ssd1327 object at 0x10ec90ed0>, serial_interface = <Mock id='4539280912'>\r\nwidth = 128, height = 128, rotate = 0, mode = '1', kwargs = {'framebuffer': 'diff_to_previous'}\r\n\r\n    def __init__(self, serial_interface=None, width=128, height=128, rotate=0, mode=\"RGB\", **kwargs):\r\n        super(ssd1327, self).__init__(luma.core.const.common, serial_interface,\r\n                                      width, height, rotate, mode,\r\n                                      framebuffer=\"full_frame\", nibble_order=1,\r\n>                                     **kwargs)\r\nE       TypeError: __init__() got multiple values for keyword argument 'framebuffer'\r\n\r\nluma/oled/device/__init__.py:516: TypeError\r\n=============================== 2 failed, 58 passed in 1.31 seconds ================================\r\nERROR: InvocationError: '/Users/rhu/dev/luma.oled/.tox/py27/bin/coverage run -m py.test -v -r wsx'\r\n_____________________________________________ summary ______________________________________________\r\nERROR:   py27: commands failed\r\n```"},"comment":{"url":"https://api.github.com/repos/rm-hull/luma.oled/issues/comments/447254312","html_url":"https://github.com/rm-hull/luma.oled/pull/232#issuecomment-447254312","issue_url":"https://api.github.com/repos/rm-hull/luma.oled/issues/232","id":447254312,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NzI1NDMxMg==","user":{"login":"rm-hull","id":1915543,"node_id":"MDQ6VXNlcjE5MTU1NDM=","avatar_url":"https://avatars3.githubusercontent.com/u/1915543?v=4","gravatar_id":"","url":"https://api.github.com/users/rm-hull","html_url":"https://github.com/rm-hull","followers_url":"https://api.github.com/users/rm-hull/followers","following_url":"https://api.github.com/users/rm-hull/following{/other_user}","gists_url":"https://api.github.com/users/rm-hull/gists{/gist_id}","starred_url":"https://api.github.com/users/rm-hull/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rm-hull/subscriptions","organizations_url":"https://api.github.com/users/rm-hull/orgs","repos_url":"https://api.github.com/users/rm-hull/repos","events_url":"https://api.github.com/users/rm-hull/events{/privacy}","received_events_url":"https://api.github.com/users/rm-hull/received_events","type":"User","site_admin":false},"created_at":"2018-12-14T08:36:43Z","updated_at":"2018-12-14T08:36:43Z","author_association":"OWNER","body":"Added changelog"}}
{"actor":{"display_login":"rm-hull"}}