{"action":"created","issue":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/99","repository_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow","labels_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/99/labels{/name}","comments_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/99/comments","events_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/99/events","html_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/99","id":336949644,"node_id":"MDExOlB1bGxSZXF1ZXN0MTk4Mjc5MjI0","number":99,"title":"Request re-rendering of the items.","user":{"login":"caalador","id":2726090,"node_id":"MDQ6VXNlcjI3MjYwOTA=","avatar_url":"https://avatars2.githubusercontent.com/u/2726090?v=4","gravatar_id":"","url":"https://api.github.com/users/caalador","html_url":"https://github.com/caalador","followers_url":"https://api.github.com/users/caalador/followers","following_url":"https://api.github.com/users/caalador/following{/other_user}","gists_url":"https://api.github.com/users/caalador/gists{/gist_id}","starred_url":"https://api.github.com/users/caalador/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/caalador/subscriptions","organizations_url":"https://api.github.com/users/caalador/orgs","repos_url":"https://api.github.com/users/caalador/repos","events_url":"https://api.github.com/users/caalador/events{/privacy}","received_events_url":"https://api.github.com/users/caalador/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-06-29T10:36:17Z","updated_at":"2018-07-02T07:32:11Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/pulls/99","html_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/99","diff_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/99.diff","patch_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/99.patch"},"body":"Fixes #97\n\n<!-- Reviewable:start -->\n---\nThis change is [<img src=\"https://reviewable.io/review_button.svg\" height=\"34\" align=\"absmiddle\" alt=\"Reviewable\"/>](https://reviewable.io/reviews/vaadin/vaadin-combo-box-flow/99)\n<!-- Reviewable:end -->\n"},"comment":{"url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/comments/401696978","html_url":"https://github.com/vaadin/vaadin-combo-box-flow/pull/99#issuecomment-401696978","issue_url":"https://api.github.com/repos/vaadin/vaadin-combo-box-flow/issues/99","id":401696978,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMTY5Njk3OA==","user":{"login":"ZheSun88","id":31067185,"node_id":"MDQ6VXNlcjMxMDY3MTg1","avatar_url":"https://avatars2.githubusercontent.com/u/31067185?v=4","gravatar_id":"","url":"https://api.github.com/users/ZheSun88","html_url":"https://github.com/ZheSun88","followers_url":"https://api.github.com/users/ZheSun88/followers","following_url":"https://api.github.com/users/ZheSun88/following{/other_user}","gists_url":"https://api.github.com/users/ZheSun88/gists{/gist_id}","starred_url":"https://api.github.com/users/ZheSun88/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ZheSun88/subscriptions","organizations_url":"https://api.github.com/users/ZheSun88/orgs","repos_url":"https://api.github.com/users/ZheSun88/repos","events_url":"https://api.github.com/users/ZheSun88/events{/privacy}","received_events_url":"https://api.github.com/users/ZheSun88/received_events","type":"User","site_admin":false},"created_at":"2018-07-02T07:32:11Z","updated_at":"2018-07-02T07:32:11Z","author_association":"CONTRIBUTOR","body":"\n\n\n\nReview status: all files reviewed, 2 unresolved discussions (waiting on @denis-anisimov)\n\n---\n\n*[src/main/java/com/vaadin/flow/component/combobox/ComboBox.java, line 74 at r2](https://reviewable.io/reviews/vaadin/vaadin-combo-box-flow/99#-LGOO6PM3ffnPTHIK9Yh:-LGOtMAU7acFo7vhvMt-:b-bzhp3t) ([raw file](https://github.com/vaadin/vaadin-combo-box-flow/blob/e1d3236825c8690130b636d819600436c3414f4c/src/main/java/com/vaadin/flow/component/combobox/ComboBox.java#L74)):*\n<details><summary><i>Previously, denis-anisimov (Denis) wrote…</i></summary><blockquote>\n\n> ```\n> transient \n> ```\n\nDo you have any specific reason to remove this ?\nIt looks like this change doesn't relate to the issue......\n\nAs I understand this list is initialized from the data provider so there is no need to keep \nserialize it since its data may be restored from the data provider.\nAnd that's the reason why it was `transient`.\n\n</blockquote></details>\n\nI am not sure what you mean here. It looks this is an adding not removing, and what you have explained here is just the reason why mikael adds this\n\n---\n\n*[src/main/java/com/vaadin/flow/component/combobox/ComboBox.java, line 211 at r2](https://reviewable.io/reviews/vaadin/vaadin-combo-box-flow/99#-LGOP3wWD-M6U2tE1K9e:-LGOtdJY7xKBtPAIBGkO:b9oemnn) ([raw file](https://github.com/vaadin/vaadin-combo-box-flow/blob/e1d3236825c8690130b636d819600436c3414f4c/src/main/java/com/vaadin/flow/component/combobox/ComboBox.java#L211)):*\n<details><summary><i>Previously, denis-anisimov (Denis) wrote…</i></summary><blockquote>\n\n> ```\n>         if (refreshScheduled) {\n>             // We have changed the renderer, but already run the rendering.\n>             // Request re-render for all items.\n>             refreshScheduled = false;\n>             refresh();\n>         }\n> ```\n\n\nI would consider `refreshScheduled` as a variable scoped by the `refresh` method.\nSo that is should not be used outside of this method.\n\nAs a result I would suggest to modify `refresh` method so that it accepts `boolean`  parameter (overload `refresh` actually with one more method).\nAnd it reschedule the runnable if the parameter value forces to do this.\nSo move this logic into `refresh`.\n</blockquote></details>\n\nAs this is a BFP, i will implement the logic based your comments, so we can process it. \n\n---\n\n\n*Comments from [Reviewable](https://reviewable.io/reviews/vaadin/vaadin-combo-box-flow/99)*\n<!-- Sent from Reviewable.io -->\n"}}
{"actor":{"display_login":"ZheSun88"}}