{"action":"created","comment":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/240573643","pull_request_review_id":183630811,"id":240573643,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDI0MDU3MzY0Mw==","diff_hunk":"@@ -0,0 +1,22 @@\n+<?xml version=\"1.0\" encoding=\"UTF-8\"?>\n+<binding:binding id=\"http\" xmlns:xsi=\"http://www.w3.org/2001/XMLSchema-instance\"\n+\txmlns:binding=\"http://eclipse.org/smarthome/schemas/binding/v1.0.0\"\n+\txsi:schemaLocation=\"http://eclipse.org/smarthome/schemas/binding/v1.0.0 http://eclipse.org/smarthome/schemas/binding-1.0.0.xsd\">\n+\n+\t<name>HTTP Binding</name>\n+\t<description>Fetch state and control devices by making HTTP requests.</description>\n+\t<author>Brian Tarricone</author>\n+\n+\t<config-description>\n+\t\t<parameter name=\"connectTimeout\" type=\"integer\">\n+\t\t\t<label>Connect Timeout</label>\n+\t\t\t<description>HTTP connect timeout, in milliseconds.</description>\n+\t\t\t<default>3000</default>\n+\t\t</parameter>\n+\t\t<parameter name=\"requestTimeout\" type=\"integer\">\n+\t\t\t<label>Request Timeout</label>\n+\t\t\t<description>HTTP request timeout, in milliseconds.</description>\n+\t\t\t<default>5000</default>\n+\t\t</parameter>\n+\t</config-description>","path":"addons/binding/org.openhab.binding.http/ESH-INF/binding/binding.xml","position":21,"original_position":21,"commit_id":"721a1921977146e7e6e672c3d6221cc857c8eaba","original_commit_id":"721a1921977146e7e6e672c3d6221cc857c8eaba","user":{"login":"davidgraeff","id":66436,"node_id":"MDQ6VXNlcjY2NDM2","avatar_url":"https://avatars2.githubusercontent.com/u/66436?v=4","gravatar_id":"","url":"https://api.github.com/users/davidgraeff","html_url":"https://github.com/davidgraeff","followers_url":"https://api.github.com/users/davidgraeff/followers","following_url":"https://api.github.com/users/davidgraeff/following{/other_user}","gists_url":"https://api.github.com/users/davidgraeff/gists{/gist_id}","starred_url":"https://api.github.com/users/davidgraeff/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/davidgraeff/subscriptions","organizations_url":"https://api.github.com/users/davidgraeff/orgs","repos_url":"https://api.github.com/users/davidgraeff/repos","events_url":"https://api.github.com/users/davidgraeff/events{/privacy}","received_events_url":"https://api.github.com/users/davidgraeff/received_events","type":"User","site_admin":false},"body":"I think those can be removed now?","created_at":"2018-12-11T11:34:27Z","updated_at":"2018-12-11T11:58:50Z","html_url":"https://github.com/openhab/openhab2-addons/pull/4342#discussion_r240573643","pull_request_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4342","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments/240573643"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/4342#discussion_r240573643"},"pull_request":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4342"}}},"pull_request":{"url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4342","id":237101543,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3MTAxNTQz","html_url":"https://github.com/openhab/openhab2-addons/pull/4342","diff_url":"https://github.com/openhab/openhab2-addons/pull/4342.diff","patch_url":"https://github.com/openhab/openhab2-addons/pull/4342.patch","issue_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4342","number":4342,"state":"open","locked":false,"title":"Initial contribution: add new HTTP binding","user":{"login":"kelnos","id":544991,"node_id":"MDQ6VXNlcjU0NDk5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/544991?v=4","gravatar_id":"","url":"https://api.github.com/users/kelnos","html_url":"https://github.com/kelnos","followers_url":"https://api.github.com/users/kelnos/followers","following_url":"https://api.github.com/users/kelnos/following{/other_user}","gists_url":"https://api.github.com/users/kelnos/gists{/gist_id}","starred_url":"https://api.github.com/users/kelnos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelnos/subscriptions","organizations_url":"https://api.github.com/users/kelnos/orgs","repos_url":"https://api.github.com/users/kelnos/repos","events_url":"https://api.github.com/users/kelnos/events{/privacy}","received_events_url":"https://api.github.com/users/kelnos/received_events","type":"User","site_admin":false},"body":"This is inspired by the old OpenHAB1 HTTP binding, but allows the user to create Things that make HTTP requests to fetch and update state, and allows for a linked item (of any ItemType) to display/control that state.\r\n\r\nI was bummed that using the old http1 binding didn't allow me to easily create things/items through PaperUI, and decided it could use an update.  Initially I was planning on basing this on the old binding, but I decided to just write it from scratch since 1 vs. 2 concepts seem a bit different, and I decided to take a slightly different approach in configuring Things created by the binding.\r\n\r\nOne thing I haven't tested is the transformation function support for HTTP request/response bodies, but I wanted to get the ball rolling with this PR, as it's my first contribution here and I want to make sure I'm doing the right things.\r\n\r\nPrebuilt binding: https://files.spurint.org/org.openhab.binding.http-2.4.0-SNAPSHOT.jar","created_at":"2018-12-09T01:18:26Z","updated_at":"2018-12-11T11:58:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"a33b8f16000f507ced1835608ec8fa9f603dfb08","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":159935827,"node_id":"MDU6TGFiZWwxNTk5MzU4Mjc=","url":"https://api.github.com/repos/openhab/openhab2-addons/labels/newbinding","name":"newbinding","color":"5319e7","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4342/commits","review_comments_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4342/comments","review_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/4342/comments","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/721a1921977146e7e6e672c3d6221cc857c8eaba","head":{"label":"kelnos:http-binding","ref":"http-binding","sha":"721a1921977146e7e6e672c3d6221cc857c8eaba","user":{"login":"kelnos","id":544991,"node_id":"MDQ6VXNlcjU0NDk5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/544991?v=4","gravatar_id":"","url":"https://api.github.com/users/kelnos","html_url":"https://github.com/kelnos","followers_url":"https://api.github.com/users/kelnos/followers","following_url":"https://api.github.com/users/kelnos/following{/other_user}","gists_url":"https://api.github.com/users/kelnos/gists{/gist_id}","starred_url":"https://api.github.com/users/kelnos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelnos/subscriptions","organizations_url":"https://api.github.com/users/kelnos/orgs","repos_url":"https://api.github.com/users/kelnos/repos","events_url":"https://api.github.com/users/kelnos/events{/privacy}","received_events_url":"https://api.github.com/users/kelnos/received_events","type":"User","site_admin":false},"repo":{"id":158518862,"node_id":"MDEwOlJlcG9zaXRvcnkxNTg1MTg4NjI=","name":"openhab2-addons","full_name":"kelnos/openhab2-addons","private":false,"owner":{"login":"kelnos","id":544991,"node_id":"MDQ6VXNlcjU0NDk5MQ==","avatar_url":"https://avatars2.githubusercontent.com/u/544991?v=4","gravatar_id":"","url":"https://api.github.com/users/kelnos","html_url":"https://github.com/kelnos","followers_url":"https://api.github.com/users/kelnos/followers","following_url":"https://api.github.com/users/kelnos/following{/other_user}","gists_url":"https://api.github.com/users/kelnos/gists{/gist_id}","starred_url":"https://api.github.com/users/kelnos/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kelnos/subscriptions","organizations_url":"https://api.github.com/users/kelnos/orgs","repos_url":"https://api.github.com/users/kelnos/repos","events_url":"https://api.github.com/users/kelnos/events{/privacy}","received_events_url":"https://api.github.com/users/kelnos/received_events","type":"User","site_admin":false},"html_url":"https://github.com/kelnos/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":true,"url":"https://api.github.com/repos/kelnos/openhab2-addons","forks_url":"https://api.github.com/repos/kelnos/openhab2-addons/forks","keys_url":"https://api.github.com/repos/kelnos/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/kelnos/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/kelnos/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/kelnos/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/kelnos/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/kelnos/openhab2-addons/events","assignees_url":"https://api.github.com/repos/kelnos/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/kelnos/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/kelnos/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/kelnos/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/kelnos/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/kelnos/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/kelnos/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/kelnos/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/kelnos/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/kelnos/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/kelnos/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/kelnos/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/kelnos/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/kelnos/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/kelnos/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/kelnos/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/kelnos/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/kelnos/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/kelnos/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/kelnos/openhab2-addons/merges","archive_url":"https://api.github.com/repos/kelnos/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/kelnos/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/kelnos/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/kelnos/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/kelnos/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/kelnos/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/kelnos/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/kelnos/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/kelnos/openhab2-addons/deployments","created_at":"2018-11-21T08:54:42Z","updated_at":"2018-11-21T08:54:57Z","pushed_at":"2018-12-11T08:29:57Z","git_url":"git://github.com/kelnos/openhab2-addons.git","ssh_url":"git@github.com:kelnos/openhab2-addons.git","clone_url":"https://github.com/kelnos/openhab2-addons.git","svn_url":"https://github.com/kelnos/openhab2-addons","homepage":"","size":307689,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"openhab:master","ref":"master","sha":"6be69dbb2c06900c8f50d2ae42996198b3702333","user":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"repo":{"id":19753195,"node_id":"MDEwOlJlcG9zaXRvcnkxOTc1MzE5NQ==","name":"openhab2-addons","full_name":"openhab/openhab2-addons","private":false,"owner":{"login":"openhab","id":1007353,"node_id":"MDEyOk9yZ2FuaXphdGlvbjEwMDczNTM=","avatar_url":"https://avatars0.githubusercontent.com/u/1007353?v=4","gravatar_id":"","url":"https://api.github.com/users/openhab","html_url":"https://github.com/openhab","followers_url":"https://api.github.com/users/openhab/followers","following_url":"https://api.github.com/users/openhab/following{/other_user}","gists_url":"https://api.github.com/users/openhab/gists{/gist_id}","starred_url":"https://api.github.com/users/openhab/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/openhab/subscriptions","organizations_url":"https://api.github.com/users/openhab/orgs","repos_url":"https://api.github.com/users/openhab/repos","events_url":"https://api.github.com/users/openhab/events{/privacy}","received_events_url":"https://api.github.com/users/openhab/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/openhab/openhab2-addons","description":"Add-ons for openHAB 2.x","fork":false,"url":"https://api.github.com/repos/openhab/openhab2-addons","forks_url":"https://api.github.com/repos/openhab/openhab2-addons/forks","keys_url":"https://api.github.com/repos/openhab/openhab2-addons/keys{/key_id}","collaborators_url":"https://api.github.com/repos/openhab/openhab2-addons/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/openhab/openhab2-addons/teams","hooks_url":"https://api.github.com/repos/openhab/openhab2-addons/hooks","issue_events_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/events{/number}","events_url":"https://api.github.com/repos/openhab/openhab2-addons/events","assignees_url":"https://api.github.com/repos/openhab/openhab2-addons/assignees{/user}","branches_url":"https://api.github.com/repos/openhab/openhab2-addons/branches{/branch}","tags_url":"https://api.github.com/repos/openhab/openhab2-addons/tags","blobs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/openhab/openhab2-addons/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/openhab/openhab2-addons/git/refs{/sha}","trees_url":"https://api.github.com/repos/openhab/openhab2-addons/git/trees{/sha}","statuses_url":"https://api.github.com/repos/openhab/openhab2-addons/statuses/{sha}","languages_url":"https://api.github.com/repos/openhab/openhab2-addons/languages","stargazers_url":"https://api.github.com/repos/openhab/openhab2-addons/stargazers","contributors_url":"https://api.github.com/repos/openhab/openhab2-addons/contributors","subscribers_url":"https://api.github.com/repos/openhab/openhab2-addons/subscribers","subscription_url":"https://api.github.com/repos/openhab/openhab2-addons/subscription","commits_url":"https://api.github.com/repos/openhab/openhab2-addons/commits{/sha}","git_commits_url":"https://api.github.com/repos/openhab/openhab2-addons/git/commits{/sha}","comments_url":"https://api.github.com/repos/openhab/openhab2-addons/comments{/number}","issue_comment_url":"https://api.github.com/repos/openhab/openhab2-addons/issues/comments{/number}","contents_url":"https://api.github.com/repos/openhab/openhab2-addons/contents/{+path}","compare_url":"https://api.github.com/repos/openhab/openhab2-addons/compare/{base}...{head}","merges_url":"https://api.github.com/repos/openhab/openhab2-addons/merges","archive_url":"https://api.github.com/repos/openhab/openhab2-addons/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/openhab/openhab2-addons/downloads","issues_url":"https://api.github.com/repos/openhab/openhab2-addons/issues{/number}","pulls_url":"https://api.github.com/repos/openhab/openhab2-addons/pulls{/number}","milestones_url":"https://api.github.com/repos/openhab/openhab2-addons/milestones{/number}","notifications_url":"https://api.github.com/repos/openhab/openhab2-addons/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/openhab/openhab2-addons/labels{/name}","releases_url":"https://api.github.com/repos/openhab/openhab2-addons/releases{/id}","deployments_url":"https://api.github.com/repos/openhab/openhab2-addons/deployments","created_at":"2014-05-13T19:41:58Z","updated_at":"2018-12-10T20:41:14Z","pushed_at":"2018-12-11T09:34:14Z","git_url":"git://github.com/openhab/openhab2-addons.git","ssh_url":"git@github.com:openhab/openhab2-addons.git","clone_url":"https://github.com/openhab/openhab2-addons.git","svn_url":"https://github.com/openhab/openhab2-addons","homepage":"","size":308137,"stargazers_count":926,"watchers_count":926,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":false,"has_pages":false,"forks_count":1711,"mirror_url":null,"archived":false,"open_issues_count":448,"license":{"key":"epl-1.0","name":"Eclipse Public License 1.0","spdx_id":"EPL-1.0","url":"https://api.github.com/licenses/epl-1.0","node_id":"MDc6TGljZW5zZTc="},"forks":1711,"open_issues":448,"watchers":926,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4342"},"html":{"href":"https://github.com/openhab/openhab2-addons/pull/4342"},"issue":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/4342"},"comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/issues/4342/comments"},"review_comments":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4342/comments"},"review_comment":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/openhab/openhab2-addons/pulls/4342/commits"},"statuses":{"href":"https://api.github.com/repos/openhab/openhab2-addons/statuses/721a1921977146e7e6e672c3d6221cc857c8eaba"}},"author_association":"NONE"}}
{"actor":{"display_login":"davidgraeff"}}