{"action":"created","issue":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/438","repository_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle","labels_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/438/labels{/name}","comments_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/438/comments","events_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/438/events","html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/438","id":308843290,"number":438,"title":"adjust to session listener changes in symfony 4.1","user":{"login":"dbu","id":76576,"avatar_url":"https://avatars3.githubusercontent.com/u/76576?v=4","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":9,"created_at":"2018-03-27T06:55:04Z","updated_at":"2018-03-27T15:16:17Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/pulls/438","html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/438","diff_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/438.diff","patch_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/438.patch"},"body":"The SessionListener in Symfony 4.1 is changed and does the `$session->save()` itself.\r\n\r\nFix #437"},"comment":{"url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/comments/376563638","html_url":"https://github.com/FriendsOfSymfony/FOSHttpCacheBundle/pull/438#issuecomment-376563638","issue_url":"https://api.github.com/repos/FriendsOfSymfony/FOSHttpCacheBundle/issues/438","id":376563638,"user":{"login":"dbu","id":76576,"avatar_url":"https://avatars3.githubusercontent.com/u/76576?v=4","gravatar_id":"","url":"https://api.github.com/users/dbu","html_url":"https://github.com/dbu","followers_url":"https://api.github.com/users/dbu/followers","following_url":"https://api.github.com/users/dbu/following{/other_user}","gists_url":"https://api.github.com/users/dbu/gists{/gist_id}","starred_url":"https://api.github.com/users/dbu/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dbu/subscriptions","organizations_url":"https://api.github.com/users/dbu/orgs","repos_url":"https://api.github.com/users/dbu/repos","events_url":"https://api.github.com/users/dbu/events{/privacy}","received_events_url":"https://api.github.com/users/dbu/received_events","type":"User","site_admin":false},"created_at":"2018-03-27T15:16:17Z","updated_at":"2018-03-27T15:16:17Z","author_association":"CONTRIBUTOR","body":"The solution we merged and tagged a few days ago works for symfony 3.4 and 4.0, but will break session saving with symfony 4.1 because the SaveSessionListener is no longer a separate step. We did not call the inner listener because it used to only overwrite the cache headers to private - now we need a different solution and `Session::hasBeenStarted` does not make it easier...\r\n\r\nBut lets discuss on https://github.com/symfony/symfony/pull/26681 first and then see what remains to be done here."}}
{"actor":{"display_login":"dbu"}}