{"action":"created","issue":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1703","repository_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift","labels_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1703/labels{/name}","comments_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1703/comments","events_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1703/events","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1703","id":306681338,"number":1703,"title":"JBIDE-25822 - be able to run minishift setup-cdk for a cdk server ","user":{"login":"robstryker","id":630383,"avatar_url":"https://avatars1.githubusercontent.com/u/630383?v=4","gravatar_id":"","url":"https://api.github.com/users/robstryker","html_url":"https://github.com/robstryker","followers_url":"https://api.github.com/users/robstryker/followers","following_url":"https://api.github.com/users/robstryker/following{/other_user}","gists_url":"https://api.github.com/users/robstryker/gists{/gist_id}","starred_url":"https://api.github.com/users/robstryker/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/robstryker/subscriptions","organizations_url":"https://api.github.com/users/robstryker/orgs","repos_url":"https://api.github.com/users/robstryker/repos","events_url":"https://api.github.com/users/robstryker/events{/privacy}","received_events_url":"https://api.github.com/users/robstryker/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-03-20T00:02:33Z","updated_at":"2018-03-20T16:03:47Z","closed_at":null,"author_association":"MEMBER","pull_request":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/pulls/1703","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1703","diff_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1703.diff","patch_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1703.patch"},"body":"THIS PR REQUIRES JBIDE-25753\r\nDO NOT COMMIT THIS UNTIL JBIDE-25753 IS PUSHED TO MASTER\r\n\r\n\r\n# Pull Request Checklist\r\n## General\r\n* Is this a blocking issue or new feature? If yes, QE needs to +1 this PR\r\n\r\n## Code\r\n* Are method-/class-/variable-names meaningful?\r\n* Are methods concise, not too long?\r\n* Are catch blocks catching precise Exceptions only (no catch all)?\r\n\r\n## Testing\r\n* Are there unit-tests?\r\n* Are there integration tests (or at least a jira to tackle these)?\r\n* Is the non-happy path working, too?\r\n* Are other parts that use the same component still working fine?\r\n\r\n## Function\r\n* Does it work?\r\n"},"comment":{"url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/comments/374654359","html_url":"https://github.com/jbosstools/jbosstools-openshift/pull/1703#issuecomment-374654359","issue_url":"https://api.github.com/repos/jbosstools/jbosstools-openshift/issues/1703","id":374654359,"user":{"login":"rhdevelopers-ci","id":18214726,"avatar_url":"https://avatars3.githubusercontent.com/u/18214726?v=4","gravatar_id":"","url":"https://api.github.com/users/rhdevelopers-ci","html_url":"https://github.com/rhdevelopers-ci","followers_url":"https://api.github.com/users/rhdevelopers-ci/followers","following_url":"https://api.github.com/users/rhdevelopers-ci/following{/other_user}","gists_url":"https://api.github.com/users/rhdevelopers-ci/gists{/gist_id}","starred_url":"https://api.github.com/users/rhdevelopers-ci/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rhdevelopers-ci/subscriptions","organizations_url":"https://api.github.com/users/rhdevelopers-ci/orgs","repos_url":"https://api.github.com/users/rhdevelopers-ci/repos","events_url":"https://api.github.com/users/rhdevelopers-ci/events{/privacy}","received_events_url":"https://api.github.com/users/rhdevelopers-ci/received_events","type":"User","site_admin":false},"created_at":"2018-03-20T16:03:47Z","updated_at":"2018-03-20T16:03:47Z","author_association":"NONE","body":"SonarQube analysis reported 14 issues\n* ![MAJOR][MAJOR] 5 major\n* ![MINOR][MINOR] 9 minor\n\nWatch the comments in this conversation to review them.\n\n#### 1 extra issue\n\nNote: The following issues were found on lines that were not modified in the pull request. Because these issues can't be reported as line comments, they are summarized here:\n\n1. ![MINOR][MINOR] [UnifiedMinishiftRuntimeDetector.java#L75](https://github.com/jbosstools/jbosstools-openshift/blob/14f06d361964cfcea16720b65cb63cf7f520a12d/plugins/org.jboss.tools.openshift.cdk.server/src/org/jboss/tools/openshift/cdk/server/core/internal/detection/UnifiedMinishiftRuntimeDetector.java#L75): Do something with the \"boolean\" value returned by \"setExecutable\". [![rule](https://sonarsource.github.io/sonar-github/rule.png)](https://sonarcloud.io/coding_rules#rule_key=squid%3AS899)\n\n[MAJOR]: https://sonarsource.github.io/sonar-github/severity-major.png 'Severity: MAJOR'\n[MINOR]: https://sonarsource.github.io/sonar-github/severity-minor.png 'Severity: MINOR'"}}
{"actor":{"display_login":"rhdevelopers-ci"}}