{"action":"created","issue":{"url":"https://api.github.com/repos/dmlc/xgboost/issues/3335","repository_url":"https://api.github.com/repos/dmlc/xgboost","labels_url":"https://api.github.com/repos/dmlc/xgboost/issues/3335/labels{/name}","comments_url":"https://api.github.com/repos/dmlc/xgboost/issues/3335/comments","events_url":"https://api.github.com/repos/dmlc/xgboost/issues/3335/events","html_url":"https://github.com/dmlc/xgboost/pull/3335","id":325609766,"node_id":"MDExOlB1bGxSZXF1ZXN0MTg5OTAwNTQ4","number":3335,"title":"Refactor of FastHistMaker to allow for custom regularisation methods","user":{"login":"henrygouk","id":1439883,"node_id":"MDQ6VXNlcjE0Mzk4ODM=","avatar_url":"https://avatars1.githubusercontent.com/u/1439883?v=4","gravatar_id":"","url":"https://api.github.com/users/henrygouk","html_url":"https://github.com/henrygouk","followers_url":"https://api.github.com/users/henrygouk/followers","following_url":"https://api.github.com/users/henrygouk/following{/other_user}","gists_url":"https://api.github.com/users/henrygouk/gists{/gist_id}","starred_url":"https://api.github.com/users/henrygouk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/henrygouk/subscriptions","organizations_url":"https://api.github.com/users/henrygouk/orgs","repos_url":"https://api.github.com/users/henrygouk/repos","events_url":"https://api.github.com/users/henrygouk/events{/privacy}","received_events_url":"https://api.github.com/users/henrygouk/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":17,"created_at":"2018-05-23T08:54:05Z","updated_at":"2018-06-28T02:13:41Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/dmlc/xgboost/pulls/3335","html_url":"https://github.com/dmlc/xgboost/pull/3335","diff_url":"https://github.com/dmlc/xgboost/pull/3335.diff","patch_url":"https://github.com/dmlc/xgboost/pull/3335.patch"},"body":"Currently only FastHistMaker has been modified to use this new regularisation framework. I figured I should get some feedback before I put in the effort of refactoring the other updaters.\r\n\r\nFuture PRs will focus on novel regularisation methods.\r\n\r\n**Things that need to be checked:**\r\n- [x] L2 weight penalty is applied correctly\r\n- [x] Monotonic constraints are applied correctly\r\n- [x] Speed is not impacted noticeably"},"comment":{"url":"https://api.github.com/repos/dmlc/xgboost/issues/comments/400888700","html_url":"https://github.com/dmlc/xgboost/pull/3335#issuecomment-400888700","issue_url":"https://api.github.com/repos/dmlc/xgboost/issues/3335","id":400888700,"node_id":"MDEyOklzc3VlQ29tbWVudDQwMDg4ODcwMA==","user":{"login":"hcho3","id":2532981,"node_id":"MDQ6VXNlcjI1MzI5ODE=","avatar_url":"https://avatars0.githubusercontent.com/u/2532981?v=4","gravatar_id":"","url":"https://api.github.com/users/hcho3","html_url":"https://github.com/hcho3","followers_url":"https://api.github.com/users/hcho3/followers","following_url":"https://api.github.com/users/hcho3/following{/other_user}","gists_url":"https://api.github.com/users/hcho3/gists{/gist_id}","starred_url":"https://api.github.com/users/hcho3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/hcho3/subscriptions","organizations_url":"https://api.github.com/users/hcho3/orgs","repos_url":"https://api.github.com/users/hcho3/repos","events_url":"https://api.github.com/users/hcho3/events{/privacy}","received_events_url":"https://api.github.com/users/hcho3/received_events","type":"User","site_admin":false},"created_at":"2018-06-28T02:13:41Z","updated_at":"2018-06-28T02:13:41Z","author_association":"CONTRIBUTOR","body":"@henrygouk I rebased the whole branch against the latest master, so that the GPU tests would pass. Once all tests pass, I will merge the PR. Thanks for your contribution."}}
{"actor":{"display_login":"hcho3"}}