{"action":"created","issue":{"url":"https://api.github.com/repos/rails/rails/issues/32145","repository_url":"https://api.github.com/repos/rails/rails","labels_url":"https://api.github.com/repos/rails/rails/issues/32145/labels{/name}","comments_url":"https://api.github.com/repos/rails/rails/issues/32145/comments","events_url":"https://api.github.com/repos/rails/rails/issues/32145/events","html_url":"https://github.com/rails/rails/pull/32145","id":301250139,"number":32145,"title":"Use Base.configurations in QueryCache.cache","user":{"login":"eugeneius","id":432189,"avatar_url":"https://avatars1.githubusercontent.com/u/432189?v=4","gravatar_id":"","url":"https://api.github.com/users/eugeneius","html_url":"https://github.com/eugeneius","followers_url":"https://api.github.com/users/eugeneius/followers","following_url":"https://api.github.com/users/eugeneius/following{/other_user}","gists_url":"https://api.github.com/users/eugeneius/gists{/gist_id}","starred_url":"https://api.github.com/users/eugeneius/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eugeneius/subscriptions","organizations_url":"https://api.github.com/users/eugeneius/orgs","repos_url":"https://api.github.com/users/eugeneius/repos","events_url":"https://api.github.com/users/eugeneius/events{/privacy}","received_events_url":"https://api.github.com/users/eugeneius/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":{"login":"eileencodes","id":1080678,"avatar_url":"https://avatars0.githubusercontent.com/u/1080678?v=4","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":true},"assignees":[{"login":"eileencodes","id":1080678,"avatar_url":"https://avatars0.githubusercontent.com/u/1080678?v=4","gravatar_id":"","url":"https://api.github.com/users/eileencodes","html_url":"https://github.com/eileencodes","followers_url":"https://api.github.com/users/eileencodes/followers","following_url":"https://api.github.com/users/eileencodes/following{/other_user}","gists_url":"https://api.github.com/users/eileencodes/gists{/gist_id}","starred_url":"https://api.github.com/users/eileencodes/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/eileencodes/subscriptions","organizations_url":"https://api.github.com/users/eileencodes/orgs","repos_url":"https://api.github.com/users/eileencodes/repos","events_url":"https://api.github.com/users/eileencodes/events{/privacy}","received_events_url":"https://api.github.com/users/eileencodes/received_events","type":"User","site_admin":true}],"milestone":null,"comments":3,"created_at":"2018-03-01T01:52:10Z","updated_at":"2018-03-04T22:29:58Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/rails/rails/pulls/32145","html_url":"https://github.com/rails/rails/pull/32145","diff_url":"https://github.com/rails/rails/pull/32145.diff","patch_url":"https://github.com/rails/rails/pull/32145.patch"},"body":"Followup to https://github.com/rails/rails/pull/29609.\r\n\r\nOverriding the `.configurations` method doesn't affect how connections are established; it shouldn't change the query cache behaviour either.\r\n\r\nThis is going in the opposite direction to https://github.com/rails/rails/pull/32135 - but even if we want to allow models to override the base configuration we shouldn't make that change in a stable branch, and https://github.com/rails/rails/pull/29609 was backported to 5-1-stable and 5-0-stable."},"comment":{"url":"https://api.github.com/repos/rails/rails/issues/comments/370270380","html_url":"https://github.com/rails/rails/pull/32145#issuecomment-370270380","issue_url":"https://api.github.com/repos/rails/rails/issues/32145","id":370270380,"user":{"login":"ioquatix","id":30030,"avatar_url":"https://avatars1.githubusercontent.com/u/30030?v=4","gravatar_id":"","url":"https://api.github.com/users/ioquatix","html_url":"https://github.com/ioquatix","followers_url":"https://api.github.com/users/ioquatix/followers","following_url":"https://api.github.com/users/ioquatix/following{/other_user}","gists_url":"https://api.github.com/users/ioquatix/gists{/gist_id}","starred_url":"https://api.github.com/users/ioquatix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioquatix/subscriptions","organizations_url":"https://api.github.com/users/ioquatix/orgs","repos_url":"https://api.github.com/users/ioquatix/repos","events_url":"https://api.github.com/users/ioquatix/events{/privacy}","received_events_url":"https://api.github.com/users/ioquatix/received_events","type":"User","site_admin":false},"created_at":"2018-03-04T22:29:58Z","updated_at":"2018-03-04T22:29:58Z","author_association":"CONTRIBUTOR","body":"Ah yeah, that makes sense.\r\n\r\nSo, what are your thoughts on:\r\n\r\n1. Backporting this for consistency\r\n2. Applying https://github.com/rails/rails/pull/32135 and also reverting this for the next release of AR?"}}
{"actor":{"display_login":"ioquatix"}}