{"action":"created","comment":{"url":"https://api.github.com/repos/xrootd/xrootd/pulls/comments/167732321","pull_request_review_id":95994657,"id":167732321,"diff_hunk":"@@ -69,13 +69,29 @@ const    char   *tident;                  // Trace identifier always preset\n                                           // it in your XrdSfsFileSystem::Disc()\n                                           // implementation, as needed.\n          XrdSecEntity(const char *pName = \"\")\n-                     : name(0), host(0), vorg(0), role(0), grps(0),\n-                       endorsements(0), moninfo(0), creds(0), credslen(0),\n-                       rsvd(0), addrInfo(0), tident(\"\"), sessvar(0)\n-                     {strncpy(prot, pName, XrdSecPROTOIDSIZE-1);\n+                     {Reset();\n+\t              strncpy(prot, pName, XrdSecPROTOIDSIZE-1);\n                       prot[XrdSecPROTOIDSIZE-1] = '\\0';","path":"src/XrdSec/XrdSecEntity.hh","position":10,"original_position":10,"commit_id":"60da79db805d122a7190535b8dead0f306e5a2f9","original_commit_id":"60da79db805d122a7190535b8dead0f306e5a2f9","user":{"login":"abh3","id":2657143,"avatar_url":"https://avatars1.githubusercontent.com/u/2657143?v=4","gravatar_id":"","url":"https://api.github.com/users/abh3","html_url":"https://github.com/abh3","followers_url":"https://api.github.com/users/abh3/followers","following_url":"https://api.github.com/users/abh3/following{/other_user}","gists_url":"https://api.github.com/users/abh3/gists{/gist_id}","starred_url":"https://api.github.com/users/abh3/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/abh3/subscriptions","organizations_url":"https://api.github.com/users/abh3/orgs","repos_url":"https://api.github.com/users/abh3/repos","events_url":"https://api.github.com/users/abh3/events{/privacy}","received_events_url":"https://api.github.com/users/abh3/received_events","type":"User","site_admin":false},"body":"Well, that's only true if the Reset() is actually inlined, isn't it?But I guess we are not providing regressed compatibility (i.e. new code running with old libraries).","created_at":"2018-02-13T00:46:19Z","updated_at":"2018-02-13T00:46:19Z","html_url":"https://github.com/xrootd/xrootd/pull/657#discussion_r167732321","pull_request_url":"https://api.github.com/repos/xrootd/xrootd/pulls/657","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/xrootd/xrootd/pulls/comments/167732321"},"html":{"href":"https://github.com/xrootd/xrootd/pull/657#discussion_r167732321"},"pull_request":{"href":"https://api.github.com/repos/xrootd/xrootd/pulls/657"}},"in_reply_to_id":167373535},"pull_request":{"url":"https://api.github.com/repos/xrootd/xrootd/pulls/657","id":168270151,"html_url":"https://github.com/xrootd/xrootd/pull/657","diff_url":"https://github.com/xrootd/xrootd/pull/657.diff","patch_url":"https://github.com/xrootd/xrootd/pull/657.patch","issue_url":"https://api.github.com/repos/xrootd/xrootd/issues/657","number":657,"state":"open","locked":false,"title":"Fix fedora rawhide build, part2.","user":{"login":"simonmichal","id":4455148,"avatar_url":"https://avatars3.githubusercontent.com/u/4455148?v=4","gravatar_id":"","url":"https://api.github.com/users/simonmichal","html_url":"https://github.com/simonmichal","followers_url":"https://api.github.com/users/simonmichal/followers","following_url":"https://api.github.com/users/simonmichal/following{/other_user}","gists_url":"https://api.github.com/users/simonmichal/gists{/gist_id}","starred_url":"https://api.github.com/users/simonmichal/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/simonmichal/subscriptions","organizations_url":"https://api.github.com/users/simonmichal/orgs","repos_url":"https://api.github.com/users/simonmichal/repos","events_url":"https://api.github.com/users/simonmichal/events{/privacy}","received_events_url":"https://api.github.com/users/simonmichal/received_events","type":"User","site_admin":false},"body":"A couple of fixes for Fedora rawhide, GCC 8","created_at":"2018-02-09T15:36:12Z","updated_at":"2018-02-13T00:46:19Z","closed_at":null,"merged_at":null,"merge_commit_sha":"05a56fc070fcf7732540ac56faff2cb5b5a331e5","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/xrootd/xrootd/pulls/657/commits","review_comments_url":"https://api.github.com/repos/xrootd/xrootd/pulls/657/comments","review_comment_url":"https://api.github.com/repos/xrootd/xrootd/pulls/comments{/number}","comments_url":"https://api.github.com/repos/xrootd/xrootd/issues/657/comments","statuses_url":"https://api.github.com/repos/xrootd/xrootd/statuses/60da79db805d122a7190535b8dead0f306e5a2f9","head":{"label":"xrootd:fedora-rawhide-fix","ref":"fedora-rawhide-fix","sha":"60da79db805d122a7190535b8dead0f306e5a2f9","user":{"login":"xrootd","id":2656051,"avatar_url":"https://avatars2.githubusercontent.com/u/2656051?v=4","gravatar_id":"","url":"https://api.github.com/users/xrootd","html_url":"https://github.com/xrootd","followers_url":"https://api.github.com/users/xrootd/followers","following_url":"https://api.github.com/users/xrootd/following{/other_user}","gists_url":"https://api.github.com/users/xrootd/gists{/gist_id}","starred_url":"https://api.github.com/users/xrootd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrootd/subscriptions","organizations_url":"https://api.github.com/users/xrootd/orgs","repos_url":"https://api.github.com/users/xrootd/repos","events_url":"https://api.github.com/users/xrootd/events{/privacy}","received_events_url":"https://api.github.com/users/xrootd/received_events","type":"Organization","site_admin":false},"repo":{"id":8924314,"name":"xrootd","full_name":"xrootd/xrootd","owner":{"login":"xrootd","id":2656051,"avatar_url":"https://avatars2.githubusercontent.com/u/2656051?v=4","gravatar_id":"","url":"https://api.github.com/users/xrootd","html_url":"https://github.com/xrootd","followers_url":"https://api.github.com/users/xrootd/followers","following_url":"https://api.github.com/users/xrootd/following{/other_user}","gists_url":"https://api.github.com/users/xrootd/gists{/gist_id}","starred_url":"https://api.github.com/users/xrootd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrootd/subscriptions","organizations_url":"https://api.github.com/users/xrootd/orgs","repos_url":"https://api.github.com/users/xrootd/repos","events_url":"https://api.github.com/users/xrootd/events{/privacy}","received_events_url":"https://api.github.com/users/xrootd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xrootd/xrootd","description":"The XRootD central repository","fork":false,"url":"https://api.github.com/repos/xrootd/xrootd","forks_url":"https://api.github.com/repos/xrootd/xrootd/forks","keys_url":"https://api.github.com/repos/xrootd/xrootd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xrootd/xrootd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xrootd/xrootd/teams","hooks_url":"https://api.github.com/repos/xrootd/xrootd/hooks","issue_events_url":"https://api.github.com/repos/xrootd/xrootd/issues/events{/number}","events_url":"https://api.github.com/repos/xrootd/xrootd/events","assignees_url":"https://api.github.com/repos/xrootd/xrootd/assignees{/user}","branches_url":"https://api.github.com/repos/xrootd/xrootd/branches{/branch}","tags_url":"https://api.github.com/repos/xrootd/xrootd/tags","blobs_url":"https://api.github.com/repos/xrootd/xrootd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xrootd/xrootd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xrootd/xrootd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xrootd/xrootd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xrootd/xrootd/statuses/{sha}","languages_url":"https://api.github.com/repos/xrootd/xrootd/languages","stargazers_url":"https://api.github.com/repos/xrootd/xrootd/stargazers","contributors_url":"https://api.github.com/repos/xrootd/xrootd/contributors","subscribers_url":"https://api.github.com/repos/xrootd/xrootd/subscribers","subscription_url":"https://api.github.com/repos/xrootd/xrootd/subscription","commits_url":"https://api.github.com/repos/xrootd/xrootd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xrootd/xrootd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xrootd/xrootd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xrootd/xrootd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xrootd/xrootd/contents/{+path}","compare_url":"https://api.github.com/repos/xrootd/xrootd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xrootd/xrootd/merges","archive_url":"https://api.github.com/repos/xrootd/xrootd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xrootd/xrootd/downloads","issues_url":"https://api.github.com/repos/xrootd/xrootd/issues{/number}","pulls_url":"https://api.github.com/repos/xrootd/xrootd/pulls{/number}","milestones_url":"https://api.github.com/repos/xrootd/xrootd/milestones{/number}","notifications_url":"https://api.github.com/repos/xrootd/xrootd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xrootd/xrootd/labels{/name}","releases_url":"https://api.github.com/repos/xrootd/xrootd/releases{/id}","deployments_url":"https://api.github.com/repos/xrootd/xrootd/deployments","created_at":"2013-03-21T08:25:19Z","updated_at":"2018-02-09T10:47:59Z","pushed_at":"2018-02-13T00:14:27Z","git_url":"git://github.com/xrootd/xrootd.git","ssh_url":"git@github.com:xrootd/xrootd.git","clone_url":"https://github.com/xrootd/xrootd.git","svn_url":"https://github.com/xrootd/xrootd","homepage":null,"size":30613,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":55,"open_issues":31,"watchers":43,"default_branch":"master"}},"base":{"label":"xrootd:master","ref":"master","sha":"3093ea89370b1c18cc45d35ea202f22a1b7da70e","user":{"login":"xrootd","id":2656051,"avatar_url":"https://avatars2.githubusercontent.com/u/2656051?v=4","gravatar_id":"","url":"https://api.github.com/users/xrootd","html_url":"https://github.com/xrootd","followers_url":"https://api.github.com/users/xrootd/followers","following_url":"https://api.github.com/users/xrootd/following{/other_user}","gists_url":"https://api.github.com/users/xrootd/gists{/gist_id}","starred_url":"https://api.github.com/users/xrootd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrootd/subscriptions","organizations_url":"https://api.github.com/users/xrootd/orgs","repos_url":"https://api.github.com/users/xrootd/repos","events_url":"https://api.github.com/users/xrootd/events{/privacy}","received_events_url":"https://api.github.com/users/xrootd/received_events","type":"Organization","site_admin":false},"repo":{"id":8924314,"name":"xrootd","full_name":"xrootd/xrootd","owner":{"login":"xrootd","id":2656051,"avatar_url":"https://avatars2.githubusercontent.com/u/2656051?v=4","gravatar_id":"","url":"https://api.github.com/users/xrootd","html_url":"https://github.com/xrootd","followers_url":"https://api.github.com/users/xrootd/followers","following_url":"https://api.github.com/users/xrootd/following{/other_user}","gists_url":"https://api.github.com/users/xrootd/gists{/gist_id}","starred_url":"https://api.github.com/users/xrootd/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xrootd/subscriptions","organizations_url":"https://api.github.com/users/xrootd/orgs","repos_url":"https://api.github.com/users/xrootd/repos","events_url":"https://api.github.com/users/xrootd/events{/privacy}","received_events_url":"https://api.github.com/users/xrootd/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/xrootd/xrootd","description":"The XRootD central repository","fork":false,"url":"https://api.github.com/repos/xrootd/xrootd","forks_url":"https://api.github.com/repos/xrootd/xrootd/forks","keys_url":"https://api.github.com/repos/xrootd/xrootd/keys{/key_id}","collaborators_url":"https://api.github.com/repos/xrootd/xrootd/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/xrootd/xrootd/teams","hooks_url":"https://api.github.com/repos/xrootd/xrootd/hooks","issue_events_url":"https://api.github.com/repos/xrootd/xrootd/issues/events{/number}","events_url":"https://api.github.com/repos/xrootd/xrootd/events","assignees_url":"https://api.github.com/repos/xrootd/xrootd/assignees{/user}","branches_url":"https://api.github.com/repos/xrootd/xrootd/branches{/branch}","tags_url":"https://api.github.com/repos/xrootd/xrootd/tags","blobs_url":"https://api.github.com/repos/xrootd/xrootd/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/xrootd/xrootd/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/xrootd/xrootd/git/refs{/sha}","trees_url":"https://api.github.com/repos/xrootd/xrootd/git/trees{/sha}","statuses_url":"https://api.github.com/repos/xrootd/xrootd/statuses/{sha}","languages_url":"https://api.github.com/repos/xrootd/xrootd/languages","stargazers_url":"https://api.github.com/repos/xrootd/xrootd/stargazers","contributors_url":"https://api.github.com/repos/xrootd/xrootd/contributors","subscribers_url":"https://api.github.com/repos/xrootd/xrootd/subscribers","subscription_url":"https://api.github.com/repos/xrootd/xrootd/subscription","commits_url":"https://api.github.com/repos/xrootd/xrootd/commits{/sha}","git_commits_url":"https://api.github.com/repos/xrootd/xrootd/git/commits{/sha}","comments_url":"https://api.github.com/repos/xrootd/xrootd/comments{/number}","issue_comment_url":"https://api.github.com/repos/xrootd/xrootd/issues/comments{/number}","contents_url":"https://api.github.com/repos/xrootd/xrootd/contents/{+path}","compare_url":"https://api.github.com/repos/xrootd/xrootd/compare/{base}...{head}","merges_url":"https://api.github.com/repos/xrootd/xrootd/merges","archive_url":"https://api.github.com/repos/xrootd/xrootd/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/xrootd/xrootd/downloads","issues_url":"https://api.github.com/repos/xrootd/xrootd/issues{/number}","pulls_url":"https://api.github.com/repos/xrootd/xrootd/pulls{/number}","milestones_url":"https://api.github.com/repos/xrootd/xrootd/milestones{/number}","notifications_url":"https://api.github.com/repos/xrootd/xrootd/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/xrootd/xrootd/labels{/name}","releases_url":"https://api.github.com/repos/xrootd/xrootd/releases{/id}","deployments_url":"https://api.github.com/repos/xrootd/xrootd/deployments","created_at":"2013-03-21T08:25:19Z","updated_at":"2018-02-09T10:47:59Z","pushed_at":"2018-02-13T00:14:27Z","git_url":"git://github.com/xrootd/xrootd.git","ssh_url":"git@github.com:xrootd/xrootd.git","clone_url":"https://github.com/xrootd/xrootd.git","svn_url":"https://github.com/xrootd/xrootd","homepage":null,"size":30613,"stargazers_count":43,"watchers_count":43,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":55,"mirror_url":null,"archived":false,"open_issues_count":31,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":55,"open_issues":31,"watchers":43,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/xrootd/xrootd/pulls/657"},"html":{"href":"https://github.com/xrootd/xrootd/pull/657"},"issue":{"href":"https://api.github.com/repos/xrootd/xrootd/issues/657"},"comments":{"href":"https://api.github.com/repos/xrootd/xrootd/issues/657/comments"},"review_comments":{"href":"https://api.github.com/repos/xrootd/xrootd/pulls/657/comments"},"review_comment":{"href":"https://api.github.com/repos/xrootd/xrootd/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/xrootd/xrootd/pulls/657/commits"},"statuses":{"href":"https://api.github.com/repos/xrootd/xrootd/statuses/60da79db805d122a7190535b8dead0f306e5a2f9"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"abh3"}}