{"action":"created","comment":{"url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/comments/176658351","pull_request_review_id":106400835,"id":176658351,"diff_hunk":"@@ -40,7 +40,7 @@\n   {                                                                                                                    \\\n     const dqm4hep::core::StatusCode statusCode(Command);                                                               \\\n     if (statusCode Operator StatusCode1) {                                                                             \\\n-      dqm_error(\"{0} return {1}, \", #Command, dqm4hep::core::statusCodeToString(statusCode));                          \\\n+      DQM4HEP_NO_EXCEPTION( dqm_error(\"{0} return {1}, \", #Command, dqm4hep::core::statusCodeToString(statusCode)); ); \\","path":"source/include/dqm4hep/StatusCodes.h","position":5,"original_position":5,"commit_id":"48c8154af678901c4377f87c99d7b073e4438337","original_commit_id":"48c8154af678901c4377f87c99d7b073e4438337","user":{"login":"apingault","id":11057316,"avatar_url":"https://avatars1.githubusercontent.com/u/11057316?v=4","gravatar_id":"","url":"https://api.github.com/users/apingault","html_url":"https://github.com/apingault","followers_url":"https://api.github.com/users/apingault/followers","following_url":"https://api.github.com/users/apingault/following{/other_user}","gists_url":"https://api.github.com/users/apingault/gists{/gist_id}","starred_url":"https://api.github.com/users/apingault/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/apingault/subscriptions","organizations_url":"https://api.github.com/users/apingault/orgs","repos_url":"https://api.github.com/users/apingault/repos","events_url":"https://api.github.com/users/apingault/events{/privacy}","received_events_url":"https://api.github.com/users/apingault/received_events","type":"User","site_admin":false},"body":"Not sure what this means: Are you afraid that `dqm4hep::core::statusCodeToString` might throw?\r\nAnd if it's the case now, what happens? Nothing is printed out?","created_at":"2018-03-23T07:47:43Z","updated_at":"2018-03-23T07:53:50Z","html_url":"https://github.com/DQM4HEP/dqm4hep-core/pull/35#discussion_r176658351","pull_request_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/35","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/comments/176658351"},"html":{"href":"https://github.com/DQM4HEP/dqm4hep-core/pull/35#discussion_r176658351"},"pull_request":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/35"}}},"pull_request":{"url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/35","id":176859460,"html_url":"https://github.com/DQM4HEP/dqm4hep-core/pull/35","diff_url":"https://github.com/DQM4HEP/dqm4hep-core/pull/35.diff","patch_url":"https://github.com/DQM4HEP/dqm4hep-core/pull/35.patch","issue_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/issues/35","number":35,"state":"open","locked":false,"title":"Coverity scan fix","user":{"login":"rete","id":950347,"avatar_url":"https://avatars1.githubusercontent.com/u/950347?v=4","gravatar_id":"","url":"https://api.github.com/users/rete","html_url":"https://github.com/rete","followers_url":"https://api.github.com/users/rete/followers","following_url":"https://api.github.com/users/rete/following{/other_user}","gists_url":"https://api.github.com/users/rete/gists{/gist_id}","starred_url":"https://api.github.com/users/rete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rete/subscriptions","organizations_url":"https://api.github.com/users/rete/orgs","repos_url":"https://api.github.com/users/rete/repos","events_url":"https://api.github.com/users/rete/events{/privacy}","received_events_url":"https://api.github.com/users/rete/received_events","type":"User","site_admin":false},"body":"\r\nBEGINRELEASENOTES\r\n- PluginManager\r\n   - Clean memory of loaded libraries using `dlclose()`\r\n- XMLParser\r\n   - Fixed XML element insertion into XML tree in resolveAllDbSelect() and `resolveIncludes()`\r\n- Added macro `DQM4HEP_NO_EXCEPTION` to shut down exceptions\r\n- Main files and tests \r\n   - Fix coverity errors/warnings using `DQM4HEP_NO_EXCEPTION` macro\r\n\r\nENDRELEASENOTES","created_at":"2018-03-22T17:48:35Z","updated_at":"2018-03-23T07:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"ef79cf73038125265b4fbb4dc4e98493013ebfd6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/35/commits","review_comments_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/35/comments","review_comment_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/issues/35/comments","statuses_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/statuses/48c8154af678901c4377f87c99d7b073e4438337","head":{"label":"rete:coverity-scan-fix","ref":"coverity-scan-fix","sha":"48c8154af678901c4377f87c99d7b073e4438337","user":{"login":"rete","id":950347,"avatar_url":"https://avatars1.githubusercontent.com/u/950347?v=4","gravatar_id":"","url":"https://api.github.com/users/rete","html_url":"https://github.com/rete","followers_url":"https://api.github.com/users/rete/followers","following_url":"https://api.github.com/users/rete/following{/other_user}","gists_url":"https://api.github.com/users/rete/gists{/gist_id}","starred_url":"https://api.github.com/users/rete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rete/subscriptions","organizations_url":"https://api.github.com/users/rete/orgs","repos_url":"https://api.github.com/users/rete/repos","events_url":"https://api.github.com/users/rete/events{/privacy}","received_events_url":"https://api.github.com/users/rete/received_events","type":"User","site_admin":false},"repo":{"id":108755855,"name":"dqm4hep-core","full_name":"rete/dqm4hep-core","owner":{"login":"rete","id":950347,"avatar_url":"https://avatars1.githubusercontent.com/u/950347?v=4","gravatar_id":"","url":"https://api.github.com/users/rete","html_url":"https://github.com/rete","followers_url":"https://api.github.com/users/rete/followers","following_url":"https://api.github.com/users/rete/following{/other_user}","gists_url":"https://api.github.com/users/rete/gists{/gist_id}","starred_url":"https://api.github.com/users/rete/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rete/subscriptions","organizations_url":"https://api.github.com/users/rete/orgs","repos_url":"https://api.github.com/users/rete/repos","events_url":"https://api.github.com/users/rete/events{/privacy}","received_events_url":"https://api.github.com/users/rete/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/rete/dqm4hep-core","description":"DQM4HEP core implementation ","fork":true,"url":"https://api.github.com/repos/rete/dqm4hep-core","forks_url":"https://api.github.com/repos/rete/dqm4hep-core/forks","keys_url":"https://api.github.com/repos/rete/dqm4hep-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/rete/dqm4hep-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/rete/dqm4hep-core/teams","hooks_url":"https://api.github.com/repos/rete/dqm4hep-core/hooks","issue_events_url":"https://api.github.com/repos/rete/dqm4hep-core/issues/events{/number}","events_url":"https://api.github.com/repos/rete/dqm4hep-core/events","assignees_url":"https://api.github.com/repos/rete/dqm4hep-core/assignees{/user}","branches_url":"https://api.github.com/repos/rete/dqm4hep-core/branches{/branch}","tags_url":"https://api.github.com/repos/rete/dqm4hep-core/tags","blobs_url":"https://api.github.com/repos/rete/dqm4hep-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/rete/dqm4hep-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/rete/dqm4hep-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/rete/dqm4hep-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/rete/dqm4hep-core/statuses/{sha}","languages_url":"https://api.github.com/repos/rete/dqm4hep-core/languages","stargazers_url":"https://api.github.com/repos/rete/dqm4hep-core/stargazers","contributors_url":"https://api.github.com/repos/rete/dqm4hep-core/contributors","subscribers_url":"https://api.github.com/repos/rete/dqm4hep-core/subscribers","subscription_url":"https://api.github.com/repos/rete/dqm4hep-core/subscription","commits_url":"https://api.github.com/repos/rete/dqm4hep-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/rete/dqm4hep-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/rete/dqm4hep-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/rete/dqm4hep-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/rete/dqm4hep-core/contents/{+path}","compare_url":"https://api.github.com/repos/rete/dqm4hep-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/rete/dqm4hep-core/merges","archive_url":"https://api.github.com/repos/rete/dqm4hep-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/rete/dqm4hep-core/downloads","issues_url":"https://api.github.com/repos/rete/dqm4hep-core/issues{/number}","pulls_url":"https://api.github.com/repos/rete/dqm4hep-core/pulls{/number}","milestones_url":"https://api.github.com/repos/rete/dqm4hep-core/milestones{/number}","notifications_url":"https://api.github.com/repos/rete/dqm4hep-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/rete/dqm4hep-core/labels{/name}","releases_url":"https://api.github.com/repos/rete/dqm4hep-core/releases{/id}","deployments_url":"https://api.github.com/repos/rete/dqm4hep-core/deployments","created_at":"2017-10-29T17:34:47Z","updated_at":"2017-10-29T17:34:49Z","pushed_at":"2018-03-22T18:10:43Z","git_url":"git://github.com/rete/dqm4hep-core.git","ssh_url":"git@github.com:rete/dqm4hep-core.git","clone_url":"https://github.com/rete/dqm4hep-core.git","svn_url":"https://github.com/rete/dqm4hep-core","homepage":"","size":1586,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"DQM4HEP:master","ref":"master","sha":"0a5e5ab0872c32c869ae94e11738a2475b8b6928","user":{"login":"DQM4HEP","id":16612352,"avatar_url":"https://avatars3.githubusercontent.com/u/16612352?v=4","gravatar_id":"","url":"https://api.github.com/users/DQM4HEP","html_url":"https://github.com/DQM4HEP","followers_url":"https://api.github.com/users/DQM4HEP/followers","following_url":"https://api.github.com/users/DQM4HEP/following{/other_user}","gists_url":"https://api.github.com/users/DQM4HEP/gists{/gist_id}","starred_url":"https://api.github.com/users/DQM4HEP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DQM4HEP/subscriptions","organizations_url":"https://api.github.com/users/DQM4HEP/orgs","repos_url":"https://api.github.com/users/DQM4HEP/repos","events_url":"https://api.github.com/users/DQM4HEP/events{/privacy}","received_events_url":"https://api.github.com/users/DQM4HEP/received_events","type":"Organization","site_admin":false},"repo":{"id":79259033,"name":"dqm4hep-core","full_name":"DQM4HEP/dqm4hep-core","owner":{"login":"DQM4HEP","id":16612352,"avatar_url":"https://avatars3.githubusercontent.com/u/16612352?v=4","gravatar_id":"","url":"https://api.github.com/users/DQM4HEP","html_url":"https://github.com/DQM4HEP","followers_url":"https://api.github.com/users/DQM4HEP/followers","following_url":"https://api.github.com/users/DQM4HEP/following{/other_user}","gists_url":"https://api.github.com/users/DQM4HEP/gists{/gist_id}","starred_url":"https://api.github.com/users/DQM4HEP/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/DQM4HEP/subscriptions","organizations_url":"https://api.github.com/users/DQM4HEP/orgs","repos_url":"https://api.github.com/users/DQM4HEP/repos","events_url":"https://api.github.com/users/DQM4HEP/events{/privacy}","received_events_url":"https://api.github.com/users/DQM4HEP/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/DQM4HEP/dqm4hep-core","description":"DQM4HEP core implementation ","fork":false,"url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core","forks_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/forks","keys_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/teams","hooks_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/hooks","issue_events_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/issues/events{/number}","events_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/events","assignees_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/assignees{/user}","branches_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/branches{/branch}","tags_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/tags","blobs_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/statuses/{sha}","languages_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/languages","stargazers_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/stargazers","contributors_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/contributors","subscribers_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/subscribers","subscription_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/subscription","commits_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/contents/{+path}","compare_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/merges","archive_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/downloads","issues_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/issues{/number}","pulls_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls{/number}","milestones_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/milestones{/number}","notifications_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/labels{/name}","releases_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/releases{/id}","deployments_url":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/deployments","created_at":"2017-01-17T18:39:22Z","updated_at":"2018-03-22T13:07:57Z","pushed_at":"2018-03-22T18:11:39Z","git_url":"git://github.com/DQM4HEP/dqm4hep-core.git","ssh_url":"git@github.com:DQM4HEP/dqm4hep-core.git","clone_url":"https://github.com/DQM4HEP/dqm4hep-core.git","svn_url":"https://github.com/DQM4HEP/dqm4hep-core","homepage":"","size":1562,"stargazers_count":0,"watchers_count":0,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":3,"mirror_url":null,"archived":false,"open_issues_count":8,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0"},"forks":3,"open_issues":8,"watchers":0,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/35"},"html":{"href":"https://github.com/DQM4HEP/dqm4hep-core/pull/35"},"issue":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/issues/35"},"comments":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/issues/35/comments"},"review_comments":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/35/comments"},"review_comment":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/pulls/35/commits"},"statuses":{"href":"https://api.github.com/repos/DQM4HEP/dqm4hep-core/statuses/48c8154af678901c4377f87c99d7b073e4438337"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"apingault"}}