{"action":"created","issue":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2601","repository_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware","labels_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2601/labels{/name}","comments_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2601/comments","events_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2601/events","html_url":"https://github.com/nodemcu/nodemcu-firmware/issues/2601","id":394903573,"node_id":"MDU6SXNzdWUzOTQ5MDM1NzM=","number":2601,"title":"Resolve deprecation status of static timers","user":{"login":"marcelstoer","id":624195,"node_id":"MDQ6VXNlcjYyNDE5NQ==","avatar_url":"https://avatars0.githubusercontent.com/u/624195?v=4","gravatar_id":"","url":"https://api.github.com/users/marcelstoer","html_url":"https://github.com/marcelstoer","followers_url":"https://api.github.com/users/marcelstoer/followers","following_url":"https://api.github.com/users/marcelstoer/following{/other_user}","gists_url":"https://api.github.com/users/marcelstoer/gists{/gist_id}","starred_url":"https://api.github.com/users/marcelstoer/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/marcelstoer/subscriptions","organizations_url":"https://api.github.com/users/marcelstoer/orgs","repos_url":"https://api.github.com/users/marcelstoer/repos","events_url":"https://api.github.com/users/marcelstoer/events{/privacy}","received_events_url":"https://api.github.com/users/marcelstoer/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-30T21:42:56Z","updated_at":"2018-12-30T21:54:08Z","closed_at":null,"author_association":"COLLABORATOR","body":"Ever since @djphoenix added an OO API to the timer module with f1afe7b6ab2ab2b385f28fda80a16a7c97ac8994 over two years ago our documentation has been saying that \r\n\r\n> Static timers are deprecated and will be removed later.\r\n\r\nThat's a bit problematic for two reasons:\r\n\r\n1. The note is just in the documentation and not reflected in the code. One should use `platform_print_deprecation_note` in `tmr.c` to print a deprecation note to the console (like we do elsewhere) whenever a static timer function is used.\r\n1. I couldn't find a follow-up issue here that would ask for the actual removal of the static timers. Who would/could/should have done that? Things get forgotten so easily.\r\n\r\nIt's all history now but I'd like to resolve that deprecation note in the docs. IMO we should either removed it or follow-up with code changes.\r\n\r\nTagging @djphoenix, @dnc40085 who is listed as the module maintainer in the docs and @devsaurus who ported the module to the ESP32 and thereby removed the static timers if I'm not mistaken"},"comment":{"url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/comments/450589275","html_url":"https://github.com/nodemcu/nodemcu-firmware/issues/2601#issuecomment-450589275","issue_url":"https://api.github.com/repos/nodemcu/nodemcu-firmware/issues/2601","id":450589275,"node_id":"MDEyOklzc3VlQ29tbWVudDQ1MDU4OTI3NQ==","user":{"login":"jmd13391","id":15124449,"node_id":"MDQ6VXNlcjE1MTI0NDQ5","avatar_url":"https://avatars3.githubusercontent.com/u/15124449?v=4","gravatar_id":"","url":"https://api.github.com/users/jmd13391","html_url":"https://github.com/jmd13391","followers_url":"https://api.github.com/users/jmd13391/followers","following_url":"https://api.github.com/users/jmd13391/following{/other_user}","gists_url":"https://api.github.com/users/jmd13391/gists{/gist_id}","starred_url":"https://api.github.com/users/jmd13391/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jmd13391/subscriptions","organizations_url":"https://api.github.com/users/jmd13391/orgs","repos_url":"https://api.github.com/users/jmd13391/repos","events_url":"https://api.github.com/users/jmd13391/events{/privacy}","received_events_url":"https://api.github.com/users/jmd13391/received_events","type":"User","site_admin":false},"created_at":"2018-12-30T21:54:08Z","updated_at":"2018-12-30T21:54:08Z","author_association":"NONE","body":"IMO, Removing the static timers is a bad idea. Legacy compatibility aside, using static timers consumes less memory than using the OOP timers.\r\n\r\nMy vote is to remove the deprecation statement from the docs.\r\n"}}
{"actor":{"display_login":"jmd13391"}}