{"action":"created","issue":{"url":"https://api.github.com/repos/apache/cloudstack/issues/2758","repository_url":"https://api.github.com/repos/apache/cloudstack","labels_url":"https://api.github.com/repos/apache/cloudstack/issues/2758/labels{/name}","comments_url":"https://api.github.com/repos/apache/cloudstack/issues/2758/comments","events_url":"https://api.github.com/repos/apache/cloudstack/issues/2758/events","html_url":"https://github.com/apache/cloudstack/issues/2758","id":343104297,"node_id":"MDU6SXNzdWUzNDMxMDQyOTc=","number":2758,"title":"storage_pool_details overprovisioning settings are being picked up as a tag","user":{"login":"borisstoyanov","id":13551960,"node_id":"MDQ6VXNlcjEzNTUxOTYw","avatar_url":"https://avatars1.githubusercontent.com/u/13551960?v=4","gravatar_id":"","url":"https://api.github.com/users/borisstoyanov","html_url":"https://github.com/borisstoyanov","followers_url":"https://api.github.com/users/borisstoyanov/followers","following_url":"https://api.github.com/users/borisstoyanov/following{/other_user}","gists_url":"https://api.github.com/users/borisstoyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisstoyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisstoyanov/subscriptions","organizations_url":"https://api.github.com/users/borisstoyanov/orgs","repos_url":"https://api.github.com/users/borisstoyanov/repos","events_url":"https://api.github.com/users/borisstoyanov/events{/privacy}","received_events_url":"https://api.github.com/users/borisstoyanov/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-07-20T13:18:01Z","updated_at":"2018-07-20T13:42:28Z","closed_at":null,"author_association":"CONTRIBUTOR","body":"<!--\r\nVerify first that your issue/request is not already reported on GitHub.\r\nAlso test if the latest release and master branch are affected too.\r\nAlways add information AFTER of these HTML comments, but no need to delete the comments.\r\n-->\r\n\r\n\r\n##### ISSUE TYPE\r\n<!-- Pick one below and delete the rest -->\r\n * Bug Report\r\n\r\n\r\n##### COMPONENT NAME\r\n<!--\r\nCategorize the issue, e.g. API, VR, VPN, UI, etc.\r\n-->\r\n~~~\r\nStorage\r\n~~~\r\n\r\n##### CLOUDSTACK VERSION\r\n<!--\r\nNew line separated list of affected versions, commit ID for issues on master branch.\r\n-->\r\n\r\n~~~\r\n4.12\r\n~~~\r\n\r\n##### SUMMARY\r\n<!-- Explain the problem/feature briefly -->\r\nWhen user uses the updateConfiguration api: \r\n~~~\r\nupdate configuration name = \"storage.overprovisioning.factor\" value = 2.0 storageid = [pool.id]\r\n~~~\r\nCloudstack api creates a record in the storage_pool_details table looking like that: \r\n~~~\r\nMariaDB [cloud]>  select * from storage_pool_details;\r\n+----+---------+---------------------------------+-------+---------+\r\n| id | pool_id | name                            | value | display |\r\n+----+---------+---------------------------------+-------+---------+\r\n|  2 |       2 | storage.overprovisioning.factor | 2.0   |       1 |\r\n+----+---------+---------------------------------+-------+---------+\r\n1 row in set (0.00 sec)\r\n~~~\r\nAt this point if you try to migrate a volume and change it's disk offering, it fails with \r\n\r\n~~~\r\n{errorcode : 431, errortext : u'Target Storage [id=26055c44-abb2-3ec6-8098-3c7f067e6d34] tags [storage.overprovisioning.factor] does not match new disk offering [id=637a5ded-3fba-4eda-9515-fc5218d1c905] tags [null].'}\r\n~~~ \r\n\r\nWhich makes me think that cloudstack thinks this setting is actually a tag and fails the operation.\r\n\r\nThere are no other setting or tags at the storage at this moment that might cause this. \r\n\r\n~~~\r\nMariaDB [cloud]>  select * from storage_pool_details;\r\n+----+---------+---------------------------------+-------+---------+\r\n| id | pool_id | name                            | value | display |\r\n+----+---------+---------------------------------+-------+---------+\r\n|  2 |       2 | storage.overprovisioning.factor | 2.0   |       1 |\r\n+----+---------+---------------------------------+-------+---------+\r\n1 row in set (0.00 sec)\r\n\r\nMariaDB [cloud]>  select * from storage_pool_tags;\r\nEmpty set (0.00 sec)\r\n\r\n~~~\r\n\r\n##### STEPS TO REPRODUCE\r\n<!--\r\nFor bugs, show exactly how to reproduce the problem, using a minimal test-case. Use Screenshots if accurate.\r\n\r\nFor new features, show how the feature would be used.\r\n-->\r\n\r\n<!-- Paste example playbooks or commands between quotes below -->\r\n~~~\r\n- Deploy a VM and attach a small disk to it\r\n- with cloudmonkey execute: update configuration name = \"storage.overprovisioning.factor\" value = 2.0 storageid = [target.pool.id]\r\n- with cloudmonkey execute: migrate volume volumeid=[vol.id] storageid=[target.pool.id] newdiskofferingid=[large.disk.off.id]\r\n~~~\r\n\r\n<!-- You can also paste gist.github.com links for larger files -->\r\n\r\n##### EXPECTED RESULTS\r\n<!-- What did you expect to happen when running the steps above? -->\r\n\r\n~~~\r\nI would expect that the volume is migrated with new disk offering\r\n~~~\r\n\r\n##### ACTUAL RESULTS\r\n<!-- What actually happened? -->\r\n\r\n<!-- Paste verbatim command output between quotes below -->\r\n~~~\r\nIt fails with:\r\n{errorcode : 431, errortext : u'Target Storage [id=26055c44-abb2-3ec6-8098-3c7f067e6d34] tags [storage.overprovisioning.factor] does not match new disk offering [id=637a5ded-3fba-4eda-9515-fc5218d1c905] tags [null].'}\r\n\r\nwhich looks like the overriding overprovisiohnning setting is taken as a tag. Note that there are no tags to the pool or offering at this time that might interfere.\r\n~~~\r\n"},"comment":{"url":"https://api.github.com/repos/apache/cloudstack/issues/comments/406604276","html_url":"https://github.com/apache/cloudstack/issues/2758#issuecomment-406604276","issue_url":"https://api.github.com/repos/apache/cloudstack/issues/2758","id":406604276,"node_id":"MDEyOklzc3VlQ29tbWVudDQwNjYwNDI3Ng==","user":{"login":"borisstoyanov","id":13551960,"node_id":"MDQ6VXNlcjEzNTUxOTYw","avatar_url":"https://avatars1.githubusercontent.com/u/13551960?v=4","gravatar_id":"","url":"https://api.github.com/users/borisstoyanov","html_url":"https://github.com/borisstoyanov","followers_url":"https://api.github.com/users/borisstoyanov/followers","following_url":"https://api.github.com/users/borisstoyanov/following{/other_user}","gists_url":"https://api.github.com/users/borisstoyanov/gists{/gist_id}","starred_url":"https://api.github.com/users/borisstoyanov/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/borisstoyanov/subscriptions","organizations_url":"https://api.github.com/users/borisstoyanov/orgs","repos_url":"https://api.github.com/users/borisstoyanov/repos","events_url":"https://api.github.com/users/borisstoyanov/events{/privacy}","received_events_url":"https://api.github.com/users/borisstoyanov/received_events","type":"User","site_admin":false},"created_at":"2018-07-20T13:42:28Z","updated_at":"2018-07-20T13:42:28Z","author_association":"CONTRIBUTOR","body":"thanks @rafaelweingartner "}}
{"actor":{"display_login":"borisstoyanov"}}