{"action":"created","issue":{"url":"https://api.github.com/repos/golang/go/issues/26957","repository_url":"https://api.github.com/repos/golang/go","labels_url":"https://api.github.com/repos/golang/go/issues/26957/labels{/name}","comments_url":"https://api.github.com/repos/golang/go/issues/26957/comments","events_url":"https://api.github.com/repos/golang/go/issues/26957/events","html_url":"https://github.com/golang/go/issues/26957","id":349948405,"node_id":"MDU6SXNzdWUzNDk5NDg0MDU=","number":26957,"title":"x/net/http2: the peer windows size not updated in processSettingInitialWindowSize()","user":{"login":"crowfrog","id":38678436,"node_id":"MDQ6VXNlcjM4Njc4NDM2","avatar_url":"https://avatars3.githubusercontent.com/u/38678436?v=4","gravatar_id":"","url":"https://api.github.com/users/crowfrog","html_url":"https://github.com/crowfrog","followers_url":"https://api.github.com/users/crowfrog/followers","following_url":"https://api.github.com/users/crowfrog/following{/other_user}","gists_url":"https://api.github.com/users/crowfrog/gists{/gist_id}","starred_url":"https://api.github.com/users/crowfrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowfrog/subscriptions","organizations_url":"https://api.github.com/users/crowfrog/orgs","repos_url":"https://api.github.com/users/crowfrog/repos","events_url":"https://api.github.com/users/crowfrog/events{/privacy}","received_events_url":"https://api.github.com/users/crowfrog/received_events","type":"User","site_admin":false},"labels":[{"id":373402289,"node_id":"MDU6TGFiZWwzNzM0MDIyODk=","url":"https://api.github.com/repos/golang/go/labels/NeedsInvestigation","name":"NeedsInvestigation","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":{"url":"https://api.github.com/repos/golang/go/milestones/65","html_url":"https://github.com/golang/go/milestone/65","labels_url":"https://api.github.com/repos/golang/go/milestones/65/labels","id":3072996,"node_id":"MDk6TWlsZXN0b25lMzA3Mjk5Ng==","number":65,"title":"Go1.12","description":"","creator":{"login":"rsc","id":104030,"node_id":"MDQ6VXNlcjEwNDAzMA==","avatar_url":"https://avatars1.githubusercontent.com/u/104030?v=4","gravatar_id":"","url":"https://api.github.com/users/rsc","html_url":"https://github.com/rsc","followers_url":"https://api.github.com/users/rsc/followers","following_url":"https://api.github.com/users/rsc/following{/other_user}","gists_url":"https://api.github.com/users/rsc/gists{/gist_id}","starred_url":"https://api.github.com/users/rsc/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/rsc/subscriptions","organizations_url":"https://api.github.com/users/rsc/orgs","repos_url":"https://api.github.com/users/rsc/repos","events_url":"https://api.github.com/users/rsc/events{/privacy}","received_events_url":"https://api.github.com/users/rsc/received_events","type":"User","site_admin":false},"open_issues":707,"closed_issues":359,"state":"open","created_at":"2018-01-29T21:17:52Z","updated_at":"2018-10-31T00:34:16Z","due_on":"2019-01-31T08:00:00Z","closed_at":null},"comments":7,"created_at":"2018-08-13T09:14:33Z","updated_at":"2018-10-31T03:05:28Z","closed_at":null,"author_association":"NONE","body":"### What version of Go are you using (`go version`)?\r\ngolang:1.10.0 linux\r\n\r\n### Does this issue reproduce with the latest release?\r\nYes\r\n\r\n### What operating system and processor architecture are you using (`go env`)?\r\ncontainer: rhel\r\nkubenet:\r\n\r\n### What did you do?\r\nIn processSettingInitialWindowSize()\r\nThe code adjust the size of all stream flow control windows **but not change the server connection flow's**.\r\n**That makes all new steam will use 65535 as initial window size but not the value from InitialWindowSize in SETTINGS**\r\n\r\n### What did you expect to see?\r\nthe window size could be updated if client send InitialWindowSize in SETTINGS\r\n\r\n### What did you see instead?\r\n65535 will be cost out speedily in high load performance test and makes server pending response until clinet WINDOW_UPDATE comes.\r\nIt impacts latency of load test.\r\n"},"comment":{"url":"https://api.github.com/repos/golang/go/issues/comments/434545108","html_url":"https://github.com/golang/go/issues/26957#issuecomment-434545108","issue_url":"https://api.github.com/repos/golang/go/issues/26957","id":434545108,"node_id":"MDEyOklzc3VlQ29tbWVudDQzNDU0NTEwOA==","user":{"login":"crowfrog","id":38678436,"node_id":"MDQ6VXNlcjM4Njc4NDM2","avatar_url":"https://avatars3.githubusercontent.com/u/38678436?v=4","gravatar_id":"","url":"https://api.github.com/users/crowfrog","html_url":"https://github.com/crowfrog","followers_url":"https://api.github.com/users/crowfrog/followers","following_url":"https://api.github.com/users/crowfrog/following{/other_user}","gists_url":"https://api.github.com/users/crowfrog/gists{/gist_id}","starred_url":"https://api.github.com/users/crowfrog/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/crowfrog/subscriptions","organizations_url":"https://api.github.com/users/crowfrog/orgs","repos_url":"https://api.github.com/users/crowfrog/repos","events_url":"https://api.github.com/users/crowfrog/events{/privacy}","received_events_url":"https://api.github.com/users/crowfrog/received_events","type":"User","site_admin":false},"created_at":"2018-10-31T03:05:28Z","updated_at":"2018-10-31T03:05:28Z","author_association":"NONE","body":"hi Fraenkel & Bradfitz,\r\n\r\nSorry for relply so late! \r\nI checked other tools's log (such as nghttp2) and websites which support http2 (https://www.wappalyzer.com/technologies/http-2, etc.)\r\nI found the peer will send WINDOW_UPDATE to set connection window size after connection setup.\r\nAnd after check RFC7540, I think this behavior should be correct.\r\nSo this issue should be invalid.\r\n\r\nB.R"}}
{"actor":{"display_login":"crowfrog"}}