{"action":"created","issue":{"url":"https://api.github.com/repos/chevah/python-package/issues/101","repository_url":"https://api.github.com/repos/chevah/python-package","labels_url":"https://api.github.com/repos/chevah/python-package/issues/101/labels{/name}","comments_url":"https://api.github.com/repos/chevah/python-package/issues/101/comments","events_url":"https://api.github.com/repos/chevah/python-package/issues/101/events","html_url":"https://github.com/chevah/python-package/pull/101","id":310487791,"number":101,"title":"[#4836] SQLite upgrade to 3.23.0.","user":{"login":"dumol","id":1620933,"avatar_url":"https://avatars3.githubusercontent.com/u/1620933?v=4","gravatar_id":"","url":"https://api.github.com/users/dumol","html_url":"https://github.com/dumol","followers_url":"https://api.github.com/users/dumol/followers","following_url":"https://api.github.com/users/dumol/following{/other_user}","gists_url":"https://api.github.com/users/dumol/gists{/gist_id}","starred_url":"https://api.github.com/users/dumol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumol/subscriptions","organizations_url":"https://api.github.com/users/dumol/orgs","repos_url":"https://api.github.com/users/dumol/repos","events_url":"https://api.github.com/users/dumol/events{/privacy}","received_events_url":"https://api.github.com/users/dumol/received_events","type":"User","site_admin":false},"labels":[{"id":721252098,"url":"https://api.github.com/repos/chevah/python-package/labels/needs-merge","name":"needs-merge","color":"0e8a16","default":false}],"state":"open","locked":false,"assignee":{"login":"dumol","id":1620933,"avatar_url":"https://avatars3.githubusercontent.com/u/1620933?v=4","gravatar_id":"","url":"https://api.github.com/users/dumol","html_url":"https://github.com/dumol","followers_url":"https://api.github.com/users/dumol/followers","following_url":"https://api.github.com/users/dumol/following{/other_user}","gists_url":"https://api.github.com/users/dumol/gists{/gist_id}","starred_url":"https://api.github.com/users/dumol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumol/subscriptions","organizations_url":"https://api.github.com/users/dumol/orgs","repos_url":"https://api.github.com/users/dumol/repos","events_url":"https://api.github.com/users/dumol/events{/privacy}","received_events_url":"https://api.github.com/users/dumol/received_events","type":"User","site_admin":false},"assignees":[{"login":"dumol","id":1620933,"avatar_url":"https://avatars3.githubusercontent.com/u/1620933?v=4","gravatar_id":"","url":"https://api.github.com/users/dumol","html_url":"https://github.com/dumol","followers_url":"https://api.github.com/users/dumol/followers","following_url":"https://api.github.com/users/dumol/following{/other_user}","gists_url":"https://api.github.com/users/dumol/gists{/gist_id}","starred_url":"https://api.github.com/users/dumol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumol/subscriptions","organizations_url":"https://api.github.com/users/dumol/orgs","repos_url":"https://api.github.com/users/dumol/repos","events_url":"https://api.github.com/users/dumol/events{/privacy}","received_events_url":"https://api.github.com/users/dumol/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-04-02T13:41:23Z","updated_at":"2018-04-03T07:40:43Z","closed_at":null,"author_association":"CONTRIBUTOR","pull_request":{"url":"https://api.github.com/repos/chevah/python-package/pulls/101","html_url":"https://github.com/chevah/python-package/pull/101","diff_url":"https://github.com/chevah/python-package/pull/101.diff","patch_url":"https://github.com/chevah/python-package/pull/101.patch"},"body":"Scope\r\n=====\r\n\r\nBuild python-package with a more recent SQLite, as the version we are currently using, 3.20.1, is affected by a few security issues: ​https://www.cvedetails.com/vulnerability-list/vendor_id-9237/Sqlite.html\r\n​https://cve.mitre.org/cgi-bin/cvekey.cgi?keyword=sqlite\r\n\r\nNote that on Windows we are at the mercy of the upstream Python packagers and the version they include, 3.8.11.0, is affected by even more serious issues.\r\n\r\nChanges\r\n=======\r\n\r\nUpdated the included SQLite sources and incremented SQLITE_VERSION accordingly.\r\n\r\nAdded an up-to-date SQLite 32-bit Windows DLL in `src/sqlite` and used it to overwrite the DLL included in Python's Windows installer.\r\n\r\n\r\nHow to try and test the changes\r\n===============================\r\n\r\nreviewers: @adiroiban \r\n\r\nPlease review the changes.\r\nRun the automated tests.\r\nMake sure the updated Windows DLL works as expected.\r\n"},"comment":{"url":"https://api.github.com/repos/chevah/python-package/issues/comments/378157864","html_url":"https://github.com/chevah/python-package/pull/101#issuecomment-378157864","issue_url":"https://api.github.com/repos/chevah/python-package/issues/101","id":378157864,"user":{"login":"dumol","id":1620933,"avatar_url":"https://avatars3.githubusercontent.com/u/1620933?v=4","gravatar_id":"","url":"https://api.github.com/users/dumol","html_url":"https://github.com/dumol","followers_url":"https://api.github.com/users/dumol/followers","following_url":"https://api.github.com/users/dumol/following{/other_user}","gists_url":"https://api.github.com/users/dumol/gists{/gist_id}","starred_url":"https://api.github.com/users/dumol/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/dumol/subscriptions","organizations_url":"https://api.github.com/users/dumol/orgs","repos_url":"https://api.github.com/users/dumol/repos","events_url":"https://api.github.com/users/dumol/events{/privacy}","received_events_url":"https://api.github.com/users/dumol/received_events","type":"User","site_admin":false},"created_at":"2018-04-03T07:40:43Z","updated_at":"2018-04-03T07:40:43Z","author_association":"CONTRIBUTOR","body":"Both the sources and the 32bit DLL were downloaded from upstream sqlite.org site. I thought it goes without saying, but it seems that's not the case, so I documented it  to be clear. Could be helpful in some other ways, as there are plenty of downloads to choose from on the sqlite.org download page.\r\n\r\nHowever, upstream Python packagers were not using the same source. From what I can tell, they build the SQLite DLL themselves, possibly with Visual Studio, as apparently they are not using GCC as the SQLite maintainer does."}}
{"actor":{"display_login":"dumol"}}