{"action":"created","comment":{"url":"https://api.github.com/repos/nodejs/node/pulls/comments/173673313","pull_request_review_id":102899829,"id":173673313,"diff_hunk":"@@ -75,47 +78,88 @@ Collaborators or additional evidence that the issue has relevance, the\n issue may be closed. Remember that issues can always be re-opened if\n necessary.\n \n+### Author ready pull requests\n+\n+A pull request that is still awaiting the minimum review time is considered\n+`author-ready` as soon as the CI has been started, it has at least one approval,\n+and it has no outstanding review comments. Please always make sure to add the\n+appropriate `author-ready` label to the PR in that case and remove it again as\n+soon as that condition is not met anymore.\n+\n+### Handling own pull requests\n+\n+If you as a Collaborator open a pull request, please always start a CI right\n+after (see [testing and CI](#testing-and-ci) for further information on how to\n+do that) and post the link to it as well. Please also make sure that you start a\n+new CI after each update (due to e.g., a change request in a review or due to\n+rebasing).","path":"COLLABORATOR_GUIDE.md","position":null,"original_position":64,"commit_id":"79c48f5f3f6467b928fe8e5cacbc38c518a9eb4d","original_commit_id":"12ef5df35cfa8bf5921bc2c0369d347fa64c9f0e","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"Reworded.","created_at":"2018-03-11T22:53:50Z","updated_at":"2018-03-11T22:53:50Z","html_url":"https://github.com/nodejs/node/pull/19116#discussion_r173673313","pull_request_url":"https://api.github.com/repos/nodejs/node/pulls/19116","author_association":"MEMBER","_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments/173673313"},"html":{"href":"https://github.com/nodejs/node/pull/19116#discussion_r173673313"},"pull_request":{"href":"https://api.github.com/repos/nodejs/node/pulls/19116"}},"in_reply_to_id":173318278},"pull_request":{"url":"https://api.github.com/repos/nodejs/node/pulls/19116","id":172695566,"html_url":"https://github.com/nodejs/node/pull/19116","diff_url":"https://github.com/nodejs/node/pull/19116.diff","patch_url":"https://github.com/nodejs/node/pull/19116.patch","issue_url":"https://api.github.com/repos/nodejs/node/issues/19116","number":19116,"state":"open","locked":false,"title":"doc: update collaborator guide","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"body":"This also updates some parts of the onboarding. It is mainly about\r\nhow to handle pull requests, how and when to start a CI, when to add\r\nthe `ready` label and some other minor changes.\r\n\r\nI believe that adopting these suggestions will improve our general PR handling a lot.\r\n\r\nIt can probably be further polished though, so I am looking forward to your comments.\r\n\r\n<!--\r\nThank you for your pull request. Please provide a description above and review\r\nthe requirements below.\r\n\r\nBug fixes and new features should include tests and possibly benchmarks.\r\n\r\nContributors guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md\r\n-->\r\n\r\n##### Checklist\r\n<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->\r\n\r\n- [x] `make -j4 test` (UNIX), or `vcbuild test` (Windows) passes\r\n- [x] tests and/or benchmarks are included\r\n- [x] documentation is changed or added\r\n- [x] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)\r\n\r\n##### Affected core subsystem(s)\r\n<!-- Provide affected core subsystem(s) (like doc, cluster, crypto, etc). -->\r\ndoc","created_at":"2018-03-04T00:40:26Z","updated_at":"2018-03-11T22:53:50Z","closed_at":null,"merged_at":null,"merge_commit_sha":"aa0d0d045407e1b9e1881a9f4896116e8c1cf2e9","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":155267517,"url":"https://api.github.com/repos/nodejs/node/labels/doc","name":"doc","color":"006b75","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/nodejs/node/pulls/19116/commits","review_comments_url":"https://api.github.com/repos/nodejs/node/pulls/19116/comments","review_comment_url":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}","comments_url":"https://api.github.com/repos/nodejs/node/issues/19116/comments","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/79c48f5f3f6467b928fe8e5cacbc38c518a9eb4d","head":{"label":"BridgeAR:update-collaborators","ref":"update-collaborators","sha":"79c48f5f3f6467b928fe8e5cacbc38c518a9eb4d","user":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"repo":{"id":51107611,"name":"node","full_name":"BridgeAR/node","owner":{"login":"BridgeAR","id":8822573,"avatar_url":"https://avatars2.githubusercontent.com/u/8822573?v=4","gravatar_id":"","url":"https://api.github.com/users/BridgeAR","html_url":"https://github.com/BridgeAR","followers_url":"https://api.github.com/users/BridgeAR/followers","following_url":"https://api.github.com/users/BridgeAR/following{/other_user}","gists_url":"https://api.github.com/users/BridgeAR/gists{/gist_id}","starred_url":"https://api.github.com/users/BridgeAR/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/BridgeAR/subscriptions","organizations_url":"https://api.github.com/users/BridgeAR/orgs","repos_url":"https://api.github.com/users/BridgeAR/repos","events_url":"https://api.github.com/users/BridgeAR/events{/privacy}","received_events_url":"https://api.github.com/users/BridgeAR/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/BridgeAR/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":true,"url":"https://api.github.com/repos/BridgeAR/node","forks_url":"https://api.github.com/repos/BridgeAR/node/forks","keys_url":"https://api.github.com/repos/BridgeAR/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/BridgeAR/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/BridgeAR/node/teams","hooks_url":"https://api.github.com/repos/BridgeAR/node/hooks","issue_events_url":"https://api.github.com/repos/BridgeAR/node/issues/events{/number}","events_url":"https://api.github.com/repos/BridgeAR/node/events","assignees_url":"https://api.github.com/repos/BridgeAR/node/assignees{/user}","branches_url":"https://api.github.com/repos/BridgeAR/node/branches{/branch}","tags_url":"https://api.github.com/repos/BridgeAR/node/tags","blobs_url":"https://api.github.com/repos/BridgeAR/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/BridgeAR/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/BridgeAR/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/BridgeAR/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/BridgeAR/node/statuses/{sha}","languages_url":"https://api.github.com/repos/BridgeAR/node/languages","stargazers_url":"https://api.github.com/repos/BridgeAR/node/stargazers","contributors_url":"https://api.github.com/repos/BridgeAR/node/contributors","subscribers_url":"https://api.github.com/repos/BridgeAR/node/subscribers","subscription_url":"https://api.github.com/repos/BridgeAR/node/subscription","commits_url":"https://api.github.com/repos/BridgeAR/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/BridgeAR/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/BridgeAR/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/BridgeAR/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/BridgeAR/node/contents/{+path}","compare_url":"https://api.github.com/repos/BridgeAR/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/BridgeAR/node/merges","archive_url":"https://api.github.com/repos/BridgeAR/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/BridgeAR/node/downloads","issues_url":"https://api.github.com/repos/BridgeAR/node/issues{/number}","pulls_url":"https://api.github.com/repos/BridgeAR/node/pulls{/number}","milestones_url":"https://api.github.com/repos/BridgeAR/node/milestones{/number}","notifications_url":"https://api.github.com/repos/BridgeAR/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/BridgeAR/node/labels{/name}","releases_url":"https://api.github.com/repos/BridgeAR/node/releases{/id}","deployments_url":"https://api.github.com/repos/BridgeAR/node/deployments","created_at":"2016-02-04T21:41:27Z","updated_at":"2016-02-04T21:41:36Z","pushed_at":"2018-03-11T22:53:18Z","git_url":"git://github.com/BridgeAR/node.git","ssh_url":"git@github.com:BridgeAR/node.git","clone_url":"https://github.com/BridgeAR/node.git","svn_url":"https://github.com/BridgeAR/node","homepage":"https://nodejs.org","size":339874,"stargazers_count":0,"watchers_count":0,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"nodejs:master","ref":"master","sha":"5a55a711505489af7fd75a83b4905afc7468ebec","user":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"repo":{"id":27193779,"name":"node","full_name":"nodejs/node","owner":{"login":"nodejs","id":9950313,"avatar_url":"https://avatars3.githubusercontent.com/u/9950313?v=4","gravatar_id":"","url":"https://api.github.com/users/nodejs","html_url":"https://github.com/nodejs","followers_url":"https://api.github.com/users/nodejs/followers","following_url":"https://api.github.com/users/nodejs/following{/other_user}","gists_url":"https://api.github.com/users/nodejs/gists{/gist_id}","starred_url":"https://api.github.com/users/nodejs/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nodejs/subscriptions","organizations_url":"https://api.github.com/users/nodejs/orgs","repos_url":"https://api.github.com/users/nodejs/repos","events_url":"https://api.github.com/users/nodejs/events{/privacy}","received_events_url":"https://api.github.com/users/nodejs/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/nodejs/node","description":"Node.js JavaScript runtime :sparkles::turtle::rocket::sparkles:","fork":false,"url":"https://api.github.com/repos/nodejs/node","forks_url":"https://api.github.com/repos/nodejs/node/forks","keys_url":"https://api.github.com/repos/nodejs/node/keys{/key_id}","collaborators_url":"https://api.github.com/repos/nodejs/node/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/nodejs/node/teams","hooks_url":"https://api.github.com/repos/nodejs/node/hooks","issue_events_url":"https://api.github.com/repos/nodejs/node/issues/events{/number}","events_url":"https://api.github.com/repos/nodejs/node/events","assignees_url":"https://api.github.com/repos/nodejs/node/assignees{/user}","branches_url":"https://api.github.com/repos/nodejs/node/branches{/branch}","tags_url":"https://api.github.com/repos/nodejs/node/tags","blobs_url":"https://api.github.com/repos/nodejs/node/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/nodejs/node/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/nodejs/node/git/refs{/sha}","trees_url":"https://api.github.com/repos/nodejs/node/git/trees{/sha}","statuses_url":"https://api.github.com/repos/nodejs/node/statuses/{sha}","languages_url":"https://api.github.com/repos/nodejs/node/languages","stargazers_url":"https://api.github.com/repos/nodejs/node/stargazers","contributors_url":"https://api.github.com/repos/nodejs/node/contributors","subscribers_url":"https://api.github.com/repos/nodejs/node/subscribers","subscription_url":"https://api.github.com/repos/nodejs/node/subscription","commits_url":"https://api.github.com/repos/nodejs/node/commits{/sha}","git_commits_url":"https://api.github.com/repos/nodejs/node/git/commits{/sha}","comments_url":"https://api.github.com/repos/nodejs/node/comments{/number}","issue_comment_url":"https://api.github.com/repos/nodejs/node/issues/comments{/number}","contents_url":"https://api.github.com/repos/nodejs/node/contents/{+path}","compare_url":"https://api.github.com/repos/nodejs/node/compare/{base}...{head}","merges_url":"https://api.github.com/repos/nodejs/node/merges","archive_url":"https://api.github.com/repos/nodejs/node/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/nodejs/node/downloads","issues_url":"https://api.github.com/repos/nodejs/node/issues{/number}","pulls_url":"https://api.github.com/repos/nodejs/node/pulls{/number}","milestones_url":"https://api.github.com/repos/nodejs/node/milestones{/number}","notifications_url":"https://api.github.com/repos/nodejs/node/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/nodejs/node/labels{/name}","releases_url":"https://api.github.com/repos/nodejs/node/releases{/id}","deployments_url":"https://api.github.com/repos/nodejs/node/deployments","created_at":"2014-11-26T19:57:11Z","updated_at":"2018-03-11T22:50:01Z","pushed_at":"2018-03-11T22:53:21Z","git_url":"git://github.com/nodejs/node.git","ssh_url":"git@github.com:nodejs/node.git","clone_url":"https://github.com/nodejs/node.git","svn_url":"https://github.com/nodejs/node","homepage":"https://nodejs.org","size":356759,"stargazers_count":46304,"watchers_count":46304,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":9706,"mirror_url":null,"archived":false,"open_issues_count":835,"license":{"key":"other","name":"Other","spdx_id":null,"url":null},"forks":9706,"open_issues":835,"watchers":46304,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/nodejs/node/pulls/19116"},"html":{"href":"https://github.com/nodejs/node/pull/19116"},"issue":{"href":"https://api.github.com/repos/nodejs/node/issues/19116"},"comments":{"href":"https://api.github.com/repos/nodejs/node/issues/19116/comments"},"review_comments":{"href":"https://api.github.com/repos/nodejs/node/pulls/19116/comments"},"review_comment":{"href":"https://api.github.com/repos/nodejs/node/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/nodejs/node/pulls/19116/commits"},"statuses":{"href":"https://api.github.com/repos/nodejs/node/statuses/79c48f5f3f6467b928fe8e5cacbc38c518a9eb4d"}},"author_association":"MEMBER"}}
{"actor":{"display_login":"BridgeAR"}}