{"action":"created","comment":{"url":"https://api.github.com/repos/LLNL/GridDyn/pulls/comments/205659610","pull_request_review_id":140975622,"id":205659610,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIwNTY1OTYxMA==","diff_hunk":"@@ -185,10 +185,8 @@ if(OPENMP_ENABLE)\n   #message(STATUS \"****** finding OpenMP support\")\n   FIND_PACKAGE(OpenMP)\n   if(OPENMP_FOUND)\n-    add_definitions(-DHAVE_OPENMP)\n-\tset(CMAKE_C_FLAGS \"${CMAKE_C_FLAGS} ${OpenMP_C_FLAGS}\")\n-    set(CMAKE_CXX_FLAGS \"${CMAKE_CDD_FLAGS} ${OpenMP_CXX_FLAGS}\")\n-    set(CMAKE_EXE_LINKER_FLAGS \"${CMAKE_EXE_LINKER_FLAGS} ${OpenMP_EXE_LINKER_FLAGS}\")\n+    add_compile_options($<$<COMPILE_LANGUAGE:C>:${OpenMP_C_FLAGS}> $<$<COMPILE_LANGUAGE:CXX>:${OpenMP_CXX_FLAGS}>)\n+    link_libraries(-fopenmp)","path":"CMakeLists.txt","position":9,"original_position":9,"commit_id":"098c3b4ac639a2afcad071b9fbb8f6c00cbd9885","original_commit_id":"098c3b4ac639a2afcad071b9fbb8f6c00cbd9885","user":{"login":"phlptp","id":20667153,"node_id":"MDQ6VXNlcjIwNjY3MTUz","avatar_url":"https://avatars0.githubusercontent.com/u/20667153?v=4","gravatar_id":"","url":"https://api.github.com/users/phlptp","html_url":"https://github.com/phlptp","followers_url":"https://api.github.com/users/phlptp/followers","following_url":"https://api.github.com/users/phlptp/following{/other_user}","gists_url":"https://api.github.com/users/phlptp/gists{/gist_id}","starred_url":"https://api.github.com/users/phlptp/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/phlptp/subscriptions","organizations_url":"https://api.github.com/users/phlptp/orgs","repos_url":"https://api.github.com/users/phlptp/repos","events_url":"https://api.github.com/users/phlptp/events{/privacy}","received_events_url":"https://api.github.com/users/phlptp/received_events","type":"User","site_admin":false},"body":"I think the better way of doing this is a check if CMAKE>3.9 and if so use the target otherwise we will need to set the flags","created_at":"2018-07-27T03:37:30Z","updated_at":"2018-07-27T03:37:30Z","html_url":"https://github.com/LLNL/GridDyn/pull/34#discussion_r205659610","pull_request_url":"https://api.github.com/repos/LLNL/GridDyn/pulls/34","author_association":"COLLABORATOR","_links":{"self":{"href":"https://api.github.com/repos/LLNL/GridDyn/pulls/comments/205659610"},"html":{"href":"https://github.com/LLNL/GridDyn/pull/34#discussion_r205659610"},"pull_request":{"href":"https://api.github.com/repos/LLNL/GridDyn/pulls/34"}},"in_reply_to_id":205659116},"pull_request":{"url":"https://api.github.com/repos/LLNL/GridDyn/pulls/34","id":204301515,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA0MzAxNTE1","html_url":"https://github.com/LLNL/GridDyn/pull/34","diff_url":"https://github.com/LLNL/GridDyn/pull/34.diff","patch_url":"https://github.com/LLNL/GridDyn/pull/34.patch","issue_url":"https://api.github.com/repos/LLNL/GridDyn/issues/34","number":34,"state":"open","locked":false,"title":"Fix OpenMP CXX_FLAGS bug and clean-up OPENMP definitions","user":{"login":"nightlark","id":3969255,"node_id":"MDQ6VXNlcjM5NjkyNTU=","avatar_url":"https://avatars3.githubusercontent.com/u/3969255?v=4","gravatar_id":"","url":"https://api.github.com/users/nightlark","html_url":"https://github.com/nightlark","followers_url":"https://api.github.com/users/nightlark/followers","following_url":"https://api.github.com/users/nightlark/following{/other_user}","gists_url":"https://api.github.com/users/nightlark/gists{/gist_id}","starred_url":"https://api.github.com/users/nightlark/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/nightlark/subscriptions","organizations_url":"https://api.github.com/users/nightlark/orgs","repos_url":"https://api.github.com/users/nightlark/repos","events_url":"https://api.github.com/users/nightlark/events{/privacy}","received_events_url":"https://api.github.com/users/nightlark/received_events","type":"User","site_admin":false},"body":"* Show results from multiple valgrind runs in a single CI build\r\n* Fix handling of OpenMP compiler/linker flags\r\n* Replace HAVE_OPENMP with GRIDDYN/SUNDIALS_OPENMP definitions from griddyn-config header","created_at":"2018-07-27T00:33:23Z","updated_at":"2018-07-27T03:37:30Z","closed_at":null,"merged_at":null,"merge_commit_sha":"adb558728529c6484973671dc23c9f55f9a62f14","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/LLNL/GridDyn/pulls/34/commits","review_comments_url":"https://api.github.com/repos/LLNL/GridDyn/pulls/34/comments","review_comment_url":"https://api.github.com/repos/LLNL/GridDyn/pulls/comments{/number}","comments_url":"https://api.github.com/repos/LLNL/GridDyn/issues/34/comments","statuses_url":"https://api.github.com/repos/LLNL/GridDyn/statuses/098c3b4ac639a2afcad071b9fbb8f6c00cbd9885","head":{"label":"LLNL:update-valgrind-test","ref":"update-valgrind-test","sha":"098c3b4ac639a2afcad071b9fbb8f6c00cbd9885","user":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":65496620,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQ5NjYyMA==","name":"GridDyn","full_name":"LLNL/GridDyn","owner":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/GridDyn","description":"GridDyn is an open-source power transmission simulation software package","fork":false,"url":"https://api.github.com/repos/LLNL/GridDyn","forks_url":"https://api.github.com/repos/LLNL/GridDyn/forks","keys_url":"https://api.github.com/repos/LLNL/GridDyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/GridDyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/GridDyn/teams","hooks_url":"https://api.github.com/repos/LLNL/GridDyn/hooks","issue_events_url":"https://api.github.com/repos/LLNL/GridDyn/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/GridDyn/events","assignees_url":"https://api.github.com/repos/LLNL/GridDyn/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/GridDyn/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/GridDyn/tags","blobs_url":"https://api.github.com/repos/LLNL/GridDyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/GridDyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/GridDyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/GridDyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/GridDyn/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/GridDyn/languages","stargazers_url":"https://api.github.com/repos/LLNL/GridDyn/stargazers","contributors_url":"https://api.github.com/repos/LLNL/GridDyn/contributors","subscribers_url":"https://api.github.com/repos/LLNL/GridDyn/subscribers","subscription_url":"https://api.github.com/repos/LLNL/GridDyn/subscription","commits_url":"https://api.github.com/repos/LLNL/GridDyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/GridDyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/GridDyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/GridDyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/GridDyn/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/GridDyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/GridDyn/merges","archive_url":"https://api.github.com/repos/LLNL/GridDyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/GridDyn/downloads","issues_url":"https://api.github.com/repos/LLNL/GridDyn/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/GridDyn/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/GridDyn/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/GridDyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/GridDyn/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/GridDyn/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/GridDyn/deployments","created_at":"2016-08-11T19:40:08Z","updated_at":"2018-01-05T21:14:07Z","pushed_at":"2018-07-27T00:33:24Z","git_url":"git://github.com/LLNL/GridDyn.git","ssh_url":"git@github.com:LLNL/GridDyn.git","clone_url":"https://github.com/LLNL/GridDyn.git","svn_url":"https://github.com/LLNL/GridDyn","homepage":null,"size":47065,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":6,"watchers":16,"default_branch":"master"}},"base":{"label":"LLNL:cmake_update","ref":"cmake_update","sha":"64035ae23683d7ba53f8913fa35f727baca6842d","user":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"repo":{"id":65496620,"node_id":"MDEwOlJlcG9zaXRvcnk2NTQ5NjYyMA==","name":"GridDyn","full_name":"LLNL/GridDyn","owner":{"login":"LLNL","id":5921419,"node_id":"MDEyOk9yZ2FuaXphdGlvbjU5MjE0MTk=","avatar_url":"https://avatars0.githubusercontent.com/u/5921419?v=4","gravatar_id":"","url":"https://api.github.com/users/LLNL","html_url":"https://github.com/LLNL","followers_url":"https://api.github.com/users/LLNL/followers","following_url":"https://api.github.com/users/LLNL/following{/other_user}","gists_url":"https://api.github.com/users/LLNL/gists{/gist_id}","starred_url":"https://api.github.com/users/LLNL/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LLNL/subscriptions","organizations_url":"https://api.github.com/users/LLNL/orgs","repos_url":"https://api.github.com/users/LLNL/repos","events_url":"https://api.github.com/users/LLNL/events{/privacy}","received_events_url":"https://api.github.com/users/LLNL/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/LLNL/GridDyn","description":"GridDyn is an open-source power transmission simulation software package","fork":false,"url":"https://api.github.com/repos/LLNL/GridDyn","forks_url":"https://api.github.com/repos/LLNL/GridDyn/forks","keys_url":"https://api.github.com/repos/LLNL/GridDyn/keys{/key_id}","collaborators_url":"https://api.github.com/repos/LLNL/GridDyn/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/LLNL/GridDyn/teams","hooks_url":"https://api.github.com/repos/LLNL/GridDyn/hooks","issue_events_url":"https://api.github.com/repos/LLNL/GridDyn/issues/events{/number}","events_url":"https://api.github.com/repos/LLNL/GridDyn/events","assignees_url":"https://api.github.com/repos/LLNL/GridDyn/assignees{/user}","branches_url":"https://api.github.com/repos/LLNL/GridDyn/branches{/branch}","tags_url":"https://api.github.com/repos/LLNL/GridDyn/tags","blobs_url":"https://api.github.com/repos/LLNL/GridDyn/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/LLNL/GridDyn/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/LLNL/GridDyn/git/refs{/sha}","trees_url":"https://api.github.com/repos/LLNL/GridDyn/git/trees{/sha}","statuses_url":"https://api.github.com/repos/LLNL/GridDyn/statuses/{sha}","languages_url":"https://api.github.com/repos/LLNL/GridDyn/languages","stargazers_url":"https://api.github.com/repos/LLNL/GridDyn/stargazers","contributors_url":"https://api.github.com/repos/LLNL/GridDyn/contributors","subscribers_url":"https://api.github.com/repos/LLNL/GridDyn/subscribers","subscription_url":"https://api.github.com/repos/LLNL/GridDyn/subscription","commits_url":"https://api.github.com/repos/LLNL/GridDyn/commits{/sha}","git_commits_url":"https://api.github.com/repos/LLNL/GridDyn/git/commits{/sha}","comments_url":"https://api.github.com/repos/LLNL/GridDyn/comments{/number}","issue_comment_url":"https://api.github.com/repos/LLNL/GridDyn/issues/comments{/number}","contents_url":"https://api.github.com/repos/LLNL/GridDyn/contents/{+path}","compare_url":"https://api.github.com/repos/LLNL/GridDyn/compare/{base}...{head}","merges_url":"https://api.github.com/repos/LLNL/GridDyn/merges","archive_url":"https://api.github.com/repos/LLNL/GridDyn/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/LLNL/GridDyn/downloads","issues_url":"https://api.github.com/repos/LLNL/GridDyn/issues{/number}","pulls_url":"https://api.github.com/repos/LLNL/GridDyn/pulls{/number}","milestones_url":"https://api.github.com/repos/LLNL/GridDyn/milestones{/number}","notifications_url":"https://api.github.com/repos/LLNL/GridDyn/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/LLNL/GridDyn/labels{/name}","releases_url":"https://api.github.com/repos/LLNL/GridDyn/releases{/id}","deployments_url":"https://api.github.com/repos/LLNL/GridDyn/deployments","created_at":"2016-08-11T19:40:08Z","updated_at":"2018-01-05T21:14:07Z","pushed_at":"2018-07-27T00:33:24Z","git_url":"git://github.com/LLNL/GridDyn.git","ssh_url":"git@github.com:LLNL/GridDyn.git","clone_url":"https://github.com/LLNL/GridDyn.git","svn_url":"https://github.com/LLNL/GridDyn","homepage":null,"size":47065,"stargazers_count":16,"watchers_count":16,"language":"C++","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":10,"mirror_url":null,"archived":false,"open_issues_count":6,"license":{"key":"other","name":"Other","spdx_id":null,"url":null,"node_id":"MDc6TGljZW5zZTA="},"forks":10,"open_issues":6,"watchers":16,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/LLNL/GridDyn/pulls/34"},"html":{"href":"https://github.com/LLNL/GridDyn/pull/34"},"issue":{"href":"https://api.github.com/repos/LLNL/GridDyn/issues/34"},"comments":{"href":"https://api.github.com/repos/LLNL/GridDyn/issues/34/comments"},"review_comments":{"href":"https://api.github.com/repos/LLNL/GridDyn/pulls/34/comments"},"review_comment":{"href":"https://api.github.com/repos/LLNL/GridDyn/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/LLNL/GridDyn/pulls/34/commits"},"statuses":{"href":"https://api.github.com/repos/LLNL/GridDyn/statuses/098c3b4ac639a2afcad071b9fbb8f6c00cbd9885"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"phlptp"}}