{"action":"created","issue":{"url":"https://api.github.com/repos/enthought/traits/issues/419","repository_url":"https://api.github.com/repos/enthought/traits","labels_url":"https://api.github.com/repos/enthought/traits/issues/419/labels{/name}","comments_url":"https://api.github.com/repos/enthought/traits/issues/419/comments","events_url":"https://api.github.com/repos/enthought/traits/issues/419/events","html_url":"https://github.com/enthought/traits/pull/419","id":389404626,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM3NDAxOTE2","number":419,"title":"HasRequiredTraits class","user":{"login":"jjenthought","id":39727845,"node_id":"MDQ6VXNlcjM5NzI3ODQ1","avatar_url":"https://avatars2.githubusercontent.com/u/39727845?v=4","gravatar_id":"","url":"https://api.github.com/users/jjenthought","html_url":"https://github.com/jjenthought","followers_url":"https://api.github.com/users/jjenthought/followers","following_url":"https://api.github.com/users/jjenthought/following{/other_user}","gists_url":"https://api.github.com/users/jjenthought/gists{/gist_id}","starred_url":"https://api.github.com/users/jjenthought/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jjenthought/subscriptions","organizations_url":"https://api.github.com/users/jjenthought/orgs","repos_url":"https://api.github.com/users/jjenthought/repos","events_url":"https://api.github.com/users/jjenthought/events{/privacy}","received_events_url":"https://api.github.com/users/jjenthought/received_events","type":"User","site_admin":false},"labels":[{"id":76537,"node_id":"MDU6TGFiZWw3NjUzNw==","url":"https://api.github.com/repos/enthought/traits/labels/enhancements","name":"enhancements","color":"02d7e1","default":false},{"id":135287549,"node_id":"MDU6TGFiZWwxMzUyODc1NDk=","url":"https://api.github.com/repos/enthought/traits/labels/in%20progress","name":"in progress","color":"ededed","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-12-10T17:21:58Z","updated_at":"2018-12-10T17:31:32Z","closed_at":null,"author_association":"NONE","pull_request":{"url":"https://api.github.com/repos/enthought/traits/pulls/419","html_url":"https://github.com/enthought/traits/pull/419","diff_url":"https://github.com/enthought/traits/pull/419.diff","patch_url":"https://github.com/enthought/traits/pull/419.patch"},"body":"From the docstring: This class builds on the functionality of HasStrictTraits and ensures that any object attribute with the metadata required=True must be passed as an argument on object initialization.\r\n\r\nThis came up as there were situations where a class had a few 'key' traits and the others were derived from them. It made sense to try and provide a more formal implementation of this pattern!\r\n\r\nThings that I'm not sure about:\r\n- What else to test for\r\n- Whether using TraitError is appropriate (It doesn't really use any of the extra functionality TraitError provides)\r\n\r\n"},"comment":{"url":"https://api.github.com/repos/enthought/traits/issues/comments/445901480","html_url":"https://github.com/enthought/traits/pull/419#issuecomment-445901480","issue_url":"https://api.github.com/repos/enthought/traits/issues/419","id":445901480,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0NTkwMTQ4MA==","user":{"login":"mdickinson","id":662003,"node_id":"MDQ6VXNlcjY2MjAwMw==","avatar_url":"https://avatars3.githubusercontent.com/u/662003?v=4","gravatar_id":"","url":"https://api.github.com/users/mdickinson","html_url":"https://github.com/mdickinson","followers_url":"https://api.github.com/users/mdickinson/followers","following_url":"https://api.github.com/users/mdickinson/following{/other_user}","gists_url":"https://api.github.com/users/mdickinson/gists{/gist_id}","starred_url":"https://api.github.com/users/mdickinson/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mdickinson/subscriptions","organizations_url":"https://api.github.com/users/mdickinson/orgs","repos_url":"https://api.github.com/users/mdickinson/repos","events_url":"https://api.github.com/users/mdickinson/events{/privacy}","received_events_url":"https://api.github.com/users/mdickinson/received_events","type":"User","site_admin":false},"created_at":"2018-12-10T17:31:32Z","updated_at":"2018-12-10T17:31:32Z","author_association":"MEMBER","body":"This is great; thank you!\r\n\r\nWhat would be really useful would be to also have documentation on this. I think the right place for that would be in https://github.com/enthought/traits/blob/master/docs/source/traits_user_manual/advanced.rst\r\n\r\nWould you be up to writing some documentation for this?"}}
{"actor":{"display_login":"mdickinson"}}