{"action":"closed","number":3462,"pull_request":{"url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3462","id":208729849,"node_id":"MDExOlB1bGxSZXF1ZXN0MjA4NzI5ODQ5","html_url":"https://github.com/wildfly/wildfly-core/pull/3462","diff_url":"https://github.com/wildfly/wildfly-core/pull/3462.diff","patch_url":"https://github.com/wildfly/wildfly-core/pull/3462.patch","issue_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3462","number":3462,"state":"closed","locked":false,"title":"[WFCORE-4040] Deprecate PersistentResourceDefinition.Parameters, remo…","user":{"login":"bstansberry","id":299242,"node_id":"MDQ6VXNlcjI5OTI0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/299242?v=4","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"body":"…ve its use in core\r\n\r\nhttps://issues.jboss.org/browse/WFCORE-4040\r\n\r\nThe main point is having the PersistentResourceDefinition constructor accept SimpleResourceDefinition.Parameters, removing any need to use the inconvenient subclass.","created_at":"2018-08-16T02:31:01Z","updated_at":"2018-08-21T13:55:29Z","closed_at":"2018-08-21T13:55:29Z","merged_at":"2018-08-21T13:55:29Z","merge_commit_sha":"79e4a8acc55b4f38bd4fd0ebbe43b5a842d3f70b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3462/commits","review_comments_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3462/comments","review_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/3462/comments","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/a20cdbbc04c7f7307db248546e5061d5d37165d5","head":{"label":"bstansberry:WFCORE-4040","ref":"WFCORE-4040","sha":"a20cdbbc04c7f7307db248546e5061d5d37165d5","user":{"login":"bstansberry","id":299242,"node_id":"MDQ6VXNlcjI5OTI0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/299242?v=4","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"repo":{"id":21433119,"node_id":"MDEwOlJlcG9zaXRvcnkyMTQzMzExOQ==","name":"wildfly-core","full_name":"bstansberry/wildfly-core","owner":{"login":"bstansberry","id":299242,"node_id":"MDQ6VXNlcjI5OTI0Mg==","avatar_url":"https://avatars1.githubusercontent.com/u/299242?v=4","gravatar_id":"","url":"https://api.github.com/users/bstansberry","html_url":"https://github.com/bstansberry","followers_url":"https://api.github.com/users/bstansberry/followers","following_url":"https://api.github.com/users/bstansberry/following{/other_user}","gists_url":"https://api.github.com/users/bstansberry/gists{/gist_id}","starred_url":"https://api.github.com/users/bstansberry/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/bstansberry/subscriptions","organizations_url":"https://api.github.com/users/bstansberry/orgs","repos_url":"https://api.github.com/users/bstansberry/repos","events_url":"https://api.github.com/users/bstansberry/events{/privacy}","received_events_url":"https://api.github.com/users/bstansberry/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/bstansberry/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":true,"url":"https://api.github.com/repos/bstansberry/wildfly-core","forks_url":"https://api.github.com/repos/bstansberry/wildfly-core/forks","keys_url":"https://api.github.com/repos/bstansberry/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/bstansberry/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/bstansberry/wildfly-core/teams","hooks_url":"https://api.github.com/repos/bstansberry/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/bstansberry/wildfly-core/events","assignees_url":"https://api.github.com/repos/bstansberry/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/bstansberry/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/bstansberry/wildfly-core/tags","blobs_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/bstansberry/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/bstansberry/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/bstansberry/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/bstansberry/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/bstansberry/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/bstansberry/wildfly-core/subscription","commits_url":"https://api.github.com/repos/bstansberry/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/bstansberry/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/bstansberry/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/bstansberry/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/bstansberry/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/bstansberry/wildfly-core/merges","archive_url":"https://api.github.com/repos/bstansberry/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/bstansberry/wildfly-core/downloads","issues_url":"https://api.github.com/repos/bstansberry/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/bstansberry/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/bstansberry/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/bstansberry/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/bstansberry/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/bstansberry/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/bstansberry/wildfly-core/deployments","created_at":"2014-07-02T17:20:55Z","updated_at":"2018-08-16T01:54:45Z","pushed_at":"2018-08-16T02:29:11Z","git_url":"git://github.com/bstansberry/wildfly-core.git","ssh_url":"git@github.com:bstansberry/wildfly-core.git","clone_url":"https://github.com/bstansberry/wildfly-core.git","svn_url":"https://github.com/bstansberry/wildfly-core","homepage":null,"size":70222,"stargazers_count":0,"watchers_count":0,"language":"Java","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"wildfly:master","ref":"master","sha":"3993d0e2878c042d2fdc5e7870b4604b01648b90","user":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"repo":{"id":21394954,"node_id":"MDEwOlJlcG9zaXRvcnkyMTM5NDk1NA==","name":"wildfly-core","full_name":"wildfly/wildfly-core","owner":{"login":"wildfly","id":3066274,"node_id":"MDEyOk9yZ2FuaXphdGlvbjMwNjYyNzQ=","avatar_url":"https://avatars2.githubusercontent.com/u/3066274?v=4","gravatar_id":"","url":"https://api.github.com/users/wildfly","html_url":"https://github.com/wildfly","followers_url":"https://api.github.com/users/wildfly/followers","following_url":"https://api.github.com/users/wildfly/following{/other_user}","gists_url":"https://api.github.com/users/wildfly/gists{/gist_id}","starred_url":"https://api.github.com/users/wildfly/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/wildfly/subscriptions","organizations_url":"https://api.github.com/users/wildfly/orgs","repos_url":"https://api.github.com/users/wildfly/repos","events_url":"https://api.github.com/users/wildfly/events{/privacy}","received_events_url":"https://api.github.com/users/wildfly/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/wildfly/wildfly-core","description":"The core runtime that is used by the Wildfly application server","fork":false,"url":"https://api.github.com/repos/wildfly/wildfly-core","forks_url":"https://api.github.com/repos/wildfly/wildfly-core/forks","keys_url":"https://api.github.com/repos/wildfly/wildfly-core/keys{/key_id}","collaborators_url":"https://api.github.com/repos/wildfly/wildfly-core/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/wildfly/wildfly-core/teams","hooks_url":"https://api.github.com/repos/wildfly/wildfly-core/hooks","issue_events_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/events{/number}","events_url":"https://api.github.com/repos/wildfly/wildfly-core/events","assignees_url":"https://api.github.com/repos/wildfly/wildfly-core/assignees{/user}","branches_url":"https://api.github.com/repos/wildfly/wildfly-core/branches{/branch}","tags_url":"https://api.github.com/repos/wildfly/wildfly-core/tags","blobs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/wildfly/wildfly-core/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/wildfly/wildfly-core/git/refs{/sha}","trees_url":"https://api.github.com/repos/wildfly/wildfly-core/git/trees{/sha}","statuses_url":"https://api.github.com/repos/wildfly/wildfly-core/statuses/{sha}","languages_url":"https://api.github.com/repos/wildfly/wildfly-core/languages","stargazers_url":"https://api.github.com/repos/wildfly/wildfly-core/stargazers","contributors_url":"https://api.github.com/repos/wildfly/wildfly-core/contributors","subscribers_url":"https://api.github.com/repos/wildfly/wildfly-core/subscribers","subscription_url":"https://api.github.com/repos/wildfly/wildfly-core/subscription","commits_url":"https://api.github.com/repos/wildfly/wildfly-core/commits{/sha}","git_commits_url":"https://api.github.com/repos/wildfly/wildfly-core/git/commits{/sha}","comments_url":"https://api.github.com/repos/wildfly/wildfly-core/comments{/number}","issue_comment_url":"https://api.github.com/repos/wildfly/wildfly-core/issues/comments{/number}","contents_url":"https://api.github.com/repos/wildfly/wildfly-core/contents/{+path}","compare_url":"https://api.github.com/repos/wildfly/wildfly-core/compare/{base}...{head}","merges_url":"https://api.github.com/repos/wildfly/wildfly-core/merges","archive_url":"https://api.github.com/repos/wildfly/wildfly-core/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/wildfly/wildfly-core/downloads","issues_url":"https://api.github.com/repos/wildfly/wildfly-core/issues{/number}","pulls_url":"https://api.github.com/repos/wildfly/wildfly-core/pulls{/number}","milestones_url":"https://api.github.com/repos/wildfly/wildfly-core/milestones{/number}","notifications_url":"https://api.github.com/repos/wildfly/wildfly-core/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/wildfly/wildfly-core/labels{/name}","releases_url":"https://api.github.com/repos/wildfly/wildfly-core/releases{/id}","deployments_url":"https://api.github.com/repos/wildfly/wildfly-core/deployments","created_at":"2014-07-01T16:33:34Z","updated_at":"2018-08-21T13:54:00Z","pushed_at":"2018-08-21T13:55:29Z","git_url":"git://github.com/wildfly/wildfly-core.git","ssh_url":"git@github.com:wildfly/wildfly-core.git","clone_url":"https://github.com/wildfly/wildfly-core.git","svn_url":"https://github.com/wildfly/wildfly-core","homepage":null,"size":72390,"stargazers_count":98,"watchers_count":98,"language":"Java","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":329,"mirror_url":null,"archived":false,"open_issues_count":37,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1","node_id":"MDc6TGljZW5zZTEx"},"forks":329,"open_issues":37,"watchers":98,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3462"},"html":{"href":"https://github.com/wildfly/wildfly-core/pull/3462"},"issue":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/3462"},"comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/issues/3462/comments"},"review_comments":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3462/comments"},"review_comment":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/wildfly/wildfly-core/pulls/3462/commits"},"statuses":{"href":"https://api.github.com/repos/wildfly/wildfly-core/statuses/a20cdbbc04c7f7307db248546e5061d5d37165d5"}},"author_association":"CONTRIBUTOR","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"kabir","id":49927,"node_id":"MDQ6VXNlcjQ5OTI3","avatar_url":"https://avatars1.githubusercontent.com/u/49927?v=4","gravatar_id":"","url":"https://api.github.com/users/kabir","html_url":"https://github.com/kabir","followers_url":"https://api.github.com/users/kabir/followers","following_url":"https://api.github.com/users/kabir/following{/other_user}","gists_url":"https://api.github.com/users/kabir/gists{/gist_id}","starred_url":"https://api.github.com/users/kabir/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kabir/subscriptions","organizations_url":"https://api.github.com/users/kabir/orgs","repos_url":"https://api.github.com/users/kabir/repos","events_url":"https://api.github.com/users/kabir/events{/privacy}","received_events_url":"https://api.github.com/users/kabir/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":25,"deletions":16,"changed_files":6}}
{"actor":{"display_login":"kabir"}}