{"action":"created","comment":{"url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/comments/233993095","pull_request_review_id":175537326,"id":233993095,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIzMzk5MzA5NQ==","diff_hunk":"@@ -0,0 +1,73 @@\n+import json\n+import matplotlib.pyplot as plt\n+import numpy as np\n+import sys\n+\n+\n+\n+tx_samples_file = sys.argv[1]\n+bf_iq_samples = sys.argv[2]\n+\n+with open(tx_samples_file, 'r') as f:\n+    tx_samples = json.load(f)\n+\n+with open(bf_iq_samples, 'r') as f:\n+    bf_iq = json.load(f)\n+\n+\n+main_beams = []\n+for dsetk, dsetv in bf_iq.iteritems():\n+    for beamk, beamv in dsetv.iteritems():\n+        main_data = beamv['main']\n+\n+        real = main_data['real']\n+        imag = main_data['imag']\n+\n+        cmplx = np.array(real) + 1.0j*np.array(imag)\n+        main_beams.append(cmplx)\n+\n+main_beams = np.array(main_beams)\n+\n+\n+phases = []\n+ant_samples = []\n+for samplek, samplev in tx_samples.iteritems():","path":"testing/dsp_testing/test_beamforming.py","position":null,"original_position":34,"commit_id":"d540a62cbd0321a4ff24fce4a39fd58af54d312a","original_commit_id":"7cd86230454bfda1bb477d03ca5bd6ef481bb825","user":{"login":"kevinkrieger","id":5935875,"node_id":"MDQ6VXNlcjU5MzU4NzU=","avatar_url":"https://avatars1.githubusercontent.com/u/5935875?v=4","gravatar_id":"","url":"https://api.github.com/users/kevinkrieger","html_url":"https://github.com/kevinkrieger","followers_url":"https://api.github.com/users/kevinkrieger/followers","following_url":"https://api.github.com/users/kevinkrieger/following{/other_user}","gists_url":"https://api.github.com/users/kevinkrieger/gists{/gist_id}","starred_url":"https://api.github.com/users/kevinkrieger/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kevinkrieger/subscriptions","organizations_url":"https://api.github.com/users/kevinkrieger/orgs","repos_url":"https://api.github.com/users/kevinkrieger/repos","events_url":"https://api.github.com/users/kevinkrieger/events{/privacy}","received_events_url":"https://api.github.com/users/kevinkrieger/received_events","type":"User","site_admin":false},"body":"ignoring for now","created_at":"2018-11-15T20:16:43Z","updated_at":"2018-11-15T20:16:44Z","html_url":"https://github.com/SuperDARNCanada/borealis/pull/39#discussion_r233993095","pull_request_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/39","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/comments/233993095"},"html":{"href":"https://github.com/SuperDARNCanada/borealis/pull/39#discussion_r233993095"},"pull_request":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/39"}},"in_reply_to_id":232077789},"pull_request":{"url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/39","id":226634547,"node_id":"MDExOlB1bGxSZXF1ZXN0MjI2NjM0NTQ3","html_url":"https://github.com/SuperDARNCanada/borealis/pull/39","diff_url":"https://github.com/SuperDARNCanada/borealis/pull/39.diff","patch_url":"https://github.com/SuperDARNCanada/borealis/pull/39.patch","issue_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/39","number":39,"state":"open","locked":false,"title":"Testing bug fixes","user":{"login":"mardet987","id":19413948,"node_id":"MDQ6VXNlcjE5NDEzOTQ4","avatar_url":"https://avatars0.githubusercontent.com/u/19413948?v=4","gravatar_id":"","url":"https://api.github.com/users/mardet987","html_url":"https://github.com/mardet987","followers_url":"https://api.github.com/users/mardet987/followers","following_url":"https://api.github.com/users/mardet987/following{/other_user}","gists_url":"https://api.github.com/users/mardet987/gists{/gist_id}","starred_url":"https://api.github.com/users/mardet987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mardet987/subscriptions","organizations_url":"https://api.github.com/users/mardet987/orgs","repos_url":"https://api.github.com/users/mardet987/repos","events_url":"https://api.github.com/users/mardet987/events{/privacy}","received_events_url":"https://api.github.com/users/mardet987/received_events","type":"User","site_admin":false},"body":"This is a big PR, sorry \r\n\r\nProbably the best way to look at this would be commit by commit because there are multiple changes and they are not all related","created_at":"2018-10-29T16:46:52Z","updated_at":"2018-11-15T20:16:44Z","closed_at":null,"merged_at":null,"merge_commit_sha":"676f031861d0c105f4d2dc1e1ff20e18d8409d09","assignee":{"login":"kkotyk","id":7105882,"node_id":"MDQ6VXNlcjcxMDU4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/7105882?v=4","gravatar_id":"","url":"https://api.github.com/users/kkotyk","html_url":"https://github.com/kkotyk","followers_url":"https://api.github.com/users/kkotyk/followers","following_url":"https://api.github.com/users/kkotyk/following{/other_user}","gists_url":"https://api.github.com/users/kkotyk/gists{/gist_id}","starred_url":"https://api.github.com/users/kkotyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkotyk/subscriptions","organizations_url":"https://api.github.com/users/kkotyk/orgs","repos_url":"https://api.github.com/users/kkotyk/repos","events_url":"https://api.github.com/users/kkotyk/events{/privacy}","received_events_url":"https://api.github.com/users/kkotyk/received_events","type":"User","site_admin":false},"assignees":[{"login":"kkotyk","id":7105882,"node_id":"MDQ6VXNlcjcxMDU4ODI=","avatar_url":"https://avatars0.githubusercontent.com/u/7105882?v=4","gravatar_id":"","url":"https://api.github.com/users/kkotyk","html_url":"https://github.com/kkotyk","followers_url":"https://api.github.com/users/kkotyk/followers","following_url":"https://api.github.com/users/kkotyk/following{/other_user}","gists_url":"https://api.github.com/users/kkotyk/gists{/gist_id}","starred_url":"https://api.github.com/users/kkotyk/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/kkotyk/subscriptions","organizations_url":"https://api.github.com/users/kkotyk/orgs","repos_url":"https://api.github.com/users/kkotyk/repos","events_url":"https://api.github.com/users/kkotyk/events{/privacy}","received_events_url":"https://api.github.com/users/kkotyk/received_events","type":"User","site_admin":false},{"login":"mardet987","id":19413948,"node_id":"MDQ6VXNlcjE5NDEzOTQ4","avatar_url":"https://avatars0.githubusercontent.com/u/19413948?v=4","gravatar_id":"","url":"https://api.github.com/users/mardet987","html_url":"https://github.com/mardet987","followers_url":"https://api.github.com/users/mardet987/followers","following_url":"https://api.github.com/users/mardet987/following{/other_user}","gists_url":"https://api.github.com/users/mardet987/gists{/gist_id}","starred_url":"https://api.github.com/users/mardet987/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/mardet987/subscriptions","organizations_url":"https://api.github.com/users/mardet987/orgs","repos_url":"https://api.github.com/users/mardet987/repos","events_url":"https://api.github.com/users/mardet987/events{/privacy}","received_events_url":"https://api.github.com/users/mardet987/received_events","type":"User","site_admin":false}],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/39/commits","review_comments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/39/comments","review_comment_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/comments{/number}","comments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/39/comments","statuses_url":"https://api.github.com/repos/SuperDARNCanada/borealis/statuses/d540a62cbd0321a4ff24fce4a39fd58af54d312a","head":{"label":"SuperDARNCanada:testing_bug_fixes","ref":"testing_bug_fixes","sha":"d540a62cbd0321a4ff24fce4a39fd58af54d312a","user":{"login":"SuperDARNCanada","id":19173794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTczNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/19173794?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperDARNCanada","html_url":"https://github.com/SuperDARNCanada","followers_url":"https://api.github.com/users/SuperDARNCanada/followers","following_url":"https://api.github.com/users/SuperDARNCanada/following{/other_user}","gists_url":"https://api.github.com/users/SuperDARNCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperDARNCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperDARNCanada/subscriptions","organizations_url":"https://api.github.com/users/SuperDARNCanada/orgs","repos_url":"https://api.github.com/users/SuperDARNCanada/repos","events_url":"https://api.github.com/users/SuperDARNCanada/events{/privacy}","received_events_url":"https://api.github.com/users/SuperDARNCanada/received_events","type":"Organization","site_admin":false},"repo":{"id":68139909,"node_id":"MDEwOlJlcG9zaXRvcnk2ODEzOTkwOQ==","name":"borealis","full_name":"SuperDARNCanada/borealis","private":false,"owner":{"login":"SuperDARNCanada","id":19173794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTczNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/19173794?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperDARNCanada","html_url":"https://github.com/SuperDARNCanada","followers_url":"https://api.github.com/users/SuperDARNCanada/followers","following_url":"https://api.github.com/users/SuperDARNCanada/following{/other_user}","gists_url":"https://api.github.com/users/SuperDARNCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperDARNCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperDARNCanada/subscriptions","organizations_url":"https://api.github.com/users/SuperDARNCanada/orgs","repos_url":"https://api.github.com/users/SuperDARNCanada/repos","events_url":"https://api.github.com/users/SuperDARNCanada/events{/privacy}","received_events_url":"https://api.github.com/users/SuperDARNCanada/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SuperDARNCanada/borealis","description":"A control system for USRP based digital radars","fork":false,"url":"https://api.github.com/repos/SuperDARNCanada/borealis","forks_url":"https://api.github.com/repos/SuperDARNCanada/borealis/forks","keys_url":"https://api.github.com/repos/SuperDARNCanada/borealis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperDARNCanada/borealis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperDARNCanada/borealis/teams","hooks_url":"https://api.github.com/repos/SuperDARNCanada/borealis/hooks","issue_events_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/events{/number}","events_url":"https://api.github.com/repos/SuperDARNCanada/borealis/events","assignees_url":"https://api.github.com/repos/SuperDARNCanada/borealis/assignees{/user}","branches_url":"https://api.github.com/repos/SuperDARNCanada/borealis/branches{/branch}","tags_url":"https://api.github.com/repos/SuperDARNCanada/borealis/tags","blobs_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperDARNCanada/borealis/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperDARNCanada/borealis/languages","stargazers_url":"https://api.github.com/repos/SuperDARNCanada/borealis/stargazers","contributors_url":"https://api.github.com/repos/SuperDARNCanada/borealis/contributors","subscribers_url":"https://api.github.com/repos/SuperDARNCanada/borealis/subscribers","subscription_url":"https://api.github.com/repos/SuperDARNCanada/borealis/subscription","commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperDARNCanada/borealis/contents/{+path}","compare_url":"https://api.github.com/repos/SuperDARNCanada/borealis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperDARNCanada/borealis/merges","archive_url":"https://api.github.com/repos/SuperDARNCanada/borealis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperDARNCanada/borealis/downloads","issues_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues{/number}","pulls_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperDARNCanada/borealis/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperDARNCanada/borealis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperDARNCanada/borealis/labels{/name}","releases_url":"https://api.github.com/repos/SuperDARNCanada/borealis/releases{/id}","deployments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/deployments","created_at":"2016-09-13T19:22:53Z","updated_at":"2018-11-14T22:57:56Z","pushed_at":"2018-11-14T22:57:57Z","git_url":"git://github.com/SuperDARNCanada/borealis.git","ssh_url":"git@github.com:SuperDARNCanada/borealis.git","clone_url":"https://github.com/SuperDARNCanada/borealis.git","svn_url":"https://github.com/SuperDARNCanada/borealis","homepage":null,"size":81783,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":20,"watchers":2,"default_branch":"master"}},"base":{"label":"SuperDARNCanada:master","ref":"master","sha":"b05f9aa7ffe1e0e37141e595bc296eecd9746bf6","user":{"login":"SuperDARNCanada","id":19173794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTczNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/19173794?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperDARNCanada","html_url":"https://github.com/SuperDARNCanada","followers_url":"https://api.github.com/users/SuperDARNCanada/followers","following_url":"https://api.github.com/users/SuperDARNCanada/following{/other_user}","gists_url":"https://api.github.com/users/SuperDARNCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperDARNCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperDARNCanada/subscriptions","organizations_url":"https://api.github.com/users/SuperDARNCanada/orgs","repos_url":"https://api.github.com/users/SuperDARNCanada/repos","events_url":"https://api.github.com/users/SuperDARNCanada/events{/privacy}","received_events_url":"https://api.github.com/users/SuperDARNCanada/received_events","type":"Organization","site_admin":false},"repo":{"id":68139909,"node_id":"MDEwOlJlcG9zaXRvcnk2ODEzOTkwOQ==","name":"borealis","full_name":"SuperDARNCanada/borealis","private":false,"owner":{"login":"SuperDARNCanada","id":19173794,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE5MTczNzk0","avatar_url":"https://avatars0.githubusercontent.com/u/19173794?v=4","gravatar_id":"","url":"https://api.github.com/users/SuperDARNCanada","html_url":"https://github.com/SuperDARNCanada","followers_url":"https://api.github.com/users/SuperDARNCanada/followers","following_url":"https://api.github.com/users/SuperDARNCanada/following{/other_user}","gists_url":"https://api.github.com/users/SuperDARNCanada/gists{/gist_id}","starred_url":"https://api.github.com/users/SuperDARNCanada/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/SuperDARNCanada/subscriptions","organizations_url":"https://api.github.com/users/SuperDARNCanada/orgs","repos_url":"https://api.github.com/users/SuperDARNCanada/repos","events_url":"https://api.github.com/users/SuperDARNCanada/events{/privacy}","received_events_url":"https://api.github.com/users/SuperDARNCanada/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/SuperDARNCanada/borealis","description":"A control system for USRP based digital radars","fork":false,"url":"https://api.github.com/repos/SuperDARNCanada/borealis","forks_url":"https://api.github.com/repos/SuperDARNCanada/borealis/forks","keys_url":"https://api.github.com/repos/SuperDARNCanada/borealis/keys{/key_id}","collaborators_url":"https://api.github.com/repos/SuperDARNCanada/borealis/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/SuperDARNCanada/borealis/teams","hooks_url":"https://api.github.com/repos/SuperDARNCanada/borealis/hooks","issue_events_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/events{/number}","events_url":"https://api.github.com/repos/SuperDARNCanada/borealis/events","assignees_url":"https://api.github.com/repos/SuperDARNCanada/borealis/assignees{/user}","branches_url":"https://api.github.com/repos/SuperDARNCanada/borealis/branches{/branch}","tags_url":"https://api.github.com/repos/SuperDARNCanada/borealis/tags","blobs_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/refs{/sha}","trees_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/trees{/sha}","statuses_url":"https://api.github.com/repos/SuperDARNCanada/borealis/statuses/{sha}","languages_url":"https://api.github.com/repos/SuperDARNCanada/borealis/languages","stargazers_url":"https://api.github.com/repos/SuperDARNCanada/borealis/stargazers","contributors_url":"https://api.github.com/repos/SuperDARNCanada/borealis/contributors","subscribers_url":"https://api.github.com/repos/SuperDARNCanada/borealis/subscribers","subscription_url":"https://api.github.com/repos/SuperDARNCanada/borealis/subscription","commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/commits{/sha}","git_commits_url":"https://api.github.com/repos/SuperDARNCanada/borealis/git/commits{/sha}","comments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/comments{/number}","issue_comment_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/comments{/number}","contents_url":"https://api.github.com/repos/SuperDARNCanada/borealis/contents/{+path}","compare_url":"https://api.github.com/repos/SuperDARNCanada/borealis/compare/{base}...{head}","merges_url":"https://api.github.com/repos/SuperDARNCanada/borealis/merges","archive_url":"https://api.github.com/repos/SuperDARNCanada/borealis/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/SuperDARNCanada/borealis/downloads","issues_url":"https://api.github.com/repos/SuperDARNCanada/borealis/issues{/number}","pulls_url":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls{/number}","milestones_url":"https://api.github.com/repos/SuperDARNCanada/borealis/milestones{/number}","notifications_url":"https://api.github.com/repos/SuperDARNCanada/borealis/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/SuperDARNCanada/borealis/labels{/name}","releases_url":"https://api.github.com/repos/SuperDARNCanada/borealis/releases{/id}","deployments_url":"https://api.github.com/repos/SuperDARNCanada/borealis/deployments","created_at":"2016-09-13T19:22:53Z","updated_at":"2018-11-14T22:57:56Z","pushed_at":"2018-11-14T22:57:57Z","git_url":"git://github.com/SuperDARNCanada/borealis.git","ssh_url":"git@github.com:SuperDARNCanada/borealis.git","clone_url":"https://github.com/SuperDARNCanada/borealis.git","svn_url":"https://github.com/SuperDARNCanada/borealis","homepage":null,"size":81783,"stargazers_count":2,"watchers_count":2,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1,"mirror_url":null,"archived":false,"open_issues_count":20,"license":{"key":"gpl-3.0","name":"GNU General Public License v3.0","spdx_id":"GPL-3.0","url":"https://api.github.com/licenses/gpl-3.0","node_id":"MDc6TGljZW5zZTk="},"forks":1,"open_issues":20,"watchers":2,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/39"},"html":{"href":"https://github.com/SuperDARNCanada/borealis/pull/39"},"issue":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/39"},"comments":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/issues/39/comments"},"review_comments":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/39/comments"},"review_comment":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/pulls/39/commits"},"statuses":{"href":"https://api.github.com/repos/SuperDARNCanada/borealis/statuses/d540a62cbd0321a4ff24fce4a39fd58af54d312a"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"kevinkrieger"}}