{"action":"closed","number":504,"pull_request":{"url":"https://api.github.com/repos/fastai/fastai/pulls/504","id":190742928,"html_url":"https://github.com/fastai/fastai/pull/504","diff_url":"https://github.com/fastai/fastai/pull/504.diff","patch_url":"https://github.com/fastai/fastai/pull/504.patch","issue_url":"https://api.github.com/repos/fastai/fastai/issues/504","number":504,"state":"closed","locked":false,"title":"proc_df should not add new na columns if na_dict is passed to it","user":{"login":"andreibaragan","id":64905,"avatar_url":"https://avatars1.githubusercontent.com/u/64905?v=4","gravatar_id":"","url":"https://api.github.com/users/andreibaragan","html_url":"https://github.com/andreibaragan","followers_url":"https://api.github.com/users/andreibaragan/followers","following_url":"https://api.github.com/users/andreibaragan/following{/other_user}","gists_url":"https://api.github.com/users/andreibaragan/gists{/gist_id}","starred_url":"https://api.github.com/users/andreibaragan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreibaragan/subscriptions","organizations_url":"https://api.github.com/users/andreibaragan/orgs","repos_url":"https://api.github.com/users/andreibaragan/repos","events_url":"https://api.github.com/users/andreibaragan/events{/privacy}","received_events_url":"https://api.github.com/users/andreibaragan/received_events","type":"User","site_admin":false},"body":"Fixes issue #74.\r\n\r\nThe reason for the PR is that I found two things surprising with proc_df\r\n\r\n1. I did not expect it to add new _na columns if it is being passed an na_dict. This is a big problem when you use proc_df on a test set which might have different NA fields in different columns than the train set.\r\n2. I did not expect proc_df to update the na_dict that is passed to it, I just expected it to return the new dictionary but not replace the one that is being passed to it. This might be because I am a beginner when it comes to python.","created_at":"2018-05-26T13:52:23Z","updated_at":"2018-05-27T13:46:34Z","closed_at":"2018-05-27T13:46:34Z","merged_at":"2018-05-27T13:46:34Z","merge_commit_sha":"27bdfd4d529a2e3d23855be0890cc2b3c8e70f5b","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/fastai/fastai/pulls/504/commits","review_comments_url":"https://api.github.com/repos/fastai/fastai/pulls/504/comments","review_comment_url":"https://api.github.com/repos/fastai/fastai/pulls/comments{/number}","comments_url":"https://api.github.com/repos/fastai/fastai/issues/504/comments","statuses_url":"https://api.github.com/repos/fastai/fastai/statuses/a2d6f0185763fdfb62ab1e48778ee08a44f85a5a","head":{"label":"andreibaragan:74-proc_df_nas_columns","ref":"74-proc_df_nas_columns","sha":"a2d6f0185763fdfb62ab1e48778ee08a44f85a5a","user":{"login":"andreibaragan","id":64905,"avatar_url":"https://avatars1.githubusercontent.com/u/64905?v=4","gravatar_id":"","url":"https://api.github.com/users/andreibaragan","html_url":"https://github.com/andreibaragan","followers_url":"https://api.github.com/users/andreibaragan/followers","following_url":"https://api.github.com/users/andreibaragan/following{/other_user}","gists_url":"https://api.github.com/users/andreibaragan/gists{/gist_id}","starred_url":"https://api.github.com/users/andreibaragan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreibaragan/subscriptions","organizations_url":"https://api.github.com/users/andreibaragan/orgs","repos_url":"https://api.github.com/users/andreibaragan/repos","events_url":"https://api.github.com/users/andreibaragan/events{/privacy}","received_events_url":"https://api.github.com/users/andreibaragan/received_events","type":"User","site_admin":false},"repo":{"id":134963044,"name":"fastai","full_name":"andreibaragan/fastai","owner":{"login":"andreibaragan","id":64905,"avatar_url":"https://avatars1.githubusercontent.com/u/64905?v=4","gravatar_id":"","url":"https://api.github.com/users/andreibaragan","html_url":"https://github.com/andreibaragan","followers_url":"https://api.github.com/users/andreibaragan/followers","following_url":"https://api.github.com/users/andreibaragan/following{/other_user}","gists_url":"https://api.github.com/users/andreibaragan/gists{/gist_id}","starred_url":"https://api.github.com/users/andreibaragan/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/andreibaragan/subscriptions","organizations_url":"https://api.github.com/users/andreibaragan/orgs","repos_url":"https://api.github.com/users/andreibaragan/repos","events_url":"https://api.github.com/users/andreibaragan/events{/privacy}","received_events_url":"https://api.github.com/users/andreibaragan/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/andreibaragan/fastai","description":"The fast.ai deep learning library, lessons, and tutorials","fork":true,"url":"https://api.github.com/repos/andreibaragan/fastai","forks_url":"https://api.github.com/repos/andreibaragan/fastai/forks","keys_url":"https://api.github.com/repos/andreibaragan/fastai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/andreibaragan/fastai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/andreibaragan/fastai/teams","hooks_url":"https://api.github.com/repos/andreibaragan/fastai/hooks","issue_events_url":"https://api.github.com/repos/andreibaragan/fastai/issues/events{/number}","events_url":"https://api.github.com/repos/andreibaragan/fastai/events","assignees_url":"https://api.github.com/repos/andreibaragan/fastai/assignees{/user}","branches_url":"https://api.github.com/repos/andreibaragan/fastai/branches{/branch}","tags_url":"https://api.github.com/repos/andreibaragan/fastai/tags","blobs_url":"https://api.github.com/repos/andreibaragan/fastai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/andreibaragan/fastai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/andreibaragan/fastai/git/refs{/sha}","trees_url":"https://api.github.com/repos/andreibaragan/fastai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/andreibaragan/fastai/statuses/{sha}","languages_url":"https://api.github.com/repos/andreibaragan/fastai/languages","stargazers_url":"https://api.github.com/repos/andreibaragan/fastai/stargazers","contributors_url":"https://api.github.com/repos/andreibaragan/fastai/contributors","subscribers_url":"https://api.github.com/repos/andreibaragan/fastai/subscribers","subscription_url":"https://api.github.com/repos/andreibaragan/fastai/subscription","commits_url":"https://api.github.com/repos/andreibaragan/fastai/commits{/sha}","git_commits_url":"https://api.github.com/repos/andreibaragan/fastai/git/commits{/sha}","comments_url":"https://api.github.com/repos/andreibaragan/fastai/comments{/number}","issue_comment_url":"https://api.github.com/repos/andreibaragan/fastai/issues/comments{/number}","contents_url":"https://api.github.com/repos/andreibaragan/fastai/contents/{+path}","compare_url":"https://api.github.com/repos/andreibaragan/fastai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/andreibaragan/fastai/merges","archive_url":"https://api.github.com/repos/andreibaragan/fastai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/andreibaragan/fastai/downloads","issues_url":"https://api.github.com/repos/andreibaragan/fastai/issues{/number}","pulls_url":"https://api.github.com/repos/andreibaragan/fastai/pulls{/number}","milestones_url":"https://api.github.com/repos/andreibaragan/fastai/milestones{/number}","notifications_url":"https://api.github.com/repos/andreibaragan/fastai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/andreibaragan/fastai/labels{/name}","releases_url":"https://api.github.com/repos/andreibaragan/fastai/releases{/id}","deployments_url":"https://api.github.com/repos/andreibaragan/fastai/deployments","created_at":"2018-05-26T13:19:59Z","updated_at":"2018-05-26T13:20:02Z","pushed_at":"2018-05-26T13:44:03Z","git_url":"git://github.com/andreibaragan/fastai.git","ssh_url":"git@github.com:andreibaragan/fastai.git","clone_url":"https://github.com/andreibaragan/fastai.git","svn_url":"https://github.com/andreibaragan/fastai","homepage":null,"size":195958,"stargazers_count":0,"watchers_count":0,"language":"Jupyter Notebook","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"fastai:master","ref":"master","sha":"5f2b13157fa04453836aa5ae8986eaa3578f131f","user":{"login":"fastai","id":20547620,"avatar_url":"https://avatars3.githubusercontent.com/u/20547620?v=4","gravatar_id":"","url":"https://api.github.com/users/fastai","html_url":"https://github.com/fastai","followers_url":"https://api.github.com/users/fastai/followers","following_url":"https://api.github.com/users/fastai/following{/other_user}","gists_url":"https://api.github.com/users/fastai/gists{/gist_id}","starred_url":"https://api.github.com/users/fastai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastai/subscriptions","organizations_url":"https://api.github.com/users/fastai/orgs","repos_url":"https://api.github.com/users/fastai/repos","events_url":"https://api.github.com/users/fastai/events{/privacy}","received_events_url":"https://api.github.com/users/fastai/received_events","type":"Organization","site_admin":false},"repo":{"id":102973646,"name":"fastai","full_name":"fastai/fastai","owner":{"login":"fastai","id":20547620,"avatar_url":"https://avatars3.githubusercontent.com/u/20547620?v=4","gravatar_id":"","url":"https://api.github.com/users/fastai","html_url":"https://github.com/fastai","followers_url":"https://api.github.com/users/fastai/followers","following_url":"https://api.github.com/users/fastai/following{/other_user}","gists_url":"https://api.github.com/users/fastai/gists{/gist_id}","starred_url":"https://api.github.com/users/fastai/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/fastai/subscriptions","organizations_url":"https://api.github.com/users/fastai/orgs","repos_url":"https://api.github.com/users/fastai/repos","events_url":"https://api.github.com/users/fastai/events{/privacy}","received_events_url":"https://api.github.com/users/fastai/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/fastai/fastai","description":"The fast.ai deep learning library, lessons, and tutorials","fork":false,"url":"https://api.github.com/repos/fastai/fastai","forks_url":"https://api.github.com/repos/fastai/fastai/forks","keys_url":"https://api.github.com/repos/fastai/fastai/keys{/key_id}","collaborators_url":"https://api.github.com/repos/fastai/fastai/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/fastai/fastai/teams","hooks_url":"https://api.github.com/repos/fastai/fastai/hooks","issue_events_url":"https://api.github.com/repos/fastai/fastai/issues/events{/number}","events_url":"https://api.github.com/repos/fastai/fastai/events","assignees_url":"https://api.github.com/repos/fastai/fastai/assignees{/user}","branches_url":"https://api.github.com/repos/fastai/fastai/branches{/branch}","tags_url":"https://api.github.com/repos/fastai/fastai/tags","blobs_url":"https://api.github.com/repos/fastai/fastai/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/fastai/fastai/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/fastai/fastai/git/refs{/sha}","trees_url":"https://api.github.com/repos/fastai/fastai/git/trees{/sha}","statuses_url":"https://api.github.com/repos/fastai/fastai/statuses/{sha}","languages_url":"https://api.github.com/repos/fastai/fastai/languages","stargazers_url":"https://api.github.com/repos/fastai/fastai/stargazers","contributors_url":"https://api.github.com/repos/fastai/fastai/contributors","subscribers_url":"https://api.github.com/repos/fastai/fastai/subscribers","subscription_url":"https://api.github.com/repos/fastai/fastai/subscription","commits_url":"https://api.github.com/repos/fastai/fastai/commits{/sha}","git_commits_url":"https://api.github.com/repos/fastai/fastai/git/commits{/sha}","comments_url":"https://api.github.com/repos/fastai/fastai/comments{/number}","issue_comment_url":"https://api.github.com/repos/fastai/fastai/issues/comments{/number}","contents_url":"https://api.github.com/repos/fastai/fastai/contents/{+path}","compare_url":"https://api.github.com/repos/fastai/fastai/compare/{base}...{head}","merges_url":"https://api.github.com/repos/fastai/fastai/merges","archive_url":"https://api.github.com/repos/fastai/fastai/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/fastai/fastai/downloads","issues_url":"https://api.github.com/repos/fastai/fastai/issues{/number}","pulls_url":"https://api.github.com/repos/fastai/fastai/pulls{/number}","milestones_url":"https://api.github.com/repos/fastai/fastai/milestones{/number}","notifications_url":"https://api.github.com/repos/fastai/fastai/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/fastai/fastai/labels{/name}","releases_url":"https://api.github.com/repos/fastai/fastai/releases{/id}","deployments_url":"https://api.github.com/repos/fastai/fastai/deployments","created_at":"2017-09-09T17:43:36Z","updated_at":"2018-05-27T13:44:08Z","pushed_at":"2018-05-27T13:46:34Z","git_url":"git://github.com/fastai/fastai.git","ssh_url":"git@github.com:fastai/fastai.git","clone_url":"https://github.com/fastai/fastai.git","svn_url":"https://github.com/fastai/fastai","homepage":null,"size":192889,"stargazers_count":4984,"watchers_count":4984,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":1602,"mirror_url":null,"archived":false,"open_issues_count":25,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":1602,"open_issues":25,"watchers":4984,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/fastai/fastai/pulls/504"},"html":{"href":"https://github.com/fastai/fastai/pull/504"},"issue":{"href":"https://api.github.com/repos/fastai/fastai/issues/504"},"comments":{"href":"https://api.github.com/repos/fastai/fastai/issues/504/comments"},"review_comments":{"href":"https://api.github.com/repos/fastai/fastai/pulls/504/comments"},"review_comment":{"href":"https://api.github.com/repos/fastai/fastai/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/fastai/fastai/pulls/504/commits"},"statuses":{"href":"https://api.github.com/repos/fastai/fastai/statuses/a2d6f0185763fdfb62ab1e48778ee08a44f85a5a"}},"author_association":"NONE","merged":true,"mergeable":null,"rebaseable":null,"mergeable_state":"unknown","merged_by":{"login":"jph00","id":346999,"avatar_url":"https://avatars1.githubusercontent.com/u/346999?v=4","gravatar_id":"","url":"https://api.github.com/users/jph00","html_url":"https://github.com/jph00","followers_url":"https://api.github.com/users/jph00/followers","following_url":"https://api.github.com/users/jph00/following{/other_user}","gists_url":"https://api.github.com/users/jph00/gists{/gist_id}","starred_url":"https://api.github.com/users/jph00/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jph00/subscriptions","organizations_url":"https://api.github.com/users/jph00/orgs","repos_url":"https://api.github.com/users/jph00/repos","events_url":"https://api.github.com/users/jph00/events{/privacy}","received_events_url":"https://api.github.com/users/jph00/received_events","type":"User","site_admin":false},"comments":0,"review_comments":0,"maintainer_can_modify":false,"commits":1,"additions":32,"deletions":0,"changed_files":2}}
{"actor":{"display_login":"jph00"}}