{"action":"created","comment":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/177143403","pull_request_review_id":106965541,"id":177143403,"diff_hunk":"@@ -292,7 +292,20 @@\n \n         function call_manager_with_reload(method, args) {\n             return call_manager(method, args).then(function () {\n-                return call_manager(\"Reload\", [ ]);\n+                var dfd = cockpit.defer();\n+                call_manager(\"Reload\", [ ]).\n+                    done(function () { dfd.resolve(); }).\n+                    fail(function (error) {\n+                        // some systemd versions disconnect too fast from the bus\n+                        // (https://bugzilla.redhat.com/show_bug.cgi?id=1560549)","path":"pkg/lib/service.js","position":10,"original_position":10,"commit_id":"31ca55e3a8d5ff934667afb9d532b24579f154c6","original_commit_id":"31ca55e3a8d5ff934667afb9d532b24579f154c6","user":{"login":"stefwalter","id":795070,"avatar_url":"https://avatars1.githubusercontent.com/u/795070?v=4","gravatar_id":"","url":"https://api.github.com/users/stefwalter","html_url":"https://github.com/stefwalter","followers_url":"https://api.github.com/users/stefwalter/followers","following_url":"https://api.github.com/users/stefwalter/following{/other_user}","gists_url":"https://api.github.com/users/stefwalter/gists{/gist_id}","starred_url":"https://api.github.com/users/stefwalter/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/stefwalter/subscriptions","organizations_url":"https://api.github.com/users/stefwalter/orgs","repos_url":"https://api.github.com/users/stefwalter/repos","events_url":"https://api.github.com/users/stefwalter/events{/privacy}","received_events_url":"https://api.github.com/users/stefwalter/received_events","type":"User","site_admin":false},"body":"This line should look like this for easy grepping, tracking:\r\n\r\n```\r\nHACK: https://bugzilla.redhat.com/show_bug.cgi?id=1560549\r\n```","created_at":"2018-03-26T15:54:37Z","updated_at":"2018-03-26T15:59:02Z","html_url":"https://github.com/cockpit-project/cockpit/pull/8897#discussion_r177143403","pull_request_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8897","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments/177143403"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/8897#discussion_r177143403"},"pull_request":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8897"}}},"pull_request":{"url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8897","id":177443640,"html_url":"https://github.com/cockpit-project/cockpit/pull/8897","diff_url":"https://github.com/cockpit-project/cockpit/pull/8897.diff","patch_url":"https://github.com/cockpit-project/cockpit/pull/8897.patch","issue_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/8897","number":8897,"state":"open","locked":false,"title":"lib: Tolerate D-Bus disconnect after reloading systemd","user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars3.githubusercontent.com/u/200109?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"body":"Some systemd versions disconnect too fast from the bus when calling\r\n`Reload()`.  While this should be fixed, it does not actually break\r\noperations, so ignore `NoReply` errors for this call.\r\n\r\nSee https://bugzilla.redhat.com/show_bug.cgi?id=1560549\r\n\r\nFix printing the error message in the playground. It is an objejct, so\r\njust logging it previously just showed `<unavailable>`.","created_at":"2018-03-26T13:19:50Z","updated_at":"2018-03-26T15:59:02Z","closed_at":null,"merged_at":null,"merge_commit_sha":"4d23649894d299b4dcc831900fcbed989634c2e6","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8897/commits","review_comments_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8897/comments","review_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/8897/comments","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/31ca55e3a8d5ff934667afb9d532b24579f154c6","head":{"label":"martinpitt:systemd-reload-disconnect","ref":"systemd-reload-disconnect","sha":"31ca55e3a8d5ff934667afb9d532b24579f154c6","user":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars3.githubusercontent.com/u/200109?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"repo":{"id":77914361,"name":"cockpit","full_name":"martinpitt/cockpit","owner":{"login":"martinpitt","id":200109,"avatar_url":"https://avatars3.githubusercontent.com/u/200109?v=4","gravatar_id":"","url":"https://api.github.com/users/martinpitt","html_url":"https://github.com/martinpitt","followers_url":"https://api.github.com/users/martinpitt/followers","following_url":"https://api.github.com/users/martinpitt/following{/other_user}","gists_url":"https://api.github.com/users/martinpitt/gists{/gist_id}","starred_url":"https://api.github.com/users/martinpitt/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/martinpitt/subscriptions","organizations_url":"https://api.github.com/users/martinpitt/orgs","repos_url":"https://api.github.com/users/martinpitt/repos","events_url":"https://api.github.com/users/martinpitt/events{/privacy}","received_events_url":"https://api.github.com/users/martinpitt/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/martinpitt/cockpit","description":"Cockpit, an admin interface for Linux servers","fork":true,"url":"https://api.github.com/repos/martinpitt/cockpit","forks_url":"https://api.github.com/repos/martinpitt/cockpit/forks","keys_url":"https://api.github.com/repos/martinpitt/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/martinpitt/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/martinpitt/cockpit/teams","hooks_url":"https://api.github.com/repos/martinpitt/cockpit/hooks","issue_events_url":"https://api.github.com/repos/martinpitt/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/martinpitt/cockpit/events","assignees_url":"https://api.github.com/repos/martinpitt/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/martinpitt/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/martinpitt/cockpit/tags","blobs_url":"https://api.github.com/repos/martinpitt/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/martinpitt/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/martinpitt/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/martinpitt/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/martinpitt/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/martinpitt/cockpit/languages","stargazers_url":"https://api.github.com/repos/martinpitt/cockpit/stargazers","contributors_url":"https://api.github.com/repos/martinpitt/cockpit/contributors","subscribers_url":"https://api.github.com/repos/martinpitt/cockpit/subscribers","subscription_url":"https://api.github.com/repos/martinpitt/cockpit/subscription","commits_url":"https://api.github.com/repos/martinpitt/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/martinpitt/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/martinpitt/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/martinpitt/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/martinpitt/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/martinpitt/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/martinpitt/cockpit/merges","archive_url":"https://api.github.com/repos/martinpitt/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/martinpitt/cockpit/downloads","issues_url":"https://api.github.com/repos/martinpitt/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/martinpitt/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/martinpitt/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/martinpitt/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/martinpitt/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/martinpitt/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/martinpitt/cockpit/deployments","created_at":"2017-01-03T12:16:26Z","updated_at":"2017-10-12T07:00:41Z","pushed_at":"2018-03-26T13:19:41Z","git_url":"git://github.com/martinpitt/cockpit.git","ssh_url":"git@github.com:martinpitt/cockpit.git","clone_url":"https://github.com/martinpitt/cockpit.git","svn_url":"https://github.com/martinpitt/cockpit","homepage":"http://www.cockpit-project.org/","size":45522,"stargazers_count":3,"watchers_count":3,"language":"JavaScript","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":0,"open_issues":0,"watchers":3,"default_branch":"master"}},"base":{"label":"cockpit-project:master","ref":"master","sha":"fa059f9de7df39ba841001e76130ad6d2a11a9a4","user":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"repo":{"id":14049216,"name":"cockpit","full_name":"cockpit-project/cockpit","owner":{"login":"cockpit-project","id":5765104,"avatar_url":"https://avatars2.githubusercontent.com/u/5765104?v=4","gravatar_id":"","url":"https://api.github.com/users/cockpit-project","html_url":"https://github.com/cockpit-project","followers_url":"https://api.github.com/users/cockpit-project/followers","following_url":"https://api.github.com/users/cockpit-project/following{/other_user}","gists_url":"https://api.github.com/users/cockpit-project/gists{/gist_id}","starred_url":"https://api.github.com/users/cockpit-project/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/cockpit-project/subscriptions","organizations_url":"https://api.github.com/users/cockpit-project/orgs","repos_url":"https://api.github.com/users/cockpit-project/repos","events_url":"https://api.github.com/users/cockpit-project/events{/privacy}","received_events_url":"https://api.github.com/users/cockpit-project/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/cockpit-project/cockpit","description":"There's code a goin' on","fork":false,"url":"https://api.github.com/repos/cockpit-project/cockpit","forks_url":"https://api.github.com/repos/cockpit-project/cockpit/forks","keys_url":"https://api.github.com/repos/cockpit-project/cockpit/keys{/key_id}","collaborators_url":"https://api.github.com/repos/cockpit-project/cockpit/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/cockpit-project/cockpit/teams","hooks_url":"https://api.github.com/repos/cockpit-project/cockpit/hooks","issue_events_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/events{/number}","events_url":"https://api.github.com/repos/cockpit-project/cockpit/events","assignees_url":"https://api.github.com/repos/cockpit-project/cockpit/assignees{/user}","branches_url":"https://api.github.com/repos/cockpit-project/cockpit/branches{/branch}","tags_url":"https://api.github.com/repos/cockpit-project/cockpit/tags","blobs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/cockpit-project/cockpit/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/cockpit-project/cockpit/git/refs{/sha}","trees_url":"https://api.github.com/repos/cockpit-project/cockpit/git/trees{/sha}","statuses_url":"https://api.github.com/repos/cockpit-project/cockpit/statuses/{sha}","languages_url":"https://api.github.com/repos/cockpit-project/cockpit/languages","stargazers_url":"https://api.github.com/repos/cockpit-project/cockpit/stargazers","contributors_url":"https://api.github.com/repos/cockpit-project/cockpit/contributors","subscribers_url":"https://api.github.com/repos/cockpit-project/cockpit/subscribers","subscription_url":"https://api.github.com/repos/cockpit-project/cockpit/subscription","commits_url":"https://api.github.com/repos/cockpit-project/cockpit/commits{/sha}","git_commits_url":"https://api.github.com/repos/cockpit-project/cockpit/git/commits{/sha}","comments_url":"https://api.github.com/repos/cockpit-project/cockpit/comments{/number}","issue_comment_url":"https://api.github.com/repos/cockpit-project/cockpit/issues/comments{/number}","contents_url":"https://api.github.com/repos/cockpit-project/cockpit/contents/{+path}","compare_url":"https://api.github.com/repos/cockpit-project/cockpit/compare/{base}...{head}","merges_url":"https://api.github.com/repos/cockpit-project/cockpit/merges","archive_url":"https://api.github.com/repos/cockpit-project/cockpit/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/cockpit-project/cockpit/downloads","issues_url":"https://api.github.com/repos/cockpit-project/cockpit/issues{/number}","pulls_url":"https://api.github.com/repos/cockpit-project/cockpit/pulls{/number}","milestones_url":"https://api.github.com/repos/cockpit-project/cockpit/milestones{/number}","notifications_url":"https://api.github.com/repos/cockpit-project/cockpit/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/cockpit-project/cockpit/labels{/name}","releases_url":"https://api.github.com/repos/cockpit-project/cockpit/releases{/id}","deployments_url":"https://api.github.com/repos/cockpit-project/cockpit/deployments","created_at":"2013-11-01T17:36:46Z","updated_at":"2018-03-26T15:29:19Z","pushed_at":"2018-03-26T15:10:45Z","git_url":"git://github.com/cockpit-project/cockpit.git","ssh_url":"git@github.com:cockpit-project/cockpit.git","clone_url":"https://github.com/cockpit-project/cockpit.git","svn_url":"https://github.com/cockpit-project/cockpit","homepage":"http://www.cockpit-project.org/","size":45507,"stargazers_count":3120,"watchers_count":3120,"language":"JavaScript","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":394,"mirror_url":null,"archived":false,"open_issues_count":569,"license":{"key":"lgpl-2.1","name":"GNU Lesser General Public License v2.1","spdx_id":"LGPL-2.1","url":"https://api.github.com/licenses/lgpl-2.1"},"forks":394,"open_issues":569,"watchers":3120,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8897"},"html":{"href":"https://github.com/cockpit-project/cockpit/pull/8897"},"issue":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/8897"},"comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/issues/8897/comments"},"review_comments":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8897/comments"},"review_comment":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/cockpit-project/cockpit/pulls/8897/commits"},"statuses":{"href":"https://api.github.com/repos/cockpit-project/cockpit/statuses/31ca55e3a8d5ff934667afb9d532b24579f154c6"}},"author_association":"OWNER"}}
{"actor":{"display_login":"stefwalter"}}