{"action":"created","issue":{"url":"https://api.github.com/repos/iceiix/steven/issues/40","repository_url":"https://api.github.com/repos/iceiix/steven","labels_url":"https://api.github.com/repos/iceiix/steven/issues/40/labels{/name}","comments_url":"https://api.github.com/repos/iceiix/steven/issues/40/comments","events_url":"https://api.github.com/repos/iceiix/steven/issues/40/events","html_url":"https://github.com/iceiix/steven/pull/40","id":386491050,"node_id":"MDExOlB1bGxSZXF1ZXN0MjM1MjE0MjA4","number":40,"title":"1.12.2 protocol support (340)","user":{"login":"iceiix","id":43691553,"node_id":"MDQ6VXNlcjQzNjkxNTUz","avatar_url":"https://avatars0.githubusercontent.com/u/43691553?v=4","gravatar_id":"","url":"https://api.github.com/users/iceiix","html_url":"https://github.com/iceiix","followers_url":"https://api.github.com/users/iceiix/followers","following_url":"https://api.github.com/users/iceiix/following{/other_user}","gists_url":"https://api.github.com/users/iceiix/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiix/subscriptions","organizations_url":"https://api.github.com/users/iceiix/orgs","repos_url":"https://api.github.com/users/iceiix/repos","events_url":"https://api.github.com/users/iceiix/events{/privacy}","received_events_url":"https://api.github.com/users/iceiix/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":2,"created_at":"2018-12-01T19:48:37Z","updated_at":"2018-12-01T21:57:59Z","closed_at":null,"author_association":"OWNER","pull_request":{"url":"https://api.github.com/repos/iceiix/steven/pulls/40","html_url":"https://github.com/iceiix/steven/pull/40","diff_url":"https://github.com/iceiix/steven/pull/40.diff","patch_url":"https://github.com/iceiix/steven/pull/40.patch"},"body":"https://github.com/iceiix/steven/issues/18\r\nhttps://wiki.vg/Protocol_History#1.12.2\r\nhttps://wiki.vg/index.php?title=Protocol&oldid=14204"},"comment":{"url":"https://api.github.com/repos/iceiix/steven/issues/comments/443461692","html_url":"https://github.com/iceiix/steven/pull/40#issuecomment-443461692","issue_url":"https://api.github.com/repos/iceiix/steven/issues/40","id":443461692,"node_id":"MDEyOklzc3VlQ29tbWVudDQ0MzQ2MTY5Mg==","user":{"login":"iceiix","id":43691553,"node_id":"MDQ6VXNlcjQzNjkxNTUz","avatar_url":"https://avatars0.githubusercontent.com/u/43691553?v=4","gravatar_id":"","url":"https://api.github.com/users/iceiix","html_url":"https://github.com/iceiix","followers_url":"https://api.github.com/users/iceiix/followers","following_url":"https://api.github.com/users/iceiix/following{/other_user}","gists_url":"https://api.github.com/users/iceiix/gists{/gist_id}","starred_url":"https://api.github.com/users/iceiix/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/iceiix/subscriptions","organizations_url":"https://api.github.com/users/iceiix/orgs","repos_url":"https://api.github.com/users/iceiix/repos","events_url":"https://api.github.com/users/iceiix/events{/privacy}","received_events_url":"https://api.github.com/users/iceiix/received_events","type":"User","site_admin":false},"created_at":"2018-12-01T21:57:59Z","updated_at":"2018-12-01T21:57:59Z","author_association":"OWNER","body":"i16 is 3338 (0x0d0a), reading into a Vec with read_to_end instead of read_to_string:\r\n\r\n```rust\r\npub fn read_string<R: io::Read>(buf: &mut R) -> Result<String, protocol::Error> { \r\n    let len: i16 = buf.read_i16::<BigEndian>()?;\r\n    let mut ret = String::new();\r\n    println!(\"read_string len = {:?}\", len);\r\n    if len > 3000 { \r\n        let mut vec = vec![];\r\n        let result = buf.take(len as u64).read_to_end(&mut vec);\r\n        println!(\"vec = {:?}\", vec);\r\n        println!(\"result = {:?}\", result);\r\n    } \r\n\r\n    buf.take(len as u64).read_to_string(&mut ret)?;\r\n    Result::Ok(ret)\r\n}\r\n```\r\n\r\nbytes are [0, 0, 0, 255]. Bytes 0x0d0a for length are suspicious, CRLF?"}}
{"actor":{"display_login":"iceiix"}}