{"action":"created","comment":{"url":"https://api.github.com/repos/ioam/holoviews/pulls/comments/175519877","pull_request_review_id":105062381,"id":175519877,"diff_hunk":"@@ -1,71 +1,89 @@\n div.hololayout {\n-    display: flex;","path":"holoviews/plotting/widgets/jsslider.css","position":2,"original_position":2,"commit_id":"ad664d84b2f52b36372713725756a0259ac7b9cf","original_commit_id":"ad664d84b2f52b36372713725756a0259ac7b9cf","user":{"login":"jlstevens","id":890576,"avatar_url":"https://avatars3.githubusercontent.com/u/890576?v=4","gravatar_id":"","url":"https://api.github.com/users/jlstevens","html_url":"https://github.com/jlstevens","followers_url":"https://api.github.com/users/jlstevens/followers","following_url":"https://api.github.com/users/jlstevens/following{/other_user}","gists_url":"https://api.github.com/users/jlstevens/gists{/gist_id}","starred_url":"https://api.github.com/users/jlstevens/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jlstevens/subscriptions","organizations_url":"https://api.github.com/users/jlstevens/orgs","repos_url":"https://api.github.com/users/jlstevens/repos","events_url":"https://api.github.com/users/jlstevens/events{/privacy}","received_events_url":"https://api.github.com/users/jlstevens/received_events","type":"User","site_admin":false},"body":"Could you add some comments to mark which bits of CSS map to the sliders in jupyterlab and which map to the classic notebook?","created_at":"2018-03-19T17:28:17Z","updated_at":"2018-03-19T17:28:17Z","html_url":"https://github.com/ioam/holoviews/pull/2456#discussion_r175519877","pull_request_url":"https://api.github.com/repos/ioam/holoviews/pulls/2456","author_association":"OWNER","_links":{"self":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/comments/175519877"},"html":{"href":"https://github.com/ioam/holoviews/pull/2456#discussion_r175519877"},"pull_request":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/2456"}}},"pull_request":{"url":"https://api.github.com/repos/ioam/holoviews/pulls/2456","id":175784708,"html_url":"https://github.com/ioam/holoviews/pull/2456","diff_url":"https://github.com/ioam/holoviews/pull/2456.diff","patch_url":"https://github.com/ioam/holoviews/pull/2456.patch","issue_url":"https://api.github.com/repos/ioam/holoviews/issues/2456","number":2456,"state":"open","locked":false,"title":"Define custom css for JupyterLab slider","user":{"login":"philippjfr","id":1550771,"avatar_url":"https://avatars2.githubusercontent.com/u/1550771?v=4","gravatar_id":"","url":"https://api.github.com/users/philippjfr","html_url":"https://github.com/philippjfr","followers_url":"https://api.github.com/users/philippjfr/followers","following_url":"https://api.github.com/users/philippjfr/following{/other_user}","gists_url":"https://api.github.com/users/philippjfr/gists{/gist_id}","starred_url":"https://api.github.com/users/philippjfr/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/philippjfr/subscriptions","organizations_url":"https://api.github.com/users/philippjfr/orgs","repos_url":"https://api.github.com/users/philippjfr/repos","events_url":"https://api.github.com/users/philippjfr/events{/privacy}","received_events_url":"https://api.github.com/users/philippjfr/received_events","type":"User","site_admin":false},"body":"Has no effect on the CSS design in the classic notebook but overrides improves the styling for JupyterLab which does not include bootstrap.css.\r\n\r\n<img width=\"1214\" alt=\"screen shot 2018-03-19 at 1 25 17 am\" src=\"https://user-images.githubusercontent.com/1550771/37574014-8c338d92-2b15-11e8-9f3c-17fe308ae4fa.png\">\r\n\r\n\r\nThere's still some things that could be improved but I haven't been able to figure out a way without affecting the styling in the classic notebook.","created_at":"2018-03-19T00:55:43Z","updated_at":"2018-03-19T17:28:17Z","closed_at":null,"merged_at":null,"merge_commit_sha":"80170e36611cb629da36ef887a818268b0f3af81","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":872354168,"url":"https://api.github.com/repos/ioam/holoviews/labels/enhancement","name":"enhancement","color":"6eea80","default":true}],"milestone":null,"commits_url":"https://api.github.com/repos/ioam/holoviews/pulls/2456/commits","review_comments_url":"https://api.github.com/repos/ioam/holoviews/pulls/2456/comments","review_comment_url":"https://api.github.com/repos/ioam/holoviews/pulls/comments{/number}","comments_url":"https://api.github.com/repos/ioam/holoviews/issues/2456/comments","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/ad664d84b2f52b36372713725756a0259ac7b9cf","head":{"label":"ioam:jlab_css","ref":"jlab_css","sha":"ad664d84b2f52b36372713725756a0259ac7b9cf","user":{"login":"ioam","id":1693676,"avatar_url":"https://avatars2.githubusercontent.com/u/1693676?v=4","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"repo":{"id":19542768,"name":"holoviews","full_name":"ioam/holoviews","owner":{"login":"ioam","id":1693676,"avatar_url":"https://avatars2.githubusercontent.com/u/1693676?v=4","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioam/holoviews","description":"Stop plotting your data - annotate your data and let it visualize itself.","fork":false,"url":"https://api.github.com/repos/ioam/holoviews","forks_url":"https://api.github.com/repos/ioam/holoviews/forks","keys_url":"https://api.github.com/repos/ioam/holoviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioam/holoviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioam/holoviews/teams","hooks_url":"https://api.github.com/repos/ioam/holoviews/hooks","issue_events_url":"https://api.github.com/repos/ioam/holoviews/issues/events{/number}","events_url":"https://api.github.com/repos/ioam/holoviews/events","assignees_url":"https://api.github.com/repos/ioam/holoviews/assignees{/user}","branches_url":"https://api.github.com/repos/ioam/holoviews/branches{/branch}","tags_url":"https://api.github.com/repos/ioam/holoviews/tags","blobs_url":"https://api.github.com/repos/ioam/holoviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioam/holoviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioam/holoviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioam/holoviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/{sha}","languages_url":"https://api.github.com/repos/ioam/holoviews/languages","stargazers_url":"https://api.github.com/repos/ioam/holoviews/stargazers","contributors_url":"https://api.github.com/repos/ioam/holoviews/contributors","subscribers_url":"https://api.github.com/repos/ioam/holoviews/subscribers","subscription_url":"https://api.github.com/repos/ioam/holoviews/subscription","commits_url":"https://api.github.com/repos/ioam/holoviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioam/holoviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioam/holoviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioam/holoviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioam/holoviews/contents/{+path}","compare_url":"https://api.github.com/repos/ioam/holoviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioam/holoviews/merges","archive_url":"https://api.github.com/repos/ioam/holoviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioam/holoviews/downloads","issues_url":"https://api.github.com/repos/ioam/holoviews/issues{/number}","pulls_url":"https://api.github.com/repos/ioam/holoviews/pulls{/number}","milestones_url":"https://api.github.com/repos/ioam/holoviews/milestones{/number}","notifications_url":"https://api.github.com/repos/ioam/holoviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioam/holoviews/labels{/name}","releases_url":"https://api.github.com/repos/ioam/holoviews/releases{/id}","deployments_url":"https://api.github.com/repos/ioam/holoviews/deployments","created_at":"2014-05-07T16:59:22Z","updated_at":"2018-03-19T17:17:22Z","pushed_at":"2018-03-19T17:17:19Z","git_url":"git://github.com/ioam/holoviews.git","ssh_url":"git@github.com:ioam/holoviews.git","clone_url":"https://github.com/ioam/holoviews.git","svn_url":"https://github.com/ioam/holoviews","homepage":"http://holoviews.org","size":18462,"stargazers_count":735,"watchers_count":735,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":417,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":107,"open_issues":417,"watchers":735,"default_branch":"master"}},"base":{"label":"ioam:master","ref":"master","sha":"fc565b74d11dad7109ab0d4878d3c1ed29de71d4","user":{"login":"ioam","id":1693676,"avatar_url":"https://avatars2.githubusercontent.com/u/1693676?v=4","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"repo":{"id":19542768,"name":"holoviews","full_name":"ioam/holoviews","owner":{"login":"ioam","id":1693676,"avatar_url":"https://avatars2.githubusercontent.com/u/1693676?v=4","gravatar_id":"","url":"https://api.github.com/users/ioam","html_url":"https://github.com/ioam","followers_url":"https://api.github.com/users/ioam/followers","following_url":"https://api.github.com/users/ioam/following{/other_user}","gists_url":"https://api.github.com/users/ioam/gists{/gist_id}","starred_url":"https://api.github.com/users/ioam/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ioam/subscriptions","organizations_url":"https://api.github.com/users/ioam/orgs","repos_url":"https://api.github.com/users/ioam/repos","events_url":"https://api.github.com/users/ioam/events{/privacy}","received_events_url":"https://api.github.com/users/ioam/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/ioam/holoviews","description":"Stop plotting your data - annotate your data and let it visualize itself.","fork":false,"url":"https://api.github.com/repos/ioam/holoviews","forks_url":"https://api.github.com/repos/ioam/holoviews/forks","keys_url":"https://api.github.com/repos/ioam/holoviews/keys{/key_id}","collaborators_url":"https://api.github.com/repos/ioam/holoviews/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/ioam/holoviews/teams","hooks_url":"https://api.github.com/repos/ioam/holoviews/hooks","issue_events_url":"https://api.github.com/repos/ioam/holoviews/issues/events{/number}","events_url":"https://api.github.com/repos/ioam/holoviews/events","assignees_url":"https://api.github.com/repos/ioam/holoviews/assignees{/user}","branches_url":"https://api.github.com/repos/ioam/holoviews/branches{/branch}","tags_url":"https://api.github.com/repos/ioam/holoviews/tags","blobs_url":"https://api.github.com/repos/ioam/holoviews/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/ioam/holoviews/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/ioam/holoviews/git/refs{/sha}","trees_url":"https://api.github.com/repos/ioam/holoviews/git/trees{/sha}","statuses_url":"https://api.github.com/repos/ioam/holoviews/statuses/{sha}","languages_url":"https://api.github.com/repos/ioam/holoviews/languages","stargazers_url":"https://api.github.com/repos/ioam/holoviews/stargazers","contributors_url":"https://api.github.com/repos/ioam/holoviews/contributors","subscribers_url":"https://api.github.com/repos/ioam/holoviews/subscribers","subscription_url":"https://api.github.com/repos/ioam/holoviews/subscription","commits_url":"https://api.github.com/repos/ioam/holoviews/commits{/sha}","git_commits_url":"https://api.github.com/repos/ioam/holoviews/git/commits{/sha}","comments_url":"https://api.github.com/repos/ioam/holoviews/comments{/number}","issue_comment_url":"https://api.github.com/repos/ioam/holoviews/issues/comments{/number}","contents_url":"https://api.github.com/repos/ioam/holoviews/contents/{+path}","compare_url":"https://api.github.com/repos/ioam/holoviews/compare/{base}...{head}","merges_url":"https://api.github.com/repos/ioam/holoviews/merges","archive_url":"https://api.github.com/repos/ioam/holoviews/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/ioam/holoviews/downloads","issues_url":"https://api.github.com/repos/ioam/holoviews/issues{/number}","pulls_url":"https://api.github.com/repos/ioam/holoviews/pulls{/number}","milestones_url":"https://api.github.com/repos/ioam/holoviews/milestones{/number}","notifications_url":"https://api.github.com/repos/ioam/holoviews/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/ioam/holoviews/labels{/name}","releases_url":"https://api.github.com/repos/ioam/holoviews/releases{/id}","deployments_url":"https://api.github.com/repos/ioam/holoviews/deployments","created_at":"2014-05-07T16:59:22Z","updated_at":"2018-03-19T17:17:22Z","pushed_at":"2018-03-19T17:17:19Z","git_url":"git://github.com/ioam/holoviews.git","ssh_url":"git@github.com:ioam/holoviews.git","clone_url":"https://github.com/ioam/holoviews.git","svn_url":"https://github.com/ioam/holoviews","homepage":"http://holoviews.org","size":18462,"stargazers_count":735,"watchers_count":735,"language":"Python","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":107,"mirror_url":null,"archived":false,"open_issues_count":417,"license":{"key":"bsd-3-clause","name":"BSD 3-Clause \"New\" or \"Revised\" License","spdx_id":"BSD-3-Clause","url":"https://api.github.com/licenses/bsd-3-clause"},"forks":107,"open_issues":417,"watchers":735,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/2456"},"html":{"href":"https://github.com/ioam/holoviews/pull/2456"},"issue":{"href":"https://api.github.com/repos/ioam/holoviews/issues/2456"},"comments":{"href":"https://api.github.com/repos/ioam/holoviews/issues/2456/comments"},"review_comments":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/2456/comments"},"review_comment":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/ioam/holoviews/pulls/2456/commits"},"statuses":{"href":"https://api.github.com/repos/ioam/holoviews/statuses/ad664d84b2f52b36372713725756a0259ac7b9cf"}},"author_association":"OWNER"}}
{"actor":{"display_login":"jlstevens"}}