{"action":"created","issue":{"url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/338","repository_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm","labels_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/338/labels{/name}","comments_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/338/comments","events_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/338/events","html_url":"https://github.com/ethereumjs/ethereumjs-vm/issues/338","id":349448859,"node_id":"MDU6SXNzdWUzNDk0NDg4NTk=","number":338,"title":"Fix failing blockchain tests","user":{"login":"holgerd77","id":931137,"node_id":"MDQ6VXNlcjkzMTEzNw==","avatar_url":"https://avatars0.githubusercontent.com/u/931137?v=4","gravatar_id":"","url":"https://api.github.com/users/holgerd77","html_url":"https://github.com/holgerd77","followers_url":"https://api.github.com/users/holgerd77/followers","following_url":"https://api.github.com/users/holgerd77/following{/other_user}","gists_url":"https://api.github.com/users/holgerd77/gists{/gist_id}","starred_url":"https://api.github.com/users/holgerd77/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/holgerd77/subscriptions","organizations_url":"https://api.github.com/users/holgerd77/orgs","repos_url":"https://api.github.com/users/holgerd77/repos","events_url":"https://api.github.com/users/holgerd77/events{/privacy}","received_events_url":"https://api.github.com/users/holgerd77/received_events","type":"User","site_admin":false},"labels":[{"id":1063540541,"node_id":"MDU6TGFiZWwxMDYzNTQwNTQx","url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/labels/effort:%20E2%20days","name":"effort: E2 days","color":"a5e3be","default":false},{"id":1063540914,"node_id":"MDU6TGFiZWwxMDYzNTQwOTE0","url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/labels/effort:%20E3%20weeks","name":"effort: E3 weeks","color":"a5e3be","default":false},{"id":1063492944,"node_id":"MDU6TGFiZWwxMDYzNDkyOTQ0","url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/labels/prio:%20P2%20very%20important","name":"prio: P2 very important","color":"fd9579","default":false}],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":12,"created_at":"2018-08-10T09:50:03Z","updated_at":"2018-10-22T16:39:46Z","closed_at":null,"author_association":"MEMBER","body":"Just ran the blockchain tests after a long time (see also associated issue https://github.com/ethereumjs/ethereumjs-vm/issues/337 on a revived BlockchainTests test run strategy).\r\n\r\nCurrently 66 tests are failing:\r\n\r\n```shell\r\n1..956\r\n# tests 956\r\n# pass  890\r\n# fail  66\r\n```\r\n\r\nI will list all here so we have a basis to fix without the need (for the initial fixes) to re-run the tests again and again:\r\n\r\n```shell\r\nRPC_API_Test\r\nGasLimitHigherThan2p63m1\r\nChainAtoChainB_BlockHash\r\nrandomStatetest218BC\r\nrandomStatetest224BC\r\nrandomStatetest234BC\r\nrandomStatetest240BC\r\nrandomStatetest255BC\r\nrandomStatetest331BC\r\nrandomStatetest34BC\r\nrandomStatetest35BC\r\nrandomStatetest403BC\r\nrandomStatetest431BC\r\nrandomStatetest432BC\r\nrandomStatetest529BC\r\nrandomStatetest598BC\r\nrandomStatetest65BC\r\nBLOCKHASH_Bounds\r\nOOGStateCopyContainingDeletedContract\r\nblockhashNonConstArg\r\nblockhashTests\r\nsuicideCoinbase\r\nExtraData32\r\nRecallSuicidedContractInOneBlock\r\nlog1_correct\r\ntimeDiff0\r\ntimeDiff12\r\ntimeDiff13\r\ntimeDiff14\r\nwallet2outOf3txs2\r\nwallet2outOf3txsRevoke\r\nwallet2outOf3txsRevokeAndConfirmAgain\r\nwalletReorganizeOwners\r\n```\r\n\r\nTest runs on the listed files can be triggered with ``node tests/tester.js -b --file='blockhashTests'``.\r\n\r\nExtra note: I think atm blockchain tests are not updated to take the HF setting into account and explicitly instantiate the VM with it (like on the state tests). Atm this shouldn't be a (the) problem, but this should be updated anyhow."},"comment":{"url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/comments/431891092","html_url":"https://github.com/ethereumjs/ethereumjs-vm/issues/338#issuecomment-431891092","issue_url":"https://api.github.com/repos/ethereumjs/ethereumjs-vm/issues/338","id":431891092,"node_id":"MDEyOklzc3VlQ29tbWVudDQzMTg5MTA5Mg==","user":{"login":"danjm","id":7499938,"node_id":"MDQ6VXNlcjc0OTk5Mzg=","avatar_url":"https://avatars2.githubusercontent.com/u/7499938?v=4","gravatar_id":"","url":"https://api.github.com/users/danjm","html_url":"https://github.com/danjm","followers_url":"https://api.github.com/users/danjm/followers","following_url":"https://api.github.com/users/danjm/following{/other_user}","gists_url":"https://api.github.com/users/danjm/gists{/gist_id}","starred_url":"https://api.github.com/users/danjm/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/danjm/subscriptions","organizations_url":"https://api.github.com/users/danjm/orgs","repos_url":"https://api.github.com/users/danjm/repos","events_url":"https://api.github.com/users/danjm/events{/privacy}","received_events_url":"https://api.github.com/users/danjm/received_events","type":"User","site_admin":false},"created_at":"2018-10-22T16:39:46Z","updated_at":"2018-10-22T16:39:46Z","author_association":"CONTRIBUTOR","body":"I propose that we treat the resolution of these tests as five separate tasks:\r\n\r\n- [ ] Tests failing with https://github.com/ethereumjs/ethereumjs-vm/pull/147 (assignee: @danjm)\r\n- [ ] Fix/skip tests that started failing with https://github.com/ethereumjs/ethereumjs-vm/pull/168 (assignee: )\r\n- [ ] Fix/skip tests that started failing with https://github.com/ethereumjs/ethereumjs-vm/pull/184  (assignee: )\r\n- [ ] Fix/skip tests that started failing with https://github.com/ethereumjs/ethereumjs-vm/pull/197  (assignee: )\r\n- [ ] Fix/skip tests that started failing with https://github.com/ethereumjs/ethereumjs-vm/pull/295 (assignee: @alextsg )\r\n\r\nI've started investigating the first group of these. Unless claimed by others, I will attempt to work through all of them this week.\r\n\r\ncc @holgerd77 "}}
{"actor":{"display_login":"danjm"}}