{"action":"closed","issue":{"url":"https://api.github.com/repos/voltusdev/rickshaw/issues/6","repository_url":"https://api.github.com/repos/voltusdev/rickshaw","labels_url":"https://api.github.com/repos/voltusdev/rickshaw/issues/6/labels{/name}","comments_url":"https://api.github.com/repos/voltusdev/rickshaw/issues/6/comments","events_url":"https://api.github.com/repos/voltusdev/rickshaw/issues/6/events","html_url":"https://github.com/voltusdev/rickshaw/issues/6","id":393199327,"node_id":"MDU6SXNzdWUzOTMxOTkzMjc=","number":6,"title":"Investigate adding Prettier.js to the library","user":{"login":"evanemolo","id":1220668,"node_id":"MDQ6VXNlcjEyMjA2Njg=","avatar_url":"https://avatars2.githubusercontent.com/u/1220668?v=4","gravatar_id":"","url":"https://api.github.com/users/evanemolo","html_url":"https://github.com/evanemolo","followers_url":"https://api.github.com/users/evanemolo/followers","following_url":"https://api.github.com/users/evanemolo/following{/other_user}","gists_url":"https://api.github.com/users/evanemolo/gists{/gist_id}","starred_url":"https://api.github.com/users/evanemolo/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/evanemolo/subscriptions","organizations_url":"https://api.github.com/users/evanemolo/orgs","repos_url":"https://api.github.com/users/evanemolo/repos","events_url":"https://api.github.com/users/evanemolo/events{/privacy}","received_events_url":"https://api.github.com/users/evanemolo/received_events","type":"User","site_admin":false},"labels":[],"state":"closed","locked":false,"assignee":{"login":"jessipedia","id":2893384,"node_id":"MDQ6VXNlcjI4OTMzODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2893384?v=4","gravatar_id":"","url":"https://api.github.com/users/jessipedia","html_url":"https://github.com/jessipedia","followers_url":"https://api.github.com/users/jessipedia/followers","following_url":"https://api.github.com/users/jessipedia/following{/other_user}","gists_url":"https://api.github.com/users/jessipedia/gists{/gist_id}","starred_url":"https://api.github.com/users/jessipedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessipedia/subscriptions","organizations_url":"https://api.github.com/users/jessipedia/orgs","repos_url":"https://api.github.com/users/jessipedia/repos","events_url":"https://api.github.com/users/jessipedia/events{/privacy}","received_events_url":"https://api.github.com/users/jessipedia/received_events","type":"User","site_admin":false},"assignees":[{"login":"jessipedia","id":2893384,"node_id":"MDQ6VXNlcjI4OTMzODQ=","avatar_url":"https://avatars2.githubusercontent.com/u/2893384?v=4","gravatar_id":"","url":"https://api.github.com/users/jessipedia","html_url":"https://github.com/jessipedia","followers_url":"https://api.github.com/users/jessipedia/followers","following_url":"https://api.github.com/users/jessipedia/following{/other_user}","gists_url":"https://api.github.com/users/jessipedia/gists{/gist_id}","starred_url":"https://api.github.com/users/jessipedia/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jessipedia/subscriptions","organizations_url":"https://api.github.com/users/jessipedia/orgs","repos_url":"https://api.github.com/users/jessipedia/repos","events_url":"https://api.github.com/users/jessipedia/events{/privacy}","received_events_url":"https://api.github.com/users/jessipedia/received_events","type":"User","site_admin":false}],"milestone":null,"comments":1,"created_at":"2018-12-20T20:25:34Z","updated_at":"2018-12-21T20:13:33Z","closed_at":"2018-12-21T20:13:33Z","author_association":"NONE","body":"While Rickshaw uses JSHint for linting, the codebase suffers from a lack of enforcement regarding consistent code styling. \r\n\r\nTo do: \r\n- read the Prettier docs (https://prettier.io/docs/en/install.html) and understand what it will take to:\r\n  1. install the package\r\n  2. run the package from the CLI\r\n  3. have Prettier run on src files only - ignore outputted files that are compiled from the Makefile, node_modules, etc.\r\n  4. Add a line to package.json scripts that can run from the CLI with `npm run lint:prettier`\r\n- copy over a pretterrc file from one of the other JS projects\r\n\r\nA couple things to note:\r\n- Prettier should be able to run without ESLint\r\n- Babel / ES6'ing the code is not required to run Prettier\r\n\r\n---\r\n\r\nOnce that's in place, we can enforce it with Circle CI."}}
{"actor":{"display_login":"nrlakin"}}