{"action":"created","comment":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments/175071741","pull_request_review_id":104544281,"id":175071741,"diff_hunk":"@@ -23,4 +23,4 @@ jobs:\n       language: go\n       go: 1.9\n       script:\n-      - make verify test\n+      - make verify verify_pr test","path":".travis.yml","position":5,"original_position":5,"commit_id":"9233e30ef5764c181bd39466fdc1d9201b2c5e10","original_commit_id":"9233e30ef5764c181bd39466fdc1d9201b2c5e10","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars0.githubusercontent.com/u/2147649?v=4","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"body":"I did notice the repo didn't use it; I wasn't sure if you wanted to keep it up to date for turning on later or something though.","created_at":"2018-03-16T12:18:48Z","updated_at":"2018-03-16T12:18:49Z","html_url":"https://github.com/jetstack/cert-manager/pull/397#discussion_r175071741","pull_request_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/397","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments/175071741"},"html":{"href":"https://github.com/jetstack/cert-manager/pull/397#discussion_r175071741"},"pull_request":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/397"}},"in_reply_to_id":175071400},"pull_request":{"url":"https://api.github.com/repos/jetstack/cert-manager/pulls/397","id":175424083,"html_url":"https://github.com/jetstack/cert-manager/pull/397","diff_url":"https://github.com/jetstack/cert-manager/pull/397.diff","patch_url":"https://github.com/jetstack/cert-manager/pull/397.patch","issue_url":"https://api.github.com/repos/jetstack/cert-manager/issues/397","number":397,"state":"open","locked":false,"title":"make: split 'verify_pr' out ","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars0.githubusercontent.com/u/2147649?v=4","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"body":"This is a followup/fixup for #372 \r\n\r\nThe changes in 372 broke break running `make verify` locally, which I think is a somewhat useful developer command.\r\n\r\nWhile I was at it, I also changed the default target to build since I think that's more likely what someone wants. I don't think that breaks anything since I think other places have explicitly been calling out which targets to call.\r\n\r\nThis also requires https://github.com/jetstack/test-infra/pull/158 to not lose that new coverage","created_at":"2018-03-16T02:12:06Z","updated_at":"2018-03-16T12:18:49Z","closed_at":null,"merged_at":null,"merge_commit_sha":"b5e74f80c536f27a5d8fcc3e3ae149baf46f90ae","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[{"id":728658090,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/needs-ok-to-test","name":"needs-ok-to-test","color":"b60205","default":false},{"id":728589163,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/release-note-none","name":"release-note-none","color":"c2e0c6","default":false},{"id":728648139,"url":"https://api.github.com/repos/jetstack/cert-manager/labels/size/S","name":"size/S","color":"77bb00","default":false}],"milestone":null,"commits_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/397/commits","review_comments_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/397/comments","review_comment_url":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments{/number}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/issues/397/comments","statuses_url":"https://api.github.com/repos/jetstack/cert-manager/statuses/9233e30ef5764c181bd39466fdc1d9201b2c5e10","head":{"label":"euank:hack-ver","ref":"hack-ver","sha":"9233e30ef5764c181bd39466fdc1d9201b2c5e10","user":{"login":"euank","id":2147649,"avatar_url":"https://avatars0.githubusercontent.com/u/2147649?v=4","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"repo":{"id":110508763,"name":"cert-manager","full_name":"euank/cert-manager","owner":{"login":"euank","id":2147649,"avatar_url":"https://avatars0.githubusercontent.com/u/2147649?v=4","gravatar_id":"","url":"https://api.github.com/users/euank","html_url":"https://github.com/euank","followers_url":"https://api.github.com/users/euank/followers","following_url":"https://api.github.com/users/euank/following{/other_user}","gists_url":"https://api.github.com/users/euank/gists{/gist_id}","starred_url":"https://api.github.com/users/euank/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/euank/subscriptions","organizations_url":"https://api.github.com/users/euank/orgs","repos_url":"https://api.github.com/users/euank/repos","events_url":"https://api.github.com/users/euank/events{/privacy}","received_events_url":"https://api.github.com/users/euank/received_events","type":"User","site_admin":false},"private":false,"html_url":"https://github.com/euank/cert-manager","description":"Automatically provision TLS certificates for Kubernetes","fork":true,"url":"https://api.github.com/repos/euank/cert-manager","forks_url":"https://api.github.com/repos/euank/cert-manager/forks","keys_url":"https://api.github.com/repos/euank/cert-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/euank/cert-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/euank/cert-manager/teams","hooks_url":"https://api.github.com/repos/euank/cert-manager/hooks","issue_events_url":"https://api.github.com/repos/euank/cert-manager/issues/events{/number}","events_url":"https://api.github.com/repos/euank/cert-manager/events","assignees_url":"https://api.github.com/repos/euank/cert-manager/assignees{/user}","branches_url":"https://api.github.com/repos/euank/cert-manager/branches{/branch}","tags_url":"https://api.github.com/repos/euank/cert-manager/tags","blobs_url":"https://api.github.com/repos/euank/cert-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/euank/cert-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/euank/cert-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/euank/cert-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/euank/cert-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/euank/cert-manager/languages","stargazers_url":"https://api.github.com/repos/euank/cert-manager/stargazers","contributors_url":"https://api.github.com/repos/euank/cert-manager/contributors","subscribers_url":"https://api.github.com/repos/euank/cert-manager/subscribers","subscription_url":"https://api.github.com/repos/euank/cert-manager/subscription","commits_url":"https://api.github.com/repos/euank/cert-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/euank/cert-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/euank/cert-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/euank/cert-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/euank/cert-manager/contents/{+path}","compare_url":"https://api.github.com/repos/euank/cert-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/euank/cert-manager/merges","archive_url":"https://api.github.com/repos/euank/cert-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/euank/cert-manager/downloads","issues_url":"https://api.github.com/repos/euank/cert-manager/issues{/number}","pulls_url":"https://api.github.com/repos/euank/cert-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/euank/cert-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/euank/cert-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/euank/cert-manager/labels{/name}","releases_url":"https://api.github.com/repos/euank/cert-manager/releases{/id}","deployments_url":"https://api.github.com/repos/euank/cert-manager/deployments","created_at":"2017-11-13T06:27:38Z","updated_at":"2017-11-13T06:27:41Z","pushed_at":"2018-03-16T02:50:18Z","git_url":"git://github.com/euank/cert-manager.git","ssh_url":"git@github.com:euank/cert-manager.git","clone_url":"https://github.com/euank/cert-manager.git","svn_url":"https://github.com/euank/cert-manager","homepage":"","size":51188,"stargazers_count":0,"watchers_count":0,"language":"Go","has_issues":false,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":0,"mirror_url":null,"archived":false,"open_issues_count":0,"license":null,"forks":0,"open_issues":0,"watchers":0,"default_branch":"master"}},"base":{"label":"jetstack:master","ref":"master","sha":"08df3631fad1a1025decb9a23b10863381fdaadb","user":{"login":"jetstack","id":13183983,"avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"repo":{"id":92313258,"name":"cert-manager","full_name":"jetstack/cert-manager","owner":{"login":"jetstack","id":13183983,"avatar_url":"https://avatars1.githubusercontent.com/u/13183983?v=4","gravatar_id":"","url":"https://api.github.com/users/jetstack","html_url":"https://github.com/jetstack","followers_url":"https://api.github.com/users/jetstack/followers","following_url":"https://api.github.com/users/jetstack/following{/other_user}","gists_url":"https://api.github.com/users/jetstack/gists{/gist_id}","starred_url":"https://api.github.com/users/jetstack/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/jetstack/subscriptions","organizations_url":"https://api.github.com/users/jetstack/orgs","repos_url":"https://api.github.com/users/jetstack/repos","events_url":"https://api.github.com/users/jetstack/events{/privacy}","received_events_url":"https://api.github.com/users/jetstack/received_events","type":"Organization","site_admin":false},"private":false,"html_url":"https://github.com/jetstack/cert-manager","description":"Automatically provision and manage TLS certificates in Kubernetes","fork":false,"url":"https://api.github.com/repos/jetstack/cert-manager","forks_url":"https://api.github.com/repos/jetstack/cert-manager/forks","keys_url":"https://api.github.com/repos/jetstack/cert-manager/keys{/key_id}","collaborators_url":"https://api.github.com/repos/jetstack/cert-manager/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/jetstack/cert-manager/teams","hooks_url":"https://api.github.com/repos/jetstack/cert-manager/hooks","issue_events_url":"https://api.github.com/repos/jetstack/cert-manager/issues/events{/number}","events_url":"https://api.github.com/repos/jetstack/cert-manager/events","assignees_url":"https://api.github.com/repos/jetstack/cert-manager/assignees{/user}","branches_url":"https://api.github.com/repos/jetstack/cert-manager/branches{/branch}","tags_url":"https://api.github.com/repos/jetstack/cert-manager/tags","blobs_url":"https://api.github.com/repos/jetstack/cert-manager/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/jetstack/cert-manager/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/jetstack/cert-manager/git/refs{/sha}","trees_url":"https://api.github.com/repos/jetstack/cert-manager/git/trees{/sha}","statuses_url":"https://api.github.com/repos/jetstack/cert-manager/statuses/{sha}","languages_url":"https://api.github.com/repos/jetstack/cert-manager/languages","stargazers_url":"https://api.github.com/repos/jetstack/cert-manager/stargazers","contributors_url":"https://api.github.com/repos/jetstack/cert-manager/contributors","subscribers_url":"https://api.github.com/repos/jetstack/cert-manager/subscribers","subscription_url":"https://api.github.com/repos/jetstack/cert-manager/subscription","commits_url":"https://api.github.com/repos/jetstack/cert-manager/commits{/sha}","git_commits_url":"https://api.github.com/repos/jetstack/cert-manager/git/commits{/sha}","comments_url":"https://api.github.com/repos/jetstack/cert-manager/comments{/number}","issue_comment_url":"https://api.github.com/repos/jetstack/cert-manager/issues/comments{/number}","contents_url":"https://api.github.com/repos/jetstack/cert-manager/contents/{+path}","compare_url":"https://api.github.com/repos/jetstack/cert-manager/compare/{base}...{head}","merges_url":"https://api.github.com/repos/jetstack/cert-manager/merges","archive_url":"https://api.github.com/repos/jetstack/cert-manager/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/jetstack/cert-manager/downloads","issues_url":"https://api.github.com/repos/jetstack/cert-manager/issues{/number}","pulls_url":"https://api.github.com/repos/jetstack/cert-manager/pulls{/number}","milestones_url":"https://api.github.com/repos/jetstack/cert-manager/milestones{/number}","notifications_url":"https://api.github.com/repos/jetstack/cert-manager/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/jetstack/cert-manager/labels{/name}","releases_url":"https://api.github.com/repos/jetstack/cert-manager/releases{/id}","deployments_url":"https://api.github.com/repos/jetstack/cert-manager/deployments","created_at":"2017-05-24T16:25:59Z","updated_at":"2018-03-16T10:43:02Z","pushed_at":"2018-03-16T11:23:14Z","git_url":"git://github.com/jetstack/cert-manager.git","ssh_url":"git@github.com:jetstack/cert-manager.git","clone_url":"https://github.com/jetstack/cert-manager.git","svn_url":"https://github.com/jetstack/cert-manager","homepage":"","size":51170,"stargazers_count":646,"watchers_count":646,"language":"Go","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":87,"mirror_url":null,"archived":false,"open_issues_count":106,"license":{"key":"apache-2.0","name":"Apache License 2.0","spdx_id":"Apache-2.0","url":"https://api.github.com/licenses/apache-2.0"},"forks":87,"open_issues":106,"watchers":646,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/397"},"html":{"href":"https://github.com/jetstack/cert-manager/pull/397"},"issue":{"href":"https://api.github.com/repos/jetstack/cert-manager/issues/397"},"comments":{"href":"https://api.github.com/repos/jetstack/cert-manager/issues/397/comments"},"review_comments":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/397/comments"},"review_comment":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/jetstack/cert-manager/pulls/397/commits"},"statuses":{"href":"https://api.github.com/repos/jetstack/cert-manager/statuses/9233e30ef5764c181bd39466fdc1d9201b2c5e10"}},"author_association":"CONTRIBUTOR"}}
{"actor":{"display_login":"euank"}}