{"action":"created","comment":{"url":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/comments/223178232","pull_request_review_id":162252220,"id":223178232,"node_id":"MDI0OlB1bGxSZXF1ZXN0UmV2aWV3Q29tbWVudDIyMzE3ODIzMg==","diff_hunk":"@@ -75,7 +75,9 @@ class BeelineSuggestRouteSpec extends FunSuite {\n   // Some assertions on our assumptions\n   require { getRequests.zipWithIndex.forall { case (o, i) => o.id == i} }\n   require { testDataSource.busStops.zipWithIndex.forall { case (o, i) => o.index == i} }\n-  test (\"BeelineSuggestRoute skips over suggestions without stops\") {\n+\n+  // This is ignored, because we now force every suggestion to have a stop","path":"routing/src/test/scala/sg/beeline/BeelineSuggestRouteSpec.scala","position":6,"original_position":6,"commit_id":"3aeecb3fa58d191ec2f14da60f1e4c221ef9b0ba","original_commit_id":"3aeecb3fa58d191ec2f14da60f1e4c221ef9b0ba","user":{"login":"LoneRifle","id":10572368,"node_id":"MDQ6VXNlcjEwNTcyMzY4","avatar_url":"https://avatars2.githubusercontent.com/u/10572368?v=4","gravatar_id":"","url":"https://api.github.com/users/LoneRifle","html_url":"https://github.com/LoneRifle","followers_url":"https://api.github.com/users/LoneRifle/followers","following_url":"https://api.github.com/users/LoneRifle/following{/other_user}","gists_url":"https://api.github.com/users/LoneRifle/gists{/gist_id}","starred_url":"https://api.github.com/users/LoneRifle/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/LoneRifle/subscriptions","organizations_url":"https://api.github.com/users/LoneRifle/orgs","repos_url":"https://api.github.com/users/LoneRifle/repos","events_url":"https://api.github.com/users/LoneRifle/events{/privacy}","received_events_url":"https://api.github.com/users/LoneRifle/received_events","type":"User","site_admin":false},"body":"Why not rework the test?","created_at":"2018-10-06T10:19:04Z","updated_at":"2018-10-06T10:19:05Z","html_url":"https://github.com/datagovsg/beeline-routing/pull/14#discussion_r223178232","pull_request_url":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/14","author_association":"CONTRIBUTOR","_links":{"self":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/comments/223178232"},"html":{"href":"https://github.com/datagovsg/beeline-routing/pull/14#discussion_r223178232"},"pull_request":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/14"}}},"pull_request":{"url":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/14","id":220604220,"node_id":"MDExOlB1bGxSZXF1ZXN0MjIwNjA0MjIw","html_url":"https://github.com/datagovsg/beeline-routing/pull/14","diff_url":"https://github.com/datagovsg/beeline-routing/pull/14.diff","patch_url":"https://github.com/datagovsg/beeline-routing/pull/14.patch","issue_url":"https://api.github.com/repos/datagovsg/beeline-routing/issues/14","number":14,"state":"open","locked":false,"title":"use nearest bus stop if none within radius","user":{"login":"xkjyeah","id":2659143,"node_id":"MDQ6VXNlcjI2NTkxNDM=","avatar_url":"https://avatars3.githubusercontent.com/u/2659143?v=4","gravatar_id":"","url":"https://api.github.com/users/xkjyeah","html_url":"https://github.com/xkjyeah","followers_url":"https://api.github.com/users/xkjyeah/followers","following_url":"https://api.github.com/users/xkjyeah/following{/other_user}","gists_url":"https://api.github.com/users/xkjyeah/gists{/gist_id}","starred_url":"https://api.github.com/users/xkjyeah/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/xkjyeah/subscriptions","organizations_url":"https://api.github.com/users/xkjyeah/orgs","repos_url":"https://api.github.com/users/xkjyeah/repos","events_url":"https://api.github.com/users/xkjyeah/events{/privacy}","received_events_url":"https://api.github.com/users/xkjyeah/received_events","type":"User","site_admin":false},"body":"SOme frequented places (e.g. Changi Naval Base) may be pinned very far away from their bus stop. For these locations, just pick the nearest bus stop.","created_at":"2018-10-05T07:03:25Z","updated_at":"2018-10-06T10:19:05Z","closed_at":null,"merged_at":null,"merge_commit_sha":"9a26cfff88536183574cd7b66c42471eb9015722","assignee":null,"assignees":[],"requested_reviewers":[],"requested_teams":[],"labels":[],"milestone":null,"commits_url":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/14/commits","review_comments_url":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/14/comments","review_comment_url":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/comments{/number}","comments_url":"https://api.github.com/repos/datagovsg/beeline-routing/issues/14/comments","statuses_url":"https://api.github.com/repos/datagovsg/beeline-routing/statuses/3aeecb3fa58d191ec2f14da60f1e4c221ef9b0ba","head":{"label":"datagovsg:nearest-bus-stop-if-none-nearby","ref":"nearest-bus-stop-if-none-nearby","sha":"3aeecb3fa58d191ec2f14da60f1e4c221ef9b0ba","user":{"login":"datagovsg","id":16471968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDcxOTY4","avatar_url":"https://avatars2.githubusercontent.com/u/16471968?v=4","gravatar_id":"","url":"https://api.github.com/users/datagovsg","html_url":"https://github.com/datagovsg","followers_url":"https://api.github.com/users/datagovsg/followers","following_url":"https://api.github.com/users/datagovsg/following{/other_user}","gists_url":"https://api.github.com/users/datagovsg/gists{/gist_id}","starred_url":"https://api.github.com/users/datagovsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datagovsg/subscriptions","organizations_url":"https://api.github.com/users/datagovsg/orgs","repos_url":"https://api.github.com/users/datagovsg/repos","events_url":"https://api.github.com/users/datagovsg/events{/privacy}","received_events_url":"https://api.github.com/users/datagovsg/received_events","type":"Organization","site_admin":false},"repo":{"id":105742092,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3NDIwOTI=","name":"beeline-routing","full_name":"datagovsg/beeline-routing","private":false,"owner":{"login":"datagovsg","id":16471968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDcxOTY4","avatar_url":"https://avatars2.githubusercontent.com/u/16471968?v=4","gravatar_id":"","url":"https://api.github.com/users/datagovsg","html_url":"https://github.com/datagovsg","followers_url":"https://api.github.com/users/datagovsg/followers","following_url":"https://api.github.com/users/datagovsg/following{/other_user}","gists_url":"https://api.github.com/users/datagovsg/gists{/gist_id}","starred_url":"https://api.github.com/users/datagovsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datagovsg/subscriptions","organizations_url":"https://api.github.com/users/datagovsg/orgs","repos_url":"https://api.github.com/users/datagovsg/repos","events_url":"https://api.github.com/users/datagovsg/events{/privacy}","received_events_url":"https://api.github.com/users/datagovsg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datagovsg/beeline-routing","description":"Provides routing services for Beeline","fork":false,"url":"https://api.github.com/repos/datagovsg/beeline-routing","forks_url":"https://api.github.com/repos/datagovsg/beeline-routing/forks","keys_url":"https://api.github.com/repos/datagovsg/beeline-routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datagovsg/beeline-routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datagovsg/beeline-routing/teams","hooks_url":"https://api.github.com/repos/datagovsg/beeline-routing/hooks","issue_events_url":"https://api.github.com/repos/datagovsg/beeline-routing/issues/events{/number}","events_url":"https://api.github.com/repos/datagovsg/beeline-routing/events","assignees_url":"https://api.github.com/repos/datagovsg/beeline-routing/assignees{/user}","branches_url":"https://api.github.com/repos/datagovsg/beeline-routing/branches{/branch}","tags_url":"https://api.github.com/repos/datagovsg/beeline-routing/tags","blobs_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datagovsg/beeline-routing/statuses/{sha}","languages_url":"https://api.github.com/repos/datagovsg/beeline-routing/languages","stargazers_url":"https://api.github.com/repos/datagovsg/beeline-routing/stargazers","contributors_url":"https://api.github.com/repos/datagovsg/beeline-routing/contributors","subscribers_url":"https://api.github.com/repos/datagovsg/beeline-routing/subscribers","subscription_url":"https://api.github.com/repos/datagovsg/beeline-routing/subscription","commits_url":"https://api.github.com/repos/datagovsg/beeline-routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/datagovsg/beeline-routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/datagovsg/beeline-routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/datagovsg/beeline-routing/contents/{+path}","compare_url":"https://api.github.com/repos/datagovsg/beeline-routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datagovsg/beeline-routing/merges","archive_url":"https://api.github.com/repos/datagovsg/beeline-routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datagovsg/beeline-routing/downloads","issues_url":"https://api.github.com/repos/datagovsg/beeline-routing/issues{/number}","pulls_url":"https://api.github.com/repos/datagovsg/beeline-routing/pulls{/number}","milestones_url":"https://api.github.com/repos/datagovsg/beeline-routing/milestones{/number}","notifications_url":"https://api.github.com/repos/datagovsg/beeline-routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datagovsg/beeline-routing/labels{/name}","releases_url":"https://api.github.com/repos/datagovsg/beeline-routing/releases{/id}","deployments_url":"https://api.github.com/repos/datagovsg/beeline-routing/deployments","created_at":"2017-10-04T07:29:00Z","updated_at":"2018-10-01T04:58:53Z","pushed_at":"2018-10-05T10:16:37Z","git_url":"git://github.com/datagovsg/beeline-routing.git","ssh_url":"git@github.com:datagovsg/beeline-routing.git","clone_url":"https://github.com/datagovsg/beeline-routing.git","svn_url":"https://github.com/datagovsg/beeline-routing","homepage":"","size":356026,"stargazers_count":23,"watchers_count":23,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":4,"watchers":23,"default_branch":"master"}},"base":{"label":"datagovsg:master","ref":"master","sha":"926f841905b3b9ef0f7c5f5fb7c6dd92626779a7","user":{"login":"datagovsg","id":16471968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDcxOTY4","avatar_url":"https://avatars2.githubusercontent.com/u/16471968?v=4","gravatar_id":"","url":"https://api.github.com/users/datagovsg","html_url":"https://github.com/datagovsg","followers_url":"https://api.github.com/users/datagovsg/followers","following_url":"https://api.github.com/users/datagovsg/following{/other_user}","gists_url":"https://api.github.com/users/datagovsg/gists{/gist_id}","starred_url":"https://api.github.com/users/datagovsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datagovsg/subscriptions","organizations_url":"https://api.github.com/users/datagovsg/orgs","repos_url":"https://api.github.com/users/datagovsg/repos","events_url":"https://api.github.com/users/datagovsg/events{/privacy}","received_events_url":"https://api.github.com/users/datagovsg/received_events","type":"Organization","site_admin":false},"repo":{"id":105742092,"node_id":"MDEwOlJlcG9zaXRvcnkxMDU3NDIwOTI=","name":"beeline-routing","full_name":"datagovsg/beeline-routing","private":false,"owner":{"login":"datagovsg","id":16471968,"node_id":"MDEyOk9yZ2FuaXphdGlvbjE2NDcxOTY4","avatar_url":"https://avatars2.githubusercontent.com/u/16471968?v=4","gravatar_id":"","url":"https://api.github.com/users/datagovsg","html_url":"https://github.com/datagovsg","followers_url":"https://api.github.com/users/datagovsg/followers","following_url":"https://api.github.com/users/datagovsg/following{/other_user}","gists_url":"https://api.github.com/users/datagovsg/gists{/gist_id}","starred_url":"https://api.github.com/users/datagovsg/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/datagovsg/subscriptions","organizations_url":"https://api.github.com/users/datagovsg/orgs","repos_url":"https://api.github.com/users/datagovsg/repos","events_url":"https://api.github.com/users/datagovsg/events{/privacy}","received_events_url":"https://api.github.com/users/datagovsg/received_events","type":"Organization","site_admin":false},"html_url":"https://github.com/datagovsg/beeline-routing","description":"Provides routing services for Beeline","fork":false,"url":"https://api.github.com/repos/datagovsg/beeline-routing","forks_url":"https://api.github.com/repos/datagovsg/beeline-routing/forks","keys_url":"https://api.github.com/repos/datagovsg/beeline-routing/keys{/key_id}","collaborators_url":"https://api.github.com/repos/datagovsg/beeline-routing/collaborators{/collaborator}","teams_url":"https://api.github.com/repos/datagovsg/beeline-routing/teams","hooks_url":"https://api.github.com/repos/datagovsg/beeline-routing/hooks","issue_events_url":"https://api.github.com/repos/datagovsg/beeline-routing/issues/events{/number}","events_url":"https://api.github.com/repos/datagovsg/beeline-routing/events","assignees_url":"https://api.github.com/repos/datagovsg/beeline-routing/assignees{/user}","branches_url":"https://api.github.com/repos/datagovsg/beeline-routing/branches{/branch}","tags_url":"https://api.github.com/repos/datagovsg/beeline-routing/tags","blobs_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/blobs{/sha}","git_tags_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/tags{/sha}","git_refs_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/refs{/sha}","trees_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/trees{/sha}","statuses_url":"https://api.github.com/repos/datagovsg/beeline-routing/statuses/{sha}","languages_url":"https://api.github.com/repos/datagovsg/beeline-routing/languages","stargazers_url":"https://api.github.com/repos/datagovsg/beeline-routing/stargazers","contributors_url":"https://api.github.com/repos/datagovsg/beeline-routing/contributors","subscribers_url":"https://api.github.com/repos/datagovsg/beeline-routing/subscribers","subscription_url":"https://api.github.com/repos/datagovsg/beeline-routing/subscription","commits_url":"https://api.github.com/repos/datagovsg/beeline-routing/commits{/sha}","git_commits_url":"https://api.github.com/repos/datagovsg/beeline-routing/git/commits{/sha}","comments_url":"https://api.github.com/repos/datagovsg/beeline-routing/comments{/number}","issue_comment_url":"https://api.github.com/repos/datagovsg/beeline-routing/issues/comments{/number}","contents_url":"https://api.github.com/repos/datagovsg/beeline-routing/contents/{+path}","compare_url":"https://api.github.com/repos/datagovsg/beeline-routing/compare/{base}...{head}","merges_url":"https://api.github.com/repos/datagovsg/beeline-routing/merges","archive_url":"https://api.github.com/repos/datagovsg/beeline-routing/{archive_format}{/ref}","downloads_url":"https://api.github.com/repos/datagovsg/beeline-routing/downloads","issues_url":"https://api.github.com/repos/datagovsg/beeline-routing/issues{/number}","pulls_url":"https://api.github.com/repos/datagovsg/beeline-routing/pulls{/number}","milestones_url":"https://api.github.com/repos/datagovsg/beeline-routing/milestones{/number}","notifications_url":"https://api.github.com/repos/datagovsg/beeline-routing/notifications{?since,all,participating}","labels_url":"https://api.github.com/repos/datagovsg/beeline-routing/labels{/name}","releases_url":"https://api.github.com/repos/datagovsg/beeline-routing/releases{/id}","deployments_url":"https://api.github.com/repos/datagovsg/beeline-routing/deployments","created_at":"2017-10-04T07:29:00Z","updated_at":"2018-10-01T04:58:53Z","pushed_at":"2018-10-05T10:16:37Z","git_url":"git://github.com/datagovsg/beeline-routing.git","ssh_url":"git@github.com:datagovsg/beeline-routing.git","clone_url":"https://github.com/datagovsg/beeline-routing.git","svn_url":"https://github.com/datagovsg/beeline-routing","homepage":"","size":356026,"stargazers_count":23,"watchers_count":23,"language":"Jupyter Notebook","has_issues":true,"has_projects":true,"has_downloads":true,"has_wiki":true,"has_pages":false,"forks_count":7,"mirror_url":null,"archived":false,"open_issues_count":4,"license":{"key":"mit","name":"MIT License","spdx_id":"MIT","url":"https://api.github.com/licenses/mit","node_id":"MDc6TGljZW5zZTEz"},"forks":7,"open_issues":4,"watchers":23,"default_branch":"master"}},"_links":{"self":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/14"},"html":{"href":"https://github.com/datagovsg/beeline-routing/pull/14"},"issue":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/issues/14"},"comments":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/issues/14/comments"},"review_comments":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/14/comments"},"review_comment":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/comments{/number}"},"commits":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/pulls/14/commits"},"statuses":{"href":"https://api.github.com/repos/datagovsg/beeline-routing/statuses/3aeecb3fa58d191ec2f14da60f1e4c221ef9b0ba"}},"author_association":"COLLABORATOR"}}
{"actor":{"display_login":"LoneRifle"}}