{"action":"created","issue":{"url":"https://api.github.com/repos/brigade-automation/brigade/issues/126","repository_url":"https://api.github.com/repos/brigade-automation/brigade","labels_url":"https://api.github.com/repos/brigade-automation/brigade/issues/126/labels{/name}","comments_url":"https://api.github.com/repos/brigade-automation/brigade/issues/126/comments","events_url":"https://api.github.com/repos/brigade-automation/brigade/issues/126/events","html_url":"https://github.com/brigade-automation/brigade/pull/126","id":318179457,"number":126,"title":"Add test for print_result function","user":{"login":"ogenstad","id":6694669,"avatar_url":"https://avatars0.githubusercontent.com/u/6694669?v=4","gravatar_id":"","url":"https://api.github.com/users/ogenstad","html_url":"https://github.com/ogenstad","followers_url":"https://api.github.com/users/ogenstad/followers","following_url":"https://api.github.com/users/ogenstad/following{/other_user}","gists_url":"https://api.github.com/users/ogenstad/gists{/gist_id}","starred_url":"https://api.github.com/users/ogenstad/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/ogenstad/subscriptions","organizations_url":"https://api.github.com/users/ogenstad/orgs","repos_url":"https://api.github.com/users/ogenstad/repos","events_url":"https://api.github.com/users/ogenstad/events{/privacy}","received_events_url":"https://api.github.com/users/ogenstad/received_events","type":"User","site_admin":false},"labels":[],"state":"open","locked":false,"assignee":null,"assignees":[],"milestone":null,"comments":0,"created_at":"2018-04-26T20:10:17Z","updated_at":"2018-04-27T09:40:32Z","closed_at":null,"author_association":"COLLABORATOR","pull_request":{"url":"https://api.github.com/repos/brigade-automation/brigade/pulls/126","html_url":"https://github.com/brigade-automation/brigade/pull/126","diff_url":"https://github.com/brigade-automation/brigade/pull/126.diff","patch_url":"https://github.com/brigade-automation/brigade/pull/126.patch"},"body":"Adding a test to print_result as discussed in https://github.com/brigade-automation/brg-tools/pull/1\r\n\r\nCopied the wrapper from the same PR, but modified it slightly for Python 2 and also added an exception to make it easier to see why a task was failing as the `assert` seemed to be running outside of the test environment and only gave a true/false statement, it wasn't possible to see how the results differed.\r\n\r\nI took a shortcut by only returning a bare string from a fake task. Other return values gets converted to unicode in Python 2 so the asserts fail. Could revisit that later."},"comment":{"url":"https://api.github.com/repos/brigade-automation/brigade/issues/comments/384920484","html_url":"https://github.com/brigade-automation/brigade/pull/126#issuecomment-384920484","issue_url":"https://api.github.com/repos/brigade-automation/brigade/issues/126","id":384920484,"user":{"login":"coveralls","id":2354108,"avatar_url":"https://avatars1.githubusercontent.com/u/2354108?v=4","gravatar_id":"","url":"https://api.github.com/users/coveralls","html_url":"https://github.com/coveralls","followers_url":"https://api.github.com/users/coveralls/followers","following_url":"https://api.github.com/users/coveralls/following{/other_user}","gists_url":"https://api.github.com/users/coveralls/gists{/gist_id}","starred_url":"https://api.github.com/users/coveralls/starred{/owner}{/repo}","subscriptions_url":"https://api.github.com/users/coveralls/subscriptions","organizations_url":"https://api.github.com/users/coveralls/orgs","repos_url":"https://api.github.com/users/coveralls/repos","events_url":"https://api.github.com/users/coveralls/events{/privacy}","received_events_url":"https://api.github.com/users/coveralls/received_events","type":"User","site_admin":false},"created_at":"2018-04-27T09:40:32Z","updated_at":"2018-04-27T09:40:32Z","author_association":"NONE","body":"## Pull Request Test Coverage Report for [Build 574](https://coveralls.io/builds/16725838)\n\n* **0** of **0**  **(NaN%)** changed or added relevant lines in **0** files are covered.\n* **8** unchanged lines in **1** file lost coverage.\n* Overall coverage increased (+**4.09%**) to **91.468%**\n\n---\n\n\n|  Files with Coverage Reduction | New Missed Lines | % |\n| :-----|--------------|--: |\n| [brigade/core/__init__.py](https://coveralls.io/builds/16725838/source?filename=brigade%2Fcore%2F__init__.py#L12) | 8 | 85.32% |\n<!-- | **Total:** | **8** |  | -->\n\n|  Totals | [![Coverage Status](https://coveralls.io/builds/16725838/badge)](https://coveralls.io/builds/16725838) |\n| :-- | --: |\n| Change from base [Build 560](https://coveralls.io/builds/16631756): |  4.09% |\n| Covered Lines: | 922 |\n| Relevant Lines: | 1008 |\n\n---\n##### 💛  - [Coveralls](https://coveralls.io)\n"}}
{"actor":{"display_login":"coveralls"}}